* Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-18  Darin Adler  <darin@apple.com>
2
3         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
4
5 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
6
7         Add script to run Drosera as part of the nightly.
8         
9         Reviewed by Kevin M.
10
11         * Scripts/run-drosera.cmd: Added.
12
13 2007-12-18  Darin Adler  <darin@apple.com>
14
15         * Scripts/do-webcore-rename: Remove a stray K.
16
17 2007-12-18  Darin Adler  <darin@apple.com>
18
19         * Scripts/do-webcore-rename: Plan more renaming.
20
21 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
22
23         Reviewed by Alp Toker.
24
25         http://bugs.webkit.org/show_bug.cgi?id=16042
26         [GTK] Eliminate webkit_init()
27
28         Moving webkit initialization to WebView class init.
29
30         * DumpRenderTree/gtk/DumpRenderTree.cpp:
31         (main):
32         * GtkLauncher/main.c:
33         (main):
34
35 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
36
37         Reviewed by Alp Toker.
38
39         http://bugs.webkit.org/show_bug.cgi?id=13542
40         gdklauncher doesnt change URL in adress GTKEntry.
41
42         * GtkLauncher/main.c:
43         (load_commit_cb): added
44         (title_change_cb):
45         (create_browser):
46
47 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
48
49         Reviewed by Adam Roben.
50
51         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
52
53         * FindSafari/FindSafari.cpp:
54         (_tmain):
55
56 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
57
58         Reviewed by Adam Roben.
59
60         http://bugs.webkit.org/show_bug.cgi?id=16315
61         FindSafari needs a path-only option.
62
63         * FindSafari/FindSafari.cpp:
64         (_tmain):
65
66 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
67
68         Reviewed by Darin.
69
70         http://bugs.webkit.org/show_bug.cgi?id=16462
71         REGRESSION: access keys broken on Windows
72
73         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
74         if Alt is pressed.
75
76 2007-12-15  Sam Weinig  <sam@webkit.org>
77
78         Reviewed by Mark Rowe.
79
80         Fix urlSuitableForTestResult to correctly identify wstring::npos as
81         the case when wstring.find doesn't find anything.
82
83         * DumpRenderTree/win/DumpRenderTree.cpp:
84         (urlSuitableForTestResult):
85
86 2007-12-15  Alp Toker  <alp@atoker.com>
87
88         GTK+ DRT build fix for GLib < 2.14.
89
90         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
91         (LayoutTestController::setWaitToDump):
92
93 2007-12-05  Mark Rowe  <mrowe@apple.com>
94
95         Reviewed by Alp Toker.
96
97         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
98         many layout tests from hanging while waiting on user responses to dialogs.
99
100         * DumpRenderTree/gtk/DumpRenderTree.cpp:
101         (invalidateAnyPreviousWaitToDumpWatchdog):
102         (webViewScriptAlert):
103         (webViewScriptPrompt):
104         (webViewScriptConfirm):
105         (main):
106         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
107         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
108         (waitToDumpWatchdogFired):
109         (LayoutTestController::setWaitToDump):
110
111 2007-12-05  Mark Rowe  <mrowe@apple.com>
112
113         Reviewed by Alp Toker.
114
115         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
116
117         * DumpRenderTree/gtk/DumpRenderTree.cpp:
118         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
119         (dump):
120         (runTest):
121         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
122         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
123         work queue is empty.
124         (webViewWindowObjectCleared): Set up window.layoutTestController.
125         (webViewConsoleMessage): Match the console message format expected by the layout test results.
126         (main): Hook up the new signals.
127         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
128         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
129         dumping multiple times.
130         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
131         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
132
133 2007-12-14  Anders Carlsson  <andersca@apple.com>
134
135         Reviewed by Brady.
136
137         Assert that a web frame that's loading a resource always has either a data source or 
138         a provisional data source.
139         
140         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
141         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
142
143 2007-12-14  Darin Adler  <darin@apple.com>
144
145         - fix mistake causing nearly all tests to fail on Windows
146
147         * DumpRenderTree/win/UIDelegate.cpp:
148         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
149         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
150
151         * DumpRenderTree/mac/UIDelegate.mm:
152         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
153         than passing the entire message.
154
155 2007-12-14  Darin Adler  <darin@apple.com>
156
157         - fix Tiger build
158
159         * DumpRenderTree/mac/UIDelegate.mm:
160         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
161         new-to-Leopard methods.
162
163 2007-12-14  Darin Adler  <darin@apple.com>
164
165         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
166         since it now triggers unwanted icon loading. We only had it because we implemented "all"
167         delegate methods here.
168
169 2007-12-14  Anders Carlsson  <andersca@apple.com>
170
171         Reviewed by Darin and Geoff.
172
173         <rdar://problem/5619295> 
174         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
175         
176         Add property getting methods to the plug-in.
177         
178         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
179         (pluginInvoke):
180
181 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
182
183         Reviewed by Darin.
184
185         - Layout test fix for mac. When dumped to the console local file paths
186         now only show the name of the resource not the whole path.  This is to
187         make the results machine and OS independent.
188
189         * DumpRenderTree/mac/UIDelegate.mm:
190         (-[UIDelegate webView:addMessageToConsole:]):
191
192 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
193
194         Reviewed by Adam.
195
196         - Layout tests fix.  We need a way to remove machine-dependent
197         information from paths in layout test results. The UIDelegate now does
198         this.
199
200         * DumpRenderTree/DumpRenderTree.h:
201         * DumpRenderTree/win/DumpRenderTree.cpp:
202         (urlSuitableForTestResult):
203         * DumpRenderTree/win/DumpRenderTreeWin.h:
204         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
205         * DumpRenderTree/win/UIDelegate.cpp:
206         (UIDelegate::webViewAddMessageToConsole):
207
208 2007-12-13  Alp Toker  <alp@atoker.com>
209
210         Build fix for DRT breakage introduced in r28690.
211
212         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
213         (LayoutTestController::pathToLocalResource):
214
215 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
216
217         Reviewed by Alice and Sam.
218
219         - <rdar://5621435> Need a way to specify local resources (being loaded
220         from HTTP tests) on Windows.
221         - Implemented pathToLocalResource which exposes the functionality of
222         converting a given unix path to the correct location on Windows.
223
224         * DumpRenderTree/LayoutTestController.cpp:
225         (pathToLocalResourceCallback):
226         (LayoutTestController::staticFunctions):
227         * DumpRenderTree/LayoutTestController.h:
228         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
229         (LayoutTestController::pathToLocalResource):
230         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
231         (LayoutTestController::pathToLocalResource):
232
233 2007-12-12  Anders Carlsson  <andersca@apple.com>
234
235         Reviewed by Sam.
236
237         <rdar://problem/5132003>
238         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
239
240         * DumpRenderTree/win/DumpRenderTree.cpp:
241         (main):
242         Set the resource load delegate.
243         
244         * DumpRenderTree/win/DumpRenderTree.vcproj:
245         
246         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
247         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
248
249 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
250
251         Reviewed by Adam Roben.
252
253         Fix conversion from double to LPARAM in dispatchMessage().
254
255         * DumpRenderTree/win/EventSender.cpp:
256         (dispatchMessageCallback):
257
258 2007-12-11  Dan Bernstein  <mitz@apple.com>
259
260         Reviewed by Mark Rowe and Sam Weinig too!
261
262         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
263           fonts DumpRenderTree registers.
264
265         * DumpRenderTree/win/DumpRenderTree.cpp:
266         (initialize):
267
268 2007-12-11  Brady Eidson  <beidson@apple.com>
269
270         Reviewed by Anders
271
272         Make DumpRenderTree on mac use its own path for Databases testing
273
274         * DumpRenderTree/mac/DumpRenderTree.mm:
275         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
276           for future DRT-only use, then use it to construct the Databases path and set that default
277
278 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
279
280         Reviewed by Darin.
281
282         <rdar://problem/5535636>
283         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
284
285         http://bugs.webkit.org/show_bug.cgi?id=13916
286         JavaScript detects Tab as a character input on a textfield validation
287
288         * DumpRenderTree/mac/EventSendingController.mm:
289         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
290         Dispatch a keyup to better match what happens when a key is physically pressed.
291
292         * DumpRenderTree/win/EventSender.cpp:
293         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
294         returning from keyDown().
295         (getConstantCallback): Fixed a couple copy/paste mistakes.
296
297 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
298
299         Reviewed by Oliver.
300
301         - <rdar://5599845> Drosera: Does not show loal files in the file list
302         on the left side.
303
304         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
305         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
306         so the open source community can build.
307
308 2007-12-10  Brady Eidson  <beidson@apple.com>
309
310         Rubberstamped by Sam Weinig
311
312         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
313
314         * DumpRenderTree/mac/UIDelegate.mm:
315         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
316         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
317
318 2007-12-08  Oliver Hunt  <oliver@apple.com>
319
320         Reviewed by Sam W.
321
322         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
323         
324         Fixes <rdar://problem/5620249> Must disable SVG animation
325         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
326         
327         In order to allow finer grained control over the set of SVG features
328         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
329         distinct flags:
330         ENABLE_SVG_ANIMATION
331         ENABLE_SVG_FILTERS
332         ENABLE_SVG_FONTS
333         ENABLE_SVG_AS_IMAGE
334         ENABLE_SVG_USE
335         
336         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
337         
338         Script handles all the new build flags, and allows --svg-experimental
339         to automatically enable all features.
340
341         * Scripts/build-webkit:
342
343 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
344
345         Fix version parsing.
346
347         Rubber-stamped by Oliver.
348
349         * Drosera/win/Drosera.vcproj/auto-version.sh:
350
351 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
352
353         Build modifications for Drosera.
354
355         Reviewed by Adam.
356
357         * Drosera/DroseraWin.make: Added.
358         * Drosera/win/Drosera.vcproj/Drosera.rc:
359         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
360         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
361         * Drosera/win/Drosera.vcproj/VERSION: Added.
362         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
363
364 2007-12-06  Adam Roben  <aroben@apple.com>
365
366         Explicitly turn on the Mac font ascent hack on Windows
367
368         This keeps our font metrics matching those from Mac.
369
370         Reviewed by Hyatt.
371
372         * DumpRenderTree/win/DumpRenderTree.cpp:
373         (main):
374
375 2007-12-06  Anders Carlsson  <andersca@apple.com>
376
377         Rename main.c to main.cpp here too.
378         
379         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
380
381 2007-12-06  Sam Weinig  <sam@webkit.org>
382
383         Rubber stamped by Geoff.
384
385         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
386
387 2007-12-06  Darin Adler  <darin@apple.com>
388
389         * Scripts/do-webcore-rename: Some more renaming plans.
390
391 2007-12-06  Anders Carlsson  <andersca@apple.com>
392
393         Restore implementation of testGetIntIdentifier that was accidentally
394         removed somehow (possibly when I made PluginObject be a cpp file).
395         
396         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
397         (pluginInvoke):
398
399 2007-12-05  Anders Carlsson  <andersca@apple.com>
400
401         Make the entry points extern "C".
402         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
403         
404 2007-12-05  Anders Carlsson  <andersca@apple.com>
405
406         C++ warning fixes.
407         
408         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
409         (NPP_New):
410         (NPP_Destroy):
411         (NPP_SetWindow):
412         (NPP_NewStream):
413         (NPP_HandleEvent):
414         (NPP_URLNotify):
415         (NPP_GetValue):
416
417 2007-12-05  Anders Carlsson  <andersca@apple.com>
418
419         Add the .cpp files to the TestNetscapePlugIn target.
420
421         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
422
423 2007-12-05  Anders Carlsson  <andersca@apple.com>
424
425         Reviewed by Geoff.
426         
427         Rename the TestNetscapePlugIn .c files to be .cpp.
428
429         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
430         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
431         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
432         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
433         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
434         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
435         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
436         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
437
438 2007-12-05  Adam Roben  <aroben@apple.com>
439
440         Fix case of keypresses from the Windows implementation of eventSender.keyDown
441
442         This fixes several regression tests.
443
444         Reviewed by Alice.
445
446         * DumpRenderTree/win/EventSender.cpp:
447         (keyDownCallback): Virtual keycodes for ASCII characters are always
448         uppercase, so we need to check the case of the original character
449         passed in to eventSender.keyDown.
450
451 2007-12-05  Adam Roben  <aroben@apple.com>
452
453         Learn from Tim's mistakes
454
455         * DumpRenderTree/win/DumpRenderTree.cpp:
456         (runTest): Reset the authorAndUserStylesEnabled preference for each
457         test.
458
459 2007-12-05  Alp Toker  <alp@atoker.com>
460
461         Reviewed by Mark Rowe.
462
463         Initialize GTK+ and WebKit so the tests can run.
464
465         Reorganize the headers a little.
466
467         * DumpRenderTree/gtk/DumpRenderTree.cpp:
468         (main):
469
470 2007-12-04  Anders Carlsson  <andersca@apple.com>
471
472         Remove IWebScriptScope include.
473         
474         * Drosera/win/DebuggerDocumentPlatform.cpp:
475
476 2007-12-04  Sam Weinig  <sam@webkit.org>
477
478         Rubber stamped by Mark Rowe.
479
480         Define CF as platform for mac and revert r28409
481
482         * DumpRenderTree/DumpRenderTree.h:
483         * DumpRenderTree/mac/DumpRenderTreeMac.h:
484
485 2007-12-04  Sam Weinig  <sam@webkit.org>
486
487         Define CF as platform for windows.
488
489         Reviewed by Adam Roben.
490
491         * DumpRenderTree/win/DumpRenderTreeWin.h:
492
493 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
494
495         Reviewed by Adam and Darin.
496
497         - Removed a needless BSTR cleanup.
498
499         * Drosera/win/DebuggerDocumentPlatform.cpp:
500         (DebuggerDocument::getPlatformCurrentFunctionStack):
501
502 2007-11-27  Adam Roben  <aroben@apple.com>
503
504         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
505
506         Reviewed by Maciej.
507
508         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
509         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
510
511 2007-12-04  Alp Toker  <alp@atoker.com>
512
513         Prospective Win DRT build fix.
514
515         * DumpRenderTree/DumpRenderTree.h:
516
517 2007-12-04  Alp Toker  <alp@atoker.com>
518
519         Fix a clobbered copyright header.
520
521         * DumpRenderTree/gtk/DumpRenderTree.cpp:
522
523 2007-12-04  Xan Lopez  <xan@gnome.org>
524
525         Reviewed by Alp Toker.
526
527         http://bugs.webkit.org/show_bug.cgi?id=15561
528         GTK port needs DumpRenderTree implementation
529
530         Start work on the GTK+ DRT.
531
532         This does not work yet, and there are a few lingering style issues
533         (nothing major) but this patch has been stuck in the bug tracker for
534         too long already.
535
536         * DumpRenderTree/DumpRenderTree.h:
537         * DumpRenderTree/gtk: Added.
538         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
539         (autocorrectURL):
540         (shouldLogFrameLoadDelegates):
541         (dumpFrameScrollPosition):
542         (displayWebView):
543         (appendString):
544         (dumpFramesAsText):
545         (dumpRenderTreeAsText):
546         (dump):
547         (runTest):
548         (main):
549         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
550         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
551         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
552         (GCController::collect):
553         (GCController::collectOnAlternateThread):
554         (GCController::getJSObjectCount):
555         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
556         (LayoutTestController::~LayoutTestController):
557         (LayoutTestController::addDisallowedURL):
558         (LayoutTestController::clearBackForwardList):
559         (LayoutTestController::copyDecodedHostName):
560         (LayoutTestController::copyEncodedHostName):
561         (LayoutTestController::display):
562         (LayoutTestController::keepWebHistory):
563         (LayoutTestController::notifyDone):
564         (LayoutTestController::queueBackNavigation):
565         (LayoutTestController::queueForwardNavigation):
566         (LayoutTestController::queueLoad):
567         (LayoutTestController::queueReload):
568         (LayoutTestController::queueScript):
569         (LayoutTestController::setAcceptsEditing):
570         (LayoutTestController::setCustomPolicyDelegate):
571         (LayoutTestController::setMainFrameIsFirstResponder):
572         (LayoutTestController::setTabKeyCyclesThroughElements):
573         (LayoutTestController::setUseDashboardCompatibilityMode):
574         (LayoutTestController::setUserStyleSheetEnabled):
575         (LayoutTestController::setUserStyleSheetLocation):
576         (LayoutTestController::setWindowIsKey):
577         (LayoutTestController::setWaitToDump):
578         (LayoutTestController::windowCount):
579         (LayoutTestController::setPrivateBrowsingEnabled):
580         (LayoutTestController::setAuthorAndUserStylesEnabled):
581         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
582         (JSStringCopyUTF8CString):
583         (LoadItem::invoke):
584         (ReloadItem::invoke):
585         (ScriptItem::invoke):
586         (BackForwardItem::invoke):
587
588 2007-12-03  Sam Weinig  <sam@webkit.org>
589
590         Move JavaScriptCore thread testing code to pthread specific directory
591         and remove the dependance on CoreFoundation by using WTF::HashSet.
592
593         Reviewed by Geoff and Oliver.
594
595         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
596         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
597         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
598         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
599         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
600         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
601         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
602         * DumpRenderTree/pthreads: Added.
603         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
604         (javaScriptThreads):
605         (runJavaScriptThread):
606         (startJavaScriptThreads):
607         (stopJavaScriptThreads):
608
609 2007-12-03  Andrew Bonventre  <andybons@google.com>
610
611         Reviewed by Darin Adler.
612
613         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
614         Symbol lookup menu broken in debugger view
615
616         * Drosera/debugger.js: Fixed javascript error where document property
617         should have been used instead of contentDocument in switchFunction that
618         was breaking the select symbol dropdown menu.  This is because
619         window.frames will return a Window object and not a frame object like
620         the author was originally expecting.
621
622 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
623
624         Reviewed by Adam.
625
626         - <rdar://5618942> Drosera: Console window does not process everything
627         correctly.
628         - <rdar://5619005> Drosera: could be sped up by moving the 
629         WebScriptScope stuff into the WebScriptCallFrame.
630         - Now the console can correctly process objects and does not receive
631         notifications from JavaScriptCore about the JavaScript in Drosera's
632         own process.
633
634         * Drosera/win/DebuggerDocumentPlatform.cpp:
635         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
636         (DebuggerDocument::platformValueForScopeVariableNamed):
637
638 2007-12-03  Stephanie  <slewis@apple.com>
639
640         Reviewed by Darin.
641
642         Check to see if we are building a debug root
643
644         * Scripts/check-for-global-initializers: 
645
646 2007-12-03  Dan Bernstein  <mitz@apple.com>
647
648         Reviewed by Darin Adler.
649
650         - added a testGetIntIdentifier() method to TestNetscapePlugIn
651
652         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
653         (pluginInvoke):
654
655 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
656
657         Reviewed by Oliver.
658
659         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
660         in a more fine-grained manner than eventSender.keyDown().
661
662         * DumpRenderTree/win/EventSender.cpp:
663         (getConstantCallback):
664         (dispatchMessageCallback):
665
666 2007-12-02  Darin Adler  <darin@apple.com>
667
668         * Scripts/do-webcore-rename: More planned renaming.
669
670 2007-12-02  Sam Weinig  <sam@webkit.org>
671
672         Rubber stamped by Anders.
673
674         Use [NSURL absoluteString] instead of [NSURL description] in order to get
675         more uniform results cross platform.
676
677         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
678         (-[NSURL _drt_descriptionSuitableForTestResult]):
679
680 2007-12-02  Sam Weinig  <sam@webkit.org>
681
682         Rubber stamped by Niko.
683
684         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
685
686         * DumpRenderTree/win/DumpRenderTree.cpp:
687         * DumpRenderTree/win/DumpRenderTree.vcproj:
688         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
689         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
690         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
691         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
692
693 2007-12-01  Alp Toker  <alp@atoker.com>
694
695         Reviewed by Adam Roben.
696
697         Make use of the newly introduced webkit.h convenience header.
698
699         * GtkLauncher/main.c:
700
701 2007-12-01  Adam Treat  <treat@kde.org>
702
703         Reviewed by Simon.
704
705         * Check to see if the directory exists and exit if not.
706
707         * DumpRenderTree/qt/main.cpp:
708         (main):
709
710 2007-12-01  Adam Treat  <treat@kde.org>
711
712         Reviewed by Simon.
713
714         * Don't hide symbols when in Debug mode
715         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
716
717
718         * DumpRenderTree/qt/main.cpp:
719         (messageHandler):
720
721 2007-11-30  Alp Toker  <alp@atoker.com>
722
723         Reviewed by Adam Roben.
724
725         http://bugs.webkit.org/show_bug.cgi?id=15691
726         [GTK] Public API does not follow GTK+ conventions
727
728         Refactor the WebKit/GTK+ public API. Changes:
729           WebKitPage -> WebKitWebView
730           WebKitFrame -> WebKitWebFrame
731
732         Public API source and header names have been updated to mirror the API
733         changes.
734
735         The API is now kept in WebKit/gtk/WebView to match other ports in the
736         same class such as Mac and Win.
737
738         * GtkLauncher/main.c:
739         (activate_uri_entry_cb):
740         (link_hover_cb):
741         (title_change_cb):
742         (progress_change_cb):
743         (go_back_cb):
744         (go_forward_cb):
745         (create_browser):
746         (main):
747
748 2007-11-30  Adam Roben  <aroben@apple.com>
749
750         Hopefully the final build fix
751
752         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
753         pull in WTF's assertion/logging functions.
754
755 2007-11-30  Adam Roben  <aroben@apple.com>
756
757         Another build fix
758
759         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
760         WebKit.lib.
761
762 2007-11-30  Adam Roben  <aroben@apple.com>
763
764         Debug build fix
765
766         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
767         configuration.
768         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
769         projects.
770         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
771         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
772         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
773
774 2007-11-30  Sam Weinig  <sam@webkit.org>
775
776         Reviewed by Adam Roben.
777
778         Fix drawSelectionRect to actually draw the selection rect.
779
780         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
781         (drawSelectionRect):
782
783 2007-11-30  Darin Adler  <darin@apple.com>
784
785         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
786
787 2007-11-30  Darin Adler  <darin@apple.com>
788
789         * Scripts/do-webcore-rename: Get ready for some future renaming.
790
791 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
792
793         Reviewed by Adam.
794
795         - Removed some unnecessary functions and changed an unused return type. 
796
797         * Drosera/win/DebuggerClient.cpp:
798         (registerConsoleClass):
799         * Drosera/win/DebuggerClient.h:
800         * Drosera/win/Drosera.cpp:
801         (registerDroseraClass):
802
803 2007-11-28  Alp Toker  <alp@atoker.com>
804
805         Reviewed by Timothy Hatcher.
806
807         http://bugs.webkit.org/show_bug.cgi?id=16174
808         [GTK] Use "URI" not "URL" in public API
809
810         Replace use of the term "URL" with "URI" in public headers,
811         documentation and some internal code to match GLib/GTK+ convention.
812
813         This is now mentioned in the API guidelines:
814           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
815
816         * GtkLauncher/main.c:
817         (activate_uri_entry_cb):
818         (title_change_cb):
819         (create_toolbar):
820         (main):
821
822 2007-11-29  Anders Carlsson  <andersca@apple.com>
823
824         Reviewed by Sam.
825
826         <rdar://problem/5230478>
827         FrameLoadDelegate callbacks are not dumped in DRT.
828         
829         * DumpRenderTree/win/DumpRenderTree.cpp:
830         (shouldLogFrameLoadDelegates):
831         (runTest):
832         (main):
833         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
834         (BSTRtoString):
835         (descriptionSuitableForTestResult):
836         (FrameLoadDelegate::QueryInterface):
837         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
838         (FrameLoadDelegate::didFailProvisionalLoadWithError):
839         (FrameLoadDelegate::didCommitLoadForFrame):
840         (FrameLoadDelegate::didFinishLoadForFrame):
841         (FrameLoadDelegate::willCloseFrame):
842         (FrameLoadDelegate::didClearWindowObject):
843         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
844         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
845         * DumpRenderTree/win/FrameLoaderDelegate.h:
846         (FrameLoadDelegate::windowScriptObjectAvailable):
847         (FrameLoadDelegate::didFirstLayoutInFrame):
848
849 2007-11-29  Sam Weinig  <sam@webkit.org>
850
851         Reviewed by Anders.
852
853         Add database quota UIDelegates methods to DRT UIDelegate.
854
855         * DumpRenderTree/mac/UIDelegate.mm:
856         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
857         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
858
859 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
860
861         Reviewed by Sam.
862
863         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
864         dying and vice versa.
865         - This fix will allow Drosera and Safari to reconnect if either of them
866         closes correctly, but does not fix the case where one of them dies
867         silently.
868
869         * Drosera/win/ServerConnection.cpp:
870         (ServerConnection::attemptToCreateServerConnection): Added a safety
871         check, because it's possilbe to try to connect to a server that's dying.
872         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
873         the server has died.
874         * Drosera/win/ServerConnection.h: Added the new function and removed
875         an unnecessary member.
876
877 2007-11-29  Anders Carlsson  <andersca@apple.com>
878
879         * DumpRenderTree/win/DumpRenderTree.vcproj:
880         Add shlwapi.lib to all configurations.
881
882 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
883
884         - Build fix.  Added additional includes for VS Express to the Release
885         project.
886
887         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
888
889 2007-11-29  Anders Carlsson  <andersca@apple.com>
890
891         Reviewed by Adam.
892
893         <rdar://problem/5132005>
894         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
895         
896         * DumpRenderTree/win/DumpRenderTree.vcproj:
897         Add shlwapi.lib
898         
899         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
900         (LayoutTestController::setUserStyleSheetEnabled):
901         Implement this.
902         
903         (appendComponentToPath):
904         New method which wraps the Win32 API PathAppend.
905         
906         (followShortcuts):
907         New method which checks if a file points to a shortcut and
908         follows the shortcut.
909         
910         (resolveCygwinPath):
911         New method that takes a cygwin unix-style path and returns the Win32 path.
912         
913         (cfStringRefToWString):
914         
915         (LayoutTestController::setUserStyleSheetLocation):
916         Implement this.
917
918 2007-11-29  Alice Liu  <alice.liu@apple.com>
919
920         Reviewed by Adam.
921
922         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
923
924         * DumpRenderTree/win/EventSender.cpp:
925         (keyDownCallback):
926         uppercase letters were being sent as lowercase letters without the shift key down.
927
928 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
929
930         - Windows build fix. VS express needs some love.
931
932         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
933
934 2007-11-28  Darin Adler  <darin@apple.com>
935
936         Reviewed by Adam Roben.
937
938         * DumpRenderTree/mac/EventSendingController.mm:
939         (-[EventSendingController keyDown:withModifiers:]):
940         Send capital letters through as lowercase letters with the shift key down
941         rather than sending them as if they were highly unusual "capital letter keys".
942
943         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
944         where you need to update results and more tests are failing than before.
945
946 2007-11-28  Anders Carlsson  <andersca@apple.com>
947
948         Reviewed by Darin.
949
950         <rdar://problem/5132001>
951         contextClick is not implemented in DRT on Windows.
952         
953         * DumpRenderTree/win/EventSender.cpp:
954         (contextClickCallback):
955         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
956         by a WM_RBUTTONUP message.
957         
958         * DumpRenderTree/win/UIDelegate.cpp:
959         (UIDelegate::hasCustomMenuImplementation):
960         (UIDelegate::trackCustomPopupMenu):
961         * DumpRenderTree/win/UIDelegate.h:
962         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
963         menu from being shown (and causing the DRT to hang).
964
965 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
966
967         Reviewed by Darin.
968
969         Fix DumpRenderTree ObjC bug comparing strings.
970
971         * DumpRenderTree/mac/ObjCController.m:
972         (-[ObjCController identityIsEqual::]): Compare strings with string
973         equality instead of identiy equality.
974
975 2007-11-27  Timothy Hatcher  <timothy@apple.com>
976
977         Reviewed by Sam.
978
979         Reset the authorAndUserStylesEnabled preference
980         back to YES for each test. Fixes the broken tests.
981
982         * DumpRenderTree/mac/DumpRenderTree.mm:
983         (resetWebViewToConsistentStateBeforeTesting):
984
985 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
986
987         Reviewed by Adam.
988
989         - Drosera now displays the console window, although it cannot currently
990         process JavaScript.
991
992         * Drosera/win/DebuggerClient.cpp: Shows the console window.
993         (registerConsoleClass): Implemented.
994         (consoleWndProc): Implemented.
995         (DebuggerClient::onSize): Implemented.
996         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
997         new window.
998         * Drosera/win/DebuggerClient.h: Added needed method and members for 
999         creating and maintaining a new window.
1000         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1001         lines of code to more appropriate places.
1002         (Drosera::handleCommand):
1003         (Drosera::initUI):
1004         (Drosera::onSize):
1005         (Drosera::attach):
1006
1007 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1008
1009         Reviewed by Dave Hyatt.
1010
1011         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1012         
1013         Add support for disabling author and user styles for testing.
1014
1015         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1016         * DumpRenderTree/LayoutTestController.cpp:
1017         (setAuthorAndUserStylesEnabledCallback):
1018         (LayoutTestController::staticFunctions):
1019         * DumpRenderTree/LayoutTestController.h:
1020         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1021         (LayoutTestController::setAuthorAndUserStylesEnabled):
1022         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1023         (LayoutTestController::setAuthorAndUserStylesEnabled):
1024
1025 2007-11-26  Dan Bernstein  <mitz@apple.com>
1026
1027         - Tiger build fix.
1028
1029         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1030
1031 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1032
1033         Reviewed by Maciej.
1034
1035         - Implemented displaying variables for Drosera on Win.
1036
1037         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1038         that retrieve variables to not hold onto the return value since it's
1039         not returned.  Also changed to use the new signatures of the retrieval
1040         functions.
1041         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1042         (DebuggerDocument::platformValueForScopeVariableNamed):
1043         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1044         (droseraWndProc):
1045
1046 2007-11-26  Sam Weinig  <sam@webkit.org>
1047
1048         Cleanup names of painting and repainting functions.
1049
1050         Reviewed by Adam Roben.
1051
1052         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1053         (drawSelectionRect): was drawSelectionRectIntoContext.
1054         (dumpWebViewAsPixelsAndCompareWithExpected):
1055         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1056         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1057         (paintWebView): was drawWebViewIntoContext.
1058         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1059
1060 2007-11-26  Sam Weinig  <sam@webkit.org>
1061
1062         Reviewed by Dan Bernstein.
1063
1064         - Leopard build fix
1065
1066         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1067
1068 2007-11-26  Sam Weinig  <sam@webkit.org>
1069
1070         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1071         Use shared PixelDumpSupport for Mac DRT
1072
1073         Reviewed by Adam Roben.
1074
1075         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1076         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1077         * DumpRenderTree/cg/ImageDiffCG.cpp:
1078         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1079         (drawSelectionRectIntoContext):
1080         (dumpWebViewAsPixelsAndCompareWithExpected):
1081         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1082         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1083         * DumpRenderTree/mac/DumpRenderTree.mm:
1084         (dump):
1085         * DumpRenderTree/mac/ImageDiff.m: Removed.
1086         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1087         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1088         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1089         (setDefaultColorProfileToRGB):
1090         (getBitmapContextFromWebView):
1091         (drawWebViewIntoContext):
1092         (repaintWithVerticalSweep):
1093         (repaintWithHorizontalSweep):
1094         (getSelectionRect):
1095         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1096
1097 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1098
1099         Bug 16052: prepare-ChangeLog doesn't report deleted files
1100         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1101
1102         Reviewed by Sam.
1103
1104         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1105
1106 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1107
1108         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1109         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1110
1111         Reviewed by Adam.
1112
1113         Roll functionality of merge-changelog into resolve-ChangeLogs
1114         script.  The script now checks for ChangeLog.rej and
1115         ChangeLog.orig files first.  If it finds them, it uses the
1116         ChangeLog.rej file as a patch (in old contextual diff format) to
1117         apply with --fuzz=3.
1118
1119         * Scripts/merge-changelog: Removed.
1120         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1121
1122 2007-11-25  Sam Weinig  <sam@webkit.org>
1123
1124         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1125
1126         Reviewed by Mark Rowe.
1127
1128         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1129         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1130         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1131         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1132         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1133
1134 2007-11-25  Sam Weinig  <sam@webkit.org>
1135
1136         Convert DumpRenderTree to ues .xcconfig files.
1137
1138         Reviewed by Mark Rowe.
1139
1140         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1141         * DumpRenderTree/mac/Configurations: Added.
1142         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1143         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1144         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1145
1146 2007-11-25  Sam Weinig  <sam@webkit.org>
1147
1148         Add ForwardingHeaders to wtf for DumpRenderTree.
1149
1150         Reviewed by Mark Rowe.
1151
1152         * DumpRenderTree/DumpRenderTree.h:
1153         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1154         * DumpRenderTree/ForwardingHeaders: Added.
1155         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1156         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1157         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1158         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1159         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1160         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1161         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1162         * DumpRenderTree/LayoutTestController.cpp:
1163         * DumpRenderTree/WorkQueue.cpp:
1164         * DumpRenderTree/mac/DumpRenderTree.mm:
1165         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1166         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1167         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1168         * DumpRenderTree/mac/ObjCController.m:
1169         * DumpRenderTree/mac/UIDelegate.mm:
1170         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1171
1172 2007-11-25  Adam Roben  <aroben@apple.com>
1173
1174         Fix some test failures caused by r28019
1175
1176         Now that stdout is in binary mode, we need to always use printf
1177         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1178         the output.
1179
1180         Reviewed by Sam.
1181
1182         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1183         printf.
1184         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1185         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1186         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1187         (UIDelegate::webViewAddMessageToConsole):
1188
1189 2007-11-25  Adam Roben  <aroben@apple.com>
1190
1191         Set the font smoothing preference in DRT
1192
1193         This makes the pixel results on Windows closer to the Mac results.
1194
1195         Reviewed by Mitz.
1196
1197         * DumpRenderTree/win/DumpRenderTree.cpp:
1198         (initializePreferences):
1199
1200 2007-11-25  Adam Roben  <aroben@apple.com>
1201
1202         Port ImageDiff to CG and C++
1203
1204         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1205         <rdar://5071708>
1206
1207         Reviewed by Sam.
1208
1209         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1210         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1211         (main):
1212         (createImageFromStdin):
1213         (compareImages):
1214         (getDifferenceBitmap):
1215         (computePercentageDifferent):
1216         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1217
1218 2007-11-25  Adam Roben  <aroben@apple.com>
1219
1220         Fix image diff link generation on Windows
1221
1222         Reviewed by Sam.
1223
1224         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1225         to toURL.
1226
1227 2007-11-25  Adam Roben  <aroben@apple.com>
1228
1229         Implement pixel dumping in Windows DRT
1230
1231         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1232         <rdar://5071708>
1233
1234         Reviewed by Sam.
1235
1236         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1237         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1238         Content-Length header.
1239         (getMD5HashStringForBitmap):
1240         (dumpWebViewAsPixelsAndCompareWithExpected):
1241         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1242         * DumpRenderTree/win/DumpRenderTree.cpp:
1243         (dump): Do a pixel dump if requested.
1244         (main): Parse pixel test options.
1245         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1246         the cg/ subdirectory to the include path.
1247         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1248         available in a header or import library, so we have to go through this
1249         LoadLibrary/GetProcAddress dance to use them.
1250         (cryptDLL):
1251         (init):
1252         (update):
1253         (final):
1254         (MD5_Init):
1255         (MD5_Update):
1256         (MD5_Final):
1257         * DumpRenderTree/win/MD5.h: Added.
1258         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1259         moved up to the top level to share it with Mac eventually.
1260         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1261         (getBitmapContextFromWebView): Forces the WebView to paint using a
1262         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1263
1264 2007-11-25  Adam Roben  <aroben@apple.com>
1265
1266         Clean up Windows DRT's option parsing a little bit
1267
1268         Reviewed by Sam.
1269
1270         * DumpRenderTree/win/DumpRenderTree.cpp:
1271         (main): Put non-option arguments into a Vector.
1272
1273 2007-11-25  Adam Roben  <aroben@apple.com>
1274
1275         Make Windows DRT stop changing LF into CRLF
1276
1277         Reviewed by Sam.
1278
1279         * DumpRenderTree/win/DumpRenderTree.cpp:
1280         (main): Put stdout in binary mode.
1281         * Scripts/run-webkit-tests: Remove the CRLF hack.
1282
1283 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1284
1285         Removed empty directory.
1286
1287         * Scripts/resources: Removed.
1288
1289 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1290
1291         Fix bisect-builds to work with recent WebKit nightly builds.
1292
1293         Reviewed by Dan.
1294
1295         * Scripts/bisect-builds: Check for the 
1296         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1297         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1298         to WebKit.app/Contents/Resources.
1299
1300 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1301
1302         Reviewed by Maciej.
1303
1304         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1305         not closed (affects digg.com)
1306
1307         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1308         one after finishing with a test to avoid having its delayed onload handler firing when
1309         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1310         but it helps somewhat.
1311
1312 2007-11-22  Mark Rowe  <mrowe@apple.com>
1313
1314         Reviewed by Alp Toker.
1315
1316         Fix build-webkit to propagate make's exit status if it fails.
1317
1318         * Scripts/webkitdirs.pm:
1319
1320 2007-11-22  Dan Bernstein  <mitz@apple.com>
1321
1322         Reviewed by Mark Rowe.
1323
1324         - fix crash when running pixel tests
1325
1326         * DumpRenderTree/mac/DumpRenderTree.mm:
1327         (dumpRenderTree): Parse the command line options before setting up the
1328         environment so that we know if we need to set up the pixel dump
1329         machinery.
1330
1331 2007-11-21  Eric Seidel  <eric@webkit.org>
1332
1333         Speculative build fix for Tiger.
1334
1335         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1336
1337 2007-11-21  Eric Seidel  <eric@webkit.org>
1338
1339         Reviewed by Tim Hatcher.
1340
1341         Break out more of DumpRenderTree.mm into individual files
1342
1343         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1344         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1345         (checkedMalloc):
1346         (checkedRealloc):
1347         (makeLargeMallocFailSilently):
1348         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1349         * DumpRenderTree/mac/DumpRenderTree.mm:
1350         (crashHandler):
1351         (dump):
1352         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1353         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1354         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1355         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1356         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1357         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1358         (javaScriptThreads):
1359         (runJavaScriptThread):
1360         (startJavaScriptThreads):
1361         (stopJavaScriptThreads):
1362         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1363         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1364         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1365         (restoreColorSpace):
1366         (setDefaultColorProfileToRGB):
1367         (initializeColorSpaceAndScreeBufferForPixelTests):
1368         (md5HashStringForBitmap):
1369         (dumpWebViewAsPixelsAndCompareWithExpected):
1370
1371 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1372
1373         Move install-unix-extras to wx directory as it seems only to be used by that 
1374         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1375         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1376         have install-unix-extras install into WebKitLibraries as per
1377         convention.
1378         
1379         Reviewed by Mark Rowe.
1380
1381         * Scripts/install-unix-extras: Removed.
1382         * wx/build-wxwebkit:
1383         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1384
1385 2007-11-21  Eric Seidel  <eric@webkit.org>
1386
1387         Reviewed by Adam.
1388
1389         More refactoring for greater code readability
1390
1391         * DumpRenderTree/mac/DumpRenderTree.mm:
1392         (initializeGlobalsFromCommandLineOptions):
1393         (initializeColorSpaceAndScreeBufferForPixelTests):
1394         (addTestPluginsToPluginSearchPath):
1395         (useLongRunningServerMode):
1396         (runTestingServerLoop):
1397         (prepareConsistentTestingEnvironment):
1398         (dumpRenderTree):
1399         (main):
1400         (dumpFramesAsText):
1401         (dumpBackForwardListForWebView):
1402         (sizeWebViewForCurrentTest):
1403         (methodNameStringForFailedTest):
1404         (dumpBackForwardListForAllWindows):
1405         (dumpWebViewAsPixelsAndCompareWithExpected):
1406         (invalidateAnyPreviousWaitToDumpWatchdog):
1407         (dump):
1408         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1409         * DumpRenderTree/mac/UIDelegate.mm:
1410         (-[UIDelegate webView:createWebViewWithRequest:]):
1411
1412 2007-11-21  Eric Seidel  <eric@webkit.org>
1413
1414         Reviewed by Tim Hatcher.
1415
1416         Abstract more of DRT into static methods
1417
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (setDefaultsToConsistentValuesForTesting):
1420         (setupSignalHandlers):
1421         (allocateGlobalControllers):
1422         (releaseAndZero):
1423         (releaseGlobalControllers):
1424         (dumpRenderTree):
1425         (shouldLogFrameLoadDelegates):
1426         (createCFURLFromPathOrURL):
1427         (resetWebViewToConsistentStateBeforeTesting):
1428         (runTest):
1429
1430 2007-11-21  Eric Seidel  <eric@webkit.org>
1431
1432         Reviewed by Tim Hatcher.
1433
1434         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1435
1436         * DumpRenderTree/DumpRenderTree.h:
1437         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1438         * DumpRenderTree/mac/DumpRenderTree.mm:
1439         (dumpRenderTree):
1440         (dump):
1441         (runTest):
1442         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1443         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1444         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1445         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1446         (-[DumpRenderTreePasteboard declareType:owner:]):
1447         (+[LocalPasteboard alloc]):
1448         (-[LocalPasteboard init]):
1449         (-[LocalPasteboard dealloc]):
1450         (-[LocalPasteboard name]):
1451         (-[LocalPasteboard releaseGlobally]):
1452         (-[LocalPasteboard declareTypes:owner:]):
1453         (-[LocalPasteboard addTypes:owner:]):
1454         (-[LocalPasteboard changeCount]):
1455         (-[LocalPasteboard types]):
1456         (-[LocalPasteboard availableTypeFromArray:]):
1457         (-[LocalPasteboard setData:forType:]):
1458         (-[LocalPasteboard dataForType:]):
1459         (-[LocalPasteboard setPropertyList:forType:]):
1460         (-[LocalPasteboard setString:forType:]):
1461         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1462         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1463         (+[DumpRenderTreeWindow allWindows]):
1464         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1465         (-[DumpRenderTreeWindow dealloc]):
1466         (-[DumpRenderTreeWindow isKeyWindow]):
1467         (-[DumpRenderTreeWindow keyDown:]):
1468
1469 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1470
1471         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1472         it indiscriminately copies any headers inside JavaScriptCore,
1473         which includes Tiger ICU headers. 
1474
1475         * wx/build-wxwebkit:
1476         Don't run WebCore/move-js-headers.sh any longer.
1477
1478 2007-11-20  Adam Treat  <treat@kde.org>
1479
1480         Reviewed by David Kilzer.
1481
1482         * Prepend git branch name to $baseProductDir
1483
1484         * Scripts/VCSUtils.pm:
1485         * Scripts/webkitdirs.pm:
1486
1487 2007-11-20  Mark Rowe  <mrowe@apple.com>
1488
1489         Reviewed by Simon Hausmann.
1490
1491         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1492         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1493         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1494         built product and generated Makefile's are removed.
1495
1496 2007-11-19  Alp Toker  <alp@atoker.com>
1497
1498         Reviewed by Mark Rowe.
1499
1500         http://bugs.webkit.org/show_bug.cgi?id=16040
1501         [GTK] GtkLauncher should be written in C
1502
1503         Port GtkLauncher to plain C.
1504
1505         Use a more conventional GTK+ coding style.
1506
1507         Use a toolbar instead of menus.
1508
1509         Various signature fixes and cleanups.
1510
1511         Add a license header. Assume all previous modifications were copyright
1512         assigned to Apple Inc. by default.
1513
1514         * GtkLauncher/GtkLauncher.pro:
1515         * GtkLauncher/main.c: Added.
1516         (activate_url_entry_cb):
1517         (update_title):
1518         (link_hover_cb):
1519         (title_change_cb):
1520         (progress_change_cb):
1521         (destroy_cb):
1522         (go_back_cb):
1523         (go_forward_cb):
1524         (create_browser):
1525         (create_statusbar):
1526         (create_toolbar):
1527         (create_window):
1528         (main):
1529         * GtkLauncher/main.cpp: Removed.
1530
1531 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1532
1533         Build script fixes to ensure they do the right thing for the 
1534         wx port, and update build-wxwebkit to reflect the way the
1535         build scripts now work.
1536
1537         Reviewed by Adam.
1538
1539         * Scripts/build-testkjs:
1540         * Scripts/build-webkit:
1541         * Scripts/run-javascriptcore-tests:
1542         * Scripts/webkitdirs.pm:
1543         * wx/build-wxwebkit:
1544
1545 2007-11-18  Eric Seidel  <eric@webkit.org>
1546
1547         Reviewed by Anders.
1548
1549         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1550
1551         * Scripts/run-javascriptcore-tests:
1552
1553 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1554
1555         Reviewed by Adam Roben.
1556
1557         Make run-webkit-tests work with Windows debug build.
1558
1559         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1560         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1561         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1562         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1563         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1564
1565 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1566
1567         Add wxWebKit sample and build script, and integrate it with 
1568         build-webkit. Also make build-webkit --clean work for all
1569         ports.
1570
1571         Reviewed by Darin Adler.
1572
1573         * Scripts/build-webkit:
1574         * Scripts/webkitdirs.pm:
1575         * wx: Added.
1576         * wx/browser: Added.
1577         * wx/browser/browser.bkl: Added.
1578         * wx/browser/browser.cpp: Added.
1579         * wx/build-wxwebkit: Added.
1580
1581 2007-11-17  Adam Roben  <aroben@apple.com>
1582
1583         Make it easy to run Safari in the debugger on Windows
1584
1585         I've added a new script, debug-safari, which launches Safari in the
1586         debugger. On OS X it just calls gdb-safari.
1587
1588         Reviewed by Mark Rowe.
1589
1590         * FindSafari/FindSafari.cpp:
1591         (_tmain): Added a /debugger flag, which in combination with
1592         /printSafariLauncher will print a script that launches Safari in the
1593         debugger.
1594         * Scripts/debug-safari: Added.
1595         * Scripts/run-safari: Changed to call runSafari().
1596         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1597         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1598         first argument along to FindSafari.
1599         * Scripts/webkitdirs.pm:
1600         (sub runSafari): Added.
1601
1602 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1603
1604         Reviewed by Adam Roben.
1605
1606         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1607
1608 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1609
1610         Reviewed by David Kilzer.
1611
1612         The git config command was renamed to repo-config at some point. This
1613         change tries git config and then git repo-config if the first fails.
1614
1615         * Scripts/prepare-ChangeLog:
1616         (gitConfig):
1617
1618 2007-11-16  Dan Bernstein  <mitz@apple.com>
1619
1620         Reviewed by Darin Adler and Sam Weinig.
1621
1622         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1623
1624         * DumpRenderTree/win/EventSender.cpp:
1625         (keyDownCallback): For characters that cannot be entered on the active
1626         keyboard layout, send a WM_CHAR message with the character along with
1627         a WM_KEYDOWN message with a virtual key code of 255.
1628
1629 2007-11-16  Mark Rowe  <mrowe@apple.com>
1630
1631         Reviewed by Tim Hatcher.
1632
1633         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1634
1635         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1636         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1637
1638 2007-11-15  Adam Roben  <aroben@apple.com>
1639
1640         Make run-safari actually work on Windows
1641
1642         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1643         chdir call.
1644
1645 2007-11-14  Adam Roben  <aroben@apple.com>
1646
1647         Updates to Safari launching now that 3.0.4 is released
1648
1649         Reviewed by Sam.
1650
1651         * FindSafari/FindSafari.cpp:
1652         (getWebViewCLSID): Use version-independent ProgID.
1653         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1654
1655 2007-11-14  Anders Carlsson  <andersca@apple.com>
1656
1657         Reviewed by Adam.
1658
1659         <rdar://problem/5309081>
1660         In DRT, "plugin.logDestroy = true" not working on Windows.
1661         
1662         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1663         (NPP_Destroy):
1664
1665 2007-11-14  Eric Seidel  <eric@webkit.org>
1666
1667         Reviewed by Sam.
1668
1669         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1670
1671 2007-11-14  Anders Carlsson  <andersca@apple.com>
1672
1673         Reviewed by Adam.
1674
1675         <rdar://problem/5141186>
1676         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1677         
1678         Implement setWindowIsKey.
1679         
1680         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1681         (LayoutTestController::setWindowIsKey):
1682
1683 2007-11-13  Sam Weinig  <sam@webkit.org>
1684
1685         Reviewed by Adam Roben.
1686
1687         Fix for <rdar://problem/5382579>
1688         http/tests/security/cross-frame-access-put.html reports large 
1689         negative numbers for screenLeft and screenTop (Mac reports "0")
1690
1691         * DumpRenderTree/win/UIDelegate.cpp:
1692         (UIDelegate::UIDelegate): Initialize the RECT.
1693         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1694         (UIDelegate::webViewFrame): ditto.
1695         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1696
1697 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1698
1699         Reviewed by Adam.
1700
1701         - Make Drosera show source, source URLs, and function stack on Windows,
1702         and some minor fixes.
1703
1704         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1705         (DebuggerDocument::updateFileSource):
1706         * Drosera/debugger.js: Force source to always update display.
1707         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1708         menu controls.
1709         (DebuggerClient::resume):
1710         (DebuggerClient::pause):
1711         (DebuggerClient::stepInto):
1712         (DebuggerClient::stepOver):
1713         (DebuggerClient::stepOut):
1714         (DebuggerClient::showConsole):
1715         (DebuggerClient::closeCurrentFile):
1716         * Drosera/win/DebuggerClient.h: Ditto.
1717         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1718         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1719         removed two bugs.  1) caller could be in a bad state when asked to
1720         assign into it. 2) BSTRs were not created correctly.
1721         (DebuggerDocument::getPlatformCurrentFunctionStack):
1722         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1723         (droseraWndProc):
1724         (handleCommand):
1725         (Drosera::resume):
1726         (Drosera::pause):
1727         (Drosera::stepInto):
1728         (Drosera::stepOver):
1729         (Drosera::stepOut):
1730         (Drosera::showConsole):
1731         (Drosera::closeCurrentFile):
1732         * Drosera/win/Drosera.h: Hook up the menu controls.
1733         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1734         functions, added a null check, and fixed another bug where caller could
1735         be in a bad state when asked to assign into it.
1736         (ServerConnection::didLoadMainResourceForDataSource):
1737         (ServerConnection::getCallerFrame):
1738         * Drosera/win/ServerConnection.h: Safety first.
1739
1740 2007-11-13  Dan Bernstein  <mitz@apple.com>
1741
1742         Reviewed by Darin Adler.
1743
1744         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1745           DumpRenderTree --pixel-tests renders each test twice
1746
1747         * DumpRenderTree/mac/DumpRenderTree.mm:
1748         (dumpRenderTree): Removed the --paint option because the painting code
1749         is always exercised as a result of
1750         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1751         calling -displayIfNeeded.
1752         (dump): Changed to always grab the image from the window since the view
1753         is always displayed.
1754         (runTest):
1755         (displayWebView):
1756         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1757         because it always paints.
1758
1759 2007-11-12  Antti Koivisto  <antti@apple.com>
1760
1761         Reviewed by Adele.
1762         
1763         Add support for http media tests
1764
1765         * Scripts/run-webkit-tests:
1766
1767 2007-11-12  Sam Weinig  <sam@webkit.org>
1768
1769         Reviewed by Adam Roben.
1770
1771         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1772
1773         * DumpRenderTree/win/DumpRenderTree.cpp:
1774         (runTest):
1775         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1776         (LayoutTestController::setPrivateBrowsingEnabled):
1777
1778 2007-11-12  Adam Roben  <aroben@apple.com>
1779
1780         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1781         mac and win subdirectories.
1782
1783 2007-11-11  Adam Roben  <aroben@apple.com>
1784
1785         Fix <rdar://5133816> keepWebHistory is not implemented
1786
1787         Fixes fast/history/clicked-link-is-visited.html.
1788
1789         Reviewed by Darin.
1790
1791         * DumpRenderTree/win/DumpRenderTree.cpp:
1792         (runTest): Clear the optionalSharedHistory.
1793         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1794         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1795
1796 2007-11-10  Sam Weinig  <sam@webkit.org>
1797
1798         Reviewed by Tim Hatcher.
1799
1800         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1801         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1802         is turned on)
1803
1804         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1805
1806         Added test: http/tests/security/cross-frame-access-private-browsing.html
1807
1808         * DumpRenderTree/LayoutTestController.cpp:
1809         (setPrivateBrowsingEnabledCallback):
1810         (LayoutTestController::staticFunctions):
1811         * DumpRenderTree/LayoutTestController.h:
1812         * DumpRenderTree/mac/DumpRenderTree.mm:
1813         (runTest): Default to private browsing disabled.
1814         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1815         (LayoutTestController::setPrivateBrowsingEnabled):
1816         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1817         (LayoutTestController::setPrivateBrowsingEnabled):
1818
1819 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1820
1821         Reviewed by Adam.
1822
1823         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1824         WebCore's!
1825
1826         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1827         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1828         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1829         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1830         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1831         * Drosera/win/Drosera.cpp:
1832         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1833
1834 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1835
1836         Reviewed by Sam.
1837
1838         - Use the new IWebFrame [local] function signature and get the shared
1839         server correctly.
1840
1841         * Drosera/win/DebuggerClient.cpp:
1842         (DebuggerClient::didFinishLoadForFrame):
1843         * Drosera/win/ServerConnection.cpp:
1844         (ServerConnection::attemptToCreateServerConnection):
1845
1846 2007-11-07  Dan Bernstein  <mitz@apple.com>
1847
1848         Reviewed by Darin Adler.
1849
1850         - add an option to run-webkit-tests to ignore pixel test failures where
1851           all pixels differ by no more than a specified threshold
1852
1853         * DumpRenderTree/mac/ImageDiff.m:
1854         (main):
1855         (compareImages):
1856         (computePercentageDifferent):
1857         * Scripts/run-webkit-tests:
1858
1859 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1860
1861         Reviewed by Lars.
1862
1863         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1864
1865         * DumpRenderTree/qt/DumpRenderTree.cpp:
1866
1867 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1868
1869         Reviewed by Lars.
1870
1871         Reworked the QWebSettings API.
1872         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1873
1874         * DumpRenderTree/qt/DumpRenderTree.cpp:
1875
1876 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1877
1878         Reviewed by Lars.
1879
1880         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1881
1882         * DumpRenderTree/qt/jsobjects.cpp:
1883
1884 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1885
1886         Reviewed by Lars Knoll <lars@trolltech.com>.
1887
1888         Add a QWebPage::frameCreated() signal and fix DRT
1889         
1890         The removal of createFrame in QWebPage broke the re-implementation
1891         in DumpRenderTree. Instead emit a frameCreated() signal and
1892         connect to it in DumpRenderTree.
1893         
1894
1895         * DumpRenderTree/qt/DumpRenderTree.cpp:
1896         (WebCore::WebPage::WebPage):
1897         (WebCore::DumpRenderTree::dump):
1898         (WebCore::DumpRenderTree::connectFrame):
1899         * DumpRenderTree/qt/DumpRenderTree.h:
1900
1901 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1902
1903         Reviewed by Lars Knoll <lars@trolltech.com>.
1904
1905         Moved all the event handlers from QWebFrame into QWebPage.
1906         
1907         This cleans up the public API and allows us to remove the
1908         HackWebFrame hack in DumpRenderTree.
1909         
1910
1911         * DumpRenderTree/qt/jsobjects.cpp:
1912         (EventSender::mouseDown):
1913         (EventSender::mouseUp):
1914         (EventSender::mouseMoveTo):
1915
1916 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1917
1918         Reviewed by Mark.
1919
1920         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1921         to prevent the default implementation from popping up messageboxes.
1922
1923         * DumpRenderTree/qt/DumpRenderTree.cpp:
1924         (WebCore::WebPage::javaScriptConfirm):
1925         (WebCore::WebPage::javaScriptPrompt):
1926
1927 2007-11-06  Eric Seidel  <eric@webkit.org>
1928
1929         * Scripts/build-testkjs: build fix... too many $$
1930
1931 2007-11-06  Eric Seidel  <eric@webkit.org>
1932
1933         Reviewed by Mark Rowe.
1934
1935         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1936
1937 2007-11-05  Adam Roben  <aroben@apple.com>
1938
1939         Add support on Windows for WEBKIT_TESTFONTS
1940
1941         This environment variable lets you specify where the fonts to be used
1942         by DumpRenderTree reside. The Qt port is already using this, so I'm
1943         just following their lead.
1944
1945         Reviewed by Darin.
1946
1947         * DumpRenderTree/win/DumpRenderTree.cpp:
1948         (exePath): Refactored code out of initialize().
1949         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1950         DumpRenderTree.resources.
1951         (initialize): Use the new fontsPath function.
1952         (main): Use the new exePath function.
1953         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1954         variable to DRT, like Qt does.
1955
1956 2007-11-05  Mark Rowe  <mrowe@apple.com>
1957
1958         Rubber-stamped by Alp Toker.
1959
1960         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1961
1962         * GtkLauncher/main.cpp:
1963         (goToURLBarText):
1964         (main):
1965
1966 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1967
1968         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1969         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1970
1971         Reviewed by Timothy.
1972
1973         Restrict the range of nightly builds used by the bisect-builds script
1974         based on the version of Safari and the version of Mac OS X being used.
1975
1976         Mac OS X 10.4: Safari 2.0: r11976 or newer
1977         Mac OS X 10.4: Safari 3.0: r19992 or newer
1978
1979         Mac OS X 10.5: Safari 2.0: r19594 or newer
1980         Mac OS X 10.5: Safari 3.0: r25124 or newer
1981
1982         * Scripts/bisect-builds:
1983         (findMacOSXVersion): Added.
1984         (makeNightlyList): Added argument to provide version of Mac OS X.
1985         Restrict range of nightly builds based on Safari and Mac OS X versions.
1986
1987 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1988
1989         Reviewed by Maciej.
1990
1991         - This patch involves several changes, all of them were noticed that
1992         they were needed by the work being done in WebKit to get Drosera and
1993         WebKit working together on Windows.
1994         - The changes are:
1995         1) Added a debugger console for output messages.
1996         2) Drosera now listens for the WebKit server (before, the server would
1997         have to be running before Drosera was started.)
1998         3) Fixed a bug where the WebView started out as 0x0 pixels.
1999         4) Fixed a bug when there is no scope.
2000         5) Added the HTML, JS, and CSS to the project file to make them easy to
2001         find.
2002         6) Made the ServerConnection functions virtual.
2003
2004         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2005         for the WebKit server.
2006         (DebuggerClient::DebuggerClient):
2007         (DebuggerClient::~DebuggerClient):
2008         (DebuggerClient::didFinishLoadForFrame):
2009         (DebuggerClient::serverConnected):
2010         (DebuggerClient::attemptToCreateServerConnection):
2011         * Drosera/win/DebuggerClient.h: Ditto.
2012         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2013         scope.
2014         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2015         (DebuggerDocument::platformValueForScopeVariableNamed):
2016         * Drosera/win/Drosera.cpp:
2017         (_tWinMain): Added a console in debug for output messages.
2018         (Drosera::Drosera): Listen for server.
2019         (Drosera::initUI): The server now Initializes COM.
2020         (Drosera::serverConnected): Part of the listening for the server.
2021         (Drosera::attemptToCreateServerConnection): Ditto.
2022         * Drosera/win/Drosera.h: New interface for listening for the server.
2023         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2024         files to the VS project.
2025         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2026         connection.
2027         (ServerConnection::ServerConnection):
2028         (ServerConnection::attemptToCreateServerConnection):
2029         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2030         methods.
2031         (ServerConnection::serverConnected):
2032
2033 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2034
2035         Reviewed by Maciej.
2036
2037         http://bugs.webkit.org/show_bug.cgi?id=15832
2038         fast/dom/gc-10.html crashes when run alone
2039
2040         Check for !done before using objects that can be already deallocated.
2041
2042         * DumpRenderTree/mac/EditingDelegate.mm:
2043         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2044         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2045         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2046         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2047         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2048         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2049         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2050         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2051         (-[EditingDelegate webViewDidBeginEditing:]):
2052         (-[EditingDelegate webViewDidChange:]):
2053         (-[EditingDelegate webViewDidEndEditing:]):
2054         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2055         (-[EditingDelegate webViewDidChangeSelection:]):
2056         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2057         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2058         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2059         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2060         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2061         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2062         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2063         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2064         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2065         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2066         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2067         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2068         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2069         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2070         (-[FrameLoadDelegate webView:willCloseFrame:]):
2071         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2072         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2073         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2074         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2075         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2076         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2077         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2078         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2079         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2080
2081 2007-11-04  Mark Rowe  <mrowe@apple.com>
2082
2083         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2084         warnings that would otherwise be suppressed due to it being a system header.
2085
2086         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2087
2088 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2089
2090         Rubber stamped by Adam.
2091         
2092         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2093
2094         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2095
2096 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2097
2098         Sort files(...); sections of Xcode project files.
2099
2100         Rubber-stamped by Darin.
2101
2102         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2103         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2104         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2105         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2106
2107 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2108
2109         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2110
2111         Reviewed by Darin.
2112
2113         * Scripts/sort-Xcode-project-file: Added.
2114
2115 2007-11-02  Darin Adler  <darin@apple.com>
2116
2117         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2118
2119 2007-11-02  Darin Adler  <darin@apple.com>
2120
2121         Reviewed by Maciej.
2122
2123         * Scripts/run-sunspider: Pass the "--base" option through.
2124
2125         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2126         the real script do that. Default configuration to Release to match run-sunspider
2127         so we don't end up building Debug just to compare results.
2128
2129 2007-11-01  Adam Roben  <aroben@apple.com>
2130
2131         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2132
2133         Reviewed by Sam.
2134
2135         * Scripts/commit-log-editor: Show all the directories beneath the
2136         source root, instead of just the last one.
2137
2138 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2139
2140         Reviewed by Adam Roben.
2141
2142         Print out an error message when the Windows build fails
2143         and provide guidance on how to find out what went wrong.
2144
2145         * Scripts/build-webkit:
2146         * Scripts/webkitdirs.pm:
2147
2148 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2149
2150         Rubber-stamped by Adam Roben.
2151
2152         Rolled out r27326 - debug CRT seems to cause no problems after all.
2153
2154         * DumpRenderTree/win/DumpRenderTree.vcproj:
2155
2156 2007-10-31  Adam Roben  <aroben@apple.com>
2157
2158         Switch the Debug configuration to using the non-debug CRT
2159
2160         This matches WebKit.
2161
2162         Reviewed by Steve.
2163
2164         * DumpRenderTree/win/DumpRenderTree.vcproj:
2165
2166 2007-10-31  Antti Koivisto  <antti@apple.com>
2167
2168         Reviewed by bdash.
2169         
2170         Disable media tests when doing leak checking on Tiger.
2171         They crash in QuickTime (rdar://problem/5537157).
2172
2173         * Scripts/run-webkit-tests:
2174
2175 2007-10-29  Antti Koivisto  <antti@apple.com>
2176
2177         Reviewed by Maciej.
2178         
2179         Build media support by default on OSX only.
2180
2181         * Scripts/build-webkit:
2182
2183 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2184
2185         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2186         get caught by the pre-commit hooks.
2187
2188 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2189
2190         Reviewed by Adam.
2191
2192         - This is a collection of relatively unrelated changes and cleanups
2193         to Drosera to prepare it for interacting with WebKit.  A lot of these
2194         changes are just correcting mistakes, for example removing included
2195         headers that are no longer needed.
2196
2197         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2198         this will be needed by the DebuggerClient.
2199         (DebuggerDocument::server):
2200         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2201         * Drosera/win/DebuggerClient.cpp: 
2202         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2203         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2204         (DebuggerClient::createWebViewWithRequest): Added comment about its
2205         purpose. 
2206         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2207         declarations.
2208         (DebuggerClient::webViewLoaded): Moved.
2209         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2210         file, since this was the only place it was used.
2211         (cfStringToBSTR):
2212         * Drosera/win/Drosera.h: Cleaned up the includes.
2213         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2214         * Drosera/win/HelperFunctions.h: Removed.
2215
2216 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2217
2218         Reviewed by Adam.
2219
2220         - Small cleanup in the ServerConnection class.
2221
2222         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2223         and added an include.
2224         (ServerConnection::currentFrame):
2225         (ServerConnection::getCallerFrame):
2226         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2227         made a pointer into a COMPtr, and cleaned up the includes.
2228
2229 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2230
2231         Reviewed by John Sullivan.
2232         
2233         - Place the Localizable.strings file in mac or win directories
2234           if that location exists.
2235         - Also look for UI_STRING in .c files.
2236
2237         * Scripts/extract-localizable-strings:
2238
2239 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2240
2241         Reviewed by Adam.
2242
2243         - Set the eol-style to native and made all the line endings the same
2244         so that I avoid messy diffs that show eol changes.
2245
2246         * Drosera/win/ServerConnection.cpp:
2247         (ServerConnection::didParseSource):
2248         (ServerConnection::didEnterCallFrame):
2249         (ServerConnection::willExecuteStatement):
2250         (ServerConnection::willLeaveCallFrame):
2251         (ServerConnection::exceptionWasRaised):
2252
2253 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2254
2255         Reviewed by Adam.
2256
2257         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2258         functionality that could not have existed previously without the new
2259         interfaces.
2260         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2261         from a BSTR to a JSValueRef.
2262         (DebuggerDocument::platformEvaluateScript): Implemented.
2263         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2264         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2265         Implemented.
2266         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2267         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2268         * Drosera/win/ServerConnection.cpp: Added a helper function.
2269         (ServerConnection::getCallerFrame):
2270         * Drosera/win/ServerConnection.h: Added a helper function.
2271
2272 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2273
2274         updated reviewers for my previous changelog.
2275
2276 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2277         Reviewed by Maciej and Adam and Geoff.
2278
2279         - Minor mac-side improvements including moving a function to a more
2280         appropriate location, fixing a warning, and correctly checking
2281         exceptions.
2282
2283         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2284         (DebuggerDocument::willExecuteStatement):
2285         (DebuggerDocument::didEnterCallFrame):
2286         (DebuggerDocument::willLeaveCallFrame):
2287         (DebuggerDocument::windowScriptObjectAvailable):
2288         (DebuggerDocument::callFunctionOnObject):
2289         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2290         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2291         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2292         because it doesn't require the ServerConnection at all.
2293         (NSStringCreateWithJSStringRef): Made an argument const.
2294         (JSValueRefCreateWithNSString): Made an argument const.
2295         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2296         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2297         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2298         * Drosera/mac/ServerConnection.mm: Ditto.
2299         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2300
2301 2007-10-29  Sam Weinig  <sam@webkit.org>
2302
2303         Reviewed by Adam Roben.
2304
2305         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2306
2307         * DumpRenderTree/LayoutTestController.cpp:
2308         (LayoutTestController::LayoutTestController):
2309         (getGlobalFlagCallback):
2310         (setGlobalFlagCallback):
2311         (LayoutTestController::getJSClass):
2312         (LayoutTestController::staticValues):
2313         * DumpRenderTree/LayoutTestController.h:
2314         (LayoutTestController::globalFlag):
2315         (LayoutTestController::setGlobalFlag):
2316
2317 2007-10-29  Darin Adler  <darin@apple.com>
2318
2319         Reviewed by Maciej.
2320
2321         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2322         resolution instead of its default.
2323
2324 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2325
2326         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2327
2328         Reviewed by Mark Rowe.
2329
2330         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2331         was successfully resolved, but this would not show any status because the change had
2332         already been cached in the index using "git add".  The solution is to add an optional
2333         second argument to showStatus() which adds the "--cached" switch to the command.
2334
2335         * Scripts/resolve-ChangeLogs:
2336         (showStatus):
2337
2338 2007-10-28  Eric Seidel  <eric@webkit.org>
2339
2340         Reviewed by Maciej and Geoff, in unison.
2341
2342         * Scripts/run-webkit-tests: remove broken --svg option
2343
2344 2007-10-28  Darin Adler  <darin@apple.com>
2345
2346         Reviewed by Adam.
2347
2348         * Scripts/run-sunspider: Default to "Release" configuration rather than
2349         defaulting to the last configuration used as other scripts do. This can
2350         still be overriden on the command line with "--debug" if there's some
2351         reason to do so. Also fix a typo.
2352
2353         * Scripts/sunspider-compare-results: Fix a typo.
2354
2355 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2356
2357         Reviewed by Adam.
2358
2359         - Implemented the WebScriptDebugListener functions now that the
2360         WebScriptDebugServer exists
2361
2362         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2363         functions.
2364         (ServerConnection::currentFrame):
2365         (ServerConnection::didLoadMainResourceForDataSource):
2366         (ServerConnection::didParseSource):
2367         (ServerConnection::failedToParseSource):
2368         (ServerConnection::didEnterCallFrame):
2369         (ServerConnection::willExecuteStatement):
2370         (ServerConnection::willLeaveCallFrame):
2371         (ServerConnection::exceptionWasRaised):
2372         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2373         members arguments list.
2374
2375 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2376
2377         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2378         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2379
2380         Reviewed by Darin.
2381
2382         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2383         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2384         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2385         file.  Note that it may also be used as a stand-alone script.
2386
2387         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2388         * Scripts/resolve-ChangeLogs: Added.
2389         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2390
2391 2007-10-26  Mark Rowe  <mrowe@apple.com>
2392
2393         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2394         to the Qt port on the assumption that it was an implementation of the cross-platform
2395         LayoutTestController class.  It is not, so it did not need to be changed.
2396
2397         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2398
2399 2007-10-25  Mark Rowe  <mrowe@apple.com>
2400
2401         Reviewed by Maciej.
2402
2403         Fix builds with code coverage enabled.
2404
2405         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2406
2407 2007-10-25  Darin Adler  <darin@apple.com>
2408
2409         Reviewed by Mark Rowe.
2410
2411         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2412         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2413
2414 2007-10-25  Stephanie  <slewis@apple.com>
2415
2416         build Fix
2417
2418         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2419
2420 2007-10-25  Stephanie  <slewis@apple.com>
2421
2422         Reviewed by Mark Rowe, Adam Roben.
2423
2424         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2425
2426         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2427
2428 2007-10-25  Alice Liu  <alice.liu@apple.com>
2429
2430         Reviewed by Adam.
2431
2432         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2433
2434         Moving destructor into platform-specific files
2435         * DumpRenderTree/LayoutTestController.cpp:
2436         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2437         (LayoutTestController::~LayoutTestController):
2438         * DumpRenderTree/qt/jsobjects.cpp:
2439         (LayoutTestController::~LayoutTestController):
2440
2441         LayoutTestController wasn't being destroyed
2442         * DumpRenderTree/win/DumpRenderTree.cpp:
2443         (runTest):
2444
2445         Added declspec
2446         * DumpRenderTree/win/EditingDelegate.h:
2447
2448         Reset certain values on the webview (or related delegate) that might 
2449         have changed while running a test
2450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2451         (LayoutTestController::~LayoutTestController):
2452
2453 2007-10-25  Adam Roben  <aroben@apple.com>
2454
2455         Make sunspider-compare-results work with relative paths
2456
2457         Reviewed by Sam.
2458
2459         * Scripts/sunspider-compare-results: Convert arguments to absolute
2460         paths before we chdir.
2461
2462 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2463
2464         Reviewed by Sam.
2465
2466         - Implemented server calls now the WebScriptDebugServer exists.
2467         - Also removed no longer needed call to initialize CG.
2468
2469         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2470         automatically now.
2471         (_tWinMain):
2472         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2473         (ServerConnection::ServerConnection):
2474         (ServerConnection::~ServerConnection):
2475         (ServerConnection::pause):
2476         (ServerConnection::resume):
2477         (ServerConnection::stepInto):
2478         (ServerConnection::applicationTerminating):
2479         (ServerConnection::serverConnectionDidDie):
2480         * Drosera/win/ServerConnection.h: Now uses the COM class.
2481
2482 2007-10-24  George Staikos  <staikos@kde.org>
2483
2484         Unbreak Qt build.
2485
2486         * Scripts/build-webkit:
2487
2488 2007-10-24  Adam Roben  <aroben@apple.com>
2489
2490         Remove now-unnecessary call to InitializeCoreGraphics
2491
2492         WebKit takes care of this now.
2493
2494         Reviewed by Ada.
2495
2496         * DumpRenderTree/win/DumpRenderTree.cpp:
2497         (initialize):
2498
2499 2007-10-24  Adam Roben  <aroben@apple.com>
2500
2501         Use WebTextRenderer in DRT
2502
2503         Reviewed by Ada.
2504
2505         * DumpRenderTree/win/DumpRenderTree.cpp:
2506         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2507
2508 2007-10-24  Sven Herzberg  <sven@imendio.com>
2509
2510         Reviewed by Mark Rowe.
2511
2512         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2513         Bug 15614: [GTK] qmake based backends don't build on OS X
2514
2515         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2516         GTK backend on a Mac
2517         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2518         isDarwin() to make it reusable in other places (like the workaround-
2519         for-prebuilt-qmake in build-webkit)
2520
2521 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2522
2523         Refurbish update-webkit script.
2524
2525         Reviewed by Adam.
2526
2527         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2528         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2529         multi-argument version of system() for flexibility and security.  Check for existence
2530         of Internal directory using -d test instead of -x.
2531
2532 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2533
2534         Minor clean-up of prepare-ChangeLog script.
2535
2536         Reviewed by Adam.
2537
2538         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2539         of a string.  Use multi-argument versions of open() and system() for flexibility and
2540         security.
2541
2542 2007-10-24  Alice Liu  <alice.liu@apple.com>
2543
2544         Reviewed by Oliver.
2545
2546         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2547
2548         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2549         replay the saved events when we're still processing the mousedown that starts the drag
2550         * DumpRenderTree/win/EventSender.cpp:
2551         (doMouseMove):
2552         * DumpRenderTree/win/UIDelegate.cpp:
2553         (UIDelegate::doDragDrop):
2554
2555 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2556
2557         Reviewed by Sam, Steve and Darin.
2558
2559         - Stubbed out the WebScriptDebugListener functionality in the Server
2560         Connection class to prepare it for receiving those callbacks.
2561         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2562         and the ServerConnection to not need to be initialized with a server
2563         name, since that is not the way we connect to the WebKit server. 
2564
2565         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2566         no exception.  Now it only loggs when there is an exception
2567         (DebuggerDocument::willExecuteStatement):
2568         (DebuggerDocument::didEnterCallFrame):
2569         (DebuggerDocument::willLeaveCallFrame):
2570         (DebuggerDocument::windowScriptObjectAvailable):
2571         (DebuggerDocument::callFunctionOnObject):
2572         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2573         to be instantiated with a server's name.
2574         (DebuggerClient::DebuggerClient):
2575         (DebuggerClient::didFinishLoadForFrame):
2576         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2577         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2578         a server name.
2579         (Drosera::init):
2580         (Drosera::initServer):
2581         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2582         instantiated with a server's name.
2583         * Drosera/win/ServerConnection.cpp: 
2584         (ServerConnection::ServerConnection): No longer needs a server name
2585         (ServerConnection::~ServerConnection): Only release the global context
2586         if there is one.
2587         (ServerConnection::serverConnectionDidDie): Stub for
2588         IWebScriptDebugListener
2589         (ServerConnection::QueryInterface): ditto
2590         (ServerConnection::AddRef): ditto
2591         (ServerConnection::Release): ditto
2592         (ServerConnection::didLoadMainResourceForDataSource): ditto
2593         (ServerConnection::didParseSource): ditto
2594         (ServerConnection::failedToParseSource): ditto
2595         (ServerConnection::didEnterCallFrame): ditto
2596         (ServerConnection::willExecuteStatement): ditto
2597         (ServerConnection::willLeaveCallFrame): ditto
2598         (ServerConnection::exceptionWasRaised): ditto
2599         * Drosera/win/ServerConnection.h: Stubbed out the
2600         IWebScriptDebugListener functions, and this class no longer needs to be
2601         instantiated with a server name.
2602
2603 2007-10-24  Lars Knoll  <lars@trolltech.com>
2604
2605         Reviewed by Simon.
2606
2607         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2608
2609         * DumpRenderTree/qt/jsobjects.h:
2610
2611 2007-10-24  Lars Knoll  <lars@trolltech.com>
2612
2613         Reviewed by Simon.
2614
2615         add another command.
2616
2617         * DumpRenderTree/qt/jsobjects.cpp:
2618         (TextInputController::doCommand):
2619
2620 2007-10-24  Lars Knoll  <lars@trolltech.com>
2621
2622         Reviewed by Simon.
2623
2624         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2625
2626         * DumpRenderTree/qt/jsobjects.cpp:
2627         (EventSender::keyDown):
2628         * DumpRenderTree/qt/jsobjects.h:
2629
2630 2007-10-24  Lars Knoll  <lars@trolltech.com>
2631
2632         Reviewed by Simon.
2633
2634         implement eventSender.keyDown().
2635
2636         * DumpRenderTree/qt/jsobjects.cpp:
2637         (EventSender::keyDown):
2638
2639 2007-10-24  Lars Knoll  <lars@trolltech.com>
2640
2641         Reviewed by Simon.
2642
2643         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2644
2645         * DumpRenderTree/qt/DumpRenderTree.cpp:
2646         (WebCore::DumpRenderTree::DumpRenderTree):
2647         (WebCore::DumpRenderTree::initJSObjects):
2648         * DumpRenderTree/qt/jsobjects.cpp:
2649         (TextInputController::doCommand):
2650
2651 2007-10-24  Lars Knoll  <lars@trolltech.com>
2652
2653         Reviewed by Simon.
2654
2655         first bit of implementation for the textinputcontroller.
2656
2657         * DumpRenderTree/qt/DumpRenderTree.cpp:
2658         (WebCore::DumpRenderTree::DumpRenderTree):
2659         * DumpRenderTree/qt/DumpRenderTree.h:
2660         * DumpRenderTree/qt/jsobjects.cpp:
2661         (TextInputController::TextInputController):
2662         (TextInputController::doCommand):
2663         * DumpRenderTree/qt/jsobjects.h:
2664
2665 2007-10-24  Lars Knoll  <lars@trolltech.com>
2666
2667         Reviewed by Simon.
2668
2669         make the man webpage believe it has focus, so the editing tests work correctly.
2670
2671         * DumpRenderTree/qt/DumpRenderTree.cpp:
2672         (WebCore::DumpRenderTree::DumpRenderTree):
2673
2674 2007-10-24  Lars Knoll  <lars@trolltech.com>
2675
2676         Reviewed by Simon.
2677
2678         implement layoutTestController.dumpEditingCallbacks() correctly.
2679
2680         * DumpRenderTree/qt/DumpRenderTree.cpp:
2681         (WebCore::DumpRenderTree::DumpRenderTree):
2682         * DumpRenderTree/qt/jsobjects.cpp:
2683         (LayoutTestController::reset):
2684         (LayoutTestController::dumpEditingCallbacks):
2685
2686 2007-10-24  Lars Knoll  <lars@trolltech.com>
2687
2688         Reviewed by Simon.
2689
2690         Implement support for testing editing.
2691
2692         * DumpRenderTree/qt/DumpRenderTree.cpp:
2693         (WebCore::DumpRenderTree::DumpRenderTree):
2694
2695 2007-10-23  Sam Weinig  <sam@webkit.org>
2696
2697         Check for null BSTR that can be passed to the UIDelegate methods
2698         from javascript null and undefined.  Fixes a failing test case on
2699         Windows (fast/dom/Window/alert-undefined.html)
2700
2701         Reviewed by Eric Seidel.
2702
2703         * DumpRenderTree/win/UIDelegate.cpp:
2704         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2705         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2706         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2707         (UIDelegate::webViewAddMessageToConsole):
2708
2709 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2710
2711         Reviewed by Darin.
2712         
2713         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2714
2715         * Scripts/build-testkjs:
2716
2717 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2718
2719         Reviewed by Darin.
2720
2721         - add wrapper that finds the right copy of testkjs
2722         
2723         * Scripts/sunspider-compare-results: Added.
2724
2725 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2726
2727         Reviewed by Sam.
2728
2729         - After talking with Steve I now see that the WebKit server must be
2730         running for DCOM to create the distributed objects, which makes sense
2731         and currently WebKit only allows one instance to be running at a time
2732         which avoids accidentally connecting to the wrong server
2733         - In light of this I have removed the code for the attach box and
2734         NotificationServer and known server names, since they are all extranious
2735         now.
2736
2737         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2738         names.
2739         (_tWinMain): Uses init instead of initUI.
2740         (droseraWndProc): No longer creats an attach dialog box.
2741         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2742         it's not manditory to call init before doing COM stuff.
2743         (Drosera::init): calls initUI and will call attach when the
2744         functionality exists. 
2745         (Drosera::initUI): Has changed very little.
2746         (Drosera::attach): Changed the signature to reflect that we no longer
2747         need the dictionary of known server names.
2748         * Drosera/win/Drosera.h: Removed notification classes and known server
2749         names.  Also renamed and moved some functions.
2750         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2751         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2752         headers to the resources folder. 
2753         * Drosera/win/resource.h: Removed the Attach box.
2754
2755 2007-10-22  Adam Roben  <aroben@apple.com>
2756
2757         Windows build fix
2758
2759         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2760
2761 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2762
2763         - Removed a leak that was fixed.
2764
2765         * Scripts/run-webkit-tests:
2766
2767 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2768
2769         Reviewed by Darin.
2770
2771         - Changed the Client so that the DebuggerDocument now own the
2772         ServerConnection.  This simplifies ownership and cleanup. 
2773
2774         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2775         ServerConnection.
2776         (DebuggerClient::initWithServerName):
2777         (DebuggerClient::didFinishLoadForFrame):
2778         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2779         ServerConnection.
2780         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2781         until after we have a server which we are attached to.
2782         (Drosera::initUI):
2783         (Drosera::attach):
2784         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2785         out previously.
2786
2787 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2788
2789         Reviewed by Nikolas.
2790
2791         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2792
2793         * Scripts/run-javascriptcore-tests:
2794
2795 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2796
2797         Reviewed by Nikolas.
2798
2799         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2800
2801         * Scripts/build-drosera:
2802         * Scripts/build-dumprendertree:
2803         * Scripts/build-testkjs:
2804         * Scripts/build-webkit:
2805         * Scripts/run-javascriptcore-tests:
2806         * Scripts/run-sunspider:
2807         * Scripts/run-webkit-tests:
2808         * Scripts/webkitdirs.pm:
2809
2810 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2811
2812         Reviewed by Mark Rowe.
2813         
2814         Fix for local database support after r26879
2815         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2816
2817         * Scripts/build-webkit:
2818
2819 2007-10-22  Holger Freyther  <zecke@selfish.org>
2820
2821         Reviewed by Simon Hausmann <hausmann@kde.org>.
2822
2823         - Do not build testkjs as an application bundle. This is
2824         needed for run-javascriptcore-tests on OSX.
2825         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2826         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2827         as we do not have -rpath on OSX.
2828
2829         * DumpRenderTree/qt/DumpRenderTree.pro:
2830         * Scripts/run-webkit-tests:
2831
2832 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2833
2834         Reviewed by aroben.
2835
2836         Fix support for Signed-off-by detection in prepare-ChangeLog
2837         --git-commit. The Signed-off-by tag does not appear in the header
2838         but usually at the end.
2839
2840         * Scripts/prepare-ChangeLog:
2841
2842 2007-10-21  Mark Rowe  <mrowe@apple.com>
2843
2844         Reviewed by Eric.
2845
2846         Fix run-javascriptcore-tests for Gtk.
2847
2848         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2849
2850 2007-10-20  Eric Seidel  <eric@webkit.org>
2851
2852         Reviewed by aroben.
2853
2854         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2855
2856 2007-10-20  Eric Seidel  <eric@webkit.org>
2857
2858         Reviewed by darin.
2859         
2860         Add improved argument handling to run-sunspider, including
2861         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2862         Also re-factor code into subroutines
2863
2864         * Scripts/build-dumprendertree: removed bogus comments
2865         * Scripts/build-testkjs: Added.
2866         * Scripts/run-javascriptcore-tests: use build-testkjs
2867         * Scripts/run-sunspider: improved argument handling, abstraction
2868         * Scripts/run-webkit-tests: improved abstraction
2869
2870 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2871
2872         Not reviewed, Windows build fix.
2873
2874         * DumpRenderTree/win/EventSender.cpp:
2875         (keyDownCallback):
2876
2877 2007-10-20  Darin Adler  <darin@apple.com>
2878
2879         Reviewed by Tim Hatcher.
2880
2881         - http://bugs.webkit.org/show_bug.cgi?id=15544
2882           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2883           not rely on Apple-specific key codes
2884
2885         * DumpRenderTree/mac/EventSendingController.mm:
2886         (-[EventSendingController keyDown:withModifiers:]):
2887         Added named key "rightArrow". Later we could have a whole table of these.
2888         Also tweaked modifiers code a little.
2889
2890         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2891
2892 2007-10-19  Darin Adler  <darin@apple.com>
2893
2894         Reviewed by Eric.
2895
2896         - http://bugs.webkit.org/show_bug.cgi?id=15566
2897           possible fix for leak seen in DumpRenderTree
2898
2899         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2900         Delete the item if it's not put on the queue, since the caller has
2901         no way of knowing that. Would be better to have the parameter type
2902         be auto_ptr to express the fact that we take ownership.
2903
2904         - unrelated change
2905
2906         * Drosera/mac/main.m: Add missing include.
2907
2908 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2909
2910         Reviewed by Adam.
2911
2912         - This change should be identical but for some reason was not working
2913         on my machine.
2914
2915         * Scripts/prepare-ChangeLog:
2916
2917 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2918
2919         Reviewed by Oliver and Tim.
2920
2921         - Made use of RetainPtr to avoid retain and release issues and moved the
2922         log function to DebuggerDocumentPlatform, which seems to be a more
2923         logical place for it to live.
2924         - Also moved knownServers from the ServerConnection to
2925         DebuggerApplication to match the Windows code and because it makes sense
2926         that a connection knows its own server but not all of them.
2927
2928         * Drosera/mac/DebuggerClient.h: Moved the log function to
2929           DebuggerDocumentPlatform.
2930         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2931           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2932           call for the server name up from the ServerConnection class.
2933         (-[DebuggerClient dealloc]):
2934         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2935           for the server name up from the ServerConnection.
2936         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2937         (DebuggerDocument::platformPause):
2938         (DebuggerDocument::platformResume):
2939         (DebuggerDocument::platformStepInto):
2940         (DebuggerDocument::platformEvaluateScript):
2941         (DebuggerDocument::getPlatformCurrentFunctionStack):
2942         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2943         (DebuggerDocument::platformValueForScopeVariableNamed):
2944         (DebuggerDocument::platformLog): Log directly from here. No need to call
2945           DebuggerClient.
2946         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2947           way I see it, a ServerConnection should only know about its connection
2948           and the group of all possible servers should be kept by the
2949           application.
2950         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2951           currentServerName, it makes sense that the connection should know that
2952           name.
2953         (-[ServerConnection currentServerName]):
2954
2955 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2956
2957         Reviewed by Adam.
2958
2959         - Integrated changes from mac drosera.  Recently I've encapsulated
2960         out the server connection object from the rest of Drosera because
2961         it is very platform dependent right now and RPC is not implemented on
2962         windows.  This functionality, of communicating with the WebKit server
2963         is the next area I will be focusing on in Windows.
2964
2965         - Other changes and cleanup were made to organize the code and add notes
2966         on which parts still need work.  Also some mac code is added and
2967         commented out, to act as pseudocode for the logic of those parts.
2968
2969         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2970           pointer.
2971         * Drosera/config.h: Added whitespace.
2972         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2973           these files got moved into Drosera.h/cpp
2974         * Drosera/win/DebuggerApplication.h: Removed.
2975         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2976           happened here to better match the logic flow of the same code on the 
2977           mac side and to use the new ServerConnection class.
2978         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2979         (DebuggerClient::initWithServerName): Initializer that will set up the
2980           class to use a ServerConnection object.  This was necessary so I could
2981           create a DebuggerClient without having to initilaize it at
2982           construction.
2983         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2984           will be the UIDelegate and FrameLoadDelegate.
2985         (DebuggerClient::AddRef): For IUnknown.
2986         (DebuggerClient::Release): For IUnknown.
2987         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2988           this still needs to set the global context of the server, but
2989           IWebFrame does not have an accessor for the global context yet. 
2990         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2991           this is a pass through for the same function in the document.
2992         (DebuggerClient::didReceiveTitle): Unimplemented part of
2993           FrameLoadDelegate this would change the title of the window.
2994         (DebuggerClient::createWebViewWithRequest): Part of the
2995           FrameLoadDelegate.  This is about new windows via Window.open() and
2996           how their delegates are set.
2997         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2998           UIDelegate.  Just a debug function for printing messages.
2999         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3000           because the Client should be the UIDelegate and FrameLoadDelegate
3001           to match the delegates on mac.
3002         (DebuggerClient::webViewLoaded): Added accessor method.
3003         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3004           forgotten to add this file before.  This is where the platform
3005           dependent versions of the Documents functions live. Most of these are
3006           unimplemented because some piece of functionality does not exist on
3007           Windows yet.
3008         (DebuggerDocument::platformPause):
3009         (DebuggerDocument::platformResume):
3010         (DebuggerDocument::platformStepInto):
3011         (DebuggerDocument::platformEvaluateScript):
3012         (DebuggerDocument::getPlatformCurrentFunctionStack):
3013         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3014         (DebuggerDocument::platformValueForScopeVariableNamed):
3015         (DebuggerDocument::platformLog):
3016         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3017           responsibilities becaue they belong in the Client. Also I laid the
3018           groundwork for attaching Drosera to a WebKit process
3019         (attachWndProc): Now if a server is selected the Client becomes it's
3020           delegate.
3021         (Drosera::Drosera): Added the construction of the Client and dictionary
3022           of server names. 
3023         (Drosera::initUI): This is no longer the delegates, the Client is.
3024         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3025           state. 
3026         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3027           notification registration when it's possible to implement.
3028         (Drosera::serverLoaded): Ditto
3029         (Drosera::serverUnloaded): Ditto
3030         (Drosera::attach): Attach Drosera to the WebKit server.
3031         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3032         (Drosera::getInst): 
3033         (Drosera::setInst):
3034         (Drosera::knownServers):
3035         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3036           and added the ServerConnection.
3037         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3038         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3039           Most of the functions are completely unimlemented because they cannot
3040           connect with the WebKit server, because one does not exist on Windows
3041           yet.
3042         (ServerConnection::initWithServerName): 
3043         (ServerConnection::~ServerConnection):
3044         (ServerConnection::setGlobalContext):
3045         (ServerConnection::pause):
3046         (ServerConnection::resume):
3047         (ServerConnection::stepInto):
3048         (ServerConnection::switchToServerNamed):
3049         (ServerConnection::applicationTerminating):
3050         (ServerConnection::serverConnectionDidDie):
3051         (ServerConnection::currentFrame):
3052         * Drosera/win/ServerConnection.h: Added. Ditto.
3053         (ServerConnection::ServerConnection):
3054
3055 2007-10-19  Alice Liu  <alice.liu@apple.com>
3056
3057         Reviewed by Darin.
3058
3059         Fix for these broken layout tests on Windows:
3060         
3061         fast/forms/focus-selection-input.html
3062         fast/forms/focus-selection-textarea.html
3063         fast/forms/select-accesskey.html
3064         
3065         * DumpRenderTree/win/EventSender.cpp:
3066         (keyDownCallback):
3067         correct the VK code for alt key.
3068         
3069 2007-10-19  Eric Seidel  <eric@webkit.org>
3070
3071         Reviewed by Mark Rowe.
3072         
3073         Make the GtkLauncher code slightly more readable.
3074
3075         * GtkLauncher/main.cpp:
3076         (setupMainMenu): Added.
3077         (setupMainWindowUI): Added.
3078         (main):
3079
3080 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3081
3082         Rubber stamped by Adam.
3083         
3084         - don't delay-load WebKit in DumpRenderTree.
3085
3086         * DumpRenderTree/win/DumpRenderTree.vcproj:
3087
3088 2007-10-18  Dan Bernstein  <mitz@apple.com>
3089
3090         Reviewed by Adam Roben.
3091
3092         - fix <rdar://problem/5313523>
3093         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3094
3095         * DumpRenderTree/mac/DumpRenderTree.mm:
3096         (dump): Changed to use _responseMIMEType.
3097
3098 2007-10-17  Adam Roben  <aroben@apple.com>
3099
3100         Make it possible to have Windows-specific tests and results
3101
3102         When searching for tests to run and the Skipped file, we will only
3103         look in platform/win and the cross-platform directory. When looking
3104         for expected results, we will look in platform/win, then
3105         platform/mac-leopard, then platform/mac, then finally the
3106         cross-platform directory.
3107
3108         Reviewed by Sam.
3109
3110         * Scripts/run-webkit-tests:
3111         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3112         searching in the cross-platform directory.
3113         (sub buildPlatformHierarchy): Removed some unneeded calls to
3114         dirname/basename.
3115
3116 2007-10-17  Adam Roben  <aroben@apple.com>
3117
3118         Add back the call to register WebKit that we had before WebKitInitializer existed
3119
3120         This is needed to ensure that the right WebKit is used when
3121         instantiating COM objects.
3122
3123         Reviewed by Oliver.
3124
3125         * DumpRenderTree/win/debug_internal.vsprops: Define
3126         DEBUG_WEBKIT_HAS_SUFFIX.
3127         * DumpRenderTree/win/DumpRenderTree.cpp:
3128         (initialize):
3129
3130 2007-10-17  Adam Roben  <aroben@apple.com>
3131
3132         Import File::Basename in webkitdirs since we use it
3133
3134         * Scripts/webkitdirs.pm:
3135
3136 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3137
3138         - Updated the tiger leaks list to make the internal bots green.
3139
3140         * Scripts/run-webkit-tests:
3141
3142 2007-10-17  Adam Roben  <aroben@apple.com>
3143
3144         Build fix for VC++ Express
3145
3146         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3147         and ole32.lib.
3148
3149 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3150
3151         Reviewed by Sam.
3152
3153         - Minor mac improvements based on observations I made while implementing the
3154         Windows code.
3155
3156         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3157         then hand it to the Client who will retain it, it should just be the client who
3158         creates and owns the server.
3159         (-[DebuggerApplication attach:]):
3160         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3161         * Drosera/mac/DebuggerClient.mm: Creates the server.
3162         (-[DebuggerClient initWithServerName:]):
3163         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3164         can instead forward declare what it needs.
3165
3166 2007-10-16  Darin Adler  <darin@apple.com>
3167
3168         Reviewed by Geoff Garen.
3169
3170         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3171         want to turn failing tests into platform-specific test results. Also did a
3172         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3173         would take the type of results into account only some of the time.
3174
3175 2007-10-16  Adam Roben  <aroben@apple.com>
3176
3177         Add a new nightly launcher script for Windows
3178
3179         This new script is for versions of Safari that don't delay-load
3180         WebKit. I had to make FindSafari be able to print out the nightly
3181         launcher script on stdout because Windows shell scripts can't capture
3182         the output from a command into an environment variable.
3183
3184         Reviewed by Steve.
3185
3186         * FindSafari/FindSafari.cpp:
3187         (_tmain): Added /printSafariLauncher option.
3188         * Scripts/run-webkit-nightly.cmd: Added.
3189
3190 2007-10-16  Adam Roben  <aroben@apple.com>
3191
3192         Replace WebKitInitializer with FindSafari
3193
3194         We now rely on setting the PATH environment variable to tell Windows
3195         where to find WebKit and its dependencies (similar to
3196         DYLD_FRAMEWORK_PATH on Mac).
3197
3198         This change also make DumpRenderTree no longer delay-load WebKit.
3199
3200         Reviewed by Sam.
3201
3202         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3203         FindSafari.
3204         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3205         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3206         WebKitInitializer, don't delay-load WebKit.
3207         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3208         * Scripts/run-webkit-tests: Ditto.
3209         * Scripts/webkitdirs.pm:
3210         (sub setPathForRunningWebKitApp): Added.
3211         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3212         * WebKitInitializer/WebKitInitializer.h: Removed.
3213         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3214         * WebKitInitializer/debug.vsprops: Removed.
3215         * WebKitInitializer/debug_internal.vsprops: Removed.
3216         * WebKitInitializer/release.vsprops: Removed.
3217
3218 2007-10-16  Adam Roben  <aroben@apple.com>
3219
3220         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3221
3222         http://bugs.webkit.org/show_bug.cgi?id=15532
3223
3224         FindSafari simply prints the location of an installed Safari.exe on
3225         stdout.
3226
3227         Reviewed by Darin.
3228
3229         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3230         (getStringValue):
3231         (getWebViewCLSID):
3232         (getInstalledWebKitDirectory):
3233         (_tmain):
3234         * FindSafari/FindSafari.vcproj: Added.
3235         * Scripts/webkitdirs.pm:
3236         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3237
3238 2007-10-16  Adam Roben  <aroben@apple.com>
3239
3240         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3241
3242         Reviewed by Kevin McCullough.
3243
3244         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3245         when referring to WebKit.dll.
3246         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3247         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3248         * DumpRenderTree/win/release.vsprops: Ditto.
3249         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3250         never have a _debug suffix on WebKit.dll.
3251         * WebKitInitializer/WebKitInitializer.cpp:
3252         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3253         specified.
3254         * WebKitInitializer/debug_internal.vsprops: Added
3255         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3256
3257 2007-10-16  Darin Adler  <darin@apple.com>
3258
3259         Reviewed by Adele.
3260
3261         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3262         Remove now-unneeded control/alt key hack; the tests have been updated.
3263
3264 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3265
3266         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3267         one of the leaks was fixed between that revision and the bot's previous version of
3268         leopard.
3269
3270         * Scripts/run-webkit-tests:
3271
3272 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3273
3274         Reviewed by Tim.
3275
3276         - I encapsulated out the server connecton functionality because it is a specific part
3277         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3278         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3279         Windows.  So the majority of this patch is moving preexisting functionality.
3280
3281         - Also I removed the prefix header and changed to use config.h because it is more
3282         standard on how we use config.h in windows and it didn't make much sense to keep
3283         the prefix header and the config.h
3284
3285         * Drosera/DebuggerDocument.cpp:
3286         (DebuggerDocument::DebuggerDocument):
3287         * Drosera/DebuggerDocument.h:
3288         * Drosera/config.h:
3289         * Drosera/mac/DebuggerApplication.mm:
3290         (-[DebuggerApplication attach:]):
3291         * Drosera/mac/DebuggerClient.h:
3292         * Drosera/mac/DebuggerClient.mm:
3293         (-[DebuggerClient initWithServerConnection:]):
3294         (-[DebuggerClient dealloc]):
3295         (-[DebuggerClient windowDidLoad]):
3296         (-[DebuggerClient windowWillClose:]):
3297         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3298         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3299         * Drosera/mac/DebuggerDocumentPlatform.mm:
3300         (DebuggerDocument::platformPause):
3301         (DebuggerDocument::platformResume):
3302         (DebuggerDocument::platformStepInto):
3303         (DebuggerDocument::platformEvaluateScript):
3304         (DebuggerDocument::getPlatformCurrentFunctionStack):
3305         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3306         (DebuggerDocument::platformValueForScopeVariableNamed):
3307         (DebuggerDocument::platformLog):
3308         * Drosera/mac/Drosera.pch: Removed.
3309         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3310         * Drosera/mac/ServerConnection.h: Added.
3311         * Drosera/mac/ServerConnection.mm: Added.
3312         (-[ServerConnection initWithServerName:]):
3313         (-[ServerConnection dealloc]):
3314         (-[ServerConnection setGlobalContext:]):
3315         (-[ServerConnection pause]):
3316         (-[ServerConnection resume]):
3317         (-[ServerConnection stepInto]):
3318         (-[ServerConnection switchToServerNamed:]):
3319         (-[ServerConnection applicationTerminating:]):
3320         (-[ServerConnection serverConnectionDidDie:]):
3321         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3322         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3323         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3324         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3325         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3326         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3327         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3328         (-[ServerConnection currentFrame]):
3329         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3330         (-[ServerConnection knownServers]):
3331
3332 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3333
3334         Reviewed by Eric.
3335
3336         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3337           Script to automatically search nightly builds for regressions (bisect-builds)
3338
3339         * Scripts/bisect-builds: Added.
3340
3341 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3342
3343         Reviewed by Darin.
3344
3345         - New JavaScript benchmark
3346         http://bugs.webkit.org/show_bug.cgi?id=15515
3347
3348         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3349         current development or release build of JavaScriptCore.
3350
3351 2007-10-15  Mark Rowe  <mrowe@apple.com>
3352
3353         Reviewed by Sam.
3354
3355         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3356
3357         * Scripts/webkitdirs.pm:
3358         - Change checkArgv to remove the options from @ARGV to prevent
3359         them from interfering with further option processing.
3360         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3361         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3362         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3363         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3364
3365 2007-10-15  Darin Adler  <darin@apple.com>
3366
3367         Reviewed by Sam.
3368
3369         - added logging of window.prompt and window.confirm
3370
3371         * DumpRenderTree/mac/UIDelegate.mm:
3372         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3373         Implement the recommended delegate rather than the deprecated one.
3374         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3375         Added.
3376         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3377         Added.
3378
3379         * DumpRenderTree/win/UIDelegate.h:
3380         * DumpRenderTree/win/UIDelegate.cpp:
3381         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3382         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3383         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3384         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3385
3386 2007-10-15  Alice Liu  <alice.liu@apple.com>
3387
3388         Reviewed by Sam Weinig.
3389
3390         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3391
3392         * DumpRenderTree/win/DumpRenderTree.cpp:
3393         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3394         (main): allocate the global policy delegate for DRT's custom use
3395         * DumpRenderTree/win/DumpRenderTree.vcproj:
3396         Adding files to project
3397         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3398         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3399         (LayoutTestController::setCustomPolicyDelegate):
3400         set the webview's policy delegate to DRT's custom one if the test requests it.
3401         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3402         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3403         (PolicyDelegate::PolicyDelegate):
3404         (PolicyDelegate::QueryInterface):
3405         (PolicyDelegate::AddRef):
3406         (PolicyDelegate::Release):
3407         (PolicyDelegate::decidePolicyForNavigationAction):
3408         * DumpRenderTree/win/PolicyDelegate.h: Added.
3409         (PolicyDelegate::decidePolicyForNewWindowAction):
3410         (PolicyDelegate::decidePolicyForMIMEType):
3411         (PolicyDelegate::unableToImplementPolicyWithError):
3412
3413 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3414
3415         Reviewed by Mark.
3416
3417         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3418         when querying for QMAKE_MKSPECS.
3419
3420 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3421
3422         Reviewed by Adam Roben.
3423         
3424         Fix run-webkit-tests is too greedy calculating platform hierarchy
3425         http://bugs.webkit.org/show_bug.cgi?id=15465
3426         
3427         Fix run-webkit-tests being too greedy in trying to split the platform name up
3428         causing it to try and find tests in every directory above the first "-" in the
3429         path to the LayoutTests
3430
3431         * Scripts/run-webkit-tests:
3432
3433 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3434
3435         Reviewed by Darin.
3436
3437         http://bugs.webkit.org/show_bug.cgi?id=15006
3438         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3439         to reduce code duplication.
3440
3441         * Scripts/build-webkit:
3442         * Scripts/webkitdirs.pm:
3443         buildQMakeProject() renamed to buildQMakeQtProject().
3444         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3445         unused $colorize has been removed.
3446
3447 === Start merge of feature-branch 2007-10-12 ===
3448
3449 2007-10-08  Eric Seidel  <eric@webkit.org>
3450
3451         Reviewed by Mark Rowe.
3452
3453         * Scripts/build-webkit: add --help, remove unused --color
3454
3455 2007-10-07  Eric Seidel  <eric@webkit.org>
3456
3457         Reviewed by darin.
3458
3459         * Drosera/mac/DebuggerDocumentPlatform.mm:
3460         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3461
3462 2007-10-03  Rob Buis  <buis@kde.org>
3463
3464         Reviewed by Olliej.
3465
3466         Adapt to changed location of Ahem font.
3467
3468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3469
3470 2007-10-02  Eric Seidel  <eric@webkit.org>
3471
3472         Reviewed by Adam Roben.
3473         
3474         Make pixel tests more useful!
3475         Finally fix the image diff 0.00% mystery problem
3476         Highlight any image differences in the image diff.
3477         Add a link from image diffs back to original test file.
3478
3479         * DumpRenderTree/mac/ImageDiff.m:
3480         (compareImages): highlight any differences
3481         (computePercentageDifferent): round to two decimal places
3482         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3483
3484 2007-10-02  Eric Seidel  <eric@webkit.org>
3485
3486         Reviewed by Alexey Proskuryakov.
3487
3488         * Scripts/run-webkit-tests: print the % image difference on main results page
3489
3490 2007-10-02  Mark Rowe  <mrowe@apple.com>
3491
3492         Reviewed by Oliver.
3493
3494         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3495
3496         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3497         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3498
3499 2007-10-01  Mark Rowe  <mrowe@apple.com>
3500
3501         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3502
3503 2007-09-25  Eric Seidel  <eric@webkit.org>
3504
3505         Reviewed by Mark Rowe.
3506         
3507         DerivedSources.make was finding "ENABLE_SVG" in the string
3508         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3509         quite correctly.
3510
3511         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3512
3513 2007-09-25  Mark Rowe  <mrowe@apple.com>
3514
3515         Rubber-stamped by Eric.
3516
3517         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3518         This makes it possible to automate nightly builds for the feature-branch.
3519
3520 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3521
3522         Rubber stamped by Mark.
3523
3524         Enable svg experimental features as default here in feature-branch.
3525
3526         * Scripts/build-webkit:
3527
3528 2007-06-29  Antti Koivisto  <antti@apple.com>
3529
3530         Reviewed by Weinig.
3531         
3532         Add VIDEO flag for timed media features
3533
3534         * Scripts/build-webkit
3535         
3536 === End merge of feature-branch 2007-10-12 ===
3537
3538 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3539
3540         Reviewed by Darin.
3541
3542         - Updated rational for the leaks list to be more clear.
3543
3544         * Scripts/run-webkit-tests:
3545
3546 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3547
3548         Rubber Stamp by Sam.
3549
3550         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3551         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3552
3553         * Scripts/run-webkit-tests:
3554
3555 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3556
3557         Reviewed by Lars.
3558
3559         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3560         includes are needed for INT_MAX, std::auto_ptr and the like.
3561
3562         * DumpRenderTree/qt/main.cpp:
3563
3564 2007-10-09  Lars Knoll  <lars@trolltech.com>
3565
3566         Reviewed by Simon.
3567
3568         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3569
3570         * DumpRenderTree/qt/jsobjects.cpp:
3571         (LayoutTestController::encodeHostName):
3572         (LayoutTestController::decodeHostName):
3573         * DumpRenderTree/qt/jsobjects.h:
3574
3575 2007-10-09  Lars Knoll  <lars@trolltech.com>
3576
3577         Reviewed by Simon.
3578
3579         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3580
3581         * DumpRenderTree/qt/DumpRenderTree.cpp:
3582         (WebCore::WebPage::createFrame):
3583         (WebCore::DumpRenderTree::DumpRenderTree):
3584         (WebCore::DumpRenderTree::titleChanged):
3585         * DumpRenderTree/qt/DumpRenderTree.h:
3586         * DumpRenderTree/qt/jsobjects.cpp:
3587         (LayoutTestController::reset):
3588         * DumpRenderTree/qt/jsobjects.h:
3589
3590 2007-10-09  Lars Knoll  <lars@trolltech.com>
3591
3592         Reviewed by Simon.
3593
3594         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3595
3596         * DumpRenderTree/qt/DumpRenderTree.h:
3597         * DumpRenderTree/qt/jsobjects.cpp:
3598         (LayoutTestController::clearBackForwardList):
3599         * DumpRenderTree/qt/jsobjects.h:
3600
3601 2007-10-09  Lars Knoll  <lars@trolltech.com>
3602
3603         Reviewed by Simon.
3604
3605         make --git-reviewer work again.
3606
3607         * Scripts/prepare-ChangeLog:
3608
3609 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3610
3611         Rubber stamped by Eric.
3612
3613         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3614         show the current link inside the statusbar.