2010-11-30 Mihai Parparita <mihaip@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         Rebaseline server: baseline display tweaks
6         https://bugs.webkit.org/show_bug.cgi?id=50207
7         
8         Determine which baselines were used when running the tests and higlight
9         them in the UI. Sort platform names alphabetically.
10         
11         Also makes the server URL be launched in the user's browser
12         automatically.
13
14         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
15         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
16         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
17         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
18         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
19
20 2010-11-30  Dan Bernstein  <mitz@apple.com>
21
22         Reviewed by Anders Carlsson.
23
24         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
25         https://bugs.webkit.org/show_bug.cgi?id=50238
26
27         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
28         (WTR::LayoutTestController::findString): Added.
29         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
30
31 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
32
33         Reviewed by Adam Roben.
34
35         All projects on Windows should use cmd files for build events
36         https://bugs.webkit.org/show_bug.cgi?id=50213
37
38         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
39         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
40         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
41         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
42         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
43         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
44         * DumpRenderTree/win/ImageDiffCommon.vsprops:
45         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
46         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
47         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
48         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
49         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
50         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
51         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
52         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
53         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
54         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
55         * WebKitAPITest/WebKitAPITestCommon.vsprops:
56         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
57         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
58         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
59         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
60         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
61         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
62         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
63         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
64         * WinLauncher/WinLauncherCommon.vsprops:
65         * WinLauncher/WinLauncherPostBuild.cmd: Added.
66         * WinLauncher/WinLauncherPreBuild.cmd: Added.
67
68 2010-11-29  Dan Bernstein  <mitz@apple.com>
69
70         GTK DumpRenderTree build fix after r72887.
71
72         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
73         (LayoutTestController::findString):
74
75 2010-11-29  Dan Bernstein  <mitz@apple.com>
76
77         Windows DumpRenderTree build fix after r72887.
78
79         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
80         (LayoutTestController::findString): Added empty implementation.
81
82 2010-11-29  Dan Bernstein  <mitz@apple.com>
83
84         Reviewed by Darin Adler.
85
86         DumpRenderTree changes for testing the text search API.
87         https://bugs.webkit.org/show_bug.cgi?id=50038
88
89         * DumpRenderTree/LayoutTestController.cpp:
90         (findStringCallback):
91         (LayoutTestController::staticFunctions):
92         * DumpRenderTree/LayoutTestController.h:
93         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
94         (LayoutTestController::findString):
95         * MiniBrowser/mac/BrowserWindowController.m:
96         (-[BrowserWindowController find:]):
97
98 2010-11-29  Johnny Ding  <jnd@chromium.org>
99
100         Unreviewed: Add myself to the list of Committers.
101
102         * Scripts/webkitpy/common/config/committers.py:
103
104 2010-11-29  Mark Rowe  <mrowe@apple.com>
105
106         Reviewed by Adele Peterson.
107
108         <rdar://problem/8694997> DumpRenderTree fails to build.
109
110         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
111
112 2010-11-29  Mark Rowe  <mrowe@apple.com>
113
114         Reviewed by Adele Peterson.
115
116         <rdar://problem/8694997> DumpRenderTree fails to build.
117
118         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
119         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
120         * DumpRenderTree/mac/PerlSupport/Makefile:
121
122 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
123
124         Reviewed by Martin Robinson.
125
126         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
127         https://bugs.webkit.org/show_bug.cgi?id=50154
128
129         Added missing checks to allAttributes().
130
131         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
132         (AccessibilityUIElement::allAttributes): Added missing checks.
133
134 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
135
136         Reviewed by Kenneth Rohde Christiansen.
137
138         [Qt] Allow pre-generation for package builds for WebKit2
139         https://bugs.webkit.org/show_bug.cgi?id=50139
140
141         Use a build variable for the generated directory path and set the
142         value based on CONFIG just like for WebKit1.
143
144         For non-package builds use a relative base path for the
145         genrated directory just like for WebKit1.
146
147         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
148         * WebKitTestRunner/qt/WebKitTestRunner.pro:
149
150 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
151
152         Reviewed by Kenneth Rohde Christiansen.
153
154         [Qt] Move some build logic from Qt to platform independent code
155         https://bugs.webkit.org/show_bug.cgi?id=50134
156
157         Create target directories inside generate-forwarding-headers.pl.
158
159         * Scripts/generate-forwarding-headers.pl:
160
161 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
162
163         Reviewed by Martin Robinson.
164
165         [GTK] Windowless plugins gets broken key input
166         https://bugs.webkit.org/show_bug.cgi?id=49927
167
168         Convert the XEvent::keycode to ASCII before printing it. Not
169         doing this was causing false positive in 
170         plugins/keyboard-events.html.
171
172         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
173         (keycode_to_char):
174         (webkit_test_plugin_handle_event):
175
176 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
177
178         Reviewed by Antonio Gomes.
179
180         [Qt] Html autofocus not working with QGraphicsWebView
181         https://bugs.webkit.org/show_bug.cgi?id=43169
182
183         Tell the scene to set the webview item as the currently
184         focused item. This makes the input field with autofocus get
185         focus as it should.
186
187         * QtTestBrowser/webview.cpp:
188         (WebViewGraphicsBased::WebViewGraphicsBased):
189
190 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
191
192         Reviewed by Tony Chang.
193
194         nrwt - clean up create_driver interface and print out the
195         command line used for DumpRenderTree/TestShell.
196
197         This patch adds a driver_cmd_line() call to the Port class in
198         order to retrive the command line to print it out (as part of
199         --print config).
200
201         In addition, this patch cleans up the Port.create_driver()
202         signature and the Driver constructor interface to take a worker
203         number and no longer require the image_path argument (Chromium's
204         drivers now synthesize the image_path from the worker number
205         internally).
206
207         https://bugs.webkit.org/show_bug.cgi?id=49934
208
209         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
210         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
211         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
212         * Scripts/webkitpy/layout_tests/port/base.py:
213         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
214         * Scripts/webkitpy/layout_tests/port/chromium.py:
215         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
216         * Scripts/webkitpy/layout_tests/port/dryrun.py:
217         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
218         * Scripts/webkitpy/layout_tests/port/test.py:
219         * Scripts/webkitpy/layout_tests/port/webkit.py:
220         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
221         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
222
223 2010-11-24  Ojan Vafai  <ojan@chromium.org>
224
225         Reviewed by Tony Chang.
226
227         [chromium] improve memory usage for test results server and store fewer runs
228         https://bugs.webkit.org/show_bug.cgi?id=50035
229
230         Store fewer runs and don't pass full files around when we only need bools.
231         Greatly improves error rates on test-results.appspot.com.
232
233         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
234         * TestResultServer/handlers/testfilehandler.py:
235         * TestResultServer/model/dashboardfile.py:
236         * TestResultServer/model/jsonresults.py:
237
238 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
239
240         Reviewed by Tony Chang.
241
242         This patch implements the first part of the manager side of the
243         Broker objects - it handles creating threads, waiting for them
244         to complete, and running a single-threaded loop as well.
245
246         https://bugs.webkit.org/show_bug.cgi?id=49779
247
248         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
249         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
250         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
251         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
252
253 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
254
255         Reviewed by David Levin.
256
257         DRT should not generate pixel output for text/plain tests
258         https://bugs.webkit.org/show_bug.cgi?id=50002
259         
260         Modify Mac, Windows and GTK DRT implementations to disable pixel output
261         when encountering a text/plain response (the Chromium one already does
262         this, and none of the other ports special-case text/plain output in
263         the first place).
264
265         * DumpRenderTree/gtk/DumpRenderTree.cpp:
266         (dump):
267         * DumpRenderTree/mac/DumpRenderTree.mm:
268         (dump):
269         * DumpRenderTree/win/DumpRenderTree.cpp:
270         (dump):
271
272 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
273
274         Unreviewed.
275
276         Add my other email address to committers.py.
277
278         * Scripts/webkitpy/common/config/committers.py:
279
280 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
281
282         Reviewed by Csaba Osztrogonác.
283
284         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
285         https://bugs.webkit.org/show_bug.cgi?id=49975
286
287         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
288         to enable the script to define it 0 in case of a minimal build.
289
290 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
291
292         Reviewed by Xan Lopez.
293
294         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
295         https://bugs.webkit.org/show_bug.cgi?id=49143
296
297         * DumpRenderTree/gtk/DumpRenderTree.cpp:
298         (createWebView): Call the new connectEditingCallbacks function.
299         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
300         (dumpNodePath):
301         (dumpRange):
302         (insertActionString):
303         (selectionAffinityString):
304         (shouldBeginEditing):
305         (shouldEndEditing):
306         (shouldInsertNode):
307         (shouldInsertText):
308         (shouldDeleteRange):
309         (shouldShowDeleteInterfaceForElement):
310         (shouldChangeSelectedRange):
311         (shouldApplyStyle):
312         (editingBegan):
313         (userChangedContents):
314         (editingEnded):
315         (selectionChanged):
316         (connectEditingCallbacks):
317         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
318         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
319
320 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
321
322         Reviewed by Andreas Kling.
323
324         [Qt] Make QtTestBrowser remember the selected user agent
325         https://bugs.webkit.org/show_bug.cgi?id=50021
326
327         Set user agent for a new page by using the old page's
328
329         * QtTestBrowser/mainwindow.cpp:
330         (MainWindow::setPage):
331
332 2010-11-24 Patrick Gansterer <paroga@webkit.org>
333
334         Reviewed by Csaba Osztrogonác.
335
336         Remove Bakefile build system files
337         https://bugs.webkit.org/show_bug.cgi?id=49983
338
339         r53757 only removed the content, but not the files.
340         This patch removes that empty files.
341
342         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
343         * wx/browser/browser.bkl: Removed.
344         * wx/build-wxwebkit: Removed.
345
346 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
347
348         Reviewed by Tony Chang.
349
350         This patch cleans up the logic used to shard tests into groups a
351         bit and adds the --worker-model flag to NRWT. The flag is only
352         used at the moment to control whether to run single-threaded or
353         not, but eventually will also allow toggling between threads and
354         processes.
355
356         Also add a minor cleanup with _test_is_slow(), which just
357         eliminates some repetition and gives slightly better encapsulation.
358
359         https://bugs.webkit.org/show_bug.cgi?id=49773
360
361         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
362         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
363
364 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
365
366         Reviewed by Tony Chang.
367
368         Rebaseline server: list current baselines and platforms
369         https://bugs.webkit.org/show_bug.cgi?id=49991
370         
371         List existing baselines (with Trac links) for tests.
372         
373         Add dropdowns for choosing with platform baselines to target (and what
374         to do with existing ones).
375
376         Also fix MockFileSystem.join to behave more like os.path.join (unit
377         test was ending up with two consecutive slashes in a layout test
378         path).        
379
380         * Scripts/webkitpy/common/system/filesystem_mock.py:
381         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
382         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
383         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
384         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
385         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
386         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
387         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
388
389 2010-11-23  Ojan Vafai  <ojan@chromium.org>
390
391         Reviewed by Tony Chang.
392
393         remove timeout argument to urlopen
394         https://bugs.webkit.org/show_bug.cgi?id=49995
395
396         Apparently the version of python we have on the bots doesn't accept a timeout argument.
397
398         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
399
400 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
401
402         Unreviewed, rolling out r72628.
403         http://trac.webkit.org/changeset/72628
404         https://bugs.webkit.org/show_bug.cgi?id=49994
405
406         This patch is causing layout-test failtures on GTK Linux
407         64-bit Debug (Requested by ctguil on #webkit).
408
409         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
410         (AccessibilityUIElement::AccessibilityUIElement):
411         (AccessibilityUIElement::parentElementCallback):
412         * DumpRenderTree/chromium/AccessibilityUIElement.h:
413         * DumpRenderTree/chromium/CppBoundClass.cpp:
414         * DumpRenderTree/chromium/CppBoundClass.h:
415
416 2010-11-22  Ojan Vafai  <ojan@chromium.org>
417
418         Reviewed by Tony Chang.
419
420         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
421         https://bugs.webkit.org/show_bug.cgi?id=49944
422
423         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
424
425 2010-11-23  Chris Guillory  <chris.guillory@google.com>
426
427         Reviewed by Dimitri Glazkov.
428
429         Include the FrameView widget of a RenderWidget in the accessibility tree.
430         https://bugs.webkit.org/show_bug.cgi?id=49106
431
432         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
433         (AccessibilityUIElement::AccessibilityUIElement):
434         (AccessibilityUIElement::parentElementCallback):
435         (AccessibilityUIElement::isEqualCallback):
436         * DumpRenderTree/chromium/AccessibilityUIElement.h:
437         * DumpRenderTree/chromium/CppBoundClass.cpp:
438         (CppBoundClass::getFromCppVariant):
439         * DumpRenderTree/chromium/CppBoundClass.h:
440
441 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
442
443         Reviewed by Kenneth Rohde Christiansen.
444
445         [EFL] Add tiled backing store to EWebLauncher
446         https://bugs.webkit.org/show_bug.cgi?id=45777
447
448         Allow EWebLauncher to choose between single and tiled backing store
449
450         * EWebLauncher/main.c:
451         (on_key_down):
452         (browserCreate):
453         (main):
454
455 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
456
457         Reviewed by Tor Arne Vestbø.
458
459         [Qt] Review the setUserPermission & friends API
460         https://bugs.webkit.org/show_bug.cgi?id=46810
461
462         Renamed requestPermissionFromUser to featurePermissionRequested
463         and cancelRequestsForPermission to featurePermissionRequestCanceled.
464
465         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
466         (WebCore::WebPage::WebPage):
467         * QtTestBrowser/webpage.cpp:
468         (WebPage::WebPage):
469         (WebPage::featurePermissionRequestCanceled):
470         * QtTestBrowser/webpage.h:
471
472 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
473
474         Reviewed by Tor Arne Vestbø.
475
476         [Qt] Review the setUserPermission & friends API
477         https://bugs.webkit.org/show_bug.cgi?id=46810
478
479         Rename setUserPermission to setFeaturePermission
480
481         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
482         (WebCore::WebPage::requestPermission):
483         (WebCore::WebPage::permissionSet):
484         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
485         (LayoutTestController::grantDesktopNotificationPermission):
486         * QtTestBrowser/webpage.cpp:
487         (WebPage::requestPermission):
488
489 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
490
491         Reviewed by Tor Arne Vestbø.
492
493         [Qt] Review the setUserPermission & friends API
494         https://bugs.webkit.org/show_bug.cgi?id=46810
495
496         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
497         and GeolocationPermissionDomain to Geolocation.
498
499         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
500         (WebCore::WebPage::WebPage):
501         (WebCore::WebPage::requestPermission):
502         (WebCore::WebPage::cancelPermission):
503         (WebCore::WebPage::permissionSet):
504         (WebCore::DumpRenderTree::geolocationPermissionSet):
505         * DumpRenderTree/qt/DumpRenderTreeQt.h:
506         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
507         (LayoutTestController::grantDesktopNotificationPermission):
508         * QtTestBrowser/webpage.cpp:
509         (WebPage::WebPage):
510         (WebPage::requestPermission):
511         (WebPage::cancelRequestsForPermission):
512         * QtTestBrowser/webpage.h:
513
514 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
515
516         Reviewed by Tor Arne Vestbø.
517
518         [Qt] Review the setUserPermission & friends API
519         https://bugs.webkit.org/show_bug.cgi?id=46810
520
521         Add a ByUser suffix to PermissionGranted/Denied. In the future
522         we can add PermissionGrantedByDefault.
523
524
525         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
526         (WebCore::WebPage::requestPermission):
527         (WebCore::WebPage::permissionSet):
528         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
529         (LayoutTestController::grantDesktopNotificationPermission):
530         * QtTestBrowser/webpage.cpp:
531         (WebPage::requestPermission):
532
533 2010-11-18  Satish Sampath  <satish@chromium.org>
534
535         Reviewed by Jeremy Orlow.
536
537         For speech input event, send an event object containing all the recognition results and metadata.
538         https://bugs.webkit.org/show_bug.cgi?id=49736
539
540         Updated DRT by renaming the mock result method on all platforms to the new signature.
541
542         * DumpRenderTree/LayoutTestController.cpp:
543         (addMockSpeechInputResultCallback):
544         (LayoutTestController::staticFunctions):
545         * DumpRenderTree/LayoutTestController.h:
546         * DumpRenderTree/chromium/LayoutTestController.cpp:
547         (LayoutTestController::LayoutTestController):
548         (LayoutTestController::addMockSpeechInputResult):
549         * DumpRenderTree/chromium/LayoutTestController.h:
550         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
551         (LayoutTestController::addMockSpeechInputResult):
552         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
553         (LayoutTestController::addMockSpeechInputResult):
554         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
555         (LayoutTestController::addMockSpeechInputResult):
556         * DumpRenderTree/qt/LayoutTestControllerQt.h:
557         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
558         (LayoutTestController::addMockSpeechInputResult):
559         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
560         (LayoutTestController::addMockSpeechInputResult):
561
562 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
563
564         Reviewed by Tony Chang.
565
566         Fix some spacing issues with log messages with
567         new-run-webkit-tests --verbose.
568
569         https://bugs.webkit.org/show_bug.cgi?id=49936
570
571         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
572
573 2010-11-22  Ojan Vafai  <ojan@chromium.org>
574
575         Reviewed by Adam Barth.
576
577         update scm to work with different remote branches
578         https://bugs.webkit.org/show_bug.cgi?id=49949
579
580         This works if there are multiple svn tracking branches
581         and/or if the tracking branch is refs/remots/origin/master
582         instead of refs/remotes/trunk which is the direction we're trying
583         to head since that makes fetches faster.
584
585         * Scripts/webkitpy/common/checkout/scm.py:
586         * Scripts/webkitpy/common/checkout/scm_unittest.py:
587
588 2010-11-22  Hayato Ito  <hayato@chromium.org>
589
590         Reviewed by Shinichiro Hamaji.
591
592         Ignore reference files which will be used by reftests when collecting
593         test cases.
594         https://bugs.webkit.org/show_bug.cgi?id=49835
595
596         * Scripts/webkitpy/layout_tests/port/test_files.py:
597         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
598
599 2010-11-22  Adam Roben  <aroben@apple.com>
600
601         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
602
603         Apple's Windows build allows placing header files and import libraries for WebKit's
604         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
605         $WebKitLibrariesDir environment variable. This is both required for production builds and
606         convenient for Apple-internal developer builds. Apple's production builds also require that
607         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
608         builds, the files are copied into that directory tree by the
609         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
610         copying is done by
611         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
612
613         This .vsprops copying is problematic in one very important case: when a developer updates
614         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
615         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
616         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
617         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
618         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
619         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
620
621         To fix this, we now use normal relative paths to access the .vsprops files in the source
622         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
623         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
624         unset, so the normal relative paths are used to read the .vsprops files out of the source
625         tree directly. In production builds, this environment variable is set to a fake directory
626         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
627         is resolved.
628         
629         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
630
631         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
632
633         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
634         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
635         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
636         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
637         FeatureDefines.vsprops becomes:
638
639         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
640
641         which resolves to:
642
643         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
644
645         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
646         actually exist since they are matched by an equal number of ".." path components.)
647
648         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
649         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
650
651         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
652         updated
653
654         Reviewed by Dave Hyatt.
655
656         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
657         * DumpRenderTree/win/DumpRenderTree.vcproj:
658         * DumpRenderTree/win/ImageDiff.vcproj:
659         * FindSafari/FindSafari.vcproj:
660         * MiniBrowser/MiniBrowser.vcproj:
661         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
662         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
663         * WebKitAPITest/WebKitAPITest.vcproj:
664         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
665         * WebKitTestRunner/win/InjectedBundle.vcproj:
666         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
667         * WinLauncher/WinLauncher.vcproj:
668         * record-memory-win/record-memory-win.vcproj:
669         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
670         files.
671
672 2010-11-22  Adam Roben  <aroben@apple.com>
673
674         Make it possible to run tests on Windows without Visual Studio or VC++
675         Express installed
676
677         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
678         are not installed. But this function doesn't need to be called when we
679         already have a build available and are just trying to run the tests.
680
681         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
682         because Visual Studio/VC++ Express aren't installed
683
684         Reviewed by Dave Hyatt.
685
686         * Scripts/webkitdirs.pm:
687         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
688         it is not needed by this function. Also added a FIXME.
689
690         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
691         relying on determineConfigurationForVisualStudio doing it.
692
693 2010-11-19  Hayato Ito  <hayato@chromium.org>
694
695         Reviewed by Shinichiro Hamaji.
696
697         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
698
699         https://bugs.webkit.org/show_bug.cgi?id=49812
700
701         * Scripts/webkitpy/layout_tests/driver_test.py:
702         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
703         * Scripts/webkitpy/layout_tests/port/base.py:
704         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
705         * Scripts/webkitpy/layout_tests/port/chromium.py:
706         * Scripts/webkitpy/layout_tests/port/dryrun.py:
707         * Scripts/webkitpy/layout_tests/port/test.py:
708         * Scripts/webkitpy/layout_tests/port/webkit.py:
709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
710         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
711
712 2010-11-22  Hayato Ito  <hayato@chromium.org>
713
714         Reviewed by Tony Chang.
715
716         [NRWT] Retry a few times in reading a png image to avoid a race condition.
717
718         https://bugs.webkit.org/show_bug.cgi?id=49924
719
720         * Scripts/webkitpy/layout_tests/port/chromium.py:
721
722 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
723
724         Reviewed by Kenneth Rohde Christiansen.
725
726         Fix EWebLauncher zoom discretization
727         https://bugs.webkit.org/show_bug.cgi?id=49810
728
729         * EWebLauncher/main.c:
730         (nearest_zoom_level_get):
731         (zoom_level_set):
732         (on_load_finished):
733         (on_key_down):
734
735 2010-11-21  Sam Weinig  <sam@webkit.org>
736
737         Rubber-stamped by Dan Bernstein.
738
739         Fix ~300 WebKit2 tests by enabling developer extras preference.
740
741         * WebKitTestRunner/TestController.cpp:
742         (WTR::TestController::resetStateToConsistentValues):
743
744 2010-11-21  Sam Weinig  <sam@webkit.org>
745
746         Reviewed by Dan Bernstein.
747
748         Textareas should be resizable by default
749         https://bugs.webkit.org/show_bug.cgi?id=49892
750
751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
752         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
753         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
754         Add preferences test.
755
756 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
757
758         Reviewed by Tony Chang.
759
760         Rebaseline server: checksum-only differences and prefetching
761         https://bugs.webkit.org/show_bug.cgi?id=49841
762         
763         Add support for image test results where the only difference is in the
764         checksum.
765         
766         Add prefetching of the image results from the next test.
767         
768         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
769         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
770         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
771
772 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
773
774         Reviewed by Tony Chang.
775
776         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
777
778         Add the 'worker number' and 'worker name' concepts to the 
779         TestShellThread objects, and move test_types and test_args from
780         the TestRunner to the TestShellThread.
781
782         https://bugs.webkit.org/show_bug.cgi?id=49768
783
784         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
785         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
786
787 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
788
789         Reviewed by Ojan Vafai.
790
791         Do some minor cleanup and bug fixing.
792
793         https://bugs.webkit.org/show_bug.cgi?id=49777
794
795         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
796         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
797
798 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
799
800         Reviewed by Ojan Vafai.
801
802         nrwt - config.build_directory() is busted
803
804         Fixes a typo that was causing us to usually return the top level
805         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
806         bug was hidden by test stubs that were too simplistic :(.
807
808         https://bugs.webkit.org/show_bug.cgi?id=49815
809
810         * Scripts/webkitpy/common/system/executive_mock.py:
811         * Scripts/webkitpy/layout_tests/port/config.py:
812         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
813
814 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
815
816         Reviewed by Adam Roben.
817
818         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
819         https://bugs.webkit.org/show_bug.cgi?id=49819
820
821         * DumpRenderTree/DumpRenderTree.sln:
822         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
823         * DumpRenderTree/win/DumpRenderTree.vcproj:
824         * DumpRenderTree/win/ImageDiff.vcproj:
825         * FindSafari/FindSafari.vcproj:
826         * MiniBrowser/MiniBrowser.vcproj:
827         * TestWebKitAPI/win/TestWebKitAPI.sln:
828         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
829         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
830         * WebKitAPITest/WebKitAPITest.vcproj:
831         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
832         * WebKitTestRunner/win/InjectedBundle.vcproj:
833         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
834         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
835         * WinLauncher/WinLauncher.vcproj:
836         * record-memory-win/record-memory-win.vcproj:
837
838 2010-11-19  Adam Roben  <aroben@apple.com>
839
840         Add some more Windows slaves
841
842         This is probably more than we will be using in the immediate future,
843         but having some extra slave names makes experimenting with different
844         configurations easier.
845
846         Reviewed by Jon Honeycutt.
847
848         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
849         Windows slaves and distributed them among the three different Test
850         builders.
851
852 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
853
854         Reviewed by Ojan Vafai.
855
856         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
857         https://bugs.webkit.org/show_bug.cgi?id=49702
858
859         Re-landing r72357 with a test fix.
860
861         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
862         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
863         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
864
865 2010-11-19  Avi Drissman  <avi@google.com>
866
867         Reviewed by Antonio Gomes.
868
869         Complete support for Unix editing mode
870         https://bugs.webkit.org/show_bug.cgi?id=49757
871
872         * DumpRenderTree/LayoutTestController.cpp:
873         (setEditingBehaviorCallback):
874         * DumpRenderTree/chromium/LayoutTestController.cpp:
875         (LayoutTestController::setEditingBehavior):
876
877 2010-11-19  Adam Roben  <aroben@apple.com>
878
879         Fix run-javascriptcore-tests when there's a space in the path to
880         testapi
881
882         Reviewed by Sam Weinig.
883
884         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
885         system() to force it to interpret spaces in the path correctly.
886
887 2010-11-19  Adam Roben  <aroben@apple.com>
888
889         Update scripts for .exe name changes after r72327
890
891         As of r72327, the "_debug" suffix is only used in Debug_All builds.
892
893         Reviewed by Sam Weinig.
894
895         * Scripts/run-javascriptcore-tests:
896         (testapiPath):
897
898         * Scripts/sunspider-compare-results:
899         (pathToBuiltJSC):
900
901         * Scripts/webkitdirs.pm:
902         (jscPath):
903         (safariPath):
904
905 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
906
907         Reviewed by Darin Adler.
908
909         Normalize Cairo/CFLite project/solution configuration names
910         https://bugs.webkit.org/show_bug.cgi?id=49818
911
912         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
913         * DumpRenderTree/win/DumpRenderTree.vcproj:
914         * DumpRenderTree/win/ImageDiff.vcproj:
915         * MiniBrowser/MiniBrowser.vcproj:
916         * TestWebKitAPI/win/TestWebKitAPI.sln:
917         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
918         * WebKitAPITest/WebKitAPITest.vcproj:
919         * WebKitTestRunner/win/InjectedBundle.vcproj:
920         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
921         * WinLauncher/WinLauncher.vcproj:
922         * Scripts/webkitdirs.pm: Updated cairo build configs.
923
924 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
925
926         Reviewed by Adam Roben.
927
928         Windows vcproj configuration names should be normalized across projects
929         https://bugs.webkit.org/show_bug.cgi?id=49776
930
931         * DumpRenderTree/DumpRenderTree.sln:
932         * FindSafari/FindSafari.vcproj:
933         * TestWebKitAPI/win/TestWebKitAPI.sln:
934         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
935         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
936         * WebKitAPITest/WebKitAPITest.vcproj:
937         * WebKitAPITest/WebKitAPITestCommon.vsprops:
938         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
939         * WebKitTestRunner/WebKitTestRunner.sln:
940         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
941         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
942         * record-memory-win/record-memory-win.vcproj:
943
944 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
945
946         Build fix - as per DRT-mac, always enabled developer extras,
947         in win/qt/gtk DRT.
948
949         This is necessary to enable rich exception messages to be generated
950         following https://bugs.webkit.org/show_bug.cgi?id=49708.
951
952         * DumpRenderTree/gtk/DumpRenderTree.cpp:
953         (shouldEnableDeveloperExtras):
954         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
955         (WebCore::shouldEnableDeveloperExtras):
956         * DumpRenderTree/win/DumpRenderTree.cpp:
957         (shouldEnableDeveloperExtras):
958
959 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
960
961         Unreviewed, rolling out r72357.
962         http://trac.webkit.org/changeset/72357
963         https://bugs.webkit.org/show_bug.cgi?id=49784
964
965         It broke test-webkitpy tests since the patch didn't have the
966         corresponding test update (Requested by kinuko on #webkit).
967
968         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
969         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
970
971 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
972
973         Reviewed by Tony Chang.
974
975         Rebaseline server: add rebaseline queue
976         https://bugs.webkit.org/show_bug.cgi?id=49763
977         
978         Add a UI queue (a multi-item <select>) where tests to be baselined
979         can be enqueued (also supports basic removal). A queue is used instead
980         of immediately doing rebaselines since SCM operations can take a while.
981         It's better to go through lots of tests quickly to mark them as
982         needing rebaselining and then batch the SCM operations.
983         
984         Also adds a simple log where results can be displayed.
985
986         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
987         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
988         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
989         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
990         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
991         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
992
993 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
994
995         Reviewed by Oliver Hunt.
996
997         Bug 49708 - Stop recompiling functions to regenerate exception info.
998
999         Instead only hold info as necessary – keep divot info is the inspector
1000         is enabled, line number info is debugging or profiling, and handler
1001         info for functions with try/catch.
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (shouldEnableDeveloperExtras):
1005             - always enable the developer tools from DRT, to ensure we
1006               produce rich error messages on JavaScript exceptions.
1007
1008 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1009
1010         Reviewed by Ojan Vafai.
1011
1012         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1013         https://bugs.webkit.org/show_bug.cgi?id=49702
1014
1015         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1016         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1017
1018 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1019
1020         Reviewed by Tony Chang.
1021
1022         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1023
1024         Create the first version of the 'message_broker' package. This
1025         class will encapsulate all of the threading/multiprocessing and
1026         message-sending details for the communication between the
1027         'manager' object and the 'worker' objects. For the moment, it
1028         just holds some routines and tests for logging thread stacks.
1029
1030         There should be no functional changes in this patch, just moving stuff
1031         around.
1032
1033         https://bugs.webkit.org/show_bug.cgi?id=49707
1034
1035         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1036         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1037         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1038         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1039         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1040         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1041
1042 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1043
1044         Reviewed by Adam Roben.
1045
1046         Remove leftover Windows Debug_Internal configurations
1047         https://bugs.webkit.org/show_bug.cgi?id=49758
1048
1049         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1050         * DumpRenderTree/win/DumpRenderTree.vcproj:
1051         * DumpRenderTree/win/ImageDiff.vcproj:
1052         * MiniBrowser/MiniBrowser.vcproj:
1053         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1054         * WebKitAPITest/WebKitAPITest.vcproj:
1055         * WebKitTestRunner/win/InjectedBundle.vcproj:
1056         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1057         * WinLauncher/WinLauncher.vcproj:
1058
1059 2010-11-18  Adam Roben  <aroben@apple.com>
1060
1061         Add three new Windows XP build slaves
1062
1063         Reviewed by Steve Falkenburg.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1066         new slaves, and added them to the Windows XP Debug (Tests) builder.
1067
1068 2010-11-18  Daniel Bates  <dbates@rim.com>
1069
1070         Reviewed by Adam Roben.
1071
1072         update-webkit-support-libs should fall back to existing
1073         WebKitSupportLibrary version if there is no internet connectivity
1074         https://bugs.webkit.org/show_bug.cgi?id=49503
1075
1076         Fall back to existing support libraries (if present) when there is
1077         no internet connection.
1078
1079         Currently, update-webkit-support-libs dies with an "out-of-date"
1080         error when there is no internet connection because it cannot
1081         retrieve versioning information from developer.apple.com. Because
1082         update-webkit-support-libs fails, build-webkit fails. Instead,
1083         if there is no internet connection and the support libraries are
1084         present then we should warn the user and exit() with success so
1085         that build-webkit can work without an internet connection.
1086
1087         * Scripts/update-webkit-support-libs:
1088
1089 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1090
1091         Reviewed by Adam Roben.
1092
1093         Debug_Internal Windows configuration is unnecessary, should be removed
1094         https://bugs.webkit.org/show_bug.cgi?id=49753
1095
1096         * DumpRenderTree/win/DumpRenderTree.cpp:
1097         * MiniBrowser/win/stdafx.h:
1098         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1099         * WebKitTestRunner/win/TestControllerWin.cpp:
1100
1101 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1102
1103         Reviewed by Adam Roben.
1104
1105         Clean up vcproj errors
1106         https://bugs.webkit.org/show_bug.cgi?id=49741
1107
1108         * MiniBrowser/MiniBrowser.vcproj:
1109         * WebKitAPITest/WebKitAPITest.vcproj:
1110         * WebKitTestRunner/win/InjectedBundle.vcproj:
1111         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1112
1113 2010-11-18  Hayato Ito  <hayato@chromium.org>
1114
1115         Reviewed by Shinichiro Hamaji.
1116
1117         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1118         which is caused by r72249.
1119
1120         https://bugs.webkit.org/show_bug.cgi?id=49751
1121
1122         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1123
1124 2010-11-18  Adam Roben  <aroben@apple.com>
1125
1126         Implement layoutTestController.waitForPolicyDelegate on Windows
1127
1128         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1129
1130         Reviewed by Simon Fraser.
1131
1132         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1133         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1134         code from LayoutTestControllerMac.mm.
1135
1136 2010-11-18  Hayato Ito  <hayato@chromium.org>
1137
1138         Reviewed by Shinichiro Hamaji.
1139
1140         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1141
1142         https://bugs.webkit.org/show_bug.cgi?id=49740
1143
1144         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1145
1146 2010-11-18  Tony Chang  <tony@chromium.org>
1147
1148         Reviewed by Adam Barth.
1149
1150         run platform/chromium/plugins/refcount-leaks.html on all platforms
1151         https://bugs.webkit.org/show_bug.cgi?id=49485
1152
1153         Add PluginObject.testObjectCount which returns the number of allocated
1154         TestObjects. Add PluginObject.testCreateTestObject which allocates
1155         and returns a TestObject.
1156
1157         Add TestObject.refCount which returns the number of refs on the
1158         TestObject.
1159
1160         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1161         (pluginGetProperty):
1162         (pluginInvoke):
1163         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1164         (getTestObjectCount):
1165         (testAllocate):
1166         (testDeallocate):
1167         (testGetProperty):
1168         (testScriptObjectInvoke): Release a ref to a plugin object that was
1169             previously leaked.
1170         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1171
1172 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1173
1174         Reviewed by Adam Roben.
1175
1176         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1177         https://bugs.webkit.org/show_bug.cgi?id=49711
1178
1179         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1180         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1181         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1182         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1183         * record-memory-win/record-memory-win-common.vsprops: Added.
1184         * record-memory-win/record-memory-win.vcproj:
1185
1186 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1187
1188         Reviewed by Csaba Osztrogonác.
1189
1190         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1191
1192         * MiniBrowser/qt/BrowserWindow.cpp:
1193         (BrowserWindow::updateUserAgentList):
1194
1195 2010-11-17  Adam Roben  <aroben@apple.com>
1196
1197         Don't trigger Windows builds when chromium-win test results change
1198
1199         Reviewed by Mark Rowe.
1200
1201         * Scripts/webkitpy/common/config/build.py:
1202         (_should_file_trigger_build): Changed the regular expression used to
1203         search for directory names to only consider full directory names,
1204         rather than matching directory names where the string we care about is
1205         a suffix of the name.
1206
1207         * Scripts/webkitpy/common/config/build_unittest.py:
1208         (ShouldBuildTest): Added a test.
1209
1210 2010-11-17  Hayato Ito  <hayato@chromium.org>
1211
1212         Reviewed by Shinichiro Hamaji.
1213
1214         Remove a uri member from TestInput class.
1215
1216         https://bugs.webkit.org/show_bug.cgi?id=49691
1217
1218         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1219         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1220
1221 2010-11-17  Adam Roben  <aroben@apple.com>
1222
1223         Move FindSafari's settings into a vsprops file
1224
1225         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1226
1227         Reviewed by Steve Falkenburg.
1228
1229         * FindSafari/FindSafari.vcproj:
1230         * FindSafari/FindSafariCommon.vsprops: Added.
1231
1232 2010-11-17  Adam Roben  <aroben@apple.com>
1233
1234         Use a minimum font size of 0 in DRT on Windows
1235
1236         This is the Windows equivalent of r72164.
1237
1238         Rubber-stamped by Dave Hyatt.
1239
1240         * DumpRenderTree/win/DumpRenderTree.cpp:
1241         (resetDefaultsToConsistentValues):
1242
1243 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1244
1245         Reviewed by Andreas Kling.
1246
1247         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1248         https://bugs.webkit.org/show_bug.cgi?id=49639
1249
1250         * Scripts/webkitpy/common/checkout/scm.py:
1251
1252 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1253
1254         Reviewed by Tony Chang.
1255
1256         Rebaseline server: add loupe for image diffs
1257         https://bugs.webkit.org/show_bug.cgi?id=49692
1258         
1259         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1260         enlarged area of the expected, actual and diff images side by side.
1261
1262         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1263         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1264         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1265         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1266
1267 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1268
1269         Reviewed by Adam Roben.
1270
1271         WebKitLauncherWin should use vsprops for shared build settings
1272         https://bugs.webkit.org/show_bug.cgi?id=49696
1273
1274         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1275         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1276
1277 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1278
1279         Reviewed by Adam Roben.
1280
1281         WinLauncher should use vsprops for shared build settings
1282         https://bugs.webkit.org/show_bug.cgi?id=49695
1283
1284         * WinLauncher/WinLauncher.cpp:
1285         (_tWinMain):
1286         (PrintView):
1287         (WndProc):
1288         (MyEditProc):
1289         * WinLauncher/WinLauncher.vcproj:
1290         * WinLauncher/WinLauncherCommon.vsprops: Added.
1291
1292 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1293
1294         Delete unused file unintentionally added in last change.
1295
1296         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1297
1298 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1299
1300         Reviewed by Adam Roben.
1301
1302         DumpRenderTree on Windows should use a vsprops file for shared project settings
1303         https://bugs.webkit.org/show_bug.cgi?id=49690
1304
1305         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1306         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1307         * DumpRenderTree/win/DumpRenderTree.vcproj:
1308         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1309         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1310         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1311         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1312         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1313         * DumpRenderTree/win/ImageDiff.vcproj:
1314         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1315
1316 2010-11-17  Hayato Ito  <hayato@chromium.org>
1317
1318         Refactor TestTypeBase.compare_output().
1319
1320         Introduce a TestOutput class and update compare_output() of each test
1321         types so that they can take both actual and expected TestOutput objects.
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=49431
1324
1325         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1326         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1327         * Scripts/webkitpy/layout_tests/port/base.py:
1328         * Scripts/webkitpy/layout_tests/port/chromium.py:
1329         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1330         * Scripts/webkitpy/layout_tests/port/test.py:
1331         * Scripts/webkitpy/layout_tests/port/webkit.py:
1332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1333         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1334         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1335         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1336
1337 2010-11-17  Adam Roben  <aroben@apple.com>
1338
1339         Make each Windows Test builder use the same OS for all its slaves
1340
1341         Currently each WebKit1 Windows Test builder has one Windows XP slave
1342         and one Windows 7 slave. Having different OSes in a single builder
1343         meant that the builders would alternate between red and green when
1344         there were OS-specific failures.
1345
1346         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1347         between red and green because of multiple OS versions
1348
1349         Reviewed by Mark Rowe.
1350
1351         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1352         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1353         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1354         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1355         builders for the two WebKit1 builders so that they would all use the
1356         appropriate OS.
1357
1358 2010-11-17  James Robinson  <jamesr@chromium.org>
1359
1360         Reviewed by Dan Bernstein.
1361
1362         [chromium] Set minimum font size to 0 for DRT
1363         https://bugs.webkit.org/show_bug.cgi?id=49677
1364
1365         Followup for http://trac.webkit.org/changeset/72141.
1366
1367         Test: http/tests/misc/acid3.html
1368
1369         * DumpRenderTree/chromium/WebPreferences.cpp:
1370         (WebPreferences::reset):
1371
1372 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1373
1374         Unreviewed build fix.
1375
1376         [Qt] Add missing file I forgot in r72220.
1377
1378         * MiniBrowser/MiniBrowser.qrc: Added.
1379
1380 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1381
1382         Reviewed by Andreas Kling.
1383
1384         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1385         https://bugs.webkit.org/show_bug.cgi?id=49627
1386
1387         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1388
1389         * MiniBrowser/MiniBrowser.qrc: Added.
1390         Add it here to prevent qmake from detecting it
1391         since it needs to be copied to the build directory.
1392         * MiniBrowser/qt/BrowserWindow.cpp:
1393         (BrowserWindow::BrowserWindow):
1394         (BrowserWindow::updateUserAgentList):
1395         (BrowserWindow::showUserAgentDialog):
1396         * MiniBrowser/qt/BrowserWindow.h:
1397         * MiniBrowser/qt/MiniBrowser.pro:
1398
1399 2010-11-17  Adam Roben  <aroben@apple.com>
1400
1401         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1402
1403         We use that file on Windows!
1404
1405         Fixes <http://webkit.org/b/49643> Changes to
1406         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1407
1408         Reviewed by Steve Falkenburg.
1409
1410         * Scripts/webkitpy/common/config/build.py:
1411         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1412         trigger builds on SnowLeopard and Windows.
1413
1414         * Scripts/webkitpy/common/config/build_unittest.py:
1415         (ShouldBuildTest.test_should_build): Added a test.
1416
1417 2010-11-17  Satish Sampath  <satish@chromium.org>
1418
1419         Reviewed by Jeremy Orlow.
1420
1421         Clear the speech input mock explicitly before each test.
1422         https://bugs.webkit.org/show_bug.cgi?id=49660
1423
1424         * DumpRenderTree/chromium/LayoutTestController.cpp:
1425         (LayoutTestController::setMockSpeechInputResult):
1426         * DumpRenderTree/chromium/LayoutTestController.h:
1427         * DumpRenderTree/chromium/WebViewHost.cpp:
1428         (WebViewHost::speechInputController):
1429         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1430         * DumpRenderTree/chromium/WebViewHost.h:
1431         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1432
1433 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1434
1435         Unreviewed, specify IRC nickname in committers.py.
1436
1437         * Scripts/webkitpy/common/config/committers.py:
1438
1439 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1440
1441         Reviewed by Tony Chang.
1442
1443         [NRWT] Make http locking similar to perl implementation
1444         https://bugs.webkit.org/show_bug.cgi?id=49187
1445
1446         * Scripts/webkitpy/common/system/file_lock.py: Added.
1447         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1448         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1449
1450 2010-11-17  MORITA Hajime  <morrita@google.com>
1451
1452         Reviewed by Kent Tamura.
1453
1454         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1455         https://bugs.webkit.org/show_bug.cgi?id=49366
1456
1457         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1458           according to the spellchecker suggestion
1459         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1460
1461         test_expectations.txt will be changed after this change is ported to test_shell.
1462         
1463         * DumpRenderTree/chromium/EventSender.cpp:
1464         (makeMenuItemStringsFor):
1465         (EventSender::contextClick):
1466         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1467         (MockSpellCheck::fillSuggestionList):
1468         (MockSpellCheck::initializeIfNeeded):
1469         * DumpRenderTree/chromium/MockSpellCheck.h:
1470         * DumpRenderTree/chromium/WebViewHost.cpp:
1471         (WebViewHost::mockSpellCheck):
1472         * DumpRenderTree/chromium/WebViewHost.h:
1473
1474 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1475
1476         Reviewed by Sam Weinig.
1477
1478         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1479         since the bots have 1 stuck in their plist otherwise.
1480
1481         * DumpRenderTree/mac/DumpRenderTree.mm:
1482         (resetDefaultsToConsistentValues):
1483
1484 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1485
1486         Reviewed by Tony Chang.
1487
1488         Rebaseline server: compute diffs client-side
1489         https://bugs.webkit.org/show_bug.cgi?id=49640
1490         
1491         The image diff output from the DRT is pretty bad on some ports (at
1492         least the Mac one), so it's better to compute diffs on the client by
1493         using <canvas>.
1494
1495         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1496         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1497         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1498
1499 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1500
1501         Reviewed by Tony Chang.
1502
1503         Rebaseline server: display test results
1504         https://bugs.webkit.org/show_bug.cgi?id=49626
1505         
1506         Adds basic result display to the rebaseline server. On the Python side
1507         this involves:
1508         - Parsing the unexpected_results.json into a dictionary.
1509         - Serving it as JSON under /results.json.
1510         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1511         but I'll need to have access to the parsed results on the Python side
1512         for follow-up changes).
1513         
1514         On the web UI side this adds:
1515         - Markup for display image and text results (expected, actual, diff),
1516           and JS for populating it.
1517         - Markup for breaking down test results by failure type and directory,
1518           and JS for populating it.
1519
1520         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1521         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1522         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1523         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
1524         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1525
1526 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1527
1528         Reviewed by Ojan Vafai.
1529
1530         See Chromium issue http://codereview.chromium.org/5133001/ - we
1531         are modifying the build bots to pass in the builder name with
1532         the "GPU" string appended instead of appending it in the code.
1533
1534         https://bugs.webkit.org/show_bug.cgi?id=49636
1535
1536         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1537
1538 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
1539
1540         Reviewed by Adam Roben.
1541
1542         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
1543         https://bugs.webkit.org/show_bug.cgi?id=49632
1544
1545         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1546         * DumpRenderTree/win/DumpRenderTree.vcproj:
1547         * DumpRenderTree/win/ImageDiff.vcproj:
1548         * MiniBrowser/MiniBrowser.vcproj:
1549         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1550         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1551         * WebKitTestRunner/win/InjectedBundle.vcproj:
1552         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1553         * WinLauncher/WinLauncher.vcproj:
1554         * record-memory-win/record-memory-win.vcproj:
1555
1556 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1557
1558         Reviewed by Ojan Vafai.
1559
1560         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
1561
1562         Rename the TestInfo class to TestInput to be clearer about its
1563         function, and move the checksum-reading code into dump_render_tree_thread
1564         to avoid cross-thread access.
1565
1566         https://bugs.webkit.org/show_bug.cgi?id=49573
1567
1568         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1569         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1570         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1571
1572 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1573
1574         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
1575
1576         * DumpRenderTree/mac/DumpRenderTree.mm:
1577         (resetDefaultsToConsistentValues):
1578
1579 2010-11-16  Stephanie Lewis  <slewis@apple.com>
1580
1581         Reviewed by Geoff Garen.
1582
1583         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1584
1585         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
1586         for every WebView, and the WebKit API doesn't support that ownership model.
1587
1588         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
1589
1590         * DumpRenderTree/mac/DumpRenderTree.mm:
1591         (createWebViewAndOffscreenWindow):
1592         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1593         (LayoutTestController::setMockDeviceOrientation):
1594
1595 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1596
1597         Reviewed by Ojan Vafai.
1598
1599         new-run-webkit-tests: log the process id in --verbose mode
1600
1601         As part of the switch to multi-process mode, we should log the
1602         process id when running w/ --verbose.
1603
1604         https://bugs.webkit.org/show_bug.cgi?id=49571
1605
1606         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1607
1608 2010-11-16  Adam Roben  <aroben@apple.com>
1609
1610         Only trigger Windows builds when files that we actually use on Windows
1611         are changed
1612
1613         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
1614         It uses the new webkitpy.common.config.build module to determine
1615         whether a particular change should trigger a build on a particular
1616         platform. The Windows builders have been switched to use a
1617         PlatformSpecificScheduler.
1618
1619         The logic to determine whether or not a particular change should
1620         trigger a build on a given platform has only been implemented/tested
1621         for Windows. I tried to make it easy to add more platforms in the
1622         future, but I don't have enough familiarity with all platforms to be
1623         able to implement it for them.
1624
1625         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
1626         lots irrelevant changes (e.g., rebaselining Chromium test results)
1627
1628         Reviewed by Eric Seidel.
1629
1630         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
1631         PlatformSpecificScheduler for the Windows builders.
1632
1633         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1634         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
1635         up a ChangeFilter that filters to our branch and will call through to
1636         our filter method, and calls up to our base class.
1637         (PlatformSpecificScheduler.filter): Calls through to
1638         build.should_build to find out whether we should trigger a build for
1639         this change.
1640
1641         * Scripts/webkitpy/common/net/build.py: Added.
1642         (_should_file_trigger_build): Uses a set of directories and regexp
1643         patterns to determine whether the given file should trigger a build on
1644         the given platform. As mentioned earlier, this has only been
1645         implemented for Windows, though I did try to make some guesses about
1646         other platforms.
1647         (should_build): Returns true if any of the files should trigger a
1648         build on the given platform.
1649
1650         * Scripts/webkitpy/common/net/build_unittest.py: Added.
1651         (ShouldBuildTest.test_should_build): Does some basic testing to make
1652         sure we're triggering builds for the right files. It only tests
1653         Windows for now, though I tried to make some guesses about other
1654         platforms.
1655
1656 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1657
1658         Reviewed by Andreas Kling.
1659
1660         [Qt] Remove synchronous QWebPage::checkPermissions signal
1661         https://bugs.webkit.org/show_bug.cgi?id=46810
1662
1663         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1664         (WebCore::WebPage::WebPage):
1665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1666         (LayoutTestController::grantDesktopNotificationPermission): When granting
1667         permission, grant it directly on the QWebPage/Frame, that will remember it.
1668         * QtTestBrowser/webpage.cpp:
1669         (WebPage::WebPage):
1670         * QtTestBrowser/webpage.h:
1671
1672
1673 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
1674
1675         Reviewed by Csaba Osztrogonác.
1676
1677         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
1678
1679         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1680         (LayoutTestController::reset):
1681         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1682         (LayoutTestController::isPrinting):
1683         (LayoutTestController::setPrinting):
1684
1685 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
1686
1687         Reviewed by Andreas Kling.
1688
1689         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
1690         https://bugs.webkit.org/show_bug.cgi?id=49587
1691
1692         * MiniBrowser/qt/BrowserView.cpp:
1693         (BrowserView::BrowserView): Added BackingStoreType
1694         argument to ctor. Propagating it to the QGraphicsWKView.
1695         * MiniBrowser/qt/BrowserView.h:
1696         * MiniBrowser/qt/BrowserWindow.cpp:
1697         (BrowserWindow::BrowserWindow):
1698         (BrowserWindow::newWindow): Create the new BrowserWindow
1699         with the same BackingStoreType that this instance has.
1700         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
1701         * MiniBrowser/qt/main.cpp:
1702         (main): Use tiled backing store if got -tiled command line argument.
1703         Avoid redundant copy of command line args.
1704
1705 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
1706
1707         Reviewed by Jeremy Orlow.
1708
1709         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
1710         https://bugs.webkit.org/show_bug.cgi?id=48506
1711
1712         This ensures that there is one mock per page WebView / WebViewHost. This is a
1713         design constraint of the DeviceOrientationClientMock because the m_controller
1714         field can only store a pointer to a single instance of the corresponding
1715         DeviceOrientationController.
1716
1717         Test: fast/dom/DeviceOrientation/no-page-cache.html
1718
1719         * DumpRenderTree/chromium/LayoutTestController.cpp:
1720         (LayoutTestController::setMockDeviceOrientation):
1721         (LayoutTestController::deviceOrientationClientMock):
1722         * DumpRenderTree/chromium/LayoutTestController.h:
1723         * DumpRenderTree/chromium/WebViewHost.cpp:
1724         (WebViewHost::deviceOrientationClientMock):
1725         (WebViewHost::deviceOrientationClient):
1726         (WebViewHost::reset):
1727         * DumpRenderTree/chromium/WebViewHost.h:
1728
1729 2010-11-15  Andras Becsi  <abecsi@webkit.org>
1730
1731         Reviewed by Andreas Kling.
1732
1733         [Qt][WK2] Avoid polling in WebKitTestRunner.
1734         https://bugs.webkit.org/show_bug.cgi?id=49542
1735
1736         Make the WK2 testing session about 10-15% faster and decrease random flakiness
1737         resulting from timing skew by removing the millisecond polling from TestControllerQt.
1738
1739         * WebKitTestRunner/TestController.cpp:
1740         (WTR::TestController::didFinishLoadForFrame):
1741         * WebKitTestRunner/TestController.h:
1742         * WebKitTestRunner/TestInvocation.cpp:
1743         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1744         * WebKitTestRunner/mac/TestControllerMac.mm:
1745         (WTR::TestController::notifyDone): Add method stub.
1746         * WebKitTestRunner/qt/TestControllerQt.cpp:
1747         (WTR::TestControllerRunLoop::instance):
1748         (WTR::TestControllerRunLoop::start):
1749         (WTR::TestControllerRunLoop::stop):
1750         (WTR::TestControllerRunLoop::TestControllerRunLoop):
1751         (WTR::TestControllerRunLoop::timerEvent):
1752         (WTR::TestController::notifyDone):
1753         (WTR::TestController::platformRunUntil):
1754         * WebKitTestRunner/win/TestControllerWin.cpp:
1755         (WTR::TestController::notifyDone): Add method stub.
1756
1757 2010-11-15  Darin Adler  <darin@apple.com>
1758
1759         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
1760
1761 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
1762
1763         Reviewed by Andreas Kling.
1764
1765         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
1766         https://bugs.webkit.org/show_bug.cgi?id=49544
1767
1768         Add the shortcut to BrowserWindow.
1769
1770         * MiniBrowser/qt/BrowserWindow.cpp:
1771         (BrowserWindow::BrowserWindow):
1772         (BrowserWindow::openLocation):
1773         * MiniBrowser/qt/BrowserWindow.h:
1774
1775 2010-11-14  David Levin  <levin@chromium.org>
1776
1777         Reviewed by Daniel Bates.
1778
1779         check-webkit-style should detect PassRefPtr usage in functions.
1780         https://bugs.webkit.org/show_bug.cgi?id=49513
1781
1782         * Scripts/webkitpy/style/checkers/cpp.py:
1783         (check_for_function_lengths): Revert a comment change that I
1784          accidentally made in r71986.
1785         (check_pass_ptr_usage): Added the code to do the check.
1786         (process_line): Added the call to check_pass_ptr_usage.
1787         (CppChecker): Added the new error category.
1788         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1789         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
1790          testing purposes.
1791         (PassPtrTest::*): The class/functions to unit test the new
1792          functionality.
1793
1794 2010-11-14  David Levin  <levin@chromium.org>
1795
1796         Reviewed by Shinichiro Hamaji.
1797
1798         check-webkit-style function detection and the line count style checks should be separate.
1799         https://bugs.webkit.org/show_bug.cgi?id=49512
1800
1801         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
1802         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
1803           call the detection function and fix line counts in two places now that
1804           the code really only counts the lines in the body of the function.
1805
1806 2010-11-14  Andreas Kling  <kling@webkit.org>
1807
1808         Reviewed by Antonio Gomes.
1809
1810         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
1811         https://bugs.webkit.org/show_bug.cgi?id=33438
1812
1813         Stifle "Unhandled variable" warning to match what the other
1814         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
1815         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
1816
1817         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1818         (webkit_test_plugin_get_value):
1819
1820 2010-11-13  David Levin  <levin@chromium.org>
1821
1822         Reviewed by Eric Seidel.
1823
1824         check-webkit-style function detection crashes on functions in templates.
1825         https://bugs.webkit.org/show_bug.cgi?id=49504
1826
1827         For example "template <bool shouldClose(const Element*)>".
1828
1829         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
1830         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
1831           function detection test to expose this issue.
1832
1833 2010-11-12  David Levin  <levin@chromium.org>
1834
1835         Reviewed by Shinichiro Hamaji.
1836
1837         check-webkit-style function detection doesn't detect indented functions declaractions.
1838         https://bugs.webkit.org/show_bug.cgi?id=49446
1839
1840         Indented function declarations occur inside class definitions, so
1841         they are a pretty common (and worth detecting).
1842
1843         * Scripts/webkitpy/style/checkers/cpp.py:
1844           Changed regex to allow indentation.
1845           Changed the function start detection to only happen when not in a
1846           function.
1847           Changed function end detection to work based on matching braces
1848           instead of finding a close brace at the beginning of the line.
1849           Fixed close_expression to do what it says when it doesn't find
1850           the close.
1851         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
1852
1853 2010-11-12  Daniel Bates  <dbates@rim.com>
1854
1855         Rubber-stamped by Nikolas Zimmermann.
1856
1857         Make do-file-rename rename files in the directory WebKit2.
1858
1859         This also makes the list of searched directories in do-file-rename
1860         consistent with the list of searched directories in the script do-webcore-rename.
1861
1862         * Scripts/do-file-rename:
1863
1864 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
1865
1866         Reviewed by James Robinson.
1867
1868         Attempt yet again to land the fix for bug 49360 (respecting
1869         set-webkit-configuration). We need to handle the cases where
1870         trying to run webkit-build-directory to find out where the
1871         default configuration might be fails (that shows up on some
1872         Chromium bots that apparently don't have perl installed).
1873
1874         https://bugs.webkit.org/show_bug.cgi?id=49360
1875
1876         * Scripts/webkitpy/layout_tests/port/config.py:
1877         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
1878         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1879
1880 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
1881
1882         Reviewed by Adam Barth.
1883
1884         webkit-patch land logs commit message twice
1885         https://bugs.webkit.org/show_bug.cgi?id=49482
1886         
1887         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
1888         that's just the commit message, which we now output following the
1889         actual commit.
1890
1891         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1892
1893 2010-11-12  Tony Chang  <tony@chromium.org>
1894
1895         Reviewed by Adam Barth.
1896
1897         run platform/chromium/plugins/script-object-invoke.html on all platforms
1898         https://bugs.webkit.org/show_bug.cgi?id=49280
1899
1900         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1901         (testScriptObjectInvoke):
1902         (pluginInvoke):
1903
1904 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
1905
1906         Reviewed by Adam Barth.
1907
1908         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
1909         https://bugs.webkit.org/show_bug.cgi?id=49471
1910
1911         Right now there's no indication of a successful commit.
1912         
1913         * Scripts/webkitpy/tool/commands/download_unittest.py:
1914         * Scripts/webkitpy/tool/steps/commit.py:
1915
1916 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
1917
1918         Reviewed by Ojan Vafai.
1919
1920         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
1921         https://bugs.webkit.org/show_bug.cgi?id=49354
1922
1923         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
1924
1925         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1926         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1927         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1928         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1929
1930 2010-11-12  Tony Chang  <tony@chromium.org>
1931
1932         Reviewed by Kent Tamura.
1933
1934         [chromium] Load a blank page when closing DRT WebViewHosts
1935         https://bugs.webkit.org/show_bug.cgi?id=49417
1936
1937         In test_shell, when we close a window, we first load about:blank
1938         and run GC to fire the destruction logic of the page.  In test_shell,
1939         this happens in ~TestShell.  In DRT, we manage virtual windows as
1940         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
1941
1942         Managing focus is a bit trickier, since normally you would get window
1943         events to reset the focus to the right window.  We do it manually
1944         instead.
1945
1946         This fixes 2 plugin tests on DRT.
1947
1948         * DumpRenderTree/chromium/TestShell.cpp:
1949         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
1950         (TestShell::closeWindow): Move widget close() to WVH destructor and
1951             manage focus manually.
1952         (TestShell::closeRemainingWindows): Comment typo.
1953         * DumpRenderTree/chromium/WebViewHost.cpp:
1954         (WebViewHost::closeWidget):
1955         (invokeCloseWidget):
1956         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
1957             test_shell).
1958         (WebViewHost::~WebViewHost):
1959         * DumpRenderTree/chromium/WebViewHost.h:
1960
1961 2010-11-12  David Levin  <levin@chromium.org>
1962
1963         Reviewed by Adam Barth.
1964
1965         cpp.py needs some tidying.
1966         https://bugs.webkit.org/show_bug.cgi?id=49443
1967
1968         * Scripts/webkitpy/style/checkers/cpp.py:
1969           Fix parameter ordering for iteratively_replace_matches_with_char
1970           to mirror other similar functions (and improved comments, etc.)
1971           Also, use a python-ism (for/else) to get rid of a variable that
1972           was there to determine if something had been found in the loop.
1973
1974 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
1975
1976         Reviewed by James Robinson.
1977
1978         [Chromium/DRT] Make EventSendingController send complete touch events.
1979         https://bugs.webkit.org/show_bug.cgi?id=49285
1980
1981         * DumpRenderTree/chromium/EventSender.cpp:
1982         (EventSender::addTouchPoint):
1983         (EventSender::updateTouchPoint):
1984         (EventSender::sendCurrentTouchEvent):
1985
1986 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
1987
1988         Unreviewed rollout of r71858.
1989
1990         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
1991         NaCl tests.
1992
1993         * Scripts/webkitpy/layout_tests/port/config.py:
1994         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
1995         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1996
1997 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
1998
1999         Reviewed by Kenneth Rohde Christiansen.
2000
2001         [Qt] TestController::runUntil doesn't honor the timeout parameter
2002         https://bugs.webkit.org/show_bug.cgi?id=48941
2003
2004         Implement the missing timeout of WebKitTestRunner for Qt.
2005
2006         A QElapsedTimer has been added to RunUntilConditionLoop in order
2007         to measure how long the loop has been running. When the timer
2008         is bigger or equal than the timeout, the loop ends even if the
2009         condition is not met.
2010
2011         * WebKitTestRunner/qt/TestControllerQt.cpp:
2012         (WTR::RunUntilConditionLoop::start):
2013         (WTR::RunUntilConditionLoop::run):
2014         (WTR::RunUntilConditionLoop::timerEvent):
2015         (WTR::TestController::platformRunUntil):
2016
2017 2010-11-11  David Levin  <levin@chromium.org>
2018
2019         Reviewed by Shinichiro Hamaji.
2020
2021         check-webkit-style function detection doesn't handle templates with spaces.
2022         https://bugs.webkit.org/show_bug.cgi?id=49427
2023
2024         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2025           finding the function name.
2026         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2027           template with a space.
2028
2029 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2030
2031         Reviewed by Shinichiro Hamaji.
2032
2033         Enable check-webkit-style on Qt files
2034         https://bugs.webkit.org/show_bug.cgi?id=48322
2035
2036         Adding exception for _q_... private slots and
2037         ..._data() methods in tests
2038
2039         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2040         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2041
2042 2010-11-11  David Levin  <levin@chromium.org>
2043
2044         Reviewed by Shinichiro Hamaji.
2045
2046         check-webkit-style function detection doesn't work for templates and destructors.
2047         https://bugs.webkit.org/show_bug.cgi?id=49425
2048
2049         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2050         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2051
2052 2010-11-11  Joone Hur  <joone@kldp.org>
2053
2054         Reviewed by Antonio Gomes.
2055
2056         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2057         https://bugs.webkit.org/show_bug.cgi?id=46598
2058
2059         Support nodesFromRect in DRT
2060
2061         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2062         (LayoutTestController::nodesFromRect):
2063
2064 2010-11-11  MORITA Hajime  <morrita@google.com>
2065
2066         Reviewed by Kent Tamura.
2067
2068         editing/selection/context-menu-on-text.html fails on chromium
2069         https://bugs.webkit.org/show_bug.cgi?id=45898
2070
2071         Enhance Chromium's EventSender::contextClick() to return
2072         array of menu strings. The implementation incomplete because
2073         Although actual context menu is implemented by the browser,
2074         it reflects editability of underlying context thus makes
2075         context-menu-on-text.html passed.
2076         
2077         * DumpRenderTree/chromium/EventSender.cpp:
2078         (makeMenuItemStringsFor): Added.
2079         (EventSender::contextClick): Now returns array of menu strings.
2080         * DumpRenderTree/chromium/WebViewHost.cpp:
2081         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2082         (WebViewHost::clearContextMenuData): Added.
2083         (WebViewHost::lastContextMenuData): Added.
2084         * DumpRenderTree/chromium/WebViewHost.h:
2085
2086 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2087
2088         Unreviewed, build fix.
2089
2090         fix build breakage caused by fix for bug 49380 (r71858).
2091
2092         config_standalone needs to ensure that the packages it needs are
2093         in sys.path.
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=49419
2096
2097         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2098
2099 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2100
2101         Reviewed by Adam Roben.
2102
2103         Fix NRWT to respect set-webkit-configuration again :(
2104
2105         This change fixes a typo in config.py that was causing the wrong
2106         value to be read initially and us never actually looking into
2107         the filesystem to get the default configuration.
2108         
2109         * Scripts/webkitpy/layout_tests/port/config.py:
2110         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2111         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2112
2113 2010-11-11  Eric Seidel  <eric@webkit.org>
2114
2115         Reviewed by Adam Barth.
2116
2117         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2118         https://bugs.webkit.org/show_bug.cgi?id=49403
2119
2120         CommitterValidator really had nothing to do with bugzilla.py.
2121         I've put it next to committers.py for now since its rather tied to that file.
2122
2123         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2124         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2125         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2126         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2127         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2128         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2129         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2130         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2131         * Scripts/webkitpy/tool/bot/feeders.py:
2132         * Scripts/webkitpy/tool/commands/queues.py:
2133
2134 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2135
2136         Reviewed by Eric Seidel.
2137
2138         fix missing 'pid' argument for http lockfile checking on win32
2139         https://bugs.webkit.org/show_bug.cgi?id=49363
2140
2141         * Scripts/webkitpy/common/system/executive.py:
2142
2143 2010-11-11  Eric Seidel  <eric@webkit.org>
2144
2145         Rubber-stamped by Adam Barth.
2146
2147         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2148         https://bugs.webkit.org/show_bug.cgi?id=49402
2149
2150         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2151         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2152         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2153
2154 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2155
2156         Reviewed by Chris Fleizach.
2157
2158         Use IAccessibleComparable to compare accessibility objects.
2159         https://bugs.webkit.org/show_bug.cgi?id=49118
2160
2161         * DumpRenderTree/AccessibilityUIElement.cpp:
2162         (AccessibilityUIElement::isEqual):
2163         * DumpRenderTree/AccessibilityUIElement.h:
2164         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2165         (comparableObject):
2166         (AccessibilityUIElement::isEqual):
2167
2168 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2169
2170         Reviewed by David Hyatt.
2171
2172         HTML5 Ruby support should be mandatory feature
2173         https://bugs.webkit.org/show_bug.cgi?id=49272
2174
2175         Remove Ruby as optional feature.
2176
2177         * Scripts/build-webkit:
2178
2179 2010-11-10  Adam Roben  <aroben@apple.com>
2180
2181         Print VC++ Express build logs in the same order that the projects are
2182         built
2183
2184         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2185         in an unhelpful order
2186
2187         Reviewed by Eric Seidel.
2188
2189         * Scripts/print-vse-failure-logs:
2190         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2191         print-msvc-project-dependencies to figure out the order in which
2192         projects are built.
2193         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2194         based on their build order and project name.
2195         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2196         scripts directory from here...
2197         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2198         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2199         them.
2200
2201 2010-11-10  Adam Roben  <aroben@apple.com>
2202
2203         Only print the interesting text from VC++ Express build logs
2204
2205         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2206         output from print-vse-failure-logs
2207
2208         Reviewed by Eric Seidel.
2209
2210         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2211         added newly-required imports. Removed a comment that was essentially a
2212         FIXME, and is now fixed.
2213         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2214         BeautifulSoup to extract the relevant text from the build log.
2215         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2216
2217 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2218
2219         Reviewed by Tony Chang.
2220
2221         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2222         https://bugs.webkit.org/show_bug.cgi?id=49286
2223         
2224         The tests in http/tests/security/XFrameOptions started to fail after
2225         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2226         logic to always assign identifiers to requests, even if we're not going
2227         to be dumping resource load callbacks at that point. These tests
2228         only call LayoutTestController.dumpResourceLoadCallbacks after the
2229         request is started, thus their expectations have "<unknown>" as the
2230         identifier. Change WebViewHost to the previous behavior, which also
2231         match the other ports'.
2232
2233         * DumpRenderTree/chromium/WebViewHost.cpp:
2234         (WebViewHost::assignIdentifierToRequest):
2235         (WebViewHost::removeIdentifierForRequest):
2236
2237 2010-11-08  Tony Chang  <tony@chromium.org>
2238
2239         Reviewed by Adam Barth.
2240
2241         run platform/chromium/plugins/return-npobject.html on all platforms
2242         https://bugs.webkit.org/show_bug.cgi?id=49103
2243
2244         This tests that we can get an NPObject returned through a method on
2245         an NPAPI Object.
2246
2247         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2248         (testCallbackReturn):
2249         (pluginInvoke):
2250
2251 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2252
2253         Unreviewed, rolling out r71672.
2254         http://trac.webkit.org/changeset/71672
2255         https://bugs.webkit.org/show_bug.cgi?id=49276
2256
2257         It doesn't work on Chromium Windows bot (Requested by Ossy on
2258         #webkit).
2259
2260         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2261         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2262         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2263
2264 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2265
2266         Reviewed by Tony Chang.
2267
2268         [NRWT] Make http locking similar to perl implementation
2269         https://bugs.webkit.org/show_bug.cgi?id=49187
2270
2271         * Scripts/webkitpy/common/system/file_lock.py: Added.
2272         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2273         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2274
2275 2010-11-09  James Kozianski  <koz@chromium.org>
2276
2277         Reviewed by Eric Seidel.
2278
2279         Clean up imports for webkit-patch.
2280         https://bugs.webkit.org/show_bug.cgi?id=49083
2281
2282         Move some imports from commands into main.py where they are used.
2283         Move command imports into the __init__ of the commands module.
2284
2285         * Scripts/webkitpy/tool/commands/__init__.py:
2286         * Scripts/webkitpy/tool/commands/download.py:
2287         * Scripts/webkitpy/tool/commands/queues.py:
2288         * Scripts/webkitpy/tool/main.py:
2289
2290 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2291
2292         Reviewed by Andreas Kling.
2293
2294         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2295         https://bugs.webkit.org/show_bug.cgi?id=49047
2296
2297         * QtTestBrowser/mainwindow.cpp:
2298         (MainWindow::setAddressUrl):
2299
2300 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2301
2302         Reviewed by Csaba Osztrogonác.
2303
2304         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2305         https://bugs.webkit.org/show_bug.cgi?id=49252
2306
2307         * Scripts/old-run-webkit-tests:
2308
2309 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2310
2311         Reviewed by Tor Arne Vestbø.
2312
2313         Output of old-run-webkit-tests is buggy in verbose mode
2314         https://bugs.webkit.org/show_bug.cgi?id=49249
2315
2316         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2317
2318 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2319
2320         Reviewed by Martin Robinson.
2321
2322         [GTK] Link with target name set does not work
2323         https://bugs.webkit.org/show_bug.cgi?id=48865
2324
2325         When a new page is created with a name (target=myFrame), the new
2326         mainFrame could not be found because they where not stored in the
2327         same PageGroup. As PageGroup are not exposed externally so the
2328         simpliest solution is to use a global page group name. This also fixes
2329         issue with visited link coloration across pages. After this change the
2330         private function webkit_web_view_set_group_name() was no longer used
2331         so it was removed completly.
2332
2333         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2334         (createWebView):
2335
2336 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2337
2338         Reviewed by Kent Tamura.
2339
2340         WebViewHost::reset() uses placement new.
2341         https://bugs.webkit.org/show_bug.cgi?id=49069
2342
2343         WebViewHost is using placement destruction / new to simulate a fresh
2344         WebViewHost object at the same address. This is because the WebView remains
2345         open across tests and maintains a pointer to the WebViewHost.
2346         This change resets member variables explictly instead of the placement new dance.
2347
2348         * DumpRenderTree/chromium/WebViewHost.cpp:
2349         (WebViewHost::WebViewHost):
2350         (WebViewHost::reset):
2351
2352 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2353
2354         Reviewed by Eric Seidel.
2355
2356         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2357         It turns out that NRWT can't use the code in scm.find_checkout_root()
2358         because the Chromium bots don't do full checkouts of the WebKit
2359         tree; they only check out subdirectories like WebKitTools/Scripts.
2360         Until we can figure out a better approach for this, I've
2361         restored the base_dir-detecting code from NRWT, which works in
2362         any directory tree, scm or no.
2363
2364         This also restores the files modified in r71475 and r71474.
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=49151
2367
2368         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2369         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2370
2371 2010-11-08  Eric Seidel  <eric@webkit.org>
2372
2373         Reviewed by Adam Barth.
2374
2375         webkit-patch failure-reason explodes if a build is missing
2376         https://bugs.webkit.org/show_bug.cgi?id=49195
2377
2378         This is likely a recent regression.  Adding a unit test for this case.
2379
2380         * Scripts/webkitpy/common/net/buildbot.py:
2381         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2382
2383 2010-11-08  Dan Bernstein  <mitz@apple.com>
2384
2385         Reviewed by Darin Adler.
2386
2387         Ignore the system scrollbar setting.
2388
2389         * DumpRenderTree/mac/DumpRenderTree.mm:
2390         (resetDefaultsToConsistentValues): Set the scrollbar default.
2391
2392 2010-11-05  Adam Roben  <aroben@apple.com>
2393
2394         Make webkitpy.common.system.executive_unittest pass when running under
2395         Win32 Python
2396
2397         Fixes <http://webkit.org/b/49033>.
2398
2399         Reviewed by Dave Levin and Eric Seidel.
2400
2401         * Scripts/webkitpy/common/system/executive.py:
2402         (Executive._run_command_with_teed_output): Pass the arguments through
2403         encode_argument_if_needed rather than using Cygwin-specific code here.
2404         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2405         the output.
2406         (Executive.run_command): Use encode_argument_if_needed to encode the
2407         arguments and child_process_encoding to decode the output.
2408         (Executive._child_process_encoding): Returns the encoding that should be
2409         used when communicating with child processes. On Windows we use mbcs,
2410         which maps to the current code page. On all other platforms we use
2411         UTF-8.
2412         (Executive._should_encode_child_process_arguments): Returns True if
2413         arguments to child processes need to be encoded. This is currently
2414         only needed on Cygwin and Win32 Python 2.x.
2415         (Executive._encode_argument_if_needed): Encode the argument using
2416         child_process_encoding if we need to encode arguments to child
2417         processes on this platform.
2418
2419         * Scripts/webkitpy/common/system/executive_unittest.py:
2420         (never_ending_command): Added. Returns arguments to run a command that
2421         will not quit until we kill it. On Windows we use wmic, on other
2422         platforms we use yes.
2423         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2424         mbcs encoding to be used and for output from the child processes to
2425         have been roundtripped through encode/decode on Win32 Python. When
2426         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2427         it's possible that some characters will not be able to be converted
2428         and will be replaced by question marks; the round-tripping allows us
2429         to expect this result.
2430
2431         (ExecutiveTest.test_kill_process):
2432         (ExecutiveTest.test_kill_all):
2433         Use never_ending_command instead of invoking "yes" directly. Expect an
2434         exit code of 1 when using Win32 Python, as that's what seems to happen.
2435
2436 2010-11-08  Adam Roben  <aroben@apple.com>
2437
2438         Roll out r71532
2439
2440         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2441         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2442
2443         * Scripts/webkitdirs.pm:
2444
2445 2010-11-08  Tony Chang  <tony@chromium.org>
2446
2447         Reviewed by Adam Barth.
2448
2449         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2450         https://bugs.webkit.org/show_bug.cgi?id=49094
2451
2452         This tests that objects created by plugins are proplery cleaned up.
2453
2454         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2455         (testPassTestObject):
2456         (pluginInvoke):
2457         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2458         (testAllocate):
2459         (testDeallocate):
2460         (testGetProperty):
2461         (testConstruct):
2462
2463 2010-11-08  Adam Roben  <aroben@apple.com>
2464
2465         Mark Windows builds triggered from Perl as being non-interactive
2466
2467         This affects whether some of our scripts will show alerts vs. printing
2468         to the build log.
2469
2470         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2471         .vsprops files are updated
2472
2473         Reviewed by Steve Falkenburg.
2474
2475         * Scripts/webkitdirs.pm:
2476         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2477
2478 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2479
2480         Reviewed by Ojan Vafai.
2481
2482         Make http locking default in NRWT.
2483         https://bugs.webkit.org/show_bug.cgi?id=48053
2484
2485         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2487
2488 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2489
2490         Reviewed by Csaba Osztrogonác.
2491
2492         [NRWT] If the http lock fails we shouldn't do any locking
2493         https://bugs.webkit.org/show_bug.cgi?id=49164
2494
2495         If something goes wrong with the locking, the test should keep going.
2496
2497         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2498
2499 2010-11-08  Adam Roben  <aroben@apple.com>
2500
2501         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2502         pixel dumps on Windows
2503
2504         I changed this behavior in r71418 thinking that it was required for
2505         getting plugins to show up in pixel dumps. But it doesn't seem to be
2506         necessary, and was making it impossible to compare new Windows pixel
2507         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2508         compare an image with alpha to an image without alpha).
2509
2510         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2511         new Windows pixel results to existing Windows or Mac results
2512
2513         Reviewed by Antti Koivisto.
2514
2515         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2516         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2517         with kCGImageAlphaPremultipliedFirst.
2518
2519 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2520
2521         Unreviewed, rolling out r71466.
2522         http://trac.webkit.org/changeset/71466
2523         https://bugs.webkit.org/show_bug.cgi?id=48865
2524
2525         It broke layout tests on GTK bots.
2526
2527         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2528         (createWebView):
2529
2530 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2531
2532         Reviewed by Csaba Osztrogonác.
2533
2534         Enable running of Qt API tests on BuildBot
2535         https://bugs.webkit.org/show_bug.cgi?id=49004
2536
2537         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2538
2539 2010-11-08  Eric Seidel  <eric@webkit.org>
2540
2541         Reviewed by Adam Barth.
2542
2543         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
2544         https://bugs.webkit.org/show_bug.cgi?id=49160
2545
2546         Bugzilla doesn't automatically remove r? when a bug gets closed.
2547         This script takes care of that for webkit.org.
2548
2549         * Scripts/webkitpy/common/net/bugzilla.py:
2550         * Scripts/webkitpy/tool/commands/upload.py:
2551
2552 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2553
2554         Unreviewed, rolling out r71474.
2555         http://trac.webkit.org/changeset/71474
2556         https://bugs.webkit.org/show_bug.cgi?id=48280
2557
2558         breaks chromium webkit tests
2559         https://bugs.webkit.org/show_bug.cgi?id=49151
2560
2561         * Scripts/webkitpy/layout_tests/port/base.py:
2562         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2563         * Scripts/webkitpy/layout_tests/port/config.py:
2564         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2565         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2566         * Scripts/webkitpy/layout_tests/port/webkit.py:
2567         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2568         * Scripts/webkitpy/tool/mocktool.py:
2569
2570 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2571
2572         Unreviewed, rolling out r71475.
2573         http://trac.webkit.org/changeset/71475
2574  
2575         breaks chromium webkit tests
2576         https://bugs.webkit.org/show_bug.cgi?id=49151
2577
2578         * Scripts/webkitpy/common/newstringio.py: Removed.
2579         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
2580         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
2581         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
2582         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
2583
2584 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2585
2586         Unreviewed, build fix.
2587
2588         Add files inexplicably not committed in r71474 as part of the
2589         fix for bug 48280.
2590
2591         * Scripts/webkitpy/common/newstringio.py: Added.
2592         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2593         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2594         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2595         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
2596
2597 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2598
2599         Reviewed by Eric Siedel.
2600
2601         new-run-webkit-tests: update port/base and port/webkit to use the
2602         new FileSystem and Config abstractions, pulling more logic out of
2603         the base Port classes into separate, mockable objects.
2604
2605         Also create a MockFileSystem object, a MockConfig object, move
2606         MockExecutive into common/system to be next to executive, and
2607         update the config object to use a FileSystem.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=48280
2610
2611         * Scripts/webkitpy/common/newstringio.py: Added.
2612         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2613         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2614         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2615         * Scripts/webkitpy/layout_tests/port/base.py:
2616         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2617         * Scripts/webkitpy/layout_tests/port/config.py:
2618         * Scripts/webkitpy/layout_tests/port/config_mock.py:
2619         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2620         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2621         * Scripts/webkitpy/layout_tests/port/webkit.py:
2622         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2623         * Scripts/webkitpy/tool/mocktool.py:
2624
2625 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2626
2627         Unreviewed, build breakage.
2628
2629         Apparently I uploaded the wrong version of the file to fix 49122
2630         and neither Eric or I noticed - it was missing a dirname() call.
2631         Fixing ...
2632
2633         https://bugs.webkit.org/show_bug.cgi?id=49122
2634
2635         * Scripts/webkitpy/common/checkout/scm.py:
2636
2637 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2638
2639         Reviewed by Eric Seidel.
2640
2641         webkitpy/tool/* unittests change cwd and don't clean up properly
2642
2643         https://bugs.webkit.org/show_bug.cgi?id=49122
2644
2645         * Scripts/webkitpy/common/checkout/scm.py:
2646
2647 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2648
2649         Reviewed by Simon Fraser.
2650
2651         suspendAnimations/resumeAnimations not present in WebKit2
2652         https://bugs.webkit.org/show_bug.cgi?id=49109
2653
2654         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2655         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2656         (WTR::LayoutTestController::suspendAnimations):
2657         (WTR::LayoutTestController::resumeAnimations):
2658         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2659
2660 2010-11-05  Tony Chang  <tony@chromium.org>
2661
2662         Reviewed by David Levin.
2663
2664         cleanup style in TestNetscapePlugIn/PluginObject.cpp
2665         https://bugs.webkit.org/show_bug.cgi?id=49044
2666
2667         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2668         (getPluginClass):
2669         (pluginGetProperty):
2670         (pluginSetProperty):
2671         (variantToIdentifier):
2672         (testCallback):
2673         (getURL):
2674         (getURLNotify):
2675         (testInvokeDefault):
2676         (testGetProperty):
2677         (testDocumentOpen):
2678         (testWindowOpen):
2679         (pluginInvoke):
2680         (handleCallback):
2681         (notifyStream):
2682         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2683
2684 2010-11-05  Eric Seidel  <eric@webkit.org>
2685
2686         Reviewed by David Levin.
2687
2688         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
2689         https://bugs.webkit.org/show_bug.cgi?id=49032
2690
2691         I wrote this file as part of bug 47847, but I forgot to commit it.
2692         No one else noticed it missing because test-webkitpy knows how
2693         to recover in the case where it can't import QueueStatusServer
2694         (which generally occurs due to not having installed the AppEngine SDK).
2695
2696         * QueueStatusServer/__init__.py: Added.
2697         * QueueStatusServer/model/workitems_unittest.py:
2698          - Remove a test which fails.  This was probably landed (by me)
2699            from my other machine, which since this __init__.py was missing
2700            I never noticed the failure and landed this invalid test.
2701            Sadly we can't really test remove_work_item as it depends
2702            on .key() working.  .key() will throw unless the object
2703            has already been saved it seems.
2704            This may be a mis-design in our remove_work_item implementation,
2705            but for now, just removing the test.
2706
2707 2010-11-04  Adam Roben  <aroben@apple.com>
2708
2709         Teach check-webkit-style about TestNetscapePlugIn
2710
2711         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
2712         TestNetscapePlugIn's coding conventions
2713
2714         Reviewed by John Sullivan.
2715
2716         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
2717         WebKitAPITest and TestWebKitAPI in having different include order and
2718         naming conventions than WebCore. Added some comments about why the
2719         exceptions exist.
2720
2721 2010-11-04  Adam Roben  <aroben@apple.com>
2722
2723         Add a test that shows that windowed plugins are able to paint
2724
2725         Somehow we never had a test for this before.
2726
2727         Fixes <http://webkit.org/b/49029> Should add a test that shows
2728         windowed plugins can paint
2729
2730         Reviewed by Jon Honeycutt.
2731
2732         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
2733         (DrawsGradient::DrawsGradient):
2734         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
2735
2736         (DrawsGradient::onPaint):
2737         (DrawsGradient::onPrintClient):
2738         These both just call through to paint.
2739
2740         (DrawsGradient::paint): Fills our client area with some gradients.
2741
2742         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
2743         against Msimg32.lib for ::GradientFill and added DrawsGradient.
2744
2745         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2746         (createBitmapContextFromWebView): Use WM_PRINT instead of
2747         WM_PRINTCLIENT so that ::DefWindowProc will send
2748         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
2749         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
2750         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
2751         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
2752         will run on a big-endian platform.
2753
2754 2010-11-04  Adam Roben  <aroben@apple.com>
2755
2756         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
2757         WindowedPluginTest base class
2758
2759         The base class takes care of subclassing the plugin's window so that a
2760         custom WNDPROC is called. This will make it easier to write tests that
2761         need to handle window messages.
2762
2763         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
2764         a custom WNDPROC
2765
2766         Reviewed by Jon Honeycutt.
2767
2768         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2769         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
2770         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
2771         (NPNInvalidateRectInvalidatesWindow::wndProc):
2772         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
2773         Moved code from here to WindowedPluginTest. Changed to use window()
2774         instead of m_window.
2775
2776         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2777         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
2778         include path. Also reordered the include path to make a little more
2779         sense and simplified the entry that added TestNetscapePlugIn itself to
2780         the include path.
2781
2782         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
2783         (WindowedPluginTest::WindowedPluginTest):
2784         (WindowedPluginTest::NPP_SetWindow):
2785         (WindowedPluginTest::staticWndProc):
2786         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
2787         (WindowedPluginTest::window):
2788         Code came from NPNInvalidateRectInvalidatesWindow.
2789
2790 2010-11-04  Adam Roben  <aroben@apple.com>
2791
2792         Add a plugin test to show that windowed plugins are clipped correctly
2793
2794         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
2795         plugins aren't clipped in WebKit2 on Windows
2796
2797         Reviewed by Jon Honeycutt.
2798
2799         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
2800         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
2801         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
2802         region matches the clip rect we know we should have based on
2803         window-region-is-set-to-clip-rect.html, and check that our window class
2804         doesn't have the CS_PARENTDC style.
2805
2806         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2807         Added WindowRegionIsSetToClipRect.
2808
2809 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
2810
2811         Reviewed by Martin Robinson.
2812
2813         [GTK] Avoid font hinting in the DRT
2814         https://bugs.webkit.org/show_bug.cgi?id=48548
2815
2816         Change the settings to avoid font hinting, it was causing
2817         different results depending on the distribution.
2818
2819         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2820         (initializeGtkFontSettings):
2821         * DumpRenderTree/gtk/fonts/fonts.conf:
2822
2823 2010-11-05  Eric Seidel  <eric@webkit.org>
2824
2825         Reviewed by Adam Barth.
2826
2827         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
2828         https://bugs.webkit.org/show_bug.cgi?id=49051
2829
2830         This is a speculative fix.  The unit tests cover these methods, however
2831         I don't know if this will fully stop the system.log spam.
2832
2833         * Scripts/webkitpy/layout_tests/port/base.py:
2834         * Scripts/webkitpy/layout_tests/port/webkit.py:
2835
2836 2010-11-05  Eric Seidel  <eric@webkit.org>
2837
2838         Reviewed by Adam Barth.
2839
2840         Add basic support for showing bot id on /queue-status/ pages
2841         https://bugs.webkit.org/show_bug.cgi?id=49037
2842
2843         This support is really simple.  Eventually we'll want to
2844         show the bot id in the lock table too, but we don't have
2845         that information stored in the server yet.
2846
2847         * QueueStatusServer/handlers/queuestatus.py:
2848         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
2849         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2850
2851 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
2852
2853         Reviewed by Adam Barth.
2854
2855         Create a filesystem wrapper that we can use to enforce
2856         particular conventions and use for mocking and dependency
2857         injection down the line.
2858
2859         https://bugs.webkit.org/show_bug.cgi?id=48144
2860
2861         * Scripts/webkitpy/common/system/filesystem.py: Added.
2862         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
2863
2864 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2865
2866         Reviewed by Tony Chang.
2867
2868         run_webkit_tests_unittest fails under Python 2.5
2869         https://bugs.webkit.org/show_bug.cgi?id=49043
2870         
2871         Switch from itertools.chain.from_iterable (which was added in 2.6)
2872         to using itertools.chain directly.
2873
2874         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2875
2876 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2877
2878         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
2879         Python 2.5 (it needs an import to use the with statement).
2880
2881         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2882
2883 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
2884
2885         Reviewed by Adam Barth.
2886
2887         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
2888
2889         The current NRWT code has webkit-specific configuration code (like
2890         _script_path, default configuration, etc.) mixed in with
2891         layout-test-specific stuff in port/base. The configuration code
2892         should be split out into a separate module for easier mocking,
2893         testing, and isolation.
2894
2895         https://bugs.webkit.org/show_bug.cgi?id=48264
2896
2897         * Scripts/webkitpy/layout_tests/port/config.py: Added.
2898         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
2899
2900 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2901
2902         Reviewed by Tony Chang.
2903
2904         Rebaseline server: initial framework
2905         https://bugs.webkit.org/show_bug.cgi?id=48892
2906         
2907         Adds the basic framework for the rebaseline server (details at 
2908         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
2909         command, which starts an HTTP server that can serve static files or
2910         invoke handler methods on a class.
2911
2912         * Scripts/webkitpy/tool/commands/__init__.py:
2913         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
2914         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
2915         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
2916         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
2917
2918 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
2919
2920         Reviewed by James Robinson.
2921
2922         new-run-webkit-tests wasn't using DRT by default for
2923         --platform chromium-gpu
2924
2925         The default value was set to False instead of None, which meant
2926         that the platform specific logic wasn't firing to change the
2927         value to True (b/c we were afraid we'd be overriding the user
2928         preference).
2929
2930         https://bugs.webkit.org/show_bug.cgi?id=49038
2931
2932         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2933
2934 2010-11-04  Tony Chang  <tony@chromium.org>
2935
2936         Reviewed by Adam Barth.
2937
2938         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
2939         https://bugs.webkit.org/show_bug.cgi?id=49026
2940
2941         Have the testObject.bar property return the string "bar".  This lets
2942         us run and pass platform/chromium/plugins/multiple-plugins.html on all
2943         platforms.
2944
2945         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2946         (testGetProperty):
2947
2948 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2949
2950         Reviewed by Tony Chang.
2951
2952         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
2953         https://bugs.webkit.org/show_bug.cgi?id=48878
2954         
2955         Add get_tests_run so that it's easy to see which tests get run (and with
2956         what batching) for a given flag combination. Flesh out the various
2957         test cases that have FIXMEs.
2958         
2959         Also fixes an off-by-one error (batch sizes were one larger than 
2960         expected) and makes --run-part also have wraparound behavior, like
2961         --run-chunk.
2962
2963         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2965         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2966
2967 2010-11-04  Erik Arvidsson  <arv@chromium.org>
2968
2969         Reviewed by Dimitri Glazkov.
2970
2971         Support box-sizing without the vendor prefix
2972         https://bugs.webkit.org/show_bug.cgi?id=36713
2973
2974         Based on patch by Peter Beverloo <peter@lvp-media.com>
2975
2976         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
2977
2978 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
2979
2980         Unreviewed rollout r71340, because it broke Chromium Windows bot.
2981
2982         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2983         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2984
2985 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2986
2987         Reviewed by Ojan Vafai.
2988
2989         Make http locking default in NRWT.
2990         https://bugs.webkit.org/show_bug.cgi?id=48053
2991
2992         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2993         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2994
2995 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2996
2997         Reviewed by Eric Seidel.
2998
2999         [NRWT] Clear invalid http locks on Windows platform as well
3000         https://bugs.webkit.org/show_bug.cgi?id=48515
3001
3002         * Scripts/webkitpy/common/system/executive.py:
3003         * Scripts/webkitpy/common/system/executive_unittest.py:
3004         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3005
3006 2010-11-02  Adam Roben  <aroben@apple.com>
3007
3008         Reduce our dependence on coreutils when running Python tests
3009
3010         This patch introduces versions of the standard echo and cat utilities
3011         implemented in Python. They are probably missing features of their
3012         coreutils equivalents, but they can do what's necessary for our Python
3013         tests. This is useful on Windows, where these utilities typically
3014         aren't available.
3015
3016         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3017         and cat utilities from coreutils, which are not present on Windows
3018
3019         Reviewed by Eric Seidel.
3020
3021         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3022         our Python-based echo and cat.
3023
3024         * Scripts/webkitpy/common/system/fileutils.py: Added.
3025         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3026         that \n won't be translated into \r\n. I couldn't think of a good way
3027         to test this directly without touching the filesystem, but it is tested
3028         indirectly by echo_unittest.
3029
3030         * Scripts/webkitpy/test/cat.py: Added.
3031         (command_arguments): Returns a list for invoking cat with the given arguments.
3032         (main): Acts like a simplified version of the coreutils cat utility.
3033
3034         * Scripts/webkitpy/test/cat_unittest.py: Added.
3035         (CatTest.assert_cat): Runs cat with the given input and ensures the
3036         output matches the input.
3037         (CatTest.test_basic): Performs a simple test of cat.
3038         (CatTest.test_no_newline): Tests what happens when the input string
3039         doesn't have a trailing newline.
3040         (CatTest.test_unicode): Tests passing a unicode string to cat.
3041         (CatTest.test_as_command): Tests running cat as a separate command.
3042
3043         * Scripts/webkitpy/test/echo.py: Added.
3044         (command_arguments): Returns a list for invoking echo with the given arguments.
3045         (main): Acts like a simplified version of the coreutils echo utility.
3046
3047         * Scripts/webkitpy/test/echo_unittest.py: Added.
3048         (EchoTest.test_basic): Performs a simple test of echo.
3049         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3050         trailing newline.
3051         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3052         to echo.
3053         (EchoTest.test_argument_order): Tests what happens when -n is not the
3054         first argument.
3055         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3056         echo.main.
3057         (EchoTest.test_no_arguments): Tests what happens when you call
3058         echo.main with no arguments.
3059         (EchoTest.test_as_command): Tests running echo as a separate command.
3060
3061 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3062
3063         Unreviewed: Add myself to the list of Committers.
3064
3065         * Scripts/webkitpy/common/config/committers.py:
3066
3067 2010-11-04  Andreas Kling  <kling@webkit.org>
3068
3069         Reviewed by Kenneth Rohde Christiansen.
3070
3071         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3072
3073         In RTC mode the QGraphicsWebView item is the size of the contents,
3074         scrolling works a bit differently  (we need to react to scrollRequested.)
3075
3076         Normally QGraphicsView will replay the last mouse event when scrolling,
3077         so to prevent WebKit from getting confused by this we temporarily make
3078         the QGraphicsView non-interactive.
3079
3080         * QtTestBrowser/webview.cpp:
3081         (WebViewGraphicsBased::setPage):
3082         (WebViewGraphicsBased::scrollRequested):
3083         * QtTestBrowser/webview.h:
3084
3085 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3086
3087         Reviewed by Andreas Kling.
3088
3089         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3090
3091         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3092         the Mac-port, not the Mac OS X operating system.
3093
3094         * WebKitTestRunner/qt/TestControllerQt.cpp:
3095         (WTR::isExistingLibrary):
3096
3097 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3098
3099         Reviewed by Andreas Kling.
3100
3101         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3102         https://bugs.webkit.org/show_bug.cgi?id=48869
3103
3104         * QtTestBrowser/useragentlist.txt:
3105
3106 2010-11-03  Adam Roben  <aroben@apple.com>
3107
3108         Always use uppercase drive names in strings returned by abspath_to_uri
3109
3110         Some versions of cygpath use lowercase drive letters while others use
3111         uppercase, which makes it hard to test the output of code that uses
3112         cygpath.
3113
3114         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3115         fails with Cygwin 1.5
3116
3117         Reviewed by Eric Seidel.
3118
3119         * Scripts/webkitpy/common/system/path.py:
3120         (cygpath): Updated the docstring to indicate that only absolute paths
3121         should be passed for now (though relative paths will work fine).
3122         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3123
3124 2010-11-03  George Guo  <George.Guo@Nokia.com>
3125
3126         Reviewed by Andreas Kling.
3127
3128         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3129         https://bugs.webkit.org/show_bug.cgi?id=48767
3130     
3131         Paging is needd on Symbian devices to support benchmarks tests like
3132         dromaeo.com and Celtic Kane that need a lot of memory to run  
3133
3134         * QtTestBrowser/QtTestBrowser.pro:
3135
3136 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3137
3138         Reviewed by Dmitry Titov.
3139
3140         Chromium: Update resource tracking when moving a frame between documents
3141         https://bugs.webkit.org/show_bug.cgi?id=48363
3142
3143         * DumpRenderTree/chromium/WebViewHost.cpp:
3144         (WebViewHost::assignIdentifierToRequest):
3145         Always put resource id in map so we can make assumptions about its
3146         presence.
3147         (WebViewHost::removeIdentifierForRequest):
3148         Added.
3149         (WebViewHost::didFinishResourceLoad):
3150         (WebViewHost::didFailResourceLoad):
3151         Check existence of resource id before removing from map.
3152         * DumpRenderTree/chromium/WebViewHost.h:
3153
3154 2010-11-03  Victor Wang  <victorw@chromium.org>
3155
3156         Reviewed by Adam Barth.
3157
3158         [Chromium] update buildbot names in chromium rebaseline tool.
3159
3160         https://bugs.webkit.org/show_bug.cgi?id=48881
3161
3162         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3163
3164 2010-11-03  Darin Adler  <darin@apple.com>
3165
3166         Updated Xcode projects by opening them with Xcode 3.2.4.
3167         Updated svn:ignore for Xcode projects.
3168
3169         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3170         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3171         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3172         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3173
3174 2010-11-03  Adam Roben  <aroben@apple.com>
3175
3176         Stop waiting for messages from the web process after a timeout elapses
3177
3178         TestController::runUntil now takes a timeout parameter that specifies
3179         how long to wait for the condition to become true. WebKitTestRunner
3180         takes a --timeout flag that specifies how long the timeout should be.
3181         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3182         will be similar to run-webkit-tests.
3183
3184         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3185         WebKitTestRunner waits forever if the web process crashes
3186
3187         Reviewed by Darin Adler and Anders Carlsson.
3188
3189         * Scripts/old-run-webkit-tests:
3190         (top level): Moved the GuardMalloc timeout adjustment here from
3191         readFromDumpToolWithTimer.
3192         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3193         than the one that was specified on the command line.
3194
3195         * WebKitTestRunner/TestController.cpp:
3196         (WTR::TestController::TestController): Initialize our timeout values.
3197         (WTR::TestController::initialize): Parse the --timeout flag and use it
3198         to modify our timeout values.
3199         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3200         short timeout while waiting for the web process to reset and to return
3201         a boolean indicating whether we were able to reset the web process.
3202         Uses a 5-second timeout while waiting for the process to be reset.
3203         (WTR::TestController::runTest): Changed to return a boolean indicating
3204         whether we were able to reset the web process (and thus run the test).
3205         (WTR::TestController::runUntil): Call through to platformRunUntil.
3206
3207         (WTR::TestController::runTestingServerLoop):
3208         (WTR::TestController::run):
3209         Changed to bail if any test can't be run. This will cause the process
3210         to exit. (Unfortunately this will make run-webkit-tests think we
3211         crashed; see <http://webkit.org/b/48943>.)
3212
3213         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3214         m_longTimeout, and m_shortTimeout.
3215
3216         * WebKitTestRunner/TestInvocation.cpp:
3217         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
3218         initial response and a long timeout when waiting for the test to
3219         complete. Check whether runUntil timed out and print an error message
3220         if so.
3221
3222         * WebKitTestRunner/mac/TestControllerMac.mm:
3223         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
3224         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
3225         won't block waiting for the run loop. Only loop until the timeout
3226         elapses.
3227
3228         * WebKitTestRunner/qt/TestControllerQt.cpp:
3229         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
3230         FIXME about honoring the timeout.
3231
3232         * WebKitTestRunner/win/TestControllerWin.cpp:
3233         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
3234         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
3235         ::PeekMessageW so that we don't block waiting for messages to become
3236         available.
3237
3238 2010-11-03  Adam Roben  <aroben@apple.com>
3239
3240         Add a plugin test that evaluates JS after removing the plugin element
3241         from the document
3242
3243         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
3244         That test was made to prevent a crash very similar to this one, but
3245         unfortunately tested only the mechanism that prevented the crash and
3246         not whether the crash itself was prevented. Since WebKit2 uses a
3247         different mechanism to prevent the crash, the test was failing even
3248         though WebKit2 was not vulnerable to the crash. This new test crashes
3249         if there is no mechanism in place to prevent it and passes in both
3250         WebKit1 and WebKit2.
3251
3252         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
3253         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
3254
3255         Reviewed by Anders Carlsson.
3256
3257         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3258         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3259         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3260         * GNUmakefile.am:
3261         Added new file.
3262
3263         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3264         (pluginDeallocate): Make sure we delete the PluginTest object. This
3265         prevents a leak and also allows us to test the crash.
3266
3267         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3268         (PluginTest::executeScript): Made this into a non-static member
3269         function.
3270
3271         (PluginTest::waitUntilDone):
3272         (PluginTest::notifyDone):
3273         Updated for changes to executeScript.
3274
3275         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
3276
3277         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
3278         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
3279         Initialize ourselves and tell the test harness to wait.
3280         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
3281         plugin element from the document, then execute some JavaScript. If
3282         WebKit does not have appropriate mechanisms in place, we'll be
3283         destroyed inside the first call to executeScript and crash on the
3284         second call.
3285
3286 2010-11-02  Stephen White  <senorblanco@chromium.org>
3287
3288         Reviewed by Tony Chang.
3289
3290         [chromium] Fix LayoutTestController UMRs.
3291         https://bugs.webkit.org/show_bug.cgi?id=48872
3292
3293         * DumpRenderTree/chromium/LayoutTestController.cpp:
3294         (LayoutTestController::LayoutTestController):
3295
3296 2010-11-03  Kent Tamura  <tkent@chromium.org>
3297
3298         Reviewed by Dimitri Glazkov.
3299
3300         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
3301         image dup detection
3302         https://bugs.webkit.org/show_bug.cgi?id=48744
3303
3304         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3305          - Make a function for option parsing for ease of test
3306          - Set 0 to options.tolerance
3307         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3308          - Add a test for this change
3309
3310 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3311
3312         Unreviewed: Add myself to the list of Committers.
3313
3314         * Scripts/webkitpy/common/config/committers.py:
3315
3316 2010-11-02  Anders Carlsson  <andersca@apple.com>
3317
3318         Fix build.
3319
3320         * TestWebKitAPI/PlatformUtilities.cpp:
3321         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3322
3323 2010-11-02  Sam Weinig  <sam@webkit.org>
3324
3325         Reviewed by Anders Carlsson.
3326
3327         Add a way to send startup messages on the context which can be posted when a process launches
3328         <rdar://problem/8617928>
3329         https://bugs.webkit.org/show_bug.cgi?id=48838
3330
3331         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3332         (WKBundleInitialize):
3333         * TestWebKitAPI/InjectedBundleController.cpp:
3334         (TestWebKitAPI::InjectedBundleController::initialize):
3335         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
3336         * TestWebKitAPI/InjectedBundleController.h:
3337         * TestWebKitAPI/InjectedBundleMain.cpp:
3338         (WKBundleInitialize):
3339         * TestWebKitAPI/PlatformUtilities.cpp:
3340         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3341         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3342         (WKBundleInitialize):
3343         Update implementations of WKBundleInitialize to take an initial userData
3344         argument.  Change TestWebKitAPI to use the new initial userData to initialize
3345         each test's bundle.
3346
3347 2010-11-02  Benjamin Kalman  <kalman@google.com>
3348
3349         Reviewed by Ojan Vafai.
3350
3351         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
3352         https://bugs.webkit.org/show_bug.cgi?id=48794
3353
3354         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
3355
3356 2010-11-02  Adam Roben  <aroben@apple.com>
3357
3358         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
3359         Python 2.5.x
3360
3361         It is known to hang on that version of Python. See
3362         <http://webkit.org/b/48614>.
3363
3364         Reviewed by Adam Barth.
3365
3366         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
3367         skip_if to skip MainTest on Cygwin Python 2.5.x.
3368
3369         * Scripts/webkitpy/test/skip.py: Added.
3370         (skip_if): If the passed-in condition is false, find all the test_*
3371         methods of the given class and replace them with a function that just
3372         logs that we're skipping these tests. This is loosely based on the
3373         unittest.skip_if decorator added in Python 3.1.
3374         (_skipped_method): Returns a function that just logs that the tests are
3375         being skipped. This is used in place of the actual test_* functions.
3376
3377         * Scripts/webkitpy/test/skip_unittest.py: Added.
3378         (SkipTest.setUp): Create a logger for ourselves and give it a handler
3379         that logs to a private stream.
3380         (SkipTest.tearDown): Reset the logger.
3381         (SkipTest.create_fixture_class): Returns a class that we use to test
3382         skip_if. It has a single test_* method, test_foo, that just calls
3383         through to a callback.
3384         (SkipTest.foo_callback): Record that test_foo was called.
3385         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
3386         that test_foo does get called.
3387         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
3388         that test_foo does not get called and the appropriate message gets
3389         logged.
3390
3391 2010-11-02  Adam Barth  <abarth@webkit.org>
3392
3393         Reviewed by Eric Seidel.
3394
3395         webkit-patch should tell check-webkit-style which files were changed so
3396         check-webkit-style doesn't have to stat the whole working copy again
3397         https://bugs.webkit.org/show_bug.cgi?id=48792
3398
3399         * Scripts/webkitpy/tool/mocktool.py:
3400         * Scripts/webkitpy/tool/steps/checkstyle.py:
3401
3402 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
3403
3404         Reviewed by James Robinson.
3405
3406         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
3407         https://bugs.webkit.org/show_bug.cgi?id=48777
3408
3409         * DumpRenderTree/chromium/EventSender.cpp:
3410         (EventSender::sendCurrentTouchEvent):
3411
3412 2010-11-02  Adam Roben  <aroben@apple.com>
3413
3414         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
3415         is on
3416
3417         This reverts Windows to our pre-r71097 behavior. That patch made us
3418         track all resource identifiers, including the main resource, so the
3419         main resource's URL started appearing in test output instead of
3420         "<unknown>". Arguably having the main resource's URL is better, but all
3421         other platforms print "<unknown>" and we want to match.
3422
3423         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
3424         (r71097): Many http tests failing on Windows
3425
3426         Reviewed by Anders Carlsson.
3427
3428         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3429         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
3430         identifier to the URL map if we're not supposed to dump resource load
3431         callbacks.
3432         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
3433         identifier from the URL map even if we're already "done". There's no
3434         point in keeping out-of-date identifiers around.
3435
3436 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
3437
3438         Reviewed by Adam Roben.
3439
3440         Windows: Update resource tracking when moving a frame between documents
3441         https://bugs.webkit.org/show_bug.cgi?id=48364
3442
3443         * DumpRenderTree/win/DumpRenderTree.cpp:
3444         (createWebViewAndOffscreenWindow):
3445         (main):
3446         Give each WebView its own ResourceLoadDelegate instance in order to
3447         make assertions about resource ids on a particular WebView.
3448         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3449         (ResourceLoadDelegate::identifierForInitialRequest):
3450         Always add id to the map.
3451         (ResourceLoadDelegate::removeIdentifierForRequest):
3452         Added.
3453         (ResourceLoadDelegate::willSendRequest):
3454         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3455         (ResourceLoadDelegate::didReceiveResponse):
3456         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3457         (ResourceLoadDelegate::didFailLoadingWithError):
3458         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3459         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
3460         * DumpRenderTree/win/ResourceLoadDelegate.h:
3461         (ResourceLoadDelegate::urlMap):
3462         Moved within class so that each WebView has its own id map.
3463
3464 2010-11-01  Ojan Vafai  <ojan@chromium.org>
3465
3466         Reviewed by Dimitri Glazkov.
3467
3468         remove debug code from run_webkit_tests.py
3469         https://bugs.webkit.org/show_bug.cgi?id=48800
3470
3471         Remove temporary debug code and make --master-name required
3472         if --test-results-server is set now that all clients set
3473         --master-name.
3474
3475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3476
3477 2010-11-01  Tony Chang  <tony@chromium.org>
3478
3479         Reviewed by Kent Tamura.
3480
3481         add plugin event logging for linux
3482         https://bugs.webkit.org/show_bug.cgi?id=48779
3483
3484         This is taken from Chromium's fork of the layout test plugin:
3485         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
3486
3487         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3488         (handleEventX11):
3489         (NPP_HandleEvent):
3490
3491 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
3492
3493         Reviewed by James Robinson.
3494
3495         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
3496         https://bugs.webkit.org/show_bug.cgi?id=48790
3497
3498         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3499         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3500
3501 2010-11-01  Adam Barth  <abarth@webkit.org>
3502
3503         Reviewed by Eric Seidel.
3504
3505         Teach check-webkit-style how to accept a list of files to diff on the
3506         command line
3507         https://bugs.webkit.org/show_bug.cgi?id=48784
3508
3509         In a future patch, webkit-patch will use this option to improve
3510         performance.  I'm landing this in two pieces to avoid causing a version
3511         skew problem for the style-bot.
3512
3513         * Scripts/check-webkit-style:
3514         * Scripts/webkitpy/style/optparser.py:
3515         * Scripts/webkitpy/style/optparser_unittest.py:
3516         * Scripts/webkitpy/style_references.py:
3517
3518 2010-11-01  Anders Carlsson  <andersca@apple.com>
3519
3520         Reviewed by John Sullivan.
3521
3522         Tear down the related WebProcessProxy when a WebContext is deallocated
3523         https://bugs.webkit.org/show_bug.cgi?id=48769
3524
3525         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3526         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3527         We don't support empty URLs anymore, update test to expect a null URL instead.
3528
3529 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
3530
3531         Reviewed by Andreas Kling.
3532
3533         Fix warning when compiling the chromium port of DumpRenderShell
3534         with clang.
3535         https://bugs.webkit.org/show_bug.cgi?id=48414
3536
3537         * DumpRenderTree/chromium/TestShell.h:
3538         (TestShell::javaScriptFlagsForLoad):
3539
3540 2010-11-01  Adam Roben  <aroben@apple.com>
3541
3542         Fix typo from r71022
3543
3544         * BuildSlaveSupport/build.webkit.org-config/config.json:
3545
3546 2010-11-01  Adam Roben  <aroben@apple.com>
3547
3548         Trigger the Windows Release WebKit2 tests when a Release build
3549         finishes, not when a Debug build finishes
3550
3551         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
3552         triggered at the wrong time
3553
3554         Reviewed by Sam Weinig.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
3557         triggerable name and trigger.
3558
3559 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
3560
3561         Unreviewed. Adding my IRC nickname to the list of committers.
3562
3563         * Scripts/webkitpy/common/config/committers.py:
3564
3565 2010-10-31  Robert Hogan  <robert@webkit.org>
3566
3567         Reviewed by Antonio Gomes.
3568
3569         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
3570
3571         Qt and Gtk are case-sensitive when storing the declared mime-type
3572         of plugins. Since plugin mime-types are lowercased prior to searching
3573         for them in the plugin database, ensure they are loaded with the
3574         mime-type in lower case too.
3575
3576         Change the test netscape plugin to declare its mimetype in sentence
3577         case so that the correct behaviour is enforced.
3578
3579         https://bugs.webkit.org/show_bug.cgi?id=36815
3580
3581         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3582         (NP_GetMIMEDescription):
3583
3584