2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Unreviewed.
4
5         Adding myself as a comitter.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2010-09-15  Philippe Normand  <pnormand@igalia.com>
10
11         Reviewed by Eric Carlson.
12
13         [GTK] enhanced context menu for media elements
14         https://bugs.webkit.org/show_bug.cgi?id=45021
15
16         EventSender::contextClick() now returns an array of js
17         objects. Each object has a title property and a click() method.
18
19         * DumpRenderTree/gtk/EventSender.cpp:
20         (getMenuItemTitleCallback):
21         (setMenuItemTitleCallback):
22         (menuItemClickCallback):
23         (getMenuItemClass):
24         (contextClickCallback):
25
26 2010-09-14  Philippe Normand  <pnormand@igalia.com>
27
28         Reviewed by Eric Carlson and Martin Robinson.
29
30         [GTK] eventSender.contextClick() should return the contents of the context menu
31         https://bugs.webkit.org/show_bug.cgi?id=39102
32
33         Make the eventSender use the new private WebKitGtk+ API to
34         retrieve the context-menu item titles and store them in an array.
35
36         * DumpRenderTree/gtk/EventSender.cpp:
37         (contextClickCallback):
38
39 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
40
41         Reviewed by Jian Li.
42
43         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
44         https://bugs.webkit.org/show_bug.cgi?id=45798
45
46         * Scripts/build-webkit:
47
48 2010-09-16  Robert Hogan  <robert@webkit.org>
49
50         Reviewed by Antonio Gomes.
51
52         [Qt] Support globalhistory tests
53         https://bugs.webkit.org/show_bug.cgi?id=45774
54
55         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
56         (WebCore::isGlobalHistoryTest):
57         (WebCore::DumpRenderTree::open):
58         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
59         (LayoutTestController::reset):
60         (LayoutTestController::dumpHistoryCallbacks):
61         (LayoutTestController::removeAllVisitedLinks):
62         * DumpRenderTree/qt/LayoutTestControllerQt.h:
63
64 2010-09-10  Tony Chang  <tony@chromium.org>
65
66         Reviewed by Eric Seidel.
67
68         deduplicate-tests should be runnable from any WebKit directory
69         https://bugs.webkit.org/show_bug.cgi?id=44709
70
71         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
72         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
73
74 2010-09-15  Tony Chang  <tony@chromium.org>
75
76         Reviewed by Kent Tamura.
77
78         [chromium] sort testing methods in DRT
79         https://bugs.webkit.org/show_bug.cgi?id=45850
80
81         * DumpRenderTree/chromium/EventSender.cpp:
82         (EventSender::EventSender):
83         * DumpRenderTree/chromium/LayoutTestController.cpp:
84         (LayoutTestController::LayoutTestController):
85         * DumpRenderTree/chromium/TextInputController.cpp:
86         (TextInputController::TextInputController):
87
88 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
89
90         Reviewed by Adam Barth.
91
92         CQ status shows items out of order
93         https://bugs.webkit.org/show_bug.cgi?id=45846
94         
95         Only group consecutive status items with the same patch ID into the same
96         group, so that overall item ordering is preserved.
97         
98         Also don't indent status items that only have a single item in their
99         group.
100
101         * QueueStatusServer/handlers/queuestatus.py:
102         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
103         * QueueStatusServer/templates/queuestatus.html:
104
105 2010-09-15  Eric Seidel  <eric@webkit.org>
106
107         Reviewed by Adam Barth.
108
109         Add queue start/stop messages
110         https://bugs.webkit.org/show_bug.cgi?id=45853
111
112         I ended up needing to clean up a bunch of our unit testing
113         in order to test this new code path nicely.
114
115         There are also a few PEP8 changes needed to pass check-webkit-style.
116
117         * Scripts/webkitpy/tool/bot/queueengine.py:
118         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
119         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
120         * Scripts/webkitpy/tool/commands/queues.py:
121         * Scripts/webkitpy/tool/commands/queues_unittest.py:
122         * Scripts/webkitpy/tool/commands/queuestest.py:
123         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
124
125 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
126
127         https://bugs.webkit.org/show_bug.cgi?id=45849
128         WKURLCreateWithCFURL crashes with null url
129         
130         Fix MiniBrowser crash when the url is not parseable.
131
132         * MiniBrowser/mac/BrowserWindowController.m:
133         (-[BrowserWindowController fetch:]):
134
135 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
136
137         Unreviewed.
138
139         Adding myself to the committers list.
140
141         * Scripts/webkitpy/common/config/committers.py:
142
143 2010-09-14  Eric Seidel  <eric@webkit.org>
144
145         Reviewed by Adam Barth.
146
147         Make it possible to run more than one commit-queue instance
148         https://bugs.webkit.org/show_bug.cgi?id=45786
149
150         Mostly we need to make sure the two (or more) instances get
151         different patches to work on.  To do this, I re-worked
152         the code responsible for getting the next work item to
153         round trip through the status server.  The status server only
154         vends patches from the work items list, only if those patches
155         have not had status reported for them in the last hour.
156
157         This is another step towards making all queues go through the
158         status server, thus making it possible to run more than one
159         instance of various EWS bots (as requested in bug 44292).
160
161         The webkitpy changes are already covered by existing unit tests.
162         The QueueStatusSever sadly has no testing infrastructure yet. :(
163
164         * QueueStatusServer/handlers/nextpatch.py: Added.
165         * QueueStatusServer/index.yaml:
166         * QueueStatusServer/main.py:
167         * Scripts/webkitpy/tool/commands/queues.py:
168
169 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
170
171         Reviewed by Tony Chang.
172
173         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
174         https://bugs.webkit.org/show_bug.cgi?id=45791
175
176         Force filenames to be raw bytes before running difflib.unified_diff.
177
178         * Scripts/webkitpy/layout_tests/port/base.py:
179         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
180
181 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
182
183         Reviewed by Tor Arne Vestbø.
184
185         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
186         https://bugs.webkit.org/show_bug.cgi?id=35247
187
188         The main issue when changing the views is that the plugins and any other components that
189         depend on view specific attributes such as the native window id are not teared down.
190         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
191         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
192         we decided to work around this in QtTestBrowser by making toggling between QWebView
193         and QGraphicsWebView also re-create the page.
194
195         * QtTestBrowser/launcherwindow.cpp:
196         (LauncherWindow::initializeView):
197         * QtTestBrowser/mainwindow.h:
198
199 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
200
201         Reviewed by Adam Barth.
202
203         Send webkit accessibility notifications to Chromium
204         https://bugs.webkit.org/show_bug.cgi?id=45156
205
206         Move printf inside shouldDumpAccessibilityNotifications check.
207
208         * DumpRenderTree/chromium/WebViewHost.cpp:
209         (WebViewHost::postAccessibilityNotification):
210
211 2010-09-14  Tony Chang  <tony@chromium.org>
212
213         Reviewed by Kent Tamura.
214
215         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
216         https://bugs.webkit.org/show_bug.cgi?id=45788
217
218         * DumpRenderTree/chromium/LayoutTestController.cpp:
219         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
220
221 2010-09-14  Tony Chang  <tony@chromium.org>
222
223         Reviewed by Ojan Vafai.
224
225         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
226         https://bugs.webkit.org/show_bug.cgi?id=45768
227
228         * DumpRenderTree/chromium/TestShell.cpp:
229         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
230
231 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
232
233         [wx] Build fix, add newly added directories to the directory list.
234
235         * wx/build/settings.py:
236
237 2010-09-14  Sam Weinig  <sam@webkit.org>
238
239         Reviewed by Anders Carlsson.
240
241         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
242         https://bugs.webkit.org/show_bug.cgi?id=45785
243
244         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
245         (WTR::propertyValue):
246         (WTR::numericWindowPropertyValue):
247         (WTR::dumpPath):
248         (WTR::toStr):
249         (WTR::operator<<):
250         (WTR::InjectedBundlePage::InjectedBundlePage):
251         (WTR::InjectedBundlePage::shouldInsertNode):
252         (WTR::InjectedBundlePage::shouldBeginEditing):
253         (WTR::InjectedBundlePage::shouldEndEditing):
254         (WTR::InjectedBundlePage::shouldInsertText):
255         (WTR::InjectedBundlePage::shouldDeleteRange):
256         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
257         (WTR::InjectedBundlePage::shouldApplyStyle):
258         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
259
260 2010-09-14  Adam Barth  <abarth@webkit.org>
261
262         Fix two typos in commit-queue.  The first is harmless.  The second
263         causes the queue to reject patches when the build is broken.  :(
264
265         * Scripts/webkitpy/tool/commands/queues.py:
266         * Scripts/webkitpy/tool/commands/queues_unittest.py:
267
268 2010-09-14  Chris Guillory   <chris.guillory@google.com>
269
270         Reviewed by Chris Fleizach.
271
272         Send all accessibility notifications to Chromium.
273         https://bugs.webkit.org/show_bug.cgi?id=45156
274
275         * DumpRenderTree/chromium/WebViewHost.cpp:
276         (WebViewHost::postAccessibilityNotification):
277         * DumpRenderTree/chromium/WebViewHost.h:
278
279 2010-09-14  Adam Barth  <abarth@webkit.org>
280
281         Reviewed by Eric Seidel.
282
283         commit-queue is slow during the day
284         https://bugs.webkit.org/show_bug.cgi?id=45780
285
286         Thanks to the new logging, we've noticed that checkout-is-out-of-date
287         errors in the first pass of landing don't retry the land.  Instead,
288         they're treated as failures and cause the commit-queue to do two more
289         builds before really trying to land the patch.  Worse, in the second
290         build, we can get bitten by a flaky test.
291
292         This patch takes a slightly different approach to the commit-queue's
293         main control logic.  We now use a separate subprocess for building and
294         testing and for landing.  This means we should very rarely see the
295         checkout-is-out-of-date error, and when we do see it, we should retry
296         more quickly.  If my understanding is correct, this should be a big
297         speed win for the commit-queue.
298
299         * Scripts/webkitpy/tool/commands/download.py:
300         * Scripts/webkitpy/tool/commands/queues.py:
301         * Scripts/webkitpy/tool/commands/queues_unittest.py:
302
303 2010-09-14  Tony Chang  <tony@chromium.org>
304
305         Reviewed by Dimitri Glazkov.
306
307         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
308         https://bugs.webkit.org/show_bug.cgi?id=45762
309
310         * DumpRenderTree/chromium/LayoutTestController.cpp:
311         (LayoutTestController::LayoutTestController):
312         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
313         * DumpRenderTree/chromium/LayoutTestController.h:
314
315 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
316
317         Adding myself as a reviewer.
318
319         * Scripts/webkitpy/common/config/committers.py:
320
321 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
322
323         Reviewed by Kenneth Rohde Christiansen.
324
325         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
326         https://bugs.webkit.org/show_bug.cgi?id=45736
327
328         Build-webkit has showed a warning when WebKitBuild didn't exist, add
329         an additional condition to avoid it.
330
331         * Scripts/build-webkit:
332
333 2010-09-13  Eric Seidel  <eric@webkit.org>
334
335         Reviewed by Adam Barth.
336
337         commit-queue should log when it's retrying due to checkout out of date error
338         https://bugs.webkit.org/show_bug.cgi?id=45725
339
340         This will allow us to better track how often we see these errors
341         and how long it takes the queue to recover from them.
342
343         In order to pass the tests, I had to correct an error
344         from a previous change.  The UnitTestPort should not have
345         ever been using the base port method as that will read
346         a file from disk.  If the unit tests haven't passed the contents
347         it should raise an IOError as though the file doesn't exist.
348
349         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
350         * Scripts/webkitpy/tool/commands/queues.py:
351         * Scripts/webkitpy/tool/commands/queues_unittest.py:
352
353 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
354
355         Reviewed by Adam Barth.
356
357         Upload results when cq patch landing fails
358         https://bugs.webkit.org/show_bug.cgi?id=45683
359         
360         Include script errors when CommitQueue._land fails.
361
362         * Scripts/webkitpy/tool/commands/queues.py:
363
364 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
365
366         Reviewed by David Kilzer.
367
368         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
369         https://bugs.webkit.org/show_bug.cgi?id=45548
370
371         * DumpRenderTree/AccessibilityUIElement.cpp:
372         (isIgnoredCallback):
373         (AccessibilityUIElement::getJSClass):
374         * DumpRenderTree/AccessibilityUIElement.h:
375         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
376         (AccessibilityUIElement::isIgnored):
377         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
378         (AccessibilityUIElement::isIgnored):
379         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
380         (AccessibilityUIElement::isIgnored):
381
382 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
383
384         Reviewed by Andreas Kling.
385
386         jscPath() is incorrect in Windows' cmd.exe shell
387         https://bugs.webkit.org/show_bug.cgi?id=45651
388
389         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
390
391 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
392
393         Reviewed by Darin Adler.
394
395         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
396         https://bugs.webkit.org/show_bug.cgi?id=43807
397
398         * DumpRenderTree/AccessibilityUIElement.cpp:
399         (textMarkerForPointCallback):
400         (AccessibilityUIElement::textMarkerForPoint):
401         (AccessibilityUIElement::getJSClass):
402         * DumpRenderTree/AccessibilityUIElement.h:
403         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
404         (AccessibilityUIElement::textMarkerForPoint):
405
406 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
407
408         Reviewed by Kenneth Rohde Christiansen.
409
410         [Qt] build-webkit: Add --v8 option to build against V8
411
412         Note that V8 is picked up from QtScript, so this currently requires building
413         against the experimental qt-script-v8 branch.
414
415         * Scripts/build-webkit:
416
417 2010-09-13  Hans Wennborg  <hans@chromium.org>
418
419         Reviewed by Jeremy Orlow.
420
421         Add WebDeviceOrientationClientMock::create() and use it from DRT.
422         https://bugs.webkit.org/show_bug.cgi?id=45650
423
424         Do not use the WebDeviceOrientationClientMock constructor directly,
425         but use the create() member function.
426
427         This should fix the linker errors for the multi-DLL Chromium DRT build.
428
429         * DumpRenderTree/chromium/LayoutTestController.cpp:
430         (LayoutTestController::setMockDeviceOrientation):
431         (LayoutTestController::deviceOrientationClient):
432
433 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
434
435         Reviewed by Antti Koivisto.
436
437         Add support for testing the viewport meta tag algorithm,
438         based on the following draft spec:
439
440         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
441
442         Add common handling of viewport meta tag based on new Opera spec
443         https://bugs.webkit.org/show_bug.cgi?id=44201
444
445         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
446         (LayoutTestController::dumpConfigurationForViewport):
447         * DumpRenderTree/qt/LayoutTestControllerQt.h:
448
449 2010-09-12  Kent Tamura  <tkent@chromium.org>
450
451         Reviewed by Tony Chang.
452
453         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
454         https://bugs.webkit.org/show_bug.cgi?id=45517
455
456         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
457
458         * DumpRenderTree/chromium/ImageDiff.cpp:
459         (Image::craeteFromStdin):
460         (Image::createFromFilename):
461         (diffImages):
462         * DumpRenderTree/chromium/TestShell.cpp:
463         (TestShell::dumpImage):
464
465 2010-09-10  MORITA Hajime  <morrita@google.com>
466
467         Reviewed by Tony Chang.
468
469         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
470         https://bugs.webkit.org/show_bug.cgi?id=45441
471
472         Added TextInputController::hasSpellingMarker().
473         
474         * DumpRenderTree/chromium/TextInputController.cpp:
475         (TextInputController::TextInputController):
476         (TextInputController::hasSpellingMarker):
477         * DumpRenderTree/chromium/TextInputController.h:
478
479 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
480
481         Unreviewed, build fix.
482
483         My last change accidentally contained a local change to the
484         rebaselinig script; webkit-patch land picked it up without telling
485         me and committed it :(
486
487         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
488
489 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
490
491         Reviewed by Anders Carlsson.
492
493         Attempt to fix Windows MiniBrowser build (untested)
494         https://bugs.webkit.org/show_bug.cgi?id=45609
495
496         * MiniBrowser/win/BrowserView.cpp:
497         (runJavaScriptConfirm):
498         (runJavaScriptPrompt):
499
500 2010-09-11  Sam Weinig  <sam@webkit.org>
501
502         Reviewed by Maciej Stachowiak.
503
504         Fix zoom related tests when testing WebKit2.
505
506         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
507         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
508
509 2010-09-11  Sam Weinig  <sam@webkit.org>
510
511         Reviewed by Dan Bernstein.
512
513         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
514         <rdar://problem/8359252>
515         https://bugs.webkit.org/show_bug.cgi?id=45605
516
517         * MiniBrowser/mac/BrowserWindowController.m:
518         (setStatusText):
519         (contentsSizeChanged):
520         (-[BrowserWindowController awakeFromNib]):
521         * MiniBrowser/win/BrowserView.cpp:
522         (runJavaScriptConfirm):
523         (runJavaScriptPrompt):
524         (setStatusText):
525         (contentsSizeChanged):
526         (BrowserView::create):
527         * WebKitTestRunner/TestController.cpp:
528         (WTR::createOtherPage):
529         (WTR::TestController::initialize):
530
531 2010-09-11  Sam Weinig  <sam@webkit.org>
532
533         Reviewed by Dan Bernstein.
534
535         Add callback mechanism for the getting the source of a frame
536         <rdar://problem/8364681>
537         https://bugs.webkit.org/show_bug.cgi?id=45604
538
539         Add ability to dump the main frame's source to the console.
540
541         * MiniBrowser/mac/BrowserWindowController.h:
542         * MiniBrowser/mac/BrowserWindowController.m:
543         (-[BrowserWindowController dumpSourceToConsole:]):
544         * MiniBrowser/mac/MainMenu.xib:
545
546 2010-09-11  Eric Seidel  <eric@webkit.org>
547
548         Reviewed by Adam Barth.
549
550         Remove unneeded Empty Queue messages
551         https://bugs.webkit.org/show_bug.cgi?id=45602
552
553         We already have a /gc job to delete these.
554         recentstatus.py is already smart enough to use the
555         most recent of the workitems last update or the most recent status,
556         so removing these should not change the _last_status_date() return
557         value more than a few milliseconds.
558
559         These messages just spam the recent status log.
560
561         * Scripts/webkitpy/tool/commands/queues.py:
562
563 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
564
565         Reviewed by Adam Barth.
566
567         Fix Python exception when generating synthetic patch IDs
568         https://bugs.webkit.org/show_bug.cgi?id=45592
569
570         Can't concatenate strings and numbers directly.
571
572         * QueueStatusServer/handlers/queuestatus.py:
573
574 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
575
576         Reviewed by Adam Barth.
577
578         Group statuses in queue status by patch ID
579         https://bugs.webkit.org/show_bug.cgi?id=45588
580
581         Group statuses by patch ID so that the status page is easier
582         to scan.
583
584         * QueueStatusServer/handlers/queuestatus.py:
585         * QueueStatusServer/stylesheets/dashboard.css:
586         (.status-group):
587         (.status-bug):
588         (.status-group ul):
589         (.status-group ul li):
590         (.status-group ul li:hover):
591         (.status-cell):
592         (.status-cell:hover):
593         (.status-cell.pass):
594         (.status-cell.fail):
595         (.status-cell.pending):
596         (.status-cell.error):
597         * QueueStatusServer/templates/dashboard.html:
598         * QueueStatusServer/templates/queuestatus.html:
599
600 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
601
602         Reviewed by Tony Chang.
603
604         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
605         https://bugs.webkit.org/show_bug.cgi?id=45479
606
607         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
608         implementation in ResourceLoadDelegate in the Mac port).
609
610         * DumpRenderTree/chromium/LayoutTestController.cpp:
611         (LayoutTestController::LayoutTestController):
612         (LayoutTestController::dumpResourceResponseMIMETypes):
613         (LayoutTestController::reset):
614         * DumpRenderTree/chromium/LayoutTestController.h:
615         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
616         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
617         * DumpRenderTree/chromium/TestShell.h:
618         (TestShell::shouldDumpResourceResponseMIMETypes):
619         * DumpRenderTree/chromium/WebViewHost.cpp:
620         (WebViewHost::didReceiveResponse):
621
622 2010-09-11  Eric Seidel  <eric@webkit.org>
623
624         Reviewed by Adam Barth.
625
626         queues.webkit.org should expose /remote_api for data upload/download
627         https://bugs.webkit.org/show_bug.cgi?id=45559
628
629         * QueueStatusServer/app.yaml:
630          - /remote_api is a standard app-engine service which allows use of
631            the bulk uploader for data upload/download.  Exposing this
632            (for admin access only) allows us to use 
633
634 2010-09-10  Sam Weinig  <sam@webkit.org>
635
636         Reviewed by Dan Bernstein.
637
638         Add zoom support to WebKit2 API
639         <rdar://problem/7660657>
640         https://bugs.webkit.org/show_bug.cgi?id=45585
641
642         - Add zoom options to MiniBrowser that mimic Safari's options using
643           the new WebKit2 zoom APIs.
644         - Switch uses of float for the zoom APIs to use double.
645
646         * MiniBrowser/mac/BrowserWindowController.h:
647         * MiniBrowser/mac/BrowserWindowController.m:
648         (-[BrowserWindowController initWithPageNamespace:]):
649         (-[BrowserWindowController validateMenuItem:]):
650         (-[BrowserWindowController validateUserInterfaceItem:]):
651         (-[BrowserWindowController currentZoomFactor]):
652         (-[BrowserWindowController setCurrentZoomFactor:]):
653         (-[BrowserWindowController canZoomIn]):
654         (-[BrowserWindowController zoomIn:]):
655         (-[BrowserWindowController canZoomOut]):
656         (-[BrowserWindowController zoomOut:]):
657         (-[BrowserWindowController canResetZoom]):
658         (-[BrowserWindowController resetZoom:]):
659         (-[BrowserWindowController toggleZoomMode:]):
660         * MiniBrowser/mac/MainMenu.xib:
661         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
662         (WTR::EventSendingController::textZoomIn):
663         (WTR::EventSendingController::textZoomOut):
664         (WTR::EventSendingController::zoomPageIn):
665         (WTR::EventSendingController::zoomPageOut):
666
667 2010-09-10  Robert Hogan  <robert@webkit.org>
668
669         Reviewed by Andreas Kling.
670
671         [Qt] Fix crash in DRT in standalone mode
672
673         https://bugs.webkit.org/show_bug.cgi?id=45454
674
675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
676         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
677
678 2010-09-10  Sam Weinig  <sam@webkit.org>
679
680         Reviewed by Darin Adler.
681
682         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
683         Precursor to <rdar://problem/7660657>
684         https://bugs.webkit.org/show_bug.cgi?id=45522
685
686         Update for changes to the Bundle API to allow separate control of page and text zoom
687         levels.
688
689         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
690         (WTR::EventSendingController::textZoomIn):
691         (WTR::EventSendingController::textZoomOut):
692         (WTR::EventSendingController::zoomPageIn):
693         (WTR::EventSendingController::zoomPageOut):
694         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
695         (WTR::InjectedBundlePage::reset):
696
697 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
698
699         Reviewed by Andreas Kling.
700
701         [Qt] Support click event for notifications
702         https://bugs.webkit.org/show_bug.cgi?id=44836
703
704         Add support for simulateDesktopNotificationClick by calling
705         back to DumpRenderTreeSupportQt.cpp.
706
707         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
708         (LayoutTestController::simulateDesktopNotificationClick):
709         * DumpRenderTree/qt/LayoutTestControllerQt.h:
710
711 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
712
713         Reviewed by Eric Seidel.
714
715         Update queue status when patches fail their first land attempt
716         https://bugs.webkit.org/show_bug.cgi?id=45583
717
718         Add a few more _update_status calls to make it more obvious if a patch is 
719         being retried because tests failed.
720
721         * Scripts/webkitpy/tool/commands/queues.py:
722
723 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
724
725         Reviewed by Andreas Kling.
726
727         [Qt] MiniBrowser crashes with multiply windows when closing one of them
728         https://bugs.webkit.org/show_bug.cgi?id=45536
729
730         * MiniBrowser/qt/BrowserView.cpp:
731         (BrowserView::BrowserView): Reference the context instead of adopting it
732         because it can be shared across different views.
733
734 2010-09-10  Tony Chang  <tony@chromium.org>
735
736         Unreviewed, rolling out r67241.
737         http://trac.webkit.org/changeset/67241
738         https://bugs.webkit.org/show_bug.cgi?id=44709
739
740         Accidentally committed.
741
742         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
743         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
744
745 2010-09-10  Tony Chang  <tony@chromium.org>
746
747         Reviewed by Ojan Vafai.
748
749         deduplicate-tests should be runnable from any WebKit directory
750         https://bugs.webkit.org/show_bug.cgi?id=44709
751
752         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
753         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
754
755 2010-09-10  Tony Chang  <tony@chromium.org>
756
757         Unreviewed, rolling out r67216.
758         http://trac.webkit.org/changeset/67216
759         https://bugs.webkit.org/show_bug.cgi?id=44709
760
761         Broke
762
763         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
764         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
765
766 2010-09-10  Tony Chang  <tony@chromium.org>
767
768         Reviewed by Ojan Vafai.
769
770         deduplicate-tests should be runnable from any WebKit directory
771         https://bugs.webkit.org/show_bug.cgi?id=44709
772
773         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
774         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
775
776 2010-09-09  Hans Wennborg  <hans@chromium.org>
777
778         Reviewed by Jeremy Orlow.
779
780         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
781         https://bugs.webkit.org/show_bug.cgi?id=45460
782
783         This enables DumpRenderTree to run layout tests for DeviceOrientation.
784
785         Also declare the LayoutTestController destructor out-of-line.
786         Otherwise the implicit destructor would cause compiler errors because
787         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
788
789         * DumpRenderTree/chromium/LayoutTestController.cpp:
790         (LayoutTestController::~LayoutTestController):
791         (LayoutTestController::setMockDeviceOrientation):
792         (LayoutTestController::deviceOrientationClient):
793         * DumpRenderTree/chromium/LayoutTestController.h:
794         * DumpRenderTree/chromium/WebViewHost.cpp:
795         (WebViewHost::deviceOrientationClient):
796         * DumpRenderTree/chromium/WebViewHost.h:
797
798 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
799
800         Unreviewed, rolling out r67119.
801         http://trac.webkit.org/changeset/67119
802         https://bugs.webkit.org/show_bug.cgi?id=45505
803
804         Extra newlines in results (Requested by tony^work on #webkit).
805
806         * DumpRenderTree/chromium/LayoutTestController.cpp:
807         (LayoutTestController::LayoutTestController):
808         (LayoutTestController::reset):
809         * DumpRenderTree/chromium/LayoutTestController.h:
810         * DumpRenderTree/chromium/TestShell.h:
811         * DumpRenderTree/chromium/WebViewHost.cpp:
812         (printResponseDescription):
813         (printNodeDescription):
814         (printRangeDescription):
815         (WebViewHost::shouldBeginEditing):
816         (WebViewHost::shouldEndEditing):
817         (WebViewHost::shouldInsertNode):
818         (WebViewHost::shouldChangeSelectedRange):
819         (WebViewHost::shouldDeleteRange):
820         (WebViewHost::shouldApplyStyle):
821         (WebViewHost::didBeginEditing):
822         (WebViewHost::didChangeSelection):
823         (WebViewHost::didChangeContents):
824         (WebViewHost::didEndEditing):
825         (WebViewHost::decidePolicyForNavigation):
826         (WebViewHost::didCancelClientRedirect):
827         (WebViewHost::didStartProvisionalLoad):
828         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
829         (WebViewHost::didFailProvisionalLoad):
830         (WebViewHost::didCommitProvisionalLoad):
831         (WebViewHost::didFinishDocumentLoad):
832         (WebViewHost::didHandleOnloadEvents):
833         (WebViewHost::didFailLoad):
834         (WebViewHost::didFinishLoad):
835         (WebViewHost::didChangeLocationWithinPage):
836         (WebViewHost::willSendRequest):
837         (WebViewHost::didReceiveResponse):
838         (WebViewHost::didFinishResourceLoad):
839         (WebViewHost::didFailResourceLoad):
840         (WebViewHost::didDisplayInsecureContent):
841         (WebViewHost::didRunInsecureContent):
842         (WebViewHost::printFrameDescription):
843
844 2010-09-09  Michael Saboff  <msaboff@apple.com>
845
846         Unreviewed, adding myself to committers list.
847
848         * Scripts/webkitpy/common/config/committers.py:
849
850 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
851
852         Reviewed by Tony Chang.
853
854         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
855         https://bugs.webkit.org/show_bug.cgi?id=45479
856
857         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
858         implementation in ResourceLoadDelegate in the Mac port).
859
860         * DumpRenderTree/chromium/LayoutTestController.cpp:
861         (LayoutTestController::LayoutTestController):
862         (LayoutTestController::dumpResourceResponseMIMETypes):
863         (LayoutTestController::reset):
864         * DumpRenderTree/chromium/LayoutTestController.h:
865         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
866         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
867         * DumpRenderTree/chromium/TestShell.h:
868         (TestShell::shouldDumpResourceResponseMIMETypes):
869         * DumpRenderTree/chromium/WebViewHost.cpp:
870         (WebViewHost::didReceiveResponse):
871
872 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
873
874         Reviewed by Daniel Bates.
875
876         svn-apply tries to delete directories it shouldn't
877         https://bugs.webkit.org/show_bug.cgi?id=45424
878
879         isDirectoryEmptyForRemoval had the wrong check. If an item in the
880         directory is itself a directory, then the directory is definitely
881         not empty.
882
883         * Scripts/svn-apply:
884
885 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
886
887         Fixing GTK and windows build failure.
888
889         AX: Support AccessibilityTextMarkers in DRT
890         https://bugs.webkit.org/show_bug.cgi?id=44778
891
892         * DumpRenderTree/AccessibilityTextMarker.h:
893         (AccessibilityTextMarker::platformTextMarker):
894         (AccessibilityTextMarkerRange::platformTextMarkerRange):
895         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
896         (AccessibilityTextMarker::platformTextMarker):
897         (AccessibilityTextMarkerRange::platformTextMarkerRange):
898
899 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
900
901         Reviewed by David Kilzer.
902
903         AX: Support AccessibilityTextMarkers in DRT
904         https://bugs.webkit.org/show_bug.cgi?id=44778
905
906         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
907         that WebCore uses when vending information about its VisiblePositions through AX.
908
909         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
910         methods for encapsulating and checking equality.
911
912         This will allow future bug fixes in the text marker system to be adequately tested.
913
914         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
915         (toTextMarker):
916         (isMarkerEqualCallback):
917         (markerFinalize):
918         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
919         (AccessibilityTextMarker::getJSClass):
920         (toTextMarkerRange):
921         (isMarkerRangeEqualCallback):
922         (markerRangeFinalize):
923         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
924         (AccessibilityTextMarkerRange::getJSClass):
925         * DumpRenderTree/AccessibilityTextMarker.h: Added.
926         (AccessibilityTextMarker::platformTextMarker):
927         (AccessibilityTextMarkerRange::platformTextMarkerRange):
928         (AccessibilityTextMarker::AccessibilityTextMarker):
929         (AccessibilityTextMarker::~AccessibilityTextMarker):
930         (AccessibilityTextMarker::isEqual):
931         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
932         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
933         (AccessibilityTextMarkerRange::isEqual):
934         * DumpRenderTree/AccessibilityUIElement.cpp:
935         (textMarkerRangeForElementCallback):
936         (textMarkerRangeLengthCallback):
937         (textMarkerRangeForMarkersCallback):
938         (startTextMarkerForTextMarkerRangeCallback):
939         (endTextMarkerForTextMarkerRangeCallback):
940         (accessibilityElementForTextMarkerCallback):
941         (AccessibilityUIElement::textMarkerRangeForElement):
942         (AccessibilityUIElement::textMarkerRangeLength):
943         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
944         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
945         (AccessibilityUIElement::accessibilityElementForTextMarker):
946         (AccessibilityUIElement::getJSClass):
947         * DumpRenderTree/AccessibilityUIElement.h:
948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
949         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
950         (AccessibilityTextMarker::AccessibilityTextMarker):
951         (AccessibilityTextMarker::~AccessibilityTextMarker):
952         (AccessibilityTextMarker::isEqual):
953         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
954         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
955         (AccessibilityTextMarkerRange::isEqual):
956         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
957         (AccessibilityUIElement::textMarkerRangeForElement):
958         (AccessibilityUIElement::textMarkerRangeLength):
959         (AccessibilityUIElement::textMarkerRangeForMarkers):
960         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
961         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
962         (AccessibilityUIElement::accessibilityElementForTextMarker):
963         * DumpRenderTree/win/DumpRenderTree.vcproj:
964
965 2010-08-25  Tony Chang  <tony@chromium.org>
966
967         Reviewed by Ojan Vafai.
968
969         don't delete duplicates needed because of intermediate results
970         https://bugs.webkit.org/show_bug.cgi?id=44653
971
972         Also, output the full path so we can pipe the output to rm.
973
974         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
975         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
976
977 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
978
979         Reviewed by Andreas Kling.
980
981         [Qt] MiniBrowser does not starts properly
982         https://bugs.webkit.org/show_bug.cgi?id=45459
983
984         Do not try set up the first window by calling newWindow on a
985         newly created BrowserWindow since it creates a new object.
986         * MiniBrowser/qt/BrowserWindow.cpp:
987         (BrowserWindow::BrowserWindow):
988         * MiniBrowser/qt/main.cpp:
989         (main):
990
991 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
992
993         Reviewed by Xan Lopez.
994
995         [GTK] Get ImageDiff building on Win32
996         https://bugs.webkit.org/show_bug.cgi?id=45353
997
998         * DumpRenderTree/gtk/ImageDiff.cpp:
999         (main): Switch from using strtok to g_strsplit.
1000
1001 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
1002
1003         Reviewed by Andreas Kling.
1004
1005         [Qt] Modify load method of MiniBrowser's BrowserView class
1006         https://bugs.webkit.org/show_bug.cgi?id=45442
1007
1008         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
1009
1010         * MiniBrowser/qt/BrowserView.cpp:
1011         (BrowserView::load):
1012         * MiniBrowser/qt/BrowserView.h:
1013         * MiniBrowser/qt/BrowserWindow.cpp:
1014         (BrowserWindow::load):
1015
1016 2010-09-09  Tony Chang  <tony@chromium.org>
1017
1018         Reviewed by Ojan Vafai.
1019
1020         fix show_results in new-run-webkit-tests
1021         https://bugs.webkit.org/show_bug.cgi?id=45413
1022
1023         * Scripts/webkitpy/layout_tests/port/chromium.py:
1024
1025 2010-09-08  Victor Wang  <victorw@chromium.org>
1026
1027         Reviewed by Ojan Vafai.
1028
1029         [Chromium] Fix test results server to make sure
1030         it does not have corrupted data.
1031
1032         results.json file size coulbe be >1M and we split
1033         the data into multiple data store entries in this
1034         case. This patch fixes the issue that the data may
1035         be corrupted if data store error happens in the middle
1036         of saving multiple entries.
1037
1038         https://bugs.webkit.org/show_bug.cgi?id=45063
1039
1040         * TestResultServer/model/datastorefile.py:
1041
1042 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
1043
1044         Reviewed by Kenneth Rohde Christiansen.
1045
1046         Fix ignoring return value warning in case of gcc 4.4.4
1047         https://bugs.webkit.org/show_bug.cgi?id=45384
1048
1049         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1050         (testPostURLFile):
1051         If fwrite have written zero byte then the testPostURLFile function
1052         returns with false as tempFile can't be opened.
1053         * DumpRenderTree/qt/ImageDiff.cpp:
1054         (main):
1055         Put fwrite function into an if condition without body to avoid
1056         warning. It is safe because this function writes to the stdout.
1057
1058 2010-09-08  Satish Sampath  <satish@chromium.org>
1059
1060         Unreviewed, adding myself to committers list.
1061
1062         * Scripts/webkitpy/common/config/committers.py:
1063
1064 2010-09-08  Hans Wennborg  <hans@chromium.org>
1065
1066         Unreviewed.
1067
1068         Adding myself as a committer in committers.py.
1069
1070         * Scripts/webkitpy/common/config/committers.py:
1071
1072 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
1073
1074         Reviewed by Simon Hausmann.
1075
1076         [Qt] Refactor MiniBrowser 
1077         https://bugs.webkit.org/show_bug.cgi?id=45173
1078
1079         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
1080
1081         * MiniBrowser/qt/BrowserView.cpp: Added.
1082         (createNewPage):
1083         (BrowserView::BrowserView):
1084         (BrowserView::resizeEvent):
1085         (BrowserView::load):
1086         (BrowserView::view):
1087         * MiniBrowser/qt/BrowserView.h: Added.
1088         (BrowserView::~BrowserView):
1089         * MiniBrowser/qt/BrowserWindow.cpp:
1090         * MiniBrowser/qt/BrowserWindow.h:
1091         * MiniBrowser/qt/MiniBrowser.pro:
1092
1093 2010-09-08  Adam Barth  <abarth@webkit.org>
1094
1095         Rubber-stamped by Eric Seidel.
1096
1097         Rename DocLoader to CachedResourceLoader because that's what it does.
1098
1099         * Scripts/do-webcore-rename:
1100
1101 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
1102
1103         Reviewed by Ojan Vafai.
1104
1105         Enable incremental results.json generation for non-layout tests.
1106         https://bugs.webkit.org/show_bug.cgi?id=45315
1107
1108         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
1109
1110         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
1111
1112
1113 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1114
1115         Unreviewed, build fix
1116
1117         Missed one test in mac_unittest.py in previous change; for some
1118         reason the method is listed twice. I will fix both for now, but will
1119         figure this out in a later, not-time-sensitive patch.
1120
1121         https://bugs.webkit.org/show_bug.cgi?id=45357
1122
1123         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1124
1125 2010-09-07  Kent Tamura  <tkent@chromium.org>
1126
1127         Reviewed by Tony Chang.
1128
1129         test-webkitpy: Fix load error of
1130         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
1131         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
1132
1133         * Scripts/webkitpy/layout_tests/port/server_process.py:
1134           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
1135           and we don't use server_process.py on Win32 Python. However
1136           unittest.py tries to load everything in a module.
1137
1138 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
1139
1140         Reviewed by Kent Tamura.
1141
1142         Fix regression introduced in previous change to new-run-webkit-tests
1143         (bug 45090) to not try to run unittests for the Mac implementation
1144         of the Port interface if we aren't running on a Mac.
1145
1146         Also fix the overrides implementation mock in the chromium unittests
1147         to fix the case where there are overrides checked in that cause
1148         problems.
1149
1150         https://bugs.webkit.org/show_bug.cgi?id=45357
1151
1152         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1153         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1154         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1155
1156 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1157
1158         Reviewed by Ojan Vafai.
1159
1160         new-run-webkit-tests: still more unit tests
1161
1162         Clean up and remove unnecessary code. Biggest notable change is
1163         moving the chromium-specific imagediff code from port/base to
1164         port/chromium.
1165
1166         Add more unit tests for run_webkit_tests.py, port/base.py,
1167         port/factory.py, port/dryrun.py, and
1168         layout_package/dump_render_tree_thread.py
1169
1170         This covers almost all of the generic and test code paths except for
1171         a few error paths involving invalid or port-specific command line
1172         arguments, and the code path for uploading results files to the
1173         buildbots.
1174         
1175         https://bugs.webkit.org/show_bug.cgi?id=45090
1176
1177         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
1178         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1179         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1180         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1181         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1182         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1183         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
1184         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
1185         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1186         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
1187         * Scripts/webkitpy/layout_tests/port/base.py:
1188         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1189         * Scripts/webkitpy/layout_tests/port/chromium.py:
1190         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1191         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1192         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1193         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
1194         * Scripts/webkitpy/layout_tests/port/server_process.py:
1195         * Scripts/webkitpy/layout_tests/port/test.py:
1196         * Scripts/webkitpy/layout_tests/port/webkit.py:
1197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1198         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1199
1200 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
1201
1202         Reviewed by Darin Adler.
1203
1204         Provide a way to trigger a <select multiple> onchange event on changes
1205         https://bugs.webkit.org/show_bug.cgi?id=45192
1206
1207         Adds a selector on ObjCController for testing
1208         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
1209         its different uses.
1210
1211         * DumpRenderTree/mac/ObjCController.m:
1212         (+[ObjCController isSelectorExcludedFromWebScript:]):
1213         (+[ObjCController webScriptNameForSelector:]):
1214         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
1215
1216 2010-09-07  James Robinson  <jamesr@chromium.org>
1217
1218         Rubber-stamped by Dimitri Glazkov.
1219
1220         Move myself from the committer to the reviewer list.
1221
1222         * Scripts/webkitpy/common/config/committers.py:
1223
1224 2010-09-07  Tony Chang  <tony@chromium.org>
1225
1226         Reviewed by Darin Fisher.
1227
1228         [chromium] Make a public flag for how DRT generates bitmaps on Linux
1229         https://bugs.webkit.org/show_bug.cgi?id=45133
1230
1231         * DumpRenderTree/chromium/TestShell.cpp:
1232         (TestShell::dumpImage):
1233
1234 2010-09-07  Kent Tamura  <tkent@chromium.org>
1235
1236         Reviewed by Dimitri Glazkov.
1237
1238         [DRT/Chromium] Implement --check-layout-test-sys-deps
1239         https://bugs.webkit.org/show_bug.cgi?id=45283
1240
1241         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1242         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
1243         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
1244         * DumpRenderTree/chromium/TestShellGtk.cpp:
1245         (checkLayoutTestSystemDependencies): Add an empty implementation.
1246         * DumpRenderTree/chromium/TestShellMac.mm:
1247         (checkLayoutTestSystemDependencies): Add an empty implementation.
1248         * DumpRenderTree/chromium/TestShellWin.cpp:
1249         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
1250
1251 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1252
1253         Unreviewed. Mac build fix.
1254
1255         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1256         (didClearWindowObjectForFrame):
1257
1258 2010-09-07  Jessie Berlin  <jberlin@apple.com>
1259
1260         Reviewed by Darin Adler.
1261
1262         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
1263         https://bugs.webkit.org/show_bug.cgi?id=45217
1264         
1265         Make WebKitTestRunner work with this change.
1266
1267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1268         (WTR::InjectedBundlePage::didClearWindowForFrame):
1269         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
1270         WebFrameLoaderClient.
1271         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1272
1273 2010-09-07  Philippe Normand  <pnormand@igalia.com>
1274
1275         Unreviewed, build fix.
1276
1277         webkit-patch command to find the ports covering a specific layout test
1278         https://bugs.webkit.org/show_bug.cgi?id=42832
1279
1280         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
1281         tests are present when building the expectations. This is needed
1282         for the unittests.
1283
1284 2010-09-06  Philippe Normand  <pnormand@igalia.com>
1285
1286         Reviewed by Adam Barth.
1287
1288         webkit-patch command to find the ports covering a specific layout test
1289         https://bugs.webkit.org/show_bug.cgi?id=42832
1290
1291         To use it: webkit-patch skipped-ports some/layout/test.html
1292
1293         * Scripts/webkitpy/layout_tests/port/base.py:
1294         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1295         * Scripts/webkitpy/layout_tests/port/chromium.py:
1296         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1297         * Scripts/webkitpy/layout_tests/port/factory.py:
1298         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1299         * Scripts/webkitpy/layout_tests/port/test.py:
1300         * Scripts/webkitpy/layout_tests/port/webkit.py:
1301         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1302         * Scripts/webkitpy/tool/commands/queries.py:
1303         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1304         * Scripts/webkitpy/tool/main.py:
1305         * Scripts/webkitpy/tool/mocktool.py:
1306
1307 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1308
1309         Reviewed by Eric Seidel.
1310
1311         [NRWT] Add temp directory to all running drivers.
1312         https://bugs.webkit.org/show_bug.cgi?id=45261
1313
1314         * Scripts/webkitpy/layout_tests/port/webkit.py:
1315
1316 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
1317
1318         Reviewed by Kent Tamura.
1319
1320         [Chromium/DRT] Empty out user stylesheet after each test run.
1321         https://bugs.webkit.org/show_bug.cgi?id=45282
1322
1323         This should significantly cut down on the number of the mysterious flaky tests
1324         whose diffs looked like the page was blown up to a very lage size. This
1325         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
1326         which set the base body font to 100px.
1327
1328         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
1329         the same thread failed.
1330
1331         * DumpRenderTree/chromium/TestShell.cpp:
1332         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
1333
1334 2010-09-06  Kent Tamura  <tkent@chromium.org>
1335
1336         Reviewed by Dimitri Glazkov.
1337
1338         [DRT/Chromium] Do not generate pixel results for text/plain resources
1339         https://bugs.webkit.org/show_bug.cgi?id=45253
1340
1341         * DumpRenderTree/chromium/TestShell.cpp:
1342         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
1343
1344 2010-09-06  Ojan Vafai  <ojan@chromium.org>
1345
1346         Reviewed by Kent Tamura.
1347
1348         print out correct error when a DRT thread dies in NRWT
1349         https://bugs.webkit.org/show_bug.cgi?id=45281
1350
1351         Not sure why, but with the parens, python 2.6.5 on Linux
1352         gives an error that raise takes 5 arguments and 0 were given.
1353         Didn't test other platforms or python versions, but putting it
1354         all on one line fixes it and correctly prints the exception
1355         from the DRT thread.
1356
1357         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1358
1359 2010-09-06  Eric Seidel  <eric@webkit.org>
1360
1361         Unreviewed, just adding some emails from lists.webkit.org.
1362
1363         Update committers.py to include emails from lists.webkit.org
1364         as found by the validate-committer-lists script.
1365
1366         * Scripts/webkitpy/common/config/committers.py:
1367
1368 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
1369
1370         Reviewed by Xan Lopez.
1371
1372         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
1373         https://bugs.webkit.org/show_bug.cgi?id=45213
1374
1375         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1376         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
1377         have to surround the invocation with #ifdefs.
1378         (useLongRunningServerMode): Added.
1379         (runTestingServerLoop): Added.
1380         (initializeGlobalsFromCommandLineOptions): Added.
1381         (runTest): Removed ifdefs.
1382         (main): Use new helper functions.
1383
1384 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
1385
1386         Reviewed by Xan Lopez.
1387
1388         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
1389         https://bugs.webkit.org/show_bug.cgi?id=45235
1390
1391         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
1392         methods of the EventSender.
1393
1394         * DumpRenderTree/gtk/EventSender.cpp:
1395         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
1396         with the current modifiers.
1397         (contextClickCallback): Always send no modifiers when preparing the mouse event.
1398         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
1399         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
1400         (mouseUpCallback): Ditto.
1401
1402 2010-09-05  Peter Kasting  <pkasting@google.com>
1403
1404         Reviewed by Adam Barth.
1405
1406         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
1407         https://bugs.webkit.org/show_bug.cgi?id=45155
1408
1409         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
1410         (EventSender::handleMouseWheel):
1411
1412 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
1413
1414         Reviewed by Joseph Pecoraro.
1415
1416         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
1417         https://bugs.webkit.org/show_bug.cgi?id=45179
1418
1419         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1420         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1421
1422 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
1423
1424         Rubber-stamped by Daniel Bates.
1425
1426         Adding myself as reviewer.
1427
1428         * Scripts/webkitpy/common/config/committers.py:
1429
1430 2010-09-04  Daniel Bates  <dbates@rim.com>
1431
1432         Reviewed by Martin Robinson.
1433
1434         Teach svn-apply/unapply about svn:mergeinfo
1435         https://bugs.webkit.org/show_bug.cgi?id=45236
1436
1437         Recognize the svn:mergeinfo property and ignore it for now.
1438
1439         Currently, svn-apply/unapply recognize only '+' and '-'
1440         property changes within a diff. We should add support
1441         to recognize "Merged" and "Reverse-merged" changes as well.
1442         Because svn:mergeinfo is metadata that is used only by SVN
1443         and tends to be error-prone and/or nuisance (*), we will ignore
1444         it for now.
1445         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
1446
1447         * Scripts/VCSUtils.pm:
1448           - Modified parseSvnProperty() to recognize "Merged" and
1449             "Reverse-merged" as the start of a property value.
1450         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1451           - Added the following unit tests:
1452             "simple: add svn:mergeinfo"
1453             "simple: delete svn:mergeinfo"
1454             "simple: modified svn:mergeinfo"
1455         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1456           - Added the following unit tests:
1457             "simple: add svn:mergeinfo"
1458             "simple: delete svn:mergeinfo"
1459             "simple: modified svn:mergeinfo"
1460             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
1461             "'Merged' change followed by 'Merged' change"
1462             "'Reverse-merged' change followed by 'Reverse-merged' change"
1463         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1464           - Added the following unit tests:
1465             "'Merged' change"
1466             "'Reverse-merged' change"
1467             "'Reverse-merged' change followed by 'Merge' change"
1468             "'Merged' change followed by 'Merge' change"
1469             "'Reverse-merged' change followed by 'Reverse-merged' change"
1470             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
1471
1472 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1473
1474         Reviewed by Kenneth Rohde Christiansen.
1475
1476         [EFL] Move test browser to WebKitTools directory
1477         https://bugs.webkit.org/show_bug.cgi?id=45212
1478
1479         Follow other ports like QT and GTK which moved the test browser to
1480         WebKitTools directory.
1481
1482         * CMakeListsEfl.txt: Added.
1483         * EWebLauncher/main.c: Added.
1484         (print_history):
1485         (zoom_level_set):
1486         (on_ecore_evas_resize):
1487         (title_set):
1488         (viewport_set):
1489         (on_title_changed):
1490         (on_progress):
1491         (on_load_finished):
1492         (on_toolbars_visible_set):
1493         (on_toolbars_visible_get):
1494         (on_statusbar_visible_set):
1495         (on_statusbar_visible_get):
1496         (on_scrollbars_visible_set):
1497         (on_scrollbars_visible_get):
1498         (on_menubar_visible_set):
1499         (on_menubar_visible_get):
1500         (on_tooltip_text_set):
1501         (on_inputmethod_changed):
1502         (on_viewport_changed):
1503         (on_mouse_down):
1504         (on_focus_out):
1505         (on_focus_in):
1506         (on_resized):
1507         (on_key_down):
1508         (on_browser_del):
1509         (on_closeWindow):
1510         (quit):
1511         (browserCreate):
1512         (browserDestroy):
1513         (closeWindow):
1514         (main_signal_exit):
1515         (findThemePath):
1516         (main):
1517
1518 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
1519
1520         Reviewed by Adam Roben.
1521
1522         Set project dependencies so that they build serially. This fixes
1523         issues when running run-webkit-tests if DRT is not built yet.
1524
1525         * DumpRenderTree/DumpRenderTree.sln:
1526
1527 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
1528
1529         Reviewed by Adam Barth.
1530
1531         Fix reading configuraiton in NWRT to work on Windows.
1532         https://bugs.webkit.org/show_bug.cgi?id=45180
1533
1534         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
1535             with the file otherwise.
1536
1537 2010-09-03  Chris Rogers  <crogers@google.com>
1538
1539         Unreviewed
1540
1541         Add myself to the committers list
1542         https://bugs.webkit.org/show_bug.cgi?id=45189
1543
1544         * Scripts/webkitpy/common/config/committers.py:
1545
1546 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
1547
1548         Reviewed by Yury Semikhatsky.
1549
1550         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
1551         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
1552         https://bugs.webkit.org/show_bug.cgi?id=45137
1553
1554         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
1555
1556 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1557
1558         Reviewed by Eric Seidel.
1559
1560         Add feature detection support to NRWT.
1561         https://bugs.webkit.org/show_bug.cgi?id=41842
1562
1563         * Scripts/webkitpy/layout_tests/port/base.py:
1564         * Scripts/webkitpy/layout_tests/port/qt.py:
1565         * Scripts/webkitpy/layout_tests/port/webkit.py:
1566         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
1567
1568 2010-09-03  Hironori Bono  <hbono@chromium.org>
1569
1570         Reviewed by Kent Tamura.
1571
1572         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
1573         and implements it for Mac.
1574         https://bugs.webkit.org/show_bug.cgi?id=41832
1575
1576         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
1577         and bind it so we can call it from JavaScript.
1578         (+[TextInputController isSelectorExcludedFromWebScript:]):
1579         (+[TextInputController webScriptNameForSelector:]):
1580         (-[TextInputController hasSpellingMarker:length:]):
1581
1582 2010-09-02  Eric Seidel  <eric@webkit.org>
1583
1584         Reviewed by Adam Barth.
1585
1586         Add a unit test for commit-queue retries
1587         https://bugs.webkit.org/show_bug.cgi?id=45162
1588
1589         I think commit-queue retries are not correctly avoiding
1590         build and test on retries.  So I started testing the code.
1591         Unfortunately this test did not find the bug.  But now
1592         that we have the test we might as well keep it.
1593         I also fixed a broken import in validate-committer-lists.
1594
1595         * Scripts/validate-committer-lists:
1596         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1597
1598 2010-09-02  Kent Tamura  <tkent@chromium.org>
1599
1600         Reviewed by Dimitri Glazkov.
1601
1602         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
1603         https://bugs.webkit.org/show_bug.cgi?id=45091
1604
1605         Task.{cpp,h} introduces a simpler version of Chromium
1606         base/task.h. It doesn't have TupleN and Method.
1607
1608         * DumpRenderTree/DumpRenderTree.gypi:
1609          Add Task.cpp and Task.h
1610         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1611         (DRTDevToolsAgent::DRTDevToolsAgent):
1612         (DRTDevToolsAgent::reset):
1613         (DRTDevToolsAgent::asyncCall):
1614         (DRTDevToolsAgent::frontendLoaded):
1615         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1616         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
1617         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1618         (DRTDevToolsClient::DRTDevToolsClient):
1619         (DRTDevToolsClient::~DRTDevToolsClient):
1620         (DRTDevToolsClient::reset):
1621         (DRTDevToolsClient::asyncCall):
1622         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1623         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
1624         * DumpRenderTree/chromium/EventSender.cpp:
1625         (EventSender::EventSender):
1626         (EventSender::reset):
1627         (EventSender::scheduleAsynchronousClick):
1628         * DumpRenderTree/chromium/EventSender.h:
1629         (EventSender::taskList): Added to use MethodTask<T>.
1630         * DumpRenderTree/chromium/LayoutTestController.cpp:
1631         (LayoutTestController::LayoutTestController):
1632         (LayoutTestController::WorkQueue::processWorkSoon):
1633         (LayoutTestController::waitUntilDone):
1634         (LayoutTestController::notifyDone):
1635         (LayoutTestController::reset):
1636         * DumpRenderTree/chromium/LayoutTestController.h:
1637         (LayoutTestController::taskList): Added to use MethodTask<T>.
1638         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
1639         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1640         (deferredDisplayDispatch):
1641         (NotificationPresenter::show):
1642         * DumpRenderTree/chromium/Task.cpp: Added.
1643         * DumpRenderTree/chromium/Task.h: Added.
1644
1645 2010-09-02  Steve Block  <steveblock@google.com>
1646
1647         Reviewed by Adam Barth.
1648
1649         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
1650         https://bugs.webkit.org/show_bug.cgi?id=43181
1651
1652         * DumpRenderTree/mac/DumpRenderTree.mm:
1653         (createWebViewAndOffscreenWindow):
1654         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1655         (LayoutTestController::setMockDeviceOrientation):
1656
1657 2010-08-31  Adam Roben  <aroben@apple.com>
1658
1659         Fix flashiness when resizing the browser window on Windows
1660
1661         Reviewed by Sam Weinig.
1662
1663         * MiniBrowser/win/BrowserWindow.cpp:
1664         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
1665         periodically fill the window with white.
1666
1667 2010-09-02  Peter Kasting  <pkasting@google.com>
1668
1669         Reviewed by Dimitri Glazkov.
1670
1671         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
1672         https://bugs.webkit.org/show_bug.cgi?id=45073
1673
1674         * DumpRenderTree/chromium/EventSender.cpp:
1675         (EventSender::EventSender):
1676         (EventSender::mouseScrollBy):
1677         (EventSender::continuousMouseScrollBy):
1678         (EventSender::sendCurrentTouchEvent):
1679         (EventSender::handleMouseWheel):
1680         * DumpRenderTree/chromium/EventSender.h:
1681         * DumpRenderTree/gtk/EventSender.cpp:
1682         (mouseScrollByCallback):
1683         (continuousMouseScrollByCallback):
1684
1685 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
1686
1687         Reviewed by Tony Chang.
1688
1689         Land a patched version of r66542 - change TestRunner to have an
1690         separate cleanup method and fix the ordering of cleanup between
1691         TestRunner and the printing module, and then wrap everything in a
1692         try/finally block to ensure reliable cleanup without needing to
1693         rely on stuff happening in the destructor of the TestRunner.
1694
1695         Also refactor run_webkit_tests.run() to be much smaller and cleaner
1696         by creating a bunch of helper methods and moving more stuff into
1697         the TestRunner class.
1698
1699         This fixes the crash at the end of the linux test run of
1700         new-run-webkit-tests (and undoes the rollout in 66547).
1701
1702         https://bugs.webkit.org/show_bug.cgi?id=44902
1703
1704         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1705         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1706         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1707         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1708         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1709         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1710         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1711         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1712         * Scripts/webkitpy/layout_tests/port/base.py:
1713         * Scripts/webkitpy/layout_tests/port/test.py:
1714         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1715         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1716
1717 2010-09-01  Mark Rowe  <mrowe@apple.com>
1718
1719         Reviewed by Adam Roben.
1720
1721         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
1722
1723         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1724
1725 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
1726
1727         Reviewed by Adam Roben.
1728
1729         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
1730         and WebKitTestRunner.
1731
1732         * BuildSlaveSupport/win/kill-old-processes:
1733
1734 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1735
1736         Reviewed by Antonio Gomes.
1737
1738         [Qt] Remove obsolete include path from DumpRenderTree.pro
1739
1740         * DumpRenderTree/qt/DumpRenderTree.pro:
1741
1742 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1743
1744         Reviewed by Laszlo Gombos.
1745
1746         [Qt] QWebPage::allowGeolocationRequest should be async API
1747         https://bugs.webkit.org/show_bug.cgi?id=41364
1748
1749         Implements new async API for geolocation permission similar to
1750         Notification. WebPage maintains list of geolocation permission request
1751         QtWebkit and set's when LayoutTestController gets the access from test JS
1752
1753         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1754         (WebCore::WebPage::WebPage):
1755         (WebCore::WebPage::resetSettings):
1756         (WebCore::WebPage::requestPermission):
1757         (WebCore::WebPage::cancelPermission):
1758         (WebCore::WebPage::permissionSet):
1759         (WebCore::DumpRenderTree::DumpRenderTree):
1760         (WebCore::DumpRenderTree::processLine):
1761         (WebCore::DumpRenderTree::geolocationPermissionSet):
1762         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1763         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1764         (LayoutTestController::reset):
1765         (LayoutTestController::setGeolocationPermission):
1766         (LayoutTestController::setGeolocationPermissionCommon):
1767         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1768
1769 2010-09-01  Andras Becsi  <abecsi@webkit.org>
1770
1771         Reviewed by Antti Koivisto.
1772
1773         [Qt] Auto-generate WebKit2 forwarding headers
1774         https://bugs.webkit.org/show_bug.cgi?id=44692
1775
1776         * MiniBrowser/qt/BrowserWindow.h: use source style includes
1777         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
1778         * Scripts/enumerate-included-framework-headers: Removed.
1779
1780 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1781
1782         Reviewed by Adam Barth.
1783
1784         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
1785         https://bugs.webkit.org/show_bug.cgi?id=44789
1786
1787         * Scripts/webkitpy/common/net/bugzilla.py:
1788
1789 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
1790
1791         Reviewed by Adam Barth.
1792
1793         ews: Add support for EFL-EWS
1794         https://bugs.webkit.org/show_bug.cgi?id=44982
1795
1796         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
1797         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
1798         and add it to the ports dict.
1799         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
1800         EflEWS class.
1801         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
1802         a test case for the EFL EWS.
1803
1804 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
1805
1806         Reviewed by Sam Weinig.
1807
1808         https://bugs.webkit.org/show_bug.cgi?id=42195
1809         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
1810
1811         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1812         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
1813         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1814         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
1815         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
1816
1817         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
1818         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
1819         which forgets its override.
1820
1821 2010-08-31  Sam Weinig  <sam@webkit.org>
1822
1823         Reviewed by Gavin Barraclough.
1824
1825         WebKitTestRunner needs layoutTestController.addUserStyleSheet
1826         https://bugs.webkit.org/show_bug.cgi?id=42680
1827
1828         WebKitTestRunner needs layoutTestController.addUserScript
1829         https://bugs.webkit.org/show_bug.cgi?id=42681
1830
1831         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1832         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1833         (WTR::InjectedBundle::beginTesting):
1834         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1835         (WTR::LayoutTestController::addUserScript):
1836         (WTR::LayoutTestController::addUserStyleSheet):
1837         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1838
1839 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1840
1841         Unreviewed, rolling out r66542.
1842         http://trac.webkit.org/changeset/66542
1843         https://bugs.webkit.org/show_bug.cgi?id=44902
1844
1845         r66542 - the weird logging dependencies in Python stuck again ...
1846
1847         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
1848         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
1849         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
1850         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
1851         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1852         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1853         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1854         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1855         * Scripts/webkitpy/layout_tests/port/base.py:
1856         * Scripts/webkitpy/layout_tests/port/test.py:
1857         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1858         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1859
1860 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
1861
1862         Reviewed by Tony Chang.
1863
1864         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
1865
1866         * DumpRenderTree/chromium/LayoutTestController.cpp:
1867         (LayoutTestController::LayoutTestController):
1868         (LayoutTestController::markerTextForListItem):
1869         * DumpRenderTree/chromium/LayoutTestController.h:
1870
1871 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
1872
1873         Reviewed by Ojan Vafai.
1874
1875         new-run-webkit-tests: add more unit tests
1876
1877         Add more unit tests for new-run-webkit-tests; we now cover all but
1878         the most obscure code paths in the generic code. We still need to
1879         add coverage for the http server and web socket paths, and add better
1880         coverage of the platform-specific logic. Note that the rebaselining
1881         tool is still not well tested.
1882
1883         Also clean up some of the configuration logic for the printing
1884         module and the way it interacts with the Python logging module; that
1885         is a crufty interface, to be certain.
1886         
1887         https://bugs.webkit.org/show_bug.cgi?id=44902
1888
1889         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
1890         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
1891         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
1892         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
1893         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1894         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1895         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1896         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1897         * Scripts/webkitpy/layout_tests/port/base.py:
1898         * Scripts/webkitpy/layout_tests/port/test.py:
1899         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1900         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1901
1902 2010-08-31  Darin Adler  <darin@apple.com>
1903
1904         Reviewed by Anders Carlsson.
1905
1906         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
1907         in a debug build when built with certain compilers.
1908
1909 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
1910
1911         Reviewed by Gustavo Noronha Silva.
1912
1913         [GTK] Isolate all GTK+ typedefs into one file
1914         https://bugs.webkit.org/show_bug.cgi?id=44900
1915
1916         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
1917
1918 2010-08-31  Eric Seidel  <eric@webkit.org>
1919
1920         Reviewed by Adam Barth.
1921
1922         Show more status on queue status pages
1923         https://bugs.webkit.org/show_bug.cgi?id=44938
1924
1925         I upped the number of status lines from 6 to 15 --
1926         this has been bugging me for a while...
1927
1928         I also disabled showing the chromium-win EWS queue
1929         since it's been down for almost 5 months now.
1930
1931         * QueueStatusServer/handlers/dashboard.py:
1932         * QueueStatusServer/handlers/queuestatus.py:
1933         * QueueStatusServer/model/queues.py:
1934
1935 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
1936
1937         Reviewed by Antonio Gomes.
1938
1939         [Qt] Read command line arguments and open them as URLs in new windows
1940         https://bugs.webkit.org/show_bug.cgi?id=44944
1941
1942         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
1943
1944         * MiniBrowser/qt/main.cpp:
1945         (main):
1946
1947 2010-08-31  Adrian Perez  <aperez@igalia.com>
1948
1949         Reviewed by Martin Robinson.
1950
1951         Support scripts to run Buildbot slaves under daemontools (gtk related)
1952         https://bugs.webkit.org/show_bug.cgi?id=40053
1953
1954         * BuildSlaveSupport/gtk: Added.
1955         * BuildSlaveSupport/gtk/README: Added.
1956         * BuildSlaveSupport/gtk/buildbot: Added.
1957         * BuildSlaveSupport/gtk/buildbot/log: Added.
1958         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
1959         * BuildSlaveSupport/gtk/buildbot/run: Added.
1960         * BuildSlaveSupport/gtk/crashmon: Added.
1961         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
1962         * BuildSlaveSupport/gtk/crashmon/log: Added.
1963         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
1964         * BuildSlaveSupport/gtk/crashmon/run: Added.
1965         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
1966         * BuildSlaveSupport/gtk/pulseaudio: Added.
1967         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
1968         * BuildSlaveSupport/gtk/xvfb: Added.
1969         * BuildSlaveSupport/gtk/xvfb/log: Added.
1970         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
1971         * BuildSlaveSupport/gtk/xvfb/run: Added.
1972
1973 2010-08-27  John Gregg  <johnnyg@google.com>
1974
1975         Reviewed by David Levin.
1976
1977         Notifications should support a click event.
1978         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
1979         can be simulated during a layout test.  Requires storing a list of active
1980         notifications so that they can be referred to later for clicking.
1981         https://bugs.webkit.org/show_bug.cgi?id=44800
1982
1983         * DumpRenderTree/chromium/LayoutTestController.cpp:
1984         (LayoutTestController::LayoutTestController):
1985         (LayoutTestController::simulateDesktopNotificationClick):
1986         * DumpRenderTree/chromium/LayoutTestController.h:
1987         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1988         (NotificationPresenter::simulateClick):
1989         (NotificationPresenter::show):
1990         (NotificationPresenter::cancel):
1991         (NotificationPresenter::objectDestroyed):
1992         * DumpRenderTree/chromium/NotificationPresenter.h:
1993
1994 2010-08-30  Alice Liu  <alice.liu@apple.com>
1995
1996         Reviewed by Darin Adler.
1997
1998         Add missing parts of didFinishDocumentLoadForFrame
1999         https://bugs.webkit.org/show_bug.cgi?id=44913
2000
2001         * MiniBrowser/mac/BrowserWindowController.m:
2002         (didFinishDocumentLoadForFrame): Added
2003         (-[BrowserWindowController awakeFromNib]): Updated struct
2004         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2005         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
2006         * WebKitTestRunner/TestController.cpp:
2007         (WTR::TestController::initialize): Updated struct
2008
2009 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
2010
2011         Unreviewed: Add myself to the list of Committers.
2012
2013         * Scripts/webkitpy/common/config/committers.py:
2014
2015 2010-08-30  Kent Tamura  <tkent@chromium.org>
2016
2017         Reviewed by Adam Barth.
2018
2019         Fix fast/notifications/notifications-display-close-events.html failure
2020         https://bugs.webkit.org/show_bug.cgi?id=44585
2021
2022         Apply http://crrev.com/48893. We should dispatch display events
2023         asynchronously.
2024
2025         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2026         (deferredDisplayDispatch):
2027         (NotificationPresenter::show):
2028
2029 2010-08-30  Robert Hogan  <robert@webkit.org>
2030
2031         Reviewed by Simon Hausmann.
2032
2033         allow ports with windowed plugins to support windowless plugin tests
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=40730
2036
2037         Ports that implement plugins windowed by default need to have a way of
2038         supporting plugin tests that assume the plugin is windowless. Add this
2039         feature to the tests and support it in the webkit test plugin. Also
2040         add mouse and keyboard event logging to the webkit-test plugin on Unix.
2041
2042         Unskip the following tests on Qt:
2043
2044         plugins/mouse-events.html
2045         plugins/keyboard-events.html
2046         plugins/mouse-events-fixedpos.html
2047
2048         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2049         (pluginSetProperty):
2050         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2051         (NPP_New):
2052         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2053         (webkit_test_plugin_handle_event):
2054
2055 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
2056
2057         [wx] Build fix after addition of fileapi directory in WebCore.
2058
2059         * wx/build/settings.py:
2060
2061 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2062
2063         Reviewed by Xan Lopez.
2064
2065         Fixed compilation error, now that we have included the
2066         GtkVersioning.h we have to remove some version dependent code from
2067         EventSender.
2068
2069         * DumpRenderTree/gtk/EventSender.cpp:
2070
2071 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
2072
2073         Reviewed by Martin Robinson.
2074
2075         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
2076         are deprecated
2077         https://bugs.webkit.org/show_bug.cgi?id=44787
2078
2079         We have replaced GtkVersioning.cpp with GtkVersioning.c and
2080         created a function (getDefaultGDKPointerDevice) to get the pointer
2081         of the window with the new APIs. We added that function to DRT and
2082         copyandpaste unit test.
2083
2084         * DumpRenderTree/gtk/EventSender.cpp:
2085         (prepareMouseButtonEvent):
2086         (mouseMoveToCallback):
2087         (keyDownCallback):
2088         * GNUmakefile.am:
2089
2090 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
2091
2092         Reviewed by Kenneth Rohde Christiansen.
2093
2094         [Qt] Add new window menu to MiniBrowser
2095
2096         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
2097
2098         * MiniBrowser/qt/BrowserWindow.cpp:
2099         (BrowserWindow::BrowserWindow):
2100         (BrowserWindow::newWindow):
2101         * MiniBrowser/qt/BrowserWindow.h:
2102         * MiniBrowser/qt/main.cpp:
2103         (main):
2104
2105 2010-08-29  James Robinson  <jamesr@chromium.org>
2106
2107         Reviewed by David Levin.
2108
2109         Make failing the download step fail the build
2110         https://bugs.webkit.org/show_bug.cgi?id=44298
2111
2112         If the download step fails on a test bot, this ensures that
2113         the build goes red instead of only the download step going red
2114         and the overall build staying green.
2115
2116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2117
2118 2010-08-29  Kent Tamura  <tkent@chromium.org>
2119
2120         Reviewed by Dimitri Glazkov.
2121
2122         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
2123         https://bugs.webkit.org/show_bug.cgi?id=44847
2124
2125         * DumpRenderTree/chromium/EventSender.cpp:
2126          Use webkit_support::VKEY_* instead of base::VKEY_*.
2127
2128 2010-08-29  Darin Adler  <darin@apple.com>
2129
2130         https://bugs.webkit.org/show_bug.cgi?id=40589
2131
2132         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
2133         function names.
2134
2135 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2136
2137         Reviewed by Darin Adler.
2138
2139         [iExploder] Add new CSS Properties and HTML Attributes
2140         https://bugs.webkit.org/show_bug.cgi?id=44746
2141
2142         Updated the files with the update-iexploder-cssproperties script
2143         and manually readded the -webkit-binding CSS Property to the list.
2144
2145         * iExploder/htdocs/cssproperties.in:
2146         * iExploder/htdocs/htmlattrs.in:
2147         * iExploder/htdocs/htmltags.in:
2148
2149 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2150
2151         Reviewed by Darin Adler.
2152
2153         Fix Coverage build after the addition of ANGLE
2154         https://bugs.webkit.org/show_bug.cgi?id=44744
2155
2156         ANGLE is using libtool to build a static library and the version of
2157         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
2158         parameters. The easiest way to handle this is to not build ANGLE with
2159         coverage information.
2160
2161         This is achieved by applying the XCode options for each project
2162         separately and exclude ANGLE.
2163
2164         * Scripts/build-webkit: Remove -framework AppKit due link errors.
2165         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
2166
2167 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
2168
2169         [wx] Build fix after directory addition.
2170
2171         * wx/build/settings.py:
2172
2173 2010-08-28  Chris Guillory   <chris.guillory@google.com>
2174
2175         Reviewed by Chris Fleizach.
2176
2177         Add AX notification for childrenChanged
2178         https://bugs.webkit.org/show_bug.cgi?id=44472
2179
2180         * DumpRenderTree/chromium/AccessibilityController.cpp:
2181         (AccessibilityController::AccessibilityController):
2182         (AccessibilityController::reset):
2183         (AccessibilityController::getRootElement):
2184         (AccessibilityController::dumpAccessibilityNotifications):
2185         * DumpRenderTree/chromium/AccessibilityController.h:
2186         (AccessibilityController::shouldDumpAccessibilityNotifications):
2187         * DumpRenderTree/chromium/WebViewHost.cpp:
2188         (WebViewHost::didChangeAccessibilityObjectChildren):
2189         * DumpRenderTree/chromium/WebViewHost.h:
2190
2191 2010-08-28  Eric Seidel  <eric@webkit.org>
2192
2193         Reviewed by Adam Barth.
2194
2195         Update commit-queue failure message
2196         https://bugs.webkit.org/show_bug.cgi?id=44798
2197
2198         The commit-queue auto-restarts itself and has for a very long time.
2199         No need for people to email me to request a restart anymore.
2200
2201         * Scripts/webkitpy/common/net/bugzilla.py:
2202         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2203         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2204
2205 2010-07-27  Jer Noble  <jer.noble@apple.com>
2206
2207         Reviewed by Eric Carlson.
2208
2209         Add JavaScript API to allow a page to go fullscreen.
2210         rdar://problem/6867795
2211         
2212         Added basic full screen support to DumpRenderTree: when a webView requests
2213         that DumpRenderTree go "full screen", just call the provided callback listener object's
2214         will/did Enter/Exit full screen methods.  Also, register a new user default which 
2215         enables full screen support.
2216
2217         * DumpRenderTree/mac/DumpRenderTree.mm:
2218         (resetDefaultsToConsistentValues):
2219         * DumpRenderTree/mac/UIDelegate.mm:
2220         (-[UIDelegate webView:supportsFullscreenForElement:]):
2221         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
2222         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
2223
2224 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2225
2226         Unreviewed. Add myself to the committers list.
2227
2228         * Scripts/webkitpy/common/config/committers.py:
2229
2230 2010-08-27  Kent Tamura  <tkent@chromium.org>
2231
2232         Reviewed by Pavel Feldman.
2233
2234         [DRT/Chromium] Fix inspector test failures
2235         https://bugs.webkit.org/show_bug.cgi?id=44748
2236
2237         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2238         (DRTDevToolsAgent::createClientMessageLoop):
2239           Returns a valid WebKitClientMessageLoop instance
2240         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2241
2242 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
2243
2244         Add Windows WebKit2 Tester to buildbot
2245         <rdar://problem/7887703>
2246
2247         Reviewed by Dan Bernstein.
2248
2249         * BuildSlaveSupport/build.webkit.org-config/config.json:
2250
2251 2010-08-26  Philippe Normand  <pnormand@igalia.com>
2252
2253         Reviewed by Martin Robinson.
2254
2255         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2256         https://bugs.webkit.org/show_bug.cgi?id=42152
2257
2258         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2259         (LoadHTMLStringItem::invoke): Implementation using
2260         webkit_web_frame_load_string().
2261
2262 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
2263
2264         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
2265         WebKitTestRunner (44331)
2266
2267         Reviewed by Darin Adler.
2268
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::initialize):
2271         The hang occurs when WebKitTestRunner begins launching the WebKit2
2272         web process then exits before it finishes launching. Work around this by
2273         looking for the --print-supported-features argument and exiting without
2274         creating the web process.
2275
2276 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
2277
2278         Reviewed by Tony Chang.
2279
2280         new-run-webkit-tests: add rebaselining tests for test_expectations
2281         
2282         This patch adds more unit tests for the rebaselining code in the
2283         test_expectations module. It doesn't add any tests for
2284         rebaseline_chromium_webkit_tests itself; that will come some other
2285         time.
2286
2287         https://bugs.webkit.org/show_bug.cgi?id=44648
2288
2289         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2290         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2291
2292 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2293
2294         Reviewed by Martin Robinson.
2295
2296         [GTK] Add HTTP caching support
2297         https://bugs.webkit.org/show_bug.cgi?id=44261
2298
2299         Ignore new soup API that we decided to merge into the soup backend
2300         while it is being cooked. It follows the libsoup style, and will
2301         be removed from WebKit as soon as it is merged into libsoup.
2302
2303         * Scripts/webkitpy/style/checker.py:
2304
2305 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2306
2307         Reviewed by Kenneth Rohde Christiansen.
2308
2309         [Qt] DumpRenderTree runs only one test from command mode
2310         https://bugs.webkit.org/show_bug.cgi?id=44012
2311
2312         Enables support to run multiple test files and single
2313         folder containing html files in stand alone mode
2314
2315         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2316         (WebCore::DumpRenderTree::DumpRenderTree):
2317         (WebCore::DumpRenderTree::processArgsLine):
2318         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2319         (WebCore::DumpRenderTree::processLine):
2320         (WebCore::DumpRenderTree::dump):
2321         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2322         (WebCore::DumpRenderTree::setStandAloneMode):
2323         (WebCore::DumpRenderTree::isStandAloneMode):
2324         * DumpRenderTree/qt/main.cpp:
2325         (main):
2326
2327 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2328
2329         Updating webkitpy test expectations.
2330
2331         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2332
2333 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2334
2335         Reviewed by Eric Seidel.
2336
2337         fix the always squash git config
2338         https://bugs.webkit.org/show_bug.cgi?id=44651
2339
2340         Fix help text and apparently underscores are not allowed
2341         in git config keys.
2342
2343         * Scripts/webkitpy/common/checkout/scm.py:
2344         * Scripts/webkitpy/tool/steps/commit.py:
2345
2346 2010-08-25  Darin Adler  <darin@apple.com>
2347
2348         Reviewed by John Sullivan.
2349
2350         * Scripts/commit-log-editor: Fix perl warning for people who have no
2351         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
2352
2353 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2354
2355         Reviewed by Eric Seidel.
2356
2357         stop blocking commits when the bots are red
2358         https://bugs.webkit.org/show_bug.cgi?id=44644
2359
2360         This check currently is just annoying. It doesn't actually
2361         help keep the tree green. We can always add it back later
2362         if we decide the tree is generally more green.
2363
2364         * Scripts/webkitpy/tool/commands/download_unittest.py:
2365         * Scripts/webkitpy/tool/mocktool.py:
2366         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2367
2368 2010-08-25  Eric Seidel  <eric@webkit.org>
2369
2370         Reviewed by Simon Fraser.
2371
2372         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
2373         https://bugs.webkit.org/show_bug.cgi?id=38912
2374
2375         I know of nothing else to do but skip all media tests for the cq.
2376
2377         * Scripts/webkitpy/tool/steps/runtests.py:
2378
2379 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2380
2381         Reviewed by Ojan Vafai.
2382
2383         new-run-webkit-tests: add more unit tests for test_expectations
2384         This adds unit tests to cover (almost?) all of the non-rebaselining
2385         functionality.
2386
2387         https://bugs.webkit.org/show_bug.cgi?id=44579
2388
2389         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2390         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2391
2392 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2393
2394         Reviewed by Ojan Vafai.
2395
2396         new-run-webkit-tests: add more unit tests
2397
2398         This change adds more unit tests for the image_diff, test_failures,
2399         and test_files modules, bringing them to 100% coverage (and adds a
2400         couple tests to run_webkit_tests while we're at it).
2401
2402         This test also turns on the "dryrun" port for testing when run on
2403         the mac, increasing coverage in a few other places.
2404
2405         https://bugs.webkit.org/show_bug.cgi?id=44578
2406
2407         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
2408         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
2409         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
2410         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
2411         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
2412         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
2413         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
2414         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
2415         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2416         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
2417         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2418         * Scripts/webkitpy/layout_tests/port/test.py:
2419         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2420
2421 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
2422
2423         Reviewed by Ojan Vafai.
2424
2425         new-run-webkit-tests: add more unit tests for layout_package/printing.py
2426
2427         This change adds more unit tests to get the test coverage to 100%
2428         for the printing module. This code is actually pretty crufty and
2429         has some layering violations that need to be cleaned up but I'll
2430         save that for another CL after we get all the unit tests written and
2431         we fix the multithreading issues. At least now we'll be able to tell
2432         if we break things.
2433
2434         https://bugs.webkit.org/show_bug.cgi?id=44576
2435
2436         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2437         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2438
2439 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2440
2441         Reviewed by Adam Barth.
2442
2443         new-run-webkit-tests should respect set-webkit-configuration
2444         https://bugs.webkit.org/show_bug.cgi?id=44633
2445
2446         Moves the getting of the configuration into the base Port so that
2447         chromium ports use it as well. In the downstream chromium port,
2448         this should still just return Release.
2449
2450         * Scripts/webkitpy/layout_tests/port/base.py:
2451         * Scripts/webkitpy/layout_tests/port/webkit.py:
2452
2453 2010-08-25  Tony Chang  <tony@chromium.org>
2454
2455         Not reviewed, changing svn props for a script.
2456
2457         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
2458
2459 2010-08-25  Adam Barth  <abarth@webkit.org>
2460
2461         Reviewed by Eric Seidel.
2462
2463         Remove WebKit2 from core builders
2464         https://bugs.webkit.org/show_bug.cgi?id=44625
2465
2466         This builder was added to the core builders by accident.  It doesn't
2467         appear to be green enough to be a core builder yet.
2468
2469         * Scripts/webkitpy/common/net/buildbot.py:
2470         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2471
2472 2010-08-19  Adam Roben  <aroben@apple.com>
2473
2474         Test that NP_Initialize and NP_GetEntryPoints are called in the
2475         correct order
2476
2477         The order differs between Mac and Windows (see r38858).
2478
2479         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2480         NP_Initialize when loading QuickTime when running
2481         plugins/embed-attributes-setting.html in WebKit2 on Windows
2482
2483         Reviewed by John Sullivan.
2484
2485         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
2486         a boolean to record whether NP_GetEntryPoints has been called.
2487         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
2488         called yet. This matches Flash and QuickTime's behavior.
2489         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
2490         yet. This matches Silverlight's behavior.
2491
2492 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
2493
2494         Reviewed by Gustavo Noronha Silva.
2495
2496         Cairo and EFL port shouldn't depend on glib.
2497         https://bugs.webkit.org/show_bug.cgi?id=44354
2498
2499         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
2500         adoptPlatformRef.
2501
2502         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2503         (AccessibilityUIElement::isSelected):
2504
2505 2010-08-25  Ojan Vafai  <ojan@chromium.org>
2506
2507         Fix order of Timothy's email address. The script, and
2508         other tools all assume that the first email is the bugzilla address.
2509
2510         * Scripts/webkitpy/common/config/committers.py:
2511
2512 2010-08-24  Kent Tamura  <tkent@chromium.org>
2513
2514         Reviewed by Pavel Feldman.
2515
2516         [DRT/Chromium] Fix 26 inspector test crashes
2517         https://bugs.webkit.org/show_bug.cgi?id=44580
2518
2519         - DRTDevToolsAgent has a reference to the main WebView. So we
2520           should not clear it in closeDevTools() and should clear it in
2521           ~TestShell().
2522         - DRTDevToolsClient has a reference to a DevTools WebView and no
2523           way to update it. So we should delete DRTDevToolsClient instances
2524           in closeDevTools().
2525
2526         * DumpRenderTree/chromium/TestShell.cpp:
2527         (TestShell::~TestShell):
2528         (TestShell::closeDevTools):
2529
2530 2010-08-24  Eric Seidel  <eric@webkit.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
2535         https://bugs.webkit.org/show_bug.cgi?id=44584
2536
2537         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2538
2539 2010-08-24  Eric Seidel  <eric@webkit.org>
2540
2541         Reviewed by Adam Barth.
2542
2543         commit-queue and EWS bots should report all failures
2544         https://bugs.webkit.org/show_bug.cgi?id=41820
2545
2546         Right now commit-queue/EWS only report failures when the
2547         patch under testing fails.  We should report all failures
2548         to the status server so that we can diagnose when the bots
2549         are wedged w/o needing to log into the machines.
2550
2551         I also reduced the amount of data we upload since we've seen
2552         timeouts during status upload.
2553
2554         * Scripts/webkitpy/common/system/executive.py:
2555         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2556         * Scripts/webkitpy/tool/commands/queues.py:
2557         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2558
2559 2010-08-24  Eric Seidel  <eric@webkit.org>
2560
2561         Reviewed by Adam Barth.
2562
2563         Remove HTML5 parser testing infrastructure now that we don't need it
2564         https://bugs.webkit.org/show_bug.cgi?id=44581
2565
2566         * DumpRenderTree/mac/DumpRenderTree.mm:
2567         (resetDefaultsToConsistentValues):
2568         (initializeGlobalsFromCommandLineOptions):
2569         * Scripts/old-run-webkit-tests:
2570         * Scripts/test-html5-parser: Removed.
2571
2572 2010-08-24  Kent Tamura  <tkent@chromium.org>
2573
2574         Reviewed by Dimitri Glazkov.
2575
2576         [DRT/Chromium] Fix 28 inspector test crashes
2577         https://bugs.webkit.org/show_bug.cgi?id=44574
2578
2579         Reset DevToolsClient and DevToolsAgent before closing a DevTools
2580         WebView in order to avoid accessing to a deleted WebView instance.
2581
2582         * DumpRenderTree/chromium/TestShell.cpp:
2583         (TestShell::closeDevTools):
2584
2585 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2586
2587         Reviewed by Ojan Vafai.
2588
2589         new-run-webkit-tests: clean up code for test_types, test_failures
2590
2591         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
2592         webkitpy.layout_tests.layout_package.test_failures, and remove
2593         some dead code and otherwise clean up things.
2594
2595         https://bugs.webkit.org/show_bug.cgi?id=44559
2596
2597         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2598         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
2599         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2600         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2601         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2602         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
2603         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2604
2605 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2606
2607         Reviewed by Eric Seidel.
2608
2609         new-run-webkit-tests: revise unit testing strategy for test failures
2610     
2611         This change revamps the way we store test data for new-run-webkit-tests.
2612         Previously we had a few copies of test files from the main test tree.
2613         Now we have a bunch of completely fake test data and use the test
2614         data to generate different kinds of test failures, getting
2615         much better coverage.
2616
2617         https://bugs.webkit.org/show_bug.cgi?id=44556
2618
2619         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
2620         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
2621         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
2622         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
2623         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
2624         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
2625         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
2626         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
2627         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
2628         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
2629         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
2630         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
2631         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
2632         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
2633         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
2634         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
2635         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
2636         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
2637         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
2638         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
2639         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
2640         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
2641         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
2642         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
2643         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
2644         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
2645         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
2646         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
2647         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
2648         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
2649         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
2650         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
2651         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
2652         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
2653         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
2654         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
2655         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
2656         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
2657         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
2658         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
2659         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
2660         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
2661         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
2662         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
2663         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
2664         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
2665         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2666         * Scripts/webkitpy/layout_tests/port/test.py:
2667         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2668         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2669
2670 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
2671
2672         Reviewed by Eric Seidel.
2673
2674         speed up new-run-webkit-tests unit tests
2675
2676         Add a --no-record-results flag that turns off generating the JSON
2677         results file on every test run. Generating the file requires us to
2678         fetch the old results down from the bots, which can be slow. This
2679         flag is off by default.
2680     
2681         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
2682     
2683         These changes together shorten the test cycle from ~4.5s to ~1.5s
2684         - a 3x speedup.
2685
2686         https://bugs.webkit.org/show_bug.cgi?id=44553
2687
2688         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2689         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2690
2691 2010-08-24  Tony Chang  <tony@chromium.org>
2692
2693         Reviewed by Eric Seidel.
2694
2695         [chromium] fix the platform result fallback order on mac/win
2696         https://bugs.webkit.org/show_bug.cgi?id=44483
2697
2698         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2699
2700 2010-08-24  Xan Lopez  <xlopez@igalia.com>
2701
2702         Reviewed by Martin Robinson.
2703
2704         Set a device to the event struct when building with GTK+ 3.x, it's
2705         mandatory.
2706
2707         * DumpRenderTree/gtk/EventSender.cpp:
2708         (keyDownCallback):
2709
2710 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2711
2712         Reviewed by Xan Lopez.
2713
2714         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2715         https://bugs.webkit.org/show_bug.cgi?id=44534
2716
2717         Fix two double-frees introduced in my previous commit.
2718
2719         * DumpRenderTree/gtk/EventSender.cpp:
2720         (contextClickCallback): Copy the event before using it again.
2721         (keyDownCallback): Ditto.
2722
2723 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
2724
2725         Reviewed by Xan Lopez.
2726
2727         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
2728         https://bugs.webkit.org/show_bug.cgi?id=44534
2729
2730         * DumpRenderTree/gtk/EventSender.cpp:
2731         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
2732         when setting it on the event. It is dereferenced by gdk_event_free(...).
2733         (contextClickCallback): Ditto.
2734         (mouseDownCallback): Ditto.
2735         (mouseUpCallback): Ditto.
2736         (mouseMoveToCallback): Ditto.
2737         (mouseWheelToCallback): Ditto.
2738         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
2739         (dispatchEvent): Ditto. Also free the event when we are done with it.
2740         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
2741
2742 2010-08-24  Andras Becsi  <abecsi@webkit.org>
2743
2744         [Qt] WebKit2 build fix.
2745
2746         * Scripts/enumerate-included-framework-headers:
2747         Remove stray global option form sed.
2748
2749 2010-08-24  Kent Tamura  <tkent@chromium.org>
2750
2751         Reviewed by Jeremy Orlow.
2752
2753         [DRT/Chromium] Support for IndexedDB tests
2754         https://bugs.webkit.org/show_bug.cgi?id=44490
2755
2756         * DumpRenderTree/chromium/TestShell.cpp:
2757         (TestShell::TestShell): Enable IndexedDB.
2758
2759 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
2760
2761         Reviewed by Gustavo Noronha Silva.
2762
2763         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
2764         https://bugs.webkit.org/show_bug.cgi?id=44465
2765
2766         Initialize the axes field of mouse button and motion events to null.
2767         This is the value that should be used for events originating from the
2768         mouse device.
2769
2770         * DumpRenderTree/gtk/EventSender.cpp:
2771         (prepareMouseButtonEvent): Initalize button event axes field to null.
2772         (mouseMoveToCallback): Initialize motion event axes field to null.
2773
2774 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2775
2776         Unreviewed, rolling out r65703.
2777         http://trac.webkit.org/changeset/65703
2778         https://bugs.webkit.org/show_bug.cgi?id=44460
2779
2780         "Causing lots of crashes on Snow Leopard when running the
2781         layout tests" (Requested by eseidel2 on #webkit).
2782
2783         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2784         (NP_Initialize):
2785         (NP_GetEntryPoints):
2786
2787 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
2788
2789         Layout tests do not run when using WebKitTestRunner in a Debug build.
2790         https://bugs.webkit.org/show_bug.cgi?id=44409
2791
2792         Reviewed by Dan Bernstein.
2793
2794         * WebKitTestRunner/win/TestControllerWin.cpp:
2795         (WTR::TestController::initializeInjectedBundlePath):
2796         Use InjectedBundle_debug.dll when building Debug.
2797
2798 2010-08-23  Xan Lopez  <xlopez@igalia.com>
2799
2800         Reviewed by Martin Robinson.
2801
2802         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
2803         https://bugs.webkit.org/show_bug.cgi?id=42026
2804
2805         If a GTK+ 3.x build is present return that as the library to use,
2806         otherwise fallback to the GTK+ 2.x build.
2807
2808         * Scripts/webkitdirs.pm:
2809
2810 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
2811
2812         Reviewed by Ariya Hidayat.
2813
2814         [Qt] Find needed forwarding headers for WebKit2 automatically
2815         https://bugs.webkit.org/show_bug.cgi?id=44336
2816
2817         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
2818         The new script does not satisfy the needs of this file however using normal includes
2819         is generally better here.
2820         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
2821         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
2822         given frameworks by files in the current directory (and subdirectories).
2823         In the future this needs to be rewritten in perl for being able to use on Windows.
2824
2825 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
2826
2827         Reviewed by Ariya Hidayat.
2828
2829         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
2830         https://bugs.webkit.org/show_bug.cgi?id=43010
2831
2832         * QtTestBrowser/launcherwindow.cpp:
2833         (LauncherWindow::applyPrefs):
2834         * QtTestBrowser/main.cpp:
2835         (LauncherApplication::handleUserOptions):
2836
2837 2010-08-21  Sam Weinig  <sam@webkit.org>
2838
2839         Reviewed by Dan Bernstein.
2840
2841         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
2842         https://bugs.webkit.org/show_bug.cgi?id=44386
2843
2844         * MiniBrowser/mac/AppDelegate.m:
2845         (didRecieveMessageFromInjectedBundle):
2846         (didNavigateWithNavigationData):
2847         (-[BrowserAppDelegate init]):
2848         (-[BrowserAppDelegate applicationWillTerminate:]):
2849         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2850         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
2851         (-[BrowserStatisticsWindowController dealloc]):
2852         * MiniBrowser/mac/BrowserWindowController.m:
2853         (-[BrowserWindowController initWithPageNamespace:]):
2854         (-[BrowserWindowController fetch:]):
2855         (-[BrowserWindowController windowWillClose:]):
2856         (-[BrowserWindowController applicationTerminating]):
2857         (closePage):
2858         (runJavaScriptAlert):
2859         (runJavaScriptConfirm):
2860         (runJavaScriptPrompt):
2861         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2862         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2863         (didClearWindowObjectForFrame):
2864         * MiniBrowser/win/BrowserView.cpp:
2865         (BrowserView::goToURL):
2866         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2867         (WTR::PlatformWebView::~PlatformWebView):
2868
2869 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
2870
2871         Reviewed by Kenneth Rohde Christiansen.
2872
2873         WebKit does not build with Python 2.3
2874         https://bugs.webkit.org/show_bug.cgi?id=44373
2875
2876         Replaced the function sorted() by a call to sort()
2877         on the entry list.
2878         The function sorted() has been added to Python 2.4.
2879         The function method sort() of List works with older
2880         versions of Python.
2881
2882         * Scripts/create-html-entity-table:
2883
2884 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
2885
2886         Reviewed by Pavel Feldman.
2887
2888         Web Inspector: Inspector tests were disabled for GTK.
2889         https://bugs.webkit.org/show_bug.cgi?id=43977
2890
2891         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
2892         path before running tests.
2893
2894 2010-08-20  Daniel Bates  <dbates@rim.com>
2895
2896         Reviewed by Eric Seidel.
2897
2898         svn-apply doesn't detect empty line with Windows line endings
2899         after property value
2900         https://bugs.webkit.org/show_bug.cgi?id=43981
2901
2902         Part 2 of 2
2903
2904         Add unit tests that were not landed in the first commit.
2905
2906         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2907           - Added the following test cases:
2908             "SVN: binary file (isBinary true) using Windows line endings"
2909             "SVN: property diff, followed by file change diff using Windows line endings"
2910             "SVN: two consecutive property diffs using Windows line endings"
2911             "SVN: binary file with executable bit change usng Windows line endings"
2912             "SVN: binary file followed by property change on different file using Windows line endings"
2913             "SVN: binary file followed by file change on different file using Windows line endings"
2914             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2915             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2916         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2917           - Added the following test cases:
2918             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2919             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2920             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2921             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2922             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2923             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2924             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2925             "single-line '+' with trailing new line using Windows line endings"
2926             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2927             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2928             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2929         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2930           - Added the following test cases:
2931             "single-line '-' change followed by empty line with Windows line endings"
2932             "multi-line '+' change and start of binary patch with Windows line endings"
2933
2934 2010-08-20  Daniel Bates  <dbates@rim.com>
2935
2936         Reviewed by Eric Seidel.
2937
2938         svn-apply doesn't detect empty line with Windows line endings
2939         after property value
2940         https://bugs.webkit.org/show_bug.cgi?id=43981
2941
2942         Fixes an issue where an empty line following the property value
2943         in an SVN property change diff would not be detected if it had
2944         Windows line endings (i.e. ended in CRLF). Hence it was consumed
2945         as if it was part of a multi-line property value. 
2946
2947         * Scripts/VCSUtils.pm:
2948           - Modified parseSvnPropertyValue() to detect empty line
2949             with Windows line endings.
2950           - Added toWindowsLineEndings().
2951         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2952           - Added the following test cases:
2953             "SVN: binary file (isBinary true) using Windows line endings"
2954             "SVN: property diff, followed by file change diff using Windows line endings"
2955             "SVN: two consecutive property diffs using Windows line endings"
2956             "SVN: binary file with executable bit change usng Windows line endings"
2957             "SVN: binary file followed by property change on different file using Windows line endings"
2958             "SVN: binary file followed by file change on different file using Windows line endings"
2959             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
2960             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
2961         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2962           - Added the following test cases:
2963             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
2964             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
2965             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
2966             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
2967             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
2968             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
2969             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
2970             "single-line '+' with trailing new line using Windows line endings"
2971             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
2972             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
2973             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
2974         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2975           - Added the following test cases:
2976             "single-line '-' change followed by empty line with Windows line endings"
2977             "multi-line '+' change and start of binary patch with Windows line endings"
2978
2979 2010-08-19  David Kilzer  <ddkilzer@apple.com>
2980
2981         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
2982
2983         * MiniBrowser/mac/BrowserWindowController.m:
2984         (decidePolicyForNavigationAction): Updated method signature.
2985         (decidePolicyForNewWindowAction): Updated method signature.
2986
2987 2010-08-19  Adam Roben  <aroben@apple.com>
2988
2989         Test that NP_Initialize and NP_GetEntryPoints are called in the
2990         correct order
2991
2992         The order differs between Mac and Windows (see r38858).
2993
2994         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
2995         NP_Initialize when loading QuickTime when running
2996         plugins/embed-attributes-setting.html in WebKit2 on Windows
2997
2998         Reviewed by Sam Weinig.
2999
3000         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
3001         a boolean to record whether NP_GetEntryPoints has been called.
3002         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
3003         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
3004         if NP_GetEntryPoints has been called already. This matches
3005         Silverlight's behavior.
3006
3007 2010-08-19  Adam Roben  <aroben@apple.com>
3008
3009         Make build-webkittestrunner build TestNetscapePlugIn on Windows
3010
3011         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
3012
3013         Reviewed by Sam Weinig.
3014
3015         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
3016         Threaded it in between ImageDiff and InjectedBundleGenerated.
3017
3018 2010-08-19  Ojan Vafai  <ojan@chromium.org>
3019
3020         Reviewed by Adam Barth.
3021
3022         install rietveld's upload script from a versioned url
3023         https://bugs.webkit.org/show_bug.cgi?id=44291
3024
3025         autoinstall expects the file at a given URL to never change.
3026         In order to be able to update the file, we need to be able to
3027         change the path.
3028
3029         * Scripts/webkitpy/thirdparty/__init__.py:
3030
3031 2010-08-19  Ojan Vafai  <ojan@chromium.org>
3032
3033         Reviewed by Adam Barth.
3034
3035         add --webkit_patch_id to reitveld uploads
3036         https://bugs.webkit.org/show_bug.cgi?id=44289
3037
3038         This is the first step in having rietveld store which
3039         patches have been uploaded and getting rid of the
3040         in-rietveld flag.
3041
3042         * Scripts/webkitpy/common/net/rietveld.py:
3043         * Scripts/webkitpy/tool/mocktool.py:
3044         * Scripts/webkitpy/tool/steps/postcodereview.py:
3045
3046 2010-08-19  Kenneth Russell  <kbr@google.com>
3047
3048         Reviewed by David Levin.
3049
3050         Adjust my status from committer to reviewer
3051         https://bugs.webkit.org/show_bug.cgi?id=44277
3052
3053         * Scripts/webkitpy/common/config/committers.py:
3054
3055 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
3056
3057         Reviewed by Yury Semikhatsky.
3058
3059         Chromium DevTools: remove injected script fetcher from test harness.
3060         https://bugs.webkit.org/show_bug.cgi?id=44266
3061
3062         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3063         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3064
3065 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
3066
3067         Reviewed by Yury Semikhatsky.
3068
3069         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
3070         Now that we populate front-end after its onload handler, we don't need
3071         to install injected script early. Exposing injected script source on the WebCore
3072         level here.
3073         https://bugs.webkit.org/show_bug.cgi?id=44029
3074
3075         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3076         (DRTDevToolsAgent::runtimePropertyChanged):
3077         (DRTDevToolsAgent::delayedFrontendLoaded):
3078         (DRTDevToolsAgent::frontendLoaded):
3079         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3080
3081 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3082
3083         Reviewed by Kenneth Rohde Christiansen.
3084
3085         [Gtk] Enable view mode media feature layout test
3086         https://bugs.webkit.org/show_bug.cgi?id=43278
3087
3088         Add view mode media feature testing infrastructure, and add
3089         placeholder methods for the other platforms'
3090         LayoutTestControllers.
3091
3092         * DumpRenderTree/LayoutTestController.cpp:
3093         (setViewModeMediaFeatureCallback):
3094         (LayoutTestController::staticFunctions):
3095         * DumpRenderTree/LayoutTestController.h:
3096         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3097         (LayoutTestController::setViewModeMediaFeature):
3098         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3099         (LayoutTestController::setViewModeMediaFeature):
3100         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3101         (LayoutTestController::setViewModeMediaFeature):
3102         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3103         (LayoutTestController::setViewModeMediaFeature):
3104
3105 2010-08-18  Mark Rowe  <mrowe@apple.com>
3106
3107         Reviewed by Sam Weinig.
3108
3109         Make it so the WebKit2 test slave runs the WebKit2 tests
3110
3111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3112
3113 2010-08-18  Sam Weinig  <sam@webkit.org>
3114
3115         Reviewed by Mark Rowe.
3116
3117         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
3118         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
3119         module and the TestNetscapePlugin.
3120
3121         * Scripts/old-run-webkit-tests:
3122
3123 2010-08-18  Adam Roben  <aroben@apple.com>
3124
3125         Fix hang when saving crash logs on Windows
3126
3127         * Scripts/old-run-webkit-tests:
3128         (setUpWindowsCrashLogSaving):
3129         (END):
3130         Pass -s to regtool so it will write the Auto value as a string instead
3131         of as a number. This was causing a "do you want to debug?" dialog to
3132         appear.
3133
3134 2010-08-17  Victor Wang  <victorw@chromium.org>
3135
3136         Unreviewed. Fixed chromium incremental test json upload.
3137         Quote builder name and test results server in url.
3138
3139         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3140
3141 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3142
3143         Reviewed by Ariya Hidayat.
3144
3145         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
3146         https://bugs.webkit.org/show_bug.cgi?id=44124
3147
3148         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
3149         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
3150         Symbian dependencies.
3151
3152         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3153         (WebCore::DumpRenderTree::open):
3154         * QtTestBrowser/launcherwindow.cpp:
3155         (LauncherWindow::init):
3156         (LauncherWindow::toggleFullScreenMode):
3157         (LauncherWindow::showFPS):
3158         (LauncherWindow::updateFPS):
3159         * QtTestBrowser/launcherwindow.h:
3160         (WindowOptions::WindowOptions):
3161         * QtTestBrowser/mainwindow.cpp:
3162         (MainWindow::buildUI):
3163
3164 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
3165
3166         Reviewed by David Levin.
3167
3168         new-run-webkit-tests: remove --show-sources option
3169
3170         --show-sources is pretty much obsolete with --trace everything, so
3171         I'm removing it.
3172
3173         Also rename a couple of methods in the TestTextDiff class to make their
3174         intended visibility (private) more obvious.
3175
3176         https://bugs.webkit.org/show_bug.cgi?id=44143
3177
3178         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3180         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3181         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3182         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3183
3184 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
3185
3186         Reviewed by David Levin.
3187
3188         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
3189
3190         This code bit-rotted at some point more than a year ago, and nobody seems
3191         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
3192         should support instead, making this flag unnecessary anyway.
3193
3194         https://bugs.webkit.org/show_bug.cgi?id=44141
3195
3196         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3198         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
3199
3200 2010-08-17  Victor Wang  <victorw@chromium.org>
3201
3202         Reviewed by Ojan Vafai.
3203
3204         Update json results generator to have incremental json including
3205         results for tests that pass in current run but failed before.
3206
3207         https://bugs.webkit.org/show_bug.cgi?id=44119
3208
3209         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3210         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3211         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3212
3213 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
3214
3215         Reviewed by Eric Seidel.
3216
3217         fix test-webkitpy, add easy way to find a checkout root
3218
3219         test-webkitpy currently doesn't work right if run from someplace other
3220         than the checkout root, and it spews a bunch of debug logging because
3221         the deduplicate_tests tests contaminates the test environment.
3222
3223         This patch cleans up the deduplicate_tests unit tests, and creates
3224         two new methods in scm.py: find_checkout_root() and default_scm(),
3225         both of which use a single algorithm for guessing what checkout root
3226         to use if you aren't explicitly told one from a path.
3227
3228         https://bugs.webkit.org/show_bug.cgi?id=44001
3229
3230         * Scripts/deduplicate-tests:
3231         * Scripts/webkitpy/common/checkout/scm.py:
3232         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3233         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3234         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3235         * Scripts/webkitpy/layout_tests/port/test.py:
3236         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3237         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3238         * Scripts/webkitpy/tool/main.py:
3239
3240 2010-08-17  Victor Wang  <victorw@chromium.org>
3241
3242         Reviewed by Ojan Vafai.
3243
3244         Add support to the test results server for downloading json that
3245         contains test list only.
3246
3247         This is for json results generator to generate incremental json
3248         results so that it includes results not only for tests failed in
3249         current run, but also tests failed before.
3250
3251         Also set the results type to "N" (no data) instead of "P" (pass)
3252         if test results cannot be found in incremental json file.
3253
3254         https://bugs.webkit.org/show_bug.cgi?id=44117
3255
3256         * TestResultServer/handlers/testfilehandler.py:
3257         * TestResultServer/model/jsonresults.py:
3258         * TestResultServer/model/jsonresults_unittest.py:
3259
3260 2010-08-17  Adam Roben  <aroben@apple.com>
3261
3262         Use the right path style
3263
3264         * Scripts/old-run-webkit-tests:
3265
3266 2010-08-17  Adam Roben  <aroben@apple.com>
3267
3268         Fix typo
3269
3270         * Scripts/old-run-webkit-tests:
3271
3272 2010-08-17  Adam Roben  <aroben@apple.com>
3273
3274         Don't hang when running run-webkit-tests as a non-Administrator on
3275         Vista/7
3276
3277         * Scripts/old-run-webkit-tests:
3278         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
3279         post-mortem debugger, rather than using NTSD itself. The latter waits
3280         for user input when it fails to set the registry values; the former
3281         does not.
3282
3283 2010-08-17  Adam Roben  <aroben@apple.com>
3284
3285         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
3286         save crash logs on Windows
3287
3288         The crash logs are saved to /tmp/layout-test-results and have names
3289         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
3290
3291         Unfortunately, crashes in the WebKit2 web process are recorded as
3292         time-outs by run-webkit-tests. Fixing this is covered by
3293         <http://webkit.org/b/44121>.
3294
3295         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
3296         DumpRenderTree should save a stack trace and/or dump file when it
3297         crashes
3298
3299         Reviewed by Sam Weinig.
3300
3301         * DumpRenderTree/win/DumpRenderTree.cpp:
3302         (exceptionFilter):
3303         (main):
3304         * WebKitTestRunner/win/TestControllerWin.cpp:
3305         (WTR::exceptionFilter):
3306         (WTR::TestController::platformInitialize):
3307         These changes set up an exception filter that prints #CRASHED to
3308         stderr, then lets the exception propagate normally. This allows
3309         run-webkit-tests to detect when we've crashed even when a post-mortem
3310         debugger attaches to the process.
3311
3312         * Scripts/old-run-webkit-tests:
3313         (top level): Declared some variables used by the crash-log-saving
3314         code.
3315         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
3316         that the post-mortem debugger has access to it.
3317         (toCygwinPath): Added. This is the opposite of toWindowsPath.
3318         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
3319         stderr, consider it a crash.
3320         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
3321         debugger, then sets ntsd as the post-mortem debugger. ntsd is
3322         configured to save a crash log and then quit automatically.
3323         (END): Added. Restores the previous post-mortem debugger when the
3324         script exits.
3325
3326 2010-08-17  Victor Wang  <victorw@chromium.org>
3327
3328         Reviewed by ojan@chromium.org.
3329
3330         Update test results server:
3331         1. Normalize test results and times after merging (prune tests where
3332            all runs pass or do not have data, truncate all test items to max
3333            number of builds)
3334         2. times should be int not string.
3335         3. when inserting a new test item, should keep old data regardless
3336            whether or not they have same item type with new one.
3337
3338         https://bugs.webkit.org/show_bug.cgi?id=43861
3339
3340         * TestResultServer/model/jsonresults.py:
3341         * TestResultServer/model/jsonresults_unittest.py:
3342
3343 2010-08-16  Sam Weinig  <sam@webkit.org>
3344
3345         Reviewed by Mark Rowe.
3346
3347         Add WebKit2 Mac tester to buildbot.
3348
3349         * BuildSlaveSupport/build.webkit.org-config/config.json:
3350         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3351
3352 2010-08-16  Paul Sawaya  <psawaya@apple.com>
3353
3354         Reviewed by Chris Marrin.
3355
3356         Added shader validation via ANGLE
3357         https://bugs.webkit.org/show_bug.cgi?id=42405
3358
3359         Added ANGLE to webkit build
3360
3361         * Scripts/build-webkit:
3362
3363 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
3364
3365         [wx] Build fix, do not build WebCore as a convenience library as this leads to
3366         errors in the Win build w/export symbols and causes problems with DOM bindings
3367         debugging in gdb.
3368
3369         * DumpRenderTree/wscript:
3370         * Scripts/build-webkit:
3371         * wx/browser/wscript:
3372         * wx/build/settings.py:
3373         * wx/build/waf_extensions.py:
3374
3375 2010-08-16  Dan Bernstein  <mitz@apple.com>
3376
3377         Build fix.
3378
3379         * WebKitTestRunner/TestController.cpp:
3380         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
3381         (WTR::TestController::initialize): Ditto.
3382
3383 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
3384
3385         Reviewed by Kenneth Rohde Christiansen.
3386
3387         Handle content size change in WebKit2
3388         Re-landing after fix.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=43198
3391
3392         * MiniBrowser/mac/BrowserWindowController.m:
3393         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
3394         * MiniBrowser/win/BrowserView.cpp:
3395         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
3396
3397 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3398
3399         Unreviewed, rolling out r65419.
3400         http://trac.webkit.org/changeset/65419
3401         https://bugs.webkit.org/show_bug.cgi?id=44053
3402
3403         Broke the Windows build (Requested by bbandix on #webkit).
3404
3405         * MiniBrowser/mac/BrowserWindowController.m:
3406         (-[BrowserWindowController awakeFromNib]):
3407         * MiniBrowser/win/BrowserView.cpp:
3408         (BrowserView::create):
3409
3410 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
3411
3412         Reviewed by Kenneth Rohde Christiansen.
3413
3414         Handle content size change in WebKit2
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=43198
3417
3418         * MiniBrowser/mac/BrowserWindowController.m:
3419         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
3420         * MiniBrowser/win/BrowserView.cpp:
3421         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
3422
3423 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
3424
3425         Add my new email address to committers.py.
3426
3427         * Scripts/webkitpy/common/config/committers.py:
3428
3429 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
3430
3431         Add my old e-mail addresses to committers.py.
3432
3433         * Scripts/webkitpy/common/config/committers.py:
3434
3435 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3436
3437         WebEditorClient::didBeginEditing is never called in WebKit2
3438         https://bugs.webkit.org/show_bug.cgi?id=42939
3439
3440         Reviewed by Sam Weinig.
3441
3442         * WebKitTestRunner/PlatformWebView.h:
3443         Declare focus().
3444
3445         * WebKitTestRunner/TestController.cpp:
3446         (WTR::TestController::resetStateToConsistentValues):
3447         Focus the PlatformWebView.
3448
3449         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3450         (WTR::PlatformWebView::focus):
3451         Stubbed.
3452
3453         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3454         (WTR::PlatformWebView::focus):
3455         Focus the view.
3456
3457 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3458
3459         run-webkit-tests should not strip editing callbacks when using
3460         WebKitTestRunner on Windows
3461         https://bugs.webkit.org/show_bug.cgi?id=44000
3462
3463         Reviewed by Mark Rowe.
3464
3465         * Scripts/old-run-webkit-tests:
3466         Leave $stripEditingCallbacks undefined until we look for command-line
3467         arguments. If using WebKit2, set it to 0 if not explicity set on the
3468         command line. Later, set it to isCygwin() to match old behavior if it is
3469         not yet defined.
3470
3471 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
3472
3473         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
3474
3475         * wx/build/settings.py:
3476
3477 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
3478
3479         Reviewed by Kenneth Rohde Christiansen.
3480
3481         [GTK] autogen.sh not executed if build-webkit options change
3482         https://bugs.webkit.org/show_bug.cgi?id=42266
3483
3484         Rerun autogen.sh in situations where the arguments to build-webkit have
3485         changed since the previous build. This will fix some issues on the bots
3486         where the build does not notice changes to default build-webkit arguments.
3487
3488         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
3489
3490 2010-08-14  Eric Seidel  <eric@webkit.org>
3491
3492         Unreviewed.  Another fix to support python 2.3.
3493
3494         Add support for MathML entities
3495         https://bugs.webkit.org/show_bug.cgi?id=43949
3496
3497         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
3498          - It looks like our simplejson is version 1.7.3 which
3499            should be python 2.3 compatible.  But someone modified
3500            our copy slightly from the original source.
3501            I've removed the relative import in hopes this fixes
3502            the problem.
3503
3504 2010-08-13  Eric Seidel  <eric@webkit.org>
3505
3506         Unreviewed.  Build fix only.
3507
3508         Add support for MathML entities
3509         https://bugs.webkit.org/show_bug.cgi?id=43949
3510
3511         * Scripts/create-html-entity-table:
3512          - Hack sys.path to avoid executing 2.5 dependent python
3513            on systems (like chromium-win and Tiger) which do not have 2.5 python.
3514
3515 2010-08-13  Adam Barth  <abarth@webkit.org>
3516
3517         Reviewed by Eric Seidel.
3518
3519         Rename some concepts in HTML entity search to be more self-documenting
3520         https://bugs.webkit.org/show_bug.cgi?id=44004
3521
3522         Reflect name change in generator script.
3523
3524         * Scripts/create-html-entity-table:
3525
3526 2010-08-12  Adam Barth  <abarth@webkit.org>
3527
3528         Reviewed by Eric Seidel.
3529
3530         Add support for MathML entities
3531         https://bugs.webkit.org/show_bug.cgi?id=43949
3532
3533         A script for generating the C++ state data structure describing all the
3534         entities from a JSON description.
3535
3536         * Scripts/create-html-entity-table: Added.
3537
3538 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
3539
3540         Reviewed by Eric Seidel.
3541
3542         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
3543         check for exceptions on all threads, not just the first thread.
3544         
3545         This change also changes the logging behavior for wedged threads
3546         to only dump the stacks of threads that are actually wedged.
3547
3548         Refactor the thread classes in the dump_render_tree_thread module
3549         to make the contract between TestRunner and TestShellThread clearer.
3550
3551         Added a bunch of unit tests.
3552         https://bugs.webkit.org/show_bug.cgi?id=38561
3553
3554         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3555         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3556         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3557
3558 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
3559
3560         Reviewed by Shinichiro Hamaji.
3561
3562         Add test_expectations.txt syntax checker to check-webkit-style.
3563         https://bugs.webkit.org/show_bug.cgi?id=43899
3564
3565         Just utilizing layout_tests/layout_package/test_expectations.py for checking
3566         the syntax of test_expectations.txt.
3567         This change also moves tab checking class from style/checkers/text.py to
3568         style/checkers/common.py for sharing code.
3569
3570         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3571         * Scripts/webkitpy/style/checker.py:
3572         * Scripts/webkitpy/style/checkers/common.py:
3573         * Scripts/webkitpy/style/checkers/common_unittest.py:
3574         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
3575         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
3576         * Scripts/webkitpy/style/checkers/text.py:
3577         * Scripts/webkitpy/style_references.py:
3578
3579 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
3580
3581         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
3582         https://bugs.webkit.org/show_bug.cgi?id=43945
3583
3584         Reviewed by Sam Weinig.
3585
3586         * WebKitTestRunner/TestInvocation.cpp:
3587         (WTR::sizeWebViewForCurrentTest):