2007-12-20 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-20  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by mjs.
4
5         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
6
7 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
8
9         Reviewed by Steve.
10
11         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
12         WebKit.
13
14         - Drosera and Safari need to use the same ProgIDs in order for
15         CoCreateInstance to work properly.  The most robust way to do this is
16         for WebKit to dynamically publish those ProgIDs.
17
18         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
19         (DebuggerClient::createWebViewWithRequest):
20         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
21         statics.
22         (Drosera::initUI):
23         (Drosera::attach):
24         (Drosera::attemptToCreateServerConnection):
25         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
26         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
27         make use of the published ProgIDs.
28         (ServerConnection::attemptToCreateServerConnection):
29
30 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
31
32         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
33         - Build bot and leak fix.
34
35         * DumpRenderTree/LayoutTestController.cpp:
36         (pathToLocalResourceCallback):
37
38 2007-12-19  David Kilzer  <ddkilzer@apple.com>
39
40         Make svn-apply/svn-unapply work with patches from git-format-patch.
41
42         Reviewed by Darin.
43
44         * Scripts/svn-apply:
45         (patch): If 'Index:' can't be found in the text passed in, print it
46         out with a warning and return early.
47         * Scripts/svn-unapply:
48         (patch): Ditto.
49
50 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
51
52         Reviewed by Alp Toker.
53
54         Build related fixes.
55
56         * wx/build-wxwebkit:
57         - Check to make sure the user is running a supported wx port
58         - More robust checks for Cygwin
59         - Only run install-unix-extras on Mac, it's not the right solution
60           for Linux distros.
61         - Remove outdated Linux instructions after successful build
62         - Clean Bakefile-generated files during a clean operation
63
64 2007-12-18  Darin Adler  <darin@apple.com>
65
66         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
67
68 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
69
70         Add script to run Drosera as part of the nightly.
71         
72         Reviewed by Kevin M.
73
74         * Scripts/run-drosera.cmd: Added.
75
76 2007-12-18  Darin Adler  <darin@apple.com>
77
78         * Scripts/do-webcore-rename: Remove a stray K.
79
80 2007-12-18  Darin Adler  <darin@apple.com>
81
82         * Scripts/do-webcore-rename: Plan more renaming.
83
84 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
85
86         Reviewed by Alp Toker.
87
88         http://bugs.webkit.org/show_bug.cgi?id=16042
89         [GTK] Eliminate webkit_init()
90
91         Moving webkit initialization to WebView class init.
92
93         * DumpRenderTree/gtk/DumpRenderTree.cpp:
94         (main):
95         * GtkLauncher/main.c:
96         (main):
97
98 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
99
100         Reviewed by Alp Toker.
101
102         http://bugs.webkit.org/show_bug.cgi?id=13542
103         gdklauncher doesnt change URL in adress GTKEntry.
104
105         * GtkLauncher/main.c:
106         (load_commit_cb): added
107         (title_change_cb):
108         (create_browser):
109
110 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
111
112         Reviewed by Adam Roben.
113
114         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
115
116         * FindSafari/FindSafari.cpp:
117         (_tmain):
118
119 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
120
121         Reviewed by Adam Roben.
122
123         http://bugs.webkit.org/show_bug.cgi?id=16315
124         FindSafari needs a path-only option.
125
126         * FindSafari/FindSafari.cpp:
127         (_tmain):
128
129 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
130
131         Reviewed by Darin.
132
133         http://bugs.webkit.org/show_bug.cgi?id=16462
134         REGRESSION: access keys broken on Windows
135
136         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
137         if Alt is pressed.
138
139 2007-12-15  Sam Weinig  <sam@webkit.org>
140
141         Reviewed by Mark Rowe.
142
143         Fix urlSuitableForTestResult to correctly identify wstring::npos as
144         the case when wstring.find doesn't find anything.
145
146         * DumpRenderTree/win/DumpRenderTree.cpp:
147         (urlSuitableForTestResult):
148
149 2007-12-15  Alp Toker  <alp@atoker.com>
150
151         GTK+ DRT build fix for GLib < 2.14.
152
153         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
154         (LayoutTestController::setWaitToDump):
155
156 2007-12-05  Mark Rowe  <mrowe@apple.com>
157
158         Reviewed by Alp Toker.
159
160         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
161         many layout tests from hanging while waiting on user responses to dialogs.
162
163         * DumpRenderTree/gtk/DumpRenderTree.cpp:
164         (invalidateAnyPreviousWaitToDumpWatchdog):
165         (webViewScriptAlert):
166         (webViewScriptPrompt):
167         (webViewScriptConfirm):
168         (main):
169         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
170         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
171         (waitToDumpWatchdogFired):
172         (LayoutTestController::setWaitToDump):
173
174 2007-12-05  Mark Rowe  <mrowe@apple.com>
175
176         Reviewed by Alp Toker.
177
178         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
179
180         * DumpRenderTree/gtk/DumpRenderTree.cpp:
181         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
182         (dump):
183         (runTest):
184         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
185         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
186         work queue is empty.
187         (webViewWindowObjectCleared): Set up window.layoutTestController.
188         (webViewConsoleMessage): Match the console message format expected by the layout test results.
189         (main): Hook up the new signals.
190         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
191         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
192         dumping multiple times.
193         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
194         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
195
196 2007-12-14  Anders Carlsson  <andersca@apple.com>
197
198         Reviewed by Brady.
199
200         Assert that a web frame that's loading a resource always has either a data source or 
201         a provisional data source.
202         
203         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
204         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
205
206 2007-12-14  Darin Adler  <darin@apple.com>
207
208         - fix mistake causing nearly all tests to fail on Windows
209
210         * DumpRenderTree/win/UIDelegate.cpp:
211         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
212         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
213
214         * DumpRenderTree/mac/UIDelegate.mm:
215         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
216         than passing the entire message.
217
218 2007-12-14  Darin Adler  <darin@apple.com>
219
220         - fix Tiger build
221
222         * DumpRenderTree/mac/UIDelegate.mm:
223         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
224         new-to-Leopard methods.
225
226 2007-12-14  Darin Adler  <darin@apple.com>
227
228         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
229         since it now triggers unwanted icon loading. We only had it because we implemented "all"
230         delegate methods here.
231
232 2007-12-14  Anders Carlsson  <andersca@apple.com>
233
234         Reviewed by Darin and Geoff.
235
236         <rdar://problem/5619295> 
237         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
238         
239         Add property getting methods to the plug-in.
240         
241         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
242         (pluginInvoke):
243
244 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
245
246         Reviewed by Darin.
247
248         - Layout test fix for mac. When dumped to the console local file paths
249         now only show the name of the resource not the whole path.  This is to
250         make the results machine and OS independent.
251
252         * DumpRenderTree/mac/UIDelegate.mm:
253         (-[UIDelegate webView:addMessageToConsole:]):
254
255 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
256
257         Reviewed by Adam.
258
259         - Layout tests fix.  We need a way to remove machine-dependent
260         information from paths in layout test results. The UIDelegate now does
261         this.
262
263         * DumpRenderTree/DumpRenderTree.h:
264         * DumpRenderTree/win/DumpRenderTree.cpp:
265         (urlSuitableForTestResult):
266         * DumpRenderTree/win/DumpRenderTreeWin.h:
267         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
268         * DumpRenderTree/win/UIDelegate.cpp:
269         (UIDelegate::webViewAddMessageToConsole):
270
271 2007-12-13  Alp Toker  <alp@atoker.com>
272
273         Build fix for DRT breakage introduced in r28690.
274
275         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
276         (LayoutTestController::pathToLocalResource):
277
278 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
279
280         Reviewed by Alice and Sam.
281
282         - <rdar://5621435> Need a way to specify local resources (being loaded
283         from HTTP tests) on Windows.
284         - Implemented pathToLocalResource which exposes the functionality of
285         converting a given unix path to the correct location on Windows.
286
287         * DumpRenderTree/LayoutTestController.cpp:
288         (pathToLocalResourceCallback):
289         (LayoutTestController::staticFunctions):
290         * DumpRenderTree/LayoutTestController.h:
291         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
292         (LayoutTestController::pathToLocalResource):
293         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
294         (LayoutTestController::pathToLocalResource):
295
296 2007-12-12  Anders Carlsson  <andersca@apple.com>
297
298         Reviewed by Sam.
299
300         <rdar://problem/5132003>
301         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
302
303         * DumpRenderTree/win/DumpRenderTree.cpp:
304         (main):
305         Set the resource load delegate.
306         
307         * DumpRenderTree/win/DumpRenderTree.vcproj:
308         
309         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
310         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
311
312 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
313
314         Reviewed by Adam Roben.
315
316         Fix conversion from double to LPARAM in dispatchMessage().
317
318         * DumpRenderTree/win/EventSender.cpp:
319         (dispatchMessageCallback):
320
321 2007-12-11  Dan Bernstein  <mitz@apple.com>
322
323         Reviewed by Mark Rowe and Sam Weinig too!
324
325         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
326           fonts DumpRenderTree registers.
327
328         * DumpRenderTree/win/DumpRenderTree.cpp:
329         (initialize):
330
331 2007-12-11  Brady Eidson  <beidson@apple.com>
332
333         Reviewed by Anders
334
335         Make DumpRenderTree on mac use its own path for Databases testing
336
337         * DumpRenderTree/mac/DumpRenderTree.mm:
338         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
339           for future DRT-only use, then use it to construct the Databases path and set that default
340
341 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
342
343         Reviewed by Darin.
344
345         <rdar://problem/5535636>
346         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
347
348         http://bugs.webkit.org/show_bug.cgi?id=13916
349         JavaScript detects Tab as a character input on a textfield validation
350
351         * DumpRenderTree/mac/EventSendingController.mm:
352         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
353         Dispatch a keyup to better match what happens when a key is physically pressed.
354
355         * DumpRenderTree/win/EventSender.cpp:
356         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
357         returning from keyDown().
358         (getConstantCallback): Fixed a couple copy/paste mistakes.
359
360 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
361
362         Reviewed by Oliver.
363
364         - <rdar://5599845> Drosera: Does not show loal files in the file list
365         on the left side.
366
367         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
368         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
369         so the open source community can build.
370
371 2007-12-10  Brady Eidson  <beidson@apple.com>
372
373         Rubberstamped by Sam Weinig
374
375         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
376
377         * DumpRenderTree/mac/UIDelegate.mm:
378         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
379         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
380
381 2007-12-08  Oliver Hunt  <oliver@apple.com>
382
383         Reviewed by Sam W.
384
385         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
386         
387         Fixes <rdar://problem/5620249> Must disable SVG animation
388         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
389         
390         In order to allow finer grained control over the set of SVG features
391         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
392         distinct flags:
393         ENABLE_SVG_ANIMATION
394         ENABLE_SVG_FILTERS
395         ENABLE_SVG_FONTS
396         ENABLE_SVG_AS_IMAGE
397         ENABLE_SVG_USE
398         
399         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
400         
401         Script handles all the new build flags, and allows --svg-experimental
402         to automatically enable all features.
403
404         * Scripts/build-webkit:
405
406 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
407
408         Fix version parsing.
409
410         Rubber-stamped by Oliver.
411
412         * Drosera/win/Drosera.vcproj/auto-version.sh:
413
414 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
415
416         Build modifications for Drosera.
417
418         Reviewed by Adam.
419
420         * Drosera/DroseraWin.make: Added.
421         * Drosera/win/Drosera.vcproj/Drosera.rc:
422         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
423         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
424         * Drosera/win/Drosera.vcproj/VERSION: Added.
425         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
426
427 2007-12-06  Adam Roben  <aroben@apple.com>
428
429         Explicitly turn on the Mac font ascent hack on Windows
430
431         This keeps our font metrics matching those from Mac.
432
433         Reviewed by Hyatt.
434
435         * DumpRenderTree/win/DumpRenderTree.cpp:
436         (main):
437
438 2007-12-06  Anders Carlsson  <andersca@apple.com>
439
440         Rename main.c to main.cpp here too.
441         
442         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
443
444 2007-12-06  Sam Weinig  <sam@webkit.org>
445
446         Rubber stamped by Geoff.
447
448         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
449
450 2007-12-06  Darin Adler  <darin@apple.com>
451
452         * Scripts/do-webcore-rename: Some more renaming plans.
453
454 2007-12-06  Anders Carlsson  <andersca@apple.com>
455
456         Restore implementation of testGetIntIdentifier that was accidentally
457         removed somehow (possibly when I made PluginObject be a cpp file).
458         
459         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
460         (pluginInvoke):
461
462 2007-12-05  Anders Carlsson  <andersca@apple.com>
463
464         Make the entry points extern "C".
465         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
466         
467 2007-12-05  Anders Carlsson  <andersca@apple.com>
468
469         C++ warning fixes.
470         
471         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
472         (NPP_New):
473         (NPP_Destroy):
474         (NPP_SetWindow):
475         (NPP_NewStream):
476         (NPP_HandleEvent):
477         (NPP_URLNotify):
478         (NPP_GetValue):
479
480 2007-12-05  Anders Carlsson  <andersca@apple.com>
481
482         Add the .cpp files to the TestNetscapePlugIn target.
483
484         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
485
486 2007-12-05  Anders Carlsson  <andersca@apple.com>
487
488         Reviewed by Geoff.
489         
490         Rename the TestNetscapePlugIn .c files to be .cpp.
491
492         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
493         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
494         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
495         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
496         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
497         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
498         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
499         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
500
501 2007-12-05  Adam Roben  <aroben@apple.com>
502
503         Fix case of keypresses from the Windows implementation of eventSender.keyDown
504
505         This fixes several regression tests.
506
507         Reviewed by Alice.
508
509         * DumpRenderTree/win/EventSender.cpp:
510         (keyDownCallback): Virtual keycodes for ASCII characters are always
511         uppercase, so we need to check the case of the original character
512         passed in to eventSender.keyDown.
513
514 2007-12-05  Adam Roben  <aroben@apple.com>
515
516         Learn from Tim's mistakes
517
518         * DumpRenderTree/win/DumpRenderTree.cpp:
519         (runTest): Reset the authorAndUserStylesEnabled preference for each
520         test.
521
522 2007-12-05  Alp Toker  <alp@atoker.com>
523
524         Reviewed by Mark Rowe.
525
526         Initialize GTK+ and WebKit so the tests can run.
527
528         Reorganize the headers a little.
529
530         * DumpRenderTree/gtk/DumpRenderTree.cpp:
531         (main):
532
533 2007-12-04  Anders Carlsson  <andersca@apple.com>
534
535         Remove IWebScriptScope include.
536         
537         * Drosera/win/DebuggerDocumentPlatform.cpp:
538
539 2007-12-04  Sam Weinig  <sam@webkit.org>
540
541         Rubber stamped by Mark Rowe.
542
543         Define CF as platform for mac and revert r28409
544
545         * DumpRenderTree/DumpRenderTree.h:
546         * DumpRenderTree/mac/DumpRenderTreeMac.h:
547
548 2007-12-04  Sam Weinig  <sam@webkit.org>
549
550         Define CF as platform for windows.
551
552         Reviewed by Adam Roben.
553
554         * DumpRenderTree/win/DumpRenderTreeWin.h:
555
556 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
557
558         Reviewed by Adam and Darin.
559
560         - Removed a needless BSTR cleanup.
561
562         * Drosera/win/DebuggerDocumentPlatform.cpp:
563         (DebuggerDocument::getPlatformCurrentFunctionStack):
564
565 2007-11-27  Adam Roben  <aroben@apple.com>
566
567         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
568
569         Reviewed by Maciej.
570
571         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
572         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
573
574 2007-12-04  Alp Toker  <alp@atoker.com>
575
576         Prospective Win DRT build fix.
577
578         * DumpRenderTree/DumpRenderTree.h:
579
580 2007-12-04  Alp Toker  <alp@atoker.com>
581
582         Fix a clobbered copyright header.
583
584         * DumpRenderTree/gtk/DumpRenderTree.cpp:
585
586 2007-12-04  Xan Lopez  <xan@gnome.org>
587
588         Reviewed by Alp Toker.
589
590         http://bugs.webkit.org/show_bug.cgi?id=15561
591         GTK port needs DumpRenderTree implementation
592
593         Start work on the GTK+ DRT.
594
595         This does not work yet, and there are a few lingering style issues
596         (nothing major) but this patch has been stuck in the bug tracker for
597         too long already.
598
599         * DumpRenderTree/DumpRenderTree.h:
600         * DumpRenderTree/gtk: Added.
601         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
602         (autocorrectURL):
603         (shouldLogFrameLoadDelegates):
604         (dumpFrameScrollPosition):
605         (displayWebView):
606         (appendString):
607         (dumpFramesAsText):
608         (dumpRenderTreeAsText):
609         (dump):
610         (runTest):
611         (main):
612         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
613         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
614         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
615         (GCController::collect):
616         (GCController::collectOnAlternateThread):
617         (GCController::getJSObjectCount):
618         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
619         (LayoutTestController::~LayoutTestController):
620         (LayoutTestController::addDisallowedURL):
621         (LayoutTestController::clearBackForwardList):
622         (LayoutTestController::copyDecodedHostName):
623         (LayoutTestController::copyEncodedHostName):
624         (LayoutTestController::display):
625         (LayoutTestController::keepWebHistory):
626         (LayoutTestController::notifyDone):
627         (LayoutTestController::queueBackNavigation):
628         (LayoutTestController::queueForwardNavigation):
629         (LayoutTestController::queueLoad):
630         (LayoutTestController::queueReload):
631         (LayoutTestController::queueScript):
632         (LayoutTestController::setAcceptsEditing):
633         (LayoutTestController::setCustomPolicyDelegate):
634         (LayoutTestController::setMainFrameIsFirstResponder):
635         (LayoutTestController::setTabKeyCyclesThroughElements):
636         (LayoutTestController::setUseDashboardCompatibilityMode):
637         (LayoutTestController::setUserStyleSheetEnabled):
638         (LayoutTestController::setUserStyleSheetLocation):
639         (LayoutTestController::setWindowIsKey):
640         (LayoutTestController::setWaitToDump):
641         (LayoutTestController::windowCount):
642         (LayoutTestController::setPrivateBrowsingEnabled):
643         (LayoutTestController::setAuthorAndUserStylesEnabled):
644         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
645         (JSStringCopyUTF8CString):
646         (LoadItem::invoke):
647         (ReloadItem::invoke):
648         (ScriptItem::invoke):
649         (BackForwardItem::invoke):
650
651 2007-12-03  Sam Weinig  <sam@webkit.org>
652
653         Move JavaScriptCore thread testing code to pthread specific directory
654         and remove the dependance on CoreFoundation by using WTF::HashSet.
655
656         Reviewed by Geoff and Oliver.
657
658         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
659         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
660         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
661         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
662         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
663         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
664         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
665         * DumpRenderTree/pthreads: Added.
666         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
667         (javaScriptThreads):
668         (runJavaScriptThread):
669         (startJavaScriptThreads):
670         (stopJavaScriptThreads):
671
672 2007-12-03  Andrew Bonventre  <andybons@google.com>
673
674         Reviewed by Darin Adler.
675
676         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
677         Symbol lookup menu broken in debugger view
678
679         * Drosera/debugger.js: Fixed javascript error where document property
680         should have been used instead of contentDocument in switchFunction that
681         was breaking the select symbol dropdown menu.  This is because
682         window.frames will return a Window object and not a frame object like
683         the author was originally expecting.
684
685 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
686
687         Reviewed by Adam.
688
689         - <rdar://5618942> Drosera: Console window does not process everything
690         correctly.
691         - <rdar://5619005> Drosera: could be sped up by moving the 
692         WebScriptScope stuff into the WebScriptCallFrame.
693         - Now the console can correctly process objects and does not receive
694         notifications from JavaScriptCore about the JavaScript in Drosera's
695         own process.
696
697         * Drosera/win/DebuggerDocumentPlatform.cpp:
698         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
699         (DebuggerDocument::platformValueForScopeVariableNamed):
700
701 2007-12-03  Stephanie  <slewis@apple.com>
702
703         Reviewed by Darin.
704
705         Check to see if we are building a debug root
706
707         * Scripts/check-for-global-initializers: 
708
709 2007-12-03  Dan Bernstein  <mitz@apple.com>
710
711         Reviewed by Darin Adler.
712
713         - added a testGetIntIdentifier() method to TestNetscapePlugIn
714
715         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
716         (pluginInvoke):
717
718 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
719
720         Reviewed by Oliver.
721
722         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
723         in a more fine-grained manner than eventSender.keyDown().
724
725         * DumpRenderTree/win/EventSender.cpp:
726         (getConstantCallback):
727         (dispatchMessageCallback):
728
729 2007-12-02  Darin Adler  <darin@apple.com>
730
731         * Scripts/do-webcore-rename: More planned renaming.
732
733 2007-12-02  Sam Weinig  <sam@webkit.org>
734
735         Rubber stamped by Anders.
736
737         Use [NSURL absoluteString] instead of [NSURL description] in order to get
738         more uniform results cross platform.
739
740         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
741         (-[NSURL _drt_descriptionSuitableForTestResult]):
742
743 2007-12-02  Sam Weinig  <sam@webkit.org>
744
745         Rubber stamped by Niko.
746
747         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
748
749         * DumpRenderTree/win/DumpRenderTree.cpp:
750         * DumpRenderTree/win/DumpRenderTree.vcproj:
751         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
752         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
753         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
754         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
755
756 2007-12-01  Alp Toker  <alp@atoker.com>
757
758         Reviewed by Adam Roben.
759
760         Make use of the newly introduced webkit.h convenience header.
761
762         * GtkLauncher/main.c:
763
764 2007-12-01  Adam Treat  <treat@kde.org>
765
766         Reviewed by Simon.
767
768         * Check to see if the directory exists and exit if not.
769
770         * DumpRenderTree/qt/main.cpp:
771         (main):
772
773 2007-12-01  Adam Treat  <treat@kde.org>
774
775         Reviewed by Simon.
776
777         * Don't hide symbols when in Debug mode
778         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
779
780
781         * DumpRenderTree/qt/main.cpp:
782         (messageHandler):
783
784 2007-11-30  Alp Toker  <alp@atoker.com>
785
786         Reviewed by Adam Roben.
787
788         http://bugs.webkit.org/show_bug.cgi?id=15691
789         [GTK] Public API does not follow GTK+ conventions
790
791         Refactor the WebKit/GTK+ public API. Changes:
792           WebKitPage -> WebKitWebView
793           WebKitFrame -> WebKitWebFrame
794
795         Public API source and header names have been updated to mirror the API
796         changes.
797
798         The API is now kept in WebKit/gtk/WebView to match other ports in the
799         same class such as Mac and Win.
800
801         * GtkLauncher/main.c:
802         (activate_uri_entry_cb):
803         (link_hover_cb):
804         (title_change_cb):
805         (progress_change_cb):
806         (go_back_cb):
807         (go_forward_cb):
808         (create_browser):
809         (main):
810
811 2007-11-30  Adam Roben  <aroben@apple.com>
812
813         Hopefully the final build fix
814
815         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
816         pull in WTF's assertion/logging functions.
817
818 2007-11-30  Adam Roben  <aroben@apple.com>
819
820         Another build fix
821
822         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
823         WebKit.lib.
824
825 2007-11-30  Adam Roben  <aroben@apple.com>
826
827         Debug build fix
828
829         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
830         configuration.
831         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
832         projects.
833         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
834         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
835         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
836
837 2007-11-30  Sam Weinig  <sam@webkit.org>
838
839         Reviewed by Adam Roben.
840
841         Fix drawSelectionRect to actually draw the selection rect.
842
843         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
844         (drawSelectionRect):
845
846 2007-11-30  Darin Adler  <darin@apple.com>
847
848         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
849
850 2007-11-30  Darin Adler  <darin@apple.com>
851
852         * Scripts/do-webcore-rename: Get ready for some future renaming.
853
854 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
855
856         Reviewed by Adam.
857
858         - Removed some unnecessary functions and changed an unused return type. 
859
860         * Drosera/win/DebuggerClient.cpp:
861         (registerConsoleClass):
862         * Drosera/win/DebuggerClient.h:
863         * Drosera/win/Drosera.cpp:
864         (registerDroseraClass):
865
866 2007-11-28  Alp Toker  <alp@atoker.com>
867
868         Reviewed by Timothy Hatcher.
869
870         http://bugs.webkit.org/show_bug.cgi?id=16174
871         [GTK] Use "URI" not "URL" in public API
872
873         Replace use of the term "URL" with "URI" in public headers,
874         documentation and some internal code to match GLib/GTK+ convention.
875
876         This is now mentioned in the API guidelines:
877           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
878
879         * GtkLauncher/main.c:
880         (activate_uri_entry_cb):
881         (title_change_cb):
882         (create_toolbar):
883         (main):
884
885 2007-11-29  Anders Carlsson  <andersca@apple.com>
886
887         Reviewed by Sam.
888
889         <rdar://problem/5230478>
890         FrameLoadDelegate callbacks are not dumped in DRT.
891         
892         * DumpRenderTree/win/DumpRenderTree.cpp:
893         (shouldLogFrameLoadDelegates):
894         (runTest):
895         (main):
896         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
897         (BSTRtoString):
898         (descriptionSuitableForTestResult):
899         (FrameLoadDelegate::QueryInterface):
900         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
901         (FrameLoadDelegate::didFailProvisionalLoadWithError):
902         (FrameLoadDelegate::didCommitLoadForFrame):
903         (FrameLoadDelegate::didFinishLoadForFrame):
904         (FrameLoadDelegate::willCloseFrame):
905         (FrameLoadDelegate::didClearWindowObject):
906         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
907         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
908         * DumpRenderTree/win/FrameLoaderDelegate.h:
909         (FrameLoadDelegate::windowScriptObjectAvailable):
910         (FrameLoadDelegate::didFirstLayoutInFrame):
911
912 2007-11-29  Sam Weinig  <sam@webkit.org>
913
914         Reviewed by Anders.
915
916         Add database quota UIDelegates methods to DRT UIDelegate.
917
918         * DumpRenderTree/mac/UIDelegate.mm:
919         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
920         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
921
922 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
923
924         Reviewed by Sam.
925
926         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
927         dying and vice versa.
928         - This fix will allow Drosera and Safari to reconnect if either of them
929         closes correctly, but does not fix the case where one of them dies
930         silently.
931
932         * Drosera/win/ServerConnection.cpp:
933         (ServerConnection::attemptToCreateServerConnection): Added a safety
934         check, because it's possilbe to try to connect to a server that's dying.
935         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
936         the server has died.
937         * Drosera/win/ServerConnection.h: Added the new function and removed
938         an unnecessary member.
939
940 2007-11-29  Anders Carlsson  <andersca@apple.com>
941
942         * DumpRenderTree/win/DumpRenderTree.vcproj:
943         Add shlwapi.lib to all configurations.
944
945 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
946
947         - Build fix.  Added additional includes for VS Express to the Release
948         project.
949
950         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
951
952 2007-11-29  Anders Carlsson  <andersca@apple.com>
953
954         Reviewed by Adam.
955
956         <rdar://problem/5132005>
957         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
958         
959         * DumpRenderTree/win/DumpRenderTree.vcproj:
960         Add shlwapi.lib
961         
962         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
963         (LayoutTestController::setUserStyleSheetEnabled):
964         Implement this.
965         
966         (appendComponentToPath):
967         New method which wraps the Win32 API PathAppend.
968         
969         (followShortcuts):
970         New method which checks if a file points to a shortcut and
971         follows the shortcut.
972         
973         (resolveCygwinPath):
974         New method that takes a cygwin unix-style path and returns the Win32 path.
975         
976         (cfStringRefToWString):
977         
978         (LayoutTestController::setUserStyleSheetLocation):
979         Implement this.
980
981 2007-11-29  Alice Liu  <alice.liu@apple.com>
982
983         Reviewed by Adam.
984
985         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
986
987         * DumpRenderTree/win/EventSender.cpp:
988         (keyDownCallback):
989         uppercase letters were being sent as lowercase letters without the shift key down.
990
991 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
992
993         - Windows build fix. VS express needs some love.
994
995         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
996
997 2007-11-28  Darin Adler  <darin@apple.com>
998
999         Reviewed by Adam Roben.
1000
1001         * DumpRenderTree/mac/EventSendingController.mm:
1002         (-[EventSendingController keyDown:withModifiers:]):
1003         Send capital letters through as lowercase letters with the shift key down
1004         rather than sending them as if they were highly unusual "capital letter keys".
1005
1006         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1007         where you need to update results and more tests are failing than before.
1008
1009 2007-11-28  Anders Carlsson  <andersca@apple.com>
1010
1011         Reviewed by Darin.
1012
1013         <rdar://problem/5132001>
1014         contextClick is not implemented in DRT on Windows.
1015         
1016         * DumpRenderTree/win/EventSender.cpp:
1017         (contextClickCallback):
1018         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1019         by a WM_RBUTTONUP message.
1020         
1021         * DumpRenderTree/win/UIDelegate.cpp:
1022         (UIDelegate::hasCustomMenuImplementation):
1023         (UIDelegate::trackCustomPopupMenu):
1024         * DumpRenderTree/win/UIDelegate.h:
1025         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1026         menu from being shown (and causing the DRT to hang).
1027
1028 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1029
1030         Reviewed by Darin.
1031
1032         Fix DumpRenderTree ObjC bug comparing strings.
1033
1034         * DumpRenderTree/mac/ObjCController.m:
1035         (-[ObjCController identityIsEqual::]): Compare strings with string
1036         equality instead of identiy equality.
1037
1038 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1039
1040         Reviewed by Sam.
1041
1042         Reset the authorAndUserStylesEnabled preference
1043         back to YES for each test. Fixes the broken tests.
1044
1045         * DumpRenderTree/mac/DumpRenderTree.mm:
1046         (resetWebViewToConsistentStateBeforeTesting):
1047
1048 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1049
1050         Reviewed by Adam.
1051
1052         - Drosera now displays the console window, although it cannot currently
1053         process JavaScript.
1054
1055         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1056         (registerConsoleClass): Implemented.
1057         (consoleWndProc): Implemented.
1058         (DebuggerClient::onSize): Implemented.
1059         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1060         new window.
1061         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1062         creating and maintaining a new window.
1063         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1064         lines of code to more appropriate places.
1065         (Drosera::handleCommand):
1066         (Drosera::initUI):
1067         (Drosera::onSize):
1068         (Drosera::attach):
1069
1070 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1071
1072         Reviewed by Dave Hyatt.
1073
1074         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1075         
1076         Add support for disabling author and user styles for testing.
1077
1078         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1079         * DumpRenderTree/LayoutTestController.cpp:
1080         (setAuthorAndUserStylesEnabledCallback):
1081         (LayoutTestController::staticFunctions):
1082         * DumpRenderTree/LayoutTestController.h:
1083         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1084         (LayoutTestController::setAuthorAndUserStylesEnabled):
1085         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1086         (LayoutTestController::setAuthorAndUserStylesEnabled):
1087
1088 2007-11-26  Dan Bernstein  <mitz@apple.com>
1089
1090         - Tiger build fix.
1091
1092         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1093
1094 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1095
1096         Reviewed by Maciej.
1097
1098         - Implemented displaying variables for Drosera on Win.
1099
1100         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1101         that retrieve variables to not hold onto the return value since it's
1102         not returned.  Also changed to use the new signatures of the retrieval
1103         functions.
1104         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1105         (DebuggerDocument::platformValueForScopeVariableNamed):
1106         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1107         (droseraWndProc):
1108
1109 2007-11-26  Sam Weinig  <sam@webkit.org>
1110
1111         Cleanup names of painting and repainting functions.
1112
1113         Reviewed by Adam Roben.
1114
1115         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1116         (drawSelectionRect): was drawSelectionRectIntoContext.
1117         (dumpWebViewAsPixelsAndCompareWithExpected):
1118         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1119         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1120         (paintWebView): was drawWebViewIntoContext.
1121         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1122
1123 2007-11-26  Sam Weinig  <sam@webkit.org>
1124
1125         Reviewed by Dan Bernstein.
1126
1127         - Leopard build fix
1128
1129         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1130
1131 2007-11-26  Sam Weinig  <sam@webkit.org>
1132
1133         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1134         Use shared PixelDumpSupport for Mac DRT
1135
1136         Reviewed by Adam Roben.
1137
1138         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1139         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1140         * DumpRenderTree/cg/ImageDiffCG.cpp:
1141         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1142         (drawSelectionRectIntoContext):
1143         (dumpWebViewAsPixelsAndCompareWithExpected):
1144         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1145         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1146         * DumpRenderTree/mac/DumpRenderTree.mm:
1147         (dump):
1148         * DumpRenderTree/mac/ImageDiff.m: Removed.
1149         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1150         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1151         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1152         (setDefaultColorProfileToRGB):
1153         (getBitmapContextFromWebView):
1154         (drawWebViewIntoContext):
1155         (repaintWithVerticalSweep):
1156         (repaintWithHorizontalSweep):
1157         (getSelectionRect):
1158         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1159
1160 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1161
1162         Bug 16052: prepare-ChangeLog doesn't report deleted files
1163         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1164
1165         Reviewed by Sam.
1166
1167         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1168
1169 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1170
1171         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1172         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1173
1174         Reviewed by Adam.
1175
1176         Roll functionality of merge-changelog into resolve-ChangeLogs
1177         script.  The script now checks for ChangeLog.rej and
1178         ChangeLog.orig files first.  If it finds them, it uses the
1179         ChangeLog.rej file as a patch (in old contextual diff format) to
1180         apply with --fuzz=3.
1181
1182         * Scripts/merge-changelog: Removed.
1183         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1184
1185 2007-11-25  Sam Weinig  <sam@webkit.org>
1186
1187         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1188
1189         Reviewed by Mark Rowe.
1190
1191         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1192         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1193         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1194         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1195         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1196
1197 2007-11-25  Sam Weinig  <sam@webkit.org>
1198
1199         Convert DumpRenderTree to ues .xcconfig files.
1200
1201         Reviewed by Mark Rowe.
1202
1203         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1204         * DumpRenderTree/mac/Configurations: Added.
1205         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1206         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1207         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1208
1209 2007-11-25  Sam Weinig  <sam@webkit.org>
1210
1211         Add ForwardingHeaders to wtf for DumpRenderTree.
1212
1213         Reviewed by Mark Rowe.
1214
1215         * DumpRenderTree/DumpRenderTree.h:
1216         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1217         * DumpRenderTree/ForwardingHeaders: Added.
1218         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1219         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1220         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1221         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1222         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1223         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1224         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1225         * DumpRenderTree/LayoutTestController.cpp:
1226         * DumpRenderTree/WorkQueue.cpp:
1227         * DumpRenderTree/mac/DumpRenderTree.mm:
1228         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1229         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1230         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1231         * DumpRenderTree/mac/ObjCController.m:
1232         * DumpRenderTree/mac/UIDelegate.mm:
1233         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1234
1235 2007-11-25  Adam Roben  <aroben@apple.com>
1236
1237         Fix some test failures caused by r28019
1238
1239         Now that stdout is in binary mode, we need to always use printf
1240         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1241         the output.
1242
1243         Reviewed by Sam.
1244
1245         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1246         printf.
1247         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1248         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1249         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1250         (UIDelegate::webViewAddMessageToConsole):
1251
1252 2007-11-25  Adam Roben  <aroben@apple.com>
1253
1254         Set the font smoothing preference in DRT
1255
1256         This makes the pixel results on Windows closer to the Mac results.
1257
1258         Reviewed by Mitz.
1259
1260         * DumpRenderTree/win/DumpRenderTree.cpp:
1261         (initializePreferences):
1262
1263 2007-11-25  Adam Roben  <aroben@apple.com>
1264
1265         Port ImageDiff to CG and C++
1266
1267         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1268         <rdar://5071708>
1269
1270         Reviewed by Sam.
1271
1272         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1273         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1274         (main):
1275         (createImageFromStdin):
1276         (compareImages):
1277         (getDifferenceBitmap):
1278         (computePercentageDifferent):
1279         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1280
1281 2007-11-25  Adam Roben  <aroben@apple.com>
1282
1283         Fix image diff link generation on Windows
1284
1285         Reviewed by Sam.
1286
1287         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1288         to toURL.
1289
1290 2007-11-25  Adam Roben  <aroben@apple.com>
1291
1292         Implement pixel dumping in Windows DRT
1293
1294         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1295         <rdar://5071708>
1296
1297         Reviewed by Sam.
1298
1299         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1300         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1301         Content-Length header.
1302         (getMD5HashStringForBitmap):
1303         (dumpWebViewAsPixelsAndCompareWithExpected):
1304         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1305         * DumpRenderTree/win/DumpRenderTree.cpp:
1306         (dump): Do a pixel dump if requested.
1307         (main): Parse pixel test options.
1308         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1309         the cg/ subdirectory to the include path.
1310         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1311         available in a header or import library, so we have to go through this
1312         LoadLibrary/GetProcAddress dance to use them.
1313         (cryptDLL):
1314         (init):
1315         (update):
1316         (final):
1317         (MD5_Init):
1318         (MD5_Update):
1319         (MD5_Final):
1320         * DumpRenderTree/win/MD5.h: Added.
1321         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1322         moved up to the top level to share it with Mac eventually.
1323         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1324         (getBitmapContextFromWebView): Forces the WebView to paint using a
1325         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1326
1327 2007-11-25  Adam Roben  <aroben@apple.com>
1328
1329         Clean up Windows DRT's option parsing a little bit
1330
1331         Reviewed by Sam.
1332
1333         * DumpRenderTree/win/DumpRenderTree.cpp:
1334         (main): Put non-option arguments into a Vector.
1335
1336 2007-11-25  Adam Roben  <aroben@apple.com>
1337
1338         Make Windows DRT stop changing LF into CRLF
1339
1340         Reviewed by Sam.
1341
1342         * DumpRenderTree/win/DumpRenderTree.cpp:
1343         (main): Put stdout in binary mode.
1344         * Scripts/run-webkit-tests: Remove the CRLF hack.
1345
1346 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1347
1348         Removed empty directory.
1349
1350         * Scripts/resources: Removed.
1351
1352 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1353
1354         Fix bisect-builds to work with recent WebKit nightly builds.
1355
1356         Reviewed by Dan.
1357
1358         * Scripts/bisect-builds: Check for the 
1359         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1360         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1361         to WebKit.app/Contents/Resources.
1362
1363 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1364
1365         Reviewed by Maciej.
1366
1367         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1368         not closed (affects digg.com)
1369
1370         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1371         one after finishing with a test to avoid having its delayed onload handler firing when
1372         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1373         but it helps somewhat.
1374
1375 2007-11-22  Mark Rowe  <mrowe@apple.com>
1376
1377         Reviewed by Alp Toker.
1378
1379         Fix build-webkit to propagate make's exit status if it fails.
1380
1381         * Scripts/webkitdirs.pm:
1382
1383 2007-11-22  Dan Bernstein  <mitz@apple.com>
1384
1385         Reviewed by Mark Rowe.
1386
1387         - fix crash when running pixel tests
1388
1389         * DumpRenderTree/mac/DumpRenderTree.mm:
1390         (dumpRenderTree): Parse the command line options before setting up the
1391         environment so that we know if we need to set up the pixel dump
1392         machinery.
1393
1394 2007-11-21  Eric Seidel  <eric@webkit.org>
1395
1396         Speculative build fix for Tiger.
1397
1398         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1399
1400 2007-11-21  Eric Seidel  <eric@webkit.org>
1401
1402         Reviewed by Tim Hatcher.
1403
1404         Break out more of DumpRenderTree.mm into individual files
1405
1406         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1407         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1408         (checkedMalloc):
1409         (checkedRealloc):
1410         (makeLargeMallocFailSilently):
1411         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1412         * DumpRenderTree/mac/DumpRenderTree.mm:
1413         (crashHandler):
1414         (dump):
1415         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1416         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1417         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1418         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1419         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1420         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1421         (javaScriptThreads):
1422         (runJavaScriptThread):
1423         (startJavaScriptThreads):
1424         (stopJavaScriptThreads):
1425         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1426         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1427         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1428         (restoreColorSpace):
1429         (setDefaultColorProfileToRGB):
1430         (initializeColorSpaceAndScreeBufferForPixelTests):
1431         (md5HashStringForBitmap):
1432         (dumpWebViewAsPixelsAndCompareWithExpected):
1433
1434 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1435
1436         Move install-unix-extras to wx directory as it seems only to be used by that 
1437         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1438         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1439         have install-unix-extras install into WebKitLibraries as per
1440         convention.
1441         
1442         Reviewed by Mark Rowe.
1443
1444         * Scripts/install-unix-extras: Removed.
1445         * wx/build-wxwebkit:
1446         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1447
1448 2007-11-21  Eric Seidel  <eric@webkit.org>
1449
1450         Reviewed by Adam.
1451
1452         More refactoring for greater code readability
1453
1454         * DumpRenderTree/mac/DumpRenderTree.mm:
1455         (initializeGlobalsFromCommandLineOptions):
1456         (initializeColorSpaceAndScreeBufferForPixelTests):
1457         (addTestPluginsToPluginSearchPath):
1458         (useLongRunningServerMode):
1459         (runTestingServerLoop):
1460         (prepareConsistentTestingEnvironment):
1461         (dumpRenderTree):
1462         (main):
1463         (dumpFramesAsText):
1464         (dumpBackForwardListForWebView):
1465         (sizeWebViewForCurrentTest):
1466         (methodNameStringForFailedTest):
1467         (dumpBackForwardListForAllWindows):
1468         (dumpWebViewAsPixelsAndCompareWithExpected):
1469         (invalidateAnyPreviousWaitToDumpWatchdog):
1470         (dump):
1471         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1472         * DumpRenderTree/mac/UIDelegate.mm:
1473         (-[UIDelegate webView:createWebViewWithRequest:]):
1474
1475 2007-11-21  Eric Seidel  <eric@webkit.org>
1476
1477         Reviewed by Tim Hatcher.
1478
1479         Abstract more of DRT into static methods
1480
1481         * DumpRenderTree/mac/DumpRenderTree.mm:
1482         (setDefaultsToConsistentValuesForTesting):
1483         (setupSignalHandlers):
1484         (allocateGlobalControllers):
1485         (releaseAndZero):
1486         (releaseGlobalControllers):
1487         (dumpRenderTree):
1488         (shouldLogFrameLoadDelegates):
1489         (createCFURLFromPathOrURL):
1490         (resetWebViewToConsistentStateBeforeTesting):
1491         (runTest):
1492
1493 2007-11-21  Eric Seidel  <eric@webkit.org>
1494
1495         Reviewed by Tim Hatcher.
1496
1497         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1498
1499         * DumpRenderTree/DumpRenderTree.h:
1500         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1501         * DumpRenderTree/mac/DumpRenderTree.mm:
1502         (dumpRenderTree):
1503         (dump):
1504         (runTest):
1505         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1506         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1507         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1508         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1509         (-[DumpRenderTreePasteboard declareType:owner:]):
1510         (+[LocalPasteboard alloc]):
1511         (-[LocalPasteboard init]):
1512         (-[LocalPasteboard dealloc]):
1513         (-[LocalPasteboard name]):
1514         (-[LocalPasteboard releaseGlobally]):
1515         (-[LocalPasteboard declareTypes:owner:]):
1516         (-[LocalPasteboard addTypes:owner:]):
1517         (-[LocalPasteboard changeCount]):
1518         (-[LocalPasteboard types]):
1519         (-[LocalPasteboard availableTypeFromArray:]):
1520         (-[LocalPasteboard setData:forType:]):
1521         (-[LocalPasteboard dataForType:]):
1522         (-[LocalPasteboard setPropertyList:forType:]):
1523         (-[LocalPasteboard setString:forType:]):
1524         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1525         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1526         (+[DumpRenderTreeWindow allWindows]):
1527         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1528         (-[DumpRenderTreeWindow dealloc]):
1529         (-[DumpRenderTreeWindow isKeyWindow]):
1530         (-[DumpRenderTreeWindow keyDown:]):
1531
1532 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1533
1534         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1535         it indiscriminately copies any headers inside JavaScriptCore,
1536         which includes Tiger ICU headers. 
1537
1538         * wx/build-wxwebkit:
1539         Don't run WebCore/move-js-headers.sh any longer.
1540
1541 2007-11-20  Adam Treat  <treat@kde.org>
1542
1543         Reviewed by David Kilzer.
1544
1545         * Prepend git branch name to $baseProductDir
1546
1547         * Scripts/VCSUtils.pm:
1548         * Scripts/webkitdirs.pm:
1549
1550 2007-11-20  Mark Rowe  <mrowe@apple.com>
1551
1552         Reviewed by Simon Hausmann.
1553
1554         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1555         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1556         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1557         built product and generated Makefile's are removed.
1558
1559 2007-11-19  Alp Toker  <alp@atoker.com>
1560
1561         Reviewed by Mark Rowe.
1562
1563         http://bugs.webkit.org/show_bug.cgi?id=16040
1564         [GTK] GtkLauncher should be written in C
1565
1566         Port GtkLauncher to plain C.
1567
1568         Use a more conventional GTK+ coding style.
1569
1570         Use a toolbar instead of menus.
1571
1572         Various signature fixes and cleanups.
1573
1574         Add a license header. Assume all previous modifications were copyright
1575         assigned to Apple Inc. by default.
1576
1577         * GtkLauncher/GtkLauncher.pro:
1578         * GtkLauncher/main.c: Added.
1579         (activate_url_entry_cb):
1580         (update_title):
1581         (link_hover_cb):
1582         (title_change_cb):
1583         (progress_change_cb):
1584         (destroy_cb):
1585         (go_back_cb):
1586         (go_forward_cb):
1587         (create_browser):
1588         (create_statusbar):
1589         (create_toolbar):
1590         (create_window):
1591         (main):
1592         * GtkLauncher/main.cpp: Removed.
1593
1594 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1595
1596         Build script fixes to ensure they do the right thing for the 
1597         wx port, and update build-wxwebkit to reflect the way the
1598         build scripts now work.
1599
1600         Reviewed by Adam.
1601
1602         * Scripts/build-testkjs:
1603         * Scripts/build-webkit:
1604         * Scripts/run-javascriptcore-tests:
1605         * Scripts/webkitdirs.pm:
1606         * wx/build-wxwebkit:
1607
1608 2007-11-18  Eric Seidel  <eric@webkit.org>
1609
1610         Reviewed by Anders.
1611
1612         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1613
1614         * Scripts/run-javascriptcore-tests:
1615
1616 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1617
1618         Reviewed by Adam Roben.
1619
1620         Make run-webkit-tests work with Windows debug build.
1621
1622         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1623         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1624         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1625         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1626         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1627
1628 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1629
1630         Add wxWebKit sample and build script, and integrate it with 
1631         build-webkit. Also make build-webkit --clean work for all
1632         ports.
1633
1634         Reviewed by Darin Adler.
1635
1636         * Scripts/build-webkit:
1637         * Scripts/webkitdirs.pm:
1638         * wx: Added.
1639         * wx/browser: Added.
1640         * wx/browser/browser.bkl: Added.
1641         * wx/browser/browser.cpp: Added.
1642         * wx/build-wxwebkit: Added.
1643
1644 2007-11-17  Adam Roben  <aroben@apple.com>
1645
1646         Make it easy to run Safari in the debugger on Windows
1647
1648         I've added a new script, debug-safari, which launches Safari in the
1649         debugger. On OS X it just calls gdb-safari.
1650
1651         Reviewed by Mark Rowe.
1652
1653         * FindSafari/FindSafari.cpp:
1654         (_tmain): Added a /debugger flag, which in combination with
1655         /printSafariLauncher will print a script that launches Safari in the
1656         debugger.
1657         * Scripts/debug-safari: Added.
1658         * Scripts/run-safari: Changed to call runSafari().
1659         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1660         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1661         first argument along to FindSafari.
1662         * Scripts/webkitdirs.pm:
1663         (sub runSafari): Added.
1664
1665 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1666
1667         Reviewed by Adam Roben.
1668
1669         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1670
1671 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1672
1673         Reviewed by David Kilzer.
1674
1675         The git config command was renamed to repo-config at some point. This
1676         change tries git config and then git repo-config if the first fails.
1677
1678         * Scripts/prepare-ChangeLog:
1679         (gitConfig):
1680
1681 2007-11-16  Dan Bernstein  <mitz@apple.com>
1682
1683         Reviewed by Darin Adler and Sam Weinig.
1684
1685         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1686
1687         * DumpRenderTree/win/EventSender.cpp:
1688         (keyDownCallback): For characters that cannot be entered on the active
1689         keyboard layout, send a WM_CHAR message with the character along with
1690         a WM_KEYDOWN message with a virtual key code of 255.
1691
1692 2007-11-16  Mark Rowe  <mrowe@apple.com>
1693
1694         Reviewed by Tim Hatcher.
1695
1696         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1697
1698         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1699         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1700
1701 2007-11-15  Adam Roben  <aroben@apple.com>
1702
1703         Make run-safari actually work on Windows
1704
1705         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1706         chdir call.
1707
1708 2007-11-14  Adam Roben  <aroben@apple.com>
1709
1710         Updates to Safari launching now that 3.0.4 is released
1711
1712         Reviewed by Sam.
1713
1714         * FindSafari/FindSafari.cpp:
1715         (getWebViewCLSID): Use version-independent ProgID.
1716         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1717
1718 2007-11-14  Anders Carlsson  <andersca@apple.com>
1719
1720         Reviewed by Adam.
1721
1722         <rdar://problem/5309081>
1723         In DRT, "plugin.logDestroy = true" not working on Windows.
1724         
1725         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1726         (NPP_Destroy):
1727
1728 2007-11-14  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Sam.
1731
1732         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1733
1734 2007-11-14  Anders Carlsson  <andersca@apple.com>
1735
1736         Reviewed by Adam.
1737
1738         <rdar://problem/5141186>
1739         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1740         
1741         Implement setWindowIsKey.
1742         
1743         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1744         (LayoutTestController::setWindowIsKey):
1745
1746 2007-11-13  Sam Weinig  <sam@webkit.org>
1747
1748         Reviewed by Adam Roben.
1749
1750         Fix for <rdar://problem/5382579>
1751         http/tests/security/cross-frame-access-put.html reports large 
1752         negative numbers for screenLeft and screenTop (Mac reports "0")
1753
1754         * DumpRenderTree/win/UIDelegate.cpp:
1755         (UIDelegate::UIDelegate): Initialize the RECT.
1756         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1757         (UIDelegate::webViewFrame): ditto.
1758         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1759
1760 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1761
1762         Reviewed by Adam.
1763
1764         - Make Drosera show source, source URLs, and function stack on Windows,
1765         and some minor fixes.
1766
1767         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1768         (DebuggerDocument::updateFileSource):
1769         * Drosera/debugger.js: Force source to always update display.
1770         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1771         menu controls.
1772         (DebuggerClient::resume):
1773         (DebuggerClient::pause):
1774         (DebuggerClient::stepInto):
1775         (DebuggerClient::stepOver):
1776         (DebuggerClient::stepOut):
1777         (DebuggerClient::showConsole):
1778         (DebuggerClient::closeCurrentFile):
1779         * Drosera/win/DebuggerClient.h: Ditto.
1780         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1781         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1782         removed two bugs.  1) caller could be in a bad state when asked to
1783         assign into it. 2) BSTRs were not created correctly.
1784         (DebuggerDocument::getPlatformCurrentFunctionStack):
1785         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1786         (droseraWndProc):
1787         (handleCommand):
1788         (Drosera::resume):
1789         (Drosera::pause):
1790         (Drosera::stepInto):
1791         (Drosera::stepOver):
1792         (Drosera::stepOut):
1793         (Drosera::showConsole):
1794         (Drosera::closeCurrentFile):
1795         * Drosera/win/Drosera.h: Hook up the menu controls.
1796         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1797         functions, added a null check, and fixed another bug where caller could
1798         be in a bad state when asked to assign into it.
1799         (ServerConnection::didLoadMainResourceForDataSource):
1800         (ServerConnection::getCallerFrame):
1801         * Drosera/win/ServerConnection.h: Safety first.
1802
1803 2007-11-13  Dan Bernstein  <mitz@apple.com>
1804
1805         Reviewed by Darin Adler.
1806
1807         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1808           DumpRenderTree --pixel-tests renders each test twice
1809
1810         * DumpRenderTree/mac/DumpRenderTree.mm:
1811         (dumpRenderTree): Removed the --paint option because the painting code
1812         is always exercised as a result of
1813         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1814         calling -displayIfNeeded.
1815         (dump): Changed to always grab the image from the window since the view
1816         is always displayed.
1817         (runTest):
1818         (displayWebView):
1819         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1820         because it always paints.
1821
1822 2007-11-12  Antti Koivisto  <antti@apple.com>
1823
1824         Reviewed by Adele.
1825         
1826         Add support for http media tests
1827
1828         * Scripts/run-webkit-tests:
1829
1830 2007-11-12  Sam Weinig  <sam@webkit.org>
1831
1832         Reviewed by Adam Roben.
1833
1834         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1835
1836         * DumpRenderTree/win/DumpRenderTree.cpp:
1837         (runTest):
1838         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1839         (LayoutTestController::setPrivateBrowsingEnabled):
1840
1841 2007-11-12  Adam Roben  <aroben@apple.com>
1842
1843         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1844         mac and win subdirectories.
1845
1846 2007-11-11  Adam Roben  <aroben@apple.com>
1847
1848         Fix <rdar://5133816> keepWebHistory is not implemented
1849
1850         Fixes fast/history/clicked-link-is-visited.html.
1851
1852         Reviewed by Darin.
1853
1854         * DumpRenderTree/win/DumpRenderTree.cpp:
1855         (runTest): Clear the optionalSharedHistory.
1856         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1857         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1858
1859 2007-11-10  Sam Weinig  <sam@webkit.org>
1860
1861         Reviewed by Tim Hatcher.
1862
1863         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1864         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1865         is turned on)
1866
1867         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1868
1869         Added test: http/tests/security/cross-frame-access-private-browsing.html
1870
1871         * DumpRenderTree/LayoutTestController.cpp:
1872         (setPrivateBrowsingEnabledCallback):
1873         (LayoutTestController::staticFunctions):
1874         * DumpRenderTree/LayoutTestController.h:
1875         * DumpRenderTree/mac/DumpRenderTree.mm:
1876         (runTest): Default to private browsing disabled.
1877         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1878         (LayoutTestController::setPrivateBrowsingEnabled):
1879         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1880         (LayoutTestController::setPrivateBrowsingEnabled):
1881
1882 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1883
1884         Reviewed by Adam.
1885
1886         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1887         WebCore's!
1888
1889         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1890         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1891         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1892         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1893         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1894         * Drosera/win/Drosera.cpp:
1895         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1896
1897 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1898
1899         Reviewed by Sam.
1900
1901         - Use the new IWebFrame [local] function signature and get the shared
1902         server correctly.
1903
1904         * Drosera/win/DebuggerClient.cpp:
1905         (DebuggerClient::didFinishLoadForFrame):
1906         * Drosera/win/ServerConnection.cpp:
1907         (ServerConnection::attemptToCreateServerConnection):
1908
1909 2007-11-07  Dan Bernstein  <mitz@apple.com>
1910
1911         Reviewed by Darin Adler.
1912
1913         - add an option to run-webkit-tests to ignore pixel test failures where
1914           all pixels differ by no more than a specified threshold
1915
1916         * DumpRenderTree/mac/ImageDiff.m:
1917         (main):
1918         (compareImages):
1919         (computePercentageDifferent):
1920         * Scripts/run-webkit-tests:
1921
1922 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1923
1924         Reviewed by Lars.
1925
1926         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1927
1928         * DumpRenderTree/qt/DumpRenderTree.cpp:
1929
1930 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1931
1932         Reviewed by Lars.
1933
1934         Reworked the QWebSettings API.
1935         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1936
1937         * DumpRenderTree/qt/DumpRenderTree.cpp:
1938
1939 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1940
1941         Reviewed by Lars.
1942
1943         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1944
1945         * DumpRenderTree/qt/jsobjects.cpp:
1946
1947 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1948
1949         Reviewed by Lars Knoll <lars@trolltech.com>.
1950
1951         Add a QWebPage::frameCreated() signal and fix DRT
1952         
1953         The removal of createFrame in QWebPage broke the re-implementation
1954         in DumpRenderTree. Instead emit a frameCreated() signal and
1955         connect to it in DumpRenderTree.
1956         
1957
1958         * DumpRenderTree/qt/DumpRenderTree.cpp:
1959         (WebCore::WebPage::WebPage):
1960         (WebCore::DumpRenderTree::dump):
1961         (WebCore::DumpRenderTree::connectFrame):
1962         * DumpRenderTree/qt/DumpRenderTree.h:
1963
1964 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1965
1966         Reviewed by Lars Knoll <lars@trolltech.com>.
1967
1968         Moved all the event handlers from QWebFrame into QWebPage.
1969         
1970         This cleans up the public API and allows us to remove the
1971         HackWebFrame hack in DumpRenderTree.
1972         
1973
1974         * DumpRenderTree/qt/jsobjects.cpp:
1975         (EventSender::mouseDown):
1976         (EventSender::mouseUp):
1977         (EventSender::mouseMoveTo):
1978
1979 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1980
1981         Reviewed by Mark.
1982
1983         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1984         to prevent the default implementation from popping up messageboxes.
1985
1986         * DumpRenderTree/qt/DumpRenderTree.cpp:
1987         (WebCore::WebPage::javaScriptConfirm):
1988         (WebCore::WebPage::javaScriptPrompt):
1989
1990 2007-11-06  Eric Seidel  <eric@webkit.org>
1991
1992         * Scripts/build-testkjs: build fix... too many $$
1993
1994 2007-11-06  Eric Seidel  <eric@webkit.org>
1995
1996         Reviewed by Mark Rowe.
1997
1998         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1999
2000 2007-11-05  Adam Roben  <aroben@apple.com>
2001
2002         Add support on Windows for WEBKIT_TESTFONTS
2003
2004         This environment variable lets you specify where the fonts to be used
2005         by DumpRenderTree reside. The Qt port is already using this, so I'm
2006         just following their lead.
2007
2008         Reviewed by Darin.
2009
2010         * DumpRenderTree/win/DumpRenderTree.cpp:
2011         (exePath): Refactored code out of initialize().
2012         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2013         DumpRenderTree.resources.
2014         (initialize): Use the new fontsPath function.
2015         (main): Use the new exePath function.
2016         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2017         variable to DRT, like Qt does.
2018
2019 2007-11-05  Mark Rowe  <mrowe@apple.com>
2020
2021         Rubber-stamped by Alp Toker.
2022
2023         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2024
2025         * GtkLauncher/main.cpp:
2026         (goToURLBarText):
2027         (main):
2028
2029 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2030
2031         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2032         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2033
2034         Reviewed by Timothy.
2035
2036         Restrict the range of nightly builds used by the bisect-builds script
2037         based on the version of Safari and the version of Mac OS X being used.
2038
2039         Mac OS X 10.4: Safari 2.0: r11976 or newer
2040         Mac OS X 10.4: Safari 3.0: r19992 or newer
2041
2042         Mac OS X 10.5: Safari 2.0: r19594 or newer
2043         Mac OS X 10.5: Safari 3.0: r25124 or newer
2044
2045         * Scripts/bisect-builds:
2046         (findMacOSXVersion): Added.
2047         (makeNightlyList): Added argument to provide version of Mac OS X.
2048         Restrict range of nightly builds based on Safari and Mac OS X versions.
2049
2050 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2051
2052         Reviewed by Maciej.
2053
2054         - This patch involves several changes, all of them were noticed that
2055         they were needed by the work being done in WebKit to get Drosera and
2056         WebKit working together on Windows.
2057         - The changes are:
2058         1) Added a debugger console for output messages.
2059         2) Drosera now listens for the WebKit server (before, the server would
2060         have to be running before Drosera was started.)
2061         3) Fixed a bug where the WebView started out as 0x0 pixels.
2062         4) Fixed a bug when there is no scope.
2063         5) Added the HTML, JS, and CSS to the project file to make them easy to
2064         find.
2065         6) Made the ServerConnection functions virtual.
2066
2067         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2068         for the WebKit server.
2069         (DebuggerClient::DebuggerClient):
2070         (DebuggerClient::~DebuggerClient):
2071         (DebuggerClient::didFinishLoadForFrame):
2072         (DebuggerClient::serverConnected):
2073         (DebuggerClient::attemptToCreateServerConnection):
2074         * Drosera/win/DebuggerClient.h: Ditto.
2075         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2076         scope.
2077         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2078         (DebuggerDocument::platformValueForScopeVariableNamed):
2079         * Drosera/win/Drosera.cpp:
2080         (_tWinMain): Added a console in debug for output messages.
2081         (Drosera::Drosera): Listen for server.
2082         (Drosera::initUI): The server now Initializes COM.
2083         (Drosera::serverConnected): Part of the listening for the server.
2084         (Drosera::attemptToCreateServerConnection): Ditto.
2085         * Drosera/win/Drosera.h: New interface for listening for the server.
2086         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2087         files to the VS project.
2088         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2089         connection.
2090         (ServerConnection::ServerConnection):
2091         (ServerConnection::attemptToCreateServerConnection):
2092         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2093         methods.
2094         (ServerConnection::serverConnected):
2095
2096 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2097
2098         Reviewed by Maciej.
2099
2100         http://bugs.webkit.org/show_bug.cgi?id=15832
2101         fast/dom/gc-10.html crashes when run alone
2102
2103         Check for !done before using objects that can be already deallocated.
2104
2105         * DumpRenderTree/mac/EditingDelegate.mm:
2106         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2107         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2108         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2109         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2110         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2111         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2112         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2113         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2114         (-[EditingDelegate webViewDidBeginEditing:]):
2115         (-[EditingDelegate webViewDidChange:]):
2116         (-[EditingDelegate webViewDidEndEditing:]):
2117         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2118         (-[EditingDelegate webViewDidChangeSelection:]):
2119         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2120         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2121         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2122         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2123         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2124         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2125         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2126         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2127         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2128         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2129         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2130         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2131         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2132         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2133         (-[FrameLoadDelegate webView:willCloseFrame:]):
2134         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2135         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2136         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2137         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2138         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2139         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2140         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2141         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2142         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2143
2144 2007-11-04  Mark Rowe  <mrowe@apple.com>
2145
2146         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2147         warnings that would otherwise be suppressed due to it being a system header.
2148
2149         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2150
2151 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2152
2153         Rubber stamped by Adam.
2154         
2155         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2156
2157         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2158
2159 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2160
2161         Sort files(...); sections of Xcode project files.
2162
2163         Rubber-stamped by Darin.
2164
2165         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2166         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2167         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2168         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2169
2170 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2171
2172         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2173
2174         Reviewed by Darin.
2175
2176         * Scripts/sort-Xcode-project-file: Added.
2177
2178 2007-11-02  Darin Adler  <darin@apple.com>
2179
2180         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2181
2182 2007-11-02  Darin Adler  <darin@apple.com>
2183
2184         Reviewed by Maciej.
2185
2186         * Scripts/run-sunspider: Pass the "--base" option through.
2187
2188         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2189         the real script do that. Default configuration to Release to match run-sunspider
2190         so we don't end up building Debug just to compare results.
2191
2192 2007-11-01  Adam Roben  <aroben@apple.com>
2193
2194         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2195
2196         Reviewed by Sam.
2197
2198         * Scripts/commit-log-editor: Show all the directories beneath the
2199         source root, instead of just the last one.
2200
2201 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2202
2203         Reviewed by Adam Roben.
2204
2205         Print out an error message when the Windows build fails
2206         and provide guidance on how to find out what went wrong.
2207
2208         * Scripts/build-webkit:
2209         * Scripts/webkitdirs.pm:
2210
2211 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2212
2213         Rubber-stamped by Adam Roben.
2214
2215         Rolled out r27326 - debug CRT seems to cause no problems after all.
2216
2217         * DumpRenderTree/win/DumpRenderTree.vcproj:
2218
2219 2007-10-31  Adam Roben  <aroben@apple.com>
2220
2221         Switch the Debug configuration to using the non-debug CRT
2222
2223         This matches WebKit.
2224
2225         Reviewed by Steve.
2226
2227         * DumpRenderTree/win/DumpRenderTree.vcproj:
2228
2229 2007-10-31  Antti Koivisto  <antti@apple.com>
2230
2231         Reviewed by bdash.
2232         
2233         Disable media tests when doing leak checking on Tiger.
2234         They crash in QuickTime (rdar://problem/5537157).
2235
2236         * Scripts/run-webkit-tests:
2237
2238 2007-10-29  Antti Koivisto  <antti@apple.com>
2239
2240         Reviewed by Maciej.
2241         
2242         Build media support by default on OSX only.
2243
2244         * Scripts/build-webkit:
2245
2246 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2247
2248         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2249         get caught by the pre-commit hooks.
2250
2251 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2252
2253         Reviewed by Adam.
2254
2255         - This is a collection of relatively unrelated changes and cleanups
2256         to Drosera to prepare it for interacting with WebKit.  A lot of these
2257         changes are just correcting mistakes, for example removing included
2258         headers that are no longer needed.
2259
2260         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2261         this will be needed by the DebuggerClient.
2262         (DebuggerDocument::server):
2263         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2264         * Drosera/win/DebuggerClient.cpp: 
2265         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2266         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2267         (DebuggerClient::createWebViewWithRequest): Added comment about its
2268         purpose. 
2269         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2270         declarations.
2271         (DebuggerClient::webViewLoaded): Moved.
2272         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2273         file, since this was the only place it was used.
2274         (cfStringToBSTR):
2275         * Drosera/win/Drosera.h: Cleaned up the includes.
2276         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2277         * Drosera/win/HelperFunctions.h: Removed.
2278
2279 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2280
2281         Reviewed by Adam.
2282
2283         - Small cleanup in the ServerConnection class.
2284
2285         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2286         and added an include.
2287         (ServerConnection::currentFrame):
2288         (ServerConnection::getCallerFrame):
2289         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2290         made a pointer into a COMPtr, and cleaned up the includes.
2291
2292 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2293
2294         Reviewed by John Sullivan.
2295         
2296         - Place the Localizable.strings file in mac or win directories
2297           if that location exists.
2298         - Also look for UI_STRING in .c files.
2299
2300         * Scripts/extract-localizable-strings:
2301
2302 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2303
2304         Reviewed by Adam.
2305
2306         - Set the eol-style to native and made all the line endings the same
2307         so that I avoid messy diffs that show eol changes.
2308
2309         * Drosera/win/ServerConnection.cpp:
2310         (ServerConnection::didParseSource):
2311         (ServerConnection::didEnterCallFrame):
2312         (ServerConnection::willExecuteStatement):
2313         (ServerConnection::willLeaveCallFrame):
2314         (ServerConnection::exceptionWasRaised):
2315
2316 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2317
2318         Reviewed by Adam.
2319
2320         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2321         functionality that could not have existed previously without the new
2322         interfaces.
2323         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2324         from a BSTR to a JSValueRef.
2325         (DebuggerDocument::platformEvaluateScript): Implemented.
2326         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2327         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2328         Implemented.
2329         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2330         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2331         * Drosera/win/ServerConnection.cpp: Added a helper function.
2332         (ServerConnection::getCallerFrame):
2333         * Drosera/win/ServerConnection.h: Added a helper function.
2334
2335 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2336
2337         updated reviewers for my previous changelog.
2338
2339 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2340         Reviewed by Maciej and Adam and Geoff.
2341
2342         - Minor mac-side improvements including moving a function to a more
2343         appropriate location, fixing a warning, and correctly checking
2344         exceptions.
2345
2346         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2347         (DebuggerDocument::willExecuteStatement):
2348         (DebuggerDocument::didEnterCallFrame):
2349         (DebuggerDocument::willLeaveCallFrame):
2350         (DebuggerDocument::windowScriptObjectAvailable):
2351         (DebuggerDocument::callFunctionOnObject):
2352         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2353         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2354         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2355         because it doesn't require the ServerConnection at all.
2356         (NSStringCreateWithJSStringRef): Made an argument const.
2357         (JSValueRefCreateWithNSString): Made an argument const.
2358         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2359         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2360         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2361         * Drosera/mac/ServerConnection.mm: Ditto.
2362         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2363
2364 2007-10-29  Sam Weinig  <sam@webkit.org>
2365
2366         Reviewed by Adam Roben.
2367
2368         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2369
2370         * DumpRenderTree/LayoutTestController.cpp:
2371         (LayoutTestController::LayoutTestController):
2372         (getGlobalFlagCallback):
2373         (setGlobalFlagCallback):
2374         (LayoutTestController::getJSClass):
2375         (LayoutTestController::staticValues):
2376         * DumpRenderTree/LayoutTestController.h:
2377         (LayoutTestController::globalFlag):
2378         (LayoutTestController::setGlobalFlag):
2379
2380 2007-10-29  Darin Adler  <darin@apple.com>
2381
2382         Reviewed by Maciej.
2383
2384         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2385         resolution instead of its default.
2386
2387 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2388
2389         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2390
2391         Reviewed by Mark Rowe.
2392
2393         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2394         was successfully resolved, but this would not show any status because the change had
2395         already been cached in the index using "git add".  The solution is to add an optional
2396         second argument to showStatus() which adds the "--cached" switch to the command.
2397
2398         * Scripts/resolve-ChangeLogs:
2399         (showStatus):
2400
2401 2007-10-28  Eric Seidel  <eric@webkit.org>
2402
2403         Reviewed by Maciej and Geoff, in unison.
2404
2405         * Scripts/run-webkit-tests: remove broken --svg option
2406
2407 2007-10-28  Darin Adler  <darin@apple.com>
2408
2409         Reviewed by Adam.
2410
2411         * Scripts/run-sunspider: Default to "Release" configuration rather than
2412         defaulting to the last configuration used as other scripts do. This can
2413         still be overriden on the command line with "--debug" if there's some
2414         reason to do so. Also fix a typo.
2415
2416         * Scripts/sunspider-compare-results: Fix a typo.
2417
2418 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2419
2420         Reviewed by Adam.
2421
2422         - Implemented the WebScriptDebugListener functions now that the
2423         WebScriptDebugServer exists
2424
2425         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2426         functions.
2427         (ServerConnection::currentFrame):
2428         (ServerConnection::didLoadMainResourceForDataSource):
2429         (ServerConnection::didParseSource):
2430         (ServerConnection::failedToParseSource):
2431         (ServerConnection::didEnterCallFrame):
2432         (ServerConnection::willExecuteStatement):
2433         (ServerConnection::willLeaveCallFrame):
2434         (ServerConnection::exceptionWasRaised):
2435         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2436         members arguments list.
2437
2438 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2439
2440         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2441         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2442
2443         Reviewed by Darin.
2444
2445         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2446         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2447         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2448         file.  Note that it may also be used as a stand-alone script.
2449
2450         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2451         * Scripts/resolve-ChangeLogs: Added.
2452         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2453
2454 2007-10-26  Mark Rowe  <mrowe@apple.com>
2455
2456         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2457         to the Qt port on the assumption that it was an implementation of the cross-platform
2458         LayoutTestController class.  It is not, so it did not need to be changed.
2459
2460         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2461
2462 2007-10-25  Mark Rowe  <mrowe@apple.com>
2463
2464         Reviewed by Maciej.
2465
2466         Fix builds with code coverage enabled.
2467
2468         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2469
2470 2007-10-25  Darin Adler  <darin@apple.com>
2471
2472         Reviewed by Mark Rowe.
2473
2474         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2475         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2476
2477 2007-10-25  Stephanie  <slewis@apple.com>
2478
2479         build Fix
2480
2481         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2482
2483 2007-10-25  Stephanie  <slewis@apple.com>
2484
2485         Reviewed by Mark Rowe, Adam Roben.
2486
2487         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2488
2489         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2490
2491 2007-10-25  Alice Liu  <alice.liu@apple.com>
2492
2493         Reviewed by Adam.
2494
2495         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2496
2497         Moving destructor into platform-specific files
2498         * DumpRenderTree/LayoutTestController.cpp:
2499         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2500         (LayoutTestController::~LayoutTestController):
2501         * DumpRenderTree/qt/jsobjects.cpp:
2502         (LayoutTestController::~LayoutTestController):
2503
2504         LayoutTestController wasn't being destroyed
2505         * DumpRenderTree/win/DumpRenderTree.cpp:
2506         (runTest):
2507
2508         Added declspec
2509         * DumpRenderTree/win/EditingDelegate.h:
2510
2511         Reset certain values on the webview (or related delegate) that might 
2512         have changed while running a test
2513         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2514         (LayoutTestController::~LayoutTestController):
2515
2516 2007-10-25  Adam Roben  <aroben@apple.com>
2517
2518         Make sunspider-compare-results work with relative paths
2519
2520         Reviewed by Sam.
2521
2522         * Scripts/sunspider-compare-results: Convert arguments to absolute
2523         paths before we chdir.
2524
2525 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2526
2527         Reviewed by Sam.
2528
2529         - Implemented server calls now the WebScriptDebugServer exists.
2530         - Also removed no longer needed call to initialize CG.
2531
2532         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2533         automatically now.
2534         (_tWinMain):
2535         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2536         (ServerConnection::ServerConnection):
2537         (ServerConnection::~ServerConnection):
2538         (ServerConnection::pause):
2539         (ServerConnection::resume):
2540         (ServerConnection::stepInto):
2541         (ServerConnection::applicationTerminating):
2542         (ServerConnection::serverConnectionDidDie):
2543         * Drosera/win/ServerConnection.h: Now uses the COM class.
2544
2545 2007-10-24  George Staikos  <staikos@kde.org>
2546
2547         Unbreak Qt build.
2548
2549         * Scripts/build-webkit:
2550
2551 2007-10-24  Adam Roben  <aroben@apple.com>
2552
2553         Remove now-unnecessary call to InitializeCoreGraphics
2554
2555         WebKit takes care of this now.
2556
2557         Reviewed by Ada.
2558
2559         * DumpRenderTree/win/DumpRenderTree.cpp:
2560         (initialize):
2561
2562 2007-10-24  Adam Roben  <aroben@apple.com>
2563
2564         Use WebTextRenderer in DRT
2565
2566         Reviewed by Ada.
2567
2568         * DumpRenderTree/win/DumpRenderTree.cpp:
2569         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2570
2571 2007-10-24  Sven Herzberg  <sven@imendio.com>
2572
2573         Reviewed by Mark Rowe.
2574
2575         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2576         Bug 15614: [GTK] qmake based backends don't build on OS X
2577
2578         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2579         GTK backend on a Mac
2580         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2581         isDarwin() to make it reusable in other places (like the workaround-
2582         for-prebuilt-qmake in build-webkit)
2583
2584 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2585
2586         Refurbish update-webkit script.
2587
2588         Reviewed by Adam.
2589
2590         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2591         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2592         multi-argument version of system() for flexibility and security.  Check for existence
2593         of Internal directory using -d test instead of -x.
2594
2595 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2596
2597         Minor clean-up of prepare-ChangeLog script.
2598
2599         Reviewed by Adam.
2600
2601         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2602         of a string.  Use multi-argument versions of open() and system() for flexibility and
2603         security.
2604
2605 2007-10-24  Alice Liu  <alice.liu@apple.com>
2606
2607         Reviewed by Oliver.
2608
2609         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2610
2611         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2612         replay the saved events when we're still processing the mousedown that starts the drag
2613         * DumpRenderTree/win/EventSender.cpp:
2614         (doMouseMove):
2615         * DumpRenderTree/win/UIDelegate.cpp:
2616         (UIDelegate::doDragDrop):
2617
2618 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2619
2620         Reviewed by Sam, Steve and Darin.
2621
2622         - Stubbed out the WebScriptDebugListener functionality in the Server
2623         Connection class to prepare it for receiving those callbacks.
2624         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2625         and the ServerConnection to not need to be initialized with a server
2626         name, since that is not the way we connect to the WebKit server. 
2627
2628         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2629         no exception.  Now it only loggs when there is an exception
2630         (DebuggerDocument::willExecuteStatement):
2631         (DebuggerDocument::didEnterCallFrame):
2632         (DebuggerDocument::willLeaveCallFrame):
2633         (DebuggerDocument::windowScriptObjectAvailable):
2634         (DebuggerDocument::callFunctionOnObject):
2635         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2636         to be instantiated with a server's name.
2637         (DebuggerClient::DebuggerClient):
2638         (DebuggerClient::didFinishLoadForFrame):
2639         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2640         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2641         a server name.
2642         (Drosera::init):
2643         (Drosera::initServer):
2644         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2645         instantiated with a server's name.
2646         * Drosera/win/ServerConnection.cpp: 
2647         (ServerConnection::ServerConnection): No longer needs a server name
2648         (ServerConnection::~ServerConnection): Only release the global context
2649         if there is one.
2650         (ServerConnection::serverConnectionDidDie): Stub for
2651         IWebScriptDebugListener
2652         (ServerConnection::QueryInterface): ditto
2653         (ServerConnection::AddRef): ditto
2654         (ServerConnection::Release): ditto
2655         (ServerConnection::didLoadMainResourceForDataSource): ditto
2656         (ServerConnection::didParseSource): ditto
2657         (ServerConnection::failedToParseSource): ditto
2658         (ServerConnection::didEnterCallFrame): ditto
2659         (ServerConnection::willExecuteStatement): ditto
2660         (ServerConnection::willLeaveCallFrame): ditto
2661         (ServerConnection::exceptionWasRaised): ditto
2662         * Drosera/win/ServerConnection.h: Stubbed out the
2663         IWebScriptDebugListener functions, and this class no longer needs to be
2664         instantiated with a server name.
2665
2666 2007-10-24  Lars Knoll  <lars@trolltech.com>
2667
2668         Reviewed by Simon.
2669
2670         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2671
2672         * DumpRenderTree/qt/jsobjects.h:
2673
2674 2007-10-24  Lars Knoll  <lars@trolltech.com>
2675
2676         Reviewed by Simon.
2677
2678         add another command.
2679
2680         * DumpRenderTree/qt/jsobjects.cpp:
2681         (TextInputController::doCommand):
2682
2683 2007-10-24  Lars Knoll  <lars@trolltech.com>
2684
2685         Reviewed by Simon.
2686
2687         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2688
2689         * DumpRenderTree/qt/jsobjects.cpp:
2690         (EventSender::keyDown):
2691         * DumpRenderTree/qt/jsobjects.h:
2692
2693 2007-10-24  Lars Knoll  <lars@trolltech.com>
2694
2695         Reviewed by Simon.
2696
2697         implement eventSender.keyDown().
2698
2699         * DumpRenderTree/qt/jsobjects.cpp:
2700         (EventSender::keyDown):
2701
2702 2007-10-24  Lars Knoll  <lars@trolltech.com>
2703
2704         Reviewed by Simon.
2705
2706         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2707
2708         * DumpRenderTree/qt/DumpRenderTree.cpp:
2709         (WebCore::DumpRenderTree::DumpRenderTree):
2710         (WebCore::DumpRenderTree::initJSObjects):
2711         * DumpRenderTree/qt/jsobjects.cpp:
2712         (TextInputController::doCommand):
2713
2714 2007-10-24  Lars Knoll  <lars@trolltech.com>
2715
2716         Reviewed by Simon.
2717
2718         first bit of implementation for the textinputcontroller.
2719
2720         * DumpRenderTree/qt/DumpRenderTree.cpp:
2721         (WebCore::DumpRenderTree::DumpRenderTree):
2722         * DumpRenderTree/qt/DumpRenderTree.h:
2723         * DumpRenderTree/qt/jsobjects.cpp:
2724         (TextInputController::TextInputController):
2725         (TextInputController::doCommand):
2726         * DumpRenderTree/qt/jsobjects.h:
2727
2728 2007-10-24  Lars Knoll  <lars@trolltech.com>
2729
2730         Reviewed by Simon.
2731
2732         make the man webpage believe it has focus, so the editing tests work correctly.
2733
2734         * DumpRenderTree/qt/DumpRenderTree.cpp:
2735         (WebCore::DumpRenderTree::DumpRenderTree):
2736
2737 2007-10-24  Lars Knoll  <lars@trolltech.com>
2738
2739         Reviewed by Simon.
2740
2741         implement layoutTestController.dumpEditingCallbacks() correctly.
2742
2743         * DumpRenderTree/qt/DumpRenderTree.cpp:
2744         (WebCore::DumpRenderTree::DumpRenderTree):
2745         * DumpRenderTree/qt/jsobjects.cpp:
2746         (LayoutTestController::reset):
2747         (LayoutTestController::dumpEditingCallbacks):
2748
2749 2007-10-24  Lars Knoll  <lars@trolltech.com>
2750
2751         Reviewed by Simon.
2752
2753         Implement support for testing editing.
2754
2755         * DumpRenderTree/qt/DumpRenderTree.cpp:
2756         (WebCore::DumpRenderTree::DumpRenderTree):
2757
2758 2007-10-23  Sam Weinig  <sam@webkit.org>
2759
2760         Check for null BSTR that can be passed to the UIDelegate methods
2761         from javascript null and undefined.  Fixes a failing test case on
2762         Windows (fast/dom/Window/alert-undefined.html)
2763
2764         Reviewed by Eric Seidel.
2765
2766         * DumpRenderTree/win/UIDelegate.cpp:
2767         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2768         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2769         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2770         (UIDelegate::webViewAddMessageToConsole):
2771
2772 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2773
2774         Reviewed by Darin.
2775         
2776         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2777
2778         * Scripts/build-testkjs:
2779
2780 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2781
2782         Reviewed by Darin.
2783
2784         - add wrapper that finds the right copy of testkjs
2785         
2786         * Scripts/sunspider-compare-results: Added.
2787
2788 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2789
2790         Reviewed by Sam.
2791
2792         - After talking with Steve I now see that the WebKit server must be
2793         running for DCOM to create the distributed objects, which makes sense
2794         and currently WebKit only allows one instance to be running at a time
2795         which avoids accidentally connecting to the wrong server
2796         - In light of this I have removed the code for the attach box and
2797         NotificationServer and known server names, since they are all extranious
2798         now.
2799
2800         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2801         names.
2802         (_tWinMain): Uses init instead of initUI.
2803         (droseraWndProc): No longer creats an attach dialog box.
2804         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2805         it's not manditory to call init before doing COM stuff.
2806         (Drosera::init): calls initUI and will call attach when the
2807         functionality exists. 
2808         (Drosera::initUI): Has changed very little.
2809         (Drosera::attach): Changed the signature to reflect that we no longer
2810         need the dictionary of known server names.
2811         * Drosera/win/Drosera.h: Removed notification classes and known server
2812         names.  Also renamed and moved some functions.
2813         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2814         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2815         headers to the resources folder. 
2816         * Drosera/win/resource.h: Removed the Attach box.
2817
2818 2007-10-22  Adam Roben  <aroben@apple.com>
2819
2820         Windows build fix
2821
2822         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2823
2824 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2825
2826         - Removed a leak that was fixed.
2827
2828         * Scripts/run-webkit-tests:
2829
2830 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2831
2832         Reviewed by Darin.
2833
2834         - Changed the Client so that the DebuggerDocument now own the
2835         ServerConnection.  This simplifies ownership and cleanup. 
2836
2837         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2838         ServerConnection.
2839         (DebuggerClient::initWithServerName):
2840         (DebuggerClient::didFinishLoadForFrame):
2841         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2842         ServerConnection.
2843         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2844         until after we have a server which we are attached to.
2845         (Drosera::initUI):
2846         (Drosera::attach):
2847         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2848         out previously.
2849
2850 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2851
2852         Reviewed by Nikolas.
2853
2854         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2855
2856         * Scripts/run-javascriptcore-tests:
2857
2858 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2859
2860         Reviewed by Nikolas.
2861
2862         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2863
2864         * Scripts/build-drosera:
2865         * Scripts/build-dumprendertree:
2866         * Scripts/build-testkjs:
2867         * Scripts/build-webkit:
2868         * Scripts/run-javascriptcore-tests:
2869         * Scripts/run-sunspider:
2870         * Scripts/run-webkit-tests:
2871         * Scripts/webkitdirs.pm:
2872
2873 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2874
2875         Reviewed by Mark Rowe.
2876         
2877         Fix for local database support after r26879
2878         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2879
2880         * Scripts/build-webkit:
2881
2882 2007-10-22  Holger Freyther  <zecke@selfish.org>
2883
2884         Reviewed by Simon Hausmann <hausmann@kde.org>.
2885
2886         - Do not build testkjs as an application bundle. This is
2887         needed for run-javascriptcore-tests on OSX.
2888         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2889         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2890         as we do not have -rpath on OSX.
2891
2892         * DumpRenderTree/qt/DumpRenderTree.pro:
2893         * Scripts/run-webkit-tests:
2894
2895 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2896
2897         Reviewed by aroben.
2898
2899         Fix support for Signed-off-by detection in prepare-ChangeLog
2900         --git-commit. The Signed-off-by tag does not appear in the header
2901         but usually at the end.
2902
2903         * Scripts/prepare-ChangeLog:
2904
2905 2007-10-21  Mark Rowe  <mrowe@apple.com>
2906
2907         Reviewed by Eric.
2908
2909         Fix run-javascriptcore-tests for Gtk.
2910
2911         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2912
2913 2007-10-20  Eric Seidel  <eric@webkit.org>
2914
2915         Reviewed by aroben.
2916
2917         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2918
2919 2007-10-20  Eric Seidel  <eric@webkit.org>
2920
2921         Reviewed by darin.
2922         
2923         Add improved argument handling to run-sunspider, including
2924         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2925         Also re-factor code into subroutines
2926
2927         * Scripts/build-dumprendertree: removed bogus comments
2928         * Scripts/build-testkjs: Added.
2929         * Scripts/run-javascriptcore-tests: use build-testkjs
2930         * Scripts/run-sunspider: improved argument handling, abstraction
2931         * Scripts/run-webkit-tests: improved abstraction
2932
2933 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2934
2935         Not reviewed, Windows build fix.
2936
2937         * DumpRenderTree/win/EventSender.cpp:
2938         (keyDownCallback):
2939
2940 2007-10-20  Darin Adler  <darin@apple.com>
2941
2942         Reviewed by Tim Hatcher.
2943
2944         - http://bugs.webkit.org/show_bug.cgi?id=15544
2945           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2946           not rely on Apple-specific key codes
2947
2948         * DumpRenderTree/mac/EventSendingController.mm:
2949         (-[EventSendingController keyDown:withModifiers:]):
2950         Added named key "rightArrow". Later we could have a whole table of these.
2951         Also tweaked modifiers code a little.
2952
2953         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2954
2955 2007-10-19  Darin Adler  <darin@apple.com>
2956
2957         Reviewed by Eric.
2958
2959         - http://bugs.webkit.org/show_bug.cgi?id=15566
2960           possible fix for leak seen in DumpRenderTree
2961
2962         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2963         Delete the item if it's not put on the queue, since the caller has
2964         no way of knowing that. Would be better to have the parameter type
2965         be auto_ptr to express the fact that we take ownership.
2966
2967         - unrelated change
2968
2969         * Drosera/mac/main.m: Add missing include.
2970
2971 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2972
2973         Reviewed by Adam.
2974
2975         - This change should be identical but for some reason was not working
2976         on my machine.
2977
2978         * Scripts/prepare-ChangeLog:
2979
2980 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2981
2982         Reviewed by Oliver and Tim.
2983
2984         - Made use of RetainPtr to avoid retain and release issues and moved the
2985         log function to DebuggerDocumentPlatform, which seems to be a more
2986         logical place for it to live.
2987         - Also moved knownServers from the ServerConnection to
2988         DebuggerApplication to match the Windows code and because it makes sense
2989         that a connection knows its own server but not all of them.
2990
2991         * Drosera/mac/DebuggerClient.h: Moved the log function to
2992           DebuggerDocumentPlatform.
2993         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2994           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2995           call for the server name up from the ServerConnection class.
2996         (-[DebuggerClient dealloc]):
2997         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2998           for the server name up from the ServerConnection.
2999         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3000         (DebuggerDocument::platformPause):
3001         (DebuggerDocument::platformResume):
3002         (DebuggerDocument::platformStepInto):
3003         (DebuggerDocument::platformEvaluateScript):
3004         (DebuggerDocument::getPlatformCurrentFunctionStack):
3005         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3006         (DebuggerDocument::platformValueForScopeVariableNamed):
3007         (DebuggerDocument::platformLog): Log directly from here. No need to call
3008           DebuggerClient.
3009         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3010           way I see it, a ServerConnection should only know about its connection
3011           and the group of all possible servers should be kept by the
3012           application.
3013         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3014           currentServerName, it makes sense that the connection should know that
3015           name.
3016         (-[ServerConnection currentServerName]):
3017
3018 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3019
3020         Reviewed by Adam.
3021
3022         - Integrated changes from mac drosera.  Recently I've encapsulated
3023         out the server connection object from the rest of Drosera because
3024         it is very platform dependent right now and RPC is not implemented on
3025         windows.  This functionality, of communicating with the WebKit server
3026         is the next area I will be focusing on in Windows.
3027
3028         - Other changes and cleanup were made to organize the code and add notes
3029         on which parts still need work.  Also some mac code is added and
3030         commented out, to act as pseudocode for the logic of those parts.
3031
3032         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3033           pointer.
3034         * Drosera/config.h: Added whitespace.
3035         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3036           these files got moved into Drosera.h/cpp
3037         * Drosera/win/DebuggerApplication.h: Removed.
3038         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3039           happened here to better match the logic flow of the same code on the 
3040           mac side and to use the new ServerConnection class.
3041         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3042         (DebuggerClient::initWithServerName): Initializer that will set up the
3043           class to use a ServerConnection object.  This was necessary so I could
3044           create a DebuggerClient without having to initilaize it at
3045           construction.
3046         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3047           will be the UIDelegate and FrameLoadDelegate.
3048         (DebuggerClient::AddRef): For IUnknown.
3049         (DebuggerClient::Release): For IUnknown.
3050         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3051           this still needs to set the global context of the server, but
3052           IWebFrame does not have an accessor for the global context yet. 
3053         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3054           this is a pass through for the same function in the document.
3055         (DebuggerClient::didReceiveTitle): Unimplemented part of
3056           FrameLoadDelegate this would change the title of the window.
3057         (DebuggerClient::createWebViewWithRequest): Part of the
3058           FrameLoadDelegate.  This is about new windows via Window.open() and
3059           how their delegates are set.
3060         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3061           UIDelegate.  Just a debug function for printing messages.
3062         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3063           because the Client should be the UIDelegate and FrameLoadDelegate
3064           to match the delegates on mac.
3065         (DebuggerClient::webViewLoaded): Added accessor method.
3066         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3067           forgotten to add this file before.  This is where the platform
3068           dependent versions of the Documents functions live. Most of these are
3069           unimplemented because some piece of functionality does not exist on
3070           Windows yet.
3071         (DebuggerDocument::platformPause):
3072         (DebuggerDocument::platformResume):
3073         (DebuggerDocument::platformStepInto):
3074         (DebuggerDocument::platformEvaluateScript):
3075         (DebuggerDocument::getPlatformCurrentFunctionStack):
3076         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3077         (DebuggerDocument::platformValueForScopeVariableNamed):
3078         (DebuggerDocument::platformLog):
3079         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3080           responsibilities becaue they belong in the Client. Also I laid the
3081           groundwork for attaching Drosera to a WebKit process
3082         (attachWndProc): Now if a server is selected the Client becomes it's
3083           delegate.
3084         (Drosera::Drosera): Added the construction of the Client and dictionary
3085           of server names. 
3086         (Drosera::initUI): This is no longer the delegates, the Client is.
3087         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3088           state. 
3089         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3090           notification registration when it's possible to implement.
3091         (Drosera::serverLoaded): Ditto
3092         (Drosera::serverUnloaded): Ditto
3093         (Drosera::attach): Attach Drosera to the WebKit server.
3094         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3095         (Drosera::getInst): 
3096         (Drosera::setInst):
3097         (Drosera::knownServers):
3098         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3099           and added the ServerConnection.
3100         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3101         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3102           Most of the functions are completely unimlemented because they cannot
3103           connect with the WebKit server, because one does not exist on Windows
3104           yet.
3105         (ServerConnection::initWithServerName): 
3106         (ServerConnection::~ServerConnection):
3107         (ServerConnection::setGlobalContext):
3108         (ServerConnection::pause):
3109         (ServerConnection::resume):
3110         (ServerConnection::stepInto):
3111         (ServerConnection::switchToServerNamed):
3112         (ServerConnection::applicationTerminating):
3113         (ServerConnection::serverConnectionDidDie):
3114         (ServerConnection::currentFrame):
3115         * Drosera/win/ServerConnection.h: Added. Ditto.
3116         (ServerConnection::ServerConnection):
3117
3118 2007-10-19  Alice Liu  <alice.liu@apple.com>
3119
3120         Reviewed by Darin.
3121
3122         Fix for these broken layout tests on Windows:
3123         
3124         fast/forms/focus-selection-input.html
3125         fast/forms/focus-selection-textarea.html
3126         fast/forms/select-accesskey.html
3127         
3128         * DumpRenderTree/win/EventSender.cpp:
3129         (keyDownCallback):
3130         correct the VK code for alt key.
3131         
3132 2007-10-19  Eric Seidel  <eric@webkit.org>
3133
3134         Reviewed by Mark Rowe.
3135         
3136         Make the GtkLauncher code slightly more readable.
3137
3138         * GtkLauncher/main.cpp:
3139         (setupMainMenu): Added.
3140         (setupMainWindowUI): Added.
3141         (main):
3142
3143 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3144
3145         Rubber stamped by Adam.
3146         
3147         - don't delay-load WebKit in DumpRenderTree.
3148
3149         * DumpRenderTree/win/DumpRenderTree.vcproj:
3150
3151 2007-10-18  Dan Bernstein  <mitz@apple.com>
3152
3153         Reviewed by Adam Roben.
3154
3155         - fix <rdar://problem/5313523>
3156         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3157
3158         * DumpRenderTree/mac/DumpRenderTree.mm:
3159         (dump): Changed to use _responseMIMEType.
3160
3161 2007-10-17  Adam Roben  <aroben@apple.com>
3162
3163         Make it possible to have Windows-specific tests and results
3164
3165         When searching for tests to run and the Skipped file, we will only
3166         look in platform/win and the cross-platform directory. When looking
3167         for expected results, we will look in platform/win, then
3168         platform/mac-leopard, then platform/mac, then finally the
3169         cross-platform directory.
3170
3171         Reviewed by Sam.
3172
3173         * Scripts/run-webkit-tests:
3174         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3175         searching in the cross-platform directory.
3176         (sub buildPlatformHierarchy): Removed some unneeded calls to
3177         dirname/basename.
3178
3179 2007-10-17  Adam Roben  <aroben@apple.com>
3180
3181         Add back the call to register WebKit that we had before WebKitInitializer existed
3182
3183         This is needed to ensure that the right WebKit is used when
3184         instantiating COM objects.
3185
3186         Reviewed by Oliver.
3187
3188         * DumpRenderTree/win/debug_internal.vsprops: Define
3189         DEBUG_WEBKIT_HAS_SUFFIX.
3190         * DumpRenderTree/win/DumpRenderTree.cpp:
3191         (initialize):
3192
3193 2007-10-17  Adam Roben  <aroben@apple.com>
3194
3195         Import File::Basename in webkitdirs since we use it
3196
3197         * Scripts/webkitdirs.pm:
3198
3199 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3200
3201         - Updated the tiger leaks list to make the internal bots green.
3202
3203         * Scripts/run-webkit-tests:
3204
3205 2007-10-17  Adam Roben  <aroben@apple.com>
3206
3207         Build fix for VC++ Express
3208
3209         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3210         and ole32.lib.
3211
3212 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3213
3214         Reviewed by Sam.
3215
3216         - Minor mac improvements based on observations I made while implementing the
3217         Windows code.
3218
3219         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3220         then hand it to the Client who will retain it, it should just be the client who
3221         creates and owns the server.
3222         (-[DebuggerApplication attach:]):
3223         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3224         * Drosera/mac/DebuggerClient.mm: Creates the server.
3225         (-[DebuggerClient initWithServerName:]):
3226         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3227         can instead forward declare what it needs.
3228
3229 2007-10-16  Darin Adler  <darin@apple.com>
3230
3231         Reviewed by Geoff Garen.
3232
3233         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3234         want to turn failing tests into platform-specific test results. Also did a
3235         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3236         would take the type of results into account only some of the time.
3237
3238 2007-10-16  Adam Roben  <aroben@apple.com>
3239
3240         Add a new nightly launcher script for Windows
3241
3242         This new script is for versions of Safari that don't delay-load
3243         WebKit. I had to make FindSafari be able to print out the nightly
3244         launcher script on stdout because Windows shell scripts can't capture
3245         the output from a command into an environment variable.
3246
3247         Reviewed by Steve.
3248
3249         * FindSafari/FindSafari.cpp:
3250         (_tmain): Added /printSafariLauncher option.
3251         * Scripts/run-webkit-nightly.cmd: Added.
3252
3253 2007-10-16  Adam Roben  <aroben@apple.com>
3254
3255         Replace WebKitInitializer with FindSafari
3256
3257         We now rely on setting the PATH environment variable to tell Windows
3258         where to find WebKit and its dependencies (similar to
3259         DYLD_FRAMEWORK_PATH on Mac).
3260
3261         This change also make DumpRenderTree no longer delay-load WebKit.
3262
3263         Reviewed by Sam.
3264
3265         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3266         FindSafari.
3267         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3268         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3269         WebKitInitializer, don't delay-load WebKit.
3270         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3271         * Scripts/run-webkit-tests: Ditto.
3272         * Scripts/webkitdirs.pm:
3273         (sub setPathForRunningWebKitApp): Added.
3274         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3275         * WebKitInitializer/WebKitInitializer.h: Removed.
3276         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3277         * WebKitInitializer/debug.vsprops: Removed.
3278         * WebKitInitializer/debug_internal.vsprops: Removed.
3279         * WebKitInitializer/release.vsprops: Removed.
3280
3281 2007-10-16  Adam Roben  <aroben@apple.com>
3282
3283         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3284
3285         http://bugs.webkit.org/show_bug.cgi?id=15532
3286
3287         FindSafari simply prints the location of an installed Safari.exe on
3288         stdout.
3289
3290         Reviewed by Darin.
3291
3292         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3293         (getStringValue):
3294         (getWebViewCLSID):
3295         (getInstalledWebKitDirectory):
3296         (_tmain):
3297         * FindSafari/FindSafari.vcproj: Added.
3298         * Scripts/webkitdirs.pm:
3299         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3300
3301 2007-10-16  Adam Roben  <aroben@apple.com>
3302
3303         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3304
3305         Reviewed by Kevin McCullough.
3306
3307         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3308         when referring to WebKit.dll.
3309         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3310         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3311         * DumpRenderTree/win/release.vsprops: Ditto.
3312         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3313         never have a _debug suffix on WebKit.dll.
3314         * WebKitInitializer/WebKitInitializer.cpp:
3315         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3316         specified.
3317         * WebKitInitializer/debug_internal.vsprops: Added
3318         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3319
3320 2007-10-16  Darin Adler  <darin@apple.com>
3321
3322         Reviewed by Adele.
3323
3324         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3325         Remove now-unneeded control/alt key hack; the tests have been updated.
3326
3327 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3328
3329         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3330         one of the leaks was fixed between that revision and the bot's previous version of
3331         leopard.
3332
3333         * Scripts/run-webkit-tests:
3334
3335 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3336
3337         Reviewed by Tim.
3338
3339         - I encapsulated out the server connecton functionality because it is a specific part
3340         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3341         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3342         Windows.  So the majority of this patch is moving preexisting functionality.
3343
3344         - Also I removed the prefix header and changed to use config.h because it is more
3345         standard on how we use config.h in windows and it didn't make much sense to keep
3346         the prefix header and the config.h
3347
3348         * Drosera/DebuggerDocument.cpp:
3349         (DebuggerDocument::DebuggerDocument):
3350         * Drosera/DebuggerDocument.h:
3351         * Drosera/config.h:
3352         * Drosera/mac/DebuggerApplication.mm:
3353         (-[DebuggerApplication attach:]):
3354         * Drosera/mac/DebuggerClient.h:
3355         * Drosera/mac/DebuggerClient.mm:
3356         (-[DebuggerClient initWithServerConnection:]):
3357         (-[DebuggerClient dealloc]):
3358         (-[DebuggerClient windowDidLoad]):
3359         (-[DebuggerClient windowWillClose:]):
3360         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3361         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3362         * Drosera/mac/DebuggerDocumentPlatform.mm:
3363         (DebuggerDocument::platformPause):
3364         (DebuggerDocument::platformResume):
3365         (DebuggerDocument::platformStepInto):
3366         (DebuggerDocument::platformEvaluateScript):
3367         (DebuggerDocument::getPlatformCurrentFunctionStack):
3368         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3369         (DebuggerDocument::platformValueForScopeVariableNamed):
3370         (DebuggerDocument::platformLog):
3371         * Drosera/mac/Drosera.pch: Removed.
3372         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3373         * Drosera/mac/ServerConnection.h: Added.
3374         * Drosera/mac/ServerConnection.mm: Added.
3375         (-[ServerConnection initWithServerName:]):
3376         (-[ServerConnection dealloc]):
3377         (-[ServerConnection setGlobalContext:]):
3378         (-[ServerConnection pause]):
3379         (-[ServerConnection resume]):
3380         (-[ServerConnection stepInto]):
3381         (-[ServerConnection switchToServerNamed:]):
3382         (-[ServerConnection applicationTerminating:]):
3383         (-[ServerConnection serverConnectionDidDie:]):
3384         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3385         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3386         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3387         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3388         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3389         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3390         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3391         (-[ServerConnection currentFrame]):
3392         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3393         (-[ServerConnection knownServers]):
3394
3395 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3396
3397         Reviewed by Eric.
3398
3399         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3400           Script to automatically search nightly builds for regressions (bisect-builds)
3401
3402         * Scripts/bisect-builds: Added.
3403
3404 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3405
3406         Reviewed by Darin.
3407
3408         - New JavaScript benchmark
3409         http://bugs.webkit.org/show_bug.cgi?id=15515
3410
3411         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3412         current development or release build of JavaScriptCore.
3413
3414 2007-10-15  Mark Rowe  <mrowe@apple.com>
3415
3416         Reviewed by Sam.
3417
3418         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3419
3420         * Scripts/webkitdirs.pm:
3421         - Change checkArgv to remove the options from @ARGV to prevent
3422         them from interfering with further option processing.
3423         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3424         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3425         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3426         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3427
3428 2007-10-15  Darin Adler  <darin@apple.com>
3429
3430         Reviewed by Sam.
3431
3432         - added logging of window.prompt and window.confirm
3433
3434         * DumpRenderTree/mac/UIDelegate.mm:
3435         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3436         Implement the recommended delegate rather than the deprecated one.
3437         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3438         Added.
3439         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3440         Added.
3441
3442         * DumpRenderTree/win/UIDelegate.h:
3443         * DumpRenderTree/win/UIDelegate.cpp:
3444         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3445         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3446         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3447         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3448
3449 2007-10-15  Alice Liu  <alice.liu@apple.com>
3450
3451         Reviewed by Sam Weinig.
3452
3453         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3454
3455         * DumpRenderTree/win/DumpRenderTree.cpp:
3456         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3457         (main): allocate the global policy delegate for DRT's custom use
3458         * DumpRenderTree/win/DumpRenderTree.vcproj:
3459         Adding files to project
3460         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3461         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3462         (LayoutTestController::setCustomPolicyDelegate):
3463         set the webview's policy delegate to DRT's custom one if the test requests it.
3464         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3465         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3466         (PolicyDelegate::PolicyDelegate):
3467         (PolicyDelegate::QueryInterface):
3468         (PolicyDelegate::AddRef):
3469         (PolicyDelegate::Release):
3470         (PolicyDelegate::decidePolicyForNavigationAction):
3471         * DumpRenderTree/win/PolicyDelegate.h: Added.
3472         (PolicyDelegate::decidePolicyForNewWindowAction):
3473         (PolicyDelegate::decidePolicyForMIMEType):
3474         (PolicyDelegate::unableToImplementPolicyWithError):
3475
3476 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3477
3478         Reviewed by Mark.
3479
3480         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3481         when querying for QMAKE_MKSPECS.
3482
3483 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3484
3485         Reviewed by Adam Roben.
3486         
3487         Fix run-webkit-tests is too greedy calculating platform hierarchy
3488         http://bugs.webkit.org/show_bug.cgi?id=15465
3489         
3490         Fix run-webkit-tests being too greedy in trying to split the platform name up
3491         causing it to try and find tests in every directory above the first "-" in the
3492         path to the LayoutTests
3493
3494         * Scripts/run-webkit-tests:
3495
3496 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3497
3498         Reviewed by Darin.
3499
3500         http://bugs.webkit.org/show_bug.cgi?id=15006
3501         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3502         to reduce code duplication.
3503
3504         * Scripts/build-webkit:
3505         * Scripts/webkitdirs.pm:
3506         buildQMakeProject() renamed to buildQMakeQtProject().
3507         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3508         unused $colorize has been removed.
3509
3510 === Start merge of feature-branch 2007-10-12 ===
3511
3512 2007-10-08  Eric Seidel  <eric@webkit.org>
3513
3514         Reviewed by Mark Rowe.
3515
3516         * Scripts/build-webkit: add --help, remove unused --color
3517
3518 2007-10-07  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by darin.
3521
3522         * Drosera/mac/DebuggerDocumentPlatform.mm:
3523         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3524
3525 2007-10-03  Rob Buis  <buis@kde.org>
3526
3527         Reviewed by Olliej.
3528
3529         Adapt to changed location of Ahem font.
3530
3531         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3532
3533 2007-10-02  Eric Seidel  <eric@webkit.org>
3534
3535         Reviewed by Adam Roben.
3536         
3537         Make pixel tests more useful!
3538         Finally fix the image diff 0.00% mystery problem
3539         Highlight any image differences in the image diff.
3540         Add a link from image diffs back to original test file.
3541
3542         * DumpRenderTree/mac/ImageDiff.m:
3543         (compareImages): highlight any differences
3544         (computePercentageDifferent): round to two decimal places
3545         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3546
3547 2007-10-02  Eric Seidel  <eric@webkit.org>
3548
3549         Reviewed by Alexey Proskuryakov.
3550
3551         * Scripts/run-webkit-tests: print the % image difference on main results page
3552
3553 2007-10-02  Mark Rowe  <mrowe@apple.com>
3554
3555         Reviewed by Oliver.
3556
3557         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3558
3559         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3560         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3561
3562 2007-10-01  Mark Rowe  <mrowe@apple.com>
3563
3564         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3565
3566 2007-09-25  Eric Seidel  <eric@webkit.org>
3567
3568         Reviewed by Mark Rowe.
3569         
3570         DerivedSources.make was finding "ENABLE_SVG" in the string
3571         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3572         quite correctly.
3573
3574         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3575
3576 2007-09-25  Mark Rowe  <mrowe@apple.com>
3577
3578         Rubber-stamped by Eric.
3579
3580         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3581         This makes it possible to automate nightly builds for the feature-branch.
3582
3583 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3584
3585         Rubber stamped by Mark.
3586
3587         Enable svg experimental features as default here in feature-branch.
3588
3589         * Scripts/build-webkit:
3590
3591 2007-06-29  Antti Koivisto  <antti@apple.com>
3592
3593         Reviewed by Weinig.
3594         
3595         Add VIDEO flag for timed media features
3596
3597         * Scripts/build-webkit
3598         
3599 === End merge of feature-branch 2007-10-12 ===
3600
3601 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3602
3603         Reviewed by Darin.
3604
3605         - Updated rational for the leaks list to be more clear.
3606
3607         * Scripts/run-webkit-tests:
3608
3609 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3610
3611         Rubber Stamp by Sam.
3612
3613         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.