2010-12-02 Martin Robinson <mrobinson@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Xan Lopez.
4
5         [GTK] DumpRenderTree has two copies of JavaScriptCore
6         https://bugs.webkit.org/show_bug.cgi?id=49877
7
8         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
9         LDADD list for DumpRenderTree.
10
11 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
12
13         Unreviewed: Added myself to list of Committers.
14
15         * Scripts/webkitpy/common/config/committers.py:
16
17 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
18
19         Reviewed by Adam Barth.
20
21         build-webkit --chromium always updates DEPS and re-generates project files
22         https://bugs.webkit.org/show_bug.cgi?id=50340
23         
24         Make build-webkit --chromium invoke update-webkit-chromium only when
25         --update-chromium is passed in, so that we don't add 20 seconds to all
26         builds.
27         
28         Making all invocations update was added with r61883, with the goal of
29         making EWS bots always update. The bots will switch to using this flag
30         (as will all other webkit-patch build steps) so nothing should change
31         for them.
32
33         * Scripts/webkitdirs.pm:
34         * Scripts/webkitpy/common/config/ports.py:
35         * Scripts/webkitpy/common/config/ports_unittest.py:
36
37 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
38
39         Reviewed by Tony Chang.
40
41         new-run-webkit-tests: add a --dry-run / -n flag
42         https://bugs.webkit.org/show_bug.cgi?id=50045
43
44         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
45         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
46
47 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
48
49         Reviewed by Adam Roben.
50
51         WinCairo build should not use link-time code generation (LTCG)
52         https://bugs.webkit.org/show_bug.cgi?id=50353
53
54         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
55         * DumpRenderTree/win/DumpRenderTree.vcproj:
56         * DumpRenderTree/win/ImageDiff.vcproj:
57         * FindSafari/FindSafari.vcproj:
58         * MiniBrowser/MiniBrowser.vcproj:
59         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
60         * WebKitAPITest/WebKitAPITest.vcproj:
61         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
62         * WebKitTestRunner/win/InjectedBundle.vcproj:
63         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
64         * WinLauncher/WinLauncher.vcproj:
65         * record-memory-win/record-memory-win.vcproj:
66
67 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
68
69         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
70         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
71         adding the file to the sources list was not enough to force the rebuild.
72
73         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
74         Remove an empty line at the end of this file to force a rebuild.
75
76 2010-12-01  Sam Weinig  <sam@webkit.org>
77
78         Fix windows build.
79
80         * MiniBrowser/win/BrowserView.cpp:
81         (BrowserView::create):
82
83 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
84
85         Add missing file to the TestNetscapePlugin sources list after r73057.
86
87         * GNUmakefile.am: Add missing file.
88
89 2010-12-01  Sam Weinig  <sam@webkit.org>
90
91         Reviewed by Anders Carlsson.
92
93         Add PageGrouping to WebKit2 API
94         https://bugs.webkit.org/show_bug.cgi?id=50332
95
96         - Update testing harnesses to deal with new PageGroup API.
97
98         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
99         (WKBundleInitialize):
100         * TestWebKitAPI/InjectedBundleController.cpp:
101         (TestWebKitAPI::InjectedBundleController::initialize):
102         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
103         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
104         * TestWebKitAPI/InjectedBundleController.h:
105         * TestWebKitAPI/InjectedBundleTest.h:
106         (TestWebKitAPI::InjectedBundleTest::initialize):
107         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
108         * TestWebKitAPI/PlatformUtilities.cpp:
109         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
110         * TestWebKitAPI/PlatformUtilities.h:
111         * TestWebKitAPI/PlatformWebView.h:
112         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
113         (TestWebKitAPI::TEST):
114         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
115         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
116         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
117         (TestWebKitAPI::PlatformWebView::PlatformWebView):
118         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
119         (TestWebKitAPI::PlatformWebView::PlatformWebView):
120         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
121         (WTR::InjectedBundle::didInitializePageGroup):
122         (WTR::InjectedBundle::initialize):
123         (WTR::InjectedBundle::beginTesting):
124         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
125         (WTR::InjectedBundle::pageGroup):
126         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
127         (WTR::LayoutTestController::addUserScript):
128         (WTR::LayoutTestController::addUserStyleSheet):
129         (WTR::LayoutTestController::setXSSAuditorEnabled):
130         * WebKitTestRunner/TestController.cpp:
131         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
132         (WTR::PlatformWebView::PlatformWebView):
133
134 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
135
136         Reviewed by Adam Roben.
137
138         vcproj changes can't be applied cleanly by the Windows EWS bot
139         https://bugs.webkit.org/show_bug.cgi?id=50328
140
141         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
142         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
143         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
144         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
145         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
146         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
147         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
148         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
149         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
150         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
151         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
152         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
153         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
154         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
155         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
156         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
157         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
158         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
159         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
160         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
161         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
162         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
163         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
164         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
165         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
166         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
167         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
168         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
169         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
170         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
171         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
172         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
173         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
174         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
175         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
176         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
177         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
178         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
179         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
180         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
181         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
182         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
183         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
184         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
185         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
186
187 2010-12-01  Anders Carlsson  <andersca@apple.com>
188
189         Reviewed by Darin Adler.
190
191         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
192         https://bugs.webkit.org/show_bug.cgi?id=50336
193
194         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
195         Add new test.
196
197         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
198         (PluginTest::NPP_New):
199         Add default implementation/
200
201         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
202         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
203         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
204         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
205         Get the user agent.
206
207         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
208         (NPP_New):
209         Call PluginTest::NPP_New.
210
211         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
212         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
213         Add new files.
214
215         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
216         (webkit_test_plugin_new_instance):
217         Call PluginTest::NPP_New.
218
219 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
220
221         [wx] Build fixes after recent trunk changes.
222
223         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
224         (LayoutTestController::findString):
225         * wx/build/settings.py:
226
227 2010-12-01  Dan Bernstein  <mitz@apple.com>
228
229         Reviewed by Darin Adler.
230
231         WebKitTestRunner needs layoutTestController.findString
232         https://bugs.webkit.org/show_bug.cgi?id=50238
233
234         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
235         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
236         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
237         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
238
239 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
240
241         Try using svn:eol-style native on a vcproj file.
242
243         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
244
245 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
246
247         Reviewed by Adam Roben.
248
249         [WINCE] Add WinCELauncher
250         https://bugs.webkit.org/show_bug.cgi?id=50217
251
252         * WinCELauncher/main.cpp: Added.
253
254 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
255
256         Reviewed by Kenneth Rohde Christiansen.
257
258         [Qt] Implement layoutTestController.findString
259         https://bugs.webkit.org/show_bug.cgi?id=50236
260
261         Add the missing function to the LayoutTestController.
262
263         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
264         (LayoutTestController::findString):
265         * DumpRenderTree/qt/LayoutTestControllerQt.h:
266
267 2010-11-30  Tony Chang  <tony@chromium.org>
268
269         Reviewed by Adam Barth.
270
271         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
272         https://bugs.webkit.org/show_bug.cgi?id=49036
273
274         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
275             for CppVariants.
276         (LayoutTestController::cppVariantToBool):
277         (LayoutTestController::cppVariantToInt32):
278         (LayoutTestController::setDatabaseQuota):
279         (LayoutTestController::evaluateInWebInspector):
280         (LayoutTestController::setMockGeolocationError):
281
282 2010-11-30  Eric Seidel  <eric@webkit.org>
283
284         Reviewed by Tony Chang.
285
286         update-webkit should call git fetch before git svn rebase
287         https://bugs.webkit.org/show_bug.cgi?id=50273
288
289         After discussion on webkit-dev, we've decided to move the "default"
290         git setup to pulling updates from git.webkit.org in preference
291         to rebuilding the local svn index using git svn fetch every time.
292
293         This change should have no effect on people using the "old" git setup
294         and should dramatically increase the speed of updates for those using
295         the "new" git setup along with update-webkit.  I'm about to move the
296         EWS and other queues over to this setup once this lands.
297
298         * Scripts/update-webkit:
299
300 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
301
302         Reviewed by Xan Lopez.
303
304         GTK: AX: implement press in DRT
305         https://bugs.webkit.org/show_bug.cgi?id=36146
306
307         Implement AccessibilityUIElement::press() for GTK.
308
309         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
310         (AccessibilityUIElement::press): Implemented.
311
312 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
313
314         Reviewed by Tony Chang.
315
316         config.webkit_base_dir returns a path with a trailing slash
317         https://bugs.webkit.org/show_bug.cgi?id=50197
318         
319         config.webkit_base_dir() should return a path without a trailing slash,
320         like all the other methods that return paths.
321         
322         Undoes MockFileSytem changes by r72640, since they're no longer
323         necessary for GetBaselinesTest to pass.
324
325         * Scripts/webkitpy/common/system/filesystem_mock.py:
326         * Scripts/webkitpy/layout_tests/port/base.py:
327         * Scripts/webkitpy/layout_tests/port/config.py:
328         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
329
330 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
331
332         Reviewed by Tony Chang.
333
334         Rebaseline server: baseline display tweaks
335         https://bugs.webkit.org/show_bug.cgi?id=50207
336         
337         Determine which baselines were used when running the tests and highlight
338         them in the UI. Sort platform names alphabetically.
339         
340         Also makes the server URL be launched in the user's browser
341         automatically.
342
343         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
344         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
345         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
346         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
347         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
348
349 2010-11-30  Dan Bernstein  <mitz@apple.com>
350
351         Reviewed by Anders Carlsson.
352
353         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
354         https://bugs.webkit.org/show_bug.cgi?id=50238
355
356         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
357         (WTR::LayoutTestController::findString): Added.
358         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
359
360 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
361
362         Reviewed by Adam Roben.
363
364         All projects on Windows should use cmd files for build events
365         https://bugs.webkit.org/show_bug.cgi?id=50213
366
367         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
368         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
369         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
370         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
371         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
372         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
373         * DumpRenderTree/win/ImageDiffCommon.vsprops:
374         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
375         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
376         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
377         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
378         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
379         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
380         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
381         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
382         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
383         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
384         * WebKitAPITest/WebKitAPITestCommon.vsprops:
385         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
386         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
387         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
388         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
389         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
390         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
391         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
392         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
393         * WinLauncher/WinLauncherCommon.vsprops:
394         * WinLauncher/WinLauncherPostBuild.cmd: Added.
395         * WinLauncher/WinLauncherPreBuild.cmd: Added.
396
397 2010-11-29  Dan Bernstein  <mitz@apple.com>
398
399         GTK DumpRenderTree build fix after r72887.
400
401         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
402         (LayoutTestController::findString):
403
404 2010-11-29  Dan Bernstein  <mitz@apple.com>
405
406         Windows DumpRenderTree build fix after r72887.
407
408         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
409         (LayoutTestController::findString): Added empty implementation.
410
411 2010-11-29  Dan Bernstein  <mitz@apple.com>
412
413         Reviewed by Darin Adler.
414
415         DumpRenderTree changes for testing the text search API.
416         https://bugs.webkit.org/show_bug.cgi?id=50038
417
418         * DumpRenderTree/LayoutTestController.cpp:
419         (findStringCallback):
420         (LayoutTestController::staticFunctions):
421         * DumpRenderTree/LayoutTestController.h:
422         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
423         (LayoutTestController::findString):
424         * MiniBrowser/mac/BrowserWindowController.m:
425         (-[BrowserWindowController find:]):
426
427 2010-11-29  Johnny Ding  <jnd@chromium.org>
428
429         Unreviewed: Add myself to the list of Committers.
430
431         * Scripts/webkitpy/common/config/committers.py:
432
433 2010-11-29  Mark Rowe  <mrowe@apple.com>
434
435         Reviewed by Adele Peterson.
436
437         <rdar://problem/8694997> DumpRenderTree fails to build.
438
439         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
440
441 2010-11-29  Mark Rowe  <mrowe@apple.com>
442
443         Reviewed by Adele Peterson.
444
445         <rdar://problem/8694997> DumpRenderTree fails to build.
446
447         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
448         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
449         * DumpRenderTree/mac/PerlSupport/Makefile:
450
451 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
452
453         Reviewed by Martin Robinson.
454
455         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
456         https://bugs.webkit.org/show_bug.cgi?id=50154
457
458         Added missing checks to allAttributes().
459
460         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
461         (AccessibilityUIElement::allAttributes): Added missing checks.
462
463 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
464
465         Reviewed by Kenneth Rohde Christiansen.
466
467         [Qt] Allow pre-generation for package builds for WebKit2
468         https://bugs.webkit.org/show_bug.cgi?id=50139
469
470         Use a build variable for the generated directory path and set the
471         value based on CONFIG just like for WebKit1.
472
473         For non-package builds use a relative base path for the
474         genrated directory just like for WebKit1.
475
476         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
477         * WebKitTestRunner/qt/WebKitTestRunner.pro:
478
479 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
480
481         Reviewed by Kenneth Rohde Christiansen.
482
483         [Qt] Move some build logic from Qt to platform independent code
484         https://bugs.webkit.org/show_bug.cgi?id=50134
485
486         Create target directories inside generate-forwarding-headers.pl.
487
488         * Scripts/generate-forwarding-headers.pl:
489
490 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
491
492         Reviewed by Martin Robinson.
493
494         [GTK] Windowless plugins gets broken key input
495         https://bugs.webkit.org/show_bug.cgi?id=49927
496
497         Convert the XEvent::keycode to ASCII before printing it. Not
498         doing this was causing false positive in 
499         plugins/keyboard-events.html.
500
501         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
502         (keycode_to_char):
503         (webkit_test_plugin_handle_event):
504
505 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
506
507         Reviewed by Antonio Gomes.
508
509         [Qt] Html autofocus not working with QGraphicsWebView
510         https://bugs.webkit.org/show_bug.cgi?id=43169
511
512         Tell the scene to set the webview item as the currently
513         focused item. This makes the input field with autofocus get
514         focus as it should.
515
516         * QtTestBrowser/webview.cpp:
517         (WebViewGraphicsBased::WebViewGraphicsBased):
518
519 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
520
521         Reviewed by Tony Chang.
522
523         nrwt - clean up create_driver interface and print out the
524         command line used for DumpRenderTree/TestShell.
525
526         This patch adds a driver_cmd_line() call to the Port class in
527         order to retrive the command line to print it out (as part of
528         --print config).
529
530         In addition, this patch cleans up the Port.create_driver()
531         signature and the Driver constructor interface to take a worker
532         number and no longer require the image_path argument (Chromium's
533         drivers now synthesize the image_path from the worker number
534         internally).
535
536         https://bugs.webkit.org/show_bug.cgi?id=49934
537
538         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
539         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
540         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
541         * Scripts/webkitpy/layout_tests/port/base.py:
542         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
543         * Scripts/webkitpy/layout_tests/port/chromium.py:
544         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
545         * Scripts/webkitpy/layout_tests/port/dryrun.py:
546         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
547         * Scripts/webkitpy/layout_tests/port/test.py:
548         * Scripts/webkitpy/layout_tests/port/webkit.py:
549         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
550         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
551
552 2010-11-24  Ojan Vafai  <ojan@chromium.org>
553
554         Reviewed by Tony Chang.
555
556         [chromium] improve memory usage for test results server and store fewer runs
557         https://bugs.webkit.org/show_bug.cgi?id=50035
558
559         Store fewer runs and don't pass full files around when we only need bools.
560         Greatly improves error rates on test-results.appspot.com.
561
562         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
563         * TestResultServer/handlers/testfilehandler.py:
564         * TestResultServer/model/dashboardfile.py:
565         * TestResultServer/model/jsonresults.py:
566
567 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
568
569         Reviewed by Tony Chang.
570
571         This patch implements the first part of the manager side of the
572         Broker objects - it handles creating threads, waiting for them
573         to complete, and running a single-threaded loop as well.
574
575         https://bugs.webkit.org/show_bug.cgi?id=49779
576
577         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
578         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
579         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
580         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
581
582 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
583
584         Reviewed by David Levin.
585
586         DRT should not generate pixel output for text/plain tests
587         https://bugs.webkit.org/show_bug.cgi?id=50002
588         
589         Modify Mac, Windows and GTK DRT implementations to disable pixel output
590         when encountering a text/plain response (the Chromium one already does
591         this, and none of the other ports special-case text/plain output in
592         the first place).
593
594         * DumpRenderTree/gtk/DumpRenderTree.cpp:
595         (dump):
596         * DumpRenderTree/mac/DumpRenderTree.mm:
597         (dump):
598         * DumpRenderTree/win/DumpRenderTree.cpp:
599         (dump):
600
601 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
602
603         Unreviewed.
604
605         Add my other email address to committers.py.
606
607         * Scripts/webkitpy/common/config/committers.py:
608
609 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
610
611         Reviewed by Csaba Osztrogonác.
612
613         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
614         https://bugs.webkit.org/show_bug.cgi?id=49975
615
616         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
617         to enable the script to define it 0 in case of a minimal build.
618
619 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
620
621         Reviewed by Xan Lopez.
622
623         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
624         https://bugs.webkit.org/show_bug.cgi?id=49143
625
626         * DumpRenderTree/gtk/DumpRenderTree.cpp:
627         (createWebView): Call the new connectEditingCallbacks function.
628         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
629         (dumpNodePath):
630         (dumpRange):
631         (insertActionString):
632         (selectionAffinityString):
633         (shouldBeginEditing):
634         (shouldEndEditing):
635         (shouldInsertNode):
636         (shouldInsertText):
637         (shouldDeleteRange):
638         (shouldShowDeleteInterfaceForElement):
639         (shouldChangeSelectedRange):
640         (shouldApplyStyle):
641         (editingBegan):
642         (userChangedContents):
643         (editingEnded):
644         (selectionChanged):
645         (connectEditingCallbacks):
646         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
647         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
648
649 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
650
651         Reviewed by Andreas Kling.
652
653         [Qt] Make QtTestBrowser remember the selected user agent
654         https://bugs.webkit.org/show_bug.cgi?id=50021
655
656         Set user agent for a new page by using the old page's
657
658         * QtTestBrowser/mainwindow.cpp:
659         (MainWindow::setPage):
660
661 2010-11-24 Patrick Gansterer <paroga@webkit.org>
662
663         Reviewed by Csaba Osztrogonác.
664
665         Remove Bakefile build system files
666         https://bugs.webkit.org/show_bug.cgi?id=49983
667
668         r53757 only removed the content, but not the files.
669         This patch removes that empty files.
670
671         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
672         * wx/browser/browser.bkl: Removed.
673         * wx/build-wxwebkit: Removed.
674
675 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
676
677         Reviewed by Tony Chang.
678
679         This patch cleans up the logic used to shard tests into groups a
680         bit and adds the --worker-model flag to NRWT. The flag is only
681         used at the moment to control whether to run single-threaded or
682         not, but eventually will also allow toggling between threads and
683         processes.
684
685         Also add a minor cleanup with _test_is_slow(), which just
686         eliminates some repetition and gives slightly better encapsulation.
687
688         https://bugs.webkit.org/show_bug.cgi?id=49773
689
690         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
692
693 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
694
695         Reviewed by Tony Chang.
696
697         Rebaseline server: list current baselines and platforms
698         https://bugs.webkit.org/show_bug.cgi?id=49991
699         
700         List existing baselines (with Trac links) for tests.
701         
702         Add dropdowns for choosing with platform baselines to target (and what
703         to do with existing ones).
704
705         Also fix MockFileSystem.join to behave more like os.path.join (unit
706         test was ending up with two consecutive slashes in a layout test
707         path).        
708
709         * Scripts/webkitpy/common/system/filesystem_mock.py:
710         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
711         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
712         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
713         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
714         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
715         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
716         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
717
718 2010-11-23  Ojan Vafai  <ojan@chromium.org>
719
720         Reviewed by Tony Chang.
721
722         remove timeout argument to urlopen
723         https://bugs.webkit.org/show_bug.cgi?id=49995
724
725         Apparently the version of python we have on the bots doesn't accept a timeout argument.
726
727         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
728
729 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
730
731         Unreviewed, rolling out r72628.
732         http://trac.webkit.org/changeset/72628
733         https://bugs.webkit.org/show_bug.cgi?id=49994
734
735         This patch is causing layout-test failtures on GTK Linux
736         64-bit Debug (Requested by ctguil on #webkit).
737
738         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
739         (AccessibilityUIElement::AccessibilityUIElement):
740         (AccessibilityUIElement::parentElementCallback):
741         * DumpRenderTree/chromium/AccessibilityUIElement.h:
742         * DumpRenderTree/chromium/CppBoundClass.cpp:
743         * DumpRenderTree/chromium/CppBoundClass.h:
744
745 2010-11-22  Ojan Vafai  <ojan@chromium.org>
746
747         Reviewed by Tony Chang.
748
749         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
750         https://bugs.webkit.org/show_bug.cgi?id=49944
751
752         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
753
754 2010-11-23  Chris Guillory  <chris.guillory@google.com>
755
756         Reviewed by Dimitri Glazkov.
757
758         Include the FrameView widget of a RenderWidget in the accessibility tree.
759         https://bugs.webkit.org/show_bug.cgi?id=49106
760
761         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
762         (AccessibilityUIElement::AccessibilityUIElement):
763         (AccessibilityUIElement::parentElementCallback):
764         (AccessibilityUIElement::isEqualCallback):
765         * DumpRenderTree/chromium/AccessibilityUIElement.h:
766         * DumpRenderTree/chromium/CppBoundClass.cpp:
767         (CppBoundClass::getFromCppVariant):
768         * DumpRenderTree/chromium/CppBoundClass.h:
769
770 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
771
772         Reviewed by Kenneth Rohde Christiansen.
773
774         [EFL] Add tiled backing store to EWebLauncher
775         https://bugs.webkit.org/show_bug.cgi?id=45777
776
777         Allow EWebLauncher to choose between single and tiled backing store
778
779         * EWebLauncher/main.c:
780         (on_key_down):
781         (browserCreate):
782         (main):
783
784 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
785
786         Reviewed by Tor Arne Vestbø.
787
788         [Qt] Review the setUserPermission & friends API
789         https://bugs.webkit.org/show_bug.cgi?id=46810
790
791         Renamed requestPermissionFromUser to featurePermissionRequested
792         and cancelRequestsForPermission to featurePermissionRequestCanceled.
793
794         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
795         (WebCore::WebPage::WebPage):
796         * QtTestBrowser/webpage.cpp:
797         (WebPage::WebPage):
798         (WebPage::featurePermissionRequestCanceled):
799         * QtTestBrowser/webpage.h:
800
801 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
802
803         Reviewed by Tor Arne Vestbø.
804
805         [Qt] Review the setUserPermission & friends API
806         https://bugs.webkit.org/show_bug.cgi?id=46810
807
808         Rename setUserPermission to setFeaturePermission
809
810         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
811         (WebCore::WebPage::requestPermission):
812         (WebCore::WebPage::permissionSet):
813         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
814         (LayoutTestController::grantDesktopNotificationPermission):
815         * QtTestBrowser/webpage.cpp:
816         (WebPage::requestPermission):
817
818 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
819
820         Reviewed by Tor Arne Vestbø.
821
822         [Qt] Review the setUserPermission & friends API
823         https://bugs.webkit.org/show_bug.cgi?id=46810
824
825         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
826         and GeolocationPermissionDomain to Geolocation.
827
828         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
829         (WebCore::WebPage::WebPage):
830         (WebCore::WebPage::requestPermission):
831         (WebCore::WebPage::cancelPermission):
832         (WebCore::WebPage::permissionSet):
833         (WebCore::DumpRenderTree::geolocationPermissionSet):
834         * DumpRenderTree/qt/DumpRenderTreeQt.h:
835         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
836         (LayoutTestController::grantDesktopNotificationPermission):
837         * QtTestBrowser/webpage.cpp:
838         (WebPage::WebPage):
839         (WebPage::requestPermission):
840         (WebPage::cancelRequestsForPermission):
841         * QtTestBrowser/webpage.h:
842
843 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
844
845         Reviewed by Tor Arne Vestbø.
846
847         [Qt] Review the setUserPermission & friends API
848         https://bugs.webkit.org/show_bug.cgi?id=46810
849
850         Add a ByUser suffix to PermissionGranted/Denied. In the future
851         we can add PermissionGrantedByDefault.
852
853
854         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
855         (WebCore::WebPage::requestPermission):
856         (WebCore::WebPage::permissionSet):
857         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
858         (LayoutTestController::grantDesktopNotificationPermission):
859         * QtTestBrowser/webpage.cpp:
860         (WebPage::requestPermission):
861
862 2010-11-18  Satish Sampath  <satish@chromium.org>
863
864         Reviewed by Jeremy Orlow.
865
866         For speech input event, send an event object containing all the recognition results and metadata.
867         https://bugs.webkit.org/show_bug.cgi?id=49736
868
869         Updated DRT by renaming the mock result method on all platforms to the new signature.
870
871         * DumpRenderTree/LayoutTestController.cpp:
872         (addMockSpeechInputResultCallback):
873         (LayoutTestController::staticFunctions):
874         * DumpRenderTree/LayoutTestController.h:
875         * DumpRenderTree/chromium/LayoutTestController.cpp:
876         (LayoutTestController::LayoutTestController):
877         (LayoutTestController::addMockSpeechInputResult):
878         * DumpRenderTree/chromium/LayoutTestController.h:
879         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
880         (LayoutTestController::addMockSpeechInputResult):
881         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
882         (LayoutTestController::addMockSpeechInputResult):
883         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
884         (LayoutTestController::addMockSpeechInputResult):
885         * DumpRenderTree/qt/LayoutTestControllerQt.h:
886         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
887         (LayoutTestController::addMockSpeechInputResult):
888         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
889         (LayoutTestController::addMockSpeechInputResult):
890
891 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
892
893         Reviewed by Tony Chang.
894
895         Fix some spacing issues with log messages with
896         new-run-webkit-tests --verbose.
897
898         https://bugs.webkit.org/show_bug.cgi?id=49936
899
900         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
901
902 2010-11-22  Ojan Vafai  <ojan@chromium.org>
903
904         Reviewed by Adam Barth.
905
906         update scm to work with different remote branches
907         https://bugs.webkit.org/show_bug.cgi?id=49949
908
909         This works if there are multiple svn tracking branches
910         and/or if the tracking branch is refs/remots/origin/master
911         instead of refs/remotes/trunk which is the direction we're trying
912         to head since that makes fetches faster.
913
914         * Scripts/webkitpy/common/checkout/scm.py:
915         * Scripts/webkitpy/common/checkout/scm_unittest.py:
916
917 2010-11-22  Hayato Ito  <hayato@chromium.org>
918
919         Reviewed by Shinichiro Hamaji.
920
921         Ignore reference files which will be used by reftests when collecting
922         test cases.
923         https://bugs.webkit.org/show_bug.cgi?id=49835
924
925         * Scripts/webkitpy/layout_tests/port/test_files.py:
926         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
927
928 2010-11-22  Adam Roben  <aroben@apple.com>
929
930         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
931
932         Apple's Windows build allows placing header files and import libraries for WebKit's
933         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
934         $WebKitLibrariesDir environment variable. This is both required for production builds and
935         convenient for Apple-internal developer builds. Apple's production builds also require that
936         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
937         builds, the files are copied into that directory tree by the
938         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
939         copying is done by
940         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
941
942         This .vsprops copying is problematic in one very important case: when a developer updates
943         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
944         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
945         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
946         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
947         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
948         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
949
950         To fix this, we now use normal relative paths to access the .vsprops files in the source
951         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
952         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
953         unset, so the normal relative paths are used to read the .vsprops files out of the source
954         tree directly. In production builds, this environment variable is set to a fake directory
955         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
956         is resolved.
957         
958         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
959
960         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
961
962         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
963         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
964         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
965         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
966         FeatureDefines.vsprops becomes:
967
968         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
969
970         which resolves to:
971
972         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
973
974         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
975         actually exist since they are matched by an equal number of ".." path components.)
976
977         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
978         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
979
980         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
981         updated
982
983         Reviewed by Dave Hyatt.
984
985         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
986         * DumpRenderTree/win/DumpRenderTree.vcproj:
987         * DumpRenderTree/win/ImageDiff.vcproj:
988         * FindSafari/FindSafari.vcproj:
989         * MiniBrowser/MiniBrowser.vcproj:
990         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
991         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
992         * WebKitAPITest/WebKitAPITest.vcproj:
993         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
994         * WebKitTestRunner/win/InjectedBundle.vcproj:
995         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
996         * WinLauncher/WinLauncher.vcproj:
997         * record-memory-win/record-memory-win.vcproj:
998         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
999         files.
1000
1001 2010-11-22  Adam Roben  <aroben@apple.com>
1002
1003         Make it possible to run tests on Windows without Visual Studio or VC++
1004         Express installed
1005
1006         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1007         are not installed. But this function doesn't need to be called when we
1008         already have a build available and are just trying to run the tests.
1009
1010         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1011         because Visual Studio/VC++ Express aren't installed
1012
1013         Reviewed by Dave Hyatt.
1014
1015         * Scripts/webkitdirs.pm:
1016         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1017         it is not needed by this function. Also added a FIXME.
1018
1019         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1020         relying on determineConfigurationForVisualStudio doing it.
1021
1022 2010-11-19  Hayato Ito  <hayato@chromium.org>
1023
1024         Reviewed by Shinichiro Hamaji.
1025
1026         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1027
1028         https://bugs.webkit.org/show_bug.cgi?id=49812
1029
1030         * Scripts/webkitpy/layout_tests/driver_test.py:
1031         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1032         * Scripts/webkitpy/layout_tests/port/base.py:
1033         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1034         * Scripts/webkitpy/layout_tests/port/chromium.py:
1035         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1036         * Scripts/webkitpy/layout_tests/port/test.py:
1037         * Scripts/webkitpy/layout_tests/port/webkit.py:
1038         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1039         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1040
1041 2010-11-22  Hayato Ito  <hayato@chromium.org>
1042
1043         Reviewed by Tony Chang.
1044
1045         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1046
1047         https://bugs.webkit.org/show_bug.cgi?id=49924
1048
1049         * Scripts/webkitpy/layout_tests/port/chromium.py:
1050
1051 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1052
1053         Reviewed by Kenneth Rohde Christiansen.
1054
1055         Fix EWebLauncher zoom discretization
1056         https://bugs.webkit.org/show_bug.cgi?id=49810
1057
1058         * EWebLauncher/main.c:
1059         (nearest_zoom_level_get):
1060         (zoom_level_set):
1061         (on_load_finished):
1062         (on_key_down):
1063
1064 2010-11-21  Sam Weinig  <sam@webkit.org>
1065
1066         Rubber-stamped by Dan Bernstein.
1067
1068         Fix ~300 WebKit2 tests by enabling developer extras preference.
1069
1070         * WebKitTestRunner/TestController.cpp:
1071         (WTR::TestController::resetStateToConsistentValues):
1072
1073 2010-11-21  Sam Weinig  <sam@webkit.org>
1074
1075         Reviewed by Dan Bernstein.
1076
1077         Textareas should be resizable by default
1078         https://bugs.webkit.org/show_bug.cgi?id=49892
1079
1080         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1081         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1082         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1083         Add preferences test.
1084
1085 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1086
1087         Reviewed by Tony Chang.
1088
1089         Rebaseline server: checksum-only differences and prefetching
1090         https://bugs.webkit.org/show_bug.cgi?id=49841
1091         
1092         Add support for image test results where the only difference is in the
1093         checksum.
1094         
1095         Add prefetching of the image results from the next test.
1096         
1097         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1098         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1099         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1100
1101 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1102
1103         Reviewed by Tony Chang.
1104
1105         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1106
1107         Add the 'worker number' and 'worker name' concepts to the 
1108         TestShellThread objects, and move test_types and test_args from
1109         the TestRunner to the TestShellThread.
1110
1111         https://bugs.webkit.org/show_bug.cgi?id=49768
1112
1113         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1114         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1115
1116 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1117
1118         Reviewed by Ojan Vafai.
1119
1120         Do some minor cleanup and bug fixing.
1121
1122         https://bugs.webkit.org/show_bug.cgi?id=49777
1123
1124         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1125         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1126
1127 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1128
1129         Reviewed by Ojan Vafai.
1130
1131         nrwt - config.build_directory() is busted
1132
1133         Fixes a typo that was causing us to usually return the top level
1134         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1135         bug was hidden by test stubs that were too simplistic :(.
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=49815
1138
1139         * Scripts/webkitpy/common/system/executive_mock.py:
1140         * Scripts/webkitpy/layout_tests/port/config.py:
1141         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1142
1143 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1144
1145         Reviewed by Adam Roben.
1146
1147         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1148         https://bugs.webkit.org/show_bug.cgi?id=49819
1149
1150         * DumpRenderTree/DumpRenderTree.sln:
1151         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1152         * DumpRenderTree/win/DumpRenderTree.vcproj:
1153         * DumpRenderTree/win/ImageDiff.vcproj:
1154         * FindSafari/FindSafari.vcproj:
1155         * MiniBrowser/MiniBrowser.vcproj:
1156         * TestWebKitAPI/win/TestWebKitAPI.sln:
1157         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1158         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1159         * WebKitAPITest/WebKitAPITest.vcproj:
1160         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1161         * WebKitTestRunner/win/InjectedBundle.vcproj:
1162         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1163         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1164         * WinLauncher/WinLauncher.vcproj:
1165         * record-memory-win/record-memory-win.vcproj:
1166
1167 2010-11-19  Adam Roben  <aroben@apple.com>
1168
1169         Add some more Windows slaves
1170
1171         This is probably more than we will be using in the immediate future,
1172         but having some extra slave names makes experimenting with different
1173         configurations easier.
1174
1175         Reviewed by Jon Honeycutt.
1176
1177         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1178         Windows slaves and distributed them among the three different Test
1179         builders.
1180
1181 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1182
1183         Reviewed by Ojan Vafai.
1184
1185         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1186         https://bugs.webkit.org/show_bug.cgi?id=49702
1187
1188         Re-landing r72357 with a test fix.
1189
1190         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1191         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1192         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1193
1194 2010-11-19  Avi Drissman  <avi@google.com>
1195
1196         Reviewed by Antonio Gomes.
1197
1198         Complete support for Unix editing mode
1199         https://bugs.webkit.org/show_bug.cgi?id=49757
1200
1201         * DumpRenderTree/LayoutTestController.cpp:
1202         (setEditingBehaviorCallback):
1203         * DumpRenderTree/chromium/LayoutTestController.cpp:
1204         (LayoutTestController::setEditingBehavior):
1205
1206 2010-11-19  Adam Roben  <aroben@apple.com>
1207
1208         Fix run-javascriptcore-tests when there's a space in the path to
1209         testapi
1210
1211         Reviewed by Sam Weinig.
1212
1213         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1214         system() to force it to interpret spaces in the path correctly.
1215
1216 2010-11-19  Adam Roben  <aroben@apple.com>
1217
1218         Update scripts for .exe name changes after r72327
1219
1220         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1221
1222         Reviewed by Sam Weinig.
1223
1224         * Scripts/run-javascriptcore-tests:
1225         (testapiPath):
1226
1227         * Scripts/sunspider-compare-results:
1228         (pathToBuiltJSC):
1229
1230         * Scripts/webkitdirs.pm:
1231         (jscPath):
1232         (safariPath):
1233
1234 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1235
1236         Reviewed by Darin Adler.
1237
1238         Normalize Cairo/CFLite project/solution configuration names
1239         https://bugs.webkit.org/show_bug.cgi?id=49818
1240
1241         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1242         * DumpRenderTree/win/DumpRenderTree.vcproj:
1243         * DumpRenderTree/win/ImageDiff.vcproj:
1244         * MiniBrowser/MiniBrowser.vcproj:
1245         * TestWebKitAPI/win/TestWebKitAPI.sln:
1246         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1247         * WebKitAPITest/WebKitAPITest.vcproj:
1248         * WebKitTestRunner/win/InjectedBundle.vcproj:
1249         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1250         * WinLauncher/WinLauncher.vcproj:
1251         * Scripts/webkitdirs.pm: Updated cairo build configs.
1252
1253 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1254
1255         Reviewed by Adam Roben.
1256
1257         Windows vcproj configuration names should be normalized across projects
1258         https://bugs.webkit.org/show_bug.cgi?id=49776
1259
1260         * DumpRenderTree/DumpRenderTree.sln:
1261         * FindSafari/FindSafari.vcproj:
1262         * TestWebKitAPI/win/TestWebKitAPI.sln:
1263         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1264         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1265         * WebKitAPITest/WebKitAPITest.vcproj:
1266         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1267         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1268         * WebKitTestRunner/WebKitTestRunner.sln:
1269         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1270         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1271         * record-memory-win/record-memory-win.vcproj:
1272
1273 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1274
1275         Build fix - as per DRT-mac, always enabled developer extras,
1276         in win/qt/gtk DRT.
1277
1278         This is necessary to enable rich exception messages to be generated
1279         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1280
1281         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1282         (shouldEnableDeveloperExtras):
1283         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1284         (WebCore::shouldEnableDeveloperExtras):
1285         * DumpRenderTree/win/DumpRenderTree.cpp:
1286         (shouldEnableDeveloperExtras):
1287
1288 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1289
1290         Unreviewed, rolling out r72357.
1291         http://trac.webkit.org/changeset/72357
1292         https://bugs.webkit.org/show_bug.cgi?id=49784
1293
1294         It broke test-webkitpy tests since the patch didn't have the
1295         corresponding test update (Requested by kinuko on #webkit).
1296
1297         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1298         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1299
1300 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1301
1302         Reviewed by Tony Chang.
1303
1304         Rebaseline server: add rebaseline queue
1305         https://bugs.webkit.org/show_bug.cgi?id=49763
1306         
1307         Add a UI queue (a multi-item <select>) where tests to be baselined
1308         can be enqueued (also supports basic removal). A queue is used instead
1309         of immediately doing rebaselines since SCM operations can take a while.
1310         It's better to go through lots of tests quickly to mark them as
1311         needing rebaselining and then batch the SCM operations.
1312         
1313         Also adds a simple log where results can be displayed.
1314
1315         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1316         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1317         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1318         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1319         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1320         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1321
1322 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1323
1324         Reviewed by Oliver Hunt.
1325
1326         Bug 49708 - Stop recompiling functions to regenerate exception info.
1327
1328         Instead only hold info as necessary – keep divot info is the inspector
1329         is enabled, line number info is debugging or profiling, and handler
1330         info for functions with try/catch.
1331
1332         * DumpRenderTree/mac/DumpRenderTree.mm:
1333         (shouldEnableDeveloperExtras):
1334             - always enable the developer tools from DRT, to ensure we
1335               produce rich error messages on JavaScript exceptions.
1336
1337 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1338
1339         Reviewed by Ojan Vafai.
1340
1341         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1342         https://bugs.webkit.org/show_bug.cgi?id=49702
1343
1344         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1345         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1346
1347 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1348
1349         Reviewed by Tony Chang.
1350
1351         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1352
1353         Create the first version of the 'message_broker' package. This
1354         class will encapsulate all of the threading/multiprocessing and
1355         message-sending details for the communication between the
1356         'manager' object and the 'worker' objects. For the moment, it
1357         just holds some routines and tests for logging thread stacks.
1358
1359         There should be no functional changes in this patch, just moving stuff
1360         around.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=49707
1363
1364         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1365         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1366         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1367         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1368         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1369         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1370
1371 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1372
1373         Reviewed by Adam Roben.
1374
1375         Remove leftover Windows Debug_Internal configurations
1376         https://bugs.webkit.org/show_bug.cgi?id=49758
1377
1378         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1379         * DumpRenderTree/win/DumpRenderTree.vcproj:
1380         * DumpRenderTree/win/ImageDiff.vcproj:
1381         * MiniBrowser/MiniBrowser.vcproj:
1382         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1383         * WebKitAPITest/WebKitAPITest.vcproj:
1384         * WebKitTestRunner/win/InjectedBundle.vcproj:
1385         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1386         * WinLauncher/WinLauncher.vcproj:
1387
1388 2010-11-18  Adam Roben  <aroben@apple.com>
1389
1390         Add three new Windows XP build slaves
1391
1392         Reviewed by Steve Falkenburg.
1393
1394         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1395         new slaves, and added them to the Windows XP Debug (Tests) builder.
1396
1397 2010-11-18  Daniel Bates  <dbates@rim.com>
1398
1399         Reviewed by Adam Roben.
1400
1401         update-webkit-support-libs should fall back to existing
1402         WebKitSupportLibrary version if there is no internet connectivity
1403         https://bugs.webkit.org/show_bug.cgi?id=49503
1404
1405         Fall back to existing support libraries (if present) when there is
1406         no internet connection.
1407
1408         Currently, update-webkit-support-libs dies with an "out-of-date"
1409         error when there is no internet connection because it cannot
1410         retrieve versioning information from developer.apple.com. Because
1411         update-webkit-support-libs fails, build-webkit fails. Instead,
1412         if there is no internet connection and the support libraries are
1413         present then we should warn the user and exit() with success so
1414         that build-webkit can work without an internet connection.
1415
1416         * Scripts/update-webkit-support-libs:
1417
1418 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1419
1420         Reviewed by Adam Roben.
1421
1422         Debug_Internal Windows configuration is unnecessary, should be removed
1423         https://bugs.webkit.org/show_bug.cgi?id=49753
1424
1425         * DumpRenderTree/win/DumpRenderTree.cpp:
1426         * MiniBrowser/win/stdafx.h:
1427         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1428         * WebKitTestRunner/win/TestControllerWin.cpp:
1429
1430 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1431
1432         Reviewed by Adam Roben.
1433
1434         Clean up vcproj errors
1435         https://bugs.webkit.org/show_bug.cgi?id=49741
1436
1437         * MiniBrowser/MiniBrowser.vcproj:
1438         * WebKitAPITest/WebKitAPITest.vcproj:
1439         * WebKitTestRunner/win/InjectedBundle.vcproj:
1440         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1441
1442 2010-11-18  Hayato Ito  <hayato@chromium.org>
1443
1444         Reviewed by Shinichiro Hamaji.
1445
1446         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1447         which is caused by r72249.
1448
1449         https://bugs.webkit.org/show_bug.cgi?id=49751
1450
1451         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1452
1453 2010-11-18  Adam Roben  <aroben@apple.com>
1454
1455         Implement layoutTestController.waitForPolicyDelegate on Windows
1456
1457         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1458
1459         Reviewed by Simon Fraser.
1460
1461         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1462         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1463         code from LayoutTestControllerMac.mm.
1464
1465 2010-11-18  Hayato Ito  <hayato@chromium.org>
1466
1467         Reviewed by Shinichiro Hamaji.
1468
1469         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1470
1471         https://bugs.webkit.org/show_bug.cgi?id=49740
1472
1473         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1474
1475 2010-11-18  Tony Chang  <tony@chromium.org>
1476
1477         Reviewed by Adam Barth.
1478
1479         run platform/chromium/plugins/refcount-leaks.html on all platforms
1480         https://bugs.webkit.org/show_bug.cgi?id=49485
1481
1482         Add PluginObject.testObjectCount which returns the number of allocated
1483         TestObjects. Add PluginObject.testCreateTestObject which allocates
1484         and returns a TestObject.
1485
1486         Add TestObject.refCount which returns the number of refs on the
1487         TestObject.
1488
1489         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1490         (pluginGetProperty):
1491         (pluginInvoke):
1492         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1493         (getTestObjectCount):
1494         (testAllocate):
1495         (testDeallocate):
1496         (testGetProperty):
1497         (testScriptObjectInvoke): Release a ref to a plugin object that was
1498             previously leaked.
1499         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1500
1501 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1502
1503         Reviewed by Adam Roben.
1504
1505         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1506         https://bugs.webkit.org/show_bug.cgi?id=49711
1507
1508         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1509         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1510         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1511         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1512         * record-memory-win/record-memory-win-common.vsprops: Added.
1513         * record-memory-win/record-memory-win.vcproj:
1514
1515 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1516
1517         Reviewed by Csaba Osztrogonác.
1518
1519         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1520
1521         * MiniBrowser/qt/BrowserWindow.cpp:
1522         (BrowserWindow::updateUserAgentList):
1523
1524 2010-11-17  Adam Roben  <aroben@apple.com>
1525
1526         Don't trigger Windows builds when chromium-win test results change
1527
1528         Reviewed by Mark Rowe.
1529
1530         * Scripts/webkitpy/common/config/build.py:
1531         (_should_file_trigger_build): Changed the regular expression used to
1532         search for directory names to only consider full directory names,
1533         rather than matching directory names where the string we care about is
1534         a suffix of the name.
1535
1536         * Scripts/webkitpy/common/config/build_unittest.py:
1537         (ShouldBuildTest): Added a test.
1538
1539 2010-11-17  Hayato Ito  <hayato@chromium.org>
1540
1541         Reviewed by Shinichiro Hamaji.
1542
1543         Remove a uri member from TestInput class.
1544
1545         https://bugs.webkit.org/show_bug.cgi?id=49691
1546
1547         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1548         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1549
1550 2010-11-17  Adam Roben  <aroben@apple.com>
1551
1552         Move FindSafari's settings into a vsprops file
1553
1554         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1555
1556         Reviewed by Steve Falkenburg.
1557
1558         * FindSafari/FindSafari.vcproj:
1559         * FindSafari/FindSafariCommon.vsprops: Added.
1560
1561 2010-11-17  Adam Roben  <aroben@apple.com>
1562
1563         Use a minimum font size of 0 in DRT on Windows
1564
1565         This is the Windows equivalent of r72164.
1566
1567         Rubber-stamped by Dave Hyatt.
1568
1569         * DumpRenderTree/win/DumpRenderTree.cpp:
1570         (resetDefaultsToConsistentValues):
1571
1572 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1573
1574         Reviewed by Andreas Kling.
1575
1576         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1577         https://bugs.webkit.org/show_bug.cgi?id=49639
1578
1579         * Scripts/webkitpy/common/checkout/scm.py:
1580
1581 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1582
1583         Reviewed by Tony Chang.
1584
1585         Rebaseline server: add loupe for image diffs
1586         https://bugs.webkit.org/show_bug.cgi?id=49692
1587         
1588         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1589         enlarged area of the expected, actual and diff images side by side.
1590
1591         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1592         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1593         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1594         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1595
1596 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1597
1598         Reviewed by Adam Roben.
1599
1600         WebKitLauncherWin should use vsprops for shared build settings
1601         https://bugs.webkit.org/show_bug.cgi?id=49696
1602
1603         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1604         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1605
1606 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1607
1608         Reviewed by Adam Roben.
1609
1610         WinLauncher should use vsprops for shared build settings
1611         https://bugs.webkit.org/show_bug.cgi?id=49695
1612
1613         * WinLauncher/WinLauncher.cpp:
1614         (_tWinMain):
1615         (PrintView):
1616         (WndProc):
1617         (MyEditProc):
1618         * WinLauncher/WinLauncher.vcproj:
1619         * WinLauncher/WinLauncherCommon.vsprops: Added.
1620
1621 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1622
1623         Delete unused file unintentionally added in last change.
1624
1625         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1626
1627 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1628
1629         Reviewed by Adam Roben.
1630
1631         DumpRenderTree on Windows should use a vsprops file for shared project settings
1632         https://bugs.webkit.org/show_bug.cgi?id=49690
1633
1634         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1635         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1636         * DumpRenderTree/win/DumpRenderTree.vcproj:
1637         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1638         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1639         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1640         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1641         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1642         * DumpRenderTree/win/ImageDiff.vcproj:
1643         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1644
1645 2010-11-17  Hayato Ito  <hayato@chromium.org>
1646
1647         Refactor TestTypeBase.compare_output().
1648
1649         Introduce a TestOutput class and update compare_output() of each test
1650         types so that they can take both actual and expected TestOutput objects.
1651
1652         https://bugs.webkit.org/show_bug.cgi?id=49431
1653
1654         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1655         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1656         * Scripts/webkitpy/layout_tests/port/base.py:
1657         * Scripts/webkitpy/layout_tests/port/chromium.py:
1658         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1659         * Scripts/webkitpy/layout_tests/port/test.py:
1660         * Scripts/webkitpy/layout_tests/port/webkit.py:
1661         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1662         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1663         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1664         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1665
1666 2010-11-17  Adam Roben  <aroben@apple.com>
1667
1668         Make each Windows Test builder use the same OS for all its slaves
1669
1670         Currently each WebKit1 Windows Test builder has one Windows XP slave
1671         and one Windows 7 slave. Having different OSes in a single builder
1672         meant that the builders would alternate between red and green when
1673         there were OS-specific failures.
1674
1675         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1676         between red and green because of multiple OS versions
1677
1678         Reviewed by Mark Rowe.
1679
1680         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1681         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1682         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1683         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1684         builders for the two WebKit1 builders so that they would all use the
1685         appropriate OS.
1686
1687 2010-11-17  James Robinson  <jamesr@chromium.org>
1688
1689         Reviewed by Dan Bernstein.
1690
1691         [chromium] Set minimum font size to 0 for DRT
1692         https://bugs.webkit.org/show_bug.cgi?id=49677
1693
1694         Followup for http://trac.webkit.org/changeset/72141.
1695
1696         Test: http/tests/misc/acid3.html
1697
1698         * DumpRenderTree/chromium/WebPreferences.cpp:
1699         (WebPreferences::reset):
1700
1701 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1702
1703         Unreviewed build fix.
1704
1705         [Qt] Add missing file I forgot in r72220.
1706
1707         * MiniBrowser/MiniBrowser.qrc: Added.
1708
1709 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1710
1711         Reviewed by Andreas Kling.
1712
1713         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1714         https://bugs.webkit.org/show_bug.cgi?id=49627
1715
1716         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1717
1718         * MiniBrowser/MiniBrowser.qrc: Added.
1719         Add it here to prevent qmake from detecting it
1720         since it needs to be copied to the build directory.
1721         * MiniBrowser/qt/BrowserWindow.cpp:
1722         (BrowserWindow::BrowserWindow):
1723         (BrowserWindow::updateUserAgentList):
1724         (BrowserWindow::showUserAgentDialog):
1725         * MiniBrowser/qt/BrowserWindow.h:
1726         * MiniBrowser/qt/MiniBrowser.pro:
1727
1728 2010-11-17  Adam Roben  <aroben@apple.com>
1729
1730         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1731
1732         We use that file on Windows!
1733
1734         Fixes <http://webkit.org/b/49643> Changes to
1735         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1736
1737         Reviewed by Steve Falkenburg.
1738
1739         * Scripts/webkitpy/common/config/build.py:
1740         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1741         trigger builds on SnowLeopard and Windows.
1742
1743         * Scripts/webkitpy/common/config/build_unittest.py:
1744         (ShouldBuildTest.test_should_build): Added a test.
1745
1746 2010-11-17  Satish Sampath  <satish@chromium.org>
1747
1748         Reviewed by Jeremy Orlow.
1749
1750         Clear the speech input mock explicitly before each test.
1751         https://bugs.webkit.org/show_bug.cgi?id=49660
1752
1753         * DumpRenderTree/chromium/LayoutTestController.cpp:
1754         (LayoutTestController::setMockSpeechInputResult):
1755         * DumpRenderTree/chromium/LayoutTestController.h:
1756         * DumpRenderTree/chromium/WebViewHost.cpp:
1757         (WebViewHost::speechInputController):
1758         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1759         * DumpRenderTree/chromium/WebViewHost.h:
1760         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1761
1762 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1763
1764         Unreviewed, specify IRC nickname in committers.py.
1765
1766         * Scripts/webkitpy/common/config/committers.py:
1767
1768 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1769
1770         Reviewed by Tony Chang.
1771
1772         [NRWT] Make http locking similar to perl implementation
1773         https://bugs.webkit.org/show_bug.cgi?id=49187
1774
1775         * Scripts/webkitpy/common/system/file_lock.py: Added.
1776         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1777         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1778
1779 2010-11-17  MORITA Hajime  <morrita@google.com>
1780
1781         Reviewed by Kent Tamura.
1782
1783         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1784         https://bugs.webkit.org/show_bug.cgi?id=49366
1785
1786         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1787           according to the spellchecker suggestion
1788         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1789
1790         test_expectations.txt will be changed after this change is ported to test_shell.
1791         
1792         * DumpRenderTree/chromium/EventSender.cpp:
1793         (makeMenuItemStringsFor):
1794         (EventSender::contextClick):
1795         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1796         (MockSpellCheck::fillSuggestionList):
1797         (MockSpellCheck::initializeIfNeeded):
1798         * DumpRenderTree/chromium/MockSpellCheck.h:
1799         * DumpRenderTree/chromium/WebViewHost.cpp:
1800         (WebViewHost::mockSpellCheck):
1801         * DumpRenderTree/chromium/WebViewHost.h:
1802
1803 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1804
1805         Reviewed by Sam Weinig.
1806
1807         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1808         since the bots have 1 stuck in their plist otherwise.
1809
1810         * DumpRenderTree/mac/DumpRenderTree.mm:
1811         (resetDefaultsToConsistentValues):
1812
1813 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1814
1815         Reviewed by Tony Chang.
1816
1817         Rebaseline server: compute diffs client-side
1818         https://bugs.webkit.org/show_bug.cgi?id=49640
1819         
1820         The image diff output from the DRT is pretty bad on some ports (at
1821         least the Mac one), so it's better to compute diffs on the client by
1822         using <canvas>.
1823
1824         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1825         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1826         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1827
1828 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1829
1830         Reviewed by Tony Chang.
1831
1832         Rebaseline server: display test results
1833         https://bugs.webkit.org/show_bug.cgi?id=49626
1834         
1835         Adds basic result display to the rebaseline server. On the Python side
1836         this involves:
1837         - Parsing the unexpected_results.json into a dictionary.
1838         - Serving it as JSON under /results.json.
1839         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1840         but I'll need to have access to the parsed results on the Python side
1841         for follow-up changes).
1842         
1843         On the web UI side this adds:
1844         - Markup for display image and text results (expected, actual, diff),
1845           and JS for populating it.
1846         - Markup for breaking down test results by failure type and directory,
1847           and JS for populating it.
1848
1849         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1850         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1851         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1852         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
1853         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1854
1855 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1856
1857         Reviewed by Ojan Vafai.
1858
1859         See Chromium issue http://codereview.chromium.org/5133001/ - we
1860         are modifying the build bots to pass in the builder name with
1861         the "GPU" string appended instead of appending it in the code.
1862
1863         https://bugs.webkit.org/show_bug.cgi?id=49636
1864
1865         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1866
1867 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
1868
1869         Reviewed by Adam Roben.
1870
1871         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
1872         https://bugs.webkit.org/show_bug.cgi?id=49632
1873
1874         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1875         * DumpRenderTree/win/DumpRenderTree.vcproj:
1876         * DumpRenderTree/win/ImageDiff.vcproj:
1877         * MiniBrowser/MiniBrowser.vcproj:
1878         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1879         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1880         * WebKitTestRunner/win/InjectedBundle.vcproj:
1881         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1882         * WinLauncher/WinLauncher.vcproj:
1883         * record-memory-win/record-memory-win.vcproj:
1884
1885 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1886
1887         Reviewed by Ojan Vafai.
1888
1889         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
1890
1891         Rename the TestInfo class to TestInput to be clearer about its
1892         function, and move the checksum-reading code into dump_render_tree_thread
1893         to avoid cross-thread access.
1894
1895         https://bugs.webkit.org/show_bug.cgi?id=49573
1896
1897         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1899         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1900
1901 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1902
1903         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
1904
1905         * DumpRenderTree/mac/DumpRenderTree.mm:
1906         (resetDefaultsToConsistentValues):
1907
1908 2010-11-16  Stephanie Lewis  <slewis@apple.com>
1909
1910         Reviewed by Geoff Garen.
1911
1912         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1913
1914         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
1915         for every WebView, and the WebKit API doesn't support that ownership model.
1916
1917         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
1918
1919         * DumpRenderTree/mac/DumpRenderTree.mm:
1920         (createWebViewAndOffscreenWindow):
1921         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1922         (LayoutTestController::setMockDeviceOrientation):
1923
1924 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1925
1926         Reviewed by Ojan Vafai.
1927
1928         new-run-webkit-tests: log the process id in --verbose mode
1929
1930         As part of the switch to multi-process mode, we should log the
1931         process id when running w/ --verbose.
1932
1933         https://bugs.webkit.org/show_bug.cgi?id=49571
1934
1935         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1936
1937 2010-11-16  Adam Roben  <aroben@apple.com>
1938
1939         Only trigger Windows builds when files that we actually use on Windows
1940         are changed
1941
1942         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
1943         It uses the new webkitpy.common.config.build module to determine
1944         whether a particular change should trigger a build on a particular
1945         platform. The Windows builders have been switched to use a
1946         PlatformSpecificScheduler.
1947
1948         The logic to determine whether or not a particular change should
1949         trigger a build on a given platform has only been implemented/tested
1950         for Windows. I tried to make it easy to add more platforms in the
1951         future, but I don't have enough familiarity with all platforms to be
1952         able to implement it for them.
1953
1954         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
1955         lots irrelevant changes (e.g., rebaselining Chromium test results)
1956
1957         Reviewed by Eric Seidel.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
1960         PlatformSpecificScheduler for the Windows builders.
1961
1962         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1963         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
1964         up a ChangeFilter that filters to our branch and will call through to
1965         our filter method, and calls up to our base class.
1966         (PlatformSpecificScheduler.filter): Calls through to
1967         build.should_build to find out whether we should trigger a build for
1968         this change.
1969
1970         * Scripts/webkitpy/common/net/build.py: Added.
1971         (_should_file_trigger_build): Uses a set of directories and regexp
1972         patterns to determine whether the given file should trigger a build on
1973         the given platform. As mentioned earlier, this has only been
1974         implemented for Windows, though I did try to make some guesses about
1975         other platforms.
1976         (should_build): Returns true if any of the files should trigger a
1977         build on the given platform.
1978
1979         * Scripts/webkitpy/common/net/build_unittest.py: Added.
1980         (ShouldBuildTest.test_should_build): Does some basic testing to make
1981         sure we're triggering builds for the right files. It only tests
1982         Windows for now, though I tried to make some guesses about other
1983         platforms.
1984
1985 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1986
1987         Reviewed by Andreas Kling.
1988
1989         [Qt] Remove synchronous QWebPage::checkPermissions signal
1990         https://bugs.webkit.org/show_bug.cgi?id=46810
1991
1992         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1993         (WebCore::WebPage::WebPage):
1994         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1995         (LayoutTestController::grantDesktopNotificationPermission): When granting
1996         permission, grant it directly on the QWebPage/Frame, that will remember it.
1997         * QtTestBrowser/webpage.cpp:
1998         (WebPage::WebPage):
1999         * QtTestBrowser/webpage.h:
2000
2001
2002 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2003
2004         Reviewed by Csaba Osztrogonác.
2005
2006         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2007
2008         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2009         (LayoutTestController::reset):
2010         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2011         (LayoutTestController::isPrinting):
2012         (LayoutTestController::setPrinting):
2013
2014 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2015
2016         Reviewed by Andreas Kling.
2017
2018         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2019         https://bugs.webkit.org/show_bug.cgi?id=49587
2020
2021         * MiniBrowser/qt/BrowserView.cpp:
2022         (BrowserView::BrowserView): Added BackingStoreType
2023         argument to ctor. Propagating it to the QGraphicsWKView.
2024         * MiniBrowser/qt/BrowserView.h:
2025         * MiniBrowser/qt/BrowserWindow.cpp:
2026         (BrowserWindow::BrowserWindow):
2027         (BrowserWindow::newWindow): Create the new BrowserWindow
2028         with the same BackingStoreType that this instance has.
2029         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2030         * MiniBrowser/qt/main.cpp:
2031         (main): Use tiled backing store if got -tiled command line argument.
2032         Avoid redundant copy of command line args.
2033
2034 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2035
2036         Reviewed by Jeremy Orlow.
2037
2038         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2039         https://bugs.webkit.org/show_bug.cgi?id=48506
2040
2041         This ensures that there is one mock per page WebView / WebViewHost. This is a
2042         design constraint of the DeviceOrientationClientMock because the m_controller
2043         field can only store a pointer to a single instance of the corresponding
2044         DeviceOrientationController.
2045
2046         Test: fast/dom/DeviceOrientation/no-page-cache.html
2047
2048         * DumpRenderTree/chromium/LayoutTestController.cpp:
2049         (LayoutTestController::setMockDeviceOrientation):
2050         (LayoutTestController::deviceOrientationClientMock):
2051         * DumpRenderTree/chromium/LayoutTestController.h:
2052         * DumpRenderTree/chromium/WebViewHost.cpp:
2053         (WebViewHost::deviceOrientationClientMock):
2054         (WebViewHost::deviceOrientationClient):
2055         (WebViewHost::reset):
2056         * DumpRenderTree/chromium/WebViewHost.h:
2057
2058 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2059
2060         Reviewed by Andreas Kling.
2061
2062         [Qt][WK2] Avoid polling in WebKitTestRunner.
2063         https://bugs.webkit.org/show_bug.cgi?id=49542
2064
2065         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2066         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2067
2068         * WebKitTestRunner/TestController.cpp:
2069         (WTR::TestController::didFinishLoadForFrame):
2070         * WebKitTestRunner/TestController.h:
2071         * WebKitTestRunner/TestInvocation.cpp:
2072         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2073         * WebKitTestRunner/mac/TestControllerMac.mm:
2074         (WTR::TestController::notifyDone): Add method stub.
2075         * WebKitTestRunner/qt/TestControllerQt.cpp:
2076         (WTR::TestControllerRunLoop::instance):
2077         (WTR::TestControllerRunLoop::start):
2078         (WTR::TestControllerRunLoop::stop):
2079         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2080         (WTR::TestControllerRunLoop::timerEvent):
2081         (WTR::TestController::notifyDone):
2082         (WTR::TestController::platformRunUntil):
2083         * WebKitTestRunner/win/TestControllerWin.cpp:
2084         (WTR::TestController::notifyDone): Add method stub.
2085
2086 2010-11-15  Darin Adler  <darin@apple.com>
2087
2088         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2089
2090 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2091
2092         Reviewed by Andreas Kling.
2093
2094         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2095         https://bugs.webkit.org/show_bug.cgi?id=49544
2096
2097         Add the shortcut to BrowserWindow.
2098
2099         * MiniBrowser/qt/BrowserWindow.cpp:
2100         (BrowserWindow::BrowserWindow):
2101         (BrowserWindow::openLocation):
2102         * MiniBrowser/qt/BrowserWindow.h:
2103
2104 2010-11-14  David Levin  <levin@chromium.org>
2105
2106         Reviewed by Daniel Bates.
2107
2108         check-webkit-style should detect PassRefPtr usage in functions.
2109         https://bugs.webkit.org/show_bug.cgi?id=49513
2110
2111         * Scripts/webkitpy/style/checkers/cpp.py:
2112         (check_for_function_lengths): Revert a comment change that I
2113          accidentally made in r71986.
2114         (check_pass_ptr_usage): Added the code to do the check.
2115         (process_line): Added the call to check_pass_ptr_usage.
2116         (CppChecker): Added the new error category.
2117         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2118         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2119          testing purposes.
2120         (PassPtrTest::*): The class/functions to unit test the new
2121          functionality.
2122
2123 2010-11-14  David Levin  <levin@chromium.org>
2124
2125         Reviewed by Shinichiro Hamaji.
2126
2127         check-webkit-style function detection and the line count style checks should be separate.
2128         https://bugs.webkit.org/show_bug.cgi?id=49512
2129
2130         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2131         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2132           call the detection function and fix line counts in two places now that
2133           the code really only counts the lines in the body of the function.
2134
2135 2010-11-14  Andreas Kling  <kling@webkit.org>
2136
2137         Reviewed by Antonio Gomes.
2138
2139         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2140         https://bugs.webkit.org/show_bug.cgi?id=33438
2141
2142         Stifle "Unhandled variable" warning to match what the other
2143         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2144         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2145
2146         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2147         (webkit_test_plugin_get_value):
2148
2149 2010-11-13  David Levin  <levin@chromium.org>
2150
2151         Reviewed by Eric Seidel.
2152
2153         check-webkit-style function detection crashes on functions in templates.
2154         https://bugs.webkit.org/show_bug.cgi?id=49504
2155
2156         For example "template <bool shouldClose(const Element*)>".
2157
2158         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2159         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2160           function detection test to expose this issue.
2161
2162 2010-11-12  David Levin  <levin@chromium.org>
2163
2164         Reviewed by Shinichiro Hamaji.
2165
2166         check-webkit-style function detection doesn't detect indented functions declaractions.
2167         https://bugs.webkit.org/show_bug.cgi?id=49446
2168
2169         Indented function declarations occur inside class definitions, so
2170         they are a pretty common (and worth detecting).
2171
2172         * Scripts/webkitpy/style/checkers/cpp.py:
2173           Changed regex to allow indentation.
2174           Changed the function start detection to only happen when not in a
2175           function.
2176           Changed function end detection to work based on matching braces
2177           instead of finding a close brace at the beginning of the line.
2178           Fixed close_expression to do what it says when it doesn't find
2179           the close.
2180         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2181
2182 2010-11-12  Daniel Bates  <dbates@rim.com>
2183
2184         Rubber-stamped by Nikolas Zimmermann.
2185
2186         Make do-file-rename rename files in the directory WebKit2.
2187
2188         This also makes the list of searched directories in do-file-rename
2189         consistent with the list of searched directories in the script do-webcore-rename.
2190
2191         * Scripts/do-file-rename:
2192
2193 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2194
2195         Reviewed by James Robinson.
2196
2197         Attempt yet again to land the fix for bug 49360 (respecting
2198         set-webkit-configuration). We need to handle the cases where
2199         trying to run webkit-build-directory to find out where the
2200         default configuration might be fails (that shows up on some
2201         Chromium bots that apparently don't have perl installed).
2202
2203         https://bugs.webkit.org/show_bug.cgi?id=49360
2204
2205         * Scripts/webkitpy/layout_tests/port/config.py:
2206         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2207         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2208
2209 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2210
2211         Reviewed by Adam Barth.
2212
2213         webkit-patch land logs commit message twice
2214         https://bugs.webkit.org/show_bug.cgi?id=49482
2215         
2216         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2217         that's just the commit message, which we now output following the
2218         actual commit.
2219
2220         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2221
2222 2010-11-12  Tony Chang  <tony@chromium.org>
2223
2224         Reviewed by Adam Barth.
2225
2226         run platform/chromium/plugins/script-object-invoke.html on all platforms
2227         https://bugs.webkit.org/show_bug.cgi?id=49280
2228
2229         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2230         (testScriptObjectInvoke):
2231         (pluginInvoke):
2232
2233 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2234
2235         Reviewed by Adam Barth.
2236
2237         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2238         https://bugs.webkit.org/show_bug.cgi?id=49471
2239
2240         Right now there's no indication of a successful commit.
2241         
2242         * Scripts/webkitpy/tool/commands/download_unittest.py:
2243         * Scripts/webkitpy/tool/steps/commit.py:
2244
2245 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2246
2247         Reviewed by Ojan Vafai.
2248
2249         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2250         https://bugs.webkit.org/show_bug.cgi?id=49354
2251
2252         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2253
2254         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2255         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2256         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2258
2259 2010-11-12  Tony Chang  <tony@chromium.org>
2260
2261         Reviewed by Kent Tamura.
2262
2263         [chromium] Load a blank page when closing DRT WebViewHosts
2264         https://bugs.webkit.org/show_bug.cgi?id=49417
2265
2266         In test_shell, when we close a window, we first load about:blank
2267         and run GC to fire the destruction logic of the page.  In test_shell,
2268         this happens in ~TestShell.  In DRT, we manage virtual windows as
2269         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2270
2271         Managing focus is a bit trickier, since normally you would get window
2272         events to reset the focus to the right window.  We do it manually
2273         instead.
2274
2275         This fixes 2 plugin tests on DRT.
2276
2277         * DumpRenderTree/chromium/TestShell.cpp:
2278         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2279         (TestShell::closeWindow): Move widget close() to WVH destructor and
2280             manage focus manually.
2281         (TestShell::closeRemainingWindows): Comment typo.
2282         * DumpRenderTree/chromium/WebViewHost.cpp:
2283         (WebViewHost::closeWidget):
2284         (invokeCloseWidget):
2285         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2286             test_shell).
2287         (WebViewHost::~WebViewHost):
2288         * DumpRenderTree/chromium/WebViewHost.h:
2289
2290 2010-11-12  David Levin  <levin@chromium.org>
2291
2292         Reviewed by Adam Barth.
2293
2294         cpp.py needs some tidying.
2295         https://bugs.webkit.org/show_bug.cgi?id=49443
2296
2297         * Scripts/webkitpy/style/checkers/cpp.py:
2298           Fix parameter ordering for iteratively_replace_matches_with_char
2299           to mirror other similar functions (and improved comments, etc.)
2300           Also, use a python-ism (for/else) to get rid of a variable that
2301           was there to determine if something had been found in the loop.
2302
2303 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2304
2305         Reviewed by James Robinson.
2306
2307         [Chromium/DRT] Make EventSendingController send complete touch events.
2308         https://bugs.webkit.org/show_bug.cgi?id=49285
2309
2310         * DumpRenderTree/chromium/EventSender.cpp:
2311         (EventSender::addTouchPoint):
2312         (EventSender::updateTouchPoint):
2313         (EventSender::sendCurrentTouchEvent):
2314
2315 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2316
2317         Unreviewed rollout of r71858.
2318
2319         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2320         NaCl tests.
2321
2322         * Scripts/webkitpy/layout_tests/port/config.py:
2323         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2324         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2325
2326 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2327
2328         Reviewed by Kenneth Rohde Christiansen.
2329
2330         [Qt] TestController::runUntil doesn't honor the timeout parameter
2331         https://bugs.webkit.org/show_bug.cgi?id=48941
2332
2333         Implement the missing timeout of WebKitTestRunner for Qt.
2334
2335         A QElapsedTimer has been added to RunUntilConditionLoop in order
2336         to measure how long the loop has been running. When the timer
2337         is bigger or equal than the timeout, the loop ends even if the
2338         condition is not met.
2339
2340         * WebKitTestRunner/qt/TestControllerQt.cpp:
2341         (WTR::RunUntilConditionLoop::start):
2342         (WTR::RunUntilConditionLoop::run):
2343         (WTR::RunUntilConditionLoop::timerEvent):
2344         (WTR::TestController::platformRunUntil):
2345
2346 2010-11-11  David Levin  <levin@chromium.org>
2347
2348         Reviewed by Shinichiro Hamaji.
2349
2350         check-webkit-style function detection doesn't handle templates with spaces.
2351         https://bugs.webkit.org/show_bug.cgi?id=49427
2352
2353         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2354           finding the function name.
2355         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2356           template with a space.
2357
2358 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2359
2360         Reviewed by Shinichiro Hamaji.
2361
2362         Enable check-webkit-style on Qt files
2363         https://bugs.webkit.org/show_bug.cgi?id=48322
2364
2365         Adding exception for _q_... private slots and
2366         ..._data() methods in tests
2367
2368         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2369         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2370
2371 2010-11-11  David Levin  <levin@chromium.org>
2372
2373         Reviewed by Shinichiro Hamaji.
2374
2375         check-webkit-style function detection doesn't work for templates and destructors.
2376         https://bugs.webkit.org/show_bug.cgi?id=49425
2377
2378         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2379         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2380
2381 2010-11-11  Joone Hur  <joone@kldp.org>
2382
2383         Reviewed by Antonio Gomes.
2384
2385         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2386         https://bugs.webkit.org/show_bug.cgi?id=46598
2387
2388         Support nodesFromRect in DRT
2389
2390         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2391         (LayoutTestController::nodesFromRect):
2392
2393 2010-11-11  MORITA Hajime  <morrita@google.com>
2394
2395         Reviewed by Kent Tamura.
2396
2397         editing/selection/context-menu-on-text.html fails on chromium
2398         https://bugs.webkit.org/show_bug.cgi?id=45898
2399
2400         Enhance Chromium's EventSender::contextClick() to return
2401         array of menu strings. The implementation incomplete because
2402         Although actual context menu is implemented by the browser,
2403         it reflects editability of underlying context thus makes
2404         context-menu-on-text.html passed.
2405         
2406         * DumpRenderTree/chromium/EventSender.cpp:
2407         (makeMenuItemStringsFor): Added.
2408         (EventSender::contextClick): Now returns array of menu strings.
2409         * DumpRenderTree/chromium/WebViewHost.cpp:
2410         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2411         (WebViewHost::clearContextMenuData): Added.
2412         (WebViewHost::lastContextMenuData): Added.
2413         * DumpRenderTree/chromium/WebViewHost.h:
2414
2415 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2416
2417         Unreviewed, build fix.
2418
2419         fix build breakage caused by fix for bug 49380 (r71858).
2420
2421         config_standalone needs to ensure that the packages it needs are
2422         in sys.path.
2423
2424         https://bugs.webkit.org/show_bug.cgi?id=49419
2425
2426         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2427
2428 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2429
2430         Reviewed by Adam Roben.
2431
2432         Fix NRWT to respect set-webkit-configuration again :(
2433
2434         This change fixes a typo in config.py that was causing the wrong
2435         value to be read initially and us never actually looking into
2436         the filesystem to get the default configuration.
2437         
2438         * Scripts/webkitpy/layout_tests/port/config.py:
2439         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2440         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2441
2442 2010-11-11  Eric Seidel  <eric@webkit.org>
2443
2444         Reviewed by Adam Barth.
2445
2446         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2447         https://bugs.webkit.org/show_bug.cgi?id=49403
2448
2449         CommitterValidator really had nothing to do with bugzilla.py.
2450         I've put it next to committers.py for now since its rather tied to that file.
2451
2452         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2453         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2454         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2455         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2456         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2457         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2458         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2459         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2460         * Scripts/webkitpy/tool/bot/feeders.py:
2461         * Scripts/webkitpy/tool/commands/queues.py:
2462
2463 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2464
2465         Reviewed by Eric Seidel.
2466
2467         fix missing 'pid' argument for http lockfile checking on win32
2468         https://bugs.webkit.org/show_bug.cgi?id=49363
2469
2470         * Scripts/webkitpy/common/system/executive.py:
2471
2472 2010-11-11  Eric Seidel  <eric@webkit.org>
2473
2474         Rubber-stamped by Adam Barth.
2475
2476         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2477         https://bugs.webkit.org/show_bug.cgi?id=49402
2478
2479         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2480         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2481         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2482
2483 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2484
2485         Reviewed by Chris Fleizach.
2486
2487         Use IAccessibleComparable to compare accessibility objects.
2488         https://bugs.webkit.org/show_bug.cgi?id=49118
2489
2490         * DumpRenderTree/AccessibilityUIElement.cpp:
2491         (AccessibilityUIElement::isEqual):
2492         * DumpRenderTree/AccessibilityUIElement.h:
2493         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2494         (comparableObject):
2495         (AccessibilityUIElement::isEqual):
2496
2497 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2498
2499         Reviewed by David Hyatt.
2500
2501         HTML5 Ruby support should be mandatory feature
2502         https://bugs.webkit.org/show_bug.cgi?id=49272
2503
2504         Remove Ruby as optional feature.
2505
2506         * Scripts/build-webkit:
2507
2508 2010-11-10  Adam Roben  <aroben@apple.com>
2509
2510         Print VC++ Express build logs in the same order that the projects are
2511         built
2512
2513         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2514         in an unhelpful order
2515
2516         Reviewed by Eric Seidel.
2517
2518         * Scripts/print-vse-failure-logs:
2519         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2520         print-msvc-project-dependencies to figure out the order in which
2521         projects are built.
2522         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2523         based on their build order and project name.
2524         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2525         scripts directory from here...
2526         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2527         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2528         them.
2529
2530 2010-11-10  Adam Roben  <aroben@apple.com>
2531
2532         Only print the interesting text from VC++ Express build logs
2533
2534         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2535         output from print-vse-failure-logs
2536
2537         Reviewed by Eric Seidel.
2538
2539         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2540         added newly-required imports. Removed a comment that was essentially a
2541         FIXME, and is now fixed.
2542         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2543         BeautifulSoup to extract the relevant text from the build log.
2544         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2545
2546 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2547
2548         Reviewed by Tony Chang.
2549
2550         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2551         https://bugs.webkit.org/show_bug.cgi?id=49286
2552         
2553         The tests in http/tests/security/XFrameOptions started to fail after
2554         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2555         logic to always assign identifiers to requests, even if we're not going
2556         to be dumping resource load callbacks at that point. These tests
2557         only call LayoutTestController.dumpResourceLoadCallbacks after the
2558         request is started, thus their expectations have "<unknown>" as the
2559         identifier. Change WebViewHost to the previous behavior, which also
2560         match the other ports'.
2561
2562         * DumpRenderTree/chromium/WebViewHost.cpp:
2563         (WebViewHost::assignIdentifierToRequest):
2564         (WebViewHost::removeIdentifierForRequest):
2565
2566 2010-11-08  Tony Chang  <tony@chromium.org>
2567
2568         Reviewed by Adam Barth.
2569
2570         run platform/chromium/plugins/return-npobject.html on all platforms
2571         https://bugs.webkit.org/show_bug.cgi?id=49103
2572
2573         This tests that we can get an NPObject returned through a method on
2574         an NPAPI Object.
2575
2576         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2577         (testCallbackReturn):
2578         (pluginInvoke):
2579
2580 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2581
2582         Unreviewed, rolling out r71672.
2583         http://trac.webkit.org/changeset/71672
2584         https://bugs.webkit.org/show_bug.cgi?id=49276
2585
2586         It doesn't work on Chromium Windows bot (Requested by Ossy on
2587         #webkit).
2588
2589         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2590         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2591         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2592
2593 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2594
2595         Reviewed by Tony Chang.
2596
2597         [NRWT] Make http locking similar to perl implementation
2598         https://bugs.webkit.org/show_bug.cgi?id=49187
2599
2600         * Scripts/webkitpy/common/system/file_lock.py: Added.
2601         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2602         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2603
2604 2010-11-09  James Kozianski  <koz@chromium.org>
2605
2606         Reviewed by Eric Seidel.
2607
2608         Clean up imports for webkit-patch.
2609         https://bugs.webkit.org/show_bug.cgi?id=49083
2610
2611         Move some imports from commands into main.py where they are used.
2612         Move command imports into the __init__ of the commands module.
2613
2614         * Scripts/webkitpy/tool/commands/__init__.py:
2615         * Scripts/webkitpy/tool/commands/download.py:
2616         * Scripts/webkitpy/tool/commands/queues.py:
2617         * Scripts/webkitpy/tool/main.py:
2618
2619 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2620
2621         Reviewed by Andreas Kling.
2622
2623         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2624         https://bugs.webkit.org/show_bug.cgi?id=49047
2625
2626         * QtTestBrowser/mainwindow.cpp:
2627         (MainWindow::setAddressUrl):
2628
2629 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2630
2631         Reviewed by Csaba Osztrogonác.
2632
2633         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2634         https://bugs.webkit.org/show_bug.cgi?id=49252
2635
2636         * Scripts/old-run-webkit-tests:
2637
2638 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2639
2640         Reviewed by Tor Arne Vestbø.
2641
2642         Output of old-run-webkit-tests is buggy in verbose mode
2643         https://bugs.webkit.org/show_bug.cgi?id=49249
2644
2645         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2646
2647 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2648
2649         Reviewed by Martin Robinson.
2650
2651         [GTK] Link with target name set does not work
2652         https://bugs.webkit.org/show_bug.cgi?id=48865
2653
2654         When a new page is created with a name (target=myFrame), the new
2655         mainFrame could not be found because they where not stored in the
2656         same PageGroup. As PageGroup are not exposed externally so the
2657         simpliest solution is to use a global page group name. This also fixes
2658         issue with visited link coloration across pages. After this change the
2659         private function webkit_web_view_set_group_name() was no longer used
2660         so it was removed completly.
2661
2662         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2663         (createWebView):
2664
2665 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2666
2667         Reviewed by Kent Tamura.
2668
2669         WebViewHost::reset() uses placement new.
2670         https://bugs.webkit.org/show_bug.cgi?id=49069
2671
2672         WebViewHost is using placement destruction / new to simulate a fresh
2673         WebViewHost object at the same address. This is because the WebView remains
2674         open across tests and maintains a pointer to the WebViewHost.
2675         This change resets member variables explictly instead of the placement new dance.
2676
2677         * DumpRenderTree/chromium/WebViewHost.cpp:
2678         (WebViewHost::WebViewHost):
2679         (WebViewHost::reset):
2680
2681 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2682
2683         Reviewed by Eric Seidel.
2684
2685         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2686         It turns out that NRWT can't use the code in scm.find_checkout_root()
2687         because the Chromium bots don't do full checkouts of the WebKit
2688         tree; they only check out subdirectories like WebKitTools/Scripts.
2689         Until we can figure out a better approach for this, I've
2690         restored the base_dir-detecting code from NRWT, which works in
2691         any directory tree, scm or no.
2692
2693         This also restores the files modified in r71475 and r71474.
2694
2695         https://bugs.webkit.org/show_bug.cgi?id=49151
2696
2697         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2698         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2699
2700 2010-11-08  Eric Seidel  <eric@webkit.org>
2701
2702         Reviewed by Adam Barth.
2703
2704         webkit-patch failure-reason explodes if a build is missing
2705         https://bugs.webkit.org/show_bug.cgi?id=49195
2706
2707         This is likely a recent regression.  Adding a unit test for this case.
2708
2709         * Scripts/webkitpy/common/net/buildbot.py:
2710         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2711
2712 2010-11-08  Dan Bernstein  <mitz@apple.com>
2713
2714         Reviewed by Darin Adler.
2715
2716         Ignore the system scrollbar setting.
2717
2718         * DumpRenderTree/mac/DumpRenderTree.mm:
2719         (resetDefaultsToConsistentValues): Set the scrollbar default.
2720
2721 2010-11-05  Adam Roben  <aroben@apple.com>
2722
2723         Make webkitpy.common.system.executive_unittest pass when running under
2724         Win32 Python
2725
2726         Fixes <http://webkit.org/b/49033>.
2727
2728         Reviewed by Dave Levin and Eric Seidel.
2729
2730         * Scripts/webkitpy/common/system/executive.py:
2731         (Executive._run_command_with_teed_output): Pass the arguments through
2732         encode_argument_if_needed rather than using Cygwin-specific code here.
2733         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2734         the output.
2735         (Executive.run_command): Use encode_argument_if_needed to encode the
2736         arguments and child_process_encoding to decode the output.
2737         (Executive._child_process_encoding): Returns the encoding that should be
2738         used when communicating with child processes. On Windows we use mbcs,
2739         which maps to the current code page. On all other platforms we use
2740         UTF-8.
2741         (Executive._should_encode_child_process_arguments): Returns True if
2742         arguments to child processes need to be encoded. This is currently
2743         only needed on Cygwin and Win32 Python 2.x.
2744         (Executive._encode_argument_if_needed): Encode the argument using
2745         child_process_encoding if we need to encode arguments to child
2746         processes on this platform.
2747
2748         * Scripts/webkitpy/common/system/executive_unittest.py:
2749         (never_ending_command): Added. Returns arguments to run a command that
2750         will not quit until we kill it. On Windows we use wmic, on other
2751         platforms we use yes.
2752         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2753         mbcs encoding to be used and for output from the child processes to
2754         have been roundtripped through encode/decode on Win32 Python. When
2755         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2756         it's possible that some characters will not be able to be converted
2757         and will be replaced by question marks; the round-tripping allows us
2758         to expect this result.
2759
2760         (ExecutiveTest.test_kill_process):
2761         (ExecutiveTest.test_kill_all):
2762         Use never_ending_command instead of invoking "yes" directly. Expect an
2763         exit code of 1 when using Win32 Python, as that's what seems to happen.
2764
2765 2010-11-08  Adam Roben  <aroben@apple.com>
2766
2767         Roll out r71532
2768
2769         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2770         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2771
2772         * Scripts/webkitdirs.pm:
2773
2774 2010-11-08  Tony Chang  <tony@chromium.org>
2775
2776         Reviewed by Adam Barth.
2777
2778         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2779         https://bugs.webkit.org/show_bug.cgi?id=49094
2780
2781         This tests that objects created by plugins are proplery cleaned up.
2782
2783         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2784         (testPassTestObject):
2785         (pluginInvoke):
2786         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2787         (testAllocate):
2788         (testDeallocate):
2789         (testGetProperty):
2790         (testConstruct):
2791
2792 2010-11-08  Adam Roben  <aroben@apple.com>
2793
2794         Mark Windows builds triggered from Perl as being non-interactive
2795
2796         This affects whether some of our scripts will show alerts vs. printing
2797         to the build log.
2798
2799         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2800         .vsprops files are updated
2801
2802         Reviewed by Steve Falkenburg.
2803
2804         * Scripts/webkitdirs.pm:
2805         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2806
2807 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2808
2809         Reviewed by Ojan Vafai.
2810
2811         Make http locking default in NRWT.
2812         https://bugs.webkit.org/show_bug.cgi?id=48053
2813
2814         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2815         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2816
2817 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2818
2819         Reviewed by Csaba Osztrogonác.
2820
2821         [NRWT] If the http lock fails we shouldn't do any locking
2822         https://bugs.webkit.org/show_bug.cgi?id=49164
2823
2824         If something goes wrong with the locking, the test should keep going.
2825
2826         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2827
2828 2010-11-08  Adam Roben  <aroben@apple.com>
2829
2830         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2831         pixel dumps on Windows
2832
2833         I changed this behavior in r71418 thinking that it was required for
2834         getting plugins to show up in pixel dumps. But it doesn't seem to be
2835         necessary, and was making it impossible to compare new Windows pixel
2836         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2837         compare an image with alpha to an image without alpha).
2838
2839         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2840         new Windows pixel results to existing Windows or Mac results
2841
2842         Reviewed by Antti Koivisto.
2843
2844         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2845         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2846         with kCGImageAlphaPremultipliedFirst.
2847
2848 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2849
2850         Unreviewed, rolling out r71466.
2851         http://trac.webkit.org/changeset/71466
2852         https://bugs.webkit.org/show_bug.cgi?id=48865
2853
2854         It broke layout tests on GTK bots.
2855
2856         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2857         (createWebView):
2858
2859 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2860
2861         Reviewed by Csaba Osztrogonác.
2862
2863         Enable running of Qt API tests on BuildBot
2864         https://bugs.webkit.org/show_bug.cgi?id=49004
2865
2866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2867
2868 2010-11-08  Eric Seidel  <eric@webkit.org>
2869
2870         Reviewed by Adam Barth.
2871
2872         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
2873         https://bugs.webkit.org/show_bug.cgi?id=49160
2874
2875         Bugzilla doesn't automatically remove r? when a bug gets closed.
2876         This script takes care of that for webkit.org.
2877
2878         * Scripts/webkitpy/common/net/bugzilla.py:
2879         * Scripts/webkitpy/tool/commands/upload.py:
2880
2881 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2882
2883         Unreviewed, rolling out r71474.
2884         http://trac.webkit.org/changeset/71474
2885         https://bugs.webkit.org/show_bug.cgi?id=48280
2886
2887         breaks chromium webkit tests
2888         https://bugs.webkit.org/show_bug.cgi?id=49151
2889
2890         * Scripts/webkitpy/layout_tests/port/base.py:
2891         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2892         * Scripts/webkitpy/layout_tests/port/config.py:
2893         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2894         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2895         * Scripts/webkitpy/layout_tests/port/webkit.py:
2896         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2897         * Scripts/webkitpy/tool/mocktool.py:
2898
2899 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2900
2901         Unreviewed, rolling out r71475.
2902         http://trac.webkit.org/changeset/71475
2903  
2904         breaks chromium webkit tests
2905         https://bugs.webkit.org/show_bug.cgi?id=49151
2906
2907         * Scripts/webkitpy/common/newstringio.py: Removed.
2908         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
2909         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
2910         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
2911         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
2912
2913 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2914
2915         Unreviewed, build fix.
2916
2917         Add files inexplicably not committed in r71474 as part of the
2918         fix for bug 48280.
2919
2920         * Scripts/webkitpy/common/newstringio.py: Added.
2921         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2922         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2923         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2924         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
2925
2926 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2927
2928         Reviewed by Eric Siedel.
2929
2930         new-run-webkit-tests: update port/base and port/webkit to use the
2931         new FileSystem and Config abstractions, pulling more logic out of
2932         the base Port classes into separate, mockable objects.
2933
2934         Also create a MockFileSystem object, a MockConfig object, move
2935         MockExecutive into common/system to be next to executive, and
2936         update the config object to use a FileSystem.
2937
2938         https://bugs.webkit.org/show_bug.cgi?id=48280
2939
2940         * Scripts/webkitpy/common/newstringio.py: Added.
2941         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2942         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2943         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2944         * Scripts/webkitpy/layout_tests/port/base.py:
2945         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2946         * Scripts/webkitpy/layout_tests/port/config.py:
2947         * Scripts/webkitpy/layout_tests/port/config_mock.py:
2948         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2949         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2950         * Scripts/webkitpy/layout_tests/port/webkit.py:
2951         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2952         * Scripts/webkitpy/tool/mocktool.py:
2953
2954 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2955
2956         Unreviewed, build breakage.
2957
2958         Apparently I uploaded the wrong version of the file to fix 49122
2959         and neither Eric or I noticed - it was missing a dirname() call.
2960         Fixing ...
2961
2962         https://bugs.webkit.org/show_bug.cgi?id=49122
2963
2964         * Scripts/webkitpy/common/checkout/scm.py:
2965
2966 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2967
2968         Reviewed by Eric Seidel.
2969
2970         webkitpy/tool/* unittests change cwd and don't clean up properly
2971
2972         https://bugs.webkit.org/show_bug.cgi?id=49122
2973
2974         * Scripts/webkitpy/common/checkout/scm.py:
2975
2976 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2977
2978         Reviewed by Simon Fraser.
2979
2980         suspendAnimations/resumeAnimations not present in WebKit2
2981         https://bugs.webkit.org/show_bug.cgi?id=49109
2982
2983         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2984         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2985         (WTR::LayoutTestController::suspendAnimations):
2986         (WTR::LayoutTestController::resumeAnimations):
2987         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2988
2989 2010-11-05  Tony Chang  <tony@chromium.org>
2990
2991         Reviewed by David Levin.
2992
2993         cleanup style in TestNetscapePlugIn/PluginObject.cpp
2994         https://bugs.webkit.org/show_bug.cgi?id=49044
2995
2996         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2997         (getPluginClass):
2998         (pluginGetProperty):
2999         (pluginSetProperty):
3000         (variantToIdentifier):
3001         (testCallback):
3002         (getURL):
3003         (getURLNotify):
3004         (testInvokeDefault):
3005         (testGetProperty):
3006         (testDocumentOpen):
3007         (testWindowOpen):
3008         (pluginInvoke):
3009         (handleCallback):
3010         (notifyStream):
3011         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3012
3013 2010-11-05  Eric Seidel  <eric@webkit.org>
3014
3015         Reviewed by David Levin.
3016
3017         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3018         https://bugs.webkit.org/show_bug.cgi?id=49032
3019
3020         I wrote this file as part of bug 47847, but I forgot to commit it.
3021         No one else noticed it missing because test-webkitpy knows how
3022         to recover in the case where it can't import QueueStatusServer
3023         (which generally occurs due to not having installed the AppEngine SDK).
3024
3025         * QueueStatusServer/__init__.py: Added.
3026         * QueueStatusServer/model/workitems_unittest.py:
3027          - Remove a test which fails.  This was probably landed (by me)
3028            from my other machine, which since this __init__.py was missing
3029            I never noticed the failure and landed this invalid test.
3030            Sadly we can't really test remove_work_item as it depends
3031            on .key() working.  .key() will throw unless the object
3032            has already been saved it seems.
3033            This may be a mis-design in our remove_work_item implementation,
3034            but for now, just removing the test.
3035
3036 2010-11-04  Adam Roben  <aroben@apple.com>
3037
3038         Teach check-webkit-style about TestNetscapePlugIn
3039
3040         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3041         TestNetscapePlugIn's coding conventions
3042
3043         Reviewed by John Sullivan.
3044
3045         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3046         WebKitAPITest and TestWebKitAPI in having different include order and
3047         naming conventions than WebCore. Added some comments about why the
3048         exceptions exist.
3049
3050 2010-11-04  Adam Roben  <aroben@apple.com>
3051
3052         Add a test that shows that windowed plugins are able to paint
3053
3054         Somehow we never had a test for this before.
3055
3056         Fixes <http://webkit.org/b/49029> Should add a test that shows
3057         windowed plugins can paint
3058
3059         Reviewed by Jon Honeycutt.
3060
3061         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3062         (DrawsGradient::DrawsGradient):
3063         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3064
3065         (DrawsGradient::onPaint):
3066         (DrawsGradient::onPrintClient):
3067         These both just call through to paint.
3068
3069         (DrawsGradient::paint): Fills our client area with some gradients.
3070
3071         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3072         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3073
3074         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3075         (createBitmapContextFromWebView): Use WM_PRINT instead of
3076         WM_PRINTCLIENT so that ::DefWindowProc will send
3077         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3078         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3079         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3080         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3081         will run on a big-endian platform.
3082
3083 2010-11-04  Adam Roben  <aroben@apple.com>
3084
3085         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3086         WindowedPluginTest base class
3087
3088         The base class takes care of subclassing the plugin's window so that a
3089         custom WNDPROC is called. This will make it easier to write tests that
3090         need to handle window messages.
3091
3092         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3093         a custom WNDPROC
3094
3095         Reviewed by Jon Honeycutt.
3096
3097         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3098         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3099         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3100         (NPNInvalidateRectInvalidatesWindow::wndProc):
3101         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3102         Moved code from here to WindowedPluginTest. Changed to use window()
3103         instead of m_window.
3104
3105         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3106         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3107         include path. Also reordered the include path to make a little more
3108         sense and simplified the entry that added TestNetscapePlugIn itself to
3109         the include path.
3110
3111         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3112         (WindowedPluginTest::WindowedPluginTest):
3113         (WindowedPluginTest::NPP_SetWindow):
3114         (WindowedPluginTest::staticWndProc):
3115         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3116         (WindowedPluginTest::window):
3117         Code came from NPNInvalidateRectInvalidatesWindow.
3118
3119 2010-11-04  Adam Roben  <aroben@apple.com>
3120
3121         Add a plugin test to show that windowed plugins are clipped correctly
3122
3123         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3124         plugins aren't clipped in WebKit2 on Windows
3125
3126         Reviewed by Jon Honeycutt.
3127
3128         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3129         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3130         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3131         region matches the clip rect we know we should have based on
3132         window-region-is-set-to-clip-rect.html, and check that our window class
3133         doesn't have the CS_PARENTDC style.
3134
3135         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3136         Added WindowRegionIsSetToClipRect.
3137
3138 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3139
3140         Reviewed by Martin Robinson.
3141
3142         [GTK] Avoid font hinting in the DRT
3143         https://bugs.webkit.org/show_bug.cgi?id=48548
3144
3145         Change the settings to avoid font hinting, it was causing
3146         different results depending on the distribution.
3147
3148         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3149         (initializeGtkFontSettings):
3150         * DumpRenderTree/gtk/fonts/fonts.conf:
3151
3152 2010-11-05  Eric Seidel  <eric@webkit.org>
3153
3154         Reviewed by Adam Barth.
3155
3156         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3157         https://bugs.webkit.org/show_bug.cgi?id=49051
3158
3159         This is a speculative fix.  The unit tests cover these methods, however
3160         I don't know if this will fully stop the system.log spam.
3161
3162         * Scripts/webkitpy/layout_tests/port/base.py:
3163         * Scripts/webkitpy/layout_tests/port/webkit.py:
3164
3165 2010-11-05  Eric Seidel  <eric@webkit.org>
3166
3167         Reviewed by Adam Barth.
3168
3169         Add basic support for showing bot id on /queue-status/ pages
3170         https://bugs.webkit.org/show_bug.cgi?id=49037
3171
3172         This support is really simple.  Eventually we'll want to
3173         show the bot id in the lock table too, but we don't have
3174         that information stored in the server yet.
3175
3176         * QueueStatusServer/handlers/queuestatus.py:
3177         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3178         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3179
3180 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3181
3182         Reviewed by Adam Barth.
3183
3184         Create a filesystem wrapper that we can use to enforce
3185         particular conventions and use for mocking and dependency
3186         injection down the line.
3187
3188         https://bugs.webkit.org/show_bug.cgi?id=48144
3189
3190         * Scripts/webkitpy/common/system/filesystem.py: Added.
3191         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3192
3193 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3194
3195         Reviewed by Tony Chang.
3196
3197         run_webkit_tests_unittest fails under Python 2.5
3198         https://bugs.webkit.org/show_bug.cgi?id=49043
3199         
3200         Switch from itertools.chain.from_iterable (which was added in 2.6)
3201         to using itertools.chain directly.
3202
3203         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3204
3205 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3206
3207         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3208         Python 2.5 (it needs an import to use the with statement).
3209
3210         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3211
3212 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3213
3214         Reviewed by Adam Barth.
3215
3216         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3217
3218         The current NRWT code has webkit-specific configuration code (like
3219         _script_path, default configuration, etc.) mixed in with
3220         layout-test-specific stuff in port/base. The configuration code
3221         should be split out into a separate module for easier mocking,
3222         testing, and isolation.
3223
3224         https://bugs.webkit.org/show_bug.cgi?id=48264
3225
3226         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3227         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3228
3229 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3230
3231         Reviewed by Tony Chang.
3232
3233         Rebaseline server: initial framework
3234         https://bugs.webkit.org/show_bug.cgi?id=48892
3235         
3236         Adds the basic framework for the rebaseline server (details at 
3237         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3238         command, which starts an HTTP server that can serve static files or
3239         invoke handler methods on a class.
3240
3241         * Scripts/webkitpy/tool/commands/__init__.py:
3242         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3243         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3244         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3245         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3246
3247 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3248
3249         Reviewed by James Robinson.
3250
3251         new-run-webkit-tests wasn't using DRT by default for
3252         --platform chromium-gpu
3253
3254         The default value was set to False instead of None, which meant
3255         that the platform specific logic wasn't firing to change the
3256         value to True (b/c we were afraid we'd be overriding the user
3257         preference).
3258
3259         https://bugs.webkit.org/show_bug.cgi?id=49038
3260
3261         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3262
3263 2010-11-04  Tony Chang  <tony@chromium.org>
3264
3265         Reviewed by Adam Barth.
3266
3267         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3268         https://bugs.webkit.org/show_bug.cgi?id=49026
3269
3270         Have the testObject.bar property return the string "bar".  This lets
3271         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3272         platforms.
3273
3274         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3275         (testGetProperty):
3276
3277 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3278
3279         Reviewed by Tony Chang.
3280
3281         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3282         https://bugs.webkit.org/show_bug.cgi?id=48878
3283         
3284         Add get_tests_run so that it's easy to see which tests get run (and with
3285         what batching) for a given flag combination. Flesh out the various
3286         test cases that have FIXMEs.
3287         
3288         Also fixes an off-by-one error (batch sizes were one larger than 
3289         expected) and makes --run-part also have wraparound behavior, like
3290         --run-chunk.
3291
3292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3293         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3294         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3295
3296 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3297
3298         Reviewed by Dimitri Glazkov.
3299
3300         Support box-sizing without the vendor prefix
3301         https://bugs.webkit.org/show_bug.cgi?id=36713
3302
3303         Based on patch by Peter Beverloo <peter@lvp-media.com>
3304
3305         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3306
3307 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3308
3309         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3310
3311         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3312         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3313
3314 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3315
3316         Reviewed by Ojan Vafai.
3317
3318         Make http locking default in NRWT.
3319         https://bugs.webkit.org/show_bug.cgi?id=48053
3320
3321         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3322         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3323
3324 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3325
3326         Reviewed by Eric Seidel.
3327
3328         [NRWT] Clear invalid http locks on Windows platform as well
3329         https://bugs.webkit.org/show_bug.cgi?id=48515
3330
3331         * Scripts/webkitpy/common/system/executive.py:
3332         * Scripts/webkitpy/common/system/executive_unittest.py:
3333         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3334
3335 2010-11-02  Adam Roben  <aroben@apple.com>
3336
3337         Reduce our dependence on coreutils when running Python tests
3338
3339         This patch introduces versions of the standard echo and cat utilities
3340         implemented in Python. They are probably missing features of their
3341         coreutils equivalents, but they can do what's necessary for our Python
3342         tests. This is useful on Windows, where these utilities typically
3343         aren't available.
3344
3345         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3346         and cat utilities from coreutils, which are not present on Windows
3347
3348         Reviewed by Eric Seidel.
3349
3350         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3351         our Python-based echo and cat.
3352
3353         * Scripts/webkitpy/common/system/fileutils.py: Added.
3354         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3355         that \n won't be translated into \r\n. I couldn't think of a good way
3356         to test this directly without touching the filesystem, but it is tested
3357         indirectly by echo_unittest.
3358
3359         * Scripts/webkitpy/test/cat.py: Added.
3360         (command_arguments): Returns a list for invoking cat with the given arguments.
3361         (main): Acts like a simplified version of the coreutils cat utility.
3362
3363         * Scripts/webkitpy/test/cat_unittest.py: Added.
3364         (CatTest.assert_cat): Runs cat with the given input and ensures the
3365         output matches the input.
3366         (CatTest.test_basic): Performs a simple test of cat.
3367         (CatTest.test_no_newline): Tests what happens when the input string
3368         doesn't have a trailing newline.
3369         (CatTest.test_unicode): Tests passing a unicode string to cat.
3370         (CatTest.test_as_command): Tests running cat as a separate command.
3371
3372         * Scripts/webkitpy/test/echo.py: Added.
3373         (command_arguments): Returns a list for invoking echo with the given arguments.
3374         (main): Acts like a simplified version of the coreutils echo utility.
3375
3376         * Scripts/webkitpy/test/echo_unittest.py: Added.
3377         (EchoTest.test_basic): Performs a simple test of echo.
3378         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3379         trailing newline.
3380         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3381         to echo.
3382         (EchoTest.test_argument_order): Tests what happens when -n is not the
3383         first argument.
3384         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3385         echo.main.
3386         (EchoTest.test_no_arguments): Tests what happens when you call
3387         echo.main with no arguments.
3388         (EchoTest.test_as_command): Tests running echo as a separate command.
3389
3390 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3391
3392         Unreviewed: Add myself to the list of Committers.
3393
3394         * Scripts/webkitpy/common/config/committers.py:
3395
3396 2010-11-04  Andreas Kling  <kling@webkit.org>
3397
3398         Reviewed by Kenneth Rohde Christiansen.
3399
3400         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3401
3402         In RTC mode the QGraphicsWebView item is the size of the contents,
3403         scrolling works a bit differently  (we need to react to scrollRequested.)
3404
3405         Normally QGraphicsView will replay the last mouse event when scrolling,
3406         so to prevent WebKit from getting confused by this we temporarily make
3407         the QGraphicsView non-interactive.
3408
3409         * QtTestBrowser/webview.cpp:
3410         (WebViewGraphicsBased::setPage):
3411         (WebViewGraphicsBased::scrollRequested):
3412         * QtTestBrowser/webview.h:
3413
3414 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3415
3416         Reviewed by Andreas Kling.
3417
3418         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3419
3420         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3421         the Mac-port, not the Mac OS X operating system.
3422
3423         * WebKitTestRunner/qt/TestControllerQt.cpp:
3424         (WTR::isExistingLibrary):
3425
3426 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3427
3428         Reviewed by Andreas Kling.
3429
3430         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3431         https://bugs.webkit.org/show_bug.cgi?id=48869
3432
3433         * QtTestBrowser/useragentlist.txt:
3434
3435 2010-11-03  Adam Roben  <aroben@apple.com>
3436
3437         Always use uppercase drive names in strings returned by abspath_to_uri
3438
3439         Some versions of cygpath use lowercase drive letters while others use
3440         uppercase, which makes it hard to test the output of code that uses
3441         cygpath.
3442
3443         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3444         fails with Cygwin 1.5
3445
3446         Reviewed by Eric Seidel.
3447
3448         * Scripts/webkitpy/common/system/path.py:
3449         (cygpath): Updated the docstring to indicate that only absolute paths
3450         should be passed for now (though relative paths will work fine).
3451         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3452
3453 2010-11-03  George Guo  <George.Guo@Nokia.com>
3454
3455         Reviewed by Andreas Kling.
3456
3457         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3458         https://bugs.webkit.org/show_bug.cgi?id=48767
3459     
3460         Paging is needd on Symbian devices to support benchmarks tests like
3461         dromaeo.com and Celtic Kane that need a lot of memory to run  
3462
3463         * QtTestBrowser/QtTestBrowser.pro:
3464
3465 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3466
3467         Reviewed by Dmitry Titov.
3468
3469         Chromium: Update resource tracking when moving a frame between documents
3470         https://bugs.webkit.org/show_bug.cgi?id=48363
3471
3472         * DumpRenderTree/chromium/WebViewHost.cpp:
3473         (WebViewHost::assignIdentifierToRequest):
3474         Always put resource id in map so we can make assumptions about its
3475         presence.
3476         (WebViewHost::removeIdentifierForRequest):
3477         Added.
3478         (WebViewHost::didFinishResourceLoad):
3479         (WebViewHost::didFailResourceLoad):
3480         Check existence of resource id before removing from map.
3481         * DumpRenderTree/chromium/WebViewHost.h:
3482
3483 2010-11-03  Victor Wang  <victorw@chromium.org>
3484
3485         Reviewed by Adam Barth.
3486
3487         [Chromium] update buildbot names in chromium rebaseline tool.
3488
3489         https://bugs.webkit.org/show_bug.cgi?id=48881
3490
3491         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3492
3493 2010-11-03  Darin Adler  <darin@apple.com>
3494
3495         Updated Xcode projects by opening them with Xcode 3.2.4.
3496         Updated svn:ignore for Xcode projects.
3497
3498         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3499         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3500         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3501         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3502
3503 2010-11-03  Adam Roben  <aroben@apple.com>
3504
3505         Stop waiting for messages from the web process after a timeout elapses
3506
3507         TestController::runUntil now takes a timeout parameter that specifies
3508         how long to wait for the condition to become true. WebKitTestRunner
3509         takes a --timeout flag that specifies how long the timeout should be.
3510         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3511         will be similar to run-webkit-tests.
3512
3513         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3514         WebKitTestRunner waits forever if the web process crashes
3515
3516         Reviewed by Darin Adler and Anders Carlsson.
3517
3518         * Scripts/old-run-webkit-tests:
3519         (top level): Moved the GuardMalloc timeout adjustment here from
3520         readFromDumpToolWithTimer.
3521         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3522         than the one that was specified on the command line.
3523
3524         * WebKitTestRunner/TestController.cpp:
3525         (WTR::TestController::TestController): Initialize our timeout values.
3526         (WTR::TestController::initialize): Parse the --timeout flag and use it
3527         to modify our timeout values.
3528         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3529         short timeout while waiting for the web process to reset and to return
3530         a boolean indicating whether we were able to reset the web process.
3531         Uses a 5-second timeout while waiting for the process to be reset.
3532         (WTR::TestController::runTest): Changed to return a boolean indicating
3533         whether we were able to reset the web process (and thus run the test).
3534         (WTR::TestController::runUntil): Call through to platformRunUntil.
3535
3536         (WTR::TestController::runTestingServerLoop):
3537         (WTR::TestController::run):
3538         Changed to bail if any test can't be run. This will cause the process
3539         to exit. (Unfortunately this will make run-webkit-tests think we
3540         crashed; see <http://webkit.org/b/48943>.)
3541
3542         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3543         m_longTimeout, and m_shortTimeout.
3544
3545         * WebKitTestRunner/TestInvocation.cpp:
3546         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
3547         initial response and a long timeout when waiting for the test to
3548         complete. Check whether runUntil timed out and print an error message
3549         if so.
3550
3551         * WebKitTestRunner/mac/TestControllerMac.mm:
3552         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
3553         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
3554         won't block waiting for the run loop. Only loop until the timeout
3555         elapses.
3556
3557         * WebKitTestRunner/qt/TestControllerQt.cpp:
3558         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
3559         FIXME about honoring the timeout.
3560
3561         * WebKitTestRunner/win/TestControllerWin.cpp:
3562         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
3563         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
3564         ::PeekMessageW so that we don't block waiting for messages to become
3565         available.
3566
3567 2010-11-03  Adam Roben  <aroben@apple.com>
3568
3569         Add a plugin test that evaluates JS after removing the plugin element
3570         from the document
3571
3572         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
3573         That test was made to prevent a crash very similar to this one, but
3574         unfortunately tested only the mechanism that prevented the crash and
3575         not whether the crash itself was prevented. Since WebKit2 uses a
3576         different mechanism to prevent the crash, the test was failing even
3577         though WebKit2 was not vulnerable to the crash. This new test crashes
3578         if there is no mechanism in place&