49f6afe8ae27e0d6892884b1afba739e314b2627
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-16  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Add a hidden land-cowboy command to webkit-patch to help land quick
6         build fixes.
7
8         * Scripts/webkitpy/tool/commands/download.py:
9         * Scripts/webkitpy/tool/steps/preparechangelog.py:
10
11 2010-06-16  Adam Roben  <aroben@apple.com>
12
13         Convert console messages to UTF-8 before printing them
14
15         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
16         http/tests/security/xssAuditor/embed-tag-null-char.html and
17         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
18         Windows. (I can't test the fix because Apache is crashing on my
19         computer.)
20
21         Reviewed by Alexey Proskuryakov.
22
23         * DumpRenderTree/win/DumpRenderTree.cpp:
24         (toUTF8): Extracted the code into an overload that takes a wide string
25         and a length, then added an overload that takes a wstring.
26
27         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
28         overload.
29
30         * DumpRenderTree/win/UIDelegate.cpp:
31         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
32         UTF-8 instead of letting printf convert to the current code page.
33
34 2010-06-16  Drew Wilson  <atwilson@chromium.org>
35
36         Reviewed by Kent Tamura.
37
38         [Chromium] Plumbing for top-level frame names
39         https://bugs.webkit.org/show_bug.cgi?id=40430
40
41         * DumpRenderTree/chromium/WebViewHost.cpp:
42         (WebViewHost::createView):
43         Migrate to new createView() API.
44         * DumpRenderTree/chromium/WebViewHost.h:
45         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
46
47 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
48
49         Reviewed by Kenneth Rohde Christiansen.
50
51         [Qt] Scroll wheel event support to graphics based DRT
52         https://bugs.webkit.org/show_bug.cgi?id=40577
53
54         * DumpRenderTree/qt/EventSenderQt.cpp:
55         (EventSender::continuousMouseScrollBy):
56         (EventSender::createGraphicsSceneWheelEvent):
57         * DumpRenderTree/qt/EventSenderQt.h:
58
59 2010-06-16  Adam Roben  <aroben@apple.com>
60
61         Remove a stray newline from the Windows version of TestNetscapePlugin
62
63         Reviewed by Alexey Proskuryakov.
64
65         Fixes <http://webkit.org/b/40728>
66         plugins/geturlnotify-during-document-teardown.html fails on Windows
67
68         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
69         (NPP_Destroy): Removed extra newline that the Mac version doesn't
70         have.
71
72 2010-06-16  Adam Roben  <aroben@apple.com>
73
74         Respect LayoutTestController::isPrinting on Windows
75
76         This gets some printing tests closer to passing (like
77         printing/page-rule-in-media-query.html).
78
79         Fixes <http://webkit.org/b/40727>.
80
81         Reviewed by Dan Bernstein.
82
83         * DumpRenderTree/win/DumpRenderTree.cpp:
84         (dump): Pass LayoutTestController::isPrinting to
85         IWebFramePrivate::renderTreeAsExternalRepresentation.
86
87 2010-06-15  Adam Barth  <abarth@webkit.org>
88
89         Reviewed by Eric Seidel.
90
91         Enable HTML5 lexer
92         https://bugs.webkit.org/show_bug.cgi?id=40650
93
94         * DumpRenderTree/mac/DumpRenderTree.mm:
95         (initializeGlobalsFromCommandLineOptions):
96
97 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
98
99         Reviewed by Shinichiro Hamaji.
100
101         Implement render style selection for pages to support CSS3 Paged Media.
102         https://bugs.webkit.org/show_bug.cgi?id=35961
103
104         * DumpRenderTree/LayoutTestController.cpp:
105         (parsePagePropertyParameters):
106         (pagePropertyCallback):
107         (LayoutTestController::staticFunctions):
108         * DumpRenderTree/LayoutTestController.h:
109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
110         (LayoutTestController::pageProperty):
111         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
112         (LayoutTestController::pageProperty):
113         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
114         (LayoutTestController::pageProperty):
115
116 2010-06-15  Sam Weinig  <sam@webkit.org>
117
118         Reviewed by Anders Carlsson.
119
120         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
121         WebKit2: Add mechanism to inject code into the WebProcess on startup
122
123         Add initial InjectedBundle support.
124
125         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
126         * MiniBrowser/WebBundle-Info.plist: Added.
127         Add test InjectedBundle to the project.
128
129         * MiniBrowser/mac/AppDelegate.m:
130         (-[BrowserAppDelegate init]):
131         Get the path to the WebBundle from the the main bundle and pass it to the new
132         WKContextCreateWithInjectedBundlePath function.
133
134         * MiniBrowser/mac/BrowserWindowController.m:
135         (_didChangeProgress):
136         Fix the build.  This has been broken for a while.
137
138         * MiniBrowser/mac/WebBundle: Added.
139         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
140         (_didCreatePage):
141         (WKBundleInitialize):
142         Add really basic InjectedBundle.
143
144         * MiniBrowser/win/BrowserView.cpp:
145         (BrowserView::create):
146         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
147
148 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
149
150         Reviewed by Darin Adler.
151
152         Adding myself to the reviewers list.
153         https://bugs.webkit.org/show_bug.cgi?id=40693
154
155         * Scripts/webkitpy/common/config/committers.py:
156
157 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
158
159         Reviewed by Xan Lopez.
160
161         Switch to using GIO methods instead of realpath in GtkLauncher to determine
162         the file URI. This should remove warnings about realpath being undefined
163         when compiling with '-ansi'.
164
165         * GtkLauncher/main.c:
166         (filenameToURL): Use GIO instead of realpath to determine file URI.
167
168 2010-06-15  Adam Roben  <aroben@apple.com>
169
170         Remove the redundant set-apple-windows-environment-variables script
171
172         Apparently update-webkit does this for you these days.
173
174         Rubber-stamped by Steve Falkenburg.
175
176         * Scripts/set-apple-windows-environment-variables: Removed.
177
178 2010-06-14  Adam Roben  <aroben@apple.com>
179
180         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
181         environment variables
182
183         Fixes <http://webkit.org/b/40595>.
184
185         Reviewed by Steve Falkenburg.
186
187         * Scripts/set-apple-windows-environment-variables: Added.
188         (to_windows_path): Passes the passed-in path through cygpath to
189         generate a Windows-style path.
190         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
191         variables to their defaults, if they aren't already set.
192
193 2010-06-14  Adam Roben  <aroben@apple.com>
194
195         Speed up run-safari/debug-safari on Windows
196
197         Fixes <http://webkit.org/b/40586>.
198
199         Reviewed by Steve Falkenburg.
200
201         * Scripts/webkitdirs.pm:
202         (runSafari): When debugging, set up the environment to run Safari
203         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
204         actually launch the debugger. When not debugging, just run WebKit.exe
205         and it will do the rest for us.
206
207 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
208
209         Reviewed by Kenneth Rohde Christiansen.
210
211         [Qt] DRT EventSender support to graphics context events
212         https://bugs.webkit.org/show_bug.cgi?id=40324
213
214         * DumpRenderTree/qt/EventSenderQt.cpp:
215         (EventSender::contextClick):
216
217 2010-06-14  Tony Chang  <tony@chromium.org>
218
219         Reviewed by Darin Fisher.
220
221         [chromium] checkout chromium third_party directly
222         https://bugs.webkit.org/show_bug.cgi?id=40556
223
224         * Scripts/update-webkit-chromium: some migration code for the bots
225
226 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
227
228         Chromium build fix.
229
230         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
231         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
232
233 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
234
235         Reviewed by Darin Adler.
236
237         https://bugs.webkit.org/show_bug.cgi?id=40529
238         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
239
240         * DumpRenderTree/mac/EventSendingController.mm:
241         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
242         event for "delete" - it had virtual key code from forward delete, and text from backspace.
243         Fixed "delete" to mean forward delete.
244
245         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
246         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
247         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
248         Mac DRT confusion has propagated to other platforms, fixing those.
249
250 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
251
252         Reviewed by Xan Lopez.
253
254         Small GtkLauncher build fix for some systems.
255
256         * GtkLauncher/main.c: Add <limit.h> include.
257
258 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
259
260         Reviewed by Laszlo Gombos.
261
262         [Qt] navigator.geolocation support for Qt port
263         https://bugs.webkit.org/show_bug.cgi?id=39724
264
265         Implementation for geolocation cases to DumpRenderTreeQt
266
267         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
268         (WebCore::WebPage::allowGeolocationRequest):
269         * DumpRenderTree/qt/DumpRenderTreeQt.h:
270         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
271         (LayoutTestController::setGeolocationPermission):
272         (LayoutTestController::setMockGeolocationError):
273         (LayoutTestController::setMockGeolocationPosition):
274         * DumpRenderTree/qt/LayoutTestControllerQt.h:
275         (LayoutTestController::isGeolocationPermissionSet):
276         (LayoutTestController::geolocationPermission):
277
278 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
279
280         Reviewed by Darin Adler.
281
282         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
283         be a way of overwriting the Xcode system path.  Making
284         $WEBKITOUTPUTDIR take precedence over the system default would make
285         this possible.
286
287         * Scripts/webkitdirs.pm:
288
289 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
290
291         Reviewed by Darin Adler.
292
293         AX: link won't return linked element if URL contains #
294         https://bugs.webkit.org/show_bug.cgi?id=40192
295
296         * DumpRenderTree/AccessibilityUIElement.cpp:
297         (linkedUIElementAtIndexCallback):
298         (AccessibilityUIElement::getJSClass):
299         * DumpRenderTree/AccessibilityUIElement.h:
300         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
301         (AccessibilityUIElement::linkedUIElementAtIndex):
302         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
303         (AccessibilityUIElement::linkedUIElementAtIndex):
304         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
305         (AccessibilityUIElement::linkedUIElementAtIndex):
306
307 2010-06-13  Adam Barth  <abarth@webkit.org>
308
309         Reviewed by Darin Adler.
310
311         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
312         https://bugs.webkit.org/show_bug.cgi?id=39550
313
314         This can cause an extra request to bugs.webkit.org durig upload, but it
315         shouldn't be too bad.  Also, this won't work if you remove the
316         boilerplate created by prepare-ChangeLog.
317
318         * Scripts/webkitpy/common/checkout/changelog.py:
319         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
320         * Scripts/webkitpy/common/net/bugzilla.py:
321         * Scripts/webkitpy/tool/steps/abstractstep.py:
322         * Scripts/webkitpy/tool/steps/preparechangelog.py:
323         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
324
325 2010-06-08  Robert Hogan  <robert@webkit.org>
326
327         Reviewed by Eric Seidel.
328
329         [Qt] Add support for callShouldCloseOnWebView() to DRT
330         https://bugs.webkit.org/show_bug.cgi?id=40330
331
332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
333         (LayoutTestController::callShouldCloseOnWebView):
334         * DumpRenderTree/qt/LayoutTestControllerQt.h:
335         (LayoutTestController::setCallCloseOnWebViews):
336
337 2010-06-12  Eric Seidel  <eric@webkit.org>
338
339         Reviewed by Daniel Bates.
340
341         do-webcore-rename should have a --verbose option
342         https://bugs.webkit.org/show_bug.cgi?id=40497
343
344         * Scripts/do-webcore-rename:
345          - Unified how we handle skipping files/directories
346            this will allow us to "black list" certain files and
347            directories when performing renames.
348          - Made do-webcore-rename log what it's skipping when passed --verbose.
349
350 2010-06-12  Darin Adler  <darin@apple.com>
351
352         * Scripts/run-bindings-tests: Fixed a typo in a message.
353
354 2010-06-12  Kent Tamura  <tkent@chromium.org>
355
356         Reviewed by Dimitri Glazkov.
357
358         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
359         https://bugs.webkit.org/show_bug.cgi?id=40402
360
361         _build_path() of each Chromium port check existence of build path
362         of Chromium checkout first, then check existence of build path of
363         WebKit-only checkout.
364
365         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
366         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
367         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
368
369 2010-06-12  Robert Hogan  <robert@webkit.org>
370
371         Reviewed by Kenneth Rohde Christiansen.
372
373         [Qt] Back-forward list dumping is incorrect
374
375         https://bugs.webkit.org/show_bug.cgi?id=36392
376
377         Support dumping child history items in DRT.
378
379         Unskip:
380
381         fast/loader/frame-src-change-added-to-history.html
382         fast/loader/frame-src-change-not-added-to-history.html
383         fast/loader/frame-location-change-not-added-to-history.html
384
385         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
386         (WebCore::dumpHistoryItem):
387
388 2010-06-10  Ojan Vafai  <ojan@chromium.org>
389
390         Reviewed by Eric Seidel.
391
392         upload all patches that lack in-rietveld to rietveld
393         https://bugs.webkit.org/show_bug.cgi?id=40444
394
395         If it's a patch, then we'll try to upload it as long as it
396         doesn't have in-rietveld set. No longer set in-rietveld? since
397         it's not needed.
398
399         * Scripts/webkitpy/common/net/bugzilla.py:
400
401 2010-06-10  Ojan Vafai  <ojan@chromium.org>
402
403         Reviewed by Darin Fisher.
404
405         Fix rietveld upload when message length > 100 characters
406         https://bugs.webkit.org/show_bug.cgi?id=40457
407
408         * Scripts/webkitpy/common/net/rietveld.py:
409
410 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
411
412         Reviewed by Laszlo Gombos.
413
414         [Qt] There should be a way to enable popups in QtTestBrowser
415         https://bugs.webkit.org/show_bug.cgi?id=40427
416
417         * QtTestBrowser/main.cpp:
418         (LauncherWindow::toggleJavascriptCanOpenWindows):
419         (LauncherWindow::createChrome):
420
421 2010-06-10  Adam Barth  <abarth@webkit.org>
422
423         Reviewed by Daniel Bates.
424
425         Make SheriffBot more chatty
426         https://bugs.webkit.org/show_bug.cgi?id=40463
427
428         People seem to like to talk to SheriffBot, so let's make him chat back.
429
430         * Scripts/webkitpy/thirdparty/__init__.py:
431         * Scripts/webkitpy/tool/bot/irc_command.py:
432         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
433         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
434         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
435
436 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
437
438         Reviewed by Darin Adler.
439
440         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
441         
442         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
443         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
444         WEXITSTATUS on $result instead of just comparing $result to 0.
445
446         * Scripts/update-webkit-auxiliary-libs:
447
448 2010-06-10  Ojan Vafai  <ojan@chromium.org>
449
450         Reviewed by Alexey Proskuryakov.
451
452         don't use Exception.message as it's deprecated in python 2.6+
453         https://bugs.webkit.org/show_bug.cgi?id=40449
454
455         * Scripts/webkitpy/tool/commands/queues.py:
456
457 2010-06-10  Ojan Vafai  <ojan@chromium.org>
458
459         Reviewed by Adam Barth.
460
461         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
462         https://bugs.webkit.org/show_bug.cgi?id=40436
463
464         * Scripts/webkitpy/common/system/outputcapture.py:
465         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
466         * Scripts/webkitpy/tool/commands/queues.py:
467         * Scripts/webkitpy/tool/commands/queues_unittest.py:
468         * Scripts/webkitpy/tool/commands/queuestest.py:
469         * Scripts/webkitpy/tool/mocktool.py:
470
471 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
472
473         Reviewed by Simon Hausmann.
474
475         [Qt] *All* WebGL layout tests fail!
476         https://bugs.webkit.org/show_bug.cgi?id=40296
477
478         Added test for WebKitWebGLEnabled to
479         LayoutTestController::overridePreference().
480
481         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
482         (LayoutTestController::overridePreference):
483
484 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
485
486         Reviewed by Kenneth Rohde Christiansen.
487
488         [Qt] DRT EventSender support to graphics mouse events activation
489         https://bugs.webkit.org/show_bug.cgi?id=40017
490
491         * DumpRenderTree/qt/EventSenderQt.cpp:
492         (EventSender::mouseDown):
493         (EventSender::mouseUp):
494         (EventSender::mouseMoveTo):
495         (EventSender::keyDown):
496         (EventSender::contextClick):
497         (EventSender::sendTouchEvent):
498         (EventSender::sendOrQueueEvent):
499         (EventSender::eventFilter):
500         (EventSender::createGraphicsSceneMouseEvent):
501         (EventSender::sendEvent):
502         * DumpRenderTree/qt/EventSenderQt.h:
503         (EventSender::isGraphicsBased):
504
505 2010-06-09  Adam Barth  <abarth@webkit.org>
506
507         Reviewed by Ojan Vafai.
508
509         webkit-patch upload fails for security bugs because there's no rietveld flag
510         https://bugs.webkit.org/show_bug.cgi?id=40309
511
512         There's probably a more elegant way of seeing whether the form control
513         exists, but this seems to work.
514
515         * Scripts/webkitpy/common/net/bugzilla.py:
516
517 2010-06-09  Ojan Vafai  <ojan@chromium.org>
518
519         Reviewed by Adam Barth.
520
521         make rietveld upload faster and avoid posting to bug on errors
522         https://bugs.webkit.org/show_bug.cgi?id=40389
523
524         Only grab the first item of the upload queue instead of trying
525         to compute the whole list upfront (which is O(n) bugzilla lookups!).
526
527         Also, don't post comments to the bug when uploading fails.
528
529         * Scripts/webkitpy/common/net/bugzilla.py:
530         * Scripts/webkitpy/tool/commands/queues.py:
531         * Scripts/webkitpy/tool/commands/queues_unittest.py:
532         * Scripts/webkitpy/tool/commands/stepsequence.py:
533         * Scripts/webkitpy/tool/mocktool.py:
534
535 2010-06-09  Ojan Vafai  <ojan@chromium.org>
536
537         Reviewed by Adam Barth.
538
539         Rietveld upload queue fails when setting in-rietveld flag
540         https://bugs.webkit.org/show_bug.cgi?id=40371
541
542         Make the comment arguments to set_flag_on_attachment optional
543         and add it to the MockBugzilla.
544
545         * Scripts/webkitpy/common/net/bugzilla.py:
546         * Scripts/webkitpy/tool/bot/queueengine.py:
547         * Scripts/webkitpy/tool/commands/download_unittest.py:
548         * Scripts/webkitpy/tool/commands/queues.py:
549         * Scripts/webkitpy/tool/commands/queues_unittest.py:
550         * Scripts/webkitpy/tool/mocktool.py:
551
552 2010-06-09  Kenneth Russell  <kbr@google.com>
553
554         Reviewed by Dimitri Glazkov.
555
556         Rename FloatArray to Float32Array
557         https://bugs.webkit.org/show_bug.cgi?id=40323
558
559         Used do-webcore-rename to perform renaming. Manually undid
560         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
561         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
562         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
563         all layout tests on Safari; built Chromium and ran selected WebGL
564         tests.
565
566         * Scripts/do-webcore-rename:
567
568 2010-06-08  Tony Chang  <tony@chromium.org>
569
570         Reviewed by David Levin.
571
572         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
573         https://bugs.webkit.org/show_bug.cgi?id=40285
574
575         * Scripts/webkitdirs.pm:
576         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
577
578 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
579
580         Reviewed by Tamura Kent.
581
582         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
583         https://bugs.webkit.org/show_bug.cgi?id=40052
584         
585         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
586
587         * DumpRenderTree/DumpRenderTree.gypi:
588         * DumpRenderTree/chromium/TestShellWin.cpp:
589         (platformInit):
590         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
591         (WebKit::):
592         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
593         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
594         (WebKit::WebThemeControlDRT::box):
595         (WebKit::WebThemeControlDRT::line):
596         (WebKit::WebThemeControlDRT::triangle):
597         (WebKit::WebThemeControlDRT::roundRect):
598         (WebKit::WebThemeControlDRT::oval):
599         (WebKit::WebThemeControlDRT::circle):
600         (WebKit::WebThemeControlDRT::nestedBoxes):
601         (WebKit::WebThemeControlDRT::markState):
602         (WebKit::WebThemeControlDRT::draw):
603         (WebKit::WebThemeControlDRT::drawTextField):
604         (WebKit::WebThemeControlDRT::drawProgressBar):
605         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
606         (WebKit::WebThemeControlDRT::):
607         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
608         (WebKit::):
609         (WebKit::WebThemeEngineDRT::paintButton):
610         (WebKit::WebThemeEngineDRT::paintMenuList):
611         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
612         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
613         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
614         (WebKit::WebThemeEngineDRT::paintTextField):
615         (WebKit::WebThemeEngineDRT::paintTrackbar):
616         (WebKit::WebThemeEngineDRT::paintProgressBar):
617         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
618         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
619
620 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
621
622         Unreviewed, rolling out r60878.
623         http://trac.webkit.org/changeset/60878
624         https://bugs.webkit.org/show_bug.cgi?id=40349
625
626         broke linux build (Requested by tony^work on #webkit).
627
628         * Scripts/webkitdirs.pm:
629         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
630
631 2010-06-08  Tony Chang  <tony@chromium.org>
632
633         Reviewed by David Levin.
634
635         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
636         https://bugs.webkit.org/show_bug.cgi?id=40285
637
638         * Scripts/webkitdirs.pm:
639         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
640
641 2010-06-08  Kenneth Russell  <kbr@google.com>
642
643         Unreviewed, build fix.
644
645         Fix build breakage from 38145
646         https://bugs.webkit.org/show_bug.cgi?id=40346
647
648         The fix for bug 38145 broke the Chromium Win build because
649         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
650         change log2(x) to log(x) / log(2). Built and ran WebGL layout
651         tests in Safari on Mac OS X. Changed download mirrors for
652         python-irclib to working ones.
653
654         * Scripts/webkitpy/thirdparty/__init__.py:
655
656 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
657
658         Reviewed by Eric Seidel.
659
660         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
661         https://bugs.webkit.org/show_bug.cgi?id=39058
662
663         * Scripts/old-run-webkit-tests:
664          use sourceDir() to find ensure-valid-python in checkPythonVersion()
665
666 2010-06-08  Andras Becsi  <abecsi@webkit.org>
667
668         Unreviewed buildfix after r60479.
669
670         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
671         versions other than 2.17.3.
672
673         * DumpRenderTree/gtk/EventSender.cpp:
674         (getRootCoords):
675
676 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
677
678         Reviewed by Oliver Hunt.
679
680         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
681         https://bugs.webkit.org/show_bug.cgi?id=40267
682
683         When a mouse button is down, automatically queue mouse motion events and
684         do not play them back until the mouse button is released. This matches the
685         behavior of other ports' EventSenders.
686
687         * DumpRenderTree/gtk/EventSender.cpp:
688         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
689         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
690
691 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
692
693         Reviewed by Sam Weinig.
694
695         Add CPP bindings generator
696         https://bugs.webkit.org/show_bug.cgi?id=38279
697
698         Integrate CPP bindings in run-bindings-tests.
699
700         * Scripts/run-bindings-tests:
701
702 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
703
704         Reviewed by Ojan Vafai.
705
706         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
707         https://bugs.webkit.org/show_bug.cgi?id=40183
708
709         * Scripts/webkitpy/tool/steps/preparechangelog.py:
710
711 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
712
713         Unreviewed.
714
715         Add my new email and IRC nick to committers.py.
716
717         * Scripts/webkitpy/common/config/committers.py:
718
719 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
720
721         Unreviewed.
722
723         Revert changes in json_results_generator.py's _get_svn_revision.
724
725         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
726
727 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
728
729         Reviewed by Xan Lopez.
730
731         [GTK] GtkLauncher should support relative file paths
732         https://bugs.webkit.org/show_bug.cgi?id=39944
733
734         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
735
736         * GtkLauncher/main.c:
737         (filename_to_url): Added.
738         (main): Try to resolve arguments as relative file URLs first.
739
740 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
741
742         Reviewed by Xan Lopez.
743
744         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
745         https://bugs.webkit.org/show_bug.cgi?id=40182
746
747         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
748         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
749         without breaking DRT.
750
751         * DumpRenderTree/gtk/EventSender.cpp:
752         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
753         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
754
755 2010-06-04  Anders Carlsson  <andersca@apple.com>
756
757         Reviewed by David Hyatt.
758
759         Make the editing/spelling/context-menu-suggestions.html test more robust
760         https://bugs.webkit.org/show_bug.cgi?id=40178
761
762         Change the contextClick method to return an array of strings describing the context menu items.
763
764         * DumpRenderTree/mac/EventSendingController.mm:
765         (+[EventSendingController isSelectorExcludedFromWebScript:]):
766         (+[EventSendingController webScriptNameForSelector:]):
767         (-[EventSendingController contextClick]):
768
769 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
770
771         Reviewed by Shinichiro Hamaji.
772
773         Clean up chromium-specific code from json_results_generator.py.
774         https://bugs.webkit.org/show_bug.cgi?id=39665
775
776         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
777         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
778         * Scripts/webkitpy/layout_tests/port/base.py:
779         * Scripts/webkitpy/layout_tests/port/chromium.py:
780
781 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
782
783         Reviewed by Adam Barth.
784
785         Utilize new takeFirst() method where appropriate.
786         https://bugs.webkit.org/show_bug.cgi?id=40089
787
788         * DumpRenderTree/chromium/EventSender.cpp:
789         (EventSender::replaySavedEvents):
790         * DumpRenderTree/chromium/LayoutTestController.cpp:
791         (LayoutTestController::WorkQueue::processWork):
792         (LayoutTestController::WorkQueue::reset):
793
794 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
795
796         Reviewed by Simon Hausmann.
797
798         [Qt] QtTestLauncher should allow notifications by default.
799         https://bugs.webkit.org/show_bug.cgi?id=40078
800
801         * QtTestBrowser/main.cpp:
802         (NotificationsPermissionController::NotificationsPermissionController):
803         (NotificationsPermissionController::checkPermission):
804         (NotificationsPermissionController::requestPermission):
805         (LauncherWindow::LauncherWindow):
806
807 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
808
809         Reviewed by Adam Barth.
810
811         Detect whether the user's environment can open a browser.
812         https://bugs.webkit.org/show_bug.cgi?id=40136
813
814         Some environments like cygwin silently fail webbrowser.open() causing
815         webkit-patch upload not to display any diff. This detects environments
816         where webbrowser.open() would fail by testing if webbrowser.get()
817         raises an exception.
818
819         * Scripts/webkitpy/common/system/user.py:
820         * Scripts/webkitpy/tool/mocktool.py:
821         * Scripts/webkitpy/tool/steps/confirmdiff.py:
822
823 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
824
825         Reviewed by David Levin.
826
827         Add dependencies required to link with VS Express 2005.
828         https://bugs.webkit.org/show_bug.cgi?id=40038
829
830         Visual Studio implicitly links against these libs.
831         VC++ Express does not.
832
833         * WebKitAPITest/WebKitAPITestCommon.vsprops:
834         * WinLauncher/WinLauncher.vcproj:
835
836 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
837
838         Reviewed by David Levin.
839
840         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
841         https://bugs.webkit.org/show_bug.cgi?id=40105
842
843         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
844         - kill pywebsocket process when url is not alive and the process is not
845           terminated, not to leave pywebsocket server running.
846         - fix codecs.open parameters.
847
848 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
849
850         Reviewed by Alexey Proskuryakov.
851
852         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
853         https://bugs.webkit.org/show_bug.cgi?id=39058
854
855         * Scripts/ensure-valid-python:
856           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
857           - Add --check-only and --help option.
858           - --check-only option only checks python version and don't try to install Python 2.5.
859           - Set executable bit.
860         * Scripts/old-run-webkit-tests:
861           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
862
863 2010-05-14  Ojan Vafai  <ojan@chromium.org>
864
865         Reviewed by Adam Barth.
866
867         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
868         https://bugs.webkit.org/show_bug.cgi?id=38918
869
870         Patches with in-rietveld? get uploaded to rietveld and get marked
871         in-rietveld+. If the upload fails, they are marked in-rietveld-
872         and an error is logged to the bug, like the commit-queue.
873
874         Also, get rid of --fancy-review and the ability to upload to rietveld
875         using webkit-patch upload/post.
876
877         * Scripts/webkitpy/common/net/bugzilla.py:
878         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
879         * Scripts/webkitpy/tool/commands/download.py:
880         * Scripts/webkitpy/tool/commands/download_unittest.py:
881         * Scripts/webkitpy/tool/commands/queues.py:
882         * Scripts/webkitpy/tool/commands/queues_unittest.py:
883         * Scripts/webkitpy/tool/commands/upload.py:
884         * Scripts/webkitpy/tool/commands/upload_unittest.py:
885         * Scripts/webkitpy/tool/mocktool.py:
886         * Scripts/webkitpy/tool/steps/options.py:
887         * Scripts/webkitpy/tool/steps/postcodereview.py:
888
889 2010-05-24  Ojan Vafai  <ojan@chromium.org>
890
891         Reviewed by Chris Jerdonek.
892
893         many webkit-patch commands fail in a non-svn tracking git checkout
894         https://bugs.webkit.org/show_bug.cgi?id=38156
895
896         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
897         If neither exists, then error out. This makes webkit-patch work
898         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
899         to checkout webkit. The fallback to master is for people who don't
900         do the steps on that page for tracking svn.
901
902         * Scripts/webkitpy/common/checkout/scm.py:
903         * Scripts/webkitpy/common/checkout/scm_unittest.py:
904
905 2010-06-03  Mike Fenton  <mifenton@rim.com>
906
907         Unreviewed.
908
909         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
910
911         * Scripts/webkitpy/common/config/committers.py:
912
913 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
914
915         Reviewed by Yury Semikhatsky.
916
917         Web Inspector: a number of fixes that make InspectorController
918         happy with null redirects.
919
920         https://bugs.webkit.org/show_bug.cgi?id=40109
921
922         * DumpRenderTree/gtk/DumpRenderTree.cpp:
923         (runTest):
924         * DumpRenderTree/mac/DumpRenderTree.mm:
925         (runTest):
926         * DumpRenderTree/win/DumpRenderTree.cpp:
927         (runTest):
928
929 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
930
931         Reviewed by Shinichiro Hamaji.
932
933         [Qt] Fix compilation with QT_NO_PROPERTIES
934         https://bugs.webkit.org/show_bug.cgi?id=38324
935
936         * QtTestBrowser/main.cpp:
937         (LauncherWindow::init):
938
939 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
940
941         Reviewed by Kenneth Rohde Christiansen.
942
943         [Qt] Make possible run DRT with QGraphicsWebView
944         https://bugs.webkit.org/show_bug.cgi?id=40016
945
946         Make possible to use a environment variable for switching backend.
947         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
948
949         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
950         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
951         (WebCore::DumpRenderTree::DumpRenderTree):
952         * DumpRenderTree/qt/DumpRenderTreeQt.h:
953         (WebCore::DumpRenderTree::setGraphicsBased):
954         (WebCore::DumpRenderTree::isGraphicsBased):
955         (WebCore::WebViewGraphicsBased::graphicsView):
956         (WebCore::WebViewGraphicsBased::setPage):
957         * Scripts/old-run-webkit-tests:
958
959 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
960
961         Reviewed by Eric Seidel.
962
963         Slave lost shouldn't be recognized as build failed.
964         https://bugs.webkit.org/show_bug.cgi?id=39282
965
966         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
967         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
968
969 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
970
971         Reviewed by Kenneth Rohde Christiansen.
972
973         [Qt] Fix the lifecycle of notification objects
974         https://bugs.webkit.org/show_bug.cgi?id=40003
975
976         Remove the dependency of notifications on QWebPage.
977
978         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
979         (WebCore::requestPermissionCallback):
980         (WebCore::WebPage::WebPage):
981         (WebCore::DumpRenderTree::requestPermission):
982         * DumpRenderTree/qt/DumpRenderTreeQt.h:
983
984 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
985
986         Unreviewed, rolling out r60559.
987         http://trac.webkit.org/changeset/60559
988         https://bugs.webkit.org/show_bug.cgi?id=40055
989
990         It broke python unit test (Requested by Ossy on #webkit).
991
992         * Scripts/webkitpy/common/net/buildbot.py:
993
994 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
995
996         Reviewed by Eric Seidel.
997
998         Slave lost shouldn't be recognized as build failed.
999         https://bugs.webkit.org/show_bug.cgi?id=39282
1000
1001         * Scripts/webkitpy/common/net/buildbot.py:
1002
1003 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         Fix crash caused when assigned_to is disabled
1008         https://bugs.webkit.org/show_bug.cgi?id=40039
1009
1010         * Scripts/webkitpy/common/net/bugzilla.py:
1011
1012 2010-06-02  Sterling Swigart  <sswigart@google.com>
1013
1014         Reviewed by David Levin.
1015
1016         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
1017         https://bugs.webkit.org/show_bug.cgi?id=39906
1018
1019         * Scripts/build-webkit:
1020
1021 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
1022
1023         Reviewed by Simon Hausmann.
1024
1025         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
1026
1027         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1028         (WebCore::WebPage::WebPage):
1029         (WebCore::WebPage::resetSettings):
1030         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1031         (LayoutTestController::setJavaScriptCanAccessClipboard):
1032
1033 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1034
1035         Reviewed by Mark Rowe.
1036
1037         A nicer Tiger build fix.
1038
1039         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1040         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1041         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
1042
1043 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1044
1045         A real Tiger build fix.
1046
1047         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
1048         for all configurations, not just debug.
1049
1050 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1051
1052         Tiger build fix.
1053
1054         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
1055
1056 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1057
1058         Reviewed by Xan Lopez.
1059
1060         [GTK] Get more mouse tests passing
1061         https://bugs.webkit.org/show_bug.cgi?id=39040
1062
1063         Reproduce the logic from the Windows EventSender for mapping
1064         button numbers to GDK button numbers. Move this logic to the
1065         prepareMouseButtonEvent helper.
1066
1067         * DumpRenderTree/gtk/EventSender.cpp:
1068         (prepareMouseButtonEvent): Reproduce Windows logic.
1069         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
1070         (mouseDownCallback): Ditto.
1071         (mouseUpCallback): Ditto.
1072
1073 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1074
1075         Reviewed by Sam Weinig.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=39434
1078         REGRESSION (r59811): Geolocation callbacks cannot be created
1079
1080         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
1081
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
1084         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
1085         into subsequent tests.
1086
1087         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1088         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
1089         (LayoutTestController::setMockGeolocationError): Ditto.
1090
1091         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
1092         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
1093         (+[MockGeolocationProvider shared]):
1094         (-[MockGeolocationProvider dealloc]):
1095         (-[MockGeolocationProvider setPosition:]):
1096         (-[MockGeolocationProvider setError:]):
1097         (-[MockGeolocationProvider registerWebView:]):
1098         (-[MockGeolocationProvider unregisterWebView:]):
1099         (-[MockGeolocationProvider lastPosition]):
1100         (-[MockGeolocationProvider stopTimer]):
1101         (-[MockGeolocationProvider timerFired]):
1102
1103         * DumpRenderTree/mac/UIDelegate.mm:
1104         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1105         This delegate method must send a response. I'm not sure what the two-stage check is supposed
1106         to achieve, it seems unnecessary.
1107
1108 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
1109
1110         Reviewed by Xan Lopez.
1111
1112         [GTK] Double clicks cause three button press events
1113         https://bugs.webkit.org/show_bug.cgi?id=38853
1114
1115         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
1116         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
1117         the GDK event queue entirely, we simply do not send the extra event.
1118
1119         * DumpRenderTree/gtk/EventSender.cpp:
1120         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
1121         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
1122
1123 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1124
1125         Not reviewed. Build fix.
1126
1127         Fix GTK+ build caused by a bad merge.
1128
1129         * DumpRenderTree/gtk/EventSender.cpp: 
1130         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
1131
1132 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
1133
1134         Reviewed by Xan Lopez.
1135
1136         [GTK] Double clicks cause three button press events
1137         https://bugs.webkit.org/show_bug.cgi?id=38853
1138
1139         Small EventSender cleanups. Consolidate some common code. Style fixes.
1140
1141         * DumpRenderTree/gtk/EventSender.cpp:
1142         (prepareMouseButtonEvent): Added.
1143         (contextClickCallback): Use prepareMouseButtonEvent.
1144         (mouseDownCallback): Use prepareMouseButtonEvent.
1145         (mouseUpCallback): Use prepareMouseButtonEvent.
1146         (mouseMoveToCallback): Small style fix.
1147
1148 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1149
1150         Reviewed by Xan Lopez.
1151
1152         [GTK] Double clicks cause three button press events
1153         https://bugs.webkit.org/show_bug.cgi?id=38853
1154
1155         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
1156         to pause for a specified amount of time. It is used in the processing of drag-
1157         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
1158         This patch enables tests that rely on the latter behavior to pass.
1159
1160         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1161         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
1162         * DumpRenderTree/gtk/EventSender.cpp:
1163         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
1164         (contextClickCallback): Use sendOrQueueEvent.
1165         (updateClickCount): Take the time offset into account when counting clicks.
1166         (mouseDownCallback): Use sendOrQueueEvent.
1167         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
1168         (mouseUpCallback): Use sendOrQueueEvent.
1169         (mouseMoveToCallback): Ditto.
1170         (mouseWheelToCallback): Ditto.
1171         (sendOrQueueEvent): Added.
1172         (dispatchEvent): Added.
1173         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
1174         (makeEventSender): Only initialize the EventSender when loading the top frame.
1175         * DumpRenderTree/gtk/EventSender.h: Ditto.
1176
1177 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1178
1179         Reviewed by Xan Lopez.
1180
1181         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
1182         https://bugs.webkit.org/show_bug.cgi?id=39101
1183
1184         Work around timing issues for render tree dumps by pumping the
1185         main loop before doing the dump. Resize events are asynchronous
1186         in GTK+, so sometimes resize requests are still pending when DRT
1187         dumps the tree.
1188
1189         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1190         (dump): Pump the main loop before dumping the render tree.
1191
1192 2010-05-31  Kent Tamura  <tkent@chromium.org>
1193
1194         Reviewed by Dimitri Glazkov.
1195
1196         [DRT/Chromium] Fix crash of a test after another test with multiple windows
1197         https://bugs.webkit.org/show_bug.cgi?id=39942
1198
1199         If a test opens multiple windows, focuses on non-main window, and
1200         the focused window is closed, TestShell::m_focusedWidget points a
1201         deleted object.
1202
1203         * DumpRenderTree/chromium/TestShell.cpp:
1204         (TestShell::closeWindow): Clear m_focusedWidget.
1205
1206 2010-05-30  Kent Tamura  <tkent@chromium.org>
1207
1208         Reviewed by Dimitri Glazkov.
1209
1210         new-run-webkit-tests: Support DRT on Chromium-win
1211         https://bugs.webkit.org/show_bug.cgi?id=39810
1212
1213         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
1214         it behaves like test_shell about command analysis, printing
1215         format, pixel dumping, and timeout handling.
1216
1217         chromium.py and chromium_win.py supports the --test-shell flag and
1218         DRT/Chromium-win binary names.
1219         
1220         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
1221         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1222         (runTest): Support for test_shell-style command.
1223         (main): Introduce --test-shell.
1224         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
1225         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
1226           TestEventPrinter class manages stdio output and image output.
1227           TestEventPrinter.cpp has two implementations; DRTPrinter and
1228           TestShellPrinter.
1229         * DumpRenderTree/chromium/TestShell.cpp:
1230           Some changes for TestEventPrinter.
1231         (TestShell::TestShell):
1232         (TestShell::runFileTest):
1233         (TestShell::testTimedOut):
1234         (TestShell::dump):
1235         (TestShell::dumpImage):
1236         * DumpRenderTree/chromium/TestShell.h:
1237         (TestShell::printer):
1238         (TestShell::layoutTestTimeout):
1239         (TestShell::layoutTestTimeoutForWatchDog):
1240         (TestShell::setLayoutTestTimeout):
1241         * DumpRenderTree/chromium/TestShellWin.cpp:
1242         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
1243         * Scripts/webkitpy/layout_tests/port/chromium.py:
1244         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1245
1246 2010-05-30  Robert Hogan  <robert@webkit.org>
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
1251
1252         https://bugs.webkit.org/show_bug.cgi?id=36004
1253
1254         * DumpRenderTree/qt/EventSenderQt.cpp:
1255         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
1256                                     Scrollbar::pixelsPerLineStep() for DRT testing.
1257         (EventSender::mouseScrollBy): Added
1258         (EventSender::continuousMouseScrollBy): Added
1259         * DumpRenderTree/qt/EventSenderQt.h:
1260
1261 2010-05-28  Adam Barth  <abarth@webkit.org>
1262
1263         Reviewed by David Levin.
1264
1265         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
1266         https://bugs.webkit.org/show_bug.cgi?id=39546
1267
1268         One sublty is that we want to wait for the user to finish editing the
1269         ChangeLog before moving on to the next step.  That means we want to pass
1270         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
1271         we don't want them to have to exit the Xcode application.  For this reason,
1272         we create a new instance of the application with -n.
1273         
1274         Overall, xed seems like a better solution, so we recommend that too.
1275
1276         * Scripts/webkitpy/common/system/user.py:
1277         * Scripts/webkitpy/tool/mocktool.py:
1278         * Scripts/webkitpy/tool/steps/editchangelog.py:
1279
1280 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
1281
1282         Reviewed by Ojan Vafai.
1283
1284         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
1285         threads are wedged. Also, the script will print the results of the
1286         tests completed when the interrupt occurs.
1287
1288         https://bugs.webkit.org/show_bug.cgi?id=33238
1289
1290         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1291         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1292         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1293         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1294
1295 2010-05-28  Darin Adler  <darin@apple.com>
1296
1297         Ignore more Python messiness.
1298
1299         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
1300         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
1301         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
1302         * Scripts/webkitpy/test: Added property svn:ignore.
1303         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
1304
1305 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1306
1307         Reviewed by Beth Dakin.
1308
1309         Adding myself as a reviewer.
1310
1311         * Scripts/webkitpy/common/config/committers.py:
1312
1313 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1314
1315         Build fix. No review.
1316
1317         AX: need to catch NSAccessibilityExceptions in DRT
1318         https://bugs.webkit.org/show_bug.cgi?id=39881
1319
1320         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
1321
1322         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1323         (AccessibilityUIElement::rowIndexRange):
1324         (AccessibilityUIElement::columnIndexRange):
1325         (AccessibilityUIElement::selectedTextRange):
1326
1327 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1328
1329         Reviewed by Darin Adler.
1330
1331         AX: need to catch NSAccessibilityExceptions in DRT
1332         https://bugs.webkit.org/show_bug.cgi?id=39881
1333
1334         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
1335         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
1336   
1337         So DRT should wrap exception handlers around its AX related calls.
1338
1339         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1340         (attributesOfElement):
1341         (AccessibilityUIElement::getLinkedUIElements):
1342         (AccessibilityUIElement::getDocumentLinks):
1343         (AccessibilityUIElement::getChildren):
1344         (AccessibilityUIElement::getChildrenWithRange):
1345         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1346         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1347         (AccessibilityUIElement::disclosedRowAtIndex):
1348         (AccessibilityUIElement::selectedRowAtIndex):
1349         (AccessibilityUIElement::titleUIElement):
1350         (AccessibilityUIElement::parentElement):
1351         (AccessibilityUIElement::disclosedByRow):
1352         (AccessibilityUIElement::stringAttributeValue):
1353         (AccessibilityUIElement::boolAttributeValue):
1354         (AccessibilityUIElement::isAttributeSettable):
1355         (AccessibilityUIElement::isAttributeSupported):
1356         (AccessibilityUIElement::role):
1357         (AccessibilityUIElement::subrole):
1358         (AccessibilityUIElement::roleDescription):
1359         (AccessibilityUIElement::title):
1360         (AccessibilityUIElement::description):
1361         (AccessibilityUIElement::orientation):
1362         (AccessibilityUIElement::stringValue):
1363         (AccessibilityUIElement::language):
1364         (AccessibilityUIElement::helpText):
1365         (AccessibilityUIElement::x):
1366         (AccessibilityUIElement::y):
1367         (AccessibilityUIElement::width):
1368         (AccessibilityUIElement::height):
1369         (AccessibilityUIElement::clickPointX):
1370         (AccessibilityUIElement::clickPointY):
1371         (AccessibilityUIElement::intValue):
1372         (AccessibilityUIElement::minValue):
1373         (AccessibilityUIElement::maxValue):
1374         (AccessibilityUIElement::valueDescription):
1375         (AccessibilityUIElement::insertionPointLineNumber):
1376         (AccessibilityUIElement::isActionSupported):
1377         (AccessibilityUIElement::isEnabled):
1378         (AccessibilityUIElement::isRequired):
1379         (AccessibilityUIElement::isSelected):
1380         (AccessibilityUIElement::isExpanded):
1381         (AccessibilityUIElement::hierarchicalLevel):
1382         (AccessibilityUIElement::ariaIsGrabbed):
1383         (AccessibilityUIElement::ariaDropEffects):
1384         (AccessibilityUIElement::lineForIndex):
1385         (AccessibilityUIElement::boundsForRange):
1386         (AccessibilityUIElement::stringForRange):
1387         (AccessibilityUIElement::attributesOfColumnHeaders):
1388         (AccessibilityUIElement::attributesOfRowHeaders):
1389         (AccessibilityUIElement::attributesOfColumns):
1390         (AccessibilityUIElement::attributesOfRows):
1391         (AccessibilityUIElement::attributesOfVisibleCells):
1392         (AccessibilityUIElement::attributesOfHeader):
1393         (AccessibilityUIElement::rowCount):
1394         (AccessibilityUIElement::columnCount):
1395         (AccessibilityUIElement::indexInTable):
1396         (AccessibilityUIElement::rowIndexRange):
1397         (AccessibilityUIElement::columnIndexRange):
1398         (AccessibilityUIElement::cellForColumnAndRow):
1399         (AccessibilityUIElement::selectedTextRange):
1400         (AccessibilityUIElement::setSelectedTextRange):
1401         (AccessibilityUIElement::increment):
1402         (AccessibilityUIElement::decrement):
1403         (AccessibilityUIElement::showMenu):
1404         (AccessibilityUIElement::press):
1405         (AccessibilityUIElement::url):
1406         (AccessibilityUIElement::hasPopup):
1407
1408 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
1409
1410         Reviewed by Laszlo Gombos.
1411
1412         [Qt] Pass all web notification layout tests
1413         https://bugs.webkit.org/show_bug.cgi?id=39146
1414
1415         Mimic Chromium's test_shell security model in Qt's DRT.
1416         It makes a list of origins which were granted permission to display
1417         notifications, and only those origins can display notifications.
1418
1419         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1420         (WebCore::checkPermissionCallback):
1421         (WebCore::requestPermissionCallback):
1422         (WebCore::WebPage::WebPage):
1423         (WebCore::DumpRenderTree::checkPermission):
1424         (WebCore::DumpRenderTree::requestPermission):
1425         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1426         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1427         (LayoutTestController::reset):
1428         (LayoutTestController::grantDesktopNotificationPermission):
1429         (LayoutTestController::checkDesktopNotificationPermission):
1430         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1431
1432 2010-05-27  Philippe Normand  <pnormand@igalia.com>
1433
1434         Reviewed by Shinichiro Hamaji.
1435
1436         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
1437         https://bugs.webkit.org/show_bug.cgi?id=39372
1438
1439         Don't warn about NULL in g_*() calls. Zero can't be used instead
1440         for calls like g_build_filename and g_object_get/set.
1441
1442         * Scripts/webkitpy/style/checkers/cpp.py:
1443         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1444
1445 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
1446
1447         Reviewed by Kenneth Rohde Christiansen.
1448
1449         [Qt] Platform plugin example
1450         https://bugs.webkit.org/show_bug.cgi?id=39489
1451
1452         Exempting directory WebKit/qt/examples/ from style guide.
1453
1454         * Scripts/webkitpy/style/checker.py:
1455
1456 2010-05-26  Philippe Normand  <pnormand@igalia.com>
1457
1458         Reviewed by David Levin.
1459
1460         [style] Allow usage of NULL in gst_*_many()
1461         https://bugs.webkit.org/show_bug.cgi?id=39740
1462
1463         Don't warn if NULL is used by gst_*_many() functions. Zero can't
1464         be used for the reason explained in Bug 32858.
1465
1466         * Scripts/webkitpy/style/checkers/cpp.py:
1467         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1468
1469 2010-05-27  Adam Barth  <abarth@webkit.org>
1470
1471         Reviewed by Eric Seidel.
1472
1473         Update script to run the normal version of the parser tests.
1474
1475         * Scripts/test-html5-parser:
1476
1477 2010-05-27  Adam Barth  <abarth@webkit.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         Add HTML5 parser support to run-webkit-tests
1482         https://bugs.webkit.org/show_bug.cgi?id=39815
1483
1484         * Scripts/old-run-webkit-tests:
1485
1486 2010-05-26  Adam Barth  <abarth@webkit.org>
1487
1488         Reviewed by Eric Seidel.
1489
1490         Make HTML5 lexer not ASSERT when resuming partial parses
1491         https://bugs.webkit.org/show_bug.cgi?id=39755
1492
1493         Add webkit-resumer.html to the HTML5 parser test suite.
1494
1495         * Scripts/test-html5-parser:
1496
1497 2010-05-24  Tony Chang  <tony@chromium.org>
1498
1499         Reviewed by Kent Tamura.
1500
1501         [chromium] setup fonts on chromium linux DRT
1502         https://bugs.webkit.org/show_bug.cgi?id=39644
1503
1504         * DumpRenderTree/chromium/TestShellGtk.cpp:
1505         (setupFontconfig):
1506         (platformInit):
1507         * DumpRenderTree/chromium/WebViewHost.cpp:
1508         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
1509         * DumpRenderTree/chromium/fonts.conf: Added.
1510
1511 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
1512
1513         Reviewed by Dimitri Glazkov.
1514
1515         Re-commit r58765 - it had been rolled out to see if it was causing
1516         a perf regression (in r59787 and r59789), but that does not seem to
1517         have been the case.
1518
1519         https://bugs.webkit.org/show_bug.cgi?id=39605
1520
1521         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1522         (NotificationPresenter::show):
1523
1524 2010-05-25  Ojan Vafai  <ojan@chromium.org>
1525
1526         Reviewed by Chris Jerdonek.
1527
1528         remove suppression of rietveld logging
1529         https://bugs.webkit.org/show_bug.cgi?id=39693
1530
1531         Now that we only upload to rietveld explicitly, e.g. on the bot
1532         or via webkit-patch post-attachment-to-rietveld, we should print
1533         all the rietveld logging. It was suppressed before to avoid making
1534         webkit-patch upload too noisy.
1535
1536         * Scripts/webkitpy/common/net/rietveld.py:
1537
1538 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
1539
1540         Reviewed by Ojan Vafai.
1541
1542         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
1543         https://bugs.webkit.org/show_bug.cgi?id=39680
1544
1545         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
1546
1547         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1548         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1549         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1550         (LayoutTestController::setEditingBehavior):
1551
1552 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1553
1554         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
1555
1556         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1557         (LayoutTestController::setEditingBehavior):
1558         * wx/build/settings.py:
1559
1560 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
1561
1562         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
1563
1564         editingBehavior settings needs to be set back to a reasonable default between tests
1565         https://bugs.webkit.org/show_bug.cgi?id=39433
1566
1567         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
1568         so that the serialized version of the setting stays in sync with expectations.
1569
1570         * DumpRenderTree/chromium/TestShell.cpp:
1571         (TestShell::resetWebSettings):
1572         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1573         (resetDefaultsToConsistentValues):
1574
1575 2010-05-24  Eric Seidel  <eric@webkit.org>
1576
1577         Reviewed by Adam Barth.
1578
1579         webkit-patch land calls scm.changed_files 4 times!
1580         https://bugs.webkit.org/show_bug.cgi?id=39584
1581
1582         * Scripts/webkitpy/tool/commands/download_unittest.py:
1583          - Assert that we don't call modified_changelogs too often.
1584         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1585          - Use cached changelogs list instead of calling modified_changelogs directly.
1586         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1587          - ditto.
1588
1589 2010-05-24  Kent Tamura  <tkent@chromium.org>
1590
1591         Reviewed by Dimitri Glazkov.
1592
1593         [DRT/Chromium] Import layout_test_helper for Windows
1594         https://bugs.webkit.org/show_bug.cgi?id=39581
1595
1596         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
1597         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
1598
1599         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
1600
1601 2010-05-24  Kent Tamura  <tkent@chromium.org>
1602
1603         Reviewed by Dimitri Glazkov.
1604
1605         [DRT/Chromium] Reset frame name
1606         https://bugs.webkit.org/show_bug.cgi?id=39586
1607
1608         This change fixes about 70 unexpected results.
1609
1610         * DumpRenderTree/chromium/WebViewHost.cpp:
1611         (WebViewHost::reset):
1612
1613 2010-05-24  Marcus Bulach  <bulach@chromium.org>
1614
1615         Reviewed by Kent Tamura.
1616
1617         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
1618         https://bugs.webkit.org/show_bug.cgi?id=39587
1619
1620         * DumpRenderTree/chromium/WebViewHost.cpp:
1621         (WebViewHost::geolocationService):
1622
1623 2010-05-24  Robert Hogan  <robert@webkit.org>
1624
1625         Reviewed by Laszlo Gombos.
1626
1627         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1628
1629         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
1630
1631         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1632         https://bugs.webkit.org/show_bug.cgi?id=39565
1633
1634         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1635         (LayoutTestController::removeOriginAccessWhitelistEntry):
1636
1637 2010-05-24  Marcus Bulach  <bulach@google.com>
1638
1639         Reviewed by Ojan Vafai.
1640
1641         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
1642         https://bugs.webkit.org/show_bug.cgi?id=39603
1643
1644         * Scripts/webkitpy/common/checkout/scm.py:
1645
1646 == Rolled over to ChangeLog-2010-05-24 ==