48773fd27077d2436c73565b64169c52c932616f
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-07-30  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Maciej Stachowiak.
4
5         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
6         Add structured message passing from the injected bundle to UIProcess
7
8         * MiniBrowser/mac/AppDelegate.m:
9         (didRecieveMessageFromInjectedBundle):
10         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
11         (didClearWindowForFrame):
12         (didRecieveMessage):
13         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
14         (WTR::InjectedBundle::done):
15         (WTR::InjectedBundle::didReceiveMessage):
16         * WebKitTestRunner/TestController.cpp:
17         (WTR::TestController::initialize):
18         (WTR::TestController::didReceiveMessageFromInjectedBundle):
19         * WebKitTestRunner/TestController.h:
20         * WebKitTestRunner/TestInvocation.cpp:
21         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
22         * WebKitTestRunner/TestInvocation.h:
23         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
24
25 2010-07-30  Sam Weinig  <sam@webkit.org>
26
27         Reviewed by Anders Carlsson.
28
29         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
30         Make WKArrayRef more usable.
31
32         Remove now unnecessary const_casts.
33
34         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
35         (WTR::dumpDescendantFrameScrollPositions):
36         (WTR::dumpDescendantFramesText):
37
38 2010-07-30  Sam Weinig  <sam@webkit.org>
39
40         Reviewed by Anders Carlsson.
41
42         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
43         Add first pass of structured message passing.
44
45         Update Minibrowser and WebKitTestRunner to work with the new post message
46         function.
47
48         * MiniBrowser/mac/AppDelegate.m:
49         (didRecieveMessageFromInjectedBundle):
50         (-[BrowserAppDelegate init]):
51         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
52         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
53         (didStartProvisionalLoadForFrame):
54         (didReceiveServerRedirectForProvisionalLoadForFrame):
55         (didFailProvisionalLoadWithErrorForFrame):
56         (didCommitLoadForFrame):
57         (didFinishLoadForFrame):
58         (didFailLoadWithErrorForFrame):
59         (didReceiveTitleForFrame):
60         (didClearWindowForFrame):
61         (didCreatePage):
62         (willDestroyPage):
63         (didRecieveMessage):
64         (WKBundleInitialize):
65         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
66         (WTR::InjectedBundle::_didReceiveMessage):
67         (WTR::InjectedBundle::didReceiveMessage):
68         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
69         * WebKitTestRunner/TestInvocation.cpp:
70         (WTR::TestInvocation::invoke):
71         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
72
73 2010-07-30  Anders Carlsson  <andersca@apple.com>
74
75         Try to fix the layout test failures.
76
77         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
78         (webkit_test_plugin_get_value):
79
80 2010-07-29  Anders Carlsson  <andersca@apple.com>
81
82         Reviewed by Adam Roben.
83
84         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
85         https://bugs.webkit.org/show_bug.cgi?id=43232
86
87         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
88         Add PluginScriptableNPObjectInvokeDefault.cpp.
89
90         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
91         Remove invokeDefault callback function.
92
93         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
94         (PluginTest::create):
95         Move this to the top of the file.
96
97         (PluginTest::NPP_GetValue):
98         Add default implementation.
99
100         (PluginTest::NPN_CreateObject):
101         Add NPN_ wrapper.
102
103         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
104         (PluginTest::identifier):
105         Add identifier getter.
106
107         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
108         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
109         Add "using namespace std".
110
111         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
112         (NPP_GetValue):
113         Give PluginTest a chance to return a value.
114
115         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
116         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
117         * GNUmakefile.am:
118         Add PluginScriptableNPObjectInvokeDefault.cpp.
119         
120         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
121         (webkit_test_plugin_get_value):
122         Give PluginTest a chance to return a value.
123
124 2010-07-30  Steve Block  <steveblock@google.com>
125
126         Reviewed by Steve Block.
127
128         Add LayoutTestController methods to test DeviceOrientation
129         https://bugs.webkit.org/show_bug.cgi?id=39589
130
131         * DumpRenderTree/LayoutTestController.cpp:
132         (setMockDeviceOrientationCallback):
133         (LayoutTestController::staticFunctions):
134         * DumpRenderTree/LayoutTestController.h:
135         * DumpRenderTree/chromium/LayoutTestController.cpp:
136         (LayoutTestController::LayoutTestController):
137         (LayoutTestController::setMockDeviceOrientation):
138         * DumpRenderTree/chromium/LayoutTestController.h:
139         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
140         (LayoutTestController::setMockDeviceOrientation):
141         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
142         (LayoutTestController::setMockDeviceOrientation):
143         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
144         (LayoutTestController::setMockDeviceOrientation):
145         * DumpRenderTree/qt/LayoutTestControllerQt.h:
146         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
147         (LayoutTestController::setMockDeviceOrientation):
148         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
149         (LayoutTestController::setMockDeviceOrientation):
150         * Scripts/build-webkit:
151
152 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
153
154         Reviewed by Kenneth Christiansen.
155
156         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
157         https://bugs.webkit.org/show_bug.cgi?id=43209
158
159         When -resizes-to-content was being passed as a command line parameter it was simply
160         not being set (although the corresponding menu item was marked as ON).
161         User had to toggle the menu OFF and then ON again for it to take place.
162
163         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
164         the command line, but not resizesToContents. Patch addresses that.
165
166         * QtTestBrowser/launcherwindow.cpp:
167         (LauncherWindow::createChrome):
168         (LauncherWindow::applyPrefs):
169         (LauncherWindow::toggleResizesToContents):
170         * QtTestBrowser/webview.h:
171         (WebViewGraphicsBased::resizesToContents):
172
173 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
174
175         Rubber-stamped by Simon Fraser.
176
177         [Qt] QtTestBrowser: more method grouping and clean ups.
178
179         Moving blocks of code around. Basically grouping related methods close to each.
180
181         * QtTestBrowser/launcherwindow.cpp:
182         (LauncherWindow::initializeView):
183         (LauncherWindow::createChrome):
184         (LauncherWindow::changeViewportUpdateMode):
185         (LauncherWindow::showFPS):
186         (LauncherWindow::newWindow):
187         (LauncherWindow::cloneWindow):
188         * QtTestBrowser/launcherwindow.h:
189
190 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
191
192         Reviewed by Tor Arne Vestbø.
193
194         [QT][Symbian] QtTestBrowser missing location capabilities
195         https://bugs.webkit.org/show_bug.cgi?id=43235
196
197         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
198
199         * QtTestBrowser/QtTestBrowser.pro:
200
201 2010-07-29  Anders Carlsson  <andersca@apple.com>
202
203         Add PluginTest.cpp
204
205         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
206
207 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
208
209         Reviewed by Eric Seidel.
210
211         Update download URLs for python irclib package; the old URLs 
212         pointed at a specific mirror host and not the general sourceforge
213         URLs.
214
215         https://bugs.webkit.org/show_bug.cgi?id=43228
216
217         * Scripts/webkitpy/thirdparty/__init__.py:
218
219 2010-07-29  Anders Carlsson  <andersca@apple.com>
220
221         Fix typo.
222
223         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
224
225 2010-07-29  Anders Carlsson  <andersca@apple.com>
226
227         Another attempt at fixing the Qt and GTK+ build.
228
229         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
230         (webkit_test_plugin_new_instance):
231         (webkit_test_plugin_destroy_stream):
232
233 2010-07-29  Anders Carlsson  <andersca@apple.com>
234
235         Another build fix attempt.
236
237         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
238         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
239         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
240         (webkit_test_plugin_new_instance):
241         * GNUmakefile.am:
242
243 2010-07-29  Anders Carlsson  <andersca@apple.com>
244
245         Try to fix Windows and Unix builds.
246
247         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
248         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
249         (webkit_test_plugin_new_instance):
250         (webkit_test_plugin_destroy_stream):
251
252 2010-07-29  Anders Carlsson  <andersca@apple.com>
253
254         Reviewed by Sam Weinig.
255
256         Refactor TestNetscapePlugin so tests can be split in separate files
257         https://bugs.webkit.org/show_bug.cgi?id=43220
258
259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
260         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
261
262         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
263         (pluginAllocate):
264         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
265
266         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
267         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
268         (PluginTest::PluginTest):
269         Initialize m_npp and the test identifier.
270         
271         (PluginTest::createTestFunctions):
272         Return the map from identifiers to createTest functions.
273
274         (PluginTest::registerCreateTestFunction):
275         Insert the identifier and create function pair in the map.
276
277         (PluginTest::create):
278         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
279
280         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
281         (PluginTest::Register::Register):
282         Helper class template for registering plug-in tests.
283         
284         (PluginTest::Register::create):
285         Create a new test of the given type.
286
287         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
288         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
289         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
290
291         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
292         (NPP_New):
293         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
294
295         (NPP_DestroyStream):
296         Call the plug-in test NPP_DestroyStream member function.
297
298         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
299         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
300
301 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
302
303         Unreviewed build fix.
304
305         Add missing second argument to assert_lint in new style checker tests.
306
307         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
308
309 2010-07-29  Anders Carlsson  <andersca@apple.com>
310
311         Reviewed by Adam Roben.
312
313         check-webkit-style shouldn't complain about NPAPI functions
314         https://bugs.webkit.org/show_bug.cgi?id=43211
315
316         Allow underscores in functions that start with NPN_, NPP_ or NP_.
317
318         * Scripts/webkitpy/style/checkers/cpp.py:
319         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
320
321 2010-07-29  Victor Wang  <victorw@chromium.org>
322
323         Unreviewed, rolling out r64270.
324         http://trac.webkit.org/changeset/64270
325         https://bugs.webkit.org/show_bug.cgi?id=39589
326
327         The patch breaks chromium webkit unittest
328
329         * DumpRenderTree/LayoutTestController.cpp:
330         (LayoutTestController::staticFunctions):
331         * DumpRenderTree/LayoutTestController.h:
332         * DumpRenderTree/chromium/LayoutTestController.cpp:
333         (LayoutTestController::LayoutTestController):
334         * DumpRenderTree/chromium/LayoutTestController.h:
335         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
336         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
337         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
338         * DumpRenderTree/qt/LayoutTestControllerQt.h:
339         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
340         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
341         * Scripts/build-webkit:
342
343 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
344
345         Reviewed by Kenneth Christiansen.
346
347         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
348         https://bugs.webkit.org/show_bug.cgi?id=43199
349
350         There is no sense in keeping WebPage method definitions in main.cpp once
351         webpage.cpp already exists.
352
353         No behavior change.
354
355         * QtTestBrowser/main.cpp:
356         * QtTestBrowser/webpage.cpp:
357         (WebPage::createWindow):
358         (WebPage::createPlugin):
359
360 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
361
362         Reviewed by Kenneth Christiansen.
363
364         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
365         https://bugs.webkit.org/show_bug.cgi?id=43170
366
367         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
368         launcherwindow.{cpp|h}
369
370         No behavior change.
371
372         Also changed all global static variables (named "gXXX") from main.cpp to
373         static public variables of the LauncherWindow class.
374
375         * QtTestBrowser/QtTestBrowser.pro:
376         * QtTestBrowser/launcherwindow.cpp: Added.
377         * QtTestBrowser/launcherwindow.h: Added.
378         * QtTestBrowser/main.cpp:
379         (LauncherApplication::handleUserOptions):
380         (main):
381
382 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
383
384         Reviewed by Xan Lopez.
385
386         Build fix for building against GTK+ 3.x. GSEAL requires that we
387         access internals of the GdkDragContext via methods. For older versions
388         of GTK+, define those methods.
389
390         * DumpRenderTree/gtk/EventSender.cpp:
391         (gdk_drag_context_get_selected_action): Added.
392         (gdk_drag_context_get_actions): Added.
393         (dispatchEvent): Use the two new accessor methods.
394
395 2010-07-29  Adam Roben  <aroben@apple.com>
396
397         Always say "plugins directory" when referring to a directory
398         containing one or more plugins
399
400         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
401         directory" when it means "plugins directory"
402
403         Reviewed by John Sullivan.
404
405         * WebKitTestRunner/TestController.cpp:
406         (WTR::TestController::initialize): Updated for rename.
407
408 2010-07-29  Adam Roben  <aroben@apple.com>
409
410         Always say "directory" when referring to a plugin directory
411
412         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
413         when it means "plugin directory"
414
415         Reviewed by John Sullivan.
416
417         * WebKitTestRunner/TestController.cpp:
418         (WTR::TestController::initialize): Updated for renames.
419
420         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
421         m_testPluginDirectory.
422         (WTR::TestController::testPluginDirectory): Renamed from
423         testPluginPath.
424
425         * WebKitTestRunner/mac/TestControllerMac.mm:
426         (WTR::TestController::initializeTestPluginDirectory):
427         * WebKitTestRunner/win/TestControllerWin.cpp:
428         (WTR::TestController::initializeTestPluginDirectory):
429         Renamed from initializeTestPluginPath and updated for rename.
430
431 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
432
433          Reviewed by Antonio Gomes.
434
435          Initialize all members of NPClass struct.
436          https://bugs.webkit.org/show_bug.cgi?id=43193
437
438          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
439
440 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
441
442         Reviewed by Antonio Gomes.
443
444         Warning fix on platforms where XP_MACOSX is undefined.
445         https://bugs.webkit.org/show_bug.cgi?id=43192
446
447         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
448         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
449
450 2010-07-29  Adam Roben  <aroben@apple.com>
451
452         Give find-included-framework-headers our standard license
453
454         * Scripts/find-included-framework-headers: Used the license from
455         WebCore/LICENSE-APPLE.
456
457 2010-07-29  Adam Roben  <aroben@apple.com>
458
459         Speed up find-included-framework-headers
460
461         We only do one invocation of find now, no longer pipe to grep, and
462         replace uniq with sort -u.
463
464         Also added a license header.
465
466         * Scripts/find-included-framework-headers:
467
468 2010-07-29  Steve Block  <steveblock@google.com>
469
470         Reviewed by Jeremy Orlow.
471
472         Add LayoutTestController methods to test DeviceOrientation
473         https://bugs.webkit.org/show_bug.cgi?id=39589
474
475         * DumpRenderTree/LayoutTestController.cpp:
476         (setMockDeviceOrientationCallback):
477         (LayoutTestController::staticFunctions):
478         * DumpRenderTree/LayoutTestController.h:
479         * DumpRenderTree/chromium/LayoutTestController.cpp:
480         * DumpRenderTree/chromium/LayoutTestController.h:
481         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
482         (LayoutTestController::setMockDeviceOrientation):
483         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
484         (LayoutTestController::setMockDeviceOrientation):
485         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
486         (LayoutTestController::setMockDeviceOrientation):
487         * DumpRenderTree/qt/LayoutTestControllerQt.h:
488         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
489         (LayoutTestController::setMockDeviceOrientation):
490         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
491         (LayoutTestController::setMockDeviceOrientation):
492         * Scripts/build-webkit:
493
494 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
495
496         Reviewed by Shinichiro Hamaji.
497
498         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
499         check-webkit-style gives false positives in single-line functions.
500
501         * Scripts/webkitpy/style/checkers/cpp.py:
502         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
503
504 2010-07-28  Darin Adler  <darin@apple.com>
505
506         Reviewed by Sam Weinig.
507
508         WebKitTestRunner needs to support layoutTestController.execCommand
509         <https://bugs.webkit.org/show_bug.cgi?id=42538>
510
511         WebKitTestRunner needs layoutTestController.isCommandEnabled
512         <https://bugs.webkit.org/show_bug.cgi?id=42671>
513
514         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
515         Added execCommand and isCommandEnabled.
516         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
517         (WTR::LayoutTestController::execCommand): Added.
518         (WTR::LayoutTestController::isCommandEnabled): Added.
519         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
520
521 2010-07-28  Kent Tamura  <tkent@chromium.org>
522
523         Reviewed by Dimitri Glazkov.
524
525         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
526         https://bugs.webkit.org/show_bug.cgi?id=43123
527
528         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
529         which overrides test expectations only for DumpRenderTree, in
530         order to manage what problems are investigated.
531         This change will be reverted when we switch to DRT completely.
532
533         * Scripts/webkitpy/layout_tests/port/chromium.py:
534          Add drt_expectations.txt content to the result of
535          test_expectations_overrides() if --use-drt is specified.
536
537 2010-07-28  Brady Eidson  <beidson@apple.com>
538
539         Reviewed by Darin Adler.
540
541         First pass at visited link support for WK2
542         https://bugs.webkit.org/show_bug.cgi?id=43157
543
544         * MiniBrowser/mac/AppDelegate.m:
545         (didNavigateWithNavigationData):
546         (didPerformClientRedirect):
547         (didPerformServerRedirect):
548         (didUpdateHistoryTitle):
549         (populateVisitedLinks): Added for the new version of the HistoryClient.
550         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
551         
552         * MiniBrowser/mac/BrowserWindowController.m:
553         (-[BrowserWindowController awakeFromNib]):
554
555 2010-07-28  Robin Dunn  <robin@alldunn.com>
556
557         Reviewed by Kevin Ollivier.
558
559         Add DOM bindings support for wx port.
560
561         * DumpRenderTree/wscript:
562         * wx/browser/wscript:
563         * wx/build/settings.py:
564
565 2010-07-28  Tony Chang  <tony@chromium.org>
566
567         Reviewed by Kent Tamura.
568
569         [chromium] cleanup temp files left by Linux DRT
570         https://bugs.webkit.org/show_bug.cgi?id=43062
571
572         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
573         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
574             by crashed DRTs
575
576 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
577
578         Rubber-stamped by Kenneth Christiansen.
579
580         More Developer menu items reordering.
581
582         Grouping related menu items together, visually and logically (in the code).
583
584         No behavior change.
585
586         * QtTestBrowser/main.cpp:
587         (LauncherWindow::createChrome):
588
589 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
590
591         Reviewed by Ojan Vafai.
592
593         Add FILE_SYSTEM build flag for FileSystem API
594         https://bugs.webkit.org/show_bug.cgi?id=42915
595
596         * Scripts/build-webkit:
597
598 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
599
600         Reviewed by David Levin.
601
602         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
603         https://bugs.webkit.org/show_bug.cgi?id=43090
604
605         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
606         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
607
608 2010-07-27  Kent Tamura  <tkent@chromium.org>
609
610         Unreviewed, trivial typo fix.
611
612         * Scripts/webkitpy/layout_tests/port/chromium.py:
613           Fix a wrong method name committed by r64109.
614
615 2010-07-27  Sam Weinig  <sam@webkit.org>
616
617         Reviewed by Anders Carlsson.
618
619         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
620         Clean up handling of strings at the WebKit2 API layer.
621
622         * MiniBrowser/mac/BrowserWindowController.m:
623         (runJavaScriptAlert):
624         (runJavaScriptConfirm):
625         (runJavaScriptPrompt):
626         (didNavigateWithNavigationData):
627         (-[BrowserWindowController updateProvisionalURLForFrame:]):
628         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
629         (_didClearWindowForFrame):
630
631 2010-07-27  Ojan Vafai  <ojan@chromium.org>
632
633         Reviewed by Eric Seidel.
634
635         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
636         https://bugs.webkit.org/show_bug.cgi?id=42984
637
638         squash and no_squash have been intentionally erroring for a couple weeks now.
639         But post-commits was just broken. Just remove squash/no_squash.
640
641         * Scripts/webkitpy/tool/steps/abstractstep.py:
642         * Scripts/webkitpy/tool/steps/options.py:
643
644 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
645
646         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
647
648         * wx/build/settings.py:
649
650 2010-07-27  Adam Roben  <aroben@apple.com>
651
652         Mac build fix
653
654         * MiniBrowser/mac/BrowserWindowController.m:
655         (processDidExit):
656         (-[BrowserWindowController awakeFromNib]):
657         Added processDidExit support.
658
659 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
660
661         Rubber-stamped by Simon Hausmann.
662
663         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
664
665         Move some less useful menu items on Developers menu from the top to the bottom, so
666         QGraphicsView menu goes to the top, and becomes more quickly accessible.
667
668         * QtTestBrowser/main.cpp:
669         (LauncherWindow::createChrome):
670
671 2010-07-26  Adam Roben  <aroben@apple.com>
672
673         Fix the path to InjectedBundle.dll in Debug_Internal builds
674
675         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
676         InjectedBundle.dll in the Debug_Internal configuration
677
678         Reviewed by Anders Carlsson.
679
680         * WebKitTestRunner/win/TestControllerWin.cpp:
681         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
682         suffix only in Debug_All builds.
683
684 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
685
686         Reviewed by Darin Adler.
687
688         https://bugs.webkit.org/show_bug.cgi?id=42947
689         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
690         error. Without which dumpRenderTree crashes.
691
692         * Scripts/old-run-webkit-tests:
693
694 2010-07-27  Kent Tamura  <tkent@chromium.org>
695
696         Reviewed by Dimitri Glazkov.
697
698         https://bugs.webkit.org/show_bug.cgi?id=42956
699         [DRT/Chromium] Fix "out of sync" assertion error
700
701         Fix an assertion error on Windows like the following:
702         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
703         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
704         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
705
706         * Scripts/webkitpy/layout_tests/port/chromium.py:
707         If the url matches with "file:///[a-z]:", does case-ignore comparison.
708         GURL capitalize the driver letter of a file: URL.
709
710 2010-07-26  Darin Adler  <darin@apple.com>
711
712         Reviewed by Sam Weinig.
713
714         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
715         https://bugs.webkit.org/show_bug.cgi?id=42537
716
717         WebKitTestRunner needs layoutTestController.markerTextForListItem
718         https://bugs.webkit.org/show_bug.cgi?id=42549
719
720         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
721         Fixed _paramterExpression typo. Improved support for string type as a
722         return value, so we don't try to include DOMString.h and we can convert
723         the string to a JSValue by calling JSValueMakeStringOrNull.
724
725         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
726         Added JSValueMakeStringOrNull, used by the code generator.
727
728         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
729         Added counterValueForElementById and markerTextForListItem.
730
731         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
732         Moved constant to the top of the file.
733         (WTR::toCF): Added. Converts strings to CFStringRef.
734         (WTR::toWK): Added. Converts strings to WKStringRef.
735         (WTR::toJS): Added. Converts strings to JSStringRef.
736         (WTR::setProperty): Moved this function to the top of the file
737         rather than having it down where it's used inside the class. Also
738         renamed it so it's a separate function rather than an overload of
739         JSObjectSetProperty.
740         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
741         Should move it somewhere we can share it.
742         (WTR::propertyObject): Ditto.
743         (WTR::getElementById): Added. Calls getElementById through the magic
744         of JavaScript.
745         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
746         Chagned to use toWK instead of four local variables.
747         (WTR::LayoutTestController::counterValueForElementById): Added.
748         Calls WKBundleFrameCopyCounterValue.
749         (WTR::LayoutTestController::markerTextForListItem): Added.
750         Calls WKBundleFrameCopyMarkerText.
751
752         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
753         Added counterValueForElementById and markerTextForListItem.
754
755 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
756
757         Reviewed by Gustavo Noronha Silva.
758
759         [GTK] The EventSender should support simulating drop events
760         https://bugs.webkit.org/show_bug.cgi?id=39844
761
762         Add initial dropping support to the GTK+ EventSender.
763
764         * DumpRenderTree/gtk/DumpRenderTree.cpp:
765         (createWebView): Listen for some new drag-and-drop signals.
766         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
767         (dispatchEvent):
768         Detect situations where a drag is either starting or ending and massage
769         GTK+ into sending the appropriate signals to the WebView.
770         (replaySavedEvents): Remove comment.
771         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
772         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
773         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
774         (dragFailedCallback): Disable the GTK+ drag failed animation.
775         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
776
777 2010-07-26  Daniel Bates  <dbates@rim.com>
778
779         Reviewed by Darin Adler.
780
781         svn-unapply warns of uninitialized variable when unapplying
782         a patch that describes an svn move operation
783         https://bugs.webkit.org/show_bug.cgi?id=42036
784
785         Fixes Perl uninitialized variable warnings when un-applying
786         a patch that moves a file.
787
788         * Scripts/svn-unapply:
789           - Modified patch() so that it initializes $patch to the empty
790             string when we don't have svnConvertedText (such as when
791             reversing a diff that represents a svn copy/move operation).
792
793 2010-07-26  Sam Weinig  <sam@webkit.org>
794
795         Reviewed by Anders Carlsson.
796
797         Move some non-APIish functions into private headers.
798
799         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
800         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
801
802 2010-07-26  Sam Weinig  <sam@webkit.org>
803
804         Reviewed by Anders Carlsson.
805
806         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
807         Add prompt and confirm client functions to WebKit2
808
809         * MiniBrowser/mac/BrowserWindowController.m:
810         (-[BrowserWindowController awakeFromNib]):
811
812 2010-07-26  Adam Roben  <aroben@apple.com>
813
814         Windows build fix
815
816         * MiniBrowser/MiniBrowser.vcproj:
817         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
818         Removed empty attributes so the values will be picked up from the
819         vsprops files. (Also removed a couple of attributes that accidentally
820         duplicated values from the vsprops files.)
821
822 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
823
824         Rubber-stamped by Adam Roben.
825         
826         Touch MiniBrowser's stdafx to fix the build.
827
828         * MiniBrowser/win/stdafx.h:
829
830 2010-07-26  Hayato Ito  <hayato@chromium.org>
831
832         Reviewed by Shinichiro Hamaji.
833
834         Add pretty printer of WTF::Vector for GDB 7.
835
836         https://bugs.webkit.org/show_bug.cgi?id=40909
837
838         * gdb/wtf.py: Added.
839
840 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
841
842         Reviewed by Simon Hausmann.
843
844         [Qt] Fix feature detection regexp
845
846         We were missing the last feature
847
848         * Scripts/webkitdirs.pm:
849
850 2010-07-25  Darin Adler  <darin@apple.com>
851
852         Reviewed by Dan Bernstein.
853
854         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
855         https://bugs.webkit.org/show_bug.cgi?id=42326
856
857         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
858         Added dumpSelectionRect.
859
860         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
861         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
862         does nothing because its purpose is to change pixel test output and
863         we do not have pixel tests implemented yet.
864
865 2010-07-25  Darin Adler  <darin@apple.com>
866
867         Reviewed by Maciej Stachowiak.
868
869         WebKitTestRunner needs to support layoutTestController.keepWebHistory
870         https://bugs.webkit.org/show_bug.cgi?id=42323
871
872         Added keepWebHistory and computedStyleIncludingVisitedInfo.
873
874         Also fixed misspellings of the word "receive".
875
876         Also tweaked the names of some of the LayoutTestController members.
877
878         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
879         Added support for a type named "object" that is passed and returns as
880         a JSValueRef.
881
882         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
883         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
884         put setAcceptsEditing up nearer the top.
885
886         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
887         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
888         (WTR::InjectedBundle::initialize): Ditto.
889         (WTR::InjectedBundle::didReceiveMessage): Ditto.
890         (WTR::InjectedBundle::reset): Reset the state of visited links between
891         tests. Also eliminated the unused argument to the LayoutTestController
892         create function.
893         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
894         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
895
896         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
897         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
898         instead of acceptsEditing.
899         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
900         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
901         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
902         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
903         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
904         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
905
906         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
907         (WTR::LayoutTestController::create): Removed uneeded argument.
908         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
909         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
910         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
911         about the fact that this works on the main frame.
912         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
913         (WTR::LayoutTestController::keepWebHistory): Added.
914         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
915         (WTR::JSObjectSetProperty): Added. Helper to make the function below
916         cleaner.
917         (WTR::LayoutTestController::makeWindowObject): Changed to use the
918         overload of JSObjectSetProperty above.
919
920         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
921         match above.
922
923         * WebKitTestRunner/TestController.cpp:
924         (WTR::TestController::initialize): Fixed mispellings of receive.
925         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
926         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
927         * WebKitTestRunner/TestController.h: Ditto.
928         * WebKitTestRunner/TestInvocation.cpp:
929         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
930         * WebKitTestRunner/TestInvocation.h: Ditto.
931
932 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
933
934         Reviewed by Sam Weinig.
935
936         https://bugs.webkit.org/show_bug.cgi?id=42193
937         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
938
939         Step 2 - add the rest of editing delegates.
940
941         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
942         (WTR::operator<<): Fixed to not crash when range is null.
943         (WTR::InjectedBundlePage::InjectedBundlePage):
944         (WTR::InjectedBundlePage::_shouldEndEditing):
945         (WTR::InjectedBundlePage::_shouldInsertNode):
946         (WTR::InjectedBundlePage::_shouldInsertText):
947         (WTR::InjectedBundlePage::_shouldDeleteRange):
948         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
949         (WTR::InjectedBundlePage::_shouldApplyStyle):
950         (WTR::InjectedBundlePage::_didBeginEditing):
951         (WTR::InjectedBundlePage::_didEndEditing):
952         (WTR::InjectedBundlePage::_didChange):
953         (WTR::InjectedBundlePage::_didChangeSelection):
954         (WTR::InjectedBundlePage::shouldEndEditing):
955         (WTR::InjectedBundlePage::shouldInsertNode):
956         (WTR::InjectedBundlePage::shouldInsertText):
957         (WTR::InjectedBundlePage::shouldDeleteRange):
958         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
959         (WTR::InjectedBundlePage::shouldApplyStyle):
960         (WTR::InjectedBundlePage::didBeginEditing):
961         (WTR::InjectedBundlePage::didEndEditing):
962         (WTR::InjectedBundlePage::didChange):
963         (WTR::InjectedBundlePage::didChangeSelection):
964         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
965
966 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
967
968         Reviewed by David Kilzer.
969
970         AX: need a layout test testing misspelled words in attributed strings
971         https://bugs.webkit.org/show_bug.cgi?id=42899
972
973         * DumpRenderTree/AccessibilityUIElement.cpp:
974         (attributedStringForRangeCallback):
975         (attributedStringRangeIsMisspelledCallback):
976         (AccessibilityUIElement::getJSClass):
977         * DumpRenderTree/AccessibilityUIElement.h:
978         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
979         (AccessibilityUIElement::attributedStringForRange):
980         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
981         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
982         (AccessibilityUIElement::attributedStringForRange):
983         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
984         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
985         (AccessibilityUIElement::attributedStringForRange):
986         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
987
988 2010-07-23  David Kilzer  <ddkilzer@apple.com>
989
990         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
991
992         Reviewed by Mark Rowe.
993
994         * Scripts/check-for-inappropriate-files-in-framework: Added
995         check for the SHALLOW_BUNDLE environment variable so that the
996         script will work with iOS WebKit builds.
997         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
998
999 2010-07-22  Darin Adler  <darin@apple.com>
1000
1001         Reviewed by Sam Weinig.
1002
1003         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
1004         https://bugs.webkit.org/show_bug.cgi?id=42847
1005
1006         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1007         (WTR::operator<<): Replaced the WKStringToUTF8 function with
1008         a set of overloaded stream operators.
1009         (WTR::dumpPath): Changed to use ostringstream and return a string.
1010         (WTR::propertyValue): Added.
1011         (WTR::propertyObject): Added.
1012         (WTR::propertyString): Added.
1013         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
1014         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
1015         since we now have suitable streaming functions.
1016         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
1017         WKBundleFrameCopyInnerText.
1018         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
1019         since we now have suitable streaming functions.
1020         (WTR::InjectedBundlePage::dump): Ditto.
1021         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
1022         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
1023         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
1024         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
1025         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
1026
1027 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
1028
1029         Reviewed by Sam Weinig and Darin Adler.
1030
1031         https://bugs.webkit.org/show_bug.cgi?id=42193
1032         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
1033
1034         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
1035         fixed, but this makes difference one line smaller on many editing tests.
1036
1037         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1038         Added dumpEditingCallbacks() and setAcceptsEditing().
1039
1040         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1041         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
1042         (WTR::operator<<): Print a range.
1043         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
1044         clients.
1045         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
1046         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
1047         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
1048         calls.
1049
1050         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1051         (WTR::LayoutTestController::LayoutTestController):
1052         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1053         (WTR::LayoutTestController::dumpEditingCallbacks):
1054         (WTR::LayoutTestController::setAcceptsEditing):
1055         (WTR::LayoutTestController::acceptsEditing):
1056         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
1057         Store m_acceptsEditing and m_dumpEditingCallbacks.
1058
1059 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
1060
1061         Reviewed by Laszlo Gombos.
1062
1063         [Qt] QtWebKit needs public API for Notifications.
1064         https://bugs.webkit.org/show_bug.cgi?id=41413
1065
1066         Update DumpRenderTree and QtTestBrowser to use the new API.
1067         Add new DRT API to flag that notifications permission requests should be ignored.
1068
1069         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1070         (WebCore::WebPage::WebPage):
1071         (WebCore::WebPage::requestPermission):
1072         (WebCore::WebPage::checkPermission):
1073         (WebCore::WebPage::cancelRequestsForPermission):
1074         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1075         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1076         (LayoutTestController::reset):
1077         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
1078         (LayoutTestController::checkDesktopNotificationPermission):
1079         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1080         (LayoutTestController::ignoreReqestForPermission):
1081         * QtTestBrowser/main.cpp:
1082         (LauncherWindow::LauncherWindow):
1083         * QtTestBrowser/webpage.cpp:
1084         (WebPage::WebPage):
1085         (WebPage::requestPermission):
1086         (WebPage::checkPermission):
1087         (WebPage::cancelRequestsForPermission):
1088         * QtTestBrowser/webpage.h:
1089
1090 2010-07-22  Darin Adler  <darin@apple.com>
1091
1092         Reviewed by Sam Weinig.
1093
1094         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
1095         https://bugs.webkit.org/show_bug.cgi?id=42325
1096
1097         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1098         Added dumpChildFramesAsText.
1099
1100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1101         (WTR::dumpFrameText): Added.
1102         (WTR::dumpDescendantFramesText): Added.
1103         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
1104         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
1105         instead of the shouldDumpAsText function, and added a case for AllFramesText.
1106
1107         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
1108
1109         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1110         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
1111         m_whatToDump.
1112
1113         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
1114         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
1115         and shouldDumpSourceAsWebArchive. Added whatToDump.
1116
1117 2010-07-22  Adam Roben  <aroben@apple.com>
1118
1119         Windows build fix
1120
1121         Inspired by r63881.
1122
1123         * MiniBrowser/MiniBrowser.vcproj:
1124         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
1125         Removed pre- and post-build events so they will be inherited from the
1126         vsprops files.
1127
1128 2010-07-21  Darin Adler  <darin@apple.com>
1129
1130         Reviewed by Sam Weinig.
1131
1132         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
1133         https://bugs.webkit.org/show_bug.cgi?id=42548
1134
1135         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1137         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
1138         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
1139         Changed to a file-internal function instead of a member function.
1140         (WTR::dumpDescendantFrameScrollPositions): Added.
1141         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
1142         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
1143         appropriate. Also streamlined all the WKStringToUTF8 call sites.
1144         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
1145         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
1146         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
1147         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
1148         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
1149
1150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
1151
1152         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1153         (WTR::LayoutTestController::LayoutTestController): Initialize
1154         m_shouldDumpAllFrameScrollPositions.
1155         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
1156         shouldDumpFrameScrollPositions.
1157
1158         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
1159         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
1160         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
1161
1162 2010-07-21  Darin Adler  <darin@apple.com>
1163
1164         Reviewed by Sam Weinig.
1165
1166         WebKitTestRunner needs to support dumping of scroll position
1167         https://bugs.webkit.org/show_bug.cgi?id=42514
1168
1169         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1170         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
1171
1172         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1173         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
1174         instead of JSContextRef.
1175         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
1176         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
1177         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
1178         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
1179         instead of JSContextRef.
1180
1181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
1182         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
1183
1184         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1185         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
1186         returns false.
1187         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
1188         returns false.
1189         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
1190         the logic in DumpRenderTree.
1191
1192         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
1193
1194         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
1195
1196 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
1197
1198         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
1199
1200         * wx/build/settings.py:
1201
1202 2010-07-21  Sam Weinig  <sam@webkit.org>
1203
1204         Reviewed by Anders Carlsson.
1205
1206         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
1207         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
1208
1209         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1210         (WTR::InjectedBundlePage::InjectedBundlePage):
1211         (WTR::InjectedBundlePage::_willAddMessageToConsole):
1212         (WTR::InjectedBundlePage::_willSetStatusbarText):
1213         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
1214         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
1215         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
1216         (WTR::InjectedBundlePage::willAddMessageToConsole):
1217         (WTR::InjectedBundlePage::willSetStatusbarText):
1218         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1219         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1220         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1221         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1222
1223 2010-07-21  Adam Roben  <aroben@apple.com>
1224
1225         Give InjectedBundle our standard set of configurations (minus the
1226         *_Cairo variants)
1227
1228         InjectedBundle's Debug_All configuration was the same as is Debug
1229         configuration, and it was missing a Debug_Internal configuration.
1230
1231         Fixes <http://webkit.org/b/42749> InjectedBundle's build
1232         configurations are screwy
1233
1234         Reviewed by Darin Adler.
1235
1236         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
1237         debug_internal.vsprops and debug_all.vsprops to the Debug_All
1238         configuration. Added a Debug_Internal configuration.
1239
1240         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
1241         variant of InjectedBundle when we're using the Debug_Internal solution
1242         configuration.
1243
1244 2010-07-21  Adam Roben  <aroben@apple.com>
1245
1246         Move InjectedBundle's settings to a vsprops file
1247
1248         This will make it easier to change settings for all configurations,
1249         and to add new configurations.
1250
1251         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
1252         files
1253
1254         Reviewed by Darin Adler.
1255
1256         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
1257         Moved settings here...
1258         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
1259         here.
1260
1261 2010-07-21  Adam Roben  <aroben@apple.com>
1262
1263         Give MiniBrowser our standard set of configurations (minus the *_Cairo
1264         variants)
1265
1266         MiniBrowser already had a configuration called "Release", but it was
1267         using mostly the same settings as Debug. And its Debug configuration
1268         was using the settings that Debug_Internal should be using.
1269
1270         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
1271         are screwy
1272
1273         Reviewed by Darin Adler.
1274
1275         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
1276         the Debug configuration. Remove debug.vsprops and
1277         debug_internal.vsprops from the Release configuration and replace them
1278         with release.vsprops. Added Debug_Internal and Debug_All
1279         configurations.
1280
1281 2010-07-21  Adam Roben  <aroben@apple.com>
1282
1283         Move MiniBrowser's settings to a vsprops file
1284
1285         This will make it easier to change settings for all configurations,
1286         and to add new configurations.
1287
1288         MiniBrowser should use vsprops files
1289         https://bugs.webkit.org/show_bug.cgi?id=42745
1290
1291         Reviewed by Darin Adler.
1292
1293         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
1294         settings here...
1295         * MiniBrowser/MiniBrowser.vcproj: ...from here.
1296
1297 2010-07-21  Adam Roben  <aroben@apple.com>
1298
1299         Fix compiler warnings when building MiniBrowser
1300
1301         Also cleaned up the .vcproj a bit.
1302
1303         Fixes <http://webkit.org/b/42743>.
1304
1305         Reviewed by Darin Adler.
1306
1307         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
1308         already defined in .vsprops files. This also fixes a warning about
1309         /EDITANDCONTINUE being incompatible with /SAFESEH.
1310
1311         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
1312         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
1313         being redefined. (I think this will also get us closer to building
1314         with VC++ Express.)
1315
1316 2010-07-20  Sam Weinig  <sam@webkit.org>
1317
1318         Reviewed by Jon Honeycutt.
1319
1320         Fix obvious typo.
1321
1322         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1323         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
1324
1325 2010-07-20  Tony Chang  <tony@chromium.org>
1326
1327         Reviewed by Kent Tamura.
1328
1329         [chromium] by default, dumpAsText should disable pixel results
1330         https://bugs.webkit.org/show_bug.cgi?id=42715
1331
1332         * DumpRenderTree/chromium/LayoutTestController.cpp:
1333         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
1334
1335 2010-07-20  Adam Roben  <aroben@apple.com>
1336
1337         Windows build fix
1338
1339         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
1340         WebKit.lib instead of the old, dusty WebKit2.lib.
1341
1342 2010-07-20  Adam Roben  <aroben@apple.com>
1343
1344         Stop linking WebKitTestRunner against getopt
1345
1346         Use of getopt was removed in r63700.
1347
1348         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
1349         getopt, but doesn't need to
1350
1351         Reviewed by Sam Weinig.
1352
1353         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
1354         from all configurations.
1355
1356 2010-07-20  Adam Roben  <aroben@apple.com>
1357
1358         Make run-webkit-tests --webkit-test-runner "work" on Windows
1359
1360         WebKitTestRunner crashes on launch, but at least the scripts build and
1361         launch it!
1362
1363         Fixes <http://webkit.org/b/42709> run-webkit-tests
1364         --webkit-test-runner bails with an error on Windows
1365
1366         Reviewed by Anders Carlsson.
1367
1368         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
1369         Windows.
1370         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
1371         projects (from first-built to last-built): FindSafari, ImageDiff,
1372         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
1373
1374 2010-07-20  Adam Roben  <aroben@apple.com>
1375
1376         Change build-webkit back to building WebKit.sln on Windows
1377
1378         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
1379         is being removed.
1380
1381         Rubber-stamped in advance by Steve Falkenburg.
1382
1383         * Scripts/build-webkit:
1384
1385 2010-07-20  Adam Roben  <aroben@apple.com>
1386
1387         Windows build fix
1388
1389         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
1390
1391 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
1392
1393         Reviewed by Geoffrey Garen.
1394
1395         WebScriptObject Should Allow Safely Checking For Key Existence
1396         https://bugs.webkit.org/show_bug.cgi?id=42613
1397
1398         Normal ObjCController workflow for a WebScriptObject test.
1399
1400         * DumpRenderTree/mac/ObjCController.m:
1401         (+[ObjCController isSelectorExcludedFromWebScript:]):
1402         (+[ObjCController webScriptNameForSelector:]):
1403         (-[ObjCController testHasWebScriptKey:]):
1404
1405 2010-07-20  Chris Marrin  <cmarrin@apple.com>
1406
1407         Reviewed by Simon Fraser.
1408
1409         https://bugs.webkit.org/show_bug.cgi?id=42118
1410         Disable compositing/webgl tests if WebGL is not enabled
1411
1412         * Scripts/old-run-webkit-tests:
1413
1414 2010-07-20  Anton Muhin  <antonm@chromium.org>
1415
1416         Reviewed by Darin Adler.
1417
1418         Print additional information about exception if failed to connect to apache (in verbose mode).
1419         https://bugs.webkit.org/show_bug.cgi?id=42627
1420
1421         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1422
1423 2010-07-20  Tony Chang  <tony@chromium.org>
1424
1425         Reviewed by David Levin.
1426
1427         [chromium] only pass --force to gclient sync if explicitly stated
1428         https://bugs.webkit.org/show_bug.cgi?id=42581
1429
1430         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
1431               always pass --force since it's hard to do manual cleanups
1432         * Scripts/update-webkit-chromium: only pass --force if --force is
1433               passed in
1434
1435 2010-07-19  Anders Carlsson  <andersca@apple.com>
1436
1437         Fix build.
1438
1439         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1440         Paths of generated files should be relative to the build product.
1441
1442 2010-07-19  Daniel Bates  <dbates@rim.com>
1443
1444         Reviewed by Adam Roben.
1445
1446         [Win] Implement LayoutTestController::markerTextForListItem()
1447         https://bugs.webkit.org/show_bug.cgi?id=37930
1448
1449         Implements DRT support for markerTextForListItem in the Windows port.
1450
1451         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1452         (LayoutTestController::markerTextForListItem): Implemented.
1453
1454 2010-07-19  Jessie Berlin  <jberlin@apple.com>
1455
1456         Windows build fix. Unreviewed.
1457
1458         * WebKitTestRunner/win/TestControllerWin.cpp:
1459         (WTR::TestController::initializeTestPluginPath):
1460
1461 2010-07-19  Sam Weinig  <sam@webkit.org>
1462
1463         Reviewed by Jon Honeycutt.
1464
1465         Remove dependency on getopt from WebKitTestRunner.
1466
1467         - Simplify options parsing and eliminate unused options.
1468
1469         * WebKitTestRunner/TestController.cpp:
1470         (WTR::TestController::TestController):
1471         (WTR::TestController::initialize):
1472         * WebKitTestRunner/TestController.h:
1473         (WTR::TestController::testPluginPath):
1474         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1475         * WebKitTestRunner/mac/TestControllerMac.mm:
1476         (WTR::TestController::platformInitialize):
1477         (WTR::TestController::initializeTestPluginPath):
1478         * WebKitTestRunner/win/TestControllerWin.cpp:
1479         (WTR::TestController::platformInitialize):
1480         (WTR::TestController::initializeTestPluginPath):
1481
1482 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
1483
1484         Reviewed by Antonio Gomes.
1485
1486         [Qt] MiniBrowser: Progress indication at address bar
1487         https://bugs.webkit.org/show_bug.cgi?id=42565
1488
1489         Make possible to see load progress at address bar based on
1490         QtTestBrowser solution
1491
1492         * MiniBrowser/qt/BrowserWindow.cpp:
1493         (BrowserWindow::BrowserWindow):
1494         (BrowserWindow::loadProgress):
1495         * MiniBrowser/qt/BrowserWindow.h:
1496
1497 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
1498
1499         Reviewed by Antonio Gomes.
1500
1501         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
1502         https://bugs.webkit.org/show_bug.cgi?id=42564
1503
1504         * MiniBrowser/qt/BrowserWindow.cpp:
1505         (BrowserView::load):
1506         (BrowserWindow::BrowserWindow):
1507         (BrowserWindow::titleChanged):
1508         (BrowserWindow::urlChanged):
1509         * MiniBrowser/qt/BrowserWindow.h:
1510
1511 2010-07-19  Sam Weinig  <weinig@apple.com>
1512
1513         Reviewed by Adam Roben.
1514
1515         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
1516         Auto-generate the JS bindings for WebKitTestRunner's script objects.
1517
1518         * WebKitTestRunner/Configurations/Base.xcconfig:
1519         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1520         * WebKitTestRunner/DerivedSources.make: Added.
1521         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
1522         * WebKitTestRunner/InjectedBundle/Bindings: Added.
1523         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
1524         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
1525         (WTR::JSWrappable::~JSWrappable):
1526         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
1527         (WTR::JSWrapper::wrap):
1528         (WTR::JSWrapper::unwrap):
1529         (WTR::unwrapObject):
1530         (WTR::JSWrapper::initialize):
1531         (WTR::JSWrapper::finalize):
1532         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
1533         (WTR::toJS):
1534         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
1535         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1536         (WTR::InjectedBundlePage::dump):
1537         (WTR::InjectedBundlePage::setStatusbarText):
1538         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1539         (WTR::LayoutTestController::wrapperClass):
1540         (WTR::LayoutTestController::waitUntilDone):
1541         (WTR::LayoutTestController::makeWindowObject):
1542         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1543         (WTR::LayoutTestController::shouldDumpAsText):
1544         (WTR::LayoutTestController::dumpAsText):
1545         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
1546         (WTR::LayoutTestController::dumpStatusCallbacks):
1547         (WTR::LayoutTestController::waitToDump):
1548         (WTR::LayoutTestController::testRepaint):
1549         (WTR::LayoutTestController::repaintSweepHorizontally):
1550         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
1551         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1552         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
1553         * WebKitTestRunner/win/build-generated-files.sh: Added.
1554
1555 2010-07-19  Mark Rowe  <mrowe@apple.com>
1556
1557         Clean up the buildbot configuration a little.
1558
1559         * BuildSlaveSupport/build.webkit.org-config/config.json:
1560
1561 2010-07-19  Chris Marrin  <cmarrin@apple.com>
1562
1563         Reviewed by Darin Adler.
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=42118
1566         Disable WebGL on Leopard for now. 
1567
1568         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
1569         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
1570         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
1571         software OpenGL driver on machines without this support.
1572
1573         * Scripts/build-webkit:
1574
1575 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
1576
1577         Reviewed by Brady Eidson.
1578
1579         Fix MiniBrowser to update URL as you browse
1580         https://bugs.webkit.org/show_bug.cgi?id=42591
1581         
1582         Hook up various loading notifications to update the URL bar in MiniBrowser.
1583
1584         * MiniBrowser/mac/BrowserWindowController.m:
1585         (_didStartProvisionalLoadForFrame):
1586         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1587         (_didFailProvisionalLoadWithErrorForFrame):
1588         (_didCommitLoadForFrame):
1589         (_didFailLoadWithErrorForFrame):
1590         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1591         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
1592         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
1593         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
1594         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
1595         (-[BrowserWindowController didCommitLoadForFrame:]):
1596
1597 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
1598
1599         Reviewed by Darin Adler.
1600
1601         https://bugs.webkit.org/show_bug.cgi?id=42586
1602         Log all canceled authentication attempts in DumpRenderTree
1603
1604         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1605         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1606         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1607         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1608         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
1609         case.
1610
1611 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1612
1613         Unreviewed, rolling out r63671.
1614         http://trac.webkit.org/changeset/63671
1615         https://bugs.webkit.org/show_bug.cgi?id=42575
1616
1617         broke windows (Requested by weinig on #webkit).
1618
1619         * WebKitTestRunner/Configurations/Base.xcconfig:
1620         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1621         * WebKitTestRunner/DerivedSources.make: Removed.
1622         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
1623         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
1624         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
1625         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
1626         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
1627         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
1628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1629         (WTR::InjectedBundlePage::dump):
1630         (WTR::InjectedBundlePage::setStatusbarText):
1631         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1632         (WTR::LayoutTestController::setWaitToDump):
1633         (WTR::displayCallback):
1634         (WTR::dumpAsTextCallback):
1635         (WTR::dumpStatusCallbacksCallback):
1636         (WTR::waitUntilDoneCallback):
1637         (WTR::notifyDoneCallback):
1638         (WTR::numberOfActiveAnimationsCallback):
1639         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
1640         (WTR::repaintSweepHorizontallyCallback):
1641         (WTR::testRepaintCallback):
1642         (WTR::layoutTestControllerObjectFinalize):
1643         (WTR::LayoutTestController::makeWindowObject):
1644         (WTR::LayoutTestController::getJSClass):
1645         (WTR::LayoutTestController::staticFunctions):
1646         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1647         (WTR::LayoutTestController::dumpAsText):
1648         (WTR::LayoutTestController::setDumpAsText):
1649         (WTR::LayoutTestController::dumpStatusCallbacks):
1650         (WTR::LayoutTestController::setDumpStatusCallbacks):
1651         (WTR::LayoutTestController::setTestRepaint):
1652         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
1653         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1654
1655 2010-07-19  Sam Weinig  <sam@webkit.org>
1656
1657         Reviewed by Adam Roben.
1658
1659         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
1660         Auto-generate the JS bindings for WebKitTestRunner's script objects.
1661
1662         * WebKitTestRunner/Configurations/Base.xcconfig:
1663         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1664         * WebKitTestRunner/DerivedSources.make: Added.
1665         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
1666         * WebKitTestRunner/InjectedBundle/Bindings: Added.
1667         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
1668         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
1669         (WTR::JSWrappable::~JSWrappable):
1670         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
1671         (WTR::JSWrapper::wrap):
1672         (WTR::JSWrapper::unwrap):
1673         (WTR::unwrapObject):
1674         (WTR::JSWrapper::initialize):
1675         (WTR::JSWrapper::finalize):
1676         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
1677         (WTR::toJS):
1678         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
1679         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1680         (WTR::InjectedBundlePage::dump):
1681         (WTR::InjectedBundlePage::setStatusbarText):
1682         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1683         (WTR::LayoutTestController::wrapperClass):
1684         (WTR::LayoutTestController::waitUntilDone):
1685         (WTR::LayoutTestController::makeWindowObject):
1686         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1687         (WTR::LayoutTestController::shouldDumpAsText):
1688         (WTR::LayoutTestController::dumpAsText):
1689         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
1690         (WTR::LayoutTestController::dumpStatusCallbacks):
1691         (WTR::LayoutTestController::waitToDump):
1692         (WTR::LayoutTestController::testRepaint):
1693         (WTR::LayoutTestController::repaintSweepHorizontally):
1694         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1695
1696 2010-07-19  Tony Chang  <tony@chromium.org>
1697
1698         Reviewed by David Levin.
1699
1700         fix chromium linux compile on ubuntu maverick
1701         https://bugs.webkit.org/show_bug.cgi?id=42528
1702
1703         * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
1704
1705 2010-07-19  Adam Roben  <aroben@apple.com>
1706
1707         When dumping a response's MIME type, print its URL's last path
1708         component rather than its suitable-for-test-result form
1709
1710         This matches the Mac behavior.
1711
1712         Fixes <http://webkit.org/b/42276>
1713         http/tests/loading/preload-slow-loading.php and
1714         http/tests/mime/uppercase-mime-type.html fail on Windows
1715
1716         Reviewed by Anders Carlsson.
1717
1718         * DumpRenderTree/win/DumpRenderTree.cpp:
1719         (urlSuitableForTestResult): Moved code to actually extract the last
1720         path component from here...
1721         (lastPathComponent): ...to here.
1722
1723         * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
1724
1725         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1726         (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
1727         component, rather than its suitable-for-test-result form, to match
1728         Mac.
1729
1730 2010-07-19  Anders carlsson  <andersca@apple.com>
1731
1732         Reviewed by Adam Roben.
1733
1734         WebKit2 does not have application cache
1735         https://bugs.webkit.org/show_bug.cgi?id=42552
1736
1737         * WebKitTestRunner/TestInvocation.cpp:
1738         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1739         Set up default preferences. Right now just enables the web application cache.
1740
1741         (WTR::TestInvocation::invoke):
1742         Call resetPreferencesToConsistentValues.
1743
1744         * WebKitTestRunner/TestInvocation.h:
1745
1746 2010-07-19  Kent Tamura  <tkent@chromium.org>
1747
1748         Reviewed by Adam Roben.
1749
1750         Fix NewRunWebKitTests to work on Windows.
1751         https://bugs.webkit.org/show_bug.cgi?id=41180
1752
1753         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1754           Specifying python explicitly.
1755
1756 2010-07-18  Anders Carlsson  <andersca@apple.com>
1757
1758         Reviewed by Dan Bernstein.
1759
1760         Add dumping of statusbar text to WebKitTestRunner
1761         https://bugs.webkit.org/show_bug.cgi?id=42516
1762
1763         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1764         (WTR::InjectedBundlePage::InjectedBundlePage):
1765         (WTR::InjectedBundlePage::_setStatusbarText):
1766         (WTR::InjectedBundlePage::setStatusbarText):
1767         Dump the statusbar text.
1768
1769         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1770         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1771         (WTR::LayoutTestController::LayoutTestController):
1772         Initialize m_dumpStatusCallbacks to false.
1773
1774         (WTR::dumpStatusCallbacksCallback):
1775         Implement JSC callback.
1776
1777         (WTR::LayoutTestController::staticFunctions):
1778         Add dumpStatusCallbacks.
1779
1780         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1781         (WTR::LayoutTestController::dumpStatusCallbacks):
1782         (WTR::LayoutTestController::setDumpStatusCallbacks):
1783         Add setter and getter for m_dumpStatusCallbacks.
1784
1785 2010-07-17  Anders Carlsson  <andersca@apple.com>
1786
1787         Reviewed by Maciej Stachowiak.
1788
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::TestController::initialize):
1791         Get the test plug-in path and set it on the context.
1792
1793         * WebKitTestRunner/TestController.h:
1794         * WebKitTestRunner/mac/TestControllerMac.mm:
1795         (WTR::TestController::initializeInjectedBundlePath):
1796         Simplify this code by using NSBundle.
1797
1798         (WTR::TestController::testPluginPath):
1799         Return the test plug-in path.
1800
1801         * WebKitTestRunner/win/TestControllerWin.cpp:
1802         (WTR::TestController::testPluginPath):
1803         Ditto.
1804
1805 2010-07-16  Adam Barth  <abarth@webkit.org>
1806
1807         Reviewed by Eric Seidel.
1808
1809         Teach webkitpy about queues.webkit.org
1810         https://bugs.webkit.org/show_bug.cgi?id=42492
1811
1812         * Scripts/webkitpy/common/net/statusserver.py:
1813
1814 2010-07-16  Ada Chan  <adachan@apple.com>
1815
1816         Reviewed by Alice Liu.
1817
1818         Fix Windows build.
1819
1820         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
1821
1822 2010-07-16  Sam Weinig  <sam@webkit.org>
1823
1824         Reviewed by Anders Carlsson.
1825
1826         Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
1827         <rdar://problem/8197701>
1828         Add notification of when the BackForwardList changes
1829         to aid invalidation of Back/Forward related UI elements.
1830
1831         * MiniBrowser/mac/BrowserWindowController.m:
1832         (_didStartProvisionalLoadForFrame):
1833         (_didCommitLoadForFrame):
1834         (_didFailLoadWithErrorForFrame):
1835         (_didChangeBackForwardList):
1836         (-[BrowserWindowController awakeFromNib]):
1837         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1838
1839 2010-07-16  Kent Tamura  <tkent@chromium.org>
1840
1841         Reviewed by Darin Fisher.
1842
1843         [Chromium] <input type=number> UI implementation for Windows
1844         https://bugs.webkit.org/show_bug.cgi?id=42259
1845
1846         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1847         (WebThemeEngineDRT::paintSpinButton):
1848          Added. Check state consistency and use existing arrow painting code.
1849         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1850
1851 2010-07-16  Alice Liu  <alice.liu@apple.com>
1852
1853         Reviewed by Sam Weinig.
1854
1855         https://bugs.webkit.org/show_bug.cgi?id=42430
1856         Make WebKitTestRunner on Windows actually load and run a test
1857
1858         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
1859         (WKBundleInitialize):
1860         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added.  Output is a dll.
1861         * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
1862         (WTR::createWKURL):
1863         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
1864         other existing checks, and avoid including Platform.h
1865         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1866         (WTR::registerWindowClass): Added.
1867         (WTR::PlatformWebView::PlatformWebView): Implemented.
1868         (WTR::PlatformWebView::~PlatformWebView): Implemented.
1869         (WTR::PlatformWebView::page): Implemented.
1870         * WebKitTestRunner/win/TestControllerWin.cpp:
1871         (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 
1872         configuration specific path to InjectedBundle.dll.
1873         * WebKitTestRunner/win/TestInvocationWin.cpp:
1874         (WTR::TestInvocation::runUntil): Implemented.
1875         * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
1876         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
1877
1878 2010-07-16  Brady Eidson  <beidson@apple.com>
1879
1880         Reviewed by Sam Weinig.
1881
1882         Make revalidation of back/forward work a little better with page loads
1883         https://bugs.webkit.org/show_bug.cgi?id=42470
1884
1885         * MiniBrowser/mac/BrowserWindow.xib:
1886         * MiniBrowser/mac/BrowserWindowController.h:
1887         * MiniBrowser/mac/BrowserWindowController.m:
1888         (-[BrowserWindowController validateToolbar]):
1889         (_didStartProvisionalLoadForFrame):
1890         (_didCommitLoadForFrame):
1891         (_didFailLoadWithErrorForFrame):
1892
1893 2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
1894
1895         Reviewed by Dirk Schulze.
1896
1897         Add possibility to dumpAsText and generate a pixel test result
1898         https://bugs.webkit.org/show_bug.cgi?id=42374
1899
1900         Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
1901         setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
1902
1903         This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
1904         At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
1905
1906         Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
1907         (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
1908
1909         * DumpRenderTree/LayoutTestController.cpp:
1910         (LayoutTestController::LayoutTestController):
1911         (dumpAsTextAndPixelsCallback):
1912         (LayoutTestController::staticFunctions):
1913         * DumpRenderTree/LayoutTestController.h:
1914         (LayoutTestController::dumpAsTextAndPixels):
1915         (LayoutTestController::setDumpAsTextAndPixels):
1916         * DumpRenderTree/chromium/LayoutTestController.cpp:
1917         (LayoutTestController::LayoutTestController):
1918         (LayoutTestController::dumpAsTextAndPixels):
1919         (LayoutTestController::reset):
1920         * DumpRenderTree/chromium/LayoutTestController.h:
1921         (LayoutTestController::shouldDumpAsTextAndPixels):
1922         * DumpRenderTree/chromium/TestShell.cpp:
1923         (TestShell::dump):
1924         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1925         (dump):
1926         * DumpRenderTree/mac/DumpRenderTree.mm:
1927         (dump):
1928         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1929         (WebCore::DumpRenderTree::dump):
1930         * DumpRenderTree/win/DumpRenderTree.cpp:
1931         (dump):
1932         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1933         (dump):
1934
1935 2010-07-16  Kent Hansen  <kent.hansen@nokia.com>
1936
1937         Unreviewed. Adding myself as committer.
1938
1939         * Scripts/webkitpy/common/config/committers.py:
1940
1941 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
1942
1943         Another uneviewed attempt to fix build.
1944
1945         Printing test results differ between machines, we should use ImageDiff instead
1946         https://bugs.webkit.org/show_bug.cgi?id=20011
1947
1948         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1949         (createPagedBitmapContext):
1950
1951 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
1952
1953         Unreviewed tiger build fix.
1954
1955         Printing test results differ between machines, we should use ImageDiff instead
1956         https://bugs.webkit.org/show_bug.cgi?id=20011
1957
1958         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1959         (createBitmapContext):
1960         (createBitmapContextFromWebView):
1961
1962 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
1963
1964         Unreviewed build fix.
1965
1966         Printing test results differ between machines, we should use ImageDiff instead
1967         https://bugs.webkit.org/show_bug.cgi?id=20011
1968
1969         * DumpRenderTree/PixelDumpSupport.cpp:
1970         (dumpWebViewAsPixelsAndCompareWithExpected):
1971
1972 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
1973
1974         Reviewed by Darin Adler.
1975
1976         Printing test results differ between machines, we should use ImageDiff instead
1977         https://bugs.webkit.org/show_bug.cgi?id=20011
1978
1979         * DumpRenderTree/PixelDumpSupport.cpp:
1980         (dumpWebViewAsPixelsAndCompareWithExpected):
1981         * DumpRenderTree/PixelDumpSupport.h:
1982         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1983         (createBitmapContext): This function was added to share bitmap context creation code.
1984         (createBitmapContextFromWebView):
1985         (createPagedBitmapContext):
1986
1987 2010-07-15  Yuta Kitamura  <yutak@chromium.org>
1988
1989         Reviewed by Kent Tamura.
1990
1991         Pull in pywebsocket-0.5.1
1992         https://bugs.webkit.org/show_bug.cgi?id=42353
1993
1994         pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
1995         in Chromium. There is no other functional change.
1996
1997         (*) http://code.google.com/p/pywebsocket/source/detail?r=265
1998
1999         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
2000
2001 2010-07-15  Brady Eidson  <beidson@apple.com>
2002
2003         Reviewed by Sam Weinig.
2004
2005         Add toolbar and toolbar item validation for MiniBrowser
2006         https://bugs.webkit.org/show_bug.cgi?id=42422
2007
2008         * MiniBrowser/MBToolbarItem.h: Added.
2009         * MiniBrowser/MBToolbarItem.m: Added.
2010         (-[MBToolbarItem validate]):
2011
2012         * MiniBrowser/mac/BrowserWindowController.m:
2013         (-[BrowserWindowController validateUserInterfaceItem:]):
2014
2015         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2016         * MiniBrowser/mac/BrowserWindow.xib:
2017
2018 2010-07-15  Victor Wang  <victorw@chromium.org>
2019
2020         Unreviewed, add victorw irc nickname to committer list.
2021
2022         * Scripts/webkitpy/common/config/committers.py:
2023
2024 2010-07-15  Adam Roben  <aroben@apple.com>
2025
2026         Make killing Apache more reliable (on both Mac and Windows)
2027
2028         We previously had two ways of determining whether we had succeeded in
2029         killing Apache:
2030           1) checking the return value of kill(0, $apachePID)
2031           2) checking whether Apache's PID file still exists
2032
2033         On Cygwin, Apache doesn't always delete its PID file when it exits,
2034         making (2) unreliable. We unfortunately misdiagnosed this as an
2035         impotency of Perl's kill function, which led to r63177 and r63355.
2036
2037         Now that we know that the real problem is that Apache doesn't always
2038         delete its PID file on Windows, we can make a much better fix: always
2039         use method (1) to determine whether we've killed Apache.
2040
2041         Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
2042         leading to regression test failures (and general annoyance).
2043
2044         Reviewed by Anders Carlsson.
2045
2046         * Scripts/webkitperl/httpd.pm:
2047         (openHTTPD): Moved killing code from here to killHTTPD. Added a call
2048         to delete the PID file in case Apache doesn't do this itself when
2049         killed. Our later logic relies on the PID file being deleted after
2050         this point.
2051         (closeHTTPD): Removed killing logic and changed to just call killHTTPD
2052         instead. killHTTPD's logic is a bit different from the logic we had
2053         here, for the reasons stated above.
2054         (killHTTPD): Added. Code came from openHTTPD.
2055         (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
2056         On Mac, don't try to kill Apache when we receive a signal, as Apache
2057         will already have been killed by this point (though for some reason
2058         this isn't detected by our killing logic in killHTTPD). On Cygwin, we
2059         still need to kill Apache manually.
2060
2061 2010-07-15  Sam Weinig  <sam@webkit.org>
2062
2063         Reviewed by Anders Carlsson.
2064
2065         Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
2066         Update MiniBrowser for WKFrameNavigationType 
2067
2068         * MiniBrowser/mac/BrowserWindowController.m:
2069         (_decidePolicyForNavigationAction):
2070         (_decidePolicyForNewWindowAction):
2071
2072 2010-07-15  Stephanie Lewis  <slewis@apple.com>
2073
2074         Reviewed by Geoff Garen.
2075
2076         http://bugs.webkit.org/show_bug.cgi?id=42406
2077         Make SunSpider work better with roots.
2078
2079         * Scripts/sunspider-compare-results: fix argument bug
2080         * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
2081
2082 2010-07-15  Brady Eidson  <beidson@apple.com>
2083
2084         Reviewed by Sam Weinig.
2085
2086         Hook up back/forward in MiniBrowser
2087         https://bugs.webkit.org/show_bug.cgi?id=42397
2088
2089         * MiniBrowser/mac/BrowserWindow.xib:
2090         * MiniBrowser/mac/BrowserWindowController.h:
2091         * MiniBrowser/mac/BrowserWindowController.m:
2092         (-[BrowserWindowController goBack:]):
2093         (-[BrowserWindowController goForward:]):
2094
2095 2010-07-15  Daniel Bates  <dbates@rim.com>
2096
2097         Reviewed by Darin Adler.
2098
2099         [Mac] Implement LayoutTestController::markerTextForListItem()
2100         https://bugs.webkit.org/show_bug.cgi?id=37929
2101
2102         Implements DRT support for markerTextForListItem in the Mac port.
2103
2104         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2105         (LayoutTestController::markerTextForListItem): Implemented.
2106
2107 2010-07-15  Adam Barth  <abarth@webkit.org>
2108
2109         Unreviewed.
2110
2111         Update the port names to be more specific.  Before this patch,
2112         port-specific results for Mac would end up in the wrong place.
2113
2114         * Scripts/webkitpy/tool/commands/rebaseline.py:
2115         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2116
2117 2010-07-14  Eric Seidel  <eric@webkit.org>
2118
2119         Reviewed by Adam Barth.
2120
2121         WebKit needs a rebaselining tool (finally)
2122         https://bugs.webkit.org/show_bug.cgi?id=42339
2123
2124         This is a very basic rebaselining tool.  It's not
2125         quite as fancy as chromium's as it will only handle
2126         updating failing results.  It cannot yet handle adding new
2127         results, or updating results where the results should not
2128         replace existing results.
2129
2130         * Scripts/webkitpy/layout_tests/port/base.py:
2131         * Scripts/webkitpy/tool/commands/__init__.py:
2132         * Scripts/webkitpy/tool/commands/queries.py:
2133         * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
2134         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
2135
2136 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2137
2138         Unreviewed, rolling out r63352.
2139         http://trac.webkit.org/changeset/63352
2140         https://bugs.webkit.org/show_bug.cgi?id=42341
2141
2142         Broke plugin-initiate-popup-window.html and plugin-javascript-
2143         access.html on snow leopard (Requested by abarth on #webkit).
2144
2145         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2146         (pluginAllocate):
2147         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2148         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2149         (NPP_New):
2150         (handleEventCarbon):
2151         (handleEventCocoa):
2152
2153 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
2154
2155         Reviewed by Mark Rowe.
2156
2157         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
2158
2159         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2160
2161 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2162
2163         Unreviewed, rolling out r63346.
2164         http://trac.webkit.org/changeset/63346
2165         https://bugs.webkit.org/show_bug.cgi?id=42295
2166
2167         Broke lots of tests, some of which probably just need new
2168         results (Requested by aroben on #webkit).
2169
2170         * DumpRenderTree/win/DumpRenderTree.cpp:
2171         (urlSuitableForTestResult):
2172
2173 2010-07-14  Adam Roben  <aroben@apple.com>
2174
2175         Speed up killing of Apache on Windows
2176
2177         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
2178         run-webkit-tests) takes a long time on Windows
2179
2180         Reviewed by Darin Adler and Jon Honeycutt.
2181
2182         * Scripts/webkitperl/httpd.pm:
2183         (closeHTTPD): Use taskkill to kill Apache and its child processes.
2184         Perl's kill seems ineffectual. We were already using taskkill, but
2185         only after trying kill 20 times. Since kill never works, let's just
2186         skip it entirely.
2187
2188 2010-07-14  Johnny Ding  <jnd@chromium.org>
2189
2190         Reviewed by Adam Barth.
2191
2192         https://bugs.webkit.org/show_bug.cgi?id=41292
2193         Add a new parameter to the test plugin to allow to specify a script and a
2194         mouse/keyboard event. The specified script will be evaluated in the browser
2195         when the specified event is received by the plugin.
2196
2197         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2198         (pluginAllocate):
2199         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2200         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2201         (NPP_New):
2202         (handleEventCarbon):
2203         (handleEventCocoa):
2204
2205 2010-07-14  Adam Roben  <aroben@apple.com>
2206
2207         Make urlSuitableForTestResult work for http: URLs, too
2208
2209         Fixes <http://webkit.org/b/42276>
2210         http/tests/loading/preload-slow-loading.php and
2211         http/tests/mime/uppercase-mime-type.html fail on Windows.
2212
2213         Reviewed by Darin Adler.
2214
2215         * DumpRenderTree/win/DumpRenderTree.cpp:
2216         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
2217         We want this function to work for those URLs, too!
2218
2219 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
2220
2221         Reviewed by Oliver Hunt.
2222
2223         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
2224         https://bugs.webkit.org/show_bug.cgi?id=42227
2225
2226         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2227         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
2228         members.
2229         (WTR::LayoutTestController::display): Dummy method.
2230         (WTR::displayCallback): Call the dummy.
2231         (WTR::repaintSweepHorizontallyCallback): ditto
2232         (WTR::testRepaintCallback): ditto
2233         (WTR::LayoutTestController::staticFunctions): Expose new methods.
2234         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2235         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
2236         nothing).
2237         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
2238
2239 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
2240
2241         Unreviewed. Adding myself as committer.
2242
2243         * Scripts/webkitpy/common/config/committers.py:
2244
2245 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2246
2247         Reviewed by Darin Adler.
2248
2249         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
2250
2251         https://bugs.webkit.org/show_bug.cgi?id=30879
2252
2253         MainResourceLoader uses the member m_initialRequest to store requests for future
2254         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
2255         have to clear this request so that subsequent entries into the loader will not
2256         start yet another load.
2257
2258         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
2259         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
2260         but only in the case of using both substitute-data and non-deferred main resource
2261         load together. That's why two new DRT functions were added:
2262
2263          * queueLoadHTMLString()
2264          * setDeferMainResourceLoad()
2265
2266         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
2267         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
2268         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
2269
2270         * DumpRenderTree/LayoutTestController.cpp:
2271         (LayoutTestController::LayoutTestController):
2272         (queueLoadHTMLStringCallback):
2273         (setDeferMainResourceDataLoadCallback):
2274         (LayoutTestController::staticFunctions):
2275         (LayoutTestController::queueLoadHTMLString):
2276         * DumpRenderTree/LayoutTestController.h:
2277         (LayoutTestController::deferMainResourceDataLoad):
2278         (LayoutTestController::setDeferMainResourceDataLoad):
2279         * DumpRenderTree/WorkQueueItem.h:
2280         (LoadHTMLStringItem::LoadHTMLStringItem):
2281         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2282         (LoadHTMLStringItem::invoke):
2283         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2284         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2285         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2286         (LoadHTMLStringItem::invoke):
2287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2288         (LayoutTestController::reset):
2289         (LayoutTestController::setDeferMainResourceDataLoad):
2290         (LayoutTestController::queueLoadHTMLString):
2291         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2292         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2293         (LoadHTMLStringItem::invoke):
2294         * DumpRenderTree/qt/WorkQueueItemQt.h:
2295         (LoadHTMLStringItem::LoadHTMLStringItem):
2296         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2297         (ResourceLoadDelegate::willSendRequest):
2298         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2299         (LoadHTMLStringItem::invoke):
2300         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
2301         (LoadHTMLStringItem::invoke):
2302
2303 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
2304
2305         Reviewed by Nikolas Zimmermann.
2306
2307         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
2308         https://bugs.webkit.org/show_bug.cgi?id=42153
2309
2310         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
2311         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2312         (WTR::InjectedBundle::initialize): Activate fonts on startup.
2313         * WebKitTestRunner/InjectedBundle/mac: Added.
2314         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
2315         (WTR::activateFonts): Activate our fonts.
2316         * WebKitTestRunner/InjectedBundle/win: Added.
2317         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
2318         (WTR::activateFonts): Dummy version.
2319         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
2320         add more files.
2321         * WebKitTestRunner/fonts: Added.
2322         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
2323         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
2324         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
2325         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
2326         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
2327         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
2328         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
2329         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
2330         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
2331         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
2332         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
2333         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
2334         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
2335         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
2336
2337 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
2338
2339         Reviewed by Eric Seidel.
2340
2341         Remove check-header-includes, as it didn't turn out to be very useful.
2342         https://bugs.webkit.org/show_bug.cgi?id=41970
2343
2344         * Scripts/check-header-includes: Removed.
2345
2346 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
2347
2348         Reviewed by Maciej Stachowiak.
2349
2350         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
2351         https://bugs.webkit.org/show_bug.cgi?id=40922
2352         
2353         Always build WebKit2 on Windows. Necessary since our WebKit build on
2354         Windows is packaged into a DLL with WebKit2.
2355
2356         * Scripts/build-webkit: Always build WebKit2 on Windows.
2357
2358 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
2359
2360         Reviewed by Steve Falkenburg.
2361
2362         One http test timing out on Windows can cause all future tests to time out
2363         https://bugs.webkit.org/show_bug.cgi?id=42146
2364         
2365         There have been multiple times on the Windows bots where one http test timing out causes all future
2366         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
2367         times out, we should restart httpd on Cygwin to prevent this.
2368
2369         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
2370         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
2371             using kill fails.
2372
2373 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
2374
2375         Reviewed by Dan Bernstein.
2376
2377         Remove use of auto_ptr in WebKitTestRunner
2378         https://bugs.webkit.org/show_bug.cgi?id=42134
2379         
2380         Replaced auto_ptr with PassOwnPtr / OwnPtr.
2381
2382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2383         (WTR::WKStringToUTF8):
2384         (WTR::InjectedBundlePage::dump):
2385         (WTR::InjectedBundlePage::addMessageToConsole):
2386         * WebKitTestRunner/TestInvocation.cpp:
2387         (WTR::WKStringToUTF8):
2388         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
2389
2390 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
2391
2392         Reviewed by Sam Weinig.
2393
2394         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
2395         https://bugs.webkit.org/show_bug.cgi?id=42132
2396
2397         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
2398         platform directories.
2399
2400 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
2401
2402         Reviewed by Anders Carlsson.
2403
2404         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
2405         https://bugs.webkit.org/show_bug.cgi?id=42126
2406
2407         * WebKitTestRunner/PlatformWebView.h:
2408         * WebKitTestRunner/TestInvocation.cpp:
2409         (WTR::TestInvocation::TestInvocation): Store the path as a C
2410         string for later use.
2411         (WTR::TestInvocation::~TestInvocation):
2412         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
2413         size, depending on whether this is a W3C SVG test.
2414         (WTR::TestInvocation::invoke): Call the size function.
2415         * WebKitTestRunner/TestInvocation.h:
2416         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2417         (WTR::PlatformWebView::resizeTo): Implement.
2418         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2419         (WTR::PlatformWebView::resizeTo): Placeholder.
2420
2421 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
2422
2423         Reviewed by Xan Lopez.
2424
2425         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
2426         https://bugs.webkit.org/show_bug.cgi?id=38648
2427
2428         Add the GTK_MODULES envvar (set to "gail") to the clean
2429         environment when running DRT for the Gtk+ port
2430
2431         * Scripts/old-run-webkit-tests:
2432
2433 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
2434
2435         Reviewed by Dirk Schulze.
2436
2437         [GTK] Support pixel tests
2438         https://bugs.webkit.org/show_bug.cgi?id=31518
2439
2440         Finish support for pixel tests on GTK+.
2441
2442         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
2443         works on CoreFoundation systems) and add missing cstdio include.
2444         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
2445         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
2446         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
2447         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
2448         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
2449         by the ANSI standard and this fails on Linux, so unroll the loop here.
2450         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
2451         (BitmapContext::BitmapContext): There is no reason to check the value of the
2452         m_context member in the constructor and it certainly should not be freed. Instead
2453         just initialize it with the incoming value.
2454         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
2455         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
2456         dump pixels.
2457         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
2458         (createBitmapContextFromWebView):
2459         * GNUmakefile.am: Add new files to the build.
2460
2461 2010-07-12  Adam Barth  <abarth@webkit.org>
2462
2463         Unreviewed.
2464
2465         Remove stray "raise e" that got included in a previous patch.  This
2466         caused the EWS bots to turn red instead of purple when a patch failed
2467         to apply.
2468
2469         * Scripts/webkitpy/tool/commands/stepsequence.py:
2470
2471 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2472
2473         Unreviewed, rolling out r63101.
2474         http://trac.webkit.org/changeset/63101
2475         https://bugs.webkit.org/show_bug.cgi?id=42103
2476
2477         Broke one API test (Requested by xan_ on #webkit).
2478
2479         * Scripts/old-run-webkit-tests:
2480
2481 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
2482
2483         Reviewed by Adam Roben.
2484
2485         https://bugs.webkit.org/show_bug.cgi?id=13075
2486         XMLHttpRequest with failed authentication should set status to 401
2487
2488         https://bugs.webkit.org/show_bug.cgi?id=6871
2489         <rdar://problem/3363403> 401 error page is never shown
2490
2491         Fix crashes in Windows DumpRenderTree.
2492
2493         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2494         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
2495         again on a destroyed sender.
2496
2497 2010-07-12  Adam Roben  <aroben@apple.com>
2498
2499         Windows failure-to-launch fix
2500
2501         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
2502         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
2503         we already do for CoreFoundation, CFNetwork, etc.
2504
2505 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
2506
2507         Reviewed by Xan Lopez.
2508
2509         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
2510         https://bugs.webkit.org/show_bug.cgi?id=38648
2511
2512         Add the GTK_MODULES envvar (set to "gail") to the clean
2513         environment when running DRT for the Gtk+ port
2514
2515         * Scripts/old-run-webkit-tests:
2516
2517 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
2518
2519         Reviewed by Darin Adler.
2520
2521         https://bugs.webkit.org/show_bug.cgi?id=13075
2522         XMLHttpRequest with failed authentication should set status to 401
2523
2524         https://bugs.webkit.org/show_bug.cgi?id=6871
2525         <rdar://problem/3363403> 401 error page is never shown
2526
2527         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2528         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2529         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2530         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2531         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
2532         the Cancel button.
2533
2534 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
2535
2536         Reviewed by Tor Arne Vestbø.
2537
2538         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
2539         https://bugs.webkit.org/show_bug.cgi?id=42082
2540
2541         * QtTestBrowser/main.cpp:
2542         (LauncherWindow::createChrome):
2543         * QtTestBrowser/mainwindow.cpp:
2544         (MainWindow::openLocation):
2545         * QtTestBrowser/mainwindow.h:
2546
2547 2010-07-12  Adam Roben  <aroben@apple.com>
2548
2549         Make the Python autoinstaller not use a dead SourceForge server
2550
2551         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
2552         offline SourceForge server
2553
2554         Reviewed by Anders Carlsson.
2555
2556         * Scripts/webkitpy/thirdparty/__init__.py: Use
2557         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
2558         which seems to be down.
2559
2560 2010-07-12  Adam Roben  <aroben@apple.com>
2561
2562         Make run-webkit-tests print how many tests timed out when exiting
2563         early
2564
2565         The number of timed-out tests is taken into account when deciding
2566         whether to exit early. Leaving it out of the output just makes the
2567         script look buggy (because it might say something like "Exiting early
2568         after 0 crashes.").
2569
2570         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
2571         messages when exiting early due to crashes and time-outs
2572
2573         Reviewed by Anders Carlsson.
2574
2575         * Scripts/old-run-webkit-tests:
2576         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
2577         timed-out tests, too.
2578
2579 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
2580
2581         Reviewed by Dan Bernstein.
2582
2583         Implement animation-related methods for WebKitTestRunner
2584         https://bugs.webkit.org/show_bug.cgi?id=42053
2585         
2586         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
2587         animation tests were hanging otherwise.
2588
2589         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2590         (WTR::LayoutTestController::numberOfActiveAnimations):
2591         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2592         (WTR::numberOfActiveAnimationsCallback):
2593         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
2594         (WTR::LayoutTestController::staticFunctions):
2595         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2596
2597 2010-07-11  Daniel Bates  <dbates@rim.com>
2598
2599         Reviewed by David Kilzer.
2600
2601         Enable executable support for svn-apply and svn-unapply
2602         https://bugs.webkit.org/show_bug.cgi?id=39409
2603
2604         Connect up the Git and SVN executable bit support in parseDiff() so that
2605         executable bit changes are propagated via the returned diff hash to the
2606         patch function in svn-apply and svn-unapply.
2607
2608         * Scripts/VCSUtils.pm:
2609           - Modified parseDiff() to call parseSvnDiffProperties when
2610             it finds the start of an SVN property change diff.
2611           - Removed FIXME comment above parseSvnDiffProperties() since
2612             it is now being used by parseDiff().
2613           - Export method scmToggleExecutableBit() now that we added the
2614             executableBitDelta hash key. (This should have been exported
2615             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
2616         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2617           - Updated results for:
2618             "rename (with executable bit change)"
2619               - Test value of executableBitDelta (now that we have support).
2620             "SVN: binary file (isBinary true)"
2621               - Remove the property change diff from svnConvertedText. We plan
2622                 to remove svnConvertedText in the future. So, we decided
2623                 against adding such support to any new code, such as the
2624                 property parsing routines. Therefore, we do not keep SVN
2625                 converted text for property change diffs.
2626           - Added unit tests:
2627             "SVN: file change diff with property change diff"
2628             "SVN: file change diff, followed by property change diff on different file"
2629             "SVN: property diff, followed by file change diff"
2630             "SVN: copied file with property change"
2631             "SVN: two consecutive property diffs"
2632             "SVN: binary file with executable bit change"
2633             "SVN: binary file followed by property change on different file"
2634             "SVN: binary file followed by file change on different file"
2635             "SVN: file change diff with property change, followed by property change diff"
2636             "SVN: file change diff with property change, followed by file change diff"
2637
2638 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
2639
2640         Reviewed by Dan Bernstein.
2641
2642         Implement waitUntilDone and notifyDone for WebKitTestRunner
2643         https://bugs.webkit.org/show_bug.cgi?id=42049
2644
2645         With this fix, most of the DOM tests pass.
2646         
2647         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2648         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
2649         a great way to do it in the future case where we may get multiple
2650         pages - we really need a way to send it over from the ui process.
2651         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2652         (WTR::InjectedBundle::page): A way to get the main page.
2653         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2654         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
2655         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
2656         are loading.
2657         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
2658         called by the layout test controller. Also, cancel any pending watchdogs.
2659         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
2660         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2661         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2662         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
2663         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2664         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
2665         to false.
2666         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
2667         the watchdog.
2668         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
2669         (WTR::LayoutTestController::setWaitToDump): Set the flag.
2670         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
2671         where waitUntilDone times out.
2672         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
2673         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
2674         (WTR::notifyDoneCallback): JS glue for notifyDone.
2675         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
2676         to the layoutController.
2677         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2678         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
2679
2680 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
2681
2682         Rubber-stamped by Dan Bernstein.
2683
2684         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
2685         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
2686         slow down the tests).
2687
2688         * Scripts/webkitpy/common/system/executive.py:
2689
2690 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
2691
2692         Reviewed by Kenneth Rohde Christiansen.
2693
2694         [Qt] Mac build fix
2695         https://bugs.webkit.org/show_bug.cgi?id=41967
2696
2697         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
2698
2699         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2700
2701 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
2702
2703         Reviewed by Antonio Gomes.
2704
2705         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
2706         https://bugs.webkit.org/show_bug.cgi?id=41966
2707
2708         * MiniBrowser/qt/BrowserWindow.cpp:
2709         (BrowserWindow::BrowserWindow):
2710
2711 2010-07-09  Leon Clarke  <leonclarke@google.com>
2712
2713         Reviewed by Adam Barth.
2714
2715         add support for link prefetching
2716         https://bugs.webkit.org/show_bug.cgi?id=3652
2717
2718         * Scripts/build-webkit:
2719
2720 2010-07-09  Ojan Vafai  <ojan@chromium.org>
2721
2722         Reviewed by Adam Barth.
2723
2724         r63004 broke some python tests
2725         https://bugs.webkit.org/show_bug.cgi?id=42007
2726
2727         AbstractStep now checks options.no_squash and options.squash, so
2728         they needed to have real values. Mock would return an object for those,
2729         which would then act as if the values were True.
2730
2731         * Scripts/webkitpy/tool/commands/commandtest.py:
2732         * Scripts/webkitpy/tool/commands/download_unittest.py:
2733         * Scripts/webkitpy/tool/commands/stepsequence.py:
2734         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2735         * Scripts/webkitpy/tool/mocktool.py:
2736         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2737         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2738         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2739         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2740         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2741
2742 2010-07-09  Ojan Vafai  <ojan@chromium.org>
2743
2744         Reviewed by Adam Barth.
2745
2746         --squash should go away and become the default
2747         https://bugs.webkit.org/show_bug.cgi?id=39624
2748
2749         If there are local commits and working copy changes, then prompt the user
2750         whether to continue. Setting git config webkit-patch.commit_should_always_squash
2751         true bypasses the prompt.
2752
2753         --git-commit=HEAD.. operates on working copy changes only.
2754         --git-commit=committish operates on a range of commits as a single commit.
2755             e.g. --git-commit=HEAD only operates on the HEAD commit.
2756             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
2757
2758         --no-squash and --squash are left in with descriptive error messages if used.
2759
2760         * Scripts/check-webkit-style:
2761         * Scripts/webkitpy/common/checkout/api.py:
2762         * Scripts/webkitpy/common/checkout/api_unittest.py:
2763         * Scripts/webkitpy/common/checkout/scm.py:
2764         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2765         * Scripts/webkitpy/common/net/rietveld.py:
2766         * Scripts/webkitpy/common/system/user.py:
2767         * Scripts/webkitpy/style/optparser.py:
2768         * Scripts/webkitpy/style_references.py:
2769         * Scripts/webkitpy/tool/commands/download.py:
2770         * Scripts/webkitpy/tool/commands/upload.py:
2771         * Scripts/webkitpy/tool/mocktool.py:
2772         * Scripts/webkitpy/tool/steps/abstractstep.py:
2773         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2774         * Scripts/webkitpy/tool/steps/checkstyle.py:
2775         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
2776         * Scripts/webkitpy/tool/steps/commit.py:
2777         * Scripts/webkitpy/tool/steps/options.py:
2778         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2779         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2780         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2781         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2782
2783 2010-07-09  Mark Rowe  <mrowe@apple.com>
2784
2785         Add two new Windows test build slaves.
2786
2787         * BuildSlaveSupport/build.webkit.org-config/config.json:
2788
2789 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
2790
2791         Reviewed by David Levin.
2792
2793         rebaseline_chromium_webkit_tests missing --use_drt option on linux
2794         https://bugs.webkit.org/show_bug.cgi?id=41985
2795
2796         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
2797         so that it works on linux. This is essentially a "compile-fix" for the
2798         script.
2799
2800         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2801
2802 2010-07-09  Nico Weber  <thakis@chromium.org>
2803
2804         Unreviewed. Adding myself as committer.
2805
2806         * Scripts/webkitpy/common/config/committers.py:
2807
2808 2010-07-09  David Kilzer  <ddkilzer@apple.com>
2809
2810         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
2811
2812         This reverts commit r62692.
2813
2814         * Scripts/commit-log-editor:
2815
2816 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
2817
2818         Reviewed by Ojan Vafai.
2819
2820         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
2821         https://bugs.webkit.org/show_bug.cgi?id=38693
2822
2823         Introduced a new base class JSONResultsGeneratorBase that doesn't
2824         have any dependency on layout_tests packages.
2825         Turned JSONResultsGenerator into a wrapper class of the base class
2826         so that the old code can work with it during the cleanup.
2827
2828         Added json_results_generator_unittest.py.
2829
2830         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2831         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2832         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
2833
2834 2010-07-09  Abhishek Arya  <inferno@chromium.org>
2835
2836         Unreviewed.
2837
2838         Marking myself as a committer.
2839
2840         * Scripts/webkitpy/common/config/committers.py:
2841
2842 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2843
2844         Reviewed by Antti Koivisto.
2845
2846         Implement MiniBrowser for Qt.
2847         https://bugs.webkit.org/show_bug.cgi?id=40233
2848
2849         * MiniBrowser/qt/BrowserWindow.cpp: Added.
2850         (createNewPage):
2851         (BrowserView::BrowserView):
2852         (BrowserView::resizeEvent):
2853         (BrowserView::load):
2854         (BrowserView::view):
2855         (BrowserWindow::BrowserWindow):
2856         (BrowserWindow::load):
2857         (BrowserWindow::changeLocation):
2858         (BrowserWindow::~BrowserWindow):
2859         * MiniBrowser/qt/BrowserWindow.h: Added.
2860         (BrowserView::~BrowserView):
2861         * MiniBrowser/qt/MiniBrowser.pro: Added.
2862         * MiniBrowser/qt/main.cpp: Added.
2863         (main):
2864
2865 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2866
2867         Reviewed by Simon Hausmann.
2868
2869         Introduce the Qt autotest launcher.
2870
2871         Qt autotests should be executed more frequently, ideally by the Qt
2872         build bot. This is the first step to provide the tests more accessible.
2873
2874         [Qt] It should be easier to run all Qt's autotests.
2875         https://bugs.webkit.org/show_bug.cgi?id=31625
2876
2877         * Scripts/run-qtwebkit-tests: Added.
2878
2879 2010-07-09  Adam Barth  <abarth@webkit.org>
2880
2881         Reviewed by Eric Seidel.
2882
2883         commit-queue should merge to TOT when checkout needs update
2884         https://bugs.webkit.org/show_bug.cgi?id=41944
2885
2886         There are a bunch of different designs that are possible here.  This
2887         one merges to top of tree by cleaning out the working copy and
2888         re-applying the patch.  Once you decide to merge that way, you need to
2889         decide who's going to retry.  In this patch, we retry in the child
2890         process instead of plumbing the failure reason to the master process.
2891
2892         This patch is difficult to test end-to-end, but hopefully it will work.
2893         :)
2894
2895         * Scripts/webkitpy/tool/commands/queues.py:
2896         * Scripts/webkitpy/tool/commands/stepsequence.py:
2897         * Scripts/webkitpy/tool/multicommandtool.py:
2898         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2899
2900 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
2901
2902         Reviewed by Darin Adler.
2903
2904         Add a script to check for unnecessary includes in header files.
2905         https://bugs.webkit.org/show_bug.cgi?id=41894
2906
2907         * Scripts/check-header-includes: Added.
2908
2909 2010-07-09  Adam Barth  <abarth@webkit.org>
2910
2911         Reviewed by Eric Seidel.
2912
2913         Add --html5-treebuilder option to run-webkit-tests
2914         https://bugs.webkit.org/show_bug.cgi?id=41922
2915
2916         We're down to one or two regressions in the HTML5lib test suite.  It's
2917         getting to be time to look at fixing LayoutTests.
2918
2919         * Scripts/old-run-webkit-tests:
2920
2921 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2922
2923         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
2924         in the drawing model never getting set on Tiger.
2925
2926         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2927         (NPP_New):
2928
2929 2010-07-08  Aaron Boodman  <aa@chromium.org>
2930
2931         Reviewed by Timothy Hatcher.
2932
2933         Add the ability for user scripts and user styles to affect just the top frame.
2934
2935         https://bugs.webkit.org/show_bug.cgi?id=41529
2936
2937         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
2938         * DumpRenderTree/LayoutTestController.cpp: Ditto.
2939         (addUserScriptCallback):
2940         (addUserStyleSheetCallback):
2941         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
2942         (LayoutTestController::addUserScript):
2943         (LayoutTestController::addUserStyleSheet):
2944         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
2945         (LayoutTestController::addUserScript):
2946         (LayoutTestController::addUserStyleSheet):
2947         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
2948         (LayoutTestController::addUserScript):
2949         (LayoutTestController::addUserStyleSheet):
2950         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
2951         (LayoutTestController::addUserScript):
2952         (LayoutTestController::addUserStyleSheet):
2953         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
2954         (LayoutTestController::addUserScript):
2955         (LayoutTestController::addUserStyleSheet):
2956
2957 2010-07-08  Adele Peterson  <adele@apple.com>
2958
2959         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
2960
2961         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
2962         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
2963
2964         Log when the missing plugin button is pressed.
2965
2966         * DumpRenderTree/mac/UIDelegate.mm:
2967         (-[UIDelegate webView:didPressMissingPluginButton:]):
2968         * DumpRenderTree/win/UIDelegate.cpp:
2969         (UIDelegate::QueryInterface):
2970         (UIDelegate::createWebViewWithRequest):
2971         (UIDelegate::drawBackground):
2972         (UIDelegate::decidePolicyForGeolocationRequest):
2973         (UIDelegate::didPressMissingPluginButton):
2974         * DumpRenderTree/win/UIDelegate.h:
2975
2976 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2977
2978         Fix the Tiger build.
2979
2980         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2981         (NPP_New):
2982
2983 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2984
2985         Fix windows build.
2986
2987         #ifdef code for Mac.
2988
2989         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2990         (NPP_New):
2991
2992 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2993
2994         Reviewed by Anders Carlsson.
2995
2996         Allow the TestPlugin to use Core Animation rendering for testing
2997         https://bugs.webkit.org/show_bug.cgi?id=41872
2998         
2999         Add the ability for the TestPlugin to use the CoreAnimation rendering model
3000         when available, based on the "drawingmodel" attribute of the embed tag:
3001             drawingmodel="coreanimation"
3002
3003         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
3004         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
3005         when building on Tiger. Add a void* coreAnimationLayer member.
3006         
3007         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
3008         (createCoreAnimationLayer): Obj-C method to create the CALayer.
3009         
3010         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3011         (NPP_New): Look for the drawingmodel attribute to decide which drawing
3012         model to use.
3013         (NPP_Destroy): Release the CALayer if we have one.
3014         (NPP_GetValue): Return the retained CALayer.
3015
3016 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
3017
3018         Reviewed by Xan Lopez.
3019
3020         [GTK] Support pixel tests
3021         https://bugs.webkit.org/show_bug.cgi?id=31518
3022
3023         Convert this file from CRLF to NL line endings. It will soon
3024         be used on more than just the WinCairo platform.
3025
3026         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3027         (writeFunction):
3028         (printPNG):
3029         (computeMD5HashStringForBitmapContext):
3030         (dumpBitmap):
3031
3032 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
3033
3034         Reviewed by Darin Adler.
3035
3036         Enable Data Execution Prevention for our test harnesses on Windows
3037         https://bugs.webkit.org/show_bug.cgi?id=41882
3038
3039         * DumpRenderTree/win/DumpRenderTree.vcproj:
3040         * DumpRenderTree/win/ImageDiff.vcproj:
3041         * WebKitAPITest/WebKitAPITest.vcproj:
3042         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3043
3044 2010-07-07  Robert Hogan  <robert@webkit.org>
3045
3046         Reviewed by Kenneth Rohde Christiansen.
3047
3048         [Qt] Add DRT support for pageProperty etc.
3049
3050         https://bugs.webkit.org/show_bug.cgi?id=41584
3051
3052         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3053         (LayoutTestController::isPageBoxVisible):
3054         (LayoutTestController::pageSizeAndMarginsInPixels):
3055         (LayoutTestController::pageProperty):
3056         (LayoutTestController::addUserStyleSheet):
3057         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3058
3059 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
3060
3061         Reviewed by Xan Lopez.
3062
3063         Remove a warnings from the ImageDiff build by using the proper
3064         printf format string for the gsize data type.
3065
3066         * DumpRenderTree/gtk/ImageDiff.cpp:
3067         (printImage): Use the proper printf format string for the gsize data type.
3068
3069 2010-07-08  Alice Liu  <alice.liu@apple.com>
3070
3071         Reviewed by Sam Weinig.
3072
3073         https://bugs.webkit.org/show_bug.cgi?id=41653
3074         Add new WebKitTestRunner project for Windows
3075
3076         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
3077         Similar to how it's done in DumpRenderTree, define max and min early
3078         on so that they don't get replaced by a macro requiring 2 arguments.
3079
3080         * WebKitTestRunner/win: Added.
3081         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
3082         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
3083         * WebKitTestRunner/win/main.cpp: Added.
3084         (main): Implemented
3085
3086         Added these files with stubbed out functions:
3087         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
3088         (WTR::PlatformWebView::PlatformWebView):
3089         (WTR::PlatformWebView::~PlatformWebView):
3090         (WTR::PlatformWebView::page):
3091         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
3092         (WTR::TestController::initializeInjectedBundlePath):
3093         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
3094         (WTR::TestInvocation::runUntil):
3095
3096 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
3097
3098         Reviewed by Gustavo Noronha Silva.
3099
3100         [GTK] Implement ImageDiff and add it to the build system
3101         https://bugs.webkit.org/show_bug.cgi?id=41779
3102
3103         Add the initial implementation of the ImageDiff tool for the GTK+
3104         port. This is an essential tool for doing pixel tests. The implementation
3105         is based on the Mac and Chromium ports.
3106
3107         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
3108         (readPixbufFromStdin): Added.
3109         (differenceImageFromDifferenceBuffer): Ditto.
3110         (calculateDifference): Ditto.
3111         (printImage): Ditto.
3112         (printImageDifferences): Ditto.
3113         (main): Ditto.
3114         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
3115
3116 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
3117
3118         Unreviewed. Adding myself as a committer.
3119
3120         * Scripts/webkitpy/common/config/committers.py:
3121
3122 2010-07-08  Adam Roben  <aroben@apple.com>
3123
3124         Make Windows stop running tests from platform/mac
3125
3126         r62742 made a change (at my suggestion!) that caused us to start
3127         looking for tests in platform/mac, rather than just looking for
3128         expected results in platform/mac. This patch just undoes that part of
3129         r62742.
3130
3131         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
3132         tests from platform/mac, but shouldn't
3133
3134         Reviewed by Antti Koivisto and Anders Carlsson.
3135
3136         * Scripts/old-run-webkit-tests:
3137         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
3138         so we won't look in those directories for tests to run.
3139         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
3140         platform/mac-snowleopard and platform/mac for expected results.
3141
3142 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
3143
3144         Unreviewed. Adding myself as a reviewer.
3145
3146         * Scripts/webkitpy/common/config/committers.py:
3147
3148 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3149
3150         Update my e-mail in committers.py
3151
3152         * Scripts/webkitpy/common/config/committers.py:
3153
3154 2010-07-07  Daniel Bates  <dbates@rim.com>
3155
3156         Reviewed by Dumitru Daniliuc.
3157
3158         VCSUtils.pm complains about uninitialized value $newLine
3159         https://bugs.webkit.org/show_bug.cgi?id=41333
3160
3161         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
3162         an array when fixing a change log entry that overlaps with an earlier
3163         entry. In particular, when a patch contains a change log entry inserted
3164         earlier in the change log file, but after an entry with the same author
3165         and date.
3166
3167         * Scripts/VCSUtils.pm:
3168             - Added for-loop constraint to fixChangeLogPatch() so that it does not
3169               read off the end of the @overlappingLines array.
3170         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
3171
3172 2010-07-07  Anders Carlsson  <andersca@apple.com>
3173
3174         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
3175
3176         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3177         (NPP_New):
3178
3179 2010-07-07  Kent Tamura  <tkent@chromium.org>
3180
3181         Reviewed by Adam Barth.
3182
3183         [DRT/Chromium] Support for indeterminate checkbox
3184         https://bugs.webkit.org/show_bug.cgi?id=41747
3185
3186         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
3187
3188         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
3189         (WebThemeControlDRT::draw):
3190         * DumpRenderTree/chromium/WebThemeControlDRT.h:
3191         (WebThemeControlDRT::):
3192         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
3193         (WebThemeEngineDRT::paintButton):
3194
3195 2010-07-07  Sam Weinig  <sam@webkit.org>
3196
3197         Reviewed by Mark Rowe.
3198
3199         Clean up MiniBrowser Xcode project.
3200
3201         - Use xcconfig files.
3202         - Rename plists to canonical Info.plist
3203         - Remove localizations.
3204
3205         * MiniBrowser/Configurations: Added.
3206         * MiniBrowser/Configurations/Base.xcconfig: Added.
3207         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
3208         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
3209         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
3210         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3211         * MiniBrowser/WebBundle-Info.plist: Removed.
3212         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3213         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
3214         * MiniBrowser/mac/BrowserWindow.xib: Added.
3215         * MiniBrowser/mac/BrowserWindowController.m:
3216         (-[BrowserWindowController initWithPageNamespace:]):
3217         * MiniBrowser/mac/English.lproj: Removed.
3218         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
3219         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
3220         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
3221         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
3222         * MiniBrowser/mac/MainMenu.xib: Added.
3223         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
3224         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
3225
3226 2010-07-07  Kent Tamura  <tkent@chromium.org>
3227
3228         Reviewed by Dimitri Glazkov.
3229
3230         [DRT/Chromium] Fix two regressions
3231         https://bugs.webkit.org/show_bug.cgi?id=41745
3232
3233         * DumpRenderTree/chromium/WebViewHost.cpp:
3234         (WebViewHost::paintInvalidatedRegion):
3235          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
3236          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
3237          though test_shell does it twice. Probably DRT needs it because
3238          DRT delays painting as possible.
3239
3240 2010-07-07  Anders Carlsson  <andersca@apple.com>
3241
3242         Try to fix build.
3243
3244         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3245         (webkit_test_plugin_destroy_stream):
3246
3247 2010-07-07  Anders Carlsson  <andersca@apple.com>
3248
3249         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
3250
3251         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3252         (webkit_test_plugin_new_stream):
3253         (webkit_test_plugin_destroy_stream):
3254         (webkit_test_plugin_write_ready):
3255         (webkit_test_plugin_write):
3256
3257 2010-07-07  Sam Weinig  <sam@webkit.org>
3258
3259         Reviewed by Mark Rowe.
3260
3261         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
3262
3263         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3264
3265 2010-07-07  Anders Carlsson  <andersca@apple.com>
3266
3267         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
3268
3269         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3270         (NPP_New):
3271         (NPP_HandleEvent):
3272
3273 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
3274
3275         Reviewed by Adam Roben.
3276
3277         Need to have a way to specify different results for Windows XP and 7
3278         https://bugs.webkit.org/show_bug.cgi?id=41776
3279         
3280         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
3281         subdirectories, so we can have different results for tests on Windows XP, Windows
3282         Vista, and Windows 7.
3283
3284         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
3285         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
3286         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
3287
3288         This matches the behavior of the mac.
3289
3290         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
3291             or Vista, try looking in other win-* subdirectories before win.
3292         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
3293             we are running.
3294
3295 2010-07-07  Kent Tamura  <tkent@chromium.org>
3296
3297         Reviewed by Dimitri Glazkov.
3298
3299         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
3300         https://bugs.webkit.org/show_bug.cgi?id=41753
3301
3302         The original code of the following functions in
3303         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
3304         ASSERT_NOT_REACHED(). The program shouldn't stop at these
3305         functions.
3306
3307         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3308         (DRTDevToolsClient::activateWindow):
3309         (DRTDevToolsClient::closeWindow):
3310         (DRTDevToolsClient::dockWindow):
3311         (DRTDevToolsClient::undockWindow):
3312
3313 2010-07-07  Anders Carlsson  <andersca@apple.com>
3314
3315         Reviewed by Sam Weinig.
3316
3317         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
3318         https://bugs.webkit.org/show_bug.cgi?id=41821
3319
3320         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3321         (pluginGetProperty):
3322         (pluginSetProperty):
3323         (pluginAllocate):
3324         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3325         Add and initialize the returnNegativeOneFromWrite property.
3326
3327         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3328         (NPP_NewStream):
3329         Set the stream type to NP_NORMAL so we'll get write callbacks.
3330
3331         (NPP_DestroyStream):
3332         Treat the onstreamdestroy attribute as a function name and not a string.
3333
3334         (NPP_WriteReady):
3335         Have this return a nonzero value.
3336
3337         (NPP_Write):
3338         If returnNegativeOneFromWrite is true return -1.
3339
3340 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
3341
3342         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
3343         latest version is selected by default, and allows the version to be specified.
3344
3345         * wx/build/settings.py:
3346
3347 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
3348
3349         Reviewed by Darin Adler.
3350
3351         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
3352         https://bugs.webkit.org/show_bug.cgi?id=41810
3353
3354         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3355         (AccessibilityUIElement::selectedTextRange):
3356
3357 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
3358
3359         Unreviewed.
3360
3361         Build fix after r62700.
3362
3363         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
3364         source file locations.
3365
3366 2010-07-07  Ojan Vafai  <ojan@chromium.org>
3367
3368         Reviewed by David Levin.
3369
3370         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
3371         https://bugs.webkit.org/show_bug.cgi?id=41814
3372
3373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3374         * Scripts/old-run-webkit-tests:
3375
3376 2010-07-07  Ojan Vafai  <ojan@chromium.org>
3377
3378         Reviewed by David Levin.
3379
3380         add --exit-after-n-crashes to run-webkit-tests
3381         https://bugs.webkit.org/show_bug.cgi?id=41811
3382
3383         Change the bots at build.webkit.org to use --exit-after-n-crashes
3384         instead of --exit-after-n-failures since we want to be able to have
3385         more than 20 failures on those bots, but more than 20 crashes means
3386         something should be rolled out.
3387
3388         * Scripts/old-run-webkit-tests:
3389         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3390
3391 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
3392
3393         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
3394         TestNetscapePlugin project, because this was removed from the tree.
3395
3396         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3397
3398 2010-07-07  Anders Carlsson  <andersca@apple.com>
3399
3400         Reviewed by Simon Fraser.
3401
3402         Unify Mac and Windows TestNetscapePlugin main.cpp files
3403         https://bugs.webkit.org/show_bug.cgi?id=41798
3404         
3405         * DumpRenderTree/DumpRenderTree.sln:
3406         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3407         (strcasecmp):
3408         (NP_Initialize):
3409         (NP_GetEntryPoints):
3410         (NP_Shutdown):
3411         (NPP_New):
3412         (NPP_Destroy):
3413         (NPP_HandleEvent):
3414         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3415         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
3416
3417 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
3418
3419         [wx] Build fix. pageProperty needs to return a value.
3420
3421         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3422         (LayoutTestController::pageProperty):
3423
3424 2010-07-07  David Kilzer  <ddkilzer@apple.com>
3425
3426         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
3427
3428         Reviewed by Anders Carlsson.
3429
3430         For both svn and git, commit-log-editor is invoked from the root
3431         of the working directory.  Unlike svn, git returns a list of
3432         changed files that are relative to the directory where the
3433         command was invoked.  This caused the ChangeLog file in the root
3434         directory to be read instead of the ChangeLog in the current
3435         directory.
3436
3437         The fix is to use $ENV{PWD} as the base directory when fixing
3438         the path to the ChangeLog files.  With svn, this has no net
3439         effect since $ENV{PWD} is the root of the working directory and
3440         the ChangeLog paths are already relative to that directory.
3441         With git, $ENV{PWD} is the directory that the commit was invoked
3442         from, which fixes the ChangeLog paths so that the correct files
3443         are read when creating the commit log entry.
3444
3445         Note that the call to makeFilePathRelative() was supposed to
3446         address this issue, but it doesn't because (a) it does nothing
3447         with svn working directories by design, and (b) it does nothing
3448         with git working directories because it's invoked when the
3449         current directory is the root of the working directory, thus
3450         giving no relative path.
3451
3452         * Scripts/commit-log-editor: Removed call to
3453         makeFilePathRelative() since since it does nothing.  Moved code
3454         to fix up $changeLog path so that it's fixed before trying to
3455         open the file, and use $ENV{PWD} as the base path.  Also use
3456         canonicalizePath() to clean up paths with "../" in them.
3457
3458 2010-07-07  Anders Carlsson  <andersca@apple.com>
3459
3460         Another attempt at fixing the Qt build.
3461
3462         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3463
3464 2010-07-07  Anders Carlsson  <andersca@apple.com>
3465
3466         Try to fix Qt build.
3467
3468         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3469
3470 2010-07-07  Anders Carlsson  <andersca@apple.com>
3471
3472         Reviewed by Simon Fraser.
3473
3474         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
3475         https://bugs.webkit.org/show_bug.cgi?id=41781
3476
3477         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3478         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
3479         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
3480         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
3481         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
3482         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
3483         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
3484         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
3485         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
3486         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
3487         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
3488         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
3489         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3490
3491 2010-07-07  Andras Becsi  <abecsi@webkit.org>
3492
3493         Unreviewed trivial fix.
3494
3495         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
3496         which was checked in accidentally in r62635.
3497
3498         * Scripts/webkitpy/layout_tests/port/webkit.py:
3499
3500 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3501
3502         Reviewed by Eric Seidel.
3503
3504         Pass port specific environment to server process.
3505         https://bugs.webkit.org/show_bug.cgi?id=41593
3506
3507         * Scripts/webkitpy/layout_tests/port/qt.py:
3508         * Scripts/webkitpy/layout_tests/port/webkit.py:
3509
3510 2010-07-06  Kent Tamura  <tkent@chromium.org>
3511
3512         Reviewed by Shinichiro Hamaji.
3513
3514         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
3515         https://bugs.webkit.org/show_bug.cgi?id=41644
3516
3517         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
3518         tolerance. We don't need tolerance for rebaseline.
3519
3520         * Scripts/webkitpy/layout_tests/port/base.py:
3521           Add optional tolerance parameter to diff_image().
3522         * Scripts/webkitpy/layout_tests/port/test.py:
3523           Add optional tolerance parameter to diff_image().
3524         * Scripts/webkitpy/layout_tests/port/webkit.py:
3525           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
3526         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3527           diff_files() always calls diff_image() with tolerance=0.
3528           diff_files() is used only by rebaseline-chromium-webkit-tests.
3529
3530 2010-07-06  Sam Weinig  <sam@webkit.org>
3531
3532         Fix MiniBrowser build.
3533
3534         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3535
3536 2010-07-06  Sam Weinig  <sam@webkit.org>
3537
3538         Reviewed by Anders Carlsson.
3539
3540         Add support for dumping the contents of messages to the console to WebKitTestRunner
3541
3542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3543         (WTR::InjectedBundlePage::InjectedBundlePage):
3544         (WTR::InjectedBundlePage::_addMessageToConsole):
3545         (WTR::InjectedBundlePage::addMessageToConsole):
3546         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3547
3548 2010-07-06  Sam Weinig  <sam@webkit.org>
3549
3550         Reviewed by Anders Carlsson.
3551
3552         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
3553         Add dumpAsText support for WebKitTestRunner
3554
3555         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3556         (WTR::InjectedBundle::InjectedBundle):
3557         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
3558         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3559         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
3560         API to dump the main frames text.
3561
3562 2010-07-06  Darin Adler  <darin@apple.com>
3563
3564         Fix Chromium build.
3565
3566         * DumpRenderTree/chromium/WebViewHost.cpp:
3567         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
3568         (WebViewHost::didNavigateWithinPage): Ditto.
3569         (WebViewHost::updateURL): Ditto.
3570
3571 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
3572
3573         Reviewed by Xan Lopez.
3574
3575         [GTK] build-webkit should not run autogen.sh unconditionally
3576         https://bugs.webkit.org/show_bug.cgi?id=41704
3577
3578         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
3579         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
3580         some very minor cleanup.
3581
3582 2010-07-06  Darin Adler  <darin@apple.com>
3583
3584         Try to fix Chromium build.
3585
3586         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
3587
3588 2010-07-06  Darin Adler  <darin@apple.com>
3589
3590         Fix build.
3591
3592         * WebKitAPITest/TestsController.cpp:
3593         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
3594
3595 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
3596
3597         Reviewed by Kent Tamura.
3598
3599         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
3600         https://bugs.webkit.org/show_bug.cgi?id=40558
3601
3602         Upstream DevTools for Chromium DRT.
3603         (original Chromium files rev. 51287)
3604
3605         * DumpRenderTree/DumpRenderTree.gypi:
3606         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
3607         (DRTDevToolsAgent::DRTDevToolsAgent):
3608         (DRTDevToolsAgent::setWebView):
3609         (DRTDevToolsAgent::sendMessageToFrontend):
3610         (DRTDevToolsAgent::forceRepaint):
3611         (DRTDevToolsAgent::runtimeFeatureStateChanged):
3612         (DRTDevToolsAgent::injectedScriptSource):
3613         (DRTDevToolsAgent::injectedScriptDispatcherSource):
3614         (DRTDevToolsAgent::debuggerScriptSource):
3615         (DRTDevToolsAgent::asyncCall):
3616         (DRTDevToolsAgent::call):
3617         (DRTDevToolsAgent::webDevToolsAgent):
3618         (DRTDevToolsAgent::attach):
3619         (DRTDevToolsAgent::detach):
3620         (DRTDevToolsAgent::setTimelineProfilingEnabled):
3621         (DRTDevToolsAgent::evaluateInWebInspector):
3622         (DRTDevToolsAgent::dispatchMessageLoop):
3623         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
3624         (DRTDevToolsAgent::~DRTDevToolsAgent):
3625         (DRTDevToolsAgent::hostIdentifier):
3626         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
3627         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
3628         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
3629         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
3630         (DRTDevToolsCallArgs::callsCount):
3631         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
3632         (DRTDevToolsClient::DRTDevToolsClient):
3633         (DRTDevToolsClient::~DRTDevToolsClient):
3634         (DRTDevToolsClient::sendMessageToAgent):
3635         (DRTDevToolsClient::sendDebuggerCommandToAgent):
3636         (DRTDevToolsClient::activateWindow):
3637         (DRTDevToolsClient::closeWindow):
3638         (DRTDevToolsClient::dockWindow):
3639         (DRTDevToolsClient::undockWindow):
3640         (DRTDevToolsClient::asyncCall):
3641         (DRTDevToolsClient::call):
3642         (DRTDevToolsClient::allMessagesProcessed):
3643         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3644         * DumpRenderTree/chromium/EventSender.cpp:
3645         * DumpRenderTree/chromium/LayoutTestController.cpp:
3646         (LayoutTestController::LayoutTestController):
3647         (LayoutTestController::closeWebInspector):
3648         (LayoutTestController::setTimelineProfilingEnabled):
3649         (LayoutTestController::evaluateInWebInspector):
3650         * DumpRenderTree/chromium/LayoutTestController.h:
3651         * DumpRenderTree/chromium/TestShell.cpp:
3652         (TestShell::TestShell):
3653         (TestShell::~TestShell):
3654         (TestShell::createDRTDevToolsClient):
3655         (TestShell::showDevTools):
3656         (TestShell::closeDevTools):
3657         (TestShell::runFileTest):
3658         (TestShell::createNewWindow):
3659         * DumpRenderTree/chromium/TestShell.h:
3660         (TestShell::drtDevToolsAgent):
3661         (TestShell::drtDevToolsClient):
3662         * DumpRenderTree/chromium/config.h:
3663
3664 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3665
3666         Reviewed by Eric Seidel.
3667
3668         Don't pass image hash to DRT when pixel tests are disabled.
3669         https://bugs.webkit.org/show_bug.cgi?id=41597
3670
3671         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3672
3673 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
3674
3675         Reviewed by Eric Seidel.
3676
3677         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
3678         https://bugs.webkit.org/show_bug.cgi?id=41612
3679
3680         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
3681
3682 2010-07-05  Adam Barth  <abarth@webkit.org>
3683
3684         Reviewed by Eric Seidel.
3685
3686         We should be able to specify a bug to block for webkit-patch upload
3687         https://bugs.webkit.org/show_bug.cgi?id=41648
3688
3689         This will be useful for working on the HTML5 parser.
3690
3691         * Scripts/webkitpy/tool/steps/createbug.py:
3692         * Scripts/webkitpy/tool/steps/options.py:
3693
3694 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
3695
3696         Reviewed by Oliver Hunt.
3697
3698         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
3699         https://bugs.webkit.org/show_bug.cgi?id=41017
3700
3701         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
3702         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
3703
3704 2010-07-04  MORITA Hajime  <morrita@google.com>
3705
3706         rebaseline-chromium-webkit-tests: UnicodeDecodeError
3707         https://bugs.webkit.org/show_bug.cgi?id=41589
3708
3709         * run() method can result non-utf-8 bytes, that causes utf-8
3710           decoding fail.  Fixed to disable decoding.
3711         * Fixed Git.find_checkout_root() to make a test pass.
3712
3713         * Scripts/webkitpy/common/checkout/scm.py:
3714         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3715
3716 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
3717
3718         Reviewed by Simon Hausmann.
3719
3720         [Qt] Fix DumpRenderTree userStyleSheet handling.
3721         https://bugs.webkit.org/show_bug.cgi?id=41570
3722
3723         DumpRenderTree did only set the userStyleSheet at
3724         layoutTestController.setUserStyleSheetEnabled().
3725
3726         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3727         (LayoutTestController::reset):
3728         (LayoutTestController::setUserStyleSheetLocation):
3729         (LayoutTestController::setUserStyleSheetEnabled):
3730         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3731
3732 2010-07-03  Robert Hogan  <robert@webkit.org>
3733
3734         Reviewed by Kenneth Rohde Christiansen.
3735
3736         [Qt] support dumpChildFrameScrollPositions
3737
3738         https://bugs.webkit.org/show_bug.cgi?id=41088
3739
3740         Unskip:
3741
3742         http/tests/navigation/anchor-subframeload.html
3743         http/tests/navigation/relativeanchor-frames.html
3744
3745         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3746         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
3747         (WebCore::DumpRenderTree::dump):
3748         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3749         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3750         (LayoutTestController::reset):
3751         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3752         (LayoutTestController::shouldDumpChildFrameScrollPositions):
3753         (LayoutTestController::dumpChildFrameScrollPositions):
3754
3755 2010-07-02  Sam Weinig  <sam@webkit.org>
3756
3757         Reviewed by Anders Carlsson.
3758
3759         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
3760
3761         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
3762         * Scripts/debug-webkittestrunner: Removed.
3763         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
3764         * Scripts/run-webkittestrunner: Removed.
3765
3766 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
3767
3768         Reviewed by Steve Falkenburg.
3769
3770         Some http tests fail on Windows with Cygwin 1.7
3771         https://bugs.webkit.org/show_bug.cgi?id=41537
3772         
3773         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
3774         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
3775         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
3776
3777         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3778         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
3779             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
3780
3781 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
3782
3783         Reviewed by Gustavo Noronha Silva.
3784
3785         [GTK] Separate DerivedSources per-project
3786         https://bugs.webkit.org/show_bug.cgi?id=41109
3787
3788         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
3789         allowing the tools to build as a side-effect. Now that the top-level directory
3790         is no longer in the list of JavaScriptCore includes, include it explicitly.
3791
3792         * GNUmakefile.am:
3793
3794 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3795
3796         Reviewed by Kenneth Rohde Christiansen.
3797
3798         [Qt] Make context menus show up in the right place in QTestBrowser
3799
3800         Context menus were shown at scene-relative coordinates for
3801         QGraphicsWebView while QMenu expects them to be global. The
3802         change to the QWidget case was to get rid of the mapToGlobal.
3803
3804         * QtTestBrowser/webview.cpp:
3805
3806 2010-07-01  Robert Hogan <robert@webkit.org>
3807
3808         Reviewed by Kenneth Rohde Christiansen.
3809
3810         [Qt] dump frames in ascending alphabetical order of title
3811
3812         https://bugs.webkit.org/show_bug.cgi?id=41261
3813
3814         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3815         (WebCore::dumpHistoryItem):
3816
3817 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
3818
3819         Unreviewed. 
3820
3821         Fix the GTK+ build after r62278.
3822
3823         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
3824         let them override the automatic CPU detection for autotools builds.
3825
3826 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
3827
3828         Unreviewed.
3829
3830         Fix the Windows build after r62278.
3831
3832         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
3833
3834 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
3835
3836         Reviewed by Gustavo Noronha Silva.
3837
3838         [GTK] build-webkit does not detect the number of CPUs
3839         https://bugs.webkit.org/show_bug.cgi?id=41469
3840
3841         Pass the appropriate -j<#> flag to make when building autotools builds.
3842         This causes make to spawn that many number of child processes for doing
3843         parallel builds.
3844
3845         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
3846         of CPUs. This makes the script work across more platforms.
3847         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
3848         number of CPUs across several platforms. Use this new function to determine the appropriate
3849         arguments to pass to make for doing parallel builds with autotools build files.
3850
3851 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
3852
3853         Rubber-stamped by Laszlo Gombos.
3854
3855         [Qt][Symbian] Bumped up the maximum heap size to 96MB
3856
3857         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
3858         and use the one from WebKit.pri instead.
3859
3860 2010-07-01  Adam Barth  <abarth@webkit.org>
3861
3862         Reviewed by Eric Seidel.
3863
3864         Promote webkit-patch land-safely to main help
3865         https://bugs.webkit.org/show_bug.cgi?id=41446
3866
3867         I've been using this command a bunch and recommending it to folks.  We
3868         should show it in main help as it's past the experimental phase.
3869
3870         * Scripts/webkitpy/tool/commands/upload.py:
3871
3872 2010-06-28  MORITA Hajime  <morrita@google.com>
3873
3874         Reviewed by Shinichiro Hamaji.
3875
3876         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
3877         https://bugs.webkit.org/show_bug.cgi?id=38775
3878
3879         - Introduced SCM.show_head() and SCM.diff_for_file().
3880         - Replaced direct svn invocations with newly implement SCM methods.
3881
3882         * Scripts/webkitpy/common/checkout/scm.py:
3883         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3884         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3885
3886 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
3887
3888         Reviewed by Sam Weinig.
3889
3890         Allow MiniBrowser to open local files
3891         https://bugs.webkit.org/show_bug.cgi?id=41104
3892
3893         Wire up the openDocument: message with an NSOpenPanel, so we can open
3894         local files.
3895         
3896         Also change the xib so that the window remembers its size.
3897         
3898         * MiniBrowser/mac/AppDelegate.m:
3899         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3900         (-[BrowserAppDelegate openDocument:]):
3901         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
3902         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
3903
3904 2010-06-30  Sam Weinig  <sam@webkit.org>
3905
3906         Rubber-stamped by Anders Carlsson.
3907
3908         Add debug-webkittestrunner and cleanup related scripts.
3909
3910         * Scripts/debug-webkittestrunner: Added.
3911         * Scripts/run-webkittestrunner:
3912         * Scripts/webkitdirs.pm:
3913
3914 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
3915
3916         [wx] Build fix after recent changes to LayoutTestController.
3917
3918         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3919         (LayoutTestController::pageSizeAndMarginsInPixels):
3920
3921 2010-06-29  Sam Weinig  <sam@webkit.org>
3922
3923         Reviewed by Anders Carlsson.
3924
3925         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
3926         Make WebKitTestRunner work with more than one test at a time.
3927
3928         This converts WebKitTestRunner to a similar model as DumpRenderTree,
3929         where there is a single WKView and each test is run it, rather than
3930         the design I was using where each test got its own WKView.
3931
3932         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3933         (WTR::InjectedBundle::didRecieveMessage):
3934         (WTR::InjectedBundle::reset):
3935         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3936         * WebKitTestRunner/TestController.cpp:
3937         (WTR::TestController::initialize):
3938         (WTR::TestController::runTest):
3939         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
3940         (WTR::TestController::didRecieveMessageFromInjectedBundle):
3941         * WebKitTestRunner/TestController.h:
3942         (WTR::TestController::mainWebView):
3943         (WTR::TestController::pageNamespace):
3944         (WTR::TestController::context):
3945         * WebKitTestRunner/TestInvocation.cpp:
3946         (WTR::TestInvocation::TestInvocation):
3947         (WTR::TestInvocation::~TestInvocation):
3948         (WTR::TestInvocation::invoke):
3949         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
3950         * WebKitTestRunner/TestInvocation.h:
3951
3952 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
3953
3954         Reviewed by Laszlo Gombos.
3955
3956         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
3957         https://bugs.webkit.org/show_bug.cgi?id=40446
3958
3959         We quickly run out of memory on Symbian when loading web pages. This is
3960         caused by the default heap size, which is not suited for a web browser.
3961
3962         This change bumps the max heap size to 32MB.
3963
3964         * QtTestBrowser/QtTestBrowser.pro:
3965
3966 2010-06-30  Eric Seidel  <eric@webkit.org>
3967
3968         Reviewed by Adam Barth.
3969
3970         webkit-patch land allow the user to continue even if the builders are red
3971         https://bugs.webkit.org/show_bug.cgi?id=41395
3972
3973         I don't think it's good that we've been teaching people
3974         to always pass --ignore-builders.  At least land is now
3975         useable w/o --ignore-builders.
3976
3977         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
3978
3979 2010-06-29  Robert Hogan  <robert@webkit.org>
3980
3981         Reviewed by Kenneth Rohde Christiansen.
3982
3983         [Qt] support dumpResourceResponseMIMETypes
3984         https://bugs.webkit.org/show_bug.cgi?id=41260
3985
3986         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3987         (LayoutTestController::reset):
3988         (LayoutTestController::dumpResourceResponseMIMETypes):
3989         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3990
3991 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
3992
3993         Reviewed by Kenneth Rohde Christiansen.
3994
3995         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
3996         https://bugs.webkit.org/show_bug.cgi?id=41173
3997
3998         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3999         (WebCore::WebPage::setViewGeometry):
4000         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4001
4002 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
4003
4004         Reviewed by Simon Hausmann.
4005
4006         [Qt] Deal with postEvent in case of graphics based DRT
4007         https://bugs.webkit.org/show_bug.cgi?id=41174
4008
4009         QGraphicsScene does not have a postEvent method, so make scene
4010         send the event, in case of graphics based DRT, and delete it after that.
4011
4012         * DumpRenderTree/qt/EventSenderQt.cpp:
4013         (EventSender::scheduleAsynchronousClick):
4014         (EventSender::replaySavedEvents):
4015         (EventSender::postEvent):
4016         * DumpRenderTree/qt/EventSenderQt.h:
4017
4018 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
4019
4020         Reviewed by Kenneth Rohde Christiansen.
4021
4022         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
4023         https://bugs.webkit.org/show_bug.cgi?id=41172
4024
4025         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4026         (WebCore::DumpRenderTree::switchFocus):
4027
4028 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
4029
4030         Reviewed by Xan Lopez.
4031
4032         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
4033         https://bugs.webkit.org/show_bug.cgi?id=40009
4034
4035         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
4036         are used when returning those values, for coherency with other ports.
4037
4038         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4039         (AccessibilityUIElement::role):
4040         (AccessibilityUIElement::title):
4041         (AccessibilityUIElement::description):
4042
4043 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
4044
4045         Unreviewed, rolling out r62106.
4046         http://trac.webkit.org/changeset/62106
4047         https://bugs.webkit.org/show_bug.cgi?id=41346
4048
4049         "Broke editing tests" (Requested by xan_ on #webkit).
4050
4051         * Scripts/old-run-webkit-tests:
4052
4053 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
4054
4055         Reviewed by Xan Lopez.
4056
4057         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
4058         https://bugs.webkit.org/show_bug.cgi?id=38648
4059
4060         Add the GTK_MODULES envvar (set to "gail") to the clean
4061         environment when running DRT for the Gtk+ port
4062
4063         * Scripts/old-run-webkit-tests:
4064
4065 2010-06-28  Adam Barth  <abarth@webkit.org>
4066
4067         Unreviewed.
4068
4069         Switch test-html5-parser back to using runner.html.
4070
4071         * Scripts/test-html5-parser:
4072
4073 2010-06-28  Adam Barth  <abarth@webkit.org>
4074
4075         Reviewed by Eric Seidel.
4076
4077         Restore webkit-runner.html for use with new tree builder
4078         https://bugs.webkit.org/show_bug.cgi?id=41317
4079
4080         For now, we just want to run webkit-runner when we test-html5-parser.
4081
4082         * Scripts/test-html5-parser:
4083
4084 2010-06-23  John Gregg  <johnnyg@google.com>
4085
4086         Reviewed by Kent Tamura.
4087
4088         add ENABLE_DIRECTORY_UPLOAD build support
4089         https://bugs.webkit.org/show_bug.cgi?id=41100
4090
4091         * Scripts/build-webkit:
4092
4093 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
4094
4095         Rubber-stamped by Xan Lopez.
4096
4097         Update webkitdirs's knowledge of our library's name.
4098
4099         * Scripts/webkitdirs.pm:
4100
4101 2010-06-28  Sam Weinig  <sam@webkit.org>
4102
4103         Reviewed by Anders Carlsson.
4104
4105         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
4106         Build up WebKitTestRunner output in the InjectedBundle
4107
4108         Simplify WebKitTestRunner by building up the output in the InjectedBundle
4109         and sending it over postMessage when done, instead of using the async
4110         WKPageRenderTreeExternalRepresentation.
4111
4112         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4113         (WTR::InjectedBundle::done):
4114         (WTR::InjectedBundle::didRecieveMessage):
4115         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4116         (WTR::InjectedBundle::os):
4117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4118         (WTR::WKStringToUTF8):
4119         (WTR::InjectedBundlePage::didFinishLoadForFrame):
4120         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
4121         * WebKitTestRunner/TestInvocation.cpp:
4122         (WTR::WKStringToUTF8):
4123         (WTR::TestInvocation::TestInvocation):
4124         (WTR::TestInvocation::invoke):
4125         (WTR::TestInvocation::initializeMainWebView):
4126         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
4127         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
4128         * WebKitTestRunner/TestInvocation.h:
4129
4130 2010-06-28  Robert Hogan  <robert@webkit.org>
4131
4132         Unreviewed, rolling out r62021.
4133         http://trac.webkit.org/changeset/62021
4134         https://bugs.webkit.org/show_bug.cgi?id=41261
4135
4136         Broke http/navigation tests among other
4137
4138         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4139         (WebCore::DumpRenderTree::dumpFramesAsText):
4140
4141 2010-06-28  Sam Weinig  <sam@webkit.org>
4142
4143         Reviewed by Anders Carlsson.
4144
4145         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
4146         environment.
4147
4148         * Scripts/run-webkittestrunner: Added.
4149         * Scripts/webkitdirs.pm:
4150
4151 2010-06-28  Robert Hogan  <robert@webkit.org>
4152
4153         Reviewed by Kenneth Rohde Christiansen.
4154
4155         [Qt] dump frames in ascending alphabetical order of title
4156
4157         https://bugs.webkit.org/show_bug.cgi?id=41261
4158
4159         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4160         (WebCore::DumpRenderTree::dumpFramesAsText):
4161
4162 2010-06-28  Robert Hogan  <robert@webkit.org>
4163
4164         Reviewed by Kenneth Rohde Christiansen.
4165
4166         [Qt] dump bf history of child windows
4167
4168         https://bugs.webkit.org/show_bug.cgi?id=41266
4169
4170         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4171         (WebCore::DumpRenderTree::dumpBackForwardList):
4172         (WebCore::DumpRenderTree::dump):
4173         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4174
4175 2010-06-28  Sam Weinig  <sam@webkit.org>
4176
4177         Reviewed by Anders Carlsson.
4178
4179         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
4180         WebKit2: Add frame API for InjectedBundle code
4181
4182         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
4183         (_didClearWindowForFrame):
4184
4185 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
4186
4187         Reviewed by Kenneth Rohde Christiansen.
4188
4189         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
4190         https://bugs.webkit.org/show_bug.cgi?id=38597
4191
4192         Fix behavior so reload button really acts as a load and a reload button.
4193
4194         * QtTestBrowser/mainwindow.cpp:
4195         (MainWindow::changeLocation):
4196
4197 2010-06-28  Xan Lopez  <xlopez@igalia.com>
4198
4199         Reviewed by Gustavo Noronha.
4200
4201         [GTK] Does not compile with -DGSEAL_ENABLE
4202         https://bugs.webkit.org/show_bug.cgi?id=37851
4203
4204         Fix build with GSEAL enabled.
4205
4206         * DumpRenderTree/gtk/EventSender.cpp:
4207         (gtk_widget_get_window):
4208         (prepareMouseButtonEvent):
4209         (mouseMoveToCallback):
4210         (mouseWheelToCallback):
4211         (keyDownCallback):
4212
4213 2010-06-28  Xan Lopez  <xlopez@igalia.com>
4214
4215         Reviewed by Gustavo Noronha.
4216
4217         [GTK] Add support for GTK+3
4218         https://bugs.webkit.org/show_bug.cgi?id=41253
4219
4220         Adapt build system for 3.x support.
4221
4222         * GNUmakefile.am:
4223
4224 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
4225
4226         Reviewed by Simon Hausmann.
4227
4228         [QT][S60] build-webkit scripts picks wrong make spec for windows build
4229         https://bugs.webkit.org/show_bug.cgi?id=41198
4230
4231         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
4232
4233         * Scripts/webkitdirs.pm:
4234         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
4235
4236 2010-06-28  Eric Seidel  <eric@webkit.org>
4237
4238         Reviewed by Adam Barth.
4239
4240         Make it possible to test the new HTML5 TreeBuilder
4241         https://bugs.webkit.org/show_bug.cgi?id=41276
4242
4243         Adam was concerned that someone might make their port
4244         depend on this setting (I guess we had some trouble with that
4245         with the HTML5Parser setting), so I littered the code with warnings.
4246
4247         test-html5-parser now tests this code path.