Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-07-31  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Dan Bernstein.
4
5         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
6         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
7         due to SVGElements not having the innerText function.
8
9         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
10         (WTR::dumpFrameText):
11
12 2010-07-30  Sam Weinig  <sam@webkit.org>
13
14         Reviewed by Maciej Stachowiak.
15
16         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
17         Add structured message passing from the injected bundle to UIProcess
18
19         * MiniBrowser/mac/AppDelegate.m:
20         (didRecieveMessageFromInjectedBundle):
21         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
22         (didClearWindowForFrame):
23         (didRecieveMessage):
24         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
25         (WTR::InjectedBundle::done):
26         (WTR::InjectedBundle::didReceiveMessage):
27         * WebKitTestRunner/TestController.cpp:
28         (WTR::TestController::initialize):
29         (WTR::TestController::didReceiveMessageFromInjectedBundle):
30         * WebKitTestRunner/TestController.h:
31         * WebKitTestRunner/TestInvocation.cpp:
32         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
33         * WebKitTestRunner/TestInvocation.h:
34         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
35
36 2010-07-30  Sam Weinig  <sam@webkit.org>
37
38         Reviewed by Anders Carlsson.
39
40         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
41         Make WKArrayRef more usable.
42
43         Remove now unnecessary const_casts.
44
45         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
46         (WTR::dumpDescendantFrameScrollPositions):
47         (WTR::dumpDescendantFramesText):
48
49 2010-07-30  Sam Weinig  <sam@webkit.org>
50
51         Reviewed by Anders Carlsson.
52
53         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
54         Add first pass of structured message passing.
55
56         Update Minibrowser and WebKitTestRunner to work with the new post message
57         function.
58
59         * MiniBrowser/mac/AppDelegate.m:
60         (didRecieveMessageFromInjectedBundle):
61         (-[BrowserAppDelegate init]):
62         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
63         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
64         (didStartProvisionalLoadForFrame):
65         (didReceiveServerRedirectForProvisionalLoadForFrame):
66         (didFailProvisionalLoadWithErrorForFrame):
67         (didCommitLoadForFrame):
68         (didFinishLoadForFrame):
69         (didFailLoadWithErrorForFrame):
70         (didReceiveTitleForFrame):
71         (didClearWindowForFrame):
72         (didCreatePage):
73         (willDestroyPage):
74         (didRecieveMessage):
75         (WKBundleInitialize):
76         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
77         (WTR::InjectedBundle::_didReceiveMessage):
78         (WTR::InjectedBundle::didReceiveMessage):
79         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
80         * WebKitTestRunner/TestInvocation.cpp:
81         (WTR::TestInvocation::invoke):
82         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
83
84 2010-07-30  Anders Carlsson  <andersca@apple.com>
85
86         Try to fix the layout test failures.
87
88         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
89         (webkit_test_plugin_get_value):
90
91 2010-07-29  Anders Carlsson  <andersca@apple.com>
92
93         Reviewed by Adam Roben.
94
95         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
96         https://bugs.webkit.org/show_bug.cgi?id=43232
97
98         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
99         Add PluginScriptableNPObjectInvokeDefault.cpp.
100
101         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
102         Remove invokeDefault callback function.
103
104         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
105         (PluginTest::create):
106         Move this to the top of the file.
107
108         (PluginTest::NPP_GetValue):
109         Add default implementation.
110
111         (PluginTest::NPN_CreateObject):
112         Add NPN_ wrapper.
113
114         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
115         (PluginTest::identifier):
116         Add identifier getter.
117
118         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
119         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
120         Add "using namespace std".
121
122         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
123         (NPP_GetValue):
124         Give PluginTest a chance to return a value.
125
126         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
127         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
128         * GNUmakefile.am:
129         Add PluginScriptableNPObjectInvokeDefault.cpp.
130         
131         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
132         (webkit_test_plugin_get_value):
133         Give PluginTest a chance to return a value.
134
135 2010-07-30  Steve Block  <steveblock@google.com>
136
137         Reviewed by Steve Block.
138
139         Add LayoutTestController methods to test DeviceOrientation
140         https://bugs.webkit.org/show_bug.cgi?id=39589
141
142         * DumpRenderTree/LayoutTestController.cpp:
143         (setMockDeviceOrientationCallback):
144         (LayoutTestController::staticFunctions):
145         * DumpRenderTree/LayoutTestController.h:
146         * DumpRenderTree/chromium/LayoutTestController.cpp:
147         (LayoutTestController::LayoutTestController):
148         (LayoutTestController::setMockDeviceOrientation):
149         * DumpRenderTree/chromium/LayoutTestController.h:
150         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
151         (LayoutTestController::setMockDeviceOrientation):
152         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
153         (LayoutTestController::setMockDeviceOrientation):
154         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
155         (LayoutTestController::setMockDeviceOrientation):
156         * DumpRenderTree/qt/LayoutTestControllerQt.h:
157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
158         (LayoutTestController::setMockDeviceOrientation):
159         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
160         (LayoutTestController::setMockDeviceOrientation):
161         * Scripts/build-webkit:
162
163 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
164
165         Reviewed by Kenneth Christiansen.
166
167         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
168         https://bugs.webkit.org/show_bug.cgi?id=43209
169
170         When -resizes-to-content was being passed as a command line parameter it was simply
171         not being set (although the corresponding menu item was marked as ON).
172         User had to toggle the menu OFF and then ON again for it to take place.
173
174         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
175         the command line, but not resizesToContents. Patch addresses that.
176
177         * QtTestBrowser/launcherwindow.cpp:
178         (LauncherWindow::createChrome):
179         (LauncherWindow::applyPrefs):
180         (LauncherWindow::toggleResizesToContents):
181         * QtTestBrowser/webview.h:
182         (WebViewGraphicsBased::resizesToContents):
183
184 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
185
186         Rubber-stamped by Simon Fraser.
187
188         [Qt] QtTestBrowser: more method grouping and clean ups.
189
190         Moving blocks of code around. Basically grouping related methods close to each.
191
192         * QtTestBrowser/launcherwindow.cpp:
193         (LauncherWindow::initializeView):
194         (LauncherWindow::createChrome):
195         (LauncherWindow::changeViewportUpdateMode):
196         (LauncherWindow::showFPS):
197         (LauncherWindow::newWindow):
198         (LauncherWindow::cloneWindow):
199         * QtTestBrowser/launcherwindow.h:
200
201 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
202
203         Reviewed by Tor Arne Vestbø.
204
205         [QT][Symbian] QtTestBrowser missing location capabilities
206         https://bugs.webkit.org/show_bug.cgi?id=43235
207
208         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
209
210         * QtTestBrowser/QtTestBrowser.pro:
211
212 2010-07-29  Anders Carlsson  <andersca@apple.com>
213
214         Add PluginTest.cpp
215
216         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
217
218 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
219
220         Reviewed by Eric Seidel.
221
222         Update download URLs for python irclib package; the old URLs 
223         pointed at a specific mirror host and not the general sourceforge
224         URLs.
225
226         https://bugs.webkit.org/show_bug.cgi?id=43228
227
228         * Scripts/webkitpy/thirdparty/__init__.py:
229
230 2010-07-29  Anders Carlsson  <andersca@apple.com>
231
232         Fix typo.
233
234         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
235
236 2010-07-29  Anders Carlsson  <andersca@apple.com>
237
238         Another attempt at fixing the Qt and GTK+ build.
239
240         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
241         (webkit_test_plugin_new_instance):
242         (webkit_test_plugin_destroy_stream):
243
244 2010-07-29  Anders Carlsson  <andersca@apple.com>
245
246         Another build fix attempt.
247
248         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
249         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
250         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
251         (webkit_test_plugin_new_instance):
252         * GNUmakefile.am:
253
254 2010-07-29  Anders Carlsson  <andersca@apple.com>
255
256         Try to fix Windows and Unix builds.
257
258         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
259         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
260         (webkit_test_plugin_new_instance):
261         (webkit_test_plugin_destroy_stream):
262
263 2010-07-29  Anders Carlsson  <andersca@apple.com>
264
265         Reviewed by Sam Weinig.
266
267         Refactor TestNetscapePlugin so tests can be split in separate files
268         https://bugs.webkit.org/show_bug.cgi?id=43220
269
270         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
271         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
272
273         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
274         (pluginAllocate):
275         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
276
277         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
278         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
279         (PluginTest::PluginTest):
280         Initialize m_npp and the test identifier.
281         
282         (PluginTest::createTestFunctions):
283         Return the map from identifiers to createTest functions.
284
285         (PluginTest::registerCreateTestFunction):
286         Insert the identifier and create function pair in the map.
287
288         (PluginTest::create):
289         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
290
291         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
292         (PluginTest::Register::Register):
293         Helper class template for registering plug-in tests.
294         
295         (PluginTest::Register::create):
296         Create a new test of the given type.
297
298         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
299         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
300         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
301
302         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
303         (NPP_New):
304         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
305
306         (NPP_DestroyStream):
307         Call the plug-in test NPP_DestroyStream member function.
308
309         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
310         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
311
312 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
313
314         Unreviewed build fix.
315
316         Add missing second argument to assert_lint in new style checker tests.
317
318         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
319
320 2010-07-29  Anders Carlsson  <andersca@apple.com>
321
322         Reviewed by Adam Roben.
323
324         check-webkit-style shouldn't complain about NPAPI functions
325         https://bugs.webkit.org/show_bug.cgi?id=43211
326
327         Allow underscores in functions that start with NPN_, NPP_ or NP_.
328
329         * Scripts/webkitpy/style/checkers/cpp.py:
330         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
331
332 2010-07-29  Victor Wang  <victorw@chromium.org>
333
334         Unreviewed, rolling out r64270.
335         http://trac.webkit.org/changeset/64270
336         https://bugs.webkit.org/show_bug.cgi?id=39589
337
338         The patch breaks chromium webkit unittest
339
340         * DumpRenderTree/LayoutTestController.cpp:
341         (LayoutTestController::staticFunctions):
342         * DumpRenderTree/LayoutTestController.h:
343         * DumpRenderTree/chromium/LayoutTestController.cpp:
344         (LayoutTestController::LayoutTestController):
345         * DumpRenderTree/chromium/LayoutTestController.h:
346         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
347         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
348         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
349         * DumpRenderTree/qt/LayoutTestControllerQt.h:
350         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
351         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
352         * Scripts/build-webkit:
353
354 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
355
356         Reviewed by Kenneth Christiansen.
357
358         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
359         https://bugs.webkit.org/show_bug.cgi?id=43199
360
361         There is no sense in keeping WebPage method definitions in main.cpp once
362         webpage.cpp already exists.
363
364         No behavior change.
365
366         * QtTestBrowser/main.cpp:
367         * QtTestBrowser/webpage.cpp:
368         (WebPage::createWindow):
369         (WebPage::createPlugin):
370
371 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
372
373         Reviewed by Kenneth Christiansen.
374
375         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
376         https://bugs.webkit.org/show_bug.cgi?id=43170
377
378         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
379         launcherwindow.{cpp|h}
380
381         No behavior change.
382
383         Also changed all global static variables (named "gXXX") from main.cpp to
384         static public variables of the LauncherWindow class.
385
386         * QtTestBrowser/QtTestBrowser.pro:
387         * QtTestBrowser/launcherwindow.cpp: Added.
388         * QtTestBrowser/launcherwindow.h: Added.
389         * QtTestBrowser/main.cpp:
390         (LauncherApplication::handleUserOptions):
391         (main):
392
393 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
394
395         Reviewed by Xan Lopez.
396
397         Build fix for building against GTK+ 3.x. GSEAL requires that we
398         access internals of the GdkDragContext via methods. For older versions
399         of GTK+, define those methods.
400
401         * DumpRenderTree/gtk/EventSender.cpp:
402         (gdk_drag_context_get_selected_action): Added.
403         (gdk_drag_context_get_actions): Added.
404         (dispatchEvent): Use the two new accessor methods.
405
406 2010-07-29  Adam Roben  <aroben@apple.com>
407
408         Always say "plugins directory" when referring to a directory
409         containing one or more plugins
410
411         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
412         directory" when it means "plugins directory"
413
414         Reviewed by John Sullivan.
415
416         * WebKitTestRunner/TestController.cpp:
417         (WTR::TestController::initialize): Updated for rename.
418
419 2010-07-29  Adam Roben  <aroben@apple.com>
420
421         Always say "directory" when referring to a plugin directory
422
423         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
424         when it means "plugin directory"
425
426         Reviewed by John Sullivan.
427
428         * WebKitTestRunner/TestController.cpp:
429         (WTR::TestController::initialize): Updated for renames.
430
431         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
432         m_testPluginDirectory.
433         (WTR::TestController::testPluginDirectory): Renamed from
434         testPluginPath.
435
436         * WebKitTestRunner/mac/TestControllerMac.mm:
437         (WTR::TestController::initializeTestPluginDirectory):
438         * WebKitTestRunner/win/TestControllerWin.cpp:
439         (WTR::TestController::initializeTestPluginDirectory):
440         Renamed from initializeTestPluginPath and updated for rename.
441
442 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
443
444          Reviewed by Antonio Gomes.
445
446          Initialize all members of NPClass struct.
447          https://bugs.webkit.org/show_bug.cgi?id=43193
448
449          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
450
451 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
452
453         Reviewed by Antonio Gomes.
454
455         Warning fix on platforms where XP_MACOSX is undefined.
456         https://bugs.webkit.org/show_bug.cgi?id=43192
457
458         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
459         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
460
461 2010-07-29  Adam Roben  <aroben@apple.com>
462
463         Give find-included-framework-headers our standard license
464
465         * Scripts/find-included-framework-headers: Used the license from
466         WebCore/LICENSE-APPLE.
467
468 2010-07-29  Adam Roben  <aroben@apple.com>
469
470         Speed up find-included-framework-headers
471
472         We only do one invocation of find now, no longer pipe to grep, and
473         replace uniq with sort -u.
474
475         Also added a license header.
476
477         * Scripts/find-included-framework-headers:
478
479 2010-07-29  Steve Block  <steveblock@google.com>
480
481         Reviewed by Jeremy Orlow.
482
483         Add LayoutTestController methods to test DeviceOrientation
484         https://bugs.webkit.org/show_bug.cgi?id=39589
485
486         * DumpRenderTree/LayoutTestController.cpp:
487         (setMockDeviceOrientationCallback):
488         (LayoutTestController::staticFunctions):
489         * DumpRenderTree/LayoutTestController.h:
490         * DumpRenderTree/chromium/LayoutTestController.cpp:
491         * DumpRenderTree/chromium/LayoutTestController.h:
492         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
493         (LayoutTestController::setMockDeviceOrientation):
494         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
495         (LayoutTestController::setMockDeviceOrientation):
496         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
497         (LayoutTestController::setMockDeviceOrientation):
498         * DumpRenderTree/qt/LayoutTestControllerQt.h:
499         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
500         (LayoutTestController::setMockDeviceOrientation):
501         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
502         (LayoutTestController::setMockDeviceOrientation):
503         * Scripts/build-webkit:
504
505 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
506
507         Reviewed by Shinichiro Hamaji.
508
509         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
510         check-webkit-style gives false positives in single-line functions.
511
512         * Scripts/webkitpy/style/checkers/cpp.py:
513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
514
515 2010-07-28  Darin Adler  <darin@apple.com>
516
517         Reviewed by Sam Weinig.
518
519         WebKitTestRunner needs to support layoutTestController.execCommand
520         <https://bugs.webkit.org/show_bug.cgi?id=42538>
521
522         WebKitTestRunner needs layoutTestController.isCommandEnabled
523         <https://bugs.webkit.org/show_bug.cgi?id=42671>
524
525         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
526         Added execCommand and isCommandEnabled.
527         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
528         (WTR::LayoutTestController::execCommand): Added.
529         (WTR::LayoutTestController::isCommandEnabled): Added.
530         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
531
532 2010-07-28  Kent Tamura  <tkent@chromium.org>
533
534         Reviewed by Dimitri Glazkov.
535
536         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
537         https://bugs.webkit.org/show_bug.cgi?id=43123
538
539         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
540         which overrides test expectations only for DumpRenderTree, in
541         order to manage what problems are investigated.
542         This change will be reverted when we switch to DRT completely.
543
544         * Scripts/webkitpy/layout_tests/port/chromium.py:
545          Add drt_expectations.txt content to the result of
546          test_expectations_overrides() if --use-drt is specified.
547
548 2010-07-28  Brady Eidson  <beidson@apple.com>
549
550         Reviewed by Darin Adler.
551
552         First pass at visited link support for WK2
553         https://bugs.webkit.org/show_bug.cgi?id=43157
554
555         * MiniBrowser/mac/AppDelegate.m:
556         (didNavigateWithNavigationData):
557         (didPerformClientRedirect):
558         (didPerformServerRedirect):
559         (didUpdateHistoryTitle):
560         (populateVisitedLinks): Added for the new version of the HistoryClient.
561         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
562         
563         * MiniBrowser/mac/BrowserWindowController.m:
564         (-[BrowserWindowController awakeFromNib]):
565
566 2010-07-28  Robin Dunn  <robin@alldunn.com>
567
568         Reviewed by Kevin Ollivier.
569
570         Add DOM bindings support for wx port.
571
572         * DumpRenderTree/wscript:
573         * wx/browser/wscript:
574         * wx/build/settings.py:
575
576 2010-07-28  Tony Chang  <tony@chromium.org>
577
578         Reviewed by Kent Tamura.
579
580         [chromium] cleanup temp files left by Linux DRT
581         https://bugs.webkit.org/show_bug.cgi?id=43062
582
583         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
584         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
585             by crashed DRTs
586
587 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
588
589         Rubber-stamped by Kenneth Christiansen.
590
591         More Developer menu items reordering.
592
593         Grouping related menu items together, visually and logically (in the code).
594
595         No behavior change.
596
597         * QtTestBrowser/main.cpp:
598         (LauncherWindow::createChrome):
599
600 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
601
602         Reviewed by Ojan Vafai.
603
604         Add FILE_SYSTEM build flag for FileSystem API
605         https://bugs.webkit.org/show_bug.cgi?id=42915
606
607         * Scripts/build-webkit:
608
609 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
610
611         Reviewed by David Levin.
612
613         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
614         https://bugs.webkit.org/show_bug.cgi?id=43090
615
616         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
617         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
618
619 2010-07-27  Kent Tamura  <tkent@chromium.org>
620
621         Unreviewed, trivial typo fix.
622
623         * Scripts/webkitpy/layout_tests/port/chromium.py:
624           Fix a wrong method name committed by r64109.
625
626 2010-07-27  Sam Weinig  <sam@webkit.org>
627
628         Reviewed by Anders Carlsson.
629
630         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
631         Clean up handling of strings at the WebKit2 API layer.
632
633         * MiniBrowser/mac/BrowserWindowController.m:
634         (runJavaScriptAlert):
635         (runJavaScriptConfirm):
636         (runJavaScriptPrompt):
637         (didNavigateWithNavigationData):
638         (-[BrowserWindowController updateProvisionalURLForFrame:]):
639         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
640         (_didClearWindowForFrame):
641
642 2010-07-27  Ojan Vafai  <ojan@chromium.org>
643
644         Reviewed by Eric Seidel.
645
646         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
647         https://bugs.webkit.org/show_bug.cgi?id=42984
648
649         squash and no_squash have been intentionally erroring for a couple weeks now.
650         But post-commits was just broken. Just remove squash/no_squash.
651
652         * Scripts/webkitpy/tool/steps/abstractstep.py:
653         * Scripts/webkitpy/tool/steps/options.py:
654
655 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
656
657         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
658
659         * wx/build/settings.py:
660
661 2010-07-27  Adam Roben  <aroben@apple.com>
662
663         Mac build fix
664
665         * MiniBrowser/mac/BrowserWindowController.m:
666         (processDidExit):
667         (-[BrowserWindowController awakeFromNib]):
668         Added processDidExit support.
669
670 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
671
672         Rubber-stamped by Simon Hausmann.
673
674         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
675
676         Move some less useful menu items on Developers menu from the top to the bottom, so
677         QGraphicsView menu goes to the top, and becomes more quickly accessible.
678
679         * QtTestBrowser/main.cpp:
680         (LauncherWindow::createChrome):
681
682 2010-07-26  Adam Roben  <aroben@apple.com>
683
684         Fix the path to InjectedBundle.dll in Debug_Internal builds
685
686         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
687         InjectedBundle.dll in the Debug_Internal configuration
688
689         Reviewed by Anders Carlsson.
690
691         * WebKitTestRunner/win/TestControllerWin.cpp:
692         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
693         suffix only in Debug_All builds.
694
695 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
696
697         Reviewed by Darin Adler.
698
699         https://bugs.webkit.org/show_bug.cgi?id=42947
700         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
701         error. Without which dumpRenderTree crashes.
702
703         * Scripts/old-run-webkit-tests:
704
705 2010-07-27  Kent Tamura  <tkent@chromium.org>
706
707         Reviewed by Dimitri Glazkov.
708
709         https://bugs.webkit.org/show_bug.cgi?id=42956
710         [DRT/Chromium] Fix "out of sync" assertion error
711
712         Fix an assertion error on Windows like the following:
713         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
714         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
715         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
716
717         * Scripts/webkitpy/layout_tests/port/chromium.py:
718         If the url matches with "file:///[a-z]:", does case-ignore comparison.
719         GURL capitalize the driver letter of a file: URL.
720
721 2010-07-26  Darin Adler  <darin@apple.com>
722
723         Reviewed by Sam Weinig.
724
725         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
726         https://bugs.webkit.org/show_bug.cgi?id=42537
727
728         WebKitTestRunner needs layoutTestController.markerTextForListItem
729         https://bugs.webkit.org/show_bug.cgi?id=42549
730
731         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
732         Fixed _paramterExpression typo. Improved support for string type as a
733         return value, so we don't try to include DOMString.h and we can convert
734         the string to a JSValue by calling JSValueMakeStringOrNull.
735
736         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
737         Added JSValueMakeStringOrNull, used by the code generator.
738
739         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
740         Added counterValueForElementById and markerTextForListItem.
741
742         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
743         Moved constant to the top of the file.
744         (WTR::toCF): Added. Converts strings to CFStringRef.
745         (WTR::toWK): Added. Converts strings to WKStringRef.
746         (WTR::toJS): Added. Converts strings to JSStringRef.
747         (WTR::setProperty): Moved this function to the top of the file
748         rather than having it down where it's used inside the class. Also
749         renamed it so it's a separate function rather than an overload of
750         JSObjectSetProperty.
751         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
752         Should move it somewhere we can share it.
753         (WTR::propertyObject): Ditto.
754         (WTR::getElementById): Added. Calls getElementById through the magic
755         of JavaScript.
756         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
757         Chagned to use toWK instead of four local variables.
758         (WTR::LayoutTestController::counterValueForElementById): Added.
759         Calls WKBundleFrameCopyCounterValue.
760         (WTR::LayoutTestController::markerTextForListItem): Added.
761         Calls WKBundleFrameCopyMarkerText.
762
763         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
764         Added counterValueForElementById and markerTextForListItem.
765
766 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
767
768         Reviewed by Gustavo Noronha Silva.
769
770         [GTK] The EventSender should support simulating drop events
771         https://bugs.webkit.org/show_bug.cgi?id=39844
772
773         Add initial dropping support to the GTK+ EventSender.
774
775         * DumpRenderTree/gtk/DumpRenderTree.cpp:
776         (createWebView): Listen for some new drag-and-drop signals.
777         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
778         (dispatchEvent):
779         Detect situations where a drag is either starting or ending and massage
780         GTK+ into sending the appropriate signals to the WebView.
781         (replaySavedEvents): Remove comment.
782         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
783         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
784         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
785         (dragFailedCallback): Disable the GTK+ drag failed animation.
786         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
787
788 2010-07-26  Daniel Bates  <dbates@rim.com>
789
790         Reviewed by Darin Adler.
791
792         svn-unapply warns of uninitialized variable when unapplying
793         a patch that describes an svn move operation
794         https://bugs.webkit.org/show_bug.cgi?id=42036
795
796         Fixes Perl uninitialized variable warnings when un-applying
797         a patch that moves a file.
798
799         * Scripts/svn-unapply:
800           - Modified patch() so that it initializes $patch to the empty
801             string when we don't have svnConvertedText (such as when
802             reversing a diff that represents a svn copy/move operation).
803
804 2010-07-26  Sam Weinig  <sam@webkit.org>
805
806         Reviewed by Anders Carlsson.
807
808         Move some non-APIish functions into private headers.
809
810         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
811         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
812
813 2010-07-26  Sam Weinig  <sam@webkit.org>
814
815         Reviewed by Anders Carlsson.
816
817         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
818         Add prompt and confirm client functions to WebKit2
819
820         * MiniBrowser/mac/BrowserWindowController.m:
821         (-[BrowserWindowController awakeFromNib]):
822
823 2010-07-26  Adam Roben  <aroben@apple.com>
824
825         Windows build fix
826
827         * MiniBrowser/MiniBrowser.vcproj:
828         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
829         Removed empty attributes so the values will be picked up from the
830         vsprops files. (Also removed a couple of attributes that accidentally
831         duplicated values from the vsprops files.)
832
833 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
834
835         Rubber-stamped by Adam Roben.
836         
837         Touch MiniBrowser's stdafx to fix the build.
838
839         * MiniBrowser/win/stdafx.h:
840
841 2010-07-26  Hayato Ito  <hayato@chromium.org>
842
843         Reviewed by Shinichiro Hamaji.
844
845         Add pretty printer of WTF::Vector for GDB 7.
846
847         https://bugs.webkit.org/show_bug.cgi?id=40909
848
849         * gdb/wtf.py: Added.
850
851 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
852
853         Reviewed by Simon Hausmann.
854
855         [Qt] Fix feature detection regexp
856
857         We were missing the last feature
858
859         * Scripts/webkitdirs.pm:
860
861 2010-07-25  Darin Adler  <darin@apple.com>
862
863         Reviewed by Dan Bernstein.
864
865         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
866         https://bugs.webkit.org/show_bug.cgi?id=42326
867
868         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
869         Added dumpSelectionRect.
870
871         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
872         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
873         does nothing because its purpose is to change pixel test output and
874         we do not have pixel tests implemented yet.
875
876 2010-07-25  Darin Adler  <darin@apple.com>
877
878         Reviewed by Maciej Stachowiak.
879
880         WebKitTestRunner needs to support layoutTestController.keepWebHistory
881         https://bugs.webkit.org/show_bug.cgi?id=42323
882
883         Added keepWebHistory and computedStyleIncludingVisitedInfo.
884
885         Also fixed misspellings of the word "receive".
886
887         Also tweaked the names of some of the LayoutTestController members.
888
889         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
890         Added support for a type named "object" that is passed and returns as
891         a JSValueRef.
892
893         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
894         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
895         put setAcceptsEditing up nearer the top.
896
897         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
898         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
899         (WTR::InjectedBundle::initialize): Ditto.
900         (WTR::InjectedBundle::didReceiveMessage): Ditto.
901         (WTR::InjectedBundle::reset): Reset the state of visited links between
902         tests. Also eliminated the unused argument to the LayoutTestController
903         create function.
904         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
905         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
906
907         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
908         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
909         instead of acceptsEditing.
910         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
911         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
912         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
913         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
914         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
915         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
916
917         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
918         (WTR::LayoutTestController::create): Removed uneeded argument.
919         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
920         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
921         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
922         about the fact that this works on the main frame.
923         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
924         (WTR::LayoutTestController::keepWebHistory): Added.
925         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
926         (WTR::JSObjectSetProperty): Added. Helper to make the function below
927         cleaner.
928         (WTR::LayoutTestController::makeWindowObject): Changed to use the
929         overload of JSObjectSetProperty above.
930
931         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
932         match above.
933
934         * WebKitTestRunner/TestController.cpp:
935         (WTR::TestController::initialize): Fixed mispellings of receive.
936         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
937         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
938         * WebKitTestRunner/TestController.h: Ditto.
939         * WebKitTestRunner/TestInvocation.cpp:
940         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
941         * WebKitTestRunner/TestInvocation.h: Ditto.
942
943 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
944
945         Reviewed by Sam Weinig.
946
947         https://bugs.webkit.org/show_bug.cgi?id=42193
948         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
949
950         Step 2 - add the rest of editing delegates.
951
952         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
953         (WTR::operator<<): Fixed to not crash when range is null.
954         (WTR::InjectedBundlePage::InjectedBundlePage):
955         (WTR::InjectedBundlePage::_shouldEndEditing):
956         (WTR::InjectedBundlePage::_shouldInsertNode):
957         (WTR::InjectedBundlePage::_shouldInsertText):
958         (WTR::InjectedBundlePage::_shouldDeleteRange):
959         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
960         (WTR::InjectedBundlePage::_shouldApplyStyle):
961         (WTR::InjectedBundlePage::_didBeginEditing):
962         (WTR::InjectedBundlePage::_didEndEditing):
963         (WTR::InjectedBundlePage::_didChange):
964         (WTR::InjectedBundlePage::_didChangeSelection):
965         (WTR::InjectedBundlePage::shouldEndEditing):
966         (WTR::InjectedBundlePage::shouldInsertNode):
967         (WTR::InjectedBundlePage::shouldInsertText):
968         (WTR::InjectedBundlePage::shouldDeleteRange):
969         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
970         (WTR::InjectedBundlePage::shouldApplyStyle):
971         (WTR::InjectedBundlePage::didBeginEditing):
972         (WTR::InjectedBundlePage::didEndEditing):
973         (WTR::InjectedBundlePage::didChange):
974         (WTR::InjectedBundlePage::didChangeSelection):
975         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
976
977 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
978
979         Reviewed by David Kilzer.
980
981         AX: need a layout test testing misspelled words in attributed strings
982         https://bugs.webkit.org/show_bug.cgi?id=42899
983
984         * DumpRenderTree/AccessibilityUIElement.cpp:
985         (attributedStringForRangeCallback):
986         (attributedStringRangeIsMisspelledCallback):
987         (AccessibilityUIElement::getJSClass):
988         * DumpRenderTree/AccessibilityUIElement.h:
989         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
990         (AccessibilityUIElement::attributedStringForRange):
991         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
992         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
993         (AccessibilityUIElement::attributedStringForRange):
994         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
995         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
996         (AccessibilityUIElement::attributedStringForRange):
997         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
998
999 2010-07-23  David Kilzer  <ddkilzer@apple.com>
1000
1001         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
1002
1003         Reviewed by Mark Rowe.
1004
1005         * Scripts/check-for-inappropriate-files-in-framework: Added
1006         check for the SHALLOW_BUNDLE environment variable so that the
1007         script will work with iOS WebKit builds.
1008         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
1009
1010 2010-07-22  Darin Adler  <darin@apple.com>
1011
1012         Reviewed by Sam Weinig.
1013
1014         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
1015         https://bugs.webkit.org/show_bug.cgi?id=42847
1016
1017         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1018         (WTR::operator<<): Replaced the WKStringToUTF8 function with
1019         a set of overloaded stream operators.
1020         (WTR::dumpPath): Changed to use ostringstream and return a string.
1021         (WTR::propertyValue): Added.
1022         (WTR::propertyObject): Added.
1023         (WTR::propertyString): Added.
1024         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
1025         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
1026         since we now have suitable streaming functions.
1027         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
1028         WKBundleFrameCopyInnerText.
1029         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
1030         since we now have suitable streaming functions.
1031         (WTR::InjectedBundlePage::dump): Ditto.
1032         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
1033         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
1034         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
1035         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
1036         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
1037
1038 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
1039
1040         Reviewed by Sam Weinig and Darin Adler.
1041
1042         https://bugs.webkit.org/show_bug.cgi?id=42193
1043         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
1044
1045         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
1046         fixed, but this makes difference one line smaller on many editing tests.
1047
1048         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1049         Added dumpEditingCallbacks() and setAcceptsEditing().
1050
1051         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1052         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
1053         (WTR::operator<<): Print a range.
1054         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
1055         clients.
1056         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
1057         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
1058         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
1059         calls.
1060
1061         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1062         (WTR::LayoutTestController::LayoutTestController):
1063         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1064         (WTR::LayoutTestController::dumpEditingCallbacks):
1065         (WTR::LayoutTestController::setAcceptsEditing):
1066         (WTR::LayoutTestController::acceptsEditing):
1067         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
1068         Store m_acceptsEditing and m_dumpEditingCallbacks.
1069
1070 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
1071
1072         Reviewed by Laszlo Gombos.
1073
1074         [Qt] QtWebKit needs public API for Notifications.
1075         https://bugs.webkit.org/show_bug.cgi?id=41413
1076
1077         Update DumpRenderTree and QtTestBrowser to use the new API.
1078         Add new DRT API to flag that notifications permission requests should be ignored.
1079
1080         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1081         (WebCore::WebPage::WebPage):
1082         (WebCore::WebPage::requestPermission):
1083         (WebCore::WebPage::checkPermission):
1084         (WebCore::WebPage::cancelRequestsForPermission):
1085         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1086         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1087         (LayoutTestController::reset):
1088         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
1089         (LayoutTestController::checkDesktopNotificationPermission):
1090         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1091         (LayoutTestController::ignoreReqestForPermission):
1092         * QtTestBrowser/main.cpp:
1093         (LauncherWindow::LauncherWindow):
1094         * QtTestBrowser/webpage.cpp:
1095         (WebPage::WebPage):
1096         (WebPage::requestPermission):
1097         (WebPage::checkPermission):
1098         (WebPage::cancelRequestsForPermission):
1099         * QtTestBrowser/webpage.h:
1100
1101 2010-07-22  Darin Adler  <darin@apple.com>
1102
1103         Reviewed by Sam Weinig.
1104
1105         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
1106         https://bugs.webkit.org/show_bug.cgi?id=42325
1107
1108         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1109         Added dumpChildFramesAsText.
1110
1111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1112         (WTR::dumpFrameText): Added.
1113         (WTR::dumpDescendantFramesText): Added.
1114         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
1115         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
1116         instead of the shouldDumpAsText function, and added a case for AllFramesText.
1117
1118         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
1119
1120         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1121         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
1122         m_whatToDump.
1123
1124         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
1125         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
1126         and shouldDumpSourceAsWebArchive. Added whatToDump.
1127
1128 2010-07-22  Adam Roben  <aroben@apple.com>
1129
1130         Windows build fix
1131
1132         Inspired by r63881.
1133
1134         * MiniBrowser/MiniBrowser.vcproj:
1135         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
1136         Removed pre- and post-build events so they will be inherited from the
1137         vsprops files.
1138
1139 2010-07-21  Darin Adler  <darin@apple.com>
1140
1141         Reviewed by Sam Weinig.
1142
1143         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
1144         https://bugs.webkit.org/show_bug.cgi?id=42548
1145
1146         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1148         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
1149         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
1150         Changed to a file-internal function instead of a member function.
1151         (WTR::dumpDescendantFrameScrollPositions): Added.
1152         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
1153         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
1154         appropriate. Also streamlined all the WKStringToUTF8 call sites.
1155         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
1156         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
1157         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
1158         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
1159         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
1160
1161         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
1162
1163         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1164         (WTR::LayoutTestController::LayoutTestController): Initialize
1165         m_shouldDumpAllFrameScrollPositions.
1166         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
1167         shouldDumpFrameScrollPositions.
1168
1169         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
1170         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
1171         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
1172
1173 2010-07-21  Darin Adler  <darin@apple.com>
1174
1175         Reviewed by Sam Weinig.
1176
1177         WebKitTestRunner needs to support dumping of scroll position
1178         https://bugs.webkit.org/show_bug.cgi?id=42514
1179
1180         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1181         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
1182
1183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1184         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
1185         instead of JSContextRef.
1186         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
1187         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
1188         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
1189         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
1190         instead of JSContextRef.
1191
1192         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
1193         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
1194
1195         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1196         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
1197         returns false.
1198         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
1199         returns false.
1200         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
1201         the logic in DumpRenderTree.
1202
1203         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
1204
1205         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
1206
1207 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
1208
1209         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
1210
1211         * wx/build/settings.py:
1212
1213 2010-07-21  Sam Weinig  <sam@webkit.org>
1214
1215         Reviewed by Anders Carlsson.
1216
1217         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
1218         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
1219
1220         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1221         (WTR::InjectedBundlePage::InjectedBundlePage):
1222         (WTR::InjectedBundlePage::_willAddMessageToConsole):
1223         (WTR::InjectedBundlePage::_willSetStatusbarText):
1224         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
1225         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
1226         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
1227         (WTR::InjectedBundlePage::willAddMessageToConsole):
1228         (WTR::InjectedBundlePage::willSetStatusbarText):
1229         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1230         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1231         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1232         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1233
1234 2010-07-21  Adam Roben  <aroben@apple.com>
1235
1236         Give InjectedBundle our standard set of configurations (minus the
1237         *_Cairo variants)
1238
1239         InjectedBundle's Debug_All configuration was the same as is Debug
1240         configuration, and it was missing a Debug_Internal configuration.
1241
1242         Fixes <http://webkit.org/b/42749> InjectedBundle's build
1243         configurations are screwy
1244
1245         Reviewed by Darin Adler.
1246
1247         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
1248         debug_internal.vsprops and debug_all.vsprops to the Debug_All
1249         configuration. Added a Debug_Internal configuration.
1250
1251         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
1252         variant of InjectedBundle when we're using the Debug_Internal solution
1253         configuration.
1254
1255 2010-07-21  Adam Roben  <aroben@apple.com>
1256
1257         Move InjectedBundle's settings to a vsprops file
1258
1259         This will make it easier to change settings for all configurations,
1260         and to add new configurations.
1261
1262         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
1263         files
1264
1265         Reviewed by Darin Adler.
1266
1267         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
1268         Moved settings here...
1269         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
1270         here.
1271
1272 2010-07-21  Adam Roben  <aroben@apple.com>
1273
1274         Give MiniBrowser our standard set of configurations (minus the *_Cairo
1275         variants)
1276
1277         MiniBrowser already had a configuration called "Release", but it was
1278         using mostly the same settings as Debug. And its Debug configuration
1279         was using the settings that Debug_Internal should be using.
1280
1281         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
1282         are screwy
1283
1284         Reviewed by Darin Adler.
1285
1286         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
1287         the Debug configuration. Remove debug.vsprops and
1288         debug_internal.vsprops from the Release configuration and replace them
1289         with release.vsprops. Added Debug_Internal and Debug_All
1290         configurations.
1291
1292 2010-07-21  Adam Roben  <aroben@apple.com>
1293
1294         Move MiniBrowser's settings to a vsprops file
1295
1296         This will make it easier to change settings for all configurations,
1297         and to add new configurations.
1298
1299         MiniBrowser should use vsprops files
1300         https://bugs.webkit.org/show_bug.cgi?id=42745
1301
1302         Reviewed by Darin Adler.
1303
1304         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
1305         settings here...
1306         * MiniBrowser/MiniBrowser.vcproj: ...from here.
1307
1308 2010-07-21  Adam Roben  <aroben@apple.com>
1309
1310         Fix compiler warnings when building MiniBrowser
1311
1312         Also cleaned up the .vcproj a bit.
1313
1314         Fixes <http://webkit.org/b/42743>.
1315
1316         Reviewed by Darin Adler.
1317
1318         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
1319         already defined in .vsprops files. This also fixes a warning about
1320         /EDITANDCONTINUE being incompatible with /SAFESEH.
1321
1322         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
1323         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
1324         being redefined. (I think this will also get us closer to building
1325         with VC++ Express.)
1326
1327 2010-07-20  Sam Weinig  <sam@webkit.org>
1328
1329         Reviewed by Jon Honeycutt.
1330
1331         Fix obvious typo.
1332
1333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1334         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
1335
1336 2010-07-20  Tony Chang  <tony@chromium.org>
1337
1338         Reviewed by Kent Tamura.
1339
1340         [chromium] by default, dumpAsText should disable pixel results
1341         https://bugs.webkit.org/show_bug.cgi?id=42715
1342
1343         * DumpRenderTree/chromium/LayoutTestController.cpp:
1344         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
1345
1346 2010-07-20  Adam Roben  <aroben@apple.com>
1347
1348         Windows build fix
1349
1350         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
1351         WebKit.lib instead of the old, dusty WebKit2.lib.
1352
1353 2010-07-20  Adam Roben  <aroben@apple.com>
1354
1355         Stop linking WebKitTestRunner against getopt
1356
1357         Use of getopt was removed in r63700.
1358
1359         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
1360         getopt, but doesn't need to
1361
1362         Reviewed by Sam Weinig.
1363
1364         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
1365         from all configurations.
1366
1367 2010-07-20  Adam Roben  <aroben@apple.com>
1368
1369         Make run-webkit-tests --webkit-test-runner "work" on Windows
1370
1371         WebKitTestRunner crashes on launch, but at least the scripts build and
1372         launch it!
1373
1374         Fixes <http://webkit.org/b/42709> run-webkit-tests
1375         --webkit-test-runner bails with an error on Windows
1376
1377         Reviewed by Anders Carlsson.
1378
1379         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
1380         Windows.
1381         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
1382         projects (from first-built to last-built): FindSafari, ImageDiff,
1383         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
1384
1385 2010-07-20  Adam Roben  <aroben@apple.com>
1386
1387         Change build-webkit back to building WebKit.sln on Windows
1388
1389         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
1390         is being removed.
1391
1392         Rubber-stamped in advance by Steve Falkenburg.
1393
1394         * Scripts/build-webkit:
1395
1396 2010-07-20  Adam Roben  <aroben@apple.com>
1397
1398         Windows build fix
1399
1400         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
1401
1402 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
1403
1404         Reviewed by Geoffrey Garen.
1405
1406         WebScriptObject Should Allow Safely Checking For Key Existence
1407         https://bugs.webkit.org/show_bug.cgi?id=42613
1408
1409         Normal ObjCController workflow for a WebScriptObject test.
1410
1411         * DumpRenderTree/mac/ObjCController.m:
1412         (+[ObjCController isSelectorExcludedFromWebScript:]):
1413         (+[ObjCController webScriptNameForSelector:]):
1414         (-[ObjCController testHasWebScriptKey:]):
1415
1416 2010-07-20  Chris Marrin  <cmarrin@apple.com>
1417
1418         Reviewed by Simon Fraser.
1419
1420         https://bugs.webkit.org/show_bug.cgi?id=42118
1421         Disable compositing/webgl tests if WebGL is not enabled
1422
1423         * Scripts/old-run-webkit-tests:
1424
1425 2010-07-20  Anton Muhin  <antonm@chromium.org>
1426
1427         Reviewed by Darin Adler.
1428
1429         Print additional information about exception if failed to connect to apache (in verbose mode).
1430         https://bugs.webkit.org/show_bug.cgi?id=42627
1431
1432         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1433
1434 2010-07-20  Tony Chang  <tony@chromium.org>
1435
1436         Reviewed by David Levin.
1437
1438         [chromium] only pass --force to gclient sync if explicitly stated
1439         https://bugs.webkit.org/show_bug.cgi?id=42581
1440
1441         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
1442               always pass --force since it's hard to do manual cleanups
1443         * Scripts/update-webkit-chromium: only pass --force if --force is
1444               passed in
1445
1446 2010-07-19  Anders Carlsson  <andersca@apple.com>
1447
1448         Fix build.
1449
1450         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1451         Paths of generated files should be relative to the build product.
1452
1453 2010-07-19  Daniel Bates  <dbates@rim.com>
1454
1455         Reviewed by Adam Roben.
1456
1457         [Win] Implement LayoutTestController::markerTextForListItem()
1458         https://bugs.webkit.org/show_bug.cgi?id=37930
1459
1460         Implements DRT support for markerTextForListItem in the Windows port.
1461
1462         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1463         (LayoutTestController::markerTextForListItem): Implemented.
1464
1465 2010-07-19  Jessie Berlin  <jberlin@apple.com>
1466
1467         Windows build fix. Unreviewed.
1468
1469         * WebKitTestRunner/win/TestControllerWin.cpp:
1470         (WTR::TestController::initializeTestPluginPath):
1471
1472 2010-07-19  Sam Weinig  <sam@webkit.org>
1473
1474         Reviewed by Jon Honeycutt.
1475
1476         Remove dependency on getopt from WebKitTestRunner.
1477
1478         - Simplify options parsing and eliminate unused options.
1479
1480         * WebKitTestRunner/TestController.cpp:
1481         (WTR::TestController::TestController):
1482         (WTR::TestController::initialize):
1483         * WebKitTestRunner/TestController.h:
1484         (WTR::TestController::testPluginPath):
1485         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1486         * WebKitTestRunner/mac/TestControllerMac.mm:
1487         (WTR::TestController::platformInitialize):
1488         (WTR::TestController::initializeTestPluginPath):
1489         * WebKitTestRunner/win/TestControllerWin.cpp:
1490         (WTR::TestController::platformInitialize):
1491         (WTR::TestController::initializeTestPluginPath):
1492
1493 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
1494
1495         Reviewed by Antonio Gomes.
1496
1497         [Qt] MiniBrowser: Progress indication at address bar
1498         https://bugs.webkit.org/show_bug.cgi?id=42565
1499
1500         Make possible to see load progress at address bar based on
1501         QtTestBrowser solution
1502
1503         * MiniBrowser/qt/BrowserWindow.cpp:
1504         (BrowserWindow::BrowserWindow):
1505         (BrowserWindow::loadProgress):
1506         * MiniBrowser/qt/BrowserWindow.h:
1507
1508 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
1509
1510         Reviewed by Antonio Gomes.
1511
1512         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
1513         https://bugs.webkit.org/show_bug.cgi?id=42564
1514
1515         * MiniBrowser/qt/BrowserWindow.cpp:
1516         (BrowserView::load):
1517         (BrowserWindow::BrowserWindow):
1518         (BrowserWindow::titleChanged):
1519         (BrowserWindow::urlChanged):
1520         * MiniBrowser/qt/BrowserWindow.h:
1521
1522 2010-07-19  Sam Weinig  <weinig@apple.com>
1523
1524         Reviewed by Adam Roben.
1525
1526         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
1527         Auto-generate the JS bindings for WebKitTestRunner's script objects.
1528
1529         * WebKitTestRunner/Configurations/Base.xcconfig:
1530         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1531         * WebKitTestRunner/DerivedSources.make: Added.
1532         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
1533         * WebKitTestRunner/InjectedBundle/Bindings: Added.
1534         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
1535         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
1536         (WTR::JSWrappable::~JSWrappable):
1537         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
1538         (WTR::JSWrapper::wrap):
1539         (WTR::JSWrapper::unwrap):
1540         (WTR::unwrapObject):
1541         (WTR::JSWrapper::initialize):
1542         (WTR::JSWrapper::finalize):
1543         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
1544         (WTR::toJS):
1545         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
1546         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1547         (WTR::InjectedBundlePage::dump):
1548         (WTR::InjectedBundlePage::setStatusbarText):
1549         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1550         (WTR::LayoutTestController::wrapperClass):
1551         (WTR::LayoutTestController::waitUntilDone):
1552         (WTR::LayoutTestController::makeWindowObject):
1553         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1554         (WTR::LayoutTestController::shouldDumpAsText):
1555         (WTR::LayoutTestController::dumpAsText):
1556         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
1557         (WTR::LayoutTestController::dumpStatusCallbacks):
1558         (WTR::LayoutTestController::waitToDump):
1559         (WTR::LayoutTestController::testRepaint):
1560         (WTR::LayoutTestController::repaintSweepHorizontally):
1561         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
1562         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1563         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
1564         * WebKitTestRunner/win/build-generated-files.sh: Added.
1565
1566 2010-07-19  Mark Rowe  <mrowe@apple.com>
1567
1568         Clean up the buildbot configuration a little.
1569
1570         * BuildSlaveSupport/build.webkit.org-config/config.json:
1571
1572 2010-07-19  Chris Marrin  <cmarrin@apple.com>
1573
1574         Reviewed by Darin Adler.
1575
1576         https://bugs.webkit.org/show_bug.cgi?id=42118
1577         Disable WebGL on Leopard for now. 
1578
1579         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
1580         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
1581         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
1582         software OpenGL driver on machines without this support.
1583
1584         * Scripts/build-webkit:
1585
1586 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
1587
1588         Reviewed by Brady Eidson.
1589
1590         Fix MiniBrowser to update URL as you browse
1591         https://bugs.webkit.org/show_bug.cgi?id=42591
1592         
1593         Hook up various loading notifications to update the URL bar in MiniBrowser.
1594
1595         * MiniBrowser/mac/BrowserWindowController.m:
1596         (_didStartProvisionalLoadForFrame):
1597         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1598         (_didFailProvisionalLoadWithErrorForFrame):
1599         (_didCommitLoadForFrame):
1600         (_didFailLoadWithErrorForFrame):
1601         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1602         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
1603         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
1604         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
1605         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
1606         (-[BrowserWindowController didCommitLoadForFrame:]):
1607
1608 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
1609
1610         Reviewed by Darin Adler.
1611
1612         https://bugs.webkit.org/show_bug.cgi?id=42586
1613         Log all canceled authentication attempts in DumpRenderTree
1614
1615         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1616         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1617         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1618         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1619         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
1620         case.
1621
1622 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1623
1624         Unreviewed, rolling out r63671.
1625         http://trac.webkit.org/changeset/63671
1626         https://bugs.webkit.org/show_bug.cgi?id=42575
1627
1628         broke windows (Requested by weinig on #webkit).
1629
1630         * WebKitTestRunner/Configurations/Base.xcconfig:
1631         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1632         * WebKitTestRunner/DerivedSources.make: Removed.
1633         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
1634         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
1635         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
1636         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
1637         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
1638         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
1639         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1640         (WTR::InjectedBundlePage::dump):
1641         (WTR::InjectedBundlePage::setStatusbarText):
1642         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1643         (WTR::LayoutTestController::setWaitToDump):
1644         (WTR::displayCallback):
1645         (WTR::dumpAsTextCallback):
1646         (WTR::dumpStatusCallbacksCallback):
1647         (WTR::waitUntilDoneCallback):
1648         (WTR::notifyDoneCallback):
1649         (WTR::numberOfActiveAnimationsCallback):
1650         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
1651         (WTR::repaintSweepHorizontallyCallback):
1652         (WTR::testRepaintCallback):
1653         (WTR::layoutTestControllerObjectFinalize):
1654         (WTR::LayoutTestController::makeWindowObject):
1655         (WTR::LayoutTestController::getJSClass):
1656         (WTR::LayoutTestController::staticFunctions):
1657         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1658         (WTR::LayoutTestController::dumpAsText):
1659         (WTR::LayoutTestController::setDumpAsText):
1660         (WTR::LayoutTestController::dumpStatusCallbacks):
1661         (WTR::LayoutTestController::setDumpStatusCallbacks):
1662         (WTR::LayoutTestController::setTestRepaint):
1663         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
1664         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1665
1666 2010-07-19  Sam Weinig  <sam@webkit.org>
1667
1668         Reviewed by Adam Roben.
1669
1670         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
1671         Auto-generate the JS bindings for WebKitTestRunner's script objects.
1672
1673         * WebKitTestRunner/Configurations/Base.xcconfig:
1674         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1675         * WebKitTestRunner/DerivedSources.make: Added.
1676         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
1677         * WebKitTestRunner/InjectedBundle/Bindings: Added.
1678         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
1679         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
1680         (WTR::JSWrappable::~JSWrappable):
1681         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
1682         (WTR::JSWrapper::wrap):
1683         (WTR::JSWrapper::unwrap):
1684         (WTR::unwrapObject):
1685         (WTR::JSWrapper::initialize):
1686         (WTR::JSWrapper::finalize):
1687         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
1688         (WTR::toJS):
1689         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
1690         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1691         (WTR::InjectedBundlePage::dump):
1692         (WTR::InjectedBundlePage::setStatusbarText):
1693         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1694         (WTR::LayoutTestController::wrapperClass):
1695         (WTR::LayoutTestController::waitUntilDone):
1696         (WTR::LayoutTestController::makeWindowObject):
1697         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1698         (WTR::LayoutTestController::shouldDumpAsText):
1699         (WTR::LayoutTestController::dumpAsText):
1700         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
1701         (WTR::LayoutTestController::dumpStatusCallbacks):
1702         (WTR::LayoutTestController::waitToDump):
1703         (WTR::LayoutTestController::testRepaint):
1704         (WTR::LayoutTestController::repaintSweepHorizontally):
1705         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1706
1707 2010-07-19  Tony Chang  <tony@chromium.org>
1708
1709         Reviewed by David Levin.
1710
1711         fix chromium linux compile on ubuntu maverick
1712         https://bugs.webkit.org/show_bug.cgi?id=42528
1713
1714         * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
1715
1716 2010-07-19  Adam Roben  <aroben@apple.com>
1717
1718         When dumping a response's MIME type, print its URL's last path
1719         component rather than its suitable-for-test-result form
1720
1721         This matches the Mac behavior.
1722
1723         Fixes <http://webkit.org/b/42276>
1724         http/tests/loading/preload-slow-loading.php and
1725         http/tests/mime/uppercase-mime-type.html fail on Windows
1726
1727         Reviewed by Anders Carlsson.
1728
1729         * DumpRenderTree/win/DumpRenderTree.cpp:
1730         (urlSuitableForTestResult): Moved code to actually extract the last
1731         path component from here...
1732         (lastPathComponent): ...to here.
1733
1734         * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
1735
1736         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1737         (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
1738         component, rather than its suitable-for-test-result form, to match
1739         Mac.
1740
1741 2010-07-19  Anders carlsson  <andersca@apple.com>
1742
1743         Reviewed by Adam Roben.
1744
1745         WebKit2 does not have application cache
1746         https://bugs.webkit.org/show_bug.cgi?id=42552
1747
1748         * WebKitTestRunner/TestInvocation.cpp:
1749         (WTR::TestInvocation::resetPreferencesToConsistentValues):
1750         Set up default preferences. Right now just enables the web application cache.
1751
1752         (WTR::TestInvocation::invoke):
1753         Call resetPreferencesToConsistentValues.
1754
1755         * WebKitTestRunner/TestInvocation.h:
1756
1757 2010-07-19  Kent Tamura  <tkent@chromium.org>
1758
1759         Reviewed by Adam Roben.
1760
1761         Fix NewRunWebKitTests to work on Windows.
1762         https://bugs.webkit.org/show_bug.cgi?id=41180
1763
1764         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1765           Specifying python explicitly.
1766
1767 2010-07-18  Anders Carlsson  <andersca@apple.com>
1768
1769         Reviewed by Dan Bernstein.
1770
1771         Add dumping of statusbar text to WebKitTestRunner
1772         https://bugs.webkit.org/show_bug.cgi?id=42516
1773
1774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1775         (WTR::InjectedBundlePage::InjectedBundlePage):
1776         (WTR::InjectedBundlePage::_setStatusbarText):
1777         (WTR::InjectedBundlePage::setStatusbarText):
1778         Dump the statusbar text.
1779
1780         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1781         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1782         (WTR::LayoutTestController::LayoutTestController):
1783         Initialize m_dumpStatusCallbacks to false.
1784
1785         (WTR::dumpStatusCallbacksCallback):
1786         Implement JSC callback.
1787
1788         (WTR::LayoutTestController::staticFunctions):
1789         Add dumpStatusCallbacks.
1790
1791         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1792         (WTR::LayoutTestController::dumpStatusCallbacks):
1793         (WTR::LayoutTestController::setDumpStatusCallbacks):
1794         Add setter and getter for m_dumpStatusCallbacks.
1795
1796 2010-07-17  Anders Carlsson  <andersca@apple.com>
1797
1798         Reviewed by Maciej Stachowiak.
1799
1800         * WebKitTestRunner/TestController.cpp:
1801         (WTR::TestController::initialize):
1802         Get the test plug-in path and set it on the context.
1803
1804         * WebKitTestRunner/TestController.h:
1805         * WebKitTestRunner/mac/TestControllerMac.mm:
1806         (WTR::TestController::initializeInjectedBundlePath):
1807         Simplify this code by using NSBundle.
1808
1809         (WTR::TestController::testPluginPath):
1810         Return the test plug-in path.
1811
1812         * WebKitTestRunner/win/TestControllerWin.cpp:
1813         (WTR::TestController::testPluginPath):
1814         Ditto.
1815
1816 2010-07-16  Adam Barth  <abarth@webkit.org>
1817
1818         Reviewed by Eric Seidel.
1819
1820         Teach webkitpy about queues.webkit.org
1821         https://bugs.webkit.org/show_bug.cgi?id=42492
1822
1823         * Scripts/webkitpy/common/net/statusserver.py:
1824
1825 2010-07-16  Ada Chan  <adachan@apple.com>
1826
1827         Reviewed by Alice Liu.
1828
1829         Fix Windows build.
1830
1831         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
1832
1833 2010-07-16  Sam Weinig  <sam@webkit.org>
1834
1835         Reviewed by Anders Carlsson.
1836
1837         Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
1838         <rdar://problem/8197701>
1839         Add notification of when the BackForwardList changes
1840         to aid invalidation of Back/Forward related UI elements.
1841
1842         * MiniBrowser/mac/BrowserWindowController.m:
1843         (_didStartProvisionalLoadForFrame):
1844         (_didCommitLoadForFrame):
1845         (_didFailLoadWithErrorForFrame):
1846         (_didChangeBackForwardList):
1847         (-[BrowserWindowController awakeFromNib]):
1848         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1849
1850 2010-07-16  Kent Tamura  <tkent@chromium.org>
1851
1852         Reviewed by Darin Fisher.
1853
1854         [Chromium] <input type=number> UI implementation for Windows
1855         https://bugs.webkit.org/show_bug.cgi?id=42259
1856
1857         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1858         (WebThemeEngineDRT::paintSpinButton):
1859          Added. Check state consistency and use existing arrow painting code.
1860         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1861
1862 2010-07-16  Alice Liu  <alice.liu@apple.com>
1863
1864         Reviewed by Sam Weinig.
1865
1866         https://bugs.webkit.org/show_bug.cgi?id=42430
1867         Make WebKitTestRunner on Windows actually load and run a test
1868
1869         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
1870         (WKBundleInitialize):
1871         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added.  Output is a dll.
1872         * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
1873         (WTR::createWKURL):
1874         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
1875         other existing checks, and avoid including Platform.h
1876         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1877         (WTR::registerWindowClass): Added.
1878         (WTR::PlatformWebView::PlatformWebView): Implemented.
1879         (WTR::PlatformWebView::~PlatformWebView): Implemented.
1880         (WTR::PlatformWebView::page): Implemented.
1881         * WebKitTestRunner/win/TestControllerWin.cpp:
1882         (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 
1883         configuration specific path to InjectedBundle.dll.
1884         * WebKitTestRunner/win/TestInvocationWin.cpp:
1885         (WTR::TestInvocation::runUntil): Implemented.
1886         * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
1887         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
1888
1889 2010-07-16  Brady Eidson  <beidson@apple.com>
1890
1891         Reviewed by Sam Weinig.
1892
1893         Make revalidation of back/forward work a little better with page loads
1894         https://bugs.webkit.org/show_bug.cgi?id=42470
1895
1896         * MiniBrowser/mac/BrowserWindow.xib:
1897         * MiniBrowser/mac/BrowserWindowController.h:
1898         * MiniBrowser/mac/BrowserWindowController.m:
1899         (-[BrowserWindowController validateToolbar]):
1900         (_didStartProvisionalLoadForFrame):
1901         (_didCommitLoadForFrame):
1902         (_didFailLoadWithErrorForFrame):
1903
1904 2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
1905
1906         Reviewed by Dirk Schulze.
1907
1908         Add possibility to dumpAsText and generate a pixel test result
1909         https://bugs.webkit.org/show_bug.cgi?id=42374
1910
1911         Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
1912         setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
1913
1914         This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
1915         At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
1916
1917         Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
1918         (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
1919
1920         * DumpRenderTree/LayoutTestController.cpp:
1921         (LayoutTestController::LayoutTestController):
1922         (dumpAsTextAndPixelsCallback):
1923         (LayoutTestController::staticFunctions):
1924         * DumpRenderTree/LayoutTestController.h:
1925         (LayoutTestController::dumpAsTextAndPixels):
1926         (LayoutTestController::setDumpAsTextAndPixels):
1927         * DumpRenderTree/chromium/LayoutTestController.cpp:
1928         (LayoutTestController::LayoutTestController):
1929         (LayoutTestController::dumpAsTextAndPixels):
1930         (LayoutTestController::reset):
1931         * DumpRenderTree/chromium/LayoutTestController.h:
1932         (LayoutTestController::shouldDumpAsTextAndPixels):
1933         * DumpRenderTree/chromium/TestShell.cpp:
1934         (TestShell::dump):
1935         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1936         (dump):
1937         * DumpRenderTree/mac/DumpRenderTree.mm:
1938         (dump):
1939         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1940         (WebCore::DumpRenderTree::dump):
1941         * DumpRenderTree/win/DumpRenderTree.cpp:
1942         (dump):
1943         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1944         (dump):
1945
1946 2010-07-16  Kent Hansen  <kent.hansen@nokia.com>
1947
1948         Unreviewed. Adding myself as committer.
1949
1950         * Scripts/webkitpy/common/config/committers.py:
1951
1952 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
1953
1954         Another uneviewed attempt to fix build.
1955
1956         Printing test results differ between machines, we should use ImageDiff instead
1957         https://bugs.webkit.org/show_bug.cgi?id=20011
1958
1959         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1960         (createPagedBitmapContext):
1961
1962 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
1963
1964         Unreviewed tiger build fix.
1965
1966         Printing test results differ between machines, we should use ImageDiff instead
1967         https://bugs.webkit.org/show_bug.cgi?id=20011
1968
1969         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1970         (createBitmapContext):
1971         (createBitmapContextFromWebView):
1972
1973 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
1974
1975         Unreviewed build fix.
1976
1977         Printing test results differ between machines, we should use ImageDiff instead
1978         https://bugs.webkit.org/show_bug.cgi?id=20011
1979
1980         * DumpRenderTree/PixelDumpSupport.cpp:
1981         (dumpWebViewAsPixelsAndCompareWithExpected):
1982
1983 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
1984
1985         Reviewed by Darin Adler.
1986
1987         Printing test results differ between machines, we should use ImageDiff instead
1988         https://bugs.webkit.org/show_bug.cgi?id=20011
1989
1990         * DumpRenderTree/PixelDumpSupport.cpp:
1991         (dumpWebViewAsPixelsAndCompareWithExpected):
1992         * DumpRenderTree/PixelDumpSupport.h:
1993         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1994         (createBitmapContext): This function was added to share bitmap context creation code.
1995         (createBitmapContextFromWebView):
1996         (createPagedBitmapContext):
1997
1998 2010-07-15  Yuta Kitamura  <yutak@chromium.org>
1999
2000         Reviewed by Kent Tamura.
2001
2002         Pull in pywebsocket-0.5.1
2003         https://bugs.webkit.org/show_bug.cgi?id=42353
2004
2005         pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
2006         in Chromium. There is no other functional change.
2007
2008         (*) http://code.google.com/p/pywebsocket/source/detail?r=265
2009
2010         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
2011
2012 2010-07-15  Brady Eidson  <beidson@apple.com>
2013
2014         Reviewed by Sam Weinig.
2015
2016         Add toolbar and toolbar item validation for MiniBrowser
2017         https://bugs.webkit.org/show_bug.cgi?id=42422
2018
2019         * MiniBrowser/MBToolbarItem.h: Added.
2020         * MiniBrowser/MBToolbarItem.m: Added.
2021         (-[MBToolbarItem validate]):
2022
2023         * MiniBrowser/mac/BrowserWindowController.m:
2024         (-[BrowserWindowController validateUserInterfaceItem:]):
2025
2026         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2027         * MiniBrowser/mac/BrowserWindow.xib:
2028
2029 2010-07-15  Victor Wang  <victorw@chromium.org>
2030
2031         Unreviewed, add victorw irc nickname to committer list.
2032
2033         * Scripts/webkitpy/common/config/committers.py:
2034
2035 2010-07-15  Adam Roben  <aroben@apple.com>
2036
2037         Make killing Apache more reliable (on both Mac and Windows)
2038
2039         We previously had two ways of determining whether we had succeeded in
2040         killing Apache:
2041           1) checking the return value of kill(0, $apachePID)
2042           2) checking whether Apache's PID file still exists
2043
2044         On Cygwin, Apache doesn't always delete its PID file when it exits,
2045         making (2) unreliable. We unfortunately misdiagnosed this as an
2046         impotency of Perl's kill function, which led to r63177 and r63355.
2047
2048         Now that we know that the real problem is that Apache doesn't always
2049         delete its PID file on Windows, we can make a much better fix: always
2050         use method (1) to determine whether we've killed Apache.
2051
2052         Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
2053         leading to regression test failures (and general annoyance).
2054
2055         Reviewed by Anders Carlsson.
2056
2057         * Scripts/webkitperl/httpd.pm:
2058         (openHTTPD): Moved killing code from here to killHTTPD. Added a call
2059         to delete the PID file in case Apache doesn't do this itself when
2060         killed. Our later logic relies on the PID file being deleted after
2061         this point.
2062         (closeHTTPD): Removed killing logic and changed to just call killHTTPD
2063         instead. killHTTPD's logic is a bit different from the logic we had
2064         here, for the reasons stated above.
2065         (killHTTPD): Added. Code came from openHTTPD.
2066         (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
2067         On Mac, don't try to kill Apache when we receive a signal, as Apache
2068         will already have been killed by this point (though for some reason
2069         this isn't detected by our killing logic in killHTTPD). On Cygwin, we
2070         still need to kill Apache manually.
2071
2072 2010-07-15  Sam Weinig  <sam@webkit.org>
2073
2074         Reviewed by Anders Carlsson.
2075
2076         Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
2077         Update MiniBrowser for WKFrameNavigationType 
2078
2079         * MiniBrowser/mac/BrowserWindowController.m:
2080         (_decidePolicyForNavigationAction):
2081         (_decidePolicyForNewWindowAction):
2082
2083 2010-07-15  Stephanie Lewis  <slewis@apple.com>
2084
2085         Reviewed by Geoff Garen.
2086
2087         http://bugs.webkit.org/show_bug.cgi?id=42406
2088         Make SunSpider work better with roots.
2089
2090         * Scripts/sunspider-compare-results: fix argument bug
2091         * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
2092
2093 2010-07-15  Brady Eidson  <beidson@apple.com>
2094
2095         Reviewed by Sam Weinig.
2096
2097         Hook up back/forward in MiniBrowser
2098         https://bugs.webkit.org/show_bug.cgi?id=42397
2099
2100         * MiniBrowser/mac/BrowserWindow.xib:
2101         * MiniBrowser/mac/BrowserWindowController.h:
2102         * MiniBrowser/mac/BrowserWindowController.m:
2103         (-[BrowserWindowController goBack:]):
2104         (-[BrowserWindowController goForward:]):
2105
2106 2010-07-15  Daniel Bates  <dbates@rim.com>
2107
2108         Reviewed by Darin Adler.
2109
2110         [Mac] Implement LayoutTestController::markerTextForListItem()
2111         https://bugs.webkit.org/show_bug.cgi?id=37929
2112
2113         Implements DRT support for markerTextForListItem in the Mac port.
2114
2115         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2116         (LayoutTestController::markerTextForListItem): Implemented.
2117
2118 2010-07-15  Adam Barth  <abarth@webkit.org>
2119
2120         Unreviewed.
2121
2122         Update the port names to be more specific.  Before this patch,
2123         port-specific results for Mac would end up in the wrong place.
2124
2125         * Scripts/webkitpy/tool/commands/rebaseline.py:
2126         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2127
2128 2010-07-14  Eric Seidel  <eric@webkit.org>
2129
2130         Reviewed by Adam Barth.
2131
2132         WebKit needs a rebaselining tool (finally)
2133         https://bugs.webkit.org/show_bug.cgi?id=42339
2134
2135         This is a very basic rebaselining tool.  It's not
2136         quite as fancy as chromium's as it will only handle
2137         updating failing results.  It cannot yet handle adding new
2138         results, or updating results where the results should not
2139         replace existing results.
2140
2141         * Scripts/webkitpy/layout_tests/port/base.py:
2142         * Scripts/webkitpy/tool/commands/__init__.py:
2143         * Scripts/webkitpy/tool/commands/queries.py:
2144         * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
2145         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
2146
2147 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2148
2149         Unreviewed, rolling out r63352.
2150         http://trac.webkit.org/changeset/63352
2151         https://bugs.webkit.org/show_bug.cgi?id=42341
2152
2153         Broke plugin-initiate-popup-window.html and plugin-javascript-
2154         access.html on snow leopard (Requested by abarth on #webkit).
2155
2156         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2157         (pluginAllocate):
2158         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2159         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2160         (NPP_New):
2161         (handleEventCarbon):
2162         (handleEventCocoa):
2163
2164 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
2165
2166         Reviewed by Mark Rowe.
2167
2168         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
2169
2170         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2171
2172 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2173
2174         Unreviewed, rolling out r63346.
2175         http://trac.webkit.org/changeset/63346
2176         https://bugs.webkit.org/show_bug.cgi?id=42295
2177
2178         Broke lots of tests, some of which probably just need new
2179         results (Requested by aroben on #webkit).
2180
2181         * DumpRenderTree/win/DumpRenderTree.cpp:
2182         (urlSuitableForTestResult):
2183
2184 2010-07-14  Adam Roben  <aroben@apple.com>
2185
2186         Speed up killing of Apache on Windows
2187
2188         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
2189         run-webkit-tests) takes a long time on Windows
2190
2191         Reviewed by Darin Adler and Jon Honeycutt.
2192
2193         * Scripts/webkitperl/httpd.pm:
2194         (closeHTTPD): Use taskkill to kill Apache and its child processes.
2195         Perl's kill seems ineffectual. We were already using taskkill, but
2196         only after trying kill 20 times. Since kill never works, let's just
2197         skip it entirely.
2198
2199 2010-07-14  Johnny Ding  <jnd@chromium.org>
2200
2201         Reviewed by Adam Barth.
2202
2203         https://bugs.webkit.org/show_bug.cgi?id=41292
2204         Add a new parameter to the test plugin to allow to specify a script and a
2205         mouse/keyboard event. The specified script will be evaluated in the browser
2206         when the specified event is received by the plugin.
2207
2208         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2209         (pluginAllocate):
2210         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2211         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2212         (NPP_New):
2213         (handleEventCarbon):
2214         (handleEventCocoa):
2215
2216 2010-07-14  Adam Roben  <aroben@apple.com>
2217
2218         Make urlSuitableForTestResult work for http: URLs, too
2219
2220         Fixes <http://webkit.org/b/42276>
2221         http/tests/loading/preload-slow-loading.php and
2222         http/tests/mime/uppercase-mime-type.html fail on Windows.
2223
2224         Reviewed by Darin Adler.
2225
2226         * DumpRenderTree/win/DumpRenderTree.cpp:
2227         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
2228         We want this function to work for those URLs, too!
2229
2230 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
2231
2232         Reviewed by Oliver Hunt.
2233
2234         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
2235         https://bugs.webkit.org/show_bug.cgi?id=42227
2236
2237         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2238         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
2239         members.
2240         (WTR::LayoutTestController::display): Dummy method.
2241         (WTR::displayCallback): Call the dummy.
2242         (WTR::repaintSweepHorizontallyCallback): ditto
2243         (WTR::testRepaintCallback): ditto
2244         (WTR::LayoutTestController::staticFunctions): Expose new methods.
2245         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2246         (WTR::LayoutTestController::setTestRepaint): Set the flag (which currently does
2247         nothing).
2248         (WTR::LayoutTestController::setTestRepaintSweepHorizontally): ditto
2249
2250 2010-07-13  Andreas Kling  <andreas.kling@nokia.com>
2251
2252         Unreviewed. Adding myself as committer.
2253
2254         * Scripts/webkitpy/common/config/committers.py:
2255
2256 2010-07-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2257
2258         Reviewed by Darin Adler.
2259
2260         Prevent assertion/duplicate loads for non-deferred subtitute-data loads
2261
2262         https://bugs.webkit.org/show_bug.cgi?id=30879
2263
2264         MainResourceLoader uses the member m_initialRequest to store requests for future
2265         deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
2266         have to clear this request so that subsequent entries into the loader will not
2267         start yet another load.
2268
2269         This can happen as a result of a PageGroupLoadDeferrer going out of scope when
2270         returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
2271         but only in the case of using both substitute-data and non-deferred main resource
2272         load together. That's why two new DRT functions were added:
2273
2274          * queueLoadHTMLString()
2275          * setDeferMainResourceLoad()
2276
2277         The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
2278         and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
2279         added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
2280
2281         * DumpRenderTree/LayoutTestController.cpp:
2282         (LayoutTestController::LayoutTestController):
2283         (queueLoadHTMLStringCallback):
2284         (setDeferMainResourceDataLoadCallback):
2285         (LayoutTestController::staticFunctions):
2286         (LayoutTestController::queueLoadHTMLString):
2287         * DumpRenderTree/LayoutTestController.h:
2288         (LayoutTestController::deferMainResourceDataLoad):
2289         (LayoutTestController::setDeferMainResourceDataLoad):
2290         * DumpRenderTree/WorkQueueItem.h:
2291         (LoadHTMLStringItem::LoadHTMLStringItem):
2292         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2293         (LoadHTMLStringItem::invoke):
2294         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2295         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2296         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2297         (LoadHTMLStringItem::invoke):
2298         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2299         (LayoutTestController::reset):
2300         (LayoutTestController::setDeferMainResourceDataLoad):
2301         (LayoutTestController::queueLoadHTMLString):
2302         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2303         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
2304         (LoadHTMLStringItem::invoke):
2305         * DumpRenderTree/qt/WorkQueueItemQt.h:
2306         (LoadHTMLStringItem::LoadHTMLStringItem):
2307         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2308         (ResourceLoadDelegate::willSendRequest):
2309         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2310         (LoadHTMLStringItem::invoke):
2311         * DumpRenderTree/wx/WorkQueueItemWx.cpp:
2312         (LoadHTMLStringItem::invoke):
2313
2314 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
2315
2316         Reviewed by Nikolas Zimmermann.
2317
2318         Activate test fonts for layout tests in WebKitTestRunner (on Mac)
2319         https://bugs.webkit.org/show_bug.cgi?id=42153
2320
2321         * WebKitTestRunner/InjectedBundle/ActivateFonts.h: Added.
2322         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2323         (WTR::InjectedBundle::initialize): Activate fonts on startup.
2324         * WebKitTestRunner/InjectedBundle/mac: Added.
2325         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: Added.
2326         (WTR::activateFonts): Activate our fonts.
2327         * WebKitTestRunner/InjectedBundle/win: Added.
2328         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Added.
2329         (WTR::activateFonts): Dummy version.
2330         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Copy fonts to bundle;
2331         add more files.
2332         * WebKitTestRunner/fonts: Added.
2333         * WebKitTestRunner/fonts/AHEM____.TTF: Added.
2334         * WebKitTestRunner/fonts/ColorBits-A.png: Added.
2335         * WebKitTestRunner/fonts/ColorBits.ttf: Added.
2336         * WebKitTestRunner/fonts/WebKit Layout Tests 2.ttf: Added.
2337         * WebKitTestRunner/fonts/WebKit Layout Tests.ttf: Added.
2338         * WebKitTestRunner/fonts/WebKitWeightWatcher100.ttf: Added.
2339         * WebKitTestRunner/fonts/WebKitWeightWatcher200.ttf: Added.
2340         * WebKitTestRunner/fonts/WebKitWeightWatcher300.ttf: Added.
2341         * WebKitTestRunner/fonts/WebKitWeightWatcher400.ttf: Added.
2342         * WebKitTestRunner/fonts/WebKitWeightWatcher500.ttf: Added.
2343         * WebKitTestRunner/fonts/WebKitWeightWatcher600.ttf: Added.
2344         * WebKitTestRunner/fonts/WebKitWeightWatcher700.ttf: Added.
2345         * WebKitTestRunner/fonts/WebKitWeightWatcher800.ttf: Added.
2346         * WebKitTestRunner/fonts/WebKitWeightWatcher900.ttf: Added.
2347
2348 2010-07-13  Dumitru Daniliuc  <dumi@chromium.org>
2349
2350         Reviewed by Eric Seidel.
2351
2352         Remove check-header-includes, as it didn't turn out to be very useful.
2353         https://bugs.webkit.org/show_bug.cgi?id=41970
2354
2355         * Scripts/check-header-includes: Removed.
2356
2357 2010-07-12  Steve Falkenburg  <sfalken@apple.com>
2358
2359         Reviewed by Maciej Stachowiak.
2360
2361         Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
2362         https://bugs.webkit.org/show_bug.cgi?id=40922
2363         
2364         Always build WebKit2 on Windows. Necessary since our WebKit build on
2365         Windows is packaged into a DLL with WebKit2.
2366
2367         * Scripts/build-webkit: Always build WebKit2 on Windows.
2368
2369 2010-07-12  Brian Weinstein  <bweinstein@apple.com>
2370
2371         Reviewed by Steve Falkenburg.
2372
2373         One http test timing out on Windows can cause all future tests to time out
2374         https://bugs.webkit.org/show_bug.cgi?id=42146
2375         
2376         There have been multiple times on the Windows bots where one http test timing out causes all future
2377         http tests to time out. This is because the httpd process becomes unresponsive. When an http test
2378         times out, we should restart httpd on Cygwin to prevent this.
2379
2380         * Scripts/old-run-webkit-tests: If an http test timed out on Cygwin, close httpd and restart it.
2381         * Scripts/webkitperl/httpd.pm: Add additional logic to closeHTTPD to teach it about taskkill if
2382             using kill fails.
2383
2384 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
2385
2386         Reviewed by Dan Bernstein.
2387
2388         Remove use of auto_ptr in WebKitTestRunner
2389         https://bugs.webkit.org/show_bug.cgi?id=42134
2390         
2391         Replaced auto_ptr with PassOwnPtr / OwnPtr.
2392
2393         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2394         (WTR::WKStringToUTF8):
2395         (WTR::InjectedBundlePage::dump):
2396         (WTR::InjectedBundlePage::addMessageToConsole):
2397         * WebKitTestRunner/TestInvocation.cpp:
2398         (WTR::WKStringToUTF8):
2399         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
2400
2401 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
2402
2403         Reviewed by Sam Weinig.
2404
2405         Need support for a WebKit2-specific Skipped list (and initially add accessibility tests to it)
2406         https://bugs.webkit.org/show_bug.cgi?id=42132
2407
2408         * Scripts/old-run-webkit-tests: In --webkit-test-runner mode, add mac-wk2 to list of
2409         platform directories.
2410
2411 2010-07-12  Maciej Stachowiak  <mjs@apple.com>
2412
2413         Reviewed by Anders Carlsson.
2414
2415         Make WebKitTestRunner resize the view specially for the W3C SVG tests.
2416         https://bugs.webkit.org/show_bug.cgi?id=42126
2417
2418         * WebKitTestRunner/PlatformWebView.h:
2419         * WebKitTestRunner/TestInvocation.cpp:
2420         (WTR::TestInvocation::TestInvocation): Store the path as a C
2421         string for later use.
2422         (WTR::TestInvocation::~TestInvocation):
2423         (WTR::sizeWebViewForCurrentTest): Resize the WebView to the proper
2424         size, depending on whether this is a W3C SVG test.
2425         (WTR::TestInvocation::invoke): Call the size function.
2426         * WebKitTestRunner/TestInvocation.h:
2427         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2428         (WTR::PlatformWebView::resizeTo): Implement.
2429         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2430         (WTR::PlatformWebView::resizeTo): Placeholder.
2431
2432 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
2433
2434         Reviewed by Xan Lopez.
2435
2436         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
2437         https://bugs.webkit.org/show_bug.cgi?id=38648
2438
2439         Add the GTK_MODULES envvar (set to "gail") to the clean
2440         environment when running DRT for the Gtk+ port
2441
2442         * Scripts/old-run-webkit-tests:
2443
2444 2010-07-12  Martin Robinson  <mrobinson@igalia.com>
2445
2446         Reviewed by Dirk Schulze.
2447
2448         [GTK] Support pixel tests
2449         https://bugs.webkit.org/show_bug.cgi?id=31518
2450
2451         Finish support for pixel tests on GTK+.
2452
2453         * DumpRenderTree/PixelDumpSupport.cpp: Remove unecessary RetainPtr include (only
2454         works on CoreFoundation systems) and add missing cstdio include.
2455         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Switch to using the MD5 support found
2456         in JSC library. MD5.cpp and MD5.h are only available for the Windows build.
2457         (computeMD5HashStringForBitmapContext): The number of bytes per row should be the row stride
2458         of the image, not the row stride multiplied by the width. Use JSC MD5 implementation to calculate
2459         the MD5 hash here. According to glibc manpages, using snprintf to build a string in unsupported
2460         by the ANSI standard and this fails on Linux, so unroll the loop here.
2461         * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Correct some constructor misbehavior.
2462         (BitmapContext::BitmapContext): There is no reason to check the value of the
2463         m_context member in the constructor and it certainly should not be freed. Instead
2464         just initialize it with the incoming value.
2465         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the order of includes.
2466         (dump): Actually call dumpWebViewAsPixelsAndCompareWithExpected when it is time to
2467         dump pixels.
2468         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Added.
2469         (createBitmapContextFromWebView):
2470         * GNUmakefile.am: Add new files to the build.
2471
2472 2010-07-12  Adam Barth  <abarth@webkit.org>
2473
2474         Unreviewed.
2475
2476         Remove stray "raise e" that got included in a previous patch.  This
2477         caused the EWS bots to turn red instead of purple when a patch failed
2478         to apply.
2479
2480         * Scripts/webkitpy/tool/commands/stepsequence.py:
2481
2482 2010-07-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2483
2484         Unreviewed, rolling out r63101.
2485         http://trac.webkit.org/changeset/63101
2486         https://bugs.webkit.org/show_bug.cgi?id=42103
2487
2488         Broke one API test (Requested by xan_ on #webkit).
2489
2490         * Scripts/old-run-webkit-tests:
2491
2492 2010-07-12  Alexey Proskuryakov  <ap@apple.com>
2493
2494         Reviewed by Adam Roben.
2495
2496         https://bugs.webkit.org/show_bug.cgi?id=13075
2497         XMLHttpRequest with failed authentication should set status to 401
2498
2499         https://bugs.webkit.org/show_bug.cgi?id=6871
2500         <rdar://problem/3363403> 401 error page is never shown
2501
2502         Fix crashes in Windows DumpRenderTree.
2503
2504         * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2505         If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
2506         again on a destroyed sender.
2507
2508 2010-07-12  Adam Roben  <aroben@apple.com>
2509
2510         Windows failure-to-launch fix
2511
2512         * DumpRenderTree/win/DumpRenderTree.vcproj: Copy CoreVideo.dll and
2513         CoreVideo.pdb into WebKitOutputDir in the post-build event, too, like
2514         we already do for CoreFoundation, CFNetwork, etc.
2515
2516 2010-07-12  Mario Sanchez Prada  <msanchez@igalia.com>
2517
2518         Reviewed by Xan Lopez.
2519
2520         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
2521         https://bugs.webkit.org/show_bug.cgi?id=38648
2522
2523         Add the GTK_MODULES envvar (set to "gail") to the clean
2524         environment when running DRT for the Gtk+ port
2525
2526         * Scripts/old-run-webkit-tests:
2527
2528 2010-07-09  Alexey Proskuryakov  <ap@apple.com>
2529
2530         Reviewed by Darin Adler.
2531
2532         https://bugs.webkit.org/show_bug.cgi?id=13075
2533         XMLHttpRequest with failed authentication should set status to 401
2534
2535         https://bugs.webkit.org/show_bug.cgi?id=6871
2536         <rdar://problem/3363403> 401 error page is never shown
2537
2538         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2539         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2540         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2541         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2542         Do respond even if handlesAuthenticationChallenges() is false. Pretend that the user pressed
2543         the Cancel button.
2544
2545 2010-07-12  Andreas Kling  <andreas.kling@nokia.com>
2546
2547         Reviewed by Tor Arne Vestbø.
2548
2549         [Qt] Add location bar (Ctrl+L) shortcut in QtTestBrowser
2550         https://bugs.webkit.org/show_bug.cgi?id=42082
2551
2552         * QtTestBrowser/main.cpp:
2553         (LauncherWindow::createChrome):
2554         * QtTestBrowser/mainwindow.cpp:
2555         (MainWindow::openLocation):
2556         * QtTestBrowser/mainwindow.h:
2557
2558 2010-07-12  Adam Roben  <aroben@apple.com>
2559
2560         Make the Python autoinstaller not use a dead SourceForge server
2561
2562         Fixes <http://webkit.org/b/42080> webkit-patch is broken due to
2563         offline SourceForge server
2564
2565         Reviewed by Anders Carlsson.
2566
2567         * Scripts/webkitpy/thirdparty/__init__.py: Use
2568         surfnet.dl.sourceforge.net instead of hivelocity.dl.sourceforge.net,
2569         which seems to be down.
2570
2571 2010-07-12  Adam Roben  <aroben@apple.com>
2572
2573         Make run-webkit-tests print how many tests timed out when exiting
2574         early
2575
2576         The number of timed-out tests is taken into account when deciding
2577         whether to exit early. Leaving it out of the output just makes the
2578         script look buggy (because it might say something like "Exiting early
2579         after 0 crashes.").
2580
2581         Fixes <http://webkit.org/b/42077> run-webkit-tests prints confusing
2582         messages when exiting early due to crashes and time-outs
2583
2584         Reviewed by Anders Carlsson.
2585
2586         * Scripts/old-run-webkit-tests:
2587         (stopRunningTestsEarlyIfNeeded): When stopping, print the number of
2588         timed-out tests, too.
2589
2590 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
2591
2592         Reviewed by Dan Bernstein.
2593
2594         Implement animation-related methods for WebKitTestRunner
2595         https://bugs.webkit.org/show_bug.cgi?id=42053
2596         
2597         Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
2598         animation tests were hanging otherwise.
2599
2600         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2601         (WTR::LayoutTestController::numberOfActiveAnimations):
2602         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2603         (WTR::numberOfActiveAnimationsCallback):
2604         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
2605         (WTR::LayoutTestController::staticFunctions):
2606         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2607
2608 2010-07-11  Daniel Bates  <dbates@rim.com>
2609
2610         Reviewed by David Kilzer.
2611
2612         Enable executable support for svn-apply and svn-unapply
2613         https://bugs.webkit.org/show_bug.cgi?id=39409
2614
2615         Connect up the Git and SVN executable bit support in parseDiff() so that
2616         executable bit changes are propagated via the returned diff hash to the
2617         patch function in svn-apply and svn-unapply.
2618
2619         * Scripts/VCSUtils.pm:
2620           - Modified parseDiff() to call parseSvnDiffProperties when
2621             it finds the start of an SVN property change diff.
2622           - Removed FIXME comment above parseSvnDiffProperties() since
2623             it is now being used by parseDiff().
2624           - Export method scmToggleExecutableBit() now that we added the
2625             executableBitDelta hash key. (This should have been exported
2626             when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
2627         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
2628           - Updated results for:
2629             "rename (with executable bit change)"
2630               - Test value of executableBitDelta (now that we have support).
2631             "SVN: binary file (isBinary true)"
2632               - Remove the property change diff from svnConvertedText. We plan
2633                 to remove svnConvertedText in the future. So, we decided
2634                 against adding such support to any new code, such as the
2635                 property parsing routines. Therefore, we do not keep SVN
2636                 converted text for property change diffs.
2637           - Added unit tests:
2638             "SVN: file change diff with property change diff"
2639             "SVN: file change diff, followed by property change diff on different file"
2640             "SVN: property diff, followed by file change diff"
2641             "SVN: copied file with property change"
2642             "SVN: two consecutive property diffs"
2643             "SVN: binary file with executable bit change"
2644             "SVN: binary file followed by property change on different file"
2645             "SVN: binary file followed by file change on different file"
2646             "SVN: file change diff with property change, followed by property change diff"
2647             "SVN: file change diff with property change, followed by file change diff"
2648
2649 2010-07-11  Maciej Stachowiak  <mjs@apple.com>
2650
2651         Reviewed by Dan Bernstein.
2652
2653         Implement waitUntilDone and notifyDone for WebKitTestRunner
2654         https://bugs.webkit.org/show_bug.cgi?id=42049
2655
2656         With this fix, most of the DOM tests pass.
2657         
2658         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2659         (WTR::InjectedBundle::didCreatePage): Track the main page. Not
2660         a great way to do it in the future case where we may get multiple
2661         pages - we really need a way to send it over from the ui process.
2662         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2663         (WTR::InjectedBundle::page): A way to get the main page.
2664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2665         (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
2666         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
2667         are loading.
2668         (WTR::InjectedBundlePage::dump): Factor into a method so this can be
2669         called by the layout test controller. Also, cancel any pending watchdogs.
2670         (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
2671         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
2672         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2673         (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
2674         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2675         (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
2676         to false.
2677         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
2678         the watchdog.
2679         (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
2680         (WTR::LayoutTestController::setWaitToDump): Set the flag.
2681         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
2682         where waitUntilDone times out.
2683         (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
2684         (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
2685         (WTR::notifyDoneCallback): JS glue for notifyDone.
2686         (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
2687         to the layoutController.
2688         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2689         (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
2690
2691 2010-07-09  Brian Weinstein  <bweinstein@apple.com>
2692
2693         Rubber-stamped by Dan Bernstein.
2694
2695         Windows testers running Windows 7 were hanging during test_kill_process. Changing the
2696         number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
2697         slow down the tests).
2698
2699         * Scripts/webkitpy/common/system/executive.py:
2700
2701 2010-07-09  Luiz Agostini  <luiz.agostini@openbossa.org>
2702
2703         Reviewed by Kenneth Rohde Christiansen.
2704
2705         [Qt] Mac build fix
2706         https://bugs.webkit.org/show_bug.cgi?id=41967
2707
2708         Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
2709
2710         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2711
2712 2010-07-09  Diego Gonzalez  <diegohcg@webkit.org>
2713
2714         Reviewed by Antonio Gomes.
2715
2716         [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
2717         https://bugs.webkit.org/show_bug.cgi?id=41966
2718
2719         * MiniBrowser/qt/BrowserWindow.cpp:
2720         (BrowserWindow::BrowserWindow):
2721
2722 2010-07-09  Leon Clarke  <leonclarke@google.com>
2723
2724         Reviewed by Adam Barth.
2725
2726         add support for link prefetching
2727         https://bugs.webkit.org/show_bug.cgi?id=3652
2728
2729         * Scripts/build-webkit:
2730
2731 2010-07-09  Ojan Vafai  <ojan@chromium.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         r63004 broke some python tests
2736         https://bugs.webkit.org/show_bug.cgi?id=42007
2737
2738         AbstractStep now checks options.no_squash and options.squash, so
2739         they needed to have real values. Mock would return an object for those,
2740         which would then act as if the values were True.
2741
2742         * Scripts/webkitpy/tool/commands/commandtest.py:
2743         * Scripts/webkitpy/tool/commands/download_unittest.py:
2744         * Scripts/webkitpy/tool/commands/stepsequence.py:
2745         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2746         * Scripts/webkitpy/tool/mocktool.py:
2747         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2748         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2749         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2750         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2751         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2752
2753 2010-07-09  Ojan Vafai  <ojan@chromium.org>
2754
2755         Reviewed by Adam Barth.
2756
2757         --squash should go away and become the default
2758         https://bugs.webkit.org/show_bug.cgi?id=39624
2759
2760         If there are local commits and working copy changes, then prompt the user
2761         whether to continue. Setting git config webkit-patch.commit_should_always_squash
2762         true bypasses the prompt.
2763
2764         --git-commit=HEAD.. operates on working copy changes only.
2765         --git-commit=committish operates on a range of commits as a single commit.
2766             e.g. --git-commit=HEAD only operates on the HEAD commit.
2767             --git-commit=HEAD~4..HEAD~2 will operate on HEAD~3 and HEAD~2 as a single commit.
2768
2769         --no-squash and --squash are left in with descriptive error messages if used.
2770
2771         * Scripts/check-webkit-style:
2772         * Scripts/webkitpy/common/checkout/api.py:
2773         * Scripts/webkitpy/common/checkout/api_unittest.py:
2774         * Scripts/webkitpy/common/checkout/scm.py:
2775         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2776         * Scripts/webkitpy/common/net/rietveld.py:
2777         * Scripts/webkitpy/common/system/user.py:
2778         * Scripts/webkitpy/style/optparser.py:
2779         * Scripts/webkitpy/style_references.py:
2780         * Scripts/webkitpy/tool/commands/download.py:
2781         * Scripts/webkitpy/tool/commands/upload.py:
2782         * Scripts/webkitpy/tool/mocktool.py:
2783         * Scripts/webkitpy/tool/steps/abstractstep.py:
2784         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2785         * Scripts/webkitpy/tool/steps/checkstyle.py:
2786         * Scripts/webkitpy/tool/steps/checkstyle_unittest.py: Removed.
2787         * Scripts/webkitpy/tool/steps/commit.py:
2788         * Scripts/webkitpy/tool/steps/options.py:
2789         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2790         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2791         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2792         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2793
2794 2010-07-09  Mark Rowe  <mrowe@apple.com>
2795
2796         Add two new Windows test build slaves.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/config.json:
2799
2800 2010-07-09  Albert J. Wong  <ajwong@chromium.org>
2801
2802         Reviewed by David Levin.
2803
2804         rebaseline_chromium_webkit_tests missing --use_drt option on linux
2805         https://bugs.webkit.org/show_bug.cgi?id=41985
2806
2807         This adds in the --use_drt option for rebaseline_chromium_webkit_tests
2808         so that it works on linux. This is essentially a "compile-fix" for the
2809         script.
2810
2811         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2812
2813 2010-07-09  Nico Weber  <thakis@chromium.org>
2814
2815         Unreviewed. Adding myself as committer.
2816
2817         * Scripts/webkitpy/common/config/committers.py:
2818
2819 2010-07-09  David Kilzer  <ddkilzer@apple.com>
2820
2821         Revert "<http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git"
2822
2823         This reverts commit r62692.
2824
2825         * Scripts/commit-log-editor:
2826
2827 2010-07-08  Kinuko Yasuda  <kinuko@chromium.org>
2828
2829         Reviewed by Ojan Vafai.
2830
2831         cleanup json_results_generator dependencies so that non-layout-tests can also use it safely
2832         https://bugs.webkit.org/show_bug.cgi?id=38693
2833
2834         Introduced a new base class JSONResultsGeneratorBase that doesn't
2835         have any dependency on layout_tests packages.
2836         Turned JSONResultsGenerator into a wrapper class of the base class
2837         so that the old code can work with it during the cleanup.
2838
2839         Added json_results_generator_unittest.py.
2840
2841         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2842         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2843         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: Added
2844
2845 2010-07-09  Abhishek Arya  <inferno@chromium.org>
2846
2847         Unreviewed.
2848
2849         Marking myself as a committer.
2850
2851         * Scripts/webkitpy/common/config/committers.py:
2852
2853 2010-07-09  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2854
2855         Reviewed by Antti Koivisto.
2856
2857         Implement MiniBrowser for Qt.
2858         https://bugs.webkit.org/show_bug.cgi?id=40233
2859
2860         * MiniBrowser/qt/BrowserWindow.cpp: Added.
2861         (createNewPage):
2862         (BrowserView::BrowserView):
2863         (BrowserView::resizeEvent):
2864         (BrowserView::load):
2865         (BrowserView::view):
2866         (BrowserWindow::BrowserWindow):
2867         (BrowserWindow::load):
2868         (BrowserWindow::changeLocation):
2869         (BrowserWindow::~BrowserWindow):
2870         * MiniBrowser/qt/BrowserWindow.h: Added.
2871         (BrowserView::~BrowserView):
2872         * MiniBrowser/qt/MiniBrowser.pro: Added.
2873         * MiniBrowser/qt/main.cpp: Added.
2874         (main):
2875
2876 2010-07-09  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2877
2878         Reviewed by Simon Hausmann.
2879
2880         Introduce the Qt autotest launcher.
2881
2882         Qt autotests should be executed more frequently, ideally by the Qt
2883         build bot. This is the first step to provide the tests more accessible.
2884
2885         [Qt] It should be easier to run all Qt's autotests.
2886         https://bugs.webkit.org/show_bug.cgi?id=31625
2887
2888         * Scripts/run-qtwebkit-tests: Added.
2889
2890 2010-07-09  Adam Barth  <abarth@webkit.org>
2891
2892         Reviewed by Eric Seidel.
2893
2894         commit-queue should merge to TOT when checkout needs update
2895         https://bugs.webkit.org/show_bug.cgi?id=41944
2896
2897         There are a bunch of different designs that are possible here.  This
2898         one merges to top of tree by cleaning out the working copy and
2899         re-applying the patch.  Once you decide to merge that way, you need to
2900         decide who's going to retry.  In this patch, we retry in the child
2901         process instead of plumbing the failure reason to the master process.
2902
2903         This patch is difficult to test end-to-end, but hopefully it will work.
2904         :)
2905
2906         * Scripts/webkitpy/tool/commands/queues.py:
2907         * Scripts/webkitpy/tool/commands/stepsequence.py:
2908         * Scripts/webkitpy/tool/multicommandtool.py:
2909         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2910
2911 2010-07-09  Dumitru Daniliuc  <dumi@chromium.org>
2912
2913         Reviewed by Darin Adler.
2914
2915         Add a script to check for unnecessary includes in header files.
2916         https://bugs.webkit.org/show_bug.cgi?id=41894
2917
2918         * Scripts/check-header-includes: Added.
2919
2920 2010-07-09  Adam Barth  <abarth@webkit.org>
2921
2922         Reviewed by Eric Seidel.
2923
2924         Add --html5-treebuilder option to run-webkit-tests
2925         https://bugs.webkit.org/show_bug.cgi?id=41922
2926
2927         We're down to one or two regressions in the HTML5lib test suite.  It's
2928         getting to be time to look at fixing LayoutTests.
2929
2930         * Scripts/old-run-webkit-tests:
2931
2932 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2933
2934         Fix Tiger plugin test failures; the #ifdefs were incorrect, resulting
2935         in the drawing model never getting set on Tiger.
2936
2937         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2938         (NPP_New):
2939
2940 2010-07-08  Aaron Boodman  <aa@chromium.org>
2941
2942         Reviewed by Timothy Hatcher.
2943
2944         Add the ability for user scripts and user styles to affect just the top frame.
2945
2946         https://bugs.webkit.org/show_bug.cgi?id=41529
2947
2948         * DumpRenderTree/LayoutTestController.h: Added new allFrames param.
2949         * DumpRenderTree/LayoutTestController.cpp: Ditto.
2950         (addUserScriptCallback):
2951         (addUserStyleSheetCallback):
2952         * DumpRenderTree/chromium/LayoutTestController.cpp: Ditto.
2953         (LayoutTestController::addUserScript):
2954         (LayoutTestController::addUserStyleSheet):
2955         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
2956         (LayoutTestController::addUserScript):
2957         (LayoutTestController::addUserStyleSheet):
2958         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
2959         (LayoutTestController::addUserScript):
2960         (LayoutTestController::addUserStyleSheet):
2961         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Ditto.
2962         (LayoutTestController::addUserScript):
2963         (LayoutTestController::addUserStyleSheet):
2964         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Ditto.
2965         (LayoutTestController::addUserScript):
2966         (LayoutTestController::addUserStyleSheet):
2967
2968 2010-07-08  Adele Peterson  <adele@apple.com>
2969
2970         Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
2971
2972         Test infrastructure for https://bugs.webkit.org/show_bug.cgi?id=41721
2973         <rdar://problem/8158561> Missing plug-in indicator should have a pressed state
2974
2975         Log when the missing plugin button is pressed.
2976
2977         * DumpRenderTree/mac/UIDelegate.mm:
2978         (-[UIDelegate webView:didPressMissingPluginButton:]):
2979         * DumpRenderTree/win/UIDelegate.cpp:
2980         (UIDelegate::QueryInterface):
2981         (UIDelegate::createWebViewWithRequest):
2982         (UIDelegate::drawBackground):
2983         (UIDelegate::decidePolicyForGeolocationRequest):
2984         (UIDelegate::didPressMissingPluginButton):
2985         * DumpRenderTree/win/UIDelegate.h:
2986
2987 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2988
2989         Fix the Tiger build.
2990
2991         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2992         (NPP_New):
2993
2994 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
2995
2996         Fix windows build.
2997
2998         #ifdef code for Mac.
2999
3000         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3001         (NPP_New):
3002
3003 2010-07-08  Simon Fraser  <simon.fraser@apple.com>
3004
3005         Reviewed by Anders Carlsson.
3006
3007         Allow the TestPlugin to use Core Animation rendering for testing
3008         https://bugs.webkit.org/show_bug.cgi?id=41872
3009         
3010         Add the ability for the TestPlugin to use the CoreAnimation rendering model
3011         when available, based on the "drawingmodel" attribute of the embed tag:
3012             drawingmodel="coreanimation"
3013
3014         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add PluginObjectMac.mm
3015         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Add some macros so we can detect
3016         when building on Tiger. Add a void* coreAnimationLayer member.
3017         
3018         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm: Added.
3019         (createCoreAnimationLayer): Obj-C method to create the CALayer.
3020         
3021         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3022         (NPP_New): Look for the drawingmodel attribute to decide which drawing
3023         model to use.
3024         (NPP_Destroy): Release the CALayer if we have one.
3025         (NPP_GetValue): Return the retained CALayer.
3026
3027 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
3028
3029         Reviewed by Xan Lopez.
3030
3031         [GTK] Support pixel tests
3032         https://bugs.webkit.org/show_bug.cgi?id=31518
3033
3034         Convert this file from CRLF to NL line endings. It will soon
3035         be used on more than just the WinCairo platform.
3036
3037         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3038         (writeFunction):
3039         (printPNG):
3040         (computeMD5HashStringForBitmapContext):
3041         (dumpBitmap):
3042
3043 2010-07-08  Steve Falkenburg  <sfalken@apple.com>
3044
3045         Reviewed by Darin Adler.
3046
3047         Enable Data Execution Prevention for our test harnesses on Windows
3048         https://bugs.webkit.org/show_bug.cgi?id=41882
3049
3050         * DumpRenderTree/win/DumpRenderTree.vcproj:
3051         * DumpRenderTree/win/ImageDiff.vcproj:
3052         * WebKitAPITest/WebKitAPITest.vcproj:
3053         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3054
3055 2010-07-07  Robert Hogan  <robert@webkit.org>
3056
3057         Reviewed by Kenneth Rohde Christiansen.
3058
3059         [Qt] Add DRT support for pageProperty etc.
3060
3061         https://bugs.webkit.org/show_bug.cgi?id=41584
3062
3063         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3064         (LayoutTestController::isPageBoxVisible):
3065         (LayoutTestController::pageSizeAndMarginsInPixels):
3066         (LayoutTestController::pageProperty):
3067         (LayoutTestController::addUserStyleSheet):
3068         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3069
3070 2010-07-08  Martin Robinson  <mrobinson@igalia.com>
3071
3072         Reviewed by Xan Lopez.
3073
3074         Remove a warnings from the ImageDiff build by using the proper
3075         printf format string for the gsize data type.
3076
3077         * DumpRenderTree/gtk/ImageDiff.cpp:
3078         (printImage): Use the proper printf format string for the gsize data type.
3079
3080 2010-07-08  Alice Liu  <alice.liu@apple.com>
3081
3082         Reviewed by Sam Weinig.
3083
3084         https://bugs.webkit.org/show_bug.cgi?id=41653
3085         Add new WebKitTestRunner project for Windows
3086
3087         * WebKitTestRunner/WebKitTestRunnerPrefix.h: 
3088         Similar to how it's done in DumpRenderTree, define max and min early
3089         on so that they don't get replaced by a macro requiring 2 arguments.
3090
3091         * WebKitTestRunner/win: Added.
3092         * WebKitTestRunner/win/WebKitTestRunner.sln: Added.
3093         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added.
3094         * WebKitTestRunner/win/main.cpp: Added.
3095         (main): Implemented
3096
3097         Added these files with stubbed out functions:
3098         * WebKitTestRunner/win/PlatformWebViewWin.cpp: Added.
3099         (WTR::PlatformWebView::PlatformWebView):
3100         (WTR::PlatformWebView::~PlatformWebView):
3101         (WTR::PlatformWebView::page):
3102         * WebKitTestRunner/win/TestControllerWin.cpp: Added.
3103         (WTR::TestController::initializeInjectedBundlePath):
3104         * WebKitTestRunner/win/TestInvocationWin.cpp: Added.
3105         (WTR::TestInvocation::runUntil):
3106
3107 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
3108
3109         Reviewed by Gustavo Noronha Silva.
3110
3111         [GTK] Implement ImageDiff and add it to the build system
3112         https://bugs.webkit.org/show_bug.cgi?id=41779
3113
3114         Add the initial implementation of the ImageDiff tool for the GTK+
3115         port. This is an essential tool for doing pixel tests. The implementation
3116         is based on the Mac and Chromium ports.
3117
3118         * DumpRenderTree/gtk/ImageDiff.cpp: Added.
3119         (readPixbufFromStdin): Added.
3120         (differenceImageFromDifferenceBuffer): Ditto.
3121         (calculateDifference): Ditto.
3122         (printImage): Ditto.
3123         (printImageDifferences): Ditto.
3124         (main): Ditto.
3125         * GNUmakefile.am: Add ImageDiff to the WebKitTools build scripts.
3126
3127 2010-07-08  Jay Civelli  <jcivelli@chromium.org>
3128
3129         Unreviewed. Adding myself as a committer.
3130
3131         * Scripts/webkitpy/common/config/committers.py:
3132
3133 2010-07-08  Adam Roben  <aroben@apple.com>
3134
3135         Make Windows stop running tests from platform/mac
3136
3137         r62742 made a change (at my suggestion!) that caused us to start
3138         looking for tests in platform/mac, rather than just looking for
3139         expected results in platform/mac. This patch just undoes that part of
3140         r62742.
3141
3142         Fixes <http://webkit.org/b/41855> REGRESSION (r62742): Windows runs
3143         tests from platform/mac, but shouldn't
3144
3145         Reviewed by Antti Koivisto and Anders Carlsson.
3146
3147         * Scripts/old-run-webkit-tests:
3148         (top level): Removed "mac-snowleopard" and "mac" from @winPlatforms,
3149         so we won't look in those directories for tests to run.
3150         (expectedDirectoryForTest): Added back code from pre-r62742 to look in
3151         platform/mac-snowleopard and platform/mac for expected results.
3152
3153 2010-07-08  Antonio Gomes  <tonikitoo@webkit.org>
3154
3155         Unreviewed. Adding myself as a reviewer.
3156
3157         * Scripts/webkitpy/common/config/committers.py:
3158
3159 2010-07-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3160
3161         Update my e-mail in committers.py
3162
3163         * Scripts/webkitpy/common/config/committers.py:
3164
3165 2010-07-07  Daniel Bates  <dbates@rim.com>
3166
3167         Reviewed by Dumitru Daniliuc.
3168
3169         VCSUtils.pm complains about uninitialized value $newLine
3170         https://bugs.webkit.org/show_bug.cgi?id=41333
3171
3172         Fixes an issue where VCSUtils::fixChangeLogPatch() may read off the end of
3173         an array when fixing a change log entry that overlaps with an earlier
3174         entry. In particular, when a patch contains a change log entry inserted
3175         earlier in the change log file, but after an entry with the same author
3176         and date.
3177
3178         * Scripts/VCSUtils.pm:
3179             - Added for-loop constraint to fixChangeLogPatch() so that it does not
3180               read off the end of the @overlappingLines array.
3181         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added unit test.
3182
3183 2010-07-07  Anders Carlsson  <andersca@apple.com>
3184
3185         Comment out a part of TestNetscapePlugin that caused tests to fail on Tiger and Leopard.
3186
3187         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3188         (NPP_New):
3189
3190 2010-07-07  Kent Tamura  <tkent@chromium.org>
3191
3192         Reviewed by Adam Barth.
3193
3194         [DRT/Chromium] Support for indeterminate checkbox
3195         https://bugs.webkit.org/show_bug.cgi?id=41747
3196
3197         Import http://src.chromium.org/viewvc/chrome?view=rev&revision=51499
3198
3199         * DumpRenderTree/chromium/WebThemeControlDRT.cpp:
3200         (WebThemeControlDRT::draw):
3201         * DumpRenderTree/chromium/WebThemeControlDRT.h:
3202         (WebThemeControlDRT::):
3203         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
3204         (WebThemeEngineDRT::paintButton):
3205
3206 2010-07-07  Sam Weinig  <sam@webkit.org>
3207
3208         Reviewed by Mark Rowe.
3209
3210         Clean up MiniBrowser Xcode project.
3211
3212         - Use xcconfig files.
3213         - Rename plists to canonical Info.plist
3214         - Remove localizations.
3215
3216         * MiniBrowser/Configurations: Added.
3217         * MiniBrowser/Configurations/Base.xcconfig: Added.
3218         * MiniBrowser/Configurations/DebugRelease.xcconfig: Added.
3219         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Added.
3220         * MiniBrowser/Configurations/WebBundle.xcconfig: Added.
3221         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3222         * MiniBrowser/WebBundle-Info.plist: Removed.
3223         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3224         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
3225         * MiniBrowser/mac/BrowserWindow.xib: Added.
3226         * MiniBrowser/mac/BrowserWindowController.m:
3227         (-[BrowserWindowController initWithPageNamespace:]):
3228         * MiniBrowser/mac/English.lproj: Removed.
3229         * MiniBrowser/mac/English.lproj/BrowserWindow.xib: Removed.
3230         * MiniBrowser/mac/English.lproj/InfoPlist.strings: Removed.
3231         * MiniBrowser/mac/English.lproj/MainMenu.xib: Removed.
3232         * MiniBrowser/mac/Info.plist: Copied from MiniBrowser/mac/MiniBrowser-Info.plist.
3233         * MiniBrowser/mac/MainMenu.xib: Added.
3234         * MiniBrowser/mac/MiniBrowser-Info.plist: Removed.
3235         * MiniBrowser/mac/WebBundle/Info.plist: Copied from MiniBrowser/WebBundle-Info.plist.
3236
3237 2010-07-07  Kent Tamura  <tkent@chromium.org>
3238
3239         Reviewed by Dimitri Glazkov.
3240
3241         [DRT/Chromium] Fix two regressions
3242         https://bugs.webkit.org/show_bug.cgi?id=41745
3243
3244         * DumpRenderTree/chromium/WebViewHost.cpp:
3245         (WebViewHost::paintInvalidatedRegion):
3246          Repaint three times to fix svg/W3C-SVG-1.1/struct-use-01-t.svg
3247          and svg/custom/use-on-g-containing-foreignObject-and-image.svg
3248          though test_shell does it twice. Probably DRT needs it because
3249          DRT delays painting as possible.
3250
3251 2010-07-07  Anders Carlsson  <andersca@apple.com>
3252
3253         Try to fix build.
3254
3255         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3256         (webkit_test_plugin_destroy_stream):
3257
3258 2010-07-07  Anders Carlsson  <andersca@apple.com>
3259
3260         Try to fix the GTK+ and Qt test failures by merging the newly added code from TestNetscapePlugin/main.cpp
3261
3262         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3263         (webkit_test_plugin_new_stream):
3264         (webkit_test_plugin_destroy_stream):
3265         (webkit_test_plugin_write_ready):
3266         (webkit_test_plugin_write):
3267
3268 2010-07-07  Sam Weinig  <sam@webkit.org>
3269
3270         Reviewed by Mark Rowe.
3271
3272         Don't hard code the Mac OS X 10.6 SDK for MiniBrowser. 
3273
3274         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3275
3276 2010-07-07  Anders Carlsson  <andersca@apple.com>
3277
3278         Use the correct XP_MACOSX define instead of XP_MAC. This was causing test failures on some platforms.
3279
3280         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3281         (NPP_New):
3282         (NPP_HandleEvent):
3283
3284 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
3285
3286         Reviewed by Adam Roben.
3287
3288         Need to have a way to specify different results for Windows XP and 7
3289         https://bugs.webkit.org/show_bug.cgi?id=41776
3290         
3291         Add the ability to have platform/win-xp, platform/win-vista, and platform/win-7
3292         subdirectories, so we can have different results for tests on Windows XP, Windows
3293         Vista, and Windows 7.
3294
3295         Windows XP will try the order: win-xp, win-vista, win-7, win, mac-snowleopard, mac.
3296         Windows Vista will try the order: win-vista, win-7, win, mac-snowleopard, mac.
3297         Windows 7 will try the order: win-7, win, mac-snowleopard, mac.
3298
3299         This matches the behavior of the mac.
3300
3301         * Scripts/old-run-webkit-tests: Add multiple platforms for Windows, and if we are on XP
3302             or Vista, try looking in other win-* subdirectories before win.
3303         * Scripts/webkitdirs.pm: Add some helper functions to determine what version of Windows
3304             we are running.
3305
3306 2010-07-07  Kent Tamura  <tkent@chromium.org>
3307
3308         Reviewed by Dimitri Glazkov.
3309
3310         [DRT/Chromium] Remove ASSERT_NOT_REACHED in some functions
3311         https://bugs.webkit.org/show_bug.cgi?id=41753
3312
3313         The original code of the following functions in
3314         test_shell_devtools_client.cc have NOTIMPLEMENTED(), not
3315         ASSERT_NOT_REACHED(). The program shouldn't stop at these
3316         functions.
3317
3318         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3319         (DRTDevToolsClient::activateWindow):
3320         (DRTDevToolsClient::closeWindow):
3321         (DRTDevToolsClient::dockWindow):
3322         (DRTDevToolsClient::undockWindow):
3323
3324 2010-07-07  Anders Carlsson  <andersca@apple.com>
3325
3326         Reviewed by Sam Weinig.
3327
3328         Test that we call NPP_DestroyStream if a plug-in returns -1 from its NPP_Write function
3329         https://bugs.webkit.org/show_bug.cgi?id=41821
3330
3331         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3332         (pluginGetProperty):
3333         (pluginSetProperty):
3334         (pluginAllocate):
3335         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3336         Add and initialize the returnNegativeOneFromWrite property.
3337
3338         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3339         (NPP_NewStream):
3340         Set the stream type to NP_NORMAL so we'll get write callbacks.
3341
3342         (NPP_DestroyStream):
3343         Treat the onstreamdestroy attribute as a function name and not a string.
3344
3345         (NPP_WriteReady):
3346         Have this return a nonzero value.
3347
3348         (NPP_Write):
3349         If returnNegativeOneFromWrite is true return -1.
3350
3351 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
3352
3353         [wx] Build fix for machines with both MSVC 2005 and 2008 installed. Ensures the
3354         latest version is selected by default, and allows the version to be specified.
3355
3356         * wx/build/settings.py:
3357
3358 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
3359
3360         Reviewed by Darin Adler.
3361
3362         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
3363         https://bugs.webkit.org/show_bug.cgi?id=41810
3364
3365         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3366         (AccessibilityUIElement::selectedTextRange):
3367
3368 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
3369
3370         Unreviewed.
3371
3372         Build fix after r62700.
3373
3374         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
3375         source file locations.
3376
3377 2010-07-07  Ojan Vafai  <ojan@chromium.org>
3378
3379         Reviewed by David Levin.
3380
3381         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
3382         https://bugs.webkit.org/show_bug.cgi?id=41814
3383
3384         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3385         * Scripts/old-run-webkit-tests:
3386
3387 2010-07-07  Ojan Vafai  <ojan@chromium.org>
3388
3389         Reviewed by David Levin.
3390
3391         add --exit-after-n-crashes to run-webkit-tests
3392         https://bugs.webkit.org/show_bug.cgi?id=41811
3393
3394         Change the bots at build.webkit.org to use --exit-after-n-crashes
3395         instead of --exit-after-n-failures since we want to be able to have
3396         more than 20 failures on those bots, but more than 20 crashes means
3397         something should be rolled out.
3398
3399         * Scripts/old-run-webkit-tests:
3400         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3401
3402 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
3403
3404         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
3405         TestNetscapePlugin project, because this was removed from the tree.
3406
3407         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3408
3409 2010-07-07  Anders Carlsson  <andersca@apple.com>
3410
3411         Reviewed by Simon Fraser.
3412
3413         Unify Mac and Windows TestNetscapePlugin main.cpp files
3414         https://bugs.webkit.org/show_bug.cgi?id=41798
3415         
3416         * DumpRenderTree/DumpRenderTree.sln:
3417         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3418         (strcasecmp):
3419         (NP_Initialize):
3420         (NP_GetEntryPoints):
3421         (NP_Shutdown):
3422         (NPP_New):
3423         (NPP_Destroy):
3424         (NPP_HandleEvent):
3425         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3426         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
3427
3428 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
3429
3430         [wx] Build fix. pageProperty needs to return a value.
3431
3432         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3433         (LayoutTestController::pageProperty):
3434
3435 2010-07-07  David Kilzer  <ddkilzer@apple.com>
3436
3437         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
3438
3439         Reviewed by Anders Carlsson.
3440
3441         For both svn and git, commit-log-editor is invoked from the root
3442         of the working directory.  Unlike svn, git returns a list of
3443         changed files that are relative to the directory where the
3444         command was invoked.  This caused the ChangeLog file in the root
3445         directory to be read instead of the ChangeLog in the current
3446         directory.
3447
3448         The fix is to use $ENV{PWD} as the base directory when fixing
3449         the path to the ChangeLog files.  With svn, this has no net
3450         effect since $ENV{PWD} is the root of the working directory and
3451         the ChangeLog paths are already relative to that directory.
3452         With git, $ENV{PWD} is the directory that the commit was invoked
3453         from, which fixes the ChangeLog paths so that the correct files
3454         are read when creating the commit log entry.
3455
3456         Note that the call to makeFilePathRelative() was supposed to
3457         address this issue, but it doesn't because (a) it does nothing
3458         with svn working directories by design, and (b) it does nothing
3459         with git working directories because it's invoked when the
3460         current directory is the root of the working directory, thus
3461         giving no relative path.
3462
3463         * Scripts/commit-log-editor: Removed call to
3464         makeFilePathRelative() since since it does nothing.  Moved code
3465         to fix up $changeLog path so that it's fixed before trying to
3466         open the file, and use $ENV{PWD} as the base path.  Also use
3467         canonicalizePath() to clean up paths with "../" in them.
3468
3469 2010-07-07  Anders Carlsson  <andersca@apple.com>
3470
3471         Another attempt at fixing the Qt build.
3472
3473         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3474
3475 2010-07-07  Anders Carlsson  <andersca@apple.com>
3476
3477         Try to fix Qt build.
3478
3479         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3480
3481 2010-07-07  Anders Carlsson  <andersca@apple.com>
3482
3483         Reviewed by Simon Fraser.
3484
3485         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
3486         https://bugs.webkit.org/show_bug.cgi?id=41781
3487
3488         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3489         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
3490         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
3491         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
3492         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
3493         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
3494         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
3495         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
3496         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
3497         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
3498         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
3499         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
3500         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3501
3502 2010-07-07  Andras Becsi  <abecsi@webkit.org>
3503
3504         Unreviewed trivial fix.
3505
3506         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
3507         which was checked in accidentally in r62635.
3508
3509         * Scripts/webkitpy/layout_tests/port/webkit.py:
3510
3511 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3512
3513         Reviewed by Eric Seidel.
3514
3515         Pass port specific environment to server process.
3516         https://bugs.webkit.org/show_bug.cgi?id=41593
3517
3518         * Scripts/webkitpy/layout_tests/port/qt.py:
3519         * Scripts/webkitpy/layout_tests/port/webkit.py:
3520
3521 2010-07-06  Kent Tamura  <tkent@chromium.org>
3522
3523         Reviewed by Shinichiro Hamaji.
3524
3525         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
3526         https://bugs.webkit.org/show_bug.cgi?id=41644
3527
3528         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
3529         tolerance. We don't need tolerance for rebaseline.
3530
3531         * Scripts/webkitpy/layout_tests/port/base.py:
3532           Add optional tolerance parameter to diff_image().
3533         * Scripts/webkitpy/layout_tests/port/test.py:
3534           Add optional tolerance parameter to diff_image().
3535         * Scripts/webkitpy/layout_tests/port/webkit.py:
3536           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
3537         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3538           diff_files() always calls diff_image() with tolerance=0.
3539           diff_files() is used only by rebaseline-chromium-webkit-tests.
3540
3541 2010-07-06  Sam Weinig  <sam@webkit.org>
3542
3543         Fix MiniBrowser build.
3544
3545         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3546
3547 2010-07-06  Sam Weinig  <sam@webkit.org>
3548
3549         Reviewed by Anders Carlsson.
3550
3551         Add support for dumping the contents of messages to the console to WebKitTestRunner
3552
3553         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3554         (WTR::InjectedBundlePage::InjectedBundlePage):
3555         (WTR::InjectedBundlePage::_addMessageToConsole):
3556         (WTR::InjectedBundlePage::addMessageToConsole):
3557         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3558
3559 2010-07-06  Sam Weinig  <sam@webkit.org>
3560
3561         Reviewed by Anders Carlsson.
3562
3563         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
3564         Add dumpAsText support for WebKitTestRunner
3565
3566         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3567         (WTR::InjectedBundle::InjectedBundle):
3568         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
3569         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3570         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
3571         API to dump the main frames text.
3572
3573 2010-07-06  Darin Adler  <darin@apple.com>
3574
3575         Fix Chromium build.
3576
3577         * DumpRenderTree/chromium/WebViewHost.cpp:
3578         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
3579         (WebViewHost::didNavigateWithinPage): Ditto.
3580         (WebViewHost::updateURL): Ditto.
3581
3582 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
3583
3584         Reviewed by Xan Lopez.
3585
3586         [GTK] build-webkit should not run autogen.sh unconditionally