2009-02-28 Gustavo Noronha Silva <gns@gnome.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
2
3         Reviewed by Holger Freyther.
4
5         Add a GTK+-only option to enable GNOME Keyring when building.
6
7         * Scripts/build-webkit:
8
9 2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
10
11         Reviewed by Holger Freyther.
12
13         [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
14         https://bugs.webkit.org/show_bug.cgi?id=24076
15
16         Refactor gtk lib detection and put it in builtDylibPathForName
17
18         * Scripts/webkitdirs.pm:
19
20 2009-02-28  Christian Dywan  <christian@twotoasts.de>
21
22         Rubber-stamped by Holger Freyther.
23
24         * GtkLauncher/main.c:
25         (activate_uri_entry_cb):
26         (main): Use the new webkit_web_view_load_uri to open URIs.
27
28 2009-02-27  Xan Lopez  <xan@gnome.org>
29
30         Rubber-stamped by Alexey Proskuryakov.
31
32         https://bugs.webkit.org/show_bug.cgi?id=24222
33         [GTK] Remove checks for old glib versions
34
35         libsoup, which is a hard dependency, needs at least glib 2.15.3,
36         so remove all glib checks for versions older than that.
37
38         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
39         (LayoutTestController::setWaitToDump):
40
41 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
42
43         Reviewed by Eric Seidel
44
45         Fix spew about a WebView being deallocated while key value observers are
46         still registered with it by making sure that we always stop observing
47         _isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].
48         
49         * DumpRenderTree/mac/DumpRenderTree.mm:
50         (dumpRenderTree):
51         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
52         (-[DumpRenderTreeWindow close]):
53
54 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
55
56         Reviewed by Alexey Proskuryakov.
57
58         Do not queue the calls to 'DumpRenderTree::dump()' as this can result
59         in more than one call as a test that calls 'notifyDone()' can then be
60         subsequently fully loaded and initiate a second dump.  Also make sure
61         to stop any existing page load that is happening before running the next
62         test.  Combined this serves to produce 217 more passing tests for the
63         Qt port or roughly 5% at this point.
64
65         * DumpRenderTree/qt/DumpRenderTree.cpp:
66         (WebCore::DumpRenderTree::DumpRenderTree):
67         (WebCore::DumpRenderTree::open):
68
69 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
70
71         Reviewed by Dan Bernstein
72
73         https://bugs.webkit.org/show_bug.cgi?id=23854
74
75         Have the DumpRenderTreeWindow observe the -_isUsingAcceleratedCompositing
76         property of the WebView, and use that to turn -autodisplay on and off.
77         This is necessary so that accelerated animations start correctly.
78         We can thus remove the -display hack in createBitmapContextFromWebView().
79
80         * DumpRenderTree/mac/DumpRenderTree.mm:
81         (createWebViewAndOffscreenWindow):
82         (dumpRenderTree):
83         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
84         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
85         (-[DumpRenderTreeWindow close]):
86         (-[DumpRenderTreeWindow webView]):
87         (-[DumpRenderTreeWindow startObservingWebView]):
88         (-[DumpRenderTreeWindow stopObservingWebView]):
89         (-[DumpRenderTreeWindow observeValueForKeyPath:ofObject:change:context:]):
90         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
91         (createBitmapContextFromWebView):
92
93 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
94
95         Reviewed by Zack Rusin.
96
97         https://bugs.webkit.org/show_bug.cgi?id=24158
98         Implement the queue*() methods of the layoutTestController and begin
99         implementing the dump of the back/forward list.  This results in 2% more
100         tests passing as well as 23 currently skipped tests now passing.
101
102         * DumpRenderTree/qt/DumpRenderTree.cpp:
103         (WebCore::DumpRenderTree::dumpBackForwardList):
104         (WebCore::DumpRenderTree::dump):
105         * DumpRenderTree/qt/DumpRenderTree.h:
106         * DumpRenderTree/qt/DumpRenderTree.pro:
107         * DumpRenderTree/qt/jsobjects.cpp:
108         (findFrameNamed):
109         (LoadItem::invoke):
110         (ReloadItem::invoke):
111         (ScriptItem::invoke):
112         (BackForwardItem::invoke):
113         (LayoutTestController::reset):
114         (LayoutTestController::processWork):
115         (LayoutTestController::maybeDump):
116         (LayoutTestController::queueBackNavigation):
117         (LayoutTestController::queueForwardNavigation):
118         (LayoutTestController::queueLoad):
119         (LayoutTestController::queueReload):
120         (LayoutTestController::queueScript):
121         * DumpRenderTree/qt/jsobjects.h:
122         (LayoutTestController::shouldDumpBackForwardList):
123         (LayoutTestController::dumpBackForwardList):
124
125 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
126
127         Reviewed by Alexey Proskuryakov.
128
129         Don't print out that you are generating new results if you are not in fact
130         generating new results and disable generating new results by default for
131         the all ports other than the canonical Apple Mac port since this can litter
132         the source directory with hundreds of new results since other ports
133         are not as up to date.
134
135         * Scripts/run-webkit-tests:
136
137 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
138
139         Reviewed by Cameron Zwarich.
140
141         The Qt port does not support these yet nor does the nm check work with
142         QMake based build.
143
144         * Scripts/webkitdirs.pm:
145
146 2009-02-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
147
148         Reviewed by Alexey Proskuryakov.
149
150         [Gtk] add options for 3D transforms and HTML5 channel messaging to the build
151         https://bugs.webkit.org/show_bug.cgi?id=24072
152
153         Allow toggling of 3D transforms and HTML5 channel messaging
154         support for the Autotools (Gtk) build.
155
156         Also add '--gtk' in the build-webkit help doc and fix autotools
157         option for web-workers support.
158
159         * Scripts/build-webkit:
160
161 2009-02-23  Xan Lopez  <xan@gnome.org>
162
163         Reviewed by Alexey Proskuryakov.
164
165         https://bugs.webkit.org/show_bug.cgi?id=22624
166         [SOUP][GTK] Need API to get SoupSession from WebKit.
167
168         Add soup flags now that dependency is explicit.
169
170         * GNUmakefile.am:
171
172 2009-02-22  Mark Rowe  <mrowe@apple.com>
173
174         Reviewed by Oliver Hunt.
175
176         Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.
177
178         * DumpRenderTree/mac/DumpRenderTree.mm:
179         (swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
180         than of an arbitrary existing method on the class.
181
182 2009-02-13  Eric Seidel  <eric@webkit.org>
183
184         Rubber-stamped by Alexey Proskuryakov.
185
186         Add a few ignores to make-js-test-wrappers.
187
188         * Scripts/make-js-test-wrappers:
189
190 2009-02-17  Holger Hans Peter Freyther  <zecke@selfish.org>
191
192         Reviewed by Alexey Proskuryakov.
193
194         Prepend file:// to the test result filename to make
195         GtkLauncher display the result page.
196
197         * Scripts/run-webkit-tests:
198
199 2009-02-16  Gustavo Noronha Silva  <gns@gnome.org>
200
201         Reviewed by Adam Roben
202
203         Actually use the installation prefix defined in WebKitInstallationPrefix,
204         in autotools builds.
205
206         * Scripts/webkitdirs.pm:
207
208 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
209
210         No review.
211
212         Remove debugging code which was committed by mistake.
213
214         * Scripts/run-webkit-tests:
215
216 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
217
218         Reviewed by Adam Roben
219
220         https://bugs.webkit.org/show_bug.cgi?id=23928
221
222         Add detection of accelerated compositing and 3d transforms,
223         and add various directories to $ignoredDirectories when these
224         features are off.
225
226         * Scripts/run-webkit-tests:
227         * Scripts/webkitdirs.pm:
228
229 2009-02-12  Adam Roben  <aroben@apple.com>
230
231         Fix Bug 23922: Warning message from run-webkit-tests when Skipped file
232         contains non-existent tests is confusing and is given for disabled
233         tests
234
235         <https://bugs.webkit.org/show_bug.cgi?id=23922>
236
237         We now no longer warn about disabled tests. The warning now reads:
238
239         Skipped list contained '$item', but no file of that name could be
240         found
241
242         Reviewed by John Sullivan.
243
244         * Scripts/run-webkit-tests:
245         (top level): Pass the list name to processIgnoreTests so it can print
246         out a reasonable warning message.
247         (processIgnoreTests): Take a list name as a second parameter and use
248         it to display a better warning message. Also check for a "-disabled"
249         version of the test before warning about it not existing.
250
251 2009-02-11  Adam Roben  <aroben@apple.com>
252
253         Windows fix for Bug 22239: Implement missing animation & transition
254         APIs on LayoutTestController for non-mac platforms
255
256         <https://bugs.webkit.org/show_bug.cgi?id=22239>
257
258         Reviewed by Simon Fraser.
259
260         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
261         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
262         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
263         (LayoutTestController::numberOfActiveAnimations):
264         Implemented these by calling through to IWebFramePrivate.
265
266 2009-02-10  Chris Marrin  <cmarrin@apple.com>
267
268         Reviewed by Simon Fraser.
269
270         * Scripts/build-webkit:
271
272         https://bugs.webkit.org/show_bug.cgi?id=23883
273
274         Added support --3d-transforms. Defaults to off
275
276 2009-02-11  Adam Roben  <aroben@apple.com>
277
278         Fix crashes in http/tests/history/redirect-301.pl and friends on
279         Windows
280
281         Reviewed by Alexey Proskuryakov.
282
283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
284         (LayoutTestController::webHistoryItemCount): Null-check the shared
285         WebHistory instance before dereferencing it.
286
287 2009-02-10  Adam Roben  <aroben@apple.com>
288
289         Fix Bug 23869: Pixel tests can't be run on Windows
290
291         <https://bugs.webkit.org/show_bug.cgi?id=23869>
292
293         This patch gets the pixel tests limping along on Windows again.
294
295         Reviewed by Dan Bernstein.
296
297         * DumpRenderTree/DumpRenderTree.sln: Changed to use the new
298         Debug_Internal configuration of ImageDiff in the Debug_Internal
299         configuration of this solution.
300
301         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
302         (printPNG): Changed to call fwrite in a loop, since this call was
303         failing due to the buffer being too large on Windows.
304         (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
305         #if PLATFORM(MAC)/#endif.
306
307         * DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
308         configuration that matches the Debug configuration but also references
309         debug_internal.vsprops.
310
311         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
312         (createBitmapContextFromWebView): Renamed from
313         getBitmapContextFromWebView to match the name used in the
314         cross-platform code.
315
316 2009-02-10  Adam Roben  <aroben@apple.com>
317
318         Robustify DumpRenderTree/win a little
319
320         DumpRenderTree was previously not holding a ref to the WebViews it
321         created via window.open. It was getting away with this because
322         WebViews get reffed by being preference notification observers and by
323         registering for drag-n-drop messages. Now DRT does hold a ref, in case
324         this situation changes in the future.
325
326         Reviewed by Alexey Proskuryakov.
327
328         * DumpRenderTree/win/DumpRenderTree.cpp:
329         (dumpBackForwardListForAllWindows): Added a .get().
330         (windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
331         * DumpRenderTree/win/DumpRenderTreeWin.h: Changed the
332         windowToWebViewMap() to hold a ref to the WebViews it contains.
333
334 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
335
336         Fix the #include file order, per review comments.
337
338         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
339
340 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
341
342         Reviewed by Dan Bernstein
343
344         https://bugs.webkit.org/show_bug.cgi?id=23362
345
346         If the WebHTMLView uses accelerated compositing, we need for force
347         the on-screen capture path and also force animations to start with -display
348         since the DRT window has autodisplay disabled.
349
350         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
351         (createBitmapContextFromWebView):
352
353 2009-02-03  miggilin  <mr.diggilin@gmail.com>
354
355         Reviewed by Darin Adler.
356
357         Change the way wxWidgets build gets arguments.
358         Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
359         argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
360         removed when --wx is checked for).
361
362         https://bugs.webkit.org/show_bug.cgi?id=23701
363
364         * Scripts/build-webkit:
365         * Scripts/webkitdirs.pm:
366
367 2009-01-30  Chris Fleizach  <cfleizach@apple.com>
368
369         Reviewed by Oliver Hunt.
370
371         Catch exceptions thrown by AppKit when accessing an attribute than an element
372         doesn't return.
373
374         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
375         (attributesOfElement):
376
377 2009-01-29  David Kilzer  <ddkilzer@apple.com>
378
379         Remove semi-colons from the end of ObjC method implementations
380
381         Rubber-stamped by Adam Roben.
382
383         $ find WebKitTools -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
384
385         * DumpRenderTree/mac/FrameLoadDelegate.mm:
386         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
387         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
388         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
389         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
390         * DumpRenderTree/mac/UIDelegate.mm:
391         (-[UIDelegate webViewFrame:]):
392
393 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
394
395         Build fix for GTK.
396
397         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
398         (LayoutTestController::webHistoryItemCount):
399
400 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
401
402         Reviewed by Sam Weinig.
403
404         Added support for querying how many history items were created during a
405         layout test.
406
407         * DumpRenderTree/LayoutTestController.cpp:
408         (getWebHistoryItemCountCallback):
409         (LayoutTestController::staticValues):
410         * DumpRenderTree/LayoutTestController.h:
411         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
412         (LayoutTestController::webHistoryItemCount):
413         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
414         (LayoutTestController::webHistoryItemCount):
415
416 2009-01-26  Pierre-Olivier Latour  <pol@apple.com>
417
418         Tweaked again earlier fix, this time just to print a warning and not abort if
419         attempting to generate pixel results and Perian is installed.
420
421         https://bugs.webkit.org/show_bug.cgi?id=22615
422
423         * Scripts/run-webkit-tests:
424
425 2009-01-26  Christian Dywan  <christian@twotoasts.de>
426
427         Rubber stamped by Holger Freyther.
428
429         * GtkLauncher/main.c:
430         (main): Initialize threads, which is required for libSoup.
431
432 2009-01-23  David Kilzer  <ddkilzer@apple.com>
433
434         * Scripts/do-webcore-rename: Removed 10 header guard renames that
435         had already been fixed, and updated 4 renames whose original values
436         had changed.
437
438 2009-01-22  Anders Carlsson  <andersca@apple.com>
439
440         Fix Windows build.
441
442         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
443
444 2009-01-22  Anders Carlsson  <andersca@apple.com>
445
446         Reviewed by Sam Weinig.
447
448         Clean up the test plug-in code. We now always use the CG drawing model and the
449         Cocoa event model. It is however possible to revert to the old Carbon event model by
450         specifying forcecarbon=true in the embed/object tag.
451
452         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
453         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
454         (NPP_New):
455         (handleEventCarbon):
456         (handleEventCocoa):
457         (NPP_HandleEvent):
458
459 2009-01-21  Pierre-Olivier Latour  <pol@apple.com>
460
461         Tweaked earlier fix to only print a warning when Perian is installed,
462         and fail completely only if attempting to generate new pixel test results.
463
464         https://bugs.webkit.org/show_bug.cgi?id=23392
465
466         * Scripts/run-webkit-tests:
467
468 2009-01-20  Darin Adler  <darin@apple.com>
469
470         Reviewed by Alexey Proskuryakov.
471
472         Bug 23450: string leaks seen in DumpRenderTree accessibility test code
473         https://bugs.webkit.org/show_bug.cgi?id=23450
474
475         * DumpRenderTree/AccessibilityUIElement.cpp:
476         (isAttributeSettableCallback): Add the missing JSStringRelease call.
477         (attributeValueCallback): Ditto.
478
479 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
480
481         Reviewed by Darin Adler.
482
483         Print warning regarding display color profile change in run-webkit-tests instead of DRT.
484
485         https://bugs.webkit.org/show_bug.cgi?id=23392
486
487         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
488         (setupMainDisplayColorProfile):
489         * Scripts/run-webkit-tests:
490
491 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
492
493         Reviewed by Darin Adler.
494
495         Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
496         in order to avoid result differences in some media tests.
497
498         https://bugs.webkit.org/show_bug.cgi?id=22615
499
500         * Scripts/run-webkit-tests:
501         * Scripts/webkitdirs.pm:
502
503 2009-01-19  Sam Weinig  <sam@webkit.org>
504
505         * Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
506
507 2009-01-16  Gabor Loki  <loki@inf.u-szeged.hu>
508
509         Reviewed by Darin Adler.
510
511         * Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional
512         parameters to make command in QMake projects.
513
514 2009-01-16  Chris Fleizach  <cfleizach@apple.com>
515
516         Reviewed by Beth Dakin.
517
518         Add AX methods to retrieve the parent of an element.
519
520         * DumpRenderTree/AccessibilityUIElement.cpp:
521         (parentElementCallback):
522         (AccessibilityUIElement::getJSClass):
523         * DumpRenderTree/AccessibilityUIElement.h:
524         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
525         (AccessibilityUIElement::parentElement):
526         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
527         (AccessibilityUIElement::parentElement):
528
529 2009-01-16  Anders Carlsson  <andersca@apple.com>
530
531         Reviewed by Adam Roben.
532
533         Set the count to the right number of elements.
534
535         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
536         (testEnumerate):
537
538 2009-01-14  David Kilzer  <ddkilzer@apple.com>
539
540         BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()
541
542         Rubber-stamped by Alice Liu.
543
544         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
545         (LayoutTestController::setIconDatabaseEnabled): Use COM API
546         to get the shared WebIconDatabase.
547
548 2009-01-14  Jeremy Moskovich  <jeremy@chromium.org>
549
550         Reviewed by Eric Seidel.
551
552         <https://bugs.webkit.org/show_bug.cgi?id=16829>
553         Implement NPN_SetException()
554
555         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
556         (pluginInvoke):
557         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
558         (initializeIdentifiers):
559         (testHasMethod):
560         (testInvoke):
561
562 2009-01-13  Dmitry Titov  <dimich@chromium.org>
563
564         Reviewed by David Kilzer.
565
566         https://bugs.webkit.org/show_bug.cgi?id=23304
567         Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
568
569         * Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
570
571 2009-01-14  David Kilzer  <ddkilzer@apple.com>
572
573         BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
574
575         * DumpRenderTree/gtk/DumpRenderTree.cpp:
576         (runTest): Added call to reset the icon database to match Mac
577         and Windows ports.
578         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
579         (LayoutTestController::setIconDatabaseEnabled): Implemented
580         stub method.
581
582 2009-01-14  David Kilzer  <ddkilzer@apple.com>
583
584         Bug 22795: favicons should be saved to webarchives
585
586         <https://bugs.webkit.org/show_bug.cgi?id=22795>
587
588         Reviewed by Darin Adler.
589
590         * DumpRenderTree/LayoutTestController.cpp:
591         (setIconDatabaseEnabledCallback): Added.
592         (setJavaScriptProfilingEnabledCallback): Realphabetized.
593         (LayoutTestController::staticFunctions): Added entry for calling
594         LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
595         * DumpRenderTree/LayoutTestController.h:
596         (setIconDatabaseEnabledCallback): Added declaration.
597         (setJavaScriptProfilingEnabledCallback): Realphabetized.
598
599         * DumpRenderTree/mac/DumpRenderTree.mm:
600         (runTest): Disable the icon database before each test.
601         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
602         (LayoutTestController::setIconDatabaseEnabled): Added.
603         (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
604
605         * DumpRenderTree/win/DumpRenderTree.cpp:
606         (runTest): Disable the icon database before each test.
607         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
608         (LayoutTestController::setIconDatabaseEnabled): Added.
609
610 2009-01-14  Steve Falkenburg  <sfalken@apple.com>
611
612         Update copyright year in version resources.
613
614         Reviewed by Adam Roben.
615
616         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
617
618 2009-01-14  Dan Bernstein  <mitz@apple.com>
619
620         Reviewed by John Sullivan.
621
622         - update copyright
623
624         * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
625         * WebKitLauncher/Info.plist:
626
627 2009-01-13  Anders Carlsson  <andersca@apple.com>
628
629         Reviewed by Sam Weinig.
630
631         Add NPRuntime test.
632
633         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
634         (testNPRuntime):
635         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
636         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
637         (NPP_New):
638         (NPP_GetValue):
639
640 2009-01-12  Mark Rowe  <mrowe@apple.com>
641
642         Use the modern spelling of WebKit.
643
644         * Scripts/find-extra-includes:
645         * Scripts/report-include-statistics:
646         * Scripts/run-webkit-app:
647         * Scripts/svn-unapply:
648         * Scripts/update-webkit:
649
650 2009-01-11  Darin Adler  <darin@apple.com>
651
652         * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
653         directory that aren't using standard wrappers.
654
655 2009-01-11  Robert Blaut  <webkit@blaut.biz>
656
657         Reviewed by Eric Seidel.
658
659         <https://bugs.webkit.org/show_bug.cgi?id=23134>
660         Update bisect-builds for Safari 3.2 to prevent crashes
661
662         * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
663
664 2009-01-08  Adam Treat  <adam.treat@torchmobile.com>
665
666         Reviewed by Simon Hausmann.
667
668         Explicitly set these so that the layout tests do not break.
669
670         * DumpRenderTree/qt/DumpRenderTree.cpp:
671         (WebCore::WebPage::WebPage):
672
673 2009-01-07  Glenn Wilson  <gwilson@chromium.org>
674
675         Reviewed by Eric Seidel.
676
677         Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
678         This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
679
680         * DumpRenderTree/mac/DumpRenderTree.mm:
681         (testStringByEvaluatingJavaScriptFromString):
682         (setDefaultsToConsistentValuesForTesting):
683
684 2009-01-07  Holger Hans Peter Freyther  <zecke@selfish.org>
685
686         Reviewed by Maciej Stachowiak.
687
688         Implement numberOfActiveAnimations to fix the build
689
690         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
691         (LayoutTestController::numberOfActiveAnimations):
692
693 2009-01-07  Adam Treat  <adam.treat@torchmobile.com>
694
695         Reviewed by George Staikos.
696
697         Fix unused variable warnings
698
699         * DumpRenderTree/qt/DumpRenderTree.cpp:
700         (WebCore::WebPage::javaScriptAlert):
701         (WebCore::WebPage::javaScriptConfirm):
702         (WebCore::WebPage::javaScriptPrompt):
703         * DumpRenderTree/qt/jsobjects.cpp:
704         (LayoutTestController::maybeDump):
705         * DumpRenderTree/qt/main.cpp:
706         (get_backtrace):
707         * DumpRenderTree/qt/testplugin.cpp:
708         (TestPlugin::create):
709
710 2009-01-06  Pierre-Olivier Latour  <pol@apple.com>
711
712         Reviewed by Darin Adler.
713
714         Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
715         This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
716
717         https://bugs.webkit.org/show_bug.cgi?id=23126
718
719         * DumpRenderTree/LayoutTestController.cpp:
720         (numberOfActiveAnimationsCallback):
721         (LayoutTestController::staticFunctions):
722         * DumpRenderTree/LayoutTestController.h:
723         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
724         (LayoutTestController::numberOfActiveAnimations):
725         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
726         (LayoutTestController::numberOfActiveAnimations):
727
728 2009-01-04  David Kilzer  <ddkilzer@apple.com>
729
730         Don't install internal headers in WebKit framework
731
732         Reviewed by Darin Adler.
733
734         Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
735         no longer installed in WebKit.framework/PrivateHeaders, use the
736         special relationship of DumpRenderTree within the WebKit source
737         tree to include the internal headers through relative paths.
738         Created the concept of mac/InternalHeaders to hide the ugly
739         paths.
740
741         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added
742         mac/InternalHeaders to HEADER_SEARCH_PATHS.
743         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
744         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
745
746 2009-01-02  Adam Treat  <treat@kde.org>
747
748         Reviewed by George Staikos.
749
750         Add support for fixedLayoutSize to the qt DRT
751
752         * DumpRenderTree/qt/jsobjects.cpp:
753         (LayoutTestController::setFixedLayoutSize):
754         (LayoutTestController::setUseFixedLayout):
755         * DumpRenderTree/qt/jsobjects.h:
756
757 2009-01-03  David D. Kilzer  <ddkilzer@webkit.org>
758
759         Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
760
761         <https://bugs.webkit.org/show_bug.cgi?id=23091>
762
763         Reviewed by Darin Adler.
764
765         * DumpRenderTree/mac/DumpRenderTree.mm:
766         (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
767         Connection headers from webarchive results.
768
769 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
770
771         Reviewed by Holger Freyther.
772
773         https://bugs.webkit.org/show_bug.cgi?id=22812
774
775         Prevent TestNetscapePlugin from installing system-wide.
776
777         * GNUmakefile.am:
778
779 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
780
781         Reviewed by Holger Freyther.
782
783         https://bugs.webkit.org/show_bug.cgi?id=22842
784
785         Move WebKitWebView's size allocation into a proper place.
786
787         * DumpRenderTree/gtk/DumpRenderTree.cpp:
788         (dump):
789         (runTest):
790
791 2008-12-24  Mark Rowe  <mrowe@apple.com>
792
793         Reviewed by Timothy Hatcher.
794
795         Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
796         and make it work for git too.
797
798         * Scripts/VCSUtils.pm:
799         * Scripts/webkitdirs.pm:
800
801 2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
802
803         Reviewed by George Staikos.
804
805         Ignore http/tests/wml, if no WML support is present.
806         Add http/tests/wml to list of HTTP tests, allowed to access local resources.
807
808         * Scripts/run-webkit-tests:
809
810 2008-12-19  David Levin  <levin@chromium.org>
811
812         Reviewed by Mark Rowe.
813
814         https://bugs.webkit.org/show_bug.cgi?id=22930
815
816         Make the git diff command used for preparing the change log avoid using any external diff tools.
817
818         * Scripts/prepare-ChangeLog:
819
820 2008-12-19  Gustavo Noronha Silva  <gns@gnome.org>
821
822         Reviewed by Holger Freyther.
823
824         https://bugs.webkit.org/show_bug.cgi?id=22686
825
826         Added files which were missing from the TestNetscapePlugin
827         directory to the SOURCES variable, so that they will be
828         distributed in a make dist.
829
830         * GNUMakefile.am:
831
832 2008-12-18  Cameron Zwarich  <zwarich@apple.com>
833
834         Reviewed by Geoff Garen.
835
836         Add tests for bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
837         <https://bugs.webkit.org/show_bug.cgi?id=21855>
838         <rdar://problem/6278244>
839
840         Add support for scheduling asynchronous clicks to DumpRenderTree, but
841         only on the Mac.
842
843         * DumpRenderTree/mac/EventSendingController.h:
844         * DumpRenderTree/mac/EventSendingController.mm:
845         (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
846         scheduleAsynchronousClick to JavaScript.
847         (-[EventSendingController scheduleAsynchronousClick]): Add.
848
849 2008-12-15  Darin Adler  <darin@apple.com>
850
851         * Scripts/make-js-test-wrappers: Added another exception to avoid overwriting
852         a custom-written test.
853
854 2008-12-15  Simon Hausmann  <hausmann@webkit.org>
855
856         Reviewed by Holger Freyther.
857
858         Implement setJavaScriptProfilingEnabled in the Qt DRT to pass fast/profiler.
859
860         * DumpRenderTree/qt/jsobjects.cpp:
861         (LayoutTestController::setJavaScriptProfilingEnabled):
862         * DumpRenderTree/qt/jsobjects.h:
863
864 2008-12-13  Zan Dobersek  <zandobersek@gmail.com>
865
866         Reviewed by Darin Adler.
867
868         https://bugs.webkit.org/show_bug.cgi?id=22039
869
870         Implement animation and transition pausing.
871
872         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
873         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
874         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
875
876 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
877
878         Reviewed by Adam Roben.
879
880         https://bugs.webkit.org/show_bug.cgi?id=22809
881
882         Increase timeout in call to initWithURL so that people actually see
883         new web pages when they type URLs rather than a blank screen.
884
885         * WinLauncher/WinLauncher.cpp:
886         (loadURL):  Increase timeout in initWithURL from 0 to 60 seconds.
887
888 2008-12-12  Darin Adler  <darin@apple.com>
889
890         * Scripts/do-webcore-rename: Add a renaming idea.
891
892 2008-12-12  Holger Hans Peter Freyther  <zecke@selfish.org>
893
894         Reviewed by Simon Hausmann.
895
896         Update the WebKit.qrc and add a script to automatically generate the file.
897
898         With the way rcc and qmake work this can not be done at build time
899         as the WebKit.qrc must sit inside the directory that contains the files
900         and at build time we may not change the content of the source directory.
901
902         * Scripts/generate-qt-inspector-resource: Added.
903
904 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
905
906         Rubber-stamped by Mark Rowe.
907
908         Roll out r39212 due to assertion failures during layout tests, multiple
909         layout test failures, memory leaks, and obvious incorrectness.
910
911         * DumpRenderTree/LayoutTestController.cpp:
912         (LayoutTestController::staticFunctions):
913         * DumpRenderTree/LayoutTestController.h:
914         * DumpRenderTree/mac/DumpRenderTree.mm:
915         (resetWebViewToConsistentStateBeforeTesting):
916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
917         * DumpRenderTree/win/DumpRenderTree.cpp:
918         (resetWebViewToConsistentStateBeforeTesting):
919         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
920         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
921
922 2008-12-10  Glenn Wilson  <gwilson@google.com>
923
924         Reviewed by Adam Roben.
925
926         Changed LayoutTestController and DumpRenderTree to allow for manual
927         overriding of default preferences at test time.  Also added support for
928         resetting the preferences after each test.
929         https://bugs.webkit.org/show_bug.cgi?id=20534
930
931         * DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
932         * DumpRenderTree/LayoutTestController.h: Added signature for callback
933         * DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
934         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
935         * DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
936         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
937
938 2008-12-10  Brady Eidson  <beidson@apple.com>
939
940         Reviewed by Darin Adler.
941
942         Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
943
944         * DumpRenderTree/win/DumpRenderTree.cpp:
945         * DumpRenderTree/win/DumpRenderTreeWin.h:
946
947         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
948         (LayoutTestController::setCustomPolicyDelegate):
949
950         * DumpRenderTree/win/PolicyDelegate.cpp:
951         (PolicyDelegate::PolicyDelegate):
952         (PolicyDelegate::decidePolicyForNavigationAction):
953         * DumpRenderTree/win/PolicyDelegate.h:
954         (PolicyDelegate::setPermissive):
955
956 2008-12-10  Brady Eidson  <beidson@apple.com>
957
958         Reviewed by Darin
959
960         Change the custom policy delegate to actually allow navigation for tests that need it.
961         The new behavior is opt-in and doesn't require any changes in old tests.
962
963         * DumpRenderTree/LayoutTestController.cpp:
964         (setCustomPolicyDelegateCallback):  Allow for a second boolean argument to set the permissive flag on the custom
965           policy delegate, which will be false by default to maintain original behavior.
966         * DumpRenderTree/LayoutTestController.h:
967         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
968         (LayoutTestController::setCustomPolicyDelegate):
969
970         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
971         (LayoutTestController::setCustomPolicyDelegate):  Partially stubbed out for now.
972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
973         (LayoutTestController::setCustomPolicyDelegate):  Still stubbed out, but with new param.
974
975         * DumpRenderTree/mac/PolicyDelegate.h:
976         * DumpRenderTree/mac/PolicyDelegate.mm:
977         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):  If the permissive flag
978           is set, allow the navigation.
979         (-[PolicyDelegate setPermissive:]):  Change the behavior between "use" and "ignore" - allowing navigation or not.
980
981 2008-12-09  Mark Rowe  <mrowe@apple.com>
982
983         Rubber-stamped by Ada Chan.
984
985         Fix gdb-safari on Tiger.
986
987         gdb on Tiger does not take the -arch flag, so do not pass it.
988
989         * Scripts/gdb-safari:
990
991 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
992
993         Reviewed by Alexey Proskuryakov.
994
995         Ignore WML tests, if no WML support available.
996
997         * Scripts/run-webkit-tests:
998
999 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
1000
1001         Reviewed by Oliver Hunt.
1002
1003         Added a shortcut for --jsDriver-args, which I use a lot.
1004
1005         * Scripts/run-javascriptcore-tests:
1006
1007 2008-12-08  Stephanie Lewis  <slewis@apple.com>
1008
1009         Fix Tiger build.
1010
1011         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1012
1013 2008-12-08  Darin Adler  <darin@apple.com>
1014
1015         Reviewed by John Sullivan.
1016
1017         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
1018           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
1019
1020         * DumpRenderTree/LayoutTestController.cpp:
1021         (isCommandEnabledCallback): Added.
1022         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
1023         * DumpRenderTree/LayoutTestController.h: Ditto.
1024         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1025         (LayoutTestController::isCommandEnabled): Ditto.
1026         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1027         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
1028         command validation system to tell us if a comment is enabled.
1029         (-[CommandValidationTarget action]): Ditto.
1030         (-[CommandValidationTarget tag]): Ditto.
1031         (LayoutTestController::isCommandEnabled): Ditto.
1032         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1033         (LayoutTestController::isCommandEnabled): Ditto.
1034
1035 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1036
1037         Bug 22555: Sort "children" sections in Xcode project files
1038
1039         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1040
1041         Reviewed by Eric Seidel.
1042
1043         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
1044         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
1045         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
1046
1047 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1048
1049         Bug 22555: Sort "children" sections in Xcode project files
1050
1051         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1052
1053         Reviewed by Timothy Hatcher.
1054
1055         * Scripts/sort-Xcode-project-file: By popular request, don't sort
1056         the mainGroup in the project (the list of items below the top-level
1057         project file).
1058
1059 2008-12-05  David Kilzer  <ddkilzer@apple.com>
1060
1061         Bug 22555: Sort "children" sections in Xcode project files
1062
1063         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1064
1065         Reviewed by Darin Adler.
1066
1067         Sort "children" sections alphabetically, moving groups (folders) to
1068         the top of each of the lists.  Files are assumed to have extensions,
1069         so %isFile is used to override this behavior.
1070
1071         * Scripts/sort-Xcode-project-file:
1072         (sortChildrenByFileName): Added.
1073         (sortFilesByFileName): Renamed from sortByFileName().
1074
1075 2008-12-05  Eric Seidel  <eric@webkit.org>
1076
1077         Reviewed by Geoff Garen.
1078
1079         https://bugs.webkit.org/show_bug.cgi?id=22683
1080         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
1081         Add a new argumentsForConfiguration() function and clean up some old code to use it.
1082         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
1083
1084         * Scripts/run-javascriptcore-tests:
1085         * Scripts/run-launcher:
1086         * Scripts/run-webkit-tests:
1087         * Scripts/webkitdirs.pm:
1088
1089 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1090
1091         Reviewed by Cameron Zwarich.
1092
1093         Further preparations for WML layout tests.
1094         Ignore WMLTestCase.js, that's going to be in trunk soon.
1095
1096         * Scripts/make-js-test-wrappers:
1097
1098 2008-12-03  Eric Seidel  <eric@webkit.org>
1099
1100         Build fix for --gtk and --chromium, no review.
1101
1102         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
1103         through to build-jsc.
1104
1105         * Scripts/build-jsc:
1106         * Scripts/webkitdirs.pm:
1107
1108 2008-12-03  Eric Seidel  <eric@webkit.org>
1109
1110         Build fix only, no review.
1111
1112         Remove support for build-webkit --svg-experimental.
1113         All of the "experimental" svg features have their own toggles anyway.
1114         I broke --svg-experimental in my last commit (which then broke clean builds)
1115         I can't find any use of --svg-experimental in our source tree, so removing it.
1116
1117         * Scripts/build-webkit:
1118
1119 2008-12-02  Eric Seidel  <eric@webkit.org>
1120
1121         Reviewed by David Hyatt (and Mark Rowe).
1122
1123         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
1124         Move --coverage support out of run-javascriptcore-tests and into build-jsc
1125
1126         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
1127         there from build-webkit (to allow future sharing with other build-* scripts)
1128
1129         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
1130         picking through ARGV with a blacklist of what arguments weren't jsDriver args
1131         this makes run-javascriptcore-tests transparently support all arguments which
1132         webkitdirs.pm gives it support for.
1133
1134         Make run-javascriptcore-tests actually print what commands it's running before running them.
1135
1136         Add --help support to build-jsc and run-javascriptcore-tests!
1137
1138         Make code to support --svg-experimental defaults take up half as many lines.
1139
1140         * Scripts/build-jsc:
1141         * Scripts/build-webkit:
1142         * Scripts/run-javascriptcore-tests:
1143         * Scripts/webkitdirs.pm:
1144
1145 2008-12-03  Adam Roben  <aroben@apple.com>
1146
1147         Fix a leak in WinLauncher shutdown
1148
1149         Reviewed by Sam Weinig.
1150
1151         * WinLauncher/WinLauncher.cpp:
1152         (_tWinMain): Replaced a delete with a Release. We can't delete the
1153         WebView properly since we only have a pointer to one of its
1154         interfaces. We also shouldn't be deleting COM objects directly anyway,
1155         for a number of reasons.
1156
1157 2008-12-03  Adam Roben  <aroben@apple.com>
1158
1159         Fix a crash on exit in WinLauncher
1160
1161         Reviewed by Sam Weinig.
1162
1163         * WinLauncher/WinLauncher.cpp:
1164         (_tWinMain): Call shutDownWebKit before exiting.
1165
1166 2008-12-03  Adam Roben  <aroben@apple.com>
1167
1168         Add a Debug_Internal configuration to WinLauncher
1169
1170         This matches our other projects.
1171
1172         Reviewed by Sam Weinig.
1173
1174         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
1175         configuration, which is identical to Debug except that it also
1176         references debug_internal.vsprops. Also removed some settings that we
1177         should be picking up from the .vsprops files.
1178
1179 2008-12-02  Eric Seidel  <eric@webkit.org>
1180
1181         Reviewed by David Kilzer.
1182
1183         Hack build-webkit --chromium to use Win32 python instead
1184         of using the default cygwin python.  Scons + CYGWIN tries
1185         to build with GCC by default, we force MSVC in our file
1186         but that just results in errors from Scons.  Until we can fix
1187         this latest round of errors, at least make build-webkit --chromium
1188         actually "work" under CYGWIN instead of forcing users to use
1189         a cmd shell directly.
1190
1191         This is working around a Scons bug:
1192         http://scons.tigris.org/issues/show_bug.cgi?id=2266
1193
1194         * Scripts/webkitdirs.pm:
1195
1196 2008-12-01  David Kilzer  <ddkilzer@apple.com>
1197
1198         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
1199
1200         <https://bugs.webkit.org/show_bug.cgi?id=22466>
1201         <rdar://problem/6403593>
1202
1203         Reviewed by Brady Eidson.
1204
1205         * DumpRenderTree/mac/DumpRenderTree.mm:
1206         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
1207         Keep-Alive, Last-Modified and Server header fields to prevent false
1208         positive test failures.
1209         (convertWebResourceResponseToDictionary): Call
1210         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
1211         header fields.
1212
1213 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
1214
1215         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
1216
1217         <https://bugs.webkit.org/show_bug.cgi?id=22559>
1218
1219         Reviewed by Adam Roben.
1220
1221         * Scripts/bisect-builds: Updated status message to report the
1222         maximum number of builds left to test after the current one.
1223         (max): Added.
1224
1225 2008-11-27  Alp Toker  <alp@nuanti.com>
1226
1227         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
1228         API header breakage at build time.
1229
1230         * GNUmakefile.am:
1231
1232 2008-11-26  Eric Seidel  <eric@webkit.org>
1233
1234         Reviewed by Nikolas Zimmermann and Mark Rowe.
1235
1236         Add support for build-webkit --chromium
1237         https://bugs.webkit.org/show_bug.cgi?id=22515
1238         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
1239
1240         * Scripts/build-dumprendertree:
1241         * Scripts/build-jsc:
1242         * Scripts/build-webkit:
1243         * Scripts/gdb-safari:
1244         * Scripts/run-webkit-tests:
1245         * Scripts/webkitdirs.pm:
1246
1247 2008-11-26  Eric Seidel  <eric@webkit.org>
1248
1249         Reviewed by Nikolas Zimmermann.
1250
1251         Add support for build-webkit --chromium (tested on mac)
1252         https://bugs.webkit.org/show_bug.cgi?id=22515
1253         Also simplified some code using checkArgv
1254
1255         * Scripts/build-webkit:
1256         * Scripts/webkitdirs.pm:
1257
1258 2008-11-26  Eric Seidel  <eric@webkit.org>
1259
1260         Reviewed by Nikolas Zimmermann.
1261
1262         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
1263         https://bugs.webkit.org/show_bug.cgi?id=22515
1264         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
1265         in preparation for having a chromium cygwin and chromium mac build
1266
1267         * Scripts/build-webkit:
1268         * Scripts/webkitdirs.pm:
1269
1270 2008-11-26  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Nikolas Zimmermann.
1273
1274         Pre-work for getting build-webkit --chromium to work
1275         https://bugs.webkit.org/show_bug.cgi?id=22515
1276         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
1277
1278         * Scripts/build-dumprendertree:
1279         * Scripts/build-jsc:
1280         * Scripts/build-webkit:
1281         * Scripts/gdb-safari:
1282         * Scripts/run-javascriptcore-tests:
1283         * Scripts/run-webkit-tests:
1284         * Scripts/webkitdirs.pm:
1285
1286 2008-11-26  David Kilzer  <ddkilzer@apple.com>
1287
1288         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
1289
1290         <https://bugs.webkit.org/show_bug.cgi?id=22488>
1291
1292         Reviewed by Brady Eidson.
1293
1294         * DumpRenderTree/mac/DumpRenderTree.mm:
1295         (convertWebResourceDataToString): If an IANA charset encoding string
1296         is provided, convert it to a CFStringEncoding value and then to an
1297         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
1298         also nil-check dataAsString, so the worst-case scenario is that the
1299         data won't be decoded to a string (versus crashing DumpRenderTree).
1300
1301 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
1302
1303         Reviewed by Holger Freyther.
1304
1305         [Gtk] add/remove tests from Skipped and fix netscape plugin test
1306         https://bugs.webkit.org/show_bug.cgi?id=22484
1307
1308         Remove print'ing to stderr
1309
1310         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1311         (NP_Initialize):
1312         (NP_Shutdown):
1313
1314 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
1315
1316         Windows build fix.
1317
1318         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1319
1320 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
1321
1322         Windows build fix.
1323
1324         * DumpRenderTree/cg/ImageDiffCG.cpp:
1325
1326 2008-11-24  Darin Fisher  <darin@chromium.org>
1327
1328         Fix bustage.
1329
1330         https://bugs.webkit.org/show_bug.cgi?id=15643
1331
1332         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1333         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1334
1335 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
1336
1337         Reviewed by Alexey Proskuryakov.
1338
1339         http://bugs.webkit.org/show_bug.cgi?id=15643
1340
1341         Added support for changing the "trailing whitespace" work-around
1342         in LayoutTestController (so layout tests can verify this functionality)
1343
1344         * DumpRenderTree/LayoutTestController.cpp:
1345         (setSelectTrailingWhitespaceEnabledCallback):
1346         (LayoutTestController::staticFunctions):
1347         * DumpRenderTree/LayoutTestController.h:
1348         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1349         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1350         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1351         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
1352
1353 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
1354
1355         Reviewed by Darin Adler
1356
1357         https://bugs.webkit.org/show_bug.cgi?id=22433
1358
1359         Add script that attempts to detect virtual methods
1360         whose signatures differ only by constness (which can
1361         indicate a programming error).
1362
1363         * Scripts/detect-mismatched-virtual-const: Added.
1364
1365 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
1366
1367         Reviewed by Holger Freyther.
1368
1369         https://bugs.webkit.org/show_bug.cgi?id=22039
1370
1371         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
1372         build.
1373
1374         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1375         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1376         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1377         (setDefaultsToConsistentStateValuesForTesting):
1378         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
1379         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
1380         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
1381         * GNUmakefile.am:
1382
1383 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
1384
1385         Reviewed by Mark Rowe.
1386
1387         [Gtk+] Add configure option to enable Web Workers and enable it by default
1388
1389         Add --enable-workers to the buildsystem (used by build-webkit) add
1390         the to be build files to the GNUmakefile.am and change build-webkit
1391         to enable Web Workers by default.
1392
1393         * Scripts/build-webkit:
1394
1395 2008-11-24  Mark Rowe  <mrowe@apple.com>
1396
1397         Reviewed by Alexey Proskuryakov.
1398
1399         Let gdb-safari accept the --debug and --release options once more.
1400
1401         * Scripts/gdb-safari:
1402
1403 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
1404
1405         Reviewed by Holger Freyther. Landed by Jan Alonzo.
1406
1407         Get SVG tests tested on GTK port.
1408
1409         * Scripts/webkitdirs.pm:
1410
1411 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
1412
1413         Reviewed by Darin Adler.
1414
1415         https://bugs.webkit.org/show_bug.cgi?id=21810
1416         Remove use of static C++ objects that are destroyed at exit time (destructors)
1417
1418         All static C++ objects that create atexit calls are gone. Update script
1419         to indicate how to fix the problem should a new one appear.
1420
1421         * Scripts/check-for-exit-time-destructors:
1422
1423 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
1424
1425         Reviewed by Darin Adler.
1426
1427         https://bugs.webkit.org/show_bug.cgi?id=22337
1428         Enable workers by default
1429
1430         * Scripts/build-webkit: Changed the default to enabled.
1431
1432 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
1433
1434         Rubber-stamped by Darin Adler.
1435
1436         https://bugs.webkit.org/show_bug.cgi?id=22306
1437         Disable channel messaging support
1438
1439         * Scripts/build-webkit: Add an option to enable channel messaging.
1440
1441 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1442
1443         Reviewed by George Staikos.
1444
1445         Add --(no-)wml build flags.
1446
1447         * Scripts/build-webkit:
1448         * Scripts/run-webkit-tests:
1449         * Scripts/webkitdirs.pm:
1450
1451 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
1452
1453         Not reviewed.
1454
1455         Try to fix gtk build.
1456
1457         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1458         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1459         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1460
1461 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
1462
1463         Reviewed by Maciej.
1464
1465         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
1466         on Tiger.
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=22271
1469
1470         * Scripts/run-webkit-tests:
1471
1472 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
1473
1474         Reviewed by Sam Weinig.
1475
1476         Added new JavaScript API on LayoutController to pause a running
1477         CSS transition or animation at a given time.
1478
1479         https://bugs.webkit.org/show_bug.cgi?id=21261
1480
1481         * DumpRenderTree/LayoutTestController.cpp:
1482         (pauseAnimationAtTimeOnElementWithIdCallback):
1483         (pauseTransitionAtTimeOnElementWithIdCallback):
1484         (LayoutTestController::staticFunctions):
1485         * DumpRenderTree/LayoutTestController.h:
1486         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1487         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1488         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1489         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1490         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1491         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1492
1493 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
1494
1495         Reviewed by Darin Adler.
1496
1497         <https://bugs.webkit.org/show_bug.cgi?id=22309>
1498         Pass the remaining options to build system on Qt-port
1499
1500         * Scripts/build-webkit:
1501         * Scripts/webkitdirs.pm:
1502
1503 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
1504
1505         Reviewed by Darin Adler.
1506
1507         https://bugs.webkit.org/show_bug.cgi?id=21810
1508         Remove use of static C++ objects that are destroyed at exit time (destructors)
1509
1510         Remove .o files from the exclude list that have had their exit-time destructors removed.
1511         Handle case when there is no current symbol.
1512
1513         * Scripts/check-for-exit-time-destructors:
1514
1515 2008-11-16  Sam Weinig  <sam@webkit.org>
1516
1517         * Scripts/do-webcore-rename: Remove now fixed renames.
1518
1519 2008-11-16  Darin Adler  <darin@apple.com>
1520
1521         * Scripts/do-webcore-rename: Plan some future renames.
1522
1523 2008-11-15  Darin Adler  <darin@apple.com>
1524
1525         Rubber stamped by Geoff Garen.
1526
1527         - do the long-planned StructureID -> Structure rename
1528
1529         * Scripts/check-for-global-initializers: Update name of StructureID.o.
1530         * Scripts/do-webcore-rename: Renaming script that I used.
1531
1532 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
1533
1534         Reviewed by Darin Adler.
1535
1536         https://bugs.webkit.org/show_bug.cgi?id=21810
1537         Remove use of static C++ objects that are destroyed at exit time (destructors)
1538
1539         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
1540         exit-time destructor. Update code that was changed to fix this issue that ran
1541         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
1542         in gcc build 5465). Also typdefs for template types needed to be added in some
1543         cases so the type could make it through the macro successfully.
1544
1545         Basically code of the form:
1546         static T m;
1547         becomes:
1548         DEFINE_STATIC_LOCAL(T, m, ());
1549
1550         Also any code of the form:
1551         static T& m = *new T;
1552         also becomes:
1553         DEFINE_STATIC_LOCAL(T, m, ());
1554
1555         Remove .o files from the exclude list that have had their exit-time destructors removed.
1556
1557         * Scripts/check-for-exit-time-destructors:
1558
1559 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
1560
1561         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
1562
1563         * wx/install-unix-extras:
1564
1565 2008-11-14  Alp Toker  <alp@nuanti.com>
1566
1567         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
1568
1569         Fixes Debian bug #505723
1570         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
1571
1572         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1573
1574 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
1575
1576         Reviewed by Simon Hausmann.
1577
1578         Fix hanging DRT with Qt.
1579
1580         https://bugs.webkit.org/show_bug.cgi?id=22209
1581
1582         * DumpRenderTree/qt/DumpRenderTree.cpp:
1583         (WebCore::DumpRenderTree::dump):
1584         Send empty pixel test data 'block', which is now
1585         expected by run-layout-tests.
1586
1587 2008-11-12  Dmitry Titov  <dimich@chromium.org>
1588
1589         Reviewed by Alexey Proskuryakov.
1590
1591         https://bugs.webkit.org/show_bug.cgi?id=22216
1592
1593         * Scripts/build-webkit:
1594         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
1595
1596 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1597
1598         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
1599
1600         Apparently older versions of gcc have issues with this patch.
1601         Backing out a second time until the issues are resolved.
1602
1603 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1604
1605         BUILD WAS NOT BROKEN: Rolling r38189 back in.
1606
1607         Please perform a clean build if you see crashes.
1608
1609 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1610
1611         BUILD FIX: Backed out r38189 since it apparently broke the world.
1612
1613 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
1614
1615         Reviewed by Beth Dakin.
1616
1617         Add ability to query an attribute's settable status and the
1618         ability to retrieve a single attribute from an AXObject
1619
1620         * DumpRenderTree/AccessibilityUIElement.cpp:
1621         (isAttributeSettableCallback):
1622         (attributeValueCallback):
1623         (AccessibilityUIElement::getJSClass):
1624         * DumpRenderTree/AccessibilityUIElement.h:
1625         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1626         (+[NSString stringWithJSStringRef:]):
1627         (AccessibilityUIElement::attributeValue):
1628         (AccessibilityUIElement::isAttributeSettable):
1629         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1630         (AccessibilityUIElement::attributeValue):
1631         (AccessibilityUIElement::isAttributeSettable):
1632
1633 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
1634
1635         Reviewed by Darin Adler.
1636
1637         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
1638         https://bugs.webkit.org/show_bug.cgi?id=21810
1639
1640         Remove .o files from the exclude list that have had their exit-time destructors removed.
1641
1642         * Scripts/check-for-exit-time-destructors:
1643
1644 2008-11-05  Alp Toker  <alp@nuanti.com>
1645
1646         GTK build script tweak.
1647
1648         Make the path relative since it will appear in all -I compiler flags.
1649         Long argument lists cause bizarre slowdowns in libtool and result
1650         in huge build logs.
1651
1652         * Scripts/webkitdirs.pm:
1653
1654 2008-11-05  Anders Carlsson  <andersca@apple.com>
1655
1656         Fix 64-bit build.
1657
1658         * DumpRenderTree/mac/DumpRenderTree.mm:
1659         (setDefaultsToConsistentValuesForTesting):
1660
1661 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
1662
1663         Add AccessibilityObject.o to the exclude list for the
1664         check for global destructors.
1665
1666         * Scripts/check-for-exit-time-destructors:
1667
1668 2008-11-04  Darin Adler  <darin@apple.com>
1669
1670         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
1671         bot, but for some reason not on my computer.
1672
1673 2008-11-03  Darin Adler  <darin@apple.com>
1674
1675         Reviewed by Tim Hatcher.
1676
1677         - https://bugs.webkit.org/show_bug.cgi?id=22061
1678           create script to check for exit-time destructors
1679
1680         * Scripts/check-for-exit-time-destructors: Added.
1681         Started as a copy of check-for-global-initializers.
1682
1683         * Scripts/check-for-global-initializers: Added code to make
1684         this script rerun any time it's modified, and also to properly
1685         run again after the first time it reports an error.
1686
1687 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
1688
1689         Reviewed by Dan Bernstein.
1690
1691         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
1692
1693         https://bugs.webkit.org/show_bug.cgi?id=22054
1694
1695         * DumpRenderTree/mac/DumpRenderTree.mm:
1696         (setDefaultsToConsistentValuesForTesting):
1697
1698 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
1699
1700         Not reviewed.
1701
1702         * Scripts/do-webcore-rename:
1703
1704         Add some renames to contemplate for the future.
1705
1706 2008-10-31  Darin Adler  <darin@apple.com>
1707
1708         Requested by Mark Rowe.
1709
1710         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
1711
1712 2008-10-31  David Kilzer  <ddkilzer@apple.com>
1713
1714         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
1715
1716         <https://bugs.webkit.org/show_bug.cgi?id=21997>
1717
1718         Reviewed by Darin Adler.
1719
1720         * Scripts/prepare-ChangeLog:
1721         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
1722         This prevents them from showing up in the new ChangeLog entry.  They
1723         were already excluded from @{$changedFiles}.
1724
1725 2008-10-30  Mark Rowe  <mrowe@apple.com>
1726
1727         Reviewed by Jon Homeycutt.
1728
1729         Explicitly default to building for only the native architecture in debug and release builds.
1730
1731         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1732
1733 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
1734
1735         Reviewed by Dan Bernstein.
1736
1737         Fixed 64 bit build failure.
1738
1739         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1740         (setupMainDisplayColorProfile):
1741         (createBitmapContextFromWebView):
1742
1743 2008-10-28  Alp Toker  <alp@nuanti.com>
1744
1745         Fix GTK DRT following build breakage in r37928.
1746
1747         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1748         (dump):
1749         (runTest):
1750         (main):
1751
1752 2008-10-28  Alp Toker  <alp@nuanti.com>
1753
1754         Reviewed by Mark Rowe.
1755
1756         Fix recently introduced double-free crashes in GTK DRT.
1757
1758         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
1759         were updated to call ->deref() but GTK DRT was still deleting
1760         gLayoutTestController manually. This patch updates GTK to match the
1761         other ports and resolves the memory allocation issues.
1762
1763         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1764         (runTest):
1765
1766 2008-10-28  Alp Toker  <alp@nuanti.com>
1767
1768         Reviewed by Mark Rowe.
1769
1770         Fix GTK DRT hang when running the tests.
1771
1772         Update output from the DRT tool to print an additional '#EOF' to match
1773         breaking changes that were made in r37434.
1774
1775         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1776         (dump):
1777
1778 2008-10-28  Adele Peterson  <adele@apple.com>
1779
1780         Reviewed by Sam Weinig.
1781
1782         Specify which Localizable.strings to update since we don't always want to update the file in the same
1783         directory where we're searching for the strings to localize.
1784
1785         * Scripts/extract-localizable-strings:
1786         * Scripts/update-webkit-localizable-strings:
1787
1788 2008-10-28  Timothy Hatcher  <timothy@apple.com>
1789
1790         Add support for enabling the profiler, so the profiling tests can continue
1791         work now that the profiler is not always enabled.
1792
1793         https://bugs.webkit.org/show_bug.cgi?id=21927
1794
1795         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
1796         not slow down JavaScript all the time
1797
1798         Reviewed by Darin Adler and Kevin McCullough.
1799
1800         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
1801         * DumpRenderTree/LayoutTestController.cpp:
1802         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
1803         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
1804         * DumpRenderTree/LayoutTestController.h:
1805         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1806         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
1807         * DumpRenderTree/mac/DumpRenderTree.mm:
1808         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
1809         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1810         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
1811         * DumpRenderTree/win/DumpRenderTree.cpp:
1812         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
1813         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1814         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
1815
1816 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
1817
1818         Reviewed by Dan Bernstein
1819
1820         Primary changes in DumpRenderTree:
1821         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
1822         is different from regular font CG anti-aliasing) as font-smoothing settings
1823         depends on the display and can also be changed by the user
1824         - Use a new cleared buffer for each test instead of the reusing same one to
1825         avoid potential result corruption across tests
1826         - Can now receive the expected pixel hash as a suffix to the test path or
1827         url as "path'hash"
1828         - Make sure hash is computed in a endian-independent way
1829         - Improve the code that sets/restores the screen color profile
1830         - Make the code more cross-platformy with std::string goodness
1831         - Added an "on-screen" mode where the snapshot will take into account surfaces
1832         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
1833         reading from the display framebuffer on 10.4. This mode is not active by
1834         default for performance reason, but must be explicitly activated from the test
1835         file using the new "testOnscreen()" JS API.
1836
1837         Primary changes in ImageDiff:
1838         - Provide a new comparison algorithm that is more tolerant to "acceptable"
1839         failures (i.e. very small differences in font rendering, which --threshold is
1840         not really good at handling)
1841         - Generate normalized intensity-only diff images
1842
1843         Primary changes in run-webkit-tests:
1844         - Take advantage of hashes for pixel tests which makes them much faster by
1845         minimizing image comparisons
1846         - Removed repaint options as these should be set from within test files using
1847         JS API
1848         - Replaced "threshold" option in  by "tolerance" expressed in percents
1849         - Added more logging when in "verbose" mode
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=21322
1852         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1853         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
1854         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
1855         * DumpRenderTree/LayoutTestController.cpp:
1856         (LayoutTestController::LayoutTestController):
1857         (testOnscreenCallback):
1858         (LayoutTestController::staticFunctions):
1859         * DumpRenderTree/LayoutTestController.h:
1860         (LayoutTestController::testOnscreen):
1861         (LayoutTestController::setTestOnscreen):
1862         (LayoutTestController::testPathOrURL):
1863         (LayoutTestController::expectedPixelHash):
1864         * DumpRenderTree/PixelDumpSupport.h:
1865         * DumpRenderTree/cg/ImageDiffCG.cpp:
1866         (strtof):
1867         (releaseMallocBuffer):
1868         (createDifferenceImage):
1869         (imageHasAlpha):
1870         (main):
1871         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1872         (computeMD5HashStringForBitmapContext):
1873         (dumpWebViewAsPixelsAndCompareWithExpected):
1874         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1875         (BitmapContext::createByAdoptingBitmapAndContext):
1876         (BitmapContext::~BitmapContext):
1877         (BitmapContext::cgContext):
1878         (BitmapContext::BitmapContext):
1879         * DumpRenderTree/mac/DumpRenderTree.mm:
1880         (shouldIgnoreWebCoreNodeLeaks):
1881         (setDefaultsToConsistentValuesForTesting):
1882         (crashHandler):
1883         (initializeGlobalsFromCommandLineOptions):
1884         (prepareConsistentTestingEnvironment):
1885         (dumpRenderTree):
1886         (sizeWebViewForCurrentTest):
1887         (dump):
1888         (runTest):
1889         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1890         (restoreMainDisplayColorProfile):
1891         (setupMainDisplayColorProfile):
1892         (createBitmapContextFromWebView):
1893         * DumpRenderTree/win/DumpRenderTree.cpp:
1894         (dump):
1895         (runTest):
1896         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1897         (getBitmapContextFromWebView):
1898         * Scripts/run-webkit-tests:
1899
1900 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
1901
1902         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
1903
1904         * wx/build-wxwebkit:
1905
1906 2008-10-24  Anders Carlsson  <andersca@apple.com>
1907
1908         Try fixing the 64-bit build.
1909
1910         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1911         (testGetProperty):
1912
1913 2008-10-24  Anders Carlsson  <andersca@apple.com>
1914
1915         Reviewed by Sam Weinig.
1916
1917         <rdar://problem/5440917> Support NPN_Construct
1918
1919         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1920         (testCallback):
1921         Fix a memory leak.
1922
1923         (testConstruct):
1924         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
1925
1926         (pluginInvoke):
1927         Handle testConstruct.
1928
1929         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1930         (testGetProperty):
1931         Add objectPointer property.
1932
1933         (testEnumerate):
1934         Only enumerate the two first properties.
1935
1936         (testConstruct):
1937         Add a simple construct implementation that just returns the test object.
1938
1939 2008-10-24  David Kilzer  <ddkilzer@apple.com>
1940
1941         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
1942
1943         <https://bugs.webkit.org/show_bug.cgi?id=21850>
1944
1945         Reviewed by Adam Roben.
1946
1947         * Scripts/svn-apply: Save end-of-line characters when stripping them
1948         off each line of a patch so that they may be restored after
1949         processing the line.
1950         * Scripts/svn-unapply: Ditto.
1951
1952 2008-10-23  David Kilzer  <ddkilzer@apple.com>
1953
1954         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
1955
1956         <https://bugs.webkit.org/show_bug.cgi?id=21832>
1957
1958         Reviewed by Sam Weinig.
1959
1960         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
1961         instead of 'new File::Temp' to make the script work with Perl 5.10.
1962         * Scripts/sort-Xcode-project-file: Ditto.
1963
1964 2008-10-22  Brady Eidson  <beidson@apple.com>
1965
1966         Reviewed by Adam Roben
1967
1968         <rdar://6261773> - autocomplete="off" doesn't work on Windows
1969
1970         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
1971
1972         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1973
1974 2008-10-22  Darin Adler  <darin@apple.com>
1975
1976         * Scripts/do-webcore-rename: More renaming plans.
1977
1978 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
1979
1980         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
1981
1982         * Scripts/extract-localizable-strings:
1983
1984 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1985
1986         Reviewed by Mark Rowe.
1987
1988         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
1989         excess different stack logs.
1990
1991         (Also fix a small bug in my last change.)
1992
1993         * Scripts/run-webkit-tests:
1994
1995 2008-10-17  Stephanie Lewis  <slewis@apple.com>
1996
1997         Reviewed by Mark Rowe.
1998
1999         Fix layout tests that use prologues and epilogues.
2000
2001         * Scripts/run-webkit-tests:
2002
2003 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2004
2005         Reviewed by Mark Rowe.
2006
2007         - make sure MallocStackLogging is only on for tools we want to
2008         leak check, not other random stuff as well.
2009
2010         * Scripts/run-webkit-tests:
2011
2012 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2013
2014         Reviewed by Stephanie Lewis.
2015
2016         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
2017
2018         This should reduce or eliminate crashes on the buildbot due to
2019         running out of memory while stack logging.
2020
2021         * Scripts/run-webkit-tests:
2022
2023 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
2024
2025         Gtk build fix. Not reviewed.
2026
2027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2028         (LayoutTestController::setSmartInsertDeleteEnabled):
2029
2030 2008-10-15  Glenn Wilson  <gwilson@google.com>
2031
2032         Added new method to allow tests to disable smart editing in the course of a test.
2033         This is a possible solution to bug .20655
2034
2035         Reviewed by Tim Hatcher.
2036
2037         * DumpRenderTree/LayoutTestController.cpp:
2038         (setSmartInsertDeleteEnabledCallback): new method
2039         (LayoutTestController::staticFunctions): added new method to static list of callbacks
2040         * DumpRenderTree/LayoutTestController.h: added signature of new method
2041         * DumpRenderTree/mac/DumpRenderTree.mm:
2042         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2043         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2044         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2045         * DumpRenderTree/win/DumpRenderTree.cpp:
2046         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2047         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2048         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2049
2050 2008-10-14  Ada Chan  <adachan@apple.com>
2051
2052         Fix windows build.
2053
2054         Reviewed by Sam Weinig.
2055
2056         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2057         * DumpRenderTree/config.h:
2058         * DumpRenderTree/win/DumpRenderTreeWin.h:
2059         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2060         * DumpRenderTree/win/UIDelegate.cpp:
2061
2062 2008-10-13  Timothy Hatcher  <timothy@apple.com>
2063
2064         Make prepare-ChangeLog populate the changed functions for JavaScript files.
2065
2066         https://bugs.webkit.org/show_bug.cgi?id=21567
2067
2068         Reviewed by David Kilzer.
2069
2070         * Scripts/prepare-ChangeLog:
2071         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
2072         files that end with ".js".
2073         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
2074         and getters/setters.
2075
2076 2008-10-14  Alp Toker  <alp@nuanti.com>
2077
2078         Reviewed by Sam Weinig.
2079
2080         https://bugs.webkit.org/show_bug.cgi?id=16299
2081         Add a config.h file to DRT
2082
2083         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
2084         an ad-hoc config header.
2085
2086         * DumpRenderTree/AccessibilityController.cpp:
2087         * DumpRenderTree/AccessibilityUIElement.cpp:
2088         * DumpRenderTree/AccessibilityUIElement.h:
2089         * DumpRenderTree/DumpRenderTree.h:
2090         * DumpRenderTree/GCController.cpp:
2091         * DumpRenderTree/LayoutTestController.cpp:
2092         * DumpRenderTree/WorkQueue.cpp:
2093         * DumpRenderTree/config.h: Added.
2094         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2095         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2096         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2097         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2098         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2099         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2100         * DumpRenderTree/win/DumpRenderTree.cpp:
2101         * DumpRenderTree/win/DumpRenderTreeWin.h:
2102         * DumpRenderTree/win/EditingDelegate.cpp:
2103         * DumpRenderTree/win/EventSender.cpp:
2104         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2105         * DumpRenderTree/win/GCControllerWin.cpp:
2106         * DumpRenderTree/win/MD5.cpp:
2107         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2108         * DumpRenderTree/win/PolicyDelegate.cpp:
2109         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2110         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2111         * GNUmakefile.am:
2112
2113 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
2114
2115         Reviewed by Beth Dakin.
2116
2117         Added a method to get the links in a webpage
2118
2119         * DumpRenderTree/AccessibilityUIElement.cpp:
2120         (attributesOfDocumentLinksCallback):
2121         (AccessibilityUIElement::getJSClass):
2122         * DumpRenderTree/AccessibilityUIElement.h:
2123         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2124         (AccessibilityUIElement::getDocumentLinks):
2125         (AccessibilityUIElement::attributesOfDocumentLinks):
2126         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2127         (AccessibilityUIElement::getDocumentLinks):
2128         (AccessibilityUIElement::attributesOfDocumentLinks):
2129
2130 2008-10-13  David Kilzer  <ddkilzer@apple.com>
2131
2132         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
2133
2134         <https://bugs.webkit.org/show_bug.cgi?id=21457>
2135
2136         Reviewed by Adam.
2137
2138         * Scripts/resolve-ChangeLogs: Added optional parameter to
2139         -f|--fix-merged switch to run the script on a revision range.
2140         Updated command-line validation checks.
2141         (findChangeLog): Fixed long-standing bug that should have used
2142         $_[0] instead of $_.
2143         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
2144         to work when called from git filter-branch.  It always restores a
2145         copy of the previous revision before reapplying the patch.
2146         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
2147         to re-merge ChangeLog files across a revision range.  Removes
2148         .git/refs/original directory on success.
2149         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
2150         switch.
2151         (removeChangeLogArguments): Added.  Removes items from @ARGV when
2152         they are ChangeLog paths, and return a list of paths.  This makes it
2153         easier to validate the command-line.
2154         (resolveChangeLog): Added.  Extracted from main code block.  Runs
2155         the traditional single-file merge algorithm.
2156         (usageAndExit): Added.  Extracted from main code block.  Prints
2157         usage statement and exits with error status.
2158
2159 2008-10-12  Darin Adler  <darin@apple.com>
2160
2161         * Scripts/make-js-test-wrappers: Update exceptions list so the script
2162         won't overwrite files and mangle tests.
2163
2164 2008-10-11  Dan Bernstein  <mitz@apple.com>
2165
2166         Reviewed by Sam Weinig and Anders Carlsson.
2167
2168         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
2169           complex text code path
2170         - add --complex-text support to Windows DumpRenderTree
2171
2172         * DumpRenderTree/mac/DumpRenderTree.mm:
2173         (dumpRenderTree):
2174         * DumpRenderTree/win/DumpRenderTree.cpp:
2175         (createWebViewAndOffscreenWindow):
2176         (main):
2177         * Scripts/run-webkit-tests:
2178
2179 2008-10-09  Eric Seidel  <eric@webkit.org>
2180
2181         Reviewed by Oliver Hunt.
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=21498
2184
2185         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
2186
2187 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
2188
2189         Not reviewed.
2190
2191         Add StructureID.o to the exclusion list in the global initializers
2192         script to fix the Debug build.
2193
2194         * Scripts/check-for-global-initializers:
2195
2196 2008-10-08  Mark Rowe  <mrowe@apple.com>
2197
2198         Fix the Windows build after r37434.
2199
2200         * DumpRenderTree/win/DumpRenderTree.cpp:
2201         (dump): Update code to approximate valid C++ syntax.
2202
2203 2008-10-08  Timothy Hatcher  <timothy@apple.com>
2204
2205         Add SVGElementInstance to the list of exceptions that have
2206         global initializers in debug builds.
2207
2208         Rubber-stamped by Mark Rowe.
2209
2210         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
2211
2212 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
2213
2214         Reviewed by Dan Bernstein
2215
2216         Avoid disconnect between DRT and run-webkit-tests
2217         about whether to expect PNG dumps by having DRT always
2218         print two blocks terminated by #EOF, the second of which
2219         may be empty.
2220
2221         https://bugs.webkit.org/show_bug.cgi?id=21483
2222
2223         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2224         (printPNG):
2225         (dumpWebViewAsPixelsAndCompareWithExpected):
2226         * DumpRenderTree/mac/DumpRenderTree.mm:
2227         (dump):
2228         * DumpRenderTree/win/DumpRenderTree.cpp:
2229         (dump):
2230         * Scripts/run-webkit-tests:
2231
2232 2008-10-07  Adam Roben  <aroben@apple.com>
2233
2234         Make sure short functions get included in ChangeLog output for git
2235         repositories
2236
2237         Reviewed by Dave Kilzer.
2238
2239         * Scripts/prepare-ChangeLog:
2240         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
2241         will get its own chunk without any surrounding context.
2242         (sub extractLineRange): Use the line numbers from the chunk header
2243         without modifying them now that they're accurate.
2244
2245 2008-10-04  Mark Rowe  <mrowe@apple.com>
2246
2247         Reviewed by Tim Hatcher.
2248
2249         Update check-for-weak-vtables to check only the final linked image for weak vtables.
2250         This gives more useful results than checking each object file independently.
2251
2252         * Scripts/check-for-weak-vtables:
2253
2254 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
2255
2256         Reviewed by Darin Adler
2257
2258         Render images to RGBA8 bitmaps independently of platform endianness.
2259
2260         Create image difference bitmap in reference image colorspace instead of device colorspace
2261         (which depends on the main display profile), so that no color matching happens.
2262
2263         https://bugs.webkit.org/show_bug.cgi?id=21336
2264
2265         * DumpRenderTree/cg/ImageDiffCG.cpp:
2266         (createDifferenceBitmap):
2267         (computePercentageDifferent):
2268         (compareImages):
2269
2270 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
2271
2272         Reviewed by Darin Adler
2273
2274         Fix hang when running with --pixel --reset, which occurs
2275         because DRT spews PNG data when the script does not expect it.
2276
2277         https://bugs.webkit.org/show_bug.cgi?id=21323
2278
2279         * Scripts/run-webkit-tests:
2280
2281 2008-09-30  Mark Rowe  <mrowe@apple.com>
2282
2283         Reviewed by Dan Bernstein.
2284
2285         Add a leak counter for CachedResources since we've had two recent leaks involving them.
2286
2287         * Scripts/check-for-global-initializers:
2288
2289 2008-09-30  Mark Rowe  <mrowe@apple.com>
2290
2291         Rubber-stamped by Dan Bernstein.
2292
2293         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
2294
2295         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
2296         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
2297         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
2298         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
2299         torn down before we exit.
2300
2301         * DumpRenderTree/mac/DumpRenderTree.mm:
2302         (dumpRenderTree):
2303         (main):
2304
2305 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
2306
2307         Reviewed by Dan Bernstein
2308
2309         Don't run pixel comparison for text-only tests.
2310         https://bugs.webkit.org/show_bug.cgi?id=21124
2311
2312         * DumpRenderTree/mac/DumpRenderTree.mm:
2313         (dump):
2314         * Scripts/run-webkit-tests:
2315
2316 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
2317
2318         Reviewed by Simon.
2319
2320         Changed copyright from Trolltech ASA to Nokia.
2321
2322         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
2323
2324
2325         * DumpRenderTree/qt/DumpRenderTree.cpp:
2326         * DumpRenderTree/qt/jsobjects.cpp:
2327         * DumpRenderTree/qt/jsobjects.h:
2328         * DumpRenderTree/qt/main.cpp:
2329         * DumpRenderTree/qt/testplugin.cpp:
2330         * DumpRenderTree/qt/testplugin.h:
2331
2332 2008-09-28  David Kilzer  <ddkilzer@apple.com>
2333
2334         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
2335
2336         <https://bugs.webkit.org/show_bug.cgi?id=21185>
2337
2338         Reviewed by Adam.
2339
2340         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
2341         will attempt to reapply the last commit to a ChangeLog file such
2342         that the ChangeLog entry appears at the top of the file.
2343         (findChangeLog): Added prototype and moved method below the exit
2344         statement.
2345         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
2346         ChangeLog entries.
2347
2348 2008-09-27  Anders Carlsson  <andersca@apple.com>
2349
2350         Reviewed by Sam Weinig.
2351
2352         https://bugs.webkit.org/show_bug.cgi?id=21178
2353         <rdar://problem/6248651>
2354
2355         Return the result value from getURL.
2356
2357         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2358         (getURL):
2359
2360 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
2361
2362         Reviewed by Tim Hatcher.
2363
2364         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
2365
2366         * Scripts/build-webkit:
2367
2368 2008-09-26  Alice Liu  <alice.liu@apple.com>
2369
2370         Remove usage of atlstr.h and CString for VCExpress compatibility
2371
2372         Reviewed by Stephanie Lewis.
2373
2374         * record-memory-win/main.cpp:
2375         (ProcessArgs):
2376         (UseImage):
2377         (QueryContinuously):
2378         (OneQuery):
2379         (OneQueryMP):
2380
2381 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
2382
2383         wx build fix. Update the version of libpng.
2384
2385         * wx/install-unix-extras:
2386
2387 2008-09-24  Sam Weinig  <sam@webkit.org>
2388
2389         Reviewed by Darin Adler.
2390
2391         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
2392         <rdar://problem/6243534>
2393         Crash below Function.apply when using a runtime array as the argument list
2394
2395         Add method to ObjCController to return a runtime array.
2396
2397         * DumpRenderTree/mac/ObjCController.m:
2398         (+[ObjCController isSelectorExcludedFromWebScript:]):
2399         (+[ObjCController webScriptNameForSelector:]):
2400         (-[ObjCController testArray]):
2401
2402 2008-09-24  Beth Dakin  <bdakin@apple.com>
2403
2404         Reviewed by Sam Weinig.
2405
2406         Speculative build fix.
2407
2408         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2409         (AccessibilityUIElement::supportsPressAction):
2410
2411 2008-09-23  Beth Dakin  <bdakin@apple.com>
2412
2413         Reviewed by Sam Weinig.
2414
2415         This patch extends DumpRenderTree's AccessibilityController to ask
2416         if the focused element supports the press action.
2417
2418         * DumpRenderTree/AccessibilityUIElement.cpp:
2419         (getSupportsPressActionCallback):
2420         (AccessibilityUIElement::getJSClass):
2421         * DumpRenderTree/AccessibilityUIElement.h:
2422         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2423         (AccessibilityUIElement::supportsPressAction):
2424
2425 2008-09-22  Alice Liu  <alice.liu@apple.com>
2426
2427         Adding a stand-alone Windows console application to record a process's memory usage
2428
2429         Reviewed by Steve Falkenburg.
2430
2431         * record-memory-win: Added.
2432         * record-memory-win/main.cpp: Added.
2433         * record-memory-win/record-memory-win.vcproj: Added.
2434
2435 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
2436
2437         Reviewed by Darin Adler.
2438
2439         Support ability to get/set selected text ranges for text controls through AX.
2440
2441         * DumpRenderTree/AccessibilityUIElement.cpp:
2442         (setSelectedTextRangeCallback):
2443         (getSelectedTextRangeCallback):
2444         (AccessibilityUIElement::getJSClass):
2445         * DumpRenderTree/AccessibilityUIElement.h:
2446         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2447         (AccessibilityUIElement::attributesOfRowHeaders):
2448         (AccessibilityUIElement::attributesOfVisibleCells):
2449         (AccessibilityUIElement::rowIndexRange):
2450         (AccessibilityUIElement::columnIndexRange):
2451         (AccessibilityUIElement::cellForColumnAndRow):
2452         (AccessibilityUIElement::selectedTextRange):
2453         (AccessibilityUIElement::setSelectedTextRange):
2454         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2455         (AccessibilityUIElement::selectedTextRange):
2456         (AccessibilityUIElement::setSelectedTextRange):
2457
2458 2008-09-20  Darin Adler  <darin@apple.com>
2459
2460         * DumpRenderTree/mac/DumpRenderTree.mm:
2461         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
2462
2463 2008-09-19  Alp Toker  <alp@nuanti.com>
2464
2465         Build fix for the 'gold' linker and recent binutils. New behaviour
2466         requires that we link to used libraries explicitly.
2467
2468         * GNUmakefile.am:
2469
2470 2008-09-19  Stephanie Lewis  <slewis@apple.com>
2471
2472         Reviewed by Oliver Hunt.
2473
2474         Implement a workaround for an incorrect mime-type on machines with
2475         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
2476         See radar <rdar://problem/6234318>.
2477
2478         * DumpRenderTree/mac/DumpRenderTree.mm:
2479         (convertMIMEType):
2480
2481 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
2482
2483         Fixed Windows bustage
2484
2485         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2486         (AccessibilityUIElement::titleUIElement):
2487
2488 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
2489
2490         Reviewed by Darin Adler.
2491
2492         Expose titleUIElement call for DumpRenderTree
2493
2494         * ChangeLog:
2495         * DumpRenderTree/AccessibilityUIElement.cpp:
2496         (titleUIElementCallback):
2497         (AccessibilityUIElement::getJSClass):
2498         * DumpRenderTree/AccessibilityUIElement.h:
2499         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2500         (AccessibilityUIElement::titleUIElement):
2501
2502 2008-09-18  Darin Adler  <darin@apple.com>
2503
2504         * Scripts/do-webcore-rename: More renaming plans.
2505
2506 2008-09-18  Mark Rowe  <mrowe@apple.com>
2507
2508         Reviewed by Dan Bernstein.
2509
2510         Clear the main frame's name between tests to get more consistent test results
2511         when running the WebKit tests with --nthly.
2512
2513         * DumpRenderTree/mac/DumpRenderTree.mm:
2514         (resetWebViewToConsistentStateBeforeTesting):
2515         * DumpRenderTree/win/DumpRenderTree.cpp:
2516         (resetWebViewToConsistentStateBeforeTesting):
2517
2518 2008-09-18  Stephanie Lewis  <slewis@apple.com>
2519
2520         Really fix tiger jsc tests.
2521
2522         * Scripts/run-javascriptcore-tests:
2523
2524 2008-09-18  Stephanie Lewis  <slewis@apple.com>
2525
2526         Reviewed by Maciej Stachowiak.
2527
2528         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
2529
2530         * Scripts/run-javascriptcore-tests:
2531         * Scripts/webkitdirs.pm:
2532
2533 2008-09-18  Mark Rowe  <mrowe@apple.com>
2534
2535         Rubber-stamped by Sam Weinig.
2536
2537         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
2538         This should make it more obvious when a test does this, as stderr output tends to be obscured
2539         by noise in the test results.
2540
2541         Also fixes some coding style issues in ResourceLoadDelegate.mm.
2542
2543         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2544         (-[NSError _drt_descriptionSuitableForTestResult]):
2545         (-[NSURL _drt_descriptionSuitableForTestResult]):
2546         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2547         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2548         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2549         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2550         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2551         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2552
2553 2008-09-18  Stephanie Lewis  <slewis@apple.com>
2554
2555         Reviewed by Mark Rowe and Maciej Stachowiak..
2556
2557         add a --64-bit option and specify which architecture to run on Mac.
2558
2559         * Scripts/run-javascriptcore-tests:
2560
2561 2008-09-17  Mark Rowe  <mrowe@apple.com>
2562
2563         Reviewed by Sam Weinig.
2564
2565         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
2566
2567         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
2568         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
2569         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
2570
2571         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
2572         * DumpRenderTree/LayoutTestController.cpp:
2573         (LayoutTestController::LayoutTestController):
2574         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
2575         (layoutTestControllerObjectFinalize): Deref the wrapped object.
2576         (LayoutTestController::makeWindowObject): Ref the wrapped object.
2577         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
2578         * DumpRenderTree/mac/DumpRenderTree.mm:
2579         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
2580         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
2581         * DumpRenderTree/win/DumpRenderTree.cpp:
2582         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
2583
2584 2008-09-16  Sam Weinig  <sam@webkit.org>
2585
2586         Reviewed by Mark Rowe.
2587
2588         Add flag to disable running sample on tests that timeout.
2589
2590         * Scripts/run-webkit-tests:
2591
2592 2008-09-16  Adam Roben  <aroben@apple.com>
2593
2594         Windows build fix after r36511
2595
2596         Update for rename of layoutTestController to gLayoutTestController.
2597
2598         * DumpRenderTree/LayoutTestController.cpp:
2599         * DumpRenderTree/win/EditingDelegate.cpp:
2600         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2601         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2602         * DumpRenderTree/win/UIDelegate.cpp:
2603
2604 2008-09-16  Adam Roben  <aroben@apple.com>
2605
2606         Add a script to print out the dependency tree of a Visual Studio
2607         solution file
2608
2609         * Scripts/print-msvc-project-dependencies: Added.
2610
2611 2008-09-16  Mark Rowe  <mrowe@apple.com>
2612
2613         Fix the build.
2614
2615         * DumpRenderTree/LayoutTestController.cpp:
2616         (notifyDoneCallback): Call fprintf in a safer manner.
2617
2618 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
2619
2620         Reviewed by Eric Seidel
2621
2622         Protect against tests that call layoutTestController.notifyDone()
2623         more than once, which would lead to memory corruption, by nulling
2624         out the LayoutTestController on the JSObjectRef on destruction. Also
2625         add a finalize callback on the class so that if the LTC outlives
2626         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
2627         nulled out.
2628
2629         https://bugs.webkit.org/show_bug.cgi?id=20875
2630
2631         * DumpRenderTree/LayoutTestController.cpp:
2632         (LayoutTestController::LayoutTestController):
2633         (notifyDoneCallback):
2634         (layoutTestControllerObjectFinalize):
2635         (LayoutTestController::makeWindowObject):
2636         (LayoutTestController::getJSClass):
2637         * DumpRenderTree/LayoutTestController.h:
2638         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2639         (LayoutTestController::~LayoutTestController):
2640
2641 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
2642
2643         Reviewed by Eric Seidel
2644
2645         Step 1 patch: rename global variable for clarity.
2646         https://bugs.webkit.org/show_bug.cgi?id=20875
2647
2648         * DumpRenderTree/DumpRenderTree.h:
2649         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2650         (dumpWebViewAsPixelsAndCompareWithExpected):
2651         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2652         (dumpFramesAsText):
2653         (dump):
2654         (runTest):
2655         (processWork):
2656         (webViewLoadFinished):
2657         (webViewWindowObjectCleared):
2658         * DumpRenderTree/mac/DumpRenderTree.mm:
2659         (allocateGlobalControllers):
2660         (dumpFrameScrollPosition):
2661         (dumpFramesAsText):
2662         (methodNameStringForFailedTest):
2663         (dump):
2664         (runTest):
2665         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2666         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2667         * DumpRenderTree/mac/EditingDelegate.mm:
2668         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2669         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2670         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2671         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2672         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2673         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2674         (-[EditingDelegate webViewDidBeginEditing:]):
2675         (-[EditingDelegate webViewDidChange:]):
2676         (-[EditingDelegate webViewDidEndEditing:]):
2677         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2678         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2679         (-[FrameLoadDelegate processWork:]):
2680         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2681         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2682         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2683         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2684         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2685         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2686         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2687         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2688         * DumpRenderTree/mac/UIDelegate.mm:
2689         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2690         (-[UIDelegate webViewFocus:]):
2691         (-[UIDelegate webViewUnfocus:]):
2692         (-[UIDelegate webView:createWebViewWithRequest:]):
2693         (-[UIDelegate webViewClose:]):
2694         * DumpRenderTree/win/DumpRenderTree.cpp:
2695         (dumpFrameScrollPosition):
2696         (dumpFramesAsText):
2697         (dump):
2698         (runTest):
2699
2700 2008-09-15  Alice Liu  <alice.liu@apple.com>
2701
2702         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
2703
2704         Reviewed by Stephanie Lewis.
2705
2706         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2707         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
2708         but not Intel.  Add a check for nil before calling.
2709         (AccessibilityUIElement::rowIndexRange):
2710         (AccessibilityUIElement::columnIndexRange):
2711
2712 2008-09-14  Mark Rowe  <mrowe@apple.com>
2713
2714         Build fix.
2715
2716         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2717         (waitUntilDoneWatchdogFired):
2718         * DumpRenderTree/mac/ObjCPlugin.m:
2719
2720 2008-09-08  Dan Bernstein  <mitz@apple.com>
2721
2722         Reviewed by Mark Rowe.
2723
2724         - add an option to run-webkit-tests to always use the complex text code path
2725
2726         * DumpRenderTree/mac/DumpRenderTree.mm:
2727         (initializeGlobalsFromCommandLineOptions):
2728         (dumpRenderTree):
2729         * Scripts/run-webkit-tests:
2730
2731 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
2732
2733         Another Windows nightly build fix.
2734
2735         Reviewed by Sam Weinig.
2736
2737         * FindSafari/FindSafari.cpp:
2738         (_tmain): Delete existing WebKitNightly directory in temp.
2739         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
2740
2741 2008-09-07  Stephanie Lewis  <slewis@apple.com>
2742
2743         Reviewed by Mark Rowe.
2744
2745         Fix DRT build
2746
2747         * DumpRenderTree/DumpRenderTreePrefix.h:
2748         * DumpRenderTree/win/DumpRenderTree.vcproj:
2749
2750 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
2751
2752         Fix Windows nightlies.
2753
2754         Copy WebKit.dll alongside application so registry-free COM can find it.
2755         Update embedded manifest to force use registry-free COM.
2756
2757         Reviewed by Dave Hyatt.
2758
2759         * FindSafari/FindSafari.cpp:
2760         (copyManifest):
2761         (replaceManifest):
2762         (_tmain):
2763         * FindSafari/FindSafari.rc: Added.
2764         * FindSafari/FindSafari.vcproj:
2765         * FindSafari/Safari.exe.manifest: Added.
2766         * FindSafari/resource.h: Added.
2767
2768 === End merge of squirrelfish-extreme ===
2769
2770 2008-08-31  Mark Rowe  <mrowe@apple.com>
2771
2772         Reviewed by Maciej Stachowiak.
2773
2774         Add a --profile flag to run-sunspider.
2775
2776         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
2777         to build scripts as indicating that we should use the "Profiling" configuration.  At present
2778         this is only supported by JavaScriptCore, so using this argument to build any other project
2779         will likely result in unexpected behaviour.
2780
2781 2008-08-27  Mark Rowe  <mrowe@apple.com>
2782
2783         Reviewed by Oliver Hunt.
2784
2785         Fix run-webkit-tests to handle DRT exiting early.
2786
2787         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
2788
2789 === Start merge of squirrelfish-extreme ===
2790
2791 2008-09-04  Mark Rowe  <mrowe@apple.com>
2792
2793         Reviewed by Eric Seidel.
2794
2795         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
2796         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
2797
2798         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
2799
2800 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2801
2802         Reviewed by Oliver Hunt.
2803
2804         Bug 20616: Incorporate V8 benchmarks in testing
2805         <https://bugs.webkit.org/show_bug.cgi?id=20616>
2806
2807         Add support for the --v8 option to run-sunspider.
2808
2809         * Scripts/run-sunspider:
2810
2811 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2812
2813         wx buildbot fix. More robust handling of clean when makefiles are not built or
2814         are not completely made.
2815
2816         * wx/build-wxwebkit:
2817
2818 2008-09-03  Mark Rowe  <mrowe@apple.com>
2819
2820         More Mac build fixes.
2821
2822         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
2823         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
2824         default configuration specified in the .xcconfig files.
2825
2826         * Scripts/build-webkit:
2827
2828 2008-09-03  Mark Rowe  <mrowe@apple.com>
2829
2830         Mac build fix.  Ensure that dashboard support is enabled.
2831
2832         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2833
2834 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
2835
2836         Build fix. Copy correct version of ICU.
2837
2838         * DumpRenderTree/win/DumpRenderTree.vcproj:
2839
2840 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
2841
2842         Reviewed by Simon.
2843
2844         [run-webkit-tests] Use QtLauncher to show the results of the tests
2845         konqueror might not be installed, xdg-open might not be installed but the
2846         QtLauncher should be present.
2847
2848         * Scripts/run-webkit-tests:
2849
2850 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
2851
2852         Initial support for accessibility layout tests on Windows.
2853         https://bugs.webkit.org/show_bug.cgi?id=20497
2854
2855         Reviewed by Sam Weinig.
2856
2857         * DumpRenderTree/AccessibilityController.h: Fix typos.
2858         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
2859         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
2860         prevent oleacc.h, which includes windows.h, from including winsock.h.
2861         Fixed typos.
2862         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
2863         (AccessibilityController::AccessibilityController):
2864         (AccessibilityController::~AccessibilityController):
2865         (AccessibilityController::focusedElement): Get the root element, and
2866         request its focused object.
2867         (AccessibilityController::rootElement): Query Windows for the
2868         accessible client object for the WebView's window.
2869         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
2870         (AccessibilityUIElement::AccessibilityUIElement):
2871         (AccessibilityUIElement::~AccessibilityUIElement):
2872         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
2873         (AccessibilityUIElement::getChildren): Get the child count, and append
2874         each child.
2875         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
2876         index offset by 1. In MSAA, child 0 is the object itself.
2877         (AccessibilityUIElement::allAttributes): Not implemented.
2878         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
2879         (AccessibilityUIElement::attributesOfChildren): Same.
2880         (AccessibilityUIElement::parameterizedAttributeNames): Same.
2881         (self): Return a VARIANT representing the "self" object. This is used
2882         when calling methods that require a child variant.
2883         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
2884         convert it into a string with GetRoleText().
2885         (AccessibilityUIElement::title): Get the element's title, and convert
2886         it to a JS String.
2887         (AccessibilityUIElement::description): Same, for description.
2888         (AccessibilityUIElement::width):
2889         (AccessibilityUIElement::height):
2890         (AccessibilityUIElement::intValue): Get the object's value as a string,
2891         and convert the string to a double.
2892         (AccessibilityUIElement::minValue): Not implemented.
2893         (AccessibilityUIElement::maxValue): Same.
2894         (AccessibilityUIElement::insertionPointLineNumber): Same.
2895         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
2896         (AccessibilityUIElement::attributesOfRowHeaders): Same.
2897         (AccessibilityUIElement::attributesOfColumns): Same.
2898         (AccessibilityUIElement::attributesOfRows): Same.
2899         (AccessibilityUIElement::attributesOfVisibleCells): Same.
2900         (AccessibilityUIElement::attributesOfHeader): Same.
2901         (AccessibilityUIElement::indexInTable): Same.
2902         (AccessibilityUIElement::rowIndexRange): Same.
2903         (AccessibilityUIElement::columnIndexRange): Same.
2904         (AccessibilityUIElement::lineForIndex): Same.
2905         (AccessibilityUIElement::boundsForRange): Same.
2906         (AccessibilityUIElement::cellForColumnAndRow): Same.
2907         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
2908         project.  Link to oleacc.lib, the MSAA library.
2909         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2910         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
2911         controller.
2912         (FrameLoadDelegate::didClearWindowObject): Create a new window object
2913         for the accessibility controller.
2914         * DumpRenderTree/win/FrameLoadDelegate.h:
2915
2916 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
2917
2918         Reviewed by Mark Rowe
2919
2920         Make build-launcher-app work when run from a git repository.
2921         https://bugs.webkit.org/show_bug.cgi?id=20478
2922
2923         * BuildSlaveSupport/build-launcher-app:
2924
2925 2008-08-20  Maxime Britto  <britto@apple.com>
2926
2927         Reviewed by Ada Chan.
2928
2929          rdar://5259746
2930         Mouse events are sent to page while resizing window (affects Gmail)
2931
2932         * DumpRenderTree/win/UIDelegate.h:
2933         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
2934
2935 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
2936
2937         Reviewed by Beth Dakin.
2938
2939         Add snowleopard platform in layout tests
2940
2941         Added support for accessing the attributes of
2942         accessibility tables through the accessibility controller
2943         in DumpRenderTree
2944
2945         * DumpRenderTree/AccessibilityUIElement.cpp:
2946         (attributesOfColumnHeadersCallback):
2947         (attributesOfRowHeadersCallback):
2948         (attributesOfColumnsCallback):
2949         (attributesOfRowsCallback):
2950         (attributesOfVisibleCellsCallback):
2951         (attributesOfHeaderCallback):
2952         (indexInTableCallback):
2953         (rowIndexRangeCallback):
2954         (columnIndexRangeCallback):
2955         (childAtIndexCallback):
2956         (cellForColumnAndRowCallback):
2957         (AccessibilityUIElement::getJSClass):
2958         * DumpRenderTree/AccessibilityUIElement.h:
2959         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2960         (convertNSArrayToVector):
2961         (descriptionOfElements):
2962         (AccessibilityUIElement::getLinkedUIElements):
2963         (AccessibilityUIElement::getChildren):
2964         (AccessibilityUIElement::attributesOfLinkedUIElements):
2965         (AccessibilityUIElement::attributesOfChildren):
2966         (AccessibilityUIElement::attributesOfColumnHeaders):
2967         (AccessibilityUIElement::attributesOfRowHeaders):
2968         (AccessibilityUIElement::attributesOfColumns):
2969         (AccessibilityUIElement::attributesOfRows):
2970         (AccessibilityUIElement::attributesOfVisibleCells):
2971         (AccessibilityUIElement::attributesOfHeader):
2972         (AccessibilityUIElement::indexInTable):
2973         (AccessibilityUIElement::rowIndexRange):
2974         (AccessibilityUIElement::columnIndexRange):
2975         (AccessibilityUIElement::cellForColumnAndRow):
2976         * Scripts/run-webkit-tests:
2977
2978 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
2979
2980         Reviewed by Darin Adler.
2981
2982         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
2983         is waiting for crash reporter to let it exit.
2984
2985         The fix does not work on Tiger, because the state of the process is indistinguishable from
2986         other waiting processes, at least not with this technique.
2987
2988         * Scripts/run-webkit-tests:
2989
2990 2008-08-18  Alp Toker  <alp@nuanti.com>
2991
2992         Reviewed by Holger Freyther.
2993
2994         https://bugs.webkit.org/show_bug.cgi?id=20350
2995         [GTK] Get DumpRenderTree working
2996
2997         Fixes and enhancements to DumpRenderTree. With these changes, the test
2998         suite can now complete a run producing text and render tree dumps.
2999
3000         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3001         (dumpFramesAsText):
3002         (dump):
3003         (runTest):
3004         (webViewLoadFinished):
3005         (webViewWindowObjectCleared):
3006         (webViewConsoleMessage):
3007         (webViewScriptAlert):
3008         (webViewScriptPrompt):
3009         (webViewScriptConfirm):
3010         (webViewTitleChanged):
3011         (main):
3012         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3013         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3014         (LayoutTestController::clearBackForwardList):
3015         (LayoutTestController::pathToLocalResource):
3016         (LayoutTestController::setAcceptsEditing):
3017         (LayoutTestController::setUserStyleSheetEnabled):
3018         (LayoutTestController::setUserStyleSheetLocation):
3019         (waitToDumpWatchdogFired):
3020         (LayoutTestController::windowCount):
3021         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3022         (JSStringCopyUTF8CString):
3023         (ScriptItem::invoke):
3024
3025 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
3026
3027         Reviewed by Cameron Zwarich.
3028
3029         Updated project files to XCode 3.1.
3030
3031         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3032         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3033
3034 2008-08-15  Mark Rowe  <mrowe@apple.com>
3035
3036         Rubber-stamped by Geoff Garen.
3037
3038         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
3039
3040         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
3041
3042 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
3043
3044         Rubber-stamped by Holger.
3045
3046         Revert r31585 and disable http tests for the Qt build again unless
3047         explicitly enabled.
3048
3049         Running the http tests unfortunately currently still triggers
3050         failures in non-http tests due to side-effects. Disable them by default for
3051         now, for more reliable results.
3052
3053         * Scripts/run-webkit-tests:
3054
3055 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
3056
3057         Reviewed (and updated) by Alp Toker.
3058
3059         https://bugs.webkit.org/show_bug.cgi?id=16620
3060         [GTK] Autotools make dist and make check support
3061
3062         Get make dist working.
3063
3064         Note that not all possible configurations have been tested yet.
3065
3066         * GNUmakefile.am:
3067
3068 2008-08-10  Alp Toker  <alp@nuanti.com>
3069
3070         Remove leftover qmake/GTK+ build files.
3071
3072         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
3073         * GtkLauncher/GtkLauncher.pro: Removed.
3074
3075 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
3076
3077         Reviewed by Beth Dakin
3078
3079         AX functions shouldn't return position information because it changes
3080         based on the platform
3081
3082         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3083         (AccessibilityUIElement::boundsForRange):
3084
3085 2008-08-06  Eric Seidel  <eric@webkit.org>
3086
3087         Reviewed by darin.
3088
3089         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
3090         <https://bugs.webkit.org/show_bug.cgi?id=20297>
3091         <rdar://problem/6093153>
3092
3093         I've made AccessibilityUIElement a stack object for now.  It could be
3094         made RefCounted, but I figured that might be overkill for the moment.
3095         Essentially it's just a RefPtr itself. :)
3096
3097         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
3098         which was causing additional leaks. :)
3099
3100         I added toAXElement to remove a bunch of copy/paste code.
3101
3102         * DumpRenderTree/AccessibilityController.h:
3103         * DumpRenderTree/AccessibilityUIElement.cpp:
3104         (toAXElement):
3105         (allAttributesCallback):
3106         (attributesOfLinkedUIElementsCallback):
3107         (attributesOfChildrenCallback):
3108         (lineForIndexCallback):
3109         (boundsForRangeCallback):
3110         (childAtIndexCallback):
3111         (getRoleCallback):
3112         (getTitleCallback):
3113         (getDescriptionCallback):
3114         (getWidthCallback):
3115         (getHeightCallback):
3116         (getIntValueCallback):
3117         (getMinValueCallback):
3118         (getMaxValueCallback):
3119         (getInsertionPointLineNumberCallback):
3120         (finalize):
3121         * DumpRenderTree/AccessibilityUIElement.h:
3122         (AccessibilityUIElement::platformUIElement):
3123         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3124         (AccessibilityController::focusedElement):
3125         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3126         (AccessibilityUIElement::AccessibilityUIElement):
3127         (AccessibilityUIElement::getLinkedUIElements):
3128         (AccessibilityUIElement::getChildren):
3129         (AccessibilityUIElement::getChildAtIndex):
3130         (AccessibilityUIElement::attributesOfLinkedUIElements):
3131         (AccessibilityUIElement::attributesOfChildren):
3132
3133 2008-08-06  Eric Seidel  <eric@webkit.org>
3134
3135         Reviewed by Cameron Zwarich.
3136
3137         Speculative fix for an error I keep seeing in my Cygwin build
3138
3139         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
3140
3141 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
3142
3143         Forgot to commit licensing correction in last commit.
3144
3145         * wx/packaging/wxWebKitInstaller.iss.in:
3146
3147 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
3148
3149         Reviewed by Eric Seidel.
3150
3151         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
3152         be used for nightlies.
3153
3154         https://bugs.webkit.org/show_bug.cgi?id=20036
3155
3156         * wx/packaging: Added.
3157         * wx/packaging/build-win-installer.py: Added.
3158         * wx/packaging/wxWebKitInstaller.iss.in: Added.
3159
3160 2008-07-31  Adam Roben  <aroben@apple.com>
3161
3162         Follow-up to r35500
3163
3164         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
3165         Release configuration, too.
3166
3167 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
3168
3169         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
3170         the box
3171
3172         <https://bugs.webkit.org/show_bug.cgi?id=20245>
3173
3174         Reviewed by Adam Roben.
3175
3176         * WinLauncher/WinLauncher.vcproj: adding the following properties to
3177         WinLauncher > Properties > Manifest Tool > Isolated COM
3178         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
3179         Component File Name: WebKit$(WebKitDLLConfigSuffix)
3180         Doing the change on "All Configurations"
3181
3182 2008-07-31  Adam Roben  <aroben@apple.com>
3183
3184         Windows build bot fix
3185
3186         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
3187         exist for people at Apple can't be found. Also updated the ICU version
3188         to 3.8.
3189
3190 2008-07-31  David Kilzer  <ddkilzer@apple.com>
3191
3192         Fix layout test results for webarchive/test-xml-stylesheet.xml
3193
3194         Reviewed by Darin Adler.
3195
3196         * DumpRenderTree/mac/DumpRenderTree.mm:
3197         (convertMIMEType): Work around the "text/xml" local file type
3198         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
3199         stop mangling "application/x-javascript" into "text/javascript".
3200         (convertWebResourceDataToString): When checking whether to dump a
3201         resource as text, also check to see if the MIME type is in the
3202         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
3203         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
3204         macro.
3205
3206 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
3207
3208         Reviewed by Alice Liu
3209
3210         Add AX support to get the bounds for a range of text
3211         Add AX support to get the child of an element
3212         Add AX support to get all the parameterized attribute names of an element
3213
3214         * DumpRenderTree/AccessibilityUIElement.cpp:
3215         (parameterizedAttributeNamesCallback):
3216         (boundsForRangeCallback):
3217         (childAtIndexCallback):
3218         (AccessibilityUIElement::getJSClass):
3219         * DumpRenderTree/AccessibilityUIElement.h:
3220         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3221         (AccessibilityUIElement::getChildAtIndex):
3222         (AccessibilityUIElement::parameterizedAttributeNames):
3223         (AccessibilityUIElement::boundsForRange):
3224
3225 2008-07-31  Erik Bunce  <elbunce@thehive.com>
3226
3227         Reviewed by Simon.
3228
3229         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
3230
3231         * Scripts/run-launcher:
3232
3233 2008-07-30  Jessica Kahn  <jess@apple.com>
3234
3235         Reviewed by Adam Roben.
3236
3237         Slightly stricter checking for previous change, suggested by Adam.
3238
3239         * Scripts/extract-localizable-strings:
3240
3241 2008-07-30  Jessica Kahn  <jess@apple.com>
3242
3243         Reviewed by Darin Adler.
3244
3245         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
3246
3247         * Scripts/extract-localizable-strings:
3248
3249 2008-07-30  Anders Carlsson  <andersca@apple.com>
3250
3251         Reviewed by Adam.
3252
3253         Copy icu38* files instead of icu36* files.
3254
3255         * DumpRenderTree/win/DumpRenderTree.vcproj:
3256
3257 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
3258
3259         DRT/Gtk build fix for r35362
3260
3261         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3262         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3263
3264 2008-07-25  Brady Eidson  <beidson@apple.com>
3265
3266         Reviewed by Sam
3267
3268         Add the ability to dump whether-or-not an element should have autocomplete enabled,
3269         from the perspective of the WebKit API
3270
3271         * DumpRenderTree/LayoutTestController.cpp:
3272         (elementDoesAutoCompleteForElementWithIdCallback):
3273         (LayoutTestController::staticFunctions):
3274
3275         * DumpRenderTree/LayoutTestController.h:
3276         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3277         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
3278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3279         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
3280
3281 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
3282
3283         Reviewed by Beth Dakin
3284
3285         Add support for AXLineForIndex and AXInsertionPointIndex through the
3286         accessibility controller
3287
3288         * DumpRenderTree/AccessibilityUIElement.cpp:
3289         (lineForIndexCallback):
3290         (getInsertionPointLineNumberCallback):
3291         (AccessibilityUIElement::getJSClass):
3292         * DumpRenderTree/AccessibilityUIElement.h:
3293         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3294         (AccessibilityUIElement::insertionPointLineNumber):
3295         (AccessibilityUIElement::lineForIndex):
3296
3297 2008-07-25  Adam Roben  <aroben@apple.com>
3298
3299         Try to fix the Windows build bot
3300
3301         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
3302         that don't exist for people outside of Apple.
3303
3304 2008-07-18  Landry Breuil  <landry@openbsd.org>
3305
3306         Bug 19975: [OpenBSD] Patches to enable build of WebKit
3307
3308         <https://bugs.webkit.org/show_bug.cgi?id=19975>
3309
3310         Reviewed by David Kilzer.
3311
3312         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
3313
3314 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
3315
3316         CygwinDownloader fails to install necessary packages
3317         https://bugs.webkit.org/show_bug.cgi?id=20075
3318
3319         Reviewed by Mark Rowe.
3320
3321         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
3322         mirrors removed in r34116. Set MIME type to application/octet-stream.
3323
3324 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
3325
3326         CygwinDownloader's make-zip.sh script fails
3327         https://bugs.webkit.org/show_bug.cgi?id=20074
3328
3329         Reviewed by Mark Rowe.
3330
3331         * CygwinDownloader/cygwin-downloader.py:
3332
3333 2008-07-15  Sam Weinig  <sam@webkit.org>
3334
3335         Reviewed by Anders Carlsson.
3336
3337         Refactor accessibility testing code.
3338
3339         We now have:
3340         - AccessibilityController
3341           Controller which has access to the WebView and can provide the focused element, root element
3342           and in the future, elementAtPoint.
3343
3344         - AccessibilityUIElement
3345           Object which provides access to the data provided by the Accessibility APIs.
3346
3347         * DumpRenderTree/AccessibilityController.cpp:
3348         (getFocusedElementCallback):
3349         (getRootElementCallback):
3350         (AccessibilityController::getJSClass):
3351         * DumpRenderTree/AccessibilityController.h:
3352         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
3353         (allAttributesCallback):
3354         (attributesOfLinkedUIElementsCallback):
3355         (attributesOfChildrenCallback):
3356         (getRoleCallback):
3357         (getTitleCallback):
3358         (getDescriptionCallback):
3359         (getWidthCallback):
3360         (getHeightCallback):
3361         (getIntValueCallback):
3362         (getMinValueCallback):
3363         (getMaxValueCallback):
3364         (finalize):
3365         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3366         (AccessibilityUIElement::getJSClass):
3367         * DumpRenderTree/AccessibilityUIElement.h: Added.
3368         (AccessibilityUIElement::platformUIElement):
3369         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3370         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3371         (AccessibilityController::AccessibilityController):
3372         (AccessibilityController::~AccessibilityController):
3373         (AccessibilityController::focusedElement):
3374         (AccessibilityController::rootElement):
3375         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
3376         (AccessibilityUIElement::AccessibilityUIElement):
3377         (descriptionOfValue):
3378         (attributesOfElement):
3379         (nsStringToJSStringRef):
3380         (concatenateAttributeAndValue):
3381         (AccessibilityUIElement::getLinkedUIElements):
3382         (AccessibilityUIElement::getChildren):
3383         (AccessibilityUIElement::attributesOfLinkedUIElements):
3384         (AccessibilityUIElement::attributesOfChildren):
3385         (AccessibilityUIElement::allAttributes):
3386         (AccessibilityUIElement::role):
3387         (AccessibilityUIElement::title):
3388         (AccessibilityUIElement::description):
3389         (AccessibilityUIElement::width):
3390         (AccessibilityUIElement::height):
3391         (AccessibilityUIElement::intValue):
3392         (AccessibilityUIElement::minValue):
3393         (AccessibilityUIElement::maxValue):
3394
3395 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
3396
3397         Reviewed by Beth Dakin
3398
3399         Add support to get attributes of the AXChildren of an objecty
3400
3401         * DumpRenderTree/AccessibilityController.cpp:
3402         (attributesOfChildrenForFocusedElementCallback):
3403         (AccessibilityController::staticFunctions):
3404         * DumpRenderTree/AccessibilityController.h:
3405         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3406         (descriptionOfValue):
3407         (AccessibilityController::attributesOfChildrenForFocusedElement):
3408
3409 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
3410
3411         Build fix.
3412
3413         * DumpRenderTree/win/DumpRenderTree.vcproj:
3414
3415 2008-07-14  Adam Roben  <aroben@apple.com>
3416
3417         Attempted Windows build fix
3418
3419         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
3420         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
3421         include path.
3422
3423 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
3424
3425         Reviewed by Geoff Garen.
3426
3427         Eliminate per-thread JavaScript global data instance support and make arbitrary
3428         global data/global object combinations possible.
3429
3430         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3431         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
3432         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
3433         chance for a different thread to cause GC after the context was released.
3434
3435 2008-07-11  Stephanie Lewis  <slewis@apple.com>
3436
3437         Reviewed by Darin Adler.
3438
3439         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
3440
3441         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
3442
3443         * DumpRenderTree/mac/DumpRenderTree.mm:
3444         (setDefaultsToConsistentValuesForTesting):
3445         (resetWebViewToConsistentStateBeforeTesting):
3446         * Scripts/run-webkit-tests:
3447
3448 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
3449
3450         Build fix.
3451
3452         * DumpRenderTree/win/DumpRenderTree.vcproj:
3453
3454 2008-07-09  Eric Seidel  <eric@webkit.org>
3455
3456         Reviewed by Mark Rowe.
3457
3458         Print <div> backgrounds when printing from DRT.
3459
3460         * DumpRenderTree/mac/DumpRenderTree.mm:
3461         (setDefaultsToConsistentValuesForTesting):
3462
3463 2008-07-09  Eric Seidel  <eric@webkit.org>
3464
3465         Reviewed by Mark Rowe.
3466
3467         Fix copying of expected results to correct location
3468
3469         * Scripts/run-webkit-tests:
3470
3471 2008-07-09  Eric Seidel  <eric@webkit.org>
3472
3473         Reviewed by aroben.
3474
3475         * DumpRenderTree/LayoutTestController.cpp:
3476         (LayoutTestController::LayoutTestController):
3477         (dumpAsPDFCallback):
3478         (LayoutTestController::staticFunctions):
3479         * DumpRenderTree/LayoutTestController.h:
3480         (LayoutTestController::dumpAsPDF):
3481         (LayoutTestController::setDumpAsPDF):
3482         * DumpRenderTree/mac/DumpRenderTree.mm:
3483         (dumpFrameAsPDF):
3484         (dump):
3485
3486 2008-07-09  Eric Seidel  <eric@webkit.org>
3487
3488         Reviewed by weinig.
3489
3490         Add Content-Type support to DumpRenderTree and run-webkit-tests
3491         and move expected.txt files to expected.webarchive
3492
3493         https://bugs.webkit.org/show_bug.cgi?id=15565
3494
3495         * DumpRenderTree/cg/ImageDiffCG.cpp:
3496         (compareImages):
3497         (main):
3498         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3499         (printPNG):
3500         * DumpRenderTree/mac/DumpRenderTree.mm:
3501         (dump):
3502         * Scripts/run-webkit-tests:
3503
3504 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
3505
3506         Reviewed by Anders.
3507
3508         Port r34988 to Mac: allow tests to define JavaScript to execute when
3509         NPP_DestroyStream or NPP_URLNotify is called.
3510
3511         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3512         (NPP_New): Remove initialization that happens in pluginAllocate. Look
3513         for new arguments onStreamDestroy and onURLNotify.
3514         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
3515         (executeScript): Code moved from onStreamLoad.
3516         (NPP_NewStream): Call executeScript.
3517         (NPP_DestroyStream): Same.
3518         (NPP_URLNotify): Same.
3519
3520 2008-07-07  Beth Dakin  <bdakin@apple.com>
3521
3522         Reviewed by Anders.
3523
3524         This patch extends DRT accessibility tests to add the ability to
3525         query the intValue, minValue, and maxValue of the focused element.
3526
3527         * DumpRenderTree/AccessibilityController.cpp:
3528         (intValueOfFocusedElementCallback):
3529         (minValueOfFocusedElementCallback):
3530         (maxValueOfFocusedElementCallback):
3531         (AccessibilityController::staticFunctions):
3532         * DumpRenderTree/AccessibilityController.h:
3533         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3534         (AccessibilityController::intValueOfFocusedElement):
3535         (AccessibilityController::minValueOfFocusedElement):
3536         (AccessibilityController::maxValueOfFocusedElement):
3537
3538 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
3539
3540         Fix build.
3541
3542         * DumpRenderTree/win/ImageDiff.vcproj:
3543
3544 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
3545
3546         Allow tests to define JavaScript to execute when NPP_DestroyStream or
3547         NPP_URLNotify is called.
3548
3549         Reviewed by Anders.
3550
3551         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
3552         property, "returnErrorFromNewStream." This is to support the test for
3553         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
3554         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
3555         error from NPP_NewStream.
3556         (pluginGetProperty):
3557         (pluginSetProperty):
3558         (pluginAllocate):
3559         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
3560         members, onStreamDestroy and onURLNotify.
3561         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3562         (NPP_New): Remove initialization of onStreamLoad; this was moved to
3563         pluginAllocate. Look for new arguments onStreamDestroy and
3564         onURLNotify, and store their values.
3565         (NPP_Destroy): Free new members.
3566         (executeScript): Code moved from onStreamLoad
3567         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
3568         return a generic error code. If onStreamLoad is set, execute it as
3569         JavaScript.
3570         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
3571         (NPP_URLNotify): Same, for onURLNotify.
3572
3573 2008-07-02  Brady Eidson  <beidson@apple.com>
3574
3575         Reviewed by Mitz Pettel and John Sullivan
3576
3577         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
3578         load delegate.
3579
3580         Required to add a layout test for the fix for <rdar://problem/5549871>
3581
3582         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3583         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
3584           [WebFrame stopLoading] to test for the crash reflected in 5549871
3585
3586         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
3587         * DumpRenderTree/LayoutTestController.cpp:
3588         (LayoutTestController::LayoutTestController):
3589         (setStopProvisionalFrameLoadsCallback):
3590         (LayoutTestController::staticFunctions):
3591         * DumpRenderTree/LayoutTestController.h:
3592         (LayoutTestController::stopProvisionalFrameLoads):
3593         (LayoutTestController::setStopProvisionalFrameLoads):
3594
3595 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
3596
3597         Reviewed by Beth Dakin
3598
3599         Support ability to get width and height of an element through accessibility
3600
3601         * DumpRenderTree/AccessibilityController.cpp:
3602         (widthOfFocusedElementCallback):
3603         (heightOfFocusedElementCallback):
3604         (AccessibilityController::staticFunctions):
3605         * DumpRenderTree/AccessibilityController.h:
3606         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3607         (AccessibilityController::widthOfFocusedElement):
3608         (AccessibilityController::heightOfFocusedElement):
3609
3610 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
3611
3612         Reviewed by Beth Dakin
3613
3614         Support the ability to get the linked ui elements of an object
3615
3616         * DumpRenderTree/AccessibilityController.cpp:
3617         (attributesOfLinkedUIElementsForFocusedElementCallback):
3618         (AccessibilityController::staticFunctions):
3619         * DumpRenderTree/AccessibilityController.h:
3620         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3621         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
3622         (AccessibilityController::allAttributesOfFocusedElement):
3623         (attributesOfElement):
3624         (nsStringToJSStringRef):
3625
3626 2008-06-29  Sam Weinig  <sam@webkit.org>
3627
3628         Fix Tiger build.
3629
3630         * DumpRenderTree/mac/EventSendingController.mm:
3631         (eventTypeForMouseButtonAndAction):
3632
3633 2008-06-27  Eric Seidel  <eric@webkit.org>
3634
3635         Reviewed by darin.
3636
3637         Add multi-button mouseevent support to DRT
3638         https://bugs.webkit.org/show_bug.cgi?id=15173
3639
3640         It's now possible to specify the mouse button with:
3641         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
3642
3643         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3644         * DumpRenderTree/mac/EventSendingController.h:
3645         * DumpRenderTree/mac/EventSendingController.mm:
3646         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3647         (+[EventSendingController webScriptNameForSelector:]):
3648         (eventTypeForMouseButtonAndAction):
3649         (-[EventSendingController updateClickCountForButton:]):
3650         (-[EventSendingController mouseDown:]):
3651         (-[EventSendingController mouseUp:]):
3652         (-[EventSendingController mouseMoveToX:Y:]):
3653         (-[EventSendingController contextClick]):
3654
3655 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
3656
3657         Reviewed by Oliver.
3658
3659         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
3660         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
3661
3662         * Scripts/run-webkit-tests:
3663