2010-06-16 Martin Robinson <mrobinson@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Gustavo Noronha Silva.
4
5         [GTK] r60803 broke media/controls-drag-timebar.html
6         https://bugs.webkit.org/show_bug.cgi?id=40269
7
8         Only queue events while the mouse button is down, if drag mode is enabled. Some
9         tests may disable drag mode, to prevent the queuing of events in this situation.
10
11         * DumpRenderTree/gtk/EventSender.cpp:
12         (sendOrQueueEvent): Only queue events here if dragMode is true.
13
14 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
15
16         Reviewed by Gustavo Noronha Silva.
17
18         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
19         https://bugs.webkit.org/show_bug.cgi?id=40600
20
21         * DumpRenderTree/gtk/EventSender.cpp:
22         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
23
24 2010-06-16  Adam Barth  <abarth@webkit.org>
25
26         Reviewed by Dimitri Glazkov.
27
28         Add a hidden land-cowboy command to webkit-patch to help land quick
29         build fixes.
30
31         * Scripts/webkitpy/tool/commands/download.py:
32         * Scripts/webkitpy/tool/steps/preparechangelog.py:
33
34 2010-06-16  Adam Roben  <aroben@apple.com>
35
36         Convert console messages to UTF-8 before printing them
37
38         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
39         http/tests/security/xssAuditor/embed-tag-null-char.html and
40         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
41         Windows. (I can't test the fix because Apache is crashing on my
42         computer.)
43
44         Reviewed by Alexey Proskuryakov.
45
46         * DumpRenderTree/win/DumpRenderTree.cpp:
47         (toUTF8): Extracted the code into an overload that takes a wide string
48         and a length, then added an overload that takes a wstring.
49
50         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
51         overload.
52
53         * DumpRenderTree/win/UIDelegate.cpp:
54         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
55         UTF-8 instead of letting printf convert to the current code page.
56
57 2010-06-16  Drew Wilson  <atwilson@chromium.org>
58
59         Reviewed by Kent Tamura.
60
61         [Chromium] Plumbing for top-level frame names
62         https://bugs.webkit.org/show_bug.cgi?id=40430
63
64         * DumpRenderTree/chromium/WebViewHost.cpp:
65         (WebViewHost::createView):
66         Migrate to new createView() API.
67         * DumpRenderTree/chromium/WebViewHost.h:
68         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
69
70 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
71
72         Reviewed by Kenneth Rohde Christiansen.
73
74         [Qt] Scroll wheel event support to graphics based DRT
75         https://bugs.webkit.org/show_bug.cgi?id=40577
76
77         * DumpRenderTree/qt/EventSenderQt.cpp:
78         (EventSender::continuousMouseScrollBy):
79         (EventSender::createGraphicsSceneWheelEvent):
80         * DumpRenderTree/qt/EventSenderQt.h:
81
82 2010-06-16  Adam Roben  <aroben@apple.com>
83
84         Remove a stray newline from the Windows version of TestNetscapePlugin
85
86         Reviewed by Alexey Proskuryakov.
87
88         Fixes <http://webkit.org/b/40728>
89         plugins/geturlnotify-during-document-teardown.html fails on Windows
90
91         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
92         (NPP_Destroy): Removed extra newline that the Mac version doesn't
93         have.
94
95 2010-06-16  Adam Roben  <aroben@apple.com>
96
97         Respect LayoutTestController::isPrinting on Windows
98
99         This gets some printing tests closer to passing (like
100         printing/page-rule-in-media-query.html).
101
102         Fixes <http://webkit.org/b/40727>.
103
104         Reviewed by Dan Bernstein.
105
106         * DumpRenderTree/win/DumpRenderTree.cpp:
107         (dump): Pass LayoutTestController::isPrinting to
108         IWebFramePrivate::renderTreeAsExternalRepresentation.
109
110 2010-06-15  Adam Barth  <abarth@webkit.org>
111
112         Reviewed by Eric Seidel.
113
114         Enable HTML5 lexer
115         https://bugs.webkit.org/show_bug.cgi?id=40650
116
117         * DumpRenderTree/mac/DumpRenderTree.mm:
118         (initializeGlobalsFromCommandLineOptions):
119
120 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
121
122         Reviewed by Shinichiro Hamaji.
123
124         Implement render style selection for pages to support CSS3 Paged Media.
125         https://bugs.webkit.org/show_bug.cgi?id=35961
126
127         * DumpRenderTree/LayoutTestController.cpp:
128         (parsePagePropertyParameters):
129         (pagePropertyCallback):
130         (LayoutTestController::staticFunctions):
131         * DumpRenderTree/LayoutTestController.h:
132         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
133         (LayoutTestController::pageProperty):
134         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
135         (LayoutTestController::pageProperty):
136         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
137         (LayoutTestController::pageProperty):
138
139 2010-06-15  Sam Weinig  <sam@webkit.org>
140
141         Reviewed by Anders Carlsson.
142
143         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
144         WebKit2: Add mechanism to inject code into the WebProcess on startup
145
146         Add initial InjectedBundle support.
147
148         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
149         * MiniBrowser/WebBundle-Info.plist: Added.
150         Add test InjectedBundle to the project.
151
152         * MiniBrowser/mac/AppDelegate.m:
153         (-[BrowserAppDelegate init]):
154         Get the path to the WebBundle from the the main bundle and pass it to the new
155         WKContextCreateWithInjectedBundlePath function.
156
157         * MiniBrowser/mac/BrowserWindowController.m:
158         (_didChangeProgress):
159         Fix the build.  This has been broken for a while.
160
161         * MiniBrowser/mac/WebBundle: Added.
162         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
163         (_didCreatePage):
164         (WKBundleInitialize):
165         Add really basic InjectedBundle.
166
167         * MiniBrowser/win/BrowserView.cpp:
168         (BrowserView::create):
169         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
170
171 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
172
173         Reviewed by Darin Adler.
174
175         Adding myself to the reviewers list.
176         https://bugs.webkit.org/show_bug.cgi?id=40693
177
178         * Scripts/webkitpy/common/config/committers.py:
179
180 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
181
182         Reviewed by Xan Lopez.
183
184         Switch to using GIO methods instead of realpath in GtkLauncher to determine
185         the file URI. This should remove warnings about realpath being undefined
186         when compiling with '-ansi'.
187
188         * GtkLauncher/main.c:
189         (filenameToURL): Use GIO instead of realpath to determine file URI.
190
191 2010-06-15  Adam Roben  <aroben@apple.com>
192
193         Remove the redundant set-apple-windows-environment-variables script
194
195         Apparently update-webkit does this for you these days.
196
197         Rubber-stamped by Steve Falkenburg.
198
199         * Scripts/set-apple-windows-environment-variables: Removed.
200
201 2010-06-14  Adam Roben  <aroben@apple.com>
202
203         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
204         environment variables
205
206         Fixes <http://webkit.org/b/40595>.
207
208         Reviewed by Steve Falkenburg.
209
210         * Scripts/set-apple-windows-environment-variables: Added.
211         (to_windows_path): Passes the passed-in path through cygpath to
212         generate a Windows-style path.
213         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
214         variables to their defaults, if they aren't already set.
215
216 2010-06-14  Adam Roben  <aroben@apple.com>
217
218         Speed up run-safari/debug-safari on Windows
219
220         Fixes <http://webkit.org/b/40586>.
221
222         Reviewed by Steve Falkenburg.
223
224         * Scripts/webkitdirs.pm:
225         (runSafari): When debugging, set up the environment to run Safari
226         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
227         actually launch the debugger. When not debugging, just run WebKit.exe
228         and it will do the rest for us.
229
230 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
231
232         Reviewed by Kenneth Rohde Christiansen.
233
234         [Qt] DRT EventSender support to graphics context events
235         https://bugs.webkit.org/show_bug.cgi?id=40324
236
237         * DumpRenderTree/qt/EventSenderQt.cpp:
238         (EventSender::contextClick):
239
240 2010-06-14  Tony Chang  <tony@chromium.org>
241
242         Reviewed by Darin Fisher.
243
244         [chromium] checkout chromium third_party directly
245         https://bugs.webkit.org/show_bug.cgi?id=40556
246
247         * Scripts/update-webkit-chromium: some migration code for the bots
248
249 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
250
251         Chromium build fix.
252
253         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
254         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
255
256 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
257
258         Reviewed by Darin Adler.
259
260         https://bugs.webkit.org/show_bug.cgi?id=40529
261         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
262
263         * DumpRenderTree/mac/EventSendingController.mm:
264         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
265         event for "delete" - it had virtual key code from forward delete, and text from backspace.
266         Fixed "delete" to mean forward delete.
267
268         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
269         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
270         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
271         Mac DRT confusion has propagated to other platforms, fixing those.
272
273 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
274
275         Reviewed by Xan Lopez.
276
277         Small GtkLauncher build fix for some systems.
278
279         * GtkLauncher/main.c: Add <limit.h> include.
280
281 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
282
283         Reviewed by Laszlo Gombos.
284
285         [Qt] navigator.geolocation support for Qt port
286         https://bugs.webkit.org/show_bug.cgi?id=39724
287
288         Implementation for geolocation cases to DumpRenderTreeQt
289
290         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
291         (WebCore::WebPage::allowGeolocationRequest):
292         * DumpRenderTree/qt/DumpRenderTreeQt.h:
293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
294         (LayoutTestController::setGeolocationPermission):
295         (LayoutTestController::setMockGeolocationError):
296         (LayoutTestController::setMockGeolocationPosition):
297         * DumpRenderTree/qt/LayoutTestControllerQt.h:
298         (LayoutTestController::isGeolocationPermissionSet):
299         (LayoutTestController::geolocationPermission):
300
301 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
302
303         Reviewed by Darin Adler.
304
305         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
306         be a way of overwriting the Xcode system path.  Making
307         $WEBKITOUTPUTDIR take precedence over the system default would make
308         this possible.
309
310         * Scripts/webkitdirs.pm:
311
312 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
313
314         Reviewed by Darin Adler.
315
316         AX: link won't return linked element if URL contains #
317         https://bugs.webkit.org/show_bug.cgi?id=40192
318
319         * DumpRenderTree/AccessibilityUIElement.cpp:
320         (linkedUIElementAtIndexCallback):
321         (AccessibilityUIElement::getJSClass):
322         * DumpRenderTree/AccessibilityUIElement.h:
323         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
324         (AccessibilityUIElement::linkedUIElementAtIndex):
325         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
326         (AccessibilityUIElement::linkedUIElementAtIndex):
327         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
328         (AccessibilityUIElement::linkedUIElementAtIndex):
329
330 2010-06-13  Adam Barth  <abarth@webkit.org>
331
332         Reviewed by Darin Adler.
333
334         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
335         https://bugs.webkit.org/show_bug.cgi?id=39550
336
337         This can cause an extra request to bugs.webkit.org durig upload, but it
338         shouldn't be too bad.  Also, this won't work if you remove the
339         boilerplate created by prepare-ChangeLog.
340
341         * Scripts/webkitpy/common/checkout/changelog.py:
342         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
343         * Scripts/webkitpy/common/net/bugzilla.py:
344         * Scripts/webkitpy/tool/steps/abstractstep.py:
345         * Scripts/webkitpy/tool/steps/preparechangelog.py:
346         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
347
348 2010-06-08  Robert Hogan  <robert@webkit.org>
349
350         Reviewed by Eric Seidel.
351
352         [Qt] Add support for callShouldCloseOnWebView() to DRT
353         https://bugs.webkit.org/show_bug.cgi?id=40330
354
355         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
356         (LayoutTestController::callShouldCloseOnWebView):
357         * DumpRenderTree/qt/LayoutTestControllerQt.h:
358         (LayoutTestController::setCallCloseOnWebViews):
359
360 2010-06-12  Eric Seidel  <eric@webkit.org>
361
362         Reviewed by Daniel Bates.
363
364         do-webcore-rename should have a --verbose option
365         https://bugs.webkit.org/show_bug.cgi?id=40497
366
367         * Scripts/do-webcore-rename:
368          - Unified how we handle skipping files/directories
369            this will allow us to "black list" certain files and
370            directories when performing renames.
371          - Made do-webcore-rename log what it's skipping when passed --verbose.
372
373 2010-06-12  Darin Adler  <darin@apple.com>
374
375         * Scripts/run-bindings-tests: Fixed a typo in a message.
376
377 2010-06-12  Kent Tamura  <tkent@chromium.org>
378
379         Reviewed by Dimitri Glazkov.
380
381         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
382         https://bugs.webkit.org/show_bug.cgi?id=40402
383
384         _build_path() of each Chromium port check existence of build path
385         of Chromium checkout first, then check existence of build path of
386         WebKit-only checkout.
387
388         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
389         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
390         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
391
392 2010-06-12  Robert Hogan  <robert@webkit.org>
393
394         Reviewed by Kenneth Rohde Christiansen.
395
396         [Qt] Back-forward list dumping is incorrect
397
398         https://bugs.webkit.org/show_bug.cgi?id=36392
399
400         Support dumping child history items in DRT.
401
402         Unskip:
403
404         fast/loader/frame-src-change-added-to-history.html
405         fast/loader/frame-src-change-not-added-to-history.html
406         fast/loader/frame-location-change-not-added-to-history.html
407
408         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
409         (WebCore::dumpHistoryItem):
410
411 2010-06-10  Ojan Vafai  <ojan@chromium.org>
412
413         Reviewed by Eric Seidel.
414
415         upload all patches that lack in-rietveld to rietveld
416         https://bugs.webkit.org/show_bug.cgi?id=40444
417
418         If it's a patch, then we'll try to upload it as long as it
419         doesn't have in-rietveld set. No longer set in-rietveld? since
420         it's not needed.
421
422         * Scripts/webkitpy/common/net/bugzilla.py:
423
424 2010-06-10  Ojan Vafai  <ojan@chromium.org>
425
426         Reviewed by Darin Fisher.
427
428         Fix rietveld upload when message length > 100 characters
429         https://bugs.webkit.org/show_bug.cgi?id=40457
430
431         * Scripts/webkitpy/common/net/rietveld.py:
432
433 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
434
435         Reviewed by Laszlo Gombos.
436
437         [Qt] There should be a way to enable popups in QtTestBrowser
438         https://bugs.webkit.org/show_bug.cgi?id=40427
439
440         * QtTestBrowser/main.cpp:
441         (LauncherWindow::toggleJavascriptCanOpenWindows):
442         (LauncherWindow::createChrome):
443
444 2010-06-10  Adam Barth  <abarth@webkit.org>
445
446         Reviewed by Daniel Bates.
447
448         Make SheriffBot more chatty
449         https://bugs.webkit.org/show_bug.cgi?id=40463
450
451         People seem to like to talk to SheriffBot, so let's make him chat back.
452
453         * Scripts/webkitpy/thirdparty/__init__.py:
454         * Scripts/webkitpy/tool/bot/irc_command.py:
455         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
456         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
457         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
458
459 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
460
461         Reviewed by Darin Adler.
462
463         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
464         
465         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
466         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
467         WEXITSTATUS on $result instead of just comparing $result to 0.
468
469         * Scripts/update-webkit-auxiliary-libs:
470
471 2010-06-10  Ojan Vafai  <ojan@chromium.org>
472
473         Reviewed by Alexey Proskuryakov.
474
475         don't use Exception.message as it's deprecated in python 2.6+
476         https://bugs.webkit.org/show_bug.cgi?id=40449
477
478         * Scripts/webkitpy/tool/commands/queues.py:
479
480 2010-06-10  Ojan Vafai  <ojan@chromium.org>
481
482         Reviewed by Adam Barth.
483
484         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
485         https://bugs.webkit.org/show_bug.cgi?id=40436
486
487         * Scripts/webkitpy/common/system/outputcapture.py:
488         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
489         * Scripts/webkitpy/tool/commands/queues.py:
490         * Scripts/webkitpy/tool/commands/queues_unittest.py:
491         * Scripts/webkitpy/tool/commands/queuestest.py:
492         * Scripts/webkitpy/tool/mocktool.py:
493
494 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
495
496         Reviewed by Simon Hausmann.
497
498         [Qt] *All* WebGL layout tests fail!
499         https://bugs.webkit.org/show_bug.cgi?id=40296
500
501         Added test for WebKitWebGLEnabled to
502         LayoutTestController::overridePreference().
503
504         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
505         (LayoutTestController::overridePreference):
506
507 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
508
509         Reviewed by Kenneth Rohde Christiansen.
510
511         [Qt] DRT EventSender support to graphics mouse events activation
512         https://bugs.webkit.org/show_bug.cgi?id=40017
513
514         * DumpRenderTree/qt/EventSenderQt.cpp:
515         (EventSender::mouseDown):
516         (EventSender::mouseUp):
517         (EventSender::mouseMoveTo):
518         (EventSender::keyDown):
519         (EventSender::contextClick):
520         (EventSender::sendTouchEvent):
521         (EventSender::sendOrQueueEvent):
522         (EventSender::eventFilter):
523         (EventSender::createGraphicsSceneMouseEvent):
524         (EventSender::sendEvent):
525         * DumpRenderTree/qt/EventSenderQt.h:
526         (EventSender::isGraphicsBased):
527
528 2010-06-09  Adam Barth  <abarth@webkit.org>
529
530         Reviewed by Ojan Vafai.
531
532         webkit-patch upload fails for security bugs because there's no rietveld flag
533         https://bugs.webkit.org/show_bug.cgi?id=40309
534
535         There's probably a more elegant way of seeing whether the form control
536         exists, but this seems to work.
537
538         * Scripts/webkitpy/common/net/bugzilla.py:
539
540 2010-06-09  Ojan Vafai  <ojan@chromium.org>
541
542         Reviewed by Adam Barth.
543
544         make rietveld upload faster and avoid posting to bug on errors
545         https://bugs.webkit.org/show_bug.cgi?id=40389
546
547         Only grab the first item of the upload queue instead of trying
548         to compute the whole list upfront (which is O(n) bugzilla lookups!).
549
550         Also, don't post comments to the bug when uploading fails.
551
552         * Scripts/webkitpy/common/net/bugzilla.py:
553         * Scripts/webkitpy/tool/commands/queues.py:
554         * Scripts/webkitpy/tool/commands/queues_unittest.py:
555         * Scripts/webkitpy/tool/commands/stepsequence.py:
556         * Scripts/webkitpy/tool/mocktool.py:
557
558 2010-06-09  Ojan Vafai  <ojan@chromium.org>
559
560         Reviewed by Adam Barth.
561
562         Rietveld upload queue fails when setting in-rietveld flag
563         https://bugs.webkit.org/show_bug.cgi?id=40371
564
565         Make the comment arguments to set_flag_on_attachment optional
566         and add it to the MockBugzilla.
567
568         * Scripts/webkitpy/common/net/bugzilla.py:
569         * Scripts/webkitpy/tool/bot/queueengine.py:
570         * Scripts/webkitpy/tool/commands/download_unittest.py:
571         * Scripts/webkitpy/tool/commands/queues.py:
572         * Scripts/webkitpy/tool/commands/queues_unittest.py:
573         * Scripts/webkitpy/tool/mocktool.py:
574
575 2010-06-09  Kenneth Russell  <kbr@google.com>
576
577         Reviewed by Dimitri Glazkov.
578
579         Rename FloatArray to Float32Array
580         https://bugs.webkit.org/show_bug.cgi?id=40323
581
582         Used do-webcore-rename to perform renaming. Manually undid
583         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
584         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
585         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
586         all layout tests on Safari; built Chromium and ran selected WebGL
587         tests.
588
589         * Scripts/do-webcore-rename:
590
591 2010-06-08  Tony Chang  <tony@chromium.org>
592
593         Reviewed by David Levin.
594
595         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
596         https://bugs.webkit.org/show_bug.cgi?id=40285
597
598         * Scripts/webkitdirs.pm:
599         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
600
601 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
602
603         Reviewed by Tamura Kent.
604
605         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
606         https://bugs.webkit.org/show_bug.cgi?id=40052
607         
608         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
609
610         * DumpRenderTree/DumpRenderTree.gypi:
611         * DumpRenderTree/chromium/TestShellWin.cpp:
612         (platformInit):
613         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
614         (WebKit::):
615         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
616         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
617         (WebKit::WebThemeControlDRT::box):
618         (WebKit::WebThemeControlDRT::line):
619         (WebKit::WebThemeControlDRT::triangle):
620         (WebKit::WebThemeControlDRT::roundRect):
621         (WebKit::WebThemeControlDRT::oval):
622         (WebKit::WebThemeControlDRT::circle):
623         (WebKit::WebThemeControlDRT::nestedBoxes):
624         (WebKit::WebThemeControlDRT::markState):
625         (WebKit::WebThemeControlDRT::draw):
626         (WebKit::WebThemeControlDRT::drawTextField):
627         (WebKit::WebThemeControlDRT::drawProgressBar):
628         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
629         (WebKit::WebThemeControlDRT::):
630         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
631         (WebKit::):
632         (WebKit::WebThemeEngineDRT::paintButton):
633         (WebKit::WebThemeEngineDRT::paintMenuList):
634         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
635         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
636         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
637         (WebKit::WebThemeEngineDRT::paintTextField):
638         (WebKit::WebThemeEngineDRT::paintTrackbar):
639         (WebKit::WebThemeEngineDRT::paintProgressBar):
640         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
641         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
642
643 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
644
645         Unreviewed, rolling out r60878.
646         http://trac.webkit.org/changeset/60878
647         https://bugs.webkit.org/show_bug.cgi?id=40349
648
649         broke linux build (Requested by tony^work on #webkit).
650
651         * Scripts/webkitdirs.pm:
652         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
653
654 2010-06-08  Tony Chang  <tony@chromium.org>
655
656         Reviewed by David Levin.
657
658         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
659         https://bugs.webkit.org/show_bug.cgi?id=40285
660
661         * Scripts/webkitdirs.pm:
662         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
663
664 2010-06-08  Kenneth Russell  <kbr@google.com>
665
666         Unreviewed, build fix.
667
668         Fix build breakage from 38145
669         https://bugs.webkit.org/show_bug.cgi?id=40346
670
671         The fix for bug 38145 broke the Chromium Win build because
672         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
673         change log2(x) to log(x) / log(2). Built and ran WebGL layout
674         tests in Safari on Mac OS X. Changed download mirrors for
675         python-irclib to working ones.
676
677         * Scripts/webkitpy/thirdparty/__init__.py:
678
679 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
680
681         Reviewed by Eric Seidel.
682
683         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
684         https://bugs.webkit.org/show_bug.cgi?id=39058
685
686         * Scripts/old-run-webkit-tests:
687          use sourceDir() to find ensure-valid-python in checkPythonVersion()
688
689 2010-06-08  Andras Becsi  <abecsi@webkit.org>
690
691         Unreviewed buildfix after r60479.
692
693         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
694         versions other than 2.17.3.
695
696         * DumpRenderTree/gtk/EventSender.cpp:
697         (getRootCoords):
698
699 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
700
701         Reviewed by Oliver Hunt.
702
703         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
704         https://bugs.webkit.org/show_bug.cgi?id=40267
705
706         When a mouse button is down, automatically queue mouse motion events and
707         do not play them back until the mouse button is released. This matches the
708         behavior of other ports' EventSenders.
709
710         * DumpRenderTree/gtk/EventSender.cpp:
711         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
712         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
713
714 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
715
716         Reviewed by Sam Weinig.
717
718         Add CPP bindings generator
719         https://bugs.webkit.org/show_bug.cgi?id=38279
720
721         Integrate CPP bindings in run-bindings-tests.
722
723         * Scripts/run-bindings-tests:
724
725 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
726
727         Reviewed by Ojan Vafai.
728
729         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
730         https://bugs.webkit.org/show_bug.cgi?id=40183
731
732         * Scripts/webkitpy/tool/steps/preparechangelog.py:
733
734 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
735
736         Unreviewed.
737
738         Add my new email and IRC nick to committers.py.
739
740         * Scripts/webkitpy/common/config/committers.py:
741
742 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
743
744         Unreviewed.
745
746         Revert changes in json_results_generator.py's _get_svn_revision.
747
748         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
749
750 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
751
752         Reviewed by Xan Lopez.
753
754         [GTK] GtkLauncher should support relative file paths
755         https://bugs.webkit.org/show_bug.cgi?id=39944
756
757         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
758
759         * GtkLauncher/main.c:
760         (filename_to_url): Added.
761         (main): Try to resolve arguments as relative file URLs first.
762
763 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
764
765         Reviewed by Xan Lopez.
766
767         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
768         https://bugs.webkit.org/show_bug.cgi?id=40182
769
770         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
771         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
772         without breaking DRT.
773
774         * DumpRenderTree/gtk/EventSender.cpp:
775         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
776         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
777
778 2010-06-04  Anders Carlsson  <andersca@apple.com>
779
780         Reviewed by David Hyatt.
781
782         Make the editing/spelling/context-menu-suggestions.html test more robust
783         https://bugs.webkit.org/show_bug.cgi?id=40178
784
785         Change the contextClick method to return an array of strings describing the context menu items.
786
787         * DumpRenderTree/mac/EventSendingController.mm:
788         (+[EventSendingController isSelectorExcludedFromWebScript:]):
789         (+[EventSendingController webScriptNameForSelector:]):
790         (-[EventSendingController contextClick]):
791
792 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
793
794         Reviewed by Shinichiro Hamaji.
795
796         Clean up chromium-specific code from json_results_generator.py.
797         https://bugs.webkit.org/show_bug.cgi?id=39665
798
799         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
800         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
801         * Scripts/webkitpy/layout_tests/port/base.py:
802         * Scripts/webkitpy/layout_tests/port/chromium.py:
803
804 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
805
806         Reviewed by Adam Barth.
807
808         Utilize new takeFirst() method where appropriate.
809         https://bugs.webkit.org/show_bug.cgi?id=40089
810
811         * DumpRenderTree/chromium/EventSender.cpp:
812         (EventSender::replaySavedEvents):
813         * DumpRenderTree/chromium/LayoutTestController.cpp:
814         (LayoutTestController::WorkQueue::processWork):
815         (LayoutTestController::WorkQueue::reset):
816
817 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
818
819         Reviewed by Simon Hausmann.
820
821         [Qt] QtTestLauncher should allow notifications by default.
822         https://bugs.webkit.org/show_bug.cgi?id=40078
823
824         * QtTestBrowser/main.cpp:
825         (NotificationsPermissionController::NotificationsPermissionController):
826         (NotificationsPermissionController::checkPermission):
827         (NotificationsPermissionController::requestPermission):
828         (LauncherWindow::LauncherWindow):
829
830 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
831
832         Reviewed by Adam Barth.
833
834         Detect whether the user's environment can open a browser.
835         https://bugs.webkit.org/show_bug.cgi?id=40136
836
837         Some environments like cygwin silently fail webbrowser.open() causing
838         webkit-patch upload not to display any diff. This detects environments
839         where webbrowser.open() would fail by testing if webbrowser.get()
840         raises an exception.
841
842         * Scripts/webkitpy/common/system/user.py:
843         * Scripts/webkitpy/tool/mocktool.py:
844         * Scripts/webkitpy/tool/steps/confirmdiff.py:
845
846 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
847
848         Reviewed by David Levin.
849
850         Add dependencies required to link with VS Express 2005.
851         https://bugs.webkit.org/show_bug.cgi?id=40038
852
853         Visual Studio implicitly links against these libs.
854         VC++ Express does not.
855
856         * WebKitAPITest/WebKitAPITestCommon.vsprops:
857         * WinLauncher/WinLauncher.vcproj:
858
859 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
860
861         Reviewed by David Levin.
862
863         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
864         https://bugs.webkit.org/show_bug.cgi?id=40105
865
866         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
867         - kill pywebsocket process when url is not alive and the process is not
868           terminated, not to leave pywebsocket server running.
869         - fix codecs.open parameters.
870
871 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
872
873         Reviewed by Alexey Proskuryakov.
874
875         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
876         https://bugs.webkit.org/show_bug.cgi?id=39058
877
878         * Scripts/ensure-valid-python:
879           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
880           - Add --check-only and --help option.
881           - --check-only option only checks python version and don't try to install Python 2.5.
882           - Set executable bit.
883         * Scripts/old-run-webkit-tests:
884           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
885
886 2010-05-14  Ojan Vafai  <ojan@chromium.org>
887
888         Reviewed by Adam Barth.
889
890         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
891         https://bugs.webkit.org/show_bug.cgi?id=38918
892
893         Patches with in-rietveld? get uploaded to rietveld and get marked
894         in-rietveld+. If the upload fails, they are marked in-rietveld-
895         and an error is logged to the bug, like the commit-queue.
896
897         Also, get rid of --fancy-review and the ability to upload to rietveld
898         using webkit-patch upload/post.
899
900         * Scripts/webkitpy/common/net/bugzilla.py:
901         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
902         * Scripts/webkitpy/tool/commands/download.py:
903         * Scripts/webkitpy/tool/commands/download_unittest.py:
904         * Scripts/webkitpy/tool/commands/queues.py:
905         * Scripts/webkitpy/tool/commands/queues_unittest.py:
906         * Scripts/webkitpy/tool/commands/upload.py:
907         * Scripts/webkitpy/tool/commands/upload_unittest.py:
908         * Scripts/webkitpy/tool/mocktool.py:
909         * Scripts/webkitpy/tool/steps/options.py:
910         * Scripts/webkitpy/tool/steps/postcodereview.py:
911
912 2010-05-24  Ojan Vafai  <ojan@chromium.org>
913
914         Reviewed by Chris Jerdonek.
915
916         many webkit-patch commands fail in a non-svn tracking git checkout
917         https://bugs.webkit.org/show_bug.cgi?id=38156
918
919         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
920         If neither exists, then error out. This makes webkit-patch work
921         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
922         to checkout webkit. The fallback to master is for people who don't
923         do the steps on that page for tracking svn.
924
925         * Scripts/webkitpy/common/checkout/scm.py:
926         * Scripts/webkitpy/common/checkout/scm_unittest.py:
927
928 2010-06-03  Mike Fenton  <mifenton@rim.com>
929
930         Unreviewed.
931
932         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
933
934         * Scripts/webkitpy/common/config/committers.py:
935
936 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
937
938         Reviewed by Yury Semikhatsky.
939
940         Web Inspector: a number of fixes that make InspectorController
941         happy with null redirects.
942
943         https://bugs.webkit.org/show_bug.cgi?id=40109
944
945         * DumpRenderTree/gtk/DumpRenderTree.cpp:
946         (runTest):
947         * DumpRenderTree/mac/DumpRenderTree.mm:
948         (runTest):
949         * DumpRenderTree/win/DumpRenderTree.cpp:
950         (runTest):
951
952 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
953
954         Reviewed by Shinichiro Hamaji.
955
956         [Qt] Fix compilation with QT_NO_PROPERTIES
957         https://bugs.webkit.org/show_bug.cgi?id=38324
958
959         * QtTestBrowser/main.cpp:
960         (LauncherWindow::init):
961
962 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
963
964         Reviewed by Kenneth Rohde Christiansen.
965
966         [Qt] Make possible run DRT with QGraphicsWebView
967         https://bugs.webkit.org/show_bug.cgi?id=40016
968
969         Make possible to use a environment variable for switching backend.
970         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
971
972         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
973         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
974         (WebCore::DumpRenderTree::DumpRenderTree):
975         * DumpRenderTree/qt/DumpRenderTreeQt.h:
976         (WebCore::DumpRenderTree::setGraphicsBased):
977         (WebCore::DumpRenderTree::isGraphicsBased):
978         (WebCore::WebViewGraphicsBased::graphicsView):
979         (WebCore::WebViewGraphicsBased::setPage):
980         * Scripts/old-run-webkit-tests:
981
982 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
983
984         Reviewed by Eric Seidel.
985
986         Slave lost shouldn't be recognized as build failed.
987         https://bugs.webkit.org/show_bug.cgi?id=39282
988
989         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
990         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
991
992 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
993
994         Reviewed by Kenneth Rohde Christiansen.
995
996         [Qt] Fix the lifecycle of notification objects
997         https://bugs.webkit.org/show_bug.cgi?id=40003
998
999         Remove the dependency of notifications on QWebPage.
1000
1001         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1002         (WebCore::requestPermissionCallback):
1003         (WebCore::WebPage::WebPage):
1004         (WebCore::DumpRenderTree::requestPermission):
1005         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1006
1007 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1008
1009         Unreviewed, rolling out r60559.
1010         http://trac.webkit.org/changeset/60559
1011         https://bugs.webkit.org/show_bug.cgi?id=40055
1012
1013         It broke python unit test (Requested by Ossy on #webkit).
1014
1015         * Scripts/webkitpy/common/net/buildbot.py:
1016
1017 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
1018
1019         Reviewed by Eric Seidel.
1020
1021         Slave lost shouldn't be recognized as build failed.
1022         https://bugs.webkit.org/show_bug.cgi?id=39282
1023
1024         * Scripts/webkitpy/common/net/buildbot.py:
1025
1026 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
1027
1028         Reviewed by Eric Seidel.
1029
1030         Fix crash caused when assigned_to is disabled
1031         https://bugs.webkit.org/show_bug.cgi?id=40039
1032
1033         * Scripts/webkitpy/common/net/bugzilla.py:
1034
1035 2010-06-02  Sterling Swigart  <sswigart@google.com>
1036
1037         Reviewed by David Levin.
1038
1039         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
1040         https://bugs.webkit.org/show_bug.cgi?id=39906
1041
1042         * Scripts/build-webkit:
1043
1044 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
1045
1046         Reviewed by Simon Hausmann.
1047
1048         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
1049
1050         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1051         (WebCore::WebPage::WebPage):
1052         (WebCore::WebPage::resetSettings):
1053         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1054         (LayoutTestController::setJavaScriptCanAccessClipboard):
1055
1056 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1057
1058         Reviewed by Mark Rowe.
1059
1060         A nicer Tiger build fix.
1061
1062         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1063         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1064         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
1065
1066 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1067
1068         A real Tiger build fix.
1069
1070         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
1071         for all configurations, not just debug.
1072
1073 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1074
1075         Tiger build fix.
1076
1077         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
1078
1079 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1080
1081         Reviewed by Xan Lopez.
1082
1083         [GTK] Get more mouse tests passing
1084         https://bugs.webkit.org/show_bug.cgi?id=39040
1085
1086         Reproduce the logic from the Windows EventSender for mapping
1087         button numbers to GDK button numbers. Move this logic to the
1088         prepareMouseButtonEvent helper.
1089
1090         * DumpRenderTree/gtk/EventSender.cpp:
1091         (prepareMouseButtonEvent): Reproduce Windows logic.
1092         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
1093         (mouseDownCallback): Ditto.
1094         (mouseUpCallback): Ditto.
1095
1096 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Reviewed by Sam Weinig.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=39434
1101         REGRESSION (r59811): Geolocation callbacks cannot be created
1102
1103         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
1104
1105         * DumpRenderTree/mac/DumpRenderTree.mm:
1106         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
1107         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
1108         into subsequent tests.
1109
1110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1111         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
1112         (LayoutTestController::setMockGeolocationError): Ditto.
1113
1114         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
1115         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
1116         (+[MockGeolocationProvider shared]):
1117         (-[MockGeolocationProvider dealloc]):
1118         (-[MockGeolocationProvider setPosition:]):
1119         (-[MockGeolocationProvider setError:]):
1120         (-[MockGeolocationProvider registerWebView:]):
1121         (-[MockGeolocationProvider unregisterWebView:]):
1122         (-[MockGeolocationProvider lastPosition]):
1123         (-[MockGeolocationProvider stopTimer]):
1124         (-[MockGeolocationProvider timerFired]):
1125
1126         * DumpRenderTree/mac/UIDelegate.mm:
1127         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1128         This delegate method must send a response. I'm not sure what the two-stage check is supposed
1129         to achieve, it seems unnecessary.
1130
1131 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
1132
1133         Reviewed by Xan Lopez.
1134
1135         [GTK] Double clicks cause three button press events
1136         https://bugs.webkit.org/show_bug.cgi?id=38853
1137
1138         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
1139         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
1140         the GDK event queue entirely, we simply do not send the extra event.
1141
1142         * DumpRenderTree/gtk/EventSender.cpp:
1143         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
1144         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
1145
1146 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1147
1148         Not reviewed. Build fix.
1149
1150         Fix GTK+ build caused by a bad merge.
1151
1152         * DumpRenderTree/gtk/EventSender.cpp: 
1153         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
1154
1155 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
1156
1157         Reviewed by Xan Lopez.
1158
1159         [GTK] Double clicks cause three button press events
1160         https://bugs.webkit.org/show_bug.cgi?id=38853
1161
1162         Small EventSender cleanups. Consolidate some common code. Style fixes.
1163
1164         * DumpRenderTree/gtk/EventSender.cpp:
1165         (prepareMouseButtonEvent): Added.
1166         (contextClickCallback): Use prepareMouseButtonEvent.
1167         (mouseDownCallback): Use prepareMouseButtonEvent.
1168         (mouseUpCallback): Use prepareMouseButtonEvent.
1169         (mouseMoveToCallback): Small style fix.
1170
1171 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1172
1173         Reviewed by Xan Lopez.
1174
1175         [GTK] Double clicks cause three button press events
1176         https://bugs.webkit.org/show_bug.cgi?id=38853
1177
1178         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
1179         to pause for a specified amount of time. It is used in the processing of drag-
1180         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
1181         This patch enables tests that rely on the latter behavior to pass.
1182
1183         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1184         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
1185         * DumpRenderTree/gtk/EventSender.cpp:
1186         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
1187         (contextClickCallback): Use sendOrQueueEvent.
1188         (updateClickCount): Take the time offset into account when counting clicks.
1189         (mouseDownCallback): Use sendOrQueueEvent.
1190         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
1191         (mouseUpCallback): Use sendOrQueueEvent.
1192         (mouseMoveToCallback): Ditto.
1193         (mouseWheelToCallback): Ditto.
1194         (sendOrQueueEvent): Added.
1195         (dispatchEvent): Added.
1196         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
1197         (makeEventSender): Only initialize the EventSender when loading the top frame.
1198         * DumpRenderTree/gtk/EventSender.h: Ditto.
1199
1200 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1201
1202         Reviewed by Xan Lopez.
1203
1204         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
1205         https://bugs.webkit.org/show_bug.cgi?id=39101
1206
1207         Work around timing issues for render tree dumps by pumping the
1208         main loop before doing the dump. Resize events are asynchronous
1209         in GTK+, so sometimes resize requests are still pending when DRT
1210         dumps the tree.
1211
1212         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1213         (dump): Pump the main loop before dumping the render tree.
1214
1215 2010-05-31  Kent Tamura  <tkent@chromium.org>
1216
1217         Reviewed by Dimitri Glazkov.
1218
1219         [DRT/Chromium] Fix crash of a test after another test with multiple windows
1220         https://bugs.webkit.org/show_bug.cgi?id=39942
1221
1222         If a test opens multiple windows, focuses on non-main window, and
1223         the focused window is closed, TestShell::m_focusedWidget points a
1224         deleted object.
1225
1226         * DumpRenderTree/chromium/TestShell.cpp:
1227         (TestShell::closeWindow): Clear m_focusedWidget.
1228
1229 2010-05-30  Kent Tamura  <tkent@chromium.org>
1230
1231         Reviewed by Dimitri Glazkov.
1232
1233         new-run-webkit-tests: Support DRT on Chromium-win
1234         https://bugs.webkit.org/show_bug.cgi?id=39810
1235
1236         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
1237         it behaves like test_shell about command analysis, printing
1238         format, pixel dumping, and timeout handling.
1239
1240         chromium.py and chromium_win.py supports the --test-shell flag and
1241         DRT/Chromium-win binary names.
1242         
1243         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
1244         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1245         (runTest): Support for test_shell-style command.
1246         (main): Introduce --test-shell.
1247         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
1248         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
1249           TestEventPrinter class manages stdio output and image output.
1250           TestEventPrinter.cpp has two implementations; DRTPrinter and
1251           TestShellPrinter.
1252         * DumpRenderTree/chromium/TestShell.cpp:
1253           Some changes for TestEventPrinter.
1254         (TestShell::TestShell):
1255         (TestShell::runFileTest):
1256         (TestShell::testTimedOut):
1257         (TestShell::dump):
1258         (TestShell::dumpImage):
1259         * DumpRenderTree/chromium/TestShell.h:
1260         (TestShell::printer):
1261         (TestShell::layoutTestTimeout):
1262         (TestShell::layoutTestTimeoutForWatchDog):
1263         (TestShell::setLayoutTestTimeout):
1264         * DumpRenderTree/chromium/TestShellWin.cpp:
1265         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
1266         * Scripts/webkitpy/layout_tests/port/chromium.py:
1267         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1268
1269 2010-05-30  Robert Hogan  <robert@webkit.org>
1270
1271         Reviewed by Kenneth Rohde Christiansen.
1272
1273         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
1274
1275         https://bugs.webkit.org/show_bug.cgi?id=36004
1276
1277         * DumpRenderTree/qt/EventSenderQt.cpp:
1278         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
1279                                     Scrollbar::pixelsPerLineStep() for DRT testing.
1280         (EventSender::mouseScrollBy): Added
1281         (EventSender::continuousMouseScrollBy): Added
1282         * DumpRenderTree/qt/EventSenderQt.h:
1283
1284 2010-05-28  Adam Barth  <abarth@webkit.org>
1285
1286         Reviewed by David Levin.
1287
1288         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
1289         https://bugs.webkit.org/show_bug.cgi?id=39546
1290
1291         One sublty is that we want to wait for the user to finish editing the
1292         ChangeLog before moving on to the next step.  That means we want to pass
1293         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
1294         we don't want them to have to exit the Xcode application.  For this reason,
1295         we create a new instance of the application with -n.
1296         
1297         Overall, xed seems like a better solution, so we recommend that too.
1298
1299         * Scripts/webkitpy/common/system/user.py:
1300         * Scripts/webkitpy/tool/mocktool.py:
1301         * Scripts/webkitpy/tool/steps/editchangelog.py:
1302
1303 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
1304
1305         Reviewed by Ojan Vafai.
1306
1307         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
1308         threads are wedged. Also, the script will print the results of the
1309         tests completed when the interrupt occurs.
1310
1311         https://bugs.webkit.org/show_bug.cgi?id=33238
1312
1313         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1314         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1315         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1316         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1317
1318 2010-05-28  Darin Adler  <darin@apple.com>
1319
1320         Ignore more Python messiness.
1321
1322         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
1323         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
1324         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
1325         * Scripts/webkitpy/test: Added property svn:ignore.
1326         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
1327
1328 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1329
1330         Reviewed by Beth Dakin.
1331
1332         Adding myself as a reviewer.
1333
1334         * Scripts/webkitpy/common/config/committers.py:
1335
1336 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1337
1338         Build fix. No review.
1339
1340         AX: need to catch NSAccessibilityExceptions in DRT
1341         https://bugs.webkit.org/show_bug.cgi?id=39881
1342
1343         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
1344
1345         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1346         (AccessibilityUIElement::rowIndexRange):
1347         (AccessibilityUIElement::columnIndexRange):
1348         (AccessibilityUIElement::selectedTextRange):
1349
1350 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1351
1352         Reviewed by Darin Adler.
1353
1354         AX: need to catch NSAccessibilityExceptions in DRT
1355         https://bugs.webkit.org/show_bug.cgi?id=39881
1356
1357         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
1358         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
1359   
1360         So DRT should wrap exception handlers around its AX related calls.
1361
1362         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1363         (attributesOfElement):
1364         (AccessibilityUIElement::getLinkedUIElements):
1365         (AccessibilityUIElement::getDocumentLinks):
1366         (AccessibilityUIElement::getChildren):
1367         (AccessibilityUIElement::getChildrenWithRange):
1368         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1369         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1370         (AccessibilityUIElement::disclosedRowAtIndex):
1371         (AccessibilityUIElement::selectedRowAtIndex):
1372         (AccessibilityUIElement::titleUIElement):
1373         (AccessibilityUIElement::parentElement):
1374         (AccessibilityUIElement::disclosedByRow):
1375         (AccessibilityUIElement::stringAttributeValue):
1376         (AccessibilityUIElement::boolAttributeValue):
1377         (AccessibilityUIElement::isAttributeSettable):
1378         (AccessibilityUIElement::isAttributeSupported):
1379         (AccessibilityUIElement::role):
1380         (AccessibilityUIElement::subrole):
1381         (AccessibilityUIElement::roleDescription):
1382         (AccessibilityUIElement::title):
1383         (AccessibilityUIElement::description):
1384         (AccessibilityUIElement::orientation):
1385         (AccessibilityUIElement::stringValue):
1386         (AccessibilityUIElement::language):
1387         (AccessibilityUIElement::helpText):
1388         (AccessibilityUIElement::x):
1389         (AccessibilityUIElement::y):
1390         (AccessibilityUIElement::width):
1391         (AccessibilityUIElement::height):
1392         (AccessibilityUIElement::clickPointX):
1393         (AccessibilityUIElement::clickPointY):
1394         (AccessibilityUIElement::intValue):
1395         (AccessibilityUIElement::minValue):
1396         (AccessibilityUIElement::maxValue):
1397         (AccessibilityUIElement::valueDescription):
1398         (AccessibilityUIElement::insertionPointLineNumber):
1399         (AccessibilityUIElement::isActionSupported):
1400         (AccessibilityUIElement::isEnabled):
1401         (AccessibilityUIElement::isRequired):
1402         (AccessibilityUIElement::isSelected):
1403         (AccessibilityUIElement::isExpanded):
1404         (AccessibilityUIElement::hierarchicalLevel):
1405         (AccessibilityUIElement::ariaIsGrabbed):
1406         (AccessibilityUIElement::ariaDropEffects):
1407         (AccessibilityUIElement::lineForIndex):
1408         (AccessibilityUIElement::boundsForRange):
1409         (AccessibilityUIElement::stringForRange):
1410         (AccessibilityUIElement::attributesOfColumnHeaders):
1411         (AccessibilityUIElement::attributesOfRowHeaders):
1412         (AccessibilityUIElement::attributesOfColumns):
1413         (AccessibilityUIElement::attributesOfRows):
1414         (AccessibilityUIElement::attributesOfVisibleCells):
1415         (AccessibilityUIElement::attributesOfHeader):
1416         (AccessibilityUIElement::rowCount):
1417         (AccessibilityUIElement::columnCount):
1418         (AccessibilityUIElement::indexInTable):
1419         (AccessibilityUIElement::rowIndexRange):
1420         (AccessibilityUIElement::columnIndexRange):
1421         (AccessibilityUIElement::cellForColumnAndRow):
1422         (AccessibilityUIElement::selectedTextRange):
1423         (AccessibilityUIElement::setSelectedTextRange):
1424         (AccessibilityUIElement::increment):
1425         (AccessibilityUIElement::decrement):
1426         (AccessibilityUIElement::showMenu):
1427         (AccessibilityUIElement::press):
1428         (AccessibilityUIElement::url):
1429         (AccessibilityUIElement::hasPopup):
1430
1431 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
1432
1433         Reviewed by Laszlo Gombos.
1434
1435         [Qt] Pass all web notification layout tests
1436         https://bugs.webkit.org/show_bug.cgi?id=39146
1437
1438         Mimic Chromium's test_shell security model in Qt's DRT.
1439         It makes a list of origins which were granted permission to display
1440         notifications, and only those origins can display notifications.
1441
1442         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1443         (WebCore::checkPermissionCallback):
1444         (WebCore::requestPermissionCallback):
1445         (WebCore::WebPage::WebPage):
1446         (WebCore::DumpRenderTree::checkPermission):
1447         (WebCore::DumpRenderTree::requestPermission):
1448         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1450         (LayoutTestController::reset):
1451         (LayoutTestController::grantDesktopNotificationPermission):
1452         (LayoutTestController::checkDesktopNotificationPermission):
1453         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1454
1455 2010-05-27  Philippe Normand  <pnormand@igalia.com>
1456
1457         Reviewed by Shinichiro Hamaji.
1458
1459         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
1460         https://bugs.webkit.org/show_bug.cgi?id=39372
1461
1462         Don't warn about NULL in g_*() calls. Zero can't be used instead
1463         for calls like g_build_filename and g_object_get/set.
1464
1465         * Scripts/webkitpy/style/checkers/cpp.py:
1466         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1467
1468 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
1469
1470         Reviewed by Kenneth Rohde Christiansen.
1471
1472         [Qt] Platform plugin example
1473         https://bugs.webkit.org/show_bug.cgi?id=39489
1474
1475         Exempting directory WebKit/qt/examples/ from style guide.
1476
1477         * Scripts/webkitpy/style/checker.py:
1478
1479 2010-05-26  Philippe Normand  <pnormand@igalia.com>
1480
1481         Reviewed by David Levin.
1482
1483         [style] Allow usage of NULL in gst_*_many()
1484         https://bugs.webkit.org/show_bug.cgi?id=39740
1485
1486         Don't warn if NULL is used by gst_*_many() functions. Zero can't
1487         be used for the reason explained in Bug 32858.
1488
1489         * Scripts/webkitpy/style/checkers/cpp.py:
1490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1491
1492 2010-05-27  Adam Barth  <abarth@webkit.org>
1493
1494         Reviewed by Eric Seidel.
1495
1496         Update script to run the normal version of the parser tests.
1497
1498         * Scripts/test-html5-parser:
1499
1500 2010-05-27  Adam Barth  <abarth@webkit.org>
1501
1502         Reviewed by Eric Seidel.
1503
1504         Add HTML5 parser support to run-webkit-tests
1505         https://bugs.webkit.org/show_bug.cgi?id=39815
1506
1507         * Scripts/old-run-webkit-tests:
1508
1509 2010-05-26  Adam Barth  <abarth@webkit.org>
1510
1511         Reviewed by Eric Seidel.
1512
1513         Make HTML5 lexer not ASSERT when resuming partial parses
1514         https://bugs.webkit.org/show_bug.cgi?id=39755
1515
1516         Add webkit-resumer.html to the HTML5 parser test suite.
1517
1518         * Scripts/test-html5-parser:
1519
1520 2010-05-24  Tony Chang  <tony@chromium.org>
1521
1522         Reviewed by Kent Tamura.
1523
1524         [chromium] setup fonts on chromium linux DRT
1525         https://bugs.webkit.org/show_bug.cgi?id=39644
1526
1527         * DumpRenderTree/chromium/TestShellGtk.cpp:
1528         (setupFontconfig):
1529         (platformInit):
1530         * DumpRenderTree/chromium/WebViewHost.cpp:
1531         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
1532         * DumpRenderTree/chromium/fonts.conf: Added.
1533
1534 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
1535
1536         Reviewed by Dimitri Glazkov.
1537
1538         Re-commit r58765 - it had been rolled out to see if it was causing
1539         a perf regression (in r59787 and r59789), but that does not seem to
1540         have been the case.
1541
1542         https://bugs.webkit.org/show_bug.cgi?id=39605
1543
1544         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1545         (NotificationPresenter::show):
1546
1547 2010-05-25  Ojan Vafai  <ojan@chromium.org>
1548
1549         Reviewed by Chris Jerdonek.
1550
1551         remove suppression of rietveld logging
1552         https://bugs.webkit.org/show_bug.cgi?id=39693
1553
1554         Now that we only upload to rietveld explicitly, e.g. on the bot
1555         or via webkit-patch post-attachment-to-rietveld, we should print
1556         all the rietveld logging. It was suppressed before to avoid making
1557         webkit-patch upload too noisy.
1558
1559         * Scripts/webkitpy/common/net/rietveld.py:
1560
1561 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
1562
1563         Reviewed by Ojan Vafai.
1564
1565         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
1566         https://bugs.webkit.org/show_bug.cgi?id=39680
1567
1568         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
1569
1570         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1571         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1572         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1573         (LayoutTestController::setEditingBehavior):
1574
1575 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1576
1577         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
1578
1579         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1580         (LayoutTestController::setEditingBehavior):
1581         * wx/build/settings.py:
1582
1583 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
1584
1585         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
1586
1587         editingBehavior settings needs to be set back to a reasonable default between tests
1588         https://bugs.webkit.org/show_bug.cgi?id=39433
1589
1590         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
1591         so that the serialized version of the setting stays in sync with expectations.
1592
1593         * DumpRenderTree/chromium/TestShell.cpp:
1594         (TestShell::resetWebSettings):
1595         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1596         (resetDefaultsToConsistentValues):
1597
1598 2010-05-24  Eric Seidel  <eric@webkit.org>
1599
1600         Reviewed by Adam Barth.
1601
1602         webkit-patch land calls scm.changed_files 4 times!
1603         https://bugs.webkit.org/show_bug.cgi?id=39584
1604
1605         * Scripts/webkitpy/tool/commands/download_unittest.py:
1606          - Assert that we don't call modified_changelogs too often.
1607         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1608          - Use cached changelogs list instead of calling modified_changelogs directly.
1609         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1610          - ditto.
1611
1612 2010-05-24  Kent Tamura  <tkent@chromium.org>
1613
1614         Reviewed by Dimitri Glazkov.
1615
1616         [DRT/Chromium] Import layout_test_helper for Windows
1617         https://bugs.webkit.org/show_bug.cgi?id=39581
1618
1619         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
1620         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
1621
1622         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
1623
1624 2010-05-24  Kent Tamura  <tkent@chromium.org>
1625
1626         Reviewed by Dimitri Glazkov.
1627
1628         [DRT/Chromium] Reset frame name
1629         https://bugs.webkit.org/show_bug.cgi?id=39586
1630
1631         This change fixes about 70 unexpected results.
1632
1633         * DumpRenderTree/chromium/WebViewHost.cpp:
1634         (WebViewHost::reset):
1635
1636 2010-05-24  Marcus Bulach  <bulach@chromium.org>
1637
1638         Reviewed by Kent Tamura.
1639
1640         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
1641         https://bugs.webkit.org/show_bug.cgi?id=39587
1642
1643         * DumpRenderTree/chromium/WebViewHost.cpp:
1644         (WebViewHost::geolocationService):
1645
1646 2010-05-24  Robert Hogan  <robert@webkit.org>
1647
1648         Reviewed by Laszlo Gombos.
1649
1650         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1651
1652         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
1653
1654         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1655         https://bugs.webkit.org/show_bug.cgi?id=39565
1656
1657         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1658         (LayoutTestController::removeOriginAccessWhitelistEntry):
1659
1660 2010-05-24  Marcus Bulach  <bulach@google.com>
1661
1662         Reviewed by Ojan Vafai.
1663
1664         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
1665         https://bugs.webkit.org/show_bug.cgi?id=39603
1666
1667         * Scripts/webkitpy/common/checkout/scm.py:
1668
1669 == Rolled over to ChangeLog-2010-05-24 ==