2010-09-04 Lucas De Marchi <lucas.demarchi@profusion.mobi>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [EFL] Move test browser to WebKitTools directory
6         https://bugs.webkit.org/show_bug.cgi?id=45212
7
8         Follow other ports like QT and GTK which moved the test browser to
9         WebKitTools directory.
10
11         * CMakeListsEfl.txt: Added.
12         * EWebLauncher/main.c: Added.
13         (print_history):
14         (zoom_level_set):
15         (on_ecore_evas_resize):
16         (title_set):
17         (viewport_set):
18         (on_title_changed):
19         (on_progress):
20         (on_load_finished):
21         (on_toolbars_visible_set):
22         (on_toolbars_visible_get):
23         (on_statusbar_visible_set):
24         (on_statusbar_visible_get):
25         (on_scrollbars_visible_set):
26         (on_scrollbars_visible_get):
27         (on_menubar_visible_set):
28         (on_menubar_visible_get):
29         (on_tooltip_text_set):
30         (on_inputmethod_changed):
31         (on_viewport_changed):
32         (on_mouse_down):
33         (on_focus_out):
34         (on_focus_in):
35         (on_resized):
36         (on_key_down):
37         (on_browser_del):
38         (on_closeWindow):
39         (quit):
40         (browserCreate):
41         (browserDestroy):
42         (closeWindow):
43         (main_signal_exit):
44         (findThemePath):
45         (main):
46
47 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
48
49         Reviewed by Adam Roben.
50
51         Set project dependencies so that they build serially. This fixes
52         issues when running run-webkit-tests if DRT is not built yet.
53
54         * DumpRenderTree/DumpRenderTree.sln:
55
56 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
57
58         Reviewed by Adam Barth.
59
60         Fix reading configuraiton in NWRT to work on Windows.
61         https://bugs.webkit.org/show_bug.cgi?id=45180
62
63         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
64             with the file otherwise.
65
66 2010-09-03  Chris Rogers  <crogers@google.com>
67
68         Unreviewed
69
70         Add myself to the committers list
71         https://bugs.webkit.org/show_bug.cgi?id=45189
72
73         * Scripts/webkitpy/common/config/committers.py:
74
75 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
76
77         Reviewed by Yury Semikhatsky.
78
79         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
80         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
81         https://bugs.webkit.org/show_bug.cgi?id=45137
82
83         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
84
85 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
86
87         Reviewed by Eric Seidel.
88
89         Add feature detection support to NRWT.
90         https://bugs.webkit.org/show_bug.cgi?id=41842
91
92         * Scripts/webkitpy/layout_tests/port/base.py:
93         * Scripts/webkitpy/layout_tests/port/qt.py:
94         * Scripts/webkitpy/layout_tests/port/webkit.py:
95         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
96
97 2010-09-03  Hironori Bono  <hbono@chromium.org>
98
99         Reviewed by Kent Tamura.
100
101         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
102         and implements it for Mac.
103         https://bugs.webkit.org/show_bug.cgi?id=41832
104
105         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
106         and bind it so we can call it from JavaScript.
107         (+[TextInputController isSelectorExcludedFromWebScript:]):
108         (+[TextInputController webScriptNameForSelector:]):
109         (-[TextInputController hasSpellingMarker:length:]):
110
111 2010-09-02  Eric Seidel  <eric@webkit.org>
112
113         Reviewed by Adam Barth.
114
115         Add a unit test for commit-queue retries
116         https://bugs.webkit.org/show_bug.cgi?id=45162
117
118         I think commit-queue retries are not correctly avoiding
119         build and test on retries.  So I started testing the code.
120         Unfortunately this test did not find the bug.  But now
121         that we have the test we might as well keep it.
122         I also fixed a broken import in validate-committer-lists.
123
124         * Scripts/validate-committer-lists:
125         * Scripts/webkitpy/tool/commands/queues_unittest.py:
126
127 2010-09-02  Kent Tamura  <tkent@chromium.org>
128
129         Reviewed by Dimitri Glazkov.
130
131         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
132         https://bugs.webkit.org/show_bug.cgi?id=45091
133
134         Task.{cpp,h} introduces a simpler version of Chromium
135         base/task.h. It doesn't have TupleN and Method.
136
137         * DumpRenderTree/DumpRenderTree.gypi:
138          Add Task.cpp and Task.h
139         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
140         (DRTDevToolsAgent::DRTDevToolsAgent):
141         (DRTDevToolsAgent::reset):
142         (DRTDevToolsAgent::asyncCall):
143         (DRTDevToolsAgent::frontendLoaded):
144         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
145         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
146         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
147         (DRTDevToolsClient::DRTDevToolsClient):
148         (DRTDevToolsClient::~DRTDevToolsClient):
149         (DRTDevToolsClient::reset):
150         (DRTDevToolsClient::asyncCall):
151         * DumpRenderTree/chromium/DRTDevToolsClient.h:
152         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
153         * DumpRenderTree/chromium/EventSender.cpp:
154         (EventSender::EventSender):
155         (EventSender::reset):
156         (EventSender::scheduleAsynchronousClick):
157         * DumpRenderTree/chromium/EventSender.h:
158         (EventSender::taskList): Added to use MethodTask<T>.
159         * DumpRenderTree/chromium/LayoutTestController.cpp:
160         (LayoutTestController::LayoutTestController):
161         (LayoutTestController::WorkQueue::processWorkSoon):
162         (LayoutTestController::waitUntilDone):
163         (LayoutTestController::notifyDone):
164         (LayoutTestController::reset):
165         * DumpRenderTree/chromium/LayoutTestController.h:
166         (LayoutTestController::taskList): Added to use MethodTask<T>.
167         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
168         * DumpRenderTree/chromium/NotificationPresenter.cpp:
169         (deferredDisplayDispatch):
170         (NotificationPresenter::show):
171         * DumpRenderTree/chromium/Task.cpp: Added.
172         * DumpRenderTree/chromium/Task.h: Added.
173
174 2010-09-02  Steve Block  <steveblock@google.com>
175
176         Reviewed by Adam Barth.
177
178         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
179         https://bugs.webkit.org/show_bug.cgi?id=43181
180
181         * DumpRenderTree/mac/DumpRenderTree.mm:
182         (createWebViewAndOffscreenWindow):
183         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
184         (LayoutTestController::setMockDeviceOrientation):
185
186 2010-08-31  Adam Roben  <aroben@apple.com>
187
188         Fix flashiness when resizing the browser window on Windows
189
190         Reviewed by Sam Weinig.
191
192         * MiniBrowser/win/BrowserWindow.cpp:
193         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
194         periodically fill the window with white.
195
196 2010-09-02  Peter Kasting  <pkasting@google.com>
197
198         Reviewed by Dimitri Glazkov.
199
200         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
201         https://bugs.webkit.org/show_bug.cgi?id=45073
202
203         * DumpRenderTree/chromium/EventSender.cpp:
204         (EventSender::EventSender):
205         (EventSender::mouseScrollBy):
206         (EventSender::continuousMouseScrollBy):
207         (EventSender::sendCurrentTouchEvent):
208         (EventSender::handleMouseWheel):
209         * DumpRenderTree/chromium/EventSender.h:
210         * DumpRenderTree/gtk/EventSender.cpp:
211         (mouseScrollByCallback):
212         (continuousMouseScrollByCallback):
213
214 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
215
216         Reviewed by Tony Chang.
217
218         Land a patched version of r66542 - change TestRunner to have an
219         separate cleanup method and fix the ordering of cleanup between
220         TestRunner and the printing module, and then wrap everything in a
221         try/finally block to ensure reliable cleanup without needing to
222         rely on stuff happening in the destructor of the TestRunner.
223
224         Also refactor run_webkit_tests.run() to be much smaller and cleaner
225         by creating a bunch of helper methods and moving more stuff into
226         the TestRunner class.
227
228         This fixes the crash at the end of the linux test run of
229         new-run-webkit-tests (and undoes the rollout in 66547).
230
231         https://bugs.webkit.org/show_bug.cgi?id=44902
232
233         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
234         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
235         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
236         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
237         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
238         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
239         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
240         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
241         * Scripts/webkitpy/layout_tests/port/base.py:
242         * Scripts/webkitpy/layout_tests/port/test.py:
243         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
244         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
245
246 2010-09-01  Mark Rowe  <mrowe@apple.com>
247
248         Reviewed by Adam Roben.
249
250         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
251
252         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
253
254 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
255
256         Reviewed by Adam Roben.
257
258         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
259         and WebKitTestRunner.
260
261         * BuildSlaveSupport/win/kill-old-processes:
262
263 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
264
265         Reviewed by Antonio Gomes.
266
267         [Qt] Remove obsolete include path from DumpRenderTree.pro
268
269         * DumpRenderTree/qt/DumpRenderTree.pro:
270
271 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
272
273         Reviewed by Laszlo Gombos.
274
275         [Qt] QWebPage::allowGeolocationRequest should be async API
276         https://bugs.webkit.org/show_bug.cgi?id=41364
277
278         Implements new async API for geolocation permission similar to
279         Notification. WebPage maintains list of geolocation permission request
280         QtWebkit and set's when LayoutTestController gets the access from test JS
281
282         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
283         (WebCore::WebPage::WebPage):
284         (WebCore::WebPage::resetSettings):
285         (WebCore::WebPage::requestPermission):
286         (WebCore::WebPage::cancelPermission):
287         (WebCore::WebPage::permissionSet):
288         (WebCore::DumpRenderTree::DumpRenderTree):
289         (WebCore::DumpRenderTree::processLine):
290         (WebCore::DumpRenderTree::geolocationPermissionSet):
291         * DumpRenderTree/qt/DumpRenderTreeQt.h:
292         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
293         (LayoutTestController::reset):
294         (LayoutTestController::setGeolocationPermission):
295         (LayoutTestController::setGeolocationPermissionCommon):
296         * DumpRenderTree/qt/LayoutTestControllerQt.h:
297
298 2010-09-01  Andras Becsi  <abecsi@webkit.org>
299
300         Reviewed by Antti Koivisto.
301
302         [Qt] Auto-generate WebKit2 forwarding headers
303         https://bugs.webkit.org/show_bug.cgi?id=44692
304
305         * MiniBrowser/qt/BrowserWindow.h: use source style includes
306         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
307         * Scripts/enumerate-included-framework-headers: Removed.
308
309 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
310
311         Reviewed by Adam Barth.
312
313         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
314         https://bugs.webkit.org/show_bug.cgi?id=44789
315
316         * Scripts/webkitpy/common/net/bugzilla.py:
317
318 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
319
320         Reviewed by Adam Barth.
321
322         ews: Add support for EFL-EWS
323         https://bugs.webkit.org/show_bug.cgi?id=44982
324
325         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
326         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
327         and add it to the ports dict.
328         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
329         EflEWS class.
330         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
331         a test case for the EFL EWS.
332
333 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
334
335         Reviewed by Sam Weinig.
336
337         https://bugs.webkit.org/show_bug.cgi?id=42195
338         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
339
340         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
341         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
342         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
343         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
344         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
345
346         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
347         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
348         which forgets its override.
349
350 2010-08-31  Sam Weinig  <sam@webkit.org>
351
352         Reviewed by Gavin Barraclough.
353
354         WebKitTestRunner needs layoutTestController.addUserStyleSheet
355         https://bugs.webkit.org/show_bug.cgi?id=42680
356
357         WebKitTestRunner needs layoutTestController.addUserScript
358         https://bugs.webkit.org/show_bug.cgi?id=42681
359
360         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
361         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
362         (WTR::InjectedBundle::beginTesting):
363         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
364         (WTR::LayoutTestController::addUserScript):
365         (WTR::LayoutTestController::addUserStyleSheet):
366         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
367
368 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
369
370         Unreviewed, rolling out r66542.
371         http://trac.webkit.org/changeset/66542
372         https://bugs.webkit.org/show_bug.cgi?id=44902
373
374         r66542 - the weird logging dependencies in Python stuck again ...
375
376         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
377         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
378         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
379         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
380         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
381         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
382         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
383         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
384         * Scripts/webkitpy/layout_tests/port/base.py:
385         * Scripts/webkitpy/layout_tests/port/test.py:
386         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
387         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
388
389 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
390
391         Reviewed by Tony Chang.
392
393         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
394
395         * DumpRenderTree/chromium/LayoutTestController.cpp:
396         (LayoutTestController::LayoutTestController):
397         (LayoutTestController::markerTextForListItem):
398         * DumpRenderTree/chromium/LayoutTestController.h:
399
400 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
401
402         Reviewed by Ojan Vafai.
403
404         new-run-webkit-tests: add more unit tests
405
406         Add more unit tests for new-run-webkit-tests; we now cover all but
407         the most obscure code paths in the generic code. We still need to
408         add coverage for the http server and web socket paths, and add better
409         coverage of the platform-specific logic. Note that the rebaselining
410         tool is still not well tested.
411
412         Also clean up some of the configuration logic for the printing
413         module and the way it interacts with the Python logging module; that
414         is a crufty interface, to be certain.
415         
416         https://bugs.webkit.org/show_bug.cgi?id=44902
417
418         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
419         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
420         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
421         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
422         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
423         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
424         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
425         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
426         * Scripts/webkitpy/layout_tests/port/base.py:
427         * Scripts/webkitpy/layout_tests/port/test.py:
428         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
429         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
430
431 2010-08-31  Darin Adler  <darin@apple.com>
432
433         Reviewed by Anders Carlsson.
434
435         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
436         in a debug build when built with certain compilers.
437
438 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
439
440         Reviewed by Gustavo Noronha Silva.
441
442         [GTK] Isolate all GTK+ typedefs into one file
443         https://bugs.webkit.org/show_bug.cgi?id=44900
444
445         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
446
447 2010-08-31  Eric Seidel  <eric@webkit.org>
448
449         Reviewed by Adam Barth.
450
451         Show more status on queue status pages
452         https://bugs.webkit.org/show_bug.cgi?id=44938
453
454         I upped the number of status lines from 6 to 15 --
455         this has been bugging me for a while...
456
457         I also disabled showing the chromium-win EWS queue
458         since it's been down for almost 5 months now.
459
460         * QueueStatusServer/handlers/dashboard.py:
461         * QueueStatusServer/handlers/queuestatus.py:
462         * QueueStatusServer/model/queues.py:
463
464 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
465
466         Reviewed by Antonio Gomes.
467
468         [Qt] Read command line arguments and open them as URLs in new windows
469         https://bugs.webkit.org/show_bug.cgi?id=44944
470
471         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
472
473         * MiniBrowser/qt/main.cpp:
474         (main):
475
476 2010-08-31  Adrian Perez  <aperez@igalia.com>
477
478         Reviewed by Martin Robinson.
479
480         Support scripts to run Buildbot slaves under daemontools (gtk related)
481         https://bugs.webkit.org/show_bug.cgi?id=40053
482
483         * BuildSlaveSupport/gtk: Added.
484         * BuildSlaveSupport/gtk/README: Added.
485         * BuildSlaveSupport/gtk/buildbot: Added.
486         * BuildSlaveSupport/gtk/buildbot/log: Added.
487         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
488         * BuildSlaveSupport/gtk/buildbot/run: Added.
489         * BuildSlaveSupport/gtk/crashmon: Added.
490         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
491         * BuildSlaveSupport/gtk/crashmon/log: Added.
492         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
493         * BuildSlaveSupport/gtk/crashmon/run: Added.
494         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
495         * BuildSlaveSupport/gtk/pulseaudio: Added.
496         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
497         * BuildSlaveSupport/gtk/xvfb: Added.
498         * BuildSlaveSupport/gtk/xvfb/log: Added.
499         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
500         * BuildSlaveSupport/gtk/xvfb/run: Added.
501
502 2010-08-27  John Gregg  <johnnyg@google.com>
503
504         Reviewed by David Levin.
505
506         Notifications should support a click event.
507         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
508         can be simulated during a layout test.  Requires storing a list of active
509         notifications so that they can be referred to later for clicking.
510         https://bugs.webkit.org/show_bug.cgi?id=44800
511
512         * DumpRenderTree/chromium/LayoutTestController.cpp:
513         (LayoutTestController::LayoutTestController):
514         (LayoutTestController::simulateDesktopNotificationClick):
515         * DumpRenderTree/chromium/LayoutTestController.h:
516         * DumpRenderTree/chromium/NotificationPresenter.cpp:
517         (NotificationPresenter::simulateClick):
518         (NotificationPresenter::show):
519         (NotificationPresenter::cancel):
520         (NotificationPresenter::objectDestroyed):
521         * DumpRenderTree/chromium/NotificationPresenter.h:
522
523 2010-08-30  Alice Liu  <alice.liu@apple.com>
524
525         Reviewed by Darin Adler.
526
527         Add missing parts of didFinishDocumentLoadForFrame
528         https://bugs.webkit.org/show_bug.cgi?id=44913
529
530         * MiniBrowser/mac/BrowserWindowController.m:
531         (didFinishDocumentLoadForFrame): Added
532         (-[BrowserWindowController awakeFromNib]): Updated struct
533         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
534         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::initialize): Updated struct
537
538 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
539
540         Unreviewed: Add myself to the list of Committers.
541
542         * Scripts/webkitpy/common/config/committers.py:
543
544 2010-08-30  Kent Tamura  <tkent@chromium.org>
545
546         Reviewed by Adam Barth.
547
548         Fix fast/notifications/notifications-display-close-events.html failure
549         https://bugs.webkit.org/show_bug.cgi?id=44585
550
551         Apply http://crrev.com/48893. We should dispatch display events
552         asynchronously.
553
554         * DumpRenderTree/chromium/NotificationPresenter.cpp:
555         (deferredDisplayDispatch):
556         (NotificationPresenter::show):
557
558 2010-08-30  Robert Hogan  <robert@webkit.org>
559
560         Reviewed by Simon Hausmann.
561
562         allow ports with windowed plugins to support windowless plugin tests
563
564         https://bugs.webkit.org/show_bug.cgi?id=40730
565
566         Ports that implement plugins windowed by default need to have a way of
567         supporting plugin tests that assume the plugin is windowless. Add this
568         feature to the tests and support it in the webkit test plugin. Also
569         add mouse and keyboard event logging to the webkit-test plugin on Unix.
570
571         Unskip the following tests on Qt:
572
573         plugins/mouse-events.html
574         plugins/keyboard-events.html
575         plugins/mouse-events-fixedpos.html
576
577         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
578         (pluginSetProperty):
579         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
580         (NPP_New):
581         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
582         (webkit_test_plugin_handle_event):
583
584 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
585
586         [wx] Build fix after addition of fileapi directory in WebCore.
587
588         * wx/build/settings.py:
589
590 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
591
592         Reviewed by Xan Lopez.
593
594         Fixed compilation error, now that we have included the
595         GtkVersioning.h we have to remove some version dependent code from
596         EventSender.
597
598         * DumpRenderTree/gtk/EventSender.cpp:
599
600 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
601
602         Reviewed by Martin Robinson.
603
604         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
605         are deprecated
606         https://bugs.webkit.org/show_bug.cgi?id=44787
607
608         We have replaced GtkVersioning.cpp with GtkVersioning.c and
609         created a function (getDefaultGDKPointerDevice) to get the pointer
610         of the window with the new APIs. We added that function to DRT and
611         copyandpaste unit test.
612
613         * DumpRenderTree/gtk/EventSender.cpp:
614         (prepareMouseButtonEvent):
615         (mouseMoveToCallback):
616         (keyDownCallback):
617         * GNUmakefile.am:
618
619 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
620
621         Reviewed by Kenneth Rohde Christiansen.
622
623         [Qt] Add new window menu to MiniBrowser
624
625         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
626
627         * MiniBrowser/qt/BrowserWindow.cpp:
628         (BrowserWindow::BrowserWindow):
629         (BrowserWindow::newWindow):
630         * MiniBrowser/qt/BrowserWindow.h:
631         * MiniBrowser/qt/main.cpp:
632         (main):
633
634 2010-08-29  James Robinson  <jamesr@chromium.org>
635
636         Reviewed by David Levin.
637
638         Make failing the download step fail the build
639         https://bugs.webkit.org/show_bug.cgi?id=44298
640
641         If the download step fails on a test bot, this ensures that
642         the build goes red instead of only the download step going red
643         and the overall build staying green.
644
645         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
646
647 2010-08-29  Kent Tamura  <tkent@chromium.org>
648
649         Reviewed by Dimitri Glazkov.
650
651         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
652         https://bugs.webkit.org/show_bug.cgi?id=44847
653
654         * DumpRenderTree/chromium/EventSender.cpp:
655          Use webkit_support::VKEY_* instead of base::VKEY_*.
656
657 2010-08-29  Darin Adler  <darin@apple.com>
658
659         https://bugs.webkit.org/show_bug.cgi?id=40589
660
661         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
662         function names.
663
664 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
665
666         Reviewed by Darin Adler.
667
668         [iExploder] Add new CSS Properties and HTML Attributes
669         https://bugs.webkit.org/show_bug.cgi?id=44746
670
671         Updated the files with the update-iexploder-cssproperties script
672         and manually readded the -webkit-binding CSS Property to the list.
673
674         * iExploder/htdocs/cssproperties.in:
675         * iExploder/htdocs/htmlattrs.in:
676         * iExploder/htdocs/htmltags.in:
677
678 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
679
680         Reviewed by Darin Adler.
681
682         Fix Coverage build after the addition of ANGLE
683         https://bugs.webkit.org/show_bug.cgi?id=44744
684
685         ANGLE is using libtool to build a static library and the version of
686         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
687         parameters. The easiest way to handle this is to not build ANGLE with
688         coverage information.
689
690         This is achieved by applying the XCode options for each project
691         separately and exclude ANGLE.
692
693         * Scripts/build-webkit: Remove -framework AppKit due link errors.
694         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
695
696 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
697
698         [wx] Build fix after directory addition.
699
700         * wx/build/settings.py:
701
702 2010-08-28  Chris Guillory   <chris.guillory@google.com>
703
704         Reviewed by Chris Fleizach.
705
706         Add AX notification for childrenChanged
707         https://bugs.webkit.org/show_bug.cgi?id=44472
708
709         * DumpRenderTree/chromium/AccessibilityController.cpp:
710         (AccessibilityController::AccessibilityController):
711         (AccessibilityController::reset):
712         (AccessibilityController::getRootElement):
713         (AccessibilityController::dumpAccessibilityNotifications):
714         * DumpRenderTree/chromium/AccessibilityController.h:
715         (AccessibilityController::shouldDumpAccessibilityNotifications):
716         * DumpRenderTree/chromium/WebViewHost.cpp:
717         (WebViewHost::didChangeAccessibilityObjectChildren):
718         * DumpRenderTree/chromium/WebViewHost.h:
719
720 2010-08-28  Eric Seidel  <eric@webkit.org>
721
722         Reviewed by Adam Barth.
723
724         Update commit-queue failure message
725         https://bugs.webkit.org/show_bug.cgi?id=44798
726
727         The commit-queue auto-restarts itself and has for a very long time.
728         No need for people to email me to request a restart anymore.
729
730         * Scripts/webkitpy/common/net/bugzilla.py:
731         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
732         * Scripts/webkitpy/tool/commands/queues_unittest.py:
733
734 2010-07-27  Jer Noble  <jer.noble@apple.com>
735
736         Reviewed by Eric Carlson.
737
738         Add JavaScript API to allow a page to go fullscreen.
739         rdar://problem/6867795
740         
741         Added basic full screen support to DumpRenderTree: when a webView requests
742         that DumpRenderTree go "full screen", just call the provided callback listener object's
743         will/did Enter/Exit full screen methods.  Also, register a new user default which 
744         enables full screen support.
745
746         * DumpRenderTree/mac/DumpRenderTree.mm:
747         (resetDefaultsToConsistentValues):
748         * DumpRenderTree/mac/UIDelegate.mm:
749         (-[UIDelegate webView:supportsFullscreenForElement:]):
750         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
751         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
752
753 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
754
755         Unreviewed. Add myself to the committers list.
756
757         * Scripts/webkitpy/common/config/committers.py:
758
759 2010-08-27  Kent Tamura  <tkent@chromium.org>
760
761         Reviewed by Pavel Feldman.
762
763         [DRT/Chromium] Fix inspector test failures
764         https://bugs.webkit.org/show_bug.cgi?id=44748
765
766         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
767         (DRTDevToolsAgent::createClientMessageLoop):
768           Returns a valid WebKitClientMessageLoop instance
769         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
770
771 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
772
773         Add Windows WebKit2 Tester to buildbot
774         <rdar://problem/7887703>
775
776         Reviewed by Dan Bernstein.
777
778         * BuildSlaveSupport/build.webkit.org-config/config.json:
779
780 2010-08-26  Philippe Normand  <pnormand@igalia.com>
781
782         Reviewed by Martin Robinson.
783
784         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
785         https://bugs.webkit.org/show_bug.cgi?id=42152
786
787         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
788         (LoadHTMLStringItem::invoke): Implementation using
789         webkit_web_frame_load_string().
790
791 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
792
793         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
794         WebKitTestRunner (44331)
795
796         Reviewed by Darin Adler.
797
798         * WebKitTestRunner/TestController.cpp:
799         (WTR::TestController::initialize):
800         The hang occurs when WebKitTestRunner begins launching the WebKit2
801         web process then exits before it finishes launching. Work around this by
802         looking for the --print-supported-features argument and exiting without
803         creating the web process.
804
805 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
806
807         Reviewed by Tony Chang.
808
809         new-run-webkit-tests: add rebaselining tests for test_expectations
810         
811         This patch adds more unit tests for the rebaselining code in the
812         test_expectations module. It doesn't add any tests for
813         rebaseline_chromium_webkit_tests itself; that will come some other
814         time.
815
816         https://bugs.webkit.org/show_bug.cgi?id=44648
817
818         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
819         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
820
821 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
822
823         Reviewed by Martin Robinson.
824
825         [GTK] Add HTTP caching support
826         https://bugs.webkit.org/show_bug.cgi?id=44261
827
828         Ignore new soup API that we decided to merge into the soup backend
829         while it is being cooked. It follows the libsoup style, and will
830         be removed from WebKit as soon as it is merged into libsoup.
831
832         * Scripts/webkitpy/style/checker.py:
833
834 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
835
836         Reviewed by Kenneth Rohde Christiansen.
837
838         [Qt] DumpRenderTree runs only one test from command mode
839         https://bugs.webkit.org/show_bug.cgi?id=44012
840
841         Enables support to run multiple test files and single
842         folder containing html files in stand alone mode
843
844         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
845         (WebCore::DumpRenderTree::DumpRenderTree):
846         (WebCore::DumpRenderTree::processArgsLine):
847         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
848         (WebCore::DumpRenderTree::processLine):
849         (WebCore::DumpRenderTree::dump):
850         * DumpRenderTree/qt/DumpRenderTreeQt.h:
851         (WebCore::DumpRenderTree::setStandAloneMode):
852         (WebCore::DumpRenderTree::isStandAloneMode):
853         * DumpRenderTree/qt/main.cpp:
854         (main):
855
856 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
857
858         Updating webkitpy test expectations.
859
860         * Scripts/webkitpy/tool/steps/steps_unittest.py:
861
862 2010-08-25  Ojan Vafai  <ojan@chromium.org>
863
864         Reviewed by Eric Seidel.
865
866         fix the always squash git config
867         https://bugs.webkit.org/show_bug.cgi?id=44651
868
869         Fix help text and apparently underscores are not allowed
870         in git config keys.
871
872         * Scripts/webkitpy/common/checkout/scm.py:
873         * Scripts/webkitpy/tool/steps/commit.py:
874
875 2010-08-25  Darin Adler  <darin@apple.com>
876
877         Reviewed by John Sullivan.
878
879         * Scripts/commit-log-editor: Fix perl warning for people who have no
880         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
881
882 2010-08-25  Ojan Vafai  <ojan@chromium.org>
883
884         Reviewed by Eric Seidel.
885
886         stop blocking commits when the bots are red
887         https://bugs.webkit.org/show_bug.cgi?id=44644
888
889         This check currently is just annoying. It doesn't actually
890         help keep the tree green. We can always add it back later
891         if we decide the tree is generally more green.
892
893         * Scripts/webkitpy/tool/commands/download_unittest.py:
894         * Scripts/webkitpy/tool/mocktool.py:
895         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
896
897 2010-08-25  Eric Seidel  <eric@webkit.org>
898
899         Reviewed by Simon Fraser.
900
901         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
902         https://bugs.webkit.org/show_bug.cgi?id=38912
903
904         I know of nothing else to do but skip all media tests for the cq.
905
906         * Scripts/webkitpy/tool/steps/runtests.py:
907
908 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
909
910         Reviewed by Ojan Vafai.
911
912         new-run-webkit-tests: add more unit tests for test_expectations
913         This adds unit tests to cover (almost?) all of the non-rebaselining
914         functionality.
915
916         https://bugs.webkit.org/show_bug.cgi?id=44579
917
918         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
919         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
920
921 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
922
923         Reviewed by Ojan Vafai.
924
925         new-run-webkit-tests: add more unit tests
926
927         This change adds more unit tests for the image_diff, test_failures,
928         and test_files modules, bringing them to 100% coverage (and adds a
929         couple tests to run_webkit_tests while we're at it).
930
931         This test also turns on the "dryrun" port for testing when run on
932         the mac, increasing coverage in a few other places.
933
934         https://bugs.webkit.org/show_bug.cgi?id=44578
935
936         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
937         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
938         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
939         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
940         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
941         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
942         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
943         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
944         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
945         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
946         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
947         * Scripts/webkitpy/layout_tests/port/test.py:
948         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
949
950 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
951
952         Reviewed by Ojan Vafai.
953
954         new-run-webkit-tests: add more unit tests for layout_package/printing.py
955
956         This change adds more unit tests to get the test coverage to 100%
957         for the printing module. This code is actually pretty crufty and
958         has some layering violations that need to be cleaned up but I'll
959         save that for another CL after we get all the unit tests written and
960         we fix the multithreading issues. At least now we'll be able to tell
961         if we break things.
962
963         https://bugs.webkit.org/show_bug.cgi?id=44576
964
965         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
966         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
967
968 2010-08-25  Ojan Vafai  <ojan@chromium.org>
969
970         Reviewed by Adam Barth.
971
972         new-run-webkit-tests should respect set-webkit-configuration
973         https://bugs.webkit.org/show_bug.cgi?id=44633
974
975         Moves the getting of the configuration into the base Port so that
976         chromium ports use it as well. In the downstream chromium port,
977         this should still just return Release.
978
979         * Scripts/webkitpy/layout_tests/port/base.py:
980         * Scripts/webkitpy/layout_tests/port/webkit.py:
981
982 2010-08-25  Tony Chang  <tony@chromium.org>
983
984         Not reviewed, changing svn props for a script.
985
986         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
987
988 2010-08-25  Adam Barth  <abarth@webkit.org>
989
990         Reviewed by Eric Seidel.
991
992         Remove WebKit2 from core builders
993         https://bugs.webkit.org/show_bug.cgi?id=44625
994
995         This builder was added to the core builders by accident.  It doesn't
996         appear to be green enough to be a core builder yet.
997
998         * Scripts/webkitpy/common/net/buildbot.py:
999         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1000
1001 2010-08-19  Adam Roben  <aroben@apple.com>
1002
1003         Test that NP_Initialize and NP_GetEntryPoints are called in the
1004         correct order
1005
1006         The order differs between Mac and Windows (see r38858).
1007
1008         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1009         NP_Initialize when loading QuickTime when running
1010         plugins/embed-attributes-setting.html in WebKit2 on Windows
1011
1012         Reviewed by John Sullivan.
1013
1014         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1015         a boolean to record whether NP_GetEntryPoints has been called.
1016         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1017         called yet. This matches Flash and QuickTime's behavior.
1018         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
1019         yet. This matches Silverlight's behavior.
1020
1021 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
1022
1023         Reviewed by Gustavo Noronha Silva.
1024
1025         Cairo and EFL port shouldn't depend on glib.
1026         https://bugs.webkit.org/show_bug.cgi?id=44354
1027
1028         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1029         adoptPlatformRef.
1030
1031         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1032         (AccessibilityUIElement::isSelected):
1033
1034 2010-08-25  Ojan Vafai  <ojan@chromium.org>
1035
1036         Fix order of Timothy's email address. The script, and
1037         other tools all assume that the first email is the bugzilla address.
1038
1039         * Scripts/webkitpy/common/config/committers.py:
1040
1041 2010-08-24  Kent Tamura  <tkent@chromium.org>
1042
1043         Reviewed by Pavel Feldman.
1044
1045         [DRT/Chromium] Fix 26 inspector test crashes
1046         https://bugs.webkit.org/show_bug.cgi?id=44580
1047
1048         - DRTDevToolsAgent has a reference to the main WebView. So we
1049           should not clear it in closeDevTools() and should clear it in
1050           ~TestShell().
1051         - DRTDevToolsClient has a reference to a DevTools WebView and no
1052           way to update it. So we should delete DRTDevToolsClient instances
1053           in closeDevTools().
1054
1055         * DumpRenderTree/chromium/TestShell.cpp:
1056         (TestShell::~TestShell):
1057         (TestShell::closeDevTools):
1058
1059 2010-08-24  Eric Seidel  <eric@webkit.org>
1060
1061         Reviewed by Adam Barth.
1062
1063         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
1064         https://bugs.webkit.org/show_bug.cgi?id=44584
1065
1066         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1067
1068 2010-08-24  Eric Seidel  <eric@webkit.org>
1069
1070         Reviewed by Adam Barth.
1071
1072         commit-queue and EWS bots should report all failures
1073         https://bugs.webkit.org/show_bug.cgi?id=41820
1074
1075         Right now commit-queue/EWS only report failures when the
1076         patch under testing fails.  We should report all failures
1077         to the status server so that we can diagnose when the bots
1078         are wedged w/o needing to log into the machines.
1079
1080         I also reduced the amount of data we upload since we've seen
1081         timeouts during status upload.
1082
1083         * Scripts/webkitpy/common/system/executive.py:
1084         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1085         * Scripts/webkitpy/tool/commands/queues.py:
1086         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1087
1088 2010-08-24  Eric Seidel  <eric@webkit.org>
1089
1090         Reviewed by Adam Barth.
1091
1092         Remove HTML5 parser testing infrastructure now that we don't need it
1093         https://bugs.webkit.org/show_bug.cgi?id=44581
1094
1095         * DumpRenderTree/mac/DumpRenderTree.mm:
1096         (resetDefaultsToConsistentValues):
1097         (initializeGlobalsFromCommandLineOptions):
1098         * Scripts/old-run-webkit-tests:
1099         * Scripts/test-html5-parser: Removed.
1100
1101 2010-08-24  Kent Tamura  <tkent@chromium.org>
1102
1103         Reviewed by Dimitri Glazkov.
1104
1105         [DRT/Chromium] Fix 28 inspector test crashes
1106         https://bugs.webkit.org/show_bug.cgi?id=44574
1107
1108         Reset DevToolsClient and DevToolsAgent before closing a DevTools
1109         WebView in order to avoid accessing to a deleted WebView instance.
1110
1111         * DumpRenderTree/chromium/TestShell.cpp:
1112         (TestShell::closeDevTools):
1113
1114 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1115
1116         Reviewed by Ojan Vafai.
1117
1118         new-run-webkit-tests: clean up code for test_types, test_failures
1119
1120         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
1121         webkitpy.layout_tests.layout_package.test_failures, and remove
1122         some dead code and otherwise clean up things.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=44559
1125
1126         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1127         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
1128         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1129         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1130         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1131         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
1132         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1133
1134 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1135
1136         Reviewed by Eric Seidel.
1137
1138         new-run-webkit-tests: revise unit testing strategy for test failures
1139     
1140         This change revamps the way we store test data for new-run-webkit-tests.
1141         Previously we had a few copies of test files from the main test tree.
1142         Now we have a bunch of completely fake test data and use the test
1143         data to generate different kinds of test failures, getting
1144         much better coverage.
1145
1146         https://bugs.webkit.org/show_bug.cgi?id=44556
1147
1148         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
1149         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
1150         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
1151         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
1152         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
1153         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
1154         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
1155         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
1156         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
1157         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
1158         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
1159         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
1160         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
1161         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
1162         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
1163         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
1164         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
1165         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
1166         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
1167         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
1168         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
1169         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
1170         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
1171         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
1172         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
1173         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
1174         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
1175         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
1176         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
1177         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
1178         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
1179         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
1180         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
1181         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
1182         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
1183         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
1184         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
1185         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
1186         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
1187         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
1188         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
1189         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
1190         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
1191         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1192         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
1193         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
1194         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1195         * Scripts/webkitpy/layout_tests/port/test.py:
1196         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1197         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1198
1199 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1200
1201         Reviewed by Eric Seidel.
1202
1203         speed up new-run-webkit-tests unit tests
1204
1205         Add a --no-record-results flag that turns off generating the JSON
1206         results file on every test run. Generating the file requires us to
1207         fetch the old results down from the bots, which can be slow. This
1208         flag is off by default.
1209     
1210         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
1211     
1212         These changes together shorten the test cycle from ~4.5s to ~1.5s
1213         - a 3x speedup.
1214
1215         https://bugs.webkit.org/show_bug.cgi?id=44553
1216
1217         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1218         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1219
1220 2010-08-24  Tony Chang  <tony@chromium.org>
1221
1222         Reviewed by Eric Seidel.
1223
1224         [chromium] fix the platform result fallback order on mac/win
1225         https://bugs.webkit.org/show_bug.cgi?id=44483
1226
1227         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1228
1229 2010-08-24  Xan Lopez  <xlopez@igalia.com>
1230
1231         Reviewed by Martin Robinson.
1232
1233         Set a device to the event struct when building with GTK+ 3.x, it's
1234         mandatory.
1235
1236         * DumpRenderTree/gtk/EventSender.cpp:
1237         (keyDownCallback):
1238
1239 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1240
1241         Reviewed by Xan Lopez.
1242
1243         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1244         https://bugs.webkit.org/show_bug.cgi?id=44534
1245
1246         Fix two double-frees introduced in my previous commit.
1247
1248         * DumpRenderTree/gtk/EventSender.cpp:
1249         (contextClickCallback): Copy the event before using it again.
1250         (keyDownCallback): Ditto.
1251
1252 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1253
1254         Reviewed by Xan Lopez.
1255
1256         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1257         https://bugs.webkit.org/show_bug.cgi?id=44534
1258
1259         * DumpRenderTree/gtk/EventSender.cpp:
1260         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
1261         when setting it on the event. It is dereferenced by gdk_event_free(...).
1262         (contextClickCallback): Ditto.
1263         (mouseDownCallback): Ditto.
1264         (mouseUpCallback): Ditto.
1265         (mouseMoveToCallback): Ditto.
1266         (mouseWheelToCallback): Ditto.
1267         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
1268         (dispatchEvent): Ditto. Also free the event when we are done with it.
1269         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
1270
1271 2010-08-24  Andras Becsi  <abecsi@webkit.org>
1272
1273         [Qt] WebKit2 build fix.
1274
1275         * Scripts/enumerate-included-framework-headers:
1276         Remove stray global option form sed.
1277
1278 2010-08-24  Kent Tamura  <tkent@chromium.org>
1279
1280         Reviewed by Jeremy Orlow.
1281
1282         [DRT/Chromium] Support for IndexedDB tests
1283         https://bugs.webkit.org/show_bug.cgi?id=44490
1284
1285         * DumpRenderTree/chromium/TestShell.cpp:
1286         (TestShell::TestShell): Enable IndexedDB.
1287
1288 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
1289
1290         Reviewed by Gustavo Noronha Silva.
1291
1292         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
1293         https://bugs.webkit.org/show_bug.cgi?id=44465
1294
1295         Initialize the axes field of mouse button and motion events to null.
1296         This is the value that should be used for events originating from the
1297         mouse device.
1298
1299         * DumpRenderTree/gtk/EventSender.cpp:
1300         (prepareMouseButtonEvent): Initalize button event axes field to null.
1301         (mouseMoveToCallback): Initialize motion event axes field to null.
1302
1303 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1304
1305         Unreviewed, rolling out r65703.
1306         http://trac.webkit.org/changeset/65703
1307         https://bugs.webkit.org/show_bug.cgi?id=44460
1308
1309         "Causing lots of crashes on Snow Leopard when running the
1310         layout tests" (Requested by eseidel2 on #webkit).
1311
1312         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1313         (NP_Initialize):
1314         (NP_GetEntryPoints):
1315
1316 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
1317
1318         Layout tests do not run when using WebKitTestRunner in a Debug build.
1319         https://bugs.webkit.org/show_bug.cgi?id=44409
1320
1321         Reviewed by Dan Bernstein.
1322
1323         * WebKitTestRunner/win/TestControllerWin.cpp:
1324         (WTR::TestController::initializeInjectedBundlePath):
1325         Use InjectedBundle_debug.dll when building Debug.
1326
1327 2010-08-23  Xan Lopez  <xlopez@igalia.com>
1328
1329         Reviewed by Martin Robinson.
1330
1331         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
1332         https://bugs.webkit.org/show_bug.cgi?id=42026
1333
1334         If a GTK+ 3.x build is present return that as the library to use,
1335         otherwise fallback to the GTK+ 2.x build.
1336
1337         * Scripts/webkitdirs.pm:
1338
1339 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
1340
1341         Reviewed by Ariya Hidayat.
1342
1343         [Qt] Find needed forwarding headers for WebKit2 automatically
1344         https://bugs.webkit.org/show_bug.cgi?id=44336
1345
1346         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
1347         The new script does not satisfy the needs of this file however using normal includes
1348         is generally better here.
1349         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
1350         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
1351         given frameworks by files in the current directory (and subdirectories).
1352         In the future this needs to be rewritten in perl for being able to use on Windows.
1353
1354 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
1355
1356         Reviewed by Ariya Hidayat.
1357
1358         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
1359         https://bugs.webkit.org/show_bug.cgi?id=43010
1360
1361         * QtTestBrowser/launcherwindow.cpp:
1362         (LauncherWindow::applyPrefs):
1363         * QtTestBrowser/main.cpp:
1364         (LauncherApplication::handleUserOptions):
1365
1366 2010-08-21  Sam Weinig  <sam@webkit.org>
1367
1368         Reviewed by Dan Bernstein.
1369
1370         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
1371         https://bugs.webkit.org/show_bug.cgi?id=44386
1372
1373         * MiniBrowser/mac/AppDelegate.m:
1374         (didRecieveMessageFromInjectedBundle):
1375         (didNavigateWithNavigationData):
1376         (-[BrowserAppDelegate init]):
1377         (-[BrowserAppDelegate applicationWillTerminate:]):
1378         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1379         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1380         (-[BrowserStatisticsWindowController dealloc]):
1381         * MiniBrowser/mac/BrowserWindowController.m:
1382         (-[BrowserWindowController initWithPageNamespace:]):
1383         (-[BrowserWindowController fetch:]):
1384         (-[BrowserWindowController windowWillClose:]):
1385         (-[BrowserWindowController applicationTerminating]):
1386         (closePage):
1387         (runJavaScriptAlert):
1388         (runJavaScriptConfirm):
1389         (runJavaScriptPrompt):
1390         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1391         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1392         (didClearWindowObjectForFrame):
1393         * MiniBrowser/win/BrowserView.cpp:
1394         (BrowserView::goToURL):
1395         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1396         (WTR::PlatformWebView::~PlatformWebView):
1397
1398 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
1399
1400         Reviewed by Kenneth Rohde Christiansen.
1401
1402         WebKit does not build with Python 2.3
1403         https://bugs.webkit.org/show_bug.cgi?id=44373
1404
1405         Replaced the function sorted() by a call to sort()
1406         on the entry list.
1407         The function sorted() has been added to Python 2.4.
1408         The function method sort() of List works with older
1409         versions of Python.
1410
1411         * Scripts/create-html-entity-table:
1412
1413 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
1414
1415         Reviewed by Pavel Feldman.
1416
1417         Web Inspector: Inspector tests were disabled for GTK.
1418         https://bugs.webkit.org/show_bug.cgi?id=43977
1419
1420         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
1421         path before running tests.
1422
1423 2010-08-20  Daniel Bates  <dbates@rim.com>
1424
1425         Reviewed by Eric Seidel.
1426
1427         svn-apply doesn't detect empty line with Windows line endings
1428         after property value
1429         https://bugs.webkit.org/show_bug.cgi?id=43981
1430
1431         Part 2 of 2
1432
1433         Add unit tests that were not landed in the first commit.
1434
1435         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1436           - Added the following test cases:
1437             "SVN: binary file (isBinary true) using Windows line endings"
1438             "SVN: property diff, followed by file change diff using Windows line endings"
1439             "SVN: two consecutive property diffs using Windows line endings"
1440             "SVN: binary file with executable bit change usng Windows line endings"
1441             "SVN: binary file followed by property change on different file using Windows line endings"
1442             "SVN: binary file followed by file change on different file using Windows line endings"
1443             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1444             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1445         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1446           - Added the following test cases:
1447             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1448             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1449             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1450             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1451             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1452             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1453             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1454             "single-line '+' with trailing new line using Windows line endings"
1455             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1456             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1457             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1458         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1459           - Added the following test cases:
1460             "single-line '-' change followed by empty line with Windows line endings"
1461             "multi-line '+' change and start of binary patch with Windows line endings"
1462
1463 2010-08-20  Daniel Bates  <dbates@rim.com>
1464
1465         Reviewed by Eric Seidel.
1466
1467         svn-apply doesn't detect empty line with Windows line endings
1468         after property value
1469         https://bugs.webkit.org/show_bug.cgi?id=43981
1470
1471         Fixes an issue where an empty line following the property value
1472         in an SVN property change diff would not be detected if it had
1473         Windows line endings (i.e. ended in CRLF). Hence it was consumed
1474         as if it was part of a multi-line property value. 
1475
1476         * Scripts/VCSUtils.pm:
1477           - Modified parseSvnPropertyValue() to detect empty line
1478             with Windows line endings.
1479           - Added toWindowsLineEndings().
1480         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1481           - Added the following test cases:
1482             "SVN: binary file (isBinary true) using Windows line endings"
1483             "SVN: property diff, followed by file change diff using Windows line endings"
1484             "SVN: two consecutive property diffs using Windows line endings"
1485             "SVN: binary file with executable bit change usng Windows line endings"
1486             "SVN: binary file followed by property change on different file using Windows line endings"
1487             "SVN: binary file followed by file change on different file using Windows line endings"
1488             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1489             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1490         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1491           - Added the following test cases:
1492             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1493             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1494             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1495             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1496             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1497             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1498             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1499             "single-line '+' with trailing new line using Windows line endings"
1500             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1501             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1502             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1503         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1504           - Added the following test cases:
1505             "single-line '-' change followed by empty line with Windows line endings"
1506             "multi-line '+' change and start of binary patch with Windows line endings"
1507
1508 2010-08-19  David Kilzer  <ddkilzer@apple.com>
1509
1510         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
1511
1512         * MiniBrowser/mac/BrowserWindowController.m:
1513         (decidePolicyForNavigationAction): Updated method signature.
1514         (decidePolicyForNewWindowAction): Updated method signature.
1515
1516 2010-08-19  Adam Roben  <aroben@apple.com>
1517
1518         Test that NP_Initialize and NP_GetEntryPoints are called in the
1519         correct order
1520
1521         The order differs between Mac and Windows (see r38858).
1522
1523         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1524         NP_Initialize when loading QuickTime when running
1525         plugins/embed-attributes-setting.html in WebKit2 on Windows
1526
1527         Reviewed by Sam Weinig.
1528
1529         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1530         a boolean to record whether NP_GetEntryPoints has been called.
1531         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1532         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
1533         if NP_GetEntryPoints has been called already. This matches
1534         Silverlight's behavior.
1535
1536 2010-08-19  Adam Roben  <aroben@apple.com>
1537
1538         Make build-webkittestrunner build TestNetscapePlugIn on Windows
1539
1540         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
1541
1542         Reviewed by Sam Weinig.
1543
1544         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
1545         Threaded it in between ImageDiff and InjectedBundleGenerated.
1546
1547 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1548
1549         Reviewed by Adam Barth.
1550
1551         install rietveld's upload script from a versioned url
1552         https://bugs.webkit.org/show_bug.cgi?id=44291
1553
1554         autoinstall expects the file at a given URL to never change.
1555         In order to be able to update the file, we need to be able to
1556         change the path.
1557
1558         * Scripts/webkitpy/thirdparty/__init__.py:
1559
1560 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1561
1562         Reviewed by Adam Barth.
1563
1564         add --webkit_patch_id to reitveld uploads
1565         https://bugs.webkit.org/show_bug.cgi?id=44289
1566
1567         This is the first step in having rietveld store which
1568         patches have been uploaded and getting rid of the
1569         in-rietveld flag.
1570
1571         * Scripts/webkitpy/common/net/rietveld.py:
1572         * Scripts/webkitpy/tool/mocktool.py:
1573         * Scripts/webkitpy/tool/steps/postcodereview.py:
1574
1575 2010-08-19  Kenneth Russell  <kbr@google.com>
1576
1577         Reviewed by David Levin.
1578
1579         Adjust my status from committer to reviewer
1580         https://bugs.webkit.org/show_bug.cgi?id=44277
1581
1582         * Scripts/webkitpy/common/config/committers.py:
1583
1584 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
1585
1586         Reviewed by Yury Semikhatsky.
1587
1588         Chromium DevTools: remove injected script fetcher from test harness.
1589         https://bugs.webkit.org/show_bug.cgi?id=44266
1590
1591         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1592         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1593
1594 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
1595
1596         Reviewed by Yury Semikhatsky.
1597
1598         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
1599         Now that we populate front-end after its onload handler, we don't need
1600         to install injected script early. Exposing injected script source on the WebCore
1601         level here.
1602         https://bugs.webkit.org/show_bug.cgi?id=44029
1603
1604         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1605         (DRTDevToolsAgent::runtimePropertyChanged):
1606         (DRTDevToolsAgent::delayedFrontendLoaded):
1607         (DRTDevToolsAgent::frontendLoaded):
1608         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1609
1610 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1611
1612         Reviewed by Kenneth Rohde Christiansen.
1613
1614         [Gtk] Enable view mode media feature layout test
1615         https://bugs.webkit.org/show_bug.cgi?id=43278
1616
1617         Add view mode media feature testing infrastructure, and add
1618         placeholder methods for the other platforms'
1619         LayoutTestControllers.
1620
1621         * DumpRenderTree/LayoutTestController.cpp:
1622         (setViewModeMediaFeatureCallback):
1623         (LayoutTestController::staticFunctions):
1624         * DumpRenderTree/LayoutTestController.h:
1625         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1626         (LayoutTestController::setViewModeMediaFeature):
1627         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1628         (LayoutTestController::setViewModeMediaFeature):
1629         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1630         (LayoutTestController::setViewModeMediaFeature):
1631         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1632         (LayoutTestController::setViewModeMediaFeature):
1633
1634 2010-08-18  Mark Rowe  <mrowe@apple.com>
1635
1636         Reviewed by Sam Weinig.
1637
1638         Make it so the WebKit2 test slave runs the WebKit2 tests
1639
1640         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1641
1642 2010-08-18  Sam Weinig  <sam@webkit.org>
1643
1644         Reviewed by Mark Rowe.
1645
1646         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
1647         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
1648         module and the TestNetscapePlugin.
1649
1650         * Scripts/old-run-webkit-tests:
1651
1652 2010-08-18  Adam Roben  <aroben@apple.com>
1653
1654         Fix hang when saving crash logs on Windows
1655
1656         * Scripts/old-run-webkit-tests:
1657         (setUpWindowsCrashLogSaving):
1658         (END):
1659         Pass -s to regtool so it will write the Auto value as a string instead
1660         of as a number. This was causing a "do you want to debug?" dialog to
1661         appear.
1662
1663 2010-08-17  Victor Wang  <victorw@chromium.org>
1664
1665         Unreviewed. Fixed chromium incremental test json upload.
1666         Quote builder name and test results server in url.
1667
1668         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1669
1670 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1671
1672         Reviewed by Ariya Hidayat.
1673
1674         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
1675         https://bugs.webkit.org/show_bug.cgi?id=44124
1676
1677         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
1678         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
1679         Symbian dependencies.
1680
1681         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1682         (WebCore::DumpRenderTree::open):
1683         * QtTestBrowser/launcherwindow.cpp:
1684         (LauncherWindow::init):
1685         (LauncherWindow::toggleFullScreenMode):
1686         (LauncherWindow::showFPS):
1687         (LauncherWindow::updateFPS):
1688         * QtTestBrowser/launcherwindow.h:
1689         (WindowOptions::WindowOptions):
1690         * QtTestBrowser/mainwindow.cpp:
1691         (MainWindow::buildUI):
1692
1693 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1694
1695         Reviewed by David Levin.
1696
1697         new-run-webkit-tests: remove --show-sources option
1698
1699         --show-sources is pretty much obsolete with --trace everything, so
1700         I'm removing it.
1701
1702         Also rename a couple of methods in the TestTextDiff class to make their
1703         intended visibility (private) more obvious.
1704
1705         https://bugs.webkit.org/show_bug.cgi?id=44143
1706
1707         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1708         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1709         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1710         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1711         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1712
1713 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1714
1715         Reviewed by David Levin.
1716
1717         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
1718
1719         This code bit-rotted at some point more than a year ago, and nobody seems
1720         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
1721         should support instead, making this flag unnecessary anyway.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=44141
1724
1725         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1726         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1727         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
1728
1729 2010-08-17  Victor Wang  <victorw@chromium.org>
1730
1731         Reviewed by Ojan Vafai.
1732
1733         Update json results generator to have incremental json including
1734         results for tests that pass in current run but failed before.
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=44119
1737
1738         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1739         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1740         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1741
1742 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1743
1744         Reviewed by Eric Seidel.
1745
1746         fix test-webkitpy, add easy way to find a checkout root
1747
1748         test-webkitpy currently doesn't work right if run from someplace other
1749         than the checkout root, and it spews a bunch of debug logging because
1750         the deduplicate_tests tests contaminates the test environment.
1751
1752         This patch cleans up the deduplicate_tests unit tests, and creates
1753         two new methods in scm.py: find_checkout_root() and default_scm(),
1754         both of which use a single algorithm for guessing what checkout root
1755         to use if you aren't explicitly told one from a path.
1756
1757         https://bugs.webkit.org/show_bug.cgi?id=44001
1758
1759         * Scripts/deduplicate-tests:
1760         * Scripts/webkitpy/common/checkout/scm.py:
1761         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1762         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1763         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1764         * Scripts/webkitpy/layout_tests/port/test.py:
1765         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1766         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1767         * Scripts/webkitpy/tool/main.py:
1768
1769 2010-08-17  Victor Wang  <victorw@chromium.org>
1770
1771         Reviewed by Ojan Vafai.
1772
1773         Add support to the test results server for downloading json that
1774         contains test list only.
1775
1776         This is for json results generator to generate incremental json
1777         results so that it includes results not only for tests failed in
1778         current run, but also tests failed before.
1779
1780         Also set the results type to "N" (no data) instead of "P" (pass)
1781         if test results cannot be found in incremental json file.
1782
1783         https://bugs.webkit.org/show_bug.cgi?id=44117
1784
1785         * TestResultServer/handlers/testfilehandler.py:
1786         * TestResultServer/model/jsonresults.py:
1787         * TestResultServer/model/jsonresults_unittest.py:
1788
1789 2010-08-17  Adam Roben  <aroben@apple.com>
1790
1791         Use the right path style
1792
1793         * Scripts/old-run-webkit-tests:
1794
1795 2010-08-17  Adam Roben  <aroben@apple.com>
1796
1797         Fix typo
1798
1799         * Scripts/old-run-webkit-tests:
1800
1801 2010-08-17  Adam Roben  <aroben@apple.com>
1802
1803         Don't hang when running run-webkit-tests as a non-Administrator on
1804         Vista/7
1805
1806         * Scripts/old-run-webkit-tests:
1807         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
1808         post-mortem debugger, rather than using NTSD itself. The latter waits
1809         for user input when it fails to set the registry values; the former
1810         does not.
1811
1812 2010-08-17  Adam Roben  <aroben@apple.com>
1813
1814         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
1815         save crash logs on Windows
1816
1817         The crash logs are saved to /tmp/layout-test-results and have names
1818         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
1819
1820         Unfortunately, crashes in the WebKit2 web process are recorded as
1821         time-outs by run-webkit-tests. Fixing this is covered by
1822         <http://webkit.org/b/44121>.
1823
1824         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
1825         DumpRenderTree should save a stack trace and/or dump file when it
1826         crashes
1827
1828         Reviewed by Sam Weinig.
1829
1830         * DumpRenderTree/win/DumpRenderTree.cpp:
1831         (exceptionFilter):
1832         (main):
1833         * WebKitTestRunner/win/TestControllerWin.cpp:
1834         (WTR::exceptionFilter):
1835         (WTR::TestController::platformInitialize):
1836         These changes set up an exception filter that prints #CRASHED to
1837         stderr, then lets the exception propagate normally. This allows
1838         run-webkit-tests to detect when we've crashed even when a post-mortem
1839         debugger attaches to the process.
1840
1841         * Scripts/old-run-webkit-tests:
1842         (top level): Declared some variables used by the crash-log-saving
1843         code.
1844         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
1845         that the post-mortem debugger has access to it.
1846         (toCygwinPath): Added. This is the opposite of toWindowsPath.
1847         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
1848         stderr, consider it a crash.
1849         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
1850         debugger, then sets ntsd as the post-mortem debugger. ntsd is
1851         configured to save a crash log and then quit automatically.
1852         (END): Added. Restores the previous post-mortem debugger when the
1853         script exits.
1854
1855 2010-08-17  Victor Wang  <victorw@chromium.org>
1856
1857         Reviewed by ojan@chromium.org.
1858
1859         Update test results server:
1860         1. Normalize test results and times after merging (prune tests where
1861            all runs pass or do not have data, truncate all test items to max
1862            number of builds)
1863         2. times should be int not string.
1864         3. when inserting a new test item, should keep old data regardless
1865            whether or not they have same item type with new one.
1866
1867         https://bugs.webkit.org/show_bug.cgi?id=43861
1868
1869         * TestResultServer/model/jsonresults.py:
1870         * TestResultServer/model/jsonresults_unittest.py:
1871
1872 2010-08-16  Sam Weinig  <sam@webkit.org>
1873
1874         Reviewed by Mark Rowe.
1875
1876         Add WebKit2 Mac tester to buildbot.
1877
1878         * BuildSlaveSupport/build.webkit.org-config/config.json:
1879         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1880
1881 2010-08-16  Paul Sawaya  <psawaya@apple.com>
1882
1883         Reviewed by Chris Marrin.
1884
1885         Added shader validation via ANGLE
1886         https://bugs.webkit.org/show_bug.cgi?id=42405
1887
1888         Added ANGLE to webkit build
1889
1890         * Scripts/build-webkit:
1891
1892 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
1893
1894         [wx] Build fix, do not build WebCore as a convenience library as this leads to
1895         errors in the Win build w/export symbols and causes problems with DOM bindings
1896         debugging in gdb.
1897
1898         * DumpRenderTree/wscript:
1899         * Scripts/build-webkit:
1900         * wx/browser/wscript:
1901         * wx/build/settings.py:
1902         * wx/build/waf_extensions.py:
1903
1904 2010-08-16  Dan Bernstein  <mitz@apple.com>
1905
1906         Build fix.
1907
1908         * WebKitTestRunner/TestController.cpp:
1909         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
1910         (WTR::TestController::initialize): Ditto.
1911
1912 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1913
1914         Reviewed by Kenneth Rohde Christiansen.
1915
1916         Handle content size change in WebKit2
1917         Re-landing after fix.
1918
1919         https://bugs.webkit.org/show_bug.cgi?id=43198
1920
1921         * MiniBrowser/mac/BrowserWindowController.m:
1922         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1923         * MiniBrowser/win/BrowserView.cpp:
1924         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1925
1926 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1927
1928         Unreviewed, rolling out r65419.
1929         http://trac.webkit.org/changeset/65419
1930         https://bugs.webkit.org/show_bug.cgi?id=44053
1931
1932         Broke the Windows build (Requested by bbandix on #webkit).
1933
1934         * MiniBrowser/mac/BrowserWindowController.m:
1935         (-[BrowserWindowController awakeFromNib]):
1936         * MiniBrowser/win/BrowserView.cpp:
1937         (BrowserView::create):
1938
1939 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1940
1941         Reviewed by Kenneth Rohde Christiansen.
1942
1943         Handle content size change in WebKit2
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=43198
1946
1947         * MiniBrowser/mac/BrowserWindowController.m:
1948         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1949         * MiniBrowser/win/BrowserView.cpp:
1950         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1951
1952 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1953
1954         Add my new email address to committers.py.
1955
1956         * Scripts/webkitpy/common/config/committers.py:
1957
1958 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1959
1960         Add my old e-mail addresses to committers.py.
1961
1962         * Scripts/webkitpy/common/config/committers.py:
1963
1964 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1965
1966         WebEditorClient::didBeginEditing is never called in WebKit2
1967         https://bugs.webkit.org/show_bug.cgi?id=42939
1968
1969         Reviewed by Sam Weinig.
1970
1971         * WebKitTestRunner/PlatformWebView.h:
1972         Declare focus().
1973
1974         * WebKitTestRunner/TestController.cpp:
1975         (WTR::TestController::resetStateToConsistentValues):
1976         Focus the PlatformWebView.
1977
1978         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1979         (WTR::PlatformWebView::focus):
1980         Stubbed.
1981
1982         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1983         (WTR::PlatformWebView::focus):
1984         Focus the view.
1985
1986 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1987
1988         run-webkit-tests should not strip editing callbacks when using
1989         WebKitTestRunner on Windows
1990         https://bugs.webkit.org/show_bug.cgi?id=44000
1991
1992         Reviewed by Mark Rowe.
1993
1994         * Scripts/old-run-webkit-tests:
1995         Leave $stripEditingCallbacks undefined until we look for command-line
1996         arguments. If using WebKit2, set it to 0 if not explicity set on the
1997         command line. Later, set it to isCygwin() to match old behavior if it is
1998         not yet defined.
1999
2000 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
2001
2002         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
2003
2004         * wx/build/settings.py:
2005
2006 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
2007
2008         Reviewed by Kenneth Rohde Christiansen.
2009
2010         [GTK] autogen.sh not executed if build-webkit options change
2011         https://bugs.webkit.org/show_bug.cgi?id=42266
2012
2013         Rerun autogen.sh in situations where the arguments to build-webkit have
2014         changed since the previous build. This will fix some issues on the bots
2015         where the build does not notice changes to default build-webkit arguments.
2016
2017         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
2018
2019 2010-08-14  Eric Seidel  <eric@webkit.org>
2020
2021         Unreviewed.  Another fix to support python 2.3.
2022
2023         Add support for MathML entities
2024         https://bugs.webkit.org/show_bug.cgi?id=43949
2025
2026         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
2027          - It looks like our simplejson is version 1.7.3 which
2028            should be python 2.3 compatible.  But someone modified
2029            our copy slightly from the original source.
2030            I've removed the relative import in hopes this fixes
2031            the problem.
2032
2033 2010-08-13  Eric Seidel  <eric@webkit.org>
2034
2035         Unreviewed.  Build fix only.
2036
2037         Add support for MathML entities
2038         https://bugs.webkit.org/show_bug.cgi?id=43949
2039
2040         * Scripts/create-html-entity-table:
2041          - Hack sys.path to avoid executing 2.5 dependent python
2042            on systems (like chromium-win and Tiger) which do not have 2.5 python.
2043
2044 2010-08-13  Adam Barth  <abarth@webkit.org>
2045
2046         Reviewed by Eric Seidel.
2047
2048         Rename some concepts in HTML entity search to be more self-documenting
2049         https://bugs.webkit.org/show_bug.cgi?id=44004
2050
2051         Reflect name change in generator script.
2052
2053         * Scripts/create-html-entity-table:
2054
2055 2010-08-12  Adam Barth  <abarth@webkit.org>
2056
2057         Reviewed by Eric Seidel.
2058
2059         Add support for MathML entities
2060         https://bugs.webkit.org/show_bug.cgi?id=43949
2061
2062         A script for generating the C++ state data structure describing all the
2063         entities from a JSON description.
2064
2065         * Scripts/create-html-entity-table: Added.
2066
2067 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
2068
2069         Reviewed by Eric Seidel.
2070
2071         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
2072         check for exceptions on all threads, not just the first thread.
2073         
2074         This change also changes the logging behavior for wedged threads
2075         to only dump the stacks of threads that are actually wedged.
2076
2077         Refactor the thread classes in the dump_render_tree_thread module
2078         to make the contract between TestRunner and TestShellThread clearer.
2079
2080         Added a bunch of unit tests.
2081         https://bugs.webkit.org/show_bug.cgi?id=38561
2082
2083         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2085         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2086
2087 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
2088
2089         Reviewed by Shinichiro Hamaji.
2090
2091         Add test_expectations.txt syntax checker to check-webkit-style.
2092         https://bugs.webkit.org/show_bug.cgi?id=43899
2093
2094         Just utilizing layout_tests/layout_package/test_expectations.py for checking
2095         the syntax of test_expectations.txt.
2096         This change also moves tab checking class from style/checkers/text.py to
2097         style/checkers/common.py for sharing code.
2098
2099         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2100         * Scripts/webkitpy/style/checker.py:
2101         * Scripts/webkitpy/style/checkers/common.py:
2102         * Scripts/webkitpy/style/checkers/common_unittest.py:
2103         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
2104         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
2105         * Scripts/webkitpy/style/checkers/text.py:
2106         * Scripts/webkitpy/style_references.py:
2107
2108 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2109
2110         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
2111         https://bugs.webkit.org/show_bug.cgi?id=43945
2112
2113         Reviewed by Sam Weinig.
2114
2115         * WebKitTestRunner/TestInvocation.cpp:
2116         (WTR::sizeWebViewForCurrentTest):
2117         Allow for a Windows-style path.
2118
2119         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2120         (WTR::PlatformWebView::resizeTo):
2121         Call SetWindowPos to resize the view window.
2122
2123 2010-08-12  David Levin  <levin@chromium.org>
2124
2125         Build break fix.
2126
2127         * WebKitTestRunner/TestController.cpp:
2128         (WTR::TestController::resetStateToConsistentValues): Removed usage
2129         of a variable that doesn't exist in the class.
2130
2131 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2132
2133         WebKitTestRunner needs to run tests without using native controls
2134         https://bugs.webkit.org/show_bug.cgi?id=43772
2135
2136         Reviewed by Sam Weinig.
2137
2138         * WebKitTestRunner/TestController.cpp:
2139         (WTR::TestController::initialize):
2140         Call platformInitializeContext().
2141
2142         * WebKitTestRunner/TestController.h:
2143         Declare platformInitializeContext().
2144
2145         * WebKitTestRunner/mac/TestControllerMac.mm:
2146         (WTR::TestController::platformInitializeContext):
2147         Stubbed.
2148
2149         * WebKitTestRunner/win/TestControllerWin.cpp:
2150         (WTR::TestController::platformInitializeContext):
2151         Call WKContextSetShouldPaintNativeControls() to disable native control
2152         drawing.
2153
2154 2010-08-12  Sam Weinig  <sam@webkit.org>
2155
2156         Reviewed by Alexey Proskuryakov.
2157
2158         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
2159         https://bugs.webkit.org/show_bug.cgi?id=43653
2160
2161         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2162         (WTR::InjectedBundle::InjectedBundle):
2163         (WTR::InjectedBundle::didReceiveMessage):
2164         (WTR::InjectedBundle::beginTesting):
2165         (WTR::InjectedBundle::done):
2166         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2167         (WTR::InjectedBundle::isTestRunning):
2168         (WTR::InjectedBundle::):
2169         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2170         (WTR::InjectedBundlePage::stopLoading):
2171         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2172         (WTR::InjectedBundlePage::dump):
2173         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2174         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2175         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2176         (WTR::InjectedBundlePage::didClearWindowForFrame):
2177         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2178         (WTR::InjectedBundlePage::willAddMessageToConsole):
2179         (WTR::InjectedBundlePage::willSetStatusbarText):
2180         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2181         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2182         (WTR::InjectedBundlePage::shouldBeginEditing):
2183         (WTR::InjectedBundlePage::shouldEndEditing):
2184         (WTR::InjectedBundlePage::shouldInsertNode):
2185         (WTR::InjectedBundlePage::shouldInsertText):
2186         (WTR::InjectedBundlePage::shouldDeleteRange):
2187         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2188         (WTR::InjectedBundlePage::shouldApplyStyle):
2189         (WTR::InjectedBundlePage::didBeginEditing):
2190         (WTR::InjectedBundlePage::didEndEditing):
2191         (WTR::InjectedBundlePage::didChange):
2192         (WTR::InjectedBundlePage::didChangeSelection):
2193         Don't do any work if we are not currently running a test.
2194
2195         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2196         * WebKitTestRunner/StringFunctions.h:
2197         (WTR::toCF):
2198         Add conversion function for WKURLRef -> CFURLRef
2199
2200         * WebKitTestRunner/TestController.cpp:
2201         (WTR::TestController::TestController):
2202         (WTR::TestController::initialize):
2203         (WTR::TestController::resetStateToConsistentValues):
2204         (WTR::TestController::runTest):
2205         (WTR::TestController::didFinishLoadForFrame):
2206         * WebKitTestRunner/TestController.h:
2207         (WTR::TestController::):
2208         * WebKitTestRunner/TestInvocation.cpp:
2209         (WTR::TestInvocation::invoke):
2210         * WebKitTestRunner/TestInvocation.h:
2211         Move resetting code to TestController.
2212
2213         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2214         * WebKitTestRunner/mac/TestControllerMac.mm:
2215         (WTR::TestController::runUntil):
2216         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2217         * WebKitTestRunner/win/TestControllerWin.cpp:
2218         (WTR::TestController::runUntil):
2219         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2220         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2221         Move runUntil to TestController.
2222
2223 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2224
2225         Unreviewed.
2226
2227         Adding myself to the committers list.
2228
2229         * Scripts/webkitpy/common/config/committers.py:
2230
2231 2010-08-12  Hayato Ito  <hayato@chromium.org>
2232
2233         Reviewed by Tony Chang.
2234
2235         Merge pretty printers for gdb.
2236         https://bugs.webkit.org/show_bug.cgi?id=43850
2237
2238         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
2239         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
2240         webcore.py is left for backward compatibility.
2241
2242         * gdb/webcore.py:
2243         * gdb/webkit.py: Added.
2244         * gdb/wtf.py: Removed.
2245
2246 2010-08-11  Tony Chang  <tony@chromium.org>
2247
2248         Reviewed by David Levin.
2249
2250         [chromium] add google-chrome layout test result directories
2251         https://bugs.webkit.org/show_bug.cgi?id=43889
2252
2253         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2254         * Scripts/webkitpy/layout_tests/port/factory.py:
2255         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
2256         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2257
2258 2010-08-11  Kent Tamura  <tkent@chromium.org>
2259
2260         Reviewed by Dimitri Glazkov.
2261
2262         [DRT/Chromium] Disable accelerated compositing
2263         https://bugs.webkit.org/show_bug.cgi?id=43894
2264
2265         Disable accelerated compositing because DRT is not ready for
2266         it. This change fixes hundreds of test crashes on Windows and
2267         Linux.
2268
2269         * DumpRenderTree/chromium/TestShell.cpp:
2270         (TestShell::resetWebSettings):
2271
2272 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2273
2274         Unreviewed. Adding my Collabora personality to the list.
2275
2276         * Scripts/webkitpy/common/config/committers.py:
2277
2278 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
2279
2280         Adding myself as a reviewer.
2281
2282         * Scripts/webkitpy/common/config/committers.py:
2283
2284 2010-08-11  Daniel Bates  <dbates@rim.com>
2285
2286         Reviewed by Darin Adler.
2287
2288         Perl warnings when running commit-log-editor
2289         https://bugs.webkit.org/show_bug.cgi?id=43856
2290
2291         Fixes Perl warnings introduced by the patch for Bug #40548.
2292
2293         Perl doesn't have symbolic names for True/False. Instead, we
2294         should use boolean values. Moreover, the variable installedEditorApplication
2295         is not be used and should be renamed builtEditorApplication so that it
2296         uses the existing machinery to set the commit log editor application.
2297
2298         * Scripts/commit-log-editor:
2299
2300 2010-08-11  Adam Barth  <abarth@webkit.org>
2301
2302         Reviewed by Eric Seidel.
2303
2304         Trying waiting for httpd lock in the EWS
2305         https://bugs.webkit.org/show_bug.cgi?id=43833
2306
2307         If this works, we can probably run the tests on the mac-ews, which
2308         would be very exciting.  :)
2309
2310         * Scripts/webkitpy/tool/steps/runtests.py:
2311
2312 2010-08-11  Marcus Bulach  <bulach@chromium.org>
2313
2314         Reviewed by Eric Seidel.
2315
2316         Check in a script to list redundant test outputs.
2317         https://bugs.webkit.org/show_bug.cgi?id=37630
2318
2319         If e.g. platform/mac-leopard is missing an expected test output, we
2320         fall back on platform/mac.  This means it's possible to grow redundant
2321         test outputs, where we have the same expected data in both a platform
2322         directory and another platform it falls back on.
2323         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
2324
2325         * Scripts/deduplicate-tests: Added.
2326         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
2327         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
2328
2329 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2330
2331         Reviewed by Ariya Hidayat.
2332
2333         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
2334         https://bugs.webkit.org/show_bug.cgi?id=43853
2335
2336         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
2337         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
2338         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
2339         to slots at all.
2340
2341         * QtTestBrowser/launcherwindow.cpp:
2342         (LauncherWindow::createChrome):
2343         (LauncherWindow::animatedFlip):
2344         (LauncherWindow::animatedYFlip):
2345         * QtTestBrowser/launcherwindow.h:
2346
2347 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2348
2349         Reviewed by Simon Hausmann.
2350
2351         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
2352         https://bugs.webkit.org/show_bug.cgi?id=43851
2353
2354         All window options data (including the bool holding if the view is either QWebView or
2355         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
2356         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
2357         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
2358         getting broken.
2359
2360         Patch addresses this issue.
2361
2362         * QtTestBrowser/launcherwindow.cpp:
2363         (LauncherWindow::createChrome):
2364         (LauncherWindow::toggleWebView):
2365         (LauncherWindow::toggleAcceleratedCompositing):
2366
2367 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
2368
2369         Reviewed by Ariya Hidayat.
2370
2371         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
2372         https://bugs.webkit.org/show_bug.cgi?id=43831
2373
2374         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
2375
2376         * QtTestBrowser/webview.cpp:
2377         (WebViewGraphicsBased::WebViewGraphicsBased):
2378         (WebViewGraphicsBased::animatedYFlip):
2379
2380 2010-08-11  Darin Adler  <darin@apple.com>
2381
2382         Reviewed by John Sullivan.
2383
2384         Improved editor options for prepare-ChangeLog and commit-log-editor
2385         https://bugs.webkit.org/show_bug.cgi?id=40548
2386
2387         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
2388         values like "xed --launch --wait" work properly.
2389
2390         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
2391         use a command line tool with the $openChangeLogs feature.
2392
2393 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
2394
2395         Reviewed by Pavel Feldman.
2396
2397         Web Inspector: remove InjectDispatch.js
2398         https://bugs.webkit.org/show_bug.cgi?id=43835
2399
2400         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2401         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2402
2403 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
2404
2405         Reviewed by Eric Seidel.
2406
2407         webkit-patch should refuse to run under Win32 Python
2408         https://bugs.webkit.org/show_bug.cgi?id=40962
2409
2410         Given that there are lots of places in webkit-patch's code that
2411         assume unix-style filenames (forward slashes), webkit-patch fails
2412         with weird file-not-found errors when run under a native windows
2413         Python. It would be nice if we just trapped this and errored out
2414         at the beginning, rather than producing unpredictable errors.
2415
2416         * Scripts/webkit-patch:
2417
2418 2010-08-10  Kent Tamura  <tkent@chromium.org>
2419
2420         Unreviewed, build fix.
2421         
2422         Chromium build fix for r65107.
2423
2424         * DumpRenderTree/chromium/LayoutTestController.cpp:
2425         (LayoutTestController::suspendAnimations):
2426         (LayoutTestController::resumeAnimations):
2427
2428 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
2429
2430         Reviewed by Xan Lopez.
2431
2432         [GTK] http/tests/media/video-cookie.html fails
2433         https://bugs.webkit.org/show_bug.cgi?id=42240
2434
2435         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2436         (LayoutTestController::setAlwaysAcceptCookies): create the
2437         SoupCookieJar if it does not exist. Otherwise the accept policy
2438         won't be set.
2439
2440 2010-08-10  Chris Marrin  <cmarrin@apple.com>
2441
2442         Reviewed by Oliver Hunt.
2443
2444         Add suspendAnimations/resumeAnimation API to DRT
2445         https://bugs.webkit.org/show_bug.cgi?id=43733
2446         
2447         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
2448         Calls functions with the same names on AnimationController for the 
2449         mainFrame.
2450
2451         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2452         * DumpRenderTree/LayoutTestController.cpp:
2453         (suspendAnimationsCallback):
2454         (resumeAnimationsCallback):
2455         (LayoutTestController::staticFunctions):
2456         * DumpRenderTree/LayoutTestController.h:
2457         * DumpRenderTree/chromium/LayoutTestController.cpp:
2458         (LayoutTestController::LayoutTestController):
2459         (LayoutTestController::suspendAnimations):
2460         (LayoutTestController::resumeAnimations):
2461         * DumpRenderTree/chromium/LayoutTestController.h:
2462         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2463         (LayoutTestController::suspendAnimations):
2464         (LayoutTestController::resumeAnimations):
2465         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2466         (LayoutTestController::suspendAnimations):
2467         (LayoutTestController::resumeAnimations):
2468         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2469         (LayoutTestController::suspendAnimations):
2470         (LayoutTestController::resumeAnimations):
2471         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2472         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2473         (LayoutTestController::suspendAnimations):
2474         (LayoutTestController::resumeAnimations):
2475         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2476         (LayoutTestController::suspendAnimations):
2477         (LayoutTestController::resumeAnimations):
2478
2479 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
2480
2481         Reviewed by Ojan Vafai.
2482
2483         [Chromium/DRT] Enable saving layout test results.
2484         https://bugs.webkit.org/show_bug.cgi?id=43796
2485
2486         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
2487             parameters to the new-run-webkit-tests, including the name
2488             of the test results server.
2489
2490 2010-08-10  Jian Li  <jianli@chromium.org>
2491
2492         More chromium build fix.
2493
2494         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2495         (MockSpellCheck::spellCheckWord):
2496         (MockSpellCheck::initializeIfNeeded):
2497         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2498         (NotificationPresenter::grantPermission):
2499         (NotificationPresenter::show):
2500         (NotificationPresenter::checkPermission):
2501
2502 2010-08-10  Jian Li  <jianli@chromium.org>
2503
2504         Chromium build fix.
2505
2506         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2507         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2508
2509 2010-08-10  Victor Wang  <victorw@chromium.org>
2510
2511         Reviewed by Ojan Vafai.
2512
2513         Update test results server merge logic so the aggregated
2514         results and times are updated for tests that are
2515         in aggragated json but not in incremental json.
2516
2517         Also update unittest to test this case.
2518
2519         https://bugs.webkit.org/show_bug.cgi?id=43769
2520
2521         * TestResultServer/model/jsonresults.py:
2522         * TestResultServer/model/jsonresults_unittest.py:
2523
2524 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2525
2526         Reviewed by Ariya Hidayat.
2527
2528         [Qt] QtTestBrowser: proper set scene rect
2529
2530         When resizesToContents is ON scene's rect is set to the boundary of
2531         the mainFrame. However, navigating to other web page should keep resizing
2532         scene's rect according to the new document loaded. Patch addresses this issue.
2533
2534         Now resizesToContents and scrolling properly work on QtTestBrowser.
2535
2536         * QtTestBrowser/webview.cpp:
2537         (WebViewGraphicsBased::setPage):
2538         (WebViewGraphicsBased::contentsSizeChanged):
2539         (WebViewGraphicsBased::setResizesToContents):
2540         (WebViewGraphicsBased::resizeEvent):
2541         * QtTestBrowser/webview.h:
2542
2543 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2544
2545         Reviewed by Ariya Hidayat.
2546
2547         [Qt] QtTestBrowser: Clean up LauncherWindow code.
2548
2549         * QtTestBrowser/launcherwindow.cpp:
2550         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
2551         (LauncherWindow::init): Fixed comments.
2552         (LauncherWindow::applyPrefs): Move the method around.
2553         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
2554
2555 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2556
2557         Reviewed by Ariya Hidayat.
2558
2559         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
2560
2561         It gets control+0 the same visual effect as control++ or control-.
2562
2563         * QtTestBrowser/launcherwindow.cpp:
2564         (LauncherWindow::toggleZoomTextOnly):
2565
2566 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2567
2568         Reviewed by Ariya Hidayat.
2569
2570         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
2571
2572         Not all instances of LauncherWindow need its own m_zoomLevel.
2573
2574         * QtTestBrowser/launcherwindow.cpp:
2575         * QtTestBrowser/launcherwindow.h:
2576
2577 2010-08-09  Sam Weinig  <sam@webkit.org>
2578
2579         Reviewed by Geoffrey Garen.
2580
2581         Add zoom support for injected bundle
2582         https://bugs.webkit.org/show_bug.cgi?id=43759
2583
2584         Use zoom factor SPI to implement zoom related eventSender functions.
2585
2586         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2587         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2588         (WTR::EventSendingController::textZoomIn):
2589         (WTR::EventSendingController::textZoomOut):
2590         (WTR::EventSendingController::zoomPageIn):
2591         (WTR::EventSendingController::zoomPageOut):
2592         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2594         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
2595
2596 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
2597
2598         Speculative chromium build fix III.
2599
2600         * DumpRenderTree/chromium/MockSpellCheck.h:
2601         * DumpRenderTree/chromium/NotificationPresenter.h:
2602         * DumpRenderTree/chromium/WebViewHost.h:
2603         (WebViewHost::addClearHeader):
2604         (WebViewHost::clearHeaders):
2605
2606 2010-08-09  Ojan Vafai  <ojan@chromium.org>
2607
2608         Reviewed by Tony Chang.
2609
2610         increase the number of test results that we save
2611         https://bugs.webkit.org/show_bug.cgi?id=43763
2612
2613         Now that we do incremental uploads, we can increase the number of
2614         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
2615
2616         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2617
2618 2010-08-09  Evan Martin  <evan@chromium.org>
2619
2620         Reviewed by Tony Chang.
2621
2622         [chromium] DRT error print statement incorrectly tries to print a FILE*
2623         https://bugs.webkit.org/show_bug.cgi?id=43747
2624
2625         * DumpRenderTree/chromium/ImageDiff.cpp:
2626         (writeFile): pass the correct pointer.
2627
2628 2010-08-09  Victor Wang  <victorw@chromium.org>
2629
2630         Reviewed by Ojan Vafai.
2631
2632         Upload incremental test results json to server by default.
2633
2634         https://bugs.webkit.org/show_bug.cgi?id=43743
2635
2636         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2637
2638 2010-08-09  Eric Seidel  <eric@webkit.org>
2639
2640         Reviewed by Adam Barth.
2641
2642         EWS bots wait 2 minutes between patches
2643         https://bugs.webkit.org/show_bug.cgi?id=43731
2644
2645         * Scripts/webkitpy/tool/bot/queueengine.py:
2646          - Don't sleep after failures.  This was a hold-over from
2647            an earlier design.
2648         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2649          - EWS bots were not properly reporting true/false from process_work_item.
2650            They were always returning None, thus false, thus always logging
2651            as a failure and sleeping 2 minutes after each patch.
2652
2653 2010-08-09  Sam Weinig  <sam@webkit.org>
2654
2655         Reviewed by Anders Carlsson.
2656
2657         Stub out EventSender for WebKitTestRunner
2658         https://bugs.webkit.org/show_bug.cgi?id=43703
2659
2660         * WebKitTestRunner/DerivedSources.make:
2661         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2662         Add ability to pass javascript arguments to the wrapped object.
2663
2664         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
2665         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
2666         (WTR::EventSendingController::create):
2667         (WTR::EventSendingController::EventSendingController):
2668         (WTR::EventSendingController::~EventSendingController):
2669         (WTR::EventSendingController::wrapperClass):
2670         (WTR::setExceptionForString):
2671         (WTR::EventSendingController::mouseDown):
2672         (WTR::EventSendingController::mouseUp):
2673         (WTR::EventSendingController::mouseMoveTo):
2674         (WTR::EventSendingController::keyDown):
2675         (WTR::EventSendingController::contextClick):
2676         (WTR::EventSendingController::leapForward):
2677         (WTR::EventSendingController::textZoomIn):
2678         (WTR::EventSendingController::textZoomOut):
2679         (WTR::EventSendingController::zoomPageIn):
2680         (WTR::EventSendingController::zoomPageOut):
2681         (WTR::EventSendingController::makeWindowObject):
2682         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
2683         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2684         (WTR::InjectedBundle::reset):
2685         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2686         (WTR::InjectedBundle::eventSendingController):
2687         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2688         (WTR::InjectedBundlePage::didClearWindowForFrame):
2689         Add stubbed out EventSenderController.
2690
2691         * WebKitTestRunner/InjectedBundle/GCController.h:
2692         Remove incorrect comment.
2693
2694         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2695         * WebKitTestRunner/win/InjectedBundle.vcproj:
2696         Add new files.
2697
2698 2010-08-08  Kent Tamura  <tkent@chromium.org>
2699
2700         Unreviewed, trivial fix.
2701
2702         Fix "WindowsError: [Error 32] The process cannot access the file
2703         because it is being used by another process" introduced by r64959.
2704
2705         * BuildSlaveSupport/test-result-archive:
2706
2707 2010-08-08  Kent Tamura  <tkent@chromium.org>
2708
2709         Reviewed by Tony Chang.
2710
2711         Chromium buildbot: Avoid "zip" command dependency
2712         https://bugs.webkit.org/show_bug.cgi?id=43470
2713
2714         * BuildSlaveSupport/test-result-archive:
2715          For Chromium port, creates a zip archive with zipfile package of Python
2716          instead of external "zip" command. We'd like to avoid additional
2717          command installation.
2718
2719 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
2720
2721         WebKitTestRunner should add the QuickTime dir to the PATH environment
2722         variable
2723         https://bugs.webkit.org/show_bug.cgi?id=43686
2724
2725         Reviewed by Dan Bernstein.
2726
2727         * WebKitTestRunner/win/TestControllerWin.cpp:
2728         (WTR::addQTDirToPATH):
2729         Copied from DRT.
2730         (WTR::TestController::platformInitialize):
2731         Call addQTDirToPath().
2732         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2733         Link to shlwapi.lib for SHGetValue.
2734
2735 2010-08-07  Sam Weinig  <sam@webkit.org>
2736
2737         Reviewed by Maciej Stachowiak.
2738
2739         WebKitTestRunner needs layoutTestController.dumpTitleChanges
2740         <rdar://problem/8213861>
2741         https://bugs.webkit.org/show_bug.cgi?id=42683
2742
2743         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2744         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2745         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2746         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2747         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2748         (WTR::LayoutTestController::LayoutTestController):
2749         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2750         (WTR::LayoutTestController::dumpTitleChanges):
2751         (WTR::LayoutTestController::shouldDumpTitleChanges):
2752
2753 2010-08-07  Sam Weinig  <sam@webkit.org>
2754
2755         Reviewed by Anders Carlsson.
2756
2757         WebKitTestRunner needs to print onunload handler information
2758         <rdar://problem/8213831>
2759         https://bugs.webkit.org/show_bug.cgi?id=42703
2760
2761         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2762         (WTR::operator<<):
2763         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2764
2765 2010-08-07  Sam Weinig  <sam@webkit.org>
2766
2767         Reviewed by Anders Carlsson.
2768
2769         Add additional loader client functions need to complete WebKitTestRunner
2770         https://bugs.webkit.org/show_bug.cgi?id=43684
2771
2772         Remove unnecessary and jarring underscores as well.
2773
2774         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2775         (didClearWindowObjectForFrame):
2776         (didCreatePage):
2777         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2778         (WTR::InjectedBundlePage::InjectedBundlePage):
2779         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2780         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2781         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2782         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2783         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2784         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2785         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2786         (WTR::InjectedBundlePage::didClearWindowForFrame):
2787         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
2788         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2789         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2790         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2791         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
2792         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
2793         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
2794         (WTR::InjectedBundlePage::willAddMessageToConsole):
2795         (WTR::InjectedBundlePage::willSetStatusbarText):
2796         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2797         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2798         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2799         (WTR::InjectedBundlePage::shouldBeginEditing):
2800         (WTR::InjectedBundlePage::shouldEndEditing):
2801         (WTR::InjectedBundlePage::shouldInsertNode):
2802         (WTR::InjectedBundlePage::shouldInsertText):
2803         (WTR::InjectedBundlePage::shouldDeleteRange):
2804         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2805         (WTR::InjectedBundlePage::shouldApplyStyle):
2806         (WTR::InjectedBundlePage::didBeginEditing):
2807         (WTR::InjectedBundlePage::didEndEditing):
2808         (WTR::InjectedBundlePage::didChange):
2809         (WTR::InjectedBundlePage::didChangeSelection):
2810         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2811
2812 2010-08-07  Dan Bernstein  <mitz@apple.com>
2813
2814         Build fix.
2815
2816         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
2817         to JSGCController.{cpp,h} relative to the build root.
2818
2819 2010-08-07  Sam Weinig  <sam@webkit.org>
2820
2821         Reviewed by Anders Carlsson.
2822
2823         WebKitTestRunner needs GCController
2824         <rdar://problem/8213834>
2825         https://bugs.webkit.org/show_bug.cgi?id=42701
2826
2827         * WebKitTestRunner/DerivedSources.make:
2828         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
2829         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2830         (WTR::setProperty):
2831         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
2832         (WTR::GCController::create):
2833         (WTR::GCController::GCController):
2834         (WTR::GCController::~GCController):
2835         (WTR::GCController::wrapperClass):
2836         (WTR::GCController::collect):
2837         (WTR::GCController::collectOnAlternateThread):
2838         (WTR::GCController::getJSObjectCount):
2839         (WTR::GCController::makeWindowObject):
2840         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
2841         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2842         (WTR::InjectedBundle::reset):
2843         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2844         (WTR::InjectedBundle::bundle):
2845         (WTR::InjectedBundle::gcController):
2846         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2847         (WTR::InjectedBundlePage::didClearWindowForFrame):
2848         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2849         (WTR::LayoutTestController::keepWebHistory):
2850         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2851         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2852         * WebKitTestRunner/win/InjectedBundle.vcproj:
2853
2854 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
2855
2856         WebKitTestRunner needs to be able to set the font smoothing type
2857         https://bugs.webkit.org/show_bug.cgi?id=43406
2858
2859         Reviewed by Adam Roben.
2860
2861         * WebKitTestRunner/TestInvocation.cpp:
2862         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2863         Set the font smoothing level to
2864         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2865
2866 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2867
2868         Fix a missed variable rename.
2869
2870         Unreviewed.
2871
2872         * Scripts/old-run-webkit-tests:
2873
2874 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2875
2876         mac-wk2/Skipped should be used on Windows when running regression tests
2877         https://bugs.webkit.org/show_bug.cgi?id=43494
2878
2879         Reviewed by Adam Roben.
2880
2881         * Scripts/old-run-webkit-tests:
2882         If the platform is win-wk2, also read the mac-wk2 skipped list.
2883
2884 2010-08-06  Kent Tamura  <tkent@chromium.org>
2885
2886         Reviewed by Dimitri Glazkov.
2887
2888         [DRT/Chromium] Should revoke scheduled tasks
2889         https://bugs.webkit.org/show_bug.cgi?id=43560
2890
2891         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2892         (DRTDevToolsAgent::reset): Calls RevokeAll().
2893         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2894         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2895         (DRTDevToolsClient::reset): Calls RevokeAll().
2896         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2897         * DumpRenderTree/chromium/EventSender.cpp:
2898         (EventSender::reset): Calls RevokeAll().
2899         * DumpRenderTree/chromium/LayoutTestController.cpp:
2900         (LayoutTestController::reset): Calls RevokeAll().
2901         * DumpRenderTree/chromium/TestShell.cpp:
2902         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2903
2904 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2905
2906         Reviewed by Antonio Gomes.
2907
2908         [Qt] Fix the DRT build on Mac OS X
2909
2910         * DumpRenderTree/qt/DumpRenderTree.pro:
2911
2912 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
2913
2914         Reviewed by Pavel Feldman.
2915
2916         Rietvield's upload.py moved to a different location.
2917         https://bugs.webkit.org/show_bug.cgi?id=43613
2918
2919         * Scripts/webkitpy/thirdparty/__init__.py:
2920
2921 2010-05-23  Eric Seidel  <eric@webkit.org>
2922
2923         Reviewed by Adam Barth.
2924
2925         QueueStatusServer needs better queue-status pages
2926         https://bugs.webkit.org/show_bug.cgi?id=39562
2927
2928         The primary goal of this patch is to display queue
2929         positions somewhere on the site so that it's easier
2930         for commit-queue users to know when their pach will
2931         be landed.  I also tried to improve the root page
2932         to be more useful than the previous wall of status text.
2933
2934         * QueueStatusServer/handlers/recentstatus.py:
2935         * QueueStatusServer/main.py:
2936         * QueueStatusServer/model/queues.py:
2937         * QueueStatusServer/templates/recentstatus.html:
2938
2939 2010-08-05  Victor Wang  <victorw@chromium.org>
2940
2941         Reviewed by Ojan Vafai.
2942
2943         Add option to generate/upload incremental json results to test result server.
2944         Also refactor the json results generator unittest code to test
2945         incremental and aggregated json results.
2946
2947         https://bugs.webkit.org/show_bug.cgi?id=43519
2948
2949         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2950         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2951         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2952         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2953
2954 2010-08-05  Jian Li  <jianli@chromium.org>
2955
2956         Reviewed by David Levin.
2957
2958         Unify blob related feature defines to ENABLE(BLOB).
2959         https://bugs.webkit.org/show_bug.cgi?id=43081
2960
2961         * Scripts/build-webkit:
2962
2963 2010-08-05  Satish Sampath  <satish@chromium.org>
2964
2965         Reviewed by Jeremy Orlow.
2966
2967         Add speech input controller mock in WebKit and a layout test.
2968         https://bugs.webkit.org/show_bug.cgi?id=43477
2969
2970         Added LayoutTestController::setMockSpeechInputResultCallback method.
2971
2972         * DumpRenderTree/LayoutTestController.cpp:
2973         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2974         (LayoutTestController::staticFunctions):
2975         * DumpRenderTree/LayoutTestController.h:
2976         * DumpRenderTree/chromium/LayoutTestController.cpp:
2977         (LayoutTestController::LayoutTestController):
2978         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2979         (LayoutTestController::speechInputController): Creates the mock controller.
2980         * DumpRenderTree/chromium/LayoutTestController.h:
2981         * DumpRenderTree/chromium/WebViewHost.cpp:
2982         (WebViewHost::speechInputController): Creates the mock controller.
2983         * DumpRenderTree/chromium/WebViewHost.h:
2984         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2985         (LayoutTestController::setMockSpeechInputResult): dummy method.
2986         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2987         (LayoutTestController::setMockSpeechInputResult): dummy method.
2988         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2989         (LayoutTestController::setMockSpeechInputResult): dummy method.
2990         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2991         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2992         (LayoutTestController::setMockSpeechInputResult):
2993         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2994         (LayoutTestController::setMockSpeechInputResult):
2995
2996 2010-08-04  Adam Roben  <aroben@apple.com>
2997
2998         Fix the path to TestNetscapePlugin's directory on Windows
2999
3000         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
3001         load TestNetscapePlugin
3002
3003         Reviewed by Jon Honeycutt.
3004
3005         * WebKitTestRunner/win/TestControllerWin.cpp:
3006         (WTR::TestController::initializeTestPluginDirectory):
3007         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
3008         next to WebKitTestRunner.exe. Previously we were passing the directory
3009         that contains WebKitTestRunner.exe. Also fixed some leaks.
3010
3011 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
3012
3013         Reviewed by Shinichiro Hamaji.
3014
3015         check-webkit-style returns non-zero when patch is entirely minus lines.
3016         https://bugs.webkit.org/show_bug.cgi?id=38169
3017
3018         * Scripts/check-webkit-style:
3019         Check whether a patch contains modified files that are entirely minus lines.
3020         * Scripts/webkitpy/style/filereader.py:
3021         Add a variable that holds number of files that contain only deleted lines.
3022         * Scripts/webkitpy/style/patchreader.py:
3023         Count up modified files that contain only deleted lines.
3024
3025 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
3026
3027         Reviewed by Yury Semikhatsky.
3028
3029         DevTools: get rid of delayed command dispatching on front-end side.
3030
3031         https://bugs.webkit.org/show_bug.cgi?id=43479
3032
3033         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3034         (DRTDevToolsAgent::detach):
3035         (DRTDevToolsAgent::frontendLoaded):
3036         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3037         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3038         (DRTDevToolsClient::~DRTDevToolsClient):
3039         (DRTDevToolsClient::sendFrontendLoaded):
3040         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3041
3042 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
3043
3044         Reviewed by Shinichiro Hamaji.
3045
3046         Fixes check-webkit-style false positive on "new uint32_t."
3047         https://bugs.webkit.org/show_bug.cgi?id=43077
3048
3049         * Scripts/webkitpy/style/checkers/cpp.py:
3050         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3051
3052 2010-08-04  Kent Tamura  <tkent@chromium.org>
3053
3054         Reviewed by Dimitri Glazkov.
3055
3056         [DRT/Chromium] Remove base/linked_ptr.h dependency
3057         https://bugs.webkit.org/show_bug.cgi?id=43472
3058
3059         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
3060         We need to use RefPtr<> because m_pendingEntry points an object in
3061         m_entries or not in m_entries.
3062
3063         * DumpRenderTree/chromium/TestNavigationController.cpp:
3064         (TestNavigationEntry::create): Added.
3065         (TestNavigationController::activeEntry):
3066         (TestNavigationController::didNavigateToEntry):
3067         (TestNavigationController::discardPendingEntry):
3068         (TestNavigationController::insertEntry):
3069         (TestNavigationController::navigateToPendingEntry):
3070         * DumpRenderTree/chromium/TestNavigationController.h:
3071         * DumpRenderTree/chromium/WebViewHost.cpp:
3072         (WebViewHost::loadURLForFrame):
3073          Use TestNavigationEntry::create().
3074         (WebViewHost::updateURL):
3075          Use RefPtr<>.
3076         (WebViewHost::updateSessionHistory):
3077          Remove unnecessary static_cast<>.
3078
3079 2010-08-04  Kent Tamura  <tkent@chromium.org>
3080
3081         Reviewed by Dimitri Glazkov.
3082
3083         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
3084         https://bugs.webkit.org/show_bug.cgi?id=43333
3085
3086         * BuildSlaveSupport/test-result-archive:
3087           - Make layoutTestResultsDir local and pass it to archiveTestResults()
3088           - Adjust layoutTestResultsDir for Chromium
3089
3090 2010-08-04  Kent Tamura  <tkent@chromium.org>
3091
3092         Reviewed by Dimitri Glazkov.
3093
3094         NRWT: websocket_server startup detection failure
3095         https://bugs.webkit.org/show_bug.cgi?id=43466
3096
3097         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3098          Increase timeout value: 5 second -> 10 second
3099
3100 2010-08-04  Victor Wang  <victorw@chromium.org>
3101
3102         Reviewed by Ojan Vafai.
3103
3104         -. Add result.json incremental merging functionality to test results app engine.
3105         -. blobstore is not suitable for AE data merging and there is no API to
3106            programatically edit existing blob or write a new one yet, so replace blobstore
3107            with datastore. If file is oversize (>1000*1000 bytes), store file data in
3108            multiple datastore entries.
3109         -. Fix styles.
3110
3111         Test: jsonresults_unittest to test merging logics.
3112
3113         https://bugs.webkit.org/show_bug.cgi?id=38599
3114
3115         * TestResultServer/handlers/dashboardhandler.py:
3116         * TestResultServer/handlers/menu.py:
3117         * TestResultServer/handlers/testfilehandler.py:
3118         * TestResultServer/main.py:
3119         * TestResultServer/model/dashboardfile.py:
3120         * TestResultServer/model/datastorefile.py: Added.
3121         * TestResultServer/model/jsonresults.py: Added.
3122         * TestResultServer/model/jsonresults_unittest.py: Added.
3123         * TestResultServer/model/testfile.py:
3124         * TestResultServer/templates/uploadform.html:
3125
3126 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3127
3128         Reviewed by Kenneth Christiansen.
3129
3130         [Qt] [QtTestBrowser] Remove unneeded QAction class members
3131         https://bugs.webkit.org/show_bug.cgi?id=43518
3132
3133         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
3134         m_flipYAnimated. Also, in initializeView method there are some dead code block
3135         trying to connect them at the wrong time, when they have not been instanciated.
3136
3137         This patch:
3138
3139         - removes the two cited class members in favor of local variables in createChrome method;
3140         - removes the dead code block.
3141
3142         * QtTestBrowser/launcherwindow.cpp:
3143         (LauncherWindow::LauncherWindow):
3144         (LauncherWindow::initializeView):
3145         (LauncherWindow::createChrome):
3146         * QtTestBrowser/launcherwindow.h:
3147
3148 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3149
3150         Reviewed by Simon Hausmann and Kenneth Christiansen.
3151
3152         [Qt] [QtTestBrowser] Clean up static and global menu state controls
3153         https://bugs.webkit.org/show_bug.cgi?id=43448
3154
3155         After LauncherWindow class was refactored out of from main.cpp, all global variables that
3156         were hanging in main.cpp became temporarily public static class members of newly added
3157         LauncherWindow class. This design was not properly handling the initial purpose of the
3158         global variables: newly created launcher windows should inherit the settings of the originating
3159         one.
3160
3161         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
3162         comprises all data needed to handling the goal described above.
3163
3164         * QtTestBrowser/launcherwindow.cpp:
3165         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
3166                                           holding all user settings configured in the menus and command line.
3167                                           It also receices an optional QGraphicsScene points in case we are doing
3168                                           a "Clone Window".
3169         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
3170                                 value.
3171         (LauncherWindow::initializeView): Ditto.
3172         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
3173         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
3174                                       apply the preferences is provided by m_userData.
3175         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
3176         (LauncherWindow::toggleResizesToContents): Ditto.
3177         (LauncherWindow::toggleWebGL): Ditto.
3178         (LauncherWindow::toggleFrameFlattening): Ditto.
3179         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
3180         (LauncherWindow::changeViewportUpdateMode): Ditto.
3181         (LauncherWindow::showFPS): Ditto.
3182         (LauncherWindow::newWindow): Changed to pass the userData.
3183         (LauncherWindow::cloneWindow): Ditto.
3184         * QtTestBrowser/launcherwindow.h:
3185         (WindowOptions::WindowOptions):
3186         * QtTestBrowser/main.cpp:
3187         (requiresGraphicsView):
3188         (LauncherApplication::handleUserOptions):
3189         (main):
3190
3191 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
3192
3193         [wx] Build fix for gcc not importing all symbols from convenience libraries.
3194         Works on 10.6 only for Mac until the build system is reworked. 
3195
3196         * wx/build/settings.py:
3197
3198 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
3199
3200         Reviewed by Simon Hausmann.
3201
3202         [Qt] Change wording in QtTestBrowser
3203         https://bugs.webkit.org/show_bug.cgi?id=43241
3204
3205         * QtTestBrowser/launcherwindow.cpp:
3206         (LauncherWindow::createChrome):
3207
3208 2010-08-04  Aaron Boodman  <aa@chromium.org>
3209
3210         Reviewed by Eric Seidel.
3211
3212         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
3213         https://bugs.webkit.org/show_bug.cgi?id=43460
3214
3215         * Scripts/prepare-ChangeLog:
3216
3217 2010-08-03  MORITA Hajime  <morrita@google.com>
3218
3219         Reviewed by Tony Chang.
3220
3221         [DRT] Assertion failed when drag and move a draggable element.
3222         https://bugs.webkit.org/show_bug.cgi?id=41695
3223
3224         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
3225         But Cocoa doesn't call mouseDragged() until dragging is done.
3226         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
3227         on UIDelegate failed when mouseDragged() is called during dragging.
3228         This change eliminated the mouseDragged() call when dragging begins,
3229         which is implicated by draggingInfo instance.
3230         
3231         * DumpRenderTree/mac/EventSendingController.mm:
3232         (-[EventSendingController mouseMoveToX:Y:]):
3233
3234         Test: fast/events/dragging-mouse-moves.html
3235         
3236 2010-08-02  Steve Block  <steveblock@google.com>
3237
3238         Reviewed by Alexey Proskuryakov.
3239
3240         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
3241         https://bugs.webkit.org/show_bug.cgi?id=40002
3242
3243         The code in LayoutTestController::setGeolocationPermission() was moved to
3244         setGeolocationPermissionCommon() to allow each port to provide its own
3245         implementation of setGeolocationPermission().
3246
3247         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
3248         new permission, so it can call back to WebCore if permission requests are in
3249         progress and are waiting for a response. A minor fix to the Mac
3250         MockGeolocationProvider was also required to make sure that the mock provider
3251         calls back to WebCore when it is first started.
3252
3253         For other ports, LayoutTestController::setGeolocationPermission() is not
3254         implemented.
3255
3256         * DumpRenderTree/LayoutTestController.cpp:
3257         (LayoutTestController::setGeolocationPermissionCommon):
3258         * DumpRenderTree/LayoutTestController.h:
3259         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3260         (LayoutTestController::setGeolocationPermission):
3261         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3262         (LayoutTestController::setGeolocationPermission):
3263         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3264         (-[MockGeolocationProvider registerWebView:]):
3265         * DumpRenderTree/mac/UIDelegate.h:
3266         * DumpRenderTree/mac/UIDelegate.mm:
3267         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3268         (-[UIDelegate setGeolocationPermission:]):
3269         (-[UIDelegate dealloc]):
3270         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3271         (LayoutTestController::setGeolocationPermission):
3272         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3273         (LayoutTestController::setGeolocationPermission):
3274
3275 2010-08-03  Kent Tamura  <tkent@chromium.org>
3276
3277         Reviewed by Dimitri Glazkov.
3278
3279         [DRT/Chromium] Implement --testshell-startup-dialog
3280         https://bugs.webkit.org/show_bug.cgi?id=40616
3281
3282         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3283         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
3284         if it is specfied.
3285         * DumpRenderTree/chromium/TestShell.h:
3286           Declare openStartUpDialog().
3287         * DumpRenderTree/chromium/TestShellGtk.cpp:
3288         (openStartupDialog):
3289         * DumpRenderTree/chromium/TestShellMac.mm:
3290         (openStartupDialog):
3291         * DumpRenderTree/chromium/TestShellWin.cpp:
3292         (openStartupDialog):
3293
3294 2010-08-03  Kent Tamura  <tkent@chromium.org>
3295
3296         Reviewed by Dimitri Glazkov.
3297
3298         [DRT/Chromium] Remove dependency of base/md5.h
3299         https://bugs.webkit.org/show_bug.cgi?id=43403
3300
3301         * DumpRenderTree/chromium/TestShell.cpp:
3302         (TestShell::dumpImage): Use wtf/MD5.h
3303
3304 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
3305
3306         Reviewed by David Kilzer.
3307
3308         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
3309         https://bugs.webkit.org/show_bug.cgi?id=40627
3310
3311         Part 6 - LayoutTest and Cleanup
3312
3313           Allow tests to delete application caches and set application cache
3314           origin quotas, so they can be tested.
3315
3316         * DumpRenderTree/LayoutTestController.cpp:
3317         (LayoutTestController::LayoutTestController):
3318         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
3319         (clearAllApplicationCachesCallback): should delete all application caches.
3320         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
3321         (LayoutTestController::staticFunctions):
3322         * DumpRenderTree/LayoutTestController.h:
3323         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
3324         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
3325
3326           Mac implementation.
3327
3328         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3329         (LayoutTestController::clearAllApplicationCaches): delete application caches.
3330         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
3331         * DumpRenderTree/mac/UIDelegate.mm:
3332         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
3333         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
3334
3335           Stub implementations for other platforms.
3336
3337         * DumpRenderTree/chromium/LayoutTestController.cpp:
3338         (LayoutTestController::LayoutTestController):
3339         (LayoutTestController::clearAllApplicationCaches):
3340         (LayoutTestController::setApplicationCacheOriginQuota):
3341         * DumpRenderTree/chromium/LayoutTestController.h:
3342         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3343         (LayoutTestController::clearAllApplicationCaches):
3344         (LayoutTestController::setApplicationCacheOriginQuota):
3345         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3346         (LayoutTestController::clearAllApplicationCaches):
3347         (LayoutTestController::setApplicationCacheOriginQuota):
3348         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3349         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3350         (LayoutTestController::clearAllApplicationCaches):
3351         (LayoutTestController::setApplicationCacheOriginQuota):
3352         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3353         (LayoutTestController::clearAllApplicationCaches):
3354         (LayoutTestController::setApplicationCacheOriginQuota):
3355
3356 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
3357
3358         Reviewed by David Kilzer.
3359
3360         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
3361         https://bugs.webkit.org/show_bug.cgi?id=40627
3362
3363         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
3364
3365           Change old style calls to make use of the managers.
3366
3367         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3368         (LayoutTestController::setDatabaseQuota):
3369         * DumpRenderTree/mac/UIDelegate.mm:
3370         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3371
3372 2010-08-03  Mark Rowe  <mrowe@apple.com>
3373
3374         Add a new Leopard build slave to run the release tests.
3375
3376         * BuildSlaveSupport/build.webkit.org-config/config.json:
3377
3378 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
3379
3380         WebKitTestRunner needs to activate the Mac font ascent hack
3381         https://bugs.webkit.org/show_bug.cgi?id=43404
3382
3383         Reviewed by Darin Adler.
3384
3385         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3386         (WTR::InjectedBundle::initialize):
3387         Call WKBundleActivateMacFontAscentHack().
3388
3389 2010-08-03  Alex Milowski  <alex@milowski.com>
3390
3391         Reviewed by Beth Dakin.
3392
3393         Changed the default for MathML support so that is is enabled by default.
3394
3395         * Scripts/build-webkit:
3396
3397 2010-08-03  Sam Weinig  <sam@webkit.org>
3398
3399         Roll r64566 back in this time with all the overloads in place..
3400
3401         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3402         (WTR::InjectedBundlePage::shouldInsertNode):
3403         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3404         * WebKitTestRunner/StringFunctions.h:
3405         * WebKitTestRunner/TestInvocation.cpp:
3406         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3407         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3408         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3409
3410 2010-08-03  Sam Weinig  <sam@webkit.org>
3411
3412         Rollout r64566. It broke all the WebKit2 tests.
3413
3414         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3415         (WTR::operator<<):
3416         (WTR::InjectedBundlePage::shouldInsertNode):
3417         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3418         * WebKitTestRunner/StringFunctions.h: Removed.
3419         * WebKitTestRunner/TestInvocation.cpp:
3420         (WTR::createWKURL):
3421         (WTR::WKStringToUTF8):
3422         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3423         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3424         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3425
3426 2010-08-03  Sam Weinig  <sam@webkit.org>
3427
3428         Reviewed by Anders Carlsson.
3429
3430         WTR: Move all the utility functions for working with strings to a shared header.
3431         https://bugs.webkit.org/show_bug.cgi?id=43386
3432
3433         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3434         (WTR::InjectedBundlePage::shouldInsertNode):
3435         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3436         * WebKitTestRunner/StringFunctions.h: Added.
3437         * WebKitTestRunner/TestInvocation.cpp:
3438         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3439         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3440         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3441
3442 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
3443
3444         Reviewed by Kenneth Christiansen.
3445
3446         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
3447         https://bugs.webkit.org/show_bug.cgi?id=43168
3448
3449         QGraphicsWebView resizesToContents property has to work together with QWebPage's
3450         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
3451
3452         * QtTestBrowser/launcherwindow.cpp:
3453         (LauncherWindow::applyPrefs):
3454         * QtTestBrowser/webview.cpp:
3455         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
3456                                                       needed when toggle resizesToContents on/off.
3457         (WebViewGraphicsBased::resizeEvent):
3458         * QtTestBrowser/webview.h:
3459         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
3460         (WebViewGraphicsBased::customLayoutSize): Getter helper.
3461
3462 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
3463
3464         Unreviewed. Adding myself as committer.
3465
3466         * Scripts/webkitpy/common/config/committers.py:
3467
3468 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
3469
3470         Reviewed by Yury Semikhatsky.
3471
3472         Chromium DevTools: Get rid of DevTools RPC.
3473
3474         https://bugs.webkit.org/show_bug.cgi?id=43335
3475
3476         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3477         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
3478         (DRTDevToolsAgent::call):
3479         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3480         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
3481         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
3482         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3483         (DRTDevToolsClient::sendMessageToBackend):
3484         (DRTDevToolsClient::call):
3485         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3486
3487 2010-08-02  Kent Tamura  <tkent@chromium.org>
3488
3489         Reviewed by Dimitri Glazkov.
3490
3491         [DRT/Chromium] Remove dependencies to some Chromium headers
3492         https://bugs.webkit.org/show_bug.cgi?id=43396
3493
3494         * DumpRenderTree/chromium/CppVariant.h:
3495          Remove base/basictypes.h because webkit_support.h contains it.
3496         * DumpRenderTree/chromium/EventSender.cpp:
3497         (getCurrentEventTimeSec): Use new wrapper function.
3498         * DumpRenderTree/chromium/TestNavigationController.h:
3499          Remove base/basictypes.h because webkit_support.h contains it.
3500         * DumpRenderTree/chromium/TestShell.cpp:
3501         (dumpHistoryItem): Use new wrapper function.
3502         * DumpRenderTree/chromium/WebViewHost.cpp:
3503         (WebViewHost::cancelledError): Use new wrapper function.
3504         (WebViewHost::didFailResourceLoad): Use new wrapper function.
3505
3506 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3507
3508         Reviewed by Xan Lopez.
3509
3510         [GTK] DRT implement execCommand()
3511         https://bugs.webkit.org/show_bug.cgi?id=35351
3512
3513         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3514         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
3515         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
3516         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
3517
3518 2010-08-02  Sam Weinig  <sam@webkit.org>
3519
3520         Reviewed by Anders Carlsson.
3521
3522         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
3523
3524         * Scripts/old-run-webkit-tests:
3525
3526 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
3527
3528         WebKitTestRunner needs to support loading custom fonts (via the
3529         WEBKIT_TESTFONTS environment variable)
3530         https://bugs.webkit.org/show_bug.cgi?id=42782
3531
3532         Reviewed by Adam Roben.
3533
3534         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
3535         (WTR::fontsPath):
3536         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
3537         as this directory doesn't appear to be created anymore.
3538         (WTR::activateFonts):
3539         Loop through the fonts, and call AddFontResourceExW() for each.
3540
3541 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
3542
3543         Restore the WebKitTestRunner.sln that was removed, and remove the
3544         correct one.
3545
3546         Rubber-stamped by Sam Weinig.
3547
3548         * WebKitTestRunner/WebKitTestRunner.sln: Added.
3549         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
3550
3551 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
3552
3553         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
3554
3555         Remove the unused WebKitTestRunner.sln.
3556
3557         Reviewed by Sam Weinig.
3558
3559         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3560         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
3561         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
3562         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
3563         * WebKitTestRunner/win/WebKitTestRunner.sln:
3564
3565 2010-08-02  Sam Weinig  <sam@webkit.org>
3566
3567         Fix the windows build.
3568
3569         * WebKitTestRunner/win/main.cpp:
3570
3571 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
3572
3573         Add a Skipped list on Windows, and have run-webkit-tests respect it.
3574