Don't hang in WebKitAPITest if no messages have been posted
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-05  Adam Roben  <aroben@apple.com>
2
3         Don't hang in WebKitAPITest if no messages have been posted
4
5         Part of <http://webkit.org/b/33212> Small fixes/improvements to
6         WebKitAPITest
7
8         Reviewed by Sam Weinig.
9
10         * WebKitAPITest/tests/WebViewDestruction.cpp:
11         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
12         to avoid hanging if no messages have been posted.
13
14 2010-01-05  Adam Roben  <aroben@apple.com>
15
16         Fix WebKitCreateInstance helper
17
18         Part of <http://webkit.org/b/33212> Small fixes/improvements to
19         WebKitAPITest
20
21         Reviewed by Sam Weinig.
22
23         * WebKitAPITest/tests/WebViewDestruction.cpp:
24         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
25         through, instead of taking its address.
26
27 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
28
29         Reviewed by Darin Fisher.
30
31         Reorganize, document and rename OS() platform macros.
32         https://bugs.webkit.org/show_bug.cgi?id=33198
33
34         Adapt to name changes.
35         
36         * DumpRenderTree/DumpRenderTree.h:
37         * DumpRenderTree/config.h:
38
39 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
40
41         Reviewed by Eric Seidel.
42
43         Minor improvements to test-webkit-scripts, as suggested
44         by an earlier review.
45
46         https://bugs.webkit.org/show_bug.cgi?id=33125
47
48         * Scripts/test-webkit-scripts:
49           - Used OptionParser class instead of getopt.getopt().
50           - Created main() method for __main__ block.
51           - Enclosed functions in a class.
52
53 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
54
55         No review. Fix DRT breakage on Tiger/Leopard.
56
57         Add ARIA "Live Region" support
58         https://bugs.webkit.org/show_bug.cgi?id=33117
59
60         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
61
62 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
63
64         Reviewed by Darin Adler.
65
66         Add ARIA "Live Region" support
67         https://bugs.webkit.org/show_bug.cgi?id=33117
68
69         * DumpRenderTree/AccessibilityUIElement.cpp:
70         (indexOfChildCallback):
71         (boolAttributeValueCallback):
72         (stringAttributeValueCallback):
73         (addNotificationListenerCallback):
74         (AccessibilityUIElement::getJSClass):
75         * DumpRenderTree/AccessibilityUIElement.h:
76         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
77         (AccessibilityUIElement::indexOfChild):
78         (AccessibilityUIElement::stringAttributeValue):
79         (AccessibilityUIElement::boolAttributeValue):
80         (AccessibilityUIElement::addNotificationListener):
81         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
82         (AccessibilityUIElement::indexOfChild):
83         (AccessibilityUIElement::stringAttributeValue):
84         (AccessibilityUIElement::boolAttributeValue):
85         (_accessibilityNotificationCallback):
86         (AccessibilityUIElement::addNotificationListener):
87         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
88         (AccessibilityUIElement::indexOfChild):
89         (AccessibilityUIElement::stringAttributeValue):
90         (AccessibilityUIElement::boolAttributeValue):
91         (AccessibilityUIElement::addNotificationListener):
92
93 2010-01-04  Eric Seidel  <eric@webkit.org>
94
95         Reviewed by Adam Barth.
96
97         bugzilla-tool rollout should require a reason
98         https://bugs.webkit.org/show_bug.cgi?id=30810
99
100         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
101         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
102         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
103         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
104         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
105
106 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
107
108         MSAA: <select> elements should broadcast value change events
109
110         https://bugs.webkit.org/show_bug.cgi?id=33088
111
112         <rdar://problem/7332364>
113
114         Reviewed by Darin Adler.
115
116         * DumpRenderTree/AccessibilityController.cpp:
117         (logValueChangeEventsCallback):
118         Start logging value change events.
119         (AccessibilityController::getJSClass):
120         Add a "logValueChangeEvents" to the AccessibilityController's JS class
121         definition.
122         (AccessibilityController::resetToConsistentState):
123         Disable logging of value change events.
124
125         * DumpRenderTree/AccessibilityController.h:
126         Declare setLogValueChangeEvents(), and add a member variable for the
127         value change event hook.
128
129         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
130         (AccessibilityController::setLogValueChangeEvents):
131         Stubbed.
132
133         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
134         (AccessibilityController::setLogValueChangeEvents):
135         Stubbed.
136
137         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
138         (AccessibilityController::AccessibilityController):
139         Initialize new member var.
140         (AccessibilityController::~AccessibilityController):
141         Disable logging of value change events.
142         (logEventProc):
143         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
144         and its value.
145         (AccessibilityController::setLogValueChangeEvents):
146         If disabling logging, unhook the event, and clear the event hook
147         member var. Otherwise, query for the root element to enable
148         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
149
150 2010-01-04  Adam Barth  <abarth@webkit.org>
151
152         Reviewed by Eric Seidel.
153
154         long_help for submit-patch
155         https://bugs.webkit.org/show_bug.cgi?id=33184
156
157         * Scripts/webkitpy/commands/upload.py:
158
159 2010-01-04  Adam Barth  <abarth@webkit.org>
160
161         Reviewed by Eric Seidel.
162
163         commit-queue can wrongly reject patches if the buildbots are behind
164         https://bugs.webkit.org/show_bug.cgi?id=30098
165
166         Check to make sure we can currently build and test before trying to
167         land a patch.
168
169         * Scripts/webkitpy/commands/queues.py:
170
171 2010-01-04  Adam Roben  <aroben@apple.com>
172
173         Add a test harness for the Windows WebKit API, and a few tests
174
175         We currently only have tests for a handful of bugs regarding WebView
176         destruction, but more tests can easily be added later. Eventually
177         we'll run these tests as part of run-webkit-tests.
178
179         Fixes <http://webkit.org/b/33167>.
180
181         Reviewed by Sam Weinig.
182
183         * WebKitAPITest/HostWindow.cpp: Added.
184         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
185         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
186         needed.
187         (WebKitAPITest::HostWindow::initialize): Create our window.
188         (WebKitAPITest::HostWindow::clientRect): Return our window's client
189         rect.
190         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
191         (WebKitAPITest::HostWindow::wndProc): Just call through to
192         DefWindowProcW.
193
194         * WebKitAPITest/HostWindow.h: Added.
195         (WebKitAPITest::HostWindow::window): Simple getter.
196
197         * WebKitAPITest/Test.h: Added. This file defines some macros useful
198         for writing tests.
199
200         * WebKitAPITest/TestsController.cpp: Added.
201         (WebKitAPITest::TestsController::TestsController): Initialize our
202         members.
203         (WebKitAPITest::TestsController::shared): Return the shared instance.
204         (WebKitAPITest::TestsController::runAllTests): Run a message pump
205         until a WM_QUIT message is received, then return whether all tests
206         succeeded.
207         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
208         start running tests soon.
209         (WebKitAPITest::TestsController::testFailed): Record the failure and
210         print a message about it to stdout.
211         (WebKitAPITest::TestsController::runNextTest): If we don't have any
212         tests to run, post a WM_QUIT message to stop the message pump.
213         Otherwise, run the test and print whether it passed, then schedule the
214         next test.
215         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
216         to run the next test.
217         (WebKitAPITest::TestsController::registerWindowClass): Does what it
218         says.
219         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
220         fired, call runNextTest(). Pass everything else through to
221         DefWindowProcW.
222
223         * WebKitAPITest/TestsController.h: Added.
224
225         * WebKitAPITest/WebKitAPITest.vcproj: Added.
226
227         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
228
229         * WebKitAPITest/main.cpp: Added.
230         (main): (Mostly) just calls TestsController::runAllTests.
231
232         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
233         (WebKitAPITest::WebKitCreateInstance): Helper function template to
234         call through to the real WebKitCreateInstance.
235         (WebKitAPITest::webViewCount): Helper function to call through to
236         IWebKitStatistics::webViewCount.
237         (WebKitAPITest::createWebView): Helper function to create a WebView
238         and put it inside a HostWindow.
239         (WebKitAPITest::runMessagePump): Helper function to run a message pump
240         for a specified number of milliseconds, or until a WM_QUIT message is
241         received.
242         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
243         <http://webkit.org/b/32827>.
244         (WebKitAPITest::MainFrameAfterClose): Test for
245         <http://webkit.org/b/32868>.
246         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
247         <http://webkit.org/b/33162>.
248
249 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
250
251         Reviewed by David Kilzer.
252
253         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
254
255         https://bugs.webkit.org/show_bug.cgi?id=32820
256
257         * Scripts/VCSUtils.pm:
258         * Scripts/svn-apply:
259         * Scripts/svn-unapply:
260         * Scripts/test-webkitperl: Run gitdiff2svndiff test
261         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
262         * Scripts/webkitpy/diff_parser.py:
263         * Scripts/webkitpy/diff_parser_unittest.py:
264
265 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
266
267         Reviewed by David Kilzer.
268
269         Divided the Perl unit tests into separate files and put
270         them in a separate directory, and renamed test-webkit-perl
271         to test-webkitperl.
272
273         https://bugs.webkit.org/show_bug.cgi?id=33124
274
275         * Scripts/VCSUtils.pm:
276           - Renamed generateRunPatchCommand() to generatePatchCommand().
277
278         * Scripts/VCSUtils_unittest.pl: Removed.
279           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
280
281         * Scripts/test-webkit-perl: Removed.
282           - Renamed to test-webkitperl.
283
284         * Scripts/test-webkit-scripts:
285           - Updated paths to test-webkitpy and test-webkitperl.
286
287         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
288           - Added paths to new test files.
289
290         * Scripts/webkitperl: Added.
291         * Scripts/webkitperl/VCSUtils_unittest: Added.
292         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
293         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
294         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
295
296 2010-01-04  Eric Seidel  <eric@webkit.org>
297
298         Reviewed by Adam Barth.
299
300         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
301         https://bugs.webkit.org/show_bug.cgi?id=33146
302
303         One more step towards better rollouts.
304
305         * Scripts/webkitpy/changelogs.py:
306         * Scripts/webkitpy/changelogs_unittest.py:
307         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
308
309 2010-01-04  Adam Barth  <abarth@webkit.org>
310
311         Reviewed by Eric Seidel.
312
313         Sort the step options
314         https://bugs.webkit.org/show_bug.cgi?id=33144
315
316         * Scripts/webkitpy/steps/options.py:
317
318 2010-01-04  Eric Seidel  <eric@webkit.org>
319
320         Reviewed by Adam Barth.
321
322         Need support for longer text in per-command help
323         https://bugs.webkit.org/show_bug.cgi?id=33143
324
325         Add some minimal additional help to land-diff and
326         pave the way for adding better help to all commands.
327
328         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
329         * Scripts/webkitpy/multicommandtool.py: support long_help
330         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
331
332 2010-01-04  Adam Barth  <abarth@webkit.org>
333
334         Reviewed by Eric Seidel.
335
336         Add unit test for MarkBugFixed
337         https://bugs.webkit.org/show_bug.cgi?id=33142
338
339         MarkBugFixed is way behind in command technology, but it still needs a
340         unit test, as the FIXME commands.
341
342         Also, remove mark-bug-fixed and create-bug from main help since we have
343         more modern commands to replace them.
344
345         * Scripts/webkitpy/commands/upload.py:
346         * Scripts/webkitpy/commands/upload_unittest.py:
347         * Scripts/webkitpy/mock_bugzillatool.py:
348
349 2010-01-04  Adam Barth  <abarth@webkit.org>
350
351         Reviewed by Eric Seidel.
352
353         Add missing unit test for CommitMessageForCurrentDiff
354         https://bugs.webkit.org/show_bug.cgi?id=33141
355
356         * Scripts/webkitpy/commands/upload.py:
357         * Scripts/webkitpy/commands/upload_unittest.py:
358
359 2010-01-04  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Eric Seidel.
362
363         Remove raw_input from queues in favor of user.prompt
364         https://bugs.webkit.org/show_bug.cgi?id=33140
365
366         This lets up properly mock out the user interaction instead of hacking
367         around it with the options.
368
369         * Scripts/webkitpy/commands/queues.py:
370         * Scripts/webkitpy/commands/queuestest.py:
371
372 2010-01-04  Eric Seidel  <eric@webkit.org>
373
374         Reviewed by Adam Barth.
375
376         bugzilla-tool should not require users to install mechanize
377         https://bugs.webkit.org/show_bug.cgi?id=32635
378
379         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
380
381 2010-01-04  Eric Seidel  <eric@webkit.org>
382
383         Reviewed by Adam Barth.
384
385         bugzilla-tool should not require users to install mechanize
386         https://bugs.webkit.org/show_bug.cgi?id=32635
387
388         Use the nifty "autoinstall" module from Daniel Krech:
389         http://pypi.python.org/pypi/autoinstall/0.2
390         http://code.google.com/p/pyautoinstall/
391         It's available under a WebKit-compatible BSD license.
392
393         * Scripts/webkitpy/__init__.py:
394          - bind "mechanize" to an autoinstall importer which will
395            auto-download mechanize if necessary.
396         * Scripts/webkitpy/autoinstall.py: Added.
397         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
398         * Scripts/webkitpy/statusbot.py: ditto.
399         * Scripts/webkitpy/webkit_mechanize.py: Removed.
400
401 2010-01-04  Adam Barth  <abarth@webkit.org>
402
403         Reviewed by Eric Seidel.
404
405         [bzt] Move AbstractSequencedCommand to a more general location
406         https://bugs.webkit.org/show_bug.cgi?id=33137
407
408         I do what the FIXME tell me to do.
409
410         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
411         * Scripts/webkitpy/commands/download.py:
412         * Scripts/webkitpy/commands/upload.py:
413
414 2010-01-04  Adam Barth  <abarth@webkit.org>
415
416         Reviewed by Eric Seidel.
417
418         Rename StatusBot to StatusServer
419         https://bugs.webkit.org/show_bug.cgi?id=33139
420
421         It's not a bot.  It's a server.
422
423         * Scripts/bugzilla-tool:
424         * Scripts/webkitpy/bugzilla.py:
425         * Scripts/webkitpy/commands/early_warning_system.py:
426         * Scripts/webkitpy/commands/queues.py:
427         * Scripts/webkitpy/mock_bugzillatool.py:
428         * Scripts/webkitpy/queueengine.py:
429         * Scripts/webkitpy/statusbot.py: Removed.
430
431 2010-01-04  Adam Barth  <abarth@webkit.org>
432
433         Reviewed by Eric Seidel.
434
435         [bzt] submit-pach should have a -o/--open option to open the bug after submit
436         https://bugs.webkit.org/show_bug.cgi?id=33136
437
438         Python makes this very easy.
439
440         * Scripts/webkitpy/mock_bugzillatool.py:
441         * Scripts/webkitpy/steps/options.py:
442         * Scripts/webkitpy/steps/postdiff.py:
443         * Scripts/webkitpy/user.py:
444
445 2010-01-04  Adam Barth  <abarth@webkit.org>
446
447         Reviewed by Eric Seidel.
448
449         [bzt] Move steps to a submodule
450         https://bugs.webkit.org/show_bug.cgi?id=33135
451
452         For great victory.  This will probably introduce some regressions
453         because our test coverage isn't perfect, but I've tried to be careful.
454
455         * Scripts/test-webkitpy:
456         * Scripts/webkitpy/buildsteps.py: Removed.
457         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
458         * Scripts/webkitpy/commands/download.py:
459         * Scripts/webkitpy/commands/upload.py:
460         * Scripts/webkitpy/steps/__init__.py: Added.
461         * Scripts/webkitpy/steps/abstractstep.py: Added.
462         * Scripts/webkitpy/steps/applypatch.py: Added.
463         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
464         * Scripts/webkitpy/steps/build.py: Added.
465         * Scripts/webkitpy/steps/checkstyle.py: Added.
466         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
467         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
468         * Scripts/webkitpy/steps/closebug.py: Added.
469         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
470         * Scripts/webkitpy/steps/closepatch.py: Added.
471         * Scripts/webkitpy/steps/commit.py: Added.
472         * Scripts/webkitpy/steps/completerollout.py: Added.
473         * Scripts/webkitpy/steps/confirmdiff.py: Added.
474         * Scripts/webkitpy/steps/createbug.py: Added.
475         * Scripts/webkitpy/steps/editchangelog.py: Added.
476         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
477         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
478         * Scripts/webkitpy/steps/metastep.py: Added.
479         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
480         * Scripts/webkitpy/steps/options.py: Added.
481         * Scripts/webkitpy/steps/postdiff.py: Added.
482         * Scripts/webkitpy/steps/preparechangelog.py: Added.
483         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
484         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
485         * Scripts/webkitpy/steps/revertrevision.py: Added.
486         * Scripts/webkitpy/steps/runtests.py: Added.
487         * Scripts/webkitpy/steps/steps_unittest.py: Added.
488         * Scripts/webkitpy/steps/update.py: Added.
489         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
490         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
491         * Scripts/webkitpy/stepsequence.py:
492
493 2010-01-04  Daniel Bates  <dbates@webkit.org>
494
495         Reviewed by Eric Seidel.
496
497         https://bugs.webkit.org/show_bug.cgi?id=33097
498
499         Cleans up the File menu to better conform to the File menu in Safari
500         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
501         options to close all open windows. Also, renames the Tools menu to
502         Develop.
503
504         * QtLauncher/main.cpp:
505         (MainWindow::setupUI):
506
507 2010-01-04  Daniel Bates  <dbates@webkit.org>
508
509         https://bugs.webkit.org/show_bug.cgi?id=33039
510         
511         Unreviewed fix.
512
513         * Scripts/webkitpy/credentials.py:
514         * Scripts/webkitpy/credentials_unittest.py:
515
516 2010-01-04  Daniel Bates  <dbates@webkit.org>
517
518         Reviewed by Eric Seidel.
519
520         https://bugs.webkit.org/show_bug.cgi?id=33039
521
522         [bzt] Second attempt to fix an issue where bugzilla-tool dies
523         when the keychain lookup fails to find an entry for bugs.webkit.org.
524
525         * Scripts/webkitpy/credentials.py:
526         * Scripts/webkitpy/credentials_unittest.py:
527
528 2010-01-04  Eric Seidel  <eric@webkit.org>
529
530         Reviewed by Adam Barth.
531
532         Make Rollout an AbstractSequencedCommmand
533         https://bugs.webkit.org/show_bug.cgi?id=33133
534
535         As suggested by Adam in:
536         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
537
538         * Scripts/webkitpy/commands/download.py:
539
540 2010-01-04  Eric Seidel  <eric@webkit.org>
541
542         Reviewed by Adam Barth.
543
544         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
545         https://bugs.webkit.org/show_bug.cgi?id=33131
546
547         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
548         but for now we just deploy it everywhere and don't try to fix up the few valid uses
549         of Command.
550
551         * Scripts/webkitpy/commands/download.py:
552         * Scripts/webkitpy/commands/queries.py:
553         * Scripts/webkitpy/commands/upload.py:
554         * Scripts/webkitpy/multicommandtool.py:
555
556 2010-01-03  Adam Barth  <abarth@webkit.org>
557
558         Unreviewed "build" fix.  Need to import ScriptError.
559
560         * Scripts/webkitpy/buildsteps.py:
561
562 2010-01-03  Adam Barth  <abarth@webkit.org>
563
564         Reviewed by Eric Seidel.
565
566         [bzt] Make it easier to run submit-patch when previous run cancelled
567         https://bugs.webkit.org/show_bug.cgi?id=33070
568
569         This patch renames create-review to submit-patch (as requested by
570         Maciej).
571
572         This patch makes it easier to run submit-patch after the user has
573         already cancelled a previous run of submit-patch by detecting when we
574         already have ChangeLogs and reading the bug number from them (and not
575         attempting to recreate them).  Aside from performance and the extra
576         edit step, this command should not subsume post-dif.
577
578         Also, added a --email command line argument so that the output of
579         prepare-ChangeLog makes sense when it can't find the user's email
580         address.
581
582         * Scripts/webkitpy/bugzilla.py:
583         * Scripts/webkitpy/buildsteps.py:
584         * Scripts/webkitpy/commands/upload.py:
585         * Scripts/webkitpy/commands/upload_unittest.py:
586         * Scripts/webkitpy/mock_bugzillatool.py:
587         * Scripts/webkitpy/user.py:
588
589 2010-01-03  Eric Seidel  <eric@webkit.org>
590
591         Reviewed by Adam Barth.
592
593         Rename Scripts/modules to Scripts/webkitpy
594         https://bugs.webkit.org/show_bug.cgi?id=33128
595
596         Just search-replace and svn mv commands.
597
598         * Scripts/bugzilla-tool:
599         * Scripts/check-webkit-style:
600         * Scripts/modules: Removed.
601         * Scripts/modules/BeautifulSoup.py: Removed.
602         * Scripts/modules/__init__.py: Removed.
603         * Scripts/modules/bugzilla.py: Removed.
604         * Scripts/modules/bugzilla_unittest.py: Removed.
605         * Scripts/modules/buildbot.py: Removed.
606         * Scripts/modules/buildbot_unittest.py: Removed.
607         * Scripts/modules/buildsteps.py: Removed.
608         * Scripts/modules/buildsteps_unittest.py: Removed.
609         * Scripts/modules/changelogs.py: Removed.
610         * Scripts/modules/changelogs_unittest.py: Removed.
611         * Scripts/modules/commands: Removed.
612         * Scripts/modules/commands/__init__.py: Removed.
613         * Scripts/modules/commands/commandtest.py: Removed.
614         * Scripts/modules/commands/download.py: Removed.
615         * Scripts/modules/commands/download_unittest.py: Removed.
616         * Scripts/modules/commands/early_warning_system.py: Removed.
617         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
618         * Scripts/modules/commands/queries.py: Removed.
619         * Scripts/modules/commands/queries_unittest.py: Removed.
620         * Scripts/modules/commands/queues.py: Removed.
621         * Scripts/modules/commands/queues_unittest.py: Removed.
622         * Scripts/modules/commands/queuestest.py: Removed.
623         * Scripts/modules/commands/upload.py: Removed.
624         * Scripts/modules/commands/upload_unittest.py: Removed.
625         * Scripts/modules/comments.py: Removed.
626         * Scripts/modules/committers.py: Removed.
627         * Scripts/modules/committers_unittest.py: Removed.
628         * Scripts/modules/cpp_style.py: Removed.
629         * Scripts/modules/cpp_style_unittest.py: Removed.
630         * Scripts/modules/credentials.py: Removed.
631         * Scripts/modules/credentials_unittest.py: Removed.
632         * Scripts/modules/diff_parser.py: Removed.
633         * Scripts/modules/diff_parser_unittest.py: Removed.
634         * Scripts/modules/executive.py: Removed.
635         * Scripts/modules/executive_unittest.py: Removed.
636         * Scripts/modules/grammar.py: Removed.
637         * Scripts/modules/mock.py: Removed.
638         * Scripts/modules/mock_bugzillatool.py: Removed.
639         * Scripts/modules/multicommandtool.py: Removed.
640         * Scripts/modules/multicommandtool_unittest.py: Removed.
641         * Scripts/modules/outputcapture.py: Removed.
642         * Scripts/modules/patchcollection.py: Removed.
643         * Scripts/modules/queueengine.py: Removed.
644         * Scripts/modules/queueengine_unittest.py: Removed.
645         * Scripts/modules/scm.py: Removed.
646         * Scripts/modules/scm_unittest.py: Removed.
647         * Scripts/modules/statusbot.py: Removed.
648         * Scripts/modules/stepsequence.py: Removed.
649         * Scripts/modules/style: Removed.
650         * Scripts/modules/style.py: Removed.
651         * Scripts/modules/style_unittest.py: Removed.
652         * Scripts/modules/text_style.py: Removed.
653         * Scripts/modules/text_style_unittest.py: Removed.
654         * Scripts/modules/user.py: Removed.
655         * Scripts/modules/webkit_logging.py: Removed.
656         * Scripts/modules/webkit_logging_unittest.py: Removed.
657         * Scripts/modules/webkit_mechanize.py: Removed.
658         * Scripts/modules/webkitport.py: Removed.
659         * Scripts/modules/webkitport_unittest.py: Removed.
660         * Scripts/test-webkit-python: Removed.
661         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
662         * Scripts/validate-committer-lists:
663         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
664         * Scripts/webkitpy/bugzilla.py:
665         * Scripts/webkitpy/bugzilla_unittest.py:
666         * Scripts/webkitpy/buildbot.py:
667         * Scripts/webkitpy/buildbot_unittest.py:
668         * Scripts/webkitpy/buildsteps.py:
669         * Scripts/webkitpy/buildsteps_unittest.py:
670         * Scripts/webkitpy/commands/commandtest.py:
671         * Scripts/webkitpy/commands/download.py:
672         * Scripts/webkitpy/commands/download_unittest.py:
673         * Scripts/webkitpy/commands/early_warning_system.py:
674         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
675         * Scripts/webkitpy/commands/queries.py:
676         * Scripts/webkitpy/commands/queries_unittest.py:
677         * Scripts/webkitpy/commands/queues.py:
678         * Scripts/webkitpy/commands/queues_unittest.py:
679         * Scripts/webkitpy/commands/queuestest.py:
680         * Scripts/webkitpy/commands/upload.py:
681         * Scripts/webkitpy/commands/upload_unittest.py:
682         * Scripts/webkitpy/comments.py:
683         * Scripts/webkitpy/credentials.py:
684         * Scripts/webkitpy/credentials_unittest.py:
685         * Scripts/webkitpy/executive.py:
686         * Scripts/webkitpy/executive_unittest.py:
687         * Scripts/webkitpy/mock_bugzillatool.py:
688         * Scripts/webkitpy/multicommandtool.py:
689         * Scripts/webkitpy/multicommandtool_unittest.py:
690         * Scripts/webkitpy/queueengine.py:
691         * Scripts/webkitpy/queueengine_unittest.py:
692         * Scripts/webkitpy/scm.py:
693         * Scripts/webkitpy/scm_unittest.py:
694         * Scripts/webkitpy/statusbot.py:
695         * Scripts/webkitpy/stepsequence.py:
696         * Scripts/webkitpy/webkit_logging_unittest.py:
697         * Scripts/webkitpy/webkitport_unittest.py:
698
699 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
700
701         Reviewed by Eric Seidel.
702
703         Added script to test both Perl and Python, and renamed
704         run-webkit-unittests to test-webkit-python.
705
706         https://bugs.webkit.org/show_bug.cgi?id=33045
707
708         * Scripts/VCSUtils_unittest.pl:
709           - Tweaked so it can be run from outside Scripts directory.
710
711         * Scripts/run-webkit-unittests: Removed.
712           - Renamed to test-webkit-python.
713
714         * Scripts/test-webkit-perl:
715           - Tweaked so it can be run from outside Scripts directory.
716
717         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
718
719         * Scripts/test-webkit-scripts: Added.
720           - Runs both test-webkit-perl and test-webkit-python.
721
722 2010-01-03  Adam Barth  <abarth@webkit.org>
723
724         Reviewed by Eric Seidel.
725
726         commit-queue/bugzilla-tool should build both Debug and Release
727         https://bugs.webkit.org/show_bug.cgi?id=28450
728
729         Add a --build-style command that lets the master process tell the child
730         process to build both debug and release.  Eventually we want to teach
731         the test step to understand this option too, but that's a patch for
732         another day.
733
734         * Scripts/modules/buildsteps.py:
735         * Scripts/modules/commands/queues.py:
736         * Scripts/modules/webkitport.py:
737         * Scripts/modules/webkitport_unittest.py:
738
739 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
740
741         Reviewed by Eric Seidel.
742
743         [Qt] EventSender: add support for Enter key events
744         https://bugs.webkit.org/show_bug.cgi?id=33064
745
746         Unskip 5 tests that are fixed now.
747
748         * DumpRenderTree/qt/EventSenderQt.cpp:
749         (EventSender::keyDown):
750
751 2010-01-03  Adam Barth  <abarth@webkit.org>
752
753         Reviewed by Eric Seidel.
754
755         [bzt] Add test for previous typo fix
756         https://bugs.webkit.org/show_bug.cgi?id=33083
757
758         A trivial test for a trivial fix, as requested by Eric.
759
760         * Scripts/modules/bugzilla_unittest.py:
761
762 2010-01-03  Adam Barth  <abarth@webkit.org>
763
764         Reviewed by Eric Seidel.
765
766         Implement mac-ews
767         https://bugs.webkit.org/show_bug.cgi?id=33072
768
769         The mac-ews is slightly different than the other early warning systems
770         because we can't run Mac OS X inside a VM.  For that reason, we only
771         process patches that were uploaded by committers.  This isn't as much
772         coverage as the other EWS bots, but it's better than nothing.
773
774         * Scripts/modules/commands/early_warning_system.py:
775         * Scripts/modules/commands/early_warning_system_unittest.py:
776         * Scripts/modules/commands/queues.py:
777         * Scripts/modules/commands/queuestest.py:
778         * Scripts/modules/mock_bugzillatool.py:
779
780 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
781
782         Reviewed by David Kilzer.
783
784         Refactored svn-apply and svn-unapply to use a common "patch"
785         command method, and added unit tests for this new method.
786
787         https://bugs.webkit.org/show_bug.cgi?id=33098
788
789         * Scripts/VCSUtils.pm:
790           - Added generateRunPatchCommand().
791           - Added runPatchCommand().
792           - Added exitStatus() from webkitdirs.pm to address FIXME.
793
794         * Scripts/VCSUtils_unittest.pl:
795           - Added 10 unit tests for generateRunPatchCommand().
796           - Added 4 unit tests for runPatchCommand().
797           - Added callSilently() method.
798
799         * Scripts/svn-apply:
800           - Refactored applyPatch().
801           - Removed $pathScriptWasRunFrom global variable.
802           - Addressed issue where "--force" option was getting added twice.
803
804         * Scripts/svn-unapply:
805           - Refactored applyPatch().
806           - Removed $pathScriptWasRunFrom global variable.
807           - Added support for --force option.
808           - Enhanced to return meaningful exit status.
809
810         * Scripts/webkitdirs.pm:
811           - Moved exitStatus() implementation to VCSUtils.pm.
812
813 2009-12-31  Adam Barth  <abarth@webkit.org>
814
815         Reviewed by Eric Seidel.
816
817         [bzt] Implement build-and-test
818         https://bugs.webkit.org/show_bug.cgi?id=33073
819
820         Some of the early warning system bots want to use build-and-test so
821         they can cover LayoutTests in addition to just compilation.
822
823         * Scripts/modules/commands/download.py:
824         * Scripts/modules/commands/download_unittest.py:
825
826 2009-12-31  Adam Barth  <abarth@webkit.org>
827
828         Reviewed by Eric Seidel.
829
830         Show mac-ews status on QueueStatusServer
831         https://bugs.webkit.org/show_bug.cgi?id=33076
832
833         Also make error status purple.
834
835         * QueueStatusServer/model/attachment.py:
836         * QueueStatusServer/model/queues.py:
837         * QueueStatusServer/templates/dashboard.html:
838         * QueueStatusServer/templates/statusbubble.html:
839
840 2009-12-31  Adam Barth  <abarth@webkit.org>
841
842         Unreviewed.
843
844         [bzt] REGRESSION: Bugzila is a typo
845         https://bugs.webkit.org/show_bug.cgi?id=33074
846
847         Eric should test his code before landing!  :)
848
849         * Scripts/modules/bugzilla.py:
850
851 2009-12-31  Adam Barth  <abarth@webkit.org>
852
853         Unreviewed.  Fix the unit tests!
854
855         * Scripts/run-webkit-unittests:
856
857 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
858
859         Reviewed by Kevin Ollivier.
860
861         [wx] Alter a couple of default settings in the test app.
862         
863         https://bugs.webkit.org/show_bug.cgi?id=32956
864
865         * wx/browser/browser.cpp:
866         (MyApp::OnInit):
867
868 2009-12-30  Eric Seidel  <eric@webkit.org>
869
870         Reviewed by Adam Barth.
871
872         logging.py should be renamed to webkit_logging.py and eventually die
873         https://bugs.webkit.org/show_bug.cgi?id=33058
874
875         Change all imports of "logging" to webkit_logging,
876         except the ones which came from Google's cpp_lint.py and diff_parser.py
877         which clearly are assuming python's logging.py.
878
879         * Scripts/modules/bugzilla.py:
880         * Scripts/modules/buildbot.py:
881         * Scripts/modules/buildsteps.py:
882         * Scripts/modules/commands/download.py:
883         * Scripts/modules/commands/queries.py:
884         * Scripts/modules/commands/queues.py:
885         * Scripts/modules/commands/upload.py:
886         * Scripts/modules/credentials.py:
887         * Scripts/modules/executive.py:
888         * Scripts/modules/multicommandtool.py:
889         * Scripts/modules/queueengine.py:
890         * Scripts/modules/scm.py:
891         * Scripts/modules/statusbot.py:
892         * Scripts/modules/stepsequence.py:
893         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
894         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
895
896 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
897
898         Reviewed by Simon Hausmann.
899
900         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
901         https://bugs.webkit.org/show_bug.cgi?id=33051
902
903         Moreover, its primary function is to normalize the path in regard of platform
904         specific directory separators. Therefore, it can simply make use of the
905         QDir::toNativeSeparators function.
906
907         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
908         (LayoutTestController::pathToLocalResource):
909
910 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
911
912         Fix executable bits for r52646
913
914         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
915         * Scripts/test-webkit-perl: Ditto.
916
917 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
918
919         Reviewed by David Kilzer.
920
921         Fixed a bug in fixChangeLogPatch, made it work correctly in
922         more circumstances, and added unit tests.
923
924         https://bugs.webkit.org/show_bug.cgi?id=32919
925
926         * Scripts/VCSUtils.pm:
927           Rewrote fixChangeLogPatch.
928           
929         * Scripts/VCSUtils_unittest.pl: Added.
930           Added 7 unit tests for fixChangeLogPatch.
931
932         * Scripts/test-webkit-perl: Added.
933           Added test harness for unit tests of Perl code.
934
935 2009-12-29  Eric Seidel  <eric@webkit.org>
936
937         Reviewed by Adam Barth.
938
939         Split out BugzillaQueries class from Bugzilla
940         https://bugs.webkit.org/show_bug.cgi?id=33042
941
942         * Scripts/modules/bugzilla.py:
943          - Split out BugzillaQueries from Bugzilla.
944          - Try to isolate self.bugzilla usage into helper functions whenever possible.
945          - Add a bunch of FIXMEs.
946          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
947         * Scripts/modules/bugzilla_unittest.py:
948          - Create a new BugzillaQueriesTest testcase and move logic there.
949         * Scripts/modules/buildsteps_unittest.py:
950          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
951         * Scripts/modules/commands/queries.py:
952          - Update to use bugzilla.queries
953         * Scripts/modules/commands/queues.py:
954          - Ditto.
955         * Scripts/modules/commands/upload.py:
956          - Ditto.
957         * Scripts/modules/mock_bugzillatool.py:
958          - Add a MockBugzillaQueries.
959          - Make patches and bugs global privates.
960          - Let _id_to_object_dictionary take a variable argument list instead of an array.
961
962 2009-12-29  Daniel Bates  <dbates@webkit.org>
963
964         Reviewed by Eric Seidel.
965
966         https://bugs.webkit.org/show_bug.cgi?id=33041
967
968         Speed up the test method test_read_credentials_with_SVN by not actually
969         creating an SVN repository to test against (by default). Instead, it is
970         sufficient to create a temporary directory that does not contain a Git
971         repository.
972
973         Also, renamed method test_read_credentials_with_SVN to
974         test_read_credentials_without_git_repo, to better reflect what it is
975         testing.
976
977         * Scripts/modules/credentials_unittest.py:
978
979 2009-12-29  Daniel Bates  <dbates@webkit.org>
980
981         Reviewed by Adam Barth.
982
983         https://bugs.webkit.org/show_bug.cgi?id=33039
984
985         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
986         fails to find an entry for bugs.webkit.org.
987         
988         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
989         framework (via /usr/sbin/security) for an internet-password entry for
990         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
991         However, if no such entry exists then bugzilla-tool dies with an error.
992
993         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
994         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
995         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
996
997 2009-12-29  Eric Seidel  <eric@webkit.org>
998
999         Rubber-stamped by Adam Barth.
1000
1001         Remove unused BugzillaException.
1002
1003         * Scripts/modules/bugzilla.py:
1004
1005 2009-12-29  Eric Seidel  <eric@webkit.org>
1006
1007         Reviewed by Adam Barth.
1008
1009         Need a script to assign bugs with r+ patches to committers for landing
1010         https://bugs.webkit.org/show_bug.cgi?id=33009
1011
1012         This is just one more small tool to help in the fight against our
1013         ever-growing list of to-be-committed patches.
1014
1015         * Scripts/modules/bugzilla.py:
1016          - Rename assign_to_email to assigned_to_email (typo).
1017          - Add assigned_to_email() method on Bug.
1018          - Add reassign_bug method.
1019          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
1020         * Scripts/modules/bugzilla_unittest.py:
1021          - Update test after assigned_to_email rename.
1022         * Scripts/modules/commands/commandtest.py:
1023          - Call bind_to_tool to that self.tool works in Command testing.
1024         * Scripts/modules/commands/download.py:
1025          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
1026         * Scripts/modules/commands/queries_unittest.py:
1027          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
1028          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
1029         * Scripts/modules/commands/upload.py:
1030          - Add new assign-to-committer command.
1031         * Scripts/modules/commands/upload_unittest.py:
1032          - Add basic assign-to-committer test.
1033         * Scripts/modules/committers.py:
1034          - Add bugzilla_email() accessor.
1035         * Scripts/modules/committers_unittest.py:
1036          - Test our assumption that bugzilla_email is the first email.
1037         * Scripts/modules/mock_bugzillatool.py:
1038          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
1039          - Remove unused fetch_attachments_from_bug.
1040          - Add fetch_bug support and a bug_cache.
1041         * Scripts/modules/multicommandtool.py:
1042          - Move AbstractDeclarativeCommmand here from download.py
1043
1044 2009-12-29  Adam Barth  <abarth@webkit.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
1049         https://bugs.webkit.org/show_bug.cgi?id=33038
1050
1051         Simple fix with test.
1052
1053         * Scripts/modules/buildsteps.py:
1054         * Scripts/modules/buildsteps_unittest.py:
1055
1056 2009-12-29  Adam Barth  <abarth@webkit.org>
1057
1058         Reviewed by Eric Seidel.
1059
1060         [bzt] post-diff requires reading to the end
1061         https://bugs.webkit.org/show_bug.cgi?id=33036
1062
1063         Catch the IOError caused by not reading to the end of the diff.  We
1064         don't have a good way to test this currently.
1065
1066         * Scripts/modules/user.py:
1067
1068 2009-12-29  Chang Shu  <Chang.Shu@nokia.com>
1069
1070         Reviewed by Adam Barth.
1071
1072         [Qt] Move logic that handles Qt headers before primary headers
1073         so that Qt headers won't be treated as primary headers by mistake.
1074         https://bugs.webkit.org/show_bug.cgi?id=32991
1075
1076         * Scripts/modules/cpp_style.py:
1077         * Scripts/modules/cpp_style_unittest.py:
1078
1079 2009-12-29  Eric Seidel  <eric@webkit.org>
1080
1081         Reviewed by Adam Barth.
1082
1083         Add the start of a Bug object for bugzilla.py
1084         https://bugs.webkit.org/show_bug.cgi?id=32995
1085
1086         This allowed us to get rid of some duplicated "is_obsolete" checks.
1087
1088         * Scripts/modules/bugzilla.py:
1089          - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
1090          - Add _fetch_bug_page for possible future mocking.
1091            (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
1092          - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
1093          - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
1094          - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
1095            using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
1096         * Scripts/modules/bugzilla_unittest.py:
1097          - Remove an unneeded unicode string marker.
1098         * Scripts/modules/buildsteps.py:
1099          - define __all__ to include just the BuildSteps
1100         * Scripts/modules/commands/download.py:
1101          - import * now that we have an __all__ defined.
1102         * Scripts/modules/commands/upload.py:
1103          - Use fetch_bug_dictionary instead of fetch_bug.
1104
1105 2009-12-29  Daniel Bates  <dbates@webkit.org>
1106
1107         Reviewed by Ariya Hidayat.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=32925
1110
1111         Adds an Open File dialog to make it convenient to open a file
1112         to view in the browser.
1113
1114         Currently a person must either specify the path to a file as a
1115         command-line argument or type a file URL. Instead, we should
1116         have a file dialog to allow a person to open a file without
1117         memorizing its path.
1118
1119         * QtLauncher/main.cpp:
1120         (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
1121         to urlEdit->setText(qurl.toString()). 
1122         (MainWindow::openFile): Added.
1123         (MainWindow::changeLocation): Moved code to load URL into method
1124         MainWindow::loadURL.
1125         (MainWindow::loadURL): Added.
1126         (MainWindow::setupUI): Added menu item Open File.
1127
1128 2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1129
1130         Reviewed by Holger Freyther.
1131
1132         [GTK] fails fast/harness/use-page-cache.html
1133         https://bugs.webkit.org/show_bug.cgi?id=33013
1134
1135         Make sure settings are forwarded to child WebViews.
1136
1137         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1138         (createWebView):
1139
1140 2009-12-29  Daniel Bates  <dbates@webkit.org>
1141
1142         Reviewed by Eric Seidel.
1143
1144         https://bugs.webkit.org/show_bug.cgi?id=32778
1145
1146         Changes $diffPercentage to be a number to resolve Perl
1147         warning about comparing a string to a number.
1148
1149         * Scripts/run-webkit-tests:
1150
1151 2009-12-29  Jakub Wieczorek  <faw217@gmail.com>
1152
1153         Reviewed by Eric Seidel.
1154
1155         [Qt] DRT: Frame loader callbacks differ from the Mac port
1156         https://bugs.webkit.org/show_bug.cgi?id=32989
1157
1158         Remove messages from the callbacks that should not dump them to match
1159         the expected results for the http/loading tests.
1160
1161         Unskip some http/loading tests which succeed now.
1162
1163         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1164         (WebCore::DumpRenderTree::dump):
1165
1166 2009-12-29  Robert Hogan  <robert@roberthogan.net>
1167
1168         Reviewed by Eric Seidel.
1169
1170         [Qt] fix fast/dom/Window/window-onFocus.html
1171         
1172         Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
1173         window.onblur was getting dispatched twice from QtWebKit.
1174         
1175         https://bugs.webkit.org/show_bug.cgi?id=32990
1176
1177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1178         (WebCore::DumpRenderTree::DumpRenderTree):
1179         (WebCore::DumpRenderTree::switchFocus):
1180         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1182         (LayoutTestController::setWindowIsKey):
1183         (LayoutTestController::setMainFrameIsFirstResponder):
1184         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1185
1186 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
1187
1188         Reviewed by Maciej Stachowiak.
1189
1190         Extended EventSender.keyDown method to take another (3rd) argument
1191         for indicating the keyLocation to make numeric pad key events testable.
1192         Expected values for the argument is one of the KeyLocationCode
1193         specified in DOM Level 3
1194         (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
1195         https://bugs.webkit.org/show_bug.cgi?id=28247
1196
1197         Test: fast/events/keydown-numpad-keys.html
1198
1199         * DumpRenderTree/mac/EventSendingController.mm:
1200         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1201         (+[EventSendingController webScriptNameForSelector:]):
1202         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1203
1204 2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
1205
1206         Unreviewed, update my email address.
1207
1208         * Scripts/modules/committers.py:
1209
1210 2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1211
1212         Reviewed by Adam Barth.
1213
1214         [Qt] Fix build break for Qt 4.4
1215         https://bugs.webkit.org/show_bug.cgi?id=30327
1216
1217         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
1218         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
1219         * QtLauncher/main.cpp:
1220         (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
1221         introduced in Qt version 4.5
1222
1223 2009-12-28  Adam Barth  <abarth@webkit.org>
1224
1225         Reviewed by Eric Seidel.
1226
1227         [bzt] Add an edit-changelog command
1228         https://bugs.webkit.org/show_bug.cgi?id=32986
1229
1230         This command makes it easier to edit ChangeLogs.  It's similar to
1231         prepare-ChangeLog -o, except it works with already existing ChangeLogs.
1232
1233         * Scripts/modules/commands/upload.py:
1234         * Scripts/modules/commands/upload_unittest.py:
1235
1236 2009-12-28  Adam Barth  <abarth@webkit.org>
1237
1238         Reviewed by Eric Seidel.
1239
1240         [bzt] Create an ASAD command for uploading a patch
1241         https://bugs.webkit.org/show_bug.cgi?id=32979
1242
1243         The create-review command goes through the whole process of preparing a
1244         code review, including creating a bug, editing the ChangeLogs, and
1245         uploading the patch.  It is indeed the All Sing, All Dance upload
1246         command.
1247
1248         * Scripts/modules/buildsteps.py:
1249         * Scripts/modules/commands/upload.py:
1250         * Scripts/modules/commands/upload_unittest.py:
1251         * Scripts/modules/mock_bugzillatool.py:
1252         * Scripts/modules/user.py:
1253
1254 2009-12-28  Adam Barth  <abarth@webkit.org>
1255
1256         Unreviewed "build" fix (with test!).
1257
1258         * Scripts/modules/bugzilla.py:
1259         * Scripts/modules/bugzilla_unittest.py:
1260
1261 2009-12-27  Eric Seidel  <eric@webkit.org>
1262
1263         Reviewed by Adam Barth.
1264
1265         Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
1266         https://bugs.webkit.org/show_bug.cgi?id=32980
1267
1268         * Scripts/modules/bugzilla.py:
1269          - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
1270          - Replace fetch_title_from_bug with a new fetch_bug call instead.
1271          - Use list comprehensions where possible to reduce code duplication.
1272         * Scripts/modules/bugzilla_unittest.py:
1273          - Add a minimal bug parsing test.
1274          - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
1275         * Scripts/modules/commands/upload.py:
1276          - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug
1277
1278 2009-12-27  Adam Barth  <abarth@webkit.org>
1279
1280         Reviewed by Eric Seidel.
1281
1282         Status bubble shouldn't be transparent for bots that haven't run yet
1283         https://bugs.webkit.org/show_bug.cgi?id=32977
1284
1285         * QueueStatusServer/templates/statusbubble.html:
1286
1287 2009-12-27  Adam Barth  <abarth@webkit.org>
1288
1289         Reviewed by Eric Seidel.
1290
1291         [QueueStatusServer] Run gc cron job less often
1292         https://bugs.webkit.org/show_bug.cgi?id=32958
1293
1294         Now that we've cleaned out the backlog of idle messages, we don't need
1295         to run the gc job every half hour.  We could also stop logging the idle
1296         messages, but this seems easier for the time being.
1297
1298         * QueueStatusServer/cron.yaml:
1299
1300 2009-12-27  Daniel Bates  <dbates@webkit.org>
1301
1302         Reviewed by Adam Barth.
1303
1304         https://bugs.webkit.org/show_bug.cgi?id=32896
1305
1306         Fixes an issue where bugzilla-tool tries to read the username and password from
1307         Git regardless of whether Git is installed. In particular, if Git is not
1308         installed then bugzilla-tool dies (with a trace) when it attempts to query Git
1309         for the authentication credentials to log into bugs.webkit.org.
1310
1311         Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
1312         the specified error handler. For instance, the specified error handler will now
1313         be called when the command does not exist (i.e. OSError errno 2).
1314
1315         * Scripts/modules/credentials.py: Added check for Git.
1316         * Scripts/modules/credentials_unittest.py: Added test method
1317         test_read_credentials_with_SVN.
1318         * Scripts/modules/executive.py: Modified method run_command to catch
1319         OSError exceptions (i.e [Errno 2] No such file or directory) and call
1320         the specified error handler.
1321         * Scripts/modules/executive_unittest.py: Added.
1322         * Scripts/run-webkit-unittests: Added import executive_unittest.py.
1323
1324 2009-12-27  Daniel Bates  <dbates@webkit.org>
1325
1326         Unreviewed. Added missing file style_unittest.py that wasn't committed
1327         in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
1328         the patch for bug #32592.
1329
1330         * Scripts/modules/style_unittest.py: Added.
1331
1332 2009-12-27  Daniel Bates  <dbates@webkit.org>
1333
1334         Reviewed by Eric Seidel.
1335
1336         https://bugs.webkit.org/show_bug.cgi?id=32964
1337
1338         [bzt] Updated the unit test based on the change made in bug #32951.
1339
1340         The change made in bug #32951 added the command-line argument:
1341         --makeargs="-j8" to the build-webkit command. However, the associated
1342         unit test was not updated.
1343
1344         * Scripts/modules/webkitport_unittest.py:
1345
1346 2009-12-27  Yael Aharon  <yael.aharon@nokia.com>
1347
1348         Reviewed by Darin Adler.
1349
1350         check-webkit-style should not mark moc files inclusion as errors
1351         https://bugs.webkit.org/show_bug.cgi?id=32669
1352
1353         Add a new header type for moc files, and skip them when checking the order of header files.
1354
1355         * Scripts/modules/cpp_style.py:
1356
1357 2009-12-26  Adam Barth  <abarth@webkit.org>
1358
1359         Reviewed by Eric Seidel.
1360
1361         [bzt] Make the qt build go fast
1362         https://bugs.webkit.org/show_bug.cgi?id=32951
1363
1364         Make use of multiple cores, if available.
1365
1366         * Scripts/modules/webkitport.py:
1367
1368 2009-12-25  Daniel Bates  <dbates@rim.com>
1369
1370         Reviewed by Eric Seidel.
1371
1372         https://bugs.webkit.org/show_bug.cgi?id=32682
1373
1374         Fixes an issue where checkFrameworks always dies with an error under Windows
1375         since the clause "unless (-x $path)" is always satisfied because files under
1376         Windows do not have an explict executable bit.
1377
1378         * Scripts/webkitdirs.pm:
1379
1380 2009-12-23  Eric Seidel  <eric@webkit.org>
1381
1382         Reviewed by Adam Barth.
1383
1384         bugzilla-tool should accept global options anywhere
1385         https://bugs.webkit.org/show_bug.cgi?id=26912
1386
1387         * Scripts/bugzilla-tool:
1388          - Use the new global_options class property.
1389          - Add a handle_global_options callback to avoid needing callbacks for each global option.
1390         * Scripts/modules/multicommandtool.py:
1391          - Make the code use one combined option parser.
1392            This allows us to accept global options anywhere and
1393            individual command options before commands.
1394          - Add a handle_global_options callback to avoid needing callbacks for each global option.
1395          - Make the Command hold the option parser, but allow the tool to override it.
1396          - The default option parser is used for help printing and when Commands are run stand alone,
1397            but are otherwise not used.
1398          - Add Command.main to codify the idea that Commands should support being run stand-alone.
1399          - Change _split_args to _split_command_name_from_args now that args are unified.
1400         * Scripts/modules/multicommandtool_unittest.py:
1401          - Test that "tool" and "tool help" show the same help.
1402          - Test that args are accepted before commands
1403
1404 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
1405
1406         Reviewed by David Levin.
1407
1408         Moved some sections of code in preparation to refactor
1409         check-webkit-style's argument parser to avoid setting
1410         global variables.
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=32592
1413
1414         * Scripts/check-webkit-style:
1415           - Moved _USAGE string to style.py.
1416           - Addressed FIXME by eliminating dependencies on cpp_style.py.
1417
1418         * Scripts/modules/cpp_style.py:
1419           - Moved default arguments and style categories to style.py.
1420           - Moved exit_with_usage(), exit_with_categories(), and
1421             parse_arguments() to style.py.
1422           - Removed references in _CppStyleState to the global
1423             variables now in style.py.
1424
1425         * Scripts/modules/cpp_style_unittest.py:
1426           - Moved parse_arguments() unit tests to style_unittest.py.
1427
1428         * Scripts/modules/style.py:
1429           - Added _USAGE string from check-webkit-style.
1430           - Added default arguments and style categories from cpp_style.py.
1431           - Added exit_with_usage(), exit_with_categories(), and
1432             parse_arguments() from cpp_sstyle.py.
1433
1434         * Scripts/modules/style_unittest.py: Added.
1435           - Added parse_arguments() unit tests from cpp_style_unittest.py.
1436
1437         * Scripts/run-webkit-unittests:
1438           - Added unit tests from style_unittest.py.
1439
1440 2009-12-23  Eric Seidel  <eric@webkit.org>
1441
1442         Reviewed by Adam Barth.
1443
1444         commit-queue should mention bug 30084 when rejecting patches until it can be fixed
1445         https://bugs.webkit.org/show_bug.cgi?id=32911
1446
1447         * Scripts/modules/bugzilla.py: Make the message even more fancy.
1448         * Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
1449
1450 2009-12-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1451
1452         Not reviewed, adding myself to the reviewers list.
1453
1454         * Scripts/modules/committers.py:
1455
1456 2009-12-23  Adam Barth  <abarth@webkit.org>
1457
1458         Reviewed by Eric Seidel.
1459
1460         [bzt] Create a prepare-diff command that creates a bug and a ChangeLog
1461         https://bugs.webkit.org/show_bug.cgi?id=32895
1462
1463         The workflow Maciej and I discussed is as follows:
1464
1465         1) Write code.
1466         2) bugzilla-tool prepare-diff
1467         3) Edit ChangeLogs
1468         4) bugzilla-tool post-diff
1469
1470         We might want to experimenting with combining 2-4 into a single
1471         command, but that might be stressful to edit the ChangeLogs modally.
1472
1473         Removed submit-patch since it has the modal ChangeLog editing but none
1474         oof the bug creating fun.
1475
1476         * Scripts/modules/bugzilla.py:
1477         * Scripts/modules/buildsteps.py:
1478         * Scripts/modules/commands/upload.py:
1479         * Scripts/modules/commands/upload_unittest.py:
1480
1481 2009-12-23  Gabor Loki  <loki@webkit.org>
1482
1483         Unreviewed; added myself to the committers list.
1484
1485         * Scripts/modules/committers.py:
1486
1487 2009-12-22  Adam Barth  <abarth@webkit.org>
1488
1489         Reviewed by Maciej Stachowiak.
1490
1491         [bzt] Don't call create-patch twice during post-diff
1492         https://bugs.webkit.org/show_bug.cgi?id=32893
1493
1494         If we call create-patch to get the bug number, cache the diff in the
1495         state so we don't need to call it again.
1496
1497         * Scripts/modules/buildsteps.py:
1498         * Scripts/modules/commands/upload.py:
1499
1500 2009-12-22  Daniel Bates  <dbates@rim.com>
1501
1502         Reviewed by Eric Seidel.
1503
1504         https://bugs.webkit.org/show_bug.cgi?id=32680
1505
1506         Fixes an issue in builtDylibPathForName so that it returns the correct
1507         path to the built QtWebKit library on the Qt Windows port. Currently,
1508         it returns the path to the file named QtWebKit.dll but this file does
1509         not exist on the Qt Windows build. Instead, the file is named
1510         QtWebKit4.dll.
1511
1512         * Scripts/webkitdirs.pm:
1513
1514 2009-12-22  Marc-Antoine Ruel  <maruel@chromium.org>
1515
1516         Reviewed by Adam Roben.
1517
1518         Remove the only dependency on perl-libwin32 in cygwin
1519
1520         * Scripts/num-cpus:
1521
1522 2009-12-22  Darin Adler  <darin@apple.com>
1523
1524         * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
1525         generated ".pyc" files.
1526
1527 2009-12-22  Darin Adler  <darin@apple.com>
1528
1529         Reviewed by Mark Rowe.
1530
1531         Turn off datagrid by default, at least for all platforms Apple ships.
1532         The datagrid implementation isn't ready for general web use yet.
1533
1534         * Scripts/build-webkit: Turn off datagrid by default.
1535
1536 2009-12-22  Eric Seidel  <eric@webkit.org>
1537
1538         Reviewed by Darin Adler.
1539
1540         validate-committer-lists fails when run from an SVN checkout
1541         https://bugs.webkit.org/show_bug.cgi?id=31974
1542
1543         * Scripts/validate-committer-lists:
1544          - Make it print a warning message instead of throwing
1545            an exception when running from an SVN checkout.
1546
1547 2009-12-22  Philippe Normand  <pnormand@igalia.com>
1548
1549         Reviewed by Adam Barth.
1550
1551         check-webkit-style should not warn about NULL usage in g_object_{get,set}
1552         https://bugs.webkit.org/show_bug.cgi?id=32858
1553
1554         * Scripts/modules/cpp_style.py:
1555         * Scripts/modules/cpp_style_unittest.py:
1556
1557 2009-12-22  Simon Hausmann  <simon.hausmann@nokia.com>
1558
1559         Rubber-stamped by Holger Freyther.
1560
1561         Moved QtLauncher from WebKit/qt.
1562
1563         * QtLauncher: Copied from WebKit/qt/QtLauncher.
1564         * QtLauncher/QtLauncher.pro:
1565
1566 2009-12-21  Adam Barth  <abarth@webkit.org>
1567
1568         Reviewed by Eric Seidel.
1569
1570         [bzt] Automate the process of calling prepare-ChangeLog
1571         https://bugs.webkit.org/show_bug.cgi?id=32816
1572
1573         This patch automates the process of creating a bug and patch and
1574         uploading it to bugzilla.  The first cut just calls
1575         prepare-ChangeLog.
1576
1577         This patch required some refactoring of upload.py to the Step
1578         model, but that's worth doing anyway.
1579
1580         * Scripts/bugzilla-tool:
1581         * Scripts/modules/buildsteps.py:
1582         * Scripts/modules/commands/download.py:
1583         * Scripts/modules/commands/upload.py:
1584         * Scripts/modules/commands/upload_unittest.py:
1585         * Scripts/modules/mock_bugzillatool.py:
1586
1587 2009-12-21  Darin Adler  <darin@apple.com>
1588
1589         * Scripts/do-webcore-rename: Did a rename, so checking in the
1590         version of the script I used.
1591
1592 2009-12-21  Adam Barth  <abarth@webkit.org>
1593
1594         Reviewed by Eric Seidel.
1595
1596         Update status-bubble to show all the queues
1597         https://bugs.webkit.org/show_bug.cgi?id=32838
1598
1599         Also, move statusbubble over to use memcache.
1600
1601         * QueueStatusServer/handlers/statusbubble.py:
1602         * QueueStatusServer/templates/statusbubble.html:
1603
1604 2009-12-21  Adam Barth  <abarth@webkit.org>
1605
1606         Reviewed by Eric Seidel.
1607
1608         Delete the boring "Empty queue" status messages in QueueStatusServer
1609         https://bugs.webkit.org/show_bug.cgi?id=32818
1610
1611         * QueueStatusServer/app.yaml:
1612         * QueueStatusServer/cron.yaml:
1613         * QueueStatusServer/handlers/gc.py:
1614         * QueueStatusServer/main.py:
1615
1616 2009-12-21  Adam Barth  <abarth@webkit.org>
1617
1618         Reviewed by Eric Seidel.
1619
1620         Exception on queue status server
1621         https://bugs.webkit.org/show_bug.cgi?id=32812
1622
1623         Turns out we need to pass the id to the filter.
1624
1625         * QueueStatusServer/filters/webkit_extras.py:
1626         * QueueStatusServer/templates/patch.html:
1627         * QueueStatusServer/templates/recentstatus.html:
1628
1629 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
1630
1631         Reviewed by Eric Seidel.
1632
1633         Created "style" folder for code supporting check-webkit-style.
1634
1635         * Scripts/modules/style: Added.
1636
1637 2009-12-20  Adam Barth  <abarth@webkit.org>
1638
1639         Reviewed by Eric Seidel.
1640
1641         REGRESSION: error when running commit-queue
1642         https://bugs.webkit.org/show_bug.cgi?id=32806
1643
1644         Fix typo and add test!
1645
1646         * Scripts/modules/bugzilla.py:
1647         * Scripts/modules/bugzilla_unittest.py:
1648
1649 2009-12-20  Adam Barth  <abarth@webkit.org>
1650
1651         [bzt] Optimize status updates for new dashboard
1652         https://bugs.webkit.org/show_bug.cgi?id=32797
1653
1654         This patch makes the queues slightly more chatty with the web service.
1655         Also, this patch introduces some testing for the queues!
1656
1657         * Scripts/modules/commands/early_warning_system.py:
1658         * Scripts/modules/commands/early_warning_system_unittest.py: Added.
1659         * Scripts/modules/commands/queues.py:
1660         * Scripts/modules/commands/queues_unittest.py:
1661         * Scripts/modules/commands/queuestest.py: Added.
1662         * Scripts/modules/mock_bugzillatool.py:
1663         * Scripts/modules/patchcollection.py:
1664         * Scripts/modules/queueengine.py:
1665         * Scripts/run-webkit-unittests:
1666
1667 2009-12-20  Adam Barth  <abarth@webkit.org>
1668
1669         Reviewed by Eric Seidel.
1670
1671         Prepare QueueStatusServer for new status messages
1672         https://bugs.webkit.org/show_bug.cgi?id=32805
1673
1674         * QueueStatusServer/handlers/recentstatus.py:
1675         * QueueStatusServer/index.html: Removed.
1676         * QueueStatusServer/model/attachment.py:
1677         * QueueStatusServer/model/queues.py: Added.
1678         * QueueStatusServer/templates/recentstatus.html: Added.
1679
1680 2009-12-20  Shinichiro Hamaji  <hamaji@chromium.org>
1681
1682         Reviewed by Adam Barth.
1683
1684         [check-webkit-style] static_cast is not misnamed!
1685         https://bugs.webkit.org/show_bug.cgi?id=32796
1686
1687         * Scripts/modules/cpp_style.py:
1688         * Scripts/modules/cpp_style_unittest.py:
1689
1690 2009-12-20  Alejandro G. Castro  <alex@igalia.com>
1691
1692         Reviewed by Gustavo Noronha Silva.
1693
1694         [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
1695         https://bugs.webkit.org/show_bug.cgi?id=32788
1696
1697         Do not increase the click count if we are using a different button.
1698
1699         * DumpRenderTree/gtk/EventSender.cpp:
1700
1701 2009-12-20  Adam Barth  <abarth@webkit.org>
1702
1703         Reviewed by Eric Seidel.
1704
1705         [QueueStatusServer] Add a per-patch details page
1706         https://bugs.webkit.org/show_bug.cgi?id=32784
1707
1708         This is a first cut at a per-patch details page.  I'm sure we'll have
1709         to iterate.
1710
1711         * QueueStatusServer/filters/webkit_extras.py:
1712         * QueueStatusServer/handlers/patch.py: Added.
1713         * QueueStatusServer/index.yaml:
1714         * QueueStatusServer/main.py:
1715         * QueueStatusServer/model/attachment.py:
1716         * QueueStatusServer/stylesheets/dashboard.css:
1717         * QueueStatusServer/templates/dashboard.html:
1718         * QueueStatusServer/templates/patch.html: Added.
1719
1720 2009-12-20  Adam Barth  <abarth@webkit.org>
1721
1722         Reviewed by Eric Seidel.
1723
1724         Use memcache to make dashboard to fast
1725         https://bugs.webkit.org/show_bug.cgi?id=32780
1726
1727         * QueueStatusServer/app.yaml:
1728         * QueueStatusServer/handlers/dashboard.py:
1729         * QueueStatusServer/handlers/updatestatus.py:
1730         * QueueStatusServer/model/attachment.py: Added.
1731
1732 2009-12-19  Brent Fulgham  <bfulgham@webkit.org>
1733
1734         Reviewed by Adam Roben.
1735
1736         Provide an example implementation for printing under Windows.
1737         http://bugs.webkit.org/show_bug.cgi?id=32504.`
1738
1739         * WinLauncher/PrintWebUIDelegate.cpp: Added.
1740         (PrintWebUIDelegate::QueryInterface):
1741         (PrintWebUIDelegate::AddRef):
1742         (PrintWebUIDelegate::Release):
1743         (PrintWebUIDelegate::webViewPrintingMarginRect):
1744         * WinLauncher/PrintWebUIDelegate.h: Added.
1745         (PrintWebUIDelegate::PrintWebUIDelegate):
1746         (PrintWebUIDelegate::createWebViewWithRequest):
1747         (PrintWebUIDelegate::webViewShow):
1748         (PrintWebUIDelegate::webViewClose):
1749         (PrintWebUIDelegate::webViewFocus):
1750         (PrintWebUIDelegate::webViewUnfocus):
1751         (PrintWebUIDelegate::webViewFirstResponder):
1752         (PrintWebUIDelegate::makeFirstResponder):
1753         (PrintWebUIDelegate::setStatusText):
1754         (PrintWebUIDelegate::webViewStatusText):
1755         (PrintWebUIDelegate::webViewAreToolbarsVisible):
1756         (PrintWebUIDelegate::setToolbarsVisible):
1757         (PrintWebUIDelegate::webViewIsStatusBarVisible):
1758         (PrintWebUIDelegate::setStatusBarVisible):
1759         (PrintWebUIDelegate::webViewIsResizable):
1760         (PrintWebUIDelegate::setResizable):
1761         (PrintWebUIDelegate::setFrame):
1762         (PrintWebUIDelegate::webViewFrame):
1763         (PrintWebUIDelegate::setContentRect):
1764         (PrintWebUIDelegate::webViewContentRect):
1765         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
1766         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
1767         (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
1768         (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1769         (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
1770         (PrintWebUIDelegate::mouseDidMoveOverElement):
1771         (PrintWebUIDelegate::contextMenuItemsForElement):
1772         (PrintWebUIDelegate::validateUserInterfaceItem):
1773         (PrintWebUIDelegate::shouldPerformAction):
1774         (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
1775         (PrintWebUIDelegate::willPerformDragDestinationAction):
1776         (PrintWebUIDelegate::dragSourceActionMaskForPoint):
1777         (PrintWebUIDelegate::willPerformDragSourceAction):
1778         (PrintWebUIDelegate::contextMenuItemSelected):
1779         (PrintWebUIDelegate::hasCustomMenuImplementation):
1780         (PrintWebUIDelegate::trackCustomPopupMenu):
1781         (PrintWebUIDelegate::measureCustomMenuItem):
1782         (PrintWebUIDelegate::drawCustomMenuItem):
1783         (PrintWebUIDelegate::addCustomMenuDrawingData):
1784         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
1785         (PrintWebUIDelegate::canTakeFocus):
1786         (PrintWebUIDelegate::takeFocus):
1787         (PrintWebUIDelegate::registerUndoWithTarget):
1788         (PrintWebUIDelegate::removeAllActionsWithTarget):
1789         (PrintWebUIDelegate::setActionTitle):
1790         (PrintWebUIDelegate::undo):
1791         (PrintWebUIDelegate::redo):
1792         (PrintWebUIDelegate::canUndo):
1793         (PrintWebUIDelegate::canRedo):
1794         (PrintWebUIDelegate::printFrame):
1795         (PrintWebUIDelegate::ftpDirectoryTemplatePath):
1796         (PrintWebUIDelegate::webViewHeaderHeight):
1797         (PrintWebUIDelegate::webViewFooterHeight):
1798         (PrintWebUIDelegate::drawHeaderInRect):
1799         (PrintWebUIDelegate::drawFooterInRect):
1800         (PrintWebUIDelegate::canRunModal):
1801         (PrintWebUIDelegate::createModalDialog):
1802         (PrintWebUIDelegate::runModal):
1803         (PrintWebUIDelegate::isMenuBarVisible):
1804         (PrintWebUIDelegate::setMenuBarVisible):
1805         (PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
1806         (PrintWebUIDelegate::paintCustomScrollbar):
1807         (PrintWebUIDelegate::paintCustomScrollCorner):
1808         * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
1809         (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
1810         (WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
1811         (WinLauncherWebHost::AddRef): check-webkit-style fixes.
1812         (WinLauncherWebHost::Release): check-webkit-style fixes.
1813         (resizeSubViews): check-webkit-style fixes.
1814         (_tWinMain): check-webkit-style fixes.
1815         (MyRegisterClass): check-webkit-style fixes.
1816         (InitInstance): check-webkit-style fixes.
1817         (AbortProc): New print support function.
1818         (getPrinterDC): New print support function.
1819         (initDocStruct): New print support function.
1820         (PrintView): New printing implementation.
1821         (WndProc): Add support for printing.
1822         (MyEditProc): check-webkit-style fixes.
1823         (About): check-webkit-style fixes.
1824         (loadURL): check-webkit-style fixes.
1825         * WinLauncher/WinLauncher.h:
1826         (WinLauncherWebHost::WinLauncherWebHost):
1827         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1828         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1829         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1830         (WinLauncherWebHost::didCommitLoadForFrame):
1831         (WinLauncherWebHost::didReceiveTitle):
1832         (WinLauncherWebHost::didReceiveIcon):
1833         (WinLauncherWebHost::didFinishLoadForFrame):
1834         (WinLauncherWebHost::didFailLoadWithError):
1835         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1836         (WinLauncherWebHost::willPerformClientRedirectToURL):
1837         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1838         (WinLauncherWebHost::willCloseFrame):
1839         (WinLauncherWebHost::windowScriptObjectAvailable):
1840         * WinLauncher/WinLauncher.rc: Add menu entry for printing.
1841         * WinLauncher/WinLauncher.vcproj: Add new files.
1842         * WinLauncher/resource.h: Add menu entry for printing.
1843
1844 2009-12-19  Adam Barth  <abarth@webkit.org>
1845
1846         Unreviewed.  Tweak the CSS to make the dashboard prettier.
1847
1848         * QueueStatusServer/stylesheets/dashboard.css:
1849         * QueueStatusServer/templates/dashboard.html:
1850
1851 2009-12-19  Adam Barth  <abarth@webkit.org>
1852
1853         Reviewed by Eric Seidel.
1854
1855         QueueStatusServer needs a human readable dashboard
1856         https://bugs.webkit.org/show_bug.cgi?id=32769
1857
1858         Here is a first cut at the dashboard.  There's a lot left to do.
1859
1860         * QueueStatusServer/filters/webkit_extras.py:
1861         * QueueStatusServer/handlers/dashboard.py: Added.
1862         * QueueStatusServer/handlers/patchstatus.py:
1863         * QueueStatusServer/handlers/recentstatus.py:
1864         * QueueStatusServer/handlers/showresults.py:
1865         * QueueStatusServer/handlers/statusbubble.py:
1866         * QueueStatusServer/handlers/updatestatus.py:
1867         * QueueStatusServer/main.py:
1868         * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1869         * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
1870         * QueueStatusServer/stylesheets/dashboard.css: Added.
1871         * QueueStatusServer/templates/dashboard.html: Added.
1872         * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
1873         * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
1874
1875 2009-12-19  Daniel Bates  <dbates@webkit.org>
1876
1877         Reviewed by Timothy Hatcher.
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=32462
1880
1881         Added --inspector-frontend flag to build-webkit to copy any changes
1882         to the inspector front-end files to the built WebCore framework. This
1883         will make inspector development more consistent with the rest of
1884         WebKit development.
1885
1886         * Scripts/build-webkit:
1887         * Scripts/webkitdirs.pm:
1888
1889 2009-12-19  Adam Barth  <abarth@webkit.org>
1890
1891         Unreviewed fixes for me being terrible at python.
1892
1893         * Scripts/modules/bugzilla.py:
1894         * Scripts/run-webkit-unittests:
1895
1896 2009-12-18  Adam Barth  <abarth@webkit.org>
1897
1898         Reviewed by Eric Seidel.
1899
1900         Split QueueStatus server into modules
1901         https://bugs.webkit.org/show_bug.cgi?id=32768
1902
1903         One monolithic file is no good.
1904
1905         * QueueStatusServer/app.yaml:
1906         * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1907         * QueueStatusServer/handlers/patchstatus.py: Added.
1908         * QueueStatusServer/handlers/recentstatus.py: Added.
1909         * QueueStatusServer/handlers/showresults.py: Added.
1910         * QueueStatusServer/handlers/statusbubble.py: Added.
1911         * QueueStatusServer/handlers/updatestatus.py: Added.
1912         * QueueStatusServer/main.py: Added.
1913         * QueueStatusServer/model.py: Added.
1914         * QueueStatusServer/queue_status.py: Removed.
1915
1916 2009-12-18  Adam Barth  <abarth@webkit.org>
1917
1918         Rubber stamped by Eric Seidel.
1919
1920         Renamed WorkQueue to QueueEngine.  WorkQueue is not a queue.
1921
1922         * Scripts/modules/commands/queues.py:
1923         * Scripts/modules/queueengine.py: Added.
1924         * Scripts/modules/queueengine_unittest.py: Added.
1925         * Scripts/modules/stepsequence.py:
1926         * Scripts/modules/workqueue.py: Removed.
1927         * Scripts/modules/workqueue_unittest.py: Removed.
1928
1929 2009-12-18  Adam Barth  <abarth@webkit.org>
1930
1931         Reviewed by Eric Seidel.
1932
1933         Add watches for EWS
1934         https://bugs.webkit.org/show_bug.cgi?id=32767
1935
1936         dglazkov wanted to be added.
1937
1938         * Scripts/modules/bugzilla.py:
1939         * Scripts/modules/commands/early_warning_system.py:
1940         * Scripts/modules/commands/queues.py:
1941
1942 2009-12-18  Eric Seidel  <eric@webkit.org>
1943
1944         Reviewed by David Levin.
1945
1946         move bugzilla.py off of urllib2
1947         https://bugs.webkit.org/show_bug.cgi?id=32729
1948
1949         * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
1950
1951 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1952
1953         Rubber-stamped by Xan Lopez.
1954
1955         [GTK] New events (pageshow and pagehide) tests failing
1956         https://bugs.webkit.org/show_bug.cgi?id=28823
1957
1958         Original patch by Jan Michael Alonzo.
1959
1960         Disable page cache for tests.
1961
1962         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1963         (resetDefaultsToConsistentValues):
1964         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1965         (copyWebSettingKey):
1966         (LayoutTestController::overridePreference):
1967
1968 2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>
1969
1970         Reviewed by David Levin.
1971
1972         Check one space before end of line comments.
1973         https://bugs.webkit.org/show_bug.cgi?id=32597
1974         
1975         Fix to check one space before end of line comments in whitespace and build/header_guard.
1976         Also fix build/header_guard to use WebKit header guard defines.
1977
1978         * Scripts/modules/cpp_style.py:
1979         * Scripts/modules/cpp_style_unittest.py:
1980
1981 2009-12-17  Sam Weinig  <sam@webkit.org>
1982
1983         Reviewed by Mark Rowe.
1984
1985         Add BUILDING_ON_SNOW_LEOPARD #define.
1986
1987         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1988
1989 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
1990
1991         Reviewed by Alexey Proskuryakov.
1992
1993         Update pywebsocket to 0.4.5 and make handshake checking stricter
1994         https://bugs.webkit.org/show_bug.cgi?id=32249
1995
1996         * Scripts/run-webkit-tests:
1997         * pywebsocket/mod_pywebsocket/handshake.py:
1998         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
1999         * pywebsocket/mod_pywebsocket/standalone.py:
2000         * pywebsocket/setup.py:
2001         * pywebsocket/test/test_handshake.py:
2002         * pywebsocket/test/test_memorizingfile.py: Added.
2003
2004 2009-12-17  Eric Seidel  <eric@webkit.org>
2005
2006         Reviewed by Adam Barth.
2007
2008         Command.show_in_main_help should default to False
2009         https://bugs.webkit.org/show_bug.cgi?id=32686
2010
2011         * Scripts/modules/commands/download.py:
2012         * Scripts/modules/commands/queries.py:
2013         * Scripts/modules/commands/queues.py:
2014         * Scripts/modules/commands/upload.py:
2015         * Scripts/modules/multicommandtool.py:
2016
2017 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
2018
2019         Reviewed by Eric Seidel.
2020
2021         Added the key WebKitEnableCaretBrowsing to the
2022         layoutTestController.overridePreference in order to activate caret
2023         browsing.
2024         https://bugs.webkit.org/show_bug.cgi?id=32612
2025
2026         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
2027         the setting.
2028         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
2029         key in the keytable.
2030
2031 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
2032
2033         Reviewed by David Kilzer.
2034
2035         AX: DRT needs to support URL for accessibility
2036         https://bugs.webkit.org/show_bug.cgi?id=32666
2037
2038         * DumpRenderTree/AccessibilityUIElement.cpp:
2039         (getURLCallback):
2040         (AccessibilityUIElement::getJSClass):
2041         * DumpRenderTree/AccessibilityUIElement.h:
2042         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2043         (AccessibilityUIElement::url):
2044         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2045         (AccessibilityUIElement::url):
2046         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2047         (AccessibilityUIElement::url):
2048
2049 2009-12-17  Philippe Normand  <pnormand@igalia.com>
2050
2051         Unreviewed; added myself to committers
2052
2053         * Scripts/modules/committers.py:
2054
2055 2009-12-17  Benjamin Otte  <otte@gnome.org>
2056
2057         Unreviewed; added myself to committers
2058
2059         * Scripts/modules/committers.py:
2060
2061 2009-12-17  Adam Barth  <abarth@webkit.org>
2062
2063         Rubber stamp by Seidel.
2064
2065         Clean up exception handling in WorkQueue.  Basically, a bunch of the
2066         delegate messages can throw exceptions because of network errors.  We
2067         want the queues to keep on ticking instead of erroring out.  That means
2068         we want to catch generic exceptions and continue looping.
2069
2070         Also, cleaned up the exception handling in the EWS to properly log
2071         failures.
2072
2073         * Scripts/modules/commands/early_warning_system.py:
2074         * Scripts/modules/commands/queues.py:
2075         * Scripts/modules/workqueue.py:
2076
2077 2009-12-16  Adam Barth  <abarth@webkit.org>
2078
2079         Reviewed by Eric Seidel.
2080
2081         [bzt] Make UpdateStep quiet
2082         https://bugs.webkit.org/show_bug.cgi?id=32599
2083
2084         * Scripts/modules/buildsteps.py:
2085         * Scripts/modules/buildsteps_unittest.py:
2086
2087 2009-12-16  Evan Martin  <evan@chromium.org>
2088
2089         Reviewed by Adam Barth.
2090
2091         Add Gtk to the early warning system WebKit port list.
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=32629
2094
2095         * Scripts/modules/commands/early_warning_system.py:
2096         * Scripts/modules/webkitport.py:
2097         * Scripts/modules/webkitport_unittest.py:
2098
2099 2009-12-16  Eric Seidel  <eric@webkit.org>
2100
2101         Reviewed by Adam Barth.
2102
2103         post-diff is failing with exception under guess_reviewer_from_bug
2104         https://bugs.webkit.org/show_bug.cgi?id=32642
2105
2106         Also refactor output capturing code into
2107         OutputCapture.assert_outputs to share more code between tests.
2108
2109         * Scripts/modules/buildsteps.py:
2110          - Add the missing include.
2111          - Give guess_reviewer_from_bug a private underscore.
2112         * Scripts/modules/buildsteps_unittest.py: Added.
2113          - Test to make sure _guess_reviewer_from_bug works as expected.
2114         * Scripts/modules/commands/commandtest.py:
2115          - Custom code is now obsoleted by OutputCapture.assert_outputs
2116         * Scripts/modules/commands/queues_unittest.py:
2117          - ditto
2118         * Scripts/modules/credentials_unittest.py:
2119          - ditto
2120         * Scripts/modules/mock_bugzillatool.py:
2121          - fetch_reviewed_patches_from_bug can never return None
2122         * Scripts/modules/multicommandtool_unittest.py:
2123          - Custom code is now obsoleted by OutputCapture.assert_outputs
2124         * Scripts/modules/outputcapture.py:
2125          - Add assert_outputs to share more code between tests.
2126         * Scripts/run-webkit-unittests:
2127          - Add buildsteps_unittest.py
2128
2129 2009-12-16  Adam Barth  <abarth@webkit.org>
2130
2131         Unreviewed.  Added a default argument to _update_status so that callers
2132         don't have to explictly pass None when they don't have a patch object.
2133
2134         * Scripts/modules/commands/queues.py:
2135
2136 2009-12-16  Kent Tamura  <tkent@chromium.org>
2137
2138         Reviewed by David Levin.
2139
2140         check-webkit-style supports for TAB check against text files.
2141         https://bugs.webkit.org/show_bug.cgi?id=32538
2142
2143         * Scripts/check-webkit-style:
2144           Move process_patch() to style.py.
2145         * Scripts/modules/cpp_style.py:
2146           Add can_handle().
2147         * Scripts/modules/cpp_style_unittest.py:
2148           Add tests for can_handle().
2149         * Scripts/modules/style.py:
2150           Added. This is a front-end of cpp_style and text_style. It dispatches
2151           files to an appropriate linter.
2152         * Scripts/modules/text_style.py:
2153           Added. This is a linter module for generic text files. It supports
2154           only for TAB checking at this moment.
2155         * Scripts/modules/text_style_unittest.py:
2156           Added. Tests for text_style.py.
2157         * Scripts/run-webkit-unittests:
2158           Add text_style_unittest.
2159
2160 2009-12-16  Eric Seidel  <eric@webkit.org>
2161
2162         Reviewed by David Levin.
2163
2164         bugzilla-tool should not require users to install mechanize
2165         https://bugs.webkit.org/show_bug.cgi?id=32635
2166
2167         Centralize our import logic.
2168
2169         * Scripts/modules/bugzilla.py: use webkit_mechanize
2170         * Scripts/modules/statusbot.py: use webkit_mechanize
2171         * Scripts/modules/webkit_mechanize.py: Added.
2172
2173 2009-12-16  Eric Seidel  <eric@webkit.org>
2174
2175         Reviewed by Adam Barth.
2176
2177         Generalize commit-queue recent status page for all queues
2178         https://bugs.webkit.org/show_bug.cgi?id=32633
2179
2180         * QueueStatusServer/index.html:
2181          - Generalize to support other queues.
2182         * QueueStatusServer/queue_status.py:
2183          - Generalize MainPage to support other queues.
2184
2185 2009-12-16  Evan Martin  <evan@chromium.org>
2186
2187         Reviewed by Adam Barth.
2188
2189         Early warning system server should display output as UTF-8.
2190
2191         https://bugs.webkit.org/show_bug.cgi?id=32625
2192
2193         * QueueStatusServer/queue_status.py:
2194
2195 2009-12-16  Adam Barth  <abarth@webkit.org>
2196
2197         Reviewed by Eric Seidel.
2198
2199         [bzt] Add error handling to the early warning system
2200         https://bugs.webkit.org/show_bug.cgi?id=32594
2201
2202         This should be the last step in making the EWS operational.  When we
2203         have a build error, we post the log to QueueStatusServer and add a link
2204         to the bug.
2205
2206         * Scripts/modules/commands/early_warning_system.py:
2207         * Scripts/modules/commands/queues.py:
2208         * Scripts/modules/executive.py:
2209
2210 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
2211
2212         Reviewed by Holger Freyther.
2213
2214         Fix crash with tests that use custom font faces.
2215
2216         https://bugs.webkit.org/show_bug.cgi?id=32600
2217
2218         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
2219         that custom font faces between tests don't influence each other. Calling this
2220         function in Qt however also invalidates all existing handles with QFontDatabase.
2221
2222         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
2223         which implies a call to WebCore::FontCache::fontCache()->invalidate().
2224
2225         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2226         (WebCore::DumpRenderTree::open):
2227
2228 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
2229
2230         Reviewed by Simon Hausmann.
2231
2232         [Qt] Maintain button state between mouse events.
2233
2234         This allows eventSender to generate drag events.
2235
2236         https://bugs.webkit.org/show_bug.cgi?id=32601
2237
2238         * DumpRenderTree/qt/EventSenderQt.cpp:
2239         (EventSender::mouseDown):
2240         (EventSender::mouseUp):
2241         (EventSender::mouseMoveTo):
2242         * DumpRenderTree/qt/EventSenderQt.h:
2243
2244 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
2245
2246         Reviewed by David Levin.
2247
2248         Code clean-up in check-webkit-style as described below.
2249         The only functional changes are minor improvements to the
2250         script's help output.
2251         
2252         https://bugs.webkit.org/show_bug.cgi?id=32487
2253
2254         * Scripts/check-webkit-style:
2255           - Added the module docstring from cpp_style.py.
2256           - Improved wording of the --help output and added some of the
2257             default values as substitution strings.
2258           - Called cpp_style.exit_with_usage instead of sys.stderr.write
2259             in main function.
2260           - Made changes caused by changes to cpp_style.py.
2261
2262         * Scripts/modules/cpp_style.py:
2263           - Removed module docstring, as well as redundant _USAGE string
2264             and main() function obsoleted by check-webkit-style.
2265           - Moved specification of default script values from within a
2266             function definition to global variables.
2267           - Moved the default webkit filter rules to be near the other
2268             global variables.
2269           - Renamed "FILTER" global variables to "FILTER_RULES" to
2270             establish unambiguous terminology.
2271           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
2272           - Changed _STYLE_CATEGORIES from a string to a list.
2273           - Added default webkit filter rules to --filter= output.
2274           - Renamed "print_" methods to "exit_with_" since they exist
2275             and added a temporary display_help parameter.
2276           - Added a temporary display_help parameter to parse_arguments.
2277
2278         * Scripts/modules/cpp_style_unittest.py:
2279           - Made changes caused by changes to cpp_style.py.
2280           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
2281             variables since they are not global.
2282
2283 2009-12-15  Adam Barth  <abarth@webkit.org>
2284
2285         Unreviewed fix for the style-queue.
2286         Typo: _updates_status -> _update_status
2287
2288         We need to improve our testing infrastructure for the queues.
2289
2290         * Scripts/modules/commands/queues.py:
2291
2292 2009-12-15  Adam Barth  <abarth@webkit.org>
2293
2294         Unreviewed fix for the style-queue.  I suspect this is a recent
2295         regression from Eric's change below.
2296
2297         * Scripts/modules/commands/queues.py:
2298
2299 2009-12-15  Yaar Schnitman  <yaar@chromium.org>
2300
2301         Reviewed by Darin Fisher.
2302
2303         update-webkit-chromium to auto-install gclient
2304
2305         https://bugs.webkit.org/show_bug.cgi?id=32587
2306
2307         * Scripts/update-webkit-chromium:
2308
2309 2009-12-15  Eric Seidel  <eric@webkit.org>
2310
2311         Reviewed by Adam Barth.
2312
2313         bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
2314         https://bugs.webkit.org/show_bug.cgi?id=32546
2315
2316         You can see an example of this working in:
2317         https://bugs.webkit.org/show_bug.cgi?id=32585#c3
2318
2319         * QueueStatusServer/queue_status.py:
2320          - Output the id of the newly created status.
2321         * Scripts/modules/commands/queues.py:
2322          - Tweak the commit-queue logging to include a full status link.
2323         * Scripts/modules/statusbot.py:
2324          - update_status should return the newly created status id.
2325
2326 2009-12-15  Andras Becsi  <abecsi@inf.u-szeged.hu>
2327
2328         Reviewed by Tor Arne Vestbø.
2329
2330         [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
2331
2332         * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
2333         * DumpRenderTree/qt/DumpRenderTree.h: Removed.
2334         * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
2335         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
2336         * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
2337         * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
2338         (GCController::GCController):
2339         * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
2340         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2341         * DumpRenderTree/qt/WorkQueueItem.h: Removed.
2342         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
2343         * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
2344         * DumpRenderTree/qt/jsobjects.cpp: Removed.
2345         * DumpRenderTree/qt/jsobjects.h: Removed.
2346         * DumpRenderTree/qt/main.cpp: Updated includes.
2347
2348 2009-12-15  Adam Barth  <abarth@webkit.org>
2349
2350         Reviewed by Eric Seidel.
2351
2352         We have two mark-fixed commands
2353         https://bugs.webkit.org/show_bug.cgi?id=32073
2354
2355         * Scripts/mark-bug-fixed: Removed.
2356         * Scripts/modules/commands/upload.py:
2357         * Scripts/modules/commands/upload_unittest.py:
2358
2359 2009-12-15  Eric Seidel  <eric@webkit.org>
2360
2361         Reviewed by Adam Barth.
2362
2363         bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
2364         https://bugs.webkit.org/show_bug.cgi?id=28286
2365
2366         * QueueStatusServer/index.html:
2367          - Show [results] links if a results log was uploaded.
2368         * QueueStatusServer/queue_status.py:
2369          - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
2370         * Scripts/modules/commands/queues.py:
2371          - Post to the status bot when a patch fails and include the failure log as a results file.
2372
2373 2009-12-15  Eric Seidel  <eric@webkit.org>
2374
2375         Reviewed by Adam Barth.
2376
2377         queue sub-commands need --status-host so they can report status
2378         https://bugs.webkit.org/show_bug.cgi?id=32313
2379
2380         Make --status-bot a global option and make
2381         run_bugzilla_tool pass --status-bot to sub-commands.
2382
2383         * Scripts/bugzilla-tool:
2384          - Rename _status to status_bot and make it non-lazy.
2385         * Scripts/modules/commands/queues.py:
2386          - Move status updates out of WorkQueue and into individual queues.
2387         * Scripts/modules/commands/queues_unittest.py:
2388          - Test that --status-host is passed to bugzilla-tool when run as subcommand.
2389         * Scripts/modules/mock_bugzillatool.py:
2390          - Add a MockStatusBot
2391         * Scripts/modules/workqueue.py:
2392          - Remove status_host and work_work_logs_directory callbacks.
2393          - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
2394         * Scripts/modules/workqueue_unittest.py:
2395          - Update unit tests to reflect new callbacks.
2396
2397 2009-12-15  Adam Barth  <abarth@webkit.org>
2398
2399         Reviewed by Eric Seidel.
2400
2401         scm_unittest.py is too slow
2402         https://bugs.webkit.org/show_bug.cgi?id=31818
2403
2404         Now we don't run the SCM unit tests unless we get the --all flag on the
2405         command line.  Eric and I were commenting out this test because it was
2406         too painful to run.
2407
2408         * Scripts/run-webkit-unittests:
2409
2410 2009-12-14  Adam Barth  <abarth@webkit.org>
2411
2412         Unreviewed.  Fix failing unittest.
2413
2414         * Scripts/modules/bugzilla_unittest.py:
2415
2416 2009-12-14  Eric Seidel  <eric@webkit.org>
2417
2418         Reviewed by Adam Barth.
2419
2420         Move Credential handling out into a separate module
2421         https://bugs.webkit.org/show_bug.cgi?id=32531
2422
2423         * Scripts/modules/bugzilla.py:
2424         * Scripts/modules/credentials.py: Added.
2425         * Scripts/modules/credentials_unittest.py: Added.
2426         * Scripts/run-webkit-unittests:
2427
2428 2009-12-14  Adam Barth  <abarth@webkit.org>
2429
2430         Reviewed by Eric Seidel.
2431
2432         Kill _create_step_sequence
2433         https://bugs.webkit.org/show_bug.cgi?id=32539
2434
2435         It's cleaner to represent not having these sequences as an empty
2436         sequence instead of None.
2437
2438         * Scripts/modules/commands/download.py:
2439         * Scripts/modules/stepsequence.py:
2440
2441 2009-12-14  Adam Barth  <abarth@webkit.org>
2442
2443         Unreviewed.  Address reviewer comments from an earlier patch.  I didn't
2444         do this earlier because I was worried about conflicts in dependent
2445         patches.
2446
2447         * Scripts/modules/commands/download.py:
2448
2449 2009-12-14  Adam Barth  <abarth@webkit.org>
2450
2451         Reviewed by Eric Seidel.
2452
2453         [bzt] Make download commands declarative
2454         https://bugs.webkit.org/show_bug.cgi?id=32469
2455
2456         This patch "properly" factors most of the download commands.  These
2457         commands are now largely declarative, which is the final step of this
2458         grand refactoring.
2459
2460         * Scripts/modules/buildsteps.py:
2461         * Scripts/modules/commands/download.py:
2462
2463 2009-12-14  Adam Barth  <abarth@webkit.org>
2464
2465         Reviewed by Eric Seidel.
2466
2467         [bzt] Add AbstractPatchSequencingCommand to remove redundant code
2468         https://bugs.webkit.org/show_bug.cgi?id=32468
2469
2470         Redundant code is bad.  This patch moves us towards more declarative
2471         commands.
2472
2473         * Scripts/modules/commands/download.py:
2474
2475 2009-12-14  Adam Barth  <abarth@webkit.org>
2476
2477         Reviewed by Eric Seidel.
2478
2479         [bzt] Kill WebKitApplyingScripts
2480         https://bugs.webkit.org/show_bug.cgi?id=32467
2481
2482         Ah!  I've been wanting to do this for a long time.  This patch brings
2483         the applying commands into the patch processing fold.
2484
2485         * Scripts/bugzilla-tool:
2486         * Scripts/modules/buildsteps.py:
2487         * Scripts/modules/commands/download.py:
2488         * Scripts/modules/commands/download_unittest.py:
2489         * Scripts/modules/mock_bugzillatool.py:
2490
2491 2009-12-14  Adam Barth  <abarth@webkit.org>
2492
2493         Reviewed by Eric Seidel.
2494
2495         [bzt] Convert rollout to StepSequence
2496         https://bugs.webkit.org/show_bug.cgi?id=32406
2497
2498         * Scripts/modules/buildsteps.py:
2499         * Scripts/modules/commands/download.py:
2500         * Scripts/modules/commands/download_unittest.py:
2501         * Scripts/modules/mock_bugzillatool.py:
2502
2503 2009-12-14  Adam Barth  <abarth@webkit.org>
2504
2505         Reviewed by Eric Seidel.
2506
2507         [bzt] Kill LandingSequence
2508         https://bugs.webkit.org/show_bug.cgi?id=32464
2509
2510         Removes LandingSequence in favor of StepSequence.  This required
2511         changing the Step API slightly to carry a general notion of state
2512         instead of carrying patches specifically.
2513
2514         * Scripts/modules/buildsteps.py:
2515         * Scripts/modules/commands/download.py:
2516         * Scripts/modules/commands/queues.py:
2517         * Scripts/modules/landingsequence.py: Removed.
2518         * Scripts/modules/stepsequence.py:
2519
2520 2009-12-14  Robert Hogan  <robert@roberthogan.net>
2521
2522         Reviewed by Eric Seidel.
2523
2524         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
2525         
2526         Amend the behaviour of DRT::notifyDone to dump only when
2527         the page has finished loading.
2528         
2529         This fix permits removal of the following tests from the Qt skipped list:
2530         fast/forms/textarea-linewrap-dynamic.html
2531         fast/forms/textarea-setvalue-submit.html
2532         fast/forms/textarea-hard-linewrap-empty.html
2533         fast/forms/submit-to-url-fragment.html
2534         http/tests/misc/percent-sign-in-form-field-name.html
2535         http/tests/security/escape-form-data-field-names.html
2536         
2537         However it also requires the following two to be added to the skipped list:
2538         
2539         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
2540         svg/custom/use-instanceRoot-as-event-target.xhtml
2541         
2542         It appears the behaviour of notifyDone was masking problems with these two
2543         tests.
2544
2545         * DumpRenderTree/qt/DumpRenderTree.cpp:
2546         (WebCore::DumpRenderTree::DumpRenderTree):
2547         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2548         (LayoutTestController::reset):
2549         (LayoutTestController::processWork):
2550         (LayoutTestController::maybeDump):
2551         (LayoutTestController::notifyDone):
2552         (LayoutTestController::provisionalLoad):
2553         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2554         (LayoutTestController::resetLoadFinished):
2555
2556 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
2557
2558         Reviewed by Holger Freyther.
2559
2560         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
2561
2562         https://bugs.webkit.org/show_bug.cgi?id=32482
2563
2564         * DumpRenderTree/qt/EventSenderQt.cpp:
2565         (EventSender::setTouchModifier):
2566         (EventSender::clearTouchPoints):
2567         (EventSender::sendTouchEvent):
2568         * DumpRenderTree/qt/EventSenderQt.h:
2569
2570 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
2571
2572         Reviewed by Gavin Barraclaugh.
2573
2574         Fix minor problem in sunspider-compare-results which left it broken.
2575
2576         * Scripts/sunspider-compare-results: Declare $parseonly
2577
2578 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2579
2580         Reviewed by Oliver Hunt.
2581
2582         Give command-line sunspider the ability to handle multiple suites and versions
2583         https://bugs.webkit.org/show_bug.cgi?id=32477
2584
2585         * Scripts/run-sunspider: Updated for changes to command-line parameters.
2586         * Scripts/sunspider-compare-results: ditto
2587
2588 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2589
2590         Not reviewed, fixing previous comment.
2591
2592         Remove accidental change to sunspider-compare-results
2593
2594         * Scripts/sunspider-compare-results:
2595
2596 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
2597
2598         Unreviewed build fix for Qt versions < 4.6. 
2599         Guard every slot individually with #ifdef.
2600
2601         * DumpRenderTree/qt/EventSenderQt.cpp:
2602         (EventSender::addTouchPoint):
2603         (EventSender::updateTouchPoint):
2604         (EventSender::touchStart):
2605         (EventSender::touchMove):
2606         (EventSender::touchEnd):
2607         (EventSender::clearTouchPoints):
2608         (EventSender::releaseTouchPoint):
2609         (EventSender::sendTouchEvent):
2610         * DumpRenderTree/qt/EventSenderQt.h:
2611
2612 2009-12-11  Eric Seidel  <eric@webkit.org>
2613
2614         Reviewed by Adam Barth.
2615
2616         CommandsTest.assert_execute_outputs doesn't check stderr
2617         https://bugs.webkit.org/show_bug.cgi?id=32352
2618
2619         Fix assert_execute_outputs to check stderr
2620         and then fix all the unit tests which needed to
2621         pass stderr output.
2622
2623         * Scripts/modules/commands/commandtest.py:
2624         * Scripts/modules/commands/download_unittest.py:
2625         * Scripts/modules/commands/upload_unittest.py:
2626
2627 2009-12-11  Adam Barth  <abarth@webkit.org>
2628
2629         Reviewed by Eric Seidel.
2630
2631         [check-webkit-style] False positive for tst_QWebFrame
2632         https://bugs.webkit.org/show_bug.cgi?id=32436
2633
2634         Add an exception for function names that start with "tst_".  These are
2635         used by the Qt unit testing framework.
2636
2637         * Scripts/modules/cpp_style.py:
2638         * Scripts/modules/cpp_style_unittest.py:
2639
2640 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
2641
2642         Reviewed by Antti Koivisto.
2643
2644         Added support for creating synthetic touch events with EventSender
2645         in Qt's DumpRenderTree.
2646
2647         https://bugs.webkit.org/show_bug.cgi?id=32114
2648
2649         * DumpRenderTree/qt/EventSenderQt.cpp:
2650         (EventSender::addTouchPoint):
2651         (EventSender::updateTouchPoint):
2652         (EventSender::touchStart):
2653         (EventSender::touchMove):
2654         (EventSender::touchEnd):
2655         (EventSender::clearTouchPoints):
2656         (EventSender::releaseTouchPoint):
2657         (EventSender::sendTouchEvent):
2658         * DumpRenderTree/qt/EventSenderQt.h:
2659
2660 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
2661
2662         Reviewed by Darin Adler.
2663
2664         The values of RuntimeArray are not enumerable
2665         https://bugs.webkit.org/show_bug.cgi?id=29005
2666
2667         * DumpRenderTree/mac/ObjCController.m:
2668         (+[ObjCController isSelectorExcludedFromWebScript:]):
2669         (+[ObjCController webScriptNameForSelector:]):
2670         (-[ObjCController arrayOfString]):
2671
2672 2009-12-10  Eric Seidel  <eric@webkit.org>
2673
2674         No review, just updating unit tests to match recent checkins.
2675
2676         * Scripts/modules/mock_bugzillatool.py:
2677          - Add missing red_core_builders_names method causing exception.
2678         * Scripts/modules/workqueue_unittest.py:
2679          - processutils is dead, use executive.py instead.
2680
2681 2009-12-10  Eric Seidel  <eric@webkit.org>
2682
2683         Reviewed by Adam Barth.
2684
2685         Move run_command onto Executive to make code which uses run_command testable
2686         https://bugs.webkit.org/show_bug.cgi?id=32396
2687
2688         * Scripts/modules/executive.py:
2689          - Move run_command and error handlers onto Executive.
2690         * Scripts/modules/scm.py:
2691         * Scripts/modules/scm_unittest.py:
2692
2693 2009-12-09  Eric Seidel  <eric@webkit.org>
2694
2695         Reviewed by Adam Barth.
2696
2697         bugzilla-tool needs a command to list patches needing cq+
2698         https://bugs.webkit.org/show_bug.cgi?id=32351
2699
2700         * Scripts/modules/bugzilla.py:
2701          - Parse attacher_email from attachment xml.
2702         * Scripts/modules/bugzilla_unittest.py:
2703          - Test new attacher_email parsing.
2704         * Scripts/modules/commands/queries.py:
2705          - Add PatchesToCommitQueue
2706         * Scripts/modules/commands/queries_unittest.py:
2707          - Tests for PatchesToCommitQueue
2708         * Scripts/modules/mock_bugzillatool.py:
2709          - Add necessary mock methods for running PatchesToCommitQueue
2710
2711 2009-12-10  Adam Barth  <abarth@webkit.org>
2712
2713         Unreviewed.  Turns out every StepSequence command needs a --quiet
2714         option.
2715
2716         * Scripts/modules/stepsequence.py:
2717
2718 2009-12-10  Eric Z. Ayers  <zundel@google.com>
2719
2720         Reviewed by Pavel Feldman.
2721
2722         Implements displayWebView() to force an invalidation and repaint.
2723         This fixes a problem running the timeline-paint.html unit test.
2724
2725         https://bugs.webkit.org/show_bug.cgi?id=31729
2726
2727         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2728         (displayWebView):
2729
2730 2009-12-10  Adam Barth  <abarth@webkit.org>
2731
2732         Reviewed by Eric Seidel.
2733
2734         [bzt] Convert more commands to StepSequences
2735         https://bugs.webkit.org/show_bug.cgi?id=32362
2736
2737         We should eventually convert all the commands, but I'm starting with
2738         the easy ones.
2739
2740         * Scripts/modules/commands/download.py:
2741
2742 2009-12-10  Xan Lopez  <xlopez@igalia.com>
2743
2744         Reviewed by Jan Alonzo.
2745
2746         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
2747         https://bugs.webkit.org/show_bug.cgi?id=31103
2748
2749         Give focus to the webviews when we create them, since some tests expect this.
2750
2751         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2752         (main):
2753
2754 2009-12-10  Eric Seidel  <eric@webkit.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         bugzilla-tool "builders are red" error should tell you which builders
2759         https://bugs.webkit.org/show_bug.cgi?id=32211
2760
2761         * Scripts/modules/buildsteps.py:
2762
2763 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
2764
2765         Reviewed by Adam Roben.
2766
2767         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
2768         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
2769         in Windows as part of running update_webkit.
2770
2771         * Scripts/update-webkit:
2772          - Run setupAppleWinEnv() on Apple's Windows port.
2773         * Scripts/webkitdirs.pm:
2774          - Added functions that return the source directory, libraries directory and default build directory on Windows.
2775          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
2776          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
2777            and Cygwin to their desired values.
2778
2779 2009-12-09  Adam Barth  <abarth@webkit.org>
2780
2781         Reviewed by Eric Seidel.
2782
2783         exception thrown when running apply-patches
2784         https://bugs.webkit.org/show_bug.cgi?id=32344
2785
2786         The update step now takes a port option.  Once we finish the Steps
2787         refactoring, we won't have to worry about this kind of bug again.
2788
2789         * Scripts/modules/commands/download.py:
2790
2791 2009-12-09  Adam Barth  <abarth@webkit.org>
2792
2793         Unreviewed.  Fix ScriptError includes.  I don't understand why these
2794         didn't throw during unit testing...
2795
2796         * Scripts/modules/commands/download.py:
2797         * Scripts/modules/logging_unittest.py:
2798         * Scripts/modules/workqueue.py:
2799
2800 2009-12-09  Adam Barth  <abarth@webkit.org>
2801
2802         Reviewed by Eric Seidel.
2803
2804         [bzt] Remove unused PatchCollection class
2805         https://bugs.webkit.org/show_bug.cgi?id=32312
2806
2807         It's dead code.
2808
2809         * Scripts/modules/patchcollection.py:
2810         * Scripts/modules/patchcollection_unittest.py: Removed.
2811
2812 2009-12-09  Adam Barth  <abarth@webkit.org>
2813
2814         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
2815
2816         * Scripts/modules/commands/download.py:
2817
2818 2009-12-09  Adam Barth  <abarth@webkit.org>
2819
2820         Reviewed by Eric Seidel.
2821
2822         [bzt] Convert Build to use Sequence
2823         https://bugs.webkit.org/show_bug.cgi?id=32310
2824
2825         So much prettier.
2826
2827         * Scripts/modules/buildsteps.py:
2828         * Scripts/modules/commands/download.py:
2829         * Scripts/modules/landingsequence.py:
2830         * Scripts/modules/stepsequence.py: Added.
2831
2832 2009-12-09  Adam Barth  <abarth@webkit.org>
2833
2834         Add missing file.
2835
2836         * Scripts/modules/executive.py: Added.
2837
2838 2009-12-09  Adam Barth  <abarth@webkit.org>
2839
2840         Unreviewed "build" fix.
2841
2842         * Scripts/modules/landingsequence.py:
2843
2844 2009-12-09  Adam Barth  <abarth@webkit.org>
2845
2846         Reviewed by Eric Seidel.
2847
2848         [bzt] Implement abstract Steps
2849         https://bugs.webkit.org/show_bug.cgi?id=32212
2850
2851         This is a fairly disruptive change that refactors how we build
2852         commands.  Instead of using a landing sequence, we can now assemble a
2853         sequence of steps directly.  We still use the landing sequence in the
2854         interim, but this will be removed soon.
2855
2856         * Scripts/bugzilla-tool:
2857         * Scripts/modules/buildsteps.py:
2858         * Scripts/modules/commands/download.py:
2859         * Scripts/modules/commands/early_warning_system.py:
2860         * Scripts/modules/commands/queues.py:
2861         * Scripts/modules/commands/queues_unittest.py:
2862         * Scripts/modules/landingsequence.py:
2863         * Scripts/modules/mock_bugzillatool.py:
2864         * Scripts/modules/processutils.py: Removed.
2865         * Scripts/modules/scm.py:
2866         * Scripts/modules/scm_unittest.py:
2867         * Scripts/modules/webkitport.py:
2868
2869 2009-12-08  Eric Seidel  <eric@webkit.org>
2870
2871         Reviewed by Adam Barth.
2872
2873         run_command and ScriptError should move into processutils.py
2874         https://bugs.webkit.org/show_bug.cgi?id=32305
2875
2876         Turns out there are a zillion callers to run_command.
2877
2878         * Scripts/modules/commands/download.py:
2879         * Scripts/modules/commands/early_warning_system.py:
2880         * Scripts/modules/commands/queues.py:
2881         * Scripts/modules/landingsequence.py:
2882         * Scripts/modules/logging_unittest.py:
2883         * Scripts/modules/processutils.py:
2884         * Scripts/modules/scm.py:
2885         * Scripts/modules/scm_unittest.py:
2886         * Scripts/modules/workqueue.py:
2887         * Scripts/modules/workqueue_unittest.py:
2888
2889 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
2890
2891         Reviewed by Kevin Ollivier.
2892
2893         [wx] Mac plugins support.
2894         
2895         https://bugs.webkit.org/show_bug.cgi?id=32236
2896
2897         * wx/browser/wscript:
2898
2899 2009-12-08  David Levin  <levin@chromium.org>
2900
2901         Reviewed by Adam Barth.
2902
2903         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
2904         https://bugs.webkit.org/show_bug.cgi?id=32193
2905
2906         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
2907           at the beginning of line, ignore lines which then have a macro.
2908         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
2909           new behavior.
2910
2911 2009-12-08  Dmitry Titov  <dimich@chromium.org>
2912
2913         Rubber-stamped by David Levin.
2914
2915         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
2916         It may have caused massive increase of reported leaks on the bots.
2917         https://bugs.webkit.org/show_bug.cgi?id=31639
2918
2919         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
2920
2921 2009-12-08  Dmitry Titov  <dimich@chromium.org>
2922
2923         Reviewed by Darin Adler.
2924
2925         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
2926         https://bugs.webkit.org/show_bug.cgi?id=31639
2927
2928         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
2929
2930 2009-12-08  David Levin  <levin@chromium.org>
2931
2932         Reviewed by Adam Barth.
2933
2934         [check-webkit-style] False positive for camel case of JSC op codes
2935         https://bugs.webkit.org/show_bug.cgi?id=32192
2936
2937         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
2938           code functions and const_iterator as well since I noticed a false
2939           positive there when testing the fix.
2940         * Scripts/modules/cpp_style_unittest.py: Added tests for these
2941           changes.
2942
2943 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
2944
2945         Rubber-stamped by Maciej Stachowiak.
2946
2947         Turn on (SVG) Filters for Win.
2948         https://bugs.webkit.org/show_bug.cgi?id=32224
2949
2950         * Scripts/webkitdirs.pm:
2951
2952 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
2953
2954         Rubber-stamped by Maciej Stachowiak.
2955
2956         Turn on (SVG) Filters for Gtk.
2957         https://bugs.webkit.org/show_bug.cgi?id=32224
2958
2959         * Scripts/build-webkit:
2960
2961 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
2962
2963         Reviewed by David Levin.
2964
2965         [check-webkit-style] S_OK is a fine identifier
2966         https://bugs.webkit.org/show_bug.cgi?id=32225
2967
2968         * Scripts/modules/cpp_style.py:
2969         * Scripts/modules/cpp_style_unittest.py:
2970
2971 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2972
2973         Rubber-stamped by Maciej Stachowiak.
2974
2975         Turn on (SVG) Filters for Qt.
2976         https://bugs.webkit.org/show_bug.cgi?id=32224
2977
2978         * Scripts/build-webkit:
2979
2980 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
2981
2982         Reviewed by Alexey Proskuryakov.
2983
2984         Make run-webkit-websocketserver log to stderr rather than to a file.
2985         https://bugs.webkit.org/show_bug.cgi?id=32234
2986
2987         * Scripts/run-webkit-websocketserver:
2988
2989 2009-12-07  Dmitry Titov  <dimich@chromium.org>
2990
2991         Rubber-stamped by Darin Adler.
2992
2993         Remove ENABLE_SHARED_SCRIPT flags
2994         https://bugs.webkit.org/show_bug.cgi?id=32245
2995         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
2996
2997         * Scripts/build-webkit:
2998
2999 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
3000
3001         Reviewed by Darin Adler.
3002
3003         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
3004
3005         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
3006         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
3007         This caused one compositing test make DumpRenderTree think that all subsequent tests
3008         were compositing too.
3009
3010         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
3011         notification informs the client that a WebHTMLView entered compositing mode (or an already-
3012         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
3013         compositing subviews were removed, since this is tricky to get right.
3014         
3015         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
3016         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
3017         We ensure that window autodisplay is turned off before every test.
3018
3019         * DumpRenderTree/mac/DumpRenderTree.mm:
3020         (createWebViewAndOffscreenWindow):
3021         (resetWebViewToConsistentStateBeforeTesting):
3022         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3023         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3024         (-[DumpRenderTreeWindow close]):
3025         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
3026         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
3027
3028 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3029
3030         Reviewed by Holger Hans Peter Freyther.
3031
3032         Turn on (SVG) Filters support, by default.
3033         https://bugs.webkit.org/show_bug.cgi?id=32224
3034
3035         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
3036
3037         * Scripts/build-webkit:
3038
3039 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
3040
3041         Reviewed by Darin Fisher.
3042
3043         Chromium buildbots are not red when they fail
3044         https://bugs.webkit.org/show_bug.cgi?id=32235
3045
3046         * Scripts/build-webkit:
3047
3048 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
3049
3050         Reviewed by Darin Fisher.
3051
3052         Typo in chromium linux builder
3053         https://bugs.webkit.org/show_bug.cgi?id=32238
3054
3055         * Scripts/webkitdirs.pm:
3056
3057 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
3058
3059         Reviewed by Darin Fisher.
3060
3061         fixes to build-webkit --chromium
3062         https://bugs.webkit.org/show_bug.cgi?id=32179
3063
3064         * Scripts/webkitdirs.pm:
3065
3066 2009-12-07  Eric Seidel  <eric@webkit.org>
3067
3068         No review, just adding two recently approved committers.
3069
3070         * Scripts/modules/committers.py:
3071
3072 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
3073
3074         * Scripts/run-webkit-websocketserver: Added property svn:executable.
3075
3076 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
3077
3078         Reviewed by Alexey Proskuryakov.
3079
3080         Add run-webkit-websocketserver
3081
3082         https://bugs.webkit.org/show_bug.cgi?id=31390
3083
3084         * Scripts/run-webkit-websocketserver: Added.
3085
3086 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
3087
3088         Build fix. Be flexible about which version of ICU is used on Windows.
3089
3090         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
3091
3092 2009-12-07  Dirk Schulze  <krit@webkit.org>
3093
3094         Not reviewed, adding myself to the reviewers list.
3095
3096         * Scripts/modules/committers.py:
3097
3098 2009-12-06  Eric Seidel  <eric@webkit.org>
3099
3100         Reviewed by Adam Barth.
3101
3102         Add an API for uploading results files to StatusBot
3103         https://bugs.webkit.org/show_bug.cgi?id=32210
3104
3105         Add Content-Type: plain/text which was forgotten
3106         from the previous commit when I landed with land-patches
3107         instead of land-diff.
3108
3109         * QueueStatusServer/queue_status.py:
3110
3111 2009-12-06  Eric Seidel  <eric@webkit.org>
3112
3113         Reviewed by Adam Barth.
3114
3115         Status Server needs a way to handle uploaded results
3116         https://bugs.webkit.org/show_bug.cgi?id=32209
3117
3118         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
3119         * QueueStatusServer/update_status.html: Add file upload.
3120
3121 2009-12-06  Eric Seidel  <eric@webkit.org>
3122
3123         Reviewed by Adam Barth.
3124
3125         Add an API for uploading results files to StatusBot
3126         https://bugs.webkit.org/show_bug.cgi?id=32210
3127
3128         * Scripts/modules/statusbot.py:
3129
3130 2009-12-06  Eric Seidel  <eric@webkit.org>
3131
3132         Reviewed by Adam Barth.
3133
3134         Status Server needs a way to handle uploaded results
3135         https://bugs.webkit.org/show_bug.cgi?id=32209
3136
3137         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
3138         * QueueStatusServer/update_status.html: Add file upload.
3139
3140 2009-12-06  Adam Barth  <abarth@webkit.org>
3141
3142         Reviewed by Eric Seidel.
3143
3144         [bzt] BuildAttachment should not check the builders
3145         https://bugs.webkit.org/show_bug.cgi?id=32207
3146
3147         This is code that got copied here by accident when the class was created.
3148
3149         * Scripts/modules/commands/download.py:
3150
3151 2009-12-06  Adam Barth  <abarth@webkit.org>
3152
3153         Reviewed by Eric Seidel.
3154
3155         [bzt] Make LandingSequence.update aware of ports
3156         https://bugs.webkit.org/show_bug.cgi?id=32208
3157
3158         This is required to make build work on the Chromium port because
3159         Chromium has a custom update-webkit.
3160
3161         * Scripts/modules/landingsequence.py:
3162
3163 2009-12-06  Adam Barth  <abarth@webkit.org>
3164
3165         Reviewed by Eric Seidel.
3166
3167         Add early warning system commands to bugzilla-tool.
3168
3169         * Scripts/bugzilla-tool:
3170         * Scripts/modules/landingsequence.py:
3171         * Scripts/modules/webkitport.py:
3172
3173 2009-12-06  Adam Barth  <abarth@webkit.org>
3174
3175         Reviewed by Eric Seidel.
3176
3177         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
3178         https://bugs.webkit.org/show_bug.cgi?id=32205
3179
3180         * Scripts/modules/commands/early_warning_system.py: Added.
3181         * Scripts/modules/commands/queues.py:
3182
3183 2009-12-06  Dan Bernstein  <mitz@apple.com>
3184
3185         Reviewed by Adele Peterson.
3186
3187         REGRESSION (r51728): update-webkit fails when the current directory is
3188         not inside a Subversion working copy
3189         https://bugs.webkit.org/show_bug.cgi?id=32204
3190
3191         * Scripts/update-webkit: Invoke isSVN() in the correct working
3192         directory.
3193
3194 2009-12-06  Adam Barth  <abarth@webkit.org>
3195
3196         Reviewed by Eric Seidel.
3197
3198         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
3199         https://bugs.webkit.org/show_bug.cgi?id=32202
3200
3201         * Scripts/modules/commands/queues.py:
3202
3203 2009-12-05  Adam Barth  <abarth@webkit.org>
3204
3205         Reviewed by Eric Seidel.
3206
3207         [bzt] Implement ChromiumPort
3208         https://bugs.webkit.org/show_bug.cgi?id=32182
3209
3210         * Scripts/modules/webkitport.py:
3211         * Scripts/modules/webkitport_unittest.py:
3212
3213 2009-12-05  Adam Barth  <abarth@webkit.org>
3214
3215         Reviewed by Eric Seidel.
3216
3217         Move update-webkit into BuildSteps
3218         https://bugs.webkit.org/show_bug.cgi?id=32181
3219
3220         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
3221         that WebKit exists.  The proper place for the knowledge of the existence of
3222         update-webkit is in WebKitPort because some ports have specialized update
3223         scripts (analogous to build-webkit).
3224
3225         * Scripts/modules/buildsteps.py:
3226         * Scripts/modules/commands/download.py:
3227         * Scripts/modules/landingsequence.py:
3228         * Scripts/modules/scm.py:
3229         * Scripts/modules/webkitport.py:
3230
3231 2009-12-05  Adam Barth  <abarth@webkit.org>
3232
3233         Reviewed by Eric Seidel.
3234
3235         update-webkit should call git svn rebase and resolve-ChangeLogs -f
3236         https://bugs.webkit.org/show_bug.cgi?id=27162
3237
3238         Teach update-webkit about Git.  I didn't add the call to
3239         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
3240         can iterate from here, however.
3241
3242         * Scripts/update-webkit:
3243
3244 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
3245
3246         Unreviewed build fix.
3247
3248         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
3249
3250         * DumpRenderTree/qt/DumpRenderTree.cpp:
3251
3252 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3253
3254         Reviewed by Adam Treat.
3255
3256         Add some missing methods for showing and hiding the
3257         Web Inspector.
3258
3259         * DumpRenderTree/qt/DumpRenderTree.cpp:
3260         (WebCore::WebPage::WebPage):
3261         (WebCore::WebPage::~WebPage):
3262         (WebCore::WebPage::webInspector):
3263         * DumpRenderTree/qt/DumpRenderTree.h:
3264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3265         (LayoutTestController::showWebInspector):
3266         (LayoutTestController::hideWebInspector):
3267         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3268
3269 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3270
3271         Reviewed by Adam Treat.
3272
3273         Implement the setAllowUniversalAccessFromFileURLs method
3274         for the Qt LayoutTestController.
3275
3276         * DumpRenderTree/qt/DumpRenderTree.cpp:
3277         (WebCore::WebPage::resetSettings):
3278         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3279         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3280         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3281
3282 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
3283
3284         Reviewed by Darin Adler.
3285
3286         REGRESSION: AX: buttons now extremely repetitive
3287         https://bugs.webkit.org/show_bug.cgi?id=32164
3288
3289         * DumpRenderTree/AccessibilityUIElement.cpp:
3290         (isAttributeSupportedCallback):
3291         (AccessibilityUIElement::getJSClass):
3292         * DumpRenderTree/AccessibilityUIElement.h:
3293         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3294         (AccessibilityUIElement::isAttributeSupported):
3295         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3296         (AccessibilityUIElement::isAttributeSupported):
3297         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3298         (AccessibilityUIElement::isAttributeSupported):
3299
3300 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
3301
3302         Reviewed by David Levin.
3303
3304         check-webkit-style should check for camelCase variable names
3305         https://bugs.webkit.org/show_bug.cgi?id=32051
3306
3307         * Scripts/modules/cpp_style.py:
3308         * Scripts/modules/cpp_style_unittest.py:
3309
3310 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
3311
3312         Reviewed by Eric Seidel.
3313
3314         AX: VO just says "term" on many web sites
3315         https://bugs.webkit.org/show_bug.cgi?id=32139
3316
3317         * DumpRenderTree/AccessibilityUIElement.cpp:
3318         (getRoleDescriptionCallback):
3319         (AccessibilityUIElement::getJSClass):
3320         * DumpRenderTree/AccessibilityUIElement.h:
3321         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3322         (AccessibilityUIElement::roleDescription):
3323         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3324         (AccessibilityUIElement::roleDescription):
3325         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3326         (AccessibilityUIElement::roleDescription):
3327
3328 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
3329
3330         Reviewed by Beth Dakin.
3331
3332         Implement WAI-ARIA scrollbar role and related property aria-orientation
3333         https://bugs.webkit.org/show_bug.cgi?id=32126
3334
3335         * DumpRenderTree/AccessibilityUIElement.cpp:
3336         (getOrientationCallback):
3337         (AccessibilityUIElement::getJSClass):
3338         * DumpRenderTree/AccessibilityUIElement.h:
3339         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3340         (AccessibilityUIElement::orientation):
3341         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3342         (AccessibilityUIElement::orientation):
3343         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3344         (AccessibilityUIElement::orientation):
3345
3346 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
3347
3348         Reviewed by Adam Roben.
3349
3350         Minor correction to r51663.
3351
3352         * DumpRenderTree/win/DumpRenderTree.cpp:
3353         (addQTDirToPATH):
3354             GetEnvironmentVariable -> GetEnvironmentVariableW.
3355
3356 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
3357
3358         Reviewed by Adam Roben.
3359
3360         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
3361         https://bugs.webkit.org/show_bug.cgi?id=30256
3362
3363         Add the QuickTime dll directory to the PATH environment variable so
3364         inialization can succeed.
3365
3366         * DumpRenderTree/win/DumpRenderTree.cpp:
3367         (addQTDirToPATH):
3368         (initialize):
3369
3370 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
3371
3372         Reviewed by Kenneth Rohde Christiansen.
3373
3374         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
3375
3376         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3377         (LayoutTestController::maybeDump):
3378
3379 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
3380
3381         Reviewed by Eric Seidel.
3382
3383         Update pywebsocket to 0.4.3
3384         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
3385         Stack trace is logged now in INFO level.
3386         https://bugs.webkit.org/show_bug.cgi?id=32097
3387
3388         * pywebsocket/mod_pywebsocket/dispatch.py:
3389         * pywebsocket/mod_pywebsocket/msgutil.py:
3390         * pywebsocket/mod_pywebsocket/standalone.py:
3391         * pywebsocket/mod_pywebsocket/util.py:
3392         * pywebsocket/setup.py:
3393         * pywebsocket/test/test_dispatch.py:
3394         * pywebsocket/test/test_util.py:
3395
3396 2009-12-03  Sam Weinig  <sam@webkit.org>
3397
3398         Reviewed by Gavin Barraclough.
3399
3400         Fix JSClassRef leak.
3401
3402         * DumpRenderTree/AccessibilityController.cpp:
3403         (AccessibilityController::makeWindowObject):
3404         * DumpRenderTree/GCController.cpp:
3405         (GCController::makeWindowObject):
3406         * DumpRenderTree/LayoutTestController.cpp:
3407         (LayoutTestController::makeWindowObject):
3408
3409 2009-12-03  Brady Eidson  <beidson@apple.com>
3410
3411         Reviewed by Sam Weinig.
3412
3413         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
3414
3415         Keep DRT-win building...
3416
3417         * DumpRenderTree/win/FrameLoadDelegate.h:
3418         (FrameLoadDelegate::didPushStateWithinPageForFrame):
3419         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
3420         (FrameLoadDelegate::didPopStateWithinPageForFrame):
3421
3422 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
3423
3424         Unreviewed build fix.
3425
3426         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
3427
3428         * DumpRenderTree/qt/DumpRenderTree.cpp:
3429
3430 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
3431
3432         Reviewed by Kenneth Rohde Christiansen.
3433
3434         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
3435         Prevent DRT from showing the main view if these childs get deleted.
3436         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
3437
3438         * DumpRenderTree/qt/DumpRenderTree.cpp:
3439         (WebCore::WebPage::WebPage):
3440         (WebCore::DumpRenderTree::DumpRenderTree):
3441         (WebCore::DumpRenderTree::~DumpRenderTree):
3442         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3443         (WebCore::DumpRenderTree::open):
3444         (WebCore::DumpRenderTree::closeRemainingWindows):
3445         (WebCore::DumpRenderTree::createWindow):
3446         (WebCore::DumpRenderTree::windowCount):
3447         * DumpRenderTree/qt/DumpRenderTree.h:
3448
3449 2009-12-02  Eric Seidel  <eric@webkit.org>
3450
3451         Reviewed by Adam Barth.
3452
3453         REGRESSION(51595): commit-queue is throwing exceptions
3454         https://bugs.webkit.org/show_bug.cgi?id=32083
3455
3456         * Scripts/modules/commands/queues.py:
3457          - Don't use default value of [] as it ends up getting shared.
3458          - Make log_progress accept arrays of ints as well as strings.
3459          - Return an exit code from execute()
3460         * Scripts/modules/commands/queues_unittest.py: Added.
3461          - Test to make sure log_progress will accept ints.
3462          - Test to make sure run_bugzilla_tool will accept ints.
3463         * Scripts/modules/workqueue.py:
3464          - Print the stack trace on unexpected exceptions for easier debugging.
3465         * Scripts/run-webkit-unittests:
3466          - Add queues_unittest.
3467
3468         * Scripts/modules/commands/queues.py:
3469         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
3470         * Scripts/modules/mock_bugzillatool.py:
3471         * Scripts/modules/workqueue.py:
3472         * Scripts/run-webkit-unittests:
3473
3474 2009-12-02  David Levin  <levin@chromium.org>
3475
3476         Reviewed by Adam Barth.
3477
3478         check-webkit-style is too noisy about namespace indenting issues.
3479         https://bugs.webkit.org/show_bug.cgi?id=32096
3480
3481         * Scripts/modules/cpp_style.py:
3482         Added a _FileState object to be able to track file level information. In this
3483         case, it simply tracks whether the error has already been given, so that it isn't
3484         done again.
3485         * Scripts/modules/cpp_style_unittest.py:
3486         Modified test cases to pass in the _FileState object and fix a test that expected
3487         to see the namespace error twice (now it only occurs once). No new tests because
3488         existing tests cover the change in functionality.
3489
3490 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3491
3492         Reviewed by Eric Seidel.
3493
3494         [wx] Get DumpRenderTree building after waf switch.
3495         
3496         https://bugs.webkit.org/show_bug.cgi?id=32041
3497
3498         * DumpRenderTree/wscript: Added.
3499         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3500         (LayoutTestController::setTimelineProfilingEnabled):
3501         (LayoutTestController::evaluateScriptInIsolatedWorld):
3502         (LayoutTestController::disableImageLoading):
3503         (LayoutTestController::whiteListAccessFromOrigin):
3504         (LayoutTestController::counterValueForElementById):
3505         * Scripts/build-webkit:
3506
3507 2009-12-02  Adam Barth  <abarth@webkit.org>
3508
3509         Reviewed by Eric Seidel.
3510
3511         [bzt] build-attachment shouldn't check whether the builders are red
3512         https://bugs.webkit.org/show_bug.cgi?id=32062
3513
3514         build-attachment doesn't touch the remote repository, so there isn't a
3515         need to hold off when the builders are red.
3516
3517         * Scripts/modules/commands/download.py:
3518         * Scripts/modules/landingsequence.py:
3519
3520 2009-12-02  Eric Seidel  <eric@webkit.org>
3521
3522         Reviewed by Adam Barth.
3523
3524         REGRESSION(51590): style-queue and build-queue think their empty when they are not
3525         https://bugs.webkit.org/show_bug.cgi?id=32061
3526
3527         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
3528         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
3529
3530 2009-12-02  Eric Seidel  <eric@webkit.org>
3531
3532         Reviewed by Adam Barth.
3533
3534         build-queue is throwing exceptions and complaining about
3535         lack of --no-update on build-attachment.  Make it stop.
3536
3537         * Scripts/modules/buildsteps.py:
3538         * Scripts/modules/commands/download.py:
3539
3540 2009-12-02  Adam Barth  <abarth@webkit.org>
3541
3542         Unreviewed "build" fix.  Forgot to declare my variables.  :(
3543
3544         * QueueStatusServer/queue_status.py:
3545
3546 2009-12-02  Adam Barth  <abarth@webkit.org>
3547
3548         Reviewed by Eric Seidel.
3549
3550         [bzt] Implement status bubble view
3551         https://bugs.webkit.org/show_bug.cgi?id=32057
3552
3553         The status bubble is a compact representation of the queue status for a
3554         given patch.  This will eventually help us reduce the comment spam from
3555         the queues.
3556
3557         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
3558         * QueueStatusServer/queue_status.py:
3559         * QueueStatusServer/status_bubble.html: Added.
3560
3561 2009-12-02  Eric Seidel  <eric@webkit.org>
3562
3563         Reviewed by Adam Barth.
3564
3565         trim commands/*.py includes now that commands are unit tested
3566         https://bugs.webkit.org/show_bug.cgi?id=32056
3567
3568         In the course of ensuring that the unit tests still
3569         passed after this change, I had to actually make them
3570         pass in the first place.
3571
3572         * Scripts/modules/bugzilla.py:
3573          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
3574         * Scripts/modules/commands/download.py: Remove unneeded imports.
3575         * Scripts/modules/commands/queries.py: Ditto.
3576         * Scripts/modules/commands/queues.py: Ditto.
3577         * Scripts/modules/commands/upload.py: Ditto.
3578         * Scripts/modules/scm_unittest.py:
3579          - Fix to expect the \n after the path since echo adds an \n.
3580
3581 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
3582
3583         build-webkit: Remove flex,bison,gperf check for chromium
3584         https://bugs.webkit.org/show_bug.cgi?id=32043
3585
3586         * Scripts/webkitdirs.pm:
3587
3588 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
3589
3590         Build fixage for Windows/GTK for DumpRenderTree.
3591
3592         WAI-ARIA: implement support for ARIA drag and drop
3593         https://bugs.webkit.org/show_bug.cgi?id=32007
3594
3595         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3596         (AccessibilityUIElement::ariaIsGrabbed):
3597         (AccessibilityUIElement::ariaDropEffects):
3598         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3599         (AccessibilityUIElement::ariaIsGrabbed):
3600         (AccessibilityUIElement::ariaDropEffects):
3601
3602 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
3603
3604         Reviewed by Darin Adler.
3605
3606         WAI-ARIA: implement support for ARIA drag and drop
3607         https://bugs.webkit.org/show_bug.cgi?id=32007
3608
3609         * DumpRenderTree/AccessibilityUIElement.cpp:
3610         (getARIADropEffectsCallback):
3611         (getARIAIsGrabbedCallback):
3612         (AccessibilityUIElement::getJSClass):
3613         * DumpRenderTree/AccessibilityUIElement.h:
3614         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3615         (AccessibilityUIElement::ariaIsGrabbed):
3616         (AccessibilityUIElement::ariaDropEffects):
3617
3618 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3619
3620         Not reviewed. GTK DRT try 2.
3621
3622         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3623         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3624
3625 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3626
3627         Not reviewed. Try to fix gtk DRT build.
3628
3629         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3630
3631 2009-12-01  David Levin  <levin@chromium.org>
3632
3633         Reviewed by Eric Seidel.
3634
3635         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
3636         https://bugs.we