34952a075572a09e2e3c8604f446f7c25f2388ab
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
2
3         Reviewed by Steve.
4
5         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
6         WebKit.
7
8         - Drosera and Safari need to use the same ProgIDs in order for
9         CoCreateInstance to work properly.  The most robust way to do this is
10         for WebKit to dynamically publish those ProgIDs.
11
12         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
13         (DebuggerClient::createWebViewWithRequest):
14         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
15         statics.
16         (Drosera::initUI):
17         (Drosera::attach):
18         (Drosera::attemptToCreateServerConnection):
19         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
20         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
21         make use of the published ProgIDs.
22         (ServerConnection::attemptToCreateServerConnection):
23
24 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
25
26         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
27         - Build bot and leak fix.
28
29         * DumpRenderTree/LayoutTestController.cpp:
30         (pathToLocalResourceCallback):
31
32 2007-12-19  David Kilzer  <ddkilzer@apple.com>
33
34         Make svn-apply/svn-unapply work with patches from git-format-patch.
35
36         Reviewed by Darin.
37
38         * Scripts/svn-apply:
39         (patch): If 'Index:' can't be found in the text passed in, print it
40         out with a warning and return early.
41         * Scripts/svn-unapply:
42         (patch): Ditto.
43
44 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
45
46         Reviewed by Alp Toker.
47
48         Build related fixes.
49
50         * wx/build-wxwebkit:
51         - Check to make sure the user is running a supported wx port
52         - More robust checks for Cygwin
53         - Only run install-unix-extras on Mac, it's not the right solution
54           for Linux distros.
55         - Remove outdated Linux instructions after successful build
56         - Clean Bakefile-generated files during a clean operation
57
58 2007-12-18  Darin Adler  <darin@apple.com>
59
60         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
61
62 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
63
64         Add script to run Drosera as part of the nightly.
65         
66         Reviewed by Kevin M.
67
68         * Scripts/run-drosera.cmd: Added.
69
70 2007-12-18  Darin Adler  <darin@apple.com>
71
72         * Scripts/do-webcore-rename: Remove a stray K.
73
74 2007-12-18  Darin Adler  <darin@apple.com>
75
76         * Scripts/do-webcore-rename: Plan more renaming.
77
78 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
79
80         Reviewed by Alp Toker.
81
82         http://bugs.webkit.org/show_bug.cgi?id=16042
83         [GTK] Eliminate webkit_init()
84
85         Moving webkit initialization to WebView class init.
86
87         * DumpRenderTree/gtk/DumpRenderTree.cpp:
88         (main):
89         * GtkLauncher/main.c:
90         (main):
91
92 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
93
94         Reviewed by Alp Toker.
95
96         http://bugs.webkit.org/show_bug.cgi?id=13542
97         gdklauncher doesnt change URL in adress GTKEntry.
98
99         * GtkLauncher/main.c:
100         (load_commit_cb): added
101         (title_change_cb):
102         (create_browser):
103
104 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
105
106         Reviewed by Adam Roben.
107
108         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
109
110         * FindSafari/FindSafari.cpp:
111         (_tmain):
112
113 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
114
115         Reviewed by Adam Roben.
116
117         http://bugs.webkit.org/show_bug.cgi?id=16315
118         FindSafari needs a path-only option.
119
120         * FindSafari/FindSafari.cpp:
121         (_tmain):
122
123 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
124
125         Reviewed by Darin.
126
127         http://bugs.webkit.org/show_bug.cgi?id=16462
128         REGRESSION: access keys broken on Windows
129
130         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
131         if Alt is pressed.
132
133 2007-12-15  Sam Weinig  <sam@webkit.org>
134
135         Reviewed by Mark Rowe.
136
137         Fix urlSuitableForTestResult to correctly identify wstring::npos as
138         the case when wstring.find doesn't find anything.
139
140         * DumpRenderTree/win/DumpRenderTree.cpp:
141         (urlSuitableForTestResult):
142
143 2007-12-15  Alp Toker  <alp@atoker.com>
144
145         GTK+ DRT build fix for GLib < 2.14.
146
147         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
148         (LayoutTestController::setWaitToDump):
149
150 2007-12-05  Mark Rowe  <mrowe@apple.com>
151
152         Reviewed by Alp Toker.
153
154         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
155         many layout tests from hanging while waiting on user responses to dialogs.
156
157         * DumpRenderTree/gtk/DumpRenderTree.cpp:
158         (invalidateAnyPreviousWaitToDumpWatchdog):
159         (webViewScriptAlert):
160         (webViewScriptPrompt):
161         (webViewScriptConfirm):
162         (main):
163         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
165         (waitToDumpWatchdogFired):
166         (LayoutTestController::setWaitToDump):
167
168 2007-12-05  Mark Rowe  <mrowe@apple.com>
169
170         Reviewed by Alp Toker.
171
172         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
173
174         * DumpRenderTree/gtk/DumpRenderTree.cpp:
175         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
176         (dump):
177         (runTest):
178         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
179         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
180         work queue is empty.
181         (webViewWindowObjectCleared): Set up window.layoutTestController.
182         (webViewConsoleMessage): Match the console message format expected by the layout test results.
183         (main): Hook up the new signals.
184         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
185         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
186         dumping multiple times.
187         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
188         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
189
190 2007-12-14  Anders Carlsson  <andersca@apple.com>
191
192         Reviewed by Brady.
193
194         Assert that a web frame that's loading a resource always has either a data source or 
195         a provisional data source.
196         
197         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
198         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
199
200 2007-12-14  Darin Adler  <darin@apple.com>
201
202         - fix mistake causing nearly all tests to fail on Windows
203
204         * DumpRenderTree/win/UIDelegate.cpp:
205         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
206         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
207
208         * DumpRenderTree/mac/UIDelegate.mm:
209         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
210         than passing the entire message.
211
212 2007-12-14  Darin Adler  <darin@apple.com>
213
214         - fix Tiger build
215
216         * DumpRenderTree/mac/UIDelegate.mm:
217         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
218         new-to-Leopard methods.
219
220 2007-12-14  Darin Adler  <darin@apple.com>
221
222         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
223         since it now triggers unwanted icon loading. We only had it because we implemented "all"
224         delegate methods here.
225
226 2007-12-14  Anders Carlsson  <andersca@apple.com>
227
228         Reviewed by Darin and Geoff.
229
230         <rdar://problem/5619295> 
231         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
232         
233         Add property getting methods to the plug-in.
234         
235         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
236         (pluginInvoke):
237
238 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
239
240         Reviewed by Darin.
241
242         - Layout test fix for mac. When dumped to the console local file paths
243         now only show the name of the resource not the whole path.  This is to
244         make the results machine and OS independent.
245
246         * DumpRenderTree/mac/UIDelegate.mm:
247         (-[UIDelegate webView:addMessageToConsole:]):
248
249 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
250
251         Reviewed by Adam.
252
253         - Layout tests fix.  We need a way to remove machine-dependent
254         information from paths in layout test results. The UIDelegate now does
255         this.
256
257         * DumpRenderTree/DumpRenderTree.h:
258         * DumpRenderTree/win/DumpRenderTree.cpp:
259         (urlSuitableForTestResult):
260         * DumpRenderTree/win/DumpRenderTreeWin.h:
261         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
262         * DumpRenderTree/win/UIDelegate.cpp:
263         (UIDelegate::webViewAddMessageToConsole):
264
265 2007-12-13  Alp Toker  <alp@atoker.com>
266
267         Build fix for DRT breakage introduced in r28690.
268
269         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
270         (LayoutTestController::pathToLocalResource):
271
272 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
273
274         Reviewed by Alice and Sam.
275
276         - <rdar://5621435> Need a way to specify local resources (being loaded
277         from HTTP tests) on Windows.
278         - Implemented pathToLocalResource which exposes the functionality of
279         converting a given unix path to the correct location on Windows.
280
281         * DumpRenderTree/LayoutTestController.cpp:
282         (pathToLocalResourceCallback):
283         (LayoutTestController::staticFunctions):
284         * DumpRenderTree/LayoutTestController.h:
285         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
286         (LayoutTestController::pathToLocalResource):
287         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
288         (LayoutTestController::pathToLocalResource):
289
290 2007-12-12  Anders Carlsson  <andersca@apple.com>
291
292         Reviewed by Sam.
293
294         <rdar://problem/5132003>
295         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
296
297         * DumpRenderTree/win/DumpRenderTree.cpp:
298         (main):
299         Set the resource load delegate.
300         
301         * DumpRenderTree/win/DumpRenderTree.vcproj:
302         
303         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
304         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
305
306 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
307
308         Reviewed by Adam Roben.
309
310         Fix conversion from double to LPARAM in dispatchMessage().
311
312         * DumpRenderTree/win/EventSender.cpp:
313         (dispatchMessageCallback):
314
315 2007-12-11  Dan Bernstein  <mitz@apple.com>
316
317         Reviewed by Mark Rowe and Sam Weinig too!
318
319         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
320           fonts DumpRenderTree registers.
321
322         * DumpRenderTree/win/DumpRenderTree.cpp:
323         (initialize):
324
325 2007-12-11  Brady Eidson  <beidson@apple.com>
326
327         Reviewed by Anders
328
329         Make DumpRenderTree on mac use its own path for Databases testing
330
331         * DumpRenderTree/mac/DumpRenderTree.mm:
332         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
333           for future DRT-only use, then use it to construct the Databases path and set that default
334
335 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
336
337         Reviewed by Darin.
338
339         <rdar://problem/5535636>
340         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
341
342         http://bugs.webkit.org/show_bug.cgi?id=13916
343         JavaScript detects Tab as a character input on a textfield validation
344
345         * DumpRenderTree/mac/EventSendingController.mm:
346         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
347         Dispatch a keyup to better match what happens when a key is physically pressed.
348
349         * DumpRenderTree/win/EventSender.cpp:
350         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
351         returning from keyDown().
352         (getConstantCallback): Fixed a couple copy/paste mistakes.
353
354 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
355
356         Reviewed by Oliver.
357
358         - <rdar://5599845> Drosera: Does not show loal files in the file list
359         on the left side.
360
361         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
362         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
363         so the open source community can build.
364
365 2007-12-10  Brady Eidson  <beidson@apple.com>
366
367         Rubberstamped by Sam Weinig
368
369         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
370
371         * DumpRenderTree/mac/UIDelegate.mm:
372         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
373         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
374
375 2007-12-08  Oliver Hunt  <oliver@apple.com>
376
377         Reviewed by Sam W.
378
379         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
380         
381         Fixes <rdar://problem/5620249> Must disable SVG animation
382         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
383         
384         In order to allow finer grained control over the set of SVG features
385         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
386         distinct flags:
387         ENABLE_SVG_ANIMATION
388         ENABLE_SVG_FILTERS
389         ENABLE_SVG_FONTS
390         ENABLE_SVG_AS_IMAGE
391         ENABLE_SVG_USE
392         
393         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
394         
395         Script handles all the new build flags, and allows --svg-experimental
396         to automatically enable all features.
397
398         * Scripts/build-webkit:
399
400 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
401
402         Fix version parsing.
403
404         Rubber-stamped by Oliver.
405
406         * Drosera/win/Drosera.vcproj/auto-version.sh:
407
408 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
409
410         Build modifications for Drosera.
411
412         Reviewed by Adam.
413
414         * Drosera/DroseraWin.make: Added.
415         * Drosera/win/Drosera.vcproj/Drosera.rc:
416         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
417         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
418         * Drosera/win/Drosera.vcproj/VERSION: Added.
419         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
420
421 2007-12-06  Adam Roben  <aroben@apple.com>
422
423         Explicitly turn on the Mac font ascent hack on Windows
424
425         This keeps our font metrics matching those from Mac.
426
427         Reviewed by Hyatt.
428
429         * DumpRenderTree/win/DumpRenderTree.cpp:
430         (main):
431
432 2007-12-06  Anders Carlsson  <andersca@apple.com>
433
434         Rename main.c to main.cpp here too.
435         
436         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
437
438 2007-12-06  Sam Weinig  <sam@webkit.org>
439
440         Rubber stamped by Geoff.
441
442         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
443
444 2007-12-06  Darin Adler  <darin@apple.com>
445
446         * Scripts/do-webcore-rename: Some more renaming plans.
447
448 2007-12-06  Anders Carlsson  <andersca@apple.com>
449
450         Restore implementation of testGetIntIdentifier that was accidentally
451         removed somehow (possibly when I made PluginObject be a cpp file).
452         
453         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
454         (pluginInvoke):
455
456 2007-12-05  Anders Carlsson  <andersca@apple.com>
457
458         Make the entry points extern "C".
459         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
460         
461 2007-12-05  Anders Carlsson  <andersca@apple.com>
462
463         C++ warning fixes.
464         
465         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
466         (NPP_New):
467         (NPP_Destroy):
468         (NPP_SetWindow):
469         (NPP_NewStream):
470         (NPP_HandleEvent):
471         (NPP_URLNotify):
472         (NPP_GetValue):
473
474 2007-12-05  Anders Carlsson  <andersca@apple.com>
475
476         Add the .cpp files to the TestNetscapePlugIn target.
477
478         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
479
480 2007-12-05  Anders Carlsson  <andersca@apple.com>
481
482         Reviewed by Geoff.
483         
484         Rename the TestNetscapePlugIn .c files to be .cpp.
485
486         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
487         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
488         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
489         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
490         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
491         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
492         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
493         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
494
495 2007-12-05  Adam Roben  <aroben@apple.com>
496
497         Fix case of keypresses from the Windows implementation of eventSender.keyDown
498
499         This fixes several regression tests.
500
501         Reviewed by Alice.
502
503         * DumpRenderTree/win/EventSender.cpp:
504         (keyDownCallback): Virtual keycodes for ASCII characters are always
505         uppercase, so we need to check the case of the original character
506         passed in to eventSender.keyDown.
507
508 2007-12-05  Adam Roben  <aroben@apple.com>
509
510         Learn from Tim's mistakes
511
512         * DumpRenderTree/win/DumpRenderTree.cpp:
513         (runTest): Reset the authorAndUserStylesEnabled preference for each
514         test.
515
516 2007-12-05  Alp Toker  <alp@atoker.com>
517
518         Reviewed by Mark Rowe.
519
520         Initialize GTK+ and WebKit so the tests can run.
521
522         Reorganize the headers a little.
523
524         * DumpRenderTree/gtk/DumpRenderTree.cpp:
525         (main):
526
527 2007-12-04  Anders Carlsson  <andersca@apple.com>
528
529         Remove IWebScriptScope include.
530         
531         * Drosera/win/DebuggerDocumentPlatform.cpp:
532
533 2007-12-04  Sam Weinig  <sam@webkit.org>
534
535         Rubber stamped by Mark Rowe.
536
537         Define CF as platform for mac and revert r28409
538
539         * DumpRenderTree/DumpRenderTree.h:
540         * DumpRenderTree/mac/DumpRenderTreeMac.h:
541
542 2007-12-04  Sam Weinig  <sam@webkit.org>
543
544         Define CF as platform for windows.
545
546         Reviewed by Adam Roben.
547
548         * DumpRenderTree/win/DumpRenderTreeWin.h:
549
550 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
551
552         Reviewed by Adam and Darin.
553
554         - Removed a needless BSTR cleanup.
555
556         * Drosera/win/DebuggerDocumentPlatform.cpp:
557         (DebuggerDocument::getPlatformCurrentFunctionStack):
558
559 2007-11-27  Adam Roben  <aroben@apple.com>
560
561         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
562
563         Reviewed by Maciej.
564
565         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
566         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
567
568 2007-12-04  Alp Toker  <alp@atoker.com>
569
570         Prospective Win DRT build fix.
571
572         * DumpRenderTree/DumpRenderTree.h:
573
574 2007-12-04  Alp Toker  <alp@atoker.com>
575
576         Fix a clobbered copyright header.
577
578         * DumpRenderTree/gtk/DumpRenderTree.cpp:
579
580 2007-12-04  Xan Lopez  <xan@gnome.org>
581
582         Reviewed by Alp Toker.
583
584         http://bugs.webkit.org/show_bug.cgi?id=15561
585         GTK port needs DumpRenderTree implementation
586
587         Start work on the GTK+ DRT.
588
589         This does not work yet, and there are a few lingering style issues
590         (nothing major) but this patch has been stuck in the bug tracker for
591         too long already.
592
593         * DumpRenderTree/DumpRenderTree.h:
594         * DumpRenderTree/gtk: Added.
595         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
596         (autocorrectURL):
597         (shouldLogFrameLoadDelegates):
598         (dumpFrameScrollPosition):
599         (displayWebView):
600         (appendString):
601         (dumpFramesAsText):
602         (dumpRenderTreeAsText):
603         (dump):
604         (runTest):
605         (main):
606         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
607         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
608         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
609         (GCController::collect):
610         (GCController::collectOnAlternateThread):
611         (GCController::getJSObjectCount):
612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
613         (LayoutTestController::~LayoutTestController):
614         (LayoutTestController::addDisallowedURL):
615         (LayoutTestController::clearBackForwardList):
616         (LayoutTestController::copyDecodedHostName):
617         (LayoutTestController::copyEncodedHostName):
618         (LayoutTestController::display):
619         (LayoutTestController::keepWebHistory):
620         (LayoutTestController::notifyDone):
621         (LayoutTestController::queueBackNavigation):
622         (LayoutTestController::queueForwardNavigation):
623         (LayoutTestController::queueLoad):
624         (LayoutTestController::queueReload):
625         (LayoutTestController::queueScript):
626         (LayoutTestController::setAcceptsEditing):
627         (LayoutTestController::setCustomPolicyDelegate):
628         (LayoutTestController::setMainFrameIsFirstResponder):
629         (LayoutTestController::setTabKeyCyclesThroughElements):
630         (LayoutTestController::setUseDashboardCompatibilityMode):
631         (LayoutTestController::setUserStyleSheetEnabled):
632         (LayoutTestController::setUserStyleSheetLocation):
633         (LayoutTestController::setWindowIsKey):
634         (LayoutTestController::setWaitToDump):
635         (LayoutTestController::windowCount):
636         (LayoutTestController::setPrivateBrowsingEnabled):
637         (LayoutTestController::setAuthorAndUserStylesEnabled):
638         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
639         (JSStringCopyUTF8CString):
640         (LoadItem::invoke):
641         (ReloadItem::invoke):
642         (ScriptItem::invoke):
643         (BackForwardItem::invoke):
644
645 2007-12-03  Sam Weinig  <sam@webkit.org>
646
647         Move JavaScriptCore thread testing code to pthread specific directory
648         and remove the dependance on CoreFoundation by using WTF::HashSet.
649
650         Reviewed by Geoff and Oliver.
651
652         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
653         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
654         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
655         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
656         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
657         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
658         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
659         * DumpRenderTree/pthreads: Added.
660         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
661         (javaScriptThreads):
662         (runJavaScriptThread):
663         (startJavaScriptThreads):
664         (stopJavaScriptThreads):
665
666 2007-12-03  Andrew Bonventre  <andybons@google.com>
667
668         Reviewed by Darin Adler.
669
670         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
671         Symbol lookup menu broken in debugger view
672
673         * Drosera/debugger.js: Fixed javascript error where document property
674         should have been used instead of contentDocument in switchFunction that
675         was breaking the select symbol dropdown menu.  This is because
676         window.frames will return a Window object and not a frame object like
677         the author was originally expecting.
678
679 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
680
681         Reviewed by Adam.
682
683         - <rdar://5618942> Drosera: Console window does not process everything
684         correctly.
685         - <rdar://5619005> Drosera: could be sped up by moving the 
686         WebScriptScope stuff into the WebScriptCallFrame.
687         - Now the console can correctly process objects and does not receive
688         notifications from JavaScriptCore about the JavaScript in Drosera's
689         own process.
690
691         * Drosera/win/DebuggerDocumentPlatform.cpp:
692         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
693         (DebuggerDocument::platformValueForScopeVariableNamed):
694
695 2007-12-03  Stephanie  <slewis@apple.com>
696
697         Reviewed by Darin.
698
699         Check to see if we are building a debug root
700
701         * Scripts/check-for-global-initializers: 
702
703 2007-12-03  Dan Bernstein  <mitz@apple.com>
704
705         Reviewed by Darin Adler.
706
707         - added a testGetIntIdentifier() method to TestNetscapePlugIn
708
709         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
710         (pluginInvoke):
711
712 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
713
714         Reviewed by Oliver.
715
716         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
717         in a more fine-grained manner than eventSender.keyDown().
718
719         * DumpRenderTree/win/EventSender.cpp:
720         (getConstantCallback):
721         (dispatchMessageCallback):
722
723 2007-12-02  Darin Adler  <darin@apple.com>
724
725         * Scripts/do-webcore-rename: More planned renaming.
726
727 2007-12-02  Sam Weinig  <sam@webkit.org>
728
729         Rubber stamped by Anders.
730
731         Use [NSURL absoluteString] instead of [NSURL description] in order to get
732         more uniform results cross platform.
733
734         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
735         (-[NSURL _drt_descriptionSuitableForTestResult]):
736
737 2007-12-02  Sam Weinig  <sam@webkit.org>
738
739         Rubber stamped by Niko.
740
741         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
742
743         * DumpRenderTree/win/DumpRenderTree.cpp:
744         * DumpRenderTree/win/DumpRenderTree.vcproj:
745         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
746         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
747         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
748         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
749
750 2007-12-01  Alp Toker  <alp@atoker.com>
751
752         Reviewed by Adam Roben.
753
754         Make use of the newly introduced webkit.h convenience header.
755
756         * GtkLauncher/main.c:
757
758 2007-12-01  Adam Treat  <treat@kde.org>
759
760         Reviewed by Simon.
761
762         * Check to see if the directory exists and exit if not.
763
764         * DumpRenderTree/qt/main.cpp:
765         (main):
766
767 2007-12-01  Adam Treat  <treat@kde.org>
768
769         Reviewed by Simon.
770
771         * Don't hide symbols when in Debug mode
772         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
773
774
775         * DumpRenderTree/qt/main.cpp:
776         (messageHandler):
777
778 2007-11-30  Alp Toker  <alp@atoker.com>
779
780         Reviewed by Adam Roben.
781
782         http://bugs.webkit.org/show_bug.cgi?id=15691
783         [GTK] Public API does not follow GTK+ conventions
784
785         Refactor the WebKit/GTK+ public API. Changes:
786           WebKitPage -> WebKitWebView
787           WebKitFrame -> WebKitWebFrame
788
789         Public API source and header names have been updated to mirror the API
790         changes.
791
792         The API is now kept in WebKit/gtk/WebView to match other ports in the
793         same class such as Mac and Win.
794
795         * GtkLauncher/main.c:
796         (activate_uri_entry_cb):
797         (link_hover_cb):
798         (title_change_cb):
799         (progress_change_cb):
800         (go_back_cb):
801         (go_forward_cb):
802         (create_browser):
803         (main):
804
805 2007-11-30  Adam Roben  <aroben@apple.com>
806
807         Hopefully the final build fix
808
809         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
810         pull in WTF's assertion/logging functions.
811
812 2007-11-30  Adam Roben  <aroben@apple.com>
813
814         Another build fix
815
816         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
817         WebKit.lib.
818
819 2007-11-30  Adam Roben  <aroben@apple.com>
820
821         Debug build fix
822
823         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
824         configuration.
825         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
826         projects.
827         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
828         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
829         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
830
831 2007-11-30  Sam Weinig  <sam@webkit.org>
832
833         Reviewed by Adam Roben.
834
835         Fix drawSelectionRect to actually draw the selection rect.
836
837         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
838         (drawSelectionRect):
839
840 2007-11-30  Darin Adler  <darin@apple.com>
841
842         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
843
844 2007-11-30  Darin Adler  <darin@apple.com>
845
846         * Scripts/do-webcore-rename: Get ready for some future renaming.
847
848 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
849
850         Reviewed by Adam.
851
852         - Removed some unnecessary functions and changed an unused return type. 
853
854         * Drosera/win/DebuggerClient.cpp:
855         (registerConsoleClass):
856         * Drosera/win/DebuggerClient.h:
857         * Drosera/win/Drosera.cpp:
858         (registerDroseraClass):
859
860 2007-11-28  Alp Toker  <alp@atoker.com>
861
862         Reviewed by Timothy Hatcher.
863
864         http://bugs.webkit.org/show_bug.cgi?id=16174
865         [GTK] Use "URI" not "URL" in public API
866
867         Replace use of the term "URL" with "URI" in public headers,
868         documentation and some internal code to match GLib/GTK+ convention.
869
870         This is now mentioned in the API guidelines:
871           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
872
873         * GtkLauncher/main.c:
874         (activate_uri_entry_cb):
875         (title_change_cb):
876         (create_toolbar):
877         (main):
878
879 2007-11-29  Anders Carlsson  <andersca@apple.com>
880
881         Reviewed by Sam.
882
883         <rdar://problem/5230478>
884         FrameLoadDelegate callbacks are not dumped in DRT.
885         
886         * DumpRenderTree/win/DumpRenderTree.cpp:
887         (shouldLogFrameLoadDelegates):
888         (runTest):
889         (main):
890         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
891         (BSTRtoString):
892         (descriptionSuitableForTestResult):
893         (FrameLoadDelegate::QueryInterface):
894         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
895         (FrameLoadDelegate::didFailProvisionalLoadWithError):
896         (FrameLoadDelegate::didCommitLoadForFrame):
897         (FrameLoadDelegate::didFinishLoadForFrame):
898         (FrameLoadDelegate::willCloseFrame):
899         (FrameLoadDelegate::didClearWindowObject):
900         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
901         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
902         * DumpRenderTree/win/FrameLoaderDelegate.h:
903         (FrameLoadDelegate::windowScriptObjectAvailable):
904         (FrameLoadDelegate::didFirstLayoutInFrame):
905
906 2007-11-29  Sam Weinig  <sam@webkit.org>
907
908         Reviewed by Anders.
909
910         Add database quota UIDelegates methods to DRT UIDelegate.
911
912         * DumpRenderTree/mac/UIDelegate.mm:
913         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
914         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
915
916 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
917
918         Reviewed by Sam.
919
920         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
921         dying and vice versa.
922         - This fix will allow Drosera and Safari to reconnect if either of them
923         closes correctly, but does not fix the case where one of them dies
924         silently.
925
926         * Drosera/win/ServerConnection.cpp:
927         (ServerConnection::attemptToCreateServerConnection): Added a safety
928         check, because it's possilbe to try to connect to a server that's dying.
929         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
930         the server has died.
931         * Drosera/win/ServerConnection.h: Added the new function and removed
932         an unnecessary member.
933
934 2007-11-29  Anders Carlsson  <andersca@apple.com>
935
936         * DumpRenderTree/win/DumpRenderTree.vcproj:
937         Add shlwapi.lib to all configurations.
938
939 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
940
941         - Build fix.  Added additional includes for VS Express to the Release
942         project.
943
944         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
945
946 2007-11-29  Anders Carlsson  <andersca@apple.com>
947
948         Reviewed by Adam.
949
950         <rdar://problem/5132005>
951         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
952         
953         * DumpRenderTree/win/DumpRenderTree.vcproj:
954         Add shlwapi.lib
955         
956         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
957         (LayoutTestController::setUserStyleSheetEnabled):
958         Implement this.
959         
960         (appendComponentToPath):
961         New method which wraps the Win32 API PathAppend.
962         
963         (followShortcuts):
964         New method which checks if a file points to a shortcut and
965         follows the shortcut.
966         
967         (resolveCygwinPath):
968         New method that takes a cygwin unix-style path and returns the Win32 path.
969         
970         (cfStringRefToWString):
971         
972         (LayoutTestController::setUserStyleSheetLocation):
973         Implement this.
974
975 2007-11-29  Alice Liu  <alice.liu@apple.com>
976
977         Reviewed by Adam.
978
979         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
980
981         * DumpRenderTree/win/EventSender.cpp:
982         (keyDownCallback):
983         uppercase letters were being sent as lowercase letters without the shift key down.
984
985 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
986
987         - Windows build fix. VS express needs some love.
988
989         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
990
991 2007-11-28  Darin Adler  <darin@apple.com>
992
993         Reviewed by Adam Roben.
994
995         * DumpRenderTree/mac/EventSendingController.mm:
996         (-[EventSendingController keyDown:withModifiers:]):
997         Send capital letters through as lowercase letters with the shift key down
998         rather than sending them as if they were highly unusual "capital letter keys".
999
1000         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1001         where you need to update results and more tests are failing than before.
1002
1003 2007-11-28  Anders Carlsson  <andersca@apple.com>
1004
1005         Reviewed by Darin.
1006
1007         <rdar://problem/5132001>
1008         contextClick is not implemented in DRT on Windows.
1009         
1010         * DumpRenderTree/win/EventSender.cpp:
1011         (contextClickCallback):
1012         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1013         by a WM_RBUTTONUP message.
1014         
1015         * DumpRenderTree/win/UIDelegate.cpp:
1016         (UIDelegate::hasCustomMenuImplementation):
1017         (UIDelegate::trackCustomPopupMenu):
1018         * DumpRenderTree/win/UIDelegate.h:
1019         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1020         menu from being shown (and causing the DRT to hang).
1021
1022 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1023
1024         Reviewed by Darin.
1025
1026         Fix DumpRenderTree ObjC bug comparing strings.
1027
1028         * DumpRenderTree/mac/ObjCController.m:
1029         (-[ObjCController identityIsEqual::]): Compare strings with string
1030         equality instead of identiy equality.
1031
1032 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1033
1034         Reviewed by Sam.
1035
1036         Reset the authorAndUserStylesEnabled preference
1037         back to YES for each test. Fixes the broken tests.
1038
1039         * DumpRenderTree/mac/DumpRenderTree.mm:
1040         (resetWebViewToConsistentStateBeforeTesting):
1041
1042 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1043
1044         Reviewed by Adam.
1045
1046         - Drosera now displays the console window, although it cannot currently
1047         process JavaScript.
1048
1049         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1050         (registerConsoleClass): Implemented.
1051         (consoleWndProc): Implemented.
1052         (DebuggerClient::onSize): Implemented.
1053         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1054         new window.
1055         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1056         creating and maintaining a new window.
1057         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1058         lines of code to more appropriate places.
1059         (Drosera::handleCommand):
1060         (Drosera::initUI):
1061         (Drosera::onSize):
1062         (Drosera::attach):
1063
1064 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1065
1066         Reviewed by Dave Hyatt.
1067
1068         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1069         
1070         Add support for disabling author and user styles for testing.
1071
1072         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1073         * DumpRenderTree/LayoutTestController.cpp:
1074         (setAuthorAndUserStylesEnabledCallback):
1075         (LayoutTestController::staticFunctions):
1076         * DumpRenderTree/LayoutTestController.h:
1077         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1078         (LayoutTestController::setAuthorAndUserStylesEnabled):
1079         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1080         (LayoutTestController::setAuthorAndUserStylesEnabled):
1081
1082 2007-11-26  Dan Bernstein  <mitz@apple.com>
1083
1084         - Tiger build fix.
1085
1086         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1087
1088 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1089
1090         Reviewed by Maciej.
1091
1092         - Implemented displaying variables for Drosera on Win.
1093
1094         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1095         that retrieve variables to not hold onto the return value since it's
1096         not returned.  Also changed to use the new signatures of the retrieval
1097         functions.
1098         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1099         (DebuggerDocument::platformValueForScopeVariableNamed):
1100         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1101         (droseraWndProc):
1102
1103 2007-11-26  Sam Weinig  <sam@webkit.org>
1104
1105         Cleanup names of painting and repainting functions.
1106
1107         Reviewed by Adam Roben.
1108
1109         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1110         (drawSelectionRect): was drawSelectionRectIntoContext.
1111         (dumpWebViewAsPixelsAndCompareWithExpected):
1112         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1113         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1114         (paintWebView): was drawWebViewIntoContext.
1115         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1116
1117 2007-11-26  Sam Weinig  <sam@webkit.org>
1118
1119         Reviewed by Dan Bernstein.
1120
1121         - Leopard build fix
1122
1123         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1124
1125 2007-11-26  Sam Weinig  <sam@webkit.org>
1126
1127         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1128         Use shared PixelDumpSupport for Mac DRT
1129
1130         Reviewed by Adam Roben.
1131
1132         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1133         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1134         * DumpRenderTree/cg/ImageDiffCG.cpp:
1135         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1136         (drawSelectionRectIntoContext):
1137         (dumpWebViewAsPixelsAndCompareWithExpected):
1138         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1139         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1140         * DumpRenderTree/mac/DumpRenderTree.mm:
1141         (dump):
1142         * DumpRenderTree/mac/ImageDiff.m: Removed.
1143         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1144         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1145         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1146         (setDefaultColorProfileToRGB):
1147         (getBitmapContextFromWebView):
1148         (drawWebViewIntoContext):
1149         (repaintWithVerticalSweep):
1150         (repaintWithHorizontalSweep):
1151         (getSelectionRect):
1152         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1153
1154 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1155
1156         Bug 16052: prepare-ChangeLog doesn't report deleted files
1157         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1158
1159         Reviewed by Sam.
1160
1161         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1162
1163 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1164
1165         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1166         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1167
1168         Reviewed by Adam.
1169
1170         Roll functionality of merge-changelog into resolve-ChangeLogs
1171         script.  The script now checks for ChangeLog.rej and
1172         ChangeLog.orig files first.  If it finds them, it uses the
1173         ChangeLog.rej file as a patch (in old contextual diff format) to
1174         apply with --fuzz=3.
1175
1176         * Scripts/merge-changelog: Removed.
1177         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1178
1179 2007-11-25  Sam Weinig  <sam@webkit.org>
1180
1181         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1182
1183         Reviewed by Mark Rowe.
1184
1185         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1186         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1187         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1188         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1189         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1190
1191 2007-11-25  Sam Weinig  <sam@webkit.org>
1192
1193         Convert DumpRenderTree to ues .xcconfig files.
1194
1195         Reviewed by Mark Rowe.
1196
1197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1198         * DumpRenderTree/mac/Configurations: Added.
1199         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1200         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1201         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1202
1203 2007-11-25  Sam Weinig  <sam@webkit.org>
1204
1205         Add ForwardingHeaders to wtf for DumpRenderTree.
1206
1207         Reviewed by Mark Rowe.
1208
1209         * DumpRenderTree/DumpRenderTree.h:
1210         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1211         * DumpRenderTree/ForwardingHeaders: Added.
1212         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1213         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1214         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1215         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1216         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1217         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1218         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1219         * DumpRenderTree/LayoutTestController.cpp:
1220         * DumpRenderTree/WorkQueue.cpp:
1221         * DumpRenderTree/mac/DumpRenderTree.mm:
1222         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1223         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1224         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1225         * DumpRenderTree/mac/ObjCController.m:
1226         * DumpRenderTree/mac/UIDelegate.mm:
1227         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1228
1229 2007-11-25  Adam Roben  <aroben@apple.com>
1230
1231         Fix some test failures caused by r28019
1232
1233         Now that stdout is in binary mode, we need to always use printf
1234         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1235         the output.
1236
1237         Reviewed by Sam.
1238
1239         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1240         printf.
1241         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1242         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1243         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1244         (UIDelegate::webViewAddMessageToConsole):
1245
1246 2007-11-25  Adam Roben  <aroben@apple.com>
1247
1248         Set the font smoothing preference in DRT
1249
1250         This makes the pixel results on Windows closer to the Mac results.
1251
1252         Reviewed by Mitz.
1253
1254         * DumpRenderTree/win/DumpRenderTree.cpp:
1255         (initializePreferences):
1256
1257 2007-11-25  Adam Roben  <aroben@apple.com>
1258
1259         Port ImageDiff to CG and C++
1260
1261         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1262         <rdar://5071708>
1263
1264         Reviewed by Sam.
1265
1266         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1267         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1268         (main):
1269         (createImageFromStdin):
1270         (compareImages):
1271         (getDifferenceBitmap):
1272         (computePercentageDifferent):
1273         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1274
1275 2007-11-25  Adam Roben  <aroben@apple.com>
1276
1277         Fix image diff link generation on Windows
1278
1279         Reviewed by Sam.
1280
1281         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1282         to toURL.
1283
1284 2007-11-25  Adam Roben  <aroben@apple.com>
1285
1286         Implement pixel dumping in Windows DRT
1287
1288         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1289         <rdar://5071708>
1290
1291         Reviewed by Sam.
1292
1293         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1294         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1295         Content-Length header.
1296         (getMD5HashStringForBitmap):
1297         (dumpWebViewAsPixelsAndCompareWithExpected):
1298         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1299         * DumpRenderTree/win/DumpRenderTree.cpp:
1300         (dump): Do a pixel dump if requested.
1301         (main): Parse pixel test options.
1302         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1303         the cg/ subdirectory to the include path.
1304         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1305         available in a header or import library, so we have to go through this
1306         LoadLibrary/GetProcAddress dance to use them.
1307         (cryptDLL):
1308         (init):
1309         (update):
1310         (final):
1311         (MD5_Init):
1312         (MD5_Update):
1313         (MD5_Final):
1314         * DumpRenderTree/win/MD5.h: Added.
1315         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1316         moved up to the top level to share it with Mac eventually.
1317         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1318         (getBitmapContextFromWebView): Forces the WebView to paint using a
1319         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1320
1321 2007-11-25  Adam Roben  <aroben@apple.com>
1322
1323         Clean up Windows DRT's option parsing a little bit
1324
1325         Reviewed by Sam.
1326
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328         (main): Put non-option arguments into a Vector.
1329
1330 2007-11-25  Adam Roben  <aroben@apple.com>
1331
1332         Make Windows DRT stop changing LF into CRLF
1333
1334         Reviewed by Sam.
1335
1336         * DumpRenderTree/win/DumpRenderTree.cpp:
1337         (main): Put stdout in binary mode.
1338         * Scripts/run-webkit-tests: Remove the CRLF hack.
1339
1340 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1341
1342         Removed empty directory.
1343
1344         * Scripts/resources: Removed.
1345
1346 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1347
1348         Fix bisect-builds to work with recent WebKit nightly builds.
1349
1350         Reviewed by Dan.
1351
1352         * Scripts/bisect-builds: Check for the 
1353         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1354         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1355         to WebKit.app/Contents/Resources.
1356
1357 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1358
1359         Reviewed by Maciej.
1360
1361         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1362         not closed (affects digg.com)
1363
1364         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1365         one after finishing with a test to avoid having its delayed onload handler firing when
1366         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1367         but it helps somewhat.
1368
1369 2007-11-22  Mark Rowe  <mrowe@apple.com>
1370
1371         Reviewed by Alp Toker.
1372
1373         Fix build-webkit to propagate make's exit status if it fails.
1374
1375         * Scripts/webkitdirs.pm:
1376
1377 2007-11-22  Dan Bernstein  <mitz@apple.com>
1378
1379         Reviewed by Mark Rowe.
1380
1381         - fix crash when running pixel tests
1382
1383         * DumpRenderTree/mac/DumpRenderTree.mm:
1384         (dumpRenderTree): Parse the command line options before setting up the
1385         environment so that we know if we need to set up the pixel dump
1386         machinery.
1387
1388 2007-11-21  Eric Seidel  <eric@webkit.org>
1389
1390         Speculative build fix for Tiger.
1391
1392         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1393
1394 2007-11-21  Eric Seidel  <eric@webkit.org>
1395
1396         Reviewed by Tim Hatcher.
1397
1398         Break out more of DumpRenderTree.mm into individual files
1399
1400         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1401         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1402         (checkedMalloc):
1403         (checkedRealloc):
1404         (makeLargeMallocFailSilently):
1405         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1406         * DumpRenderTree/mac/DumpRenderTree.mm:
1407         (crashHandler):
1408         (dump):
1409         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1410         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1411         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1412         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1413         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1414         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1415         (javaScriptThreads):
1416         (runJavaScriptThread):
1417         (startJavaScriptThreads):
1418         (stopJavaScriptThreads):
1419         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1420         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1421         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1422         (restoreColorSpace):
1423         (setDefaultColorProfileToRGB):
1424         (initializeColorSpaceAndScreeBufferForPixelTests):
1425         (md5HashStringForBitmap):
1426         (dumpWebViewAsPixelsAndCompareWithExpected):
1427
1428 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1429
1430         Move install-unix-extras to wx directory as it seems only to be used by that 
1431         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1432         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1433         have install-unix-extras install into WebKitLibraries as per
1434         convention.
1435         
1436         Reviewed by Mark Rowe.
1437
1438         * Scripts/install-unix-extras: Removed.
1439         * wx/build-wxwebkit:
1440         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1441
1442 2007-11-21  Eric Seidel  <eric@webkit.org>
1443
1444         Reviewed by Adam.
1445
1446         More refactoring for greater code readability
1447
1448         * DumpRenderTree/mac/DumpRenderTree.mm:
1449         (initializeGlobalsFromCommandLineOptions):
1450         (initializeColorSpaceAndScreeBufferForPixelTests):
1451         (addTestPluginsToPluginSearchPath):
1452         (useLongRunningServerMode):
1453         (runTestingServerLoop):
1454         (prepareConsistentTestingEnvironment):
1455         (dumpRenderTree):
1456         (main):
1457         (dumpFramesAsText):
1458         (dumpBackForwardListForWebView):
1459         (sizeWebViewForCurrentTest):
1460         (methodNameStringForFailedTest):
1461         (dumpBackForwardListForAllWindows):
1462         (dumpWebViewAsPixelsAndCompareWithExpected):
1463         (invalidateAnyPreviousWaitToDumpWatchdog):
1464         (dump):
1465         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1466         * DumpRenderTree/mac/UIDelegate.mm:
1467         (-[UIDelegate webView:createWebViewWithRequest:]):
1468
1469 2007-11-21  Eric Seidel  <eric@webkit.org>
1470
1471         Reviewed by Tim Hatcher.
1472
1473         Abstract more of DRT into static methods
1474
1475         * DumpRenderTree/mac/DumpRenderTree.mm:
1476         (setDefaultsToConsistentValuesForTesting):
1477         (setupSignalHandlers):
1478         (allocateGlobalControllers):
1479         (releaseAndZero):
1480         (releaseGlobalControllers):
1481         (dumpRenderTree):
1482         (shouldLogFrameLoadDelegates):
1483         (createCFURLFromPathOrURL):
1484         (resetWebViewToConsistentStateBeforeTesting):
1485         (runTest):
1486
1487 2007-11-21  Eric Seidel  <eric@webkit.org>
1488
1489         Reviewed by Tim Hatcher.
1490
1491         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1492
1493         * DumpRenderTree/DumpRenderTree.h:
1494         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1495         * DumpRenderTree/mac/DumpRenderTree.mm:
1496         (dumpRenderTree):
1497         (dump):
1498         (runTest):
1499         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1500         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1501         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1502         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1503         (-[DumpRenderTreePasteboard declareType:owner:]):
1504         (+[LocalPasteboard alloc]):
1505         (-[LocalPasteboard init]):
1506         (-[LocalPasteboard dealloc]):
1507         (-[LocalPasteboard name]):
1508         (-[LocalPasteboard releaseGlobally]):
1509         (-[LocalPasteboard declareTypes:owner:]):
1510         (-[LocalPasteboard addTypes:owner:]):
1511         (-[LocalPasteboard changeCount]):
1512         (-[LocalPasteboard types]):
1513         (-[LocalPasteboard availableTypeFromArray:]):
1514         (-[LocalPasteboard setData:forType:]):
1515         (-[LocalPasteboard dataForType:]):
1516         (-[LocalPasteboard setPropertyList:forType:]):
1517         (-[LocalPasteboard setString:forType:]):
1518         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1519         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1520         (+[DumpRenderTreeWindow allWindows]):
1521         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1522         (-[DumpRenderTreeWindow dealloc]):
1523         (-[DumpRenderTreeWindow isKeyWindow]):
1524         (-[DumpRenderTreeWindow keyDown:]):
1525
1526 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1527
1528         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1529         it indiscriminately copies any headers inside JavaScriptCore,
1530         which includes Tiger ICU headers. 
1531
1532         * wx/build-wxwebkit:
1533         Don't run WebCore/move-js-headers.sh any longer.
1534
1535 2007-11-20  Adam Treat  <treat@kde.org>
1536
1537         Reviewed by David Kilzer.
1538
1539         * Prepend git branch name to $baseProductDir
1540
1541         * Scripts/VCSUtils.pm:
1542         * Scripts/webkitdirs.pm:
1543
1544 2007-11-20  Mark Rowe  <mrowe@apple.com>
1545
1546         Reviewed by Simon Hausmann.
1547
1548         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1549         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1550         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1551         built product and generated Makefile's are removed.
1552
1553 2007-11-19  Alp Toker  <alp@atoker.com>
1554
1555         Reviewed by Mark Rowe.
1556
1557         http://bugs.webkit.org/show_bug.cgi?id=16040
1558         [GTK] GtkLauncher should be written in C
1559
1560         Port GtkLauncher to plain C.
1561
1562         Use a more conventional GTK+ coding style.
1563
1564         Use a toolbar instead of menus.
1565
1566         Various signature fixes and cleanups.
1567
1568         Add a license header. Assume all previous modifications were copyright
1569         assigned to Apple Inc. by default.
1570
1571         * GtkLauncher/GtkLauncher.pro:
1572         * GtkLauncher/main.c: Added.
1573         (activate_url_entry_cb):
1574         (update_title):
1575         (link_hover_cb):
1576         (title_change_cb):
1577         (progress_change_cb):
1578         (destroy_cb):
1579         (go_back_cb):
1580         (go_forward_cb):
1581         (create_browser):
1582         (create_statusbar):
1583         (create_toolbar):
1584         (create_window):
1585         (main):
1586         * GtkLauncher/main.cpp: Removed.
1587
1588 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1589
1590         Build script fixes to ensure they do the right thing for the 
1591         wx port, and update build-wxwebkit to reflect the way the
1592         build scripts now work.
1593
1594         Reviewed by Adam.
1595
1596         * Scripts/build-testkjs:
1597         * Scripts/build-webkit:
1598         * Scripts/run-javascriptcore-tests:
1599         * Scripts/webkitdirs.pm:
1600         * wx/build-wxwebkit:
1601
1602 2007-11-18  Eric Seidel  <eric@webkit.org>
1603
1604         Reviewed by Anders.
1605
1606         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1607
1608         * Scripts/run-javascriptcore-tests:
1609
1610 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1611
1612         Reviewed by Adam Roben.
1613
1614         Make run-webkit-tests work with Windows debug build.
1615
1616         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1617         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1618         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1619         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1620         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1621
1622 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1623
1624         Add wxWebKit sample and build script, and integrate it with 
1625         build-webkit. Also make build-webkit --clean work for all
1626         ports.
1627
1628         Reviewed by Darin Adler.
1629
1630         * Scripts/build-webkit:
1631         * Scripts/webkitdirs.pm:
1632         * wx: Added.
1633         * wx/browser: Added.
1634         * wx/browser/browser.bkl: Added.
1635         * wx/browser/browser.cpp: Added.
1636         * wx/build-wxwebkit: Added.
1637
1638 2007-11-17  Adam Roben  <aroben@apple.com>
1639
1640         Make it easy to run Safari in the debugger on Windows
1641
1642         I've added a new script, debug-safari, which launches Safari in the
1643         debugger. On OS X it just calls gdb-safari.
1644
1645         Reviewed by Mark Rowe.
1646
1647         * FindSafari/FindSafari.cpp:
1648         (_tmain): Added a /debugger flag, which in combination with
1649         /printSafariLauncher will print a script that launches Safari in the
1650         debugger.
1651         * Scripts/debug-safari: Added.
1652         * Scripts/run-safari: Changed to call runSafari().
1653         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1654         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1655         first argument along to FindSafari.
1656         * Scripts/webkitdirs.pm:
1657         (sub runSafari): Added.
1658
1659 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1660
1661         Reviewed by Adam Roben.
1662
1663         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1664
1665 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1666
1667         Reviewed by David Kilzer.
1668
1669         The git config command was renamed to repo-config at some point. This
1670         change tries git config and then git repo-config if the first fails.
1671
1672         * Scripts/prepare-ChangeLog:
1673         (gitConfig):
1674
1675 2007-11-16  Dan Bernstein  <mitz@apple.com>
1676
1677         Reviewed by Darin Adler and Sam Weinig.
1678
1679         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1680
1681         * DumpRenderTree/win/EventSender.cpp:
1682         (keyDownCallback): For characters that cannot be entered on the active
1683         keyboard layout, send a WM_CHAR message with the character along with
1684         a WM_KEYDOWN message with a virtual key code of 255.
1685
1686 2007-11-16  Mark Rowe  <mrowe@apple.com>
1687
1688         Reviewed by Tim Hatcher.
1689
1690         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1691
1692         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1693         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1694
1695 2007-11-15  Adam Roben  <aroben@apple.com>
1696
1697         Make run-safari actually work on Windows
1698
1699         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1700         chdir call.
1701
1702 2007-11-14  Adam Roben  <aroben@apple.com>
1703
1704         Updates to Safari launching now that 3.0.4 is released
1705
1706         Reviewed by Sam.
1707
1708         * FindSafari/FindSafari.cpp:
1709         (getWebViewCLSID): Use version-independent ProgID.
1710         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1711
1712 2007-11-14  Anders Carlsson  <andersca@apple.com>
1713
1714         Reviewed by Adam.
1715
1716         <rdar://problem/5309081>
1717         In DRT, "plugin.logDestroy = true" not working on Windows.
1718         
1719         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1720         (NPP_Destroy):
1721
1722 2007-11-14  Eric Seidel  <eric@webkit.org>
1723
1724         Reviewed by Sam.
1725
1726         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1727
1728 2007-11-14  Anders Carlsson  <andersca@apple.com>
1729
1730         Reviewed by Adam.
1731
1732         <rdar://problem/5141186>
1733         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1734         
1735         Implement setWindowIsKey.
1736         
1737         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1738         (LayoutTestController::setWindowIsKey):
1739
1740 2007-11-13  Sam Weinig  <sam@webkit.org>
1741
1742         Reviewed by Adam Roben.
1743
1744         Fix for <rdar://problem/5382579>
1745         http/tests/security/cross-frame-access-put.html reports large 
1746         negative numbers for screenLeft and screenTop (Mac reports "0")
1747
1748         * DumpRenderTree/win/UIDelegate.cpp:
1749         (UIDelegate::UIDelegate): Initialize the RECT.
1750         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1751         (UIDelegate::webViewFrame): ditto.
1752         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1753
1754 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1755
1756         Reviewed by Adam.
1757
1758         - Make Drosera show source, source URLs, and function stack on Windows,
1759         and some minor fixes.
1760
1761         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1762         (DebuggerDocument::updateFileSource):
1763         * Drosera/debugger.js: Force source to always update display.
1764         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1765         menu controls.
1766         (DebuggerClient::resume):
1767         (DebuggerClient::pause):
1768         (DebuggerClient::stepInto):
1769         (DebuggerClient::stepOver):
1770         (DebuggerClient::stepOut):
1771         (DebuggerClient::showConsole):
1772         (DebuggerClient::closeCurrentFile):
1773         * Drosera/win/DebuggerClient.h: Ditto.
1774         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1775         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1776         removed two bugs.  1) caller could be in a bad state when asked to
1777         assign into it. 2) BSTRs were not created correctly.
1778         (DebuggerDocument::getPlatformCurrentFunctionStack):
1779         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1780         (droseraWndProc):
1781         (handleCommand):
1782         (Drosera::resume):
1783         (Drosera::pause):
1784         (Drosera::stepInto):
1785         (Drosera::stepOver):
1786         (Drosera::stepOut):
1787         (Drosera::showConsole):
1788         (Drosera::closeCurrentFile):
1789         * Drosera/win/Drosera.h: Hook up the menu controls.
1790         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1791         functions, added a null check, and fixed another bug where caller could
1792         be in a bad state when asked to assign into it.
1793         (ServerConnection::didLoadMainResourceForDataSource):
1794         (ServerConnection::getCallerFrame):
1795         * Drosera/win/ServerConnection.h: Safety first.
1796
1797 2007-11-13  Dan Bernstein  <mitz@apple.com>
1798
1799         Reviewed by Darin Adler.
1800
1801         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1802           DumpRenderTree --pixel-tests renders each test twice
1803
1804         * DumpRenderTree/mac/DumpRenderTree.mm:
1805         (dumpRenderTree): Removed the --paint option because the painting code
1806         is always exercised as a result of
1807         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1808         calling -displayIfNeeded.
1809         (dump): Changed to always grab the image from the window since the view
1810         is always displayed.
1811         (runTest):
1812         (displayWebView):
1813         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1814         because it always paints.
1815
1816 2007-11-12  Antti Koivisto  <antti@apple.com>
1817
1818         Reviewed by Adele.
1819         
1820         Add support for http media tests
1821
1822         * Scripts/run-webkit-tests:
1823
1824 2007-11-12  Sam Weinig  <sam@webkit.org>
1825
1826         Reviewed by Adam Roben.
1827
1828         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1829
1830         * DumpRenderTree/win/DumpRenderTree.cpp:
1831         (runTest):
1832         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1833         (LayoutTestController::setPrivateBrowsingEnabled):
1834
1835 2007-11-12  Adam Roben  <aroben@apple.com>
1836
1837         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1838         mac and win subdirectories.
1839
1840 2007-11-11  Adam Roben  <aroben@apple.com>
1841
1842         Fix <rdar://5133816> keepWebHistory is not implemented
1843
1844         Fixes fast/history/clicked-link-is-visited.html.
1845
1846         Reviewed by Darin.
1847
1848         * DumpRenderTree/win/DumpRenderTree.cpp:
1849         (runTest): Clear the optionalSharedHistory.
1850         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1851         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1852
1853 2007-11-10  Sam Weinig  <sam@webkit.org>
1854
1855         Reviewed by Tim Hatcher.
1856
1857         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1858         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1859         is turned on)
1860
1861         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1862
1863         Added test: http/tests/security/cross-frame-access-private-browsing.html
1864
1865         * DumpRenderTree/LayoutTestController.cpp:
1866         (setPrivateBrowsingEnabledCallback):
1867         (LayoutTestController::staticFunctions):
1868         * DumpRenderTree/LayoutTestController.h:
1869         * DumpRenderTree/mac/DumpRenderTree.mm:
1870         (runTest): Default to private browsing disabled.
1871         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1872         (LayoutTestController::setPrivateBrowsingEnabled):
1873         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1874         (LayoutTestController::setPrivateBrowsingEnabled):
1875
1876 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1877
1878         Reviewed by Adam.
1879
1880         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1881         WebCore's!
1882
1883         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1884         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1885         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1886         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1887         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1888         * Drosera/win/Drosera.cpp:
1889         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1890
1891 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1892
1893         Reviewed by Sam.
1894
1895         - Use the new IWebFrame [local] function signature and get the shared
1896         server correctly.
1897
1898         * Drosera/win/DebuggerClient.cpp:
1899         (DebuggerClient::didFinishLoadForFrame):
1900         * Drosera/win/ServerConnection.cpp:
1901         (ServerConnection::attemptToCreateServerConnection):
1902
1903 2007-11-07  Dan Bernstein  <mitz@apple.com>
1904
1905         Reviewed by Darin Adler.
1906
1907         - add an option to run-webkit-tests to ignore pixel test failures where
1908           all pixels differ by no more than a specified threshold
1909
1910         * DumpRenderTree/mac/ImageDiff.m:
1911         (main):
1912         (compareImages):
1913         (computePercentageDifferent):
1914         * Scripts/run-webkit-tests:
1915
1916 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1917
1918         Reviewed by Lars.
1919
1920         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1921
1922         * DumpRenderTree/qt/DumpRenderTree.cpp:
1923
1924 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1925
1926         Reviewed by Lars.
1927
1928         Reworked the QWebSettings API.
1929         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1930
1931         * DumpRenderTree/qt/DumpRenderTree.cpp:
1932
1933 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1934
1935         Reviewed by Lars.
1936
1937         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1938
1939         * DumpRenderTree/qt/jsobjects.cpp:
1940
1941 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1942
1943         Reviewed by Lars Knoll <lars@trolltech.com>.
1944
1945         Add a QWebPage::frameCreated() signal and fix DRT
1946         
1947         The removal of createFrame in QWebPage broke the re-implementation
1948         in DumpRenderTree. Instead emit a frameCreated() signal and
1949         connect to it in DumpRenderTree.
1950         
1951
1952         * DumpRenderTree/qt/DumpRenderTree.cpp:
1953         (WebCore::WebPage::WebPage):
1954         (WebCore::DumpRenderTree::dump):
1955         (WebCore::DumpRenderTree::connectFrame):
1956         * DumpRenderTree/qt/DumpRenderTree.h:
1957
1958 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1959
1960         Reviewed by Lars Knoll <lars@trolltech.com>.
1961
1962         Moved all the event handlers from QWebFrame into QWebPage.
1963         
1964         This cleans up the public API and allows us to remove the
1965         HackWebFrame hack in DumpRenderTree.
1966         
1967
1968         * DumpRenderTree/qt/jsobjects.cpp:
1969         (EventSender::mouseDown):
1970         (EventSender::mouseUp):
1971         (EventSender::mouseMoveTo):
1972
1973 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1974
1975         Reviewed by Mark.
1976
1977         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1978         to prevent the default implementation from popping up messageboxes.
1979
1980         * DumpRenderTree/qt/DumpRenderTree.cpp:
1981         (WebCore::WebPage::javaScriptConfirm):
1982         (WebCore::WebPage::javaScriptPrompt):
1983
1984 2007-11-06  Eric Seidel  <eric@webkit.org>
1985
1986         * Scripts/build-testkjs: build fix... too many $$
1987
1988 2007-11-06  Eric Seidel  <eric@webkit.org>
1989
1990         Reviewed by Mark Rowe.
1991
1992         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1993
1994 2007-11-05  Adam Roben  <aroben@apple.com>
1995
1996         Add support on Windows for WEBKIT_TESTFONTS
1997
1998         This environment variable lets you specify where the fonts to be used
1999         by DumpRenderTree reside. The Qt port is already using this, so I'm
2000         just following their lead.
2001
2002         Reviewed by Darin.
2003
2004         * DumpRenderTree/win/DumpRenderTree.cpp:
2005         (exePath): Refactored code out of initialize().
2006         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2007         DumpRenderTree.resources.
2008         (initialize): Use the new fontsPath function.
2009         (main): Use the new exePath function.
2010         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2011         variable to DRT, like Qt does.
2012
2013 2007-11-05  Mark Rowe  <mrowe@apple.com>
2014
2015         Rubber-stamped by Alp Toker.
2016
2017         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2018
2019         * GtkLauncher/main.cpp:
2020         (goToURLBarText):
2021         (main):
2022
2023 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2024
2025         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2026         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2027
2028         Reviewed by Timothy.
2029
2030         Restrict the range of nightly builds used by the bisect-builds script
2031         based on the version of Safari and the version of Mac OS X being used.
2032
2033         Mac OS X 10.4: Safari 2.0: r11976 or newer
2034         Mac OS X 10.4: Safari 3.0: r19992 or newer
2035
2036         Mac OS X 10.5: Safari 2.0: r19594 or newer
2037         Mac OS X 10.5: Safari 3.0: r25124 or newer
2038
2039         * Scripts/bisect-builds:
2040         (findMacOSXVersion): Added.
2041         (makeNightlyList): Added argument to provide version of Mac OS X.
2042         Restrict range of nightly builds based on Safari and Mac OS X versions.
2043
2044 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2045
2046         Reviewed by Maciej.
2047
2048         - This patch involves several changes, all of them were noticed that
2049         they were needed by the work being done in WebKit to get Drosera and
2050         WebKit working together on Windows.
2051         - The changes are:
2052         1) Added a debugger console for output messages.
2053         2) Drosera now listens for the WebKit server (before, the server would
2054         have to be running before Drosera was started.)
2055         3) Fixed a bug where the WebView started out as 0x0 pixels.
2056         4) Fixed a bug when there is no scope.
2057         5) Added the HTML, JS, and CSS to the project file to make them easy to
2058         find.
2059         6) Made the ServerConnection functions virtual.
2060
2061         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2062         for the WebKit server.
2063         (DebuggerClient::DebuggerClient):
2064         (DebuggerClient::~DebuggerClient):
2065         (DebuggerClient::didFinishLoadForFrame):
2066         (DebuggerClient::serverConnected):
2067         (DebuggerClient::attemptToCreateServerConnection):
2068         * Drosera/win/DebuggerClient.h: Ditto.
2069         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2070         scope.
2071         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2072         (DebuggerDocument::platformValueForScopeVariableNamed):
2073         * Drosera/win/Drosera.cpp:
2074         (_tWinMain): Added a console in debug for output messages.
2075         (Drosera::Drosera): Listen for server.
2076         (Drosera::initUI): The server now Initializes COM.
2077         (Drosera::serverConnected): Part of the listening for the server.
2078         (Drosera::attemptToCreateServerConnection): Ditto.
2079         * Drosera/win/Drosera.h: New interface for listening for the server.
2080         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2081         files to the VS project.
2082         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2083         connection.
2084         (ServerConnection::ServerConnection):
2085         (ServerConnection::attemptToCreateServerConnection):
2086         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2087         methods.
2088         (ServerConnection::serverConnected):
2089
2090 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2091
2092         Reviewed by Maciej.
2093
2094         http://bugs.webkit.org/show_bug.cgi?id=15832
2095         fast/dom/gc-10.html crashes when run alone
2096
2097         Check for !done before using objects that can be already deallocated.
2098
2099         * DumpRenderTree/mac/EditingDelegate.mm:
2100         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2101         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2102         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2103         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2104         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2105         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2106         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2107         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2108         (-[EditingDelegate webViewDidBeginEditing:]):
2109         (-[EditingDelegate webViewDidChange:]):
2110         (-[EditingDelegate webViewDidEndEditing:]):
2111         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2112         (-[EditingDelegate webViewDidChangeSelection:]):
2113         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2114         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2115         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2116         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2117         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2118         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2119         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2120         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2121         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2122         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2123         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2124         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2125         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2126         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2127         (-[FrameLoadDelegate webView:willCloseFrame:]):
2128         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2129         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2130         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2131         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2132         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2133         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2134         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2135         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2136         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2137
2138 2007-11-04  Mark Rowe  <mrowe@apple.com>
2139
2140         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2141         warnings that would otherwise be suppressed due to it being a system header.
2142
2143         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2144
2145 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2146
2147         Rubber stamped by Adam.
2148         
2149         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2150
2151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2152
2153 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2154
2155         Sort files(...); sections of Xcode project files.
2156
2157         Rubber-stamped by Darin.
2158
2159         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2160         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2161         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2162         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2163
2164 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2165
2166         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2167
2168         Reviewed by Darin.
2169
2170         * Scripts/sort-Xcode-project-file: Added.
2171
2172 2007-11-02  Darin Adler  <darin@apple.com>
2173
2174         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2175
2176 2007-11-02  Darin Adler  <darin@apple.com>
2177
2178         Reviewed by Maciej.
2179
2180         * Scripts/run-sunspider: Pass the "--base" option through.
2181
2182         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2183         the real script do that. Default configuration to Release to match run-sunspider
2184         so we don't end up building Debug just to compare results.
2185
2186 2007-11-01  Adam Roben  <aroben@apple.com>
2187
2188         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2189
2190         Reviewed by Sam.
2191
2192         * Scripts/commit-log-editor: Show all the directories beneath the
2193         source root, instead of just the last one.
2194
2195 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2196
2197         Reviewed by Adam Roben.
2198
2199         Print out an error message when the Windows build fails
2200         and provide guidance on how to find out what went wrong.
2201
2202         * Scripts/build-webkit:
2203         * Scripts/webkitdirs.pm:
2204
2205 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2206
2207         Rubber-stamped by Adam Roben.
2208
2209         Rolled out r27326 - debug CRT seems to cause no problems after all.
2210
2211         * DumpRenderTree/win/DumpRenderTree.vcproj:
2212
2213 2007-10-31  Adam Roben  <aroben@apple.com>
2214
2215         Switch the Debug configuration to using the non-debug CRT
2216
2217         This matches WebKit.
2218
2219         Reviewed by Steve.
2220
2221         * DumpRenderTree/win/DumpRenderTree.vcproj:
2222
2223 2007-10-31  Antti Koivisto  <antti@apple.com>
2224
2225         Reviewed by bdash.
2226         
2227         Disable media tests when doing leak checking on Tiger.
2228         They crash in QuickTime (rdar://problem/5537157).
2229
2230         * Scripts/run-webkit-tests:
2231
2232 2007-10-29  Antti Koivisto  <antti@apple.com>
2233
2234         Reviewed by Maciej.
2235         
2236         Build media support by default on OSX only.
2237
2238         * Scripts/build-webkit:
2239
2240 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2241
2242         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2243         get caught by the pre-commit hooks.
2244
2245 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2246
2247         Reviewed by Adam.
2248
2249         - This is a collection of relatively unrelated changes and cleanups
2250         to Drosera to prepare it for interacting with WebKit.  A lot of these
2251         changes are just correcting mistakes, for example removing included
2252         headers that are no longer needed.
2253
2254         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2255         this will be needed by the DebuggerClient.
2256         (DebuggerDocument::server):
2257         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2258         * Drosera/win/DebuggerClient.cpp: 
2259         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2260         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2261         (DebuggerClient::createWebViewWithRequest): Added comment about its
2262         purpose. 
2263         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2264         declarations.
2265         (DebuggerClient::webViewLoaded): Moved.
2266         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2267         file, since this was the only place it was used.
2268         (cfStringToBSTR):
2269         * Drosera/win/Drosera.h: Cleaned up the includes.
2270         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2271         * Drosera/win/HelperFunctions.h: Removed.
2272
2273 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2274
2275         Reviewed by Adam.
2276
2277         - Small cleanup in the ServerConnection class.
2278
2279         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2280         and added an include.
2281         (ServerConnection::currentFrame):
2282         (ServerConnection::getCallerFrame):
2283         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2284         made a pointer into a COMPtr, and cleaned up the includes.
2285
2286 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2287
2288         Reviewed by John Sullivan.
2289         
2290         - Place the Localizable.strings file in mac or win directories
2291           if that location exists.
2292         - Also look for UI_STRING in .c files.
2293
2294         * Scripts/extract-localizable-strings:
2295
2296 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2297
2298         Reviewed by Adam.
2299
2300         - Set the eol-style to native and made all the line endings the same
2301         so that I avoid messy diffs that show eol changes.
2302
2303         * Drosera/win/ServerConnection.cpp:
2304         (ServerConnection::didParseSource):
2305         (ServerConnection::didEnterCallFrame):
2306         (ServerConnection::willExecuteStatement):
2307         (ServerConnection::willLeaveCallFrame):
2308         (ServerConnection::exceptionWasRaised):
2309
2310 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2311
2312         Reviewed by Adam.
2313
2314         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2315         functionality that could not have existed previously without the new
2316         interfaces.
2317         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2318         from a BSTR to a JSValueRef.
2319         (DebuggerDocument::platformEvaluateScript): Implemented.
2320         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2321         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2322         Implemented.
2323         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2324         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2325         * Drosera/win/ServerConnection.cpp: Added a helper function.
2326         (ServerConnection::getCallerFrame):
2327         * Drosera/win/ServerConnection.h: Added a helper function.
2328
2329 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2330
2331         updated reviewers for my previous changelog.
2332
2333 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2334         Reviewed by Maciej and Adam and Geoff.
2335
2336         - Minor mac-side improvements including moving a function to a more
2337         appropriate location, fixing a warning, and correctly checking
2338         exceptions.
2339
2340         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2341         (DebuggerDocument::willExecuteStatement):
2342         (DebuggerDocument::didEnterCallFrame):
2343         (DebuggerDocument::willLeaveCallFrame):
2344         (DebuggerDocument::windowScriptObjectAvailable):
2345         (DebuggerDocument::callFunctionOnObject):
2346         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2347         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2348         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2349         because it doesn't require the ServerConnection at all.
2350         (NSStringCreateWithJSStringRef): Made an argument const.
2351         (JSValueRefCreateWithNSString): Made an argument const.
2352         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2353         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2354         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2355         * Drosera/mac/ServerConnection.mm: Ditto.
2356         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2357
2358 2007-10-29  Sam Weinig  <sam@webkit.org>
2359
2360         Reviewed by Adam Roben.
2361
2362         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2363
2364         * DumpRenderTree/LayoutTestController.cpp:
2365         (LayoutTestController::LayoutTestController):
2366         (getGlobalFlagCallback):
2367         (setGlobalFlagCallback):
2368         (LayoutTestController::getJSClass):
2369         (LayoutTestController::staticValues):
2370         * DumpRenderTree/LayoutTestController.h:
2371         (LayoutTestController::globalFlag):
2372         (LayoutTestController::setGlobalFlag):
2373
2374 2007-10-29  Darin Adler  <darin@apple.com>
2375
2376         Reviewed by Maciej.
2377
2378         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2379         resolution instead of its default.
2380
2381 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2382
2383         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2384
2385         Reviewed by Mark Rowe.
2386
2387         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2388         was successfully resolved, but this would not show any status because the change had
2389         already been cached in the index using "git add".  The solution is to add an optional
2390         second argument to showStatus() which adds the "--cached" switch to the command.
2391
2392         * Scripts/resolve-ChangeLogs:
2393         (showStatus):
2394
2395 2007-10-28  Eric Seidel  <eric@webkit.org>
2396
2397         Reviewed by Maciej and Geoff, in unison.
2398
2399         * Scripts/run-webkit-tests: remove broken --svg option
2400
2401 2007-10-28  Darin Adler  <darin@apple.com>
2402
2403         Reviewed by Adam.
2404
2405         * Scripts/run-sunspider: Default to "Release" configuration rather than
2406         defaulting to the last configuration used as other scripts do. This can
2407         still be overriden on the command line with "--debug" if there's some
2408         reason to do so. Also fix a typo.
2409
2410         * Scripts/sunspider-compare-results: Fix a typo.
2411
2412 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2413
2414         Reviewed by Adam.
2415
2416         - Implemented the WebScriptDebugListener functions now that the
2417         WebScriptDebugServer exists
2418
2419         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2420         functions.
2421         (ServerConnection::currentFrame):
2422         (ServerConnection::didLoadMainResourceForDataSource):
2423         (ServerConnection::didParseSource):
2424         (ServerConnection::failedToParseSource):
2425         (ServerConnection::didEnterCallFrame):
2426         (ServerConnection::willExecuteStatement):
2427         (ServerConnection::willLeaveCallFrame):
2428         (ServerConnection::exceptionWasRaised):
2429         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2430         members arguments list.
2431
2432 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2433
2434         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2435         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2436
2437         Reviewed by Darin.
2438
2439         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2440         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2441         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2442         file.  Note that it may also be used as a stand-alone script.
2443
2444         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2445         * Scripts/resolve-ChangeLogs: Added.
2446         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2447
2448 2007-10-26  Mark Rowe  <mrowe@apple.com>
2449
2450         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2451         to the Qt port on the assumption that it was an implementation of the cross-platform
2452         LayoutTestController class.  It is not, so it did not need to be changed.
2453
2454         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2455
2456 2007-10-25  Mark Rowe  <mrowe@apple.com>
2457
2458         Reviewed by Maciej.
2459
2460         Fix builds with code coverage enabled.
2461
2462         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2463
2464 2007-10-25  Darin Adler  <darin@apple.com>
2465
2466         Reviewed by Mark Rowe.
2467
2468         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2469         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2470
2471 2007-10-25  Stephanie  <slewis@apple.com>
2472
2473         build Fix
2474
2475         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2476
2477 2007-10-25  Stephanie  <slewis@apple.com>
2478
2479         Reviewed by Mark Rowe, Adam Roben.
2480
2481         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2482
2483         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2484
2485 2007-10-25  Alice Liu  <alice.liu@apple.com>
2486
2487         Reviewed by Adam.
2488
2489         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2490
2491         Moving destructor into platform-specific files
2492         * DumpRenderTree/LayoutTestController.cpp:
2493         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2494         (LayoutTestController::~LayoutTestController):
2495         * DumpRenderTree/qt/jsobjects.cpp:
2496         (LayoutTestController::~LayoutTestController):
2497
2498         LayoutTestController wasn't being destroyed
2499         * DumpRenderTree/win/DumpRenderTree.cpp:
2500         (runTest):
2501
2502         Added declspec
2503         * DumpRenderTree/win/EditingDelegate.h:
2504
2505         Reset certain values on the webview (or related delegate) that might 
2506         have changed while running a test
2507         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2508         (LayoutTestController::~LayoutTestController):
2509
2510 2007-10-25  Adam Roben  <aroben@apple.com>
2511
2512         Make sunspider-compare-results work with relative paths
2513
2514         Reviewed by Sam.
2515
2516         * Scripts/sunspider-compare-results: Convert arguments to absolute
2517         paths before we chdir.
2518
2519 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2520
2521         Reviewed by Sam.
2522
2523         - Implemented server calls now the WebScriptDebugServer exists.
2524         - Also removed no longer needed call to initialize CG.
2525
2526         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2527         automatically now.
2528         (_tWinMain):
2529         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2530         (ServerConnection::ServerConnection):
2531         (ServerConnection::~ServerConnection):
2532         (ServerConnection::pause):
2533         (ServerConnection::resume):
2534         (ServerConnection::stepInto):
2535         (ServerConnection::applicationTerminating):
2536         (ServerConnection::serverConnectionDidDie):
2537         * Drosera/win/ServerConnection.h: Now uses the COM class.
2538
2539 2007-10-24  George Staikos  <staikos@kde.org>
2540
2541         Unbreak Qt build.
2542
2543         * Scripts/build-webkit:
2544
2545 2007-10-24  Adam Roben  <aroben@apple.com>
2546
2547         Remove now-unnecessary call to InitializeCoreGraphics
2548
2549         WebKit takes care of this now.
2550
2551         Reviewed by Ada.
2552
2553         * DumpRenderTree/win/DumpRenderTree.cpp:
2554         (initialize):
2555
2556 2007-10-24  Adam Roben  <aroben@apple.com>
2557
2558         Use WebTextRenderer in DRT
2559
2560         Reviewed by Ada.
2561
2562         * DumpRenderTree/win/DumpRenderTree.cpp:
2563         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2564
2565 2007-10-24  Sven Herzberg  <sven@imendio.com>
2566
2567         Reviewed by Mark Rowe.
2568
2569         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2570         Bug 15614: [GTK] qmake based backends don't build on OS X
2571
2572         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2573         GTK backend on a Mac
2574         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2575         isDarwin() to make it reusable in other places (like the workaround-
2576         for-prebuilt-qmake in build-webkit)
2577
2578 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2579
2580         Refurbish update-webkit script.
2581
2582         Reviewed by Adam.
2583
2584         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2585         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2586         multi-argument version of system() for flexibility and security.  Check for existence
2587         of Internal directory using -d test instead of -x.
2588
2589 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2590
2591         Minor clean-up of prepare-ChangeLog script.
2592
2593         Reviewed by Adam.
2594
2595         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2596         of a string.  Use multi-argument versions of open() and system() for flexibility and
2597         security.
2598
2599 2007-10-24  Alice Liu  <alice.liu@apple.com>
2600
2601         Reviewed by Oliver.
2602
2603         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2604
2605         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2606         replay the saved events when we're still processing the mousedown that starts the drag
2607         * DumpRenderTree/win/EventSender.cpp:
2608         (doMouseMove):
2609         * DumpRenderTree/win/UIDelegate.cpp:
2610         (UIDelegate::doDragDrop):
2611
2612 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2613
2614         Reviewed by Sam, Steve and Darin.
2615
2616         - Stubbed out the WebScriptDebugListener functionality in the Server
2617         Connection class to prepare it for receiving those callbacks.
2618         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2619         and the ServerConnection to not need to be initialized with a server
2620         name, since that is not the way we connect to the WebKit server. 
2621
2622         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2623         no exception.  Now it only loggs when there is an exception
2624         (DebuggerDocument::willExecuteStatement):
2625         (DebuggerDocument::didEnterCallFrame):
2626         (DebuggerDocument::willLeaveCallFrame):
2627         (DebuggerDocument::windowScriptObjectAvailable):
2628         (DebuggerDocument::callFunctionOnObject):
2629         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2630         to be instantiated with a server's name.
2631         (DebuggerClient::DebuggerClient):
2632         (DebuggerClient::didFinishLoadForFrame):
2633         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2634         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2635         a server name.
2636         (Drosera::init):
2637         (Drosera::initServer):
2638         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2639         instantiated with a server's name.
2640         * Drosera/win/ServerConnection.cpp: 
2641         (ServerConnection::ServerConnection): No longer needs a server name
2642         (ServerConnection::~ServerConnection): Only release the global context
2643         if there is one.
2644         (ServerConnection::serverConnectionDidDie): Stub for
2645         IWebScriptDebugListener
2646         (ServerConnection::QueryInterface): ditto
2647         (ServerConnection::AddRef): ditto
2648         (ServerConnection::Release): ditto
2649         (ServerConnection::didLoadMainResourceForDataSource): ditto
2650         (ServerConnection::didParseSource): ditto
2651         (ServerConnection::failedToParseSource): ditto
2652         (ServerConnection::didEnterCallFrame): ditto
2653         (ServerConnection::willExecuteStatement): ditto
2654         (ServerConnection::willLeaveCallFrame): ditto
2655         (ServerConnection::exceptionWasRaised): ditto
2656         * Drosera/win/ServerConnection.h: Stubbed out the
2657         IWebScriptDebugListener functions, and this class no longer needs to be
2658         instantiated with a server name.
2659
2660 2007-10-24  Lars Knoll  <lars@trolltech.com>
2661
2662         Reviewed by Simon.
2663
2664         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2665
2666         * DumpRenderTree/qt/jsobjects.h:
2667
2668 2007-10-24  Lars Knoll  <lars@trolltech.com>
2669
2670         Reviewed by Simon.
2671
2672         add another command.
2673
2674         * DumpRenderTree/qt/jsobjects.cpp:
2675         (TextInputController::doCommand):
2676
2677 2007-10-24  Lars Knoll  <lars@trolltech.com>
2678
2679         Reviewed by Simon.
2680
2681         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2682
2683         * DumpRenderTree/qt/jsobjects.cpp:
2684         (EventSender::keyDown):
2685         * DumpRenderTree/qt/jsobjects.h:
2686
2687 2007-10-24  Lars Knoll  <lars@trolltech.com>
2688
2689         Reviewed by Simon.
2690
2691         implement eventSender.keyDown().
2692
2693         * DumpRenderTree/qt/jsobjects.cpp:
2694         (EventSender::keyDown):
2695
2696 2007-10-24  Lars Knoll  <lars@trolltech.com>
2697
2698         Reviewed by Simon.
2699
2700         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2701
2702         * DumpRenderTree/qt/DumpRenderTree.cpp:
2703         (WebCore::DumpRenderTree::DumpRenderTree):
2704         (WebCore::DumpRenderTree::initJSObjects):
2705         * DumpRenderTree/qt/jsobjects.cpp:
2706         (TextInputController::doCommand):
2707
2708 2007-10-24  Lars Knoll  <lars@trolltech.com>
2709
2710         Reviewed by Simon.
2711
2712         first bit of implementation for the textinputcontroller.
2713
2714         * DumpRenderTree/qt/DumpRenderTree.cpp:
2715         (WebCore::DumpRenderTree::DumpRenderTree):
2716         * DumpRenderTree/qt/DumpRenderTree.h:
2717         * DumpRenderTree/qt/jsobjects.cpp:
2718         (TextInputController::TextInputController):
2719         (TextInputController::doCommand):
2720         * DumpRenderTree/qt/jsobjects.h:
2721
2722 2007-10-24  Lars Knoll  <lars@trolltech.com>
2723
2724         Reviewed by Simon.
2725
2726         make the man webpage believe it has focus, so the editing tests work correctly.
2727
2728         * DumpRenderTree/qt/DumpRenderTree.cpp:
2729         (WebCore::DumpRenderTree::DumpRenderTree):
2730
2731 2007-10-24  Lars Knoll  <lars@trolltech.com>
2732
2733         Reviewed by Simon.
2734
2735         implement layoutTestController.dumpEditingCallbacks() correctly.
2736
2737         * DumpRenderTree/qt/DumpRenderTree.cpp:
2738         (WebCore::DumpRenderTree::DumpRenderTree):
2739         * DumpRenderTree/qt/jsobjects.cpp:
2740         (LayoutTestController::reset):
2741         (LayoutTestController::dumpEditingCallbacks):
2742
2743 2007-10-24  Lars Knoll  <lars@trolltech.com>
2744
2745         Reviewed by Simon.
2746
2747         Implement support for testing editing.
2748
2749         * DumpRenderTree/qt/DumpRenderTree.cpp:
2750         (WebCore::DumpRenderTree::DumpRenderTree):
2751
2752 2007-10-23  Sam Weinig  <sam@webkit.org>
2753
2754         Check for null BSTR that can be passed to the UIDelegate methods
2755         from javascript null and undefined.  Fixes a failing test case on
2756         Windows (fast/dom/Window/alert-undefined.html)
2757
2758         Reviewed by Eric Seidel.
2759
2760         * DumpRenderTree/win/UIDelegate.cpp:
2761         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2762         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2763         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2764         (UIDelegate::webViewAddMessageToConsole):
2765
2766 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2767
2768         Reviewed by Darin.
2769         
2770         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2771
2772         * Scripts/build-testkjs:
2773
2774 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2775
2776         Reviewed by Darin.
2777
2778         - add wrapper that finds the right copy of testkjs
2779         
2780         * Scripts/sunspider-compare-results: Added.
2781
2782 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2783
2784         Reviewed by Sam.
2785
2786         - After talking with Steve I now see that the WebKit server must be
2787         running for DCOM to create the distributed objects, which makes sense
2788         and currently WebKit only allows one instance to be running at a time
2789         which avoids accidentally connecting to the wrong server
2790         - In light of this I have removed the code for the attach box and
2791         NotificationServer and known server names, since they are all extranious
2792         now.
2793
2794         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2795         names.
2796         (_tWinMain): Uses init instead of initUI.
2797         (droseraWndProc): No longer creats an attach dialog box.
2798         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2799         it's not manditory to call init before doing COM stuff.
2800         (Drosera::init): calls initUI and will call attach when the
2801         functionality exists. 
2802         (Drosera::initUI): Has changed very little.
2803         (Drosera::attach): Changed the signature to reflect that we no longer
2804         need the dictionary of known server names.
2805         * Drosera/win/Drosera.h: Removed notification classes and known server
2806         names.  Also renamed and moved some functions.
2807         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2808         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2809         headers to the resources folder. 
2810         * Drosera/win/resource.h: Removed the Attach box.
2811
2812 2007-10-22  Adam Roben  <aroben@apple.com>
2813
2814         Windows build fix
2815
2816         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2817
2818 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2819
2820         - Removed a leak that was fixed.
2821
2822         * Scripts/run-webkit-tests:
2823
2824 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2825
2826         Reviewed by Darin.
2827
2828         - Changed the Client so that the DebuggerDocument now own the
2829         ServerConnection.  This simplifies ownership and cleanup. 
2830
2831         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2832         ServerConnection.
2833         (DebuggerClient::initWithServerName):
2834         (DebuggerClient::didFinishLoadForFrame):
2835         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2836         ServerConnection.
2837         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2838         until after we have a server which we are attached to.
2839         (Drosera::initUI):
2840         (Drosera::attach):
2841         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2842         out previously.
2843
2844 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2845
2846         Reviewed by Nikolas.
2847
2848         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2849
2850         * Scripts/run-javascriptcore-tests:
2851
2852 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2853
2854         Reviewed by Nikolas.
2855
2856         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2857
2858         * Scripts/build-drosera:
2859         * Scripts/build-dumprendertree:
2860         * Scripts/build-testkjs:
2861         * Scripts/build-webkit:
2862         * Scripts/run-javascriptcore-tests:
2863         * Scripts/run-sunspider:
2864         * Scripts/run-webkit-tests:
2865         * Scripts/webkitdirs.pm:
2866
2867 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2868
2869         Reviewed by Mark Rowe.
2870         
2871         Fix for local database support after r26879
2872         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2873
2874         * Scripts/build-webkit:
2875
2876 2007-10-22  Holger Freyther  <zecke@selfish.org>
2877
2878         Reviewed by Simon Hausmann <hausmann@kde.org>.
2879
2880         - Do not build testkjs as an application bundle. This is
2881         needed for run-javascriptcore-tests on OSX.
2882         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2883         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2884         as we do not have -rpath on OSX.
2885
2886         * DumpRenderTree/qt/DumpRenderTree.pro:
2887         * Scripts/run-webkit-tests:
2888
2889 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2890
2891         Reviewed by aroben.
2892
2893         Fix support for Signed-off-by detection in prepare-ChangeLog
2894         --git-commit. The Signed-off-by tag does not appear in the header
2895         but usually at the end.
2896
2897         * Scripts/prepare-ChangeLog:
2898
2899 2007-10-21  Mark Rowe  <mrowe@apple.com>
2900
2901         Reviewed by Eric.
2902
2903         Fix run-javascriptcore-tests for Gtk.
2904
2905         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2906
2907 2007-10-20  Eric Seidel  <eric@webkit.org>
2908
2909         Reviewed by aroben.
2910
2911         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2912
2913 2007-10-20  Eric Seidel  <eric@webkit.org>
2914
2915         Reviewed by darin.
2916         
2917         Add improved argument handling to run-sunspider, including
2918         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2919         Also re-factor code into subroutines
2920
2921         * Scripts/build-dumprendertree: removed bogus comments
2922         * Scripts/build-testkjs: Added.
2923         * Scripts/run-javascriptcore-tests: use build-testkjs
2924         * Scripts/run-sunspider: improved argument handling, abstraction
2925         * Scripts/run-webkit-tests: improved abstraction
2926
2927 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2928
2929         Not reviewed, Windows build fix.
2930
2931         * DumpRenderTree/win/EventSender.cpp:
2932         (keyDownCallback):
2933
2934 2007-10-20  Darin Adler  <darin@apple.com>
2935
2936         Reviewed by Tim Hatcher.
2937
2938         - http://bugs.webkit.org/show_bug.cgi?id=15544
2939           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2940           not rely on Apple-specific key codes
2941
2942         * DumpRenderTree/mac/EventSendingController.mm:
2943         (-[EventSendingController keyDown:withModifiers:]):
2944         Added named key "rightArrow". Later we could have a whole table of these.
2945         Also tweaked modifiers code a little.
2946
2947         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2948
2949 2007-10-19  Darin Adler  <darin@apple.com>
2950
2951         Reviewed by Eric.
2952
2953         - http://bugs.webkit.org/show_bug.cgi?id=15566
2954           possible fix for leak seen in DumpRenderTree
2955
2956         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2957         Delete the item if it's not put on the queue, since the caller has
2958         no way of knowing that. Would be better to have the parameter type
2959         be auto_ptr to express the fact that we take ownership.
2960
2961         - unrelated change
2962
2963         * Drosera/mac/main.m: Add missing include.
2964
2965 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2966
2967         Reviewed by Adam.
2968
2969         - This change should be identical but for some reason was not working
2970         on my machine.
2971
2972         * Scripts/prepare-ChangeLog:
2973
2974 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2975
2976         Reviewed by Oliver and Tim.
2977
2978         - Made use of RetainPtr to avoid retain and release issues and moved the
2979         log function to DebuggerDocumentPlatform, which seems to be a more
2980         logical place for it to live.
2981         - Also moved knownServers from the ServerConnection to
2982         DebuggerApplication to match the Windows code and because it makes sense
2983         that a connection knows its own server but not all of them.
2984
2985         * Drosera/mac/DebuggerClient.h: Moved the log function to
2986           DebuggerDocumentPlatform.
2987         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2988           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2989           call for the server name up from the ServerConnection class.
2990         (-[DebuggerClient dealloc]):
2991         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2992           for the server name up from the ServerConnection.
2993         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2994         (DebuggerDocument::platformPause):
2995         (DebuggerDocument::platformResume):
2996         (DebuggerDocument::platformStepInto):
2997         (DebuggerDocument::platformEvaluateScript):
2998         (DebuggerDocument::getPlatformCurrentFunctionStack):
2999         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3000         (DebuggerDocument::platformValueForScopeVariableNamed):
3001         (DebuggerDocument::platformLog): Log directly from here. No need to call
3002           DebuggerClient.
3003         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3004           way I see it, a ServerConnection should only know about its connection
3005           and the group of all possible servers should be kept by the
3006           application.
3007         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3008           currentServerName, it makes sense that the connection should know that
3009           name.
3010         (-[ServerConnection currentServerName]):
3011
3012 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3013
3014         Reviewed by Adam.
3015
3016         - Integrated changes from mac drosera.  Recently I've encapsulated
3017         out the server connection object from the rest of Drosera because
3018         it is very platform dependent right now and RPC is not implemented on
3019         windows.  This functionality, of communicating with the WebKit server
3020         is the next area I will be focusing on in Windows.
3021
3022         - Other changes and cleanup were made to organize the code and add notes
3023         on which parts still need work.  Also some mac code is added and
3024         commented out, to act as pseudocode for the logic of those parts.
3025
3026         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3027           pointer.
3028         * Drosera/config.h: Added whitespace.
3029         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3030           these files got moved into Drosera.h/cpp
3031         * Drosera/win/DebuggerApplication.h: Removed.
3032         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3033           happened here to better match the logic flow of the same code on the 
3034           mac side and to use the new ServerConnection class.
3035         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3036         (DebuggerClient::initWithServerName): Initializer that will set up the
3037           class to use a ServerConnection object.  This was necessary so I could
3038           create a DebuggerClient without having to initilaize it at
3039           construction.
3040         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3041           will be the UIDelegate and FrameLoadDelegate.
3042         (DebuggerClient::AddRef): For IUnknown.
3043         (DebuggerClient::Release): For IUnknown.
3044         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3045           this still needs to set the global context of the server, but
3046           IWebFrame does not have an accessor for the global context yet. 
3047         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3048           this is a pass through for the same function in the document.
3049         (DebuggerClient::didReceiveTitle): Unimplemented part of
3050           FrameLoadDelegate this would change the title of the window.
3051         (DebuggerClient::createWebViewWithRequest): Part of the
3052           FrameLoadDelegate.  This is about new windows via Window.open() and
3053           how their delegates are set.
3054         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3055           UIDelegate.  Just a debug function for printing messages.
3056         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3057           because the Client should be the UIDelegate and FrameLoadDelegate
3058           to match the delegates on mac.
3059         (DebuggerClient::webViewLoaded): Added accessor method.
3060         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3061           forgotten to add this file before.  This is where the platform
3062           dependent versions of the Documents functions live. Most of these are
3063           unimplemented because some piece of functionality does not exist on
3064           Windows yet.
3065         (DebuggerDocument::platformPause):
3066         (DebuggerDocument::platformResume):
3067         (DebuggerDocument::platformStepInto):
3068         (DebuggerDocument::platformEvaluateScript):
3069         (DebuggerDocument::getPlatformCurrentFunctionStack):
3070         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3071         (DebuggerDocument::platformValueForScopeVariableNamed):
3072         (DebuggerDocument::platformLog):
3073         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3074           responsibilities becaue they belong in the Client. Also I laid the
3075           groundwork for attaching Drosera to a WebKit process
3076         (attachWndProc): Now if a server is selected the Client becomes it's
3077           delegate.
3078         (Drosera::Drosera): Added the construction of the Client and dictionary
3079           of server names. 
3080         (Drosera::initUI): This is no longer the delegates, the Client is.
3081         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3082           state. 
3083         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3084           notification registration when it's possible to implement.
3085         (Drosera::serverLoaded): Ditto
3086         (Drosera::serverUnloaded): Ditto
3087         (Drosera::attach): Attach Drosera to the WebKit server.
3088         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3089         (Drosera::getInst): 
3090         (Drosera::setInst):
3091         (Drosera::knownServers):
3092         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3093           and added the ServerConnection.
3094         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3095         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3096           Most of the functions are completely unimlemented because they cannot
3097           connect with the WebKit server, because one does not exist on Windows
3098           yet.
3099         (ServerConnection::initWithServerName): 
3100         (ServerConnection::~ServerConnection):
3101         (ServerConnection::setGlobalContext):
3102         (ServerConnection::pause):
3103         (ServerConnection::resume):
3104         (ServerConnection::stepInto):
3105         (ServerConnection::switchToServerNamed):
3106         (ServerConnection::applicationTerminating):
3107         (ServerConnection::serverConnectionDidDie):
3108         (ServerConnection::currentFrame):
3109         * Drosera/win/ServerConnection.h: Added. Ditto.
3110         (ServerConnection::ServerConnection):
3111
3112 2007-10-19  Alice Liu  <alice.liu@apple.com>
3113
3114         Reviewed by Darin.
3115
3116         Fix for these broken layout tests on Windows:
3117         
3118         fast/forms/focus-selection-input.html
3119         fast/forms/focus-selection-textarea.html
3120         fast/forms/select-accesskey.html
3121         
3122         * DumpRenderTree/win/EventSender.cpp:
3123         (keyDownCallback):
3124         correct the VK code for alt key.
3125         
3126 2007-10-19  Eric Seidel  <eric@webkit.org>
3127
3128         Reviewed by Mark Rowe.
3129         
3130         Make the GtkLauncher code slightly more readable.
3131
3132         * GtkLauncher/main.cpp:
3133         (setupMainMenu): Added.
3134         (setupMainWindowUI): Added.
3135         (main):
3136
3137 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3138
3139         Rubber stamped by Adam.
3140         
3141         - don't delay-load WebKit in DumpRenderTree.
3142
3143         * DumpRenderTree/win/DumpRenderTree.vcproj:
3144
3145 2007-10-18  Dan Bernstein  <mitz@apple.com>
3146
3147         Reviewed by Adam Roben.
3148
3149         - fix <rdar://problem/5313523>
3150         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3151
3152         * DumpRenderTree/mac/DumpRenderTree.mm:
3153         (dump): Changed to use _responseMIMEType.
3154
3155 2007-10-17  Adam Roben  <aroben@apple.com>
3156
3157         Make it possible to have Windows-specific tests and results
3158
3159         When searching for tests to run and the Skipped file, we will only
3160         look in platform/win and the cross-platform directory. When looking
3161         for expected results, we will look in platform/win, then
3162         platform/mac-leopard, then platform/mac, then finally the
3163         cross-platform directory.
3164
3165         Reviewed by Sam.
3166
3167         * Scripts/run-webkit-tests:
3168         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3169         searching in the cross-platform directory.
3170         (sub buildPlatformHierarchy): Removed some unneeded calls to
3171         dirname/basename.
3172
3173 2007-10-17  Adam Roben  <aroben@apple.com>
3174
3175         Add back the call to register WebKit that we had before WebKitInitializer existed
3176
3177         This is needed to ensure that the right WebKit is used when
3178         instantiating COM objects.
3179
3180         Reviewed by Oliver.
3181
3182         * DumpRenderTree/win/debug_internal.vsprops: Define
3183         DEBUG_WEBKIT_HAS_SUFFIX.
3184         * DumpRenderTree/win/DumpRenderTree.cpp:
3185         (initialize):
3186
3187 2007-10-17  Adam Roben  <aroben@apple.com>
3188
3189         Import File::Basename in webkitdirs since we use it
3190
3191         * Scripts/webkitdirs.pm:
3192
3193 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3194
3195         - Updated the tiger leaks list to make the internal bots green.
3196
3197         * Scripts/run-webkit-tests:
3198
3199 2007-10-17  Adam Roben  <aroben@apple.com>
3200
3201         Build fix for VC++ Express
3202
3203         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3204         and ole32.lib.
3205
3206 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3207
3208         Reviewed by Sam.
3209
3210         - Minor mac improvements based on observations I made while implementing the
3211         Windows code.
3212
3213         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3214         then hand it to the Client who will retain it, it should just be the client who
3215         creates and owns the server.
3216         (-[DebuggerApplication attach:]):
3217         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3218         * Drosera/mac/DebuggerClient.mm: Creates the server.
3219         (-[DebuggerClient initWithServerName:]):
3220         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3221         can instead forward declare what it needs.
3222
3223 2007-10-16  Darin Adler  <darin@apple.com>
3224
3225         Reviewed by Geoff Garen.
3226
3227         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3228         want to turn failing tests into platform-specific test results. Also did a
3229         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3230         would take the type of results into account only some of the time.
3231
3232 2007-10-16  Adam Roben  <aroben@apple.com>
3233
3234         Add a new nightly launcher script for Windows
3235
3236         This new script is for versions of Safari that don't delay-load
3237         WebKit. I had to make FindSafari be able to print out the nightly
3238         launcher script on stdout because Windows shell scripts can't capture
3239         the output from a command into an environment variable.
3240
3241         Reviewed by Steve.
3242
3243         * FindSafari/FindSafari.cpp:
3244         (_tmain): Added /printSafariLauncher option.
3245         * Scripts/run-webkit-nightly.cmd: Added.
3246
3247 2007-10-16  Adam Roben  <aroben@apple.com>
3248
3249         Replace WebKitInitializer with FindSafari
3250
3251         We now rely on setting the PATH environment variable to tell Windows
3252         where to find WebKit and its dependencies (similar to
3253         DYLD_FRAMEWORK_PATH on Mac).
3254
3255         This change also make DumpRenderTree no longer delay-load WebKit.
3256
3257         Reviewed by Sam.
3258
3259         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3260         FindSafari.
3261         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3262         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3263         WebKitInitializer, don't delay-load WebKit.
3264         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3265         * Scripts/run-webkit-tests: Ditto.
3266         * Scripts/webkitdirs.pm:
3267         (sub setPathForRunningWebKitApp): Added.
3268         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3269         * WebKitInitializer/WebKitInitializer.h: Removed.
3270         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3271         * WebKitInitializer/debug.vsprops: Removed.
3272         * WebKitInitializer/debug_internal.vsprops: Removed.
3273         * WebKitInitializer/release.vsprops: Removed.
3274
3275 2007-10-16  Adam Roben  <aroben@apple.com>
3276
3277         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3278
3279         http://bugs.webkit.org/show_bug.cgi?id=15532
3280
3281         FindSafari simply prints the location of an installed Safari.exe on
3282         stdout.
3283
3284         Reviewed by Darin.
3285
3286         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3287         (getStringValue):
3288         (getWebViewCLSID):
3289         (getInstalledWebKitDirectory):
3290         (_tmain):
3291         * FindSafari/FindSafari.vcproj: Added.
3292         * Scripts/webkitdirs.pm:
3293         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3294
3295 2007-10-16  Adam Roben  <aroben@apple.com>
3296
3297         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3298
3299         Reviewed by Kevin McCullough.
3300
3301         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3302         when referring to WebKit.dll.
3303         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3304         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3305         * DumpRenderTree/win/release.vsprops: Ditto.
3306         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3307         never have a _debug suffix on WebKit.dll.
3308         * WebKitInitializer/WebKitInitializer.cpp:
3309         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3310         specified.
3311         * WebKitInitializer/debug_internal.vsprops: Added
3312         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3313
3314 2007-10-16  Darin Adler  <darin@apple.com>
3315
3316         Reviewed by Adele.
3317
3318         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3319         Remove now-unneeded control/alt key hack; the tests have been updated.
3320
3321 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3322
3323         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3324         one of the leaks was fixed between that revision and the bot's previous version of
3325         leopard.
3326
3327         * Scripts/run-webkit-tests:
3328
3329 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3330
3331         Reviewed by Tim.
3332
3333         - I encapsulated out the server connecton functionality because it is a specific part
3334         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3335         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3336         Windows.  So the majority of this patch is moving preexisting functionality.
3337
3338         - Also I removed the prefix header and changed to use config.h because it is more
3339         standard on how we use config.h in windows and it didn't make much sense to keep
3340         the prefix header and the config.h
3341
3342         * Drosera/DebuggerDocument.cpp:
3343         (DebuggerDocument::DebuggerDocument):
3344         * Drosera/DebuggerDocument.h:
3345         * Drosera/config.h:
3346         * Drosera/mac/DebuggerApplication.mm:
3347         (-[DebuggerApplication attach:]):
3348         * Drosera/mac/DebuggerClient.h:
3349         * Drosera/mac/DebuggerClient.mm:
3350         (-[DebuggerClient initWithServerConnection:]):
3351         (-[DebuggerClient dealloc]):
3352         (-[DebuggerClient windowDidLoad]):
3353         (-[DebuggerClient windowWillClose:]):
3354         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3355         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3356         * Drosera/mac/DebuggerDocumentPlatform.mm:
3357         (DebuggerDocument::platformPause):
3358         (DebuggerDocument::platformResume):
3359         (DebuggerDocument::platformStepInto):
3360         (DebuggerDocument::platformEvaluateScript):
3361         (DebuggerDocument::getPlatformCurrentFunctionStack):
3362         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3363         (DebuggerDocument::platformValueForScopeVariableNamed):
3364         (DebuggerDocument::platformLog):
3365         * Drosera/mac/Drosera.pch: Removed.
3366         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3367         * Drosera/mac/ServerConnection.h: Added.
3368         * Drosera/mac/ServerConnection.mm: Added.
3369         (-[ServerConnection initWithServerName:]):
3370         (-[ServerConnection dealloc]):
3371         (-[ServerConnection setGlobalContext:]):
3372         (-[ServerConnection pause]):
3373         (-[ServerConnection resume]):
3374         (-[ServerConnection stepInto]):
3375         (-[ServerConnection switchToServerNamed:]):
3376         (-[ServerConnection applicationTerminating:]):
3377         (-[ServerConnection serverConnectionDidDie:]):
3378         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3379         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3380         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3381         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3382         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3383         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3384         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3385         (-[ServerConnection currentFrame]):
3386         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3387         (-[ServerConnection knownServers]):
3388
3389 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3390
3391         Reviewed by Eric.
3392
3393         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3394           Script to automatically search nightly builds for regressions (bisect-builds)
3395
3396         * Scripts/bisect-builds: Added.
3397
3398 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3399
3400         Reviewed by Darin.
3401
3402         - New JavaScript benchmark
3403         http://bugs.webkit.org/show_bug.cgi?id=15515
3404
3405         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3406         current development or release build of JavaScriptCore.
3407
3408 2007-10-15  Mark Rowe  <mrowe@apple.com>
3409
3410         Reviewed by Sam.
3411
3412         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3413
3414         * Scripts/webkitdirs.pm:
3415         - Change checkArgv to remove the options from @ARGV to prevent
3416         them from interfering with further option processing.
3417         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3418         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3419         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3420         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3421
3422 2007-10-15  Darin Adler  <darin@apple.com>
3423
3424         Reviewed by Sam.
3425
3426         - added logging of window.prompt and window.confirm
3427
3428         * DumpRenderTree/mac/UIDelegate.mm:
3429         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3430         Implement the recommended delegate rather than the deprecated one.
3431         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3432         Added.
3433         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3434         Added.
3435
3436         * DumpRenderTree/win/UIDelegate.h:
3437         * DumpRenderTree/win/UIDelegate.cpp:
3438         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3439         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3440         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3441         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3442
3443 2007-10-15  Alice Liu  <alice.liu@apple.com>
3444
3445         Reviewed by Sam Weinig.
3446
3447         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3448
3449         * DumpRenderTree/win/DumpRenderTree.cpp:
3450         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3451         (main): allocate the global policy delegate for DRT's custom use
3452         * DumpRenderTree/win/DumpRenderTree.vcproj:
3453         Adding files to project
3454         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3455         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3456         (LayoutTestController::setCustomPolicyDelegate):
3457         set the webview's policy delegate to DRT's custom one if the test requests it.
3458         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3459         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3460         (PolicyDelegate::PolicyDelegate):
3461         (PolicyDelegate::QueryInterface):
3462         (PolicyDelegate::AddRef):
3463         (PolicyDelegate::Release):
3464         (PolicyDelegate::decidePolicyForNavigationAction):
3465         * DumpRenderTree/win/PolicyDelegate.h: Added.
3466         (PolicyDelegate::decidePolicyForNewWindowAction):
3467         (PolicyDelegate::decidePolicyForMIMEType):
3468         (PolicyDelegate::unableToImplementPolicyWithError):
3469
3470 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3471
3472         Reviewed by Mark.
3473
3474         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3475         when querying for QMAKE_MKSPECS.
3476
3477 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3478
3479         Reviewed by Adam Roben.
3480         
3481         Fix run-webkit-tests is too greedy calculating platform hierarchy
3482         http://bugs.webkit.org/show_bug.cgi?id=15465
3483         
3484         Fix run-webkit-tests being too greedy in trying to split the platform name up
3485         causing it to try and find tests in every directory above the first "-" in the
3486         path to the LayoutTests
3487
3488         * Scripts/run-webkit-tests:
3489
3490 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3491
3492         Reviewed by Darin.
3493
3494         http://bugs.webkit.org/show_bug.cgi?id=15006
3495         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3496         to reduce code duplication.
3497
3498         * Scripts/build-webkit:
3499         * Scripts/webkitdirs.pm:
3500         buildQMakeProject() renamed to buildQMakeQtProject().
3501         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3502         unused $colorize has been removed.
3503
3504 === Start merge of feature-branch 2007-10-12 ===
3505
3506 2007-10-08  Eric Seidel  <eric@webkit.org>
3507
3508         Reviewed by Mark Rowe.
3509
3510         * Scripts/build-webkit: add --help, remove unused --color
3511
3512 2007-10-07  Eric Seidel  <eric@webkit.org>
3513
3514         Reviewed by darin.
3515
3516         * Drosera/mac/DebuggerDocumentPlatform.mm:
3517         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3518
3519 2007-10-03  Rob Buis  <buis@kde.org>
3520
3521         Reviewed by Olliej.
3522
3523         Adapt to changed location of Ahem font.
3524
3525         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3526
3527 2007-10-02  Eric Seidel  <eric@webkit.org>
3528
3529         Reviewed by Adam Roben.
3530         
3531         Make pixel tests more useful!
3532         Finally fix the image diff 0.00% mystery problem
3533         Highlight any image differences in the image diff.
3534         Add a link from image diffs back to original test file.
3535
3536         * DumpRenderTree/mac/ImageDiff.m:
3537         (compareImages): highlight any differences
3538         (computePercentageDifferent): round to two decimal places
3539         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3540
3541 2007-10-02  Eric Seidel  <eric@webkit.org>
3542
3543         Reviewed by Alexey Proskuryakov.
3544
3545         * Scripts/run-webkit-tests: print the % image difference on main results page
3546
3547 2007-10-02  Mark Rowe  <mrowe@apple.com>
3548
3549         Reviewed by Oliver.
3550
3551         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3552
3553         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3554         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3555
3556 2007-10-01  Mark Rowe  <mrowe@apple.com>
3557
3558         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3559
3560 2007-09-25  Eric Seidel  <eric@webkit.org>
3561
3562         Reviewed by Mark Rowe.
3563         
3564         DerivedSources.make was finding "ENABLE_SVG" in the string
3565         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3566         quite correctly.
3567
3568         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3569
3570 2007-09-25  Mark Rowe  <mrowe@apple.com>
3571
3572         Rubber-stamped by Eric.
3573
3574         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3575         This makes it possible to automate nightly builds for the feature-branch.
3576
3577 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3578
3579         Rubber stamped by Mark.
3580
3581         Enable svg experimental features as default here in feature-branch.
3582
3583         * Scripts/build-webkit:
3584
3585 2007-06-29  Antti Koivisto  <antti@apple.com>
3586
3587         Reviewed by Weinig.
3588         
3589         Add VIDEO flag for timed media features
3590
3591         * Scripts/build-webkit
3592         
3593 === End merge of feature-branch 2007-10-12 ===
3594
3595 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3596
3597         Reviewed by Darin.
3598
3599         - Updated rational for the leaks list to be more clear.
3600
3601         * Scripts/run-webkit-tests:
3602
3603 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3604
3605         Rubber Stamp by Sam.
3606
3607         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3608         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3609
3610         * Scripts/run-webkit-tests:
3611
3612 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3613
3614         Reviewed by Lars.
3615
3616         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3617         includes are needed for INT_MAX, std::auto_ptr and the like.
3618
3619         * DumpRenderTree/qt/main.cpp:
3620
3621 2007-10-09  Lars Knoll  <lars@trolltech.com>
3622
3623         Reviewed by Simon.
3624
3625         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3626
3627         * DumpRenderTree/qt/jsobjects.cpp:
3628         (LayoutTestController::encodeHostName):
3629         (LayoutTestController::decodeHostName):
3630         * DumpRenderTree/qt/jsobjects.h:
3631
3632 2007-10-09  Lars Knoll  <lars@trolltech.com>
3633
3634         Reviewed by Simon.
3635
3636         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3637
3638         * DumpRenderTree/qt/DumpRenderTree.cpp:
3639         (WebCore::WebPage::createFrame):
3640         (WebCore::DumpRenderTree::DumpRenderTree):
3641         (WebCore::DumpRenderTree::titleChanged):
3642         * DumpRenderTree/qt/DumpRenderTree.h:
3643         * DumpRenderTree/qt/jsobjects.cpp:
3644         (LayoutTestController::reset):
3645         * DumpRenderTree/qt/jsobjects.h:
3646
3647 2007-10-09  Lars Knoll  <lars@trolltech.com>
3648
3649         Reviewed by Simon.
3650
3651         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3652
3653         * DumpRenderTree/qt/DumpRenderTree.h:
3654         * DumpRenderTree/qt/jsobjects.cpp:
3655         (LayoutTestController::clearBackForwardList):
3656         * DumpRenderTree/qt/jsobjects.h:
3657
3658 2007-10-09  Lars Knoll  <lars@trolltech.com>
3659
3660         Reviewed by Simon.
3661
3662         make --git-reviewer work again.
3663
3664         * Scripts/prepare-ChangeLog:
3665
3666 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3667
3668         Rubber stamped by Eric.
3669
3670         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3671         show the current link inside the statusbar.
3672         This shows how to make use of this signal and allows to easily test
3673         http://bugs.webkit.org/show_bug.cgi?id=15299.
3674
3675         * GtkLauncher/main.cpp:
3676         (hoveringOverLink):
3677         (main):
3678
3679 2007-10-05  Lars Knoll  <lars@trolltech.com>
3680
3681         add proper error messages to the FrameLoaderClient.
3682         Implement ChromeClientQt::closeWindowSoon and
3683         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3684         Some fixes in DRT to make it work correctly with multiple windows.
3685
3686         Reviewed by Maciej.
3687
3688         * DumpRenderTree/qt/DumpRenderTree.cpp:
3689         (WebCore::DumpRenderTree::DumpRenderTree):
3690         (WebCore::DumpRenderTree::createWindow):
3691         (WebCore::DumpRenderTree::windowCount):
3692         * DumpRenderTree/qt/DumpRenderTree.h:
3693         * DumpRenderTree/qt/jsobjects.cpp:
3694         (LayoutTestController::maybeDump):
3695         (LayoutTestController::windowCount):
3696         * DumpRenderTree/qt/jsobjects.h:
3697
3698 2007-10-05  Lars Knoll  <lars@trolltech.com>
3699
3700         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3701         Add support for layoutTextController.setCanOpenWindows() to DRT
3702         fixing another 2 test cases in fast/dom/Window.
3703
3704         Reviewed by Maciej.
3705
3706         * DumpRenderTree/qt/DumpRenderTree.cpp:
3707         (WebCore::WebPage::WebPage):
3708         (WebCore::WebPage::createWindow):
3709         (WebCore::DumpRenderTree::resetJSObjects):
3710         (WebCore::DumpRenderTree::createWindow):
3711         * DumpRenderTree/qt/DumpRenderTree.h:
3712         * DumpRenderTree/qt/DumpRenderTree.pro:
3713         * DumpRenderTree/qt/jsobjects.cpp:
3714         (LayoutTestController::LayoutTestController):
3715         (LayoutTestController::reset):
3716         * DumpRenderTree/qt/jsobjects.h:
3717         * DumpRenderTree/qt/main.cpp:
3718         * DumpRenderTree/qt/testplugin.cpp: Added.
3719         * DumpRenderTree/qt/testplugin.h: Added.
3720
3721 2007-10-04  Sam Weinig  <sam@webkit.org>
3722
3723         Rubber stamped by Adam.
3724
3725         Remove empty directories.
3726
3727         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3728         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3729
3730 2007-10-03  Darin Adler  <darin@apple.com>
3731
3732         Reviewed by Adam.
3733
3734         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3735         we find the internal libraries in the libraries directory. This
3736         is helpful for Safari team engineers at Apple.
3737
3738 2007-10-03  Adam Roben  <aroben@apple.com>
3739
3740         Update the location of AHEM___.TTF after r25968
3741
3742         Reviewed by Sam.
3743
3744         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3745
3746 2007-10-03  Alp Toker  <alp@atoker.com>
3747
3748         Reviewed by Adam.
3749
3750         http://bugs.webkit.org/show_bug.cgi?id=14726
3751         [gtk] API design. Mapping the WebView delegates to signals.
3752
3753         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3754
3755         * GtkLauncher/main.cpp:
3756         (goToURLBarText):
3757         (titleChanged):
3758         (progressChanged):
3759         (menuMainBackCallback):
3760         (menuMainForwardCallback):
3761         (main):
3762
3763 2007-10-03  Lars Knoll  <lars@trolltech.com>
3764
3765         Reviewed by Rob.
3766
3767         This fixes --strict mode in run-webkit-tests again after
3768         the platform dependent test results have been moved.
3769
3770         * Scripts/run-webkit-tests:
3771
3772 2007-10-03  Lars Knoll  <lars@trolltech.com>
3773
3774         Reviewed by bdash.
3775
3776         remove the hack in run-webkit-tests that forced text only test
3777         to be taken from the platform independent dir. It was only left
3778         there from early days.
3779         
3780         Remove platform dependent results for tests that are text only nowadays,
3781         and add one platform dependent result for a text only test that requires it.
3782
3783         * Scripts/run-webkit-tests:
3784
3785 2007-10-03  Lars Knoll  <lars@trolltech.com>
3786
3787         Reviewed by olliej.
3788
3789         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3790
3791         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3792         (WebCore::WebFrame::WebFrame):
3793         (WebCore::WebPage::WebPage):
3794         (WebCore::WebPage::createFrame):
3795         (WebCore::WebPage::javaScriptAlert):
3796         (WebCore::WebPage::javaScriptConsoleMessage):
3797         (WebCore::DumpRenderTree::DumpRenderTree):
3798         (WebCore::DumpRenderTree::~DumpRenderTree):
3799         (WebCore::DumpRenderTree::open):
3800         (WebCore::DumpRenderTree::readStdin):
3801         (WebCore::DumpRenderTree::resetJSObjects):
3802         (WebCore::DumpRenderTree::initJSObjects):
3803         (WebCore::DumpRenderTree::dumpFramesAsText):
3804         (WebCore::DumpRenderTree::dump):
3805         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3806         (WebCore::DumpRenderTree::layoutTestController):
3807         (WebCore::DumpRenderTree::eventSender):
3808         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3809         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3810         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3811         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3812         (HackWebFrame::mousePressEvent):
3813         (HackWebFrame::mouseReleaseEvent):
3814         (HackWebFrame::mouseMoveEvent):
3815         (HackWebFrame::HackWebFrame):
3816         (HackWebFrame::~HackWebFrame):
3817         (LayoutTestController::LayoutTestController):
3818         (LayoutTestController::reset):
3819         (LayoutTestController::maybeDump):
3820         (LayoutTestController::waitUntilDone):
3821         (LayoutTestController::notifyDone):
3822         (LayoutTestController::dumpEditingCallbacks):
3823         (LayoutTestController::queueReload):
3824         (LayoutTestController::provisionalLoad):
3825         (LayoutTestController::timerEvent):
3826         (EventSender::EventSender):
3827         (EventSender::mouseDown):
3828         (EventSender::mouseUp):
3829         (EventSender::mouseMoveTo):
3830         (EventSender::leapForward):
3831         (EventSender::keyDown):
3832         (EventSender::frameUnderMouse):
3833         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3834         (LayoutTestController::isLoading):
3835         (LayoutTestController::setLoading):
3836         (LayoutTestController::shouldDumpAsText):
3837         (LayoutTestController::shouldDumpChildrenAsText):
3838         (LayoutTestController::shouldWaitUntilDone):
3839         (LayoutTestController::dumpAsText):
3840         (LayoutTestController::dumpChildFramesAsText):
3841         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3842         (messageHandler):
3843         (crashHandler):
3844         (main):
3845         * Scripts/run-webkit-tests:
3846
3847 2007-10-03  Mark Rowe  <mrowe@apple.com>
3848
3849         Reviewed by Alp Toker.
3850
3851         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3852         should take precedence over QTDIR when determining which port we are working with.
3853
3854         * Scripts/webkitdirs.pm: 
3855
3856 2007-10-02  Adam Roben  <aroben@apple.com>
3857
3858         Add keychain to the list of default packages to install
3859
3860         Rubberstamped by Sam.
3861
3862         * CygwinDownloader/cygwin-downloader.py:
3863         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3864
3865 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3866
3867         Reviewed by Adam.
3868
3869         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3870         Also makes WebCore regression test case logic work when using git.
3871
3872         * Scripts/prepare-ChangeLog:
3873         (reviewerAndDescriptionForGitCommit): Added.
3874
3875 2007-10-02  Lars Knoll  <lars@trolltech.com>
3876
3877         Reviewed by bdash.
3878
3879         Add API to retrieve the frame name from QWebFrame.
3880         Implement support for DRT::dumpChildrenAsText.
3881
3882         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3883         (WebCore::DumpRenderTree::dumpFramesAsText):
3884         (WebCore::DumpRenderTree::dump):
3885         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3886         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3887         (LayoutTestController::LayoutTestController):
3888         (LayoutTestController::reset):
3889         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3890
3891 2007-10-02  Lars Knoll  <lars@trolltech.com>
3892
3893         Reviewed by bdash.
3894
3895         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3896
3897         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3898         (WebCore::DumpRenderTree::readStdin):
3899
3900 2007-10-02  Mark Rowe  <mrowe@apple.com>
3901
3902         Reviewed by Oliver.
3903
3904         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3905
3906         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3907         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3908
3909 2007-10-02  Mark Rowe  <mrowe@apple.com>
3910
3911         Rubber-stamped by Maciej.
3912
3913         Configuration changes from build.webkit.org.  The major change is refactoring to work
3914         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3915         last few weeks.
3916
3917         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3918         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3919         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3920         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3921         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3922         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3923         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3924         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3925
3926 2007-10-02  Lars Knoll  <lars@trolltech.com>
3927
3928         Reviewed by Maciej.
3929
3930         Add support for eventSender.mouseMove to DRT.
3931         Fixes fast/css/hover-affects-child.html
3932
3933         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3934         (EventSender::mouseMoveTo):
3935
3936 2007-10-01  Mark Rowe  <mrowe@apple.com>
3937
3938         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3939
3940 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3941
3942         Reviewed by Hyatt.
3943
3944         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3945
3946         * Scripts/svn-apply:
3947         (gitdiff2svndiff): Ignore lines beginning with "new file".
3948         * Scripts/svn-unapply:
3949         (gitdiff2svndiff): Ditto.
3950
3951 2007-09-30  George Staikos  <staikos@kde.org>
3952
3953         Qt build fix (Mac OS X specific)
3954
3955         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3956
3957 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3958
3959         Reviewed by Mark.
3960
3961         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3962         Remove Bakefiles from svn.
3963
3964         * GtkLauncher/Bakefiles.bkgen: Removed.
3965         * GtkLauncher/ENV: Removed.
3966         * GtkLauncher/gdklauncher.bkl: Removed.
3967         * GtkLauncher/mk: Removed.
3968         * Scripts/regenerate-makefiles: Removed.
3969
3970 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3971
3972         Reviewed by John.
3973
3974         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3975
3976         * Scripts/run-webkit-tests:
3977
3978 2007-09-26  Adam Roben  <aroben@apple.com>
3979
3980         Make not finding an installed WebKit non-fatal
3981
3982         What really matters is that we are able to load WebKit and its
3983         dependencies, not whether we think we've found an installed WebKit.
3984
3985         Reviewed by Sam.
3986
3987         * WebKitInitializer/WebKitInitializer.cpp:
3988         (getWebViewCLSID): Use new LOG_WARNING macro.
3989         (getInstalledWebKitDirectory): Ditto.
3990         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3991         and use new macros.
3992         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3993
3994 2007-09-26  Adam Roben  <aroben@apple.com>
3995
3996         Committed this file before saving it
3997
3998         * WebKitInitializer/debug_internal.vsprops:
3999
4000 2007-09-26  Adam Roben  <aroben@apple.com>
4001
4002         Load WebKit and its dependencies manually so they come from DllDirectory
4003
4004         I had to change WebKitInitializer to use malloc/free instead of
4005         new/delete to avoid pulling in WebKit (and its dependencies) early
4006         through use of fastMalloc.
4007
4008         Reviewed by Oliver.
4009
4010         * WebKitInitializer/WebKitInitializer.cpp:
4011         (getStringValue): Changed to use malloc/free.
4012         (getInstalledWebKitDirectory): Ditto.
4013         (initializeWebKit): Call SetDllDirectory first, then load all of
4014         WebKit's dependencies manually, finally followed by WebKit itself.
4015         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
4016         configuration to match our other projects.
4017         * WebKitInitializer/debug_internal.vsprops: Added.
4018
4019 2007-09-25  Adam Roben  <aroben@apple.com>
4020
4021         Actually define DEBUG/NDEBUG so that we load WebKit correctly
4022
4023         Rubberstamped by Sam.
4024
4025         * WebKitInitializer/WebKitInitializer.vcproj:
4026
4027 2007-09-25  Adam Roben  <aroben@apple.com>
4028
4029         Make DumpRenderTree delay-load its dependencies
4030
4031         This lets WebKitInitializer re-route the dependencies to be loaded out
4032         of the Safari installation directory.
4033
4034         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
4035         same thing), since we can't import the kCFAllocatorDefault symbol when
4036         delay-loading CoreFoundation.dll.
4037
4038         Rubberstamped by Sam.
4039
4040         * DumpRenderTree/win/DumpRenderTree.cpp:
4041         (runTest):
4042         (javaScriptThreads):
4043         * DumpRenderTree/win/DumpRenderTree.vcproj:
4044         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4045         (LayoutTestController::setWaitToDump):
4046
4047 2007-09-25  Adam Roben  <aroben@apple.com>
4048
4049         Pull ole32.lib into WebKitInitializer
4050
4051         Rubberstamped by Sam.
4052
4053         * WebKitInitializer/WebKitInitializer.vcproj:
4054
4055 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
4056
4057         Reviewed by Adam.
4058
4059         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
4060           LGPL'ed files contain incorrect FSF address
4061
4062         * Drosera/config.h:
4063
4064 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
4065
4066         Reviewed by Adam.
4067
4068         Make svn-apply and svn-unapply work with git-diff formatted patches.
4069
4070         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
4071         (gitdiff2svndiff): Added.
4072         * Scripts/svn-unapply: Ditto.
4073         (gitdiff2svndiff): Added.
4074
4075 2007-09-25  Adam Roben  <aroben@apple.com>
4076
4077         Pull advapi32.lib into WebKitInitializer
4078
4079         This is needed to get the registry functions we use.
4080
4081         Rubberstamped by Sam.
4082
4083         * WebKitInitializer/WebKitInitializer.vcproj:
4084
4085 2007-09-25  Adam Roben  <aroben@apple.com>
4086
4087         Add python and rsync to cygwin-downloader
4088
4089         Our build slaves need this, and it can't hurt for everyone else to
4090         have it, too.
4091
4092         Reviewed by Sam.
4093
4094         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
4095         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
4096
4097 2007-09-25  Adam Roben  <aroben@apple.com>
4098
4099         Add WebKitInitializer and use it in DumpRenderTree
4100
4101         WebKitInitializer is a static library that has one function,
4102         initializeWebKit(). This registers WebKit and sets up the DLL search
4103         path so that WebKit's dependencies that are installed with Safari can
4104         be found.
4105
4106         Reviewed by Sam.
4107
4108         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
4109         DumpRenderTree depend on it.
4110         * DumpRenderTree/win/DumpRenderTree.cpp:
4111         (initialize): Call initializeWebKit.
4112         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
4113         WebKitInitializer.lib.
4114         * WebKitInitializer/WebKitInitializer.cpp: Added.
4115         (getStringValue):
4116         (getWebViewCLSID):
4117         (getInstalledWebKitDirectory):
4118         (initializeWebKit):
4119         * WebKitInitializer/WebKitInitializer.h: Added.
4120         * WebKitInitializer/WebKitInitializer.vcproj: Added.
4121         * WebKitInitializer/debug.vsprops: Added.
4122         * WebKitInitializer/release.vsprops: Added.
4123
4124 2007-09-25  Adam Roben  <aroben@apple.com>
4125
4126         Make run-webkit-tests respect set-webkit-configuration
4127
4128         Reviewed by Sam.
4129
4130         * Scripts/run-webkit-tests: Initialize $configuration to whatever
4131         set-webkit-configuration was last set to.
4132
4133 2007-09-25  Mark Rowe  <mrowe@apple.com>
4134
4135         Rubber-stamped by Eric.
4136
4137         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
4138         This makes it possible to automate nightly builds for the feature-branch.
4139
4140 2007-09-25  Adam Roben  <aroben@apple.com>
4141
4142         A couple of fixes/enhancements to update-webkit-*-libs
4143
4144         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
4145         to tell update-webkit-support-libraries where it should find the
4146         WebKitSupportLibrary.zip file you downloaded.
4147
4148         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
4149         Windows-style path.
4150
4151         Reviewed by Sam.
4152
4153         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
4154         to $auxiliaryLibsURL and removed an irrelevant comment.
4155         * Scripts/update-webkit-support-libs:
4156
4157 2007-09-25  Adam Treat  <treat@kde.org>
4158
4159         Reviewed by Simon and Lars.
4160
4161         Refactors and cleans up Qt DRT member variable names, member variable
4162         initialization, style fixes and general code cleanup.
4163
4164         Adds queueReload slot to LayoutTestController that some tests require.
4165
4166         Subclasses QWebFrame to make sure that all frames have an associated
4167         LayoutTestController JS window object.
4168
4169         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
4170         aren't dumped twice.
4171
4172         EOF fixes.
4173
4174         Together, this patch fixes some 20+ layout tests in QtWebKit.
4175
4176         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
4177         (WebCore::WebFrame::WebFrame):
4178         (WebCore::WebPage::WebPage):
4179         (WebCore::WebPage::createFrame):
4180         (WebCore::DumpRenderTree::DumpRenderTree):
4181         (WebCore::DumpRenderTree::open):
4182         (WebCore::DumpRenderTree::readStdin):
4183         (WebCore::DumpRenderTree::initJSObjects):
4184         (WebCore::DumpRenderTree::dump):
4185         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
4186         (WebCore::DumpRenderTree::layoutTestController):
4187         (WebCore::DumpRenderTree::eventSender):
4188         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
4189         (LayoutTestController::LayoutTestController):
4190         (LayoutTestController::reset):
4191         (LayoutTestController::maybeDump):
4192         (LayoutTestController::waitUntilDone):
4193         (LayoutTestController::notifyDone):
4194         (LayoutTestController::queueReload):
4195         (LayoutTestController::provisionalLoad):
4196         (EventSender::EventSender):
4197         (EventSender::mouseDown):
4198         (EventSender::mouseUp):
4199         (EventSender::mouseMoveTo):
4200         (EventSender::frameUnderMouse):
4201         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
4202         (LayoutTestController::isLoading):
4203         (LayoutTestController::setLoading):
4204         (LayoutTestController::dumpAsText):
4205         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
4206         (main):
4207
4208 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
4209
4210
4211         - Reverted an accidentally checked in file.
4212
4213         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
4214
4215 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
4216         Reviewed by Sam.
4217
4218         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
4219
4220         * DumpRenderTree/win/DumpRenderTree.vcproj:
4221         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4222
4223 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
4224
4225         Rubber stamped by Adam.
4226
4227         * GdkLauncher: Removed.
4228         * GdkLauncher/Bakefiles.bkgen: Removed.
4229         * GdkLauncher/ENV: Removed.
4230         * GdkLauncher/GdkLauncher.pro: Removed.
4231         * GdkLauncher/gdklauncher.bkl: Removed.
4232         * GdkLauncher/main.cpp: Removed.
4233         * GdkLauncher/mk: Removed.
4234         * GdkLauncher/simple.svg: Removed.
4235         * GdkLauncher/text.html: Removed.
4236         * GtkLauncher: Added.
4237         * GtkLauncher/GdkLauncher.pro: Removed.
4238         * GtkLauncher/GtkLauncher.pro: Added.
4239         * GtkLauncher/main.cpp:
4240         (updateWindowTitle):
4241         (main):
4242         * Scripts/build-webkit:
4243         * Scripts/regenerate-makefiles:
4244         * Scripts/run-javascriptcore-tests:
4245         * Scripts/run-launcher:
4246         * Scripts/run-webkit-tests:
4247         * Scripts/webkitdirs.pm:
4248
4249 2007-09-21  Timothy Hatcher  <timothy@apple.com>
4250
4251         Reviewed by Darin.
4252
4253         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
4254
4255         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
4256         This is tested by plugins/root-object-premature-delete-crash.html.
4257
4258         * DumpRenderTree/mac/ObjCController.m:
4259         (-[ObjCController accessStoredWebScriptObject]):
4260
4261 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
4262
4263         Reviewed by Oliver.
4264
4265         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
4266
4267         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
4268         (FrameLoadDelegate::FrameLoadDelegate):
4269
4270 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
4271
4272         Reviewed by Adam.
4273
4274         Fix: http://bugs.webkit.org/show_bug.cgi?id=