2010-03-26 Fumitoshi Ukai <ukai@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>
2
3         Reviewed by Shinichiro Hamaji.
4
5         [Chromium-Win] websocket_server.py failed to start
6         https://bugs.webkit.org/show_bug.cgi?id=36586
7         
8         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
9         We don't need stdin, so use devnull as stdin.
10
11         * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
12
13 2010-03-26  Kent Tamura  <tkent@chromium.org>
14
15         Reviewed by Dimitri Glazkov.
16
17         [DRT/Chromium] Add TestNavigationController and TestWebWorker
18         https://bugs.webkit.org/show_bug.cgi?id=36520
19
20         Add LayoutTestController class, which is going to be used by
21         DumpRenderTree Chromium port. These files are based on:
22         - src/webkit/tools/test_shell/layout_test_controller.cc
23         - src/webkit/tools/test_shell/layout_test_controller.h
24         of Chromium rev.40492.
25
26         * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
27         * DumpRenderTree/chromium/LayoutTestController.h: Added.
28
29 2010-03-25  Charlie Reis  <creis@chromium.org>
30
31         Reviewed by Adam Barth.
32
33         onbeforeunload not called at window close + frame or iframe focused
34         https://bugs.webkit.org/show_bug.cgi?id=27481
35
36         Adds a callShouldCloseOnWebView method to LayoutTestController,
37         to allow automated testing for bug 27481.
38
39         * DumpRenderTree/LayoutTestController.cpp:
40         (callShouldCloseOnWebViewCallback):
41         (LayoutTestController::staticFunctions):
42         * DumpRenderTree/LayoutTestController.h:
43         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
44         (LayoutTestController::callShouldCloseOnWebView):
45         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
46         (LayoutTestController::callShouldCloseOnWebView):
47         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
48         (LayoutTestController::callShouldCloseOnWebView):
49         * DumpRenderTree/qt/LayoutTestControllerQt.h:
50         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
51         (LayoutTestController::callShouldCloseOnWebView):
52
53 2010-03-25  Eric Seidel  <eric@webkit.org>
54
55         Reviewed by Adam Barth.
56
57         Add webkit-patch lkgr for finding last known good revision
58         https://bugs.webkit.org/show_bug.cgi?id=36626
59
60         This is rather slow for now because the command
61         has to compute this information from the buildbot.
62         A better long-term solution would be to have a server
63         somewhere store a pre-computed LKGR and then any
64         script (like webkit-patch) could just fetch it.
65
66         * Scripts/webkitpy/common/net/buildbot.py:
67         * Scripts/webkitpy/tool/commands/queries.py:
68
69 2010-03-25  Adam Barth  <abarth@webkit.org>
70
71         Reviewed by Eric Seidel.
72
73         Move modified_changelogs (and friends) from scm to checkout
74         https://bugs.webkit.org/show_bug.cgi?id=36636
75
76         These functions know about ChangeLogs, which is forbidden knowledge in
77         scm.py.
78
79         * Scripts/webkitpy/common/checkout/api.py:
80         * Scripts/webkitpy/common/checkout/changelog.py:
81         * Scripts/webkitpy/common/checkout/scm.py:
82         * Scripts/webkitpy/tool/mocktool.py:
83         * Scripts/webkitpy/tool/steps/abstractstep.py:
84         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
85         * Scripts/webkitpy/tool/steps/revertrevision.py:
86         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
87         * Scripts/webkitpy/tool/steps/validatereviewer.py:
88
89 2010-03-25  Adam Barth  <abarth@webkit.org>
90
91         Reviewed by Eric Seidel.
92
93         Move apply_patch from scm to checkout
94         https://bugs.webkit.org/show_bug.cgi?id=36635
95
96         SCM shouldn't have any knowledge of WebKit scripts.
97
98         * Scripts/webkitpy/common/checkout/api.py:
99         * Scripts/webkitpy/common/checkout/scm.py:
100         * Scripts/webkitpy/common/checkout/scm_unittest.py:
101         * Scripts/webkitpy/tool/mocktool.py:
102         * Scripts/webkitpy/tool/steps/applypatch.py:
103
104 2010-03-25  Eric Seidel  <eric@webkit.org>
105
106         Unreviewed build fix to un-break webkit-patch land.
107         Test-case coming in follow-up commit.
108
109         Move commit_message_for_this_commit from scm to checkout
110         https://bugs.webkit.org/show_bug.cgi?id=36629
111
112         * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
113
114 2010-03-25  Dan Bernstein  <mitz@apple.com>
115
116         Reviewed by Darin Adler.
117
118         <rdar://problem/7728903> Support color bitmap fonts
119
120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
121         and ColorBits-A.png.
122         * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
123         * DumpRenderTree/fonts/ColorBits.ttf: Added.
124         * DumpRenderTree/mac/DumpRenderTree.mm:
125         (activateFonts): Activate ColorBits.ttf.
126
127 2010-03-25  Mark Rowe  <mrowe@apple.com>
128
129         Remove a printf that was causing commit-log-editor to spew the name of the editor
130         to the terminal many times during a commit.
131
132         * Scripts/commit-log-editor:
133
134 2010-03-25  Adam Barth  <abarth@webkit.org>
135
136         Reviewed by Eric Seidel.
137
138         Move commit_message_for_this_commit from scm to checkout
139         https://bugs.webkit.org/show_bug.cgi?id=36629
140
141         This function requires knowledge of ChangeLogs, but scm shouldn't know
142         about ChangeLogs.
143
144         * Scripts/webkitpy/common/checkout/api.py:
145         * Scripts/webkitpy/common/checkout/scm.py:
146         * Scripts/webkitpy/tool/commands/upload.py:
147         * Scripts/webkitpy/tool/commands/upload_unittest.py:
148         * Scripts/webkitpy/tool/mocktool.py:
149         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
150         * Scripts/webkitpy/tool/steps/commit.py:
151
152 2010-03-25  Adam Barth  <abarth@webkit.org>
153
154         Reviewed by Eric Seidel.
155
156         REGRESSION: webkit-patch land can't land "rubber-stamped" patches
157         https://bugs.webkit.org/show_bug.cgi?id=36582
158
159         Allow a "-" in rubber stamped.
160
161         * Scripts/webkitpy/tool/steps/validatereviewer.py:
162
163 2010-03-25  Adam Barth  <abarth@webkit.org>
164
165         Unreviewed.  Fix some copyright lines to remove extraneous comma and
166         python directive.
167
168         * Scripts/webkitpy/tool/bot/patchcollection.py:
169         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
170         * Scripts/webkitpy/tool/bot/queueengine.py:
171         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
172         * Scripts/webkitpy/tool/commands/download.py:
173         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
174         * Scripts/webkitpy/tool/commands/queries.py:
175         * Scripts/webkitpy/tool/commands/queues.py:
176         * Scripts/webkitpy/tool/commands/sheriffbot.py:
177         * Scripts/webkitpy/tool/comments.py:
178         * Scripts/webkitpy/tool/grammar.py:
179         * Scripts/webkitpy/tool/multicommandtool.py:
180         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
181
182 2010-03-25  Simon Fraser  <simon.fraser@apple.com>
183
184         Reviewed by Darin Adler, Alexey Proskuryakov.
185
186         https://bugs.webkit.org/show_bug.cgi?id=36631
187         Allow the test plugin to run scripts in response to NPP_SetWindow calls
188         
189         Hook up the ability for the TestNetscapePlugIn to run JavaScript in
190         response to NPP_SetWindow.
191         
192         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
193         (pluginAllocate):
194         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
195         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
196         (NPP_New):
197         (NPP_Destroy):
198         (NPP_SetWindow):
199
200 2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
201
202         Unreviewed, build fix.
203
204         [Qt] Fix QtLauncher guards.
205
206         * QtLauncher/main.cpp:
207         (LauncherWindow::showFPS):
208         (LauncherWindow::updateFPS):
209
210 2010-03-25  Yury Semikhatsky  <yurys@chromium.org>
211
212         Reviewed by Pavel Feldman.
213
214         Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
215
216         https://bugs.webkit.org/show_bug.cgi?id=36610
217
218         * DumpRenderTree/LayoutTestController.h:
219         * DumpRenderTree/gtk/DumpRenderTree.cpp:
220         (shouldEnableDeveloperExtras):
221         (runTest):
222         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
223         (LayoutTestController::setJavaScriptProfilingEnabled):
224         (LayoutTestController::setDeveloperExtrasEnabled):
225         (LayoutTestController::showWebInspector):
226         (LayoutTestController::closeWebInspector):
227         * DumpRenderTree/mac/DumpRenderTree.mm:
228         (shouldEnableDeveloperExtras):
229         (runTest):
230         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
231         (LayoutTestController::setJavaScriptProfilingEnabled):
232         (LayoutTestController::setDeveloperExtrasEnabled):
233         (LayoutTestController::showWebInspector):
234         (LayoutTestController::closeWebInspector):
235         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
236         (WebCore::shouldEnableDeveloperExtras):
237         (WebCore::DumpRenderTree::open):
238         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
239         (LayoutTestController::closeWebInspector):
240         (LayoutTestController::setDeveloperExtrasEnabled):
241         (LayoutTestController::showWebInspector):
242         (LayoutTestController::setJavaScriptProfilingEnabled):
243         * DumpRenderTree/win/DumpRenderTree.cpp:
244         (shouldEnableDeveloperExtras):
245         (runTest):
246         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
247         (LayoutTestController::setJavaScriptProfilingEnabled):
248         (LayoutTestController::setDeveloperExtrasEnabled):
249         (LayoutTestController::showWebInspector):
250         (LayoutTestController::closeWebInspector):
251
252 2010-03-25  Adam Barth  <abarth@webkit.org>
253
254         Rubber stamped by Eric Seidel.
255
256         Tweaks to sheriffbot to improve latency by keeping the working copy up
257         to date even when there's no build break.  Also, officially move
258         sheriffbot to #webkit.
259
260         (Also teach ValidateReviewer to understand rubber stamps.)
261
262         * Scripts/webkitpy/common/net/irc/ircbot.py:
263         * Scripts/webkitpy/tool/commands/sheriffbot.py:
264         * Scripts/webkitpy/tool/steps/validatereviewer.py:
265
266 2010-03-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
267
268         Reviewed by Simon Hausmann.
269
270         Not displaying FPS info on the terminal. On S60 and Maemo the
271         Window title will be used and Status bar will used on desktop.
272
273         [Qt] QtLauncher's FPS info should not be displayed on the terminal
274         https://bugs.webkit.org/show_bug.cgi?id=36244
275
276         * QtLauncher/main.cpp:
277         (LauncherWindow::initializeView):
278         (LauncherWindow::showFPS):
279         (LauncherWindow::updateFPS):
280         * QtLauncher/webview.cpp:
281         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
282         (WebViewGraphicsBased::updateFrameRate):
283         * QtLauncher/webview.h:
284         (WebViewGraphicsBased::frameRateMeasurementEnabled):
285
286 2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>
287
288         Reviewed by Kenneth Christiansen.
289
290         Added missing frame flattening activation on
291         fast/frames/flattening/frameset-flattening-grid.html;
292         removed unnecessary CONSOLE MESSAGE from the expected file;
293         reset the setFrameSetFlatteningEnabled for each test.
294
295         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
296         (WebCore::WebPage::resetSettings):
297
298 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
299
300         Reviewed by Adam Barth.
301
302         Moved deprecated_logging unit test import statement from
303         webkitpy/unittests.py to webkitpy/common/system/unittests.py.
304
305         https://bugs.webkit.org/show_bug.cgi?id=36093
306
307         This is part of the master bug to reorganize webkitpy.
308
309         * Scripts/webkitpy/common/system/unittests.py:
310         * Scripts/webkitpy/unittests.py:
311
312 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
313
314         Reviewed by Adam Barth.
315
316         Moved webkit_logging.py to common/system/deprecated_logging.py
317         inside webkitpy.
318
319         https://bugs.webkit.org/show_bug.cgi?id=36093
320
321         This is part of the master bug to reorganize webkitpy.
322
323         * Scripts/validate-committer-lists:
324         * Scripts/webkitpy/common/checkout/changelog.py:
325         * Scripts/webkitpy/common/checkout/scm.py:
326         * Scripts/webkitpy/common/net/bugzilla.py:
327         * Scripts/webkitpy/common/net/buildbot.py:
328         * Scripts/webkitpy/common/net/credentials.py:
329         * Scripts/webkitpy/common/net/irc/ircproxy.py:
330         * Scripts/webkitpy/common/net/networktransaction.py:
331         * Scripts/webkitpy/common/net/statusserver.py:
332         * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
333         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
334         * Scripts/webkitpy/common/system/executive.py:
335         * Scripts/webkitpy/tool/bot/queueengine.py:
336         * Scripts/webkitpy/tool/commands/download.py:
337         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
338         * Scripts/webkitpy/tool/commands/openbugs.py:
339         * Scripts/webkitpy/tool/commands/queries.py:
340         * Scripts/webkitpy/tool/commands/queues.py:
341         * Scripts/webkitpy/tool/commands/sheriffbot.py:
342         * Scripts/webkitpy/tool/commands/stepsequence.py:
343         * Scripts/webkitpy/tool/commands/upload.py:
344         * Scripts/webkitpy/tool/main.py:
345         * Scripts/webkitpy/tool/mocktool.py:
346         * Scripts/webkitpy/tool/multicommandtool.py:
347         * Scripts/webkitpy/tool/steps/abstractstep.py:
348         * Scripts/webkitpy/tool/steps/applypatch.py:
349         * Scripts/webkitpy/tool/steps/build.py:
350         * Scripts/webkitpy/tool/steps/checkstyle.py:
351         * Scripts/webkitpy/tool/steps/closebug.py:
352         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
353         * Scripts/webkitpy/tool/steps/confirmdiff.py:
354         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
355         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
356         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
357         * Scripts/webkitpy/tool/steps/preparechangelog.py:
358         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
359         * Scripts/webkitpy/tool/steps/runtests.py:
360         * Scripts/webkitpy/tool/steps/update.py:
361         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
362         * Scripts/webkitpy/tool/steps/validatereviewer.py:
363         * Scripts/webkitpy/unittests.py:
364         * Scripts/webkitpy/webkit_logging.py: Removed.
365         * Scripts/webkitpy/webkit_logging_unittest.py: Removed.
366
367 2010-03-25  Julien Chaffraix  <jchaffraix@webkit.org>
368
369         Reviewed by Kenneth Rohde Christiansen.
370
371         commit-log-editor can call itself in an infinite loop
372         https://bugs.webkit.org/show_bug.cgi?id=35291
373
374         if $editor ends up being commit-log-editor, the script will exec itself
375         in an infinite loop.
376
377         To avoid this, we now check that the $editor variable is not
378         commit-log-editor to avoid this case.
379
380         * Scripts/commit-log-editor: Added an isCommitLogEditor method and
381         reworked the $editor setting to add this check.
382
383 2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
384
385         Reviewed by Kenneth Rohde Christiansen.
386
387         Add a Toggle Frame Flattening option to QtLauncher.
388         It will be enabled by default on Maemo5 and S60 platforms.
389
390         [Qt] Add enable/disable Frame Flattening option to QtLauncher
391         https://bugs.webkit.org/show_bug.cgi?id=36558
392
393         * QtLauncher/main.cpp:
394         (LauncherWindow::applyPrefs):
395         (LauncherWindow::toggleFrameFlattening):
396         (LauncherWindow::createChrome):
397
398 2010-03-25  Zoltan Horvath  <zoltan@webkit.org>
399
400         Reviewed by Eric Seidel.
401
402         svn-create-patch prints a warning for large patches
403         https://bugs.webkit.org/show_bug.cgi?id=32582
404
405         svn-create-patch prints a warning message for larger patches than 20k.
406
407         * Scripts/svn-create-patch:
408
409 2010-03-25  Adam Barth  <abarth@webkit.org>
410
411         Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
412         https://bugs.webkit.org/show_bug.cgi?id=36093
413
414         * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
415         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
416         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
417         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
418         * Scripts/webkitpy/tool/main.py:
419         * Scripts/webkitpy/tool/unittests.py:
420
421 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
422
423         Reviewed by Adam Barth.
424
425         In webkitpy, pushed the unit test import statements in
426         webkitpy/unittests.py into appropriate unittests.py files in the
427         new root-level packages beneath webkitpy.
428
429         https://bugs.webkit.org/show_bug.cgi?id=36093
430
431         This is part of the master bug to reorganize webkitpy.
432
433         * Scripts/webkitpy/common/system/unittests.py:
434         * Scripts/webkitpy/common/unittests.py: Added.
435         * Scripts/webkitpy/python24/unittests.py: Added.
436         * Scripts/webkitpy/tool/unittests.py: Added.
437         * Scripts/webkitpy/unittests.py:
438
439 2010-03-25  Adam Barth  <abarth@webkit.org>
440
441         Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
442         package.
443         https://bugs.webkit.org/show_bug.cgi?id=36093
444
445         * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
446         * Scripts/webkitpy/tool/main.py:
447         * Scripts/webkitpy/tool/mocktool.py:
448         * Scripts/webkitpy/webkitcheckout.py: Removed.
449
450 2010-03-25  Adam Barth  <abarth@webkit.org>
451
452         Unreviewed.  Move OutputCapture to webkitpy.common.system.
453         https://bugs.webkit.org/show_bug.cgi?id=36093
454
455         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
456         * Scripts/webkitpy/common/net/credentials_unittest.py:
457         * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
458         * Scripts/webkitpy/outputcapture.py: Removed.
459         * Scripts/webkitpy/tool/commands/commandtest.py:
460         * Scripts/webkitpy/tool/commands/queues_unittest.py:
461         * Scripts/webkitpy/tool/commands/queuestest.py:
462         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
463         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
464         * Scripts/webkitpy/tool/steps/steps_unittest.py:
465         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
466
467 2010-03-25  Adam Barth  <abarth@webkit.org>
468
469         Unreviewed.  Move user.py to webkitpy.common.system.
470
471         * Scripts/webkitpy/common/checkout/scm.py:
472         * Scripts/webkitpy/common/net/bugzilla.py:
473         * Scripts/webkitpy/common/net/credentials.py:
474         * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
475         * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
476         * Scripts/webkitpy/tool/commands/upload.py:
477         * Scripts/webkitpy/tool/main.py:
478         * Scripts/webkitpy/unittests.py:
479         * Scripts/webkitpy/user.py: Removed.
480         * Scripts/webkitpy/user_unittest.py: Removed.
481
482 2010-03-25  Adam Barth  <abarth@webkit.org>
483
484         Unreviewed.  Move executive.py to webkitpy.common.system.
485         https://bugs.webkit.org/show_bug.cgi?id=36093
486
487         * Scripts/webkitpy/common/checkout/scm.py:
488         * Scripts/webkitpy/common/checkout/scm_unittest.py:
489         * Scripts/webkitpy/common/config/ports.py:
490         * Scripts/webkitpy/common/config/ports_unittest.py:
491         * Scripts/webkitpy/common/net/credentials.py:
492         * Scripts/webkitpy/common/net/credentials_unittest.py:
493         * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
494         * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
495         * Scripts/webkitpy/executive.py: Removed.
496         * Scripts/webkitpy/executive_unittest.py: Removed.
497         * Scripts/webkitpy/layout_tests/port/mac.py:
498         * Scripts/webkitpy/tool/bot/queueengine.py:
499         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
500         * Scripts/webkitpy/tool/commands/download.py:
501         * Scripts/webkitpy/tool/commands/early_warning_system.py:
502         * Scripts/webkitpy/tool/commands/queues.py:
503         * Scripts/webkitpy/tool/commands/stepsequence.py:
504         * Scripts/webkitpy/tool/main.py:
505         * Scripts/webkitpy/tool/steps/checkstyle.py:
506         * Scripts/webkitpy/tool/steps/preparechangelog.py:
507         * Scripts/webkitpy/unittests.py:
508         * Scripts/webkitpy/webkit_logging_unittest.py:
509
510 2010-03-25  Adam Barth  <abarth@webkit.org>
511
512         Unreviewed.  Move grammary.py into webkitpy.tool.
513         https://bugs.webkit.org/show_bug.cgi?id=36093
514
515         * Scripts/webkitpy/grammar.py: Removed.
516         * Scripts/webkitpy/grammar_unittest.py: Removed.
517         * Scripts/webkitpy/tool/commands/download.py:
518         * Scripts/webkitpy/tool/commands/queries.py:
519         * Scripts/webkitpy/tool/commands/queues.py:
520         * Scripts/webkitpy/tool/commands/upload.py:
521         * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
522         * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
523         * Scripts/webkitpy/tool/multicommandtool.py:
524         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
525         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
526         * Scripts/webkitpy/unittests.py:
527
528 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
529
530         Reviewed by Adam Barth.
531
532         In webkitpy, moved init/ to common/system/.
533
534         https://bugs.webkit.org/show_bug.cgi?id=36093
535
536         This is part of the master bug to reorganize webkitpy.
537
538         * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
539         * Scripts/webkitpy/common/system/logutils.py:
540         * Scripts/webkitpy/common/system/logutils_unittest.py:
541         * Scripts/webkitpy/init: Removed.
542         * Scripts/webkitpy/init/__init__.py: Removed.
543         * Scripts/webkitpy/init/logtesting.py: Removed.
544         * Scripts/webkitpy/init/logutils.py: Removed.
545         * Scripts/webkitpy/init/logutils_unittest.py: Removed.
546         * Scripts/webkitpy/init/unittests.py: Removed.
547         * Scripts/webkitpy/python24/versioning_unittest.py:
548         * Scripts/webkitpy/style_references.py:
549         * Scripts/webkitpy/unittests.py:
550
551 2010-03-25  Adam Barth  <abarth@webkit.org>
552
553         Unreviewed.  Move stepsequence to webkitpy.tool.commands.
554         https://bugs.webkit.org/show_bug.cgi?id=36093
555
556         * Scripts/webkitpy/stepsequence.py: Removed.
557         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
558         * Scripts/webkitpy/tool/commands/download.py:
559         * Scripts/webkitpy/tool/commands/queues.py:
560         * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
561
562 2010-03-25  Adam Barth  <abarth@webkit.org>
563
564         Unreviewed.  Create webkitpy.common.checkout as described in
565         https://bugs.webkit.org/show_bug.cgi?id=36093
566
567         * Scripts/webkitpy/changelogs.py: Removed.
568         * Scripts/webkitpy/changelogs_unittest.py: Removed.
569         * Scripts/webkitpy/commitinfo.py: Removed.
570         * Scripts/webkitpy/commitinfo_unittest.py: Removed.
571         * Scripts/webkitpy/common/checkout: Added.
572         * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
573         * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
574         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
575         * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
576         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
577         * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
578         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
579         * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
580         * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
581         * Scripts/webkitpy/common/net/credentials.py:
582         * Scripts/webkitpy/diff_parser.py: Removed.
583         * Scripts/webkitpy/diff_parser_unittest.py: Removed.
584         * Scripts/webkitpy/layout_tests/port/base.py:
585         * Scripts/webkitpy/scm.py: Removed.
586         * Scripts/webkitpy/scm_unittest.py: Removed.
587         * Scripts/webkitpy/stepsequence.py:
588         * Scripts/webkitpy/style_references.py:
589         * Scripts/webkitpy/tool/commands/download.py:
590         * Scripts/webkitpy/tool/commands/queries.py:
591         * Scripts/webkitpy/tool/comments.py:
592         * Scripts/webkitpy/tool/main.py:
593         * Scripts/webkitpy/tool/mocktool.py:
594         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
595         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
596         * Scripts/webkitpy/tool/steps/validatereviewer.py:
597         * Scripts/webkitpy/unittests.py:
598         * Scripts/webkitpy/webkitcheckout.py:
599
600 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
601
602         Reviewed by Adam Barth.
603
604         In webkitpy, moved init/versioning.py to python24/.
605
606         https://bugs.webkit.org/show_bug.cgi?id=36093
607
608         This is part of the master bug to reorganize webkitpy.
609
610         * Scripts/test-webkitpy:
611         * Scripts/webkit-patch:
612         * Scripts/webkitpy/init/unittests.py:
613         * Scripts/webkitpy/init/versioning.py: Removed.
614         * Scripts/webkitpy/init/versioning_unittest.py: Removed.
615         * Scripts/webkitpy/python24: Added.
616         * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
617         * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
618         * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
619         * Scripts/webkitpy/unittests.py:
620
621 2010-03-25  Adam Barth  <abarth@webkit.org>
622
623         Unreviewed.
624
625         Create webkitpy.common.net as described in
626         https://bugs.webkit.org/show_bug.cgi?id=36093
627
628         * Scripts/webkitpy/bugzilla.py: Removed.
629         * Scripts/webkitpy/bugzilla_unittest.py: Removed.
630         * Scripts/webkitpy/buildbot.py: Removed.
631         * Scripts/webkitpy/buildbot_unittest.py: Removed.
632         * Scripts/webkitpy/commitinfo.py:
633         * Scripts/webkitpy/common/net: Added.
634         * Scripts/webkitpy/common/net/__init__.py: Added.
635         * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
636         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
637         * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
638         * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
639         * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
640         * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
641         * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
642         * Scripts/webkitpy/common/net/irc/ircbot.py:
643         * Scripts/webkitpy/common/net/irc/ircproxy.py:
644         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
645         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
646         * Scripts/webkitpy/common/net/irc/unittests.py:
647         * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
648         * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
649         * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
650         * Scripts/webkitpy/credentials.py: Removed.
651         * Scripts/webkitpy/credentials_unittest.py: Removed.
652         * Scripts/webkitpy/irc: Removed.
653         * Scripts/webkitpy/irc/__init__.py: Removed.
654         * Scripts/webkitpy/irc/ircbot.py: Removed.
655         * Scripts/webkitpy/irc/ircproxy.py: Removed.
656         * Scripts/webkitpy/irc/messagepump.py: Removed.
657         * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
658         * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
659         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
660         * Scripts/webkitpy/irc/unittests.py: Removed.
661         * Scripts/webkitpy/networktransaction.py: Removed.
662         * Scripts/webkitpy/networktransaction_unittest.py: Removed.
663         * Scripts/webkitpy/scm_unittest.py:
664         * Scripts/webkitpy/statusserver.py: Removed.
665         * Scripts/webkitpy/tool/bot/queueengine.py:
666         * Scripts/webkitpy/tool/commands/download.py:
667         * Scripts/webkitpy/tool/commands/queries.py:
668         * Scripts/webkitpy/tool/commands/queries_unittest.py:
669         * Scripts/webkitpy/tool/commands/queues.py:
670         * Scripts/webkitpy/tool/commands/queues_unittest.py:
671         * Scripts/webkitpy/tool/commands/queuestest.py:
672         * Scripts/webkitpy/tool/commands/upload.py:
673         * Scripts/webkitpy/tool/main.py:
674         * Scripts/webkitpy/tool/mocktool.py:
675         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
676         * Scripts/webkitpy/unittests.py:
677
678 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
679
680         Reviewed by Adam Barth.
681
682         In webkitpy, renamed MockBugzillaTool to MockTool.
683
684         * Scripts/webkitpy/tool/commands/commandtest.py:
685         * Scripts/webkitpy/tool/commands/queries_unittest.py:
686         * Scripts/webkitpy/tool/commands/queues_unittest.py:
687         * Scripts/webkitpy/tool/commands/queuestest.py:
688         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
689         * Scripts/webkitpy/tool/commands/upload_unittest.py:
690         * Scripts/webkitpy/tool/mocktool.py:
691         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
692         * Scripts/webkitpy/tool/steps/steps_unittest.py:
693         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
694
695 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
696
697         Reviewed by Adam Barth.
698
699         In Scripts/webkitpy, moved webkitport.py and committers.py into
700         common/config/ (also creating common/config/).
701
702         https://bugs.webkit.org/show_bug.cgi?id=36093
703
704         This is part of the master bug to reorganize webkitpy.
705
706         * Scripts/validate-committer-lists:
707         * Scripts/webkitpy/bugzilla.py:
708         * Scripts/webkitpy/bugzilla_unittest.py:
709         * Scripts/webkitpy/changelogs.py:
710         * Scripts/webkitpy/commitinfo.py:
711         * Scripts/webkitpy/commitinfo_unittest.py:
712         * Scripts/webkitpy/committers.py: Removed.
713         * Scripts/webkitpy/committers_unittest.py: Removed.
714         * Scripts/webkitpy/common: Added.
715         * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
716         * Scripts/webkitpy/common/config: Added.
717         * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
718         * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
719         * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
720         * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
721         * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
722         * Scripts/webkitpy/mock_bugzillatool.py:
723         * Scripts/webkitpy/tool/commands/early_warning_system.py:
724         * Scripts/webkitpy/tool/commands/queries.py:
725         * Scripts/webkitpy/tool/commands/sheriffbot.py:
726         * Scripts/webkitpy/tool/commands/upload.py:
727         * Scripts/webkitpy/tool/steps/abstractstep.py:
728         * Scripts/webkitpy/unittests.py:
729         * Scripts/webkitpy/webkitport.py: Removed.
730         * Scripts/webkitpy/webkitport_unittest.py: Removed.
731
732 2010-03-25  Adam Barth  <abarth@webkit.org>
733
734         Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
735
736         * Scripts/webkitpy/mock_bugzillatool.py: Removed.
737         * Scripts/webkitpy/tool/commands/commandtest.py:
738         * Scripts/webkitpy/tool/commands/queries_unittest.py:
739         * Scripts/webkitpy/tool/commands/queues_unittest.py:
740         * Scripts/webkitpy/tool/commands/queuestest.py:
741         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
742         * Scripts/webkitpy/tool/commands/upload_unittest.py:
743         * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
744         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
745         * Scripts/webkitpy/tool/steps/steps_unittest.py:
746         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
747
748 2010-03-24  Adam Barth  <abarth@webkit.org>
749
750         Unreviewed.  Move comments.py and multicommandtool.py to their new
751         home.
752
753         * Scripts/webkitpy/comments.py: Removed.
754         * Scripts/webkitpy/multicommandtool.py: Removed.
755         * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
756         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
757         * Scripts/webkitpy/tool/commands/download.py:
758         * Scripts/webkitpy/tool/commands/openbugs.py:
759         * Scripts/webkitpy/tool/commands/queries.py:
760         * Scripts/webkitpy/tool/commands/queues.py:
761         * Scripts/webkitpy/tool/commands/upload.py:
762         * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
763         * Scripts/webkitpy/tool/main.py:
764         * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
765         * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
766         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
767         * Scripts/webkitpy/tool/steps/closepatch.py:
768         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
769         * Scripts/webkitpy/unittests.py:
770
771 2010-03-24  Adam Barth  <abarth@webkit.org>
772
773         Unreviewed.  Fixup one import statement I didn't find because the .pyc
774         masked the error.
775
776         * Scripts/webkitpy/stepsequence.py:
777
778 2010-03-24  Adam Barth  <abarth@webkit.org>
779
780         Unreviewed.  Move queueengine.py to its new home.
781
782         * Scripts/webkitpy/queueengine.py: Removed.
783         * Scripts/webkitpy/queueengine_unittest.py: Removed.
784         * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
785         * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
786         * Scripts/webkitpy/tool/commands/early_warning_system.py:
787         * Scripts/webkitpy/tool/commands/queues.py:
788         * Scripts/webkitpy/unittests.py:
789
790 2010-03-24  Adam Barth  <abarth@webkit.org>
791
792         Unreviewed.  Move patchcollection.py to its new home.
793
794         * Scripts/webkitpy/patchcollection.py: Removed.
795         * Scripts/webkitpy/patchcollection_unittest.py: Removed.
796         * Scripts/webkitpy/tool/bot: Added.
797         * Scripts/webkitpy/tool/bot/__init__.py: Added.
798         * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
799         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
800         * Scripts/webkitpy/tool/commands/queues.py:
801         * Scripts/webkitpy/unittests.py:
802
803 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
804
805         Reviewed by Adam Barth.
806
807         In Scripts/webkitpy, moved steps_references.py and the steps
808         folder into webkitpy/patch.
809
810         https://bugs.webkit.org/show_bug.cgi?id=36093
811
812         * Scripts/webkitpy/steps: Removed.
813         * Scripts/webkitpy/steps/__init__.py: Removed.
814         * Scripts/webkitpy/steps/abstractstep.py: Removed.
815         * Scripts/webkitpy/steps/applypatch.py: Removed.
816         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
817         * Scripts/webkitpy/steps/build.py: Removed.
818         * Scripts/webkitpy/steps/checkstyle.py: Removed.
819         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
820         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
821         * Scripts/webkitpy/steps/closebug.py: Removed.
822         * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
823         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
824         * Scripts/webkitpy/steps/closepatch.py: Removed.
825         * Scripts/webkitpy/steps/commit.py: Removed.
826         * Scripts/webkitpy/steps/confirmdiff.py: Removed.
827         * Scripts/webkitpy/steps/createbug.py: Removed.
828         * Scripts/webkitpy/steps/editchangelog.py: Removed.
829         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
830         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
831         * Scripts/webkitpy/steps/metastep.py: Removed.
832         * Scripts/webkitpy/steps/obsoletepatches.py: Removed.
833         * Scripts/webkitpy/steps/options.py: Removed.
834         * Scripts/webkitpy/steps/postdiff.py: Removed.
835         * Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
836         * Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
837         * Scripts/webkitpy/steps/preparechangelog.py: Removed.
838         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
839         * Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
840         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
841         * Scripts/webkitpy/steps/revertrevision.py: Removed.
842         * Scripts/webkitpy/steps/runtests.py: Removed.
843         * Scripts/webkitpy/steps/steps_unittest.py: Removed.
844         * Scripts/webkitpy/steps/update.py: Removed.
845         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
846         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
847         * Scripts/webkitpy/steps/validatereviewer.py: Removed.
848         * Scripts/webkitpy/steps_references.py: Removed.
849         * Scripts/webkitpy/stepsequence.py:
850         * Scripts/webkitpy/tool/commands/download.py:
851         * Scripts/webkitpy/tool/commands/upload.py:
852         * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
853         * Scripts/webkitpy/tool/steps/__init__.py:
854         * Scripts/webkitpy/tool/steps/applypatch.py:
855         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
856         * Scripts/webkitpy/tool/steps/build.py:
857         * Scripts/webkitpy/tool/steps/checkstyle.py:
858         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
859         * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
860         * Scripts/webkitpy/tool/steps/closebug.py:
861         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
862         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
863         * Scripts/webkitpy/tool/steps/closepatch.py:
864         * Scripts/webkitpy/tool/steps/commit.py:
865         * Scripts/webkitpy/tool/steps/confirmdiff.py:
866         * Scripts/webkitpy/tool/steps/createbug.py:
867         * Scripts/webkitpy/tool/steps/editchangelog.py:
868         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
869         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
870         * Scripts/webkitpy/tool/steps/metastep.py:
871         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
872         * Scripts/webkitpy/tool/steps/postdiff.py:
873         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
874         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
875         * Scripts/webkitpy/tool/steps/preparechangelog.py:
876         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
877         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
878         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
879         * Scripts/webkitpy/tool/steps/revertrevision.py:
880         * Scripts/webkitpy/tool/steps/runtests.py:
881         * Scripts/webkitpy/tool/steps/steps_unittest.py:
882         * Scripts/webkitpy/tool/steps/update.py:
883         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
884         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
885         * Scripts/webkitpy/tool/steps/validatereviewer.py:
886         * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
887         * Scripts/webkitpy/unittests.py:
888
889 2010-03-24  Eric Seidel  <eric@webkit.org>
890
891         Unreviewed, build fix only.
892
893         Abstract LayoutTestResults logic for easier reuse
894         https://bugs.webkit.org/show_bug.cgi?id=36579
895
896         * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
897
898 2010-03-24  Adam Barth  <abarth@webkit.org>
899
900         Unreviewed.  Fix a stray comma to test landing an patch without review.
901
902         * Scripts/webkitpy/commitinfo.py:
903
904 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
905
906         Reviewed by Adam Barth.
907
908         In Scripts/webkitpy, moved commands_references.py and the commands
909         folder into webkitpy/patch.
910
911         https://bugs.webkit.org/show_bug.cgi?id=36483
912
913         This is part of master bug 36093 to organize webkitpy.
914
915         * Scripts/webkitpy/commands: Removed.
916         * Scripts/webkitpy/commands/__init__.py: Removed.
917         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
918         * Scripts/webkitpy/commands/commandtest.py: Removed.
919         * Scripts/webkitpy/commands/download.py: Removed.
920         * Scripts/webkitpy/commands/download_unittest.py: Removed.
921         * Scripts/webkitpy/commands/early_warning_system.py: Removed.
922         * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
923         * Scripts/webkitpy/commands/openbugs.py: Removed.
924         * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
925         * Scripts/webkitpy/commands/queries.py: Removed.
926         * Scripts/webkitpy/commands/queries_unittest.py: Removed.
927         * Scripts/webkitpy/commands/queues.py: Removed.
928         * Scripts/webkitpy/commands/queues_unittest.py: Removed.
929         * Scripts/webkitpy/commands/queuestest.py: Removed.
930         * Scripts/webkitpy/commands/sheriffbot.py: Removed.
931         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
932         * Scripts/webkitpy/commands/upload.py: Removed.
933         * Scripts/webkitpy/commands/upload_unittest.py: Removed.
934         * Scripts/webkitpy/commands_references.py: Removed.
935         * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
936         * Scripts/webkitpy/tool/commands/commandtest.py:
937         * Scripts/webkitpy/tool/commands/download.py:
938         * Scripts/webkitpy/tool/commands/download_unittest.py:
939         * Scripts/webkitpy/tool/commands/early_warning_system.py:
940         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
941         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
942         * Scripts/webkitpy/tool/commands/queries_unittest.py:
943         * Scripts/webkitpy/tool/commands/queues_unittest.py:
944         * Scripts/webkitpy/tool/commands/queuestest.py:
945         * Scripts/webkitpy/tool/commands/sheriffbot.py:
946         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
947         * Scripts/webkitpy/tool/commands/upload.py:
948         * Scripts/webkitpy/tool/commands/upload_unittest.py:
949         * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
950         * Scripts/webkitpy/tool/main.py:
951         * Scripts/webkitpy/unittests.py:
952
953 2010-03-24  Adam Barth  <abarth@webkit.org>
954
955         Reviewed by Eric Seidel.
956
957         Rename webkitpy.patch to webkitpy.tool
958         https://bugs.webkit.org/show_bug.cgi?id=36580
959
960         This is in preparation for the great webkitpy naming cleanup.
961
962         * Scripts/webkit-patch:
963         * Scripts/webkitpy/patch: Removed.
964         * Scripts/webkitpy/patch/__init__.py: Removed.
965         * Scripts/webkitpy/patch/patcher.py: Removed.
966         * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
967         * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
968         * Scripts/webkitpy/tool/patcher.py: Removed.
969
970 2010-03-24  Eric Seidel  <eric@webkit.org>
971
972         Reviewed by Adam Barth.
973
974         Abstract LayoutTestResults logic for easier reuse
975         https://bugs.webkit.org/show_bug.cgi?id=36579
976
977         * Scripts/webkitpy/buildbot.py:
978          - Split out logic into new LayoutTestResults class.
979         * Scripts/webkitpy/buildbot_unittest.py:
980          - Rename the testing class to match.
981         * Scripts/webkitpy/commands/queries.py:
982          - Use the new LayoutTestResults class.
983
984 2010-03-24  Eric Seidel  <eric@webkit.org>
985
986         Reviewed by Eric Seidel.
987
988         Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
989         https://bugs.webkit.org/show_bug.cgi?id=36577
990
991         * Scripts/webkitpy/bugzilla.py:
992          - Move prompt_for_component to User
993         * Scripts/webkitpy/commands/queries.py:
994          - Add a missing argument_names declaration.
995         * Scripts/webkitpy/user.py:
996          - Add prompt_with_list
997          - Make staticmethods classmethods for easier mocking
998
999 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1000
1001         <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
1002
1003         Reviewed by Eric Seidel.
1004
1005         Fixes the following error when committing a file with
1006         "ChangeLog" in the name that isn't a ChangeLog (like
1007         mergeChangeLogs.pl from r56471 and r56472):
1008
1009             $ git commit .
1010             Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
1011             error: There was a problem with the editor 'commit-log-editor'.
1012             Please supply the message using either -m or -F option.
1013
1014         * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
1015         the end of the file name when searching for ChangeLog files in a
1016         commit.
1017
1018 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1019
1020         <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
1021
1022         Reviewed by Eric Seidel.
1023
1024         * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
1025         the merge attempt fails.
1026
1027 2010-03-24  Adam Barth  <abarth@webkit.org>
1028
1029         Reviewed by Eric Seidel.
1030
1031         webkit-patch or pre-commit hook should validate reviewer lines before committing
1032         https://bugs.webkit.org/show_bug.cgi?id=26927
1033
1034         Validate that patches have valid reivewers listed in their ChangeLogs
1035         before landing.  For patches without reviewers can be landed if their
1036         ChangeLogs state that they are unreviewed.
1037
1038         * Scripts/webkitpy/changelogs.py:
1039         * Scripts/webkitpy/commands/download.py:
1040         * Scripts/webkitpy/commitinfo.py:
1041         * Scripts/webkitpy/commitinfo_unittest.py:
1042         * Scripts/webkitpy/mock_bugzillatool.py:
1043         * Scripts/webkitpy/steps/__init__.py:
1044         * Scripts/webkitpy/steps/validatereviewer.py: Added.
1045
1046 2010-03-19  Holger Hans Peter Freyther  <zecke@selfish.org>
1047
1048         Reviewed by David Levin.
1049
1050         Undefined names reported by pyflakes in python scripts
1051         https://bugs.webkit.org/show_bug.cgi?id=36403
1052
1053         Attempt to use names that exist or can exist in the lexical
1054         scope instead of not being available at all.
1055
1056         * Scripts/webkitpy/changelogs.py: Use self._content.
1057         * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
1058         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
1059         * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
1060
1061 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1062
1063         <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
1064
1065         Reviewed by Eric Seidel.
1066
1067         When resolve-ChangeLogs fails to merge a patch while running as
1068         a git merge driver, it deletes the original file, which causes
1069         an internal failure and stops git mid-merge:
1070
1071             fatal: Failed to execute internal merge
1072
1073         The fix is to use the --force switch with patch so that it will
1074         always attempt to apply the patch.  (The change in
1075         mergeChangeLogs() for the previous commit also fixed this, but
1076         adding --force also prevents any potential user interaction that
1077         patch may want to display.)
1078
1079         * Scripts/VCSUtils.pm:
1080         (mergeChangeLogs): Added --force switch to patch command.  Also
1081         changed to use the exit status from the patch command to
1082         determine the return value for this method.
1083         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
1084         test to cover this bug.
1085
1086 2010-03-24  David Kilzer  <ddkilzer@apple.com>
1087
1088         <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
1089
1090         Reviewed by Eric Seidel.
1091
1092         * Scripts/VCSUtils.pm:
1093         (mergeChangeLogs): Copied from mergeChanges() in
1094         resolve-ChangeLogs and renamed.  Added method documentation.
1095         Fixed bug found by new tests where the original file to be
1096         patched was deleted when cleaning up after a traditinal rejected
1097         patch failed to apply.
1098         * Scripts/resolve-ChangeLogs: Switched to using
1099         mergeChangeLogs().
1100         (mergeChanges): Moved to VCSUtils.pm and renamed to
1101         mergeChangeLogs().
1102         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
1103
1104 2010-03-24  Eric Seidel  <eric@webkit.org>
1105
1106         Reviewed by Adam Barth.
1107
1108         Add support for qt's unassigned list to webkit-patch assign-to-committer
1109         https://bugs.webkit.org/show_bug.cgi?id=36559
1110
1111         * Scripts/webkitpy/bugzilla.py:
1112          - Move Bugzilla.unassigned_email into Bug and make it a set.
1113         * Scripts/webkitpy/bugzilla_unittest.py:
1114          - Test the new Bug.is_unassigned method
1115         * Scripts/webkitpy/commands/upload.py:
1116          - Use the new Bug.is_unassigned method instead of an explicit ==
1117         * Scripts/webkitpy/mock_bugzillatool.py:
1118          - Bugzilla.unassigned_email no longer needs mocking
1119
1120 2010-03-24  Kent Hansen  <kent.hansen@nokia.com>
1121
1122         Reviewed by Simon Hausmann.
1123
1124         [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
1125         https://bugs.webkit.org/show_bug.cgi?id=36522
1126
1127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1128         (LayoutTestController::setXSSAuditorEnabled): Use the new name.
1129
1130 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
1131
1132         Reviewed by Shinichiro Hamaji.
1133
1134         Added to check-webkit-style support for a --debug flag.
1135
1136         https://bugs.webkit.org/show_bug.cgi?id=36100
1137
1138         The --debug flag adjusts the logging level to DEBUG and
1139         includes the logger name and level in each log message.
1140
1141         * Scripts/check-webkit-style:
1142           - Changed the code to check for the --debug flag and pass
1143             the result to the configure_logging() method.
1144         * Scripts/webkitpy/style/checker.py:
1145           - Added an is_debug parameter to configure_logging().
1146           - Refactored configure_logging() by adding calls to
1147             the following two methods: _create_log_handlers() and
1148             _create_debug_log_handlers().
1149         * Scripts/webkitpy/style/checker_unittest.py:
1150           - Added unit tests for configure_logging() with is_debug True
1151             by splitting the ConfigureLoggingTest class into
1152             ConfigureLoggingTest and ConfigureLoggingTestBase, and
1153             adding ConfigureLoggingDebugTest.
1154         * Scripts/webkitpy/style/optparser.py:
1155           - Updated the usage string.
1156           - Added an is_debug data attribute to the CommandOptionValues
1157             class.
1158           - Added support for the --debug flag to the ArgumentParser.parse()
1159             method.
1160           - Also added extra error information to the parse() method in
1161             the case of an invalid flag.
1162         * Scripts/webkitpy/style/optparser_unittest.py:
1163           - Updated the unit tests as necessary.
1164           - Also fixed an issue with the CommandOptionValuesTest.test_eq()
1165             unit test.
1166
1167 2010-03-23  Kent Tamura  <tkent@chromium.org>
1168
1169         Reviewed by Dimitri Glazkov.
1170
1171         [DRT/Chromium] Add TestNavigationController and TestWebWorker
1172         https://bugs.webkit.org/show_bug.cgi?id=36489
1173
1174         Add TestNavigationController and TestWebWorker classes, which are
1175         going to be used by DumpRenderTree Chromium port. These files are
1176         based on:
1177         - src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
1178         - src/webkit/tools/test_shell/test_web_worker.h
1179         of Chromium rev.40492.
1180
1181         TestNavigationController has non-style changes.
1182         - Change ContentState type: binary string -> WebHistoryItem
1183         - Remove TestShell dependency by introducing NavigationHost interface.
1184
1185         * DumpRenderTree/chromium/TestNavigationController.cpp: Added.
1186         * DumpRenderTree/chromium/TestNavigationController.h: Added.
1187         * DumpRenderTree/chromium/TestWebWorker.h: Added.
1188
1189 2010-03-23  Eric Seidel  <eric@webkit.org>
1190
1191         Reviewed by Adam Barth.
1192
1193         Add support for revision -> build lookup in buildbot.py and layout test result parsing
1194         https://bugs.webkit.org/show_bug.cgi?id=36474
1195
1196         * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
1197         * Scripts/webkitpy/buildbot.py: 
1198          - Add support for looking up builds by revision number.
1199          - Add support for fetching and parsing results.html files from buildbot.
1200          - build_for_revision has an allow_failed_lookups option to work around the fact that
1201            our buildbot's xmlrpc calls return failure on old revision numbers.
1202          - Add parsing support for twisted directory listings.
1203         * Scripts/webkitpy/buildbot_unittest.py:
1204          - Unit test all the new code.
1205         * Scripts/webkitpy/commands/queries.py:
1206          - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
1207
1208 2010-03-23  Daniel Bates  <dbates@rim.com>
1209
1210         Reviewed by Adam Roben.
1211
1212         https://bugs.webkit.org/show_bug.cgi?id=36048
1213
1214         Detect if the Windows Platform SDK is missing when building with
1215         Visual C++ Express Edition and inform the user to download it.
1216
1217         * Scripts/webkitdirs.pm:
1218
1219 2010-03-23  Darin Adler  <darin@apple.com>
1220
1221         Tell Subversion about more directories that expect to have .pyc files.
1222
1223         * Scripts/webkitpy: Modified property svn:ignore.
1224         * Scripts/webkitpy/irc: Added property svn:ignore.
1225
1226 2010-03-23  Daniel Bates  <dbates@rim.com>
1227
1228         Reviewed by Adam Barth.
1229
1230         https://bugs.webkit.org/show_bug.cgi?id=36149
1231
1232         Import the GNU readline interface to modify the behavior
1233         of raw_input so as to provide line editing support. In
1234         particular this will prevent "delete" characters from
1235         appearing in the returned value for function raw_input.
1236
1237         * Scripts/webkitpy/user.py:
1238
1239 2010-03-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1240
1241         Reviewed by Kenneth Rohde Christiansen.
1242
1243         [Qt] Remove support for Qt v4.4
1244         https://bugs.webkit.org/show_bug.cgi?id=36389
1245
1246         * DumpRenderTree/qt/main.cpp:
1247         (main):
1248         * QtLauncher/mainwindow.cpp:
1249         (MainWindow::MainWindow):
1250
1251 2010-03-22  Csaba Osztrogonác  <ossy@webkit.org>
1252
1253         Reviewed by Adam Barth.
1254
1255         Make build_webkit_command() pass MAKEFLAGS environment variable to make.
1256         https://bugs.webkit.org/show_bug.cgi?id=36440
1257
1258         * Scripts/webkitpy/webkitport.py:
1259         * Scripts/webkitpy/webkitport_unittest.py:
1260
1261 2010-03-22  Dirk Pranke  <dpranke@chromium.org>
1262
1263         Reviewed by Dimitri Glazkov.
1264
1265         Change baseline_path() to point to the upstream locations for the
1266         Chromium ports. Also change the reabselining scripts to use the
1267         correct functions to get the baseline directories, and fix the
1268         script's sys.path to pull in simplejson correctly.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=36417
1271
1272         * Scripts/rebaseline-chromium-webkit-tests:
1273           - fix sys.path to pick up simplejson properly
1274         * Scripts/webkitpy/layout_tests/port/chromium.py:
1275           - change baseline_path() to use webkit_baseline_path()
1276           - error out correctly if we can't find the chromium base dir
1277         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1278           - call baseline_path(), not chromium_baseline_path()
1279
1280 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
1281
1282         Reviewed by Adam Barth.
1283
1284         Refactored the cpu_count() code in executive.py.
1285
1286         https://bugs.webkit.org/show_bug.cgi?id=36437
1287
1288         * Scripts/webkitpy/executive.py:
1289           - Moved the import of the multiprocessing module to the top
1290             of the file rather than importing from within a function.
1291
1292 2010-03-22 Antonio Gomes <tonikitoo@webkit.org>
1293
1294         Unreviewed.
1295
1296         Rolling out r56183: http://trac.webkit.org/changeset/56183
1297
1298         https://bugs.webkit.org/show_bug.cgi?id=36244
1299
1300         Need to roll out because this patch will be re-worked by the author
1301         and other reviewers agreed on it.
1302
1303 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
1304
1305         Reviewed by Adam Barth.
1306
1307         Created a function for getting a module-specific logging.logger
1308         based on the __file__ value of the module.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=35821
1311
1312         This function allows us to get the module-specific logger for
1313         a module without having to hard-code the fully-qualified name
1314         of the module in the module itself.  The code can be the same
1315         in every case: "_log = logutils.get_logger(__file__)".
1316
1317         * Scripts/webkitpy/init/logutils.py: Added.
1318           - Added a module with a get_logger() function to return
1319             a module-specific logger based on the module's __file__
1320             variable.
1321
1322         * Scripts/webkitpy/init/logutils_unittest.py: Added.
1323           - Added unit tests for logutils.py.
1324
1325         * Scripts/webkitpy/init/unittests.py:
1326           - Added logutils_unittest to the list of imports.
1327
1328 2010-03-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1329
1330         Reviewed by Simon Hausmann.
1331
1332         [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
1333         https://bugs.webkit.org/show_bug.cgi?id=36386
1334
1335         Fix the regression by implementing a null printer for Qt DRT.
1336
1337         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1338         (WebCore::NullPrinter::NullPaintEngine::begin):
1339         (WebCore::NullPrinter::NullPaintEngine::end):
1340         (WebCore::NullPrinter::NullPaintEngine::type):
1341         (WebCore::NullPrinter::NullPaintEngine::drawPixmap):
1342         (WebCore::NullPrinter::NullPaintEngine::updateState):
1343         (WebCore::NullPrinter::paintEngine):
1344         (WebCore::DumpRenderTree::dryRunPrint):
1345
1346 2010-03-20  Martin Robinson  <mrobinson@webkit.org>
1347
1348         Reviewed by Xan Lopez.
1349
1350         [GTK] eventSender.zoomPageOut() bug?
1351         https://bugs.webkit.org/show_bug.cgi?id=30575
1352
1353         Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
1354
1355         * DumpRenderTree/gtk/EventSender.cpp:
1356         (zoomIn): Added.
1357         (zoomOut): Added.
1358         (textZoomInCallback): Use zoomIn helper function.
1359         (textZoomOutCallback): Use zoomOut helper function.
1360         (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor.
1361         (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
1362
1363 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
1364
1365         [wx] Build fix after recent database API change.
1366
1367         * wx/browser/browser.cpp:
1368         (MyApp::OnInit):
1369
1370 2010-03-20  Chris Jerdonek  <cjerdonek@webkit.org>
1371
1372         Reviewed by Adam Barth.
1373
1374         Renamed UnitTestLogStream to TestLogStream in webkitpy.
1375
1376         https://bugs.webkit.org/show_bug.cgi?id=36099
1377
1378         TestLogStream is more concise and more consistent with the name of
1379         the module (logtesting rather than logunittesting) and its main
1380         class (LogTesting rather than LogUnitTesting).
1381
1382         * Scripts/webkitpy/init/logtesting.py:
1383           - Renamings.
1384
1385         * Scripts/webkitpy/style/checker_unittest.py:
1386           - Renamings.
1387
1388         * Scripts/webkitpy/style_references.py:
1389           - Renamings.
1390
1391 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
1392
1393         [wx] Build fixes for new method in LayoutTestController.
1394
1395         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1396         (LayoutTestController::setSpatialNavigationEnabled):
1397         * wx/build/settings.py:
1398
1399 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
1400
1401         Unreviewed, tool fix.
1402
1403         Remove vestiges of downstream directory names to unbreak rebaselining tool.
1404
1405         * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
1406
1407 2010-03-20  Dirk Pranke  <dpranke@chromium.org>
1408
1409         Reviewed by Dimitri Glazkov.
1410
1411         Re-enable the downstream test_expectations overrides file that was
1412         disabled in bug 36396 / r56287.
1413
1414         https://bugs.chromium.org/show_bug.cgi?id=36401
1415
1416         * Scripts/webkitpy/layout_tests/port/chromium.py:
1417
1418 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1419
1420         Reviewed by Dimitri Glazkov.
1421
1422         Disable the downstream override expectations temporarily to allow
1423         us to test that we've upstreamed everything correctly. Also, stop
1424         looking at the downstream baselines at all (now you will only be
1425         able to update baselines upstream). In theory this should work, but
1426         if we need to we can always add the downstream dirs back in.
1427
1428         https://bugs.webkit.org/show_bug.cgi?id=36396
1429
1430         * Scripts/webkitpy/layout_tests/port/chromium.py:
1431         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1432         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1433         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1434
1435 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1436
1437         Reviewed by Dimitri Glazkov.
1438
1439         fix typo in chromium test expectations overrides routine
1440         https://bugs.webkit.org/show_bug.cgi?id=36397
1441
1442         * Scripts/webkitpy/layout_tests/port/chromium.py:
1443
1444 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1445
1446         Reviewed by Dimitri Glazkov.
1447
1448         Flip the Chromium ports to look first for the test expectations
1449         in LayoutTests/platform/chromium and only afterwards look in the
1450         Chromium repo downstream for overrides.
1451
1452         https://bugs.webkit.org/show_bug.cgi?id=36326
1453
1454         * Scripts/webkitpy/layout_tests/port/chromium.py:
1455
1456 2010-03-19  James Hawkins  <jhawkins@chromium.org>
1457
1458         Unreviewed.
1459
1460         Add myself to the committers list.
1461
1462         * Scripts/webkitpy/committers.py:
1463
1464 2010-03-19  Adam Barth  <abarth@webkit.org>
1465
1466         Unreviewed.
1467
1468         Fix SheriffBot exception lock when we can't retrieve the first build
1469         from buildbot.  (I'll ask Eric to review this change after the fact,
1470         but he's at lunch and I want to get the bot unlocked.)
1471
1472         * Scripts/webkitpy/buildbot.py:
1473         * Scripts/webkitpy/buildbot_unittest.py:
1474
1475 2010-03-19  Alexey Proskuryakov  <ap@apple.com>
1476
1477         Reviewed by Darin Adler.
1478
1479         https://bugs.webkit.org/show_bug.cgi?id=36380
1480         websocket/tests/frame-lengths.html times out on Tiger bot
1481
1482         https://bugs.webkit.org/show_bug.cgi?id=35041
1483         websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot
1484
1485         Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
1486         sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
1487         timing out than to detect it early.
1488
1489         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1490         (LayoutTestController::setWaitToDump):
1491         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1492         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1493         (LayoutTestController::waitUntilDone):
1494         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1495         * Scripts/run-webkit-tests:
1496
1497 2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1498
1499         Unreviewed.
1500
1501         Buildfix for Qt v4.5.
1502
1503         * QtLauncher/main.cpp:
1504         (LauncherWindow::LauncherWindow):
1505         (LauncherWindow::applyZoom):
1506
1507 2010-03-19  Adam Barth  <abarth@webkit.org>
1508
1509         Reviewed by Eric Seidel.
1510
1511         Operational tweaks to SheriffBot
1512         https://bugs.webkit.org/show_bug.cgi?id=36385
1513
1514         These changes aren't pretty, but they're helpful to make SheriffBot
1515         work operationally.  I plan to iterate in these areas, but I wanted to
1516         get this patch landed so I could be running the bot against TOT.
1517
1518         * Scripts/webkitpy/commands/sheriffbot.py:
1519         * Scripts/webkitpy/irc/ircbot.py:
1520         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
1521
1522 2010-03-19  Eric Seidel  <eric@webkit.org>
1523
1524         Reviewed by Adam Barth.
1525
1526         Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
1527         https://bugs.webkit.org/show_bug.cgi?id=36354
1528
1529         * Scripts/webkitpy/buildbot.py:
1530          - Make Build creation easier to Mock and test
1531         * Scripts/webkitpy/buildbot_unittest.py:
1532          - Test finding green to red transitions and suspect revisions
1533         * Scripts/webkitpy/commands/queries.py:
1534          - Make what-broke note when builders have only failed once.
1535
1536 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
1537
1538         Reviewed by Dimitri Glazkov.
1539
1540         Fix the rebaselining tool, which was broken by r36324 when I
1541         added the concept of overridding expectations.
1542
1543         https://bugs.webkit.org/show_bug.cgi?id=36374
1544
1545         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1546
1547 2010-03-19  Adam Barth  <abarth@webkit.org>
1548
1549         Reviewed by Eric Seidel.
1550
1551         Misc bug fixes to make the SheriffBot actually work
1552         https://bugs.webkit.org/show_bug.cgi?id=36355
1553
1554         With these changes, I can actually run the sheriff-bot from start to
1555         finish.
1556
1557         * Scripts/webkitpy/irc/ircproxy.py:
1558         * Scripts/webkitpy/patch/patcher.py:
1559         * Scripts/webkitpy/statusserver.py:
1560
1561 2010-03-19  Adam Barth  <abarth@webkit.org>
1562
1563         Unreviewed.
1564
1565         Actually import the sheriff-bot command so we can run it.  Also, move
1566         the bot to #webkit-test so it doesn't cause a ruckus while we test it.
1567
1568         * Scripts/webkitpy/patch/patcher.py:
1569         * Scripts/webkitpy/irc/ircbot.py:
1570
1571 2010-03-19  Adam Barth  <abarth@webkit.org>
1572
1573         Reviewed by Eric Seidel.
1574
1575         Second cut at SheriffBot
1576         https://bugs.webkit.org/show_bug.cgi?id=36353
1577
1578         This patch should contain a complete SheriffBot that's capable of
1579         saying reasonable things on IRC.  I had to refactor the use of
1580         CommitInfo to make the SheriffBot testable, but I did the minimum
1581         necessary.  We should grow webkitcheckout over time to contain the
1582         knowledge of ChangeLogs from scm.
1583
1584         * Scripts/webkitpy/commands/sheriffbot.py:
1585         * Scripts/webkitpy/commands/sheriffbot_unittest.py:
1586         * Scripts/webkitpy/mock_bugzillatool.py:
1587         * Scripts/webkitpy/patch/patcher.py:
1588         * Scripts/webkitpy/webkitcheckout.py: Added.
1589
1590 2010-03-19  Adam Barth  <abarth@webkit.org>
1591
1592         Unreviewed.
1593
1594         Fix Hyatt's IRC nickname.
1595
1596         * Scripts/webkitpy/committers.py:
1597
1598 2010-03-19  Adam Barth  <abarth@webkit.org>
1599
1600         Unreviewed.
1601
1602         Add IRC nicknames for the non-reviewer committers.
1603
1604         * Scripts/webkitpy/committers.py:
1605
1606 2010-03-19  Adam Barth  <abarth@webkit.org>
1607
1608         Unreviewed.
1609
1610         More reviewer IRC nicknames.
1611
1612         * Scripts/webkitpy/committers.py:
1613
1614 2010-03-19  Adam Barth  <abarth@webkit.org>
1615
1616         Unreviewed.
1617
1618         Add a bunch of IRC nicknames for reviewers.
1619
1620         * Scripts/webkitpy/committers.py:
1621
1622 2010-03-19  Zoltan Horvath  <zoltan@webkit.org>
1623
1624         Reviewed by Oliver Hunt.
1625
1626         Added USE_SYSTEM_MALLOC flag to build-webkit
1627         https://bugs.webkit.org/show_bug.cgi?id=21272
1628
1629         Add system-alloc flag to build-webkit. It makes easy to switch
1630         between system allocator and TCmalloc.
1631
1632         * Scripts/build-webkit:
1633
1634 2010-03-19  Adam Barth  <abarth@webkit.org>
1635
1636         Unreviewed "build" fix.
1637
1638         Of course, I caused a regression in the file that isn't tested.  :(
1639
1640         * Scripts/webkitpy/statusserver.py:
1641
1642 2010-03-19  Eric Seidel  <eric@webkit.org>
1643
1644         Reviewed by Adam Barth.
1645
1646         Add basic "who-broke-it" command and revision -> broken builder association code
1647         https://bugs.webkit.org/show_bug.cgi?id=36352
1648
1649         The "what-broke" command prints builders and what revisions we suspect
1650         broke them.  who-broke-it prints revisions and what builders we suspect
1651         they broke.  The sheriff-bot needs this revision to broken builder mapping
1652         so this change adds it!
1653
1654         * Scripts/webkitpy/buildbot.py:
1655         * Scripts/webkitpy/commands/queries.py:
1656
1657 2010-03-19  Eric Seidel  <eric@webkit.org>
1658
1659         Reviewed by Adam Barth.
1660
1661         Simplify BuildBot core builder code for easier re-use
1662         https://bugs.webkit.org/show_bug.cgi?id=36350
1663
1664         I simply couldn't see anything through all this Yak-hair.
1665
1666         * Scripts/webkitpy/buildbot.py:
1667         * Scripts/webkitpy/commands/queries.py:
1668
1669 2010-03-19  Adam Barth  <abarth@webkit.org>
1670
1671         Reviewed by Eric Seidel.
1672
1673         committers.py should know IRC nicknames
1674         https://bugs.webkit.org/show_bug.cgi?id=36349
1675
1676         I'll add the actual nicknames in another patch.
1677
1678         * Scripts/webkitpy/committers.py:
1679         * Scripts/webkitpy/committers_unittest.py:
1680
1681 2010-03-18  Anders Bakken  <agbakken@gmail.com>
1682
1683         Reviewed by Simon Hausmann.
1684
1685         https://bugs.webkit.org/show_bug.cgi?id=36318
1686
1687         QtLauncher runs as a GuiClient by default in Qt Embedded which will
1688         make it try to connect to an existing GuiServer. This patch makes it
1689         run like a stand-alone app.
1690
1691         * QtLauncher/main.cpp:
1692         (LauncherApplication::LauncherApplication):
1693
1694 2010-03-19  Eric Seidel  <eric@webkit.org>
1695
1696         Reviewed by Adam Barth.
1697
1698         Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
1699         https://bugs.webkit.org/show_bug.cgi?id=36345
1700
1701         * Scripts/webkitpy/buildbot.py:
1702         * Scripts/webkitpy/commands/queries.py:
1703
1704 2010-03-19  Adam Barth  <abarth@webkit.org>
1705
1706         Reviewed by Adam Barth.
1707
1708         Actually pass the IRC password to the IRC object
1709         https://bugs.webkit.org/show_bug.cgi?id=36346
1710
1711         I wanted to do this before, but both patches were in flight.  This
1712         patch finally closes the loop and makes the IRCProxy system complete.
1713
1714         * Scripts/webkitpy/patch/patcher.py:
1715
1716 2010-03-18  Adam Barth  <abarth@webkit.org>
1717
1718         Reviewed by Eric Seidel.
1719
1720         Add a StatusServer front end to the SVNRevision table on QueueStatusServer
1721         https://bugs.webkit.org/show_bug.cgi?id=36344
1722
1723         No test because Browser was too hard to mock.  :(  I couldn't figure
1724         out how to make Mock be a dictionary as well as an object.
1725
1726         * Scripts/webkitpy/statusserver.py:
1727
1728 2010-03-18  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         Split out CommitInfo class and add unit tests
1733         https://bugs.webkit.org/show_bug.cgi?id=36343
1734
1735         Move more logic out of "what-broke" into a shared CommitInfo
1736         class so that it can be used by other commands and unit tested.
1737
1738         * Scripts/webkitpy/commands/queries.py:
1739         * Scripts/webkitpy/commitinfo.py: Added.
1740         * Scripts/webkitpy/commitinfo_unittest.py: Added.
1741         * Scripts/webkitpy/unittests.py:
1742
1743 2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1744
1745         Reviewed by Kenneth Rohde Christiansen.
1746
1747         [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
1748         https://bugs.webkit.org/show_bug.cgi?id=36207
1749
1750         Implement setAppCacheMaximumSize() for Qt.
1751
1752         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1753         (LayoutTestController::setAppCacheMaximumSize):
1754         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1755
1756 2010-03-18  Adam Barth  <abarth@webkit.org>
1757
1758         Reviewed by Eric Seidel.
1759
1760         QueueStatusServer should be able to log broken bots
1761         https://bugs.webkit.org/show_bug.cgi?id=36341
1762
1763         We need to add a new table to the QueueStatusServer to store persistent
1764         information for the SheriffBot.  The new table will keep track of which
1765         bots each SVN revision broke.
1766
1767         * QueueStatusServer/handlers/__init__.py:
1768         * QueueStatusServer/handlers/svnrevision.py: Added.
1769         * QueueStatusServer/handlers/updatebase.py: Added.
1770         * QueueStatusServer/handlers/updatestatus.py:
1771         * QueueStatusServer/handlers/updatesvnrevision.py: Added.
1772         * QueueStatusServer/index.yaml:
1773         * QueueStatusServer/main.py:
1774         * QueueStatusServer/model/__init__.py:
1775         * QueueStatusServer/model/svnrevision.py: Added.
1776         * QueueStatusServer/templates/updatesvnrevision.html: Added.
1777
1778 2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1779
1780         Reviewed by Darin Adler.
1781
1782         Add a new method to the Qt LayoutTestController for
1783         changing media type and make the DRT support dry-run printing.
1784
1785         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1786         (WebCore::DumpRenderTree::DumpRenderTree):
1787         (WebCore::DumpRenderTree::dryRunPrint):
1788         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1789         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1790         (LayoutTestController::setMediaType):
1791         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1792
1793 2010-03-18  Dirk Pranke  <dpranke@chromium.org>
1794
1795         Reviewed by Dimitri Glazkov.
1796
1797         Add upstream LayoutTests/platform/chromium* directories to the
1798         baseline search path for new-run-webkit-tests in preparation for
1799         upstreaming all of the Chromium baselines. Note that this does
1800         not actually create the directories themselves, but that's okay.
1801
1802         https://bugs.webkit.org/show_bug.cgi?id=36324
1803
1804         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1805         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1806         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1807
1808 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
1809
1810         Reviewed by Anders Carlsson.
1811
1812         https://bugs.webkit.org/show_bug.cgi?id=36327
1813         Test that a plug-in can override Node methods of its element
1814
1815         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1816         (normalizeOverride):
1817         (pluginInvoke):
1818         Override "normalize", and call back to let a test know that the plug-in was called.
1819
1820 2010-03-17  Dirk Pranke  <dpranke@chromium.org>
1821
1822         Reviewed by Dimitri Glazkov.
1823
1824         Add the concept of an "overrides" file for expectations so that we
1825         can store test_expectations both upstream and downstream for a port
1826         that runs both in webkit.org and in a separate repository (like
1827         Chromium). Also add some unit tests for the expectations module.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=36249
1830
1831         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1832         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
1833         * Scripts/webkitpy/layout_tests/port/base.py:
1834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1835
1836 2010-03-18  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1837
1838         Reviewed by Kenneth Rohde Christiansen.
1839
1840         Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
1841         on the launcher and not on the terminal anymore.
1842
1843         [Qt] QtLauncher's FPS info should be displayed on an overlay text item
1844         https://bugs.webkit.org/show_bug.cgi?id=36244
1845
1846         * QtLauncher/webview.cpp:
1847         (WebViewGraphicsBased::WebViewGraphicsBased):
1848         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1849         (WebViewGraphicsBased::updateFrameRate):
1850         * QtLauncher/webview.h:
1851
1852 2010-03-18  Adam Barth  <abarth@webkit.org>
1853
1854         Reviewed by Eric Seidel.
1855
1856         First cut at SheriffBot
1857         https://bugs.webkit.org/show_bug.cgi?id=36253
1858
1859         This patch contains a first attempt at writing a sheriff bot.
1860         Currently, we're missing the logic that actually finds the SVN revision
1861         numbers to complain about, but once we have that, we'll have the rest
1862         of the infrustructure to ping IRC and to file bugs.
1863
1864         There's a lot to fill in for the SheriffBot, but this patch give us the
1865         framework in which to do it.
1866
1867         This patch required a bit of refactoring of AbstractQueue because
1868         SheriffBot is the first bot that doesn't process patches (it processes
1869         SVN revisions).  Accordingly, I've factored out AbstractPatchQueue to
1870         hold the parts of AbstractQueue that are specific to dealing with
1871         patches.  Some of the choices here might not be obvious yet, but we can
1872         tweak them as our needs become clearer.
1873
1874         * Scripts/webkitpy/commands/queues.py:
1875         * Scripts/webkitpy/commands/queues_unittest.py:
1876         * Scripts/webkitpy/commands/sheriffbot.py: Added.
1877         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
1878         * Scripts/webkitpy/mock_bugzillatool.py:
1879             Added a MockIRC object to the mock tool.
1880         * Scripts/webkitpy/multicommandtool.py:
1881             Added a finalize method so the tool can disconnect from IRC
1882             cleanly instead of just droping the socket.
1883         * Scripts/webkitpy/multicommandtool_unittest.py:
1884         * Scripts/webkitpy/patch/patcher.py:
1885             Added support for talking to IRC.
1886         * Scripts/webkitpy/unittests.py:
1887             We should add a commands/unittests.py file at some point to make
1888             the commands module more self-contained.
1889
1890 2010-03-18  Antti Koivisto  <koivisto@iki.fi>
1891
1892         Reviewed by Kenneth Rohde Christiansen.
1893
1894         https://bugs.webkit.org/show_bug.cgi?id=36102
1895         [Qt] Scaling control API for tiled backing store
1896         
1897         Add animated smooth zooming to Qt launcher when in tiled mode.
1898
1899         * QtLauncher/main.cpp:
1900         (LauncherWindow::LauncherWindow):
1901         (LauncherWindow::zoomAnimationFinished):
1902         (LauncherWindow::applyZoom):
1903         (LauncherWindow::zoomIn):
1904         (LauncherWindow::zoomOut):
1905         * QtLauncher/webview.h:
1906         (WebViewGraphicsBased::graphicsWebView):
1907
1908 2010-03-18  Adam Barth  <abarth@webkit.org>
1909
1910         Reviewed by Eric Seidel.
1911
1912         Support using IRC accounts with a password
1913         https://bugs.webkit.org/show_bug.cgi?id=36287
1914
1915         Add a global option to specify an IRC password so we can use the
1916         sheriffbot account (which needs a password).
1917
1918         * Scripts/webkitpy/irc/ircbot.py:
1919         * Scripts/webkitpy/irc/ircproxy.py:
1920         * Scripts/webkitpy/patch/patcher.py:
1921
1922 2010-03-18  Eric Seidel  <eric@webkit.org>
1923
1924         Just fixing missing parenthesis typo, no review.
1925
1926         * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
1927
1928 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
1929
1930         Reviewed by Adam Roben and Anders Carlsson.
1931
1932         https://bugs.webkit.org/show_bug.cgi?id=36210
1933         plugins/resize-from-plugin.html fails on some platforms
1934
1935         Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
1936         the test to their versions of the file.
1937
1938         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1939         (webkit_test_plugin_set_window):
1940         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1941         (NPP_SetWindow):
1942
1943 2010-03-18  Leandro Pereira  <leandro@profusion.mobi>
1944
1945         Reviewed by Kenneth Rohde Christiansen.
1946
1947         Add support to run-launcher to open the EFL example browser.
1948         http://webkit.org/b/36181
1949
1950         * Scripts/webkitdirs.pm:
1951         * Scripts/run-launcher:
1952
1953 2010-03-18  Sergio Villar Senin  <svillar@igalia.com>
1954
1955         Reviewed by Xan Lopez.
1956
1957         [GTK] Failing tests http/tests/misc/image-blocked-src-change.html
1958         & http/tests/misc/image-blocked-src-no-change.html
1959         https://bugs.webkit.org/show_bug.cgi?id=36227
1960
1961         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1962         (webViewConsoleMessage): print only the file name instead of the
1963         whole URI when printing messages with local URI's
1964
1965 2010-03-18  Eric Seidel  <eric@webkit.org>
1966
1967         Reviewed by Adam Barth.
1968
1969         Teach what-broke how to look up reviewer and author Committer objects by name
1970         https://bugs.webkit.org/show_bug.cgi?id=36264
1971
1972         * Scripts/webkitpy/commands/queries.py:
1973          - Add committer_by_name lookups for both reviewer and author
1974          - Improve printing in the cases where lookups fail.
1975         * Scripts/webkitpy/committers.py:
1976          - Add committer_by_name
1977         * Scripts/webkitpy/committers_unittest.py:
1978          - Test committer_by_name
1979
1980 2010-03-17  Adam Barth  <abarth@webkit.org>
1981
1982         Reviewed by Eric Seidel.
1983
1984         create-rollout should actually fill out the description
1985         https://bugs.webkit.org/show_bug.cgi?id=36261
1986
1987         * Scripts/webkitpy/commands/download.py:
1988             The % operator was applied to the wrong string.
1989         * Scripts/webkitpy/commands/download_unittest.py:
1990         * Scripts/webkitpy/commands/upload_unittest.py:
1991         * Scripts/webkitpy/mock_bugzillatool.py:
1992             Add support for seeing what we actually do with create_bug.
1993
1994 2010-03-17  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1995
1996         Reviewed by Kenneth Rohde Christiansen.
1997
1998         Accelerated Compositing is now default on QtWebKit so the option
1999         in QtLauncher must be true as default.
2000
2001         [Qt] QtLauncher's Accelerated Compositing option must be true as default
2002         https://bugs.webkit.org/show_bug.cgi?id=36234
2003
2004         * QtLauncher/main.cpp:
2005         (LauncherWindow::applyPrefs):
2006         (LauncherWindow::toggleAcceleratedCompositing):
2007         (LauncherApplication::handleUserOptions):
2008
2009 2010-03-17  Adam Barth  <abarth@webkit.org>
2010
2011         Reviewed by Eric Seidel.
2012
2013         Commit queue should ignore (probably red) builders when landing rollouts
2014         https://bugs.webkit.org/show_bug.cgi?id=36169
2015
2016         When landing a rollout, the builders are probably red, so we need to
2017         ignore them in the subprocess too.  Also, we might as well update the
2018         working copy because we haven't validated anything about the current
2019         revision prior to trying to land.
2020
2021         This change is testable, but it requires changing the mock executive to
2022         log its arguments.  That will generate a lot of expectation changes, so
2023         I'd like to do that in a separate patch.
2024
2025         * Scripts/webkitpy/commands/queues.py:
2026
2027 2010-03-17  Chang Shu  <chang.shu@nokia.com>
2028
2029         Reviewed by Laszlo Gombos.
2030
2031         https://bugs.webkit.org/show_bug.cgi?id=36139
2032         [Qt] Clean up cache each time DumpRenderTree starts. This behavior 
2033         matches other platforms, such as mac and gtk.
2034
2035         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2036         (WebCore::DumpRenderTree::DumpRenderTree):
2037
2038 2010-03-17  Adam Barth  <abarth@webkit.org>
2039
2040         Unreviewed.
2041
2042         Turns out this needs to be a string.
2043
2044         * Scripts/webkitpy/bugzilla.py:
2045
2046 2010-03-17  Eric Seidel  <eric@webkit.org>
2047
2048         Reviewed by Adam Barth.
2049
2050         Add more infrastructure for sheriff-bot, including making what-broke more awesome
2051         https://bugs.webkit.org/show_bug.cgi?id=36254
2052
2053         * Scripts/webkitpy/bugzilla.py:
2054          - Made the various URL methods return None when passed None.
2055         * Scripts/webkitpy/bugzilla_unittest.py:
2056          - Test that the url methods work as expected.
2057         * Scripts/webkitpy/buildbot.py:
2058          - Add a static Build.build_url so that its possible to generate a build url without a Build object.
2059          - Give users a URL in _fetch_xmlrpc_build_dictionary error message.
2060         * Scripts/webkitpy/changelogs.py:
2061          - Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
2062          - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
2063          - Make ChangeLog.parse_latest_entry_from_file a public method.
2064         * Scripts/webkitpy/changelogs_unittest.py:
2065          - Add tests for new ChangeLog entry parsing.
2066         * Scripts/webkitpy/commands/queries.py:
2067          - Make "what-broke" not print "ok" builders, only failing ones.
2068          - Print much more information on failing builders, including links and authorship/reviewer information.
2069         * Scripts/webkitpy/commands/queues_unittest.py:
2070          - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
2071         * Scripts/webkitpy/mock_bugzillatool.py:
2072          - Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
2073         * Scripts/webkitpy/patch/patcher.py:
2074          - Remove code which was broken now that this file has moved.
2075          - Code was also redundant now that SCM.find_checkout_root() exists.
2076         * Scripts/webkitpy/scm.py:
2077          - Greatly simplify modified_changelogs now that I understand list comprehensions.
2078          - Expect ChangeLogEntry objects instead of raw strings.
2079          - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
2080          - Add commit_with_message argument to all sites since someone half-added it before. :(
2081          - Get rid of copy/paste code using _status_regexp()
2082         * Scripts/webkitpy/scm_unittest.py:
2083          - Fix these tests!
2084          - Add new tests for new scm code.
2085          - Fix spelling of "awsome" to "awesome".
2086
2087 2010-03-17  Daniel Bates  <dbates@rim.com>
2088
2089         Rubber-stamped by David Levin.
2090
2091         Add myself to the list of reviewers.
2092
2093         * Scripts/webkitpy/committers.py:
2094
2095 2010-03-17  Adam Barth  <abarth@webkit.org>
2096
2097         Reviewed by Eric Seidel.
2098
2099         Change post-rollout to create-rollout and have it make a new bug
2100         instead of posting the rollout to the old bug.
2101         https://bugs.webkit.org/show_bug.cgi?id=36250
2102
2103         The new bug blocks the old bug instead of adding more complexity to the
2104         old bug.  One tricky question is whether to create the bug if we're
2105         unable to create a rollout patch.  In this patch, we do create the bug,
2106         but we might revist this question in the future.
2107
2108         * Scripts/webkitpy/bugzilla.py:
2109         * Scripts/webkitpy/commands/download.py:
2110         * Scripts/webkitpy/commands/download_unittest.py:
2111         * Scripts/webkitpy/steps/createbug.py:
2112
2113 2010-03-17  Adam Barth  <abarth@webkit.org>
2114
2115         Reviewed by Eric Seidel.
2116
2117         Add a way for the bots to send messages to IRC
2118         https://bugs.webkit.org/show_bug.cgi?id=36235
2119
2120         We'll use these classes to notify #webkit about bad SVN revisions.
2121         This patch just has some skeleton code for us to play with.
2122
2123         * Scripts/webkitpy/irc/__init__.py: Added.
2124         * Scripts/webkitpy/irc/ircbot.py: Added.
2125             A bot that knows how to talk to IRC.
2126         * Scripts/webkitpy/irc/ircproxy.py: Added.
2127             We need to run the bot on its own thread because the irclib needs
2128             its own mainloop.  This class provides an abstraction of the
2129             threading.
2130         * Scripts/webkitpy/irc/messagepump.py: Added.
2131         * Scripts/webkitpy/irc/messagepump_unittest.py: Added.
2132         * Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
2133             A thread-safe message queue for sending messages from the main
2134             thread to the IRC thread.
2135         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
2136         * Scripts/webkitpy/irc/unittests.py: Added.
2137         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
2138             Autoinstall irclib
2139         * Scripts/webkitpy/unittests.py:
2140
2141 2010-03-17  Victor Wang  <victorw@chromium.org>
2142
2143         Reviewed by Dimitri Glazkov.
2144
2145         Fix image_diff syntax in webkitpy/port/base.py.
2146         The syntax is wrong if diff_filename is specified.
2147
2148         https://bugs.webkit.org/show_bug.cgi?id=36230
2149
2150         * Scripts/webkitpy/layout_tests/port/base.py:
2151
2152 2010-03-16  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2153
2154         Reviewed by Kenneth Christiansen.
2155
2156         Provide to QtLauncher a way to change the ViewportUpdateMode
2157         when it's in graphics based mode.
2158
2159         [Qt] Make QtLaucher able to select the ViewportUpdateMode
2160         https://bugs.webkit.org/show_bug.cgi?id=36175
2161
2162         * QtLauncher/main.cpp:
2163         (LauncherWindow::selectViewportUpdateMode):
2164         (LauncherWindow::createChrome):
2165
2166 2010-03-17  Zoltan Horvath  <zoltan@webkit.org>
2167
2168         Reviewed by Darin Adler.
2169
2170         Ambiguous error message when building for unspecified platform
2171         https://bugs.webkit.org/show_bug.cgi?id=30203
2172
2173         Add an extra line information to the error message.
2174
2175         * Scripts/webkitdirs.pm:
2176
2177 2010-03-16  Adam Barth  <abarth@webkit.org>
2178
2179         No review, rolling out r56044.
2180         http://trac.webkit.org/changeset/56044
2181         https://bugs.webkit.org/show_bug.cgi?id=36048
2182
2183         This patch broke Windows Debug (Tests)
2184
2185         * Scripts/webkitdirs.pm:
2186
2187 2010-03-16  John Abd-El-Malek  <jam@chromium.org>
2188
2189         Reviewed by Darin Fisher.
2190
2191         Give keyboard focus to PluginDocuments by default
2192         https://bugs.webkit.org/show_bug.cgi?id=36147
2193
2194         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2195         (pluginAllocate):
2196         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2197         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2198         (NPP_New):
2199         (NPP_SetWindow):
2200         (handleEventCarbon):
2201         (handleEventCocoa):
2202
2203 2010-03-16  Sam Weinig  <sam@webkit.org>
2204
2205         Reviewed by Mark Rowe.
2206
2207         Fix run-webkit-httpd on Windows.
2208
2209         * Scripts/webkitperl/httpd.pm:
2210
2211 2010-03-16  Alexey Proskuryakov  <ap@apple.com>
2212
2213         Tiger build fix.
2214
2215         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty):
2216         Added more type casts to shut down warnings.
2217
2218 2010-03-16  Alexey Proskuryakov  <ap@apple.com>
2219
2220         Reviewed by Darin Adler.
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=36184
2223         YouTube video resizing doesn't work with OOP plug-ins
2224
2225         Added a resizeTo() method, which calls resizePlugin() in JS with the same arguments,
2226         and a lastSetWindowArguments property, which returns a string describing the last NPWindow
2227         passed to NPN_SetWindow.
2228
2229         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2230         (pluginGetProperty):
2231         (testResizeTo):
2232         (pluginInvoke):
2233         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2234         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2235         (NPP_SetWindow):
2236
2237 2010-03-16  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2238
2239         Reviewed by Xan Lopez.
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=35504
2242         [Gtk] Evaluate and fix AtkTable for layout tables
2243
2244         Implements rowCount and columnCount for Gtk in DRT.
2245
2246         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2247         (AccessibilityUIElement::rowCount):
2248         (AccessibilityUIElement::columnCount):
2249
2250 2010-03-15  Eric Seidel  <eric@webkit.org>
2251
2252         Reviewed by Adam Barth.
2253
2254         Add "what-broke" command for debugging when the tree broke
2255         https://bugs.webkit.org/show_bug.cgi?id=36157
2256
2257         This is another step towards automated sheriffing of the webkit tree.
2258         With this logic our scripts are able to determine what revision broke the
2259         tree.  Buildbot should do this for us, but unfortunately buildbot doesn't
2260         expose this kind of aggregate information.
2261
2262         * Scripts/webkitpy/buildbot.py:
2263          - Add new Builder and Build classes (which will eventually replace the custom dictionaries previously used).
2264          - Split out more network logic into _fetch methods which will eventually be their own class for mocking.
2265          - Use XMLRPC to communicate with the buildbot master instead of scraping build pages.
2266         * Scripts/webkitpy/buildbot_unittest.py:
2267          - Test the newly added buildbot classes.
2268         * Scripts/webkitpy/commands/queries.py:
2269          - Add an experimental what-broke command.
2270
2271 2010-03-15  Daniel Bates  <dbates@rim.com>
2272
2273         Reviewed by Eric Seidel.
2274
2275         https://bugs.webkit.org/show_bug.cgi?id=36048
2276
2277         Detect if the Windows Platform SDK is missing when building with
2278         Visual C++ Express Edition and inform the user to download it.
2279
2280         * Scripts/webkitdirs.pm:
2281
2282 2010-03-15  Adam Barth  <abarth@webkit.org>
2283
2284         Reviewed by Eric Seidel.
2285
2286         Let commit-queue land rollout patches even when the tree is red
2287         https://bugs.webkit.org/show_bug.cgi?id=36155
2288
2289         Now the commit-queue will land patches whose name begins with "ROLLOUT "
2290         even if the tree is red.  The patches still go through the usual build
2291         and test process, but they can be landed while the tree is on fire.
2292
2293         * Scripts/webkitpy/bugzilla.py:
2294         * Scripts/webkitpy/commands/queues.py:
2295         * Scripts/webkitpy/commands/queues_unittest.py:
2296         * Scripts/webkitpy/commands/queuestest.py:
2297         * Scripts/webkitpy/mock_bugzillatool.py:
2298
2299 2010-03-15  Adam Barth  <abarth@webkit.org>
2300
2301         Reviewed by Eric Seidel.
2302
2303         Add webkit-patch post-rollout to upload rollouts to bugs.webkit.org for easy committing
2304         https://bugs.webkit.org/show_bug.cgi?id=36154
2305
2306         This new command is a mashup of prepare-rollout and post.  This command
2307         will be used by an experimental bot to post rollouts of patches that
2308         break things to bugs.webkit.org where they can be landed with the
2309         greatest of ease.
2310
2311         * Scripts/webkitpy/commands/download.py:
2312         * Scripts/webkitpy/commands/download_unittest.py:
2313         * Scripts/webkitpy/steps/__init__.py:
2314         * Scripts/webkitpy/steps/postdiffforrevert.py: Added.
2315
2316 2010-03-15  Adam Barth  <abarth@webkit.org>
2317
2318         Reviewed by Eric Seidel.
2319
2320         webkit-patch rollout should error out on conflicts
2321         https://bugs.webkit.org/show_bug.cgi?id=36151
2322
2323         Instead of blindingly plowing ahead, we now throw an exception if there
2324         are conflicts after applying a reverse diff.
2325
2326         * Scripts/webkitpy/scm.py:
2327
2328 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2329
2330         Unreviewed layout test fix.
2331
2332         VO not able to perform a VO-spacebar on facebook links
2333         https://bugs.webkit.org/show_bug.cgi?id=36132
2334
2335         GTK needs to implement press for this test to work.
2336      
2337         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2338         (AccessibilityUIElement::press):
2339
2340 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2341
2342         Unreviewed layout test fix.
2343
2344         VO not able to perform a VO-spacebar on facebook links
2345         https://bugs.webkit.org/show_bug.cgi?id=36132
2346
2347         Windows needs to implement press in DRT.
2348
2349         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2350         (AccessibilityUIElement::press):
2351
2352 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2353
2354         Unreviewed. Fix break of layout tests on win and gtk.
2355
2356         VO not able to perform a VO-spacebar on facebook links
2357         https://bugs.webkit.org/show_bug.cgi?id=36132
2358
2359         Attempting to implement press action for windows and gtk.
2360
2361         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2362         (AccessibilityUIElement::press):
2363         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2364         (AccessibilityUIElement::press):
2365
2366 2010-03-15  Chris Fleizach  <cfleizach@apple.com>
2367
2368         Reviewed by Beth Dakin.
2369
2370         VO not able to perform a VO-spacebar on facebook links
2371         https://bugs.webkit.org/show_bug.cgi?id=36132
2372
2373         * DumpRenderTree/AccessibilityUIElement.cpp:
2374         (pressCallback):
2375         (AccessibilityUIElement::getJSClass):
2376         * DumpRenderTree/AccessibilityUIElement.h:
2377         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2378         (AccessibilityUIElement::press):
2379         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2380         (AccessibilityUIElement::press):
2381         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2382         (AccessibilityUIElement::press):
2383
2384 2010-03-15  Mark Rowe  <mrowe@apple.com>
2385
2386         Add a new build slave to replace the existing SnowLeopard Leaks build slave which
2387         appears to be suffering a slow and painful death at the hands of its graphics hardware.
2388
2389         * BuildSlaveSupport/build.webkit.org-config/config.json:
2390
2391 2010-03-15  Dirk Pranke  <dpranke@chromium.org>
2392
2393         Reviewed by Alexey Proskuryakov.
2394
2395         Fix a minor case where we'd deference a null pointer if we tried
2396         to run new-run-webkit-tests on an unsupported platform (e.g.
2397         Cygwin's python version).
2398
2399         https://bugs.webkit.org/show_bug.cgi?id=36076
2400
2401         * Scripts/webkitpy/layout_tests/port/factory.py:
2402
2403 2010-03-15  Darin Adler  <darin@apple.com>
2404
2405         Tell Subversion about more directories that expect to have .pyc files.
2406
2407         * Scripts/webkitpy/layout_tests: Added property svn:ignore.
2408         * Scripts/webkitpy/layout_tests/port: Added property svn:ignore.
2409
2410 2010-03-15  Adam Barth  <abarth@webkit.org>
2411
2412         Reviewed by Darin Adler.
2413
2414         Operational scripts from running the EWS
2415         https://bugs.webkit.org/show_bug.cgi?id=36097
2416
2417         These are the scripts I use to manage the EWS on EC2.  If someone other
2418         than me wants to run the EWS, these scripts might be helpful.
2419
2420         * EWSTools/boot.sh: Added.
2421         * EWSTools/create-webkit-git: Added.
2422         * EWSTools/screen-config: Added.
2423         * EWSTools/start-queue.sh: Added.
2424
2425 2010-03-14  Adam Barth  <abarth@webkit.org>
2426
2427         Unreviewed.
2428
2429         Fix the webkit-patch bots.  Turns out they need the path of the main
2430         script to run properly.
2431
2432         * Scripts/webkit-patch:
2433         * Scripts/webkitpy/patch/patcher.py:
2434
2435 2010-03-14  Darin Adler  <darin@apple.com>
2436
2437         Tell Subversion about more directories that expect to have .pyc files.
2438
2439         * Scripts/webkitpy/init: Added property svn:ignore.
2440         * Scripts/webkitpy/patch: Added property svn:ignore.
2441         * Scripts/webkitpy/thirdparty: Added property svn:ignore.
2442         * Scripts/webkitpy/thirdparty/autoinstalled: Added property svn:ignore.
2443
2444 2010-03-14  Antti Koivisto  <koivisto@iki.fi>
2445
2446         Reviewed by Simon Hausmann.
2447
2448         https://bugs.webkit.org/show_bug.cgi?id=35146
2449         Support tiled backing store
2450
2451         QtLauncher support and build flag in build-webkit.
2452
2453         * QtLauncher/main.cpp:
2454         (LauncherWindow::applyPrefs):
2455         (LauncherWindow::toggleTiledBackingStore):
2456         (LauncherWindow::toggleResizesToContents):
2457         (LauncherWindow::createChrome):
2458         (LauncherApplication::handleUserOptions):
2459         * QtLauncher/webview.cpp:
2460         (WebViewGraphicsBased::WebViewGraphicsBased):
2461         (WebViewGraphicsBased::setResizesToContents):
2462         (WebViewGraphicsBased::resizeEvent):
2463         * QtLauncher/webview.h:
2464         * Scripts/build-webkit:
2465
2466 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2467
2468         Reviewed by Adam Barth.
2469
2470         The webkit-patch script now displays a warning if run using
2471         a version of Python less than 2.5.  This will help users
2472         understand why webkit-patch is erroring out if they are
2473         using Python 2.4, for example.
2474
2475         https://bugs.webkit.org/show_bug.cgi?id=31533
2476
2477         * Scripts/webkit-patch:
2478           - Moved most of the file contents to webkitpy/patch/patcher.py
2479             so the Python version can be checked before interpreting
2480             any code that can cause the script to error out.
2481           - Added a configure_logging() method to enable any version
2482             warnings to show up.
2483           - Added a main() method with calls to configure_logging(),
2484             check_version(), and the main webkit patch method.
2485
2486         * Scripts/webkitpy/patch/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
2487           - This file is required to make a folder a package.
2488
2489         * Scripts/webkitpy/patch/patcher.py: Added.
2490           - Moved code from Scripts/webkit-patch.
2491
2492 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2493
2494         Reviewed by Adam Barth.
2495
2496         Changed test-webkitpy so that messages logged as a side-effect
2497         of unit-testing code do not get displayed to the screen.  These
2498         messages clutter up the unit test results if not filtered out.
2499
2500         https://bugs.webkit.org/show_bug.cgi?id=35835
2501
2502         * Scripts/test-webkitpy:
2503           - Adjusted the configure_logging() method to filter out any
2504             log messages from webkitpy.
2505           - Also added an INFO message stating that most console logging
2506             is getting suppressed.
2507
2508         * Scripts/webkitpy/init/versioning.py:
2509           - Added a log parameter to the check_version() method.
2510
2511         * Scripts/webkitpy/init/versioning_unittest.py:
2512           - Qualified a call to check_version() with the parameter names.
2513
2514 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2515
2516         Reviewed by Adam Barth.
2517
2518         The test-webkitpy script now warns the user if the script is
2519         being run using a Python version different from the minimum
2520         version the webkitpy package was meant to support.
2521
2522         https://bugs.webkit.org/show_bug.cgi?id=35788
2523
2524         Warning developers if their Python version is too low will help
2525         them understand why test-webkitpy is failing.  Secondly, warning
2526         developers if their Python version is higher than the minimum will
2527         help them understand that their changes may not be okay for the
2528         minimum supported version, even if test-webkitpy is passing.
2529
2530         * Scripts/test-webkitpy:
2531           - Moved the "from ..._unittest import *" lines to the new
2532             file Scripts/webkitpy/unittests.py.  This will allow the
2533             version-check warning to be displayed even if an error occurs
2534             while interpreting (i.e. importing) the unit test code.
2535           - Added configure_logging() to configur logging for test-webkitpy.
2536           - Added an init() method to configure logging and check the
2537             current Python version.
2538
2539         * Scripts/webkitpy/init/unittests.py: Added.
2540           - Added a file to import all unit test modules in the
2541             webkitpy.init package.
2542
2543         * Scripts/webkitpy/init/versioning.py: Added.
2544           - Added a _MINIMUM_SUPPORTED_PYTHON_VERSION variable and set
2545             it equal to 2.5.
2546           - Added a compare_version() method to compare the current Python
2547             version against a target version.
2548           - Added a check_version() method to check the current Python
2549             version against the current minimum supported version, and to
2550             log a warning message if the check fails.
2551
2552         * Scripts/webkitpy/init/versioning_unittest.py: Added.
2553           - Added unit tests for the functions in versioning.py.
2554
2555         * Scripts/webkitpy/style/unittests.py:
2556           - Fixed/updated a code comment.
2557
2558         * Scripts/webkitpy/unittests.py: Added.
2559           - Moved the "from ..._unittest import *" lines from test-webkitpy.
2560
2561 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2562
2563         Reviewed by Adam Barth.
2564
2565         Moved all code in webkitpy/__init__.py to another location.
2566
2567         https://bugs.webkit.org/show_bug.cgi?id=35828
2568
2569         Keeping webkitpy/__init__.py free of non-trivial code allows
2570         calling code to import initialization code from webkitpy
2571         before any errors or log messages occur due to code in
2572         __init__.py.  Such initialization code can include things like
2573         version checking code and logging configuration code.  This
2574         also lets us move the autoinstall initialization code to a
2575         location where it only executes if it is needed -- something
2576         we have done in this patch.
2577
2578         * Scripts/webkitpy/__init__.py:
2579           - Moved all executable code to the following location:
2580             webkitpy/thirdparty/autoinstalled/__init__.py
2581           - Added a code comment to keep this file free of non-trivial
2582             code.
2583
2584         * Scripts/webkitpy/bugzilla.py:
2585           - Updated mechanize import statement.
2586
2587         * Scripts/webkitpy/networktransaction.py:
2588           - Updated mechanize import statement.
2589
2590         * Scripts/webkitpy/networktransaction_unittest.py:
2591           - Updated mechanize import statement.
2592
2593         * Scripts/webkitpy/statusserver.py:
2594           - Updated mechanize import statement.
2595
2596         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Added.
2597           - Copied the code from webkitpy/__init__.py and updated it
2598             as necessary.
2599
2600 2010-03-13  Chris Jerdonek  <cjerdonek@webkit.org>
2601
2602         Reviewed by Adam Barth.
2603
2604         Moved webkitpy/mock.py into webkitpy/thirdparty since it is
2605         third-party code.
2606
2607         https://bugs.webkit.org/show_bug.cgi?id=35499
2608
2609         Updated the import statement in all of the below except where noted.
2610
2611         * Scripts/webkitpy/bugzilla_unittest.py:
2612         * Scripts/webkitpy/commands/commandtest.py:
2613         * Scripts/webkitpy/commands/download_unittest.py:
2614         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
2615         * Scripts/webkitpy/commands/queries_unittest.py:
2616         * Scripts/webkitpy/commands/queues_unittest.py:
2617         * Scripts/webkitpy/commands/queuestest.py:
2618         * Scripts/webkitpy/commands/upload.py:
2619         * Scripts/webkitpy/commands/upload_unittest.py:
2620         * Scripts/webkitpy/commands_references.py: Added.
2621           - Added a file containing an absolute import of Mock so that
2622             the imports in the commands folder can import from this file
2623             (similar to style_references.py).  This helps limit the
2624             number of affected files in future refactorings.
2625
2626         * Scripts/webkitpy/credentials_unittest.py:
2627         * Scripts/webkitpy/mock.py: Removed.
2628           - Moved to Scripts/webkitpy/thirdparty.
2629
2630         * Scripts/webkitpy/mock_bugzillatool.py:
2631         * Scripts/webkitpy/patchcollection_unittest.py:
2632         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
2633         * Scripts/webkitpy/steps/steps_unittest.py:
2634         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
2635         * Scripts/webkitpy/steps_references.py: Added.
2636           - Added a file containing an absolute import of Mock so that
2637             the imports in the steps folder can import from this file
2638             (similar to style_references.py).  This helps limit the
2639             number of affected files in future refactorings.
2640
2641         * Scripts/webkitpy/thirdparty/mock.py: Copied from WebKitTools/Scripts/webkitpy/mock.py.
2642           - Also eliminated trailing white space and carriage returns.
2643
2644 2010-03-12  Robert Hogan  <robert@webkit.org>
2645
2646         Reviewed by Adam Barth.
2647
2648         Amend incorrect typo patch for QtLauncher.
2649
2650         https://bugs.webkit.org/show_bug.cgi?id=35877
2651
2652         * QtLauncher/webview.cpp:
2653         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
2654
2655 2010-03-13  Victor Wang  <victorw@chromium.org>
2656
2657         Add appengine app to host and serve webkit layout test results.
2658
2659         The app allows you post test result files (json) and serve them up.
2660         Chromium flakiness dashboard will first use this app to host results.json
2661         and expectations.json, but the files hosted by this app are not limited
2662         to chromium results or json files. It can be used to host other files if needed.
2663
2664         https://bugs.webkit.org/show_bug.cgi?id=35944
2665
2666         * TestResultServer: Added.
2667         * TestResultServer/app.yaml: Added.
2668         * TestResultServer/handlers: Added.
2669         * TestResultServer/handlers/__init__.py: Added.
2670         * TestResultServer/handlers/menu.py: Added.
2671         * TestResultServer/handlers/testfilehandler.py: Added.
2672         * TestResultServer/index.yaml: Added.
2673         * TestResultServer/main.py: Added.
2674         * TestResultServer/model: Added.
2675         * TestResultServer/model/__init__.py: Added.
2676         * TestResultServer/model/testfile.py: Added.
2677         * TestResultServer/stylesheets: Added.
2678         * TestResultServer/stylesheets/form.css: Added.
2679         * TestResultServer/stylesheets/menu.css: Added.
2680         * TestResultServer/stylesheets/testfile.css: Added.
2681         * TestResultServer/templates: Added.
2682         * TestResultServer/templates/menu.html: Added.
2683         * TestResultServer/templates/showfilelist.html: Added.
2684         * TestResultServer/templates/uploadform.html: Added.
2685
2686 2010-03-13  Dimitri Glazkov  <dglazkov@chromium.org>
2687
2688         Reviewed by David Levin.
2689
2690         new-run-webkit-tests fails with --debug option.
2691         https://bugs.webkit.org/show_bug.cgi?id=36067
2692
2693         * Scripts/webkitpy/layout_tests/port/mac.py:
2694
2695 2010-03-13  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2696
2697         Reviewed by Kenneth Rohde Christiansen.
2698
2699         Add "Show FPS" menu option to QtLauncher.
2700
2701         [Qt] QtLauncher need a menu option to show/hide FPS
2702         https://bugs.webkit.org/show_bug.cgi?id=35794
2703
2704         * QtLauncher/main.cpp:
2705         (LauncherWindow::showFPS):
2706         (LauncherWindow::createChrome):
2707
2708 2010-03-13  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2709
2710         Reviewed by Kenneth Rohde Christiansen.
2711
2712         Add a "Toggle FullScreen" option to QtLauncher Menu.
2713
2714         [Qt] QtLauncher needs an option to toggle FullScreen Mode
2715         https://bugs.webkit.org/show_bug.cgi?id=35755
2716
2717         * QtLauncher/main.cpp:
2718         (LauncherWindow::init):
2719         (LauncherWindow::eventFilter):
2720         (LauncherWindow::initializeView):
2721         (LauncherWindow::toggleFullScreenMode):
2722         (LauncherWindow::createChrome):
2723
2724 2010-03-12  Dirk Pranke  <dpranke@chromium.org>
2725
2726         Reviewed by Dimitri Glazkov.
2727
2728         Fix typo in websocket_server (path_from_base instead of 
2729         path_from_chromium_base).
2730
2731         https://bugs.webkit.org/show_bug.cgi?id=36074
2732
2733         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2734
2735 2010-03-12  Dirk Pranke  <dpranke@chromium.org>
2736
2737         Reviewed by Adam Barth.
2738
2739         new-run-webkit-tests --new-baseline doesn't work at all.
2740
2741         It attempts to call a method that isn't defined. To fix it, I
2742         removed the unnecessary and unnecessarily confusing 'platform'
2743         argument to the test_type constructor and use the Port object that
2744         is passed in instead, since we are only ever generating a baseline
2745         from the port that is currently executing.
2746
2747         https://bugs.webkit.org/show_bug.cgi?id=36046
2748
2749         * Scripts/webkitpy/layout_tests/port/mac.py:
2750         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2752         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2753
2754 2010-03-12  Dirk Pranke  <dpranke@chromium.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         Fix new-run-webkit-tests --run-singly
2759
2760         This script option is currently broken - the script attempts to
2761         dereference methods and variables that don't exist, which causes
2762         the Chromium Linux valgrind bot to be quite unhappy. This has been
2763         broken since r54449 when I renamed Port.start_test_driver to
2764         Port.start_driver.
2765
2766         https://bugs.webkit.org/show_bug.cgi?id=36042
2767
2768         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2769
2770 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2771
2772         Fix critical being printed to stderr on every test. This is
2773         because the jar is only being created when soup hits the HTTP
2774         path. We should reconsider the time of its creation.
2775
2776         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2777         (resetDefaultsToConsistentValues):
2778
2779 2010-03-12  Adam Roben  <aroben@apple.com>
2780
2781         Teach prepare-ChangeLog to find modified selectors in CSS files
2782
2783         Reviewed by Tim Hatcher.
2784
2785         Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
2786         modified selectors from CSS files
2787
2788         * Scripts/prepare-ChangeLog:
2789         (get_function_line_ranges): Call get_selector_line_ranges_for_css for
2790         .css files.
2791         (get_selector_line_ranges_for_css): Added. Finds selectors and their
2792         line ranges and returns them.
2793
2794 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2795
2796         Build fix (for EWS). Make sure the new code builds on older soup.
2797
2798         Thanks to Dan Winship.
2799
2800         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2801         (resetDefaultsToConsistentValues):
2802         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2803         (LayoutTestController::setAlwaysAcceptCookies):
2804
2805 2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2806
2807         Reviewed by Eric Carlson.
2808
2809         [GTK] DRT does not handle cookie policy setting
2810         https://bugs.webkit.org/show_bug.cgi?id=36056
2811
2812         Implement cookie accept policy setting for GTK+'s LayoutTestController.
2813
2814         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2815         (resetDefaultsToConsistentValues):
2816         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2817         (LayoutTestController::setAlwaysAcceptCookies):
2818
2819 2010-03-12  Adam Langley  <agl@chromium.org>
2820
2821         Reviewed by Dimitri Glazkov.
2822
2823         [chromium]: update Linux layout test scripts for RedHat like systems.
2824
2825         (Tested on Fedora 12.)
2826
2827         https://bugs.webkit.org/show_bug.cgi?id=35867
2828
2829         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2830
2831 2010-03-12  Adam Roben  <aroben@apple.com>
2832
2833         Make svn-create-patch's diffs of ObjC header files more readable
2834
2835         Fixes <http://webkit.org/b/36055>.
2836
2837         Reviewed by John Sullivan.
2838
2839         * Scripts/svn-create-patch:
2840         (diffOptionsForFile): Added. Returns the options that should be passed
2841         to diff for the given file. All the options are the same for all
2842         files, except for the option to specify which lines should be used as
2843         hunk headers.
2844         (generateDiff): Use diffOptionsForFile to get the options to pass to
2845         diff.
2846         (hunkHeaderLineRegExForFile): Added. Returns the regular expression
2847         that should be used by diff to identify lines that should be included
2848         after the "@@" in the hunk header lines of the diff. For ObjC[++]
2849         source files, we use any lines starting with -, +, or
2850         @implementation/@interface/@protocol. For ObjC[++] header files (which
2851         we assume to be any .h files in a mac/ or objc/ directory), we use any
2852         lines starting with @implementation/@interface/@protocol.
2853
2854 2010-03-12  Jochen Eisinger  <jochen@chromium.org>
2855
2856         Reviewed by Jeremy Orlow.
2857
2858         Introduce setWillSendRequestClearHeader to LayoutTestController to selectively remove headers in willSendRequest. Used in http/tests/security/no-referrer.html
2859         https://bugs.webkit.org/show_bug.cgi?id=35920
2860
2861         * DumpRenderTree/LayoutTestController.cpp:
2862         (setWillSendRequestClearHeaderCallback):
2863         (LayoutTestController::staticFunctions):
2864         * DumpRenderTree/LayoutTestController.h:
2865         (LayoutTestController::willSendRequestClearHeaders):
2866         (LayoutTestController::setWillSendRequestClearHeader):
2867         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2868         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2869         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2870         (ResourceLoadDelegate::willSendRequest):
2871
2872 2010-03-11  Fumitoshi Ukai  <ukai@chromium.org>
2873
2874         Unreviewed.
2875
2876         Fix typo in websocket_server.py
2877
2878         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2879
2880 2010-03-11  Garret Kelly  <gdk@chromium.org>
2881
2882         Reviewed by Darin Adler.
2883
2884         Fixing minor typo in the commit queue status page.
2885         https://bugs.webkit.org/show_bug.cgi?id=35979
2886
2887         * Scripts/webkitpy/commands/queues.py:
2888
2889 2010-03-11  Fumitoshi Ukai  <ukai@chromium.org>
2890
2891         Unreviewed.
2892
2893         Fix for WebSocket layout test runner on chromium/win port.
2894
2895         * Scripts/webkitpy/layout_tests/port/websocket_server.py: register_cygwin and set CYGWIN_PATH
2896
2897 2010-03-11  Mark Rowe  <mrowe@apple.com>
2898
2899         Reviewed by David Kilzer.
2900
2901         <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
2902
2903         Default to using the appropriate SDK if the target Mac OS X version is not the current Mac OS X version.
2904
2905         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2906
2907 2010-03-11  Victor Wang  <victorw@chromium.org>
2908
2909         Reviewed by dglazkov@chromium.org.
2910
2911         rebaseline_chromium_webkit_tests can generate new baselines for
2912         all platforms so it needs to know two ports in order to work correctly:
2913         the port that the script is running on and the port that it generates
2914         new baselines for. Update rebaselining tool to handle both port correctly.
2915
2916         https://bugs.webkit.org/show_bug.cgi?id=36032
2917
2918         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2919
2920 2010-03-11  Mark Rowe  <mrowe@apple.com>
2921
2922         Reviewed by Tim Hatcher.
2923
2924         <rdar://problem/7745082> Make it possible to build WebKit for older Mac OS X versions from the current Mac OS X version
2925
2926         Introduce TARGET_MAC_OS_X_VERSION_MAJOR to represent the Mac OS X version that is being targeted.  It defaults to the
2927         current Mac OS X version unless otherwise specified.
2928
2929         Key off TARGET_MAC_OS_X_VERSION_MAJOR where we'd previously been keying off MAC_OS_X_VERSION_MAJOR.
2930
2931         Explicitly map from the target Mac OS X version to the preferred compiler since Xcode's default compiler choice
2932         may not be usable when targetting a different Mac OS X version.
2933
2934         Key off TARGET_GCC_VERSION rather than MAC_OS_X_VERSION_MAJOR in locations where we'd previously been keying off
2935         MAC_OS_X_VERSION_MAJOR but the decision is really related to the compiler version being used.
2936
2937         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2938         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2939         * DumpRenderTree/mac/DumpRenderTree.mm: Wrap the include of mach-o/getsect.h in 'extern "C"' as some versions of the
2940         header in older SDKs do not do this inside the header.
2941
2942 2010-03-11  Alexey Proskuryakov  <ap@apple.com>
2943
2944         Reviewed by Geoff Garen.
2945
2946         https://bugs.webkit.org/show_bug.cgi?id=35965
2947         <rdar://problem/7742771> Crash when passing an object returned from plug-in back to the plug-in
2948
2949         Made rememberedObject a member of PluginObject. A plug-in must not use its references
2950         to browser NPObjects after being destroyed, but this wasn't the case with static variable.
2951
2952         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2953         (pluginInvoke):
2954         (pluginInvalidate):
2955         (pluginAllocate):
2956         (pluginDeallocate):
2957         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2958
2959 2010-03-11  Simon Fraser  <simon.fraser@apple.com>
2960
2961         Reviewed by Oliver Hunt.
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=35905
2964         REGRESSION(55699?): media/video-no-autoplay.html times out on Leopard Commit Bot
2965
2966         Make sure we reset the WebGL preference, so that WebGL doesn't get left
2967         on after being enabled via layoutTestController.overridePreference(),
2968         which in turn causes accelerated compositing to be enabled on Leopard
2969         when we don't want it to be.
2970         
2971         * DumpRenderTree/mac/DumpRenderTree.mm:
2972         (resetDefaultsToConsistentValues):
2973
2974 2010-03-10  Dirk Pranke  <dpranke@chromium.org>
2975
2976         Reviewed by Dimitri Glazkov.
2977
2978         rebaseline_chromium_webkit_tests doesn't handle other plaforms
2979         correctly (e.g., if you run on the Mac platform and try to
2980         rebaseline the WIN results, the result gets written into
2981         platform/mac instead of platform/chromium-win). Also, this script
2982         doesn't work on non-Chromium ports, so we need to fix that at some
2983         point.
2984
2985         https://bugs.webkit.org/show_bug.cgi?id=35982
2986
2987         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2988
2989 2010-03-10  Daniel Bates  <dbates@rim.com>
2990
2991         Reviewed by Simon Hausmann.
2992
2993         https://bugs.webkit.org/show_bug.cgi?id=35840
2994
2995         Updates the subroutine builtDylibPathForName() so that it adds the "d" suffix to
2996         the QtWebKit library name on Windows. This change makes run-launcher work again
2997         under Windows. Moreover, this change corresponds to the change made in change-
2998         set 53924 <http://trac.webkit.org/changeset/53924>.
2999
3000         * Scripts/webkitdirs.pm:
3001
3002 2010-03-10  Adam Roben  <aroben@apple.com>
3003
3004         Roll out the prepare-ChangeLog part of r55870
3005
3006         This change wasn't needed (prepare-ChangeLog calls svn-create-patch
3007         when it's asked to print out diffs for the user) and was screwing up
3008         its ability to find changed function names.
3009
3010         * Scripts/prepare-ChangeLog:
3011         (diffCommand): Change the options we pass to svn-diff back to their
3012         pre-r55870 form.
3013
3014 2010-03-10  Robert Hogan  <robert@webkit.org>
3015
3016         Reviewed by Simon Hausmann.
3017
3018         [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
3019
3020         Unskip test fast/events/multiline-link-arrow-navigation.html
3021
3022         https://bugs.webkit.org/show_bug.cgi?id=35593
3023
3024         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3025         (WebCore::WebPage::resetSettings):
3026         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3027         (LayoutTestController::overridePreference):
3028         (LayoutTestController::setCaretBrowsingEnabled):
3029         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3030
3031 2010-03-10  Robert Hogan  <robert@webkit.org>
3032
3033         Reviewed by Holger Freyther.
3034
3035         QtLauncher: Fix typo in conditional statement in
3036                     WebViewGraphicsBased::setFrameRateMeasurementEnabled.
3037
3038         '=' should be '=='!
3039
3040         https://bugs.webkit.org/show_bug.cgi?id=35877
3041
3042         * QtLauncher/webview.cpp:
3043         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
3044
3045 2010-03-10  Chris Jerdonek  <cjerdonek@webkit.org>
3046
3047         Reviewed by Shinichiro Hamaji.
3048
3049         Refactored and cleaned up the code for unit-testing logging.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=35845
3052
3053         * Scripts/webkitpy/init/logtesting.py:
3054           - Added more information to the module docstring.
3055           - Added an assertMessages() method to the UnitTestLogStream
3056             class.  This simplifies the calling code.
3057           - Renamed the UnitTestLog class to LogTesting, and reformulated
3058             it as follows:
3059               - Moved the logging configuration code from the __init__
3060                 method to a new static setUp() method.
3061               - Documented the __init__ method to be private.
3062               - Improved the code so that the root logger does not have
3063                 its logging level changed.  Instead we set the handler's
3064                 level.  This makes the unit testing more unintrusive.
3065               - Updated the assertMessages() method to call the
3066                 UnitTestLogStream class's assertMessages() method.
3067               - More fully documented the class.
3068
3069         * Scripts/webkitpy/style/checker.py:
3070           - Added a logger parameter to the configure_logging() method.
3071             This allows us to prevent test messages from being sent
3072             to the root logger during unit testing, which may be
3073             rendering to the screen, etc.
3074           - Simplified the code by removing the _LevelLoggingFilter class.
3075           - Replaced the _LevelLoggingFilter class with a one-line lambda
3076             expression in configure_logging().
3077
3078         * Scripts/webkitpy/style/checker_unittest.py:
3079           - Changed relative imports to absolute to comply more with PEP8.
3080           - In the ConfigureLoggingTest class:
3081             - Changed the setUp() method to prevent test messages from
3082               being propagated to the root logger.
3083             - Changed the _log() method to a data attribute.
3084             - Updated to accommodate changes to logtesting.py.
3085
3086         * Scripts/webkitpy/style_references.py:
3087           - Updated an import statement.
3088
3089 2010-03-10  Evan Martin  <evan@chromium.org>
3090
3091         Reviewed by Darin Adler.
3092
3093         Python code for GDB 7 to support native printing of some WebCore types.
3094
3095         * gdb/webcore.py: Added.
3096
3097 2010-03-10  Adam Roben  <aroben@apple.com>
3098
3099         Make svn-create-patch and prepare-ChangeLog show better section
3100         headings for ObjC files
3101
3102         This makes the text at the end of each "@@" line in a diff actually
3103         show the ObjC method or interface that contains the change, rather
3104         than whatever the most-recently-defined C function was.
3105
3106         Fixes <http://webkit.org/b/35970>.
3107
3108         Reviewed by John Sullivan.
3109
3110         * Scripts/svn-create-patch: Pass -F'^[-+@]' to diff so that it will
3111         treat any lines starting with -, +, or @ as section heading lines.
3112         This works well for ObjC files, and shouldn't affect other types of
3113         files.
3114
3115         * Scripts/prepare-ChangeLog: Changed the options passed to diff to
3116         match those used in svn-create-patch.
3117
3118 2010-03-10  Simon Hausmann  <simon.hausmann@nokia.com>
3119
3120         Reviewed by Tor Arne Vestbø.
3121
3122         Link QtLauncher against the WebKit library using a relative rpath.
3123
3124         This makes the launcher and the lib relocatable.
3125
3126         * QtLauncher/QtLauncher.pro:
3127
3128 2010-03-10  Holger Hans Peter Freyther  <zecke@selfish.org>
3129
3130         Rubber-stamped by Simon Hausmann.
3131
3132         [iExploder] Add new CSS Properties and HTML Attributes
3133
3134         The update-iexploder-cssproperties script was used to update
3135         the various input files. The autobuffer HTML Attribute was removed
3136         from WebKit and I manually added it back to the htmlattrs.in like
3137         we have done it for other attributes in the past.
3138
3139         * iExploder/htdocs/cssproperties.in:
3140         * iExploder/htdocs/htmlattrs.in:
3141         * iExploder/htdocs/htmltags.in:
3142
3143 2010-03-09  Fumitoshi Ukai  <ukai@chromium.org>
3144
3145         Unreviewed.
3146
3147         Obvious fix for --cgi-paths of pywebsocket.
3148
3149         * Scripts/run-webkit-websocketserver:
3150         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3151
3152 2010-03-09  Jakub Wieczorek  <jwieczorek@webkit.org>
3153
3154         Unreviewed.
3155
3156         Adding myself to committers.py.
3157
3158         * Scripts/webkitpy/committers.py:
3159
3160 2010-03-09  Dirk Pranke  <dpranke@chromium.org>
3161
3162         Reviewed by Nate Chapin.
3163
3164         Fix --clobber-old-results in new-run-webkit-tests.
3165
3166         https://bugs.webkit.org/show_bug.cgi?id=35778
3167
3168         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3169
3170 2010-03-09  Andy Estes  <aestes@apple.com>
3171
3172         Reviewed by Adele Peterson.
3173
3174         Add the ability to dispatch scroll wheel events in DRT.  This was
3175         necessary in order to write a test for
3176         https://bugs.webkit.org/show_bug.cgi?id=34700.
3177
3178         * DumpRenderTree/mac/EventSendingController.mm: Add support for two
3179         new methods to EventSender: mouseScrollBy(x, y) and
3180         continuousMouseScrollBy(x, y).  The API to generate scroll events on
3181         the mac was added in 10.5, so these methods are NOOPs on Tiger.
3182         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3183         Regiester mouseScrollByX:andY: and continuousMouseScrollByX:andY:
3184         (+[EventSendingController webScriptNameForSelector:]): Map JavaScript
3185         method names to ObjC selectors.
3186         (-[EventSendingController mouseScrollByX:andY:continuously:]): Generate
3187         a scroll wheel event using CGEventCreateScrollWheelEvent() and dispatch
3188         it to WebKit.
3189         (-[EventSendingController continuousMouseScrollByX:andY:]): Generate a
3190         continuous scrolling event by x and y pixels.
3191         (-[EventSendingController mouseScrollByX:andY:]): Generate a notchy
3192         scrolling event by x and y lines.
3193
3194 2010-03-09  Chris Fleizach  <cfleizach@apple.com>
3195
3196         DRT build fix for Tiger. No review.
3197
3198         AX: hit testing a list box doesn't work anymore
3199         https://bugs.webkit.org/show_bug.cgi?id=35893
3200
3201         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3202         (AccessibilityController::elementAtPoint):
3203
3204 2010-03-09  Chris Fleizach  <cfleizach@apple.com>
3205
3206         Reviewed by Darin Adler.
3207
3208         AX: hit testing a list box doesn't work anymore
3209         https://bugs.webkit.org/show_bug.cgi?id=35893
3210
3211         * DumpRenderTree/AccessibilityController.cpp:
3212         (getElementAtPointCallback):
3213         (AccessibilityController::getJSClass):
3214         * DumpRenderTree/AccessibilityController.h:
3215         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3216         (AccessibilityController::elementAtPoint):
3217         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3218         (AccessibilityController::elementAtPoint):
3219         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3220         (AccessibilityController::elementAtPoint):
3221
3222 2010-03-03  Fumitoshi Ukai  <ukai@chromium.org>
3223
3224         Reviewed by Alexey Proskuryakov.
3225
3226         pywebsocket should support html and cgi in the same directory.
3227         https://bugs.webkit.org/show_bug.cgi?id=34879
3228
3229         Import pywebsocket 0.4.9.2
3230         Specify --server-host 127.0.0.1, so that it only binds listening socket
3231         to 127.0.0.1 to prevent access from non-localhost.
3232         Change --cgi-paths from /websocket/tests/cookies to /websocket/tests,
3233         because pywebsocket 0.4.9.2 supports html and cgi in the same directory
3234         and only executable (httponly-cookies.pl) will be handled as cgi
3235         script.
3236
3237         * Scripts/run-webkit-tests:
3238         * Scripts/run-webkit-websocketserver:
3239         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3240         * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit:
3241         * Scripts/webkitpy/thirdparty/pywebsocket/example/echo_client.py:
3242         * Scripts/webkitpy/thirdparty/pywebsocket/example/handler_map.txt: Added.
3243         * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/standalone.py:
3244         * Scripts/webkitpy/thirdparty/pywebsocket/mod_pywebsocket/util.py:
3245         * Scripts/webkitpy/thirdparty/pywebsocket/setup.py:
3246         * Scripts/webkitpy/thirdparty/pywebsocket/test/test_util.py:
3247         * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/README: Added.
3248         * Scripts/webkitpy/thirdparty/pywebsocket/test/testdata/hello.pl: Added.
3249
3250 2010-03-09  Chris Jerdonek  <cjerdonek@webkit.org>
3251
3252         Reviewed by Shinichiro Hamaji.
3253
3254         Simplified check-webkit-style's argument parsing code by removing
3255         support for the vestigial "extra flag values" parameter.
3256
3257         https://bugs.webkit.org/show_bug.cgi?id=34677
3258
3259         The "extra flag values" parameter was needed before WebKit
3260         forked check-webkit-style from Google.  It was used to pass
3261         through the option parser those command-line flags that WebKit
3262         required but that Google's parser did not support (the --git-commit
3263         flag in particular).
3264             We can remove the parameter now because it is no longer
3265         needed and unnecessarily clutters the argument-parsing code.
3266
3267         * Scripts/webkitpy/style/optparser.py:
3268           - Removed the extra_flag_values parameter from the
3269             CommandOptionValues class's constructor.
3270           - Removed the extra_flags parameter from the ArgumentParser
3271             class's parse() method.
3272
3273         * Scripts/webkitpy/style/optparser_unittest.py:
3274           - Removed from the unit tests all references to the
3275             extra_flag_values variable.
3276
3277 2010-03-08  Kent Tamura  <tkent@chromium.org>
3278
3279         Reviewed by Dimitri Glazkov.
3280
3281         [DRT/Chromium] Add EventSender
3282         https://bugs.webkit.org/show_bug.cgi?id=35859
3283
3284         Add EventSender classes, which are going to be used by
3285         DumpRenderTree Chromium port. These files are based on:
3286         - src/webkit/tools/test_shell/event_sending_controller.cc
3287         - src/webkit/tools/test_shell/event_sending_controller.h
3288         of Chromium rev.40492.
3289
3290         * DumpRenderTree/chromium/EventSender.cpp: Added.
3291         * DumpRenderTree/chromium/EventSender.h: Added.
3292
3293 2010-03-08  Kent Tamura  <tkent@chromium.org>
3294
3295         Reviewed by Dimitri Glazkov.
3296
3297         [DRT/Chromium] Add PlainTextController and TextInputController
3298         https://bugs.webkit.org/show_bug.cgi?id=35852
3299
3300         Add PlainTextController and TextInputController classes, which are going
3301         to be used by DumpRenderTree Chromium port. These files are based on:
3302         - src/webkit/tools/test_shell/plain_text_controller.{cc,h} and
3303         - src/webkit/tools/test_shell/text_input_controller.{cc,h}
3304         of Chromium rev.40492.
3305
3306         * DumpRenderTree/chromium/PlainTextController.cpp: Added.
3307         * DumpRenderTree/chromium/PlainTextController.h: Added.
3308         * DumpRenderTree/chromium/TextInputController.cpp: Added.
3309         * DumpRenderTree/chromium/TextInputController.h: Added.
3310
3311 2010-03-08  Dumitru Daniliuc  <dumi@chromium.org>
3312
3313         Unreviewed, Chromium build fix.
3314
3315         Reverting r55689.
3316
3317         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3318
3319 2010-03-08  Fumitoshi Ukai  <ukai@chromium.org>
3320
3321         Reviewed by Adam Barth.
3322
3323         Fix webkit-patch post and land to work well with security bug
3324         https://bugs.webkit.org/show_bug.cgi?id=35733
3325
3326         Bugzilla requires authentication to access security bug page,
3327         so call authenticate() if it failed to fetch bug page.
3328
3329         * Scripts/webkitpy/bugzilla.py:
3330
3331 2010-03-04  Dirk Pranke  <dpranke@chromium.org>
3332
3333         Reviewed by Dimitry Glazkov.
3334
3335         Fix --clobber-old-results in new-run-webkit-tests.
3336
3337         https://bugs.webkit.org/show_bug.cgi?id=35778
3338
3339         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3340
3341 2010-03-08  Brady Eidson  <beidson@apple.com>
3342
3343         Reviewed by NOBODY (but suggested by Steve Falkenburg and fixing a boneheaded mistake on my part last week)
3344
3345         Followup to https://bugs.webkit.org/show_bug.cgi?id=35532
3346
3347         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3348         (LayoutTestController::apiTestGoToCurrentBackForwardItem): Can't pass in a null BOOL to WebKit APIs.
3349
3350 2010-03-08  Chris Jerdonek  <cjerdonek@webkit.org>
3351
3352         Unreviewed.
3353
3354         Fixed incorrect import statement in validate-committer-lists:
3355         webkitpy.BeautifulSoup -> webkitpy.thirdparty.BeautifulSoup.
3356
3357         * Scripts/validate-committer-lists:
3358
3359 2010-03-08  Jian Li  <jianli@chromium.org>
3360
3361         Reviewed by Dmitry Titov.
3362
3363         Blob.slice support.
3364         https://bugs.webkit.org/show_bug.cgi?id=32993
3365
3366         Add ENABLE_BLOB_SLICE feature define and  flag for build-webkit. It is
3367         currently only turned on for Mac.
3368
3369         * Scripts/build-webkit:
3370
3371 2010-03-08  Gustavo Noronha Silva  <gns@gnome.org>
3372
3373         No review, rolling out r55662.
3374         http://trac.webkit.org/changeset/55662
3375         https://bugs.webkit.org/show_bug.cgi?id=35863
3376
3377         Need to be coordinated with bots setup
3378
3379         * Scripts/run-webkit-tests:
3380
3381 2010-03-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3382
3383         Reviewed by Holger Freyther.
3384
3385         [GTK] Tests fail when running with ipv6 addresses available, on Debian systems
3386         https://bugs.webkit.org/show_bug.cgi?id=35863
3387
3388         If running on a Debian-based system, also listen on the ipv6 address.
3389
3390         * Scripts/run-webkit-tests:
3391
3392 2010-03-08  Holger Hans Peter Freyther  <zecke@selfish.org>
3393
3394         Reviewed by Darin Adler.
3395
3396         [iexploder] Automatically update htmltags.in and htmlattrs.in too
3397         https://bugs.webkit.org/show_bug.cgi?id=33755
3398
3399         Change the update-iexploder-cssproperites script to update
3400         the htmlattrs.in and htmltags.in of WebKitTools/iExploder/htdocs
3401         automatically as well.
3402
3403         Change the reading and writing code to work with parameters
3404         and extend the method that is parsing the .in files to handle
3405         the HTMLTagNames.in and the HTMLAttributeNames.in files.
3406
3407         Remove custom code to determine the revision of files with a
3408         utility of VCUtils.pm to determine the revision of the directory
3409         these files are located in. This will also work with git checkout.
3410
3411         * Scripts/update-iexploder-cssproperties:
3412
3413 2010-03-07  Shinichiro Hamaji  <hamaji@chromium.org>
3414
3415         Reviewed by Eric Seidel.
3416
3417         check-webkit-style: false positive for empty loop
3418         https://bugs.webkit.org/show_bug.cgi?id=35717
3419
3420         * Scripts/webkitpy/style/processors/cpp.py:
3421         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3422
3423 2010-03-07  Kent Tamura  <tkent@chromium.org>
3424
3425         Reviewed by Dimitri Glazkov.
3426
3427         [DRT/Chromium] Add AccessibilityController and AccessibilityUIElement
3428         https://bugs.webkit.org/show_bug.cgi?id=35774
3429
3430         Add AccessibilityController and AccessibilityUIElement classes,
3431         which are going to be used by DumpRenderTree Chromium port. These
3432         files are based on:
3433         - src/webkit/tools/test_shell/accessibility_controller.{cc,h} and
3434         - src/webkit/tools/test_shell/accessibility_ui_element.{cc,h}
3435         of Chromium rev.40492.
3436
3437         * DumpRenderTree/chromium/AccessibilityController.cpp: Added.
3438         * DumpRenderTree/chromium/AccessibilityController.h: Added.
3439         * DumpRenderTree/chromium/AccessibilityUIElement.cpp: Added.
3440         * DumpRenderTree/chromium/AccessibilityUIElement.h: Added.
3441
3442 2010-03-06  Hironori Bono  <hbono@chromium.org>
3443
3444         Reviewed by Eric Seidel.
3445
3446         [Chromium] Typing into Flash with wmode = opaque|transparent and
3447         non-latin language active outputs as if US keyboard layout active
3448
3449         https://bugs.webkit.org/show_bug.cgi?id=34936
3450
3451         To test keyboard events on the test plugin, this change implements
3452         NPCocoaEventKeyDown and NPCocoaEventKeyUp handlers so the plugin
3453         can write log messages.
3454
3455         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3456         (handleEventCocoa): Implemented the event handlers for NPCocoaKeyDown
3457         and NPCocoaEventKeyUp.
3458
3459 2010-03-05  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3460
3461         Reviewed by Eric Seidel.
3462
3463         Fix Print option on QtLauncher by calling print directly from QWebFrame.
3464
3465         [Qt] QtLauncher Print option is not working on QGraphicsView mode
3466         https://bugs.webkit.org/show_bug.cgi?id=35769
3467
3468         * QtLauncher/main.cpp:
3469         (LauncherWindow::print):
3470
3471 2010-03-05  Chris Jerdonek  <cjerdonek@webkit.org>
3472
3473         Reviewed by Eric Seidel.
3474
3475         Changed the logging code for new-run-webkit-tests to use
3476         module-specific loggers rather than the root logger. This is
3477         a standard practice that allows logging specific to a package
3478         to be configured independently of other modules.
3479
3480         https://bugs.webkit.org/show_bug.cgi?id=35194
3481
3482         Added a line of the form "_log = logging.getLogger(<module>)"
3483         to each module below, where <module> is the fully-qualified
3484         name of the module, and updated the log lines to use the new
3485         _log logger.
3486
3487         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3488         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3489         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
3490         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3491         * Scripts/webkitpy/layout_tests/port/chromium.py:
3492         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3493         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3494         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3495         * Scripts/webkitpy/layout_tests/port/http_server.py:
3496         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
3497         * Scripts/webkitpy/layout_tests/port/mac.py:
3498         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3499         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3501         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
3502         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3503         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3504         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3505
3506 2010-03-05  Dirk Pranke  <dpranke@chromium.org>
3507
3508         Reviewed by Eric Siedel.
3509
3510         Split the command-line invocation of the Chromium/python LigHTTPd
3511         server implementation out into its own top level script to make it
3512         a more "public" interface and to resolve some awkward layering
3513         issues. This script will be called directly by other test scripts in
3514         the Chromium tree.
3515
3516         At some point this script should be made to work with Apache-based
3517         implementations and on other ports. I have filed
3518         https://bugs.webkit.org/show_bug.cgi?id=35820 for this.
3519
3520         Also fix a bug in port/factory where options.chromium could be
3521         dereferenced even if it wasn't set, raising an exception.
3522
3523         https://bugs.webkit.org/show_bug.cgi?id=35812
3524
3525         * Scripts/webkitpy/layout_tests/port/factory.py:
3526         * Scripts/webkitpy/layout_tests/port/http_server.py:
3527         * Scripts/new-run-webkit-httpd: Added
3528
3529 2010-03-02  Antonio Gomes  <tonikitoo@webkit.org>
3530
3531         Reviewed by Holger Freyther
3532         Patch by Antonio Gomes <tonikitoo@webkit.org>
3533
3534         [Gtk] Implement setSpatialNavigationEnabled in DRT.
3535         https://bugs.webkit.org/show_bug.cgi?id=35705
3536
3537         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3538         (resetDefaultsToConsistentValues):
3539         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3540         (LayoutTestController::setSpatialNavigationEnabled):
3541
3542 2010-02-23  Antonio Gomes  <tonikitoo@webkit.org>
3543
3544         Reviewed by Kenneth Christiansen.
3545         Patch by Antonio Gomes <tonikitoo@webkit.org>
3546
3547         Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
3548         https://bugs.webkit.org/show_bug.cgi?id=35699
3549
3550         * DumpRenderTree/LayoutTestController.cpp:
3551         (setSpatialNavigationEnabledCallback):
3552         (LayoutTestController::staticFunctions):
3553         * DumpRenderTree/LayoutTestController.h:
3554         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3555         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3556         (LayoutTestController::setSpatialNavigationEnabled):
3557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3558         (LayoutTestController::setSpatialNavigationEnabled):
3559         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3560         (LayoutTestController::setSpatialNavigationEnabled):
3561