30ae7af78cc43e4e1e9462921b76a835ded39033
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-04-30  Chris Marrin  <cmarrin@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         Enabled accelerated compositing in DRT for Windows
6         https://bugs.webkit.org/show_bug.cgi?id=38404
7
8         * DumpRenderTree/win/DumpRenderTree.cpp:
9         (main):
10
11 2010-04-30  Anders Carlsson  <andersca@apple.com>
12
13         Try to fix GTK+ build.
14
15         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
16         (webkit_test_plugin_new_stream):
17
18 2010-04-30  Anders Carlsson  <andersca@apple.com>
19
20         Fix build.
21
22         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
23
24 2010-04-30  Anders Carlsson  <andersca@apple.com>
25
26         Reviewed by Timothy Hatcher.
27
28         Next step towards fixing
29         
30         https://bugs.webkit.org/show_bug.cgi?id=20784
31         move npapi.h to C99 integer types
32
33         Use the C99 types everywhere. The "old" types are still around but will be removed
34         in a subsequent commit.
35
36         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
37         (int32VariantToIdentifier):
38         (doubleVariantToIdentifier):
39         (testIdentifierToInt):
40         (testGetIntIdentifier):
41         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
42         (NPP_New):
43         (NPP_NewStream):
44         (NPP_WriteReady):
45         (NPP_Write):
46         (NPP_HandleEvent):
47         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
48         (NPP_New):
49         (NPP_NewStream):
50         (NPP_WriteReady):
51         (NPP_Write):
52         (NPP_HandleEvent):
53
54 2010-04-30  Steve Block  <steveblock@google.com>
55
56         Reviewed by Jeremy Orlow.
57
58         Changed Steve Block from committer to reviewer.
59
60         * Scripts/webkitpy/common/config/committers.py:
61
62 2010-04-28  Ojan Vafai  <ojan@chromium.org>
63
64         Reviewed by Eric Seidel.
65
66         webkit-patch doesn't work if a git repo is tracking multiple svn repos
67         https://bugs.webkit.org/show_bug.cgi?id=38290
68         
69         Getting the tests to pass required getting our SVN repo to more closely
70         match the real svn.webkit.org repo by having a trunk directory.
71         That involved adding an extra commit at the beginning and thus changing
72         all the commit numbers in the tests.
73
74         * Scripts/webkitpy/common/checkout/scm.py:
75
76 2010-04-29  Eric Seidel  <eric@webkit.org>
77
78         Reviewed by Adam Barth.
79
80         new-run-webkit-tests can deadlock with Chromium's TestShell
81         https://bugs.webkit.org/show_bug.cgi?id=38298
82
83         Fix _write_command_and_read_line to never send unicode() to
84         test_shell, instead to always encode as utf-8.  This was causing
85         random hangs because if test_shell ever encounters a \0 in the
86         stream it can deadlock with NRWT.
87
88         There is still a deadlock bug to fix in NRWT/test_shell design, however
89         this fix should make the deadlock occur less often.
90
91         * Scripts/webkitpy/layout_tests/port/chromium.py:
92         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
93
94 2010-04-29  Chris Jerdonek  <cjerdonek@webkit.org>
95
96         Reviewed by Eric Seidel.
97
98         Refactored svn-apply and svn-unapply to use the new
99         parsePatch() subroutine.
100
101         https://bugs.webkit.org/show_bug.cgi?id=34033
102
103         * Scripts/VCSUtils.pm:
104           - Consolidated %diffHash documentation.
105           - Added prepareParsedPatch().
106
107         * Scripts/svn-apply:
108           - Replaced main while loop with calls to parsePatch() and
109             prepareParsedPatch().
110
111         * Scripts/svn-unapply:
112           - Replaced main while loop with calls to parsePatch() and
113             prepareParsedPatch().
114
115         * Scripts/test-webkitperl:
116           - Changed to render relative test paths rather than absolute
117             test paths.
118
119         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl: Added.
120           - Added unit tests for prepareParsedPatch().
121
122 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
123
124         Reviewed by Eric Seidel.
125
126         Added to VCSUtils's parseDiffHeader() support for binary patches.
127
128         https://bugs.webkit.org/show_bug.cgi?id=38094
129
130         The parseDiffHeader() function is part of new patch-parsing code
131         for svn-apply and svn-unapply that will go live in a subsequent
132         revision.
133
134         * Scripts/VCSUtils.pm:
135           - Added logic to parseDiffHeader() to recognize the ending of
136             the header portion of a binary diff.
137
138         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
139           - Added unit test cases for SVN and Git binary diffs.
140
141 2010-04-28  Eric Seidel  <eric@webkit.org>
142
143         Reviewed by David Levin.
144
145         Document that subprocess.poll/wait are not threadsafe
146         https://bugs.webkit.org/show_bug.cgi?id=38289
147
148         * Scripts/webkitpy/common/system/executive.py:
149         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
150         * Scripts/webkitpy/layout_tests/port/chromium.py:
151         * Scripts/webkitpy/layout_tests/port/http_server.py:
152         * Scripts/webkitpy/layout_tests/port/server_process.py:
153         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
154
155 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
156
157         Reviewed by Daniel Bates.
158
159         Removed the dividing line (i.e. "====...") logic from the code
160         called by svn-apply and svn-unapply.
161
162         https://bugs.webkit.org/show_bug.cgi?id=38093
163
164         The dividing line logic is unnecessary.  Removing it simplifies the
165         code and makes some subsequent changes easier.
166
167         * Scripts/VCSUtils.pm:
168           - Removed the logic in gitdiff2svndiff() to convert the git
169             "index" line to an SVN dividing line.
170           - Adjusted the logic similarly in parseDiffHeader().
171
172         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
173           - Updated the unit tests as necessary.
174
175         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
176           - Updated the unit tests as necessary.
177           - Corrected an error in the unit tests whereby all elements
178             of an array were referencing the same element rather than
179             distinct elements -- causing unit test failures to be masked.
180
181         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
182           - Updated the unit tests as necessary.
183           - Made the same unit test correction as above for parseDiff.pl.
184
185 2010-04-28  Evan Stade  <estade@chromium.org>
186
187         Unreviewed.
188
189         * Scripts/webkitpy/common/config/committers.py: adding myself as a committer
190
191 2010-04-28  Sam Weinig  <sam@webkit.org>
192
193         Reviewed by Mark Rowe.
194
195         Add MiniBrowser to the lists of modules to build and only build it on
196         SnowLeopard and later.
197
198         * Makefile:
199         * MiniBrowser/Makefile:
200
201 2010-04-28  Sam Weinig  <sam@webkit.org>
202
203         Reviewed by Mark Rowe.
204
205         Make running MiniBrowser.app without explicitly setting DYLD_FRAMEWORK_PATH.
206
207         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
208         * MiniBrowser/mac/make-launchable.sh: Added.
209
210 2010-04-28  Eric Seidel  <eric@webkit.org>
211
212         Reviewed by David Levin.
213
214         Audit all uses of subprocess in webkitpy
215         https://bugs.webkit.org/show_bug.cgi?id=38284
216
217         After further discussions with Jeffrey Yasskin
218         about http://bugs.python.org/issue2320
219         and related issues of using subprocess from
220         multiple threads, I have learned that subprocess
221         is known to be non-threadsafe through recent
222         Python 2.7 builds.
223
224         I'm attempting to lessen our exposure to these
225         subprocess bugs by auditing each use of subprocess
226         in webkitpy.  I did not find any unsafe calls
227         in my audit, but I did remove numerous unneeded
228         import subprocess lines.
229
230         * Scripts/webkitpy/common/checkout/api.py:
231         * Scripts/webkitpy/common/net/bugzilla.py:
232         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
233         * Scripts/webkitpy/common/system/user.py:
234         * Scripts/webkitpy/layout_tests/port/base.py:
235         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
236         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
237         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Added.
238         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
239         * Scripts/webkitpy/layout_tests/port/gtk.py:
240         * Scripts/webkitpy/layout_tests/port/mac.py:
241         * Scripts/webkitpy/layout_tests/port/qt.py:
242         * Scripts/webkitpy/layout_tests/port/webkit.py:
243         * Scripts/webkitpy/layout_tests/port/win.py:
244
245 2010-04-28  Darin Adler  <darin@apple.com>
246
247         Ignore a directory the Python tools creates.
248
249         * Scripts/webkitpy/style: Modified property svn:ignore.
250
251 2010-04-28  Darin Adler  <darin@apple.com>
252
253         * Scripts/extract-localizable-strings: Fix minor mistake in
254         argument checking.
255
256 2010-04-28  Luiz Agostini  <luiz.agostini@openbossa.org>
257
258         Reviewed by Kenneth Rohde Christiansen.
259
260         [Qt] QWebPage viewMode property
261         https://bugs.webkit.org/show_bug.cgi?id=38119
262
263         Replacing method qt_wrt_setViewMode by wrt_viewMode property.
264
265         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
266         (LayoutTestController::setViewModeMediaFeature):
267
268 2010-04-28  Chris Jerdonek  <cjerdonek@webkit.org>
269
270         Reviewed by Shinichiro Hamaji.
271
272         Adjusted check-webkit-style so that files with file type NONE
273         are automatically skipped without warning.
274
275         https://bugs.webkit.org/show_bug.cgi?id=38197
276
277         This change simplifies configuring which files to skip.  It also
278         addresses an issue whereby check-webkit-style was unintentionally
279         checking .vcproj files for carriage returns.
280
281         * Scripts/webkitpy/style/checker.py:
282           - Moved the C++, Python, and text file extensions to new
283             module-level configuration variables.
284           - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration
285             variable.
286           - Changed the numeric values of the FileType enum so that
287             FileType.NONE evaluates to False.
288           - For ProcessorDispatcher.should_skip_without_warning():
289             - Changed the method to return True for FileType.NONE files.
290             - Made ChangeLog files an exception to getting skipped.
291           - Changed the StyleProcessor.process() method to raise an
292             exception if given a file path that should not be processed.
293
294         * Scripts/webkitpy/style/checker_unittest.py:
295           - Updated the unit tests and added more test cases as necessary.
296
297 2010-04-28  Eric Seidel  <eric@webkit.org>
298
299         Reviewed by Jeremy Orlow.
300
301         webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',)
302         https://bugs.webkit.org/show_bug.cgi?id=38248
303
304         The previous code did not check the return code of taskkill.
305         When I moved that callsite from using subprocess.call to
306         Executive.run_command having a non-zero return code became an error.
307
308         In this change I've centralized our killall handling in executive,
309         and added tests for it to make sure it works.
310
311         Currently kill_process and kill_all swallow exceptions in the cases
312         where the process(es) to be killed do(es) not exist.
313
314         * Scripts/webkitpy/common/system/executive.py:
315         * Scripts/webkitpy/common/system/executive_unittest.py:
316         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
317         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
318         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
319         * Scripts/webkitpy/layout_tests/port/gtk.py:
320         * Scripts/webkitpy/layout_tests/port/mac.py:
321         * Scripts/webkitpy/layout_tests/port/qt.py:
322         * Scripts/webkitpy/layout_tests/port/win.py:
323
324 2010-04-28  Eric Seidel  <eric@webkit.org>
325
326         Reviewed by Shinichiro Hamaji.
327
328         wdiff_text throws ScriptError because wdiff returns non-zero when files differ
329         https://bugs.webkit.org/show_bug.cgi?id=38246
330
331         wdiff returns 0 when files are the same, 1 when they differ.
332         run_command by default raises ScriptError if the return code is non-zero.
333         Fixed this by adding a custom error handler which only raises if the
334         return code is not 1.
335
336         I broke up the huge wdiff_text() method into little pieces
337         for easier unit testing.  There is only one functional change here
338         and that is the addition of the custom error handler.
339
340         * Scripts/webkitpy/layout_tests/port/base.py:
341         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
342
343 2010-04-28  Fumitoshi Ukai  <ukai@chromium.org>
344
345         Unreviewed build fix.
346
347         * DumpRenderTree/chromium/TestShell.cpp:
348         (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'.
349         * DumpRenderTree/chromium/WebViewHost.cpp:
350         (WebViewHost::willSendRequest): too few arguments for format.
351
352 2010-04-27  Shinichiro Hamaji  <hamaji@chromium.org>
353
354         Reviewed by Darin Adler and Eric Seidel.
355
356         Add layoutTestController.setPrinting()
357         https://bugs.webkit.org/show_bug.cgi?id=37203
358
359         * DumpRenderTree/LayoutTestController.cpp:
360         (LayoutTestController::LayoutTestController):
361         (setPrintingCallback):
362         (LayoutTestController::staticFunctions):
363         * DumpRenderTree/LayoutTestController.h:
364         (LayoutTestController::isPrinting):
365         (LayoutTestController::setIsPrinting):
366         * DumpRenderTree/mac/DumpRenderTree.mm:
367         (dump):
368
369 2010-04-27  Michael Nordman  <michaeln@google.com>
370
371         Reviewed by Dmitry Titov.
372
373         [Chromium] Add two things to the webkit API to support appcaches in workers.
374         1) WebURLRequest TargetTypes for worker and shared worker main resources.
375         2) Factory method on class WebCommonWorkerClient to
376            createApplicationCacheHost() for the associated worker.
377
378         https://bugs.webkit.org/show_bug.cgi?id=38147
379
380         * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method 
381         (TestWebWorker::createApplicationCacheHost):
382
383 2010-04-27  Adam Barth  <abarth@webkit.org>
384
385         Reviewed by Eric Seidel.
386
387         run-bindings-tests doesn't work in an SVN checkout
388         https://bugs.webkit.org/show_bug.cgi?id=38225
389
390         Previously detect_scm_system needed an absolute path for SVN.  Now we
391         accept a relative path.
392
393         * Scripts/webkitpy/common/checkout/scm.py:
394         * Scripts/webkitpy/common/checkout/scm_unittest.py:
395
396 2010-04-27  Sam Weinig  <sam@webkit.org>
397
398         Reviewed by Stephanie Lewis.
399
400         Always build WebKit2 when building on SnowLeopard and later. 
401
402         * Scripts/build-webkit:
403
404 2010-04-27  Sam Weinig  <sam@webkit.org>
405
406         Reviewed by Maciej Stachowiak.
407
408         Fix for https://bugs.webkit.org/show_bug.cgi?id=38238
409         Allow both WebKit and WebKit2 to link to the same WebCore.framework
410
411         * Scripts/build-webkit: Remove the UMBRELLA_LDFLAGS override when building
412         WebCore for WebKit2, it is no longer necessary.
413
414 2010-04-27  James Robinson  <jamesr@chromium.org>
415
416         Reviewed by David Levin.
417
418         Fix a typo in chromium.py that causes NRWT to fail in --verbose
419         mode in a Chromium checkout.
420         https://bugs.webkit.org/show_bug.cgi?id=38234
421
422         * Scripts/webkitpy/layout_tests/port/chromium.py:
423
424 2010-04-27  Darin Fisher  <darin@chromium.org>
425
426         Reviewed by Dimitri Glazkov.
427
428         [Chromium] Remove deprecated form of didChangeLocationWithinPage
429         https://bugs.webkit.org/show_bug.cgi?id=38178
430
431         Switch over to implementing didNavigateWithinPage.
432
433         * DumpRenderTree/chromium/WebViewHost.cpp:
434         (TestWebViewDelegate::didNavigateWithinPage):
435         (WebViewHost::didChangeLocationWithinPage):
436         * DumpRenderTree/chromium/WebViewHost.h:
437
438 2010-04-27  Evan Martin  <evan@chromium.org>
439
440         Unreviewed.
441
442         Adding myself to commmitters list.
443
444         * Scripts/webkitpy/common/config/committers.py:
445
446 2010-04-27  Adam Barth  <abarth@webkit.org>
447
448         Reviewed by Darin Adler.
449
450         run-bindings-tests should use --reset-results instead of --overwrite
451         https://bugs.webkit.org/show_bug.cgi?id=38200
452
453         As requested by Ojan.
454
455         * Scripts/run-bindings-tests:
456
457 2010-04-27  Adam Barth  <abarth@webkit.org>
458
459         Reviewed by Eric Seidel.
460
461         REGRESSION(r58261): webkit-patch edit-changelogs is broken
462         https://bugs.webkit.org/show_bug.cgi?id=38204
463
464         In 58261, we added code to abstract step that interrogates the squash
465         and git_commit options, but it doesn't declare that it uses those
466         options.  That means any command that doesn't happen to declare those
467         options might be broken if it uses the cached_lookup mechanism.
468
469         * Scripts/webkitpy/tool/steps/abstractstep.py:
470         * Scripts/webkitpy/tool/steps/applypatch.py:
471         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
472         * Scripts/webkitpy/tool/steps/build.py:
473         * Scripts/webkitpy/tool/steps/checkstyle.py:
474         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
475         * Scripts/webkitpy/tool/steps/closebug.py:
476         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
477         * Scripts/webkitpy/tool/steps/commit.py:
478         * Scripts/webkitpy/tool/steps/confirmdiff.py:
479         * Scripts/webkitpy/tool/steps/createbug.py:
480         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
481         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
482         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
483         * Scripts/webkitpy/tool/steps/postcodereview.py:
484         * Scripts/webkitpy/tool/steps/postdiff.py:
485         * Scripts/webkitpy/tool/steps/preparechangelog.py:
486         * Scripts/webkitpy/tool/steps/runtests.py:
487         * Scripts/webkitpy/tool/steps/update.py:
488         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
489         * Scripts/webkitpy/tool/steps/validatereviewer.py:
490
491 2010-04-27  Eric Seidel  <eric@webkit.org>
492
493         Reviewed by David Levin.
494
495         prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
496         https://bugs.webkit.org/show_bug.cgi?id=38212
497
498         * Scripts/prepare-ChangeLog:
499          - Pass --insecure to curl to work around CYGWIN missing certs.
500
501 2010-04-27  Sam Weinig  <sam@webkit.org>
502
503         Rubber-stamped by Beth Dakin.
504
505         It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
506         or WTF_USE_WEB_THREAD. Remove them.
507
508         * Scripts/build-webkit:
509
510 2010-04-27  Chris Jerdonek  <cjerdonek@webkit.org>
511
512         Reviewed by David Levin.
513
514         Changed Chris Jerdonek from committer to reviewer.
515
516         * Scripts/webkitpy/common/config/committers.py:
517
518 2010-04-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
519
520         Reviewed by Kenneth Rohde Christiansen.
521
522         [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
523         https://bugs.webkit.org/show_bug.cgi?id=35834
524
525         The scene should always have the size of the web view otherwhise it is
526         possible to scroll the graphics view.
527
528         * QtLauncher/webview.cpp:
529         (WebViewGraphicsBased::resizeEvent):
530
531 2010-04-27  Diego Gonzalez  <diegohcg@webkit.org>
532
533         Unreviewed.
534
535         Adding myself to committers.py
536
537         * Scripts/webkitpy/common/config/committers.py:
538
539 2010-04-27  Eric Seidel  <eric@webkit.org>
540
541         Reviewed by Adam Barth.
542
543         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
544         https://bugs.webkit.org/show_bug.cgi?id=37987
545
546         After further research, I believe the hang is caused by:
547         http://bugs.python.org/issue2320
548         Basically Popen() is not reentrant.
549         The workaround is to pass close_fds=True to Popen() on Mac/Linux.
550
551         I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
552         when appropriate.
553
554         I audited all places we call Popen() and either moved them to run_command
555         or left a FIXME that they are not thread safe.  A few places I added the
556         close_fds workaround there and left an explanitory note.
557
558         * Scripts/webkitpy/common/checkout/scm_unittest.py:
559          - Added note that this Popen use is not threadsafe.
560         * Scripts/webkitpy/common/system/executive.py:
561          - Fixed our Executive.run_* to workaround python bug 2320.
562         * Scripts/webkitpy/common/system/user.py:
563          _ Added note that this Popen use is not threadsafe.
564         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
565         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
566         * Scripts/webkitpy/layout_tests/port/base.py:
567          - Change wdiff back to using run_command now that we believe it
568            to be threadsafe.
569         * Scripts/webkitpy/layout_tests/port/chromium.py:
570          - Fix to use Executive in places.
571          - Pass self._executive down to the Driver for easier unit testing.
572         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
573          - Re-factor to use a _kill_all method.
574          - Made the _kill_all method use run_command to be threadsafe.
575         * Scripts/webkitpy/layout_tests/port/http_server.py:
576          - Add FIXME about using Executive.
577         * Scripts/webkitpy/layout_tests/port/server_process.py:
578          - Use Executive to be threadsafe.
579         * Scripts/webkitpy/layout_tests/port/webkit.py:
580          - Pass self._executive down to the Driver.
581         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
582          - Add note about Popen not being threadsafe.
583         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
584          - Move one caller to run_command add notes about moving others.
585
586 2010-04-27  Adam Barth  <abarth@webkit.org>
587
588         Reviewed by Maciej Stachowiak.
589
590         REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout.
591         https://bugs.webkit.org/show_bug.cgi?id=38186
592
593         Unfortunately, we don't have a good way of testing this change because
594         our test coverage of the scm.py API is poor...
595
596         * Scripts/webkitpy/common/checkout/scm.py:
597         * Scripts/webkitpy/tool/steps/preparechangelog.py:
598
599 2010-04-26  Eric Seidel  <eric@webkit.org>
600
601         Reviewed by Adam Barth.
602
603         Remove unused code from text_diff.py
604         https://bugs.webkit.org/show_bug.cgi?id=38170
605
606         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
607          - Remove is_render_tree_dump which appears unused.
608
609 2010-04-26  Adam Barth  <abarth@webkit.org>
610
611         Reviewed by Eric Seidel.
612
613         webkit-patch pretty-diff is broken
614         https://bugs.webkit.org/show_bug.cgi?id=38172
615
616         We need to register for these options because they're used when we look
617         up the diff.
618
619         * Scripts/webkitpy/tool/steps/confirmdiff.py:
620
621 2010-04-26  Adam Barth  <abarth@webkit.org>
622
623         Reviewed by Eric Seidel.
624
625         Add ObjC and GObject to run-bindings-test
626         https://bugs.webkit.org/show_bug.cgi?id=38168
627
628         * Scripts/run-bindings-tests:
629
630 2010-04-26  Adam Barth  <abarth@webkit.org>
631
632         Reviewed by Eric Seidel.
633
634         Add testing infrastructure for JSC bindings generator
635         https://bugs.webkit.org/show_bug.cgi?id=38167
636
637         Add support for testing more than one bindings.  Also, converted the
638         script to PEP8 style.
639
640         * Scripts/run-bindings-tests:
641
642 2010-04-26  Eric Seidel  <eric@webkit.org>
643
644         Reviewed by Adam Barth.
645
646         Refactor results.html generation out into a new method and test it
647         https://bugs.webkit.org/show_bug.cgi?id=38164
648
649         Hopefully this results in no change in functionality.
650
651         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
652         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
653
654 2010-04-26  Adam Barth  <abarth@webkit.org>
655
656         Unreviewed, rolling out r58265.
657         http://trac.webkit.org/changeset/58265
658         https://bugs.webkit.org/show_bug.cgi?id=38021
659
660         This change prevents me from uploading patches.  It also breaks sheriff-bot.
661
662         * Scripts/webkitpy/tool/steps/options.py:
663
664 2010-04-26  Eric Seidel  <eric@webkit.org>
665
666         Reviewed by Adam Barth.
667
668         [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
669         https://bugs.webkit.org/show_bug.cgi?id=37987
670
671         Rolled out:
672         http://trac.webkit.org/changeset/58062
673         http://trac.webkit.org/changeset/58060
674         http://trac.webkit.org/changeset/58059
675         http://trac.webkit.org/changeset/58055
676         http://trac.webkit.org/changeset/58054
677         and parts of:
678         http://trac.webkit.org/changeset/58050
679
680         I also wrote some new comments and a tiny amount of new
681         code to help make ChromiumDriver.run_test easier to read.
682
683         In order to unit-test my new code, I had to change ChromiumDriver
684         to not automatically start itself when created.  That ended up
685         being a lot of plumbing, but is hopefully easier to understand now.
686
687         There are no tests for the (restored) wdiff code.  wdiff does not
688         exist on all systems, so for now we will assume it worked since
689         it is just old code being reverted.
690
691          * Scripts/webkitpy/layout_tests/driver_test.py:
692           - Use create_driver instead of start_driver, and be sure to call .stop()
693          * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
694           - Use create_driver instead of start_driver
695          * Scripts/webkitpy/layout_tests/port/base.py:
696           - Added a comment to explain that diffs are binary files.
697           - Various patch reverts relating to wdiff
698           - Add Driver._command_wrapper to share code between WebKitDriver and ChromiumDriver.
699           - Made _command_wrapper use shlex.split to get rid of the FIXME.
700          * Scripts/webkitpy/layout_tests/port/base_unittest.py: Added.
701           - test the new _command_wrapper
702          * Scripts/webkitpy/layout_tests/port/chromium.py:
703          - Use _command_wrapper to get rid of a bunch of ugly code.
704          - Make __init__ stop auto-starting.
705          - Rename create_driver to start_driver.
706          - Added _write_command_and_read_line to make it possible to
707            put a FIXME next to read_line() w/o having to put it in two places.
708          - Moved test_shell command building into _test_shell_command and tested it.
709          - Fix comments to say test_shell since ChromiumDriver is test_shell only.
710          * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Added.
711           - Test the new test_shell_command method.
712          * Scripts/webkitpy/layout_tests/port/dryrun.py:
713           - Rename create_driver to start_driver.
714          * Scripts/webkitpy/layout_tests/port/test.py:
715           - Rename create_driver to start_driver.
716          * Scripts/webkitpy/layout_tests/port/webkit.py:
717           - Rename create_driver to start_driver.
718           - Treat output as binary arrays.
719          * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
720           - Treat diff files as binary.
721          * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
722           - Treat diff files as binary.
723
724 2010-04-26  Adam Barth  <abarth@webkit.org>
725
726         Reviewed by Eric Seidel.
727
728         Move bindings test directory into the scripts directory
729         https://bugs.webkit.org/show_bug.cgi?id=38161
730
731         Change script to point to the new location of these data files.
732
733         * Scripts/run-bindings-tests:
734
735 2010-04-26  Adam Barth  <abarth@webkit.org>
736
737         Unreviewed.  Mark run-bindings-tests executable so we can execute it.
738
739         * Scripts/run-bindings-tests:
740
741 2010-04-26  Tony Chang  <tony@chromium.org>
742
743         Reviewed by David Levin.
744
745         [chromium] build-webkit --chromium should build release by default
746         https://bugs.webkit.org/show_bug.cgi?id=38028
747
748         * Scripts/build-dumprendertree: Also should build release by default
749         * Scripts/build-webkit: Make sure to pass command line args through
750         * Scripts/webkitdirs.pm: Build the right configuration
751
752 2010-04-26  Ojan Vafai  <ojan@chromium.org>
753
754         Reviewed by Eric Seidel.
755
756         complete rietveld bugzilla integration
757         https://bugs.webkit.org/show_bug.cgi?id=38021
758
759         Makes --fancy-review the default. All this means is that the patch will
760         be uploaded to rietveld in addition to bugs.webkit.org. 
761
762         * Scripts/webkitpy/tool/steps/options.py:
763
764 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
765
766         Reviewed by Shinichiro Hamaji.
767
768         For check-webkit-style, renamed the style/processors/ directory
769         to style/checkers/.
770
771         https://bugs.webkit.org/show_bug.cgi?id=38122
772
773         * Scripts/webkitpy/style/checker.py:
774           - Updated import statements.
775
776         * Scripts/webkitpy/style/checker_unittest.py:
777           - Updated import statements.
778
779         * Scripts/webkitpy/style/checkers: Copied from WebKitTools/Scripts/webkitpy/style/processors.
780         * Scripts/webkitpy/style/processors: Removed.
781         * Scripts/webkitpy/style/processors/__init__.py: Removed.
782         * Scripts/webkitpy/style/processors/common.py: Removed.
783         * Scripts/webkitpy/style/processors/common_unittest.py: Removed.
784         * Scripts/webkitpy/style/processors/cpp.py: Removed.
785         * Scripts/webkitpy/style/processors/cpp_unittest.py: Removed.
786         * Scripts/webkitpy/style/processors/python.py: Removed.
787         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
788         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
789         * Scripts/webkitpy/style/processors/text.py: Removed.
790         * Scripts/webkitpy/style/processors/text_unittest.py: Removed.
791
792 2010-04-06  Ojan Vafai  <ojan@chromium.org>
793
794         Reviewed by Adam Barth.
795
796         Include git commits in the diff for webkit-patch upload/land.
797         https://bugs.webkit.org/show_bug.cgi?id=36394
798
799         Adds --squash, --no-squash and --git-commit.
800
801         --git-commit will use a specific local commit for land/upload.
802         If a commit-range is specified, then that range is treated as
803         a single squashed commit.
804
805         --squash will squash all local changes including working copy changes
806         into a single patch.
807
808         --no-squash is the legacy behavior (upload only considers the working copy,
809         land commits the working copy and then each local commit separately to SVN)
810
811         If neither is specified, then an informative error is raised if there is
812         more than one local commit or when there are local commit(s) and working
813         copy changes.
814
815         If the webkit-patch.squash git config parameter is set, then
816         that will be respected instead of raising an error.
817
818         * Scripts/check-webkit-style:
819         * Scripts/webkitpy/common/checkout/api.py:
820         * Scripts/webkitpy/common/checkout/api_unittest.py:
821         * Scripts/webkitpy/common/checkout/scm.py:
822         * Scripts/webkitpy/common/checkout/scm_unittest.py:
823         * Scripts/webkitpy/style/optparser.py:
824         --git-since is removed and --git-commit no longer implies commit_id..
825         Instead, it treats that individual commit, but also supports commit ranges
826         (e.g. commit_id..) as arguments.
827         * Scripts/webkitpy/style/optparser_unittest.py:
828         * Scripts/webkitpy/style_references.py:
829         * Scripts/webkitpy/tool/commands/download.py:
830         * Scripts/webkitpy/tool/commands/upload.py:
831         * Scripts/webkitpy/tool/main.py:
832         * Scripts/webkitpy/tool/mocktool.py:
833         * Scripts/webkitpy/tool/steps/abstractstep.py:
834         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
835         * Scripts/webkitpy/tool/steps/checkstyle.py:
836         * Scripts/webkitpy/tool/steps/commit.py:
837         * Scripts/webkitpy/tool/steps/options.py:
838         * Scripts/webkitpy/tool/steps/postdiff.py:
839         * Scripts/webkitpy/tool/steps/preparechangelog.py:
840         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
841         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
842         * Scripts/webkitpy/tool/steps/validatereviewer.py:
843
844 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
845
846         Reviewed by Shinichiro Hamaji.
847
848         Deleted the StyleChecker-related classes that are no longer
849         being used.
850
851         https://bugs.webkit.org/show_bug.cgi?id=38118
852
853         * Scripts/webkitpy/style/checker.py:
854           - Deleted the DeprecatedStyleChecker class.
855
856         * Scripts/webkitpy/style/checker_unittest.py:
857           - Deleted the StyleCheckerTest, StyleCheckerCheckFileBase,
858             StyleCheckerCheckFileTest, and StyleCheckerCheckPathsTest classes.
859
860 2010-04-26  Chris Jerdonek  <cjerdonek@webkit.org>
861
862         Reviewed by Shinichiro Hamaji.
863
864         Changed the StyleChecker class to use the new TextFileReader class.
865
866         https://bugs.webkit.org/show_bug.cgi?id=37066
867
868         This revision separates the code responsible for reading and iterating
869         over text files from the rest of check-webkit-style.
870
871         * Scripts/check-webkit-style:
872           - Changed the script to use the new StyleProcessor and
873             TextFileReader classes instead of the StyleChecker class.
874
875         * Scripts/webkitpy/style/checker.py:
876           - Added a FIXME to rename many of uses of the word "processor" to
877             "checker".  We did this to clarify the difference between
878             ProcessorBase instances passed to the TextFileReader and
879             classes that process and check lines for style.
880           - Added a FIXME to remove FileType.NONE as a possible return value
881             of ProcessorDispatcher._file_type().  This will better consolidate
882             the logic of which files should be skipped.
883           - Added a FIXME to delete the StyleChecker class.
884           - Added the StyleProcessor class which implements ProcessorBase.
885             This class is responsible for processing lines to check style
886             (but not for reading files).  For each file, this class creates
887             creates both a carriage-return checker and a format-specific
888             style checker (e.g. one of C++, Python, etc).
889           - Updated the PatchChecker class to use a TextFileReader instance
890             instead of a StyleChecker.
891
892         * Scripts/webkitpy/style/checker_unittest.py:
893           - Added the StyleProcessor_EndToEndTest class to do "end-to-end"
894             tests of the StyleProcessor class.
895           - Added the StyleProcessor_CodeCoverageTest to test the
896             StyleProcessor class with more complete code coverage.
897             Unlike the StyleProcessor_EndToEndTest class, this class makes
898             heavy use of mock parameters.
899           - Added FIXME's to delete the unit test classes that are no
900             longer needed.
901           - Updated the PatchCheckerTest class to use a MockTextFileReader
902             instead of a MockStyleChecker.
903
904         * Scripts/webkitpy/style/filereader.py:
905           - Updated the TextFileReader class to use the preferred logic
906             of checking file existence at the beginning of the process_file()
907             method instead of in the except block, per
908             https://bugs.webkit.org/show_bug.cgi?id=37122
909
910         * Scripts/webkitpy/style/filereader_unittest.py:
911           - In the TextFileReaderTest class:
912             - Moved the test_process_file__should_not_process() method.
913             - Added a test_process_file__file_stdin() method to test
914               the file path "-".
915
916 2010-04-20  Robert Hogan  <robert@webkit.org>
917
918         Reviewed by Simon Hausmann.
919
920         [Qt] Add more support for textInputController
921
922         Add support for selectedRange(), setMarkedText(), insertText(),
923         and firstRectForCharacterRange().
924
925         Unskip tests:
926
927         fast/forms/input-maxlength-ime-preedit.html
928         fast/forms/input-maxlength-ime-completed.html
929         fast/text/international/thai-cursor-position.html
930         fast/events/ime-composition-events-001.html
931         editing/selection/5825350-1.html
932         editing/selection/5825350-2.html
933         editing/selection/mixed-editability-10.html
934
935         https://bugs.webkit.org/show_bug.cgi?id=35702
936
937         * DumpRenderTree/qt/TextInputControllerQt.cpp:
938         (TextInputController::setMarkedText):
939         (TextInputController::insertText):
940         (TextInputController::selectedRange):
941         (TextInputController::firstRectForCharacterRange):
942         * DumpRenderTree/qt/TextInputControllerQt.h:
943
944 2010-04-23  Eric Seidel  <eric@webkit.org>
945
946         Reviewed by Adam Barth.
947
948         check-webkit-style complains about non-utf8 data in layout test result
949         https://bugs.webkit.org/show_bug.cgi?id=38027
950
951         The problem was we were assuming patch files/diff output as utf-8.
952         Turns out they're not.  We have to treat them as binary data because
953         a single patch may have multiple text files in it with conflicting encodings!
954
955         * Scripts/webkitpy/common/checkout/api.py:
956          - contents_at_revision returns a byte array, so decode it to unicode
957            before passing it to parse_latest_entry_from_file
958         * Scripts/webkitpy/common/checkout/api_unittest.py:
959          - Update our mock mock_contents_at_revision to match the encoding
960            semantics of the real one.
961         * Scripts/webkitpy/common/checkout/scm.py:
962          - Be careful not to decode output which may contain file contents
963            (like diff, cat or show) as the encoding for that content is unknown.
964         * Scripts/webkitpy/common/checkout/scm_unittest.py:
965          - Update our tests to use both latin1 and utf-8 encoded data.
966         * Scripts/webkitpy/common/net/bugzilla.py:
967          - _fill_attachment_form should not assume unicode data.  Callers
968            may wish to attach other types of files to bugs.
969         * Scripts/webkitpy/common/prettypatch.py:
970          - Diffs are byte arrays, deal with them as such.
971         * Scripts/webkitpy/common/prettypatch_unittest.py:
972          - Test to make sure we handle diffs with multiple conflicting encodings.
973         * Scripts/webkitpy/common/system/executive_unittest.py:
974          - Make sure that our unicode support does not break our
975            byte array input support for run_command.
976
977 2010-04-23  Sam Weinig  <sam@webkit.org>
978
979         Reviewed by David Levin.
980
981         Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
982         Split up Threading.h
983
984         Add necessary forwarding headers.
985
986         * DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
987         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
988         * DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
989
990 2010-04-23  Xiaomei Ji  <xji@chromium.org>
991
992         No need to review.
993
994         Add xji as committer.
995
996         * Scripts/webkitpy/common/config/committers.py:
997
998 2010-04-23  Kevin Ollivier  <kevino@theolliviers.com>
999
1000         [wx] Build fix, add platform stub for new LayoutTestController method.
1001
1002         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1003         (LayoutTestController::markerTextForListItem):
1004
1005 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
1006
1007         Reviewed by Adam Barth.
1008
1009         new-run-webkit-tests: add a "--retry-failures" flag and a
1010         "--no-retry-failures" flag (the former is the default). Also, rename
1011         "--print-unexpected-results" and "--retry-unexpected-results" to
1012         "--print-last-failures" and "--retry-last-failures" because the
1013         retry flag was confusing. The new flag names aren't great, but
1014         hopefully they're less confusing.
1015
1016         https://bugs.webkit.org/show_bug.cgi?id=37838
1017
1018         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1019
1020 2010-04-22  Sam Weinig  <sam@webkit.org>
1021
1022         Reviewed by Anders Carlsson.
1023
1024         Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
1025         Move isMainThread predicate function to MainThread.h
1026
1027         Added forwarding header for MainThread.h
1028
1029         * DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.
1030
1031 2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1032
1033         Reviewed by Kenneth Rohde Christiansen.
1034
1035         [Qt] Disable Netscape plugin support for minimal configuration
1036         https://bugs.webkit.org/show_bug.cgi?id=38026
1037
1038         Pass the minimal configuration option to Qt build system 
1039         as part of the CONFIG variable.
1040
1041         * Scripts/build-webkit:
1042
1043 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1044
1045         Unreviewed fix.
1046
1047         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1048
1049 2010-04-22  James Robinson  <jamesr@chromium.org>
1050
1051         Reviewed by Adam Barth.
1052
1053         Revert 58077 and follow-ups.  It's broken.
1054         https://bugs.webkit.org/show_bug.cgi?id=37664
1055
1056         * Scripts/new-run-webkit-httpd:
1057         * Scripts/new-run-webkit-websocketserver:
1058         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1059         * Scripts/webkitpy/layout_tests/port/http_server.py:
1060         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1061
1062 2010-04-22  Yaar Schnitman  <yaar@chromium.org>
1063
1064         Reviewed by Adam Barth.
1065
1066         Integrate v8 testing utility with webkit tests
1067         https://bugs.webkit.org/show_bug.cgi?id=37731
1068
1069         * Scripts/run-bindings-tests: Added.
1070
1071 2010-04-22  Eric Seidel  <eric@webkit.org>
1072
1073         Reviewed by Dimitri Glazkov.
1074
1075         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1076         https://bugs.webkit.org/show_bug.cgi?id=37794
1077
1078         * Scripts/webkitpy/layout_tests/port/webkit.py:
1079          - Remove the assert() since our ServerProcess code does not always
1080            seem to be reading the full stderr output (or we're not waiting for it to).
1081
1082 2010-04-22  Eric Seidel  <eric@webkit.org>
1083
1084         Reviewed by Adam Barth.
1085
1086         Add code to help debug new-run-webkit-test hangs on the Chromium bots
1087         https://bugs.webkit.org/show_bug.cgi?id=38011
1088
1089         I can see no reasonable way to test this change.
1090         Stubbing out sys._current_frames() and traceback.extract_stack
1091         seems folly.  Dumping real data would have line number
1092         (and possibly other call stack) variance between runs.
1093
1094         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1095          - Add _dump_thread_states and _dump_thread_states_if_necessary
1096            to have our main thread dump the states of all threads every
1097            60 seconds when running in verbose mode.
1098          - Better document what is going on in our main loop.
1099
1100 2010-04-22  Sam Weinig  <sam@webkit.org>
1101
1102         Reviewed by Anders Carlsson.
1103
1104         Fix for https://bugs.webkit.org/show_bug.cgi?id=38002
1105         Add rudimentary statistics gathering for WebKit2
1106
1107         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1108         * MiniBrowser/mac/AppDelegate.h:
1109         * MiniBrowser/mac/AppDelegate.m:
1110         (-[BrowserAppDelegate init]):
1111         (-[BrowserAppDelegate newWindow:]):
1112         (-[BrowserAppDelegate getCurrentPageNamespace]):
1113         (-[BrowserAppDelegate _setProcessModel:]):
1114         (-[BrowserAppDelegate showStatisticsWindow:]):
1115         (-[BrowserAppDelegate applicationWillTerminate:]):
1116         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Added.
1117         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Added.
1118         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Added.
1119         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1120         (-[BrowserStatisticsWindowController dealloc]):
1121         (-[BrowserStatisticsWindowController windowDidLoad]):
1122         (-[BrowserStatisticsWindowController refreshStatistics:]):
1123         * MiniBrowser/mac/BrowserWindowController.h:
1124         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1125         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1126
1127 2010-04-22  Dave Moore  <davemoore@chromium.org>
1128
1129         Reviewed by Dimitri Glazkov.
1130
1131         Add test support for icon changes.
1132
1133         https://bugs.webkit.org/show_bug.cgi?id=33812
1134
1135         * DumpRenderTree/LayoutTestController.cpp:
1136         (LayoutTestController::LayoutTestController):
1137         (dumpIconChangesCallback):
1138         (LayoutTestController::staticFunctions):
1139         * DumpRenderTree/LayoutTestController.h:
1140         (LayoutTestController::dumpIconChanges):
1141         (LayoutTestController::setDumpIconChanges):
1142         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1143         (FrameLoadDelegate::didChangeIcons):
1144         * DumpRenderTree/win/FrameLoadDelegate.h:
1145         * WinLauncher/WinLauncher.h:
1146         (WinLauncherWebHost::didChangeIcons):
1147
1148 2010-04-22  Eric Seidel  <eric@webkit.org>
1149
1150         Unreviewed.  Script fix.  Will ask dpranke to look tomorrow.
1151
1152         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1153         https://bugs.webkit.org/show_bug.cgi?id=37794
1154
1155         The bots are seeing cases where .error is sometimes empty.
1156         Lets make the code not crash in that case for now.
1157
1158         * Scripts/webkitpy/layout_tests/port/webkit.py:
1159
1160 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1161
1162         Unreviewed fix.
1163
1164         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.
1165
1166 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1167
1168         Unreviewed fix.
1169
1170         * Scripts/new-run-webkit-websocketserver: PyWebSocket no longer takes keyword argument 'register_cygwin'.
1171
1172 2010-04-22  Eric Seidel  <eric@webkit.org>
1173
1174         Unreviewed.  Restore the Leopard bots to using
1175         old-run-webkit-tests for now.
1176
1177         * Scripts/run-webkit-tests:
1178
1179 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1180
1181         Unreviewed fix.
1182
1183         * Scripts/webkitpy/layout_tests/port/http_server.py: fix NameError: global name 'env' is not defined.
1184
1185 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1186
1187         Unreviewed fix.
1188
1189         * Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'env' is not defined.
1190
1191 2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>
1192
1193         Reviewed by Adam Barth.
1194
1195         Chromium: Add --chromium option to new-run-webkit-websocketserver
1196         https://bugs.webkit.org/show_bug.cgi?id=37664
1197
1198         Move cygwin setup logic in chromium_win.py.
1199
1200         * Scripts/new-run-webkit-httpd: remove register_cygwin parameter to pass http_server.
1201         * Scripts/new-run-webkit-websocketserver: add --chromium flag
1202         * Scripts/webkitpy/layout_tests/port/chromium_win.py: setup for cygwin
1203         * Scripts/webkitpy/layout_tests/port/http_server.py: remove cygwin setup logic
1204         * Scripts/webkitpy/layout_tests/port/websocket_server.py: remove cygwin setup logic
1205
1206 2010-04-22  Eric Seidel  <eric@webkit.org>
1207
1208         Reviewed by Adam Barth.
1209
1210         new-run-webkit-tests --verbose shows ever-increasing #EOF lines
1211         https://bugs.webkit.org/show_bug.cgi?id=37794
1212
1213         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1214          - Fix the log message to explain that this is stderr output, not test output.
1215         * Scripts/webkitpy/layout_tests/port/webkit.py:
1216          - Be sure to reset the server_process.error after reading (seems like the wrong
1217            place to do this, but at least this fixes the bug and dpranke and I can talk
1218            about better designs later).
1219          - Also remove the #EOF from the stderr output before returning it.
1220
1221 2010-04-22  Eric Seidel  <eric@webkit.org>
1222
1223         Unreviewed.  Fixing new-run-webkit-tests on the bots.
1224
1225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1226          - Fixing _compat_shim_option to take variable keyword args.
1227          - Turns out that nargs + callback is ignored unless type is specified.
1228            So I added the type so that the option was properly consumed.
1229            This was why new-run-webkit-tests couldn't find any tests, it
1230            was looking for them under "20" because that was the argument
1231            which should have been consumed by --exit-after-n-failures.
1232
1233 2010-04-22  Tony Chang  <tony@chromium.org>
1234
1235         Not reviewed, build fix for chromium Windows.
1236
1237         [chromium] fix ImageDiff compile on windows
1238         https://bugs.webkit.org/show_bug.cgi?id=37979
1239
1240         * DumpRenderTree/chromium/ImageDiff.cpp:
1241
1242 2010-04-22  Adam Barth  <abarth@webkit.org>
1243
1244         Unreviewed, rolling out r58069.
1245         http://trac.webkit.org/changeset/58069
1246         https://bugs.webkit.org/show_bug.cgi?id=27751
1247
1248         Broke compile on Windows.
1249
1250         * DumpRenderTree/LayoutTestController.cpp:
1251         (LayoutTestController::staticFunctions):
1252         * DumpRenderTree/LayoutTestController.h:
1253         * DumpRenderTree/chromium/LayoutTestController.cpp:
1254         (LayoutTestController::LayoutTestController):
1255         (LayoutTestController::overridePreference):
1256         * DumpRenderTree/chromium/LayoutTestController.h:
1257         * DumpRenderTree/chromium/TestShell.cpp:
1258         (TestShell::resetWebSettings):
1259         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1260         * DumpRenderTree/mac/DumpRenderTree.mm:
1261         (resetDefaultsToConsistentValues):
1262         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1264         (WebCore::WebPage::WebPage):
1265         (WebCore::WebPage::resetSettings):
1266         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1267         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1268         * DumpRenderTree/win/DumpRenderTree.cpp:
1269         (resetDefaultsToConsistentValues):
1270         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1271         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1272
1273 2010-04-22  Eric Seidel  <eric@webkit.org>
1274
1275         Unreviewed.  Just adding logging.
1276
1277         Adding logging to help debug why the Leopard Bot
1278         can't find any tests to run.
1279
1280         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1281         * Scripts/webkitpy/layout_tests/port/base.py:
1282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1283          - Make it a fatal error to have no tests to run.
1284
1285 2010-04-22  Abhishek Arya  <inferno@chromium.org>
1286
1287         Reviewed by Adam Barth.
1288
1289         Add support for controlling clipboard access from javascript.
1290         Clipboard access from javascript is enabled in test framework.
1291         https://bugs.webkit.org/show_bug.cgi?id=27751
1292
1293         * DumpRenderTree/LayoutTestController.cpp:
1294         (setJavaScriptCanAccessClipboardCallback):
1295         (LayoutTestController::staticFunctions):
1296         * DumpRenderTree/LayoutTestController.h:
1297         * DumpRenderTree/chromium/LayoutTestController.cpp:
1298         (LayoutTestController::LayoutTestController):
1299         (LayoutTestController::setJavaScriptCanAccessClipboard):
1300         (LayoutTestController::overridePreference):
1301         * DumpRenderTree/chromium/LayoutTestController.h:
1302         * DumpRenderTree/chromium/TestShell.cpp:
1303         (TestShell::resetWebSettings):
1304         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1305         (LayoutTestController::setJavaScriptCanAccessClipboard):
1306         * DumpRenderTree/mac/DumpRenderTree.mm:
1307         (resetDefaultsToConsistentValues):
1308         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1309         (LayoutTestController::setJavaScriptCanAccessClipboard):
1310         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1311         (WebCore::WebPage::WebPage):
1312         (WebCore::WebPage::resetSettings):
1313         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1314         (LayoutTestController::setJavaScriptCanAccessClipboard):
1315         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1316         * DumpRenderTree/win/DumpRenderTree.cpp:
1317         (resetDefaultsToConsistentValues):
1318         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1319         (LayoutTestController::setJavaScriptCanAccessClipboard):
1320         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1321         (LayoutTestController::setJavaScriptCanAccessClipboard):
1322
1323 2010-04-21  Adam Barth  <abarth@webkit.org>
1324
1325         Reviewed by Eric Seidel.
1326
1327         webkit-patch can't fetch attachments on security bugs
1328         https://bugs.webkit.org/show_bug.cgi?id=37975
1329
1330         Instead of calling CURL, we just need to use our Mechanize object,
1331         which understand bugs.webkit.org authentication.
1332
1333         * Scripts/webkitpy/common/checkout/api.py:
1334         * Scripts/webkitpy/common/net/bugzilla.py:
1335
1336 2010-04-21  Eric Seidel  <eric@webkit.org>
1337
1338         Unreviewed.  Temporary commit, will roll-out before morning.
1339
1340         Turning on new-run-webkit-tests for the Leopard build bot
1341         for testing of the harness.
1342         Users should not noctice (except for the results.html difference).
1343
1344         * Scripts/run-webkit-tests:
1345
1346 2010-04-21  Eric Seidel  <eric@webkit.org>
1347
1348         Unreviewed.  Fix typo in my previous fix attempt.
1349
1350         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1351         https://bugs.webkit.org/show_bug.cgi?id=37765
1352
1353         More on-the-bot debugging, sigh.  I wish I had a local build.
1354
1355         * Scripts/webkitpy/layout_tests/port/base.py:
1356
1357 2010-04-21  Eric Seidel  <eric@webkit.org>
1358
1359         Unreviewed.  Fix typo in my previous fix attempt.
1360
1361         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1362         https://bugs.webkit.org/show_bug.cgi?id=37765
1363
1364         * Scripts/webkitpy/layout_tests/port/base.py:
1365          - Add self. to class variable access.
1366
1367 2010-04-21  Eric Seidel  <eric@webkit.org>
1368
1369         Unreviewed.  Another attempt to fix NRWT for chromium.
1370
1371         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1372         https://bugs.webkit.org/show_bug.cgi?id=37765
1373
1374         * Scripts/webkitpy/layout_tests/port/base.py:
1375          - wdiff_text was returning a byte array instead of a
1376            unicode string.  The simple fix was to just decode
1377            the result.  However, seeing so much duplicated code
1378            with Executive made me cry, so I re-wrote the function
1379            to be more like pretty_patch_text and use run_command
1380            (which already knows how to handle unicode).
1381
1382 2010-04-21  Adam Barth  <abarth@webkit.org>
1383
1384         Reviewed by Eric Seidel.
1385
1386         Windows tests buildbots are too slow to be core builders
1387         https://bugs.webkit.org/show_bug.cgi?id=37970
1388
1389         It's 10:45.  The Windows test bots are still hours behind.  They're too
1390         slow to be core builders.  When they get fast, we can add them back.
1391
1392         * Scripts/webkitpy/common/net/buildbot.py:
1393         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1394
1395 2010-04-21  Eric Seidel  <eric@webkit.org>
1396
1397         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1398
1399         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1400         https://bugs.webkit.org/show_bug.cgi?id=37765
1401
1402         I'm debugging in the blind because I don't have a chromium
1403         build on this laptop.
1404
1405         * Scripts/webkitpy/layout_tests/port/chromium.py:
1406          - Apply the previous fix to a second caller.
1407
1408 2010-04-21  Eric Seidel  <eric@webkit.org>
1409
1410         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1411
1412         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1413         https://bugs.webkit.org/show_bug.cgi?id=37765
1414
1415         * Scripts/webkitpy/layout_tests/port/chromium.py:
1416          - Fix handling of test_shell output so that we always
1417            decode it as utf-8.
1418            Unlike DumpRenderTree test_shell does not ever return
1419            pixel data.  It spits out the pixel dumps in a separate
1420            file, thus all output over stdout is utf-8 text.
1421
1422 2010-04-21  Eric Seidel  <eric@webkit.org>
1423
1424         Unreviewed.  Attempt one more time to fix NRWT for chromium.
1425
1426         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1427         https://bugs.webkit.org/show_bug.cgi?id=37765
1428
1429         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1430          - Pass encoding to _save_baseline_data and write_output_files
1431         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1432          - Make _save_baseline_data and write_output_files take an encoding.
1433         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1434         - Pass encoding to _save_baseline_data and write_output_files
1435
1436 2010-04-21  No'am Rosenthal  <noam.rosenthal@nokia.com>
1437
1438         Reviewed by Kenneth Rohde Christiansen.
1439
1440         [Qt] QtLauncher: make FPS measurement accurate
1441         https://bugs.webkit.org/show_bug.cgi?id=37934
1442
1443         Instead of counting paints, which are not interchangeable with frames that
1444         the user sees, we now set an arbitrary timer for FPS measurements. The idea is
1445         that if the main thread is delayed for any reason, that timer would be delayed
1446         as well.
1447
1448         * QtLauncher/QtLauncher.pro:
1449         * QtLauncher/fpstimer.cpp: Added.
1450         (FpsTimer::FpsTimer):
1451         (FpsTimer::numFrames):
1452         (FpsTimer::start):
1453         (FpsTimer::stop):
1454         (FpsTimer::timerEvent):
1455         * QtLauncher/fpstimer.h: Added.
1456         * QtLauncher/webview.cpp:
1457         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1458         (WebViewGraphicsBased::updateFrameRate):
1459         (WebViewGraphicsBased::paintEvent):
1460         * QtLauncher/webview.h:
1461
1462 2010-04-21  Eric Seidel  <eric@webkit.org>
1463
1464         Unreviewed, just adding missing ":" in python file.
1465
1466         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1467         https://bugs.webkit.org/show_bug.cgi?id=37765
1468
1469         new-run-webkit-tests --chromium was borked.
1470
1471         * Scripts/webkitpy/layout_tests/port/chromium.py:
1472
1473 2010-04-21  Eric Seidel  <eric@webkit.org>
1474
1475         Reviewed by Adam Barth.
1476
1477         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1478         https://bugs.webkit.org/show_bug.cgi?id=37765
1479
1480         Third time is the charm.  I've fixed all the
1481         new-run-webkit-tests regressions from previous attempts.
1482
1483         I fixed the queue to not ignore Tor as a reviwer in r57531,
1484         but instead it throws an exception every time his name is in a patch.
1485
1486         This fixes our Executive.run_command code to work around a Popen
1487         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1488         do not correctly handle unicode objects as input or output to
1489         Popen.communicate.
1490
1491         Following the advice of:
1492         http://farmdev.com/talks/unicode/
1493         I have changed all of webkitpy to use unicode() objects as strings
1494         instead of str objects (which in Python 3 are renamed "bytes").
1495
1496         String literals were left as "foo" instead of converting to u"foo"
1497         as u"foo" is only required if the string has a non-ascii code point.
1498         Python is smart about comparing str() and unicode() values and will
1499         log an error to the console if the comparison is ever invalid.
1500
1501         Executive.run* now correctly accept and return unicode() objects.
1502         I attempted to fix all the places that we call .write() to make sure we
1503         encode any unicode() objects into utf-8.
1504
1505         I removed several uses of StringIO.  StringIO should generally always be
1506         passed a unicode() value.
1507
1508         Likewise I replaced most calls to open() with codecs.open().
1509         codecs.open() matches Python 3 open semantics in requiring an encoding
1510         parameter.  Files opened with codecs.open() with a unicode-compatible
1511         encoding will vend unicode() objects from their read() calls, like how
1512         StringIO created with a unicode() object will do.
1513
1514         I also deployed "with" statements wider (now that the project has
1515         settled on Python 2.5) to close a bunch of file descriptor leaks.
1516
1517         * Scripts/webkitpy/common/checkout/api_unittest.py:
1518          - Read/write utf-8 files instead of ascii.
1519          - Update the tests to use test for proper unicode() handling.
1520         * Scripts/webkitpy/common/checkout/changelog.py:
1521          - Document that parse_latest_entry_from_file expects
1522            file-like objects which return unicode strings.
1523         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1524          - Use unicode() strings instead of str() byte arrays.
1525          - Deploy "with" to close file descriptor leaks.
1526         * Scripts/webkitpy/common/checkout/commitinfo.py:
1527          - Remove unneeded import.
1528         * Scripts/webkitpy/common/checkout/scm.py:
1529          - Remove use of str().
1530         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1531          - Read/write utf-8 files and use unicode() strings in testing.
1532         * Scripts/webkitpy/common/config/committers.py:
1533          - Use \u instead of \x to make slightly clearer what we're doing.
1534         * Scripts/webkitpy/common/net/bugzilla.py:
1535          - Add a new _string_contents() method and explain why
1536             we have to call unicode() on the result of soup.string
1537             and why it's safe to do so w/o needing to pass a codec name.
1538           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1539         * Scripts/webkitpy/common/net/buildbot.py:
1540          - Use unicode() instead of str() when needing to coax a
1541             NavigableString object into a unicode() object.
1542         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1543          - Add a test which contains a unicode builder name.
1544         * Scripts/webkitpy/common/net/statusserver.py:
1545          - Remove use of str()
1546         * Scripts/webkitpy/common/prettypatch.py:
1547          - Write out the patch file as utf-8.
1548         * Scripts/webkitpy/common/system/autoinstall.py:
1549          - Write out files with a explicit encodings.
1550          - Deploy "with" to close file descriptor leaks.
1551         * Scripts/webkitpy/common/system/deprecated_logging.py:
1552          - Write out log files as utf-8.
1553         * Scripts/webkitpy/common/system/executive.py:
1554          - Make run* properly take and return unicode() objects.
1555          - Cleaned up input handling in run_command a little by adding
1556            a _compute_input() method which can return early instead of having
1557            such a long/cluttered if-block.
1558         * Scripts/webkitpy/common/system/executive_unittest.py:
1559          - Added a unit test to make sure we don't break Tor again!
1560         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1561          - Write out the test list as utf-8.
1562         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1563          - Write out json files as utf-8.
1564         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1565          - Deploy "with" to close file descriptor leaks.
1566         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1567         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1568         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1569         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1570         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1571         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1572          - Make the skipped file parsing test unicode.
1573         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1574         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1575         * Scripts/webkitpy/layout_tests/port/webkit.py:
1576          - Deploy "with" to close file descriptor leaks.
1577         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1578          - Make explicit the encodings of log files and pid files.
1579         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1580          - Make encodings explicit and deploy "with".
1581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1582         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1583         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1584         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1585         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1586         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1587         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1588          - Removed extra import.
1589         * Scripts/webkitpy/tool/commands/queues.py:
1590          - No need to map args to strings now that run_command does.
1591          - Update test results to match args changes.
1592          - Document our global argument hacks.
1593         * Scripts/webkitpy/tool/commands/upload.py:
1594          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1595         * Scripts/webkitpy/tool/mocktool.py:
1596          - Rename add_patch_to_bug argument to match bugzilla.py
1597         * Scripts/webkitpy/tool/steps/abstractstep.py:
1598          - Executive.run_* now require lists instead of strings.
1599            The lack of this change was what broke webkit-patch
1600            for svn users the first time this was landed.
1601         * Scripts/webkitpy/tool/steps/postdiff.py:
1602          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1603         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1604         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1605         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1606          - Fixed spurious logging seen when running test-webkitpy
1607
1608 2010-04-21  Chris Fleizach  <cfleizach@apple.com>
1609
1610         Reviewed by Alexey Proskuryakov.
1611
1612         aria-liveregion-notifications.html fails on leopard release bot
1613         https://bugs.webkit.org/show_bug.cgi?id=37112
1614
1615         Change the way that notifications are listened for by forcing clients
1616         to call a remove listener as well to match the add listener. DRT will
1617         assert if those are not done in the correct order. 
1618
1619         * DumpRenderTree/AccessibilityUIElement.cpp:
1620         (removeNotificationListenerCallback):
1621         (AccessibilityUIElement::getJSClass):
1622         * DumpRenderTree/AccessibilityUIElement.h:
1623         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1624         (AccessibilityUIElement::removeNotificationListener):
1625         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1626         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1627         (-[AccessibilityNotificationHandler dealloc]):
1628         (-[AccessibilityNotificationHandler _notificationReceived:]):
1629         (-[AccessibilityNotificationHandler setCallback:]):
1630         (AccessibilityUIElement::AccessibilityUIElement):
1631         (AccessibilityUIElement::~AccessibilityUIElement):
1632         (AccessibilityUIElement::addNotificationListener):
1633         (AccessibilityUIElement::removeNotificationListener):
1634         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1635         (AccessibilityUIElement::removeNotificationListener):
1636
1637 2010-04-21  Anders Carlsson  <andersca@apple.com>
1638
1639         Reviewed by Sam Weinig.
1640
1641         Add debug menu items to show/hide the Web View.
1642         https://bugs.webkit.org/show_bug.cgi?id=37958
1643
1644         * MiniBrowser/mac/BrowserWindowController.h:
1645         * MiniBrowser/mac/BrowserWindowController.m:
1646         (-[BrowserWindowController showHideWebView:]):
1647         (-[BrowserWindowController removeReinsertWebView:]):
1648         (-[BrowserWindowController validateMenuItem:]):
1649         * MiniBrowser/mac/English.lproj/MainMenu.xib:
1650
1651 2010-04-21  Eric Seidel  <eric@webkit.org>
1652
1653         Unreviewed.  Rolling out unicode() changes as they broke NRWT for chromium.
1654         Rolling out:
1655         http://trac.webkit.org/changeset/58014
1656         http://trac.webkit.org/changeset/58016
1657         http://trac.webkit.org/changeset/58020
1658
1659         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbo
1660         https://bugs.webkit.org/show_bug.cgi?id=37765
1661
1662         * Scripts/webkitpy/common/checkout/api_unittest.py:
1663         * Scripts/webkitpy/common/checkout/changelog.py:
1664         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1665         * Scripts/webkitpy/common/checkout/commitinfo.py:
1666         * Scripts/webkitpy/common/checkout/scm.py:
1667         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1668         * Scripts/webkitpy/common/config/committers.py:
1669         * Scripts/webkitpy/common/net/bugzilla.py:
1670         * Scripts/webkitpy/common/net/buildbot.py:
1671         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1672         * Scripts/webkitpy/common/net/statusserver.py:
1673         * Scripts/webkitpy/common/prettypatch.py:
1674         * Scripts/webkitpy/common/system/autoinstall.py:
1675         * Scripts/webkitpy/common/system/deprecated_logging.py:
1676         * Scripts/webkitpy/common/system/executive.py:
1677         * Scripts/webkitpy/common/system/executive_unittest.py:
1678         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1679         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1680         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1681         * Scripts/webkitpy/layout_tests/port/chromium.py:
1682         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1683         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1684         * Scripts/webkitpy/layout_tests/port/gtk.py:
1685         * Scripts/webkitpy/layout_tests/port/mac.py:
1686         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1687         * Scripts/webkitpy/layout_tests/port/qt.py:
1688         * Scripts/webkitpy/layout_tests/port/server_process.py:
1689         * Scripts/webkitpy/layout_tests/port/webkit.py:
1690         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1691         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1692         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1693         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1694         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1695         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1696         * Scripts/webkitpy/style/filereader_unittest.py:
1697         * Scripts/webkitpy/thirdparty/__init__.py:
1698         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1699         * Scripts/webkitpy/tool/commands/queues.py:
1700         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1701         * Scripts/webkitpy/tool/commands/upload.py:
1702         * Scripts/webkitpy/tool/mocktool.py:
1703         * Scripts/webkitpy/tool/steps/abstractstep.py:
1704         * Scripts/webkitpy/tool/steps/postdiff.py:
1705         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1706         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1707         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1708
1709 2010-04-21  Eric Seidel  <eric@webkit.org>
1710
1711         Unreviewed, fixing NRWT for real this time.
1712
1713         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1714         https://bugs.webkit.org/show_bug.cgi?id=37765
1715
1716         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1717          - Add a hack to fix new-run-webkit-tests
1718            my understanding of codecs.open(encoding=None)
1719            must have been wrong.
1720
1721 2010-04-21  Eric Seidel  <eric@webkit.org>
1722
1723         Unreviewed, just fixing exception seen on builders.
1724
1725         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1726         https://bugs.webkit.org/show_bug.cgi?id=37765
1727
1728         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1729          - Pass and encoding to _write_into_file_at_path
1730
1731 2010-04-21  Eric Seidel  <eric@webkit.org>
1732
1733         Reviewed by Adam Barth.
1734
1735         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
1736         https://bugs.webkit.org/show_bug.cgi?id=37765
1737
1738         I fixed the queue to not ignore Tor as a reviwer in r57531,
1739         but instead it throws an exception every time his name is in a patch.
1740
1741         This fixes our Executive.run_command code to work around a Popen
1742         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
1743         do not correctly handle unicode objects as input or output to
1744         Popen.communicate.
1745
1746         Following the advice of:
1747         http://farmdev.com/talks/unicode/
1748         I have changed all of webkitpy to use unicode() objects as strings
1749         instead of str objects (which in Python 3 are renamed "bytes").
1750
1751         String literals were left as "foo" instead of converting to u"foo"
1752         as u"foo" is only required if the string has a non-ascii code point.
1753         Python is smart about comparing str() and unicode() values and will
1754         log an error to the console if the comparison is ever invalid.
1755
1756         Executive.run* now correctly accept and return unicode() objects.
1757         I attempted to fix all the places that we call .write() to make sure we
1758         encode any unicode() objects into utf-8.
1759
1760         I removed several uses of StringIO.  StringIO should generally always be
1761         passed a unicode() value.
1762
1763         Likewise I replaced most calls to open() with codecs.open().
1764         codecs.open() matches Python 3 open semantics in requiring an encoding
1765         parameter.  Files opened with codecs.open() with a unicode-compatible
1766         encoding will vend unicode() objects from their read() calls, like how
1767         StringIO created with a unicode() object will do.
1768
1769         I also deployed "with" statements wider (now that the project has
1770         settled on Python 2.5) to close a bunch of file descriptor leaks.
1771
1772         * Scripts/webkitpy/common/checkout/api_unittest.py:
1773          - Read/write utf-8 files instead of ascii.
1774          - Update the tests to use test for proper unicode() handling.
1775         * Scripts/webkitpy/common/checkout/changelog.py:
1776          - Document that parse_latest_entry_from_file expects
1777            file-like objects which return unicode strings.
1778         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1779          - Use unicode() strings instead of str() byte arrays.
1780          - Deploy "with" to close file descriptor leaks.
1781         * Scripts/webkitpy/common/checkout/commitinfo.py:
1782          - Remove unneeded import.
1783         * Scripts/webkitpy/common/checkout/scm.py:
1784          - Remove use of str().
1785         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1786          - Read/write utf-8 files and use unicode() strings in testing.
1787         * Scripts/webkitpy/common/config/committers.py:
1788          - Use \u instead of \x to make slightly clearer what we're doing.
1789         * Scripts/webkitpy/common/net/bugzilla.py:
1790          - Add a new _string_contents() method and explain why
1791             we have to call unicode() on the result of soup.string
1792             and why it's safe to do so w/o needing to pass a codec name.
1793           - Remove the (unused) support for passing a file object to add_patch_to_bug().
1794         * Scripts/webkitpy/common/net/buildbot.py:
1795          - Use unicode() instead of str() when needing to coax a
1796             NavigableString object into a unicode() object.
1797         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1798          - Add a test which contains a unicode builder name.
1799         * Scripts/webkitpy/common/net/statusserver.py:
1800          - Remove use of str()
1801         * Scripts/webkitpy/common/prettypatch.py:
1802          - Write out the patch file as utf-8.
1803         * Scripts/webkitpy/common/system/autoinstall.py:
1804          - Write out files with a explicit encodings.
1805          - Deploy "with" to close file descriptor leaks.
1806         * Scripts/webkitpy/common/system/deprecated_logging.py:
1807          - Write out log files as utf-8.
1808         * Scripts/webkitpy/common/system/executive.py:
1809          - Make run* properly take and return unicode() objects.
1810          - Cleaned up input handling in run_command a little by adding
1811            a _compute_input() method which can return early instead of having
1812            such a long/cluttered if-block.
1813         * Scripts/webkitpy/common/system/executive_unittest.py:
1814          - Added a unit test to make sure we don't break Tor again!
1815         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1816          - Write out the test list as utf-8.
1817         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1818          - Write out json files as utf-8.
1819         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1820          - Deploy "with" to close file descriptor leaks.
1821         * Scripts/webkitpy/layout_tests/port/chromium.py: Add Executive.py FIXME.
1822         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: ditto.
1823         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: ditto.
1824         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
1825         * Scripts/webkitpy/layout_tests/port/mac.py: ditto.
1826         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1827          - Make the skipped file parsing test unicode.
1828         * Scripts/webkitpy/layout_tests/port/qt.py: Add Executive.py FIXME.
1829         * Scripts/webkitpy/layout_tests/port/server_process.py: ditto.
1830         * Scripts/webkitpy/layout_tests/port/webkit.py:
1831          - Deploy "with" to close file descriptor leaks.
1832         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1833          - Make explicit the encodings of log files and pid files.
1834         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1835          - Make encodings explicit and deploy "with".
1836         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: ditto.
1837         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: ditto.
1838         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: ditto.
1839         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: ditto.
1840         * Scripts/webkitpy/style/filereader_unittest.py: ditto.
1841         * Scripts/webkitpy/thirdparty/__init__.py: ditto.
1842         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1843          - Removed extra import.
1844         * Scripts/webkitpy/tool/commands/queues.py:
1845          - No need to map args to strings now that run_command does.
1846          - Update test results to match args changes.
1847          - Document our global argument hacks.
1848         * Scripts/webkitpy/tool/commands/upload.py:
1849          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1850         * Scripts/webkitpy/tool/mocktool.py:
1851          - Rename add_patch_to_bug argument to match bugzilla.py
1852         * Scripts/webkitpy/tool/steps/abstractstep.py:
1853          - Executive.run_* now require lists instead of strings.
1854            The lack of this change was what broke webkit-patch
1855            for svn users the first time this was landed.
1856         * Scripts/webkitpy/tool/steps/postdiff.py:
1857          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
1858         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto
1859         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto
1860         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1861          - Fixed spurious logging seen when running test-webkitpy
1862
1863 2010-04-21  Kinuko Yasuda  <kinuko@chromium.org>
1864
1865         Unreviewed.
1866
1867         Add myself in committers.py.
1868
1869         * Scripts/webkitpy/common/config/committers.py:
1870
1871 2010-04-21  Dirk Pranke  <dpranke@chromium.org>
1872
1873         Reviewed by Dimitri Glazkov.
1874
1875         new-run-webkit-tests: fix a bug in the Chromium port where we would
1876         try to talk to a crashed test_shell and raise exceptions that weren't
1877         being caught.
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=37941
1880
1881         * Scripts/webkitpy/layout_tests/port/chromium.py:
1882
1883 2010-04-21  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1884
1885         Unreviewed.
1886
1887         [Qt] [Symbian] Build fix.
1888
1889         Work around a Qt quirk. Some versions of Symbian port Qt
1890         QFontDatabase::removeAllApplicationFonts symbol is not available.
1891
1892         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1893         (WebCore::DumpRenderTree::open):
1894
1895 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1896
1897         Unreviewed.
1898
1899         https://bugs.webkit.org/show_bug.cgi?id=37933
1900         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1901
1902         Adding stub implementation of authenticateSession(). Depending on platform loader behavior,
1903         a real implementation may or may not be necessary for the one test that currently uses it
1904         to pass.
1905
1906         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1907         (LayoutTestController::authenticateSession):
1908         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1909
1910 2010-04-21  Alexey Proskuryakov  <ap@apple.com>
1911
1912         Reviewed by Brady Eidson.
1913
1914         https://bugs.webkit.org/show_bug.cgi?id=37933
1915         <rdar://problem/7719540> XMLHttpRequest.withCredentials should be better enforced.
1916
1917         Adding authenticateSession() method that adds credentials to per-process credential storage
1918         (for platforms that even have such). No Windows implementation, because writing another
1919         loader for DRT is painful.
1920
1921         * DumpRenderTree/LayoutTestController.cpp:
1922         (authenticateSessionCallback):
1923         (LayoutTestController::staticFunctions):
1924         * DumpRenderTree/LayoutTestController.h:
1925         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1926         (-[SynchronousLoader dealloc]):
1927         (-[SynchronousLoader connectionShouldUseCredentialStorage:]):
1928         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
1929         (-[SynchronousLoader connection:didFailWithError:]):
1930         (-[SynchronousLoader connectionDidFinishLoading:]):
1931         (+[SynchronousLoader makeRequest:withUsername:password:]):
1932         (LayoutTestController::authenticateSession):
1933
1934         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1935         (LayoutTestController::authenticateSession):
1936         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1937         (LayoutTestController::authenticateSession):
1938         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1939         (LayoutTestController::authenticateSession):
1940         Stub implementations.
1941
1942 2010-04-21  Kent Tamura  <tkent@chromium.org>
1943
1944         Reviewed by Dimitri Glazkov.
1945
1946         [DRT/Chromium] Make DRT compilable in Chromium tree
1947         https://bugs.webkit.org/show_bug.cgi?id=37923
1948
1949         We need to use different GYPs in a case of WebKit-only checkout
1950         and a case of whole Chromium checkout because the relative paths
1951         from webkit/ to WebKit/chromium/features.gypi are different in
1952         these cases and we can't use 'conditions' for 'includes' in GYPs.
1953
1954         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1955
1956 2010-04-21  Jakub Wieczorek  <jwieczorek@webkit.org>
1957
1958         Reviewed by Darin Adler.
1959
1960         List item markers are not always updated after changes in the DOM.
1961         https://bugs.webkit.org/show_bug.cgi?id=37060
1962
1963         * DumpRenderTree/LayoutTestController.cpp:
1964         (markerTextForListItemCallback): A function that returns the marker text for a given list item.
1965         (LayoutTestController::staticFunctions):
1966         * DumpRenderTree/LayoutTestController.h:
1967         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1968         (LayoutTestController::markerTextForListItem): Implement it in the GTK port.
1969         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1970         (LayoutTestController::markerTextForListItem): Add a stub.
1971         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1972         (LayoutTestController::LayoutTestController):
1973         (LayoutTestController::markerTextForListItem): Implement it in the Qt port.
1974         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1975         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1976         (LayoutTestController::markerTextForListItem): Add a stub.
1977
1978 2010-04-21  Adam Roben  <aroben@apple.com>
1979
1980         Exclude leaks in CGGradientCreateWithColorComponents from
1981         run-webkit-tests leaks output
1982
1983         The leak in CG is covered by <rdar://problem/7888492>.
1984
1985         Fixes <http://webkit.org/b/37927>.
1986
1987         Reviewed by Eric Carlson.
1988
1989         * Scripts/old-run-webkit-tests:
1990         (sub countAndPrintLeaks): Exclude leaks in
1991         CGGradientCreateWithColorComponents on certain OSs.
1992
1993 2010-04-21  Kent Tamura  <tkent@chromium.org>
1994
1995         Reviewed by Shinichiro Hamaji.
1996
1997         [DRT/Chromium] Import MockSpellCheck from Chromium
1998         https://bugs.webkit.org/show_bug.cgi?id=37910
1999
2000         Import webkit/tools/test_shell/mock_spellcheck.{cc,h} rev.37241 of Chromium.
2001
2002         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2003           Add ICU explicitly because WTFString.h includes ICU headers.
2004           Add MockSpellCheck.{cpp,h}.
2005         * DumpRenderTree/chromium/MockSpellCheck.cpp: Added.
2006         * DumpRenderTree/chromium/MockSpellCheck.h: Added.
2007         * DumpRenderTree/chromium/WebViewHost.cpp:
2008         (WebViewHost::spellCheck):
2009         * DumpRenderTree/chromium/WebViewHost.h:
2010         * DumpRenderTree/chromium/config.h: Define JS_EXPORTDATA, which is used
2011           by wtf/text/AtomicString.h included by wtf/text/WTFString.h.
2012
2013 2010-04-21  Adam Barth  <abarth@webkit.org>
2014
2015         Reviewed by Eric Seidel.
2016
2017         Add webkit-patch pretty-diff
2018         https://bugs.webkit.org/show_bug.cgi?id=37892
2019
2020         This is slightly lame because it asks you whether the diff is correct,
2021         but it's a starting point.
2022
2023         * Scripts/webkitpy/tool/commands/__init__.py:
2024         * Scripts/webkitpy/tool/commands/prettydiff.py: Added.
2025         * Scripts/webkitpy/tool/main.py:
2026
2027 2010-04-21  Adam Barth  <abarth@webkit.org>
2028
2029         Reviewed by Darin Adler.
2030
2031         Remove mention of non-existant --no-build option
2032         https://bugs.webkit.org/show_bug.cgi?id=37893
2033
2034         The option doesn't exist!
2035
2036         * Scripts/webkitpy/tool/commands/stepsequence.py:
2037
2038 2010-04-21  Balazs Kelemen  <kb@inf.u-szeged.hu>
2039
2040         Reviewed by Kenneth Rohde Christiansen.
2041
2042         [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
2043         https://bugs.webkit.org/show_bug.cgi?id=37198
2044
2045         * QtLauncher/main.cpp:
2046         (LauncherWindow::toggleInterruptingJavaScriptEnabled):
2047         (LauncherWindow::newWindow):
2048         (LauncherWindow::cloneWindow):
2049         (LauncherWindow::createChrome):
2050         (main):
2051         * QtLauncher/webpage.cpp:
2052         (WebPage::WebPage):
2053         (WebPage::shouldInterruptJavaScript):
2054         * QtLauncher/webpage.h:
2055         (WebPage::setInterruptingJavaScriptEnabled):
2056
2057 2010-04-21  Eric Seidel  <eric@webkit.org>
2058
2059         Unreviewed, rolling out r57963.
2060         http://trac.webkit.org/changeset/57963
2061         https://bugs.webkit.org/show_bug.cgi?id=37759
2062
2063         Three tests started crashing on the Qt bot.
2064
2065         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2066         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2067
2068 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2069
2070         Reviewed by Eric Seidel.
2071
2072         Make new-run-webkit-tests work for the Qt port
2073         https://bugs.webkit.org/show_bug.cgi?id=37588
2074
2075         * Scripts/webkitpy/layout_tests/port/qt.py:
2076
2077 2010-04-21  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2078
2079         Reviewed by Eric Seidel.
2080
2081         new-run-webkit-tests: try to detect alternate apache path
2082         https://bugs.webkit.org/show_bug.cgi?id=37587
2083
2084         _check_port_build() also needs to return true in the
2085         base implementation to not fail the check_build step.
2086
2087         * Scripts/webkitpy/layout_tests/port/webkit.py:
2088
2089 2010-04-21  Yi Shen  <yi.4.shen@nokia.com>
2090
2091         Reviewed by Simon Hausmann.
2092
2093         [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
2094         https://bugs.webkit.org/show_bug.cgi?id=37759
2095
2096         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2097         (LayoutTestController::computedStyleIncludingVisitedInfo):
2098         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2099
2100 2010-04-21  Eric Seidel  <eric@webkit.org>
2101
2102         Unreviewed, test fix only.
2103
2104         new-run-webkit-tests: implement a --log trace message to be able to display detailed output of an individual test run
2105         https://bugs.webkit.org/show_bug.cgi?id=37726
2106
2107         This change seems to have broken a test.
2108         Attempting to handle the case where we don't have any
2109         timing information.  Dirk may have to correct this change.
2110
2111         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2112
2113 2010-04-19  Eric Seidel  <eric@webkit.org>
2114
2115         Reviewed by Adam Barth.
2116
2117         new-run-webkit-tests has much higher startup latency than run-webkit-tests
2118         https://bugs.webkit.org/show_bug.cgi?id=37643
2119
2120         I got rid of the -expected.checksum reads during startup.
2121         This makes startup noticably better on my laptop.
2122
2123         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2124          - Use image_hash() instead of .image_hash now that expected.checksum
2125            file reads are done lazily.
2126         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2127          - Add debug logging for this sleep call.
2128            In my testing I never saw this sleep() hit.
2129         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2130          - Sleep a shorter interval to make websocket server
2131            startup more responsive.  On my machine startup was
2132            taking around 1 second.
2133          - Remove the unconditional .5s delay on startup.
2134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2135          - Make image_hash file reads done lazily in a new image_hash() function.
2136          - Add a "Starting testing ..." meter update after DRT threads have
2137            been started, but before we get updates from the first one.
2138          - Rename variable "t" to a full english name to match WebKit style.
2139
2140 2010-04-20  Daniel Bates  <dbates@rim.com>
2141
2142         Reviewed by Eric Seidel.
2143
2144         https://bugs.webkit.org/show_bug.cgi?id=37748
2145
2146         Make Sheriffbot more inspirational.
2147
2148         * Scripts/webkitpy/common/net/bugzilla.py:
2149         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2150         * Scripts/webkitpy/tool/bot/irc_command.py:
2151         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2152         * Scripts/webkitpy/tool/mocktool.py:
2153
2154 2010-04-20  Kent Tamura  <tkent@chromium.org>
2155
2156         Reviewed by Dimitri Glazkov.
2157
2158         [DRT/Chromium] Import Chromium image_diff as ImageDiff
2159         https://bugs.webkit.org/show_bug.cgi?id=37790
2160
2161         ImageDiff.cpp is based on tools/imagediff/image_diff.cc r41911 of Chromium.
2162
2163         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2164         * DumpRenderTree/chromium/ImageDiff.cpp: Added.
2165         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2166
2167 2010-04-20  Dirk Pranke <dpranke@chromium.org>
2168
2169         This patch to new-run-webkit-tests adds a --log 'trace' option
2170         that prints out detailed info about a given test as it executes
2171         (where the baselines are, what the expectation is, what we got,
2172         how long it took).
2173
2174         https://bugs.webkit.org/show_bug.cgi?id=37726
2175
2176         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2177           - use the newly exposed TestResult class and implement
2178             --log trace
2179         * Scripts/webkitpy/layout_tests/layout_package/dump_render_thread.py:
2180           - rename TestStats to TestResult and make it more public, resulting
2181             in cleaner code
2182         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2183           - add expectation_to_string() as a separate callable function
2184
2185 2010-04-20  Eric Seidel  <eric@webkit.org>
2186
2187         Unreviewed, rolling out r57907.
2188         http://trac.webkit.org/changeset/57907
2189         https://bugs.webkit.org/show_bug.cgi?id=37765
2190
2191         Appears to have broken MacEWS and possibly webkit-patch upload
2192         for svn users.  Needs further investigation.
2193
2194         * Scripts/webkitpy/common/checkout/api.py:
2195         * Scripts/webkitpy/common/checkout/api_unittest.py:
2196         * Scripts/webkitpy/common/checkout/changelog.py:
2197         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2198         * Scripts/webkitpy/common/checkout/commitinfo.py:
2199         * Scripts/webkitpy/common/checkout/scm.py:
2200         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2201         * Scripts/webkitpy/common/config/committers.py:
2202         * Scripts/webkitpy/common/net/bugzilla.py:
2203         * Scripts/webkitpy/common/net/buildbot.py:
2204         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2205         * Scripts/webkitpy/common/net/statusserver.py:
2206         * Scripts/webkitpy/common/prettypatch.py:
2207         * Scripts/webkitpy/common/system/autoinstall.py:
2208         * Scripts/webkitpy/common/system/deprecated_logging.py:
2209         * Scripts/webkitpy/common/system/executive.py:
2210         * Scripts/webkitpy/common/system/executive_unittest.py:
2211         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2212         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2213         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2214         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2215         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2216         * Scripts/webkitpy/tool/commands/queues.py:
2217         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2218         * Scripts/webkitpy/tool/commands/upload.py:
2219         * Scripts/webkitpy/tool/mocktool.py:
2220         * Scripts/webkitpy/tool/steps/abstractstep.py:
2221         * Scripts/webkitpy/tool/steps/postdiff.py:
2222         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2223         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2224         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2225
2226 2010-04-20  Nate Chapin  <japhet@chromium.org>
2227
2228         Unreviewed.
2229
2230         Update my irc handle in committers.py (natechapin -> japhet).
2231
2232         * Scripts/webkitpy/common/config/committers.py:
2233
2234 2010-04-20  Eric Seidel  <eric@webkit.org>
2235
2236         Reviewed by Adam Barth.
2237
2238         REGRESSION(57531): the commit-queue still hates Tor Arne Vestbø
2239         https://bugs.webkit.org/show_bug.cgi?id=37765
2240
2241         I fixed the queue to not ignore Tor as a reviwer in r57531,
2242         but instead it throws an exception every time his name is in a patch.
2243
2244         This fixes our Executive.run_command code to work around a Popen
2245         bug http://bugs.python.org/issue5290 whereby python versions before 2.6
2246         do not correctly handle unicode objects as input or output to
2247         Popen.communicate.
2248
2249         Following the advice of:
2250         http://farmdev.com/talks/unicode/
2251         I'm attempting to take the python unicode plunge and use unicode()
2252         objects as strings instead of str() objects everywhere in webkitpy.
2253
2254         We do not have to use u"" instead of "" because u"a" == "a" as expected
2255         in Python.  Python will generate a warning to the console in cases where
2256         a unicode() == str() operation cannot be performed.
2257
2258         I also cleaned up the input handling in run_command a little by adding
2259         a new _compute_input() method which can return early instead of having
2260         such a long/cluttered if-block.
2261
2262         Executive.run* now correctly accept and return unicode() objects.
2263         I attempted to fix all the places that we call .write() to make sure we
2264         encode any unicode() objects into utf-8.
2265
2266         All places which use StringIO need to be sure to pass StringIO a
2267         pre-encoded byte-array (str object) instead of unicode so that
2268         clients which read from the StringIO don't have encoding exceptions.
2269         To make this easier, I removed the patch_file_object support from
2270         add_patch_to_bug, and changed the 4 places which previously used
2271         StringIO to create a fake patch file.
2272
2273         I attempted to document any places where we are not correctly converting
2274         to/from bytes (str() objects) to strings (unicode() objects).
2275
2276         * Scripts/webkitpy/common/checkout/api_unittest.py:
2277          - Read/write utf-8 files instead of ascii.
2278          - Update the tests to use test for proper unicode() handling.
2279         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2280          - Use unicode() strings instead of str() byte arrays.
2281         * Scripts/webkitpy/common/checkout/scm.py:
2282          - Remove use of str().
2283         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2284          - Read/write utf-8 files and use unicode() strings in testing.
2285         * Scripts/webkitpy/common/config/committers.py:
2286          - Use \u instead of \x to make slightly clearer what we're doing.
2287         * Scripts/webkitpy/common/net/bugzilla.py:
2288          - Add a new _string_contents() method and explain why
2289            we have to call unicode() on the result of soup.string
2290            and why it's safe to do so w/o needing to pass a codec name.
2291          - Remove the (unused) support for passing a file object to add_patch_to_bug().
2292         * Scripts/webkitpy/common/net/buildbot.py:
2293          - Use unicode() instead of str() when needing to coax a
2294            NavigableString object into a unicode() object.
2295         * Scripts/webkitpy/common/net/statusserver.py:
2296          - Remove use of str()
2297         * Scripts/webkitpy/common/prettypatch.py:
2298          - Write out the patch file as utf-8.
2299         * Scripts/webkitpy/common/system/autoinstall.py:
2300          - Add a FIXME about encoding.
2301         * Scripts/webkitpy/common/system/deprecated_logging.py:
2302          - Document that tee() works on bytes, not strings.
2303         * Scripts/webkitpy/common/system/executive.py:
2304          - Make run* properly take and return unicode() objects.
2305         * Scripts/webkitpy/common/system/executive_unittest.py:
2306          - Added a unit test to make sure we don't break Tor again!
2307         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2308          - Write out the test list as utf-8.
2309         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2310          - Write out json files as utf-8.
2311         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2312          - Add FIXME about encoding handling.
2313         * Scripts/webkitpy/tool/commands/upload.py:
2314          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2315         * Scripts/webkitpy/tool/mocktool.py:
2316          - Rename add_patch_to_bug argument to match bugzilla.py
2317         * Scripts/webkitpy/tool/steps/postdiff.py:
2318          - Pass the diff directly to add_patch_to_bug instead of creating a StringIO file wrapper.
2319         * Scripts/webkitpy/tool/steps/postdiffforcommit.py: ditto.
2320         * Scripts/webkitpy/tool/steps/postdiffforrevert.py: ditto.
2321         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2322          - Fixed spurious logging seen when running test-webkitpy
2323
2324 2010-04-20  Chris Jerdonek  <cjerdonek@webkit.org>
2325
2326         Reviewed by Shinichiro Hamaji.
2327
2328         For check-webkit-style, implemented __eq__() and __ne__() (the
2329         built-in equality and inequality methods) for the
2330         DefaultStyleErrorHandler class.
2331
2332         https://bugs.webkit.org/show_bug.cgi?id=37850
2333
2334         This will facilitate unit-testing for a subsequent patch,
2335         namely for https://bugs.webkit.org/show_bug.cgi?id=37850
2336
2337         * Scripts/webkitpy/style/error_handlers.py:
2338           - Added __eq__() and __ne__() to the DefaultStyleErrorHandler
2339             class.
2340
2341         * Scripts/webkitpy/style/error_handlers_unittest.py:
2342           - Added unit tests for __eq__() and __ne__().
2343           - Also included a minor clean-up refactoring of combining the
2344             StyleErrorHandlerTestBase class (which has not needed to
2345             be separate due to previous changes) into the
2346             DefaultStyleErrorHandlerTest class.
2347
2348 2010-04-20  Jakub Wieczorek  <jwieczorek@webkit.org>
2349
2350         Unreviewed.
2351
2352         Add my IRC nick to the committers.py list.
2353
2354         * Scripts/webkitpy/common/config/committers.py:
2355
2356 2010-04-20  Kim Grönholm  <kim.gronholm@nomovok.com>
2357
2358         Reviewed by Simon Hausmann.
2359
2360         [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView
2361         https://bugs.webkit.org/show_bug.cgi?id=37816
2362         
2363         Fix multi-touch mocking in QtLauncher when using QGraphicsView.
2364         Test: https://bug-32434-attachments.webkit.org/attachment.cgi?id=44955
2365
2366         * QtLauncher/main.cpp:
2367         (LauncherWindow::eventFilter):
2368         (LauncherWindow::initializeView):
2369
2370 2010-04-20  MORITA Hajime <morrita@google.com>
2371
2372         Unreviewed, add myself to the committers list.
2373
2374         * Scripts/webkitpy/common/config/committers.py:
2375
2376 2010-04-20  Kent Tamura  <tkent@chromium.org>
2377
2378         Reviewed by Shinichiro Hamaji.
2379
2380         [DRT/Chromium] Fix some unexpected results of editing
2381         https://bugs.webkit.org/show_bug.cgi?id=37843
2382
2383         This change fixes about 70 unexpected results.
2384         The original test_webview_delegate.cc doesn't have this bug.
2385         The bug was introduced when I ported it to WebKit tree.
2386
2387         * DumpRenderTree/chromium/WebViewHost.cpp:
2388         (printRangeDescription): Replace the latter startContainer() with endContainer().
2389
2390 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2391
2392         Unreviewed, build fix.
2393
2394         Turn off some unit tests for now - the new-run-webkit-tests dryrun
2395         tests for chromium won't work if you don't have a chromium checkout.
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=37841
2398
2399         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2400
2401 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2402
2403         Unreviewed, build fix.
2404
2405         (Re-)add dryrun.py; this was renamed from passing.py in the previous
2406         CL but apparently somehow didn't get checked in.
2407
2408         https://bugs.webkit.org/show_bug.cgi?id=37841
2409
2410         * Scripts/webkitpy/layout_tests/port/dryrun.py: Added.
2411
2412 2010-04-19  Shinichiro Hamaji  <hamaji@chromium.org>
2413
2414         Reviewed by David Levin.
2415
2416         check-webkit-style: exits when encountering a deleted file
2417         https://bugs.webkit.org/show_bug.cgi?id=37122
2418
2419         This reverts the quick fix done by r57119 and makes check_patch
2420         not call check_file for deleted files.
2421
2422         Also this change fixes the behavior for "-", which should mean
2423         stdin.  Before this change, the style checker just ignored "-"
2424         with a warning message.
2425
2426         * Scripts/webkitpy/style/checker.py:
2427         * Scripts/webkitpy/style/checker_unittest.py:
2428
2429 2010-04-19  Daniel Bates  <dbates@rim.com>
2430
2431         No review, rolling out 57868.
2432         http://trac.webkit.org/changeset/57868
2433         https://bugs.webkit.org/show_bug.cgi?id=37748
2434
2435         Sheriffbot wasn't very inspirational after this patch.
2436         Instead, he was silent when you said hi :-(. Rolling
2437         out this patch so that I can debug/test this some more.
2438
2439         * Scripts/webkitpy/common/net/bugzilla.py:
2440         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2441         * Scripts/webkitpy/tool/bot/irc_command.py:
2442         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2443         * Scripts/webkitpy/tool/mocktool.py:
2444
2445 2010-04-19  Daniel Bates  <dbates@rim.com>
2446
2447         Reviewed by Adam Barth.
2448
2449         https://bugs.webkit.org/show_bug.cgi?id=37748
2450
2451         Make Sheriffbot more inspirational.
2452
2453         * Scripts/webkitpy/common/net/bugzilla.py:
2454         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2455         * Scripts/webkitpy/tool/bot/irc_command.py:
2456         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2457         * Scripts/webkitpy/tool/mocktool.py:
2458
2459 2010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
2460
2461         [wx] Build fix, add missing header.
2462
2463         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2464
2465 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2466  
2467          Reviewed by Adam Barth.
2468  
2469          new-run-webkit-tests - repurpose the "Passing" port as "Dryrun" port
2470          that can be used to test platforms other than the one you are running
2471          on. This can be useful for checking baselines and testing code
2472          coverage.
2473  
2474          Note that running the code on the "wrong" port requires each
2475          port-specific implementation to actually not require any
2476          platform-specific python code (e.g., the chromium-win port must
2477          test for the existence of windows functions before calling them).
2478  
2479          https://bugs.webkit.org/show_bug.cgi?id=37782
2480  
2481          * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2482          * Scripts/webkitpy/layout_tests/port/dryrun.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/port/passing.py.
2483          * Scripts/webkitpy/layout_tests/port/factory.py:
2484          * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2485
2486 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2487
2488         Reviewed by Eric Seidel.
2489
2490         new-run-webkit-tests: add --build (default) and --no-build
2491         options to make that step optional. This flag modifies what happens
2492         in port.check_build().
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=37786
2495
2496         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2497         * Scripts/webkitpy/layout_tests/port/chromium.py:
2498         * Scripts/webkitpy/layout_tests/port/webkit.py:
2499
2500 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2501
2502         Unreviewed, build fix.
2503
2504         new-run-webkit-tests - fix a typo in r57480 that caused us to stop
2505         logging the actual list of unexpected results.
2506
2507         https://bugs.webkit.org/show_bug.cgi?id=37831
2508
2509         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2510
2511 2010-04-19  Dirk Pranke <dpranke@chromium.org>
2512
2513         Reviewed by Adam Barth.
2514
2515         From a patch by Tor Arne Vestbo  <tor.arne.vestbo@nokia.com>
2516
2517         new-run-webkit-tests: make the retry step more explicit
2518         https://bugs.webkit.org/show_bug.cgi?id=37606
2519
2520         It might be confusing to see the test and percent counters
2521         reset without any notice of what's going on, so we make the
2522         message that a retry-run is started explicit.
2523
2524         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2525
2526 2010-04-19  Sam Weinig  <weinig@apple.com>
2527
2528         Reviewed by Anders Carlsson.
2529
2530         Add support for opening a new window (File->New Window) to
2531         Windows MiniBrowser. Accelerator doesn't work.
2532
2533         * MiniBrowser/win/BrowserView.cpp:
2534         (createNewPage): Use BrowserView::create.
2535         * MiniBrowser/win/BrowserWindow.cpp:
2536         (BrowserWindow::onCommand): Respond to ID_FILE_NEW_WINDOW
2537         by creating a new window.
2538         * MiniBrowser/win/BrowserWindow.h:
2539         (BrowserWindow::create): Added. Don't allow creating
2540         BrowserWindows on the stack by making constructor
2541         private and exposing the create function.
2542         * MiniBrowser/win/MiniBrowser.cpp:
2543         (MiniBrowser::createNewWindow): Move new window creation
2544         logic here.
2545         * MiniBrowser/win/MiniBrowser.h:
2546         * MiniBrowser/win/MiniBrowser.rc: 
2547         * MiniBrowser/win/main.cpp:
2548         (_tWinMain): Use the new MiniBrowser::createNewWindow().
2549
2550 2010-04-19  Chris Fleizach  <cfleizach@apple.com>
2551
2552         Reviewed by Beth Dakin.
2553
2554         AX: aria-haspopup needs to be exposed
2555         https://bugs.webkit.org/show_bug.cgi?id=37808
2556
2557         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2558         (AccessibilityUIElement::hasPopup):
2559
2560 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2561
2562         Reviewed by Eric Seidel.
2563
2564         Submit a better workaround for r57806 than the one in r57831 - log
2565         an error and exit if you try to run new-run-webkit-tests with --use-drt
2566         on Windows.
2567
2568         https://bugs.webkit.org/show_bug.cgi?id=37822
2569
2570         * Scripts/webkitpy/layout_tests/port/chromium.py:
2571
2572 2010-04-19  Jesus Sanchez-Palencia  <jesus@webkit.org>
2573
2574         Unreviewed.
2575
2576         Just adding myself as a committer.
2577
2578         * Scripts/webkitpy/common/config/committers.py:
2579
2580 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2581
2582         Reviewed by Eric Seidel.
2583
2584         Add slightly better logging to the websocket python wrapper script,
2585         including a --verbose flag for debug output.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=37233
2588
2589         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2590         * Scripts/new-run-webkit-websocketserver:
2591
2592 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2593
2594         Reviewed by Eric Seidel.
2595
2596         new-run-webkit-tests: add a way (--print-unexpected-results) to
2597         (re-)print out the tests that produced unexpected results in the
2598         last run. Also add a way (--retry-unexpected-results) to
2599         automatically re-test them.
2600
2601         https://bugs.webkit.org/show_bug.cgi?id=37783
2602
2603         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2604
2605 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2606
2607         Reviewed by Eric Seidel.
2608
2609         Restructure the logging in new-run-webkit-tests so that many of log
2610         messages that were logged to the MeteredStream also get logged in
2611         --verbose mode.
2612
2613         https://bugs.webkit.org/show_bug.cgi?id=37780
2614
2615         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2617
2618 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2619
2620         Reviewed by Eric Seidel.
2621
2622         new-run-webkit-tests: add 'summary' and 'unexpected-results' options
2623         to the --log flag. Also add a 'progress' flag to enable the regular
2624         progress bar (as opposed to 'detailed-progress', which enables the
2625         dots). Also add a 'nothing' flag to allow you to be explicit that
2626         you don't want any logging on the command line.
2627
2628         The default is
2629         '--log detailed-progress,summary,unexpected,unexpected-results'
2630
2631         (The default logging is unchanged by this patch, this just makes things
2632         properly configurable).
2633
2634         Note that 'nothing' doesn't work properly yet; I need a couple other
2635         patches to land to avoid rewriting things several different ways.
2636
2637         https://bugs.webkit.org/show_bug.cgi?id=37785
2638
2639         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2640
2641 2010-04-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2642
2643         Reviewed by Simon Hausmann.
2644
2645         Make the URL change on committed load.
2646
2647         * QtLauncher/mainwindow.cpp:
2648         (MainWindow::buildUI):
2649         (MainWindow::setAddressUrl):
2650         * QtLauncher/mainwindow.h:
2651
2652 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2653
2654         Reviewed by Eric Seidel.
2655
2656         Fix a typo in the rebaselining tool that causes us to use "debug"
2657         instead of "Debug" in a directory path, which fails on platforms with
2658         case-sensitive filesystems.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=37819
2661
2662         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2663
2664 2010-04-19  Dirk Pranke  <dpranke@chromium.org>
2665
2666         Unreviewed, build fix.
2667
2668         Fix breakage of chromium-win canary bots caused by r57806. That patch
2669         introduced the option of using Chrome's new port of DumpRenderTree,
2670         but unfortunately that port relies on the webkit.py class
2671         implementation which uses non-blocking I/O that isn't available on
2672         Windows. This patch turns off that option and doesn't import the
2673         class if we're running on Windows.
2674
2675         https://bugs.webkit.org/show_bug.cgi?id=37817
2676
2677         * Scripts/webkitpy/layout_tests/port/chromium.py:
2678
2679 2010-04-19  James Robinson  <jamesr@chromium.org>
2680
2681         Reviewed by abarth.
2682
2683         Fix a typo
2684
2685         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2686
2687 2010-04-19  Adam Roben  <aroben@apple.com>
2688
2689         Fix run-webkit-tests when there are spaces in the path
2690
2691         Fixes <http://webkit.org/b/37809>
2692
2693         Reviewed by Adam Barth.
2694
2695         * Scripts/run-webkit-tests: Use an "indirect object" to specify the
2696         path to the harness to exec(). According to perldoc, this usage will
2697         prohibit perl from parsing the arguments to exec() via the shell,
2698         which would incorrectly split paths with spaces in them, etc.
2699
2700 2010-04-19  Dimitri Glazkov  <dglazkov@chromium.org>
2701
2702         Reviewed by Adam Roben.
2703
2704         WinLauncher.h should use LF line-endings and use native line-endings style.
2705         https://bugs.webkit.org/show_bug.cgi?id=37807
2706
2707         * WinLauncher/WinLauncher.h: Added property svn:eol-style, converted to LF line-endings.
2708
2709 2010-04-19  Kent Tamura  <tkent@chromium.org>
2710
2711         Reviewed by Shinichiro Hamaji.
2712
2713         [DRT/Chromium] Fix a test initialization problem
2714         https://bugs.webkit.org/show_bug.cgi?id=37791
2715
2716         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2717         (runTest): Call resetTestController() before runFileTest(). Some
2718           controllers initialize their fields in reset() and not in their
2719           constructors.
2720
2721 2010-04-19  Kent Tamura  <tkent@chromium.org>
2722
2723         Reviewed by Eric Seidel.
2724
2725         [Chromium] new-run-webkit-tests should use WebKitDriver for --use-drt
2726         https://bugs.webkit.org/show_bug.cgi?id=37793
2727
2728         We need to use WebKitDriver instead of ChromiumDriver for Chromium
2729         DRT because its interface is different from test_shell.
2730
2731         Chromium DRT has no UI.  So we can't use it to show test results.
2732
2733         * Scripts/webkitpy/layout_tests/port/chromium.py:
2734
2735 2010-04-18  Eric Seidel  <eric@webkit.org>
2736
2737         Reviewed by Adam Roben.
2738
2739         Make failure-reason more forgiving
2740         https://bugs.webkit.org/show_bug.cgi?id=37525
2741
2742         Removed search_limit, which wasn't very useful anyway.
2743         Added a log about the long load time loading from the builders.
2744         Prompt the user for what revision to start walking from (makes it easy to restart upon failure).
2745
2746         * Scripts/webkitpy/common/net/buildbot.py:
2747         * Scripts/webkitpy/tool/commands/queries.py:
2748
2749 2010-04-18  Chris Jerdonek  <cjerdonek@webkit.org>
2750
2751         Reviewed by Shinichiro Hamaji.
2752
2753         Created a class for check-webkit-style that encapsulates iterating
2754         over text files and reading them.
2755
2756         https://bugs.webkit.org/show_bug.cgi?id=37754
2757
2758         This revision is an intermediate step towards separating our
2759         style-checking code from the logic of iterating over files and
2760         reading them.
2761
2762         * Scripts/webkitpy/common/system/logtesting.py:
2763           - Added a logMessages() method to the LoggingTestCase class.
2764             This method provides unit tests with access to the raw list
2765             of log messages in case the tester needs to do something more
2766             than simply assert the list of existing messages.
2767
2768         * Scripts/webkitpy/style/checker.py:
2769           - Added a ProcessorBase class that processors of lists of lines
2770             should eventually inherit from.
2771           - Also added a FIXME to use the ProcessorBase class and the
2772             TextFileReader class added below.
2773
2774         * Scripts/webkitpy/style/filereader.py: Added.
2775           - Created a TextFileReader class that encapsulates reading
2776             and iterating over text files.
2777
2778         * Scripts/webkitpy/style/filereader_unittest.py: Added.
2779           - Added a TextFileReaderTest class to unit-test the
2780             new TextFileReader class.
2781
2782 2010-04-15  Tony Chang  <tony@chromium.org>
2783
2784         Reviewed by Adam Barth.
2785
2786         [chromium] new-run-webkit-tests should be able to use chromium DRT
2787         https://bugs.webkit.org/show_bug.cgi?id=37645
2788
2789         Make sure that the lack of a chromium checkout doesn't cause the script to
2790         fail.
2791
2792         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2793         * Scripts/webkitpy/layout_tests/port/chromium.py:
2794         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Fix up a few paths
2795             to be relative to an upstream output dir.
2796         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --use-drt flag.
2797
2798 2010-04-18  Eric Seidel  <eric@webkit.org>
2799
2800         Unreviewed, fixing the Qt bot.
2801
2802         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2803         https://bugs.webkit.org/show_bug.cgi?id=37632
2804
2805         * Scripts/run-webkit-tests:
2806          - Exit non-zero of launching the harness fails.
2807
2808 2010-04-18  Eric Seidel  <eric@webkit.org>
2809
2810         Unreviewed, fixing the Qt bot.
2811
2812         Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
2813         https://bugs.webkit.org/show_bug.cgi?id=37632
2814
2815         * Scripts/run-webkit-tests:
2816          - Fix the wrapper to work for users who do not
2817            have WebKitTools/Scripts in their path.
2818
2819 2010-04-14  Eric Seidel  <eric@webkit.org>
2820
2821         Reviewed by Adam Barth.
2822
2823         Add a layer of indirection when calling run-webkit-tests to
2824         allow testing new-run-webkit-tests on various platforms.
2825         https://bugs.webkit.org/show_bug.cgi?id=37632
2826
2827         This will let us test and fix bugs in new-run-webkit-tests
2828         without needing to restart the buildbot master between tests.
2829
2830         Currently this change leaves run-webkit-tests as-is, but once
2831         its landed we will easily be able to turn on/off
2832         new-run-webkit-tests for various ports/configurations.
2833
2834         I will send a note out to webkit-dev about how we will
2835         be using this launcher script to test on the bots.
2836
2837         * Scripts/old-run-webkit-tests: Copied from WebKitTools/Scripts/run-webkit-tests.
2838         * Scripts/run-webkit-tests:
2839          - A new script which decides whether to run new- or old-
2840            run-webkit-tests based on the platform.
2841         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2842          - Add some dummy argument handling for arguments which
2843            old-run-webkit-tests supports but new-run-webkit-tests
2844            does not yet.
2845
2846 2010-04-18  Eric Seidel  <eric@webkit.org>
2847
2848         Reviewed by Adam Barth.
2849
2850         Add Gtk bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2851         https://bugs.webkit.org/show_bug.cgi?id=33295
2852
2853         The Gtk builders have been green every time I've looked
2854         at them in the last 5 days or so.  It would appear webkit
2855         is now keeping them green and we should update the core
2856         builder list to match reality.
2857
2858         * Scripts/webkitpy/common/net/buildbot.py:
2859         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2860
2861 2010-04-18  Robert Hogan  <robert@webkit.org>
2862
2863         Reviewed by Simon Hausmann.
2864
2865         [Qt] Add support for LayoutTestController commands:
2866                    setSmartInsertDeleteEnabled
2867                    setSelectTrailingWhitespaceEnabled
2868                    execCommand
2869                    isCommandEnabled
2870
2871         https://bugs.webkit.org/show_bug.cgi?id=35844
2872
2873         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2874         (WebCore::WebPage::resetSettings):
2875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2876         (LayoutTestController::setSmartInsertDeleteEnabled):
2877         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2878         (LayoutTestController::execCommand):
2879         (LayoutTestController::isCommandEnabled):
2880         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2881
2882 2010-04-17  Adam Barth  <abarth@webkit.org>
2883
2884         Reviewed by Eric Seidel.
2885
2886         Remove steps_references and commands_references
2887         https://bugs.webkit.org/show_bug.cgi?id=37758
2888
2889         We tried using the mumble_references convention to manage our
2890         dependencies, but it doesn't seem to be providing much value for the
2891         steps and commands module because these modules are small pieces of the
2892         larger tool module.  In this patch, I've removed the references file
2893         for these modules.
2894  
2895         I've left the style_references file for the style module because that
2896         module seems better isolated from the rest of webkitpy and the
2897         style_references file appears to be providing some value.
2898
2899         * Scripts/webkitpy/tool/commands/commandtest.py:
2900         * Scripts/webkitpy/tool/commands/download_unittest.py:
2901         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2902         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2903         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2904         * Scripts/webkitpy/tool/commands/queuestest.py:
2905         * Scripts/webkitpy/tool/commands/upload.py:
2906         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2907         * Scripts/webkitpy/tool/commands_references.py: Removed.
2908         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2909         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2910         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2911         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
2912         * Scripts/webkitpy/tool/steps_references.py: Removed.
2913
2914 2010-04-17  Eric Seidel  <eric@webkit.org>
2915
2916         Reviewed by Adam Barth.
2917
2918         WebKit needs a Chromium Mac EWS Builder
2919         https://bugs.webkit.org/show_bug.cgi?id=37742
2920
2921         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2922
2923 2010-04-17  Adam Barth  <abarth@webkit.org>
2924
2925         Fix expected results for unit test broken by
2926         http://trac.webkit.org/changeset/57772
2927
2928         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2929
2930 2010-04-17  Sam Weinig  <weinig@apple.com>
2931
2932         Reviewed by Adam Roben.
2933
2934         Teach windows MiniBrowser how to work with window.open()
2935         and targeted links.
2936
2937         * MiniBrowser/win/BrowserView.cpp:
2938         (createNewPage): Create a new BrowserWindow and return its page.
2939         (showPage): Show the page.
2940         (closePage): Empty implementation.
2941         (runJavaScriptAlert): Empty implementation.
2942         (BrowserView::create): Register a UIClient.
2943         * MiniBrowser/win/BrowserView.h:
2944         (BrowserView::webView): Added.
2945         Change create to take a BrowserWindow instead of an HWND.
2946
2947         * MiniBrowser/win/BrowserWindow.cpp:
2948         (BrowserWindow::wndProc): Respond to WM_NCDESTROY.
2949         (BrowserWindow::goToURL): Added. Forwards to BrowserView.
2950         (BrowserWindow::onCreate): Don't always go to the default
2951         url. Let the caller do this.
2952         (BrowserWindow::onNCDestroy): Delete the window.
2953         * MiniBrowser/win/BrowserWindow.h:
2954         (BrowserWindow::view): Added.
2955         (BrowserWindow::window): Added.
2956
2957         * MiniBrowser/win/main.cpp:
2958         (_tWinMain):
2959         Go to the default URL for the initial page. Allocate the initial
2960         window on the heap for correctness.
2961
2962 2010-04-16  Adam Roben  <aroben@apple.com>
2963
2964         Add the Windows Debug (Test) builder to the list of core builders
2965
2966         It's been green for a few days now, and all the known Windows
2967         flakiness is Release-only.
2968
2969         Rubber-stamped by Mark Rowe.
2970
2971         * Scripts/webkitpy/common/net/buildbot.py:
2972         (BuildBot.core_builder_name_regexps): Added a regular expression to
2973         match the "Windows Debug (Test)" builder.
2974
2975 2010-04-16  Sam Weinig  <sam@webkit.org>
2976
2977         Reviewed by Anders Carlsson.
2978
2979         Fix window.open() and targeted links.
2980
2981         * MiniBrowser/mac/BrowserWindowController.m:
2982         (_createNewPage): Use the correct initializer to and load the window.
2983
2984 2010-04-16  Adam Roben  <aroben@apple.com>
2985
2986         Fix links to layout test results from build status pages
2987
2988         Reviewed by Mark Rowe.
2989
2990         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2991         (ExtractTestResults.finished): Prepend "/" on the URL of the test
2992         results page so that it is treated as an absolute URL.
2993
2994 2010-04-16  Tony Chang  <tony@chromium.org>
2995
2996         Reviewed by Dimitri Glazkov.
2997
2998         [chromium] build DRT on Linux
2999         https://bugs.webkit.org/show_bug.cgi?id=37690
3000
3001         * Scripts/build-dumprendertree: Add support for win and linux
3002
3003 2010-04-16  Sam Weinig  <weinig@apple.com>
3004
3005         Reviewed by Adam Roben.
3006
3007         Use the threaded process model for MiniBrowser if holding down
3008         the shift key on startup.
3009
3010         * MiniBrowser/win/BrowserView.cpp:
3011         (BrowserView::create): 
3012
3013 2010-04-15  Tony Chang  <tony@chromium.org>
3014
3015         Reviewed by Dimitri Glazkov.
3016
3017         [chromium] Add TestShellGtk.cpp so we can link on Linux
3018         https://bugs.webkit.org/show_bug.cgi?id=37561
3019
3020         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Add new file and
3021             add platform file exceptions.
3022         * DumpRenderTree/chromium/TestShellGtk.cpp: Added.
3023         (AlarmHandler):
3024         (TestShell::waitTestFinished):
3025
3026 2010-04-15  Tony Chang  <tony@chromium.org>
3027
3028         Reviewed by Dimitri Glazkov.
3029
3030         build DRT on chromium mac
3031         https://bugs.webkit.org/show_bug.cgi?id=37639
3032
3033         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3034         * Scripts/build-dumprendertree: enable build-dumprendertree --chromium
3035
3036 2010-04-15  Kent Tamura  <tkent@chromium.org>
3037
3038         Reviewed by Dimitri Glazkov.
3039
3040         [DRT/Chromium] Add LayoutTestHelper for Mac
3041         https://bugs.webkit.org/show_bug.cgi?id=37668
3042
3043         LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
3044         of Chromium.
3045
3046         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3047         * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
3048
3049 2010-04-15  Alexey Proskuryakov  <ap@apple.com>
3050
3051         Reviewed by Geoff Garen.
3052
3053         https://bugs.webkit.org/show_bug.cgi?id=37494
3054         <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
3055         fails on Windows
3056
3057         * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
3058         * DumpRenderTree/win/EventSender.h:
3059         Tell EventSender if it's being created for a top frame.
3060         
3061         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3062         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
3063         EventSender machinery when a new test is loaded, not when an iframe (or just its global
3064         object) is created.
3065
3066 2010-04-15  Adam Roben  <aroben@apple.com>
3067
3068         Fix Windows WebKit2 build.
3069
3070         * MiniBrowser/win/MiniBrowser.cpp:
3071
3072 2010-04-15  Ojan Vafai  <ojan@chromium.org>
3073
3074         Reviewed by Adam Barth.
3075
3076         Include codereview issue number in patch description
3077         https://bugs.webkit.org/show_bug.cgi?id=37677
3078
3079         This lets us know which rietveld issue this patch is tied to.
3080
3081         Also, make it so that --fancy-review overrides --no-review.
3082
3083         * Scripts/webkitpy/tool/steps/postcodereview.py:
3084         * Scripts/webkitpy/tool/steps/postdiff.py:
3085
3086 2010-04-15  Adam Roben  <aroben@apple.com>
3087
3088         Make --exit-after-n-failures work when all tests are timing out or crashing
3089
3090         Fixes <http://webkit.org/b/37679>.
3091
3092         Reviewed by Jon Honeycutt.
3093
3094         * Scripts/run-webkit-tests:
3095         (top level): When a test crashes or times out, break out of the main loop if
3096         stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
3097         from here...
3098         (stopRunningTestsEarlyIfNeeded): ...to here.
3099
3100 2010-04-15  Sam Weinig  <sam@webkit.org>
3101
3102         Reviewed by Anders Carlsson.
3103
3104         Add WebHistoryClient support.
3105         https://bugs.webkit.org/show_bug.cgi?id=37671
3106
3107         Add HistoryClient logging.
3108
3109         * MiniBrowser/mac/BrowserWindowController.m:
3110         (_didNavigateWithNavigationData):
3111         (_didPerformClientRedirect):
3112         (_didPerformServerRedirect):
3113         (_didUpdateHistoryTitle):
3114         (-[BrowserWindowController awakeFromNib]):
3115
3116 2010-04-15  Anders Carlsson  <andersca@apple.com>
3117
3118         Reviewed by Sam Weinig.
3119
3120         Start the mini browser in threaded mode if shift is pressed during startup.
3121         https://bugs.webkit.org/show_bug.cgi?id=37670
3122
3123         * MiniBrowser/mac/AppDelegate.m:
3124         (-[BrowserAppDelegate init]):
3125
3126 2010-04-15  Chris Fleizach  <cfleizach@apple.com>
3127
3128         Reviewed by Beth Dakin.
3129
3130         AXHelp is being appended from ancestors incorrectly
3131         https://bugs.webkit.org/show_bug.cgi?id=37659
3132
3133         * DumpRenderTree/AccessibilityUIElement.cpp:
3134         (getHelpTextCallback):
3135         (AccessibilityUIElement::getJSClass):
3136         * DumpRenderTree/AccessibilityUIElement.h:
3137         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3138         (AccessibilityUIElement::helpText):
3139         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3140         (AccessibilityUIElement::helpText):
3141         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3142         (AccessibilityUIElement::helpText):
3143
3144 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3145
3146         Reviewed by Adam Barth.
3147
3148         Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
3149         (broken by r57463 and r57381, at least). I've also filed bug 37477
3150         to fix check-webkit-style to catch these things.
3151
3152         https://bugs.webkit.org/show_bug.cgi?id=38586
3153
3154         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3155
3156 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3157
3158         Reviewed by Dimitri Glazkov.
3159
3160         Add a way to override the user-visible name for the test binary since
3161         some ports don't call it DumpRenderTree (e.g., Chromium Win uses
3162         test_shell, Chromium Mac uses TestShell) by adding a driver_name()
3163         method to the Port interface.
3164
3165         https://bugs.webkit.org/show_bug.cgi?id=37631
3166
3167         * Scripts/webkitpy/layout_tests/port/base.py:
3168         * Scripts/webkitpy/layout_tests/port/chromium.py:
3169         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3170         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3171
3172 2010-04-14  Anders Carlsson  <andersca@apple.com>
3173
3174         Reviewed by Adam Roben.
3175
3176         Add "Force Repaint" to debug menu.
3177         https://bugs.webkit.org/show_bug.cgi?id=37627
3178
3179         * MiniBrowser/mac/BrowserWindowController.h:
3180         * MiniBrowser/mac/BrowserWindowController.m:
3181         (-[BrowserWindowController forceRepaint:]):
3182         * MiniBrowser/mac/English.lproj/MainMenu.xib:
3183
3184 2010-04-15  Sam Weinig  <sam@webkit.org>
3185
3186         Reviewed by Adam Roben.
3187
3188         Add debug-minibrowser script.
3189
3190         * Scripts/debug-minibrowser: Copied from Scripts/run-minibrowser.
3191         * Scripts/webkitdirs.pm:
3192
3193 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3194  
3195         Reviewed by Dimitri Glazkov.
3196
3197         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3198         https://bugs.webkit.org/show_bug.cgi?id=37636
3199  
3200         Second patch: add Windows-specific implementation parts
3201         of TestShell.
3202
3203         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3204         * DumpRenderTree/chromium/TestShell.h:
3205         (TestShell::finishedEvent):
3206         * DumpRenderTree/chromium/TestShellWin.cpp:
3207         (watchDogThread):
3208         (TestShell::waitTestFinished):
3209
3210 2010-04-15  Roland Steiner  <rolandsteiner@chromium.org>
3211
3212         Reviewed by Dimitri Glazkov.
3213
3214         Bug 37636 - [DRT/Chromium] Implement DRT/Chromium for Windows
3215         https://bugs.webkit.org/show_bug.cgi?id=37636
3216
3217         First patch: fix compiler errors.
3218
3219         * DumpRenderTree/chromium/EventSender.cpp:
3220         (EventSender::reset):
3221         (EventSender::dispatchMessage):
3222         * DumpRenderTree/chromium/LayoutTestController.cpp:
3223         (LayoutTestController::pathToLocalResource):
3224         * DumpRenderTree/chromium/TestWebWorker.h:
3225         * DumpRenderTree/chromium/TextInputController.cpp:
3226         * DumpRenderTree/chromium/WebViewHost.h:
3227         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3228
3229 2010-04-14  Luiz Agostini  <luiz.agostini@openbossa.org>
3230
3231         Reviewed by Simon Hausmann.
3232
3233         [Qt] Moving setViewMode from DumpRenderTreeSupportQt to qwebpage.cpp
3234         https://bugs.webkit.org/show_bug.cgi?id=37622
3235
3236         Method qt_wrt_setViewMode was removed from qwebpage.cpp by mistake in r57433
3237         (bug 35844). Moving it back.
3238
3239         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3240         (LayoutTestController::setViewModeMediaFeature):
3241
3242 2010-04-15  Dirk Pranke  <dpranke@chromium.org>
3243
3244         Reviewed by Adam Barth.
3245
3246         Add some very minimal unit tests for new-run-webkit-tests. This should
3247         be enough to catch egregious brokenness like syntax errors and import
3248         declaration issues.
3249
3250         https://bugs.webkit.org/show_bug.cgi?id=37432
3251
3252         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3253         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Added.
3254
3255 2010-04-14  Brian Weinstein  <bweinstein@apple.com>
3256
3257         Reviewed by Adam Roben.
3258
3259         Add a way for the buildbot to kill any old processes that are running. This
3260         is useful because the Windows bots can get in states where a process remains
3261         running (httpd.exe, DumpRenderTree.exe), which causes the bots to get in a red
3262         state, and the processes must be killed manually.
3263
3264         * BuildSlaveSupport/build.webkit.org-config/master.cfg: If we are on Windows, kill
3265             the old processes that might be running.
3266         * BuildSlaveSupport/win/kill-old-processes: Added.
3267
3268 2010-04-14  Sam Weinig  <sam@webkit.org>
3269
3270         Reviewed by Anders Carlsson.
3271
3272         Tear down WebKit more completely on window closing and application
3273         termination. We still don't block application termination for pending
3274         close, but this is a step in the right direction.
3275
3276         * MiniBrowser/mac/AppDelegate.m:
3277         (-[BrowserAppDelegate applicationWillTerminate:]):
3278         * MiniBrowser/mac/BrowserWindowController.h:
3279         * MiniBrowser/mac/BrowserWindowController.m:
3280         (-[BrowserWindowController dealloc]):
3281         (-[BrowserWindowController windowWillClose:]):
3282         (-[BrowserWindowController applicationTerminating]):
3283
3284 2010-04-14  Adam Barth  <abarth@webkit.org>
3285
3286         Reviewed by Eric Seidel.
3287
3288         Use pretty patch for confirming webkit-patch diffs
3289         https://bugs.webkit.org/show_bug.cgi?id=37489
3290
3291         * Scripts/webkitpy/common/prettypatch.py: Added.
3292         * Scripts/webkitpy/tool/commands/download_unittest.py:
3293         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3294         * Scripts/webkitpy/tool/mocktool.py:
3295         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3296
3297 2010-04-14  Eric Seidel  <eric@webkit.org>
3298
3299         Reviewed by Adam Barth.
3300
3301         Teach webkit-patch how to handle revisions missing ChangeLogs
3302         https://bugs.webkit.org/show_bug.cgi?id=37519
3303
3304         Make commit_info_for_revision return None when revision
3305         is missing a ChangeLog.  Previously we would throw an array index
3306         exception.
3307         Teach callers how to handle None.
3308
3309         * Scripts/webkitpy/common/checkout/api.py:
3310         * Scripts/webkitpy/common/checkout/api_unittest.py:
3311         * Scripts/webkitpy/tool/commands/download.py:
3312         * Scripts/webkitpy/tool/commands/queries.py:
3313         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3314
3315 2010-04-13  Eric Seidel  <eric@webkit.org>
3316
3317         Reviewed by Adam Roben.
3318
3319         Add Qt Bot to the list of "core builders" (builders which block the commit-queue when red)
3320         https://bugs.webkit.org/show_bug.cgi?id=33297
3321
3322         This is an experiment.  The bots have been green for
3323         a while.  We'll see if adding them under sheriff-bot protection
3324         will keep them green.
3325
3326         * Scripts/webkitpy/common/net/buildbot.py:
3327         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3328
3329 2010-04-13  Eric Seidel  <eric@webkit.org>
3330
3331         Unreviewed, just fixing a constant in the Rietveld unit test.
3332
3333         * Scripts/webkitpy/common/net/rietveld_unittest.py
3334
3335 2010-04-13  Eric Seidel  <eric@webkit.org>
3336
3337         Unreviewed, just adding missing Mock to fix python tests.
3338
3339         * Scripts/webkitpy/tool/mocktool.py:
3340
3341 2010-04-13  Ojan Vafai  <ojan@chromium.org>
3342
3343         Reviewed by David Levin.
3344
3345         Add experimental prototype Rietveld integration to webkit-patch upload
3346         https://bugs.webkit.org/show_bug.cgi?id=37418
3347
3348         This patch adds bare-bones integration with Rietveld for code reviews.
3349         The behavior is hidden behind the --fancy-review command line flag.
3350         Currently, there's no support for uploading more than one patch per
3351         issue (which is a nice feature of Rietveld).  The plan is to play with
3352         this for a bit and see if it's useful.
3353
3354         Modified from Adam's original patch to autoinstall the rietveld upload script.
3355
3356         * Scripts/webkitpy/common/config/__init__.py:
3357         * Scripts/webkitpy/common/net/rietveld.py: Added.
3358         * Scripts/webkitpy/common/net/rietveld_unitttest.py: Added.
3359         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3360         * Scripts/webkitpy/tool/commands/upload.py:
3361         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3362         * Scripts/webkitpy/tool/main.py:
3363         * Scripts/webkitpy/tool/mocktool.py:
3364         * Scripts/webkitpy/tool/steps/__init__.py:
3365         * Scripts/webkitpy/tool/steps/options.py:
3366         * Scripts/webkitpy/tool/steps/postcodereview.py: Added.
3367         * Scripts/webkitpy/tool/steps/postdiff.py:
3368
3369 2010-04-13  Sam Weinig  <sam@webkit.org>
3370
3371         Rubber-stamped by Mark Rowe.
3372
3373         Add Makefile to MiniBrowser.
3374
3375         * MiniBrowser/Makefile: Added.
3376
3377 2010-04-13  Eric Seidel  <eric@webkit.org>
3378
3379         Unreviewed, just adding a sanity check.
3380
3381         Add check to make sure commit-queue can never commit too short a message
3382         https://bugs.webkit.org/show_bug.cgi?id=37528
3383
3384         The commit-queue made bogus messages here:
3385         http://trac.webkit.org/changeset/57532
3386         http://trac.webkit.org/changeset/57534
3387
3388         This was a regression caused by adding unicode parsing for
3389         our ChangeLog files.  Popen does not seem to play nice with
3390         unicode strings.
3391
3392         I'm also adding an "assert" to make sure short ChangeLogs never happen again.
3393
3394         * Scripts/webkitpy/common/system/executive.py:
3395          - Cast input to strings before passing to POpen
3396         * Scripts/webkitpy/tool/steps/commit.py:
3397          - Validate that commit messages are not to short.
3398
3399 2010-04-13  Adam Roben  <aroben@apple.com>
3400
3401         Robustify new-run-webkit-tests against paths with spaces in them
3402
3403         Reviewed by Eric Seidel.
3404
3405         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3406         (LayoutTestApacheHttpd.__init__): Quote all paths that we pass to
3407         Apache to ensure that paths with spaces in them are interpreted
3408         correctly.
3409
3410 2010-04-13  Csaba Osztrogonác  <ossy@webkit.org>
3411
3412         Unreviewed buildfix after r57537.
3413
3414         * DumpRenderTree/qt/LayoutTestControllerQt.h: Declaration of removeOriginAccessWhitelistEntry() added.
3415
3416 2010-04-13  Sam Weinig  <sam@webkit.org>
3417
3418         Reviewed by Maciej Stachowiak.
3419
3420         Make building new webkit API and MiniBrowser a little easier.
3421
3422         * Scripts/build-webkit: Make building with --webkit2 build the 
3423         MiniBrowser as well and tell you how to use it.
3424         * Scripts/run-minibrowser: Copied from Scripts/run-safari.
3425         * Scripts/webkitdirs.pm: Add runMiniBrowser function.
3426
3427 2010-04-12  Timothy Hatcher  <timothy@apple.com>
3428
3429         SecurityOrigin needs a way to remove individual OriginAccessEntries
3430         https://bugs.webkit.org/show_bug.cgi?id=37449
3431
3432         Reviewed by Dave Hyatt.
3433
3434         * DumpRenderTree/LayoutTestController.cpp:
3435         (removeOriginAccessWhitelistEntryCallback): Added. Call LayoutTestController::removeOriginAccessWhitelistEntry.
3436         (LayoutTestController::staticFunctions): Added removeOriginAccessWhitelistEntry.
3437         * DumpRenderTree/LayoutTestController.h:
3438         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3439         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3440         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3441         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3442         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3443         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3444         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3445         (LayoutTestController::removeOriginAccessWhitelistEntry): Added.
3446         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3447         (LayoutTestController::whiteListAccessFromOrigin): FIXME to implement.
3448         (LayoutTestController::removeOriginAccessWhitelistEntry): Added. FIXME to implement.
3449
3450 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3451
3452         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3453         And LayoutTestController.whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3454         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3455
3456         SecurityOrigin needs a way to remove individual OriginAccessEntries
3457         https://bugs.webkit.org/show_bug.cgi?id=37449
3458
3459         Reviewed by Dave Hyatt.
3460
3461         * DumpRenderTree/LayoutTestController.cpp:
3462         (addOriginAccessWhitelistEntryCallback):
3463         (LayoutTestController::staticFunctions):
3464         * DumpRenderTree/LayoutTestController.h:
3465         * DumpRenderTree/chromium/LayoutTestController.cpp:
3466         (LayoutTestController::LayoutTestController):
3467         (LayoutTestController::addOriginAccessWhitelistEntry):
3468         * DumpRenderTree/chromium/LayoutTestController.h:
3469         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3470         (LayoutTestController::addOriginAccessWhitelistEntry):
3471         * DumpRenderTree/mac/DumpRenderTree.mm:
3472         (resetWebViewToConsistentStateBeforeTesting):
3473         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3474         (LayoutTestController::addOriginAccessWhitelistEntry):
3475         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3476         (LayoutTestController::addOriginAccessWhitelistEntry):
3477         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3478         * DumpRenderTree/win/DumpRenderTree.cpp:
3479         (resetWebViewToConsistentStateBeforeTesting):
3480         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3481         (LayoutTestController::addOriginAccessWhitelistEntry):
3482         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3483         (LayoutTestController::addOriginAccessWhitelistEntry):
3484
3485 2010-04-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3486
3487         Reviewed by Eric Seidel.
3488
3489         Remove duplicate function for new-run-webkit-tests
3490         https://bugs.webkit.org/show_bug.cgi?id=37517
3491
3492         The version() function was already implemented.
3493
3494         * Scripts/webkitpy/layout_tests/port/webkit.py:
3495
3496 2010-04-13  Eric Seidel  <eric@webkit.org>
3497
3498         Reviewed by David Levin.
3499
3500         the commit-queue hates Tor Arne Vestbø
3501         https://bugs.webkit.org/show_bug.cgi?id=37511
3502
3503         We were failing to read reviewers out of ChangeLogs
3504         when the reviewer has unicode characters in his/her name.
3505         I fixed this by explicitly decoding from utf8 every time we
3506         read in a ChangeLog file (they are always UTF8).
3507
3508         * Scripts/webkitpy/common/checkout/changelog.py:
3509         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3510
3511 2010-04-13  Adam Roben  <aroben@apple.com>
3512
3513         Fix run-webkit-tests on Windows with spaces in the path
3514
3515         Fixes <http://webkit.org/b/37509>.
3516
3517         Reviewed by Steve Falkenburg.
3518
3519         * Scripts/run-webkit-tests:
3520         (convertPathUsingCygpath): Remove spaces from the path before passing
3521         them to cygpath, then add them back in after conversion, as some
3522         versions of cygpath seem to convert spaces into newlines.
3523
3524 2010-04-13  Adam Barth  <abarth@webkit.org>
3525
3526         Unreviewed, but approved by Dumitru Daniliuc.  (This patch is intended
3527         to fix the downstream Chromium build bots.  Hopefully it will work!)
3528
3529         Add a driver script for the new websocket server
3530         https://bugs.webkit.org/show_bug.cgi?id=37495
3531
3532         websocket_server.py can't be run directly because its a module and not
3533         a standalone script.  This used to work by accident because it didn't
3534         depend on any other modules.
3535
3536         * Scripts/new-run-webkit-websocketserver: Added.
3537         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3538
3539 2010-04-12  Eric Seidel  <eric@webkit.org>
3540
3541         Reviewed by Adam Barth.
3542
3543         Make new-run-webkit-test PrettyPatch failure reporting more awesome
3544         https://bugs.webkit.org/show_bug.cgi?id=37487
3545
3546         I also fixed an Executive/executive typo.
3547
3548         * Scripts/webkitpy/layout_tests/port/base.py:
3549
3550 2010-04-12  Eric Seidel  <eric@webkit.org>
3551
3552         Reviewed by Adam Barth.
3553
3554         new-run-webkit-tests should only build java support files on Mac
3555         https://bugs.webkit.org/show_bug.cgi?id=37482
3556
3557         Only the mac needs java support files, so I pushed _build_java
3558         down into the Mac port using a new hook "_check_port_build".
3559         In the process I noticed a bunch of code which could be shared
3560         between all ports and thus got rid of _tests_for_disabled_features
3561         and version() copy/paste between all webkit ports.
3562         I also made check_build only bother to check for ImageDiff if we're
3563         using pixel tests.
3564
3565         * Scripts/webkitpy/layout_tests/port/gtk.py:
3566         * Scripts/webkitpy/layout_tests/port/mac.py:
3567         * Scripts/webkitpy/layout_tests/port/qt.py:
3568         * Scripts/webkitpy/layout_tests/port/webkit.py:
3569         * Scripts/webkitpy/layout_tests/port/win.py:
3570
3571 2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
3572
3573         Unreviewed, trying to make scripts work on machines without
3574         Ruby...
3575
3576         * Scripts/webkitpy/layout_tests/port/base.py:
3577
3578 2010-04-12  Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3579
3580         Reviewed by Eric Seidel.
3581
3582         Add stub files for running new-run-webkit-tests for the Qt port
3583
3584         * Scripts/webkitpy/layout_tests/port/factory.py:
3585         * Scripts/webkitpy/layout_tests/port/qt.py: Added.
3586
3587 2010-04-12  Dirk Pranke  <dpranke@chromium.org>
3588
3589         Reviewed by Eric Seidel.
3590
3591         Modify run_webkit_tests.py to not call sys.exit() at the end of test
3592         run; doing so makes it more difficult to embed the routine for,
3593         among other things, unit tests. We push the exit calling up into
3594         new-run-webkit-tests.
3595
3596         https://bugs.webkit.org/show_bug.cgi?id=37464
3597
3598         * Scripts/new-run-webkit-tests:
3599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3600
3601 2010-04-12  Eric Seidel  <eric@webkit.org>
3602
3603         Unreviewed.
3604
3605         Add stub Gtk implementation for new-run-webkit-tests.
3606
3607         * Scripts/webkitpy/layout_tests/port/factory.py:
3608         * Scripts/webkitpy/layout_tests/port/gtk.py: Added.
3609
3610 2010-04-12  Eric Seidel  <eric@webkit.org>
3611
3612         Reviewed by Adam Barth.
3613
3614         new-run-webkit-tests fails with exception on systems missing ruby
3615         https://bugs.webkit.org/show_bug.cgi?id=37441
3616
3617         * Scripts/webkitpy/layout_tests/port/base.py:
3618          - Catch failures similar to how wdiff code path does.
3619          - After one failure, stop trying.
3620
3621 2010-04-12  Tony Chang  <tony@chromium.org>
3622
3623         Reviewed by Eric Seidel.
3624
3625         Fix how we import simplejson based on how it's used in this file.
3626         This fixes exceptions raised when trying to write the simplejson output.
3627
3628         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3629
3630 2010-04-11  Chris Jerdonek  <cjerdonek@webkit.org>
3631
3632         Reviewed by Shinichiro Hamaji.
3633
3634         Refactored check-webkit-style so that the StyleChecker class
3635         has no dependencies on patch-related concepts.
3636
3637         https://bugs.webkit.org/show_bug.cgi?id=37065
3638
3639         This patch is an intermediate step towards making the StyleChecker
3640         class a generalized file processor that can do arbitary operations
3641         on the files corresponding to a list of paths.  This patch
3642         also simplifies the unit-testing of patch-checking code.
3643
3644         * Scripts/check-webkit-style:
3645           - Updated to use the new PatchChecker class.
3646
3647         * Scripts/webkitpy/style/checker.py:
3648           - Refactored the StyleChecker.check_patch() method into the
3649             check() method of a new PatchChecker class.
3650
3651         * Scripts/webkitpy/style/checker_unittest.py:
3652           - Refactored the unit tests as necessary, changing the
3653             StyleCheckerCheckPatchTest class to a PatchCheckerTest class.
3654
3655 2010-04-11  Adam Barth  <abarth@webkit.org>
3656
3657         Unreviewed.
3658
3659         Fix new-run-webkit-tests regressions cased by Eric's option parsing patch
3660         https://bugs.webkit.org/show_bug.cgi?id=37430
3661
3662         We need some basic unit testing of this script, or we're going to keep
3663         breaking it like this.  Added missing namespace qualifiers and
3664         propagated renaming of an option.
3665
3666         * Scripts/webkitpy/common/config/ports.py:
3667         * Scripts/webkitpy/layout_tests/driver_test.py:
3668         * Scripts/webkitpy/layout_tests/port/base.py:
3669         * Scripts/webkitpy/layout_tests/port/mac.py:
3670         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3671
3672 2010-04-11  Eric Seidel  <eric@webkit.org>
3673
3674         Reviewed by Adam Barth.
3675
3676         Break new-run-webkit-tests options into groups for easier re-use and possible relocation
3677         https://bugs.webkit.org/show_bug.cgi?id=37408
3678
3679         new-run-webkit-tests currently has one huge function for
3680         dealing with all options-parsing. 
3681         This patch is a first attempt at trying to split that large
3682         function down into smaller (hopefully more readable?) chunks
3683         dealing with the different areas of options.
3684         For example, it would make sense to move configuration
3685         options off into some module which deals with the vagries of
3686         WebKit's configuration system.  It would also make sense to move
3687         Chromium options off onto the Chromium port object (where they are used).
3688         It may make sense to move results.json options over to the results.json code.
3689         This change is a first iteration, and we will certainly need more
3690         refinement to this code over time.  Hopefully I didn't make things
3691         harder to read here.
3692
3693         * Scripts/webkitpy/layout_tests/driver_test.py:
3694         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3695
3696 2010-04-11  Adam Barth  <abarth@webkit.org>
3697
3698         Reviewed by Eric Seidel.
3699
3700         create-rollout copy needs to be updated to reflect removal of --no-build
3701         https://bugs.webkit.org/show_bug.cgi?id=37425
3702
3703         Removed --no-build and --no-test from the instructions because these
3704         don't exist anymore.
3705
3706         * Scripts/webkitpy/tool/commands/download_unittest.py:
3707             - Updated the expected results to reflect the new copy.
3708         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3709
3710 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3711
3712         Unreviewed, rolling out r57460.
3713         http://trac.webkit.org/changeset/57460
3714         https://bugs.webkit.org/show_bug.cgi?id=37424
3715
3716         broke chromium builders (Requested by tony^work on #webkit).
3717
3718         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3719
3720 2010-04-11  Tony Chang  <tony@chromium.org>
3721
3722         Reviewed by Darin Fisher.
3723
3724         [chromium] update chromium DEPS for upstream compile
3725         https://bugs.webkit.org/show_bug.cgi?id=36578
3726
3727         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Small fix to avoid a circular dependency between
3728           WebKit.gyp and webkit.gyp.
3729
3730 2010-04-11  Joseph Pecoraro  <joepeck@webkit.org>
3731
3732         Reviewed by Eric Seidel.
3733
3734         svn-apply errors out when removing directories in git
3735         https://bugs.webkit.org/show_bug.cgi?id=34871
3736
3737         * Scripts/svn-apply:
3738         (isDirectoryEmptyForRemoval): early break if the directory doesn't exist
3739         (scmRemove): have git ignore unmatched files
3740
3741 2010-04-11  Daniel Bates  <dbates@rim.com>
3742
3743         No review, rolling out 57440.
3744         http://trac.webkit.org/changeset/57440
3745         https://bugs.webkit.org/show_bug.cgi?id=27204
3746
3747         Did not handle Git patches that included both file and property
3748         changes to the same file. Rolling this change out while I look
3749         into this.
3750
3751         * Scripts/VCSUtils.pm:
3752         * Scripts/svn-apply:
3753         * Scripts/svn-unapply:
3754         * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Removed.
3755         * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Removed.
3756         * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Removed.
3757
3758 2010-04-11  Adam Barth  <abarth@webkit.org>
3759
3760         Reviewed by Eric Seidel.
3761
3762         Fix typo in log path for AbstractQueue
3763         https://bugs.webkit.org/show_bug.cgi?id=37414
3764
3765         * Scripts/webkitpy/tool/commands/queues.py:
3766         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3767
3768 2010-04-11  Adam Barth  <abarth@webkit.org>
3769
3770         Unreviewed.  Add missing import statement.
3771
3772         * Scripts/webkitpy/common/system/executive.py:
3773
3774 2010-04-11  Robert Hogan  <robert@webkit.org>
3775
3776         Reviewed by Simon Hausmann.
3777
3778         [Qt] Add setWillSendRequestReturnsNull and setWillSendRequestClearHeader
3779
3780         https://bugs.webkit.org/show_bug.cgi?id=37410
3781
3782         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3783         (LayoutTestController::reset):
3784         (LayoutTestController::setWillSendRequestReturnsNull):
3785         (LayoutTestController::setWillSendRequestClearHeader):
3786         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3787
3788 2010-04-11  Csaba Osztrogonác  <ossy@webkit.org>
3789
3790         [Qt] Unreviewed buildfix for --debug build after r57433.
3791
3792         Refactor Qt DRT support in QtWebKit
3793         https://bugs.webkit.org/show_bug.cgi?id=35844
3794
3795         * QtLauncher/main.cpp: qt_drt_garbageCollector_collect(); renamed to DumpRenderTreeSupportQt::garbageCollectorCollect();
3796         (launcherMain):
3797
3798 2010-04-11  Joseph Pecoraro  <joepeck@webkit.org>
3799
3800         Reviewed by Mark Rowe.
3801
3802         Make commit-log-editor Rubber-stamp aware. And other minor cleanups.
3803         https://bugs.webkit.org/show_bug.cgi?id=37407
3804
3805         * Scripts/commit-log-editor:
3806
3807 2010-04-11  Eric Seidel  <eric@webkit.org>
3808
3809         Reviewed by Adam Barth.
3810
3811         Add PrettyPatch links to new-run-webkit-tests output
3812         https://bugs.webkit.org/show_bug.cgi?id=37406
3813
3814         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3815          - We're leaking a file handle here, add a FIXME.
3816         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3817          - Add pretty diff links.
3818         * Scripts/webkitpy/layout_tests/port/base.py:
3819          - Add support for generating pretty diffs using PrettyPatch.
3820         * Scripts/webkitpy/layout_tests/port/webkit.py:
3821          - We're leaking another file handle here, another FIXME.
3822         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3823          - Update write_output_files signature.
3824         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3825          - Remove unused arguments from write_output_files.
3826          - Add support for dumping pretty diffs to write_output_files.
3827          - Fix a bunch of file descriptor leaks in this file.
3828         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3829          - Update write_output_files signature.
3830
3831 2010-04-10  Adam Barth  <abarth@webkit.org>
3832
3833         Reviewed by Eric Seidel.
3834
3835         kill_process is copy/pasted in five places
3836         https://bugs.webkit.org/show_bug.cgi?id=37405
3837
3838         We shouldn't replicate the kill_process logic in every port.  Instead,
3839         we should move the process interaction to Executive.
3840
3841         Dirk mentioned that he wanted this abstraction to make it easier to
3842         mock things out for testing.  It turns out this function is only used
3843         in one place where it can't be used as a mock point for testing because
3844         the corresponding create process actually creates a real process.  In
3845         the long term, we should indirect both these calls through a non-static
3846         Executive as a mock point.  However, we should wait on that until we
3847         actually want to write the test.
3848
3849         * Scripts/webkitpy/layout_tests/port/base.py:
3850         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3851         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3852         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3853         * Scripts/webkitpy/layout_tests/port/mac.py:
3854         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3855         * Scripts/webkitpy/layout_tests/port/win.py:
3856
3857 2010-04-10  Adam Barth  <abarth@webkit.org>
3858
3859         Reviewed by Eric Seidel.
3860
3861         new-run-webkit-tests shouldn't alter its path to import packages
3862         https://bugs.webkit.org/show_bug.cgi?id=37404
3863
3864         * Scripts/new-run-webkit-tests:
3865         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3866         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3867         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3868         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3869         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
3870         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3871         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3872         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
3873
3874 2010-04-10  Eric Seidel  <eric@webkit.org>
3875
3876         Reviewed by Adam Barth.
3877
3878         new-run-webkit-tests should store results to a directory under the build tree
3879         https://bugs.webkit.org/show_bug.cgi?id=37380
3880
3881         * Scripts/webkitpy/layout_tests/port/webkit.py:
3882
3883 2010-04-10  Daniel Bates  <dbates@rim.com>
3884
3885         Reviewed by Eric Seidel.
3886
3887         https://bugs.webkit.org/show_bug.cgi?id=27204
3888
3889         Implement support for changing the executable bit of a file.
3890         The executable bit is among the most changed file properties.
3891         Future support can include other property changes.
3892
3893         Currently, if a patch changes the executable bit of a file
3894         it is not respected by svn-apply or svn-unapply. Since the
3895         commit-queue bot uses these tools as part of its workflow,
3896         such patches cannot be committed by it. That is, such patches
3897         need to be committed by hand. Instead, we should add support
3898         for the executable bit so that such patches can be committed
3899         by the commit-queue bot.
3900
3901         * Scripts/VCSUtils.pm: Also change reference to Apple Computer, Inc.
3902         in copyright to Apple, Inc.
3903         * Scripts/svn-apply:
3904         * Scripts/svn-unapply:
3905         * Scripts/webkitperl/VCSUtils_unittest/appendSVNExecutableBitChangeToPatch.pl: Added.
3906         * Scripts/webkitperl/VCSUtils_unittest/parseGitFileMode.pl: Added.
3907         * Scripts/webkitperl/VCSUtils_unittest/parseStartOfPatchOrPropertyChangeAndEndOfPropertyChange.pl: Added.
3908
3909 2010-04-10  Eric Seidel  <eric@webkit.org>
3910
3911         Reviewed by Adam Barth.
3912
3913         WinEWS bot fails to svn update because scm.clean_working_directory leaves files around
3914         https://bugs.webkit.org/show_bug.cgi?id=37401
3915
3916         The Git-based bots don't have this trouble because
3917         Git.clean_working_directory fully removes files that were
3918         marked as "add".  SVN.clean_working_directory previously just
3919         called "svn revert" which would leave added files in the
3920         working directory untracked.  This patch makes
3921         SVN.clean_working_directory function more like
3922         Git.clean_working_directory by removing added files after revert.
3923
3924         * Scripts/webkitpy/common/checkout/scm.py:
3925          - Add SCM.absolute_path for easy conversion between
3926            repository-relative paths and absolute paths.
3927          - Add SCM.add and SCM.added_files
3928          - Make SVN.clean_working_directory remove any added_files after svn revert.
3929          - The new unit tests found a bug in Git.status_command, change to use git diff --name-status instead.
3930         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3931          - Add tests for added code.
3932
3933 2010-04-10  Adam Barth  <abarth@webkit.org>
3934
3935         Reviewed by Eric Seidel.
3936
3937         new-run-webkit-tests can't find ImageDiff on Windows
3938         https://bugs.webkit.org/show_bug.cgi?id=37403
3939
3940         It turns out the build directory on Windows is structured differently
3941         than it is on other platforms.  Instead of assuming the normal
3942         structure, we should just ask perl to figure it out for us.
3943
3944         * Scripts/webkitpy/layout_tests/port/webkit.py:
3945
3946 2010-04-10  Adam Barth  <abarth@webkit.org>
3947
3948         Rubber-stamped by Eric Seidel.
3949
3950         Change "Gathering files" status line to "Collecting tests".  Gathering
3951         the files sounds silly to me.
3952
3953         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3954
3955 2010-04-10  Adam Barth  <abarth@webkit.org>
3956
3957         Reviewed by Eric Seidel.
3958
3959         Fix bugs to make new-run-webkit-tests almost run on windows
3960         https://bugs.webkit.org/show_bug.cgi?id=37400
3961
3962         Fix some minor bugs that prevent new-run-webkit-tests from being run on
3963         Windows.  I still haven't run it to completion, but I'm getting
3964         further.
3965
3966         * Scripts/webkitpy/layout_tests/port/factory.py:
3967         * Scripts/webkitpy/layout_tests/port/webkit.py:
3968
3969 2010-04-10  Robert Hogan  <robert@webkit.org>
3970
3971         Reviewed by Kenneth Rohde Christiansen.
3972
3973         Refactor Qt DRT support in QtWebKit
3974
3975         Update Qt DRT to use new DumpRenderTreeSupportQt static class.
3976
3977         https://bugs.webkit.org/show_bug.cgi?id=35844
3978
3979         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3980         (WebCore::DumpRenderTree::DumpRenderTree):
3981         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3982         (WebCore::DumpRenderTree::dumpFramesAsText):
3983         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3984         * DumpRenderTree/qt/GCControllerQt.cpp:
3985         (GCController::collect):
3986         (GCController::collectOnAlternateThread):
3987         (GCController::getJSObjectCount):
3988         * DumpRenderTree/qt/GCControllerQt.h:
3989         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3990         (LayoutTestController::counterValueForElementById):
3991         (LayoutTestController::setViewModeMediaFeature):
3992         (LayoutTestController::setMediaType):
3993         (LayoutTestController::closeWebInspector):
3994         (LayoutTestController::showWebInspector):
3995         (LayoutTestController::evaluateInWebInspector):
3996         (LayoutTestController::setFrameFlatteningEnabled):
3997         (LayoutTestController::setJavaScriptProfilingEnabled):
3998         (LayoutTestController::setTimelineProfilingEnabled):
3999         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4000         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4001         (LayoutTestController::sampleSVGAnimationForElementAtTime):
4002         (LayoutTestController::numberOfActiveAnimations):
4003         (LayoutTestController::whiteListAccessFromOrigin):
4004         (LayoutTestController::setCaretBrowsingEnabled):
4005         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
4006         (LayoutTestController::workerThreadCount):
4007         (LayoutTestController::pageNumberForElementById):
4008         (LayoutTestController::numberOfPages):
4009         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4010
4011 2010-04-10  Adam Barth  <abarth@webkit.org>
4012
4013         Reviewed by Eric Seidel.
4014
4015         Move global queue log to the logs directory so it survives git clean -f
4016         https://bugs.webkit.org/show_bug.cgi?id=37395
4017
4018         * Scripts/webkitpy/tool/commands/queues.py:
4019
4020 2010-04-10  Adam Barth  <abarth@webkit.org>
4021
4022         Reviewed by Eric Seidel.
4023
4024         SheriffBot should spam when it encounters errors
4025         https://bugs.webkit.org/show_bug.cgi?id=37329
4026
4027         We need to always update the status server so we don't get stuck in a
4028         spam loop.  I tried writing a test for this change, but it kind of
4029         got out of control.  We need a better way to do failure injection.
4030
4031         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4032
4033 2010-04-10  Adam Barth  <abarth@webkit.org>
4034
4035         Unreviewed attempt to fix the Chromium Mac canary.
4036
4037         * Scripts/webkitpy/common/config/ports.py:
4038         * Scripts/webkitpy/common/config/ports_unittest.py:
4039         * Scripts/webkitpy/common/system/executive.py:
4040
4041 2010-04-10  Adam Barth  <abarth@webkit.org>
4042
4043         Unreviewed.
4044
4045         Add the Apache bits to win.py for new-run-webkit-tests
4046         https://bugs.webkit.org/show_bug.cgi?id=37397
4047
4048         I still have run this yet, but I looked around to figure out what the
4049         various paths appear to be.  I'll figure out a way to remove the
4050         copy/paste code in a future patch.
4051
4052         * Scripts/webkitpy/layout_tests/port/mac.py:
4053         * Scripts/webkitpy/layout_tests/port/webkit.py:
4054         * Scripts/webkitpy/layout_tests/port/win.py:
4055
4056 2010-04-10  Adam Barth  <abarth@webkit.org>
4057
4058         Reviewed by Eric Seidel.
4059
4060         Sketch out the win port for new-run-webkit-tests
4061         https://bugs.webkit.org/show_bug.cgi?id=37393
4062
4063         I haven't tried running this yet, but we've got to start somewhere.
4064
4065         * Scripts/webkitpy/layout_tests/port/factory.py:
4066         * Scripts/webkitpy/layout_tests/port/mac.py:
4067         * Scripts/webkitpy/layout_tests/port/webkit.py:
4068         * Scripts/webkitpy/layout_tests/port/win.py: Added.
4069
4070 2010-04-10  Ojan Vafai  <ojan@chromium.org>
4071
4072         Reviewed by Adam Barth.
4073
4074         webkit-patch land should not build and test by default
4075         https://bugs.webkit.org/show_bug.cgi?id=33631
4076
4077         Reverse the sense of --no-build and --no-test to be --build and --test.
4078         Also, decoupled the build and test options so you can test without
4079         building.
4080
4081         (Patch manngled by Adam Barth.  All bugs are his fault.)
4082
4083         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4084         * Scripts/webkitpy/tool/commands/queues.py:
4085         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4086         * Scripts/webkitpy/tool/steps/options.py:
4087         * Scripts/webkitpy/tool/steps/runtests.py:
4088
4089 2010-04-10  Adam Barth  <abarth@webkit.org>
4090
4091         Reviewed by Eric Seidel.
4092
4093         Factor WebKitPort out of MacPort to allow for WinPort
4094         https://bugs.webkit.org/show_bug.cgi?id=37388
4095
4096         The split is a bit of a guess.  We might have to adjust things once we
4097         actually have a second port to work with.
4098
4099         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4100         * Scripts/webkitpy/layout_tests/port/mac.py:
4101         * Scripts/webkitpy/layout_tests/port/webkit.py: Added.
4102         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
4103
4104 2010-04-10  Adam Barth  <abarth@webkit.org>
4105
4106         Reviewed by Eric Seidel.
4107
4108         run_webkit_tests.py shouldn't have platform-specific logic
4109         https://bugs.webkit.org/show_bug.cgi?id=37387
4110
4111         Dirk Pranke pointed out that my last patch was wrong because I
4112         introduced platform-specific logic into run_webkit_tests.py, limiting
4113         the parallelism in Chromium to work around a bug in the main Mac port.
4114
4115         * Scripts/webkitpy/common/system/executive.py:
4116             - Fix a typo pointed out by Chris Jerdonek.
4117         * Scripts/webkitpy/layout_tests/port/base.py:
4118         * Scripts/webkitpy/layout_tests/port/mac.py:
4119         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4120
4121 2010-04-10  Robert Hogan  <robert@webkit.org>
4122
4123         Unreviewed fix to regressions in r57416.
4124
4125         [Qt] Fix regressions in http/tests/navigation from r57416
4126
4127         Reset willSendRequestReturnsNullOnRedirect after each test to
4128         prevent it leaking to subsequent tests.
4129
4130         Error pointed out by Jakub Wieczorek.
4131
4132         https://bugs.webkit.org/show_bug.cgi?id=37237
4133
4134         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4135         (LayoutTestController::reset):
4136
4137 2010-04-11  Robert Hogan  <robert@webkit.org>
4138
4139         Reviewed by Simon Hausmann.
4140
4141         [Qt] Update layoutTestController.DumpResourceLoadCallbacks to match other ports.
4142
4143         Add support for layoutTestController.setWillSendRequestReturnsNullOnRedirect to Qt DRT.
4144         Prevent dumping resource load callbacks once layout test has dumped.
4145
4146         https://bugs.webkit.org/show_bug.cgi?id=37237
4147
4148         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4149         (WebCore::DumpRenderTree::dump):
4150         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4151         (LayoutTestController::setWillSendRequestReturnsNullOnRedirect):
4152         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4153
4154 2010-04-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4155
4156         Reviewed by Kenneth Rohde Christiansen.
4157
4158         [Qt] Implement Desktop Notifications API for QtWebKit
4159         https://bugs.webkit.org/show_bug.cgi?id=35503
4160
4161         DRT stubs for notification. Enables to run and pass
4162         3 (currently disabled) tests.
4163
4164         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4165         (LayoutTestController::LayoutTestController):
4166         (LayoutTestController::grantDesktopNotificationPermission):
4167         (LayoutTestController::checkDesktopNotificationPermission):
4168         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4169
4170 2010-04-09  Dumitru Daniliuc  <dumi@chromium.org>
4171
4172         Unreviewed, another change to executive.py to make it run with
4173         python 2.4.
4174
4175         * Scripts/webkitpy/common/