2fb13f1d601e93b05f428bb5f08c2f96e6b3d789
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2
3         Reviewed by Alp Toker.
4
5         http://bugs.webkit.org/show_bug.cgi?id=16955
6         Get errors when cross-compile webkit-gtk
7
8         * GNUmakefile.am: Removed ICU_CFLAGS 
9
10 2008-01-21  Darin Adler  <darin@apple.com>
11
12         Reviewed by Mitz and Adam.
13
14         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
15         sorting speed by doing all sort criteria in a single pass instead of three sorts.
16
17 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
18
19         Reviewed by Holger.
20
21         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
22         
23         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
24         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
25         and make the return value depend on whether we successfully determined a focusable
26         node or not.
27         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
28         if we could not handle the focus chain ourselves.
29         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
30         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
31         used to control the situation of stepping out of the focus chain inside the page.
32         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
33         The layout tests expect this to be disabled but for the user it seems sensible to have it
34         on by default, hence the default in qwebsettings.cpp
35         
36
37         * DumpRenderTree/qt/DumpRenderTree.cpp:
38         (WebCore::WebPage::WebPage):
39
40 2008-01-19  Mark Rowe  <mrowe@apple.com>
41
42         Reviewed by Alp Toker.
43
44         Allow the --http flag to run-webkit-tests to override
45         the default behaviour of disabling HTTP tests for Qt,
46         Gtk and Wx.
47
48         * Scripts/run-webkit-tests:
49
50 2008-01-19  David Kilzer  <ddkilzer@apple.com>
51
52         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
53
54         Reviewed by Darin.
55
56         We now touch a check-for-global-initializers.timestamp file in
57         the TARGET_TEMP_DIR directory to determine when new object files
58         have been compiled and thus need to be checked.  If the timestamp
59         file doesn't exist, all object files will be checked.
60
61         Previously the modification time of the "executable" (the
62         framework binary, e.g., WebKit.framework/WebKit) was used, but
63         since this was the last file modified at the end of the compile
64         phase, no object files would ever get checked!
65
66         Also added JSCustomSQLTransactionCallback.o to the list of files
67         since it has static initializers in Debug builds of WebCore.
68
69         * Scripts/check-for-global-initializers:
70
71 2008-01-18  Adam Roben  <aroben@apple.com>
72
73         Build fix
74
75         * Scripts/build-webkit:
76
77 2008-01-18  Beth Dakin  <bdakin@apple.com>
78
79         Reviewed by Oliver.
80
81         Update build-webkit to account for foreign-object being disabled by 
82         default.
83
84         * Scripts/build-webkit:
85
86 2008-01-18  Adam Roben  <aroben@apple.com>
87
88         Updated for method renames
89
90         Reviewed by Adele.
91
92         * DumpRenderTree/mac/FrameLoadDelegate.mm:
93         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
94         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
95         (LayoutTestController::setMainFrameIsFirstResponder):
96         (LayoutTestController::setWindowIsKey):
97         * DumpRenderTree/mac/UIDelegate.mm:
98         (-[UIDelegate webViewFocus:]):
99         * DumpRenderTree/win/FrameLoadDelegate.cpp:
100         (FrameLoadDelegate::didCommitLoadForFrame):
101
102 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
103
104         Reviewed by Adam Roben.
105
106         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
107         between DRT and TestNetscapePlugin.
108
109         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
110         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
111
112 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
113
114         Reviewed by Holger.
115
116         Fix fast/dom/Window/window-resize.html
117         
118         In DRT connect the page's geometryChangeRequest signal to a slot that
119         sets the geometry of the view widget.
120         
121
122         * DumpRenderTree/qt/DumpRenderTree.cpp:
123         (WebCore::WebPage::setViewGeometry):
124         (WebCore::WebPage::WebPage):
125
126 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
127
128         Build fix.
129
130         * Drosera/DroseraWin.make:
131
132 2008-01-17  Darin Adler  <darin@apple.com>
133
134         * Scripts/run-webkit-tests: Fixed a bug number.
135
136 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
137
138         Reviewed by Adam Roben.
139
140         http://bugs.webkit.org/show_bug.cgi?id=16908
141         run-webkit-tests complains about missing FindSafari.exe
142
143         * Scripts/webkitdirs.pm: Append _debug as appropriate.
144
145 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
146
147         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
148         
149         Rubber-stamped by Jon Honeycutt.
150
151         * DumpRenderTree/win/DumpRenderTree.vcproj:
152
153 2008-01-16  Alp Toker  <alp@atoker.com>
154
155         Reviewed by Mark Rowe.
156
157         http://bugs.webkit.org/show_bug.cgi?id=16218
158         [GTK] API: Should this entry point be called go_back rather than go_backward?
159
160         Track back/forward API changes in the tools.
161
162         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
163         (BackForwardItem::invoke):
164         * GtkLauncher/main.c:
165         (go_back_cb):
166
167 2008-01-16  Adam Roben  <aroben@apple.com>
168
169         Windows build fix after r29488
170
171         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
172         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
173         expects to find the plugin.
174
175 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
176
177         Reviewed by Sam Weinig.
178         
179         Fixed the waitUntilDone watchdog timer -- the old code never added the
180         timer to the run loop, so it didn't do anything.
181
182         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
183         (LayoutTestController::setWaitToDump):
184         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
185         (LayoutTestController::setWaitToDump):
186
187 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
188
189         Use shared vsprops for most vcproj properties.
190         
191         Reviewed by Darin.
192
193         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
194         * DumpRenderTree/win/DumpRenderTree.vcproj:
195         * DumpRenderTree/win/ImageDiff.vcproj:
196         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
197         * FindSafari/FindSafari.vcproj:
198
199 2008-01-14  Stephanie  <slewis@apple.com>
200
201        Reviewed by NOBODY.
202   
203        revert accidental character.
204
205        * Scripts/run-webkit-tests:
206
207 2008-01-14  Stephanie  <slewis@apple.com>
208
209         RS=Oliver
210
211         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
212
213         * Scripts/run-webkit-tests:
214
215 2008-01-14  Darin Adler  <darin@apple.com>
216
217         * Scripts/do-webcore-rename: Queue up another rename.
218
219 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
220
221         Reviewed by Darin.
222
223         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
224         the tests were ran.
225         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
226
227         * Scripts/run-webkit-tests:
228
229 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
230
231         Reviewed by Darin.
232
233         * Randomize tests array to spot test cases where the results depends on the order
234         the tests are ran.
235         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
236
237         * Scripts/run-webkit-tests:
238
239 2008-01-14  Darin Adler  <darin@apple.com>
240
241         * Scripts/run-webkit-tests: More ignore list tweaking.
242
243 2008-01-14  Darin Adler  <darin@apple.com>
244
245         * Scripts/run-webkit-tests: Add another leak to the ignore list.
246
247 2008-01-14  Dan Bernstein  <mitz@apple.com>
248
249         Reviewed by Adam Roben.
250
251         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
252           build bots
253
254         * DumpRenderTree/win/DumpRenderTree.cpp:
255         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
256
257 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
258
259         Share common files across projects.
260         
261         Unify vsprops files
262         Debug:          common.vsprops, debug.vsprops
263         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
264         Release:        common.vsprops, release.vsprops
265         
266         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
267         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
268
269         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
270
271         Reviewed by Adam Roben.
272
273         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
274         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
275         * Drosera/win/Drosera.vcproj/VERSION: Removed.
276         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
277         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
278         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
279         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
280         * DumpRenderTree/win/DumpRenderTree.vcproj:
281         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
282         * DumpRenderTree/win/debug.vsprops: Removed.
283         * DumpRenderTree/win/debug_internal.vsprops: Removed.
284         * DumpRenderTree/win/release.vsprops: Removed.
285
286 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
287
288         Reviewed by Maciej.
289
290         - http://bugs.webkit.org/show_bug.cgi?id=16314
291           Script to launch Drosera
292
293         * Scripts/gdb-drosera: Added.
294         * Scripts/run-drosera: Added.
295         * Scripts/run-drosera-nightly.cmd: Added.
296         * Scripts/webkitdirs.pm: Added runDrosera function.
297
298 2008-01-13  Dan Bernstein  <mitz@apple.com>
299
300         - fix breakage due to last-minute change
301
302         * DumpRenderTree/win/DumpRenderTree.cpp:
303         (runTest): Declare the loop variable.
304
305 2008-01-13  Dan Bernstein  <mitz@apple.com>
306
307         Reviewed by Adam Roben.
308
309         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
310
311         * DumpRenderTree/win/DumpRenderTree.cpp:
312         (DumpRenderTreeWndProc):
313         (initialize):
314         (dumpBackForwardList):
315         (dumpBackForwardListForAllWindows):
316         (dump):
317         (resetWebViewToConsistentStateBeforeTesting): Factored out of
318         runTest().
319         (runTest):
320         (allWindows): Added. Returns a vector of all open windows.
321         (windowToWebViewMap): Added. Returns a map from open windows to their
322         WebViews.
323         (createWebViewAndOffscreenWindow): Factored out of main() to be
324         reusable for creating extra windows.
325         (main):
326         * DumpRenderTree/win/DumpRenderTreeWin.h:
327         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
328         (LayoutTestController::windowCount): Implemented.
329         * DumpRenderTree/win/UIDelegate.cpp:
330         (UIDelegate::createWebViewWithRequest): Implemented.
331         (UIDelegate::webViewClose): Implemented.
332         * DumpRenderTree/win/UIDelegate.h:
333
334 2008-01-12  Alp Toker  <alp@atoker.com>
335
336         Reviewed by Mark Rowe.
337
338         Hide non-public symbols in GTK+/autotools release builds.
339
340         * GNUmakefile.am:
341
342 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
343
344         Reviewed by Ap.
345
346         * Make launching of the WebKit httpd work on GNU/Debian/Linux
347         
348         The configuration of Apache2 and installation does not depend on
349         the kernel but on the distribution policy. Make launching of httpd
350         work for Debian derived distributions.
351
352         * Scripts/run-webkit-httpd:
353         * Scripts/run-webkit-tests:
354         * Scripts/webkitdirs.pm:
355
356 2008-01-12  Mark Rowe  <mrowe@apple.com>
357
358         Reviewed by Maciej Stachowiak.
359
360         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
361
362         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
363         match the callers expectations that it can take ownership of the string.
364
365 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
366
367         Reviewed by Adam Roben.
368
369         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
370
371         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
372         as these are only posted because the test window is not a normal visible one, and
373         they confuse drag&drop machinery.
374
375 2008-01-11  Adam Roben  <aroben@apple.com>
376
377         Fix a crash when pathToLocalResource fails and a leak
378
379         Reviewed by Darin.
380
381         * DumpRenderTree/LayoutTestController.cpp:
382         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
383         sure not to pass null to JSValueMakeString.
384         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
385         (LayoutTestController::pathToLocalResource): Print an error message if
386         the conversion fails so it's clear what happened.
387
388 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
389
390         Reviewed by John Sullivan.
391
392         * DumpRenderTree/mac/GCControllerMac.mm:
393         (GCController::collectOnAlternateThread): Updated for name change.
394
395 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
396
397         wx build fix. Don't build dftables any longer since it's now a Perl
398         script.
399
400         * wx/build-wxwebkit:
401
402 2008-01-10  Sam Weinig  <sam@webkit.org>
403
404         Reviewed by Anders Carlsson.
405
406         Make DRT track open windows instead of allocated windows so that
407         we can avoid ASSERTION due to late deallocs out of our control.
408
409         * DumpRenderTree/mac/DumpRenderTree.mm:
410         (dumpBackForwardListForAllWindows):
411         (runTest):
412         * DumpRenderTree/mac/DumpRenderTreeMac.h:
413         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
414         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
415         (+[DumpRenderTreeWindow openWindows]):
416         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
417         (-[DumpRenderTreeWindow close]):
418         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
419         (LayoutTestController::windowCount):
420
421 2008-01-10  Ada Chan  <adachan@apple.com>
422
423         Meta key is not the same as Alt key on windows.
424
425         Reviewed by Darin.
426
427         * DumpRenderTree/win/EventSender.cpp:
428         (keyDownCallback):
429
430 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
431
432         Reviewed by Darin, Sam and Adam.
433
434         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
435         link in gmail message displays JavaScript alert falsely complaining
436         about pop-up blocking.
437         - Added the ability to enable the pop-up blocker via the
438         LayoutTestController.
439
440         * DumpRenderTree/LayoutTestController.cpp:
441         (setPopupBlockingEnabledCallback):
442         (LayoutTestController::staticFunctions):
443         * DumpRenderTree/LayoutTestController.h:
444         * DumpRenderTree/mac/DumpRenderTree.mm:
445         (setDefaultsToConsistentValuesForTesting):
446         (resetWebViewToConsistentStateBeforeTesting):
447         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
448         (LayoutTestController::setPopupBlockingEnabled):
449
450 2008-01-10  Lars Knoll  <lars@trolltech.com>
451
452         Reviewed by Simon.
453
454         rename QWebPageHistory to QWebHistory.
455         
456
457         * DumpRenderTree/qt/jsobjects.cpp:
458
459 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
460
461         Reviewed by Darin.
462         
463         - add some more renames, adjust some
464
465         * Scripts/do-webcore-rename:
466
467 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
468
469         Reviewed by Oliver.
470
471         Enable SVG Fonts support by default.
472
473         * Scripts/build-webkit:
474
475 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
476
477         Reviewed by Adam.
478
479         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
480         DRT doesn't handle platform specific pixel test results correctly.
481
482         <test>-expected.txt files and <test>-expected.png files may now live
483         in different directories (ie. a cross-platform <test>-expected.txt file
484         and a platform-specific <test>-expected.png file).
485
486         * Scripts/run-webkit-tests:
487
488 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
489
490         Reviewed by Darin.
491
492         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
493         DRT did not correctly handle printing the '\0' char.  Now it does.
494
495         * DumpRenderTree/win/DumpRenderTree.cpp:
496         (dumpFramesAsText):
497         (dump):
498
499 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
500
501         Reviewed by Lars.
502
503         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
504         
505
506         * DumpRenderTree/qt/main.cpp:
507         * DumpRenderTree/qt/testplugin.cpp:
508         * DumpRenderTree/qt/testplugin.h:
509
510 2008-01-05  Mark Rowe  <mrowe@apple.com>
511
512         Reviewed by Alp Toker.
513
514         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
515
516         * DumpRenderTree/gtk/DumpRenderTree.cpp:
517         (processWork): Process pending work.
518         (webViewLoadFinished): Schedule processing of pending work.
519         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
520
521 2008-01-05  Darin Adler  <darin@apple.com>
522
523         * Scripts/do-webcore-rename: Some more renaming plans.
524
525 2008-01-04  Alice Liu  <alice.liu@apple.com>
526
527         Reviewed by Alexey and Darin.
528
529         Adding "home" and "end" to DRT's keydown since
530         DOM key events can't handle keyIdentifiers at this point. 
531
532         * DumpRenderTree/mac/EventSendingController.mm:
533         (-[EventSendingController keyDown:withModifiers:]):
534         * DumpRenderTree/win/EventSender.cpp:
535         (keyDownCallback):
536
537 2008-01-04  Lars Knoll  <lars@trolltech.com>
538
539         Reviewed by Simon.
540
541         fix DRT after the changes to QWebPage.
542         
543         The great thing is that we actually don't have
544         any regressions from the QWebPage change :)
545         
546
547         * DumpRenderTree/qt/DumpRenderTree.cpp:
548         (WebCore::DumpRenderTree::DumpRenderTree):
549
550 2008-01-04  Lars Knoll  <lars@trolltech.com>
551
552         Reviewed by Simon.
553
554         make QWebPage a QObject and get things to compile.
555         
556         Nothing works currently though.
557         
558
559         * DumpRenderTree/qt/DumpRenderTree.cpp:
560         (WebCore::DumpRenderTree::DumpRenderTree):
561
562 2008-01-04  Lars Knoll  <lars@trolltech.com>
563
564         Reviewed by Simon.
565
566         take a QString as identifier in QWebFrame::addToJSWindowObject.
567
568         * DumpRenderTree/qt/DumpRenderTree.cpp:
569         (WebCore::DumpRenderTree::initJSObjects):
570
571 2008-01-04  Alp Toker  <alp@atoker.com>
572
573         GTK+ DRT build fix for breakage introduced in r29149.
574
575         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
576         (LayoutTestController::execCommand):
577
578 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
579
580         Reviewed by Darin.
581
582         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
583
584         Added layoutTestController.execCommand to access editor commands that are not available
585         via document.execCommand.
586
587         * DumpRenderTree/LayoutTestController.cpp:
588         (execCommandCallback):
589         (LayoutTestController::staticFunctions):
590         * DumpRenderTree/LayoutTestController.h:
591         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
592         (LayoutTestController::execCommand):
593         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
594         (LayoutTestController::queueLoad):
595         (LayoutTestController::execCommand):
596
597 2008-01-03  Alice Liu  <alice.liu@apple.com>
598
599         Reviewed by Darin, Mitz.
600
601         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
602
603         the clickcount should not increase if the last click was at a different location.  it's a new click.
604
605         * DumpRenderTree/mac/DumpRenderTree.mm:
606         (runTest):
607         * DumpRenderTree/mac/EventSendingController.h:
608         * DumpRenderTree/mac/EventSendingController.mm:
609         (-[EventSendingController mouseDown]):
610         (-[EventSendingController mouseUp]):
611
612 2008-01-03  Darin Adler  <darin@apple.com>
613
614         Reviewed by Adam.
615
616         * Scripts/update-webkit: Make this work a little better for the people at Apple
617         who have a directory named Internal.
618
619 2008-01-03  Adam Roben  <aroben@apple.com>
620
621         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
622
623         Rubberstamped by Mark.
624
625         * Scripts/update-webkit-auxiliary-libs:
626
627 2008-01-03  Adam Roben  <aroben@apple.com>
628
629         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
630
631         http://bugs.webkit.org/show_bug.cgi?id=15663
632
633         Added a fuzz factor into the Last-Modified comparison for downloading
634         WebKitAuxiliaryLibrary.zip.
635
636         The zip file is served from a set of mirrors who give Last-Modified
637         times that are off by 1-3 seconds from each other. This was causing
638         the build bots to redownload WebKitAuxiliaryLibrary for every build,
639         which would then cause all of WebCore to rebuild each time.
640
641         Reviewed by Mark.
642
643         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
644         at least 30 seconds newer than the old one -- otherwise we assume that
645         the difference in time is due to the mirrors being slightly offset
646         from each other.
647         (sub lastModifiedToUnixTime): Added.
648
649 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
650
651         Windows build fix.
652
653         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
654
655 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
656
657         Reviewed by Lars.
658
659         Moved QWebPage::open to QWebFrame::load and added setHtml.
660         
661
662         * DumpRenderTree/qt/DumpRenderTree.cpp:
663         (WebCore::DumpRenderTree::open):
664
665 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
666
667         Reviewed by Lars.
668
669         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
670         
671
672         * DumpRenderTree/qt/DumpRenderTree.cpp:
673         (WebCore::DumpRenderTree::DumpRenderTree):
674
675 2008-01-02  Sam Weinig  <sam@webkit.org>
676
677         * Scripts/do-webcore-rename: Yet more renaming ideas.
678
679 2008-01-02  Darin Adler  <darin@apple.com>
680
681         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
682
683 2008-01-02  Alice Liu  <alice.liu@apple.com>
684
685         Reviewed by Sam Weinig.
686
687         fixing assertion hit with editing/selection/move-begin-end.html
688
689         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
690         * DumpRenderTree/win/DumpRenderTree.vcproj:
691         * DumpRenderTree/win/EventSender.cpp:
692         (keyDownCallback):
693         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
694
695 2008-01-02  Darin Adler  <darin@apple.com>
696
697         * Scripts/do-webcore-rename: Some more name change plans.
698
699 2008-01-02  Alice Liu  <alice.liu@apple.com>
700
701         Reviewed by Maciej.
702
703         Added handling for page up and page down in EventSender
704
705         * DumpRenderTree/mac/EventSendingController.mm:
706         (-[EventSendingController keyDown:withModifiers:]):
707         * DumpRenderTree/win/EventSender.cpp:
708         (keyDownCallback):
709
710 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
711
712         Reviewed by Darin.
713
714         Fix fast/events/arrow-keys-on-body.html for real.
715
716         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
717
718 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
719
720         Reviewed by Darin.
721
722         http://bugs.webkit.org/show_bug.cgi?id=16674
723         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
724
725         * Scripts/run-launcher:
726
727 2007-12-31  Darin Adler  <darin@apple.com>
728
729         Suggested by Antti.
730
731         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
732         we get it installed on the build bots.
733
734 2007-12-30  Eric Seidel  <eric@webkit.org>
735
736         Reviewed by Sam.
737
738         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
739
740 2007-12-29  Darin Adler  <darin@apple.com>
741
742         Reviewed by Oliver.
743
744         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
745           leak bot shows createCStringFromNPVariant result leaking
746
747         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
748         (pluginInvoke): Added a missing free.
749
750 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
751
752         Reviewed by Alp Toker.
753
754         http://bugs.webkit.org/show_bug.cgi?id=16390
755         Use autotools or GNU make as the build system for the GTK port
756
757         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
758         * GNUmakefile.am: Added.
759
760 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
761
762         Reviewed by Oliver.
763
764         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
765
766         * DumpRenderTree/win/EventSender.cpp:
767         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
768         of 1, even though WebKit currently ignores it.
769
770 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
771
772         wx buildbot fix. Update libpng dl script to the latest version.
773
774         * wx/install-unix-extras:
775
776 2007-12-22  Antti Koivisto  <antti@apple.com>
777
778         Fix a typo.
779
780         * Scripts/webkitdirs.pm:
781
782 2007-12-21  Sam Weinig  <sam@webkit.org>
783
784         Reviewed by Mark Rowe.
785
786         - Disable the back/forward cache using the new WebPreferences API
787           instead of through the BackForwardList.  This makes us match what
788           we do on Windows.
789
790         * DumpRenderTree/mac/DumpRenderTree.mm:
791         (createWebViewAndOffscreenWindow):
792         (setDefaultsToConsistentValuesForTesting):
793
794 2007-12-21  Dan Bernstein  <mitz@apple.com>
795
796         Reviewed by Mark Rowe.
797
798         - disable the back/forward cache in Windows DumpRenderTree. It is
799           already disabled in Mac DumpRenderTree.
800
801         * DumpRenderTree/win/DumpRenderTree.cpp:
802         (initializePreferences):
803
804 2007-12-13  Antti Koivisto  <antti@apple.com>
805
806         Reviewed by Darin and Steve.
807         
808         - check for QuickTime SDK on Windows.
809         - build media support on Windows by default
810
811         * Scripts/build-webkit:
812         * Scripts/webkitdirs.pm:
813
814 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
815
816         Build script fix for buildbot.
817
818         * wx/build-wxwebkit:
819
820 2007-12-20  Eric Seidel  <eric@webkit.org>
821
822         Reviewed by mjs.
823
824         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
825
826 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
827
828         Reviewed by Steve.
829
830         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
831         WebKit.
832
833         - Drosera and Safari need to use the same ProgIDs in order for
834         CoCreateInstance to work properly.  The most robust way to do this is
835         for WebKit to dynamically publish those ProgIDs.
836
837         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
838         (DebuggerClient::createWebViewWithRequest):
839         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
840         statics.
841         (Drosera::initUI):
842         (Drosera::attach):
843         (Drosera::attemptToCreateServerConnection):
844         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
845         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
846         make use of the published ProgIDs.
847         (ServerConnection::attemptToCreateServerConnection):
848
849 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
850
851         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
852         - Build bot and leak fix.
853
854         * DumpRenderTree/LayoutTestController.cpp:
855         (pathToLocalResourceCallback):
856
857 2007-12-19  David Kilzer  <ddkilzer@apple.com>
858
859         Make svn-apply/svn-unapply work with patches from git-format-patch.
860
861         Reviewed by Darin.
862
863         * Scripts/svn-apply:
864         (patch): If 'Index:' can't be found in the text passed in, print it
865         out with a warning and return early.
866         * Scripts/svn-unapply:
867         (patch): Ditto.
868
869 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
870
871         Reviewed by Alp Toker.
872
873         Build related fixes.
874
875         * wx/build-wxwebkit:
876         - Check to make sure the user is running a supported wx port
877         - More robust checks for Cygwin
878         - Only run install-unix-extras on Mac, it's not the right solution
879           for Linux distros.
880         - Remove outdated Linux instructions after successful build
881         - Clean Bakefile-generated files during a clean operation
882
883 2007-12-18  Darin Adler  <darin@apple.com>
884
885         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
886
887 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
888
889         Add script to run Drosera as part of the nightly.
890         
891         Reviewed by Kevin M.
892
893         * Scripts/run-drosera.cmd: Added.
894
895 2007-12-18  Darin Adler  <darin@apple.com>
896
897         * Scripts/do-webcore-rename: Remove a stray K.
898
899 2007-12-18  Darin Adler  <darin@apple.com>
900
901         * Scripts/do-webcore-rename: Plan more renaming.
902
903 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
904
905         Reviewed by Alp Toker.
906
907         http://bugs.webkit.org/show_bug.cgi?id=16042
908         [GTK] Eliminate webkit_init()
909
910         Moving webkit initialization to WebView class init.
911
912         * DumpRenderTree/gtk/DumpRenderTree.cpp:
913         (main):
914         * GtkLauncher/main.c:
915         (main):
916
917 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
918
919         Reviewed by Alp Toker.
920
921         http://bugs.webkit.org/show_bug.cgi?id=13542
922         gdklauncher doesnt change URL in adress GTKEntry.
923
924         * GtkLauncher/main.c:
925         (load_commit_cb): added
926         (title_change_cb):
927         (create_browser):
928
929 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
930
931         Reviewed by Adam Roben.
932
933         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
934
935         * FindSafari/FindSafari.cpp:
936         (_tmain):
937
938 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
939
940         Reviewed by Adam Roben.
941
942         http://bugs.webkit.org/show_bug.cgi?id=16315
943         FindSafari needs a path-only option.
944
945         * FindSafari/FindSafari.cpp:
946         (_tmain):
947
948 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
949
950         Reviewed by Darin.
951
952         http://bugs.webkit.org/show_bug.cgi?id=16462
953         REGRESSION: access keys broken on Windows
954
955         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
956         if Alt is pressed.
957
958 2007-12-15  Sam Weinig  <sam@webkit.org>
959
960         Reviewed by Mark Rowe.
961
962         Fix urlSuitableForTestResult to correctly identify wstring::npos as
963         the case when wstring.find doesn't find anything.
964
965         * DumpRenderTree/win/DumpRenderTree.cpp:
966         (urlSuitableForTestResult):
967
968 2007-12-15  Alp Toker  <alp@atoker.com>
969
970         GTK+ DRT build fix for GLib < 2.14.
971
972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
973         (LayoutTestController::setWaitToDump):
974
975 2007-12-05  Mark Rowe  <mrowe@apple.com>
976
977         Reviewed by Alp Toker.
978
979         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
980         many layout tests from hanging while waiting on user responses to dialogs.
981
982         * DumpRenderTree/gtk/DumpRenderTree.cpp:
983         (invalidateAnyPreviousWaitToDumpWatchdog):
984         (webViewScriptAlert):
985         (webViewScriptPrompt):
986         (webViewScriptConfirm):
987         (main):
988         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
989         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
990         (waitToDumpWatchdogFired):
991         (LayoutTestController::setWaitToDump):
992
993 2007-12-05  Mark Rowe  <mrowe@apple.com>
994
995         Reviewed by Alp Toker.
996
997         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
998
999         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1000         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1001         (dump):
1002         (runTest):
1003         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1004         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1005         work queue is empty.
1006         (webViewWindowObjectCleared): Set up window.layoutTestController.
1007         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1008         (main): Hook up the new signals.
1009         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1010         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1011         dumping multiple times.
1012         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1013         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1014
1015 2007-12-14  Anders Carlsson  <andersca@apple.com>
1016
1017         Reviewed by Brady.
1018
1019         Assert that a web frame that's loading a resource always has either a data source or 
1020         a provisional data source.
1021         
1022         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1023         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1024
1025 2007-12-14  Darin Adler  <darin@apple.com>
1026
1027         - fix mistake causing nearly all tests to fail on Windows
1028
1029         * DumpRenderTree/win/UIDelegate.cpp:
1030         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1031         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1032
1033         * DumpRenderTree/mac/UIDelegate.mm:
1034         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1035         than passing the entire message.
1036
1037 2007-12-14  Darin Adler  <darin@apple.com>
1038
1039         - fix Tiger build
1040
1041         * DumpRenderTree/mac/UIDelegate.mm:
1042         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1043         new-to-Leopard methods.
1044
1045 2007-12-14  Darin Adler  <darin@apple.com>
1046
1047         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1048         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1049         delegate methods here.
1050
1051 2007-12-14  Anders Carlsson  <andersca@apple.com>
1052
1053         Reviewed by Darin and Geoff.
1054
1055         <rdar://problem/5619295> 
1056         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1057         
1058         Add property getting methods to the plug-in.
1059         
1060         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1061         (pluginInvoke):
1062
1063 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1064
1065         Reviewed by Darin.
1066
1067         - Layout test fix for mac. When dumped to the console local file paths
1068         now only show the name of the resource not the whole path.  This is to
1069         make the results machine and OS independent.
1070
1071         * DumpRenderTree/mac/UIDelegate.mm:
1072         (-[UIDelegate webView:addMessageToConsole:]):
1073
1074 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1075
1076         Reviewed by Adam.
1077
1078         - Layout tests fix.  We need a way to remove machine-dependent
1079         information from paths in layout test results. The UIDelegate now does
1080         this.
1081
1082         * DumpRenderTree/DumpRenderTree.h:
1083         * DumpRenderTree/win/DumpRenderTree.cpp:
1084         (urlSuitableForTestResult):
1085         * DumpRenderTree/win/DumpRenderTreeWin.h:
1086         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1087         * DumpRenderTree/win/UIDelegate.cpp:
1088         (UIDelegate::webViewAddMessageToConsole):
1089
1090 2007-12-13  Alp Toker  <alp@atoker.com>
1091
1092         Build fix for DRT breakage introduced in r28690.
1093
1094         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1095         (LayoutTestController::pathToLocalResource):
1096
1097 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1098
1099         Reviewed by Alice and Sam.
1100
1101         - <rdar://5621435> Need a way to specify local resources (being loaded
1102         from HTTP tests) on Windows.
1103         - Implemented pathToLocalResource which exposes the functionality of
1104         converting a given unix path to the correct location on Windows.
1105
1106         * DumpRenderTree/LayoutTestController.cpp:
1107         (pathToLocalResourceCallback):
1108         (LayoutTestController::staticFunctions):
1109         * DumpRenderTree/LayoutTestController.h:
1110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1111         (LayoutTestController::pathToLocalResource):
1112         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1113         (LayoutTestController::pathToLocalResource):
1114
1115 2007-12-12  Anders Carlsson  <andersca@apple.com>
1116
1117         Reviewed by Sam.
1118
1119         <rdar://problem/5132003>
1120         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1121
1122         * DumpRenderTree/win/DumpRenderTree.cpp:
1123         (main):
1124         Set the resource load delegate.
1125         
1126         * DumpRenderTree/win/DumpRenderTree.vcproj:
1127         
1128         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1129         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1130
1131 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1132
1133         Reviewed by Adam Roben.
1134
1135         Fix conversion from double to LPARAM in dispatchMessage().
1136
1137         * DumpRenderTree/win/EventSender.cpp:
1138         (dispatchMessageCallback):
1139
1140 2007-12-11  Dan Bernstein  <mitz@apple.com>
1141
1142         Reviewed by Mark Rowe and Sam Weinig too!
1143
1144         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1145           fonts DumpRenderTree registers.
1146
1147         * DumpRenderTree/win/DumpRenderTree.cpp:
1148         (initialize):
1149
1150 2007-12-11  Brady Eidson  <beidson@apple.com>
1151
1152         Reviewed by Anders
1153
1154         Make DumpRenderTree on mac use its own path for Databases testing
1155
1156         * DumpRenderTree/mac/DumpRenderTree.mm:
1157         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1158           for future DRT-only use, then use it to construct the Databases path and set that default
1159
1160 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1161
1162         Reviewed by Darin.
1163
1164         <rdar://problem/5535636>
1165         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1166
1167         http://bugs.webkit.org/show_bug.cgi?id=13916
1168         JavaScript detects Tab as a character input on a textfield validation
1169
1170         * DumpRenderTree/mac/EventSendingController.mm:
1171         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1172         Dispatch a keyup to better match what happens when a key is physically pressed.
1173
1174         * DumpRenderTree/win/EventSender.cpp:
1175         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1176         returning from keyDown().
1177         (getConstantCallback): Fixed a couple copy/paste mistakes.
1178
1179 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1180
1181         Reviewed by Oliver.
1182
1183         - <rdar://5599845> Drosera: Does not show loal files in the file list
1184         on the left side.
1185
1186         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1187         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1188         so the open source community can build.
1189
1190 2007-12-10  Brady Eidson  <beidson@apple.com>
1191
1192         Rubberstamped by Sam Weinig
1193
1194         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1195
1196         * DumpRenderTree/mac/UIDelegate.mm:
1197         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1198         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1199
1200 2007-12-08  Oliver Hunt  <oliver@apple.com>
1201
1202         Reviewed by Sam W.
1203
1204         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1205         
1206         Fixes <rdar://problem/5620249> Must disable SVG animation
1207         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1208         
1209         In order to allow finer grained control over the set of SVG features
1210         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1211         distinct flags:
1212         ENABLE_SVG_ANIMATION
1213         ENABLE_SVG_FILTERS
1214         ENABLE_SVG_FONTS
1215         ENABLE_SVG_AS_IMAGE
1216         ENABLE_SVG_USE
1217         
1218         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1219         
1220         Script handles all the new build flags, and allows --svg-experimental
1221         to automatically enable all features.
1222
1223         * Scripts/build-webkit:
1224
1225 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1226
1227         Fix version parsing.
1228
1229         Rubber-stamped by Oliver.
1230
1231         * Drosera/win/Drosera.vcproj/auto-version.sh:
1232
1233 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1234
1235         Build modifications for Drosera.
1236
1237         Reviewed by Adam.
1238
1239         * Drosera/DroseraWin.make: Added.
1240         * Drosera/win/Drosera.vcproj/Drosera.rc:
1241         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1242         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1243         * Drosera/win/Drosera.vcproj/VERSION: Added.
1244         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1245
1246 2007-12-06  Adam Roben  <aroben@apple.com>
1247
1248         Explicitly turn on the Mac font ascent hack on Windows
1249
1250         This keeps our font metrics matching those from Mac.
1251
1252         Reviewed by Hyatt.
1253
1254         * DumpRenderTree/win/DumpRenderTree.cpp:
1255         (main):
1256
1257 2007-12-06  Anders Carlsson  <andersca@apple.com>
1258
1259         Rename main.c to main.cpp here too.
1260         
1261         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1262
1263 2007-12-06  Sam Weinig  <sam@webkit.org>
1264
1265         Rubber stamped by Geoff.
1266
1267         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1268
1269 2007-12-06  Darin Adler  <darin@apple.com>
1270
1271         * Scripts/do-webcore-rename: Some more renaming plans.
1272
1273 2007-12-06  Anders Carlsson  <andersca@apple.com>
1274
1275         Restore implementation of testGetIntIdentifier that was accidentally
1276         removed somehow (possibly when I made PluginObject be a cpp file).
1277         
1278         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1279         (pluginInvoke):
1280
1281 2007-12-05  Anders Carlsson  <andersca@apple.com>
1282
1283         Make the entry points extern "C".
1284         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1285         
1286 2007-12-05  Anders Carlsson  <andersca@apple.com>
1287
1288         C++ warning fixes.
1289         
1290         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1291         (NPP_New):
1292         (NPP_Destroy):
1293         (NPP_SetWindow):
1294         (NPP_NewStream):
1295         (NPP_HandleEvent):
1296         (NPP_URLNotify):
1297         (NPP_GetValue):
1298
1299 2007-12-05  Anders Carlsson  <andersca@apple.com>
1300
1301         Add the .cpp files to the TestNetscapePlugIn target.
1302
1303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1304
1305 2007-12-05  Anders Carlsson  <andersca@apple.com>
1306
1307         Reviewed by Geoff.
1308         
1309         Rename the TestNetscapePlugIn .c files to be .cpp.
1310
1311         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1312         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1313         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1314         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1315         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1316         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1317         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1318         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1319
1320 2007-12-05  Adam Roben  <aroben@apple.com>
1321
1322         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1323
1324         This fixes several regression tests.
1325
1326         Reviewed by Alice.
1327
1328         * DumpRenderTree/win/EventSender.cpp:
1329         (keyDownCallback): Virtual keycodes for ASCII characters are always
1330         uppercase, so we need to check the case of the original character
1331         passed in to eventSender.keyDown.
1332
1333 2007-12-05  Adam Roben  <aroben@apple.com>
1334
1335         Learn from Tim's mistakes
1336
1337         * DumpRenderTree/win/DumpRenderTree.cpp:
1338         (runTest): Reset the authorAndUserStylesEnabled preference for each
1339         test.
1340
1341 2007-12-05  Alp Toker  <alp@atoker.com>
1342
1343         Reviewed by Mark Rowe.
1344
1345         Initialize GTK+ and WebKit so the tests can run.
1346
1347         Reorganize the headers a little.
1348
1349         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1350         (main):
1351
1352 2007-12-04  Anders Carlsson  <andersca@apple.com>
1353
1354         Remove IWebScriptScope include.
1355         
1356         * Drosera/win/DebuggerDocumentPlatform.cpp:
1357
1358 2007-12-04  Sam Weinig  <sam@webkit.org>
1359
1360         Rubber stamped by Mark Rowe.
1361
1362         Define CF as platform for mac and revert r28409
1363
1364         * DumpRenderTree/DumpRenderTree.h:
1365         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1366
1367 2007-12-04  Sam Weinig  <sam@webkit.org>
1368
1369         Define CF as platform for windows.
1370
1371         Reviewed by Adam Roben.
1372
1373         * DumpRenderTree/win/DumpRenderTreeWin.h:
1374
1375 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1376
1377         Reviewed by Adam and Darin.
1378
1379         - Removed a needless BSTR cleanup.
1380
1381         * Drosera/win/DebuggerDocumentPlatform.cpp:
1382         (DebuggerDocument::getPlatformCurrentFunctionStack):
1383
1384 2007-11-27  Adam Roben  <aroben@apple.com>
1385
1386         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1387
1388         Reviewed by Maciej.
1389
1390         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1391         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1392
1393 2007-12-04  Alp Toker  <alp@atoker.com>
1394
1395         Prospective Win DRT build fix.
1396
1397         * DumpRenderTree/DumpRenderTree.h:
1398
1399 2007-12-04  Alp Toker  <alp@atoker.com>
1400
1401         Fix a clobbered copyright header.
1402
1403         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1404
1405 2007-12-04  Xan Lopez  <xan@gnome.org>
1406
1407         Reviewed by Alp Toker.
1408
1409         http://bugs.webkit.org/show_bug.cgi?id=15561
1410         GTK port needs DumpRenderTree implementation
1411
1412         Start work on the GTK+ DRT.
1413
1414         This does not work yet, and there are a few lingering style issues
1415         (nothing major) but this patch has been stuck in the bug tracker for
1416         too long already.
1417
1418         * DumpRenderTree/DumpRenderTree.h:
1419         * DumpRenderTree/gtk: Added.
1420         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1421         (autocorrectURL):
1422         (shouldLogFrameLoadDelegates):
1423         (dumpFrameScrollPosition):
1424         (displayWebView):
1425         (appendString):
1426         (dumpFramesAsText):
1427         (dumpRenderTreeAsText):
1428         (dump):
1429         (runTest):
1430         (main):
1431         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1432         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1433         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1434         (GCController::collect):
1435         (GCController::collectOnAlternateThread):
1436         (GCController::getJSObjectCount):
1437         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1438         (LayoutTestController::~LayoutTestController):
1439         (LayoutTestController::addDisallowedURL):
1440         (LayoutTestController::clearBackForwardList):
1441         (LayoutTestController::copyDecodedHostName):
1442         (LayoutTestController::copyEncodedHostName):
1443         (LayoutTestController::display):
1444         (LayoutTestController::keepWebHistory):
1445         (LayoutTestController::notifyDone):
1446         (LayoutTestController::queueBackNavigation):
1447         (LayoutTestController::queueForwardNavigation):
1448         (LayoutTestController::queueLoad):
1449         (LayoutTestController::queueReload):
1450         (LayoutTestController::queueScript):
1451         (LayoutTestController::setAcceptsEditing):
1452         (LayoutTestController::setCustomPolicyDelegate):
1453         (LayoutTestController::setMainFrameIsFirstResponder):
1454         (LayoutTestController::setTabKeyCyclesThroughElements):
1455         (LayoutTestController::setUseDashboardCompatibilityMode):
1456         (LayoutTestController::setUserStyleSheetEnabled):
1457         (LayoutTestController::setUserStyleSheetLocation):
1458         (LayoutTestController::setWindowIsKey):
1459         (LayoutTestController::setWaitToDump):
1460         (LayoutTestController::windowCount):
1461         (LayoutTestController::setPrivateBrowsingEnabled):
1462         (LayoutTestController::setAuthorAndUserStylesEnabled):
1463         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1464         (JSStringCopyUTF8CString):
1465         (LoadItem::invoke):
1466         (ReloadItem::invoke):
1467         (ScriptItem::invoke):
1468         (BackForwardItem::invoke):
1469
1470 2007-12-03  Sam Weinig  <sam@webkit.org>
1471
1472         Move JavaScriptCore thread testing code to pthread specific directory
1473         and remove the dependance on CoreFoundation by using WTF::HashSet.
1474
1475         Reviewed by Geoff and Oliver.
1476
1477         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1478         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1479         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1480         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1481         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1482         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1483         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1484         * DumpRenderTree/pthreads: Added.
1485         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1486         (javaScriptThreads):
1487         (runJavaScriptThread):
1488         (startJavaScriptThreads):
1489         (stopJavaScriptThreads):
1490
1491 2007-12-03  Andrew Bonventre  <andybons@google.com>
1492
1493         Reviewed by Darin Adler.
1494
1495         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1496         Symbol lookup menu broken in debugger view
1497
1498         * Drosera/debugger.js: Fixed javascript error where document property
1499         should have been used instead of contentDocument in switchFunction that
1500         was breaking the select symbol dropdown menu.  This is because
1501         window.frames will return a Window object and not a frame object like
1502         the author was originally expecting.
1503
1504 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1505
1506         Reviewed by Adam.
1507
1508         - <rdar://5618942> Drosera: Console window does not process everything
1509         correctly.
1510         - <rdar://5619005> Drosera: could be sped up by moving the 
1511         WebScriptScope stuff into the WebScriptCallFrame.
1512         - Now the console can correctly process objects and does not receive
1513         notifications from JavaScriptCore about the JavaScript in Drosera's
1514         own process.
1515
1516         * Drosera/win/DebuggerDocumentPlatform.cpp:
1517         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1518         (DebuggerDocument::platformValueForScopeVariableNamed):
1519
1520 2007-12-03  Stephanie  <slewis@apple.com>
1521
1522         Reviewed by Darin.
1523
1524         Check to see if we are building a debug root
1525
1526         * Scripts/check-for-global-initializers: 
1527
1528 2007-12-03  Dan Bernstein  <mitz@apple.com>
1529
1530         Reviewed by Darin Adler.
1531
1532         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1533
1534         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1535         (pluginInvoke):
1536
1537 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1538
1539         Reviewed by Oliver.
1540
1541         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1542         in a more fine-grained manner than eventSender.keyDown().
1543
1544         * DumpRenderTree/win/EventSender.cpp:
1545         (getConstantCallback):
1546         (dispatchMessageCallback):
1547
1548 2007-12-02  Darin Adler  <darin@apple.com>
1549
1550         * Scripts/do-webcore-rename: More planned renaming.
1551
1552 2007-12-02  Sam Weinig  <sam@webkit.org>
1553
1554         Rubber stamped by Anders.
1555
1556         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1557         more uniform results cross platform.
1558
1559         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1560         (-[NSURL _drt_descriptionSuitableForTestResult]):
1561
1562 2007-12-02  Sam Weinig  <sam@webkit.org>
1563
1564         Rubber stamped by Niko.
1565
1566         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1567
1568         * DumpRenderTree/win/DumpRenderTree.cpp:
1569         * DumpRenderTree/win/DumpRenderTree.vcproj:
1570         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1571         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1572         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1573         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1574
1575 2007-12-01  Alp Toker  <alp@atoker.com>
1576
1577         Reviewed by Adam Roben.
1578
1579         Make use of the newly introduced webkit.h convenience header.
1580
1581         * GtkLauncher/main.c:
1582
1583 2007-12-01  Adam Treat  <treat@kde.org>
1584
1585         Reviewed by Simon.
1586
1587         * Check to see if the directory exists and exit if not.
1588
1589         * DumpRenderTree/qt/main.cpp:
1590         (main):
1591
1592 2007-12-01  Adam Treat  <treat@kde.org>
1593
1594         Reviewed by Simon.
1595
1596         * Don't hide symbols when in Debug mode
1597         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1598
1599
1600         * DumpRenderTree/qt/main.cpp:
1601         (messageHandler):
1602
1603 2007-11-30  Alp Toker  <alp@atoker.com>
1604
1605         Reviewed by Adam Roben.
1606
1607         http://bugs.webkit.org/show_bug.cgi?id=15691
1608         [GTK] Public API does not follow GTK+ conventions
1609
1610         Refactor the WebKit/GTK+ public API. Changes:
1611           WebKitPage -> WebKitWebView
1612           WebKitFrame -> WebKitWebFrame
1613
1614         Public API source and header names have been updated to mirror the API
1615         changes.
1616
1617         The API is now kept in WebKit/gtk/WebView to match other ports in the
1618         same class such as Mac and Win.
1619
1620         * GtkLauncher/main.c:
1621         (activate_uri_entry_cb):
1622         (link_hover_cb):
1623         (title_change_cb):
1624         (progress_change_cb):
1625         (go_back_cb):
1626         (go_forward_cb):
1627         (create_browser):
1628         (main):
1629
1630 2007-11-30  Adam Roben  <aroben@apple.com>
1631
1632         Hopefully the final build fix
1633
1634         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1635         pull in WTF's assertion/logging functions.
1636
1637 2007-11-30  Adam Roben  <aroben@apple.com>
1638
1639         Another build fix
1640
1641         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1642         WebKit.lib.
1643
1644 2007-11-30  Adam Roben  <aroben@apple.com>
1645
1646         Debug build fix
1647
1648         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1649         configuration.
1650         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1651         projects.
1652         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1653         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1654         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1655
1656 2007-11-30  Sam Weinig  <sam@webkit.org>
1657
1658         Reviewed by Adam Roben.
1659
1660         Fix drawSelectionRect to actually draw the selection rect.
1661
1662         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1663         (drawSelectionRect):
1664
1665 2007-11-30  Darin Adler  <darin@apple.com>
1666
1667         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1668
1669 2007-11-30  Darin Adler  <darin@apple.com>
1670
1671         * Scripts/do-webcore-rename: Get ready for some future renaming.
1672
1673 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1674
1675         Reviewed by Adam.
1676
1677         - Removed some unnecessary functions and changed an unused return type. 
1678
1679         * Drosera/win/DebuggerClient.cpp:
1680         (registerConsoleClass):
1681         * Drosera/win/DebuggerClient.h:
1682         * Drosera/win/Drosera.cpp:
1683         (registerDroseraClass):
1684
1685 2007-11-28  Alp Toker  <alp@atoker.com>
1686
1687         Reviewed by Timothy Hatcher.
1688
1689         http://bugs.webkit.org/show_bug.cgi?id=16174
1690         [GTK] Use "URI" not "URL" in public API
1691
1692         Replace use of the term "URL" with "URI" in public headers,
1693         documentation and some internal code to match GLib/GTK+ convention.
1694
1695         This is now mentioned in the API guidelines:
1696           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1697
1698         * GtkLauncher/main.c:
1699         (activate_uri_entry_cb):
1700         (title_change_cb):
1701         (create_toolbar):
1702         (main):
1703
1704 2007-11-29  Anders Carlsson  <andersca@apple.com>
1705
1706         Reviewed by Sam.
1707
1708         <rdar://problem/5230478>
1709         FrameLoadDelegate callbacks are not dumped in DRT.
1710         
1711         * DumpRenderTree/win/DumpRenderTree.cpp:
1712         (shouldLogFrameLoadDelegates):
1713         (runTest):
1714         (main):
1715         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1716         (BSTRtoString):
1717         (descriptionSuitableForTestResult):
1718         (FrameLoadDelegate::QueryInterface):
1719         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1720         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1721         (FrameLoadDelegate::didCommitLoadForFrame):
1722         (FrameLoadDelegate::didFinishLoadForFrame):
1723         (FrameLoadDelegate::willCloseFrame):
1724         (FrameLoadDelegate::didClearWindowObject):
1725         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1726         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1727         * DumpRenderTree/win/FrameLoaderDelegate.h:
1728         (FrameLoadDelegate::windowScriptObjectAvailable):
1729         (FrameLoadDelegate::didFirstLayoutInFrame):
1730
1731 2007-11-29  Sam Weinig  <sam@webkit.org>
1732
1733         Reviewed by Anders.
1734
1735         Add database quota UIDelegates methods to DRT UIDelegate.
1736
1737         * DumpRenderTree/mac/UIDelegate.mm:
1738         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1739         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1740
1741 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1742
1743         Reviewed by Sam.
1744
1745         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1746         dying and vice versa.
1747         - This fix will allow Drosera and Safari to reconnect if either of them
1748         closes correctly, but does not fix the case where one of them dies
1749         silently.
1750
1751         * Drosera/win/ServerConnection.cpp:
1752         (ServerConnection::attemptToCreateServerConnection): Added a safety
1753         check, because it's possilbe to try to connect to a server that's dying.
1754         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1755         the server has died.
1756         * Drosera/win/ServerConnection.h: Added the new function and removed
1757         an unnecessary member.
1758
1759 2007-11-29  Anders Carlsson  <andersca@apple.com>
1760
1761         * DumpRenderTree/win/DumpRenderTree.vcproj:
1762         Add shlwapi.lib to all configurations.
1763
1764 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1765
1766         - Build fix.  Added additional includes for VS Express to the Release
1767         project.
1768
1769         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1770
1771 2007-11-29  Anders Carlsson  <andersca@apple.com>
1772
1773         Reviewed by Adam.
1774
1775         <rdar://problem/5132005>
1776         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1777         
1778         * DumpRenderTree/win/DumpRenderTree.vcproj:
1779         Add shlwapi.lib
1780         
1781         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1782         (LayoutTestController::setUserStyleSheetEnabled):
1783         Implement this.
1784         
1785         (appendComponentToPath):
1786         New method which wraps the Win32 API PathAppend.
1787         
1788         (followShortcuts):
1789         New method which checks if a file points to a shortcut and
1790         follows the shortcut.
1791         
1792         (resolveCygwinPath):
1793         New method that takes a cygwin unix-style path and returns the Win32 path.
1794         
1795         (cfStringRefToWString):
1796         
1797         (LayoutTestController::setUserStyleSheetLocation):
1798         Implement this.
1799
1800 2007-11-29  Alice Liu  <alice.liu@apple.com>
1801
1802         Reviewed by Adam.
1803
1804         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1805
1806         * DumpRenderTree/win/EventSender.cpp:
1807         (keyDownCallback):
1808         uppercase letters were being sent as lowercase letters without the shift key down.
1809
1810 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1811
1812         - Windows build fix. VS express needs some love.
1813
1814         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1815
1816 2007-11-28  Darin Adler  <darin@apple.com>
1817
1818         Reviewed by Adam Roben.
1819
1820         * DumpRenderTree/mac/EventSendingController.mm:
1821         (-[EventSendingController keyDown:withModifiers:]):
1822         Send capital letters through as lowercase letters with the shift key down
1823         rather than sending them as if they were highly unusual "capital letter keys".
1824
1825         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1826         where you need to update results and more tests are failing than before.
1827
1828 2007-11-28  Anders Carlsson  <andersca@apple.com>
1829
1830         Reviewed by Darin.
1831
1832         <rdar://problem/5132001>
1833         contextClick is not implemented in DRT on Windows.
1834         
1835         * DumpRenderTree/win/EventSender.cpp:
1836         (contextClickCallback):
1837         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1838         by a WM_RBUTTONUP message.
1839         
1840         * DumpRenderTree/win/UIDelegate.cpp:
1841         (UIDelegate::hasCustomMenuImplementation):
1842         (UIDelegate::trackCustomPopupMenu):
1843         * DumpRenderTree/win/UIDelegate.h:
1844         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1845         menu from being shown (and causing the DRT to hang).
1846
1847 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1848
1849         Reviewed by Darin.
1850
1851         Fix DumpRenderTree ObjC bug comparing strings.
1852
1853         * DumpRenderTree/mac/ObjCController.m:
1854         (-[ObjCController identityIsEqual::]): Compare strings with string
1855         equality instead of identiy equality.
1856
1857 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1858
1859         Reviewed by Sam.
1860
1861         Reset the authorAndUserStylesEnabled preference
1862         back to YES for each test. Fixes the broken tests.
1863
1864         * DumpRenderTree/mac/DumpRenderTree.mm:
1865         (resetWebViewToConsistentStateBeforeTesting):
1866
1867 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1868
1869         Reviewed by Adam.
1870
1871         - Drosera now displays the console window, although it cannot currently
1872         process JavaScript.
1873
1874         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1875         (registerConsoleClass): Implemented.
1876         (consoleWndProc): Implemented.
1877         (DebuggerClient::onSize): Implemented.
1878         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1879         new window.
1880         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1881         creating and maintaining a new window.
1882         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1883         lines of code to more appropriate places.
1884         (Drosera::handleCommand):
1885         (Drosera::initUI):
1886         (Drosera::onSize):
1887         (Drosera::attach):
1888
1889 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1890
1891         Reviewed by Dave Hyatt.
1892
1893         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1894         
1895         Add support for disabling author and user styles for testing.
1896
1897         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1898         * DumpRenderTree/LayoutTestController.cpp:
1899         (setAuthorAndUserStylesEnabledCallback):
1900         (LayoutTestController::staticFunctions):
1901         * DumpRenderTree/LayoutTestController.h:
1902         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1903         (LayoutTestController::setAuthorAndUserStylesEnabled):
1904         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1905         (LayoutTestController::setAuthorAndUserStylesEnabled):
1906
1907 2007-11-26  Dan Bernstein  <mitz@apple.com>
1908
1909         - Tiger build fix.
1910
1911         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1912
1913 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1914
1915         Reviewed by Maciej.
1916
1917         - Implemented displaying variables for Drosera on Win.
1918
1919         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1920         that retrieve variables to not hold onto the return value since it's
1921         not returned.  Also changed to use the new signatures of the retrieval
1922         functions.
1923         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1924         (DebuggerDocument::platformValueForScopeVariableNamed):
1925         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1926         (droseraWndProc):
1927
1928 2007-11-26  Sam Weinig  <sam@webkit.org>
1929
1930         Cleanup names of painting and repainting functions.
1931
1932         Reviewed by Adam Roben.
1933
1934         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1935         (drawSelectionRect): was drawSelectionRectIntoContext.
1936         (dumpWebViewAsPixelsAndCompareWithExpected):
1937         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1938         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1939         (paintWebView): was drawWebViewIntoContext.
1940         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1941
1942 2007-11-26  Sam Weinig  <sam@webkit.org>
1943
1944         Reviewed by Dan Bernstein.
1945
1946         - Leopard build fix
1947
1948         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1949
1950 2007-11-26  Sam Weinig  <sam@webkit.org>
1951
1952         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1953         Use shared PixelDumpSupport for Mac DRT
1954
1955         Reviewed by Adam Roben.
1956
1957         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1958         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1959         * DumpRenderTree/cg/ImageDiffCG.cpp:
1960         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1961         (drawSelectionRectIntoContext):
1962         (dumpWebViewAsPixelsAndCompareWithExpected):
1963         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1964         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1965         * DumpRenderTree/mac/DumpRenderTree.mm:
1966         (dump):
1967         * DumpRenderTree/mac/ImageDiff.m: Removed.
1968         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1969         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1970         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1971         (setDefaultColorProfileToRGB):
1972         (getBitmapContextFromWebView):
1973         (drawWebViewIntoContext):
1974         (repaintWithVerticalSweep):
1975         (repaintWithHorizontalSweep):
1976         (getSelectionRect):
1977         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1978
1979 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1980
1981         Bug 16052: prepare-ChangeLog doesn't report deleted files
1982         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1983
1984         Reviewed by Sam.
1985
1986         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1987
1988 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1989
1990         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1991         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1992
1993         Reviewed by Adam.
1994
1995         Roll functionality of merge-changelog into resolve-ChangeLogs
1996         script.  The script now checks for ChangeLog.rej and
1997         ChangeLog.orig files first.  If it finds them, it uses the
1998         ChangeLog.rej file as a patch (in old contextual diff format) to
1999         apply with --fuzz=3.
2000
2001         * Scripts/merge-changelog: Removed.
2002         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2003
2004 2007-11-25  Sam Weinig  <sam@webkit.org>
2005
2006         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2007
2008         Reviewed by Mark Rowe.
2009
2010         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2011         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2012         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2013         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2014         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2015
2016 2007-11-25  Sam Weinig  <sam@webkit.org>
2017
2018         Convert DumpRenderTree to ues .xcconfig files.
2019
2020         Reviewed by Mark Rowe.
2021
2022         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2023         * DumpRenderTree/mac/Configurations: Added.
2024         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2025         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2026         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2027
2028 2007-11-25  Sam Weinig  <sam@webkit.org>
2029
2030         Add ForwardingHeaders to wtf for DumpRenderTree.
2031
2032         Reviewed by Mark Rowe.
2033
2034         * DumpRenderTree/DumpRenderTree.h:
2035         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2036         * DumpRenderTree/ForwardingHeaders: Added.
2037         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2038         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2039         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2040         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2041         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2042         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2043         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2044         * DumpRenderTree/LayoutTestController.cpp:
2045         * DumpRenderTree/WorkQueue.cpp:
2046         * DumpRenderTree/mac/DumpRenderTree.mm:
2047         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2048         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2049         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2050         * DumpRenderTree/mac/ObjCController.m:
2051         * DumpRenderTree/mac/UIDelegate.mm:
2052         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2053
2054 2007-11-25  Adam Roben  <aroben@apple.com>
2055
2056         Fix some test failures caused by r28019
2057
2058         Now that stdout is in binary mode, we need to always use printf
2059         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2060         the output.
2061
2062         Reviewed by Sam.
2063
2064         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2065         printf.
2066         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2067         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2068         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2069         (UIDelegate::webViewAddMessageToConsole):
2070
2071 2007-11-25  Adam Roben  <aroben@apple.com>
2072
2073         Set the font smoothing preference in DRT
2074
2075         This makes the pixel results on Windows closer to the Mac results.
2076
2077         Reviewed by Mitz.
2078
2079         * DumpRenderTree/win/DumpRenderTree.cpp:
2080         (initializePreferences):
2081
2082 2007-11-25  Adam Roben  <aroben@apple.com>
2083
2084         Port ImageDiff to CG and C++
2085
2086         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2087         <rdar://5071708>
2088
2089         Reviewed by Sam.
2090
2091         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2092         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2093         (main):
2094         (createImageFromStdin):
2095         (compareImages):
2096         (getDifferenceBitmap):
2097         (computePercentageDifferent):
2098         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2099
2100 2007-11-25  Adam Roben  <aroben@apple.com>
2101
2102         Fix image diff link generation on Windows
2103
2104         Reviewed by Sam.
2105
2106         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2107         to toURL.
2108
2109 2007-11-25  Adam Roben  <aroben@apple.com>
2110
2111         Implement pixel dumping in Windows DRT
2112
2113         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2114         <rdar://5071708>
2115
2116         Reviewed by Sam.
2117
2118         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2119         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2120         Content-Length header.
2121         (getMD5HashStringForBitmap):
2122         (dumpWebViewAsPixelsAndCompareWithExpected):
2123         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2124         * DumpRenderTree/win/DumpRenderTree.cpp:
2125         (dump): Do a pixel dump if requested.
2126         (main): Parse pixel test options.
2127         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2128         the cg/ subdirectory to the include path.
2129         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2130         available in a header or import library, so we have to go through this
2131         LoadLibrary/GetProcAddress dance to use them.
2132         (cryptDLL):
2133         (init):
2134         (update):
2135         (final):
2136         (MD5_Init):
2137         (MD5_Update):
2138         (MD5_Final):
2139         * DumpRenderTree/win/MD5.h: Added.
2140         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2141         moved up to the top level to share it with Mac eventually.
2142         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2143         (getBitmapContextFromWebView): Forces the WebView to paint using a
2144         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2145
2146 2007-11-25  Adam Roben  <aroben@apple.com>
2147
2148         Clean up Windows DRT's option parsing a little bit
2149
2150         Reviewed by Sam.
2151
2152         * DumpRenderTree/win/DumpRenderTree.cpp:
2153         (main): Put non-option arguments into a Vector.
2154
2155 2007-11-25  Adam Roben  <aroben@apple.com>
2156
2157         Make Windows DRT stop changing LF into CRLF
2158
2159         Reviewed by Sam.
2160
2161         * DumpRenderTree/win/DumpRenderTree.cpp:
2162         (main): Put stdout in binary mode.
2163         * Scripts/run-webkit-tests: Remove the CRLF hack.
2164
2165 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2166
2167         Removed empty directory.
2168
2169         * Scripts/resources: Removed.
2170
2171 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2172
2173         Fix bisect-builds to work with recent WebKit nightly builds.
2174
2175         Reviewed by Dan.
2176
2177         * Scripts/bisect-builds: Check for the 
2178         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2179         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2180         to WebKit.app/Contents/Resources.
2181
2182 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2183
2184         Reviewed by Maciej.
2185
2186         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2187         not closed (affects digg.com)
2188
2189         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2190         one after finishing with a test to avoid having its delayed onload handler firing when
2191         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2192         but it helps somewhat.
2193
2194 2007-11-22  Mark Rowe  <mrowe@apple.com>
2195
2196         Reviewed by Alp Toker.
2197
2198         Fix build-webkit to propagate make's exit status if it fails.
2199
2200         * Scripts/webkitdirs.pm:
2201
2202 2007-11-22  Dan Bernstein  <mitz@apple.com>
2203
2204         Reviewed by Mark Rowe.
2205
2206         - fix crash when running pixel tests
2207
2208         * DumpRenderTree/mac/DumpRenderTree.mm:
2209         (dumpRenderTree): Parse the command line options before setting up the
2210         environment so that we know if we need to set up the pixel dump
2211         machinery.
2212
2213 2007-11-21  Eric Seidel  <eric@webkit.org>
2214
2215         Speculative build fix for Tiger.
2216
2217         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2218
2219 2007-11-21  Eric Seidel  <eric@webkit.org>
2220
2221         Reviewed by Tim Hatcher.
2222
2223         Break out more of DumpRenderTree.mm into individual files
2224
2225         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2226         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2227         (checkedMalloc):
2228         (checkedRealloc):
2229         (makeLargeMallocFailSilently):
2230         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2231         * DumpRenderTree/mac/DumpRenderTree.mm:
2232         (crashHandler):
2233         (dump):
2234         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2235         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2236         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2237         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2238         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2239         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2240         (javaScriptThreads):
2241         (runJavaScriptThread):
2242         (startJavaScriptThreads):
2243         (stopJavaScriptThreads):
2244         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2245         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2246         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2247         (restoreColorSpace):
2248         (setDefaultColorProfileToRGB):
2249         (initializeColorSpaceAndScreeBufferForPixelTests):
2250         (md5HashStringForBitmap):
2251         (dumpWebViewAsPixelsAndCompareWithExpected):
2252
2253 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2254
2255         Move install-unix-extras to wx directory as it seems only to be used by that 
2256         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2257         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2258         have install-unix-extras install into WebKitLibraries as per
2259         convention.
2260         
2261         Reviewed by Mark Rowe.
2262
2263         * Scripts/install-unix-extras: Removed.
2264         * wx/build-wxwebkit:
2265         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2266
2267 2007-11-21  Eric Seidel  <eric@webkit.org>
2268
2269         Reviewed by Adam.
2270
2271         More refactoring for greater code readability
2272
2273         * DumpRenderTree/mac/DumpRenderTree.mm:
2274         (initializeGlobalsFromCommandLineOptions):
2275         (initializeColorSpaceAndScreeBufferForPixelTests):
2276         (addTestPluginsToPluginSearchPath):
2277         (useLongRunningServerMode):
2278         (runTestingServerLoop):
2279         (prepareConsistentTestingEnvironment):
2280         (dumpRenderTree):
2281         (main):
2282         (dumpFramesAsText):
2283         (dumpBackForwardListForWebView):
2284         (sizeWebViewForCurrentTest):
2285         (methodNameStringForFailedTest):
2286         (dumpBackForwardListForAllWindows):
2287         (dumpWebViewAsPixelsAndCompareWithExpected):
2288         (invalidateAnyPreviousWaitToDumpWatchdog):
2289         (dump):
2290         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2291         * DumpRenderTree/mac/UIDelegate.mm:
2292         (-[UIDelegate webView:createWebViewWithRequest:]):
2293
2294 2007-11-21  Eric Seidel  <eric@webkit.org>
2295
2296         Reviewed by Tim Hatcher.
2297
2298         Abstract more of DRT into static methods
2299
2300         * DumpRenderTree/mac/DumpRenderTree.mm:
2301         (setDefaultsToConsistentValuesForTesting):
2302         (setupSignalHandlers):
2303         (allocateGlobalControllers):
2304         (releaseAndZero):
2305         (releaseGlobalControllers):
2306         (dumpRenderTree):
2307         (shouldLogFrameLoadDelegates):
2308         (createCFURLFromPathOrURL):
2309         (resetWebViewToConsistentStateBeforeTesting):
2310         (runTest):
2311
2312 2007-11-21  Eric Seidel  <eric@webkit.org>
2313
2314         Reviewed by Tim Hatcher.
2315
2316         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2317
2318         * DumpRenderTree/DumpRenderTree.h:
2319         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2320         * DumpRenderTree/mac/DumpRenderTree.mm:
2321         (dumpRenderTree):
2322         (dump):
2323         (runTest):
2324         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2325         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2326         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2327         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2328         (-[DumpRenderTreePasteboard declareType:owner:]):
2329         (+[LocalPasteboard alloc]):
2330         (-[LocalPasteboard init]):
2331         (-[LocalPasteboard dealloc]):
2332         (-[LocalPasteboard name]):
2333         (-[LocalPasteboard releaseGlobally]):
2334         (-[LocalPasteboard declareTypes:owner:]):
2335         (-[LocalPasteboard addTypes:owner:]):
2336         (-[LocalPasteboard changeCount]):
2337         (-[LocalPasteboard types]):
2338         (-[LocalPasteboard availableTypeFromArray:]):
2339         (-[LocalPasteboard setData:forType:]):
2340         (-[LocalPasteboard dataForType:]):
2341         (-[LocalPasteboard setPropertyList:forType:]):
2342         (-[LocalPasteboard setString:forType:]):
2343         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2344         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2345         (+[DumpRenderTreeWindow allWindows]):
2346         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2347         (-[DumpRenderTreeWindow dealloc]):
2348         (-[DumpRenderTreeWindow isKeyWindow]):
2349         (-[DumpRenderTreeWindow keyDown:]):
2350
2351 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2352
2353         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2354         it indiscriminately copies any headers inside JavaScriptCore,
2355         which includes Tiger ICU headers. 
2356
2357         * wx/build-wxwebkit:
2358         Don't run WebCore/move-js-headers.sh any longer.
2359
2360 2007-11-20  Adam Treat  <treat@kde.org>
2361
2362         Reviewed by David Kilzer.
2363
2364         * Prepend git branch name to $baseProductDir
2365
2366         * Scripts/VCSUtils.pm:
2367         * Scripts/webkitdirs.pm:
2368
2369 2007-11-20  Mark Rowe  <mrowe@apple.com>
2370
2371         Reviewed by Simon Hausmann.
2372
2373         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2374         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2375         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2376         built product and generated Makefile's are removed.
2377
2378 2007-11-19  Alp Toker  <alp@atoker.com>
2379
2380         Reviewed by Mark Rowe.
2381
2382         http://bugs.webkit.org/show_bug.cgi?id=16040
2383         [GTK] GtkLauncher should be written in C
2384
2385         Port GtkLauncher to plain C.
2386
2387         Use a more conventional GTK+ coding style.
2388
2389         Use a toolbar instead of menus.
2390
2391         Various signature fixes and cleanups.
2392
2393         Add a license header. Assume all previous modifications were copyright
2394         assigned to Apple Inc. by default.
2395
2396         * GtkLauncher/GtkLauncher.pro:
2397         * GtkLauncher/main.c: Added.
2398         (activate_url_entry_cb):
2399         (update_title):
2400         (link_hover_cb):
2401         (title_change_cb):
2402         (progress_change_cb):
2403         (destroy_cb):
2404         (go_back_cb):
2405         (go_forward_cb):
2406         (create_browser):
2407         (create_statusbar):
2408         (create_toolbar):
2409         (create_window):
2410         (main):
2411         * GtkLauncher/main.cpp: Removed.
2412
2413 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2414
2415         Build script fixes to ensure they do the right thing for the 
2416         wx port, and update build-wxwebkit to reflect the way the
2417         build scripts now work.
2418
2419         Reviewed by Adam.
2420
2421         * Scripts/build-testkjs:
2422         * Scripts/build-webkit:
2423         * Scripts/run-javascriptcore-tests:
2424         * Scripts/webkitdirs.pm:
2425         * wx/build-wxwebkit:
2426
2427 2007-11-18  Eric Seidel  <eric@webkit.org>
2428
2429         Reviewed by Anders.
2430
2431         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2432
2433         * Scripts/run-javascriptcore-tests:
2434
2435 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2436
2437         Reviewed by Adam Roben.
2438
2439         Make run-webkit-tests work with Windows debug build.
2440
2441         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2442         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2443         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2444         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2445         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2446
2447 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2448
2449         Add wxWebKit sample and build script, and integrate it with 
2450         build-webkit. Also make build-webkit --clean work for all
2451         ports.
2452
2453         Reviewed by Darin Adler.
2454
2455         * Scripts/build-webkit:
2456         * Scripts/webkitdirs.pm:
2457         * wx: Added.
2458         * wx/browser: Added.
2459         * wx/browser/browser.bkl: Added.
2460         * wx/browser/browser.cpp: Added.
2461         * wx/build-wxwebkit: Added.
2462
2463 2007-11-17  Adam Roben  <aroben@apple.com>
2464
2465         Make it easy to run Safari in the debugger on Windows
2466
2467         I've added a new script, debug-safari, which launches Safari in the
2468         debugger. On OS X it just calls gdb-safari.
2469
2470         Reviewed by Mark Rowe.
2471
2472         * FindSafari/FindSafari.cpp:
2473         (_tmain): Added a /debugger flag, which in combination with
2474         /printSafariLauncher will print a script that launches Safari in the
2475         debugger.
2476         * Scripts/debug-safari: Added.
2477         * Scripts/run-safari: Changed to call runSafari().
2478         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2479         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2480         first argument along to FindSafari.
2481         * Scripts/webkitdirs.pm:
2482         (sub runSafari): Added.
2483
2484 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2485
2486         Reviewed by Adam Roben.
2487
2488         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2489
2490 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2491
2492         Reviewed by David Kilzer.
2493
2494         The git config command was renamed to repo-config at some point. This
2495         change tries git config and then git repo-config if the first fails.
2496
2497         * Scripts/prepare-ChangeLog:
2498         (gitConfig):
2499
2500 2007-11-16  Dan Bernstein  <mitz@apple.com>
2501
2502         Reviewed by Darin Adler and Sam Weinig.
2503
2504         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2505
2506         * DumpRenderTree/win/EventSender.cpp:
2507         (keyDownCallback): For characters that cannot be entered on the active
2508         keyboard layout, send a WM_CHAR message with the character along with
2509         a WM_KEYDOWN message with a virtual key code of 255.
2510
2511 2007-11-16  Mark Rowe  <mrowe@apple.com>
2512
2513         Reviewed by Tim Hatcher.
2514
2515         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2516
2517         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2518         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2519
2520 2007-11-15  Adam Roben  <aroben@apple.com>
2521
2522         Make run-safari actually work on Windows
2523
2524         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2525         chdir call.
2526
2527 2007-11-14  Adam Roben  <aroben@apple.com>
2528
2529         Updates to Safari launching now that 3.0.4 is released
2530
2531         Reviewed by Sam.
2532
2533         * FindSafari/FindSafari.cpp:
2534         (getWebViewCLSID): Use version-independent ProgID.
2535         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2536
2537 2007-11-14  Anders Carlsson  <andersca@apple.com>
2538
2539         Reviewed by Adam.
2540
2541         <rdar://problem/5309081>
2542         In DRT, "plugin.logDestroy = true" not working on Windows.
2543         
2544         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2545         (NPP_Destroy):
2546
2547 2007-11-14  Eric Seidel  <eric@webkit.org>
2548
2549         Reviewed by Sam.
2550
2551         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2552
2553 2007-11-14  Anders Carlsson  <andersca@apple.com>
2554
2555         Reviewed by Adam.
2556
2557         <rdar://problem/5141186>
2558         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2559         
2560         Implement setWindowIsKey.
2561         
2562         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2563         (LayoutTestController::setWindowIsKey):
2564
2565 2007-11-13  Sam Weinig  <sam@webkit.org>
2566
2567         Reviewed by Adam Roben.
2568
2569         Fix for <rdar://problem/5382579>
2570         http/tests/security/cross-frame-access-put.html reports large 
2571         negative numbers for screenLeft and screenTop (Mac reports "0")
2572
2573         * DumpRenderTree/win/UIDelegate.cpp:
2574         (UIDelegate::UIDelegate): Initialize the RECT.
2575         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2576         (UIDelegate::webViewFrame): ditto.
2577         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2578
2579 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2580
2581         Reviewed by Adam.
2582
2583         - Make Drosera show source, source URLs, and function stack on Windows,
2584         and some minor fixes.
2585
2586         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2587         (DebuggerDocument::updateFileSource):
2588         * Drosera/debugger.js: Force source to always update display.
2589         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2590         menu controls.
2591         (DebuggerClient::resume):
2592         (DebuggerClient::pause):
2593         (DebuggerClient::stepInto):
2594         (DebuggerClient::stepOver):
2595         (DebuggerClient::stepOut):
2596         (DebuggerClient::showConsole):
2597         (DebuggerClient::closeCurrentFile):
2598         * Drosera/win/DebuggerClient.h: Ditto.
2599         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2600         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2601         removed two bugs.  1) caller could be in a bad state when asked to
2602         assign into it. 2) BSTRs were not created correctly.
2603         (DebuggerDocument::getPlatformCurrentFunctionStack):
2604         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2605         (droseraWndProc):
2606         (handleCommand):
2607         (Drosera::resume):
2608         (Drosera::pause):
2609         (Drosera::stepInto):
2610         (Drosera::stepOver):
2611         (Drosera::stepOut):
2612         (Drosera::showConsole):
2613         (Drosera::closeCurrentFile):
2614         * Drosera/win/Drosera.h: Hook up the menu controls.
2615         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2616         functions, added a null check, and fixed another bug where caller could
2617         be in a bad state when asked to assign into it.
2618         (ServerConnection::didLoadMainResourceForDataSource):
2619         (ServerConnection::getCallerFrame):
2620         * Drosera/win/ServerConnection.h: Safety first.
2621
2622 2007-11-13  Dan Bernstein  <mitz@apple.com>
2623
2624         Reviewed by Darin Adler.
2625
2626         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2627           DumpRenderTree --pixel-tests renders each test twice
2628
2629         * DumpRenderTree/mac/DumpRenderTree.mm:
2630         (dumpRenderTree): Removed the --paint option because the painting code
2631         is always exercised as a result of
2632         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2633         calling -displayIfNeeded.
2634         (dump): Changed to always grab the image from the window since the view
2635         is always displayed.
2636         (runTest):
2637         (displayWebView):
2638         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2639         because it always paints.
2640
2641 2007-11-12  Antti Koivisto  <antti@apple.com>
2642
2643         Reviewed by Adele.
2644         
2645         Add support for http media tests
2646
2647         * Scripts/run-webkit-tests:
2648
2649 2007-11-12  Sam Weinig  <sam@webkit.org>
2650
2651         Reviewed by Adam Roben.
2652
2653         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2654
2655         * DumpRenderTree/win/DumpRenderTree.cpp:
2656         (runTest):
2657         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2658         (LayoutTestController::setPrivateBrowsingEnabled):
2659
2660 2007-11-12  Adam Roben  <aroben@apple.com>
2661
2662         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2663         mac and win subdirectories.
2664
2665 2007-11-11  Adam Roben  <aroben@apple.com>
2666
2667         Fix <rdar://5133816> keepWebHistory is not implemented
2668
2669         Fixes fast/history/clicked-link-is-visited.html.
2670
2671         Reviewed by Darin.
2672
2673         * DumpRenderTree/win/DumpRenderTree.cpp:
2674         (runTest): Clear the optionalSharedHistory.
2675         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2676         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2677
2678 2007-11-10  Sam Weinig  <sam@webkit.org>
2679
2680         Reviewed by Tim Hatcher.
2681
2682         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2683         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2684         is turned on)
2685
2686         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2687
2688         Added test: http/tests/security/cross-frame-access-private-browsing.html
2689
2690         * DumpRenderTree/LayoutTestController.cpp:
2691         (setPrivateBrowsingEnabledCallback):
2692         (LayoutTestController::staticFunctions):
2693         * DumpRenderTree/LayoutTestController.h:
2694         * DumpRenderTree/mac/DumpRenderTree.mm:
2695         (runTest): Default to private browsing disabled.
2696         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2697         (LayoutTestController::setPrivateBrowsingEnabled):
2698         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2699         (LayoutTestController::setPrivateBrowsingEnabled):
2700
2701 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2702
2703         Reviewed by Adam.
2704
2705         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2706         WebCore's!
2707
2708         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2709         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2710         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2711         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2712         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2713         * Drosera/win/Drosera.cpp:
2714         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2715
2716 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2717
2718         Reviewed by Sam.
2719
2720         - Use the new IWebFrame [local] function signature and get the shared
2721         server correctly.
2722
2723         * Drosera/win/DebuggerClient.cpp:
2724         (DebuggerClient::didFinishLoadForFrame):
2725         * Drosera/win/ServerConnection.cpp:
2726         (ServerConnection::attemptToCreateServerConnection):
2727
2728 2007-11-07  Dan Bernstein  <mitz@apple.com>
2729
2730         Reviewed by Darin Adler.
2731
2732         - add an option to run-webkit-tests to ignore pixel test failures where
2733           all pixels differ by no more than a specified threshold
2734
2735         * DumpRenderTree/mac/ImageDiff.m:
2736         (main):
2737         (compareImages):
2738         (computePercentageDifferent):
2739         * Scripts/run-webkit-tests:
2740
2741 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2742
2743         Reviewed by Lars.
2744
2745         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2746
2747         * DumpRenderTree/qt/DumpRenderTree.cpp:
2748
2749 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2750
2751         Reviewed by Lars.
2752
2753         Reworked the QWebSettings API.
2754         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2755
2756         * DumpRenderTree/qt/DumpRenderTree.cpp:
2757
2758 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2759
2760         Reviewed by Lars.
2761
2762         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2763
2764         * DumpRenderTree/qt/jsobjects.cpp:
2765
2766 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2767
2768         Reviewed by Lars Knoll <lars@trolltech.com>.
2769
2770         Add a QWebPage::frameCreated() signal and fix DRT
2771         
2772         The removal of createFrame in QWebPage broke the re-implementation
2773         in DumpRenderTree. Instead emit a frameCreated() signal and
2774         connect to it in DumpRenderTree.
2775         
2776
2777         * DumpRenderTree/qt/DumpRenderTree.cpp:
2778         (WebCore::WebPage::WebPage):
2779         (WebCore::DumpRenderTree::dump):
2780         (WebCore::DumpRenderTree::connectFrame):
2781         * DumpRenderTree/qt/DumpRenderTree.h:
2782
2783 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2784
2785         Reviewed by Lars Knoll <lars@trolltech.com>.
2786
2787         Moved all the event handlers from QWebFrame into QWebPage.
2788         
2789         This cleans up the public API and allows us to remove the
2790         HackWebFrame hack in DumpRenderTree.
2791         
2792
2793         * DumpRenderTree/qt/jsobjects.cpp:
2794         (EventSender::mouseDown):
2795         (EventSender::mouseUp):
2796         (EventSender::mouseMoveTo):
2797
2798 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2799
2800         Reviewed by Mark.
2801
2802         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2803         to prevent the default implementation from popping up messageboxes.
2804
2805         * DumpRenderTree/qt/DumpRenderTree.cpp:
2806         (WebCore::WebPage::javaScriptConfirm):
2807         (WebCore::WebPage::javaScriptPrompt):
2808
2809 2007-11-06  Eric Seidel  <eric@webkit.org>
2810
2811         * Scripts/build-testkjs: build fix... too many $$
2812
2813 2007-11-06  Eric Seidel  <eric@webkit.org>
2814
2815         Reviewed by Mark Rowe.
2816
2817         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2818
2819 2007-11-05  Adam Roben  <aroben@apple.com>
2820
2821         Add support on Windows for WEBKIT_TESTFONTS
2822
2823         This environment variable lets you specify where the fonts to be used
2824         by DumpRenderTree reside. The Qt port is already using this, so I'm
2825         just following their lead.
2826
2827         Reviewed by Darin.
2828
2829         * DumpRenderTree/win/DumpRenderTree.cpp:
2830         (exePath): Refactored code out of initialize().
2831         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2832         DumpRenderTree.resources.
2833         (initialize): Use the new fontsPath function.
2834         (main): Use the new exePath function.
2835         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2836         variable to DRT, like Qt does.
2837
2838 2007-11-05  Mark Rowe  <mrowe@apple.com>
2839
2840         Rubber-stamped by Alp Toker.
2841
2842         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2843
2844         * GtkLauncher/main.cpp:
2845         (goToURLBarText):
2846         (main):
2847
2848 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2849
2850         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2851         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2852
2853         Reviewed by Timothy.
2854
2855         Restrict the range of nightly builds used by the bisect-builds script
2856         based on the version of Safari and the version of Mac OS X being used.
2857
2858         Mac OS X 10.4: Safari 2.0: r11976 or newer
2859         Mac OS X 10.4: Safari 3.0: r19992 or newer
2860
2861         Mac OS X 10.5: Safari 2.0: r19594 or newer
2862         Mac OS X 10.5: Safari 3.0: r25124 or newer
2863
2864         * Scripts/bisect-builds:
2865         (findMacOSXVersion): Added.
2866         (makeNightlyList): Added argument to provide version of Mac OS X.
2867         Restrict range of nightly builds based on Safari and Mac OS X versions.
2868
2869 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2870
2871         Reviewed by Maciej.
2872
2873         - This patch involves several changes, all of them were noticed that
2874         they were needed by the work being done in WebKit to get Drosera and
2875         WebKit working together on Windows.
2876         - The changes are:
2877         1) Added a debugger console for output messages.
2878         2) Drosera now listens for the WebKit server (before, the server would
2879         have to be running before Drosera was started.)
2880         3) Fixed a bug where the WebView started out as 0x0 pixels.
2881         4) Fixed a bug when there is no scope.
2882         5) Added the HTML, JS, and CSS to the project file to make them easy to
2883         find.
2884         6) Made the ServerConnection functions virtual.
2885
2886         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2887         for the WebKit server.
2888         (DebuggerClient::DebuggerClient):
2889         (DebuggerClient::~DebuggerClient):
2890         (DebuggerClient::didFinishLoadForFrame):
2891         (DebuggerClient::serverConnected):
2892         (DebuggerClient::attemptToCreateServerConnection):
2893         * Drosera/win/DebuggerClient.h: Ditto.
2894         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2895         scope.
2896         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2897         (DebuggerDocument::platformValueForScopeVariableNamed):
2898         * Drosera/win/Drosera.cpp:
2899         (_tWinMain): Added a console in debug for output messages.
2900         (Drosera::Drosera): Listen for server.
2901         (Drosera::initUI): The server now Initializes COM.
2902         (Drosera::serverConnected): Part of the listening for the server.
2903         (Drosera::attemptToCreateServerConnection): Ditto.
2904         * Drosera/win/Drosera.h: New interface for listening for the server.
2905         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2906         files to the VS project.
2907         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2908         connection.
2909         (ServerConnection::ServerConnection):
2910         (ServerConnection::attemptToCreateServerConnection):
2911         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2912         methods.
2913         (ServerConnection::serverConnected):
2914
2915 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2916
2917         Reviewed by Maciej.
2918
2919         http://bugs.webkit.org/show_bug.cgi?id=15832
2920         fast/dom/gc-10.html crashes when run alone
2921
2922         Check for !done before using objects that can be already deallocated.
2923
2924         * DumpRenderTree/mac/EditingDelegate.mm:
2925         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2926         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2927         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2928         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2929         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2930         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2931         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2932         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2933         (-[EditingDelegate webViewDidBeginEditing:]):
2934         (-[EditingDelegate webViewDidChange:]):
2935         (-[EditingDelegate webViewDidEndEditing:]):
2936         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2937         (-[EditingDelegate webViewDidChangeSelection:]):
2938         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2939         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2940         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2941         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2942         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2943         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2944         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2945         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2946         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2947         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2948         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2949         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2950         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2951         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2952         (-[FrameLoadDelegate webView:willCloseFrame:]):
2953         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2954         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2955         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2956         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2957         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2958         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2959         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2960         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2961         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2962
2963 2007-11-04  Mark Rowe  <mrowe@apple.com>
2964
2965         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2966         warnings that would otherwise be suppressed due to it being a system header.
2967
2968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2969
2970 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2971
2972         Rubber stamped by Adam.
2973         
2974         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2975
2976         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2977
2978 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2979
2980         Sort files(...); sections of Xcode project files.
2981
2982         Rubber-stamped by Darin.
2983
2984         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2985         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2986         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2987         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2988
2989 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2990
2991         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2992
2993         Reviewed by Darin.
2994
2995         * Scripts/sort-Xcode-project-file: Added.
2996
2997 2007-11-02  Darin Adler  <darin@apple.com>
2998
2999         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3000
3001 2007-11-02  Darin Adler  <darin@apple.com>
3002
3003         Reviewed by Maciej.
3004
3005         * Scripts/run-sunspider: Pass the "--base" option through.
3006
3007         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3008         the real script do that. Default configuration to Release to match run-sunspider
3009         so we don't end up building Debug just to compare results.
3010
3011 2007-11-01  Adam Roben  <aroben@apple.com>
3012
3013         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3014
3015         Reviewed by Sam.
3016
3017         * Scripts/commit-log-editor: Show all the directories beneath the
3018         source root, instead of just the last one.
3019
3020 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3021
3022         Reviewed by Adam Roben.
3023
3024         Print out an error message when the Windows build fails
3025         and provide guidance on how to find out what went wrong.
3026
3027         * Scripts/build-webkit:
3028         * Scripts/webkitdirs.pm:
3029
3030 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3031
3032         Rubber-stamped by Adam Roben.
3033
3034         Rolled out r27326 - debug CRT seems to cause no problems after all.
3035
3036         * DumpRenderTree/win/DumpRenderTree.vcproj:
3037
3038 2007-10-31  Adam Roben  <aroben@apple.com>
3039
3040         Switch the Debug configuration to using the non-debug CRT
3041
3042         This matches WebKit.
3043
3044         Reviewed by Steve.
3045
3046         * DumpRenderTree/win/DumpRenderTree.vcproj:
3047
3048 2007-10-31  Antti Koivisto  <antti@apple.com>
3049
3050         Reviewed by bdash.
3051         
3052         Disable media tests when doing leak checking on Tiger.
3053         They crash in QuickTime (rdar://problem/5537157).
3054
3055         * Scripts/run-webkit-tests:
3056
3057 2007-10-29  Antti Koivisto  <antti@apple.com>
3058
3059         Reviewed by Maciej.
3060         
3061         Build media support by default on OSX only.
3062
3063         * Scripts/build-webkit:
3064
3065 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3066
3067         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3068         get caught by the pre-commit hooks.
3069
3070 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3071
3072         Reviewed by Adam.
3073
3074         - This is a collection of relatively unrelated changes and cleanups
3075         to Drosera to prepare it for interacting with WebKit.  A lot of these
3076         changes are just correcting mistakes, for example removing included
3077         headers that are no longer needed.
3078
3079         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3080         this will be needed by the DebuggerClient.
3081         (DebuggerDocument::server):
3082         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3083         * Drosera/win/DebuggerClient.cpp: 
3084         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3085         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3086         (DebuggerClient::createWebViewWithRequest): Added comment about its
3087         purpose. 
3088         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3089         declarations.
3090         (DebuggerClient::webViewLoaded): Moved.
3091         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3092         file, since this was the only place it was used.
3093         (cfStringToBSTR):
3094         * Drosera/win/Drosera.h: Cleaned up the includes.
3095         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3096         * Drosera/win/HelperFunctions.h: Removed.
3097
3098 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3099
3100         Reviewed by Adam.
3101
3102         - Small cleanup in the ServerConnection class.
3103
3104         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3105         and added an include.
3106         (ServerConnection::currentFrame):
3107         (ServerConnection::getCallerFrame):
3108         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3109         made a pointer into a COMPtr, and cleaned up the includes.
3110
3111 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3112
3113         Reviewed by John Sullivan.
3114         
3115         - Place the Localizable.strings file in mac or win directories
3116           if that location exists.
3117         - Also look for UI_STRING in .c files.
3118
3119         * Scripts/extract-localizable-strings:
3120
3121 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3122
3123         Reviewed by Adam.
3124
3125         - Set the eol-style to native and made all the line endings the same
3126         so that I avoid messy diffs that show eol changes.
3127
3128         * Drosera/win/ServerConnection.cpp:
3129         (ServerConnection::didParseSource):
3130         (ServerConnection::didEnterCallFrame):
3131         (ServerConnection::willExecuteStatement):
3132         (ServerConnection::willLeaveCallFrame):
3133         (ServerConnection::exceptionWasRaised):
3134
3135 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3136
3137         Reviewed by Adam.
3138
3139         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3140         functionality that could not have existed previously without the new
3141         interfaces.
3142         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3143         from a BSTR to a JSValueRef.
3144         (DebuggerDocument::platformEvaluateScript): Implemented.
3145         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3146         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3147         Implemented.
3148         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3149         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3150         * Drosera/win/ServerConnection.cpp: Added a helper function.
3151         (ServerConnection::getCallerFrame):
3152         * Drosera/win/ServerConnection.h: Added a helper function.
3153
3154 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3155
3156         updated reviewers for my previous changelog.
3157
3158 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3159         Reviewed by Maciej and Adam and Geoff.
3160
3161         - Minor mac-side improvements including moving a function to a more
3162         appropriate location, fixing a warning, and correctly checking
3163         exceptions.
3164
3165         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3166         (DebuggerDocument::willExecuteStatement):
3167         (DebuggerDocument::didEnterCallFrame):
3168         (DebuggerDocument::willLeaveCallFrame):
3169         (DebuggerDocument::windowScriptObjectAvailable):
3170         (DebuggerDocument::callFunctionOnObject):
3171         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3172         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3173         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3174         because it doesn't require the ServerConnection at all.
3175         (NSStringCreateWithJSStringRef): Made an argument const.
3176         (JSValueRefCreateWithNSString): Made an argument const.
3177         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3178         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3179         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3180         * Drosera/mac/ServerConnection.mm: Ditto.
3181         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3182
3183 2007-10-29  Sam Weinig  <sam@webkit.org>
3184
3185         Reviewed by Adam Roben.
3186
3187         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3188
3189         * DumpRenderTree/LayoutTestController.cpp:
3190         (LayoutTestController::LayoutTestController):
3191         (getGlobalFlagCallback):
3192         (setGlobalFlagCallback):
3193         (LayoutTestController::getJSClass):
3194         (LayoutTestController::staticValues):
3195         * DumpRenderTree/LayoutTestController.h:
3196         (LayoutTestController::globalFlag):
3197         (LayoutTestController::setGlobalFlag):
3198
3199 2007-10-29  Darin Adler  <darin@apple.com>
3200
3201         Reviewed by Maciej.
3202
3203         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3204         resolution instead of its default.
3205
3206 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3207
3208         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3209
3210         Reviewed by Mark Rowe.
3211
3212         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3213         was successfully resolved, but this would not show any status because the change had
3214         already been cached in the index using "git add".  The solution is to add an optional
3215         second argument to showStatus() which adds the "--cached" switch to the command.
3216
3217         * Scripts/resolve-ChangeLogs:
3218         (showStatus):
3219
3220 2007-10-28  Eric Seidel  <eric@webkit.org>
3221
3222         Reviewed by Maciej and Geoff, in unison.
3223
3224         * Scripts/run-webkit-tests: remove broken --svg option
3225
3226 2007-10-28  Darin Adler  <darin@apple.com>
3227
3228         Reviewed by Adam.
3229
3230         * Scripts/run-sunspider: Default to "Release" configuration rather than
3231         defaulting to the last configuration used as other scripts do. This can
3232         still be overriden on the command line with "--debug" if there's some
3233         reason to do so. Also fix a typo.
3234
3235         * Scripts/sunspider-compare-results: Fix a typo.
3236
3237 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3238
3239         Reviewed by Adam.
3240
3241         - Implemented the WebScriptDebugListener functions now that the
3242         WebScriptDebugServer exists
3243
3244         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3245         functions.
3246         (ServerConnection::currentFrame):
3247         (ServerConnection::didLoadMainResourceForDataSource):
3248         (ServerConnection::didParseSource):
3249         (ServerConnection::failedToParseSource):
3250         (ServerConnection::didEnterCallFrame):
3251         (ServerConnection::willExecuteStatement):
3252         (ServerConnection::willLeaveCallFrame):
3253         (ServerConnection::exceptionWasRaised):
3254         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3255         members arguments list.
3256
3257 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3258
3259         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3260         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3261
3262         Reviewed by Darin.
3263
3264         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3265         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3266         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3267         file.  Note that it may also be used as a stand-alone script.
3268
3269         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3270         * Scripts/resolve-ChangeLogs: Added.
3271         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3272
3273 2007-10-26  Mark Rowe  <mrowe@apple.com>
3274
3275         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3276         to the Qt port on the assumption that it was an implementation of the cross-platform
3277         LayoutTestController class.  It is not, so it did not need to be changed.
3278
3279         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3280
3281 2007-10-25  Mark Rowe  <mrowe@apple.com>
3282
3283         Reviewed by Maciej.
3284
3285         Fix builds with code coverage enabled.
3286
3287         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3288
3289 2007-10-25  Darin Adler  <darin@apple.com>
3290
3291         Reviewed by Mark Rowe.
3292
3293         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3294         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3295
3296 2007-10-25  Stephanie  <slewis@apple.com>
3297
3298         build Fix
3299
3300         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3301
3302 2007-10-25  Stephanie  <slewis@apple.com>
3303
3304         Reviewed by Mark Rowe, Adam Roben.
3305
3306         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3307
3308         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3309
3310 2007-10-25  Alice Liu  <alice.liu@apple.com>
3311
3312         Reviewed by Adam.
3313
3314         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3315
3316         Moving destructor into platform-specific files
3317         * DumpRenderTree/LayoutTestController.cpp:
3318         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3319         (LayoutTestController::~LayoutTestController):
3320         * DumpRenderTree/qt/jsobjects.cpp:
3321         (LayoutTestController::~LayoutTestController):
3322
3323         LayoutTestController wasn't being destroyed
3324         * DumpRenderTree/win/DumpRenderTree.cpp:
3325         (runTest):
3326
3327         Added declspec
3328         * DumpRenderTree/win/EditingDelegate.h:
3329
3330         Reset certain values on the webview (or related delegate) that might 
3331         have changed while running a test
3332         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3333         (LayoutTestController::~LayoutTestController):
3334
3335 2007-10-25  Adam Roben  <aroben@apple.com>
3336
3337         Make sunspider-compare-results work with relative paths
3338
3339         Reviewed by Sam.
3340
3341         * Scripts/sunspider-compare-results: Convert arguments to absolute
3342         paths before we chdir.
3343
3344 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3345
3346         Reviewed by Sam.
3347
3348         - Implemented server calls now the WebScriptDebugServer exists.
3349         - Also removed no longer needed call to initialize CG.
3350
3351         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3352         automatically now.
3353         (_tWinMain):
3354         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3355         (ServerConnection::ServerConnection):
3356         (ServerConnection::~ServerConnection):
3357         (ServerConnection::pause):
3358         (ServerConnection::resume):
3359         (ServerConnection::stepInto):
3360         (ServerConnection::applicationTerminating):
3361         (ServerConnection::serverConnectionDidDie):
3362         * Drosera/win/ServerConnection.h: Now uses the COM class.
3363
3364 2007-10-24  George Staikos  <staikos@kde.org>
3365
3366         Unbreak Qt build.
3367
3368         * Scripts/build-webkit:
3369
3370 2007-10-24  Adam Roben  <aroben@apple.com>
3371
3372         Remove now-unnecessary call to InitializeCoreGraphics
3373
3374         WebKit takes care of this now.
3375
3376         Reviewed by Ada.
3377
3378         * DumpRenderTree/win/DumpRenderTree.cpp:
3379         (initialize):
3380
3381 2007-10-24  Adam Roben  <aroben@apple.com>
3382
3383         Use WebTextRenderer in DRT
3384
3385         Reviewed by Ada.
3386
3387         * DumpRenderTree/win/DumpRenderTree.cpp:
3388         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3389
3390 2007-10-24  Sven Herzberg  <sven@imendio.com>
3391
3392         Reviewed by Mark Rowe.
3393
3394         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3395         Bug 15614: [GTK] qmake based backends don't build on OS X
3396
3397         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3398         GTK backend on a Mac
3399         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3400         isDarwin() to make it reusable in other places (like the workaround-
3401         for-prebuilt-qmake in build-webkit)
3402
3403 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3404
3405         Refurbish update-webkit script.
3406
3407         Reviewed by Adam.
3408
3409         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3410         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3411         multi-argument version of system() for flexibility and security.  Check for existence
3412         of Internal directory using -d test instead of -x.
3413
3414 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3415
3416         Minor clean-up of prepare-ChangeLog script.
3417
3418         Reviewed by Adam.
3419
3420         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3421         of a string.  Use multi-argument versions of open() and system() for flexibility and
3422         security.
3423
3424 2007-10-24  Alice Liu  <alice.liu@apple.com>
3425
3426         Reviewed by Oliver.
3427
3428         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3429
3430         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3431         replay the saved events when we're still processing the mousedown that starts the drag
3432         * DumpRenderTree/win/EventSender.cpp:
3433         (doMouseMove):
3434         * DumpRenderTree/win/UIDelegate.cpp:
3435         (UIDelegate::doDragDrop):
3436
3437 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3438
3439         Reviewed by Sam, Steve and Darin.
3440
3441         - Stubbed out the WebScriptDebugListener functionality in the Server
3442         Connection class to prepare it for receiving those callbacks.
3443         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3444         and the ServerConnection to not need to be initialized with a server
3445         name, since that is not the way we connect to the WebKit server. 
3446
3447         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3448         no exception.  Now it only loggs when there is an exception
3449         (DebuggerDocument::willExecuteStatement):
3450         (DebuggerDocument::didEnterCallFrame):
3451         (DebuggerDocument::willLeaveCallFrame):
3452         (DebuggerDocument::windowScriptObjectAvailable):
3453         (DebuggerDocument::callFunctionOnObject):
3454         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3455         to be instantiated with a server's name.
3456         (DebuggerClient::DebuggerClient):
3457         (DebuggerClient::didFinishLoadForFrame):
3458         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3459         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3460         a server name.
3461         (Drosera::init):
3462         (Drosera::initServer):
3463         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3464         instantiated with a server's name.
3465         * Drosera/win/ServerConnection.cpp: 
3466         (ServerConnection::ServerConnection): No longer needs a server name
3467         (ServerConnection::~ServerConnection): Only release the global context
3468         if there is one.
3469         (ServerConnection::serverConnectionDidDie): Stub for
3470         IWebScriptDebugListener
3471         (ServerConnection::QueryInterface): ditto
3472         (ServerConnection::AddRef): ditto
3473         (ServerConnection::Release): ditto
3474         (ServerConnection::didLoadMainResourceForDataSource): ditto
3475         (ServerConnection::didParseSource): ditto
3476         (ServerConnection::failedToParseSource): ditto
3477         (ServerConnection::didEnterCallFrame): ditto
3478         (ServerConnection::willExecuteStatement): ditto
3479         (ServerConnection::willLeaveCallFrame): ditto
3480         (ServerConnection::exceptionWasRaised): ditto
3481         * Drosera/win/ServerConnection.h: Stubbed out the
3482         IWebScriptDebugListener functions, and this class no longer needs to be
3483         instantiated with a server name.
3484
3485 2007-10-24  Lars Knoll  <lars@trolltech.com>
3486
3487         Reviewed by Simon.
3488
3489         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3490
3491         * DumpRenderTree/qt/jsobjects.h:
3492
3493 2007-10-24  Lars Knoll  <lars@trolltech.com>
3494
3495         Reviewed by Simon.
3496
3497         add another command.
3498
3499         * DumpRenderTree/qt/jsobjects.cpp:
3500         (TextInputController::doCommand):
3501
3502 2007-10-24  Lars Knoll  <lars@trolltech.com>
3503
3504         Reviewed by Simon.
3505
3506         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3507
3508         * DumpRenderTree/qt/jsobjects.cpp:
3509         (EventSender::keyDown):
3510         * DumpRenderTree/qt/jsobjects.h:
3511
3512 2007-10-24  Lars Knoll  <lars@trolltech.com>
3513
3514         Reviewed by Simon.
3515
3516         implement eventSender.keyDown().
3517
3518         * DumpRenderTree/qt/jsobjects.cpp:
3519         (EventSender::keyDown):
3520
3521 2007-10-24  Lars Knoll  <lars@trolltech.com>
3522
3523         Reviewed by Simon.
3524
3525         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3526
3527         * DumpRenderTree/qt/DumpRenderTree.cpp:
3528         (WebCore::DumpRenderTree::DumpRenderTree):
3529         (WebCore::DumpRenderTree::initJSObjects):
3530         * DumpRenderTree/qt/jsobjects.cpp:
3531         (TextInputController::doCommand):
3532
3533 2007-10-24  Lars Knoll  <lars@trolltech.com>
3534
3535         Reviewed by Simon.
3536
3537         first bit of implementation for the textinputcontroller.
3538
3539         * DumpRenderTree/qt/DumpRenderTree.cpp:
3540         (WebCore::DumpRenderTree::DumpRenderTree):
3541         * DumpRenderTree/qt/DumpRenderTree.h:
3542         * DumpRenderTree/qt/jsobjects.cpp:
3543         (TextInputController::TextInputController):
3544         (TextInputController::doCommand):
3545         * DumpRenderTree/qt/jsobjects.h:
3546
3547 2007-10-24  Lars Knoll  <lars@trolltech.com>
3548
3549         Reviewed by Simon.
3550
3551         make the man webpage believe it has focus, so the editing tests work correctly.
3552
3553         * DumpRenderTree/qt/DumpRenderTree.cpp:
3554         (WebCore::DumpRenderTree::DumpRenderTree):
3555
3556 2007-10-24  Lars Knoll  <lars@trolltech.com>
3557
3558         Reviewed by Simon.
3559
3560         implement layoutTestController.dumpEditingCallbacks() correctly.
3561
3562         * DumpRenderTree/qt/DumpRenderTree.cpp:
3563         (WebCore::DumpRenderTree::DumpRenderTree):
3564         * DumpRenderTree/qt/jsobjects.cpp:
3565         (LayoutTestController::reset):
3566         (LayoutTestController::dumpEditingCallbacks):
3567
3568 2007-10-24  Lars Knoll  <lars@trolltech.com>
3569
3570         Reviewed by Simon.
3571
3572         Implement support for testing editing.
3573
3574         * DumpRenderTree/qt/DumpRenderTree.cpp:
3575         (WebCore::DumpRenderTree::DumpRenderTree):
3576
3577 2007-10-23  Sam Weinig  <sam@webkit.org>
3578
3579         Check for null BSTR that can be passed to the UIDelegate methods
3580         from javascript null and undefined.  Fixes a failing test case on
3581         Windows (fast/dom/Window/alert-undefined.html)
3582
3583         Reviewed by Eric Seidel.
3584
3585         * DumpRenderTree/win/UIDelegate.cpp:
3586         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3587         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3588         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3589         (UIDelegate::webViewAddMessageToConsole):
3590
3591 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3592
3593         Reviewed by Darin.
3594         
3595         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3596
3597         * Scripts/build-testkjs:
3598
3599 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3600
3601         Reviewed by Darin.
3602
3603         - add wrapper that finds the right copy of testkjs
3604         
3605         * Scripts/sunspider-compare-results: Added.
3606
3607 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3608
3609         Reviewed by Sam.
3610
3611         - After talking with Steve I now see that the WebKit server must be
3612         running for DCOM to create the distributed objects, which makes sense
3613         and currently WebKit only allows one instance to be running at a time
3614         which avoids accidentally connecting to the wrong server
3615         - In light of this I have removed the code for the attach box and
3616         NotificationServer and known server names, since they are all extranious
3617         now.
3618
3619         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3620         names.
3621         (_tWinMain): Uses init instead of initUI.
3622         (droseraWndProc): No longer creats an attach dialog box.
3623         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3624         it's not manditory to call init before doing COM stuff.
3625         (Drosera::init): calls initUI and will call attach when the
3626         functionality exists. 
3627         (Drosera::initUI): Has changed very little.
3628         (Drosera::attach): Changed the signature to reflect that we no longer
3629         need the dictionary of known server names.
3630         * Drosera/win/Drosera.h: Removed notification classes and known server
3631         names.  Also renamed and moved some functions.
3632         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3633         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3634         headers to the resources folder. 
3635         * Drosera/win/resource.h: Removed the Attach box.
3636
3637 2007-10-22  Adam Roben  <aroben@apple.com>
3638
3639         Windows build fix
3640
3641         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3642
3643 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3644
3645         - Removed a leak that was fixed.
3646
3647         * Scripts/run-webkit-tests:
3648
3649 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3650
3651         Reviewed by Darin.
3652
3653         - Changed the Client so that the DebuggerDocument now own the
3654         ServerConnection.  This simplifies ownership and cleanup. 
3655
3656         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3657         ServerConnection.
3658         (DebuggerClient::initWithServerName):
3659         (DebuggerClient::didFinishLoadForFrame):
3660         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3661         ServerConnection.
3662         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to