SunSpider:
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-10-29  Darin Adler  <darin@apple.com>
2
3         Reviewed by Maciej.
4
5         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
6         resolution instead of its default.
7
8 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
9
10         Fixed showStatus() to print status for successfully resolved conflicts when using git.
11
12         Reviewed by Mark Rowe.
13
14         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
15         was successfully resolved, but this would not show any status because the change had
16         already been cached in the index using "git add".  The solution is to add an optional
17         second argument to showStatus() which adds the "--cached" switch to the command.
18
19         * Scripts/resolve-ChangeLogs:
20         (showStatus):
21
22 2007-10-28  Eric Seidel  <eric@webkit.org>
23
24         Reviewed by Maciej and Geoff, in unison.
25
26         * Scripts/run-webkit-tests: remove broken --svg option
27
28 2007-10-28  Darin Adler  <darin@apple.com>
29
30         Reviewed by Adam.
31
32         * Scripts/run-sunspider: Default to "Release" configuration rather than
33         defaulting to the last configuration used as other scripts do. This can
34         still be overriden on the command line with "--debug" if there's some
35         reason to do so. Also fix a typo.
36
37         * Scripts/sunspider-compare-results: Fix a typo.
38
39 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
40
41         Reviewed by Adam.
42
43         - Implemented the WebScriptDebugListener functions now that the
44         WebScriptDebugServer exists
45
46         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
47         functions.
48         (ServerConnection::currentFrame):
49         (ServerConnection::didLoadMainResourceForDataSource):
50         (ServerConnection::didParseSource):
51         (ServerConnection::failedToParseSource):
52         (ServerConnection::didEnterCallFrame):
53         (ServerConnection::willExecuteStatement):
54         (ServerConnection::willLeaveCallFrame):
55         (ServerConnection::exceptionWasRaised):
56         * Drosera/win/ServerConnection.h: Removed unused arguments from the
57         members arguments list.
58
59 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
60
61         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
62         <http://bugs.webkit.org/show_bug.cgi?id=15600>
63
64         Reviewed by Darin.
65
66         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
67         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
68         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
69         file.  Note that it may also be used as a stand-alone script.
70
71         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
72         * Scripts/resolve-ChangeLogs: Added.
73         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
74
75 2007-10-26  Mark Rowe  <mrowe@apple.com>
76
77         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
78         to the Qt port on the assumption that it was an implementation of the cross-platform
79         LayoutTestController class.  It is not, so it did not need to be changed.
80
81         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
82
83 2007-10-25  Mark Rowe  <mrowe@apple.com>
84
85         Reviewed by Maciej.
86
87         Fix builds with code coverage enabled.
88
89         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
90
91 2007-10-25  Darin Adler  <darin@apple.com>
92
93         Reviewed by Mark Rowe.
94
95         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
96         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
97
98 2007-10-25  Stephanie  <slewis@apple.com>
99
100         build Fix
101
102         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
103
104 2007-10-25  Stephanie  <slewis@apple.com>
105
106         Reviewed by Mark Rowe, Adam Roben.
107
108         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
109
110         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
111
112 2007-10-25  Alice Liu  <alice.liu@apple.com>
113
114         Reviewed by Adam.
115
116         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
117
118         Moving destructor into platform-specific files
119         * DumpRenderTree/LayoutTestController.cpp:
120         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
121         (LayoutTestController::~LayoutTestController):
122         * DumpRenderTree/qt/jsobjects.cpp:
123         (LayoutTestController::~LayoutTestController):
124
125         LayoutTestController wasn't being destroyed
126         * DumpRenderTree/win/DumpRenderTree.cpp:
127         (runTest):
128
129         Added declspec
130         * DumpRenderTree/win/EditingDelegate.h:
131
132         Reset certain values on the webview (or related delegate) that might 
133         have changed while running a test
134         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
135         (LayoutTestController::~LayoutTestController):
136
137 2007-10-25  Adam Roben  <aroben@apple.com>
138
139         Make sunspider-compare-results work with relative paths
140
141         Reviewed by Sam.
142
143         * Scripts/sunspider-compare-results: Convert arguments to absolute
144         paths before we chdir.
145
146 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
147
148         Reviewed by Sam.
149
150         - Implemented server calls now the WebScriptDebugServer exists.
151         - Also removed no longer needed call to initialize CG.
152
153         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
154         automatically now.
155         (_tWinMain):
156         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
157         (ServerConnection::ServerConnection):
158         (ServerConnection::~ServerConnection):
159         (ServerConnection::pause):
160         (ServerConnection::resume):
161         (ServerConnection::stepInto):
162         (ServerConnection::applicationTerminating):
163         (ServerConnection::serverConnectionDidDie):
164         * Drosera/win/ServerConnection.h: Now uses the COM class.
165
166 2007-10-24  George Staikos  <staikos@kde.org>
167
168         Unbreak Qt build.
169
170         * Scripts/build-webkit:
171
172 2007-10-24  Adam Roben  <aroben@apple.com>
173
174         Remove now-unnecessary call to InitializeCoreGraphics
175
176         WebKit takes care of this now.
177
178         Reviewed by Ada.
179
180         * DumpRenderTree/win/DumpRenderTree.cpp:
181         (initialize):
182
183 2007-10-24  Adam Roben  <aroben@apple.com>
184
185         Use WebTextRenderer in DRT
186
187         Reviewed by Ada.
188
189         * DumpRenderTree/win/DumpRenderTree.cpp:
190         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
191
192 2007-10-24  Sven Herzberg  <sven@imendio.com>
193
194         Reviewed by Mark Rowe.
195
196         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
197         Bug 15614: [GTK] qmake based backends don't build on OS X
198
199         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
200         GTK backend on a Mac
201         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
202         isDarwin() to make it reusable in other places (like the workaround-
203         for-prebuilt-qmake in build-webkit)
204
205 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
206
207         Refurbish update-webkit script.
208
209         Reviewed by Adam.
210
211         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
212         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
213         multi-argument version of system() for flexibility and security.  Check for existence
214         of Internal directory using -d test instead of -x.
215
216 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
217
218         Minor clean-up of prepare-ChangeLog script.
219
220         Reviewed by Adam.
221
222         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
223         of a string.  Use multi-argument versions of open() and system() for flexibility and
224         security.
225
226 2007-10-24  Alice Liu  <alice.liu@apple.com>
227
228         Reviewed by Oliver.
229
230         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
231
232         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
233         replay the saved events when we're still processing the mousedown that starts the drag
234         * DumpRenderTree/win/EventSender.cpp:
235         (doMouseMove):
236         * DumpRenderTree/win/UIDelegate.cpp:
237         (UIDelegate::doDragDrop):
238
239 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
240
241         Reviewed by Sam, Steve and Darin.
242
243         - Stubbed out the WebScriptDebugListener functionality in the Server
244         Connection class to prepare it for receiving those callbacks.
245         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
246         and the ServerConnection to not need to be initialized with a server
247         name, since that is not the way we connect to the WebKit server. 
248
249         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
250         no exception.  Now it only loggs when there is an exception
251         (DebuggerDocument::willExecuteStatement):
252         (DebuggerDocument::didEnterCallFrame):
253         (DebuggerDocument::willLeaveCallFrame):
254         (DebuggerDocument::windowScriptObjectAvailable):
255         (DebuggerDocument::callFunctionOnObject):
256         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
257         to be instantiated with a server's name.
258         (DebuggerClient::DebuggerClient):
259         (DebuggerClient::didFinishLoadForFrame):
260         * Drosera/win/DebuggerClient.h: Removed unsued variable.
261         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
262         a server name.
263         (Drosera::init):
264         (Drosera::initServer):
265         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
266         instantiated with a server's name.
267         * Drosera/win/ServerConnection.cpp: 
268         (ServerConnection::ServerConnection): No longer needs a server name
269         (ServerConnection::~ServerConnection): Only release the global context
270         if there is one.
271         (ServerConnection::serverConnectionDidDie): Stub for
272         IWebScriptDebugListener
273         (ServerConnection::QueryInterface): ditto
274         (ServerConnection::AddRef): ditto
275         (ServerConnection::Release): ditto
276         (ServerConnection::didLoadMainResourceForDataSource): ditto
277         (ServerConnection::didParseSource): ditto
278         (ServerConnection::failedToParseSource): ditto
279         (ServerConnection::didEnterCallFrame): ditto
280         (ServerConnection::willExecuteStatement): ditto
281         (ServerConnection::willLeaveCallFrame): ditto
282         (ServerConnection::exceptionWasRaised): ditto
283         * Drosera/win/ServerConnection.h: Stubbed out the
284         IWebScriptDebugListener functions, and this class no longer needs to be
285         instantiated with a server name.
286
287 2007-10-24  Lars Knoll  <lars@trolltech.com>
288
289         Reviewed by Simon.
290
291         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
292
293         * DumpRenderTree/qt/jsobjects.h:
294
295 2007-10-24  Lars Knoll  <lars@trolltech.com>
296
297         Reviewed by Simon.
298
299         add another command.
300
301         * DumpRenderTree/qt/jsobjects.cpp:
302         (TextInputController::doCommand):
303
304 2007-10-24  Lars Knoll  <lars@trolltech.com>
305
306         Reviewed by Simon.
307
308         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
309
310         * DumpRenderTree/qt/jsobjects.cpp:
311         (EventSender::keyDown):
312         * DumpRenderTree/qt/jsobjects.h:
313
314 2007-10-24  Lars Knoll  <lars@trolltech.com>
315
316         Reviewed by Simon.
317
318         implement eventSender.keyDown().
319
320         * DumpRenderTree/qt/jsobjects.cpp:
321         (EventSender::keyDown):
322
323 2007-10-24  Lars Knoll  <lars@trolltech.com>
324
325         Reviewed by Simon.
326
327         some smaller fixes to the editing support in DRT. Makes another few tests pass.
328
329         * DumpRenderTree/qt/DumpRenderTree.cpp:
330         (WebCore::DumpRenderTree::DumpRenderTree):
331         (WebCore::DumpRenderTree::initJSObjects):
332         * DumpRenderTree/qt/jsobjects.cpp:
333         (TextInputController::doCommand):
334
335 2007-10-24  Lars Knoll  <lars@trolltech.com>
336
337         Reviewed by Simon.
338
339         first bit of implementation for the textinputcontroller.
340
341         * DumpRenderTree/qt/DumpRenderTree.cpp:
342         (WebCore::DumpRenderTree::DumpRenderTree):
343         * DumpRenderTree/qt/DumpRenderTree.h:
344         * DumpRenderTree/qt/jsobjects.cpp:
345         (TextInputController::TextInputController):
346         (TextInputController::doCommand):
347         * DumpRenderTree/qt/jsobjects.h:
348
349 2007-10-24  Lars Knoll  <lars@trolltech.com>
350
351         Reviewed by Simon.
352
353         make the man webpage believe it has focus, so the editing tests work correctly.
354
355         * DumpRenderTree/qt/DumpRenderTree.cpp:
356         (WebCore::DumpRenderTree::DumpRenderTree):
357
358 2007-10-24  Lars Knoll  <lars@trolltech.com>
359
360         Reviewed by Simon.
361
362         implement layoutTestController.dumpEditingCallbacks() correctly.
363
364         * DumpRenderTree/qt/DumpRenderTree.cpp:
365         (WebCore::DumpRenderTree::DumpRenderTree):
366         * DumpRenderTree/qt/jsobjects.cpp:
367         (LayoutTestController::reset):
368         (LayoutTestController::dumpEditingCallbacks):
369
370 2007-10-24  Lars Knoll  <lars@trolltech.com>
371
372         Reviewed by Simon.
373
374         Implement support for testing editing.
375
376         * DumpRenderTree/qt/DumpRenderTree.cpp:
377         (WebCore::DumpRenderTree::DumpRenderTree):
378
379 2007-10-23  Sam Weinig  <sam@webkit.org>
380
381         Check for null BSTR that can be passed to the UIDelegate methods
382         from javascript null and undefined.  Fixes a failing test case on
383         Windows (fast/dom/Window/alert-undefined.html)
384
385         Reviewed by Eric Seidel.
386
387         * DumpRenderTree/win/UIDelegate.cpp:
388         (UIDelegate::runJavaScriptAlertPanelWithMessage):
389         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
390         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
391         (UIDelegate::webViewAddMessageToConsole):
392
393 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
394
395         Reviewed by Darin.
396         
397         Don't print a massive pile of setenvs from tools that automatically build testkjs.
398
399         * Scripts/build-testkjs:
400
401 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
402
403         Reviewed by Darin.
404
405         - add wrapper that finds the right copy of testkjs
406         
407         * Scripts/sunspider-compare-results: Added.
408
409 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
410
411         Reviewed by Sam.
412
413         - After talking with Steve I now see that the WebKit server must be
414         running for DCOM to create the distributed objects, which makes sense
415         and currently WebKit only allows one instance to be running at a time
416         which avoids accidentally connecting to the wrong server
417         - In light of this I have removed the code for the attach box and
418         NotificationServer and known server names, since they are all extranious
419         now.
420
421         * Drosera/win/Drosera.cpp: Removed notification classes and known server
422         names.
423         (_tWinMain): Uses init instead of initUI.
424         (droseraWndProc): No longer creats an attach dialog box.
425         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
426         it's not manditory to call init before doing COM stuff.
427         (Drosera::init): calls initUI and will call attach when the
428         functionality exists. 
429         (Drosera::initUI): Has changed very little.
430         (Drosera::attach): Changed the signature to reflect that we no longer
431         need the dictionary of known server names.
432         * Drosera/win/Drosera.h: Removed notification classes and known server
433         names.  Also renamed and moved some functions.
434         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
435         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
436         headers to the resources folder. 
437         * Drosera/win/resource.h: Removed the Attach box.
438
439 2007-10-22  Adam Roben  <aroben@apple.com>
440
441         Windows build fix
442
443         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
444
445 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
446
447         - Removed a leak that was fixed.
448
449         * Scripts/run-webkit-tests:
450
451 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
452
453         Reviewed by Darin.
454
455         - Changed the Client so that the DebuggerDocument now own the
456         ServerConnection.  This simplifies ownership and cleanup. 
457
458         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
459         ServerConnection.
460         (DebuggerClient::initWithServerName):
461         (DebuggerClient::didFinishLoadForFrame):
462         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
463         ServerConnection.
464         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
465         until after we have a server which we are attached to.
466         (Drosera::initUI):
467         (Drosera::attach):
468         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
469         out previously.
470
471 2007-10-22  Simon Hausmann  <hausmann@kde.org>
472
473         Reviewed by Nikolas.
474
475         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
476
477         * Scripts/run-javascriptcore-tests:
478
479 2007-10-22  Simon Hausmann  <hausmann@kde.org>
480
481         Reviewed by Nikolas.
482
483         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
484
485         * Scripts/build-drosera:
486         * Scripts/build-dumprendertree:
487         * Scripts/build-testkjs:
488         * Scripts/build-webkit:
489         * Scripts/run-javascriptcore-tests:
490         * Scripts/run-sunspider:
491         * Scripts/run-webkit-tests:
492         * Scripts/webkitdirs.pm:
493
494 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
495
496         Reviewed by Mark Rowe.
497         
498         Fix for local database support after r26879
499         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
500
501         * Scripts/build-webkit:
502
503 2007-10-22  Holger Freyther  <zecke@selfish.org>
504
505         Reviewed by Simon Hausmann <hausmann@kde.org>.
506
507         - Do not build testkjs as an application bundle. This is
508         needed for run-javascriptcore-tests on OSX.
509         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
510         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
511         as we do not have -rpath on OSX.
512
513         * DumpRenderTree/qt/DumpRenderTree.pro:
514         * Scripts/run-webkit-tests:
515
516 2007-10-22  Simon Hausmann  <hausmann@kde.org>
517
518         Reviewed by aroben.
519
520         Fix support for Signed-off-by detection in prepare-ChangeLog
521         --git-commit. The Signed-off-by tag does not appear in the header
522         but usually at the end.
523
524         * Scripts/prepare-ChangeLog:
525
526 2007-10-21  Mark Rowe  <mrowe@apple.com>
527
528         Reviewed by Eric.
529
530         Fix run-javascriptcore-tests for Gtk.
531
532         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
533
534 2007-10-20  Eric Seidel  <eric@webkit.org>
535
536         Reviewed by aroben.
537
538         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
539
540 2007-10-20  Eric Seidel  <eric@webkit.org>
541
542         Reviewed by darin.
543         
544         Add improved argument handling to run-sunspider, including
545         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
546         Also re-factor code into subroutines
547
548         * Scripts/build-dumprendertree: removed bogus comments
549         * Scripts/build-testkjs: Added.
550         * Scripts/run-javascriptcore-tests: use build-testkjs
551         * Scripts/run-sunspider: improved argument handling, abstraction
552         * Scripts/run-webkit-tests: improved abstraction
553
554 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
555
556         Not reviewed, Windows build fix.
557
558         * DumpRenderTree/win/EventSender.cpp:
559         (keyDownCallback):
560
561 2007-10-20  Darin Adler  <darin@apple.com>
562
563         Reviewed by Tim Hatcher.
564
565         - http://bugs.webkit.org/show_bug.cgi?id=15544
566           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
567           not rely on Apple-specific key codes
568
569         * DumpRenderTree/mac/EventSendingController.mm:
570         (-[EventSendingController keyDown:withModifiers:]):
571         Added named key "rightArrow". Later we could have a whole table of these.
572         Also tweaked modifiers code a little.
573
574         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
575
576 2007-10-19  Darin Adler  <darin@apple.com>
577
578         Reviewed by Eric.
579
580         - http://bugs.webkit.org/show_bug.cgi?id=15566
581           possible fix for leak seen in DumpRenderTree
582
583         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
584         Delete the item if it's not put on the queue, since the caller has
585         no way of knowing that. Would be better to have the parameter type
586         be auto_ptr to express the fact that we take ownership.
587
588         - unrelated change
589
590         * Drosera/mac/main.m: Add missing include.
591
592 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
593
594         Reviewed by Adam.
595
596         - This change should be identical but for some reason was not working
597         on my machine.
598
599         * Scripts/prepare-ChangeLog:
600
601 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
602
603         Reviewed by Oliver and Tim.
604
605         - Made use of RetainPtr to avoid retain and release issues and moved the
606         log function to DebuggerDocumentPlatform, which seems to be a more
607         logical place for it to live.
608         - Also moved knownServers from the ServerConnection to
609         DebuggerApplication to match the Windows code and because it makes sense
610         that a connection knows its own server but not all of them.
611
612         * Drosera/mac/DebuggerClient.h: Moved the log function to
613           DebuggerDocumentPlatform.
614         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
615           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
616           call for the server name up from the ServerConnection class.
617         (-[DebuggerClient dealloc]):
618         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
619           for the server name up from the ServerConnection.
620         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
621         (DebuggerDocument::platformPause):
622         (DebuggerDocument::platformResume):
623         (DebuggerDocument::platformStepInto):
624         (DebuggerDocument::platformEvaluateScript):
625         (DebuggerDocument::getPlatformCurrentFunctionStack):
626         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
627         (DebuggerDocument::platformValueForScopeVariableNamed):
628         (DebuggerDocument::platformLog): Log directly from here. No need to call
629           DebuggerClient.
630         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
631           way I see it, a ServerConnection should only know about its connection
632           and the group of all possible servers should be kept by the
633           application.
634         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
635           currentServerName, it makes sense that the connection should know that
636           name.
637         (-[ServerConnection currentServerName]):
638
639 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
640
641         Reviewed by Adam.
642
643         - Integrated changes from mac drosera.  Recently I've encapsulated
644         out the server connection object from the rest of Drosera because
645         it is very platform dependent right now and RPC is not implemented on
646         windows.  This functionality, of communicating with the WebKit server
647         is the next area I will be focusing on in Windows.
648
649         - Other changes and cleanup were made to organize the code and add notes
650         on which parts still need work.  Also some mac code is added and
651         commented out, to act as pseudocode for the logic of those parts.
652
653         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
654           pointer.
655         * Drosera/config.h: Added whitespace.
656         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
657           these files got moved into Drosera.h/cpp
658         * Drosera/win/DebuggerApplication.h: Removed.
659         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
660           happened here to better match the logic flow of the same code on the 
661           mac side and to use the new ServerConnection class.
662         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
663         (DebuggerClient::initWithServerName): Initializer that will set up the
664           class to use a ServerConnection object.  This was necessary so I could
665           create a DebuggerClient without having to initilaize it at
666           construction.
667         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
668           will be the UIDelegate and FrameLoadDelegate.
669         (DebuggerClient::AddRef): For IUnknown.
670         (DebuggerClient::Release): For IUnknown.
671         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
672           this still needs to set the global context of the server, but
673           IWebFrame does not have an accessor for the global context yet. 
674         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
675           this is a pass through for the same function in the document.
676         (DebuggerClient::didReceiveTitle): Unimplemented part of
677           FrameLoadDelegate this would change the title of the window.
678         (DebuggerClient::createWebViewWithRequest): Part of the
679           FrameLoadDelegate.  This is about new windows via Window.open() and
680           how their delegates are set.
681         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
682           UIDelegate.  Just a debug function for printing messages.
683         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
684           because the Client should be the UIDelegate and FrameLoadDelegate
685           to match the delegates on mac.
686         (DebuggerClient::webViewLoaded): Added accessor method.
687         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
688           forgotten to add this file before.  This is where the platform
689           dependent versions of the Documents functions live. Most of these are
690           unimplemented because some piece of functionality does not exist on
691           Windows yet.
692         (DebuggerDocument::platformPause):
693         (DebuggerDocument::platformResume):
694         (DebuggerDocument::platformStepInto):
695         (DebuggerDocument::platformEvaluateScript):
696         (DebuggerDocument::getPlatformCurrentFunctionStack):
697         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
698         (DebuggerDocument::platformValueForScopeVariableNamed):
699         (DebuggerDocument::platformLog):
700         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
701           responsibilities becaue they belong in the Client. Also I laid the
702           groundwork for attaching Drosera to a WebKit process
703         (attachWndProc): Now if a server is selected the Client becomes it's
704           delegate.
705         (Drosera::Drosera): Added the construction of the Client and dictionary
706           of server names. 
707         (Drosera::initUI): This is no longer the delegates, the Client is.
708         (Drosera::webViewLoaded): Now asks the Client instead of holding local
709           state. 
710         (Drosera::applicationDidFinishLaunching): Placeholder for needed
711           notification registration when it's possible to implement.
712         (Drosera::serverLoaded): Ditto
713         (Drosera::serverUnloaded): Ditto
714         (Drosera::attach): Attach Drosera to the WebKit server.
715         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
716         (Drosera::getInst): 
717         (Drosera::setInst):
718         (Drosera::knownServers):
719         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
720           and added the ServerConnection.
721         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
722         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
723           Most of the functions are completely unimlemented because they cannot
724           connect with the WebKit server, because one does not exist on Windows
725           yet.
726         (ServerConnection::initWithServerName): 
727         (ServerConnection::~ServerConnection):
728         (ServerConnection::setGlobalContext):
729         (ServerConnection::pause):
730         (ServerConnection::resume):
731         (ServerConnection::stepInto):
732         (ServerConnection::switchToServerNamed):
733         (ServerConnection::applicationTerminating):
734         (ServerConnection::serverConnectionDidDie):
735         (ServerConnection::currentFrame):
736         * Drosera/win/ServerConnection.h: Added. Ditto.
737         (ServerConnection::ServerConnection):
738
739 2007-10-19  Alice Liu  <alice.liu@apple.com>
740
741         Reviewed by Darin.
742
743         Fix for these broken layout tests on Windows:
744         
745         fast/forms/focus-selection-input.html
746         fast/forms/focus-selection-textarea.html
747         fast/forms/select-accesskey.html
748         
749         * DumpRenderTree/win/EventSender.cpp:
750         (keyDownCallback):
751         correct the VK code for alt key.
752         
753 2007-10-19  Eric Seidel  <eric@webkit.org>
754
755         Reviewed by Mark Rowe.
756         
757         Make the GtkLauncher code slightly more readable.
758
759         * GtkLauncher/main.cpp:
760         (setupMainMenu): Added.
761         (setupMainWindowUI): Added.
762         (main):
763
764 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
765
766         Rubber stamped by Adam.
767         
768         - don't delay-load WebKit in DumpRenderTree.
769
770         * DumpRenderTree/win/DumpRenderTree.vcproj:
771
772 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
773
774         Reviewed by Adam Roben.
775
776         - fix <rdar://problem/5313523>
777         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
778
779         * DumpRenderTree/mac/DumpRenderTree.mm:
780         (dump): Changed to use _responseMIMEType.
781
782 2007-10-17  Adam Roben  <aroben@apple.com>
783
784         Make it possible to have Windows-specific tests and results
785
786         When searching for tests to run and the Skipped file, we will only
787         look in platform/win and the cross-platform directory. When looking
788         for expected results, we will look in platform/win, then
789         platform/mac-leopard, then platform/mac, then finally the
790         cross-platform directory.
791
792         Reviewed by Sam.
793
794         * Scripts/run-webkit-tests:
795         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
796         searching in the cross-platform directory.
797         (sub buildPlatformHierarchy): Removed some unneeded calls to
798         dirname/basename.
799
800 2007-10-17  Adam Roben  <aroben@apple.com>
801
802         Add back the call to register WebKit that we had before WebKitInitializer existed
803
804         This is needed to ensure that the right WebKit is used when
805         instantiating COM objects.
806
807         Reviewed by Oliver.
808
809         * DumpRenderTree/win/debug_internal.vsprops: Define
810         DEBUG_WEBKIT_HAS_SUFFIX.
811         * DumpRenderTree/win/DumpRenderTree.cpp:
812         (initialize):
813
814 2007-10-17  Adam Roben  <aroben@apple.com>
815
816         Import File::Basename in webkitdirs since we use it
817
818         * Scripts/webkitdirs.pm:
819
820 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
821
822         - Updated the tiger leaks list to make the internal bots green.
823
824         * Scripts/run-webkit-tests:
825
826 2007-10-17  Adam Roben  <aroben@apple.com>
827
828         Build fix for VC++ Express
829
830         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
831         and ole32.lib.
832
833 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
834
835         Reviewed by Sam.
836
837         - Minor mac improvements based on observations I made while implementing the
838         Windows code.
839
840         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
841         then hand it to the Client who will retain it, it should just be the client who
842         creates and owns the server.
843         (-[DebuggerApplication attach:]):
844         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
845         * Drosera/mac/DebuggerClient.mm: Creates the server.
846         (-[DebuggerClient initWithServerName:]):
847         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
848         can instead forward declare what it needs.
849
850 2007-10-16  Darin Adler  <darin@apple.com>
851
852         Reviewed by Geoff Garen.
853
854         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
855         want to turn failing tests into platform-specific test results. Also did a
856         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
857         would take the type of results into account only some of the time.
858
859 2007-10-16  Adam Roben  <aroben@apple.com>
860
861         Add a new nightly launcher script for Windows
862
863         This new script is for versions of Safari that don't delay-load
864         WebKit. I had to make FindSafari be able to print out the nightly
865         launcher script on stdout because Windows shell scripts can't capture
866         the output from a command into an environment variable.
867
868         Reviewed by Steve.
869
870         * FindSafari/FindSafari.cpp:
871         (_tmain): Added /printSafariLauncher option.
872         * Scripts/run-webkit-nightly.cmd: Added.
873
874 2007-10-16  Adam Roben  <aroben@apple.com>
875
876         Replace WebKitInitializer with FindSafari
877
878         We now rely on setting the PATH environment variable to tell Windows
879         where to find WebKit and its dependencies (similar to
880         DYLD_FRAMEWORK_PATH on Mac).
881
882         This change also make DumpRenderTree no longer delay-load WebKit.
883
884         Reviewed by Sam.
885
886         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
887         FindSafari.
888         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
889         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
890         WebKitInitializer, don't delay-load WebKit.
891         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
892         * Scripts/run-webkit-tests: Ditto.
893         * Scripts/webkitdirs.pm:
894         (sub setPathForRunningWebKitApp): Added.
895         * WebKitInitializer/WebKitInitializer.cpp: Removed.
896         * WebKitInitializer/WebKitInitializer.h: Removed.
897         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
898         * WebKitInitializer/debug.vsprops: Removed.
899         * WebKitInitializer/debug_internal.vsprops: Removed.
900         * WebKitInitializer/release.vsprops: Removed.
901
902 2007-10-16  Adam Roben  <aroben@apple.com>
903
904         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
905
906         http://bugs.webkit.org/show_bug.cgi?id=15532
907
908         FindSafari simply prints the location of an installed Safari.exe on
909         stdout.
910
911         Reviewed by Darin.
912
913         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
914         (getStringValue):
915         (getWebViewCLSID):
916         (getInstalledWebKitDirectory):
917         (_tmain):
918         * FindSafari/FindSafari.vcproj: Added.
919         * Scripts/webkitdirs.pm:
920         (sub installedSafariPath): Added. Calls FindSafari on Windows.
921
922 2007-10-16  Adam Roben  <aroben@apple.com>
923
924         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
925
926         Reviewed by Kevin McCullough.
927
928         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
929         when referring to WebKit.dll.
930         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
931         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
932         * DumpRenderTree/win/release.vsprops: Ditto.
933         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
934         never have a _debug suffix on WebKit.dll.
935         * WebKitInitializer/WebKitInitializer.cpp:
936         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
937         specified.
938         * WebKitInitializer/debug_internal.vsprops: Added
939         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
940
941 2007-10-16  Darin Adler  <darin@apple.com>
942
943         Reviewed by Adele.
944
945         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
946         Remove now-unneeded control/alt key hack; the tests have been updated.
947
948 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
949
950         - Updated leaks list because our internal bot upgraded it's version of leopard and 
951         one of the leaks was fixed between that revision and the bot's previous version of
952         leopard.
953
954         * Scripts/run-webkit-tests:
955
956 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
957
958         Reviewed by Tim.
959
960         - I encapsulated out the server connecton functionality because it is a specific part
961         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
962         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
963         Windows.  So the majority of this patch is moving preexisting functionality.
964
965         - Also I removed the prefix header and changed to use config.h because it is more
966         standard on how we use config.h in windows and it didn't make much sense to keep
967         the prefix header and the config.h
968
969         * Drosera/DebuggerDocument.cpp:
970         (DebuggerDocument::DebuggerDocument):
971         * Drosera/DebuggerDocument.h:
972         * Drosera/config.h:
973         * Drosera/mac/DebuggerApplication.mm:
974         (-[DebuggerApplication attach:]):
975         * Drosera/mac/DebuggerClient.h:
976         * Drosera/mac/DebuggerClient.mm:
977         (-[DebuggerClient initWithServerConnection:]):
978         (-[DebuggerClient dealloc]):
979         (-[DebuggerClient windowDidLoad]):
980         (-[DebuggerClient windowWillClose:]):
981         (-[DebuggerClient webView:didFinishLoadForFrame:]):
982         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
983         * Drosera/mac/DebuggerDocumentPlatform.mm:
984         (DebuggerDocument::platformPause):
985         (DebuggerDocument::platformResume):
986         (DebuggerDocument::platformStepInto):
987         (DebuggerDocument::platformEvaluateScript):
988         (DebuggerDocument::getPlatformCurrentFunctionStack):
989         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
990         (DebuggerDocument::platformValueForScopeVariableNamed):
991         (DebuggerDocument::platformLog):
992         * Drosera/mac/Drosera.pch: Removed.
993         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
994         * Drosera/mac/ServerConnection.h: Added.
995         * Drosera/mac/ServerConnection.mm: Added.
996         (-[ServerConnection initWithServerName:]):
997         (-[ServerConnection dealloc]):
998         (-[ServerConnection setGlobalContext:]):
999         (-[ServerConnection pause]):
1000         (-[ServerConnection resume]):
1001         (-[ServerConnection stepInto]):
1002         (-[ServerConnection switchToServerNamed:]):
1003         (-[ServerConnection applicationTerminating:]):
1004         (-[ServerConnection serverConnectionDidDie:]):
1005         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1006         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1007         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1008         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1009         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1010         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1011         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1012         (-[ServerConnection currentFrame]):
1013         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1014         (-[ServerConnection knownServers]):
1015
1016 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1017
1018         Reviewed by Eric.
1019
1020         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1021           Script to automatically search nightly builds for regressions (bisect-builds)
1022
1023         * Scripts/bisect-builds: Added.
1024
1025 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1026
1027         Reviewed by Darin.
1028
1029         - New JavaScript benchmark
1030         http://bugs.webkit.org/show_bug.cgi?id=15515
1031
1032         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1033         current development or release build of JavaScriptCore.
1034
1035 2007-10-15  Mark Rowe  <mrowe@apple.com>
1036
1037         Reviewed by Sam.
1038
1039         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1040
1041         * Scripts/webkitdirs.pm:
1042         - Change checkArgv to remove the options from @ARGV to prevent
1043         them from interfering with further option processing.
1044         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1045         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1046         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1047         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1048
1049 2007-10-15  Darin Adler  <darin@apple.com>
1050
1051         Reviewed by Sam.
1052
1053         - added logging of window.prompt and window.confirm
1054
1055         * DumpRenderTree/mac/UIDelegate.mm:
1056         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1057         Implement the recommended delegate rather than the deprecated one.
1058         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1059         Added.
1060         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1061         Added.
1062
1063         * DumpRenderTree/win/UIDelegate.h:
1064         * DumpRenderTree/win/UIDelegate.cpp:
1065         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1066         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1067         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1068         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1069
1070 2007-10-15  Alice Liu  <alice.liu@apple.com>
1071
1072         Reviewed by Sam Weinig.
1073
1074         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1075
1076         * DumpRenderTree/win/DumpRenderTree.cpp:
1077         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1078         (main): allocate the global policy delegate for DRT's custom use
1079         * DumpRenderTree/win/DumpRenderTree.vcproj:
1080         Adding files to project
1081         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1082         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1083         (LayoutTestController::setCustomPolicyDelegate):
1084         set the webview's policy delegate to DRT's custom one if the test requests it.
1085         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1086         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1087         (PolicyDelegate::PolicyDelegate):
1088         (PolicyDelegate::QueryInterface):
1089         (PolicyDelegate::AddRef):
1090         (PolicyDelegate::Release):
1091         (PolicyDelegate::decidePolicyForNavigationAction):
1092         * DumpRenderTree/win/PolicyDelegate.h: Added.
1093         (PolicyDelegate::decidePolicyForNewWindowAction):
1094         (PolicyDelegate::decidePolicyForMIMEType):
1095         (PolicyDelegate::unableToImplementPolicyWithError):
1096
1097 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1098
1099         Reviewed by Mark.
1100
1101         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1102         when querying for QMAKE_MKSPECS.
1103
1104 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1105
1106         Reviewed by Adam Roben.
1107         
1108         Fix run-webkit-tests is too greedy calculating platform hierarchy
1109         http://bugs.webkit.org/show_bug.cgi?id=15465
1110         
1111         Fix run-webkit-tests being too greedy in trying to split the platform name up
1112         causing it to try and find tests in every directory above the first "-" in the
1113         path to the LayoutTests
1114
1115         * Scripts/run-webkit-tests:
1116
1117 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1118
1119         Reviewed by Darin.
1120
1121         http://bugs.webkit.org/show_bug.cgi?id=15006
1122         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1123         to reduce code duplication.
1124
1125         * Scripts/build-webkit:
1126         * Scripts/webkitdirs.pm:
1127         buildQMakeProject() renamed to buildQMakeQtProject().
1128         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1129         unused $colorize has been removed.
1130
1131 === Start merge of feature-branch 2007-10-12 ===
1132
1133 2007-10-08  Eric Seidel  <eric@webkit.org>
1134
1135         Reviewed by Mark Rowe.
1136
1137         * Scripts/build-webkit: add --help, remove unused --color
1138
1139 2007-10-07  Eric Seidel  <eric@webkit.org>
1140
1141         Reviewed by darin.
1142
1143         * Drosera/mac/DebuggerDocumentPlatform.mm:
1144         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1145
1146 2007-10-03  Rob Buis  <buis@kde.org>
1147
1148         Reviewed by Olliej.
1149
1150         Adapt to changed location of Ahem font.
1151
1152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1153
1154 2007-10-02  Eric Seidel  <eric@webkit.org>
1155
1156         Reviewed by Adam Roben.
1157         
1158         Make pixel tests more useful!
1159         Finally fix the image diff 0.00% mystery problem
1160         Highlight any image differences in the image diff.
1161         Add a link from image diffs back to original test file.
1162
1163         * DumpRenderTree/mac/ImageDiff.m:
1164         (compareImages): highlight any differences
1165         (computePercentageDifferent): round to two decimal places
1166         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1167
1168 2007-10-02  Eric Seidel  <eric@webkit.org>
1169
1170         Reviewed by Alexey Proskuryakov.
1171
1172         * Scripts/run-webkit-tests: print the % image difference on main results page
1173
1174 2007-10-02  Mark Rowe  <mrowe@apple.com>
1175
1176         Reviewed by Oliver.
1177
1178         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1179
1180         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1181         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1182
1183 2007-10-01  Mark Rowe  <mrowe@apple.com>
1184
1185         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1186
1187 2007-09-25  Eric Seidel  <eric@webkit.org>
1188
1189         Reviewed by Mark Rowe.
1190         
1191         DerivedSources.make was finding "ENABLE_SVG" in the string
1192         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1193         quite correctly.
1194
1195         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1196
1197 2007-09-25  Mark Rowe  <mrowe@apple.com>
1198
1199         Rubber-stamped by Eric.
1200
1201         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1202         This makes it possible to automate nightly builds for the feature-branch.
1203
1204 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1205
1206         Rubber stamped by Mark.
1207
1208         Enable svg experimental features as default here in feature-branch.
1209
1210         * Scripts/build-webkit:
1211
1212 2007-06-29  Antti Koivisto  <antti@apple.com>
1213
1214         Reviewed by Weinig.
1215         
1216         Add VIDEO flag for timed media features
1217
1218         * Scripts/build-webkit
1219         
1220 === End merge of feature-branch 2007-10-12 ===
1221
1222 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1223
1224         Reviewed by Darin.
1225
1226         - Updated rational for the leaks list to be more clear.
1227
1228         * Scripts/run-webkit-tests:
1229
1230 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1231
1232         Rubber Stamp by Sam.
1233
1234         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1235         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1236
1237         * Scripts/run-webkit-tests:
1238
1239 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1240
1241         Reviewed by Lars.
1242
1243         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1244         includes are needed for INT_MAX, std::auto_ptr and the like.
1245
1246         * DumpRenderTree/qt/main.cpp:
1247
1248 2007-10-09  Lars Knoll  <lars@trolltech.com>
1249
1250         Reviewed by Simon.
1251
1252         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1253
1254         * DumpRenderTree/qt/jsobjects.cpp:
1255         (LayoutTestController::encodeHostName):
1256         (LayoutTestController::decodeHostName):
1257         * DumpRenderTree/qt/jsobjects.h:
1258
1259 2007-10-09  Lars Knoll  <lars@trolltech.com>
1260
1261         Reviewed by Simon.
1262
1263         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1264
1265         * DumpRenderTree/qt/DumpRenderTree.cpp:
1266         (WebCore::WebPage::createFrame):
1267         (WebCore::DumpRenderTree::DumpRenderTree):
1268         (WebCore::DumpRenderTree::titleChanged):
1269         * DumpRenderTree/qt/DumpRenderTree.h:
1270         * DumpRenderTree/qt/jsobjects.cpp:
1271         (LayoutTestController::reset):
1272         * DumpRenderTree/qt/jsobjects.h:
1273
1274 2007-10-09  Lars Knoll  <lars@trolltech.com>
1275
1276         Reviewed by Simon.
1277
1278         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1279
1280         * DumpRenderTree/qt/DumpRenderTree.h:
1281         * DumpRenderTree/qt/jsobjects.cpp:
1282         (LayoutTestController::clearBackForwardList):
1283         * DumpRenderTree/qt/jsobjects.h:
1284
1285 2007-10-09  Lars Knoll  <lars@trolltech.com>
1286
1287         Reviewed by Simon.
1288
1289         make --git-reviewer work again.
1290
1291         * Scripts/prepare-ChangeLog:
1292
1293 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1294
1295         Rubber stamped by Eric.
1296
1297         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1298         show the current link inside the statusbar.
1299         This shows how to make use of this signal and allows to easily test
1300         http://bugs.webkit.org/show_bug.cgi?id=15299.
1301
1302         * GtkLauncher/main.cpp:
1303         (hoveringOverLink):
1304         (main):
1305
1306 2007-10-05  Lars Knoll  <lars@trolltech.com>
1307
1308         add proper error messages to the FrameLoaderClient.
1309         Implement ChromeClientQt::closeWindowSoon and
1310         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1311         Some fixes in DRT to make it work correctly with multiple windows.
1312
1313         Reviewed by Maciej.
1314
1315         * DumpRenderTree/qt/DumpRenderTree.cpp:
1316         (WebCore::DumpRenderTree::DumpRenderTree):
1317         (WebCore::DumpRenderTree::createWindow):
1318         (WebCore::DumpRenderTree::windowCount):
1319         * DumpRenderTree/qt/DumpRenderTree.h:
1320         * DumpRenderTree/qt/jsobjects.cpp:
1321         (LayoutTestController::maybeDump):
1322         (LayoutTestController::windowCount):
1323         * DumpRenderTree/qt/jsobjects.h:
1324
1325 2007-10-05  Lars Knoll  <lars@trolltech.com>
1326
1327         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1328         Add support for layoutTextController.setCanOpenWindows() to DRT
1329         fixing another 2 test cases in fast/dom/Window.
1330
1331         Reviewed by Maciej.
1332
1333         * DumpRenderTree/qt/DumpRenderTree.cpp:
1334         (WebCore::WebPage::WebPage):
1335         (WebCore::WebPage::createWindow):
1336         (WebCore::DumpRenderTree::resetJSObjects):
1337         (WebCore::DumpRenderTree::createWindow):
1338         * DumpRenderTree/qt/DumpRenderTree.h:
1339         * DumpRenderTree/qt/DumpRenderTree.pro:
1340         * DumpRenderTree/qt/jsobjects.cpp:
1341         (LayoutTestController::LayoutTestController):
1342         (LayoutTestController::reset):
1343         * DumpRenderTree/qt/jsobjects.h:
1344         * DumpRenderTree/qt/main.cpp:
1345         * DumpRenderTree/qt/testplugin.cpp: Added.
1346         * DumpRenderTree/qt/testplugin.h: Added.
1347
1348 2007-10-04  Sam Weinig  <sam@webkit.org>
1349
1350         Rubber stamped by Adam.
1351
1352         Remove empty directories.
1353
1354         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1355         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1356
1357 2007-10-03  Darin Adler  <darin@apple.com>
1358
1359         Reviewed by Adam.
1360
1361         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1362         we find the internal libraries in the libraries directory. This
1363         is helpful for Safari team engineers at Apple.
1364
1365 2007-10-03  Adam Roben  <aroben@apple.com>
1366
1367         Update the location of AHEM___.TTF after r25968
1368
1369         Reviewed by Sam.
1370
1371         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1372
1373 2007-10-03  Alp Toker  <alp@atoker.com>
1374
1375         Reviewed by Adam.
1376
1377         http://bugs.webkit.org/show_bug.cgi?id=14726
1378         [gtk] API design. Mapping the WebView delegates to signals.
1379
1380         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1381
1382         * GtkLauncher/main.cpp:
1383         (goToURLBarText):
1384         (titleChanged):
1385         (progressChanged):
1386         (menuMainBackCallback):
1387         (menuMainForwardCallback):
1388         (main):
1389
1390 2007-10-03  Lars Knoll  <lars@trolltech.com>
1391
1392         Reviewed by Rob.
1393
1394         This fixes --strict mode in run-webkit-tests again after
1395         the platform dependent test results have been moved.
1396
1397         * Scripts/run-webkit-tests:
1398
1399 2007-10-03  Lars Knoll  <lars@trolltech.com>
1400
1401         Reviewed by bdash.
1402
1403         remove the hack in run-webkit-tests that forced text only test
1404         to be taken from the platform independent dir. It was only left
1405         there from early days.
1406         
1407         Remove platform dependent results for tests that are text only nowadays,
1408         and add one platform dependent result for a text only test that requires it.
1409
1410         * Scripts/run-webkit-tests:
1411
1412 2007-10-03  Lars Knoll  <lars@trolltech.com>
1413
1414         Reviewed by olliej.
1415
1416         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1417
1418         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1419         (WebCore::WebFrame::WebFrame):
1420         (WebCore::WebPage::WebPage):
1421         (WebCore::WebPage::createFrame):
1422         (WebCore::WebPage::javaScriptAlert):
1423         (WebCore::WebPage::javaScriptConsoleMessage):
1424         (WebCore::DumpRenderTree::DumpRenderTree):
1425         (WebCore::DumpRenderTree::~DumpRenderTree):
1426         (WebCore::DumpRenderTree::open):
1427         (WebCore::DumpRenderTree::readStdin):
1428         (WebCore::DumpRenderTree::resetJSObjects):
1429         (WebCore::DumpRenderTree::initJSObjects):
1430         (WebCore::DumpRenderTree::dumpFramesAsText):
1431         (WebCore::DumpRenderTree::dump):
1432         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1433         (WebCore::DumpRenderTree::layoutTestController):
1434         (WebCore::DumpRenderTree::eventSender):
1435         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1436         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1437         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1438         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1439         (HackWebFrame::mousePressEvent):
1440         (HackWebFrame::mouseReleaseEvent):
1441         (HackWebFrame::mouseMoveEvent):
1442         (HackWebFrame::HackWebFrame):
1443         (HackWebFrame::~HackWebFrame):
1444         (LayoutTestController::LayoutTestController):
1445         (LayoutTestController::reset):
1446         (LayoutTestController::maybeDump):
1447         (LayoutTestController::waitUntilDone):
1448         (LayoutTestController::notifyDone):
1449         (LayoutTestController::dumpEditingCallbacks):
1450         (LayoutTestController::queueReload):
1451         (LayoutTestController::provisionalLoad):
1452         (LayoutTestController::timerEvent):
1453         (EventSender::EventSender):
1454         (EventSender::mouseDown):
1455         (EventSender::mouseUp):
1456         (EventSender::mouseMoveTo):
1457         (EventSender::leapForward):
1458         (EventSender::keyDown):
1459         (EventSender::frameUnderMouse):
1460         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1461         (LayoutTestController::isLoading):
1462         (LayoutTestController::setLoading):
1463         (LayoutTestController::shouldDumpAsText):
1464         (LayoutTestController::shouldDumpChildrenAsText):
1465         (LayoutTestController::shouldWaitUntilDone):
1466         (LayoutTestController::dumpAsText):
1467         (LayoutTestController::dumpChildFramesAsText):
1468         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1469         (messageHandler):
1470         (crashHandler):
1471         (main):
1472         * Scripts/run-webkit-tests:
1473
1474 2007-10-03  Mark Rowe  <mrowe@apple.com>
1475
1476         Reviewed by Alp Toker.
1477
1478         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1479         should take precedence over QTDIR when determining which port we are working with.
1480
1481         * Scripts/webkitdirs.pm: 
1482
1483 2007-10-02  Adam Roben  <aroben@apple.com>
1484
1485         Add keychain to the list of default packages to install
1486
1487         Rubberstamped by Sam.
1488
1489         * CygwinDownloader/cygwin-downloader.py:
1490         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1491
1492 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1493
1494         Reviewed by Adam.
1495
1496         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1497         Also makes WebCore regression test case logic work when using git.
1498
1499         * Scripts/prepare-ChangeLog:
1500         (reviewerAndDescriptionForGitCommit): Added.
1501
1502 2007-10-02  Lars Knoll  <lars@trolltech.com>
1503
1504         Reviewed by bdash.
1505
1506         Add API to retrieve the frame name from QWebFrame.
1507         Implement support for DRT::dumpChildrenAsText.
1508
1509         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1510         (WebCore::DumpRenderTree::dumpFramesAsText):
1511         (WebCore::DumpRenderTree::dump):
1512         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1513         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1514         (LayoutTestController::LayoutTestController):
1515         (LayoutTestController::reset):
1516         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1517
1518 2007-10-02  Lars Knoll  <lars@trolltech.com>
1519
1520         Reviewed by bdash.
1521
1522         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1523
1524         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1525         (WebCore::DumpRenderTree::readStdin):
1526
1527 2007-10-02  Mark Rowe  <mrowe@apple.com>
1528
1529         Reviewed by Oliver.
1530
1531         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1532
1533         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1534         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1535
1536 2007-10-02  Mark Rowe  <mrowe@apple.com>
1537
1538         Rubber-stamped by Maciej.
1539
1540         Configuration changes from build.webkit.org.  The major change is refactoring to work
1541         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1542         last few weeks.
1543
1544         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1545         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1546         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1547         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1548         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1549         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1550         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1551         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1552
1553 2007-10-02  Lars Knoll  <lars@trolltech.com>
1554
1555         Reviewed by Maciej.
1556
1557         Add support for eventSender.mouseMove to DRT.
1558         Fixes fast/css/hover-affects-child.html
1559
1560         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1561         (EventSender::mouseMoveTo):
1562
1563 2007-10-01  Mark Rowe  <mrowe@apple.com>
1564
1565         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1566
1567 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1568
1569         Reviewed by Hyatt.
1570
1571         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1572
1573         * Scripts/svn-apply:
1574         (gitdiff2svndiff): Ignore lines beginning with "new file".
1575         * Scripts/svn-unapply:
1576         (gitdiff2svndiff): Ditto.
1577
1578 2007-09-30  George Staikos  <staikos@kde.org>
1579
1580         Qt build fix (Mac OS X specific)
1581
1582         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1583
1584 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1585
1586         Reviewed by Mark.
1587
1588         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1589         Remove Bakefiles from svn.
1590
1591         * GtkLauncher/Bakefiles.bkgen: Removed.
1592         * GtkLauncher/ENV: Removed.
1593         * GtkLauncher/gdklauncher.bkl: Removed.
1594         * GtkLauncher/mk: Removed.
1595         * Scripts/regenerate-makefiles: Removed.
1596
1597 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1598
1599         Reviewed by John.
1600
1601         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1602
1603         * Scripts/run-webkit-tests:
1604
1605 2007-09-26  Adam Roben  <aroben@apple.com>
1606
1607         Make not finding an installed WebKit non-fatal
1608
1609         What really matters is that we are able to load WebKit and its
1610         dependencies, not whether we think we've found an installed WebKit.
1611
1612         Reviewed by Sam.
1613
1614         * WebKitInitializer/WebKitInitializer.cpp:
1615         (getWebViewCLSID): Use new LOG_WARNING macro.
1616         (getInstalledWebKitDirectory): Ditto.
1617         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1618         and use new macros.
1619         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1620
1621 2007-09-26  Adam Roben  <aroben@apple.com>
1622
1623         Committed this file before saving it
1624
1625         * WebKitInitializer/debug_internal.vsprops:
1626
1627 2007-09-26  Adam Roben  <aroben@apple.com>
1628
1629         Load WebKit and its dependencies manually so they come from DllDirectory
1630
1631         I had to change WebKitInitializer to use malloc/free instead of
1632         new/delete to avoid pulling in WebKit (and its dependencies) early
1633         through use of fastMalloc.
1634
1635         Reviewed by Oliver.
1636
1637         * WebKitInitializer/WebKitInitializer.cpp:
1638         (getStringValue): Changed to use malloc/free.
1639         (getInstalledWebKitDirectory): Ditto.
1640         (initializeWebKit): Call SetDllDirectory first, then load all of
1641         WebKit's dependencies manually, finally followed by WebKit itself.
1642         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1643         configuration to match our other projects.
1644         * WebKitInitializer/debug_internal.vsprops: Added.
1645
1646 2007-09-25  Adam Roben  <aroben@apple.com>
1647
1648         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1649
1650         Rubberstamped by Sam.
1651
1652         * WebKitInitializer/WebKitInitializer.vcproj:
1653
1654 2007-09-25  Adam Roben  <aroben@apple.com>
1655
1656         Make DumpRenderTree delay-load its dependencies
1657
1658         This lets WebKitInitializer re-route the dependencies to be loaded out
1659         of the Safari installation directory.
1660
1661         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1662         same thing), since we can't import the kCFAllocatorDefault symbol when
1663         delay-loading CoreFoundation.dll.
1664
1665         Rubberstamped by Sam.
1666
1667         * DumpRenderTree/win/DumpRenderTree.cpp:
1668         (runTest):
1669         (javaScriptThreads):
1670         * DumpRenderTree/win/DumpRenderTree.vcproj:
1671         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1672         (LayoutTestController::setWaitToDump):
1673
1674 2007-09-25  Adam Roben  <aroben@apple.com>
1675
1676         Pull ole32.lib into WebKitInitializer
1677
1678         Rubberstamped by Sam.
1679
1680         * WebKitInitializer/WebKitInitializer.vcproj:
1681
1682 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1683
1684         Reviewed by Adam.
1685
1686         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1687           LGPL'ed files contain incorrect FSF address
1688
1689         * Drosera/config.h:
1690
1691 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1692
1693         Reviewed by Adam.
1694
1695         Make svn-apply and svn-unapply work with git-diff formatted patches.
1696
1697         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1698         (gitdiff2svndiff): Added.
1699         * Scripts/svn-unapply: Ditto.
1700         (gitdiff2svndiff): Added.
1701
1702 2007-09-25  Adam Roben  <aroben@apple.com>
1703
1704         Pull advapi32.lib into WebKitInitializer
1705
1706         This is needed to get the registry functions we use.
1707
1708         Rubberstamped by Sam.
1709
1710         * WebKitInitializer/WebKitInitializer.vcproj:
1711
1712 2007-09-25  Adam Roben  <aroben@apple.com>
1713
1714         Add python and rsync to cygwin-downloader
1715
1716         Our build slaves need this, and it can't hurt for everyone else to
1717         have it, too.
1718
1719         Reviewed by Sam.
1720
1721         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1722         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1723
1724 2007-09-25  Adam Roben  <aroben@apple.com>
1725
1726         Add WebKitInitializer and use it in DumpRenderTree
1727
1728         WebKitInitializer is a static library that has one function,
1729         initializeWebKit(). This registers WebKit and sets up the DLL search
1730         path so that WebKit's dependencies that are installed with Safari can
1731         be found.
1732
1733         Reviewed by Sam.
1734
1735         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1736         DumpRenderTree depend on it.
1737         * DumpRenderTree/win/DumpRenderTree.cpp:
1738         (initialize): Call initializeWebKit.
1739         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1740         WebKitInitializer.lib.
1741         * WebKitInitializer/WebKitInitializer.cpp: Added.
1742         (getStringValue):
1743         (getWebViewCLSID):
1744         (getInstalledWebKitDirectory):
1745         (initializeWebKit):
1746         * WebKitInitializer/WebKitInitializer.h: Added.
1747         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1748         * WebKitInitializer/debug.vsprops: Added.
1749         * WebKitInitializer/release.vsprops: Added.
1750
1751 2007-09-25  Adam Roben  <aroben@apple.com>
1752
1753         Make run-webkit-tests respect set-webkit-configuration
1754
1755         Reviewed by Sam.
1756
1757         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1758         set-webkit-configuration was last set to.
1759
1760 2007-09-25  Mark Rowe  <mrowe@apple.com>
1761
1762         Rubber-stamped by Eric.
1763
1764         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1765         This makes it possible to automate nightly builds for the feature-branch.
1766
1767 2007-09-25  Adam Roben  <aroben@apple.com>
1768
1769         A couple of fixes/enhancements to update-webkit-*-libs
1770
1771         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1772         to tell update-webkit-support-libraries where it should find the
1773         WebKitSupportLibrary.zip file you downloaded.
1774
1775         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1776         Windows-style path.
1777
1778         Reviewed by Sam.
1779
1780         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1781         to $auxiliaryLibsURL and removed an irrelevant comment.
1782         * Scripts/update-webkit-support-libs:
1783
1784 2007-09-25  Adam Treat  <treat@kde.org>
1785
1786         Reviewed by Simon and Lars.
1787
1788         Refactors and cleans up Qt DRT member variable names, member variable
1789         initialization, style fixes and general code cleanup.
1790
1791         Adds queueReload slot to LayoutTestController that some tests require.
1792
1793         Subclasses QWebFrame to make sure that all frames have an associated
1794         LayoutTestController JS window object.
1795
1796         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1797         aren't dumped twice.
1798
1799         EOF fixes.
1800
1801         Together, this patch fixes some 20+ layout tests in QtWebKit.
1802
1803         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1804         (WebCore::WebFrame::WebFrame):
1805         (WebCore::WebPage::WebPage):
1806         (WebCore::WebPage::createFrame):
1807         (WebCore::DumpRenderTree::DumpRenderTree):
1808         (WebCore::DumpRenderTree::open):
1809         (WebCore::DumpRenderTree::readStdin):
1810         (WebCore::DumpRenderTree::initJSObjects):
1811         (WebCore::DumpRenderTree::dump):
1812         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1813         (WebCore::DumpRenderTree::layoutTestController):
1814         (WebCore::DumpRenderTree::eventSender):
1815         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1816         (LayoutTestController::LayoutTestController):
1817         (LayoutTestController::reset):
1818         (LayoutTestController::maybeDump):
1819         (LayoutTestController::waitUntilDone):
1820         (LayoutTestController::notifyDone):
1821         (LayoutTestController::queueReload):
1822         (LayoutTestController::provisionalLoad):
1823         (EventSender::EventSender):
1824         (EventSender::mouseDown):
1825         (EventSender::mouseUp):
1826         (EventSender::mouseMoveTo):
1827         (EventSender::frameUnderMouse):
1828         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1829         (LayoutTestController::isLoading):
1830         (LayoutTestController::setLoading):
1831         (LayoutTestController::dumpAsText):
1832         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
1833         (main):
1834
1835 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1836
1837
1838         - Reverted an accidentally checked in file.
1839
1840         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1841
1842 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1843         Reviewed by Sam.
1844
1845         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
1846
1847         * DumpRenderTree/win/DumpRenderTree.vcproj:
1848         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1849
1850 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1851
1852         Rubber stamped by Adam.
1853
1854         * GdkLauncher: Removed.
1855         * GdkLauncher/Bakefiles.bkgen: Removed.
1856         * GdkLauncher/ENV: Removed.
1857         * GdkLauncher/GdkLauncher.pro: Removed.
1858         * GdkLauncher/gdklauncher.bkl: Removed.
1859         * GdkLauncher/main.cpp: Removed.
1860         * GdkLauncher/mk: Removed.
1861         * GdkLauncher/simple.svg: Removed.
1862         * GdkLauncher/text.html: Removed.
1863         * GtkLauncher: Added.
1864         * GtkLauncher/GdkLauncher.pro: Removed.
1865         * GtkLauncher/GtkLauncher.pro: Added.
1866         * GtkLauncher/main.cpp:
1867         (updateWindowTitle):
1868         (main):
1869         * Scripts/build-webkit:
1870         * Scripts/regenerate-makefiles:
1871         * Scripts/run-javascriptcore-tests:
1872         * Scripts/run-launcher:
1873         * Scripts/run-webkit-tests:
1874         * Scripts/webkitdirs.pm:
1875
1876 2007-09-21  Timothy Hatcher  <timothy@apple.com>
1877
1878         Reviewed by Darin.
1879
1880         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
1881
1882         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
1883         This is tested by plugins/root-object-premature-delete-crash.html.
1884
1885         * DumpRenderTree/mac/ObjCController.m:
1886         (-[ObjCController accessStoredWebScriptObject]):
1887
1888 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
1889
1890         Reviewed by Oliver.
1891
1892         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
1893
1894         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1895         (FrameLoadDelegate::FrameLoadDelegate):
1896
1897 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
1898
1899         Reviewed by Adam.
1900
1901         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
1902         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
1903
1904         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
1905         Now isQt() and isGdk() use global variables that are only set once.
1906
1907         An array of all the parameters is now given to build-dumprender which includes
1908         the platform on linux.
1909
1910         * Scripts/build-dumprendertree:
1911         * Scripts/run-webkit-tests:
1912         * Scripts/webkitdirs.pm:
1913
1914 2007-09-19  Adam Roben  <aroben@apple.com>
1915
1916         Rubberstamped by Hyatt.
1917
1918         * Spinneret: Removed.
1919
1920 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
1921
1922         Reviewed by David Kilzer.
1923
1924         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
1925
1926 2007-09-18  Sam Weinig  <sam@webkit.org>
1927
1928         Add JSRetainPtr.h #include to fix some builds.
1929
1930         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1931
1932 2007-09-18  Mike Hommey  <glandium@debian.org>
1933
1934         Reviewed by Adam.
1935
1936         * Scripts/prepare-ChangeLog:
1937         - Properly parse GECOS field.
1938         - Use git configuration for user name and email when appropriate.
1939
1940 2007-09-17  Sam Weinig  <sam@webkit.org>
1941
1942         Build fix.
1943
1944         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1945
1946 2007-09-17  Sam Weinig  <sam@webkit.org>
1947
1948         Reviewed by Adam Roben.
1949
1950         Share more code between mac and windows DRT.
1951             - GCController is now shared.
1952             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
1953
1954         * DumpRenderTree/GCController.cpp:
1955         * DumpRenderTree/win/DumpRenderTree.cpp:
1956         * DumpRenderTree/win/DumpRenderTree.vcproj:
1957         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
1958         (FrameLoadDelegate::FrameLoadDelegate):
1959         (FrameLoadDelegate::~FrameLoadDelegate):
1960         (FrameLoadDelegate::windowScriptObjectAvailable):
1961         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
1962         * DumpRenderTree/win/GCController.cpp: Removed.
1963         * DumpRenderTree/win/GCController.h: Removed.
1964         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
1965         (GCController::collect):
1966         (GCController::collectOnAlternateThread):
1967         (GCController::getJSObjectCount):
1968         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
1969         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
1970
1971 2007-09-17  Sam Weinig  <sam@webkit.org>
1972
1973         Reviewed by Adam Roben.
1974
1975         Begin sharing code between mac and windows DRT.
1976             - both now share LayoutTestController.h/cpp and implement platform dependant 
1977               operations in LayoutTestControllerMac/Win.
1978             - DumpRenderTree.h is now shared.
1979             - WorkQueue and WorkQueueItem are also shared.
1980
1981         * DumpRenderTree/DumpRenderTree.h:
1982         * DumpRenderTree/LayoutTestController.cpp:
1983         * DumpRenderTree/win/DumpRenderTree.cpp:
1984         (displayWebView):
1985         (dumpFrameScrollPosition):
1986         (dumpFramesAsText):
1987         (dump):
1988         (runTest):
1989         * DumpRenderTree/win/DumpRenderTree.h: Removed.
1990         * DumpRenderTree/win/DumpRenderTree.vcproj:
1991         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
1992         * DumpRenderTree/win/EditingDelegate.cpp:
1993         (EditingDelegate::shouldBeginEditingInDOMRange):
1994         (EditingDelegate::shouldEndEditingInDOMRange):
1995         (EditingDelegate::shouldInsertNode):
1996         (EditingDelegate::shouldInsertText):
1997         (EditingDelegate::shouldDeleteDOMRange):
1998         (EditingDelegate::shouldChangeSelectedDOMRange):
1999         (EditingDelegate::shouldApplyStyle):
2000         (EditingDelegate::shouldChangeTypingStyle):
2001         (EditingDelegate::doPlatformCommand):
2002         (EditingDelegate::webViewDidBeginEditing):
2003         (EditingDelegate::webViewDidChange):
2004         (EditingDelegate::webViewDidEndEditing):
2005         (EditingDelegate::webViewDidChangeTypingStyle):
2006         (EditingDelegate::webViewDidChangeSelection):
2007         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2008         * DumpRenderTree/win/LayoutTestController.h: Removed.
2009         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2010         (LayoutTestController::addDisallowedURL):
2011         (LayoutTestController::clearBackForwardList):
2012         (LayoutTestController::copyDecodedHostName):
2013         (LayoutTestController::copyEncodedHostName):
2014         (LayoutTestController::display):
2015         (LayoutTestController::keepWebHistory):
2016         (LayoutTestController::notifyDone):
2017         (LayoutTestController::queueBackNavigation):
2018         (LayoutTestController::queueForwardNavigation):
2019         (jsStringRefToWString):
2020         (LayoutTestController::queueLoad):
2021         (LayoutTestController::queueReload):
2022         (LayoutTestController::queueScript):
2023         (LayoutTestController::setAcceptsEditing):
2024         (LayoutTestController::setCustomPolicyDelegate):
2025         (LayoutTestController::setMainFrameIsFirstResponder):
2026         (LayoutTestController::setTabKeyCyclesThroughElements):
2027         (LayoutTestController::setUseDashboardCompatibilityMode):
2028         (LayoutTestController::setUserStyleSheetEnabled):
2029         (LayoutTestController::setUserStyleSheetLocation):
2030         (LayoutTestController::setWindowIsKey):
2031         (waitUntilDoneWatchdogFired):
2032         (LayoutTestController::setWaitToDump):
2033         (LayoutTestController::windowCount):
2034         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2035         (FrameLoadDelegate::didReceiveTitle):
2036         (FrameLoadDelegate::processWork):
2037         (FrameLoadDelegate::locationChangeDone):
2038         (FrameLoadDelegate::windowScriptObjectAvailable):
2039         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2040         * DumpRenderTree/win/WorkQueue.h: Removed.
2041         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2042         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2043         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2044         (jsStringRefToWString):
2045         (LoadItem::invoke):
2046         (ScriptItem::invoke):
2047
2048 2007-09-17  Sam Weinig  <sam@webkit.org>
2049
2050         Reviewed by Adam Roben.
2051
2052         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2053
2054         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2055         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2056         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2057         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2058         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2059         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2060         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2061         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2062         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2063         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2064         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2065         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2066         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2067         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2068         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2069         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2070         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2071         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2072         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2073         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2074         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2075         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2076         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2077         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2078         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2079         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2080         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2081         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2082         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2083         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2084         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2085         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2086         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2087         * DumpRenderTree/win: Added.
2088         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2089         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2090         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2091         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2092         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2093         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2094         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2095         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2096         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2097         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2098         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2099         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2100         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2101         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2102         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2103         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2104         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2105         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2106         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2107         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2108         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2109         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2110         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2111         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2112         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2113         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2114
2115 2007-09-15  Mark Rowe  <mrowe@apple.com>
2116
2117         Build fix for DumpRenderTree.
2118
2119         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2120
2121 2007-09-14  Sam Weinig  <sam@webkit.org>
2122
2123         Rubber stamped by Adam Roben.
2124
2125         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2126           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2127             kept in the WaitUntilDoneDelegate file for the time being.
2128
2129         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2130         (main):
2131         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2132         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2133         (UIDelegate::QueryInterface):
2134         (UIDelegate::AddRef):
2135         (UIDelegate::Release):
2136         (UIDelegate::hasCustomMenuImplementation):
2137         (UIDelegate::setFrame):
2138         (UIDelegate::webViewFrame):
2139         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2140         (UIDelegate::webViewAddMessageToConsole):
2141         (UIDelegate::doDragDrop):
2142         (UIDelegate::webViewGetDlgCode):
2143         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2144         (UIDelegate::UIDelegate):
2145         (UIDelegate::createWebViewWithRequest):
2146         (UIDelegate::webViewShow):
2147         (UIDelegate::webViewClose):
2148         (UIDelegate::webViewFocus):
2149         (UIDelegate::webViewUnfocus):
2150         (UIDelegate::webViewFirstResponder):
2151         (UIDelegate::makeFirstResponder):
2152         (UIDelegate::setStatusText):
2153         (UIDelegate::webViewStatusText):
2154         (UIDelegate::webViewAreToolbarsVisible):
2155         (UIDelegate::setToolbarsVisible):
2156         (UIDelegate::webViewIsStatusBarVisible):
2157         (UIDelegate::setStatusBarVisible):
2158         (UIDelegate::webViewIsResizable):
2159         (UIDelegate::setResizable):
2160         (UIDelegate::setContentRect):
2161         (UIDelegate::webViewContentRect):
2162         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2163         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2164         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2165         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2166         (UIDelegate::mouseDidMoveOverElement):
2167         (UIDelegate::contextMenuItemsForElement):
2168         (UIDelegate::validateUserInterfaceItem):
2169         (UIDelegate::shouldPerformAction):
2170         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2171         (UIDelegate::willPerformDragDestinationAction):
2172         (UIDelegate::dragSourceActionMaskForPoint):
2173         (UIDelegate::willPerformDragSourceAction):
2174         (UIDelegate::contextMenuItemSelected):
2175         (UIDelegate::trackCustomPopupMenu):
2176         (UIDelegate::measureCustomMenuItem):
2177         (UIDelegate::drawCustomMenuItem):
2178         (UIDelegate::addCustomMenuDrawingData):
2179         (UIDelegate::cleanUpCustomMenuDrawingData):
2180         (UIDelegate::canTakeFocus):
2181         (UIDelegate::takeFocus):
2182         (UIDelegate::registerUndoWithTarget):
2183         (UIDelegate::removeAllActionsWithTarget):
2184         (UIDelegate::setActionTitle):
2185         (UIDelegate::undo):
2186         (UIDelegate::redo):
2187         (UIDelegate::canUndo):
2188         (UIDelegate::canRedo):
2189         (UIDelegate::webViewResizerRect):
2190         (UIDelegate::webViewDrawResizer):
2191         (UIDelegate::webViewScrolled):
2192         (UIDelegate::webViewShouldInterruptJavaScript):
2193         (UIDelegate::webViewReceivedFocus):
2194         (UIDelegate::webViewLostFocus):
2195         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2196         (FrameLoadDelegate::QueryInterface):
2197         (FrameLoadDelegate::AddRef):
2198         (FrameLoadDelegate::Release):
2199         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2200         (FrameLoadDelegate::didCommitLoadForFrame):
2201         (FrameLoadDelegate::didReceiveTitle):
2202         (FrameLoadDelegate::processWork):
2203         (processWorkTimer):
2204         (FrameLoadDelegate::locationChangeDone):
2205         (FrameLoadDelegate::didFinishLoadForFrame):
2206         (FrameLoadDelegate::didFailLoadWithError):
2207         (FrameLoadDelegate::windowScriptObjectAvailable):
2208         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2209         (FrameLoadDelegate::FrameLoadDelegate):
2210
2211 2007-09-14  Sam Weinig  <sam@webkit.org>
2212
2213         Reviewed by Kevin McCullough.
2214
2215         Move mac specific globals in to mac/DumpRenderTreeMac.h
2216
2217         * DumpRenderTree/DumpRenderTree.h:
2218         * DumpRenderTree/DumpRenderTree.mm: Removed.
2219         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2220         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2221         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2222
2223 2007-09-14  Brady Eidson  <beidson@apple.com>
2224
2225         Rubberstamped by Weinig
2226
2227         You know, Sam, some of us use case-sensitve filesystems...
2228
2229         * DumpRenderTree/DumpRenderTree.h:
2230         * DumpRenderTree/mac/UIDelegate.mm:
2231
2232 2007-09-14  Sam Weinig  <sam@webkit.org>
2233
2234         Rubber stamped by Adam Roben.
2235
2236         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2237         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2238
2239         * DumpRenderTree/AppleScriptController.h: Removed.
2240         * DumpRenderTree/AppleScriptController.m: Removed.
2241         * DumpRenderTree/DumpRenderTree.h:
2242         * DumpRenderTree/DumpRenderTree.mm:
2243         (startJavaScriptThreads):
2244         (stopJavaScriptThreads):
2245         (activateAhemFont):
2246         (setDefaultColorProfileToRGB):
2247         (makeLargeMallocFailSilently):
2248         (dumpFrameScrollPosition):
2249         (dumpFramesAsText):
2250         (dump):
2251         (runTest):
2252         (-[DumpRenderTreeWindow isKeyWindow]):
2253         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2254         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2255         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2256         * DumpRenderTree/EditingDelegate.h: Removed.
2257         * DumpRenderTree/EditingDelegate.m: Removed.
2258         * DumpRenderTree/EventSendingController.h: Removed.
2259         * DumpRenderTree/EventSendingController.m: Removed.
2260         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2261         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2262         * DumpRenderTree/GCController.mm: Removed.
2263         * DumpRenderTree/ImageDiff.m: Removed.
2264         * DumpRenderTree/LayoutTestController.cpp:
2265         (LayoutTestController::LayoutTestController):
2266         (dumpAsTextCallback):
2267         (dumpBackForwardListCallback):
2268         (dumpChildFramesAsTextCallback):
2269         (dumpChildFrameScrollPositionsCallback):
2270         (dumpDOMAsWebArchiveCallback):
2271         (dumpEditingCallbacksCallback):
2272         (dumpFrameLoadCallbacksCallback):
2273         (dumpResourceLoadCallbacksCallback):
2274         (dumpSelectionRectCallback):
2275         (dumpSourceAsWebArchiveCallback):
2276         (dumpTitleChangesCallback):
2277         (repaintSweepHorizontallyCallback):
2278         (setCallCloseOnWebViewsCallback):
2279         (setCanOpenWindowsCallback):
2280         (setCloseRemainingWindowsWhenCompleteCallback):
2281         (testRepaintCallback):
2282         (addFileToPasteboardOnDragCallback):
2283         (waitUntilDoneCallback):
2284         * DumpRenderTree/LayoutTestController.h:
2285         (LayoutTestController::dumpAsText):
2286         (LayoutTestController::setDumpAsText):
2287         (LayoutTestController::dumpBackForwardList):
2288         (LayoutTestController::setDumpBackForwardList):
2289         (LayoutTestController::dumpChildFrameScrollPositions):
2290         (LayoutTestController::setDumpChildFrameScrollPositions):
2291         (LayoutTestController::dumpChildFramesAsText):
2292         (LayoutTestController::setDumpChildFramesAsText):
2293         (LayoutTestController::dumpDOMAsWebArchive):
2294         (LayoutTestController::setDumpDOMAsWebArchive):
2295         (LayoutTestController::dumpSelectionRect):
2296         (LayoutTestController::setDumpSelectionRect):
2297         (LayoutTestController::dumpSourceAsWebArchive):
2298         (LayoutTestController::setDumpSourceAsWebArchive):
2299         (LayoutTestController::dumpTitleChanges):
2300         (LayoutTestController::setDumpTitleChanges):
2301         (LayoutTestController::dumpEditingCallbacks):
2302         (LayoutTestController::setDumpEditingCallbacks):
2303         (LayoutTestController::dumpResourceLoadCallbacks):
2304         (LayoutTestController::setDumpResourceLoadCallbacks):
2305         (LayoutTestController::dumpFrameLoadCallbacks):
2306         (LayoutTestController::setDumpFrameLoadCallbacks):
2307         (LayoutTestController::addFileToPasteboardOnDrag):
2308         (LayoutTestController::setAddFileToPasteboardOnDrag):
2309         (LayoutTestController::callCloseOnWebViews):
2310         (LayoutTestController::setCallCloseOnWebViews):
2311         (LayoutTestController::canOpenWindows):
2312         (LayoutTestController::setCanOpenWindows):
2313         (LayoutTestController::closeRemainingWindowsWhenComplete):
2314         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2315         (LayoutTestController::testRepaint):
2316         (LayoutTestController::setTestRepaint):
2317         (LayoutTestController::testRepaintSweepHorizontally):
2318         (LayoutTestController::setTestRepaintSweepHorizontally):
2319         (LayoutTestController::waitToDump):
2320         (LayoutTestController::windowIsKey):
2321         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2322         * DumpRenderTree/NavigationController.h: Removed.
2323         * DumpRenderTree/NavigationController.m: Removed.
2324         * DumpRenderTree/ObjCController.h: Removed.
2325         * DumpRenderTree/ObjCController.m: Removed.
2326         * DumpRenderTree/ObjCPlugin.h: Removed.
2327         * DumpRenderTree/ObjCPlugin.m: Removed.
2328         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2329         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2330         * DumpRenderTree/PolicyDelegate.h: Removed.
2331         * DumpRenderTree/PolicyDelegate.m: Removed.
2332         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2333         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2334         * DumpRenderTree/TextInputController.h: Removed.
2335         * DumpRenderTree/TextInputController.m: Removed.
2336         * DumpRenderTree/UIDelegate.h: Removed.
2337         * DumpRenderTree/UIDelegate.mm: Removed.
2338         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2339         * DumpRenderTree/mac: Added.
2340         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2341         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2342         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2343         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2344         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2345         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2346         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2347         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2348         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2349         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2350         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2351         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2352         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2353         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2354         (-[EditingDelegate webViewDidBeginEditing:]):
2355         (-[EditingDelegate webViewDidChange:]):
2356         (-[EditingDelegate webViewDidEndEditing:]):
2357         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2358         (-[EditingDelegate webViewDidChangeSelection:]):
2359         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2360         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2361         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2362         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2363         (-[FrameLoadDelegate init]):
2364         (-[FrameLoadDelegate dealloc]):
2365         (-[FrameLoadDelegate processWork:]):
2366         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2367         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2368         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2369         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2370         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2371         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2372         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2373         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2374         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2375         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2376         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2377         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2378         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2379         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2380         (-[FrameLoadDelegate webView:willCloseFrame:]):
2381         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2382         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2383         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2384         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2385         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2386         (LayoutTestController::notifyDone):
2387         (LayoutTestController::setWindowIsKey):
2388         (LayoutTestController::setWaitToDump):
2389         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2390         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2391         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2392         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2393         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2394         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2395         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2396         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2397         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2398         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2399         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2400         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2401         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2402         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2403         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2404         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2405         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2406         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2407         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2408         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2409         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2410         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2411         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2412         (-[UIDelegate webViewFocus:]):
2413         (-[UIDelegate webView:createWebViewWithRequest:]):
2414         (-[UIDelegate webViewClose:]):
2415         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2416
2417 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2418
2419         Reviewed by Adam.
2420
2421         - Changing Win version of Drosera work with recent changes.
2422
2423         * Drosera/DebuggerDocument.cpp:
2424         * Drosera/DebuggerDocument.h:
2425         * Drosera/mac/DebuggerDocumentPlatform.mm:
2426         (NSStringCreateWithJSStringRef):
2427         (JSValueRefCreateWithNSString):
2428         * Drosera/win/DebuggerClient.cpp:
2429         (DebuggerClient::stepInto):
2430         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2431
2432 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2433
2434         Reviewed by Tim.
2435
2436         - Moved isPaused into the JS for efficiency and simplicity.
2437
2438         * Drosera/DebuggerDocument.cpp:
2439         (DebuggerDocument::DebuggerDocument):
2440         (DebuggerDocument::pauseCallback):
2441         (DebuggerDocument::resumeCallback):
2442         (DebuggerDocument::isPaused):
2443         (DebuggerDocument::staticFunctions):
2444         * Drosera/DebuggerDocument.h:
2445         * Drosera/console.js:
2446         * Drosera/debugger.js:
2447         * Drosera/mac/DebuggerClient.mm:
2448         (-[DebuggerClient validateUserInterfaceItem:]):
2449
2450 2007-09-13  Sam Weinig  <sam@webkit.org>
2451
2452         Rubber stamped by Darin.
2453
2454         Make DumpRenderTree more cross platform ready.
2455         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2456         - Use CF types instead of NS objects.
2457         - General cleanup.
2458
2459         * DumpRenderTree/DumpRenderTree.h:
2460         * DumpRenderTree/DumpRenderTree.mm:
2461         (dumpRenderTree):
2462         (dump):
2463         (runTest):
2464         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2465         * DumpRenderTree/EditingDelegate.m:
2466         * DumpRenderTree/FrameLoadDelegate.h:
2467         * DumpRenderTree/FrameLoadDelegate.mm:
2468         (-[FrameLoadDelegate init]):
2469         (-[FrameLoadDelegate dealloc]):
2470         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2471         * DumpRenderTree/GCController.cpp: Added.
2472         (GCController::GCController):
2473         (GCController::~GCController):
2474         (collectCallback):
2475         (collectOnAlternateThreadCallback):
2476         (getJSObjectCountCallback):
2477         (GCController::makeWindowObject):
2478         (GCController::getJSClass):
2479         (GCController::staticFunctions):
2480         * DumpRenderTree/GCController.h:
2481         * DumpRenderTree/GCController.mm:
2482         (GCController::collect):
2483         (GCController::collectOnAlternateThread):
2484         (GCController::getJSObjectCount):
2485         * DumpRenderTree/LayoutTestController.cpp:
2486         (LayoutTestController::makeWindowObject):
2487         (LayoutTestController::getJSClass):
2488         * DumpRenderTree/LayoutTestController.h:
2489         * DumpRenderTree/LayoutTestControllerMac.mm:
2490         (LayoutTestController::addDisallowedURL):
2491         (waitUntilDoneWatchdogFired):
2492         (LayoutTestController::waitUntilDone):
2493         * DumpRenderTree/ResourceLoadDelegate.m:
2494         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2495
2496 2007-09-12  Sam Weinig  <sam@webkit.org>
2497
2498         Reviewed by Stephanie.
2499
2500         Fix leaks in mac DumpRenderTree.
2501
2502         * DumpRenderTree/FrameLoadDelegate.mm:
2503         (-[FrameLoadDelegate init]): Initalize in the correct order.
2504         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2505         * DumpRenderTree/LayoutTestController.cpp:
2506         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2507         (encodeHostNameCallback): ditto.
2508         * DumpRenderTree/LayoutTestController.h:
2509         * DumpRenderTree/LayoutTestControllerMac.mm:
2510         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2511         (LayoutTestController::copyEncodedHostName): ditto
2512         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2513
2514 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2515
2516         Reviewed by Geof.
2517
2518         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2519
2520         * Scripts/run-webkit-tests:
2521
2522 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2523
2524         Reviewed by Darin.
2525
2526         - Simplified code paths and extracted out functions to increase encapsulation.
2527
2528         * Drosera/DebuggerDocument.cpp:
2529         (DebuggerDocument::breakpointEditorHTMLCallback):
2530         (DebuggerDocument::isPausedCallback):
2531         (DebuggerDocument::pauseCallback):
2532         (DebuggerDocument::resumeCallback):
2533         (DebuggerDocument::stepIntoCallback):
2534         (DebuggerDocument::evaluateScriptCallback):
2535         (DebuggerDocument::currentFunctionStackCallback):
2536         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2537         (DebuggerDocument::valueForScopeVariableNamedCallback):
2538         (DebuggerDocument::logCallback):
2539         * Drosera/DebuggerDocument.h:
2540         (DebuggerDocument::getPaused):
2541         * Drosera/mac/DebuggerClient.mm:
2542         (-[DebuggerClient pause:]):
2543         (-[DebuggerClient resume:]):
2544         (-[DebuggerClient stepInto:]):
2545         (-[DebuggerClient stepOver:]):
2546         (-[DebuggerClient stepOut:]):
2547         (-[DebuggerClient showConsole:]):
2548         (-[DebuggerClient closeCurrentFile:]):
2549         (-[DebuggerClient validateUserInterfaceItem:]):
2550         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2551         (+[NSString stringOrNilFromWebScriptResult:]):
2552         (DebuggerDocument::platformPause):
2553         (DebuggerDocument::platformResume):
2554         (DebuggerDocument::platformStepInto):
2555         (DebuggerDocument::platformEvaluateScript):
2556         (DebuggerDocument::getPlatformCurrentFunctionStack):
2557         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2558         (DebuggerDocument::platformValueForScopeVariableNamed):
2559         (DebuggerDocument::platformLog):
2560         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2561
2562 2007-09-12  Sam Weinig  <sam@webkit.org>
2563
2564         Build fix for Buildbot.
2565
2566         * DumpRenderTree/DumpRenderTree.mm:
2567         (dump):
2568
2569 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2570
2571         Reviewed by Geoff.
2572
2573         - Updated the leaks list for leopard to help identify regressions.
2574
2575         * Scripts/run-webkit-tests:
2576
2577 2007-09-12  Sam Weinig  <sam@webkit.org>
2578
2579         Rubber stamped by Darin.
2580
2581         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2582
2583         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
2584         * DumpRenderTree/DumpRenderTree.m: Removed.
2585         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2586         (stopJavaScriptThreads): Fix initialization.
2587         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2588         (dumpRenderTree): Ditto.
2589         (runTest):
2590         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2591
2592         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2593         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2594         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2595         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2596         (-[FrameLoadDelegate init]):
2597         (-[FrameLoadDelegate dealloc]):
2598         (-[FrameLoadDelegate processWork:]):
2599         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2600         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2601         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2602         
2603         * DumpRenderTree/LayoutTestController.cpp: Added.
2604         (LayoutTestController::LayoutTestController):
2605         (LayoutTestController::~LayoutTestController):
2606         (dumpAsTextCallback):
2607         (dumpBackForwardListCallback):
2608         (dumpChildFramesAsTextCallback):
2609         (dumpChildFrameScrollPositionsCallback):
2610         (dumpDOMAsWebArchiveCallback):
2611         (dumpEditingCallbacksCallback):
2612         (dumpFrameLoadCallbacksCallback):
2613         (dumpResourceLoadCallbacksCallback):
2614         (dumpSelectionRectCallback):
2615         (dumpSourceAsWebArchiveCallback):
2616         (dumpTitleChangesCallback):
2617         (repaintSweepHorizontallyCallback):
2618         (setCallCloseOnWebViewsCallback):
2619         (setCanOpenWindowsCallback):
2620         (setCloseRemainingWindowsWhenCompleteCallback):
2621         (testRepaintCallback):
2622         (addFileToPasteboardOnDragCallback):
2623         (addDisallowedURLCallback):
2624         (clearBackForwardListCallback):
2625         (decodeHostNameCallback):
2626         (displayCallback):
2627         (encodeHostNameCallback):
2628         (keepWebHistoryCallback):
2629         (notifyDoneCallback):
2630         (queueBackNavigationCallback):
2631         (queueForwardNavigationCallback):
2632         (queueLoadCallback):
2633         (queueReloadCallback):
2634         (queueScriptCallback):
2635         (setAcceptsEditingCallback):
2636         (setCustomPolicyDelegateCallback):
2637         (setMainFrameIsFirstResponderCallback):
2638         (setTabKeyCyclesThroughElementsCallback):
2639         (setUseDashboardCompatibilityModeCallback):
2640         (setUserStyleSheetEnabledCallback):
2641         (setUserStyleSheetLocationCallback):
2642         (setWindowIsKeyCallback):
2643         (waitUntilDoneCallback):
2644         (windowCountCallback):
2645         (LayoutTestController::makeWindowObject):
2646         (LayoutTestController::getLayoutTestControllerJSClass):
2647         (LayoutTestController::staticFunctions):
2648         * DumpRenderTree/LayoutTestController.h: Replaced.
2649         * DumpRenderTree/LayoutTestController.m: Removed.
2650         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2651         (LayoutTestController::dumpAsText):
2652         (LayoutTestController::dumpBackForwardList):
2653         (LayoutTestController::dumpChildFramesAsText):
2654         (LayoutTestController::dumpChildFrameScrollPositions):
2655         (LayoutTestController::dumpDOMAsWebArchive):
2656         (LayoutTestController::dumpEditingCallbacks):
2657         (LayoutTestController::dumpFrameLoadCallbacks):
2658         (LayoutTestController::dumpResourceLoadCallbacks):
2659         (LayoutTestController::dumpSelectionRect):
2660         (LayoutTestController::dumpSourceAsWebArchive):
2661         (LayoutTestController::dumpTitleChanges):
2662         (LayoutTestController::repaintSweepHorizontally):
2663         (LayoutTestController::setCallCloseOnWebViews):
2664         (LayoutTestController::setCanOpenWindows):
2665         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2666         (LayoutTestController::testRepaint):
2667         (LayoutTestController::addFileToPasteboardOnDrag):
2668         (LayoutTestController::addDisallowedURL):
2669         (LayoutTestController::clearBackForwardList):
2670         (LayoutTestController::decodeHostName):
2671         (LayoutTestController::encodeHostName):
2672         (LayoutTestController::display):
2673         (LayoutTestController::keepWebHistory):
2674         (LayoutTestController::notifyDone):
2675         (LayoutTestController::queueBackNavigation):
2676         (LayoutTestController::queueForwardNavigation):
2677         (LayoutTestController::queueLoad):
2678         (LayoutTestController::queueReload):
2679         (LayoutTestController::queueScript):
2680         (LayoutTestController::setAcceptsEditing):
2681         (LayoutTestController::setCustomPolicyDelegate):
2682         (LayoutTestController::setMainFrameIsFirstResponder):
2683         (LayoutTestController::setTabKeyCyclesThroughElements):
2684         (LayoutTestController::setUseDashboardCompatibilityMode):
2685         (LayoutTestController::setUserStyleSheetEnabled):
2686         (LayoutTestController::setUserStyleSheetLocation):
2687         (LayoutTestController::setWindowIsKey):
2688         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2689         (LayoutTestController::waitUntilDone):
2690         (LayoutTestController::windowCount):
2691         Use the JSCore API to implement the LayoutTestController.
2692
2693         * DumpRenderTree/ObjCController.h:
2694         * DumpRenderTree/ObjCController.m:
2695         (+[ObjCController isSelectorExcludedFromWebScript:]):
2696         (+[ObjCController webScriptNameForSelector:]):
2697         (-[ObjCController accessStoredWebScriptObject]):
2698         (-[ObjCController storeWebScriptObject:]):
2699         (-[ObjCController dealloc]):
2700         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2701         Move WebScriptObject tests to ObjCController.
2702
2703         * DumpRenderTree/UIDelegate.m: Removed.
2704         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2705
2706         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2707         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2708         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2709         (WorkQueueItem::~WorkQueueItem):
2710         (LoadItem::LoadItem):
2711         (LoadItem::url):
2712         (LoadItem::target):
2713         (ScriptItem::ScriptItem):
2714         (ScriptItem::script):
2715         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2716         (LoadItem::invoke):
2717         (ReloadItem::invoke):
2718         (ScriptItem::invoke):
2719         (BackForwardItem::invoke):
2720         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2721         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2722         sharing code.
2723
2724 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2725
2726         Reviewed by Maciej.
2727
2728         - Updated Win side to take advantage of the platform separating changes.
2729
2730         * Drosera/DebuggerDocument.cpp:
2731         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2732         * Drosera/DebuggerDocument.h:
2733         * Drosera/win/DebuggerClient.cpp:
2734         (DebuggerClient::pause):
2735         (DebuggerClient::resume):
2736         (DebuggerClient::stepInto):
2737         (DebuggerDocument::platformPause):
2738         (DebuggerDocument::platformResume):
2739         (DebuggerDocument::platformStepInto):
2740         (DebuggerDocument::platformEvaluateScript):
2741         (DebuggerDocument::getPlatformCurrentFunctionStack):
2742         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2743         (DebuggerDocument::platformValueForScopeVariableNamed):
2744         (DebuggerDocument::platformLog):
2745         * Drosera/win/DebuggerClient.h:
2746         * Drosera/win/Drosera.cpp:
2747         (Drosera::Drosera):
2748         (Drosera::windowScriptObjectAvailable):
2749         (Drosera::initWithServerName):
2750         (Drosera::switchToServerNamed):
2751         * Drosera/win/Drosera.h:
2752         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2753
2754 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2755
2756         Reviewed by Adam.
2757
2758         - Just doing the moves in a separate patch so the changes are easier to see.
2759
2760         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2761         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2762         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2763         * Drosera/win/DebuggerDocumentWin.h: Removed.
2764         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2765
2766 2007-09-11  Sven Herzberg  <sven@imendio.com>
2767
2768         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2769         http://bugs.webkit.org/show_bug.cgi?id=15176
2770
2771         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2772         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2773         other paths eg. from jhbuild)
2774
2775 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2776
2777         Reviewed by Adam.
2778
2779         - Made an order-of-deletion mistake.
2780
2781         * Drosera/DebuggerDocument.h:
2782         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2783         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2784         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2785         * Drosera/mac/DebuggerClient.mm:
2786         (DebuggerDocument::platformPause):
2787         (DebuggerDocument::platformResume):
2788         (DebuggerDocument::platformStepInto):
2789         (DebuggerDocument::platformEvaluateScript):
2790         (DebuggerDocument::getPlatformCurrentFunctionStack):
2791         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2792         (DebuggerDocument::platformValueForScopeVariableNamed):
2793         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2794
2795 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2796
2797         Reviewed by Darin.
2798
2799         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2800
2801         * Drosera/DebuggerDocument.cpp:
2802         (DebuggerDocument::DebuggerDocument):
2803         * Drosera/DebuggerDocument.h:
2804         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2805         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2806         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2807         * Drosera/mac/DebuggerApplication.mm:
2808         (-[DebuggerApplication attach:]):
2809         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2810         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2811         (DebuggerDocument::platformPause):
2812         (DebuggerDocument::platformResume):
2813         (DebuggerDocument::platformStepInto):
2814         (DebuggerDocument::platformEvaluateScript):
2815         (DebuggerDocument::getPlatformCurrentFunctionStack):
2816         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2817         (DebuggerDocument::platformValueForScopeVariableNamed):
2818         (DebuggerDocument::platformLog):
2819         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2820         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2821         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2822
2823 2007-09-09  Sam Weinig  <sam@webkit.org>
2824
2825         Reviewed by Mark Rowe.
2826
2827         Remove 'objC' prefix from methods now in the ObjCController. 
2828
2829         * DumpRenderTree/ObjCController.m:
2830         (+[ObjCController isSelectorExcludedFromWebScript:]):
2831         (+[ObjCController webScriptNameForSelector:]):
2832         (-[ObjCController classNameOf:]):
2833         (-[ObjCController objectOfClass:]):
2834         (-[ObjCController identityIsEqual::]):
2835         (-[ObjCController longLongRoundTrip:]):
2836         (-[ObjCController unsignedLongLongRoundTrip:]):
2837
2838 2007-09-09  Sam Weinig  <sam@webkit.org>
2839
2840         Reviewed by Oliver.
2841
2842         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
2843         - Move LayoutTestController into its own file.
2844         - Move Objective-C only functions on LayoutTestController into a new controller called the
2845           ObjCController. 
2846
2847         * DumpRenderTree/DumpRenderTree.h:
2848         * DumpRenderTree/DumpRenderTree.m:
2849         (displayWebView):
2850         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2851         * DumpRenderTree/FrameLoadDelegate.m:
2852         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2853         * DumpRenderTree/LayoutTestController.h: Added.
2854         * DumpRenderTree/LayoutTestController.m: Added.
2855         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2856         (+[LayoutTestController webScriptNameForSelector:]):
2857         (-[LayoutTestController clearBackForwardList]):
2858         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
2859         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
2860         (-[LayoutTestController setCustomPolicyDelegate:]):
2861         (-[LayoutTestController keepWebHistory]):
2862         (-[LayoutTestController setCallCloseOnWebViews:]):
2863         (-[LayoutTestController setCanOpenWindows]):
2864         (-[LayoutTestController waitUntilDone]):
2865         (-[LayoutTestController waitUntilDoneWatchdogFired]):
2866         (-[LayoutTestController notifyDone]):
2867         (-[LayoutTestController dumpAsText]):
2868         (-[LayoutTestController addFileToPasteboardOnDrag]):
2869         (-[LayoutTestController addDisallowedURL:]):
2870         (-[LayoutTestController setUserStyleSheetLocation:]):
2871         (-[LayoutTestController setUserStyleSheetEnabled:]):
2872         (-[LayoutTestController dumpDOMAsWebArchive]):
2873         (-[LayoutTestController dumpSourceAsWebArchive]):
2874         (-[LayoutTestController dumpSelectionRect]):
2875         (-[LayoutTestController dumpTitleChanges]):
2876         (-[LayoutTestController dumpBackForwardList]):
2877         (-[LayoutTestController windowCount]):
2878         (-[LayoutTestController dumpChildFrameScrollPositions]):
2879         (-[LayoutTestController dumpChildFramesAsText]):
2880         (-[LayoutTestController dumpEditingCallbacks]):
2881         (-[LayoutTestController dumpResourceLoadCallbacks]):
2882         (-[LayoutTestController dumpFrameLoadCallbacks]):
2883         (-[LayoutTestController setWindowIsKey:]):
2884         (-[LayoutTestController setMainFrameIsFirstResponder:]):
2885         (-[LayoutTestController display]):
2886         (-[LayoutTestController testRepaint]):
2887         (-[LayoutTestController repaintSweepHorizontally]):
2888         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
2889         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
2890         (-[LayoutTestController _doLoad:target:]):
2891         (-[LayoutTestController _doBackOrForwardNavigation:]):
2892         (-[LayoutTestController queueBackNavigation:]):
2893         (-[LayoutTestController queueForwardNavigation:]):
2894         (-[LayoutTestController queueReload]):
2895         (-[LayoutTestController queueScript:]):
2896         (-[LayoutTestController queueLoad:target:]):
2897         (-[LayoutTestController setAcceptsEditing:]):
2898         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2899         (-[LayoutTestController storeWebScriptObject:]):
2900         (-[LayoutTestController accessStoredWebScriptObject]):
2901         (-[LayoutTestController dealloc]):
2902         (-[LayoutTestController decodeHostName:]):
2903         (-[LayoutTestController encodeHostName:]):
2904         * DumpRenderTree/ObjCController.h: Added.
2905         * DumpRenderTree/ObjCController.m: Added.
2906         (+[ObjCController isSelectorExcludedFromWebScript:]):
2907         (+[ObjCController webScriptNameForSelector:]):
2908         (-[ObjCController objCClassNameOf:]):
2909         (-[ObjCController objCObjectOfClass:]):
2910         (-[ObjCController objCIdentityIsEqual::]):
2911         (-[ObjCController objCLongLongRoundTrip:]):
2912         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
2913         (-[ObjCController testWrapperRoundTripping:]):
2914
2915 2007-09-07  Sam Weinig  <sam@webkit.org>
2916
2917         Reviewed by Alice.
2918
2919         Strip trailing and leading space/newline characters from skiplist file names.
2920
2921         * Scripts/run-webkit-tests:
2922
2923 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
2924
2925         Reviewed by Maciej.
2926
2927         - Changed Drosera to take advantage of the JSRetainPtr changes.
2928
2929         * Drosera/DebuggerDocument.cpp:
2930         (DebuggerDocument::breakpointEditorHTML):
2931         (DebuggerDocument::evaluateScript):
2932         (DebuggerDocument::valueForScopeVariableNamed):
2933         (DebuggerDocument::log):
2934         (DebuggerDocument::windowScriptObjectAvailable):
2935         (DebuggerDocument::toJSArray):
2936         (DebuggerDocument::callFunctionOnObject):
2937         (DebuggerDocument::logException):
2938         * Drosera/mac/DebuggerDocumentMac.mm:
2939         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
2940         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2941         (DebuggerDocument::platformEvaluateScript):
2942         (DebuggerDocument::getPlatformCurrentFunctionStack):
2943         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2944         (DebuggerDocument::platformValueForScopeVariableNamed):
2945
2946 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
2947
2948         Reviewed by Adam, Sam, Darin.
2949
2950         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
2951
2952         * Drosera/Debugger.h: Added.
2953         * Drosera/DebuggerDocument.cpp:
2954         (DebuggerDocument::breakpointEditorHTMLCallback):
2955         (DebuggerDocument::isPausedCallback):
2956         (DebuggerDocument::pauseCallback):
2957         (DebuggerDocument::resumeCallback):
2958         (DebuggerDocument::stepIntoCallback):
2959         (DebuggerDocument::evaluateScriptCallback):
2960         (DebuggerDocument::currentFunctionStackCallback):
2961         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2962         (DebuggerDocument::valueForScopeVariableNamedCallback):
2963         (DebuggerDocument::logCallback):
2964         (DebuggerDocument::breakpointEditorHTML):
2965         (DebuggerDocument::isPaused):
2966         (DebuggerDocument::pause):
2967         (DebuggerDocument::resume):
2968         (DebuggerDocument::stepInto):
2969         (DebuggerDocument::evaluateScript):
2970         (DebuggerDocument::currentFunctionStack):
2971         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2972         (DebuggerDocument::valueForScopeVariableNamed):
2973         (DebuggerDocument::log):
2974         (DebuggerDocument::toolbarPause):
2975         (DebuggerDocument::toolbarResume):
2976         (DebuggerDocument::toolbarStepInto):
2977         (DebuggerDocument::toolbarStepOver):
2978         (DebuggerDocument::toolbarStepOut):
2979         (DebuggerDocument::toolbarShowConsole):
2980         (DebuggerDocument::toolbarCloseCurrentFile):
2981         (DebuggerDocument::updateFileSource):
2982         (DebuggerDocument::didParseScript):
2983         (DebuggerDocument::willExecuteStatement):
2984         (DebuggerDocument::didEnterCallFrame):
2985         (DebuggerDocument::willLeaveCallFrame):
2986         (DebuggerDocument::exceptionWasRaised):
2987         (DebuggerDocument::windowScriptObjectAvailable):
2988         (DebuggerDocument::toJSArray):
2989         (DebuggerDocument::callGlobalFunction):
2990         (DebuggerDocument::callFunctionOnObject):
2991         (DebuggerDocument::getDroseraJSClass):
2992         (DebuggerDocument::staticFunctions):
2993         (DebuggerDocument::logException):
2994         * Drosera/DebuggerDocument.h:
2995         (DebuggerDocument::DebuggerDocument):
2996         * Drosera/ForwardingHeaders: Added.
2997         * Drosera/ForwardingHeaders/wtf: Added.
2998         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
2999         * Drosera/config.h:
3000         * Drosera/console.html:
3001         * Drosera/console.js:
3002         * Drosera/debugger.js:
3003         * Drosera/mac/DebuggerApplication.mm:
3004         (-[DebuggerApplication attach:]):
3005         * Drosera/mac/DebuggerDocumentMac.h:
3006         * Drosera/mac/DebuggerDocumentMac.mm:
3007         (+[NSString stringOrNilFromWebScriptResult:]):
3008         (+[DebuggerClientMac log:]):
3009         (-[DebuggerClientMac initWithServerName:]):
3010         (-[DebuggerClientMac dealloc]):
3011         (-[DebuggerClientMac pause]):
3012         (-[DebuggerClientMac resume]):
3013         (-[DebuggerClientMac pause:]):
3014         (-[DebuggerClientMac resume:]):
3015         (-[DebuggerClientMac stepInto:]):
3016         (-[DebuggerClientMac stepOver:]):
3017         (-[DebuggerClientMac stepOut:]):
3018         (-[DebuggerClientMac showConsole:]):
3019         (-[DebuggerClientMac closeCurrentFile:]):
3020         (-[DebuggerClientMac validateUserInterfaceItem:]):
3021         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3022         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3023         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3024         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3025         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3026         (DebuggerDocument::platformPause):
3027         (DebuggerDocument::platformResume):
3028         (DebuggerDocument::platformStepInto):
3029         (DebuggerDocument::platformEvaluateScript):
3030         (DebuggerDocument::platformCurrentFunctionStack):
3031         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3032         (DebuggerDocument::platformValueForScopeVariableNamed):
3033         (DebuggerDocument::platformLog):
3034         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3035
3036 2007-09-06  Sam Weinig  <sam@webkit.org>
3037
3038         Reviewed by Adam Roben.
3039
3040         Register the WebKit DLL on initialization of the DumpRenderTree.
3041
3042         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3043         (initialize):
3044
3045 2007-09-05  Sam Weinig  <sam@webkit.org>
3046
3047         Reviewed by Oliver.
3048
3049         Fix many layout test failures caused by r25364.
3050         Set text size to standand size at the begining of each test matching the mac.
3051
3052         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3053         (runTest):
3054
3055 2007-09-04  Sam Weinig  <sam@webkit.org>
3056
3057         Reviewed by Adam.
3058
3059         Fix for <rdar://problem/5382277>
3060         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3061
3062         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3063         (textZoomInCallback):
3064         (textZoomOutCallback):
3065
3066 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3067
3068         Reviewed by Adam.
3069
3070         Added case-insensitivity to checks for adding regression tests.
3071
3072         * Scripts/prepare-ChangeLog:
3073         (generateFileList):
3074
3075 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3076
3077         Reviewed by Maciej.
3078
3079         Ignore files in /resources/ subdirectories when creating a list of added tests.
3080
3081         * Scripts/prepare-ChangeLog:
3082         (generateFileList):
3083
3084 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3085
3086         Reviewed by John.
3087
3088         - Removed Leopard leaks list since all of those radars were fixed.
3089
3090         * Scripts/run-webkit-tests:
3091
3092 2007-08-27  Adam Roben  <aroben@apple.com>
3093
3094         Rubberstamped by Mark.
3095
3096         * Scripts/pdevenv: Pass arguments along to devenv.com.
3097
3098 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3099
3100         Reviewed by Mark Rowe.
3101
3102         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3103
3104         * Scripts/prepare-ChangeLog:
3105         (changeLogDate): Added.
3106
3107 2007-08-24  Sam Weinig  <sam@webkit.org>
3108
3109         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3110
3111 2007-08-24  Sam Weinig  <sam@webkit.org>
3112
3113         Rubber-stamped by Adam Roben.
3114
3115         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3116
3117         Rename COM DOM bindings to use Deprecated prefix.
3118
3119         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3120         (dumpFramesAsText):
3121         (dump):
3122         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3123         (dumpPath):
3124         (dump):
3125         (EditingDelegate::shouldBeginEditingInDOMRange):
3126         (EditingDelegate::shouldEndEditingInDOMRange):
3127         (EditingDelegate::shouldInsertNode):
3128         (EditingDelegate::shouldInsertText):
3129         (EditingDelegate::shouldDeleteDOMRange):
3130         (EditingDelegate::shouldChangeSelectedDOMRange):
3131         (EditingDelegate::shouldApplyStyle):
3132         (EditingDelegate::shouldChangeTypingStyle):
3133         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3134
3135 2007-08-24  Oliver Hunt  <oliver@apple.com>
3136
3137         Reviewed by John H.
3138
3139         WebDataSource::response can legitimately have a null response, so we
3140         must check that case.
3141
3142         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3143         (queueLoadCallback):
3144
3145 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3146
3147         Reviewed by Darin and Adam.
3148
3149         - DumpRenderTree changes to allow testing for
3150           http://bugs.webkit.org/show_bug.cgi?id=11756
3151           REGRESSION: link targeting a frame in another window does not work
3152           <rdar://problem/5286420>
3153
3154         Use a frame group name for all WebViews created by DumpRenderTree to
3155         allow testing of cross-page frame lookup.
3156
3157         * DumpRenderTree/DumpRenderTree.m:
3158         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3159         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3160         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3161
3162 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3163
3164         Reviewed by Adam.
3165
3166         Quote the $sslCertificate path in case it contains a space.
3167
3168         * Scripts/run-webkit-httpd:
3169         * Scripts/run-webkit-tests:
3170
3171 2007-08-22  Oliver Hunt  <oliver@apple.com>
3172
3173         Reviewed by John and Adam.
3174         
3175         WebDataSource::response can legitimately have a null response, so we
3176         must check that case.
3177
3178         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3179         (dump):
3180
3181 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3182
3183         Reviewed by Geof.
3184
3185         - Changing the usage to be more clear.
3186
3187         * Scripts/run-testkjs:
3188
3189 2007-08-20  John Sullivan  <sullivan@apple.com>
3190
3191         Reviewed by Adam Roben
3192
3193         * DumpRenderTree/DumpRenderTree.m:
3194         (runTest):
3195         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3196         in layout tests on Tiger and Leopard
3197
3198 2007-08-20  Adam Roben  <aroben@apple.com>
3199
3200         Put LayoutTests after all other ChangeLogs in commit logs
3201
3202         We use "~" to sort LayoutTests after all the other ChangeLogs because
3203         "~" is the last ASCII character (other than "DEL").
3204
3205         Reviewed by Sam.
3206
3207         * Scripts/commit-log-editor:
3208
3209 2007-08-20  Adam Roben  <aroben@apple.com>
3210
3211         Detect that DRT crashed even if a crash dialog is running
3212
3213         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3214         process is still running at this point, so run-webkit-tests wouldn't
3215         detect that DRT had crashed. We now record the crash in our SIGPIPE
3216         handler so that we know if DRT crashed even if the crash dialog is up.
3217
3218         Reviewed by Sam.
3219
3220         * Scripts/run-webkit-tests:
3221         (sub catch_pipe): Set the crashed bit.
3222         (sub openDumpTool): Reset the crashed bit.
3223         (sub dumpToolDidCrash): Check the crashed bit.
3224
3225 2007-08-20  Adam Roben  <aroben@apple.com>
3226
3227         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3228
3229         http://bugs.webkit.org/show_bug.cgi?id=15026
3230
3231         Reviewed by David Kilzer and Darin Adler.
3232
3233         * Scripts/prepare-ChangeLog:
3234         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3235         (sub isAddedStatus): Ditto.
3236         (sub testListForChangeLog): Added.
3237
3238 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3239
3240         Reviewed by Mark.
3241
3242         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3243
3244         * Scripts/webkitdirs.pm:
3245         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3246
3247 2007-08-17  Darin Adler  <darin@apple.com>
3248
3249         Reviewed by Oliver Hunt.
3250
3251         - don't look for Apple-style localizable strings in the GTK version of WebKit
3252
3253         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3254         name of subdirectories to skip.
3255         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3256         to skip.
3257
3258 2007-08-17  Anders Carlsson  <andersca@apple.com>
3259
3260         Build fix.
3261         
3262         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3263         (NPP_SetWindow):
3264
3265 2007-08-17  Anders Carlsson  <andersca@apple.com>
3266
3267         Reviewed by Dave Hyatt.
3268
3269         <rdar://problem/5379040>
3270         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3271
3272         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3273         
3274         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3275         (pluginAllocate):
3276         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3277         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3278         (NPP_New):
3279         (NPP_SetWindow):
3280
3281 2007-08-16  Alice Liu  <alice.liu@apple.com>
3282
3283         Reviewed by Maciej.
3284
3285         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3286
3287         * DumpRenderTree/DumpRenderTree.m:
3288         (createWebView):
3289         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3290         (dumpRenderTree):
3291         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
3292
3293 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3294
3295         Reviewed by Adam.
3296
3297         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3298
3299         * Scripts/run-webkit-tests:
3300
3301 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3302
3303         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3304         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3305
3306         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3307         this prevents making "build" directories in each project folder.
3308
3309         * Scripts/webkitdirs.pm:
3310
3311 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3312
3313         Reviewed by Kevin Mccullough.
3314         
3315         Removed special case that didn't belong. (It would allow a global 
3316         initializer to sneak into production builds, which would cause a 
3317         system-wide performance regression on Mac OS X.)
3318
3319         * Scripts/check-for-global-initializers:
3320
3321 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3322
3323         Reviewed by Tim.
3324         
3325         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3326
3327         * DumpRenderTree/EditingDelegate.m:
3328         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3329         only for elements with the class needsDeletionUI.
3330
3331 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3332
3333         Reviewed by Darin.
3334
3335         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3336           svn-create-patch uses deprecated tail switch
3337
3338         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3339
3340 2007-08-13  Sam Weinig  <sam@webkit.org>
3341
3342         Reviewed by Adam Roben.
3343
3344         Use the cygwin specific Apache config file under cygwin.
3345
3346         * Scripts/run-webkit-httpd:
3347
3348 2007-08-12  Adam Roben  <aroben@apple.com>
3349
3350         Generate results for new tests in a more logical location
3351
3352         New platform-specific tests always have their results generated right
3353         next to the test. New cross-platform tests will have their results
3354         generated a) in the cross-platform directory, if they are text-only,
3355         or b) in the least-specific platform directory, if they are render
3356         tree dumps.
3357
3358         Reviewed by Lars.
3359
3360         * Scripts/run-webkit-tests:
3361
3362 2007-08-12  Adam Roben  <aroben@apple.com>
3363
3364         Print the actual directory where new results are generated.
3365
3366         Before, we were printing an unpredictable, context-specific substring
3367         of the directory.
3368
3369         Reviewed by Lars.
3370
3371         * Scripts/run-webkit-tests:
3372
3373 2007-08-12  Adam Roben  <aroben@apple.com>
3374
3375         Factor some common code into a stripExtension() subroutine.
3376
3377         Reviewed by Lars.
3378
3379         * Scripts/run-webkit-tests: Also removed some debugging output.
3380
3381 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
3382
3383         Reviewed over and over and over by Adam Roben.
3384
3385         Bug 14740: Hierarchical layout tests and platform organization
3386         http://bugs.webkit.org/show_bug.cgi?id=14740
3387
3388         Add support for platform-specific layout tests and results.
3389
3390         * Scripts/run-webkit-tests:
3391
3392 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
3393
3394         Reviewed by Adam.
3395
3396         Refactored svn-create-path to use a hash-of-hashes data structure to keep
3397         track of changed files.  In the top level hash, keys are paths to files and
3398         values are 'fileData' hashes with the following keys and values:
3399
3400         - isBinary: boolean value (set to true for non-text files like images, etc.)
3401         - isTestFile: boolean value (set to true if file exists within a known test
3402           directory)
3403         - modificationType: string equal to one of 'addition', 'additionWithHistory',
3404           'modification' or 'deletion'
3405         - path: string equal to the path to the file (this may seem redundant, but it
3406           is required to use the second-level 'fileData' hash independent of the
3407           top-level hash)
3408         - sourceFile: [optional] string equal to the path of the original file that was
3409           copied or moved
3410         - sourceRevision: [optional] string equal to the revision of the original file
3411           that was copied or moved
3412
3413         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
3414         that saves the return value in $result, then checks it before printing help.
3415         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
3416         and eliminated two for() loops.
3417         (binarycmp): Added.  Used with sort() to order non-binary files before binary
3418         files.
3419         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
3420         (findMimeType): Added optional second argument that takes a revision number.
3421         (generateDiff): Updated to take one fileData argument instead of three ($file,
3422         $modificationType, $isBinary).
3423         (generateFileList): Updated to take one hash ref argument (%diffFiles)
3424         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
3425         %diffFiles using paths for keys and fileData hashes for values.
3426         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
3427         argument.
3428         (pathcmp): Updated to take two fileData arguments instead of two strings.
3429         (testfilecmp): Added.  Used with sort() to order non-test files before test
3430         files.
3431
3432 2007-08-11  Darin Adler  <darin@apple.com>
3433
3434         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
3435
3436 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
3437
3438         Reviewed by David Kilzer.
3439
3440         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
3441         http://bugs.webkit.org/show_bug.cgi?id=14745
3442
3443         * Scripts/run-launcher:
3444         Scrub the "--gdk" out of the command line args, if given, so that
3445         GdkLauncher doesn't try to interpret it as a URL.
3446
3447 2007-08-03  Adam Roben  <aroben@apple.com>
3448
3449         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
3450
3451         Reviewed by Sam.
3452
3453         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
3454
3455 2007-08-03  Sam Weinig  <sam@webkit.org>
3456
3457         Reviewed by Darin.
3458
3459         Recursively dump all frames as text using new
3460         layoutTestController.dumpChildFramesAsText() function.
3461
3462         * DumpRenderTree/DumpRenderTree.m:
3463         (dumpFramesAsText):
3464         (dump):
3465         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3466         (-[LayoutTestController dumpChildFramesAsText]):
3467         (runTest):
3468         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3469         (dumpFramesAsText):
3470         (dump):
3471         (runTest):
3472         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
3473         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3474         (dumpChildFramesAsTextCallback):
3475         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3476
3477 2007-08-02  Adam Roben  <aroben@apple.com>
3478
3479         Fix fast/dom/Window/alert-undefined.html
3480
3481         Reviewed by Sam.
3482
3483         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3484         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
3485         Windows translate a null BSTR into "(null)"
3486
3487 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
3488
3489         Reviewed by Tim. 
3490
3491         - It would help if I actually called the right function.
3492
3493         * Drosera/DebuggerDocument.cpp:
3494         (DebuggerDocument::showConsole):
3495
3496 2007-08-02  Adam Roben  <aroben@apple.com>
3497
3498         Don't delete the stderr file right after creating it
3499
3500         * Scripts/run-webkit-tests:
3501
3502 2007-08-01  Adam Roben  <aroben@apple.com>
3503
3504         When DRT crashes, record stderr and restart DRT
3505
3506         This prevents a DRT crash from causing the next few hundred tests to
3507         "fail" because DRT is no longer running. 
3508
3509         I also changed the terminology that run-webkit-tests uses in its
3510         output a bit, so that crashing tests are referred to as "crashes"
3511         instead of "failures".
3512
3513         Reviewed by Mark.
3514
3515         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
3516         failure.
3517         (sub openDumpTool): Use open3 so that we can access stderr.
3518         (sub dumpToolCrashed): Added.
3519         (sub printFailureMessageForTest): Added.
3520         (sub htmlForExpectedAndActualResults): Added.
3521         (sub deleteExpectedAndActualResults): Added.
3522         (sub recordActualResultsAndDiff): Added.
3523
3524 2007-07-30  Darin Adler  <darin@apple.com>
3525
3526         Reviewed by Tim Hatcher.
3527
3528         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
3529         characters. This turned out not to be needed for the test case that motivated me to
3530         do it, but it's nice to have this for the future.
3531
3532 2007-07-30  Simon Hausmann  <hausmann@kde.org>
3533
3534         Reviewed by Lars.
3535
3536         Link QtLauncher into $$OUTPUT_DIR/bin
3537
3538         * Scripts/run-launcher:
3539
3540 2007-07-27  David Kilzer  <ddkilzer@apple.com>
3541
3542         Reviewed by Geoff and Darin.
3543
3544         Use a subroutine for validating the --skipped switch.
3545
3546         * Scripts/run-webkit-tests:
3547
3548 2007-07-27  Darin Adler  <darin@apple.com>