Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-29  Andras Becsi  <abecsi@webkit.org>
2
3         Reviewed by Alexey Proskuryakov.
4
5         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
6         This fixes a regression introduced in r53559.
7
8         https://bugs.webkit.org/show_bug.cgi?id=34336
9
10         * Scripts/webkitperl/httpd.pm:
11
12 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
13
14         MSAA: Crash when posting a notification for a detached object
15
16         https://bugs.webkit.org/show_bug.cgi?id=34309
17         <rdar://problem/7409759>
18
19         Reviewed by Darin Adler.
20
21         * DumpRenderTree/AccessibilityController.h:
22         Declare new functions. Add new members to store the event hook and the
23         mapping of accessibility elements to their JS callbacks.
24
25         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
26         (AccessibilityController::notificationReceived):
27         Stubbed.
28         (AccessibilityController::addNotificationListener):
29         Stubbed.
30
31         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
32         (AccessibilityController::notificationReceived):
33         Stubbed.
34         (AccessibilityController::addNotificationListener):
35         Stubbed.
36
37         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
38         (AccessibilityController::AccessibilityController):
39         Initialize the event hook.
40         (AccessibilityController::~AccessibilityController):
41         Remove the event hook. Unprotect all of the JS functions that are stored
42         in the map.
43         (logEventProc):
44         Clean-up a variable.
45         (stringEvent):
46         Return a string description of the MSAA event code.
47         (notificationListenerProc):
48         Get the accessible object from the event, and query it for IAccessible.
49         Call the AccessibilityController's notificationReceived().
50         (comparableObject):
51         Use QueryService to obtain the IAccessibleComparable for the
52         IServiceProvider.
53         (AccessibilityController::notificationReceived):
54         Iterate the map of objects that have registered for notification
55         callbacks. Query each for IServiceProvider, then use comparableObject()
56         to get an IAccessibleComparable. If we find an object matching the
57         notified object, call its callback, passing the event that was received.
58         (AccessibilityController::addNotificationListener):
59         If we have not created the event hook, create it. Protect the JS
60         callback function object, and add the object and its callback to our
61         map.
62
63         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
64         (AccessibilityUIElement::addNotificationListener):
65         Call through to the AccessibilityController's addNotificationListener().
66
67         * DumpRenderTree/win/DumpRenderTreeWin.h:
68         Add an extern declaration for the shared FrameLoadDelegate extern, so we
69         can access it from AccessibilityController.
70
71         * DumpRenderTree/win/FrameLoadDelegate.h:
72         (FrameLoadDelegate::accessibilityController):
73         Return the AccessibilityController.
74
75 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
76
77         Reviewed by Darin Adler.
78
79         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
80         https://bugs.webkit.org/show_bug.cgi?id=34313
81
82         * Scripts/prepare-ChangeLog:
83
84 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
85
86         Rubberstamped by Simon Hausmann.
87
88         [Qt] Separate implementation from class definition.
89
90         * QtLauncher/main.cpp:
91         (LauncherWindow::webView):
92         (LauncherWindow::LauncherWindow):
93         (LauncherWindow::~LauncherWindow):
94         (LauncherWindow::keyPressEvent):
95         (LauncherWindow::grabZoomKeys):
96         (LauncherWindow::sendTouchEvent):
97         (LauncherWindow::eventFilter):
98         (LauncherWindow::loadStarted):
99         (LauncherWindow::loadFinished):
100         (LauncherWindow::showLinkHover):
101         (LauncherWindow::zoomIn):
102         (LauncherWindow::zoomOut):
103         (LauncherWindow::resetZoom):
104         (LauncherWindow::toggleZoomTextOnly):
105         (LauncherWindow::print):
106         (LauncherWindow::screenshot):
107         (LauncherWindow::setEditable):
108         (LauncherWindow::dumpHtml):
109         (LauncherWindow::selectElements):
110         (LauncherWindow::setTouchMocking):
111         (LauncherWindow::newWindow):
112         (LauncherWindow::setupUI):
113
114 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
115
116         Reviewed by Ariya Hidayat.
117
118         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
119         should result in all text selected.
120
121         * QtLauncher/locationedit.cpp:
122         (LocationEdit::focusInEvent):
123         * QtLauncher/locationedit.h:
124
125 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
126
127         Reviewed by Ariya Hidayat.
128
129         [Qt] Show progress reaching 100% for loads.
130
131         * QtLauncher/locationedit.cpp:
132         (LocationEdit::LocationEdit):
133         (LocationEdit::setProgress):
134         (LocationEdit::reset):
135         (LocationEdit::paintEvent):
136         * QtLauncher/locationedit.h:
137
138 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
139
140         Reviewed by Kenneth Rohde Christiansen.
141
142         [Qt] Disable the QtLauncher statusbar on Maemo
143
144         https://bugs.webkit.org/show_bug.cgi?id=34330
145
146         * QtLauncher/main.cpp:
147         (LauncherWindow::showLinkHover):
148         (LauncherWindow::selectElements):
149
150 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
151
152         Reviewed by Kenneth Rohde Christiansen.
153
154         [Qt] Display page loading progress inside the QtLauncher location bar
155
156         https://bugs.webkit.org/show_bug.cgi?id=34210
157
158         * QtLauncher/QtLauncher.pro:
159         * QtLauncher/locationedit.cpp: Added.
160         (LocationEdit::LocationEdit):
161         (LocationEdit::setProgress):
162         (LocationEdit::paintEvent):
163         * QtLauncher/locationedit.h: Added.
164         * QtLauncher/mainwindow.cpp:
165         (MainWindow::buildUI):
166         * QtLauncher/mainwindow.h:
167
168 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
169
170         Reviewed by Kenneth Rohde Christiansen.
171
172         [Qt] Add support for Maemo zoom keys in QtLauncher
173
174         https://bugs.webkit.org/show_bug.cgi?id=34160
175
176         * QtLauncher/main.cpp:
177         (LauncherWindow::LauncherWindow):
178         (LauncherWindow::~LauncherWindow):
179         (LauncherWindow::keyPressEvent):
180         (LauncherWindow::grabZoomKeys):
181
182 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
183
184         Reviewed by Kenneth Rohde Christiansen.
185
186         [Qt] Implement the display() method of the layout test controller
187         https://bugs.webkit.org/show_bug.cgi?id=34258
188
189         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
190         (WebCore::DumpRenderTree::DumpRenderTree):
191         (WebCore::DumpRenderTree::showPage):
192         (WebCore::DumpRenderTree::hidePage):
193         * DumpRenderTree/qt/DumpRenderTreeQt.h:
194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
195         (LayoutTestController::reset):
196         (LayoutTestController::display):
197         * DumpRenderTree/qt/LayoutTestControllerQt.h:
198
199 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
200
201         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
202         implements pthread_t in a way that makes it impossible to check its validity,
203         which is needed by ThreadingPthreads.cpp.
204
205         * DumpRenderTree/wscript:
206         * wx/build/settings.py:
207
208 2010-01-28  Andras Becsi  <abecsi@webkit.org>
209
210         Adding myself to the committer list. No review needed.
211
212         * Scripts/webkitpy/committers.py:
213
214 2010-01-28  Hayato Ito  <hayato@chromium.org>
215
216         Reviewed by David Levin.
217
218         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
219
220         https://bugs.webkit.org/show_bug.cgi?id=34252
221
222         * Scripts/make-script-test-wrappers:
223
224 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
225
226         [wx] Build fix after removal of the zlib image decoder.
227
228         * wx/build/settings.py:
229
230 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
231
232         [Qt] Unreviewed, roll out r54000.
233
234         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
235         (WebCore::DumpRenderTree::DumpRenderTree):
236         * DumpRenderTree/qt/DumpRenderTreeQt.h:
237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
238         (LayoutTestController::reset):
239         * DumpRenderTree/qt/LayoutTestControllerQt.h:
240         (LayoutTestController::display):
241
242 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
243
244         Reviewed by Kenneth Rohde Christiansen.
245
246         [Qt] Implement the display() method of the layout test controller
247         https://bugs.webkit.org/show_bug.cgi?id=34258
248
249         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
250         (WebCore::DumpRenderTree::DumpRenderTree):
251         (WebCore::DumpRenderTree::showPage):
252         (WebCore::DumpRenderTree::hidePage):
253         * DumpRenderTree/qt/DumpRenderTreeQt.h:
254         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
255         (LayoutTestController::reset):
256         (LayoutTestController::display):
257         * DumpRenderTree/qt/LayoutTestControllerQt.h:
258
259 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
260
261         Reviewed by Shinichiro Hamaji.
262
263         Eliminated the filename parameter from functions in
264         check-webkit-style's cpp.py where it is no longer used.
265
266         https://bugs.webkit.org/show_bug.cgi?id=34249
267
268         * Scripts/webkitpy/style/processors/cpp.py:
269           - Reduced number of occurrences of "filename" variable from
270             approximately 200 to 120.
271
272         * Scripts/webkitpy/style/processors/cpp_unittest.py:
273           - Refactored unit tests as necessary to accommodate changes to cpp.py.
274           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
275             where the incorrect file extension was getting passed to
276             cpp_style.check_language().
277
278 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
279
280         Reviewed by Shinichiro Hamaji.
281
282         In check-webkit-style, eliminated the dependency of
283         processors/cpp_unittest.py on checker.py.
284
285         https://bugs.webkit.org/show_bug.cgi?id=34205
286
287         * Scripts/webkitpy/style/checker.py:
288           - Addressed FIXME by removing STYLE_CATEGORIES data.
289           - Added style_categories().
290
291         * Scripts/webkitpy/style/checker_unittest.py:
292           - Minor changes.
293
294         * Scripts/webkitpy/style/processors/cpp.py:
295           - Added categories attribute to CppProcessor class (data
296             was originally checker.STYLE_CATEGORIES).
297
298         * Scripts/webkitpy/style/processors/cpp_unittest.py:
299           - Addressed FIXME by eliminating "import" from checker.py.
300
301 2010-01-28  Anton Muhin  <antonm@chromium.org>
302
303         Reviewed by Shinichiro Hamaji.
304
305         Improve treatment of conditions and rest of the line for if, else, switch and alikes
306         https://bugs.webkit.org/show_bug.cgi?id=34173
307
308         * Scripts/webkitpy/style/cpp_style.py:
309         * Scripts/webkitpy/style/cpp_style_unittest.py:
310
311 2010-01-28  Joe Mason  <jmason@rim.com>
312
313         Reviewed by Adam Barth.
314
315         Limit login retries to 5
316         https://bugs.webkit.org/show_bug.cgi?id=34193
317
318         * Scripts/webkitpy/bugzilla.py:
319
320 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
321
322         Adding myself to the committer list. No review necessary.
323
324         * Scripts/webkitpy/committers.py:
325
326 2010-01-27  George Wright  <gwright@rim.com>
327
328         Reviewed by Adam Treat.
329
330         https://bugs.webkit.org/show_bug.cgi?id=34216
331
332         Add missing include for wtf/Platform.h
333
334         * DumpRenderTree/AccessibilityController.h:
335
336 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
337
338         Reviewed by Kenneth Rohde Christiansen.
339
340         [Qt] DRT Provide worker thread ability to track counters
341         https://bugs.webkit.org/show_bug.cgi?id=34221
342
343         Implement workerThreadCount() in LayoutTestController of Qt DRT
344
345         Tests:
346         fast/workers/dedicated-worker-lifecycle.html
347         fast/workers/shared-worker-frame-lifecycle.html
348         fast/workers/shared-worker-lifecycle.html
349         fast/workers/worker-lifecycle.html
350
351         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
352         (LayoutTestController::workerThreadCount):
353         * DumpRenderTree/qt/LayoutTestControllerQt.h:
354
355 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
356
357         Rubberstamped by Simon Hausmann.
358
359         [Qt] QtLauncher refactoring:
360
361         Make the LauncherWindow depend less on the view, so that more
362         code can be shared in near future.
363
364         * QtLauncher/main.cpp:
365         (LauncherWindow::sendTouchEvent):
366         (LauncherWindow::loadFinished):
367         (LauncherWindow::zoomIn):
368         (LauncherWindow::zoomOut):
369         (LauncherWindow::resetZoom):
370         (LauncherWindow::toggleZoomTextOnly):
371         (LauncherWindow::dumpHtml):
372         (LauncherWindow::selectElements):
373         (LauncherWindow::setupUI):
374
375 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
376
377         Reviewed by Eric Seidel.
378
379         Correctly handle the KeyLocation argument that has been introduced
380         recently to test location-dependent key events in EventSender.keyDown.
381         http://bugs.webkit.org/show_bug.cgi?id=28247
382
383         Test: fast/events/keydown-numpad-keys.html
384
385         * DumpRenderTree/gtk/EventSender.cpp:
386         (keyDownCallback):
387
388 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
389
390         Rubberstamped by Simon Hausmann.
391
392         [Qt] QtLauncher refactoring:
393
394         Move out code from the MainWindow (renamed to LauncherWindow)
395         that is not depending on the view, and add it to a new class
396         called MainWindow.
397
398         * QtLauncher/QtLauncher.pro:
399         * QtLauncher/main.cpp:
400         (LauncherWindow::LauncherWindow):
401         (LauncherWindow::eventFilter):
402         (LauncherWindow::loadStarted):
403         (LauncherWindow::loadFinished):
404         (LauncherWindow::newWindow):
405         (LauncherWindow::setupUI):
406         (WebPage::createWindow):
407         (main):
408         * QtLauncher/mainwindow.cpp: Added.
409         (MainWindow::MainWindow):
410         (MainWindow::buildUI):
411         (MainWindow::page):
412         (MainWindow::setAddressUrl):
413         (MainWindow::addCompleterEntry):
414         (MainWindow::load):
415         (MainWindow::changeLocation):
416         (MainWindow::openFile):
417         * QtLauncher/mainwindow.h: Added.
418
419 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
420
421         Rubberstamped by Simon Hausmann.
422
423         [Qt] QtLauncher, coding style fixes.
424
425         * QtLauncher/main.cpp:
426         (MainWindow::MainWindow):
427         (MainWindow::sendTouchEvent):
428         (MainWindow::eventFilter):
429         (MainWindow::loadURL):
430         (MainWindow::setupUI):
431         (WebPage::createPlugin):
432
433 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
434
435         Rubberstamped by Simon Hausmann.
436
437         [Qt] QtLauncher refactoring, separating the webview and
438         adding a QGraphicsWebView based version.
439
440         * QtLauncher/QtLauncher.pro:
441         * QtLauncher/main.cpp:
442         (MainWindow::MainWindow):
443         * QtLauncher/webpage.h:
444         * QtLauncher/webview.cpp: Added.
445         (createContextMenu):
446         (WebViewGraphicsBased::mousePressEvent):
447         (WebViewTraditional::mousePressEvent):
448         (WebViewGraphicsBased::contextMenuEvent):
449         (WebViewTraditional::contextMenuEvent):
450         * QtLauncher/webview.h: Added.
451         (WebViewGraphicsBased::WebViewGraphicsBased):
452         (WebViewTraditional::WebViewTraditional):
453
454 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
455
456         Adding myself as committer. No review necessary.
457
458         * Scripts/webkitpy/committers.py:
459
460 2010-01-27  Eric Seidel  <eric@webkit.org>
461
462         Reviewed by Darin Adler.
463
464         webkit-patch needs an open-bugs command
465         https://bugs.webkit.org/show_bug.cgi?id=30793
466
467         * Scripts/test-webkitpy: import OpenBugsTest
468         * Scripts/webkit-patch: import OpenBugs
469         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
470         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
471         * Scripts/webkitpy/commands/queries_unittest.py: ditto
472         * Scripts/webkitpy/commands/queues_unittest.py: ditto
473         * Scripts/webkitpy/commands/upload_unittest.py: ditto
474         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
475
476 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
477
478         Rubberstamped by Simon Hausmann
479
480         [Qt] QtLauncher refactoring, separating utility methods.
481
482         * QtLauncher/QtLauncher.pro:
483         * QtLauncher/main.cpp:
484         * QtLauncher/utils.cpp: Added.
485         (urlFromUserInput):
486         * QtLauncher/utils.h: Added.
487
488 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
489
490         Rubberstamped by Simon Hausmann
491
492         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
493
494         * QtLauncher/main.cpp:
495         (MainWindow::MainWindow):
496         * QtLauncher/webpage.cpp:
497         (WebPage::WebPage):
498         (WebPage::applyProxy):
499         * QtLauncher/webpage.h:
500
501 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
502
503         Reviewed by Tor Arne Vestbø.
504
505         [Qt] Corrects debug build of DumpRenderTree on Windows.
506
507         * DumpRenderTree/qt/DumpRenderTree.pro:
508
509 2010-01-26  Daniel Bates  <dbates@webkit.org>
510
511         Reviewed by Adam Barth.
512
513         https://bugs.webkit.org/show_bug.cgi?id=34070
514
515         Moves the try/catch for OSError exceptions in Executive.run_command
516         to Credentials.read_credentials() so that the unit test
517         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
518         assert that Executive.run_command throws an OSError exception.
519
520         * Scripts/webkitpy/credentials.py:
521         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
522         method Credentials.read_credentials().
523         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
524         apply: test_run_command_with_bad_command_check_return_code and
525         test_run_command_with_bad_command_check_calls_error_handler. Added new
526         test to assert that run_command throws OSError exceptions.
527
528 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
529
530         Reviewed by Kenneth Rohde Christiansen.
531
532         [Qt] DRT WebHistory support
533         https://bugs.webkit.org/show_bug.cgi?id=34167
534
535         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
536         (LayoutTestController::reset):
537         (LayoutTestController::webHistoryItemCount):
538         (LayoutTestController::keepWebHistory):
539         * DumpRenderTree/qt/LayoutTestControllerQt.h:
540
541 2010-01-26  Kent Tamura  <tkent@chromium.org>
542
543         Reviewed by Eric Seidel.
544
545         [Win] Add modifiers parameter support to Windows DumpRenderTree
546         https://bugs.webkit.org/show_bug.cgi?id=34068
547
548         Add support for functional name modifiers; "addSelectionKey" and
549         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
550         and eventSender.mouseUp().
551         This change is similar to r53498 for Mac.
552         
553         * DumpRenderTree/win/EventSender.cpp:
554         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
555         (mouseDownCallback): Call buidlModifiersFlags().
556         (mouseUpCallback): ditto.
557         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
558
559 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
560
561         Reviewed by Eric Seidel.
562
563         The Python autoinstall cache directory now only gets created
564         in the directory containing autoinstall.py.
565
566         https://bugs.webkit.org/show_bug.cgi?id=33365
567
568         * Scripts/webkitpy/autoinstall.py:
569           - Also added a README file to the cache directory saying
570             where it came from.
571
572 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
573
574         Reviewed by Eric Seidel.
575
576         Moved the check-webkit-style processors into a new
577         webkitpy/style/processors directory.
578
579         https://bugs.webkit.org/show_bug.cgi?id=34060
580
581         * Scripts/webkitpy/style/checker.py:
582         * Scripts/webkitpy/style/checker_unittest.py:
583         * Scripts/webkitpy/style/cpp_style.py: Removed.
584         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
585         * Scripts/webkitpy/style/processors: Added.
586         * Scripts/webkitpy/style/processors/__init__.py: Added.
587         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
588         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
589         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
590         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
591         * Scripts/webkitpy/style/text_style.py: Removed.
592         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
593         * Scripts/webkitpy/style/unittests.py:
594
595 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
596
597         [wx] Build fix, make sure stub function returns a value.
598
599         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
600         (LayoutTestController::counterValueForElementById):
601
602 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
603
604         Reviewed by Oliver Hunt.
605
606         Windows build references non-existent include paths
607         https://bugs.webkit.org/show_bug.cgi?id=34175
608
609         * DumpRenderTree/win/DumpRenderTree.vcproj:
610         * DumpRenderTree/win/ImageDiff.vcproj:
611         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
612
613 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
614
615         Reviewed by Ariya Hidayat.
616
617         [Qt] Separating out the UrlLoader from the QtLauncher in it's
618         own implementation and header file.
619
620         * QtLauncher/main.cpp:
621         (main):
622         * QtLauncher/urlloader.cpp: Added.
623         (UrlLoader::UrlLoader):
624         (UrlLoader::loadNext):
625         (UrlLoader::init):
626         (UrlLoader::getUrl):
627         * QtLauncher/urlloader.h: Added.
628
629 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
630
631         Reviewed by Shinichiro Hamaji.
632
633         Refactored check-webkit-style by removing the file path
634         parameter from the style error handler functions.
635
636         https://bugs.webkit.org/show_bug.cgi?id=34031
637
638         * Scripts/webkitpy/style/checker.py:
639           - Added _default_style_error_handler() to StyleChecker class.
640           - Moved handle_style_error() to inside _default_style_error_handler().
641
642         * Scripts/webkitpy/style/checker_unittest.py:
643           - Removed file path from calls to error handler.
644
645         * Scripts/webkitpy/style/cpp_style.py:
646           - Removed file path from calls to error handler.
647
648         * Scripts/webkitpy/style/cpp_style_unittest.py:
649           - Removed file path from calls to error handler.
650
651         * Scripts/webkitpy/style/text_style.py:
652           - Removed file path from calls to error handler.
653
654         * Scripts/webkitpy/style/text_style_unittest.py:
655           - Removed file path from calls to error handler.
656
657 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
658
659         Adding myself as reviewer.  No review necessary.
660
661         * Scripts/webkitpy/committers.py:
662
663 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
664
665         Reviewed by Adam Barth.
666
667         Improved prepare-ChangeLog so that it preserves the relative
668         indentation of a git commit message.
669
670         https://bugs.webkit.org/show_bug.cgi?id=34058
671
672         * Scripts/prepare-ChangeLog:
673           - Also adjusted the script so that it does not add white
674             space characters to empty lines.
675
676 2010-01-24  Eric Seidel  <eric@webkit.org>
677
678         No review, rolling out r53763.
679         http://trac.webkit.org/changeset/53763
680         https://bugs.webkit.org/show_bug.cgi?id=33895
681
682         Broke 20+ tests on Windows.
683
684         * Scripts/run-webkit-tests:
685         * Scripts/webkitdirs.pm:
686
687 2010-01-24  Adam Barth  <abarth@webkit.org>
688
689         Rubber stamped by Eric Seidel.
690
691         More pep8 compliance.
692
693         * Scripts/webkitpy/mock_bugzillatool.py:
694
695 2010-01-24  Adam Barth  <abarth@webkit.org>
696
697         Rubber stamped by Eric Seidel.
698
699         More pep8 compliance.
700
701         * Scripts/webkitpy/executive.py:
702         * Scripts/webkitpy/grammar.py:
703
704 2010-01-24  Adam Barth  <abarth@webkit.org>
705
706         Rubber stamped by Eric Seidel.
707
708         More pep8 compliance.
709
710         * Scripts/webkitpy/comments.py:
711         * Scripts/webkitpy/committers.py:
712         * Scripts/webkitpy/credentials.py:
713
714 2010-01-24  Adam Barth  <abarth@webkit.org>
715
716         Rubber stamped by Eric Seidel.
717
718         Make changelogs.py pass pep8.
719
720         * Scripts/webkitpy/changelogs.py:
721
722 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
723
724         [Qt] Unreviewed build fix
725
726         * QtLauncher/QtLauncher.pro:
727         * QtLauncher/webinspector.h:
728
729 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
730
731         Rubberstamped by Simon Hausmann.
732
733         [Qt] Move the WebInspector class to it's own header file.
734
735         * QtLauncher/main.cpp:
736         * QtLauncher/webinspector.h: Added.
737         (WebInspector::WebInspector):
738         (WebInspector::showEvent):
739         (WebInspector::hideEvent):
740
741 2010-01-23  Robert Hogan  <robert@roberthogan.net>
742
743         Reviewed by Kenneth Rohde Christiansen.
744
745         Qt DRT: respect window.close() and window.closed()
746         
747         Qt DRT needs to maintain a correct count of open windows
748         for windowCount(). It also needs to delete windows that
749         have been closed by window.close().
750         
751         This fixes the following tests:
752         
753         plugins/destroy-during-npp-new.html
754         fast/dom/Document/early-document-access.html
755         fast/dom/Window/window-early-properties.html
756         fast/events/open-window-from-another-frame.html
757         fast/events/popup-blocking-click-in-iframe.html
758         
759         https://bugs.webkit.org/show_bug.cgi?id=32953
760
761         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
762         (WebCore::DumpRenderTree::DumpRenderTree):
763         (WebCore::DumpRenderTree::createWindow):
764         (WebCore::DumpRenderTree::windowCloseRequested):
765         * DumpRenderTree/qt/DumpRenderTreeQt.h:
766         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
767         (LayoutTestController::maybeDump):
768
769 2010-01-23  Dan Bernstein  <mitz@apple.com>
770
771         Reviewed by Mark Rowe.
772
773         Added a user default for specifying a fallback frameworks path in case
774         the bundle does not contain frameworks for the current Mac OS X version.
775
776         * WebKitLauncher/main.m:
777         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
778         keyed by the FallbackSystemVersions user default and returns it.
779         (main): If a frameworks directory for the current system version is not found,
780         try the fallback.
781
782 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
783
784         Reviewed by Simon Hausmann.
785
786         Make run-webkit-tests work under Cygwin for the Qt port
787
788         setPathForRunningWebKitApp() is implemented for the Qt port
789         by using qmake to query for the location of the Qt libraries.
790
791         This requires the original environment (%ENV) to be untouched,
792         so launchWithCurrentEnv() was refactored to launchWithEnv(),
793         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
794         instead. This has the added benefit of getting rid of the temp
795         variables used for storing the current env.
796
797         openDumpTool() is also refactored a bit into platform-spesific,
798         port-spesific, and generic environment variables.
799
800         Checks for undef was added a few places to fix Perl concat
801         warnings when run-webkit-tests is aborted.
802
803         https://bugs.webkit.org/show_bug.cgi?id=33895
804
805         * Scripts/run-webkit-tests:
806         * Scripts/webkitdirs.pm:
807
808 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
809
810         Reviewed by Kevin Ollivier.
811
812         [wx] Remove the Bakefile build system, which is no longer being used.
813         
814         https://bugs.webkit.org/show_bug.cgi?id=34022
815
816         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
817         * wx/browser/browser.bkl: Removed.
818         * wx/build-wxwebkit: Removed.
819
820 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
821
822         Reviewed by Simon Fraser.
823
824         Reset zoom level to 1.0 when resetting view state. This is causing
825         many tests to fail after svg/custom/text-zoom.xhtml changes the
826         zoom level.
827
828         * DumpRenderTree/gtk/DumpRenderTree.cpp:
829         (resetDefaultsToConsistentValues):
830
831 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
832
833         Reviewed by Darin Adler.
834
835         https://bugs.webkit.org/show_bug.cgi?id=34025
836         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
837
838         * Scripts/build-webkit:
839
840 2010-01-22  Adam Barth  <abarth@webkit.org>
841
842         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
843
844         * Scripts/webkitpy/commands/queues.py:
845
846 2010-01-22  Adam Barth  <abarth@webkit.org>
847
848         Rubber stamped by Eric Seidel.
849
850         Make __init__.py and buildbot.py pass pep8 style checker.
851
852         * Scripts/webkitpy/__init__.py:
853         * Scripts/webkitpy/buildbot.py:
854
855 2010-01-21  Joe Mason  <jmason@rim.com>
856
857         Reviewed by Adam Barth.
858
859         webkit-patch should retry on invalid password
860         https://bugs.webkit.org/show_bug.cgi?id=33955
861
862         Ask for bugs.webkit.org authentication in a loop.
863
864         * Scripts/webkitpy/bugzilla.py:
865
866 2010-01-22  Adam Barth  <abarth@webkit.org>
867
868         Unreviewed.  Don't call seek on a NoneType.
869
870         * Scripts/webkitpy/statusserver.py:
871
872 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
873
874         Reviewed by David Levin.
875
876         check-webkit-style breaks on files with unknown types
877         https://bugs.webkit.org/show_bug.cgi?id=34001
878
879         For files with type FileType.NONE, dispatch_processor returns None.
880
881         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
882
883 2010-01-22  Adam Barth  <abarth@webkit.org>
884
885         Reviewed by Eric Seidel.
886
887         Make bugzilla.py and webkitport.py conform to pep8
888         https://bugs.webkit.org/show_bug.cgi?id=34015
889
890         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
891         style as enforced by pep8.py.  I wasn't able to get rid of all the
892         errors because I'm not sure how to wrap some lines properly.  Also,
893         there are a few deprication errors that I couldn't resolve easily.
894         However, this is a massive improvement in compliance.
895
896         * Scripts/webkitpy/bugzilla.py:
897         * Scripts/webkitpy/webkitport.py:
898
899 2010-01-22  Adam Barth  <abarth@webkit.org>
900
901         Reviewed by Darin Adler.
902
903         Limit length of EWS results to 5MB
904         https://bugs.webkit.org/show_bug.cgi?id=34016
905
906         Hopefully this will fix the bug where the results link doesn't appear.
907         Our current theory is that the results blob is too big and the server
908         is rejecting the request with a 500 error.  That causes us to re-try
909         the post, but when we re-try the StringIO buffer has its seek pointer
910         at the end.
911
912         * Scripts/webkitpy/commands/queues.py:
913         * Scripts/webkitpy/statusserver.py:
914
915 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
916
917         Reviewed by Adam Barth.
918
919         Made check-webkit-style able to check patches when script not
920         run from source root. Also consolidated external references
921         to a single file.
922
923         https://bugs.webkit.org/show_bug.cgi?id=33791
924
925         * Scripts/check-webkit-style:
926           - Changed to import style_references.py.
927
928         * Scripts/webkitpy/style/__init__.py:
929           - Removed __path__ hack that allowed searching Scripts/ directory.
930
931         * Scripts/webkitpy/style/checker.py:
932           - Changed to import style_references.py.
933
934         * Scripts/webkitpy/style_references.py: Added.
935
936 2010-01-22  Dmitry Titov  <dimich@chromium.org>
937
938         Reviewed by Maciej Stachowiak.
939
940         Fix the leak of ThreadIdentifiers in threadMap across threads.
941         https://bugs.webkit.org/show_bug.cgi?id=32689
942
943         Add a new test to verify the ThreadIdentifiers are not reused across threads.
944         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
945         waiting for the previous thread to terminate before starting the next.
946         The treads use WTF::currentThread() in their thread function. Without a fix, this
947         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
948         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
949         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
950         The test practically does not affect the DRT run time because the threads end immediately.
951
952         * DumpRenderTree/mac/DumpRenderTree.mm:
953         (runThread): Test thread function.
954         (testThreadIdentifierMap):
955         (dumpRenderTree):
956
957 2010-01-22  Kent Tamura  <tkent@chromium.org>
958
959         Reviewed by Maciej Stachowiak.
960
961         Fix a bug that mouseDown:withModifiers: is never called.
962         https://bugs.webkit.org/show_bug.cgi?id=33989
963
964         * DumpRenderTree/mac/EventSendingController.mm:
965         (+[EventSendingController isSelectorExcludedFromWebScript:]):
966         (+[EventSendingController webScriptNameForSelector:]):
967
968 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
969
970         Rubberstamped by Antti Koivisto.
971
972         [Qt] Separate out the WebPage class into it's own
973         cpp/header files. Also, removed the assumption that
974         the view is a QWebView, in preparation of a merger
975         of the two Qt WebKit launchers.
976
977         * QtLauncher/QtLauncher.pro:
978         * QtLauncher/main.cpp:
979         (WebView::mousePressEvent):
980         * QtLauncher/webpage.cpp: Added.
981         (WebPage::supportsExtension):
982         (WebPage::extension):
983         (WebPage::acceptNavigationRequest):
984         (WebPage::openUrlInDefaultBrowser):
985         * QtLauncher/webpage.h: Added.
986         (WebPage::WebPage):
987
988 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
989
990         Reviewed by Shinichiro Hamaji.
991
992         Refactored to move file name and file-reading related code
993         from cpp_style.py and text_style.py to checker.py.
994
995         https://bugs.webkit.org/show_bug.cgi?id=33775
996
997         * Scripts/check-webkit-style:
998           - Updates caused by changes to checker.py.
999
1000         * Scripts/webkitpy/style/checker.py:
1001           - Added SKIPPED_FILES_WITH_WARNING list.
1002           - Added SKIPPED_FILES_WITHOUT_WARNING list.
1003           - Added FileType class.
1004           - Added ProcessorDispatcher class.
1005           - In StyleChecker class:
1006             - Renamed process_patch() to check_patch().
1007             - Renamed process_file() to check_file().
1008             - Added _process_file().
1009             - Related refactoring.
1010             - Addressed check_patch() FIXME to share code with process_file().
1011
1012         * Scripts/webkitpy/style/checker_unittest.py:
1013           - Added ProcessorDispatcherSkipTest class.
1014           - Added ProcessorDispatcherDispatchTest class.
1015           - Added StyleCheckerCheckFileTest class.
1016
1017         * Scripts/webkitpy/style/cpp_style.py:
1018           - Renamed process_file_data() to _process_lines.
1019           - Removed process_file() (moved logic to checker.py).
1020           - Removed can_handle() (moved logic to checker.py).
1021           - Added CppProcessor class.
1022           - Removed is_exempt() (moved logic to checker.py).
1023           - Added process_file_data() back as a wrapper function.
1024
1025         * Scripts/webkitpy/style/cpp_style_unittest.py:
1026           - Removed test_can_handle().
1027           - Removed test_is_exempt().
1028           - Added CppProcessorTest class.
1029
1030         * Scripts/webkitpy/style/text_style.py:
1031           - Added TextProcessor class.
1032           - Removed process_file().
1033           - Removed can_handle().
1034
1035         * Scripts/webkitpy/style/text_style_unittest.py:
1036           - Removed test_can_handle().
1037           - Added TextProcessorTest class.
1038
1039 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1040
1041         Reviewed by David Kilzer.
1042
1043         Create a unit-tested subroutine to parse patch files created
1044         by svn-create-patch.
1045
1046         https://bugs.webkit.org/show_bug.cgi?id=33475
1047
1048         * Scripts/VCSUtils.pm:
1049           - Added parseDiff().
1050           - Added parsePatch().
1051
1052         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
1053           - Added unit tests for parseDiff().
1054
1055         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1056           - Total number of tests now computed dynamically.
1057
1058         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
1059           - Added unit tests for parsePatch().
1060
1061 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
1062
1063         [wx] Build fix, add new directory to dir list.
1064
1065         * wx/build/settings.py:
1066
1067 2010-01-21  Adam Barth  <abarth@webkit.org>
1068
1069         Reviewed by Eric Seidel.
1070
1071         Make the EWS transactional
1072         https://bugs.webkit.org/show_bug.cgi?id=33978
1073
1074         Now if the EWS gets interrupted in the middle of processing a patch,
1075         the bots will re-process the patch.
1076
1077         * Scripts/test-webkitpy:
1078         * Scripts/webkitpy/commands/queues.py:
1079         * Scripts/webkitpy/commands/queues_unittest.py:
1080         * Scripts/webkitpy/patchcollection.py:
1081         * Scripts/webkitpy/patchcollection_unittest.py: Added.
1082
1083 2010-01-21  Adam Barth  <abarth@webkit.org>
1084
1085         Unreviewed.  Add missing "ago" for style in the status bubble.
1086
1087         * QueueStatusServer/templates/statusbubble.html:
1088
1089 2010-01-21  Adam Barth  <abarth@webkit.org>
1090
1091         Reviewed by David Levin.
1092
1093         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
1094         https://bugs.webkit.org/show_bug.cgi?id=33356
1095
1096         White list unix_hacker_style names in WebKit/gtk/webkit because these
1097         are used in the GTK+ API.
1098
1099         * Scripts/webkitpy/style/cpp_style.py:
1100         * Scripts/webkitpy/style/cpp_style_unittest.py:
1101
1102 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1103
1104         Reviewed by Kenneth Rohde Christiansen.
1105
1106         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
1107         https://bugs.webkit.org/show_bug.cgi?id=33945
1108
1109         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1110         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1111         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1112
1113 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
1114
1115         No review, rolling out 53615 as it causes two
1116         crashes on the bot.
1117
1118         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1119         (WebCore::DumpRenderTree::DumpRenderTree):
1120         (WebCore::DumpRenderTree::createWindow):
1121         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1122         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1123         (LayoutTestController::maybeDump):
1124
1125 2010-01-21  Robert Hogan  <robert@roberthogan.net>
1126
1127         Reviewed by Simon Hausmann.
1128
1129         Qt DRT: respect window.close() and window.closed()
1130
1131         Qt DRT needs to maintain a correct count of open windows
1132         for windowCount(). It also needs to delete windows that
1133         have been closed by window.close().
1134
1135         This fixes the following tests:
1136
1137         plugins/destroy-during-npp-new.html
1138         fast/dom/Document/early-document-access.html
1139         fast/dom/Window/window-early-properties.html
1140         fast/events/open-window-from-another-frame.html
1141         fast/events/popup-blocking-click-in-iframe.html
1142
1143         https://bugs.webkit.org/show_bug.cgi?id=32953
1144
1145         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1146         (WebCore::DumpRenderTree::DumpRenderTree):
1147         (WebCore::DumpRenderTree::createWindow):
1148         (WebCore::DumpRenderTree::windowCloseRequested):
1149         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1150         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1151         (LayoutTestController::maybeDump):
1152
1153 2010-01-20  Eric Seidel  <eric@webkit.org>
1154
1155         No review, rolling out r53593.
1156         http://trac.webkit.org/changeset/53593
1157         https://bugs.webkit.org/show_bug.cgi?id=33496
1158
1159         Re-rollout this patch, the commit-queue should not have landed
1160         it again, but it did due to land-diff and rollout both not
1161         clearing flags.
1162
1163         * Scripts/webkitpy/commands/early_warning_system.py:
1164         * Scripts/webkitpy/commands/queues.py:
1165         * Scripts/webkitpy/queueengine.py:
1166         * Scripts/webkitpy/scm.py:
1167         * Scripts/webkitpy/scm_unittest.py:
1168
1169 2010-01-20  Eric Seidel  <eric@webkit.org>
1170
1171         Reviewed by Adam Barth.
1172
1173         webkit-commit-queue status page is confusing
1174         https://bugs.webkit.org/show_bug.cgi?id=33496
1175
1176         This should improve the status page by removing more Fail messages.
1177         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1178         to behave more like one another.  This meant moving where the failure reporting was done.
1179         Previously the AbstractReviewQueue always used the parent process to report the error,
1180         while CommitQueue used the subprocess when possible, and the parent only reported errors
1181         that we didn't know how to handle (bugs in the commit-queue itself).
1182         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1183         in both implementations and required teaching handle_script_error in each to post Fail messages
1184         to the status server instead of calling exit(1).
1185
1186         This will also make the style-queue share more bug posting logic with other queues:
1187         https://bugs.webkit.org/show_bug.cgi?id=33871
1188
1189         * Scripts/webkitpy/commands/early_warning_system.py:
1190          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1191            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1192            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1193            _update_status_for_script_error knows how to post the Fail message to the status server.
1194          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1195         * Scripts/webkitpy/commands/queues.py:
1196          - Remove the try block from process_work_item since the caller already has one.
1197          - Only CC watchers on failure to cut down on commit-queue generated mail.
1198          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1199          - Abstract _format_script_error_output_for_bug to share code between all queues.
1200          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1201          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1202          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1203          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1204         * Scripts/webkitpy/queueengine.py:
1205          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1206         * Scripts/webkitpy/scm.py:
1207          - Add new checkout_revision function.
1208         * Scripts/webkitpy/scm_unittest.py:
1209          - Test our new checkout_revision function.
1210
1211 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
1212
1213         Reviewed by Alexey Proskuryakov.
1214
1215         WebSocket: Missing Request-URI, when no tralling slash in host
1216         https://bugs.webkit.org/show_bug.cgi?id=33689
1217
1218         Update pywebsocket to 0.4.7.1, which supports alias for resource
1219         name, so that we could test for ws://127.0.0.1:8880
1220
1221         * Scripts/run-webkit-tests:
1222         * Scripts/run-webkit-websocketserver:
1223         * pywebsocket/mod_pywebsocket/dispatch.py:
1224         * pywebsocket/mod_pywebsocket/handshake.py:
1225         * pywebsocket/mod_pywebsocket/standalone.py:
1226         * pywebsocket/setup.py:
1227         * pywebsocket/test/test_dispatch.py:
1228         * pywebsocket/test/test_handshake.py:
1229
1230 2010-01-20  Eric Seidel  <eric@webkit.org>
1231
1232         No review, rolling out r53537.
1233         http://trac.webkit.org/changeset/53537
1234         https://bugs.webkit.org/show_bug.cgi?id=33496
1235
1236         Added a failure condition to the commit-queue and looks to
1237         have broken the EWS bots
1238
1239         * Scripts/webkitpy/commands/early_warning_system.py:
1240         * Scripts/webkitpy/commands/queues.py:
1241         * Scripts/webkitpy/queueengine.py:
1242         * Scripts/webkitpy/scm.py:
1243         * Scripts/webkitpy/scm_unittest.py:
1244
1245 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
1246
1247         MSAA: accSelect() is not implemented
1248
1249         https://bugs.webkit.org/show_bug.cgi?id=33918
1250         <rdar://problem/7436861>
1251
1252         Reviewed by Darin Adler.
1253
1254         * DumpRenderTree/AccessibilityUIElement.cpp:
1255         (takeFocusCallback):
1256         Call the object's takeFocus() function.
1257         (takeSelectionCallback):
1258         Call its takeSelection() function.
1259         (addSelectionCallback):
1260         Call its addSelection() function.
1261         (removeSelectionCallback):
1262         Call its removeSelection() function.
1263         (AccessibilityUIElement::getJSClass):
1264         Add new functions to the JS class definition.
1265
1266         * DumpRenderTree/AccessibilityUIElement.h:
1267         Declare new functions.
1268
1269         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1270         (AccessibilityUIElement::takeFocus):
1271         Stubbed.
1272         (AccessibilityUIElement::takeSelection):
1273         Stubbed.
1274         (AccessibilityUIElement::addSelection):
1275         Stubbed.
1276         (AccessibilityUIElement::removeSelection):
1277         Stubbed.
1278
1279         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1280         (AccessibilityUIElement::takeFocus):
1281         Stubbed.
1282         (AccessibilityUIElement::takeSelection):
1283         Stubbed.
1284         (AccessibilityUIElement::addSelection):
1285         Stubbed.
1286         (AccessibilityUIElement::removeSelection):
1287         Stubbed.
1288
1289         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1290         (AccessibilityUIElement::takeFocus):
1291         Call the object's accSelect() function, passing the appropriate flag.
1292         (AccessibilityUIElement::takeSelection):
1293         Ditto.
1294         (AccessibilityUIElement::addSelection):
1295         Ditto.
1296         (AccessibilityUIElement::removeSelection):
1297         Ditto.
1298
1299 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
1300
1301         Reviewed by Alexey Proskuryakov.
1302
1303         Extract Apache handling to httpd.pm module and use the provided functionality
1304         in scripts where Apache is needed.
1305         The module httpd.pm stores the PID of Apache in a variable and cleans up
1306         the PID directory after Apache properly shut down. Catching INT and TERM
1307         signals allows the scripts to close Apache and clean up its PID directory
1308         even if the testing was interrupted.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=33153
1311
1312         * Scripts/webkitperl/httpd.pm: Added.
1313         * Scripts/run-iexploder-tests:
1314         * Scripts/run-webkit-httpd:
1315         * Scripts/run-webkit-tests:
1316
1317 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1318
1319         Reviewed by Simon Hausmann.
1320
1321         [Qt] Make DumpRenderTree build on Windows
1322
1323         * DumpRenderTree/qt/DumpRenderTree.pro:
1324         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1325         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1326         * DumpRenderTree/qt/main.cpp:
1327
1328 2010-01-20  Steve Block  <steveblock@google.com>
1329
1330         Reviewed by Eric Seidel.
1331
1332         Fix commit bot to land patches in order of the bug last modification date.
1333         https://bugs.webkit.org/show_bug.cgi?id=33395
1334
1335         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
1336
1337 2010-01-20  Adam Barth  <abarth@webkit.org>
1338
1339         Reviewed by Eric Seidel.
1340
1341         Teach check-webkit-style about WebKit/gtk/tests
1342         https://bugs.webkit.org/show_bug.cgi?id=33892
1343
1344         Removes false positives found in
1345         https://bugs.webkit.org/show_bug.cgi?id=30883
1346
1347         * Scripts/webkitpy/style/cpp_style.py:
1348         * Scripts/webkitpy/style/cpp_style_unittest.py:
1349
1350 2010-01-20  Adam Barth  <abarth@webkit.org>
1351
1352         Reviewed by Eric Seidel.
1353
1354         Teach check-webkit-style about QGVLauncher
1355         https://bugs.webkit.org/show_bug.cgi?id=33890
1356
1357         Remove false positives found in
1358         https://bugs.webkit.org/show_bug.cgi?id=33708
1359
1360         * Scripts/webkitpy/style/cpp_style.py:
1361         * Scripts/webkitpy/style/cpp_style_unittest.py:
1362
1363 2010-01-20  Eric Seidel  <eric@webkit.org>
1364
1365         Reviewed by Adam Barth.
1366
1367         webkit-commit-queue status page is confusing
1368         https://bugs.webkit.org/show_bug.cgi?id=33496
1369
1370         This should improve the status page by removing more Fail messages.
1371         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
1372         to behave more like one another.  This meant moving where the failure reporting was done.
1373         Previously the AbstractReviewQueue always used the parent process to report the error,
1374         while CommitQueue used the subprocess when possible, and the parent only reported errors
1375         that we didn't know how to handle (bugs in the commit-queue itself).
1376         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
1377         in both implementations and required teaching handle_script_error in each to post Fail messages
1378         to the status server instead of calling exit(1).
1379
1380         This will also make the style-queue share more bug posting logic with other queues:
1381         https://bugs.webkit.org/show_bug.cgi?id=33871
1382
1383         * Scripts/webkitpy/commands/early_warning_system.py:
1384          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
1385            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
1386            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
1387            _update_status_for_script_error knows how to post the Fail message to the status server.
1388          - Teach _update_status_for_script_error how to post Fail messages to the status server.
1389         * Scripts/webkitpy/commands/queues.py:
1390          - Remove the try block from process_work_item since the caller already has one.
1391          - Only CC watchers on failure to cut down on commit-queue generated mail.
1392          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
1393          - Abstract _format_script_error_output_for_bug to share code between all queues.
1394          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
1395          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
1396          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
1397          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
1398         * Scripts/webkitpy/queueengine.py:
1399          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
1400         * Scripts/webkitpy/scm.py:
1401          - Add new checkout_revision function.
1402         * Scripts/webkitpy/scm_unittest.py:
1403          - Test our new checkout_revision function.
1404
1405 2010-01-20  Adam Barth  <abarth@webkit.org>
1406
1407         Reviewed by Darin Adler.
1408
1409         Exempt JavaScriptCore/qt/api from style checks
1410         https://bugs.webkit.org/show_bug.cgi?id=33879
1411
1412         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
1413         API.
1414
1415         * Scripts/webkitpy/style/cpp_style.py:
1416         * Scripts/webkitpy/style/cpp_style_unittest.py:
1417
1418 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1419
1420         Reviewed by Simon Hausmann.
1421
1422         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
1423
1424         QSocketNotifier is not available on Windows. Instead we read
1425         stdin synchronously after each test using signals and slots.
1426
1427         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1428         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1429         * DumpRenderTree/qt/main.cpp:
1430
1431 2010-01-19  Adam Barth  <abarth@webkit.org>
1432
1433         Rubber stamped by Eric Seidel.
1434
1435         Move chromium-ews back to building release only to make the EWS faster.
1436
1437         * Scripts/webkitpy/commands/early_warning_system.py:
1438
1439 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
1440
1441         MSAA: The child <option> elements of a non-multiple <select> are not
1442         exposed
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=33773
1445         <rdar://problem/7550556>
1446
1447         Reviewed by Alice Liu.
1448
1449         * DumpRenderTree/AccessibilityUIElement.cpp:
1450         (getIsVisibleCallback):
1451         Call the object's isVisible() function.
1452         (getIsOffScreenCallback):
1453         Ditto, for isOffScreen().
1454         (getIsCollapsedCallback):
1455         Ditto, for isCollapsed().
1456         (getHasPopupCallback):
1457         Ditto, for hasPopup().
1458         (AccessibilityUIElement::getJSClass):
1459         Add isVisible and isOffScreen attributes.
1460
1461         * DumpRenderTree/AccessibilityUIElement.h:
1462         Declare new functions.
1463
1464         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1465         (AccessibilityUIElement::isVisible):
1466         Stubbed.
1467         (AccessibilityUIElement::isOffScreen):
1468         Stubbed.
1469         (AccessibilityUIElement::isCollapsed):
1470         Stubbed.
1471         (AccessibilityUIElement::hasPopup):
1472         Stubbed.
1473
1474         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1475         (AccessibilityUIElement::isVisible):
1476         Stubbed.
1477         (AccessibilityUIElement::isOffScreen):
1478         Stubbed.
1479         (AccessibilityUIElement::isCollapsed):
1480         Stubbed.
1481         (AccessibilityUIElement::hasPopup):
1482         Stubbed.
1483
1484         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1485         (AccessibilityUIElement::showMenu):
1486         Call the object's accDoDefaultAction() to show its popup menu.
1487         (AccessibilityUIElement::isEnabled):
1488         Check that the object does not have the "unavailable" state.
1489         (AccessibilityUIElement::isVisible):
1490         Check that the object does not have the "invisible" state.
1491         (AccessibilityUIElement::isOffScreen):
1492         Check whether the object has the "offscreen" state.
1493         (AccessibilityUIElement::isCollapsed):
1494         Check whether the object has the "collapsed" state.
1495         (AccessibilityUIElement::hasPopup):
1496         Check whether the object has the "has popup" state.
1497
1498 2010-01-19  Victor Wang  <victorw@chromium.org>
1499
1500         Reviewed by Eric Seidel.
1501
1502         Correct committer name.
1503         https://bugs.webkit.org/show_bug.cgi?id=33868
1504
1505         * Scripts/webkitpy/committers.py:
1506
1507 2010-01-19  Kent Tamura  <tkent@chromium.org>
1508
1509         Reviewed by Darin Adler.
1510
1511         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
1512         https://bugs.webkit.org/show_bug.cgi?id=33783
1513
1514         Some listbox tests check selection behavior by click events with
1515         "meta" or "shift" keys. Behaviors for such modifier keys are
1516         platform-dependent. The new parameter of mouseDown() and mouseUp()
1517         allows to specify not only concrete modifier keys such as
1518         "shiftKey" "metaKey", but also functional names like
1519         "addSelectionKey" "rangeSelectionKey".
1520
1521         * DumpRenderTree/mac/EventSendingController.mm:
1522         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1523         (+[EventSendingController webScriptNameForSelector:]):
1524         (buildModifierFlags):
1525         (-[EventSendingController mouseDown:withModifiers:]):
1526         (-[EventSendingController mouseDown:]):
1527         (-[EventSendingController mouseUp:withModifiers:]):
1528         (-[EventSendingController mouseUp:]):
1529         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1530
1531 2010-01-19  Adam Barth  <abarth@webkit.org>
1532
1533         Reviewed by Eric Seidel.
1534
1535         Unbreak --request-commit
1536         https://bugs.webkit.org/show_bug.cgi?id=33832
1537
1538         * Scripts/webkitpy/bugzilla.py:
1539
1540 2010-01-19  Eric Seidel  <eric@webkit.org>
1541
1542         Reviewed by Adam Barth.
1543
1544         validate-committer-lists throws exception and committers.py needs a refresh
1545         https://bugs.webkit.org/show_bug.cgi?id=33831
1546
1547         * Scripts/validate-committer-lists: use webkit_logging
1548         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
1549
1550 2010-01-18  Adam Roben  <aroben@apple.com>
1551
1552         Add LayoutTestController support for calling new WebKit SPI to
1553         disallow setting document.domain
1554
1555         DRT part of fixing <http://webkit.org/b/33806>
1556         <rdar://problem/7552837> Would like API to disallow setting of
1557         document.domain for pages with certain URL schemes
1558
1559         Reviewed by Sam Weinig.
1560
1561         * DumpRenderTree/LayoutTestController.cpp:
1562         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
1563         through to LayoutTestController.
1564         (LayoutTestController::staticFunctions): Added
1565         setDomainRelaxationForbiddenForURLScheme.
1566
1567         * DumpRenderTree/LayoutTestController.h: Added
1568         setDomainRelaxationForbiddenForURLScheme.
1569
1570         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1571         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1572         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1573         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1574         Added. Calls through to WebKit.
1575
1576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1577         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1578         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1579         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1580         Stubbed out.
1581
1582 2010-01-18  Adam Barth  <abarth@webkit.org>
1583
1584         Reviewed by Adam Roben.
1585
1586         Rename patches-to-commit to patches-in-commit-queue
1587         https://bugs.webkit.org/show_bug.cgi?id=33789
1588
1589         The command really lists the patches in the commit-queue not all the
1590         patches that are pending-commit (as the FIXME commands).
1591
1592         * Scripts/webkitpy/commands/queries.py:
1593         * Scripts/webkitpy/commands/queries_unittest.py:
1594
1595 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1596
1597         Reviewed by Simon Hausmann.
1598
1599         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
1600
1601         * Scripts/webkitdirs.pm:
1602
1603 2010-01-18  Adam Roben  <aroben@apple.com>
1604
1605         Clean up use of /useenv when invoking Visual C++
1606
1607         This change reverts things to their pre-r49485 state. That revision
1608         (and, subsequently, r49664 and r51788) started passing /useenv to
1609         Visual C++, even in cases where we don't want to do so (such as when
1610         invoking Visual C++ Express), in the name of making the Chromium build
1611         work. Now that Chromium isn't using buildVisualStudioProject or
1612         pdevenv, we can put things back they way they were.
1613
1614         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
1615         (due to /useenv flag)
1616
1617         Reviewed by Sam Weinig.
1618
1619         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
1620         script anymore.
1621         * Scripts/webkitdirs.pm:
1622         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
1623         care of this itself, and we don't want to pass /useenv when not using
1624         pdevenv (e.g., when using VC++ Express, because that will cause it to
1625         ignore the Platform SDK).
1626
1627 2010-01-18  Adam Barth  <abarth@webkit.org>
1628
1629         Reviewed by Eric Seidel.
1630
1631         webkit-patch land-safely should obsolete old patches
1632         https://bugs.webkit.org/show_bug.cgi?id=33788
1633
1634         When posting a commit-queue+ patch with land-safely, we should
1635         obsolete the old patches on the bug.  They're really confusing
1636         because the main use case is to address reviewer feedback on a
1637         previous patch.
1638
1639         * Scripts/webkitpy/commands/upload.py:
1640         * Scripts/webkitpy/commands/upload_unittest.py:
1641
1642 2010-01-18  Adam Barth  <abarth@webkit.org>
1643
1644         Reviewed by David Levin.
1645
1646         webkit-patch should authenticate more often
1647         https://bugs.webkit.org/show_bug.cgi?id=33701
1648
1649         This makes it easier to work with security patches.
1650
1651         * Scripts/webkitpy/bugzilla.py:
1652
1653 2010-01-18  Adam Barth  <abarth@webkit.org>
1654
1655         Reviewed by Darin Adler.
1656
1657         style checker needs to know about GObject-specific requirements
1658         inside WebCore/bindings/gobject/
1659         https://bugs.webkit.org/show_bug.cgi?id=33606
1660
1661         Add an exception to the underscore rule for certain
1662         GObject-specific names.
1663
1664         * Scripts/webkitpy/style/cpp_style.py:
1665         * Scripts/webkitpy/style/cpp_style_unittest.py:
1666
1667 2010-01-18  Adam Barth  <abarth@webkit.org>
1668
1669         Reviewed by Shinichiro Hamaji.
1670
1671         [check-webkit-style] does understand ResourceHandleWin.h
1672         https://bugs.webkit.org/show_bug.cgi?id=32975
1673
1674         I'm not 100% convinced this fix is correct, but without more examples,
1675         it's hard to generalize.  We can always generalize the fix in the
1676         future.
1677
1678         * Scripts/webkitpy/style/cpp_style.py:
1679         * Scripts/webkitpy/style/cpp_style_unittest.py:
1680
1681 2010-01-18  Adam Barth  <abarth@webkit.org>
1682
1683         Unreviewed "build" fix.
1684
1685         * Scripts/webkitpy/bugzilla.py:
1686
1687 2010-01-18  Adam Barth  <abarth@webkit.org>
1688
1689         Unreviewed.  Actually make land-safely mark commit-queue+ as
1690         discussed with Eric.
1691
1692         * Scripts/webkitpy/bugzilla.py:
1693         * Scripts/webkitpy/steps/postdiffforcommit.py:
1694
1695 2010-01-17  Adam Barth  <abarth@webkit.org>
1696
1697         Reviewed by Darin Adler.
1698
1699         style-queue complains about one-line macros that include multiple statements
1700         https://bugs.webkit.org/show_bug.cgi?id=33173
1701
1702         Add an exception for multiple statements on a line that starts a macro.
1703
1704         * Scripts/webkitpy/style/cpp_style.py:
1705         * Scripts/webkitpy/style/cpp_style_unittest.py:
1706
1707 2010-01-17  Adam Barth  <abarth@webkit.org>
1708
1709         Reviewed by Darin Adler.
1710
1711         [check-webkit-style] qt unit testing false positives
1712         https://bugs.webkit.org/show_bug.cgi?id=32833
1713
1714         Exempt the Qt API and unit tests from the style checker.
1715
1716         * Scripts/webkitpy/style/cpp_style.py:
1717         * Scripts/webkitpy/style/cpp_style_unittest.py:
1718
1719 2010-01-17  Adam Barth  <abarth@webkit.org>
1720
1721         Reviewed by Darin Adler.
1722
1723         style-check script reports loads of errors on gtk2drawing.c
1724         https://bugs.webkit.org/show_bug.cgi?id=33771
1725
1726         Exempt WebCore/platform/gtk/gtk2drawing.c and
1727         WebCore/platform/gtk/gtk2drawing.h from style checks.
1728
1729         * Scripts/webkitpy/style/cpp_style.py:
1730         * Scripts/webkitpy/style/cpp_style_unittest.py:
1731
1732 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1733
1734         Reviewed by Shinichiro Hamaji.
1735
1736         Finished eliminating _cpp_style_state global state variable from
1737         check-webkit-style code and eliminating _CppStyleState class.
1738
1739         https://bugs.webkit.org/show_bug.cgi?id=33764
1740
1741         * Scripts/webkitpy/style/checker.py:
1742           - Minor updates caused by changes to cpp_style.py.
1743
1744         * Scripts/webkitpy/style/cpp_style.py:
1745           - Removed _CppStyleState class.
1746           - Removed verbose_level functions.
1747           - Added verbosity as a parameter to _FunctionState constructor.
1748           - Added verbosity as a parameter to process_file().
1749           - Added verbosity as a parameter to process_file_data().
1750
1751         * Scripts/webkitpy/style/cpp_style_unittest.py:
1752           - Added helper functions to set verbosity while running tests.
1753
1754 2010-01-17  Adam Barth  <abarth@webkit.org>
1755
1756         Reviewed by Shinichiro Hamaji.
1757
1758         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
1759         https://bugs.webkit.org/show_bug.cgi?id=33663
1760
1761         * Scripts/webkitpy/style/cpp_style.py:
1762         * Scripts/webkitpy/style/cpp_style_unittest.py:
1763
1764 2010-01-17  Adam Barth  <abarth@webkit.org>
1765
1766         Reviewed by Eric Seidel.
1767
1768         style-queue complains about missing #include of config.h for non-WebCore projects
1769         https://bugs.webkit.org/show_bug.cgi?id=33170
1770
1771         WebKitAPITests are consumers of the WebKit API and therefore do not
1772         need to follow the same include discipline as the rest of WebKit.  This
1773         patch exempts them from the include checks.
1774
1775         * Scripts/webkitpy/style/cpp_style.py:
1776         * Scripts/webkitpy/style/cpp_style_unittest.py:
1777
1778 2010-01-17  Adam Barth  <abarth@webkit.org>
1779
1780         Reviewed by Eric Seidel.
1781
1782         EWS (Early Warning Systems) should build both debug and release
1783         https://bugs.webkit.org/show_bug.cgi?id=33681
1784
1785         Build both debug and release for chromium-ews.
1786
1787         * Scripts/webkitpy/commands/early_warning_system.py:
1788
1789 2010-01-17  Adam Barth  <abarth@webkit.org>
1790
1791         Reviewed by Darin Adler.
1792
1793         style-queue should include instructions for how to file bugs against check-webkit-style
1794         https://bugs.webkit.org/show_bug.cgi?id=32345
1795
1796         Added some text to the error message asking folks to file bugs against
1797         false positives.
1798
1799         * Scripts/webkitpy/commands/queues.py:
1800
1801 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
1802
1803         Reviewed by Adam Barth.
1804
1805         Eliminated the error_count global variable and related
1806         check-webkit-style refactoring.
1807
1808         https://bugs.webkit.org/show_bug.cgi?id=33678
1809
1810         * Scripts/check-webkit-style:
1811           - Updated to use webkit_argument_defaults().
1812           - Renamed styleChecker to style_checker.
1813
1814         * Scripts/webkitpy/style/checker.py:
1815           - Prefixed the three default arguments with WEBKIT_DEFAULT.
1816           - Added webkit_argument_defaults().
1817           - Added default filter_rules parameter to CategoryFilter constructor.
1818           - Added __ne__() to CategoryFilter class.
1819           - Added __eq__() and __ne__() to ProcessorOptions class.
1820           - Added error_count and _write_error attributes to StyleChecker class.
1821           - Made StyleChecker._handle_error() increment the error count.
1822
1823         * Scripts/webkitpy/style/checker_unittest.py:
1824           - Improved CategoryFilterTest.test_eq().
1825           - Added CategoryFilterTest.test_ne().
1826           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
1827           - Updated unit tests to use webkit_argument_defaults().
1828           - Added StyleCheckerTest class.
1829
1830         * Scripts/webkitpy/style/cpp_style.py:
1831           - Removed references to global error_count.
1832
1833         * Scripts/webkitpy/style/cpp_style_unittest.py:
1834           - Removed CppStyleStateTest class.
1835
1836 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
1837
1838         get_accParent should try to retrieve parent AccessibilityObject, before
1839         calling upon window
1840
1841         https://bugs.webkit.org/show_bug.cgi?id=22893
1842
1843         Reviewed by Darin Adler.
1844
1845         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1846         (AccessibilityUIElement::parentElement):
1847         Get the object's parent. Query it for IAccessible, and return it.
1848
1849 2010-01-16  Dan Bernstein  <mitz@apple.com>
1850
1851         Reviewed by Mark Rowe.
1852
1853         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
1854
1855         * DumpRenderTree/mac/CheckedMalloc.cpp:
1856         (makeLargeMallocFailSilently): Temporarily allow writing to the default
1857         malloc zone structure while modifying it.
1858
1859 2010-01-16  David Kilzer  <ddkilzer@apple.com>
1860
1861         Added back removed properties to iExploder input files
1862
1863         While the update-iexploder-cssproperties script works great to
1864         add new properties, it has the side-effect of removing old
1865         properties that once were parsed.
1866
1867         * iExploder/htdocs/cssproperties.in: Added back removed
1868         properties into their own section.
1869         * iExploder/htdocs/htmlattrs.in: Ditto.
1870
1871 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
1872
1873         Reviewed by David Kilzer.
1874
1875         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
1876         https://bugs.webkit.org/show_bug.cgi?id=33756
1877
1878         * iExploder/htdocs/cssproperties.in: New CSS attributes
1879         * iExploder/htdocs/htmlattrs.in: New HTML attributes
1880         * iExploder/htdocs/htmltags.in: New HTML tags
1881
1882 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
1883
1884         Reviewed by David Kilzer.
1885
1886         Altered parseDiffHeader() to skip unrecognized lines and
1887         other minor clean-ups.
1888
1889         https://bugs.webkit.org/show_bug.cgi?id=33476
1890
1891         * Scripts/VCSUtils.pm:
1892           - Changed parseDiffHeader() as follows:
1893             - Skips over unrecognized lines.
1894             - Addressed FIXME to remove substitution for "diff" line.
1895             - Renamed "version" header hash key to "sourceRevision".
1896             - Eliminated "copiedFromVersion" header hash key.
1897             - Included "sourceRevision" also for copied files.
1898             - Checks that copy revision number matches "sourceRevision".
1899             - No longer returns $foundHeaderEnding.
1900             - Dies if header ending not found.
1901             - Diff header dividing line now always added.
1902
1903         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1904           - Made necessary changes in parseDiffHeader() unit tests.
1905           - Shortened the file paths in some test cases.
1906
1907 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
1908
1909         Reviewed by Alexey Proskuryakov.
1910
1911         Update pywebsocket to 0.4.6
1912         https://bugs.webkit.org/show_bug.cgi?id=32299
1913         The newer pywebsocket can handle more simultaneous connections.
1914
1915         * pywebsocket/mod_pywebsocket/handshake.py:
1916         * pywebsocket/mod_pywebsocket/standalone.py:
1917         * pywebsocket/setup.py:
1918         * pywebsocket/test/test_handshake.py:
1919
1920 2010-01-14  Eric Seidel  <eric@webkit.org>
1921
1922         Reviewed by Adam Barth.
1923
1924         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
1925         https://bugs.webkit.org/show_bug.cgi?id=33638
1926
1927         * Scripts/webkitpy/bugzilla.py:
1928          - Add Bug.id() to match Attachment.id()
1929          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
1930          - Add back a missing variable to _validate_setter_email found by the new unit tests!
1931         * Scripts/webkitpy/commands/queries.py:
1932          - Add FIXMEs about the commands being confusingly named.
1933         * Scripts/webkitpy/commands/queries_unittest.py:
1934          - Update results to reflect the newly restructured mock bug cache.
1935         * Scripts/webkitpy/commands/queues.py:
1936          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
1937          - Add a FIXME about eventually sorting the patches into some order.
1938         * Scripts/webkitpy/commands/queues_unittest.py:
1939          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
1940         * Scripts/webkitpy/commands/upload_unittest.py:
1941          - Update results to match the newly restructured mock bug cache.
1942         * Scripts/webkitpy/mock_bugzillatool.py:
1943          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
1944          - Add a few more attachments and bug dictionaries for use by the tests.
1945
1946 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1947
1948         Reviewed by Kenneth Christiansen.
1949
1950         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
1951         https://bugs.webkit.org/show_bug.cgi?id=33617
1952
1953         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1954         (WebCore::WebPage::resetSettings):
1955         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1956         (LayoutTestController::setUserStyleSheetLocation):
1957         (LayoutTestController::setUserStyleSheetEnabled):
1958         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1959
1960 2010-01-14  Adam Roben  <aroben@apple.com>
1961
1962         Add LayoutTestController API to force
1963         -webView:resource:willSendRequest:: to return null
1964
1965         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
1966         window.onload never fires if page contains an <iframe> with a bad
1967         scheme or whose load is cancelled by returning null from resource load
1968         delegate's willSendRequest
1969
1970         Reviewed by Brady Eidson.
1971
1972         * DumpRenderTree/LayoutTestController.cpp:
1973         (LayoutTestController::LayoutTestController): Initialize new member.
1974         (setWillSendRequestReturnsNullCallback): Call through to
1975         LayoutTestController.
1976         (LayoutTestController::staticFunctions): Added new function.
1977
1978         * DumpRenderTree/LayoutTestController.h: Added
1979         m_willSendRequestReturnsNull.
1980         (LayoutTestController::willSendRequestReturnsNull):
1981         (LayoutTestController::setWillSendRequestReturnsNull):
1982         Added standard accessors.
1983
1984         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1985         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1986         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1987         (ResourceLoadDelegate::willSendRequest):
1988         Return null if LayoutTestController says to.
1989
1990 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
1991
1992         [wx] Build fix after removal of XBM support.
1993
1994         * wx/build/settings.py:
1995
1996 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1997
1998         Reviewed by Simon Hausmann.
1999
2000         Add support for partial building on Symbian.
2001
2002         The build happens in the source directory as out of source builds are
2003         not supported by qmake for Symbian.
2004
2005         Also the actual build isn't started but it is left to the developer
2006         to choose the architecture/configuration.
2007
2008         * Scripts/webkitdirs.pm:
2009
2010 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
2011
2012         Reviewed by Kenneth Rohde Christiansen.
2013
2014         Add support for "detecting" Symbian environments by either
2015         looking for the EPOCROOT environment variable or via --symbian
2016         being passed on the commandline.
2017
2018         * Scripts/webkitdirs.pm:
2019
2020 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2021
2022         Unreviewed.
2023
2024         [Qt] Use a different Makefile names for sources generation and compilation.
2025         This prevents Makefile overwriting when running build-webkit twice.
2026
2027         * Scripts/webkitdirs.pm:
2028
2029 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
2030
2031         Reviewed by Kenneth Rohde Christiansen.
2032
2033         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=33373
2036
2037         * QtLauncher/main.cpp:
2038         (WebPage::createPlugin):
2039
2040 2010-01-14  Eric Seidel  <eric@webkit.org>
2041
2042         No review, rolling out r53249.
2043         http://trac.webkit.org/changeset/53249
2044         https://bugs.webkit.org/show_bug.cgi?id=33617
2045
2046         This caused http/tests/security/local-user-CSS-from-
2047         remote.html to fail on the Qt Release Build Bot.
2048
2049         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2050         (WebCore::WebPage::resetSettings):
2051         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2052         (LayoutTestController::overridePreference):
2053         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2054
2055 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
2056
2057         Reviewed by Shinichiro Hamaji.
2058
2059         Moved error() from cpp_style.py to checker.py.
2060
2061         https://bugs.webkit.org/show_bug.cgi?id=33620
2062
2063         * Scripts/check-webkit-style:
2064           - Addressed FIXME to not set global state.
2065
2066         * Scripts/webkitpy/style/checker.py:
2067           - Added argument validation to ProcessorOptions constructor.
2068           - Added should_report_error() to ProcessorOptions class.
2069           - Removed set_options().
2070           - Added StyleChecker class.
2071
2072         * Scripts/webkitpy/style/checker_unittest.py:
2073           - Added unit test class for ProcessorOptions class.
2074           - Added unit test to check that parse() strips white space.
2075
2076         * Scripts/webkitpy/style/cpp_style.py:
2077           - Removed "filter" and "output_format" methods.
2078           - Removed should_print_error() and error() functions.
2079           - Removed default parameter value from process_file().
2080
2081         * Scripts/webkitpy/style/cpp_style_unittest.py:
2082           - Removed call to cpp_style._should_print_error().
2083           - Removed test_filter() and test_filter_appending().
2084
2085         * Scripts/webkitpy/style/text_style.py:
2086           - Removed default parameter value from process_file().
2087
2088 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2089
2090         Reviewed by Kenneth Rohde Christiansen.
2091
2092         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2093         https://bugs.webkit.org/show_bug.cgi?id=33617
2094
2095         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2096         (WebCore::WebPage::resetSettings):
2097         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2098         (LayoutTestController::setUserStyleSheetLocation):
2099         (LayoutTestController::setUserStyleSheetEnabled):
2100         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2101
2102 2010-01-13  Adam Barth  <abarth@webkit.org>
2103
2104         Reviewed by Eric Seidel.
2105
2106         Fix CloseBugForLandDiff unittest to actually run
2107         https://bugs.webkit.org/show_bug.cgi?id=33640
2108
2109         * Scripts/webkitpy/mock_bugzillatool.py:
2110         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
2111
2112 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
2113
2114         MSAA: selected, selectable, extended selectable, and multiple
2115         selectable states are not reported
2116
2117         https://bugs.webkit.org/show_bug.cgi?id=33574
2118         <rdar://problem/7536826>
2119
2120         Reviewed by Darin Adler.
2121
2122         * DumpRenderTree/AccessibilityUIElement.cpp:
2123         (getIsSelectableCallback):
2124         Return the result of calling isSelectable().
2125         (getIsMultiSelectableCallback):
2126         Return the result of calling isMultiSelectable().
2127         (AccessibilityUIElement::getJSClass):
2128         Add isSelected and isMultiSelectable properties to the JSClass
2129         definition.
2130
2131         * DumpRenderTree/AccessibilityUIElement.h:
2132         Declare isSelectable() and isMultiSelectable().
2133
2134         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2135         (AccessibilityUIElement::isSelectable):
2136         Stubbed.
2137         (AccessibilityUIElement::isMultiSelectable):
2138         Stubbed.
2139
2140         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2141         (AccessibilityUIElement::isSelectable):
2142         Stubbed.
2143         (AccessibilityUIElement::isMultiSelectable):
2144         Stubbed.
2145
2146         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2147         (accessibilityState):
2148         Get the object's state, and return it.
2149         (AccessibilityUIElement::isSelected):
2150         Check the object's selected state.
2151         (AccessibilityUIElement::isSelectable):
2152         Check the object's selectable state.
2153         (AccessibilityUIElement::isMultiSelectable):
2154         Check the object's extended/multiple selectable state.
2155
2156 2010-01-13  Adam Barth  <abarth@webkit.org>
2157
2158         Unreviewed.  Repeat the below for CloseBugForLandDiff.
2159
2160         * Scripts/test-webkitpy:
2161         * Scripts/webkitpy/steps/closebugforlanddiff.py:
2162         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
2163
2164 2010-01-13  Adam Barth  <abarth@webkit.org>
2165
2166         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
2167         is running again.
2168
2169         * QueueStatusServer/templates/statusbubble.html:
2170
2171 2010-01-13  Adam Barth  <abarth@webkit.org>
2172
2173         Reviewed by Darin Adler.
2174
2175         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
2176         https://bugs.webkit.org/show_bug.cgi?id=33634
2177
2178         Deal with the case of no bug patch object in the state.
2179
2180         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
2181         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
2182
2183 2010-01-13  Kenneth Russell  <kbr@google.com>
2184
2185         Unreviewed; added myself to the committers list.
2186
2187         * Scripts/webkitpy/committers.py:
2188
2189 2010-01-13  Darin Adler  <darin@apple.com>
2190
2191         Ignore compiled Python in more of webkitpy.
2192
2193         * Scripts/webkitpy/commands: Added property svn:ignore.
2194         * Scripts/webkitpy/steps: Added property svn:ignore.
2195         * Scripts/webkitpy/style: Added property svn:ignore.
2196
2197 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2198
2199         Reviewed by Simon Hausmann.
2200
2201         [Qt] Fix build problem related to the pushd command
2202
2203         * Scripts/webkitdirs.pm:
2204
2205 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2206
2207         Reviewed by Simon Hausmann.
2208
2209         [Qt] Split the build process in two different .pro files.
2210         This allows qmake to be run once all source files are available.
2211
2212         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
2213
2214 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
2215
2216         Unreviewed tiny typo fix in docstrings.
2217
2218         * Scripts/webkitpy/style/checker_unittest.py:
2219
2220 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
2221
2222         Reviewed by Shinichiro Hamaji.
2223
2224         Created a CategoryFilter class to encapsulate the logic of
2225         filter rules.
2226
2227         https://bugs.webkit.org/show_bug.cgi?id=33454
2228
2229         * Scripts/webkitpy/style/checker.py:
2230           - Added CategoryFilter class.
2231
2232         * Scripts/webkitpy/style/checker_unittest.py:
2233           - Added CategoryFilter unit tests.
2234
2235         * Scripts/webkitpy/style/cpp_style.py:
2236           - Updated filter methods to use CategoryFilter.
2237
2238         * Scripts/webkitpy/style/cpp_style_unittest.py:
2239           - Updated references to filters.
2240
2241 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
2242
2243         Unreviewed. Now I can review :)
2244
2245         * Scripts/webkitpy/committers.py:
2246
2247 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
2248
2249         Reviewed by Darin Adler.
2250
2251         Extend WinLauncher example with better printing features.
2252
2253         * WinLauncher/PrintWebUIDelegate.cpp:
2254         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
2255          larger margins.
2256         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
2257          on text metrics.
2258         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
2259          on text metrics.
2260         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
2261          with separating line.
2262         (PrintWebUIDelegate::drawFooterInRect):
2263         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
2264         * WinLauncher/WinLauncher.cpp:
2265         (PrintView): Correct loop used to print individual pages.
2266          Previously it started at 0, which is a wild-card to print all
2267          pages at once.
2268
2269 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
2270
2271         Reviewed by Darin Adler.
2272
2273         https://bugs.webkit.org/show_bug.cgi?id=33540
2274         Make it possible to build in debug mode with assertions disabled
2275
2276         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
2277
2278 2010-01-11  Darin Fisher  <darin@chromium.org>
2279
2280         Reviewed by Dimitri Glazkov.
2281
2282         [Chromium] "build-webkit --chromium" should run "make all" on Linux
2283         https://bugs.webkit.org/show_bug.cgi?id=33500
2284
2285         * Scripts/webkitdirs.pm:
2286
2287 2010-01-12  Eric Seidel  <eric@webkit.org>
2288
2289         Reviewed by Adam Barth.
2290
2291         AssignToCommitter does not need to fetch bugs twice
2292         https://bugs.webkit.org/show_bug.cgi?id=33530
2293
2294         This is a no-brainer patch now that we've added Bug.reviewed_patches
2295
2296         * Scripts/webkitpy/commands/upload.py:
2297
2298 2010-01-12  Eric Seidel  <eric@webkit.org>
2299
2300         Reviewed by Adam Barth.
2301
2302         bugzilla.py should have an Attachment object instead of passing around dictionaries
2303         https://bugs.webkit.org/show_bug.cgi?id=31594
2304
2305         * Scripts/webkitpy/bugzilla.py:
2306          - Add a new Attachment class, with accessor methods for all the necessary properties.
2307          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
2308          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
2309          - Move committer validation logic into its own class.
2310          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
2311            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
2312            the case where we want to reject patches in bugzilla.
2313          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
2314          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
2315          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
2316          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
2317         * Scripts/webkitpy/bugzilla_unittest.py:
2318          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
2319         * Scripts/webkitpy/commands/download.py:
2320          - Store "bug_id" in state instead of making a fake patch object.
2321          - Update to use Attachment and Bug objects.
2322         * Scripts/webkitpy/commands/download_unittest.py:
2323          - Update expected results now that our testing framework covers more code.
2324         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
2325         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
2326         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
2327         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
2328         * Scripts/webkitpy/commands/queuestest.py: ditto.
2329         * Scripts/webkitpy/commands/upload.py: ditto.
2330         * Scripts/webkitpy/mock_bugzillatool.py:
2331          - Now that more logic has moved into Attachment and Bug, we have to actually
2332            provide real reviewer emails as well as real reviewer flags.
2333          - Update mock methods to return Attachment objects.
2334         * Scripts/webkitpy/scm.py: Update to use Attachment class.
2335         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
2336         * Scripts/webkitpy/statusserver.py: ditto.
2337         * Scripts/webkitpy/steps/applypatch.py: ditto.
2338         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
2339         * Scripts/webkitpy/steps/closebug.py: ditto.
2340         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
2341         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
2342         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
2343         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
2344
2345 2010-01-12  Adam Barth  <abarth@webkit.org>
2346
2347         Unreviewed typo fix.  :(
2348
2349         * Scripts/webkitpy/commands/early_warning_system.py:
2350         * Scripts/webkitpy/commands/queues.py:
2351
2352 2010-01-12  Adam Barth  <abarth@webkit.org>
2353
2354         Unreviewed.  Add "error" to the right part of the message.
2355
2356         * Scripts/webkitpy/commands/queues.py:
2357
2358 2010-01-12  Adam Barth  <abarth@webkit.org>
2359
2360         Reviewed by Eric Seidel.
2361
2362         EWS should show purple when svn-apply fails
2363         https://bugs.webkit.org/show_bug.cgi?id=33527
2364
2365         * Scripts/webkitpy/commands/early_warning_system.py:
2366         * Scripts/webkitpy/commands/queues.py:
2367
2368 2010-01-12  Adam Barth  <abarth@webkit.org>
2369
2370         Reviewed by Eric Seidel.
2371
2372         Remove copy/paste code from subclasses of AbstractReviewQueue
2373         https://bugs.webkit.org/show_bug.cgi?id=33525
2374
2375         * Scripts/webkitpy/commands/early_warning_system.py:
2376         * Scripts/webkitpy/commands/queues.py:
2377
2378 2010-01-12  Adam Barth  <abarth@webkit.org>
2379
2380         Reviewed by Eric Seidel.
2381
2382         Add Gustavo and Xan as gtk-ews watchers
2383         https://bugs.webkit.org/show_bug.cgi?id=33519
2384
2385         * Scripts/webkitpy/commands/early_warning_system.py:
2386
2387 2010-01-12  Adam Barth  <abarth@webkit.org>
2388
2389         Reviewed by Eric Seidel.
2390
2391         webkit-patch shouldn't waste my time for with a component prompt
2392         https://bugs.webkit.org/show_bug.cgi?id=33521
2393
2394         The component field isn't very useful for bugs created with
2395         webkit-patch because they're likely to be resolved quickly.  Instead of
2396         always prompting for a component, we should just default to the "New
2397         Bugs" component.  If the bug stays around for more than five minutes,
2398         we can assign it a proper component.
2399
2400         * Scripts/webkitpy/bugzilla.py:
2401
2402 2010-01-12  Adam Barth  <abarth@webkit.org>
2403
2404         Reviewed by Eric Seidel.
2405
2406         Add experimental "land-safely" command to webkit-patch
2407         https://bugs.webkit.org/show_bug.cgi?id=33518
2408
2409         * Scripts/webkitpy/commands/upload.py:
2410         * Scripts/webkitpy/commands/upload_unittest.py:
2411         * Scripts/webkitpy/steps/__init__.py:
2412         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
2413
2414 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
2415
2416         [wx] Build fix after introduction of JS_NO_EXPORT
2417         
2418         * wx/build/settings.py:
2419
2420 2010-01-11  Eric Seidel  <eric@webkit.org>
2421
2422         No review, rolling out r53079.
2423         http://trac.webkit.org/changeset/53079
2424         https://bugs.webkit.org/show_bug.cgi?id=33197
2425
2426         Adam doens't think this actually works, and believe it caused
2427         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
2428         rolling this out.
2429
2430         * Scripts/test-webkitpy:
2431         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
2432         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
2433         * Scripts/webkitpy/commands/download.py:
2434         * Scripts/webkitpy/commands/upload.py:
2435         * Scripts/webkitpy/mock_bugzillatool.py:
2436
2437 2010-01-10  Adam Barth  <abarth@webkit.org>
2438
2439         Reviewed by David Kilzer.
2440
2441         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2442         https://bugs.webkit.org/show_bug.cgi?id=33197
2443
2444         We should just search for bug numbers in the ChangeLogs instead of in
2445         the whole diff.
2446  
2447         * Scripts/test-webkitpy:
2448         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
2449         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
2450         * Scripts/webkitpy/commands/download.py:
2451         * Scripts/webkitpy/commands/upload.py:
2452         * Scripts/webkitpy/mock_bugzillatool.py:
2453
2454 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
2455
2456         Reviewed by David Kilzer.
2457
2458         Created a unit-tested function to parse the header block of
2459         a Git or SVN diff -- for future refactoring of svn-apply and
2460         svn-unapply.
2461
2462         https://bugs.webkit.org/show_bug.cgi?id=33447
2463
2464         * Scripts/VCSUtils.pm:
2465           - Added parseDiffHeader().
2466           - Removed irrelevant comment from gitdiff2svndiff().
2467
2468         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
2469           - Added 48 unit tests for parseDiffHeader().
2470
2471 2010-01-10  Adam Barth  <abarth@webkit.org>
2472
2473         Rubber stamped by David Kilzer.
2474
2475         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
2476         https://bugs.webkit.org/show_bug.cgi?id=33197
2477
2478         Fix a typo: Commmand -> Command.
2479
2480         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
2481         * Scripts/webkitpy/commands/download.py:
2482         * Scripts/webkitpy/commands/queries.py:
2483         * Scripts/webkitpy/commands/upload.py:
2484         * Scripts/webkitpy/multicommandtool.py:
2485
2486 2010-01-10  Adam Barth  <abarth@webkit.org>
2487
2488         Reviewed by Darin Adler.
2489
2490         Let webkit-patch work with options in $EDITOR
2491         https://bugs.webkit.org/show_bug.cgi?id=33414
2492
2493         The $EDITOR evironment variable might have command line options like
2494         bbedit -w.  This patch lets us run those $EDITORs.
2495
2496         * Scripts/webkitpy/user.py:
2497
2498 2010-01-10  Robert Hogan  <robert@roberthogan.net>
2499
2500         Reviewed by Adam Barth.
2501
2502         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
2503
2504         https://bugs.webkit.org/show_bug.cgi?id=33419
2505
2506         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2507         (WebCore::WebPage::WebPage):
2508         (WebCore::WebPage::resetSettings):
2509         (WebCore::DumpRenderTree::createWindow):
2510         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2511         (LayoutTestController::setXSSAuditorEnabled):
2512         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2513
2514 2010-01-10  Adam Barth  <abarth@webkit.org>
2515
2516         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
2517         because we don't have hardware for it at the moment.
2518
2519         * QueueStatusServer/templates/statusbubble.html:
2520
2521 2010-01-09  Daniel Bates  <dbates@webkit.org>
2522
2523         No review, rolling out r53044.
2524         http://trac.webkit.org/changeset/53044
2525         https://bugs.webkit.org/show_bug.cgi?id=33419
2526         
2527         We need to look into this some more because the Qt
2528         bot is failing the XSSAuditor tests. See bug #33419
2529         for more details.
2530
2531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2532         (WebCore::WebPage::WebPage):
2533         (WebCore::WebPage::resetSettings):
2534         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2535         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2536
2537 2010-01-09  Daniel Bates  <dbates@webkit.org>
2538
2539         Reviewed by Adam Barth.
2540
2541         https://bugs.webkit.org/show_bug.cgi?id=33419
2542
2543         Adds support for the XSSAuditor to the Qt DRT.
2544
2545         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2546         (WebCore::WebPage::WebPage):
2547         (WebCore::WebPage::resetSettings):
2548         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2549         (LayoutTestController::setXSSAuditorEnabled):
2550         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2551
2552 2010-01-09  Adam Barth  <abarth@webkit.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         Retry writes to QueueStatusServer when we get 500 errors
2557         https://bugs.webkit.org/show_bug.cgi?id=33412
2558
2559         This prevents the queues from failing to mark a patch as "pass" or
2560         "fail" when AppEngine throws 500 errors.
2561
2562         * Scripts/test-webkitpy:
2563         * Scripts/webkitpy/networktransaction.py: Added.
2564         * Scripts/webkitpy/networktransaction_unittest.py: Added.
2565         * Scripts/webkitpy/statusserver.py:
2566         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
2567         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
2568         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
2569
2570 2010-01-09  David Kilzer  <ddkilzer@apple.com>
2571
2572         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
2573
2574         Reviewed by Eric Seidel.
2575
2576         * QueueStatusServer/templates/statusbubble.html: Added
2577         -moz-border-radius and -webkit-border-radius to provide rounded
2578         borders in older Firefox and Safari browsers.
2579
2580 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
2581
2582         Reviewed by David Kilzer.
2583
2584         Modified VCSUtils::gitdiff2svndiff() to accept strings that
2585         end in vertical white space.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=33415
2588
2589         * Scripts/VCSUtils.pm:
2590         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
2591
2592 2010-01-08  Eric Seidel  <eric@webkit.org>
2593
2594         Reviewed by Adam Barth.
2595
2596         run-javascriptcore-tests needs a --quiet flag
2597         https://bugs.webkit.org/show_bug.cgi?id=33399
2598
2599         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
2600
2601         * Scripts/webkitpy/steps/runtests.py:
2602
2603 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
2604
2605         Reviewed by Alexey Proskuryakov.
2606
2607         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
2608
2609         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
2610         the time when Apache and WebSocketServer is locked by tests.
2611         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
2612         we need to run http and websocket tests after all other tests.
2613         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
2614         we need to preserve the given order.
2615
2616         * Scripts/run-webkit-tests:
2617
2618 2010-01-08  Adam Barth  <abarth@webkit.org>
2619
2620         Reviewed by Eric Seidel.
2621
2622         Don't post style-queue pass messages to bugs
2623         https://bugs.webkit.org/show_bug.cgi?id=33404
2624
2625         These messages aren't needed any more now that we have the status
2626         bubble reporting pass events passively.
2627
2628         * Scripts/webkitpy/commands/queues.py:
2629
2630 2010-01-08  Adam Barth  <abarth@webkit.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         Optimize the number of CPUs used for building Qt and Gtk
2635         https://bugs.webkit.org/show_bug.cgi?id=33394
2636
2637         Instead of hardcoding the number 8, we should read the number of CPUs
2638         from the environment.
2639
2640         * Scripts/webkitpy/executive.py:
2641         * Scripts/webkitpy/webkitport.py:
2642         * Scripts/webkitpy/webkitport_unittest.py:
2643
2644 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
2645
2646         Reviewed by Eric Seidel.
2647
2648         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
2649         https://bugs.webkit.org/show_bug.cgi?id=33300
2650
2651         * DumpRenderTree/AccessibilityUIElement.h:
2652         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2653         (AccessibilityUIElement::AccessibilityUIElement):
2654         (AccessibilityUIElement::~AccessibilityUIElement):
2655         (_accessibilityNotificationCallback):
2656         (AccessibilityUIElement::addNotificationListener):
2657
2658 2010-01-08  Eric Seidel  <eric@webkit.org>
2659
2660         Reviewed by Simon Hausmann.
2661
2662         commit-queue should run run-javascriptcore-tests
2663         https://bugs.webkit.org/show_bug.cgi?id=33376
2664
2665         I also made it run the python and perl unit tests.
2666
2667         * Scripts/webkitpy/steps/runtests.py:
2668         * Scripts/webkitpy/webkitport.py:
2669
2670 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
2671
2672         Reviewed by Darin Adler.
2673
2674         Run the http and websocket tests after all other tests.
2675         https://bugs.webkit.org/show_bug.cgi?id=33153
2676
2677         * Scripts/run-webkit-tests:
2678
2679 2010-01-07  Adam Barth  <abarth@webkit.org>
2680
2681         Reviewed by Eric Seidel.
2682
2683         Fix some test-webkitpy expectations
2684         https://bugs.webkit.org/show_bug.cgi?id=33345
2685
2686         I forgot to change these when I added the CheckStyle step.
2687
2688         * Scripts/webkitpy/commands/upload_unittest.py:
2689
2690 2010-01-07  Adam Barth  <abarth@webkit.org>
2691
2692         Reviewed by Eric Seidel.
2693
2694         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
2695         https://bugs.webkit.org/show_bug.cgi?id=33341
2696
2697         Fix this by moving to the root directory before editing ChangeLogs.
2698         There is a related bug with CheckStyle.
2699
2700         * Scripts/webkitpy/steps/checkstyle.py:
2701         * Scripts/webkitpy/steps/editchangelog.py:
2702
2703 2010-01-07  Eric Seidel  <eric@webkit.org>
2704
2705         Reviewed by Nikolas Zimmermann.
2706
2707         media/unsupported-tracks.html is failing on Snow Leopard Release bot
2708         https://bugs.webkit.org/show_bug.cgi?id=32339
2709
2710         This is a speculative fix.  I do not have a Snow Leopard machine to test on
2711         and I've not seen mention of someone being able to reproduce this locally.
2712
2713         Prevent watchdog timer from firing after a test completes but before
2714         the next one starts, causing the error to appear in the next test.
2715
2716         * DumpRenderTree/mac/DumpRenderTree.mm:
2717         (dump): Stop the watchdog before printing #EOF for the test content.
2718         We only need to care about the JavaScript of the test running too long
2719         or some hang in WebCore.  Any other failures will be covered by the calling
2720         script's own watchdog timer.
2721
2722 2010-01-07  Eric Seidel  <eric@webkit.org>
2723
2724         Reviewed by Adam Barth.
2725
2726         commit-queue is stuck spinning due to exception
2727         https://bugs.webkit.org/show_bug.cgi?id=33358
2728
2729         * Scripts/webkitpy/commands/queues.py:
2730          - Don't try to stringify the exception.
2731
2732 2010-01-07  Mark Rowe  <mrowe@apple.com>
2733
2734         Reviewed by Jon Honeycutt.
2735
2736         Don't leak a JSStringRef within _accessibilityNotificationCallback.
2737
2738         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2739         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
2740         when it goes out of scope.
2741
2742 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
2743
2744         Reviewed by Darin Adler.
2745
2746         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
2747
2748         * Scripts/do-webcore-rename:
2749
2750 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
2751
2752         Reviewed by Antti Koivisto.
2753
2754         Wrong state and TouchLists in TouchEvents
2755         https://bugs.webkit.org/show_bug.cgi?id=32878
2756
2757         * DumpRenderTree/qt/EventSenderQt.cpp:
2758         (EventSender::touchStart):
2759         (EventSender::touchEnd):
2760         (EventSender::clearTouchPoints):
2761         * DumpRenderTree/qt/EventSenderQt.h:
2762
2763 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2764
2765         Reviewed by Adam Barth.
2766
2767         Created a module that runs the style package unit tests.
2768
2769         https://bugs.webkit.org/show_bug.cgi?id=32973
2770
2771         * Scripts/test-webkitpy:
2772         * Scripts/webkitpy/style/unittests.py: Added.
2773
2774 2010-01-07  Adam Barth  <abarth@webkit.org>
2775
2776         Reviewed by Maciej Stachowiak.
2777
2778         Don't print a redundant message when confirming a diff
2779         https://bugs.webkit.org/show_bug.cgi?id=33315
2780
2781         Instead of saying "ERROR: User declined" we should just exit because
2782         the use knows they just declined!
2783
2784         * Scripts/webkitpy/steps/confirmdiff.py:
2785
2786 2010-01-07  Adam Barth  <abarth@webkit.org>
2787
2788         Reviewed by Maciej Stachowiak.
2789
2790         Check style before uploading a patch
2791         https://bugs.webkit.org/show_bug.cgi?id=33314
2792
2793         * Scripts/webkitpy/commands/upload.py:
2794         * Scripts/webkitpy/steps/checkstyle.py:
2795         * Scripts/webkitpy/steps/options.py:
2796
2797 2010-01-07  Adam Barth  <abarth@webkit.org>
2798
2799         Reviewed by Maciej Stachowiak.
2800
2801         Add prepare and post to webkit-patch main help
2802         https://bugs.webkit.org/show_bug.cgi?id=33313
2803
2804         * Scripts/webkitpy/commands/upload.py:
2805
2806 2010-01-07  Eric Seidel  <eric@webkit.org>
2807
2808         Reviewed by Adam Barth.
2809
2810         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
2811         https://bugs.webkit.org/show_bug.cgi?id=33290
2812
2813         Add the Chromium builders to our list of core builders and test that our regexps work.
2814         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
2815
2816         * Scripts/webkitpy/buildbot.py:
2817         * Scripts/webkitpy/buildbot_unittest.py:
2818
2819 2010-01-07  Adam Barth  <abarth@webkit.org>
2820
2821         Reviewed by Eric Seidel.
2822
2823         bugzilla-tool needs a new name
2824         https://bugs.webkit.org/show_bug.cgi?id=28459
2825
2826         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
2827         make more sense with the new name.
2828
2829         * Scripts/bugzilla-tool: Removed.
2830         * Scripts/webkit-patch: Added.
2831         * Scripts/webkit-tools-completion.sh:
2832         * Scripts/webkitpy/bugzilla_unittest.py:
2833         * Scripts/webkitpy/commands/download.py:
2834         * Scripts/webkitpy/commands/download_unittest.py:
2835         * Scripts/webkitpy/commands/early_warning_system.py:
2836         * Scripts/webkitpy/commands/queries.py:
2837         * Scripts/webkitpy/commands/queues.py:
2838         * Scripts/webkitpy/commands/queues_unittest.py:
2839         * Scripts/webkitpy/commands/upload.py:
2840         * Scripts/webkitpy/commands/upload_unittest.py:
2841         * Scripts/webkitpy/queueengine.py:
2842         * Scripts/webkitpy/steps/completerollout.py:
2843
2844 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
2845
2846         Reviewed by Eric Seidel.
2847
2848         Moved style-related modules to webkitpy.style sub-package.
2849
2850         https://bugs.webkit.org/show_bug.cgi?id=32971
2851
2852         * Scripts/check-webkit-style:
2853           - Updated import statement.
2854
2855         * Scripts/test-webkitpy:
2856           - Updated import statements.
2857
2858         * Scripts/webkitpy/cpp_style.py: Removed.
2859           - Moved to webkitpy/style.
2860
2861         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
2862           - Moved to webkitpy/style.
2863
2864         * Scripts/webkitpy/style.py: Removed.
2865           - Moved to webkitpy/style/checker.py.
2866
2867         * Scripts/webkitpy/style/__init__.py: Added.
2868           - Added containing webkitpy directory to package search path.
2869
2870         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
2871         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
2872           - Updated import statement.
2873
2874         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
2875         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
2876           - Update import statement.
2877
2878         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
2879         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
2880         * Scripts/webkitpy/style_unittest.py: Removed.
2881           - Moved to webkitpy/style/checker_unittest.py.
2882
2883         * Scripts/webkitpy/text_style.py: Removed.
2884           - Moved to webkitpy/style.
2885
2886         * Scripts/webkitpy/text_style_unittest.py: Removed.
2887           - Moved to webkitpy/style.
2888
2889 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
2890
2891         Reviewed by Eric Seidel.
2892
2893         [Qt] Support the 3rd argument of EventSender.keyDown that
2894         has been recently added to report keyLocation
2895         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
2896         https://bugs.webkit.org/show_bug.cgi?id=33250
2897
2898         Test: fast/events/keydown-numpad-keys.html
2899
2900         * DumpRenderTree/qt/EventSenderQt.cpp:
2901         (EventSender::keyDown):
2902         * DumpRenderTree/qt/EventSenderQt.h:
2903
2904 2010-01-06  Eric Seidel  <eric@webkit.org>
2905
2906         Reviewed by Adam Barth.
2907
2908         Add long_help for all common commands.
2909         https://bugs.webkit.org/show_bug.cgi?id=33261
2910
2911         For now these long_helps are pretty basic.
2912         These were all written to just explain the steps
2913         that each command runs.  This style long_help could
2914         be made easier by using:
2915         https://bugs.webkit.org/show_bug.cgi?id=33257
2916
2917         * Scripts/webkitpy/commands/download.py:
2918         * Scripts/webkitpy/commands/queries.py:
2919
2920 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2921
2922         Reviewed by Kenneth Christiansen.
2923
2924         [Qt] Add page zooming support to Qt DumpRenderTree
2925         https://bugs.webkit.org/show_bug.cgi?id=32898
2926
2927         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
2928                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
2929                  Afonso Costa <afonso.costa@openbossa.org>
2930
2931         * DumpRenderTree/qt/EventSenderQt.cpp:
2932         (EventSender::zoomPageIn):
2933         (EventSender::zoomPageOut):
2934         * DumpRenderTree/qt/EventSenderQt.h:
2935
2936 2010-01-06  Eric Seidel  <eric@webkit.org>
2937
2938         No review, just adding Mike Belshe's new bugzilla email at his request.
2939
2940         * Scripts/webkitpy/committers.py:
2941
2942 2010-01-06  Eric Seidel  <eric@webkit.org>
2943
2944         Unreviewed.  Rolling out r52869 and r52853 due to bot
2945         and local run-webkit-test failures
2946
2947         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
2948         https://bugs.webkit.org/show_bug.cgi?id=33256
2949
2950         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
2951
2952         * Scripts/run-webkit-tests:
2953
2954 2010-01-06  Eric Seidel  <eric@webkit.org>
2955
2956         Unreviewed "build" fix.  Just adding missing include.
2957
2958         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2959         https://bugs.webkit.org/show_bug.cgi?id=29212
2960
2961         * Scripts/webkitpy/steps/completerollout.py:
2962
2963 2010-01-06  Eric Seidel  <eric@webkit.org>
2964
2965         Reviewed by Adam Barth.
2966
2967         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
2968         https://bugs.webkit.org/show_bug.cgi?id=29212
2969
2970         * Scripts/webkitpy/bugzilla.py:
2971          - Make reopen_bug robust against the bug already being open.
2972         * Scripts/webkitpy/commands/download.py:
2973          - Remove dead code from Rollout.
2974         * Scripts/webkitpy/steps/completerollout.py:
2975          - Improve the rollout comment.
2976
2977 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2978
2979         Reviewed by Darin Adler.
2980
2981         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
2982         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
2983
2984         * Scripts/run-webkit-tests:
2985
2986 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
2987
2988         Reviewed by Darin Adler.
2989
2990         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
2991         and remove the httpd's pidfile directory if httpd terminated.
2992
2993         * Scripts/run-webkit-tests:
2994
2995 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
2996
2997         Reviewed by David Levin.
2998
2999         Refactored check-webkit-style's argument parser to not rely
3000         on global state, and improved its error handling and unit
3001         test coverage.
3002
3003         https://bugs.webkit.org/show_bug.cgi?id=32966
3004
3005         * Scripts/check-webkit-style:
3006           - Adjusted to use new argument parser.
3007
3008         * Scripts/webkitpy/cpp_style.py:
3009           - Changed _CppStyleState to accept an array of filter rules
3010             instead of a comma-delimited string.
3011           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
3012           - Eliminated cpp_style._USAGE.
3013
3014         * Scripts/webkitpy/cpp_style_unittest.py:
3015           - Updated test_filter() and test_default_filter().
3016
3017         * Scripts/webkitpy/style.py:
3018           - Converted style._USAGE to create_usage().
3019           - Corrected usage instructions by removing 0 as a valid
3020             --verbose flag value.
3021           - Removed use_webkit_styles().
3022           - Added ProcessorOptions class.
3023           - Added ArgumentDefaults class.
3024           - Added ArgumentPrinter class.
3025           - Removed parse_arguments and added ArgumentParser class.
3026           - Moved exit_with_usage() and exit_with_categories() into
3027             ArgumentParser.
3028           - Refactored parse_arguments() as ArgumentParser.parse().
3029           - Improved parser error handling.
3030
3031         * Scripts/webkitpy/style_unittest.py:
3032           - Added DefaultArgumentsTest class.
3033           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
3034             against style.STYLE_CATEGORIES.
3035           - Added ArgumentPrinterTest class.
3036           - Added ArgumentParserTest class and rewrote parser unit tests.
3037
3038 2010-01-05  Adam Roben  <aroben@apple.com>
3039
3040         Test that it's safe to call IWebView::close when
3041         IWebView::initWithFrame hasn't been called
3042
3043         Part of <http://webkit.org/b/32827> Crash when calling
3044         IWebView::close, then releasing the WebView, without calling
3045         DestroyWindow
3046
3047         Reviewed by Steve Falkenburg.
3048
3049         * WebKitAPITest/tests/WebViewDestruction.cpp:
3050         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
3051         without ever calling IWebView::initWithFrame and tests that we don't
3052         crash or leak.
3053
3054 2010-01-05  Adam Roben  <aroben@apple.com>
3055
3056         Add more WebViewDestruction tests
3057
3058         Fixes <http://webkit.org/b/33216>.
3059
3060         Reviewed by Eric Seidel.
3061
3062         * WebKitAPITest/tests/WebViewDestruction.cpp:
3063         (WebKitAPITest::NoInitWithFrame):
3064         (WebKitAPITest::CloseThenDestroyViewWindow):
3065         (WebKitAPITest::DestroyViewWindowThenClose):
3066         (WebKitAPITest::DestroyHostWindow):
3067         (WebKitAPITest::DestroyHostWindowThenClose):
3068         (WebKitAPITest::CloseThenDestroyHostWindow):
3069         Added these tests that exercise tearing down a WebView in various
3070         ways, all of which we eventually want to have work. Some of them
3071         currently crash or leak.
3072
3073 2010-01-05  Robert Hogan  <robert@roberthogan.net>
3074
3075         Reviewed by Eric Seidel.
3076
3077         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
3078         
3079         If you're working from a --minimal or --no-svg build and make changes to the
3080         DRT, then recompile, the build will fail.
3081         
3082         This is because the current behavior at build time is to assume that the
3083         previous Qt build supported SVG and consequently delete libQtWebKit.so.
3084         Unfortunately, just deleting libQtWebKit.so will not cause the library to
3085         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
3086         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
3087         results in a link failure on the DRT.
3088         
3089         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
3090         in cases where not actually required, remove the assumption that
3091         the previous Qt build supported SVG, and amend the symbol detection to look for
3092         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
3093         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
3094         
3095         https://bugs.webkit.org/show_bug.cgi?id=32992
3096
3097         * Scripts/webkitdirs.pm:
3098
3099 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3100
3101         Reviewed by David Kilzer.
3102
3103         Switched to generating list of Perl unit test files dynamically,
3104         instead of explicitly.
3105
3106         https://bugs.webkit.org/show_bug.cgi?id=33200
3107
3108         * Scripts/test-webkitperl:
3109
3110 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
3111
3112         Reviewed by Kenneth Rohde Christiansen.
3113
3114         [Qt] Reimplement EventSender::leapForward
3115         https://bugs.webkit.org/show_bug.cgi?id=33114
3116
3117         Follow Windows implementation of leapForward. When leapForward is called, 
3118         messages are queued and posted after the timeout. A new event loop is created to
3119         handle those messages and the additional messages that are created as a result.
3120
3121         * DumpRenderTree/qt/DumpRenderTree.pro:
3122         * DumpRenderTree/qt/EventSenderQt.cpp:
3123         (EventSender::EventSender):
3124         (EventSender::mouseDown):
3125         (EventSender::mouseUp):
3126         (EventSender::mouseMoveTo):
3127         (EventSender::leapForward):
3128         (EventSender::sendOrQueueEvent):
3129         (EventSender::replaySavedEvents):
3130         (EventSender::eventFilter):
3131         * DumpRenderTree/qt/EventSenderQt.h:
3132
3133 2010-01-05  Adam Barth  <abarth@webkit.org>
3134
3135         Reviewed by Darin Adler.
3136
3137         Fix obscure queue crash in queueengine
3138         https://bugs.webkit.org/show_bug.cgi?id=33196
3139
3140         Sometimes we get an exception that can't be stringified.  For example:
3141
3142         AttributeError: 'ParseError' object has no attribute 'msg'
3143
3144         In these cases, the whole queue dies because we're in the global
3145         exception handler.  Instead of dieing here, we should just print a less
3146         informative message to the console.  We're already printing the whole
3147         backtrace anyway, so there's not much point to stringifying the
3148         exception anyway.
3149
3150         * Scripts/webkitpy/queueengine.py:
3151
3152 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
3153
3154         Reviewed by Darin Adler.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=32571
3157
3158         For an object with an aria role of "checkbox" or "radiobutton",
3159         use the "aria-checked" attribute to determine if it's checked.
3160         These changes add an isChecked() method to AccessibilityUIElement
3161         so that we can check for this property from a layout test.
3162
3163         * DumpRenderTree/AccessibilityUIElement.cpp:
3164         (getIsCheckedCallback):
3165         (AccessibilityUIElement::getJSClass):
3166         * DumpRenderTree/AccessibilityUIElement.h:
3167         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3168         (AccessibilityUIElement::isChecked):
3169         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3170         (AccessibilityUIElement::isChecked):
3171         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3172         (AccessibilityUIElement::isChecked):
3173
3174 2010-01-05  David Levin  <levin@chromium.org>
3175
3176         Reviewed by Darin Adler.
3177
3178         Having a comment for the #endif for a header guard is not required WebKit style.
3179         https://bugs.webkit.org/show_bug.cgi?id=33214
3180
3181         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
3182           early when it has all the needed information to continue.
3183         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
3184
3185 2010-01-05  Adam Roben  <aroben@apple.com>
3186
3187         Share more code in the WebViewDestruction tests
3188
3189         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3190         WebKitAPITest
3191
3192         Reviewed by Sam Weinig.
3193
3194         * WebKitAPITest/tests/WebViewDestruction.cpp:
3195         (WebKitAPITest::createAndInitializeWebView): Renamed from
3196         createWebView. Now initializes the HostWindow and returns the
3197         WebView's HWND via an out-parameter.
3198         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
3199         the CloseWithoutDestroyWindow test.
3200         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
3201         CloseWithoutDestroyWindow and changed to use the new functions.
3202         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
3203         functions.
3204         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
3205         NoCloseOrDestroyWindow and changed to use the new functions.
3206
3207 2010-01-05  Adam Roben  <aroben@apple.com>
3208
3209         Don't show HostWindows by default
3210
3211         This was making WebKitAPITest very flashy as windows appeared and
3212         disappeared.
3213
3214         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3215         WebKitAPITest
3216
3217         Reviewed by Sam Weinig.
3218
3219         * WebKitAPITest/HostWindow.cpp:
3220         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
3221         from the window.
3222
3223 2010-01-05  Adam Roben  <aroben@apple.com>
3224
3225         Don't hang in WebKitAPITest if no messages have been posted
3226
3227         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3228         WebKitAPITest
3229
3230         Reviewed by Sam Weinig.
3231
3232         * WebKitAPITest/tests/WebViewDestruction.cpp:
3233         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
3234         to avoid hanging if no messages have been posted.
3235
3236 2010-01-05  Adam Roben  <aroben@apple.com>
3237
3238         Fix WebKitCreateInstance helper
3239
3240         Part of <http://webkit.org/b/33212> Small fixes/improvements to
3241         WebKitAPITest
3242
3243         Reviewed by Sam Weinig.
3244
3245         * WebKitAPITest/tests/WebViewDestruction.cpp:
3246         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
3247         through, instead of taking its address.
3248
3249 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
3250
3251         Reviewed by Darin Fisher.
3252
3253         Reorganize, document and rename OS() platform macros.
3254         https://bugs.webkit.org/show_bug.cgi?id=33198
3255
3256         Adapt to name changes.
3257         
3258         * DumpRenderTree/DumpRenderTree.h:
3259         * DumpRenderTree/config.h:
3260
3261 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3262
3263         Reviewed by Eric Seidel.
3264
3265         Minor improvements to test-webkit-scripts, as suggested
3266         by an earlier review.
3267
3268         https://bugs.webkit.org/show_bug.cgi?id=33125
3269
3270         * Scripts/test-webkit-scripts:
3271           - Used OptionParser class instead of getopt.getopt().
3272           - Created main() method for __main__ block.
3273           - Enclosed functions in a class.
3274
3275 2010-01-05  Chris Fleizach  <cfleizach@apple.com>
3276
3277         No review. Fix DRT breakage on Tiger/Leopard.
3278
3279         Add ARIA "Live Region" support
3280         https://bugs.webkit.org/show_bug.cgi?id=33117
3281
3282         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3283
3284 2010-01-04  Chris Fleizach  <cfleizach@apple.com>
3285
3286         Reviewed by Darin Adler.
3287
3288         Add ARIA "Live Region" support
3289         https://bugs.webkit.org/show_bug.cgi?id=33117
3290
3291         * DumpRenderTree/AccessibilityUIElement.cpp:
3292         (indexOfChildCallback):
3293         (boolAttributeValueCallback):
3294         (stringAttributeValueCallback):
3295         (addNotificationListenerCallback):
3296         (AccessibilityUIElement::getJSClass):
3297         * DumpRenderTree/AccessibilityUIElement.h:
3298         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3299         (AccessibilityUIElement::indexOfChild):
3300         (AccessibilityUIElement::stringAttributeValue):
3301         (AccessibilityUIElement::boolAttributeValue):
3302         (AccessibilityUIElement::addNotificationListener):
3303         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3304         (AccessibilityUIElement::indexOfChild):
3305         (AccessibilityUIElement::stringAttributeValue):
3306         (AccessibilityUIElement::boolAttributeValue):
3307         (_accessibilityNotificationCallback):
3308         (AccessibilityUIElement::addNotificationListener):
3309         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3310         (AccessibilityUIElement::indexOfChild):
3311         (AccessibilityUIElement::stringAttributeValue):
3312         (AccessibilityUIElement::boolAttributeValue):
3313         (AccessibilityUIElement::addNotificationListener):
3314
3315 2010-01-04  Eric Seidel  <eric@webkit.org>
3316
3317         Reviewed by Adam Barth.
3318
3319         bugzilla-tool rollout should require a reason
3320         https://bugs.webkit.org/show_bug.cgi?id=30810
3321
3322         * Scripts/webkitpy/changelogs.py: Add support for a reason, add auto-wrapping logic.
3323         * Scripts/webkitpy/changelogs_unittest.py: Test reason support.
3324         * Scripts/webkitpy/commands/download.py: rollout now requires a reason, remove unused BUGID argument
3325         * Scripts/webkitpy/commands/download_unittest.py: pass required reason
3326         * Scripts/webkitpy/steps/preparechangelogforrevert.py: pass reason to update_for_revert
3327
3328 2010-01-04  Jon Honeycutt  <jhoneycutt@apple.com>
3329
3330         MSAA: <select> elements should broadcast value change events
3331
3332         https://bugs.webkit.org/show_bug.cgi?id=33088
3333
3334         <rdar://problem/7332364>
3335
3336         Reviewed by Darin Adler.
3337
3338         * DumpRenderTree/AccessibilityController.cpp:
3339         (logValueChangeEventsCallback):
3340         Start logging value change events.
3341         (AccessibilityController::getJSClass):
3342         Add a "logValueChangeEvents" to the AccessibilityController's JS class
3343         definition.
3344         (AccessibilityController::resetToConsistentState):
3345         Disable logging of value change events.
3346
3347         * DumpRenderTree/AccessibilityController.h:
3348         Declare setLogValueChangeEvents(), and add a member variable for the
3349         value change event hook.
3350
3351         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3352         (AccessibilityController::setLogValueChangeEvents):
3353         Stubbed.
3354
3355         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3356         (AccessibilityController::setLogValueChangeEvents):
3357         Stubbed.
3358
3359         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3360         (AccessibilityController::AccessibilityController):
3361         Initialize new member var.
3362         (AccessibilityController::~AccessibilityController):
3363         Disable logging of value change events.
3364         (logEventProc):
3365         When we receive an EVENT_OBJECT_VALUECHANGE, log the name of the object
3366         and its value.
3367         (AccessibilityController::setLogValueChangeEvents):
3368         If disabling logging, unhook the event, and clear the event hook
3369         member var. Otherwise, query for the root element to enable
3370         accessibility, and hook EVENT_OBJECT_VALUECHANGE.
3371
3372 2010-01-04  Adam Barth  <abarth@webkit.org>
3373
3374         Reviewed by Eric Seidel.
3375
3376         long_help for submit-patch
3377         https://bugs.webkit.org/show_bug.cgi?id=33184
3378
3379         * Scripts/webkitpy/commands/upload.py:
3380
3381 2010-01-04  Adam Barth  <abarth@webkit.org>
3382
3383         Reviewed by Eric Seidel.
3384
3385         commit-queue can wrongly reject patches if the buildbots are behind
3386         https://bugs.webkit.org/show_bug.cgi?id=30098
3387
3388         Check to make sure we can currently build and test before trying to
3389         land a patch.
3390
3391         * Scripts/webkitpy/commands/queues.py:
3392
3393 2010-01-04  Adam Roben  <aroben@apple.com>
3394
3395         Add a test harness for the Windows WebKit API, and a few tests
3396
3397         We currently only have tests for a handful of bugs regarding WebView
3398         destruction, but more tests can easily be added later. Eventually
3399         we'll run these tests as part of run-webkit-tests.
3400
3401         Fixes <http://webkit.org/b/33167>.
3402
3403         Reviewed by Sam Weinig.
3404
3405         * WebKitAPITest/HostWindow.cpp: Added.
3406         (WebKitAPITest::HostWindow::HostWindow): Initialize m_window.
3407         (WebKitAPITest::HostWindow::~HostWindow): Destroy our window if
3408         needed.
3409         (WebKitAPITest::HostWindow::initialize): Create our window.
3410         (WebKitAPITest::HostWindow::clientRect): Return our window's client
3411         rect.
3412         (WebKitAPITest::HostWindow::registerWindowClass): Does what it says.
3413         (WebKitAPITest::HostWindow::wndProc): Just call through to
3414         DefWindowProcW.
3415
3416         * WebKitAPITest/HostWindow.h: Added.
3417         (WebKitAPITest::HostWindow::window): Simple getter.
3418
3419         * WebKitAPITest/Test.h: Added. This file defines some macros useful
3420         for writing tests.
3421
3422         * WebKitAPITest/TestsController.cpp: Added.
3423         (WebKitAPITest::TestsController::TestsController): Initialize our
3424         members.
3425         (WebKitAPITest::TestsController::shared): Return the shared instance.
3426         (WebKitAPITest::TestsController::runAllTests): Run a message pump
3427         until a WM_QUIT message is received, then return whether all tests
3428         succeeded.
3429         (WebKitAPITest::TestsController::addTest): Add the test to m_tests and
3430         start running tests soon.
3431         (WebKitAPITest::TestsController::testFailed): Record the failure and
3432         print a message about it to stdout.
3433         (WebKitAPITest::TestsController::runNextTest): If we don't have any
3434         tests to run, post a WM_QUIT message to stop the message pump.
3435         Otherwise, run the test and print whether it passed, then schedule the
3436         next test.
3437         (WebKitAPITest::TestsController::runNextTestSoon): Set a 0-delay timer
3438         to run the next test.
3439         (WebKitAPITest::TestsController::registerWindowClass): Does what it
3440         says.
3441         (WebKitAPITest::TestsController::wndProc): If the runNextTestTimer
3442         fired, call runNextTest(). Pass everything else through to
3443         DefWindowProcW.
3444
3445         * WebKitAPITest/TestsController.h: Added.
3446
3447         * WebKitAPITest/WebKitAPITest.vcproj: Added.
3448
3449         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added.
3450
3451         * WebKitAPITest/main.cpp: Added.
3452         (main): (Mostly) just calls TestsController::runAllTests.
3453
3454         * WebKitAPITest/tests/WebViewDestruction.cpp: Added.
3455         (WebKitAPITest::WebKitCreateInstance): Helper function template to
3456         call through to the real WebKitCreateInstance.
3457         (WebKitAPITest::webViewCount): Helper function to call through to
3458         IWebKitStatistics::webViewCount.
3459         (WebKitAPITest::createWebView): Helper function to create a WebView
3460         and put it inside a HostWindow.
3461         (WebKitAPITest::runMessagePump): Helper function to run a message pump
3462         for a specified number of milliseconds, or until a WM_QUIT message is
3463         received.
3464         (WebKitAPITest::CloseWithoutDestroyWindow): Test for
3465         <http://webkit.org/b/32827>.
3466         (WebKitAPITest::MainFrameAfterClose): Test for
3467         <http://webkit.org/b/32868>.
3468         (WebKitAPITest::NoCloseOrDestroyWindow): Test for
3469         <http://webkit.org/b/33162>.
3470
3471 2010-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3472
3473         Reviewed by David Kilzer.
3474
3475         Add support for Git's "diff.mnemonicprefix" config option to WebKitTools
3476
3477         https://bugs.webkit.org/show_bug.cgi?id=32820
3478
3479         * Scripts/VCSUtils.pm:
3480         * Scripts/svn-apply:
3481         * Scripts/svn-unapply:
3482         * Scripts/test-webkitperl: Run gitdiff2svndiff test
3483         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl: Added.
3484         * Scripts/webkitpy/diff_parser.py:
3485         * Scripts/webkitpy/diff_parser_unittest.py:
3486
3487 2010-01-04  Chris Jerdonek  <chris.jerdonek@gmail.com>
3488
3489         Reviewed by David Kilzer.
3490
3491         Divided the Perl unit tests into separate files and put
3492         them in a separate directory, and renamed test-webkit-perl
3493         to test-webkitperl.
3494
3495         https://bugs.webkit.org/show_bug.cgi?id=33124
3496
3497         * Scripts/VCSUtils.pm:
3498           - Renamed generateRunPatchCommand() to generatePatchCommand().
3499
3500         * Scripts/VCSUtils_unittest.pl: Removed.
3501           - Divided into three files in Scripts/webkitperl/VCSUtils_unittest.
3502
3503         * Scripts/test-webkit-perl: Removed.
3504           - Renamed to test-webkitperl.
3505
3506         * Scripts/test-webkit-scripts:
3507           - Updated paths to test-webkitpy and test-webkitperl.
3508
3509         * Scripts/test-webkitperl: Copied from Scripts/test-webkit-perl.
3510           - Added paths to new test files.
3511
3512         * Scripts/webkitperl: Added.
3513         * Scripts/webkitperl/VCSUtils_unittest: Added.
3514         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl: Added.
3515         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl: Added.
3516         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl: Copied from Scripts/VCSUtils_unittest.pl.
3517
3518 2010-01-04  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by Adam Barth.
3521
3522         Make bugzilla-tool rollout include a bug link in the ChangeLog entry
3523         https://bugs.webkit.org/show_bug.cgi?id=33146
3524
3525         One more step towards better rollouts.
3526
3527         * Scripts/webkitpy/changelogs.py:
3528         * Scripts/webkitpy/changelogs_unittest.py:
3529         * Scripts/webkitpy/steps/preparechangelogforrevert.py:
3530
3531 2010-01-04  Adam Barth  <abarth@webkit.org>
3532
3533         Reviewed by Eric Seidel.
3534
3535         Sort the step options
3536         https://bugs.webkit.org/show_bug.cgi?id=33144
3537
3538         * Scripts/webkitpy/steps/options.py:
3539
3540 2010-01-04  Eric Seidel  <eric@webkit.org>
3541
3542         Reviewed by Adam Barth.
3543
3544         Need support for longer text in per-command help
3545         https://bugs.webkit.org/show_bug.cgi?id=33143
3546
3547         Add some minimal additional help to land-diff and
3548         pave the way for adding better help to all commands.
3549
3550         * Scripts/webkitpy/commands/download.py: Add small amount of additional help to land-diff
3551         * Scripts/webkitpy/multicommandtool.py: support long_help
3552         * Scripts/webkitpy/multicommandtool_unittest.py: test long_help
3553
3554 2010-01-04  Adam Barth  <abarth@webkit.org>
3555
3556         Reviewed by Eric Seidel.
3557
3558         Add unit test for MarkBugFixed
3559         https://bugs.webkit.org/show_bug.cgi?id=33142
3560
3561         MarkBugFixed is way behind in command technology, but it still needs a
3562         unit test, as the FIXME commands.
3563
3564         Also, remove mark-bug-fixed and create-bug from main help since we have
3565         more modern commands to replace them.
3566
3567         * Scripts/webkitpy/commands/upload.py:
3568         * Scripts/webkitpy/commands/upload_unittest.py:
3569         * Scripts/webkitpy/mock_bugzillatool.py:
3570
3571 2010-01-04  Adam Barth  <abarth@webkit.org>
3572
3573         Reviewed by Eric Seidel.
3574
3575         Add missing unit test for CommitMessageForCurrentDiff
3576         https://bugs.webkit.org/show_bug.cgi?id=33141
3577
3578         * Scripts/webkitpy/commands/upload.py:
3579         * Scripts/webkitpy/commands/upload_unittest.py:
3580
3581 2010-01-04  Adam Barth  <abarth@webkit.org>
3582
3583         Reviewed by Eric Seidel.
3584
3585         Remove raw_input from queues in favor of user.prompt
3586         https://bugs.webkit.org/show_bug.cgi?id=33140
3587
3588         This lets up properly mock out the user interaction instead of hacking
3589         around it with the options.
3590
3591         * Scripts/webkitpy/commands/queues.py:
3592         * Scripts/webkitpy/commands/queuestest.py:
3593
3594 2010-01-04  Eric Seidel  <eric@webkit.org>
3595
3596         Reviewed by Adam Barth.
3597
3598         bugzilla-tool should not require users to install mechanize
3599         https://bugs.webkit.org/show_bug.cgi?id=32635
3600
3601         * Scripts/webkitpy/__init__.py: Add missing declaration for ClientForm (which mechanize requires).
3602
3603 2010-01-04  Eric Seidel  <eric@webkit.org>
3604
3605         Reviewed by Adam Barth.
3606
3607         bugzilla-tool should not require users to install mechanize
3608         https://bugs.webkit.org/show_bug.cgi?id=32635
3609
3610         Use the nifty "autoinstall" module from Daniel Krech:
3611         http://pypi.python.org/pypi/autoinstall/0.2
3612         http://code.google.com/p/pyautoinstall/
3613         It's available under a WebKit-compatible BSD license.
3614
3615         * Scripts/webkitpy/__init__.py:
3616          - bind "mechanize" to an autoinstall importer which will
3617            auto-download mechanize if necessary.
3618         * Scripts/webkitpy/autoinstall.py: Added.
3619         * Scripts/webkitpy/bugzilla.py: use "mechanize" instead of webkit_mechanize
3620         * Scripts/webkitpy/statusbot.py: ditto.
3621         * Scripts/webkitpy/webkit_mechanize.py: Removed.
3622