2010-10-24 Nikolas Zimmermann <nzimmermann@rim.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-23  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         EWS never removes invalid patch ids
6         https://bugs.webkit.org/show_bug.cgi?id=48173
7
8         This is just sticking another finger in the dam.
9         However this adds more unit testing which will help
10         us make sure we're always releasing patches once we
11         redesign the release_patch API and call these from
12         a more central place.
13
14         * Scripts/webkitpy/tool/commands/queues.py:
15         * Scripts/webkitpy/tool/commands/queues_unittest.py:
16         * Scripts/webkitpy/tool/mocktool.py:
17          - Added the ability to request invalid patches.
18            Log a warning message to make sure we don't ever have
19            tests use invalid patch fetches by mistake.
20
21 2010-10-23  Dan Bernstein  <mitz@apple.com>
22
23         Build fix. Add stub implementations for required NSDraggingInfo methods.
24
25         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
26         (-[DumpRenderTreeDraggingInfo draggingFormation]):
27         (-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
28         (-[DumpRenderTreeDraggingInfo animatesToDestination]):
29         (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
30         (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
31         (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
32         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
33
34 2010-10-23  David Kilzer  <ddkilzer@apple.com>
35
36         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
37
38         Reviewed by Sam Weinig.
39
40         The only method defined in WebHTMLRepresentationInternal.h is
41         also defined in WebHTMLRepresentation.h, so use that instead.
42
43         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
44         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use
45         WebHTMLRepresentation.h.
46
47 2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
48
49         Unreviewed, rolling out r70367.
50         http://trac.webkit.org/changeset/70367
51         https://bugs.webkit.org/show_bug.cgi?id=48176
52
53         It made 8-10 tests crash on Qt bot (Requested by Ossy on
54         #webkit).
55
56         * DumpRenderTree/LayoutTestController.cpp:
57         (setCustomPolicyDelegateCallback):
58         * DumpRenderTree/LayoutTestController.h:
59         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
60         (LayoutTestController::setCustomPolicyDelegate):
61         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
62         (LayoutTestController::setCustomPolicyDelegate):
63         * DumpRenderTree/mac/PolicyDelegate.h:
64         * DumpRenderTree/mac/PolicyDelegate.mm:
65         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
66         (-[PolicyDelegate setPermissive:]):
67         (-[PolicyDelegate setControllerToNotifyDone:]):
68         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
69         (LayoutTestController::setCustomPolicyDelegate):
70         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
71         (LayoutTestController::setCustomPolicyDelegate):
72
73 2010-10-22  Eric Seidel  <eric@webkit.org>
74
75         Reviewed by Adam Barth.
76
77         EWS never releases patches which fail to apply
78         https://bugs.webkit.org/show_bug.cgi?id=48171
79
80         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
81         * Scripts/webkitpy/tool/commands/queues.py:
82
83 2010-10-22  Eric Seidel  <eric@webkit.org>
84
85         Unreviewed.
86
87         Make the EWS queues restart themselves more often.
88         This matches the commit-queue.
89
90         * EWSTools/start-queue.sh:
91
92 2010-10-22  Eric Seidel  <eric@webkit.org>
93
94         Reviewed by Adam Barth.
95
96         commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
97         https://bugs.webkit.org/show_bug.cgi?id=48165
98
99         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
100         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
101         * Scripts/webkitpy/tool/commands/queues_unittest.py:
102
103 2010-10-22  Mario Sanchez Prada  <msanchez@igalia.com>
104
105         Adding myself as a committer.
106
107         * Scripts/webkitpy/common/config/committers.py:
108
109 2010-10-20  Anders Carlsson  <andersca@apple.com>
110
111         Reviewed by Adam Barth and Darin Adler.
112
113         Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
114         https://bugs.webkit.org/show_bug.cgi?id=48014
115         <rdar://problem/8202716>
116         
117         * DumpRenderTree/LayoutTestController.cpp:
118         (setCustomPolicyDelegateCallback):
119         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
120
121         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
122         (LayoutTestController::setCustomPolicyDelegate):
123         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
124
125         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
126         (LayoutTestController::setCustomPolicyDelegate):
127         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
128
129         * DumpRenderTree/mac/PolicyDelegate.h:
130         * DumpRenderTree/mac/PolicyDelegate.mm:
131         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
132         If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
133
134         (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
135         Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
136         
137         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
138         (LayoutTestController::setCustomPolicyDelegate):
139         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
140
141         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
142         (LayoutTestController::setCustomPolicyDelegate):
143         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
144
145 2010-10-22  Sam Weinig  <sam@webkit.org>
146
147         Reviewed by Anders Carlsson.
148
149         Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle
150
151         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
152         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
153         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
154         (TestWebKitAPI::Util::createInjectedBundlePath):
155
156 2010-10-22  Dirk Pranke  <dpranke@chromium.org>
157
158         Reviewed by Eric Seidel.
159
160         test-webkitpy fails when passed -v (or any other option)
161
162         Fix port/base_unittest to pass an explicit list of arguments
163         rather than accidentally picking up sys.argv.
164
165         https://bugs.webkit.org/show_bug.cgi?id=48071
166
167         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
168
169 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
170
171         Windows build fix. Update the createNewPage callback to account for the new
172         arguments.
173
174         * MiniBrowser/win/BrowserView.cpp:
175         (createNewPage):
176
177 2010-10-22  Sam Weinig  <sam@webkit.org>
178
179         Reviewed by Anders Carlsson.
180
181         WebKit2 needs to pass the current event modifier flags when requesting a new window
182         https://bugs.webkit.org/show_bug.cgi?id=48140
183
184         * MiniBrowser/mac/BrowserWindowController.m:
185         (createNewPage):
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::createOtherPage):
188         Update for new signature for the WKPageCreateNewPageCallback.
189
190 2010-10-22  Eric Seidel  <eric@webkit.org>
191
192         Unreviewed.  Just adding a test case.
193
194         The style-queue was not recognizing new patches.  It turns
195         out I had fixed this in an earlier change, but just not
196         deployed to queues.webkit.org.  As part of investigating why it
197         was broken, I wrote a test for my previous change which I'm now landing.
198
199         * QueueStatusServer/model/queues_unittest.py:
200
201 2010-10-22  Eric Seidel  <eric@webkit.org>
202
203         Reviewed by Adam Barth.
204
205         EWS does not need to process obsolete patches
206         https://bugs.webkit.org/show_bug.cgi?id=48093
207
208         This was an easy change, but to test it I had to pipe
209         real Attachment objects into the queue testing system.
210         Doing so revealed a whole bunch of bugs in our unit tests,
211         which I fixed as part of this patch.
212
213         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
214          - This is the actual code change.  This will not reduce the
215            backlog in the EWS queues much, but it will make rejections
216            much quicker for obsolete patches or closed bugs.
217         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
218          - Test my new code.
219          - Used a real attachment object and got rid of MockPatch
220          - Shared code between the mac-ews and cr-mac-ews tests.
221         * Scripts/webkitpy/tool/commands/queues_unittest.py:
222          - Can't use MockPatch anymore.
223          - Removing MockPatch found more bugs here!
224         * Scripts/webkitpy/tool/commands/queuestest.py:
225         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
226         * Scripts/webkitpy/tool/mocktool.py:
227          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
228            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
229
230 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
231
232         Unreviewed, rolling out r70301.
233         http://trac.webkit.org/changeset/70301
234         https://bugs.webkit.org/show_bug.cgi?id=48126
235
236         "Lang attribute layout tests failing" (Requested by satish on
237         #webkit).
238
239         * DumpRenderTree/LayoutTestController.cpp:
240         (setMockSpeechInputResultCallback):
241         * DumpRenderTree/LayoutTestController.h:
242         * DumpRenderTree/chromium/LayoutTestController.cpp:
243         (LayoutTestController::setMockSpeechInputResult):
244         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
245         (LayoutTestController::setMockSpeechInputResult):
246         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
247         (LayoutTestController::setMockSpeechInputResult):
248         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
249         (LayoutTestController::setMockSpeechInputResult):
250         * DumpRenderTree/qt/LayoutTestControllerQt.h:
251         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
252         (LayoutTestController::setMockSpeechInputResult):
253         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
254         (LayoutTestController::setMockSpeechInputResult):
255
256 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
257
258         Reviewed by Jeremy Orlow.
259
260         Added a second parameter to setMockSpeechInputResult for
261         the language used in speech input.
262         https://bugs.webkit.org/show_bug.cgi?id=47089
263
264         * DumpRenderTree/LayoutTestController.cpp:
265         (setMockSpeechInputResultCallback):
266         * DumpRenderTree/LayoutTestController.h:
267         * DumpRenderTree/chromium/LayoutTestController.cpp:
268         (LayoutTestController::setMockSpeechInputResult):
269         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
270         (LayoutTestController::setMockSpeechInputResult):
271         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
272         (LayoutTestController::setMockSpeechInputResult):
273         * DumpRenderTree/qt/LayoutTestControllerQt.h:
274         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
275         (LayoutTestController::setMockSpeechInputResult):
276         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
277         (LayoutTestController::setMockSpeechInputResult):
278         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
279         (LayoutTestController::setMockSpeechInputResult):
280
281 2010-10-21  MORITA Hajime  <morrita@google.com>
282
283         Reviewed by Kent Tamura.
284
285         [Win][DRT] should have LayoutTestController.hasSpellingMarker()
286         https://bugs.webkit.org/show_bug.cgi?id=47885
287
288         - Implemented LayoutTestController.hasSpellingMarker(),
289         - Added fake spellcheck implementation.
290
291         * DumpRenderTree/win/DumpRenderTree.cpp:
292         (main):
293         * DumpRenderTree/win/EditingDelegate.cpp:
294         (indexOfFirstWordCharacter):
295         (wordLength):
296         (EditingDelegate::checkSpellingOfString):
297         * DumpRenderTree/win/EditingDelegate.h:
298         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
299         (LayoutTestController::hasSpellingMarker):
300
301 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
302
303         Unreviewed. Re-enable test that was mistakenly disabled by r67974.
304
305         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
306
307 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
308
309         Unreviewed fix for rebaseline-chromium-webkit-tests.
310
311         Port.diff_image no longer has a tolerance parameter. Also, use
312         get_option('tolerance') which is safer if the options object doesn't
313         define a tolerance attribute (it doesn't for the one used in
314         rebaseline_chromium_webkit_tests).
315
316         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
317         * Scripts/webkitpy/layout_tests/port/webkit.py:
318         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
319
320 2010-10-21  Mihai Parparita  <mihaip@chromium.org>
321
322         Reviewed by Ojan Vafai.
323
324         Add support for --tolerance in NRWT
325         https://bugs.webkit.org/show_bug.cgi?id=47959
326         
327         Add support for the --tolerance flag in NRWT. The Port.diff_image
328         signature shouldn't need a tolerance parameter (it's not set per test),
329         just have ports that use it (currently only WebKitPort) read it from 
330         the options object.
331
332         * Scripts/webkitpy/layout_tests/port/chromium.py:
333         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
334         * Scripts/webkitpy/layout_tests/port/test.py:
335         * Scripts/webkitpy/layout_tests/port/webkit.py:
336         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
337         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
338
339 2010-10-21  Eric Seidel  <eric@webkit.org>
340
341         Reviewed by Adam Barth.
342
343         Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
344         https://bugs.webkit.org/show_bug.cgi?id=48088
345
346         This is a first-pass.  Works, but we'll eventually
347         turn this on by default, refine the suggestion algorithm
348         and possibly move it to a different place in the upload step order.
349
350         * Scripts/webkitpy/common/checkout/api.py:
351         * Scripts/webkitpy/tool/commands/download_unittest.py:
352         * Scripts/webkitpy/tool/commands/upload.py:
353         * Scripts/webkitpy/tool/commands/upload_unittest.py:
354         * Scripts/webkitpy/tool/mocktool.py:
355         * Scripts/webkitpy/tool/steps/__init__.py:
356         * Scripts/webkitpy/tool/steps/options.py:
357
358 2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>
359
360         Reviewed by Chris Fleizach.
361
362         [GTK] Segfault while testing accessibility/iframe-bastardization.html
363         https://bugs.webkit.org/show_bug.cgi?id=30123
364
365         Check m_element before actually using it to get the parent.
366
367         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
368         (AccessibilityUIElement::parentElement): Add an extra check to
369         make sure m_element points to a valid value before actually using
370         it to get the parent. Also, assert ATK_IS_OBJECT(m_element).
371
372 2010-10-21  Anders Carlsson  <andersca@apple.com>
373
374         Reviewed by Adam Roben.
375
376         Crash evaluating JavaScript string that throws an exception
377         https://bugs.webkit.org/show_bug.cgi?id=48092
378         <rdar://problem/8487657>
379
380         Add a test that evaluates a JavaScript string that throws an exception and check that 
381         the callback is called.
382
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
385         (TestWebKitAPI::didRunJavaScript):
386         (TestWebKitAPI::WebKit2_EvaluateJavaScript):
387         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
388
389 2010-10-21  Adam Roben  <aroben@apple.com>
390
391         Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
392         called
393
394         Test for <http://webkit.org/b/48086> <rdar://problem/8482944>
395         Silverlight doesn't repaint in WebKit2
396
397         Reviewed by Anders Carlsson.
398
399         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
400         (PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
401         (executeScript): Added. Asks the browser to evaluate the script.
402
403         (PluginTest::waitUntilDone):
404         (PluginTest::notifyDone):
405         Added. Calls through to layoutTestController.
406
407         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
408         * NPN_InvalidateRect and waitUntilDone/notifyDone.
409
410         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
411         (TemporaryWindowMover::moveSucceeded):
412         (TemporaryWindowMover::TemporaryWindowMover):
413         (TemporaryWindowMover::~TemporaryWindowMover):
414         This class moves a window on-screen and shows it, then moves it back and hides it.
415
416         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
417         Initialize our members.
418         (NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
419         Delete our window mover if it hasn't been deleted already.
420         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
421         plugin HWND and move the test harness window on screen.
422         (NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
423         when we get a WM_PAINT message.
424         (NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
425         LayoutTestController we're done.
426         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
427         ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
428         then check that our HWND's invalid region is the rect that we
429         invalidated.
430
431         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
432         * Added NPNInvalidateRectInvalidatesWindow.
433
434 2010-10-21  Daniel Bates  <dbates@rim.com>
435
436         Add Git-support to do-file-rename
437         https://bugs.webkit.org/show_bug.cgi?id=48015
438
439         Fix tools. Export function scmMoveOrRenameFile so that it can be called from
440         do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.
441
442         * Scripts/VCSUtils.pm:
443
444 2010-10-21  Eric Seidel  <eric@webkit.org>
445
446         Reviewed by Adam Barth.
447
448         mac-ews is not properly releasing patches
449         https://bugs.webkit.org/show_bug.cgi?id=48076
450
451         mac-ews overrides process_work_item, so it was not calling
452         release_work_item like the default process_work_item would.
453         To fix this I made all the status-reporting methods just
454         release the patch.  I expect we'll iterate on this design further.
455
456         * Scripts/webkitpy/common/net/statusserver.py:
457         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
458         * Scripts/webkitpy/tool/commands/queues.py:
459         * Scripts/webkitpy/tool/commands/queues_unittest.py:
460
461 2010-10-18  Martin Robinson  <mrobinson@igalia.com>
462
463         Reviewed by Gustavo Noronha Silva.
464
465         [GTK] mathml flaky tests after adding SystemFonts to the theme
466         https://bugs.webkit.org/show_bug.cgi?id=47727
467
468         The Fontconfig setup in the GTK+ now specifically checks for and
469         loads the STIX fonts for MathML tests.
470
471         * DumpRenderTree/gtk/DumpRenderTree.cpp:
472         (initializeFonts): Add hooks for loading the STIX fonts specifically.
473
474 2010-10-20  Adam Roben  <aroben@apple.com>
475
476         Test that the UI client gets notified when WKView receives a WM_CLOSE
477         message
478
479         Test for <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
480         Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
481         close its parent window
482
483         Reviewed by Jon Honeycutt.
484
485         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
486         (TestWebKitAPI::close): Record that this function was called.
487         (TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
488         send it a WM_CLOSE message, and test that the UI client's close
489         callback got called. Note that this will hang if the bug is
490         reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
491         able to handle hangs.
492
493         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.
494
495 2010-10-20  Adam Roben  <aroben@apple.com>
496
497         Make prepare-ChangeLog much faster when using git
498
499         This change also seems to make it detect renames better in some cases.
500
501         Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
502         git
503
504         Reviewed by David Kilzer.
505
506         * Scripts/prepare-ChangeLog:
507         (statusCommand):
508         (createPatchCommand):
509         Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
510         and copies. The two "-C"s were making it read many more files than were
511         necessary.
512
513 2010-10-21  Sam Weinig  <sam@webkit.org>
514
515         Reviewed by Adam Roben.
516
517         Null frame passed when running alert from UserScript run at document start
518         <rdar://problem/8573809>
519         https://bugs.webkit.org/show_bug.cgi?id=48036
520
521         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
522         * TestWebKitAPI/InjectedBundleController.cpp:
523         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
524         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
525         * TestWebKitAPI/InjectedBundleController.h:
526         * TestWebKitAPI/InjectedBundleTest.h:
527         (TestWebKitAPI::InjectedBundleTest::initialize):
528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
529         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
530         (TestWebKitAPI::runJavaScriptAlert):
531         (TestWebKitAPI::TEST):
532         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
533         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
534         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
535         Add test for invoking an alert during a UserScript run at document start.
536
537 2010-10-21  Andreas Kling  <kling@webkit.org>
538
539         Reviewed by Adam Roben.
540
541         TestNetscapePlugIn: Actually call NPP_SetWindow on Unix
542
543         We were just returning NPERR_NO_ERROR previously.
544
545         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
546         (webkit_test_plugin_set_window):
547
548 2010-10-21  David Kilzer  <ddkilzer@apple.com>
549
550         <http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
551
552         Reviewed by Adam Roben.
553
554         * DumpRenderTree/config.h: Moved macros to here...
555         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
556         Addresses a FIXME comment from r28419.
557
558 2010-10-21  David Kilzer  <ddkilzer@apple.com>
559
560         <http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
561
562         Reviewed by Adam Roben.
563
564         Fixes the following warnings:
565
566             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
567             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
568             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
569             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
570             WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
571             5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.
572
573         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
574         Removed explicit file type for *.cpp files above to make them
575         match other C++ source files.  This exposed the fact that
576         DumpRenderTreeMac.h was not safe to include in C++ source, which
577         caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
578         to build.
579         * DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
580         * DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
581         in C++ source files.  Included CoreFoundation/CoreFoundation.h
582         to make sure all CF types were defined.  Removed CFStringRef
583         typedef.
584
585 2010-10-21  Adam Roben  <aroben@apple.com>
586
587         Attempt to fix plugins/pass-different-npp-struct.html on GTK.
588
589         See <http://webkit.org/b/47690>.
590
591         * GNUmakefile.am: Added PassDifferentNPPStruct.cpp.
592
593 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
594
595         Reviewed by Csaba Osztrogonác.
596
597         [NRWT] Set ImageDiff path on Qt port
598         https://bugs.webkit.org/show_bug.cgi?id=48052
599
600         * Scripts/webkitpy/layout_tests/port/qt.py:
601
602 2010-10-21  Adam Barth  <abarth@webkit.org>
603
604         Reviewed by Eric Seidel.
605
606         Don't CC authors of flaky tests
607         https://bugs.webkit.org/show_bug.cgi?id=48038
608
609         Some authors found this too annoying.  We'll look for another way to
610         close the flaky test loop.
611
612         * Scripts/webkitpy/tool/commands/queues.py:
613         * Scripts/webkitpy/tool/commands/queues_unittest.py:
614
615 2010-10-21  Eric Seidel  <eric@webkit.org>
616
617         Reviewed by Adam Barth.
618
619         commit-queue should run run-webkit-tests with --no-new-test-results
620         https://bugs.webkit.org/show_bug.cgi?id=47998
621
622         * Scripts/webkitpy/tool/steps/runtests.py:
623         * Scripts/webkitpy/tool/steps/steps_unittest.py:
624
625 2010-10-21  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
626
627         Reviewed by Ojan Vafai.
628
629         [NRWT] Get child process number from an environment variable
630         https://bugs.webkit.org/show_bug.cgi?id=47981
631
632         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
633
634 2010-10-20  David Kilzer  <ddkilzer@apple.com>
635
636         <http://webkit.org/b/47754> New script to verify explicit source file types in Xcode project files
637
638         Reviewed by Darin Adler.
639
640         The script parses an Xcode project file and makes sure the file
641         extension matches the explicit file type set for all source
642         files.  Note that the majority of source files will have their
643         type set by Xcode, so the script doesn't check them since there
644         is no need to second-guess Xcode.
645
646         * Scripts/check-Xcode-source-file-types: Added.  Code borrowed
647         heavily from sort-Xcode-project-file.
648
649 2010-10-20  Adam Roben  <aroben@apple.com>
650         
651         Windows build fix
652
653         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added missing #include.
654
655 2010-10-20  Adam Roben  <aroben@apple.com>
656
657         Qt test fix
658
659         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Added
660         PassDifferentNPPStruct.cpp.
661
662 2010-10-20  Sam Weinig  <sam@webkit.org>
663
664         Reviewed by Adam Roben.
665
666         Add ability to test injected bundle API using TestWebKitAPI
667         https://bugs.webkit.org/show_bug.cgi?id=48027
668
669         * TestWebKitAPI/InjectedBundleController.cpp: Added.
670         * TestWebKitAPI/InjectedBundleController.h: Added.
671         Shared main object for bundle functionality.
672
673         * TestWebKitAPI/InjectedBundleMain.cpp: Added.
674         Bundle entry point.
675
676         * TestWebKitAPI/InjectedBundleTest.h: Added.
677         Base class for which the bundle portion of a test derives from. 
678
679         * TestWebKitAPI/PlatformUtilities.h:
680         * TestWebKitAPI/PlatformUtilities.cpp: Added.
681         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
682         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
683         (TestWebKitAPI::Util::createInjectedBundlePath):
684         (TestWebKitAPI::Util::createURLForResource):
685         (TestWebKitAPI::Util::URLForNonExistentResource):
686         Add helper to create a context with the shared injected bundle,
687         and send the initial message to set up the test.
688
689         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Added.
690         * TestWebKitAPI/InjectedBundle-Info.plist: Added.
691         Add mac configuration files.
692
693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
694         Add the new files.
695
696         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp: Added.
697         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp: Added.
698         Add a simple initial bundle test.
699
700 2010-10-20  Eric Seidel  <eric@webkit.org>
701
702         Unreviewed.  Fixing /release-patch url used by the EWS bots.
703
704         EWS should test patches with r+
705         https://bugs.webkit.org/show_bug.cgi?id=35460
706
707         * Scripts/webkitpy/common/net/statusserver.py:
708          - I changed the URL during development, and 404s are
709          intentionally silenced during release_patch.
710
711 2010-10-14  Adam Roben  <aroben@apple.com>
712
713         Test that passing a different NPP struct back to the browser doesn't
714         cause an assertion failure
715
716         Test for <http://webkit.org/b/47690> <rdar://problem/8553020>
717         Assertion failure in NetscapePlugin::fromNPP when using Shockwave in
718         WebKit2
719
720         Reviewed by John Sullivan.
721
722         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp: Copied from WebKitTools/DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp.
723         (PassDifferentNPPStruct::PassDifferentNPPStruct): Initialize our
724         members.
725         (PassDifferentNPPStruct::NPP_SetWindow): Pass a different NPP to the
726         browser than the one it gave us in NPP_New and see if it works.
727
728         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
729         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
730         Added PassDifferentNPPStruct.
731
732 2010-10-19  Adam Roben  <aroben@apple.com>
733
734         Gently nudge old-run-webkit-tests toward working with Win32 Perl
735
736         This makes old-run-webkit-tests able to build DRT and find all the
737         tests to run. It even invokes DRT and passes it the list of tests. But
738         DRT ends up hung blocking on I/O.
739
740         Fixes <http://webkit.org/b/47961> Get old-run-webkit-tests mostly
741         working with Win32 Perl
742
743         Reviewed by David Kilzer.
744
745         * Scripts/old-run-webkit-tests:
746           - Use File::Spec instead of manually concatenating paths
747           - Use dirname instead of manually stripping off the base name
748           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
749           - Explicitly invoke Perl when running Perl scripts
750           - Quote paths when using them in regular expressions to allow them
751             to include characters that have special meanings in regular
752             expressions
753
754         * Scripts/run-webkit-tests: Use File::Spec instead of manually
755         concatenating paths.
756
757         * Scripts/webkitdirs.pm:
758           - Remove the unused $windowsTmpPath variable
759           - Use isCygwin/isWindows/isAppleWinWebKit more judiciously
760           - Only pass paths to cygpath when using Cygwin Perl
761           - Only use pdevenv when using Cygwin Perl, for now
762
763 2010-10-20  Daniel Bates  <dbates@rim.com>
764
765         Reviewed by Martin Robinson.
766
767         Add Git-support to do-file-rename
768         https://bugs.webkit.org/show_bug.cgi?id=48015
769
770         Also, abstracts the SCM move/rename functionality in do-file-rename and
771         do-webcore-rename into a common function VCSUtils::scmMoveOrRenameFile().
772
773         Currently, do-file-rename is hard coded to assume the SCM is Subversion.
774         Instead, we should abstract the rename logic to be SCM-independent. This
775         will allow us to add Git support as well move such functionality into
776         our SCM library VCSUtils, where it can be shared by do-webcore-rename.
777
778         * Scripts/VCSUtils.pm:
779           - Added function scmMoveOrRenameFile.
780         * Scripts/do-file-rename: Modified to call VCSUtils::scmMoveOrRenameFile().
781         * Scripts/do-webcore-rename: Ditto.
782
783 2010-10-20  Adam Roben  <aroben@apple.com>
784
785         Fix old-run-webkit-tests when there's a space in the path to DRT
786
787         Reviewed by Jon Honeycutt.
788
789         * Scripts/old-run-webkit-tests: Quote the path to DRT before executing
790         it.
791
792 2010-10-20  Kenneth Russell  <kbr@google.com>
793
794         Reviewed by Dimitri Glazkov.
795
796         Regression in chromium_gpu_unittests after r70175
797         https://bugs.webkit.org/show_bug.cgi?id=48008
798
799         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
800
801 2010-10-20  Kenneth Russell  <kbr@google.com>
802
803         Reviewed by James Robinson.
804
805         chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
806         https://bugs.webkit.org/show_bug.cgi?id=48005
807
808         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
809
810 2010-10-20  Adam Barth  <abarth@webkit.org>
811
812         Reviewed by Eric Seidel.
813
814         webkit-patch doesn't get along with git rm
815         https://bugs.webkit.org/show_bug.cgi?id=47940
816
817         Turns out we need to pass "--" to tell git this is a path.
818
819         * Scripts/webkitpy/common/checkout/scm.py:
820
821 2010-10-20  Robert Hogan  <robert@webkit.org>
822
823         Reviewed by Antonio Gomes.
824
825         [Qt] Fix layoutTestController.getJsObjectCount
826
827         Qt Bridge doesn't know size_t so pass result as unsigned int.
828
829         Unskip fast/dom/gc-10.html
830
831         https://bugs.webkit.org/show_bug.cgi?id=47931
832
833         * DumpRenderTree/qt/GCControllerQt.cpp:
834         (GCController::getJSObjectCount):
835         * DumpRenderTree/qt/GCControllerQt.h:
836
837 2010-10-20  Sheriff Bot  <webkit.review.bot@gmail.com>
838
839         Unreviewed, rolling out r70149.
840         http://trac.webkit.org/changeset/70149
841         https://bugs.webkit.org/show_bug.cgi?id=47989
842
843         "Build breaks in mac and win" (Requested by satish on
844         #webkit).
845
846         * DumpRenderTree/LayoutTestController.cpp:
847         (setMockSpeechInputResultCallback):
848         * DumpRenderTree/LayoutTestController.h:
849         * DumpRenderTree/chromium/LayoutTestController.cpp:
850         (LayoutTestController::setMockSpeechInputResult):
851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
852         (LayoutTestController::setMockSpeechInputResult):
853
854 2010-10-19  Adam Roben  <aroben@apple.com>
855
856         Teach update-webkit-support-libs about the new versioning of
857         WebKitSupportLibrary
858
859         Fixes <http://webkit.org/b/47915> update-webkit-support-libs should
860         check version numbers instead of modification times
861
862         Reviewed by Sam Weinig.
863
864         * Scripts/update-webkit-support-libs: Fetch the expected version
865         number from developer.apple.com, then compare with the version number
866         of the extracted library and of the zipped library to see if anything
867         needs to be done. Removed code that tracked the modified timestamp of
868         the library, as it is no longer needed.
869
870 2010-10-19  Eric Seidel  <eric@webkit.org>
871
872         Reviewed by Adam Barth.
873
874         EWS should test patches with r+
875         https://bugs.webkit.org/show_bug.cgi?id=35460
876
877         * QueueStatusServer/handlers/submittoews.py:
878         * QueueStatusServer/model/queues.py:
879         * Scripts/webkitpy/tool/bot/patchcollection.py: Removed.
880         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Removed.
881         * Scripts/webkitpy/tool/commands/queues.py:
882
883 2010-10-19  Eric Seidel  <eric@webkit.org>
884
885         Reviewed by Adam Barth.
886
887         Teach feeder-queue how to feed the EWS bots
888         https://bugs.webkit.org/show_bug.cgi?id=47943
889
890         queues.webkit.org already knew how to accept EWS submissions
891         via /submit-to-ews.  This teaches the feeder queue how to post
892         to that page with any new r? patches it sees.
893
894         * QueueStatusServer/model/activeworkitems_unitest.py: Added.
895          - More unit testing is always a good thing.
896         * Scripts/webkitpy/common/net/bugzilla.py:
897         * Scripts/webkitpy/common/net/statusserver.py:
898         * Scripts/webkitpy/tool/bot/feeders.py:
899         * Scripts/webkitpy/tool/commands/queues.py:
900         * Scripts/webkitpy/tool/commands/queues_unittest.py:
901         * Scripts/webkitpy/tool/mocktool.py:
902
903 2010-10-19  Eric Seidel  <eric@webkit.org>
904
905         Unreviewed, just fixing test-webkitpy.  I'm really on a roll today.
906
907         commit-queue gets stuck when release-patch returns 404
908         https://bugs.webkit.org/show_bug.cgi?id=47935
909
910         Fix test-webkitpy and unittest NetworkTransaction.
911
912         * Scripts/webkitpy/common/net/networktransaction.py:
913         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
914
915 2010-10-19  Eric Seidel  <eric@webkit.org>
916
917         Unreviewed.
918
919         commit-queue gets stuck when release-patch returns 404
920         https://bugs.webkit.org/show_bug.cgi?id=47935
921
922         Turns out ClientForm gets upset if passed an int() instead of a string type.
923         Yay for untestable code.
924
925         * Scripts/webkitpy/common/net/statusserver.py:
926
927 2010-10-19  Eric Seidel  <eric@webkit.org>
928
929         Unreviewed.  Will get Adam's commentary after his meeting
930         for now this gets the commit-cluster back running.
931
932         commit-queue gets stuck when release-patch returns 404
933         https://bugs.webkit.org/show_bug.cgi?id=47935
934
935         I taught NetworkTransaction the basics of 404 handling.
936         We'll want to go back and teach it how to handle urllib2 404's too
937         and then deploy it to the places that want it.
938
939         * QueueStatusServer/handlers/releasepatch.py:
940         * Scripts/webkitpy/common/net/buildbot.py:
941         * Scripts/webkitpy/common/net/networktransaction.py:
942         * Scripts/webkitpy/common/net/statusserver.py:
943
944 2010-10-19  Eric Seidel  <eric@webkit.org>
945
946         Unreviewed.  Fixing typos in my previous commit.
947
948         Make patch release explicit and not a magic part of "retry" status
949         https://bugs.webkit.org/show_bug.cgi?id=47909
950
951         All of these typos again due to our inability to unit
952         test much of this code.  I added one unit test where
953         possible.  activeworkitems_unittest.py will be in a separate patch.
954
955         * QueueStatusServer/handlers/releasepatch.py:
956         * QueueStatusServer/main.py:
957         * QueueStatusServer/model/activeworkitems.py:
958         * QueueStatusServer/model/workitems.py:
959         * QueueStatusServer/model/workitems_unittest.py:
960         * QueueStatusServer/templates/releasepatch.html:
961         * Scripts/webkitpy/common/net/statusserver.py:
962
963 2010-10-19  Tony Chang  <tony@chromium.org>
964
965         Reviewed by Kent Tamura.
966
967         [chromium] Use webkit's TestNetscapePlugIn in DRT mac
968         https://bugs.webkit.org/show_bug.cgi?id=47850
969
970         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Added. Forked
971             because we're going to name our plugin WebKitTestNetscapePlugIn
972             temporarily until the chromium forked plugin goes away.
973
974 2010-10-19  Eric Seidel  <eric@webkit.org>
975
976         Reviewed by Adam Barth.
977
978         Make patch release explicit and not a magic part of "retry" status
979         https://bugs.webkit.org/show_bug.cgi?id=47909
980
981         This moves us another step closer to running r+ patches on the EWS bots.
982         Currently all bots just spam /update-work-items with their list of current
983         work items.  queues.webkit.org uses that data for display.  As part of making
984         the EWS run r+ patches, we're moving the official list of patches-to-process
985         into the server, and feeding them out to bots one at a time.  We need to be
986         able to remove patches from the queues one at a time instead of just spamming
987         /update-work-items with a new complete list.  That's what this patch adds.
988
989         * QueueStatusServer/handlers/nextpatch.py:
990         * QueueStatusServer/handlers/queuestatus.py:
991         * QueueStatusServer/handlers/releasepatch.py: Added.
992         * QueueStatusServer/handlers/statusbubble_unittest.py:
993          - Fix a typo causing test failure.  This was not caught by the bots
994            because they don't have AppEngineLauncher installed and thus don't run
995            the QueueStatusServer tests.
996         * QueueStatusServer/handlers/updatestatus.py:
997         * QueueStatusServer/model/activeworkitems.py:
998         * QueueStatusServer/templates/releasepatch.html: Added.
999         * Scripts/webkitpy/common/net/statusserver.py:
1000         * Scripts/webkitpy/tool/commands/queues.py:
1001         * Scripts/webkitpy/tool/mocktool.py:
1002
1003 2010-10-19  Eric Seidel  <eric@webkit.org>
1004
1005         Reviewed by Adam Barth.
1006
1007         cr-mac bubble has caused status bubbles to wrap
1008         https://bugs.webkit.org/show_bug.cgi?id=47928
1009
1010         We now have too many EWSes to fit in the bugs.webkit.org
1011         status-bubble iframe when more than a couple EWS builds are pending.
1012         To fix this I've reduced the space taken up by queue position,
1013         and also moved cr-mac to the end of the list (since it's going to be
1014         triple-digits for a while).
1015
1016         * QueueStatusServer/model/queues.py:
1017         * QueueStatusServer/templates/statusbubble.html:
1018
1019 2010-10-19  Kenneth Russell  <kbr@google.com>
1020
1021         Reviewed by David Levin.
1022
1023         chromium_gpu port of new-run-webkit-tests must search chromium-gpu directory for expectations
1024         https://bugs.webkit.org/show_bug.cgi?id=47874
1025
1026         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1027         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1028
1029 2010-10-19  Tony Chang  <tony@chromium.org>
1030
1031         Reviewed by Kent Tamura.
1032
1033         [chromium] DumpRenderTree shouldn't put '.' in include path
1034         https://bugs.webkit.org/show_bug.cgi?id=47877
1035
1036         Fix include paths.
1037
1038         * DumpRenderTree/chromium/AccessibilityController.cpp:
1039         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1040         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1041         * DumpRenderTree/chromium/CppBoundClass.cpp:
1042         * DumpRenderTree/chromium/CppVariant.cpp:
1043         * DumpRenderTree/chromium/CppVariant.h:
1044         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1045         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1046         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
1047         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1048         * DumpRenderTree/chromium/DRTDevToolsClient.h:
1049         * DumpRenderTree/chromium/EventSender.cpp:
1050         * DumpRenderTree/chromium/EventSender.h:
1051         * DumpRenderTree/chromium/LayoutTestController.cpp:
1052         * DumpRenderTree/chromium/LayoutTestController.h:
1053         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1054         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1055         * DumpRenderTree/chromium/NotificationPresenter.h:
1056         * DumpRenderTree/chromium/PlainTextController.cpp:
1057         * DumpRenderTree/chromium/Task.cpp:
1058         * DumpRenderTree/chromium/TestNavigationController.h:
1059         * DumpRenderTree/chromium/TestShell.cpp:
1060         * DumpRenderTree/chromium/TestWebWorker.h:
1061         * DumpRenderTree/chromium/TextInputController.cpp:
1062         * DumpRenderTree/chromium/WebPreferences.cpp:
1063         * DumpRenderTree/chromium/WebPreferences.h:
1064         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
1065         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1066         * DumpRenderTree/chromium/WebViewHost.cpp:
1067         * DumpRenderTree/chromium/WebViewHost.h:
1068
1069 2010-10-19  Sam Weinig  <sam@webkit.org>
1070
1071         Reviewed by Dan Bernstein.
1072
1073         Need to include WKErrorRef in the WKPageDidFail... functions
1074         https://bugs.webkit.org/show_bug.cgi?id=47871
1075
1076         Update tools for new parameter in failure callbacks.
1077
1078         * MiniBrowser/mac/BrowserWindowController.m:
1079         (didFailProvisionalLoadWithErrorForFrame):
1080         (didFailLoadWithErrorForFrame):
1081         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1082         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1083         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
1084         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1085         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1086         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1088
1089 2010-10-19  Luiz Agostini  <luiz.agostini@openbossa.org>
1090
1091         Reviewed by Antti Koivisto.
1092
1093         [Qt] WebKit2 MacOS build fix
1094         https://bugs.webkit.org/show_bug.cgi?id=47897
1095
1096         Qt WebKit2 MacOS build fix.
1097
1098         * WebKitTestRunner/PlatformWebView.h:
1099         * WebKitTestRunner/qt/TestControllerQt.cpp:
1100
1101 2010-10-19  Adam Barth  <abarth@webkit.org>
1102
1103         Reviewed by Eric Seidel.
1104
1105         webkit-patch stats the filesystem too many times
1106         https://bugs.webkit.org/show_bug.cgi?id=47883
1107
1108         This patch attempts to cache the list of changed files more agressively
1109         and to use that list to compute the diff instead of stating the file
1110         system again.
1111
1112         * Scripts/webkitpy/common/checkout/api.py:
1113         * Scripts/webkitpy/common/checkout/scm.py:
1114         * Scripts/webkitpy/tool/mocktool.py:
1115         * Scripts/webkitpy/tool/steps/abstractstep.py:
1116         * Scripts/webkitpy/tool/steps/editchangelog.py:
1117         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1118
1119 2010-10-19  David Kilzer  <ddkilzer@apple.com>
1120
1121         <http://webkit.org/b/47741> Make sort-Xcode-project-file a little more friendly
1122
1123         Reviewed by Darin Adler.
1124
1125         * Scripts/sort-Xcode-project-file:
1126         - Don't print an error message about missing arguments when
1127           -h|--help is used.
1128         - Allow Xcode project files to be specified as Project.xcodeproj
1129           instead of Project.xcodeproj/project.pbxproj.
1130
1131 2010-10-18  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1132
1133         Reviewed by Andreas Kling.
1134
1135         [Qt] QtTestBrowser: Prevent calling load() directly from loadFinished() in robot mode.
1136         https://bugs.webkit.org/show_bug.cgi?id=47809
1137
1138         Connecting a call to load from the loadFinished signal can cause
1139         re-entrance crashes in WebCore. This patch uses a timer to do so,
1140         also giving some time to subsequent frames to finish loading.
1141
1142         * QtTestBrowser/urlloader.cpp:
1143         (UrlLoader::UrlLoader):
1144         (UrlLoader::loadNext):
1145         (UrlLoader::checkIfFinished):
1146         (UrlLoader::frameLoadStarted):
1147         (UrlLoader::frameLoadFinished):
1148         * QtTestBrowser/urlloader.h:
1149
1150 2010-10-19  Sergio Villar Senín  <svillar@igalia.com>
1151
1152         Reviewed by Xan Lopez.
1153
1154         [GTK] http/history tests are failing
1155         https://bugs.webkit.org/show_bug.cgi?id=36173
1156
1157         Clear the history each time a test is run. Return the actual
1158         history item count when calling
1159         LayoutTestController::webHistoryItemCount
1160
1161         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1162         (resetDefaultsToConsistentValues):
1163         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1164         (LayoutTestController::webHistoryItemCount):
1165
1166 2010-10-18  Eric Seidel  <eric@webkit.org>
1167
1168         Reviewed by Adam Barth.
1169
1170         Add Chromium Mac EWS to the list of queues at queues.webkit.org
1171         https://bugs.webkit.org/show_bug.cgi?id=47878
1172
1173         * QueueStatusServer/model/queues.py:
1174
1175 2010-10-18  Eric Seidel  <eric@webkit.org>
1176
1177         Reviewed by Adam Barth.
1178
1179         queues.webkit.org/next_patch is always 404
1180         https://bugs.webkit.org/show_bug.cgi?id=47881
1181
1182         With the addition of the Queue class, I changed most of the
1183         code to lookup WorkItems using get_or_insert with a key_name
1184         instead of WorkItems.all().filter(queue_name=).
1185         Because the new get_or_insert code uses an explicit key_name
1186         (which is obviously different from the previously autogenerated
1187         ones), there were new WorkItem records created for each queue.
1188         However, some parts of the code still use WorkItems.all().filter,
1189         thus some parts were getting the new record and some parts the old record.
1190
1191         The same basic bug was occurring with ActiveWorkItems, because I
1192         changed the key_name for that class as well.
1193
1194         To fix this I've moved more of the code over to using Queue.*work_items.
1195         I've also enabled the datastore_admin (new in GAE 1.3.8) so that
1196         we can go delete the old WorkItems records.
1197         I also changed remote_api to use the new builtin: syntax (also added in GAE 1.3.8).
1198
1199         * QueueStatusServer/app.yaml:
1200         * QueueStatusServer/handlers/queuestatus.py:
1201         * QueueStatusServer/handlers/recentstatus.py:
1202         * QueueStatusServer/handlers/updatestatus.py:
1203         * QueueStatusServer/handlers/updateworkitems.py:
1204
1205 2010-10-18  Eric Seidel  <eric@webkit.org>
1206
1207         Reviewed by Adam Barth.
1208
1209         Correct a bunch of typos in QueueStatusServer
1210         https://bugs.webkit.org/show_bug.cgi?id=47880
1211
1212         These are all due to our complete lack of unit testing in QueueStatusServer.
1213         I added a couple unit tests to cover a few of these fixes, but most of these
1214         are still only caught by actually running the application.
1215
1216         * QueueStatusServer/handlers/nextpatch.py:
1217         * QueueStatusServer/handlers/statusbubble.py:
1218         * QueueStatusServer/handlers/statusbubble_unittest.py: Added.
1219         * QueueStatusServer/handlers/updateworkitems.py:
1220         * QueueStatusServer/model/attachment.py:
1221         * QueueStatusServer/model/queuepropertymixin.py:
1222         * QueueStatusServer/model/queuepropertymixin_unittest.py:
1223         * QueueStatusServer/model/workitems.py:
1224         * QueueStatusServer/model/workitems_unittest.py: Added.
1225
1226 2010-10-18  Adam Barth  <abarth@webkit.org>
1227
1228         Disable this test because it's failing on the bots and the authors
1229         aren't around to fix it.
1230
1231         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1232
1233 2010-10-18  Adam Barth  <abarth@webkit.org>
1234
1235         Reviewed by Eric Seidel.
1236
1237         CC authors of flaky tests when the commit-queue hits a flaky test
1238         https://bugs.webkit.org/show_bug.cgi?id=47872
1239
1240         * Scripts/webkitpy/common/checkout/api.py:
1241         * Scripts/webkitpy/common/net/layouttestresults.py:
1242         * Scripts/webkitpy/tool/commands/queues.py:
1243         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1244         * Scripts/webkitpy/tool/mocktool.py:
1245
1246 2010-10-18  Eric Seidel  <eric@webkit.org>
1247
1248         Reviewed by Adam Barth.
1249
1250         Make it possible to run a chromium-mac-ews builder
1251         https://bugs.webkit.org/show_bug.cgi?id=47876
1252
1253         Since we can't run Mac OS X in a VM, we need to only run committer patches.
1254         There was a multiple inheritance problem which was holding this patch back,
1255         but I decided to just ignore the problem and go with a functional hack for now.
1256
1257         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1258         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1259
1260 2010-10-18  Kenneth Russell  <kbr@google.com>
1261
1262         Reviewed by Tony Chang.
1263
1264         Regression in run_webkit_tests_unittest from r70017
1265         https://bugs.webkit.org/show_bug.cgi?id=47875
1266
1267         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1268
1269 2010-10-18  Adam Barth  <abarth@webkit.org>
1270
1271         Reviewed by Eric Seidel.
1272
1273         Implement webkit-patch suggest-reviewers
1274         https://bugs.webkit.org/show_bug.cgi?id=47866
1275
1276         * Scripts/webkitpy/common/checkout/api.py:
1277             - The main logic.  We look at the last five changes to each
1278               modified (non-ChangeLog) file and collect up the reviewers of
1279               those changes as well as the authors of those changes who are
1280               reviewers.
1281         * Scripts/webkitpy/common/checkout/api_unittest.py:
1282             - Test the logic with some fun mocks.
1283         * Scripts/webkitpy/common/checkout/scm.py:
1284             - Fix a bug when you have local git commits.
1285         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1286             - Test that the bug is fixed.
1287         * Scripts/webkitpy/tool/commands/queries.py:
1288             - Add the query.
1289
1290 2010-10-18  Kenneth Russell  <kbr@google.com>
1291
1292         Reviewed by Eric Seidel.
1293
1294         new-run-webkit-tests produces corrupt PNG baselines on Windows
1295         https://bugs.webkit.org/show_bug.cgi?id=47867
1296
1297         * Scripts/webkitpy/layout_tests/port/base.py:
1298
1299 2010-10-18  Eric Seidel  <eric@webkit.org>
1300
1301         Reviewed by Adam Barth.
1302
1303         Make it possible to submit patches to the EWS bots
1304         https://bugs.webkit.org/show_bug.cgi?id=47869
1305
1306         * QueueStatusServer/handlers/nextpatch.py:
1307          - Move more logic into Queue, so that it can be shared with SubmitToEWS.
1308         * QueueStatusServer/handlers/queuestatus.py:
1309          - Fix two typos from a previous commit.
1310         * QueueStatusServer/handlers/submittoews.py: Added.
1311         * QueueStatusServer/handlers/updatestatus.py:
1312          - Use the new is_retry_request method to share this (hacky) code with SubmitToEWS
1313         * QueueStatusServer/main.py:
1314          - Add /submit-to-ews
1315         * QueueStatusServer/model/queuepropertymixin.py:
1316          - Fix circular imports caused by adding Queue.work_items()
1317         * QueueStatusServer/model/queues.py:
1318          - Add work_items() and active_work_items()
1319         * QueueStatusServer/model/queuestatus.py:
1320         * QueueStatusServer/model/workitems.py:
1321          - Add transaction-safe add/remove methods.
1322         * QueueStatusServer/templates/submittoews.html: Added.
1323
1324 2010-10-18  Eric Seidel  <eric@webkit.org>
1325
1326         Reviewed by Adam Barth.
1327
1328         Deploy Queue class in more places throughout QueueStatusServer
1329         https://bugs.webkit.org/show_bug.cgi?id=47855
1330
1331         I also caught two typos from the previous change.  Unfortunately
1332         I don't yet know how to unittest request handlers yet.
1333
1334         * QueueStatusServer/handlers/dashboard.py:
1335         * QueueStatusServer/handlers/statusbubble.py:
1336         * QueueStatusServer/handlers/updateworkitems.py:
1337         * QueueStatusServer/model/activeworkitems.py:
1338         * QueueStatusServer/model/attachment.py:
1339         * QueueStatusServer/model/queuepropertymixin.py: Added.
1340         * QueueStatusServer/model/queuepropertymixin_unittest.py: Added.
1341         * QueueStatusServer/model/queuestatus.py:
1342         * QueueStatusServer/model/workitems.py:
1343
1344 2010-10-18  Adam Barth  <abarth@webkit.org>
1345
1346         Reviewed by Eric Seidel.
1347
1348         scm.py should be able tell us what revisions made changes to a given file
1349         https://bugs.webkit.org/show_bug.cgi?id=47863
1350
1351         Look again, your SCM.py can now log files.
1352
1353         * Scripts/webkitpy/common/checkout/scm.py:
1354         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1355
1356 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1357
1358         Reviewed by Eric Siedel.
1359
1360         new-run-webkit-tests: clean up the options-parsing code in the port
1361         classes.
1362         
1363         This change modifies the Port interface to have a get_option() and
1364         set_option_default() method for accessing the options argument
1365         passed to the constructor. If the constructor is not passed an
1366         options argument, we default to a MockOptions() argument from
1367         mocktool, which has the same semantics we want.
1368
1369         Note that there is a disadvantage to port.get_option('foo') over
1370         port._options.foo, which is that you lose some of the checking
1371         for whether 'foo' is set (typos result in the default value, not
1372         an exception being raised. This is desired in this case, since the
1373         Port class is not allowed to assume that options does have any
1374         particular values set, and so this change ensures that all of
1375         the subclasses are following the same, intended, logic.
1376
1377         Arguably this is the wrong semantics to have, and the Port
1378         classes should be able to assume a default set of
1379         attributes/arguments, but that change will need to wait for a
1380         different CL where we can modify new-run-webkit-tests to pull a
1381         list of arguments from the port factory routines.
1382
1383         Also, add unit tests for webkitpy.tool.mocktool.MockOptions .
1384
1385         https://bugs.webkit.org/show_bug.cgi?id=47510
1386
1387         * Scripts/webkitpy/layout_tests/port/base.py:
1388         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1389         * Scripts/webkitpy/layout_tests/port/chromium.py:
1390         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1391         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1392         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1393         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1394         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1395         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1396         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1397         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1398         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1399         * Scripts/webkitpy/layout_tests/port/test.py:
1400         * Scripts/webkitpy/layout_tests/port/webkit.py:
1401         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1402         * Scripts/webkitpy/tool/mocktool_unittest.py: Added.
1403
1404 2010-10-18  Dirk Pranke  <dpranke@chromium.org>
1405
1406         Reviewed by Eric Seidel.
1407
1408         Re-submit a revised version of r69638 - enabling new-run-webkit-tests
1409         under cygwin. The initial version had a bug in base:uri_to_test_name
1410         that was causing tests to fail. This version corrects that bug, but
1411         also makes the code safer by calling cygpath more reliably, and
1412         leaving a long-running cygpath process open.
1413
1414         This patch also corrects a couple of minor bugs in http_lock_unittest,
1415         chromium_unittest, and dedpulicate_tests_unittest that showed up
1416         while testing this.
1417
1418         https://bugs.webkit.org/show_bug.cgi?id=47220
1419
1420         * Scripts/webkitpy/common/system/path.py:
1421         * Scripts/webkitpy/common/system/path_unittest.py:
1422         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1423         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1424         * Scripts/webkitpy/layout_tests/port/base.py:
1425         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1426         * Scripts/webkitpy/layout_tests/port/chromium.py:
1427         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1428         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
1429         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1430
1431 2010-10-18  Eric Seidel  <eric@webkit.org>
1432
1433         Reviewed by Adam Barth.
1434
1435         Add Queue class and add minimal unittesting of QueueStatusServer code
1436         https://bugs.webkit.org/show_bug.cgi?id=47847
1437
1438         * QueueStatusServer/handlers/dashboard.py:
1439         * QueueStatusServer/handlers/queuestatus.py:
1440         * QueueStatusServer/handlers/recentstatus.py:
1441         * QueueStatusServer/handlers/statusbubble.py:
1442         * QueueStatusServer/handlers/updateworkitems.py:
1443         * QueueStatusServer/model/attachment.py:
1444         * QueueStatusServer/model/queues.py:
1445         * QueueStatusServer/model/queues_unittest.py: Added.
1446         * QueueStatusServer/model/svnrevision.py:
1447         * Scripts/test-webkitpy:
1448         * Scripts/webkitpy/test/main.py:
1449
1450 2010-10-18  Anders Carlsson  <andersca@apple.com>
1451
1452         Fix build.
1453
1454         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1455         (handleEventCarbon):
1456
1457 2010-10-18  Stuart Morgan  <stuartmorgan@chromium.org>
1458
1459         Reviewed by Eric Seidel.
1460
1461         Switch to using the new Carbon NPAPI event declarations, and remove
1462         the old ones.
1463
1464         https://bugs.webkit.org/show_bug.cgi?id=40784
1465
1466         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1467         (handleEventCarbon):
1468
1469 2010-10-18  David Levin  <levin@chromium.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         check-webkit-style should treat the GObject binding directory like other GTK directories.
1474         https://bugs.webkit.org/show_bug.cgi?id=47796
1475
1476         * Scripts/webkitpy/style/checker.py: Added the GObject binding directory
1477         with the other gtk directories (and fixed typo).
1478
1479 2010-10-18  David Levin  <levin@chromium.org>
1480
1481         Reviewed by Oliver Hunt.
1482
1483         check-webkit-style needs to ignore underscores in opcode names and vm_throw
1484         https://bugs.webkit.org/show_bug.cgi?id=47789
1485
1486         * Scripts/webkitpy/style/checker.py: Added the exception for the assembler directory.
1487         * Scripts/webkitpy/style/checkers/cpp.py: Added special cased names.
1488         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit tests for the special cases.
1489
1490 2010-10-18  MORITA Hajime  <morrita@google.com>
1491
1492         Reviewed by Kent Tamura.
1493
1494         TextInputController.hasSpellingMarkers() should be owned by LayoutTestController
1495         https://bugs.webkit.org/show_bug.cgi?id=47659
1496         
1497         Moved hasSpellingMarkers() from TextInputController to
1498         LayoutTestController.  Currently the implementation is available
1499         only for Mac and for Chromium.
1500
1501         * DumpRenderTree/LayoutTestController.cpp:
1502         (hasSpellingMarkerCallback):
1503         (LayoutTestController::staticFunctions):
1504         * DumpRenderTree/LayoutTestController.h:
1505         * DumpRenderTree/chromium/LayoutTestController.cpp:
1506         (LayoutTestController::LayoutTestController):
1507         (LayoutTestController::hasSpellingMarker):
1508         * DumpRenderTree/chromium/LayoutTestController.h:
1509         * DumpRenderTree/chromium/TextInputController.cpp:
1510         (TextInputController::TextInputController):
1511         (TextInputController::makeAttributedString):
1512         * DumpRenderTree/chromium/TextInputController.h:
1513         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1514         (LayoutTestController::hasSpellingMarker):
1515         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1516         (LayoutTestController::hasSpellingMarker):
1517         * DumpRenderTree/mac/TextInputController.m:
1518         (+[TextInputController isSelectorExcludedFromWebScript:]):
1519         (+[TextInputController webScriptNameForSelector:]):
1520         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1521         (LayoutTestController::hasSpellingMarker):
1522         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1524         (LayoutTestController::hasSpellingMarker):
1525         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1526         (LayoutTestController::hasSpellingMarker):
1527
1528 2010-10-18  Adam Barth  <abarth@webkit.org>
1529
1530         Reviewed by David Levin.
1531
1532         commit-queue's flaky test notice is very Pythony
1533         https://bugs.webkit.org/show_bug.cgi?id=47790
1534
1535         This patch make the list of tests delimted by \n instead of just
1536         converting the array to a string.
1537
1538         * Scripts/webkitpy/tool/commands/queues.py:
1539         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1540
1541 2010-10-14  Antonio Gomes  <agomes@rim.com>
1542
1543         Reviewed by Martin Robinson and Xan Lopez.
1544
1545         [Gtk]: DRT does not support frame flattening testing
1546         https://bugs.webkit.org/show_bug.cgi?id=38650
1547
1548         Implement DRT's support for toggling on/off frame flattening
1549         support.
1550
1551         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1552         (resetDefaultsToConsistentValues):
1553         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1554         (LayoutTestController::setFrameFlatteningEnabled):
1555
1556 2010-10-15  Dirk Pranke  <dpranke@chromium.org>
1557
1558         Reviewed by Eric Siedel.
1559
1560         mocktool.MockOptions is inheriting from Mock, which has the side
1561         effect of defaulting any attribute to another MockObject. So,
1562         MockOptions().foo would always evaluate to true. This was
1563         covering over bugs in the unit tests, and is probably the wrong
1564         default behavior for anything attempting to mock out the options
1565         argument returned from optparse.parse_args().
1566
1567         This patch changes the default behavior. The new MockOptions()
1568         class takes an optional list of keyword parameters to set; this
1569         patch doesn't use that feature but the fix for bug 47510 will.
1570
1571         Also, this patch just fills in the default values necessary to
1572         get all of the tests to pass; I didn't stare at each test by
1573         hand to determine the "right" values. We can either fix that in
1574         subsequent patches or let me know if we want to do that now (and
1575         give me some guidance on what those values might want to be).
1576
1577         https://bugs.webkit.org/show_bug.cgi?id=47709
1578
1579         * Scripts/webkitpy/tool/commands/commandtest.py:
1580         * Scripts/webkitpy/tool/commands/download_unittest.py:
1581         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1582         * Scripts/webkitpy/tool/mocktool.py:
1583         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1584         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1585
1586 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1587
1588         Fix the build; need to add new slot to PageUIClient callbacks.
1589
1590         * MiniBrowser/mac/BrowserWindowController.m:
1591         (-[BrowserWindowController awakeFromNib]):
1592         * WebKitTestRunner/TestController.cpp:
1593         (WTR::createOtherPage):
1594         (WTR::TestController::initialize):
1595
1596 2010-10-15  Simon Fraser  <simon.fraser@apple.com>
1597
1598         Add Matt Delaney to committers.py.
1599
1600         * Scripts/webkitpy/common/config/committers.py:
1601
1602 2010-10-15  Tony Chang  <tony@chromium.org>
1603
1604         Reviewed by Kent Tamura.
1605
1606         [chromium] compile TestNetscapePlugIn on Chromium mac
1607         https://bugs.webkit.org/show_bug.cgi?id=47633
1608
1609         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1610         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1611         (NP_GetEntryPoints):
1612         (NPP_New):
1613         (NPP_Destroy):
1614         (NPP_HandleEvent):
1615         (NPP_GetValue):
1616         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1617         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1618         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1619
1620 2010-10-15  Leandro Pereira  <leandro@profusion.mobi>
1621
1622         Reviewed by Gustavo Noronha Silva.
1623
1624         build-webkit: Should die when make fails when build a CMake project
1625         https://bugs.webkit.org/show_bug.cgi?id=47726
1626
1627         * Scripts/webkitdirs.pm: If make fails, die immediately.
1628
1629 2010-10-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1630
1631         Unreviewed, rolling out r69809.
1632         http://trac.webkit.org/changeset/69809
1633         https://bugs.webkit.org/show_bug.cgi?id=47725
1634
1635         Broke chromium mac compile (Requested by japhet on #webkit).
1636
1637         * DumpRenderTree/DumpRenderTree.gypi:
1638         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1639         (NP_GetEntryPoints):
1640         (NPP_New):
1641         (NPP_Destroy):
1642         (NPP_HandleEvent):
1643         (NPP_GetValue):
1644         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
1645         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
1646         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
1647
1648 2010-10-15  Adam Barth  <abarth@webkit.org>
1649
1650         Reviewed by Adam Barth.
1651
1652         test-webkitpy fails on Linux
1653         https://bugs.webkit.org/show_bug.cgi?id=47713
1654
1655         The old code failed on Linux because the MacPort tries to read
1656         something out of platform that doesn't make sense on Linux.
1657
1658         * Scripts/webkitpy/tool/mocktool.py:
1659
1660 2010-10-14  Balazs Kelemen  <kbalazs@webkit.org>
1661
1662         Reviewed by Kenneth Rohde Christiansen.
1663
1664         [Qt] WTR is sloooow
1665         https://bugs.webkit.org/show_bug.cgi?id=47695
1666
1667         * WebKitTestRunner/qt/TestControllerQt.cpp:
1668         Change the timer interval of RunUntilConditionLoop from
1669         50 milliseconds to 1 to avoid wasting time after the 
1670         test had been finished.
1671
1672 2010-10-14  Eric Seidel  <eric@webkit.org>
1673
1674         Unreviewed, just fixing an exception seen on the commit-queue.
1675
1676         I should have unit tested this function before.
1677
1678         * Scripts/webkitpy/tool/commands/queues.py:
1679         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1680
1681 2010-10-14  Eric Seidel  <eric@webkit.org>
1682
1683         Reviewed by Adam Barth.
1684
1685         commit-queue should not fail patches due to flaky tests
1686         https://bugs.webkit.org/show_bug.cgi?id=47647
1687
1688         This patch makes it so that the *same* flaky test has to fail
1689         twice in a row to have a false negative from a flaky test.
1690
1691         If different flaky tests fail (or if a test fails and then passes
1692         in a second run) then we will warn in the bug that we encountered
1693         a flaky test.
1694
1695         This patch grew to include moving port off of steps onto tool
1696         (which Adam wrote and then I integrated), as well as removing the
1697         use of tool from CommitQueueTask.
1698
1699         * Scripts/webkitpy/common/config/ports.py:
1700          - Added a layout_test_results_path method.  This covers old-run-webkit-tests
1701            but doesn't cover NRWT.  This is probably not the long term solution, but
1702            putting this knowledge on port makes more sense than in LayoutTestResults.
1703         * Scripts/webkitpy/common/net/buildbot.py:
1704          - LayoutTestResults shouldn't know how to fetch from the network, make
1705            the Build code do that instead.
1706         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1707          - Code style fix.
1708         * Scripts/webkitpy/common/net/layouttestresults.py:
1709          - Remove code for reading from the network.
1710         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1711          - Test the new entrypoint.
1712         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1713          - Make the delegate interface explicit.
1714          - Remove the _tool member, since using the delegate for
1715            everything is cleaner.
1716          - Teach the testing logic how to deal with flaky tests.
1717         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1718          - Update to match the CommitQueueTask changes.
1719         * Scripts/webkitpy/tool/commands/queues.py:
1720          - Use the new CommitQueueTaskDelegate interface.
1721         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1722          - Fix the SecondThoughtsCommitQueue test which was broken.
1723          - Add a new test to make sure the flaky test reporting works.
1724         * Scripts/webkitpy/tool/main.py:
1725          - Store the port on the tool object.
1726         * Scripts/webkitpy/tool/mocktool.py:
1727          - Add a port() accessor to MockTool
1728         * Scripts/webkitpy/tool/steps/abstractstep.py:
1729          - Move port() off of Step and onto Tool.
1730         * Scripts/webkitpy/tool/steps/build.py:
1731         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1732         * Scripts/webkitpy/tool/steps/runtests.py:
1733         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1734          - Two tests with the same name!  only the latter was being run.
1735         * Scripts/webkitpy/tool/steps/update.py:
1736
1737 2010-10-14  Dirk Pranke  <dpranke@chromium.org>
1738
1739         Reviewed by Eric Seidel.
1740
1741         new-run-webkit-tests will now handle missing Ruby installs (or
1742         missing PrettyPatch scripts) more cleanly - previously this
1743         would be detected when we actually tried to create the diff, and
1744         the error message was obscure. Now we'll log a warning up front
1745         and otherwise be silent.
1746
1747         This change also refactors some global variables to be class or
1748         instance variables to be slightly more testable and more
1749         modular. There are no cases where we create lots of port objects
1750         and can't afford to test for configurations repeatedly, so
1751         there's no performance concern here.
1752
1753         https://bugs.webkit.org/show_bug.cgi?id=47466
1754
1755         * Scripts/webkitpy/layout_tests/port/base.py:
1756         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1757         * Scripts/webkitpy/layout_tests/port/chromium.py:
1758
1759 2010-10-08  Martin Robinson  <mrobinson@igalia.com>
1760
1761         Reviewed by Xan Lopez.
1762
1763         [GTK] Form controls do not respect GTK+ font size
1764         https://bugs.webkit.org/show_bug.cgi?id=47134
1765
1766         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1767         (initializeGtkFontSettings): Initialize the font control size when running
1768         DumpRenderTree to a standard value.
1769
1770 2010-10-14  Tony Chang  <tony@chromium.org>
1771
1772         Reviewed by Kent Tamura.
1773
1774         [chromium] compile TestNetscapePlugIn on Chromium mac
1775         https://bugs.webkit.org/show_bug.cgi?id=47633
1776
1777         * DumpRenderTree/DumpRenderTree.gypi: files to compile
1778         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Use ifdef because gcc was complaining
1779         (NP_GetEntryPoints):
1780         (NPP_New):
1781         (NPP_Destroy):
1782         (NPP_HandleEvent):
1783         (NPP_GetValue):
1784         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Added.
1785         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Added.
1786         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Added.
1787
1788 2010-10-14  Victor Wang  <victorw@chromium.org>
1789
1790         Reviewed by Nate Chapin.
1791
1792         [Chromium] Fix rebaseline_chromium_webkit_tests to use 0 tolerance image diff.
1793
1794         https://bugs.webkit.org/show_bug.cgi?id=47686
1795
1796         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1797
1798 2010-10-14  Eric Seidel  <eric@webkit.org>
1799
1800         Reviewed by Adam Barth.
1801
1802         test-webkitpy spews Delegate terminated queue messages
1803         https://bugs.webkit.org/show_bug.cgi?id=47678
1804
1805         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1806
1807 2010-10-14  Adam Roben  <aroben@apple.com>
1808
1809         Test that pressing the Alt key generates a WM_SYSCOMMAND message
1810
1811         Test for <http://webkit.org/b/47671> <rdar://problem/8435594> Pressing
1812         the Alt key when MiniBrowser's WKView is focused doesn't send focus to
1813         the menu bar
1814
1815         Reviewed by Steve Falkenburg.
1816
1817         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added
1818         TestWebKitAPI/win to the include path so that WindowMessageObserver
1819         can be found.
1820
1821         * TestWebKitAPI/PlatformWebView.h: Added simulateAltKeyPress and
1822         Windows-specific members.
1823         (TestWebKitAPI::PlatformWebView::setParentWindowMessageObserver):
1824         Added this simple setter.
1825
1826         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp: Added.
1827         (TestWebKitAPI::WMSysCommandObserver::WMSysCommandObserver):
1828         Initialize our lone data member.
1829         (TestWebKitAPI::WMSysCommandObserver::windowDidReceiveWMSysCommand):
1830         Simple getter.
1831         (TestWebKitAPI::WMSysCommandObserver::windowReceivedMessage): Record
1832         when a WM_SYSCOMMAND message is received.
1833         (TestWebKitAPI::didNotHandleKeyEventCallback): Record when a
1834         WM_SYSKEYUP message is not handled.
1835         (TestWebKitAPI::WebKit2_AltKeyGeneratesWMSysCommand): Simulate
1836         pressing the Alt key and check that a WM_SYSCOMMAND message got sent
1837         to the WKView's parent window.
1838
1839         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1840         (TestWebKitAPI::PlatformWebView::registerWindowClass): Made this a
1841         member function so it could access PlatformWebView::wndProc. Use
1842         PlatformWebView::wndProc as the WNDPROC.
1843         (TestWebKitAPI::PlatformWebView::PlatformWebView): Initialize our new
1844         data member and pass the this pointer to CreateWindowEx so we can
1845         store it on the HWND.
1846         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Moved some
1847         constants from here to the top of the file.
1848         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress): Added. Sends
1849         the same messages that Notepad receives when you press the Alt key.
1850         (TestWebKitAPI::PlatformWebView::wndProc): Added.
1851           - When WM_CREATE is received, we set the PlatformWebView instance
1852             pointer as a property on the HWND so we can access it later.
1853           - For other messages, we try to get the PlatformWebView instance
1854             pointer from the HWND property.
1855           - When WM_NCDESTROY is received (which is the last message we will
1856             receive), we remove the PlatformWebView instance property.
1857           - Pass messages to the parent window's message observer, if there is
1858             one.
1859           - Pass all messages through to ::DefWindowProcW.
1860
1861         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added WindowMessageObserver
1862         and AltKeyGeneratesWMSysCommand.
1863
1864         * TestWebKitAPI/win/WindowMessageObserver.h: Added. This class can be
1865         used to observe messages sent to one or more windows.
1866
1867 2010-10-01  Martin Robinson  <mrobinson@igalia.com>
1868
1869         Reviewed by Holger Freyther.
1870
1871         [GTK] REGRESSION: FreeType backend does not respect XSettings font settings after r68558
1872         https://bugs.webkit.org/show_bug.cgi?id=47033
1873
1874         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1875         (initializeGtkFontSettings): Added this method which initializes XSettings
1876         font settings to consistent values before running a test. For the one test
1877         in which we need subpixel aliasing turned on, do that.
1878         (initializeFonts): Accepts a testURL parameter now and delegates to initializeGtkFontSettings.
1879         (runTest): Pass the testURL to initializeFonts.
1880
1881 2010-10-14  Adam Barth  <abarth@webkit.org>
1882
1883         Reviewed by Eric Seidel.
1884
1885         ChromiumXVFBPort.run_webkit_tests_command has infinite recursion
1886         https://bugs.webkit.org/show_bug.cgi?id=47655
1887
1888         * Scripts/webkitpy/common/config/ports.py:
1889         * Scripts/webkitpy/common/config/ports_unittest.py:
1890
1891 2010-10-13  Eric Seidel  <eric@webkit.org>
1892
1893         Reviewed by Adam Barth.
1894
1895         beat diff_parser with the ugly stick
1896         https://bugs.webkit.org/show_bug.cgi?id=47626
1897
1898         * Scripts/webkitpy/common/checkout/diff_parser.py:
1899         * Scripts/webkitpy/style/patchreader.py:
1900         * Scripts/webkitpy/style/patchreader_unittest.py:
1901
1902 2010-10-13  Eric Seidel  <eric@webkit.org>
1903
1904         Reviewed by Adam Barth.
1905
1906         Break LayoutTestResults out into its own file
1907         https://bugs.webkit.org/show_bug.cgi?id=47637
1908
1909         * Scripts/webkitpy/common/net/buildbot.py:
1910         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1911         * Scripts/webkitpy/common/net/layouttestresults.py: Added.
1912         * Scripts/webkitpy/common/net/layouttestresults_unittest.py: Added.
1913
1914 2010-10-13  Adam Barth  <abarth@webkit.org>
1915
1916         Unreviewed.
1917
1918         Chromium port can't run JavaScriptCore tests
1919         https://bugs.webkit.org/show_bug.cgi?id=47654
1920
1921         This lets webkit-patch build-and-test work on Chromium.
1922
1923         * Scripts/webkitpy/common/config/ports.py:
1924         * Scripts/webkitpy/tool/steps/runtests.py:
1925
1926 2010-10-13  Adam Barth  <abarth@webkit.org>
1927
1928         Reviewed by Eric Seidel.
1929
1930         Make --port a global option and pass the port information to the commit-queue subprocess
1931         https://bugs.webkit.org/show_bug.cgi?id=47650
1932
1933         This patch paves the way to run the commit-queue on a non-Mac port.
1934
1935         * Scripts/webkitpy/tool/commands/queues.py:
1936         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1937         * Scripts/webkitpy/tool/commands/queuestest.py:
1938         * Scripts/webkitpy/tool/main.py:
1939         * Scripts/webkitpy/tool/steps/options.py:
1940         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1941         * Scripts/webkitpy/tool/steps/runtests.py:
1942         * Scripts/webkitpy/tool/steps/update.py:
1943
1944 2010-10-13  Adam Barth  <abarth@webkit.org>
1945
1946         Reviewed by Eric Seidel.
1947
1948         Introduce the ChromiumXVFBPort for running commit-queue on EC2
1949         https://bugs.webkit.org/show_bug.cgi?id=47653
1950
1951         I'm not entirely sure this is the best way to do this, but we need to
1952         run the tests under XVFB on EC2 because the EC2 instances don't have a
1953         real monitor hooked up.  This patch adds a ChromiumXVFBPort that runs
1954         that way.  The idea is that XVFB is like a platform for the Chromium
1955         port, but we don't have a real notion of platform separate from port.
1956
1957         * Scripts/webkitpy/common/config/ports.py:
1958
1959 2010-10-13  Sergio Villar Senin  <svillar@igalia.com>
1960
1961         Reviewed by Martin Robinson.
1962
1963         [GTK] Add HTTP caching support
1964         https://bugs.webkit.org/show_bug.cgi?id=44261
1965
1966         Add include paths for the new soup HTTP cache code.
1967
1968         * GNUmakefile.am: Add paths for the new soup HTTP cache code.
1969
1970 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1971
1972         Reviewed by Antonio Gomes.
1973
1974         [Qt] QtTestBrowser shows two Url input fields
1975         https://bugs.webkit.org/show_bug.cgi?id=47613
1976
1977         * QtTestBrowser/mainwindow.cpp:
1978         (MainWindow::MainWindow):
1979         (MainWindow::buildUI):
1980
1981 2010-10-13  Yi Shen  <yi.4.shen@nokia.com>
1982
1983         Reviewed by Tony Chang.
1984
1985         [gdb] Add pretty-print supports for UString, Identifier and JSString
1986         https://bugs.webkit.org/show_bug.cgi?id=47601
1987
1988         * gdb/webkit.py:
1989
1990 2010-10-13  Adam Barth  <abarth@webkit.org>
1991
1992         Reviewed by Eric Seidel.
1993
1994         Add list of Ubuntu packages needed by the EWS bots
1995         https://bugs.webkit.org/show_bug.cgi?id=47628
1996
1997         I've been copy/pasting this list between bots, but it's better to have
1998         this checked in.
1999
2000         * EWSTools/ubuntu-ews-packages: Added.
2001
2002 2010-10-13  Leandro Pereira  <leandro@profusion.mobi>
2003
2004         Reviewed by Csaba Osztrogonác.
2005
2006         [EFL] Adds a build slave.
2007         https://bugs.webkit.org/show_bug.cgi?id=47290
2008
2009         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2010         entry for a release build of the EFL port.
2011         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2012         flag to build the EFL port.
2013
2014 2010-10-13  Adam Barth  <abarth@webkit.org>
2015
2016         Reviewed by Csaba Osztrogonác.
2017
2018         webkit-patch build shouldn't need --build to actually build!
2019         https://bugs.webkit.org/show_bug.cgi?id=47438
2020
2021         Yeah, requiring --build for the build command is really dumb.  We did
2022         this originally because the build step is usually optional in other
2023         commands.  We don't have a good way of reversing the default for an
2024         option in one command.  This approach is slightly hacky since --build
2025         still shows up as an option on the help page, but at least it makes
2026         progress.  Passing --build is harmless, so the EWS bots shouldn't
2027         explode because of this change.
2028
2029         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2030         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2031         * Scripts/webkitpy/tool/commands/download.py:
2032         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2033         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2034
2035 2010-10-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2036
2037         Unreviewed, rolling out r69638.
2038         http://trac.webkit.org/changeset/69638
2039         https://bugs.webkit.org/show_bug.cgi?id=47595
2040
2041         "Broke win and chromium-win bots" (Requested by dglazkov on
2042         #webkit).
2043
2044         * Scripts/webkitpy/common/system/path.py:
2045         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2046         * Scripts/webkitpy/layout_tests/port/base.py:
2047         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2048         * Scripts/webkitpy/layout_tests/port/chromium.py:
2049         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2050
2051 2010-10-13  John Knottenbelt  <jknotten@chromium.org>
2052
2053         Reviewed by Steve Block.
2054
2055         First step towards client-based Geolocation in Chromium. Build
2056         fixes for CLIENT_BASED_GEOLOCATION preprocessor feature define.
2057         https://bugs.webkit.org/show_bug.cgi?id=47586
2058
2059         * DumpRenderTree/chromium/WebViewHost.cpp:
2060         * DumpRenderTree/chromium/WebViewHost.h:
2061
2062 2010-10-13  Adam Roben  <aroben@apple.com>
2063
2064         Test that pressing the spacebar in a text field does not scroll the
2065         document
2066
2067         Test for <http://webkit.org/b/47544> <rdar://problem/8540645>
2068         REGRESSION: Pressing spacebar in a text field in WebKit2 does not
2069         insert a space, scrolls the page instead
2070
2071         Reviewed by Sam Weinig.
2072
2073         * TestWebKitAPI/PlatformUtilities.h: Added isKeyDown.
2074
2075         * TestWebKitAPI/PlatformWebView.h: Added simulateSpacebarKeyPress.
2076
2077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2078         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2079         * TestWebKitAPI/win/copy-resources.cmd:
2080         Added new files.
2081
2082         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: Added.
2083         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext):
2084         We use this to track what the result of calling into JavaScript was.
2085         (TestWebKitAPI::didFinishLoadForFrame): Records when the page
2086         finishes loading.
2087         (TestWebKitAPI::didNotHandleKeyEventCallback): Records when a key down
2088         event is not handled.
2089         (TestWebKitAPI::javaScriptCallback): Records that JavaScript finished
2090         executing and whether the result matched our expectation.
2091         (TestWebKitAPI::wk): Turns a UTF-8 C string into a WKStringRef.
2092         (TestWebKitAPI::runJSTest): Calls into JS, waits for the call to
2093         complete, and returns whether we got back the expected result.
2094         (TestWebKitAPI::WebKit2_SpacebarScrolling): Tests that pressing
2095         spacebar inside a text field does not scroll the document and that
2096         pressing it outside the text field does scroll the document.
2097
2098         * TestWebKitAPI/Tests/WebKit2/spacebar-scrolling.html: Added.
2099
2100         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2101         (TestWebKitAPI::Util::isKeyDown): Checks the event's type.
2102
2103         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2104         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Copied
2105         code from DRT's EventSendingController.
2106
2107         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2108         (TestWebKitAPI::Util::isKeyDown): Checks the message's type.
2109
2110         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2111         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Send the
2112         same messages that get sent when you press spacebar in Notepad.
2113
2114 2010-10-13  Adam Roben  <aroben@apple.com>
2115
2116         Fix a couple of issues with the TestWebKitAPI build
2117
2118         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops:
2119         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2120         Fixed a typo.
2121
2122         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Use common.vsprops
2123         to set our output and intermediate directories so that we don't spew
2124         files into the source tree.
2125
2126 2010-10-13  Balazs Kelemen  <kbalazs@webkit.org>
2127
2128         Reviewed by Csaba Osztrogonác.
2129
2130         WTR should accept relative paths
2131         https://bugs.webkit.org/show_bug.cgi?id=47486
2132
2133         * WebKitTestRunner/StringFunctions.h:
2134         * WebKitTestRunner/TestInvocation.cpp:
2135         (WTR::createWKURL): Moved from StringFunctions.h since it is
2136         used only here. Extend relative paths to absolute.
2137
2138 2010-10-12  Adam Roben  <aroben@apple.com>
2139
2140         Make TestWebKitAPI work on Windows
2141
2142         Fixes <http://webkit.org/b/47552> <rdar://problem/8541708>.
2143
2144         Reviewed by Sam Weinig.
2145
2146         * Scripts/build-api-tests: Build TestWebKitAPI.sln on Windows.
2147
2148         * Scripts/run-api-tests: Fix the PATH so that TestWebKitAPI can be
2149         run on Windows.
2150         (runTest): Added code to run TestWebKitAPI.exe on Windows and to die
2151         on unsupported platforms.
2152         (populateTests): Added code to run TestWebKitAPI.exe on Windows and to
2153         die on other platforms. Extracted some formerly-Mac-specific code to
2154         be cross-platform and made it handle any style of line-endings.
2155
2156         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added.
2157         Links against CFLite.
2158
2159         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added.
2160         Contains most properties for the project.
2161
2162         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops:
2163         Added. Links against CoreFoundation.
2164
2165         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added a Windows-specific
2166         section and moved the cross-platform section after the
2167         platform-specific parts.
2168
2169         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Added.
2170         (TestWebKitAPI::Util::run): Runs a normal message pump until we're
2171         done.
2172         (TestWebKitAPI::Util::cf): Turns a UTF-8 C string into a CFString.
2173         (TestWebKitAPI::Util::createURLForResource): Uses CFBundle to get the
2174         resource path.
2175         (TestWebKitAPI::Util::URLForNonExistentResource): Creates a bogus
2176         WKURL.
2177
2178         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Added.
2179         (TestWebKitAPI::registerWindowClass):
2180         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2181         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2182         (TestWebKitAPI::PlatformWebView::page):
2183         This was mostly copied from WebKitTestRunner's PlatformWebView.
2184
2185         * TestWebKitAPI/win/TestWebKitAPI.sln: Added. Builds both
2186         TestWebKitAPI and TestWebKitAPIGeneratd. This is used by the
2187         build-api-tests script.
2188
2189         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added. Builds
2190         TestWebKitAPI.exe.
2191
2192         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added. Just calls
2193         through to copy-resources.cmd.
2194
2195         * TestWebKitAPI/win/copy-resources.cmd: Added. Copies resources into
2196         or deletes resources from TestWebKitAPI.resources.
2197
2198         * TestWebKitAPI/win/main.cpp: Added.
2199         (main): Calls through to TestsController.
2200
2201 2010-10-13  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2202
2203         Reviewed by Kenneth Rohde Christiansen.
2204
2205         [EFL] Support viewport configuration and add new arguments for WebKit EFL
2206         https://bugs.webkit.org/show_bug.cgi?id=47084
2207
2208         Opera spec regarding to viewport meta tag was adjusted to WebCore. So, EFL port
2209         needs to be modified according to the changes.
2210
2211         * EWebLauncher/main.c:
2212         (on_viewport_changed):
2213
2214 2010-10-12  Dirk Pranke  <dpranke@chromium.org>
2215
2216         Reviewed by Eric Seidel.
2217
2218         This patch enables new-run-webkit-tests (in particular the
2219         chromium-win port) to run under Cygwin as well as Win32. Mostly
2220         this just required some conversions from cygwin paths to Win32
2221         paths when we spawn off Win32 binaries like test_shell.
2222
2223         https://bugs.webkit.org/show_bug.cgi?id=47220
2224
2225         * Scripts/webkitpy/common/system/path.py:
2226         - Expose the cygpath() function for path conversion
2227
2228         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2229         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2230         - shift filename->uri conversion in the TestInfo objects to the
2231           dump_render_tree thread
2232
2233         * Scripts/webkitpy/layout_tests/port/base.py:
2234         * Scripts/webkitpy/layout_tests/port/chromium.py:
2235         - use cygpath()
2236
2237 2010-10-12  Yuta Kitamura  <yutak@chromium.org>
2238
2239         Unreviewed. Add Yuta Kitamura (yutak) to the committers list.
2240
2241         * Scripts/webkitpy/common/config/committers.py:
2242
2243 2010-10-12  Sam Weinig  <sam@webkit.org>
2244
2245         Reviewed by Dan Bernstein.
2246
2247         When a provisional load fails, the provisional URL returned
2248         from WKFrameCopyProvisionalURL should be empty
2249         <rdar://problem/8540878>
2250         https://bugs.webkit.org/show_bug.cgi?id=47546
2251
2252         Add test.
2253
2254         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2255         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2256
2257 2010-10-12  Anders Carlsson  <andersca@apple.com>
2258
2259         Reviewed by Sam Weinig.
2260
2261         Start fleshing out find page overlays
2262         https://bugs.webkit.org/show_bug.cgi?id=47559
2263
2264         * MiniBrowser/mac/BrowserWindowController.m:
2265         (-[BrowserWindowController find:]):
2266         Pass kWKFindOptionsShowOverlay to WKPageFindString.
2267
2268 2010-10-12  Robert Hogan  <robert@webkit.org>
2269
2270         Reviewed by Antonio Gomes.
2271
2272         [Qt] editing/input/emacs-ctrl-o.html
2273
2274         ctrl-o is bound to a sequence of commands on Mac, namely:
2275         insertParagraphSeparator then moveLeft. In the DRT, we just interpret
2276         ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a
2277         result we only issue one command, so don't generate the change in caret
2278         position that results in the extra editing delegate messages.
2279
2280         So for the sake of not managing suspicious-looking differences, just
2281         make DRT issue the appropriate edit commands to pass the test.
2282
2283         https://bugs.webkit.org/show_bug.cgi?id=47548
2284
2285         * DumpRenderTree/qt/EventSenderQt.cpp:
2286         (EventSender::keyDown):
2287
2288 2010-10-12  Anders Carlsson  <andersca@apple.com>
2289
2290         Reviewed by Sam Weinig.
2291
2292         Add a simple Find UI to MiniBrowser
2293         https://bugs.webkit.org/show_bug.cgi?id=47553
2294
2295         * MiniBrowser/mac/BrowserWindow.xib:
2296         Add Find panel.
2297
2298         * MiniBrowser/mac/BrowserWindowController.h:
2299         * MiniBrowser/mac/BrowserWindowController.m:
2300         (-[BrowserWindowController performFindPanelAction:]):
2301         Show the find panel.
2302
2303         (-[BrowserWindowController find:]):
2304         Tell the WKPageRef to find the given string.
2305
2306 2010-10-12  Tony Chang  <tony@chromium.org>
2307
2308         Unreviewed, fixing DRT compile on Windows after r69586.
2309
2310         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
2311
2312 2010-10-12  Tony Chang  <tony@chromium.org>
2313
2314         Unreviewed, trying to fix NRWT on Windows.
2315
2316         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2317
2318 2010-10-12  Balazs Kelemen  <kbalazs@webkit.org>
2319
2320         Reviewed by Kenneth Rohde Christiansen.
2321
2322         [Qt][WTR] Checking the path of the injected bundle is bogus
2323         https://bugs.webkit.org/show_bug.cgi?id=47541
2324
2325         * WebKitTestRunner/qt/TestControllerQt.cpp:
2326         (WTR::isExistingLibrary): Added (static helper).
2327         Extend the path with the appropriate suffix(es) on the
2328         platform and check that the file exists.
2329         (WTR::TestController::initializeInjectedBundlePath):
2330         There were two bugs with the path checking:
2331             - the condition should have been inverted
2332             - QLibrary::fileName does not give back the filename
2333               with the library suffix so we cannot check
2334               that existance of the file this way.
2335
2336 2010-10-12  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2337
2338         Reviewed by Tony Chang.
2339
2340         Implement http locking in NRWT.
2341         https://bugs.webkit.org/show_bug.cgi?id=47072
2342
2343         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2344         * Scripts/webkitpy/layout_tests/port/base.py:
2345         * Scripts/webkitpy/layout_tests/port/http_lock.py: Added.
2346         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py: Added.
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2348
2349 2010-10-12  Mark Rowe  <mrowe@apple.com>
2350
2351         Fix the 32-bit WebKit2 build.
2352
2353         * MiniBrowser/mac/BrowserWindowController.m:
2354         (getWindowFrame): Use NSRect rather than CGRect since that's what -frame returns.
2355         (setWindowFrame): Use NSMakeRect rather than CGRectMake since that's what -setFrame:display: expects.
2356
2357 2010-10-11  Tony Chang  <tony@chromium.org>
2358
2359         Reviewed by Adam Barth.
2360
2361         change the order of mrobinson's email addresses so bugs.webkit.org suggests the right one
2362         https://bugs.webkit.org/show_bug.cgi?id=47513
2363
2364         bugs.webkit.org suggests mrobinson@igalia.com as an autocomplete,
2365         which doesn't actually work.
2366
2367         * Scripts/webkitpy/common/config/committers.py:
2368
2369 2010-10-11  Prasad Tammana  <prasadt@chromium.org>
2370
2371         Reviewed by Dmitry Titov.
2372
2373         Added support for showModalDialog on chromium port.
2374
2375         Implement showModalDialog for Layout tests for chromium port
2376         https://bugs.webkit.org/show_bug.cgi?id=46759
2377
2378         * DumpRenderTree/chromium/WebViewHost.cpp:
2379         (WebViewHost::closeWidgetSoon): Quit current message loop if in a modal loop.
2380         (WebViewHost::runModal):  Start a nested message loop and remember that.
2381         (WebViewHost::WebViewHost):  Initialize m_inModalLoop.
2382         * DumpRenderTree/chromium/WebViewHost.h:  Add m_inModalLoop.
2383
2384 2010-10-11  Martin Robinson  <mrobinson@igalia.com>
2385
2386         Reviewed by Gustavo Noronha Silva.
2387
2388         [GTK] Cleanup font selection code for the Freetype backend
2389         https://bugs.webkit.org/show_bug.cgi?id=47503
2390
2391         Update DRT to set values for the cursive and fantasy font families, so
2392         that we can generate consistent results for tests that use these families.
2393         Add some missing information to fonts.conf.
2394
2395         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2396         (resetDefaultsToConsistentValues): Always set the fantasy and cursive font
2397         family names.
2398         * DumpRenderTree/gtk/fonts/fonts.conf: Add aliases for cursive and fantasy fonts
2399         to our default serif font. Eventually we may want to import or require some "real"
2400         fonts, but this should at least ensure consistent rendering during test runs. Also
2401         add aliases for some other commonly used fonts in tests (Arial and Lucida Grande).
2402         Finally, add a missing oblique specification for DejaVu Serif, which was resulting
2403         in some incorrect baselines for the synthetic oblique test.
2404
2405 2010-10-11  Adam Barth  <abarth@webkit.org>
2406
2407         Unreviewed.
2408
2409         Fix sheriffbot not to crash when there are failing tests.  It turns out
2410         Python sets don't support the + operator.  We need to use union
2411         instead.  There's a more elegant way to do this in Python 2.6, but we
2412         need this code to work in 2.5.
2413
2414         * Scripts/webkitpy/common/net/failuremap.py:
2415         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2416
2417 2010-10-10  Robert Hogan  <robert@webkit.org>
2418
2419         Unreviewed, fix failing test from r69468.
2420
2421         [Qt] Put all DRT-created pages in a page group
2422
2423         Fix on r69468.
2424
2425         Because we don't delete closed pages immediately in DRT we need
2426         to remove them from the page group explicitly instead.
2427
2428         Fixes failure of fast/events/popup-blocked-from-fake-user-gesture.html
2429
2430         https://bugs.webkit.org/show_bug.cgi?id=47469
2431
2432         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2433         (WebCore::DumpRenderTree::windowCloseRequested):
2434
2435 2010-10-10  Leandro Pereira  <leandro@profusion.mobi>
2436
2437         Reviewed by Adam Barth.
2438
2439         commit-queue: Add EFL-EWS status bubble to Bugzilla, now that the
2440         EFL-EWS bot is up and running.
2441         https://bugs.webkit.org/show_bug.cgi?id=47277
2442
2443         * QueueStatusServer/handlers/statusbubble.py:
2444
2445 2010-10-10  Robert Hogan  <robert@webkit.org>
2446
2447         Reviewed by Antonio Gomes.
2448
2449         [Qt] Put all DRT-created pages in a page group
2450
2451         https://bugs.webkit.org/show_bug.cgi?id=47469
2452
2453         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2454         (WebCore::DumpRenderTree::DumpRenderTree):
2455         (WebCore::DumpRenderTree::createWindow):
2456
2457 2010-10-09  Sam Weinig  <sam@webkit.org>
2458
2459         Reviewed by Dan Bernstein.
2460
2461         WKFrameGetFrameLoadState() returns kWKFrameLoadStateCommitted after the load has been stopped
2462         <rdar://problem/8173667>
2463         https://bugs.webkit.org/show_bug.cgi?id=47461
2464
2465         * TestWebKitAPI/PlatformUtilities.h:
2466         * TestWebKitAPI/Test.h:
2467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2468         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp: Added.
2469         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2470         (TestWebKitAPI::TEST):
2471         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2472         (TestWebKitAPI::Util::URLForNonExistentResource):
2473         Adds a test for the frame load state after a failed provisional load. I wanted to test
2474         the frame load state after a committed load failed, but I don't believe that is possible
2475         to do without hooking up the http server to serve a long loading page.
2476
2477 2010-10-09  Sam Weinig  <sam@webkit.org>
2478
2479         Reviewed by Dan Bernstein.
2480
2481         Add WebKit2 version of runBeforeUnloadConfirmPanelWithMessage
2482         <rdar://problem/8447690>
2483         https://bugs.webkit.org/show_bug.cgi?id=47459
2484
2485         * MiniBrowser/mac/BrowserWindowController.m:
2486         (runBeforeUnloadConfirmPanel):
2487         (-[BrowserWindowController awakeFromNib]):
2488         * WebKitTestRunner/TestController.cpp:
2489         (WTR::createOtherPage):
2490         (WTR::TestController::initialize):
2491
2492 2010-10-09  Sam Weinig  <sam@webkit.org>
2493
2494         Reviewed by Dan Bernstein.
2495
2496         Need implementation of ChromeClient windowRect related functions.
2497         <rdar://problem/8469476>
2498         https://bugs.webkit.org/show_bug.cgi?id=47386
2499
2500         * MiniBrowser/mac/BrowserWindowController.m:
2501         (getWindowFrame):
2502         (setWindowFrame):
2503         (-[BrowserWindowController awakeFromNib]):
2504         * WebKitTestRunner/PlatformWebView.h:
2505         * WebKitTestRunner/TestController.cpp:
2506         (WTR::TestController::initialize):
2507         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2508         (WTR::PlatformWebView::windowFrame):
2509         (WTR::PlatformWebView::setWindowFrame):
2510         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2511         (WTR::PlatformWebView::windowFrame):
2512         (WTR::PlatformWebView::setWindowFrame):
2513         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2514         (WTR::PlatformWebView::windowFrame):
2515         (WTR::PlatformWebView::setWindowFrame):
2516
2517 2010-10-08  Adam Barth  <abarth@webkit.org>
2518
2519         Unreviewed (Eric is on vacation in this change is trivial).
2520
2521         Add a "clean" command to webkit-patch to clean the working directory
2522         https://bugs.webkit.org/show_bug.cgi?id=47436
2523
2524         This command is useful when using SVN because "svn revert" leaves
2525         unversioned files behind.
2526
2527         * Scripts/webkitpy/tool/commands/download.py:
2528
2529 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2530
2531         Unreviewed build fix.
2532
2533         [Qt] Add missing limits.h include since the Qt version currently
2534         ran on the bot does need that.
2535
2536         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2537
2538 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2539
2540         Reviewed by Csaba Osztrogonác.
2541
2542         [Qt] Turn on building WTR
2543         https://bugs.webkit.org/show_bug.cgi?id=47349
2544
2545         * Scripts/webkitdirs.pm:
2546
2547 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2548
2549         Reviewed by Andreas Kling.
2550
2551         [Qt] TestController needs its platform dependent methods
2552         https://bugs.webkit.org/show_bug.cgi?id=47413
2553
2554         * WebKitTestRunner/qt/TestControllerQt.cpp:
2555         (WTR::TestController::initializeInjectedBundlePath):
2556         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
2557         set then use that otherwise use the path where the bundle
2558         lives in a normal trunk build.
2559         (WTR::TestController::initializeTestPluginDirectory):
2560         Set the bundle's value. It is not used currently.
2561         (WTR::TestController::platformInitializeContext):
2562         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2563
2564 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2565
2566         Reviewed by Kenneth Rohde Christiansen.
2567
2568         WTR: Prevent sending the Done message twice on test timeout.
2569         https://bugs.webkit.org/show_bug.cgi?id=47410
2570
2571         When InjectedBundle::done() calls stopLoading, this may trigger
2572         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
2573         InjectedBundle::done() itself later in the stack.
2574         This would output the timeout failure message twice and confuse
2575         the run-webkit-tests script.
2576
2577         This patch adds a third state, Stopping, which prevents WebCore
2578         errors to trigger done() when testing is over.
2579
2580         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2581         (WTR::InjectedBundle::done):
2582         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2583
2584 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2585
2586         Reviewed by Kenneth Rohde Christiansen.
2587
2588         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
2589         Original code by Simon Hausmann.
2590         https://bugs.webkit.org/show_bug.cgi?id=47402
2591
2592         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
2593         (WTR::activateFonts):
2594
2595 2010-10-08  Andras Becsi  <abecsi@webkit.org>
2596
2597         Reviewed by Csaba Osztrogonác.
2598
2599         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
2600         https://bugs.webkit.org/show_bug.cgi?id=47401
2601
2602         * Scripts/build-webkittestrunner:
2603         * Scripts/old-run-webkit-tests:
2604
2605 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2606
2607         Reviewed by Kenneth Rohde Christiansen.
2608
2609         [Qt] WTR first compile: fix compile issues.
2610         https://bugs.webkit.org/show_bug.cgi?id=47343
2611
2612         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2613         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2615         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2616         * WebKitTestRunner/TestController.cpp:
2617         * WebKitTestRunner/TestInvocation.cpp:
2618
2619 2010-10-07  Antonio Gomes  <agomes@rim.com>
2620
2621         Reviewed by Simon Fraser.
2622
2623         [Mac] [DRT] implement setSpatialNavigationEnabled
2624         https://bugs.webkit.org/show_bug.cgi?id=47291
2625
2626         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
2627         so it can track regression on the existing implementation and future improvements
2628         we are making.
2629
2630         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2631         (LayoutTestController::setSpatialNavigationEnabled):
2632
2633 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
2634
2635         Reviewed by Adam Barth.
2636
2637         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
2638         hook in the Port infrastructure to generate URIs for the files
2639         in its summary HTML report; however, that method is supposed to only
2640         be used for test files (and should really be renamed), so this would
2641         crash.
2642
2643         This change adds a new "path" module to the system package with a
2644         routine called abspath_to_uri() that handles converting paths to
2645         file: URIs independently of anything in the layout_tests package,
2646         and changes the code to use this. At some point in the near future
2647         the layout_tests/port/* code should use this as well.
2648
2649         This change also deletes a bunch of unused code and fixes some
2650         comments in rebaseline_chromium_webkit_tests.py.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=47319
2653
2654         * Scripts/webkitpy/common/system/path.py: Added.
2655         * Scripts/webkitpy/common/system/path_unittest.py: Added.
2656         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2657         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2658
2659 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
2660
2661         Reviewed by Gustavo Noronha Silva.
2662
2663         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2664         https://bugs.webkit.org/show_bug.cgi?id=46216
2665
2666         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
2667
2668         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2669         (initializeFonts): Also initialize the DevaVu Sans font.
2670
2671 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
2672
2673         Reviewed by Tony Chang.
2674
2675         [chromium] Minor naming cleanup in WebDragData, part 2
2676         https://bugs.webkit.org/show_bug.cgi?id=47227
2677
2678         Update DRT to use the renamed methods.
2679
2680         * DumpRenderTree/chromium/EventSender.cpp:
2681         (EventSender::beginDragWithFiles):
2682         * DumpRenderTree/chromium/WebViewHost.cpp:
2683         (addDRTFakeFileToDataObject):
2684
2685 2010-10-07  Anders Carlsson  <andersca@apple.com>
2686
2687         Reviewed by Sam Weinig.
2688
2689         Add a WKPageFindClient, hook up WKPageCountStringMatches
2690         https://bugs.webkit.org/show_bug.cgi?id=47373
2691
2692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2693         Remove hard coded paths.
2694
2695         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2696         (TestWebKitAPI::TEST):
2697         Fix expected result.
2698
2699         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
2700         (TestWebKitAPI::didFinishLoadForFrame):
2701         (TestWebKitAPI::didCountStringMatches):
2702         (TestWebKitAPI::TEST):
2703         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
2704         Add test for WKPageCountStringMatches.
2705
2706 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
2707
2708         Reviewed by Chris Fleizach.
2709
2710         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
2711         https://bugs.webkit.org/show_bug.cgi?id=46216
2712
2713         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
2714         for DejaVu Serif when there is no bold version available. This is necessary to
2715         properly test the property in layout tests.
2716
2717 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2718
2719         Reviewed by Kenneth Rohde Christiansen.
2720
2721         [Qt] Add WTR's InjectedBundle build files.
2722         https://bugs.webkit.org/show_bug.cgi?id=47333
2723
2724         * Scripts/webkitdirs.pm:
2725         * WebKitTestRunner/DerivedSources.pro: Added.
2726         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2727         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2728         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2729         Content merged in ../DerivedSources.pro
2730
2731 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2732
2733         Unreviewed, rolling out r69315.
2734         http://trac.webkit.org/changeset/69315
2735         https://bugs.webkit.org/show_bug.cgi?id=47363
2736
2737         Forgot to add the new files (Requested by kbalazs on #webkit).
2738
2739         * Scripts/webkitdirs.pm:
2740         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2741
2742 2010-10-07  Sam Weinig  <sam@webkit.org>
2743
2744         Reviewed by Anders Carlsson.
2745
2746         Change API tester to ask the executable for the list of all
2747         tests instead of relying on the directory structure.
2748         https://bugs.webkit.org/show_bug.cgi?id=47359
2749
2750         * Scripts/run-test-webkit-api: Added.
2751         * Scripts/webkitdirs.pm:
2752         Add additional script to just launch the api tester with the correct settings.
2753
2754         * Scripts/run-api-tests:
2755         Change to use the new --dump-tests options to build the list of tests and change
2756         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
2757
2758         * TestWebKitAPI/Test.h:
2759         (TestWebKitAPI::Test::Register::Register):
2760         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2761         (TestWebKitAPI::TEST):
2762         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2763         (TestWebKitAPI::TEST):
2764         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2765         (TestWebKitAPI::TEST):
2766         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2767         (TestWebKitAPI::TEST):
2768         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2769         (TestWebKitAPI::TEST):
2770         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2771         (TestWebKitAPI::TEST):
2772         Give each test a suite name in addition to the test name.
2773
2774         * TestWebKitAPI/TestsController.cpp:
2775         (TestWebKitAPI::TestsController::dumpTestNames):
2776         (TestWebKitAPI::TestsController::runTestNamed):
2777         * TestWebKitAPI/TestsController.h:
2778         * TestWebKitAPI/mac/main.mm:
2779         (main):
2780         Add option to print all registered tests.
2781
2782 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2783
2784         Reviewed by Kenneth Rohde Christiansen.
2785
2786         [Qt] Add WTR's InjectedBundle build files.
2787         https://bugs.webkit.org/show_bug.cgi?id=47333
2788
2789         * Scripts/webkitdirs.pm:
2790         * WebKitTestRunner/DerivedSources.pro: Added.
2791         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
2792         * WebKitTestRunner/WebKitTestRunner.pro: Added.
2793         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
2794         Content merged in ../DerivedSources.pro
2795
2796 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2797
2798         Unreviewed. Do a renaming that was recommended by the reviewer
2799         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
2800
2801         * WebKitTestRunner/qt/TestControllerQt.cpp:
2802         (WTR::RunUntilConditionLoop::start):
2803         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
2804         (WTR::TestController::runUntil):
2805
2806 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2807
2808         Reviewed by Kenneth Rohde Christiansen.
2809
2810         [Qt] Watchdog timer implementation for WTR
2811         https://bugs.webkit.org/show_bug.cgi?id=47337
2812
2813         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
2814         the definition of the timer type to a typedef.
2815         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
2816         Timer implementation with QTimer and a helper QObject class.
2817         (WTR::WatchdogTimerHelper::instance):
2818         (WTR::WatchdogTimerHelper::timerFired):
2819         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
2820         (WTR::LayoutTestController::platformInitialize):
2821         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
2822         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2823
2824 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2825
2826         Unreviewed buildfix for 69297 again
2827
2828         * WebKitTestRunner/TestController.cpp:
2829         (WTR::blankURL):
2830
2831 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
2832
2833         Unreviewed trivial build fix for r69297
2834
2835         * WebKitTestRunner/TestController.cpp:
2836         (WTR::blankURL):
2837
2838 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2839
2840         Reviewed by Kenneth Rohde Christiansen.
2841
2842         WebKitTestRunner should be portable
2843         https://bugs.webkit.org/show_bug.cgi?id=45393
2844
2845         Use only the WebKit API for working with urls.
2846         * WebKitTestRunner/StringFunctions.h:
2847         (WTR::createWKURL):
2848         * WebKitTestRunner/TestController.cpp:
2849         (WTR::blankURL):
2850         (WTR::TestController::resetStateToConsistentValues):
2851         (WTR::TestController::didFinishLoadForFrame):
2852
2853 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2854
2855         Reviewed by Xan Lopez.
2856
2857         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
2858         https://bugs.webkit.org/show_bug.cgi?id=47332
2859
2860         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2861         (createBitmapContextFromWebView):
2862
2863 2010-10-06  Chris Guillory  <chris.guillory@google.com>
2864
2865         Reviewed by Chris Fleizach.
2866
2867         Remove unused accessibility functions from webkit.
2868         https://bugs.webkit.org/attachment.cgi?bugid=46707
2869
2870         * DumpRenderTree/chromium/WebViewHost.cpp:
2871         (WebViewHost::postAccessibilityNotification):
2872         * DumpRenderTree/chromium/WebViewHost.h:
2873
2874 2010-10-06  Lucas Forschler  <lforschler@apple.com>
2875
2876         Reviewed by Adam Roben.
2877
2878         Fix the sunspider-compare-results to actually use the passed in value for $root.
2879
2880         * Scripts/sunspider-compare-results:
2881
2882 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2883
2884         Reviewed by Kenneth Rohde Christiansen.
2885
2886         [Qt] Runloop implementation for WTR
2887         https://bugs.webkit.org/show_bug.cgi?id=47280
2888
2889         * WebKitTestRunner/qt/TestControllerQt.cpp:
2890         Implemented TestController::runUntil by a timerEvent
2891         and a QEventLoop. We step into the event loop from runUntil.
2892         While we are waiting in the loop a timerEvent is periodically
2893         checking the value of the condition. Once the condition has
2894         becoming true the timerEvent wakes us up.
2895         (WTR::RunUntilLoop::start):
2896         (WTR::RunUntilLoop::RunUntilLoop):
2897         (WTR::RunUntilLoop::run):
2898         (WTR::RunUntilLoop::timerEvent):
2899         (WTR::TestController::platformInitialize):
2900         (WTR::TestController::runUntil):
2901         * WebKitTestRunner/qt/main.cpp:
2902         Start the main event loop first and creating the TestController later.
2903         (Launcher::Launcher):
2904         (Launcher::~Launcher):
2905         (Launcher::launch): Creating the TestController.
2906         (main): Setting up a timer for calling Launcher::launch from
2907         the main event loop.
2908
2909 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
2910
2911         Reviewed by Kenneth Russell.
2912
2913         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
2914         enable 'accelerated-composting' instead of 'accelerated-compositing'.
2915
2916         https://bugs.webkit.org/show_bug.cgi?id=47312
2917
2918         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2919         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2920
2921 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2922
2923         Reviewed by Kenneth Rohde Christiansen.
2924
2925         [Qt] PlatformWebView implementation for WebKitTestRunner
2926         https://bugs.webkit.org/show_bug.cgi?id=47276
2927
2928         The implementation follows the way how
2929         we use the API in MiniBrowser.
2930         * WebKitTestRunner/PlatformWebView.h:
2931         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2932         (WTR::WebView::wkView):
2933         (WTR::WebView::~WebView):
2934         (WTR::WebView::WebView):
2935         (WTR::PlatformWebView::PlatformWebView):
2936         (WTR::PlatformWebView::~PlatformWebView):
2937         (WTR::PlatformWebView::resizeTo):
2938         (WTR::PlatformWebView::page):
2939         (WTR::PlatformWebView::focus):
2940         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2941
2942 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
2943
2944         Reviewed by Kenneth Rohde Christiansen.
2945
2946         [Qt] Add WebKitTestRunner's build files
2947         https://bugs.webkit.org/show_bug.cgi?id=44155
2948
2949         Parts was taken by Zoltan Horvath's patch.
2950
2951         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
2952         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
2953         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
2954         PlatformWKView and PlatformWindow (void* for now).
2955         Buildfix the case when __APPLE__ is not defined.
2956         * WebKitTestRunner/qt/DerivedSources.pro: Added.
2957         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
2958         Empty stub implementation.
2959         (WTR::registerWindowClass):
2960         (WTR::PlatformWebView::PlatformWebView):
2961         (WTR::PlatformWebView::~PlatformWebView):
2962         (WTR::PlatformWebView::resizeTo):
2963         (WTR::PlatformWebView::page):
2964         (WTR::PlatformWebView::focus):
2965         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
2966         Empty stub implementation.
2967         (WTR::registerWindowClass):
2968         (WTR::TestController::runUntil):
2969         (WTR::TestController::platformInitialize):
2970         (WTR::TestController::initializeInjectedBundlePath):
2971         (WTR::TestController::initializeTestPluginDirectory):
2972         (WTR::TestController::platformInitializeContext):
2973         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
2974         * WebKitTestRunner/qt/main.cpp: Added.
2975         (main):
2976
2977 2010-10-06  Tony Chang  <tony@chromium.org>
2978
2979         Unreviewed, rolling out r69202.
2980         http://trac.webkit.org/changeset/69202
2981         https://bugs.webkit.org/show_bug.cgi?id=46937
2982
2983         Broke compile of test_shell
2984
2985         * DumpRenderTree/chromium/EventSender.cpp:
2986         (EventSender::beginDragWithFiles):
2987         * DumpRenderTree/chromium/WebViewHost.cpp:
2988         (addDRTFakeFileToDataObject):
2989
2990 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
2991
2992         Reviewed by Tony Chang.
2993
2994         [chromium] Minor naming cleanup in WebDragData, part 2
2995         https://bugs.webkit.org/show_bug.cgi?id=46937
2996
2997         Update DRT to use the renamed methods.
2998
2999         * DumpRenderTree/chromium/EventSender.cpp:
3000         (EventSender::beginDragWithFiles):
3001         * DumpRenderTree/chromium/WebViewHost.cpp:
3002         (addDRTFakeFileToDataObject):
3003
3004 2010-10-06  David Kilzer  <ddkilzer@apple.com>
3005
3006         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
3007
3008         Reviewed by Adam Roben.
3009
3010         This is the first step in making webarchive tests work on
3011         Windows.
3012
3013         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
3014         new files to the project.
3015         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
3016         to WebArchiveDumpSupport.mm.
3017         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
3018         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
3019         (serializeWebArchiveToXML):
3020
3021 2010-10-05  Daniel Bates  <dbates@rim.com>
3022
3023         Reviewed by David Kilzer.
3024
3025         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
3026         https://bugs.webkit.org/show_bug.cgi?id=46058
3027
3028         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
3029         structure so as to support returning additional information
3030         about a change log diff.
3031
3032         Currently, VCSUtils::fixChangeLogPatch() returns a string that
3033         represents the change log diff. Towards supporting the return
3034         of additional information, such as whether the change log diff
3035         inserts an entry at the top of the ChangeLog file, we need to
3036         make VCSUtils::fixChangeLogPatch() return a reference to hash
3037         structure.
3038
3039         * Scripts/VCSUtils.pm:
3040           - Modified fixChangeLogPatch() to return a reference to a
3041             hash structure.
3042           - Added documentation to fixChangeLogPatch().
3043           - Modified call site in mergeChangeLogs() as necessary.
3044         * Scripts/svn-apply:
3045           - Modified call site in patch() as necessary.
3046         * Scripts/svn-create-patch:
3047           - Modified call site in generateDiff() as necessary.
3048         * Scripts/svn-unapply:
3049           - Modified call site in patch() as necessary.
3050         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3051           - Modified the unit tests as necessary.
3052
3053 2010-10-05  Tony Chang  <tony@chromium.org>
3054
3055         Reviewed by Darin Adler.
3056
3057         fix the link to the expected image on windows
3058         https://bugs.webkit.org/show_bug.cgi?id=47228
3059
3060         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
3061             windows, the file must be opened in binary mode when writing
3062             binary data.
3063
3064 2010-10-05  Adam Barth  <abarth@webkit.org>
3065
3066         Update expected result of unittest to match Tony's change below.
3067
3068         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3069
3070 2010-10-05  Tony Chang  <tony@chromium.org>
3071
3072         Reviewed by Ojan Vafai (over the shoulder).
3073
3074         Paper over errors in image_diff so we don't crash the whole test run.
3075
3076         * Scripts/webkitpy/layout_tests/port/chromium.py:
3077
3078 2010-10-05  Tony Chang  <tony@chromium.org>
3079
3080         Unreviewed, make shutil.rmtree more resiliant to errors
3081         since windows was raising WindowsError: The process cannot access the file because it
3082         is being used by another process.
3083
3084         * Scripts/webkitpy/layout_tests/port/chromium.py:
3085
3086 2010-10-05  Tony Chang  <tony@chromium.org>
3087
3088         Reviewed by Ojan Vafai.
3089
3090         [chromium] fix image diffing in NRWT
3091         https://bugs.webkit.org/show_bug.cgi?id=47128
3092
3093         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
3094             NamedTemporaryFile since it doesn't work on Windows.
3095         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3096
3097 2010-10-05  Kenneth Russell  <kbr@google.com>
3098
3099         Reviewed by Tony Chang.
3100
3101         [chromium] Implement layerTreeAsText in DumpRenderTree
3102         https://bugs.webkit.org/show_bug.cgi?id=47216
3103
3104         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
3105         make it callable from DumpRenderTree.
3106
3107         No new tests; verified with existing compositor layout tests.
3108
3109         * DumpRenderTree/chromium/LayoutTestController.cpp:
3110         (LayoutTestController::LayoutTestController):
3111         (LayoutTestController::layerTreeAsText):
3112         * DumpRenderTree/chromium/LayoutTestController.h:
3113
3114 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
3115
3116         Unreviewed build correction.
3117
3118         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
3119         property sheet so proper libraries are linked.
3120
3121 2010-10-05  Robert Hogan  <robert@webkit.org>
3122
3123         Reviewed by Andreas Kling.
3124
3125         [Qt] Fix url conversion in QWebHistory
3126
3127         Converting from KURL to WFT::String to QUrl does not
3128         permit proper percent encoding later.
3129
3130         https://bugs.webkit.org/show_bug.cgi?id=47048
3131
3132         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3133         (WebCore::dumpHistoryItem):
3134
3135 2010-10-05  Anders Carlsson  <andersca@apple.com>
3136
3137         Reviewed by Sam Weinig.
3138
3139         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
3140         https://bugs.webkit.org/show_bug.cgi?id=47188
3141         <rdar://problem/8514104>
3142
3143         When constructing the std::string, use the real string length instead of the maximum buffer size.
3144
3145         * TestWebKitAPI/PlatformUtilities.h:
3146         (TestWebKitAPI::Util::toSTD):
3147         * WebKitTestRunner/StringFunctions.h:
3148         (WTR::toSTD):
3149
3150 2010-10-04  Sam Weinig  <sam@webkit.org>
3151
3152         Reviewed by Mark Rowe.
3153
3154         Add MIMEType accessor to WKFrame
3155         <rdar://problem/8347683>
3156         https://bugs.webkit.org/show_bug.cgi?id=47138
3157
3158         * TestWebKitAPI/PlatformUtilities.h:
3159         (TestWebKitAPI::Util::toSTD):
3160         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3161         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
3162         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3163         (TestWebKitAPI::didCommitLoadForFrame):
3164         (TestWebKitAPI::didFinishLoadForFrame):
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
3167         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3168         (TestWebKitAPI::didCommitLoadForFrame):
3169         (TestWebKitAPI::didFinishLoadForFrame):
3170         (TestWebKitAPI::TEST):
3171         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3172         (TestWebKitAPI::TEST):
3173         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
3174         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
3175         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
3176         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3177         (TestWebKitAPI::Util::createURLForResource):
3178
3179 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3180
3181         Reviewed by Ojan Vafai.
3182
3183         [NRWT] Rename current_dir to current_group because it's not a directory
3184         https://bugs.webkit.org/show_bug.cgi?id=47169
3185
3186         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3188
3189 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3190
3191         Unreviewed, build fix.
3192
3193         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
3194         which can't always be done. This test uses tempfile.mkdtemp(), which
3195         should be safe.
3196
3197         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3198
3199 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3200
3201         Unreviewed, build fix.
3202
3203         Add missing "from __future__ import with_statement" that was
3204         breaking test-webkitpy on the Leopard bots (broke in r69040).
3205
3206         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3207
3208 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3209
3210         Unreviewed, rolling out r69066.
3211         http://trac.webkit.org/changeset/69066
3212         https://bugs.webkit.org/show_bug.cgi?id=47163
3213
3214         Made NRWT reliability worse. (Requested by tkent on #webkit).
3215
3216         * Scripts/webkitpy/layout_tests/port/chromium.py:
3217         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3218
3219 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3220
3221         Reviewed by Tony Chang.
3222
3223         [NRWT] Reverse the http tests to alphabetical order.
3224         https://bugs.webkit.org/show_bug.cgi?id=47075
3225
3226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3227
3228 2010-10-04  Robert Hogan  <robert@webkit.org>
3229
3230         Reviewed by Andreas Kling.
3231
3232         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
3233
3234         We need to queue back and forward navigations in the DRT from the
3235         LayoutTestController so that maybeDump() knows about them.
3236
3237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3238         (LayoutTestController::queueBackNavigation):
3239         (LayoutTestController::queueForwardNavigation):
3240
3241 2010-10-04  Tony Chang  <tony@chromium.org>
3242
3243         Reviewed by Kent Tamura.
3244
3245         [chromium] fix image diffing in NRWT
3246         https://bugs.webkit.org/show_bug.cgi?id=47128
3247
3248         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
3249               temp file and check the image_diff error code more carefully
3250         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3251
3252 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3253
3254         Reviewed by Adam Barth.
3255
3256         aroben's change in r68792 actually broke new-run-webkit-tests when
3257         running the DRT code path. His change was intended to fix the
3258         way we were converting windows paths to URIs when running under
3259         Cygwin (the paths were getting one too many "/" on the front).
3260         However, the change ended up breaking the chromium_win port, which
3261         had slightly different logic.
3262
3263         This patch removes the port-specific code and adds tests to make
3264         sure we're getting the behavior we expect. The Port object no longer
3265         exposes a get_absolute_path() method that can be used outside of
3266         of converting test filenames, because it's unreliable otherwise
3267         (we don't have the right context to know which conversion is intended).
3268
3269         https://bugs.webkit.org/show_bug.cgi?id=47140
3270
3271         * Scripts/webkitpy/layout_tests/port/base.py:
3272         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3273         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3275         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3276
3277 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3278
3279         Unreviewed, build fix.
3280
3281         Handle crash introduced in r69040 if we are not running in a
3282         Chromium checkout.
3283
3284         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3285
3286 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
3287
3288         Reviewed by Tony Chang.
3289
3290         Add a way for us to have test expectations that are specific to the
3291         official builds of Google Chrome (as opposed to Chromium). This change
3292         looks for an additional "test_expectations_chrome.txt" file in
3293         Chromium's repository (webkit/tools/layout_tests), and uses the
3294         concatenation of that file and the regular test_expectations.txt
3295         file for test overrides.
3296
3297         https://bugs.webkit.org/show_bug.cgi?id=46854
3298
3299         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3300         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3301
3302 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
3303
3304         Color tests in the list based on existing pass/fail result.
3305         
3306         Fix the summary data to account for htmlOnly and nonHTML tests.
3307
3308         * CSSTestSuiteHarness/harness/harness.css:
3309         (#test-list > option.pass):
3310         (#test-list > option.fail):
3311         (#test-list > option.skipped):
3312         * CSSTestSuiteHarness/harness/harness.js:
3313         (Test):
3314         (Test.prototype.statusForFormat):
3315         (TestSuite.prototype.fillTestList):
3316         (TestSuite.prototype.updateTestList):
3317         (TestSuite.prototype.recordResult):
3318         (TestSuite.prototype.markTestCompleted):
3319         (TestSuite.prototype.countTestsWithFlag):
3320         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
3321         (TestSuite.prototype.queryDatabaseForSummary):
3322
3323 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
3324
3325         Reviewed by Beth Dakin.
3326
3327         AX: doAXRangeForLine does not work
3328         https://bugs.webkit.org/show_bug.cgi?id=47101
3329
3330         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
3331
3332         * DumpRenderTree/AccessibilityUIElement.cpp:
3333         (rangeForLineCallback):
3334         (AccessibilityUIElement::rangeForLine):
3335         (AccessibilityUIElement::getJSClass):
3336         * DumpRenderTree/AccessibilityUIElement.h:
3337         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3338         (AccessibilityUIElement::rangeForLine):
3339
3340 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
3341
3342         Unreviewed. Adding myself to the committers list.
3343
3344         * Scripts/webkitpy/common/config/committers.py:
3345
3346 2010-10-04  Sam Weinig  <sam@webkit.org>
3347
3348         Reviewed by Anders Carlsson.
3349
3350         Add ability to set the CacheModel in Webkit2
3351         https://bugs.webkit.org/show_bug.cgi?id=47066
3352
3353         * MiniBrowser/mac/AppDelegate.m:
3354         (-[BrowserAppDelegate init]): Opt minibrowser into
3355         a PrimaryWebBrowser cache model.
3356
3357 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3358
3359         Make sure to enter all tests when creating the database
3360         for the first time.
3361         
3362         When migrating to a new version of the suite, be sure to
3363         sync up the database and testinfo.data by removing old
3364         tests, and inserting new ones.
3365
3366         * CSSTestSuiteHarness/harness/harness.js:
3367         (TestSuite.prototype.openDatabase.creation):
3368         (TestSuite.prototype.databaseCreated):
3369         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3370         (TestSuite.prototype.insertTest):
3371
3372 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3373
3374         More work on treating HTML4 and XHTML1 independently; when 
3375         changing the format, rebuild the test list, and update the 
3376         numbers in the chapter popup.
3377
3378         * CSSTestSuiteHarness/harness/harness.js:
3379         (Test):
3380         (Test.prototype.runForFormat):
3381         (Test.prototype.completedForFormat):
3382         (ChapterSection):
3383         (ChapterSection.prototype.countTests):
3384         (Chapter):
3385         (Chapter.prototype.description):
3386         (Chapter.prototype.countTests):
3387         (Chapter.prototype.testCount):
3388         (Chapter.prototype.untestedCount):
3389         (TestSuite.prototype.buildChapters):
3390         (TestSuite.prototype.loadCurrentTest):
3391         (TestSuite.prototype.updateProgressLabel):
3392         (TestSuite.prototype.processFlags):
3393         (TestSuite.prototype.formatChanged):
3394
3395 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
3396
3397         Update test suite version 20101001.
3398         
3399         Handle database migration, and delete tests from the db that are
3400         not present in testinfo.data.
3401         
3402         Load about:blank into the test frame before the test url, to make
3403         missing tests more obvious.
3404         
3405         * CSSTestSuiteHarness/harness/harness.js:
3406         (TestSuite.prototype.loadTest):
3407         (TestSuite.prototype.openDatabase.creation):
3408         (TestSuite.prototype.openDatabase.migration1_0To1_1):
3409         (TestSuite.prototype.openDatabase.if.return):
3410         (TestSuite.prototype.databaseReady):
3411         (TestSuite.prototype.populateDatabaseFromTestInfoData):
3412         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
3413         (TestSuite.prototype.syncDatabaseWithTestInfoData):
3414
3415 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3416
3417         Add the ability to jump to a specific test.
3418
3419         * CSSTestSuiteHarness/harness/harness.html:
3420         * CSSTestSuiteHarness/harness/harness.js:
3421         (TestSuite.prototype.goToTestByName):
3422         (TestSuite.prototype.switchToFormat):
3423
3424 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3425
3426         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
3427         as the test.
3428
3429         * CSSTestSuiteHarness/harness/harness.js:
3430         (TestSuite.prototype.loadRef):
3431
3432 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
3433
3434         Update the UI to reflect the fact that each test needs to be tested
3435         in both HTML4 and XHTML1 format.
3436         
3437         * CSSTestSuiteHarness/harness/harness.js:
3438         (Test):
3439         (Chapter.prototype.description):
3440         (Chapter.prototype.untestedCount):
3441         (TestSuite.prototype.fillChapterPopup):
3442         (TestSuite.prototype.updateChapterPopup):
3443         (TestSuite.prototype.fillTestList):
3444         (TestSuite.prototype.updateTestList):
3445         (TestSuite.prototype.goToNextIncompleteTest):
3446         (TestSuite.prototype.firstIncompleteTestIndex):
3447         (TestSuite.prototype.recordResult):
3448         (TestSuite.prototype.formatChanged):
3449         (TestSuite.prototype.markTestCompleted):
3450         (TestSuite.prototype.resetTestStatus):
3451
3452 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
3453
3454         Add the ability to remove results for re-testing, and
3455         to import results.
3456
3457         * CSSTestSuiteHarness/harness/harness.css:
3458         (.custom button):
3459         (#overlay):
3460         (#overlay.visible):
3461         (.overlay-contents):
3462         (.overlay-contents textarea):
3463         (.overlay-contents .buttons):
3464         (.overlay-contents .note):
3465         (.overlay-contents .buttons button):
3466         * CSSTestSuiteHarness/harness/harness.html:
3467         * CSSTestSuiteHarness/harness/harness.js:
3468         (TestSuite.prototype.importResults):
3469         (TestSuite.prototype.clearResults):
3470         (TestSuite.prototype.markTestCompleted):
3471         (TestSuite.prototype.resetTestStatus):
3472         (TestSuite.prototype.storeTestResult):
3473         (TestSuite.prototype.importTestResults):
3474         (TestSuite.prototype.clearTestResults):
3475
3476 2010-10-01  Sam Weinig  <sam@webkit.org>
3477
3478         Reviewed by Jon Honeycutt.
3479
3480         Deploy the new WKString functions to remove most uses of CF from
3481         the WebKitTestRunner.
3482
3483         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3484         (WTR::InjectedBundle::didReceiveMessage):
3485         (WTR::InjectedBundle::done):
3486         * WebKitTestRunner/StringFunctions.h:
3487         (WTR::toWK):
3488         (WTR::toJS):
3489         (WTR::toSTD):
3490         (WTR::operator<<):
3491         (WTR::copyURLString):
3492         * WebKitTestRunner/TestController.cpp:
3493         (WTR::TestController::resetStateToConsistentValues):
3494         (WTR::TestController::didFinishLoadForFrame):
3495         * WebKitTestRunner/TestInvocation.cpp:
3496         (WTR::TestInvocation::invoke):
3497         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3498
3499 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
3500
3501         Unreviewed TestResultsServer change.
3502
3503         Add files introduced by http://crrev.com/61273 to the list of dashboard 
3504         files to update.
3505
3506         * TestResultServer/handlers/dashboardhandler.py:
3507
3508 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
3509
3510         Build Fix for Windows.
3511
3512         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
3513             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
3514             ForwardingHeaders to the include path.
3515
3516 2010-10-01  Sam Weinig  <sam@webkit.org>
3517
3518         Reviewed by Anders Carlsson.
3519
3520         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3524         (TestWebKitAPI::TEST):
3525         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
3526         (TestWebKitAPI::TEST):
3527
3528 2010-10-01  Sam Weinig  <sam@webkit.org>
3529
3530         Reviewed by Kenneth Rohde Christiansen.
3531
3532         Add additional WKString API
3533         https://bugs.webkit.org/show_bug.cgi?id=46958
3534
3535         Add basic WKStringRef tests.
3536
3537         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3538         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
3539
3540 2010-10-01  Sam Weinig  <sam@webkit.org>
3541
3542         Reviewed by Dan Bernstein.
3543
3544         Add makefile for TestWebKitAPI and call it from the base makefile.
3545
3546         * Makefile:
3547         * TestWebKitAPI/Makefile: Added.
3548
3549 2010-10-01  Sam Weinig  <sam@webkit.org>
3550
3551         Reviewed by Adam Roben.
3552
3553         Remove unnecessary ForwardingHeaders from test runners.
3554         https://bugs.webkit.org/show_bug.cgi?id=47010
3555
3556         * TestWebKitAPI/Configurations/Base.xcconfig:
3557         * TestWebKitAPI/ForwardingHeaders: Removed.
3558         * WebKitTestRunner/Configurations/Base.xcconfig:
3559         * WebKitTestRunner/ForwardingHeaders: Removed.
3560
3561 2010-09-30  Adam Barth  <abarth@webkit.org>
3562
3563         Reviewed by Eric Seidel.
3564
3565         WebSocket tests are flaky
3566         https://bugs.webkit.org/show_bug.cgi?id=46956
3567
3568         Update these tools to understand how to run the WebSocket tests off the
3569         Apache server.
3570
3571         * Scripts/old-run-webkit-tests:
3572         * Scripts/webkitpy/layout_tests/port/base.py:
3573         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3574         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3575
3576 2010-10-01  Adam Roben  <aroben@apple.com>
3577
3578         Encode Executive command arguments using UTF-8 on Cygwin
3579
3580         Cygwin's Python's os.execv doesn't support unicode command arguments.
3581         Cygwin's execv expects arguments to be encoded using the current code
3582         page. But code pages are limited in what characters they can handle,
3583         and our tests include characters that the English code page can't