WebCore: AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-07-07  Chris Fleizach  <cfleizach@apple.com>
2
3         Reviewed by Darin Adler.
4
5         AX: TextArea should return AXSelectedTextRange of 0,0 if the cursor is not in the text area
6         https://bugs.webkit.org/show_bug.cgi?id=41810
7
8         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9         (AccessibilityUIElement::selectedTextRange):
10
11 2010-07-07  Martin Robinson  <mrobinson@igalia.com>
12
13         Unreviewed.
14
15         Build fix after r62700.
16
17         * GNUmakefile.am: Update the source list to reflect the new TestNetscapePlugIn
18         source file locations.
19
20 2010-07-07  Ojan Vafai  <ojan@chromium.org>
21
22         Reviewed by David Levin.
23
24         change --exit-after-n-crashes to --exit-after-n-crashes-or-timeouts
25         https://bugs.webkit.org/show_bug.cgi?id=41814
26
27         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
28         * Scripts/old-run-webkit-tests:
29
30 2010-07-07  Ojan Vafai  <ojan@chromium.org>
31
32         Reviewed by David Levin.
33
34         add --exit-after-n-crashes to run-webkit-tests
35         https://bugs.webkit.org/show_bug.cgi?id=41811
36
37         Change the bots at build.webkit.org to use --exit-after-n-crashes
38         instead of --exit-after-n-failures since we want to be able to have
39         more than 20 failures on those bots, but more than 20 crashes means
40         something should be rolled out.
41
42         * Scripts/old-run-webkit-tests:
43         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
44
45 2010-07-07  Brian Weinstein  <bweinstein@apple.com>
46
47         Fix the Windows build by removing win/TestNetscapePlugin/main.cpp from the
48         TestNetscapePlugin project, because this was removed from the tree.
49
50         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
51
52 2010-07-07  Anders Carlsson  <andersca@apple.com>
53
54         Reviewed by Simon Fraser.
55
56         Unify Mac and Windows TestNetscapePlugin main.cpp files
57         https://bugs.webkit.org/show_bug.cgi?id=41798
58         
59         * DumpRenderTree/DumpRenderTree.sln:
60         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
61         (strcasecmp):
62         (NP_Initialize):
63         (NP_GetEntryPoints):
64         (NP_Shutdown):
65         (NPP_New):
66         (NPP_Destroy):
67         (NPP_HandleEvent):
68         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
69         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Removed.
70
71 2010-07-07  Kevin Ollivier  <kevino@theolliviers.com>
72
73         [wx] Build fix. pageProperty needs to return a value.
74
75         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
76         (LayoutTestController::pageProperty):
77
78 2010-07-07  David Kilzer  <ddkilzer@apple.com>
79
80         <http://webkit.org/b/41788> commit-log-editor: wrong ChangeLog read when invoked from subdir with git
81
82         Reviewed by Anders Carlsson.
83
84         For both svn and git, commit-log-editor is invoked from the root
85         of the working directory.  Unlike svn, git returns a list of
86         changed files that are relative to the directory where the
87         command was invoked.  This caused the ChangeLog file in the root
88         directory to be read instead of the ChangeLog in the current
89         directory.
90
91         The fix is to use $ENV{PWD} as the base directory when fixing
92         the path to the ChangeLog files.  With svn, this has no net
93         effect since $ENV{PWD} is the root of the working directory and
94         the ChangeLog paths are already relative to that directory.
95         With git, $ENV{PWD} is the directory that the commit was invoked
96         from, which fixes the ChangeLog paths so that the correct files
97         are read when creating the commit log entry.
98
99         Note that the call to makeFilePathRelative() was supposed to
100         address this issue, but it doesn't because (a) it does nothing
101         with svn working directories by design, and (b) it does nothing
102         with git working directories because it's invoked when the
103         current directory is the root of the working directory, thus
104         giving no relative path.
105
106         * Scripts/commit-log-editor: Removed call to
107         makeFilePathRelative() since since it does nothing.  Moved code
108         to fix up $changeLog path so that it's fixed before trying to
109         open the file, and use $ENV{PWD} as the base path.  Also use
110         canonicalizePath() to clean up paths with "../" in them.
111
112 2010-07-07  Anders Carlsson  <andersca@apple.com>
113
114         Another attempt at fixing the Qt build.
115
116         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
117
118 2010-07-07  Anders Carlsson  <andersca@apple.com>
119
120         Try to fix Qt build.
121
122         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
123
124 2010-07-07  Anders Carlsson  <andersca@apple.com>
125
126         Reviewed by Simon Fraser.
127
128         Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
129         https://bugs.webkit.org/show_bug.cgi?id=41781
130
131         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
132         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp.
133         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h.
134         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp.
135         * DumpRenderTree/TestNetscapePlugIn/TestObject.h: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h.
136         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist.
137         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Renamed from WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp.
138         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.def.
139         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc.
140         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added.
141         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin_debug.def: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin_debug.def.
142         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from WebKitTools/DumpRenderTree/win/TestNetscapePlugin/resource.h.
143         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
144
145 2010-07-07  Andras Becsi  <abecsi@webkit.org>
146
147         Unreviewed trivial fix.
148
149         Remove DUMPRENDERTREE_TEMP environment variable from NRWT
150         which was checked in accidentally in r62635.
151
152         * Scripts/webkitpy/layout_tests/port/webkit.py:
153
154 2010-07-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
155
156         Reviewed by Eric Seidel.
157
158         Pass port specific environment to server process.
159         https://bugs.webkit.org/show_bug.cgi?id=41593
160
161         * Scripts/webkitpy/layout_tests/port/qt.py:
162         * Scripts/webkitpy/layout_tests/port/webkit.py:
163
164 2010-07-06  Kent Tamura  <tkent@chromium.org>
165
166         Reviewed by Shinichiro Hamaji.
167
168         Fix a wrong dup detection of rebaseline-chromium-webkit-tests
169         https://bugs.webkit.org/show_bug.cgi?id=41644
170
171         rebaseline-chromium-webkit-tests used ImageDiff with 0.1%
172         tolerance. We don't need tolerance for rebaseline.
173
174         * Scripts/webkitpy/layout_tests/port/base.py:
175           Add optional tolerance parameter to diff_image().
176         * Scripts/webkitpy/layout_tests/port/test.py:
177           Add optional tolerance parameter to diff_image().
178         * Scripts/webkitpy/layout_tests/port/webkit.py:
179           Add optional tolerance parameter to diff_image(), and pass it to ImageDiff command.
180         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
181           diff_files() always calls diff_image() with tolerance=0.
182           diff_files() is used only by rebaseline-chromium-webkit-tests.
183
184 2010-07-06  Sam Weinig  <sam@webkit.org>
185
186         Fix MiniBrowser build.
187
188         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
189
190 2010-07-06  Sam Weinig  <sam@webkit.org>
191
192         Reviewed by Anders Carlsson.
193
194         Add support for dumping the contents of messages to the console to WebKitTestRunner
195
196         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
197         (WTR::InjectedBundlePage::InjectedBundlePage):
198         (WTR::InjectedBundlePage::_addMessageToConsole):
199         (WTR::InjectedBundlePage::addMessageToConsole):
200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
201
202 2010-07-06  Sam Weinig  <sam@webkit.org>
203
204         Reviewed by Anders Carlsson.
205
206         Patch for https://bugs.webkit.org/show_bug.cgi?id=41708
207         Add dumpAsText support for WebKitTestRunner
208
209         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
210         (WTR::InjectedBundle::InjectedBundle):
211         (WTR::InjectedBundle::reset): Reset the LayoutTestController for each test.
212         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
213         (WTR::InjectedBundlePage::didFinishLoadForFrame): Use the new WKBundleFrameCopyInnerText
214         API to dump the main frames text.
215
216 2010-07-06  Darin Adler  <darin@apple.com>
217
218         Fix Chromium build.
219
220         * DumpRenderTree/chromium/WebViewHost.cpp:
221         (WebViewHost::didCreateDataSource): Call leakPtr instead of release.
222         (WebViewHost::didNavigateWithinPage): Ditto.
223         (WebViewHost::updateURL): Ditto.
224
225 2010-07-06  Martin Robinson  <mrobinson@igalia.com>
226
227         Reviewed by Xan Lopez.
228
229         [GTK] build-webkit should not run autogen.sh unconditionally
230         https://bugs.webkit.org/show_bug.cgi?id=41704
231
232         * Scripts/webkitdirs.pm: Only run autogen.sh during a build if GNUmakefile
233         doesn't exist. Autotools should re-run autogen.sh when necessary. Also do
234         some very minor cleanup.
235
236 2010-07-06  Darin Adler  <darin@apple.com>
237
238         Try to fix Chromium build.
239
240         * DumpRenderTree/chromium/WebViewHost.cpp: Added include of PassOwnPtr.h.
241
242 2010-07-06  Darin Adler  <darin@apple.com>
243
244         Fix build.
245
246         * WebKitAPITest/TestsController.cpp:
247         (WebKitAPITest::TestsController::addTest): Use leakPtr instead of release.
248
249 2010-07-06  Roland Steiner  <rolandsteiner@chromium.org>
250
251         Reviewed by Kent Tamura.
252
253         Bug 40558 - [DRT/Chromium] Upstream TestShellDevTools for Chromium DRT
254         https://bugs.webkit.org/show_bug.cgi?id=40558
255
256         Upstream DevTools for Chromium DRT.
257         (original Chromium files rev. 51287)
258
259         * DumpRenderTree/DumpRenderTree.gypi:
260         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Added.
261         (DRTDevToolsAgent::DRTDevToolsAgent):
262         (DRTDevToolsAgent::setWebView):
263         (DRTDevToolsAgent::sendMessageToFrontend):
264         (DRTDevToolsAgent::forceRepaint):
265         (DRTDevToolsAgent::runtimeFeatureStateChanged):
266         (DRTDevToolsAgent::injectedScriptSource):
267         (DRTDevToolsAgent::injectedScriptDispatcherSource):
268         (DRTDevToolsAgent::debuggerScriptSource):
269         (DRTDevToolsAgent::asyncCall):
270         (DRTDevToolsAgent::call):
271         (DRTDevToolsAgent::webDevToolsAgent):
272         (DRTDevToolsAgent::attach):
273         (DRTDevToolsAgent::detach):
274         (DRTDevToolsAgent::setTimelineProfilingEnabled):
275         (DRTDevToolsAgent::evaluateInWebInspector):
276         (DRTDevToolsAgent::dispatchMessageLoop):
277         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Added.
278         (DRTDevToolsAgent::~DRTDevToolsAgent):
279         (DRTDevToolsAgent::hostIdentifier):
280         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp:
281         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
282         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
283         (DRTDevToolsCallArgs::~DRTDevToolsCallArgs):
284         (DRTDevToolsCallArgs::callsCount):
285         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Added.
286         (DRTDevToolsClient::DRTDevToolsClient):
287         (DRTDevToolsClient::~DRTDevToolsClient):
288         (DRTDevToolsClient::sendMessageToAgent):
289         (DRTDevToolsClient::sendDebuggerCommandToAgent):
290         (DRTDevToolsClient::activateWindow):
291         (DRTDevToolsClient::closeWindow):
292         (DRTDevToolsClient::dockWindow):
293         (DRTDevToolsClient::undockWindow):
294         (DRTDevToolsClient::asyncCall):
295         (DRTDevToolsClient::call):
296         (DRTDevToolsClient::allMessagesProcessed):
297         * DumpRenderTree/chromium/DRTDevToolsClient.h:
298         * DumpRenderTree/chromium/EventSender.cpp:
299         * DumpRenderTree/chromium/LayoutTestController.cpp:
300         (LayoutTestController::LayoutTestController):
301         (LayoutTestController::closeWebInspector):
302         (LayoutTestController::setTimelineProfilingEnabled):
303         (LayoutTestController::evaluateInWebInspector):
304         * DumpRenderTree/chromium/LayoutTestController.h:
305         * DumpRenderTree/chromium/TestShell.cpp:
306         (TestShell::TestShell):
307         (TestShell::~TestShell):
308         (TestShell::createDRTDevToolsClient):
309         (TestShell::showDevTools):
310         (TestShell::closeDevTools):
311         (TestShell::runFileTest):
312         (TestShell::createNewWindow):
313         * DumpRenderTree/chromium/TestShell.h:
314         (TestShell::drtDevToolsAgent):
315         (TestShell::drtDevToolsClient):
316         * DumpRenderTree/chromium/config.h:
317
318 2010-07-06  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
319
320         Reviewed by Eric Seidel.
321
322         Don't pass image hash to DRT when pixel tests are disabled.
323         https://bugs.webkit.org/show_bug.cgi?id=41597
324
325         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
326
327 2010-07-05  Csaba Osztrogonác  <ossy@webkit.org>
328
329         Reviewed by Eric Seidel.
330
331         REGRESSION(r60652): WebKitTools/Scripts/ensure-valid-python should cleanup temporary directory
332         https://bugs.webkit.org/show_bug.cgi?id=41612
333
334         * Scripts/ensure-valid-python: File::Temp::tempdir call fixed.
335
336 2010-07-05  Adam Barth  <abarth@webkit.org>
337
338         Reviewed by Eric Seidel.
339
340         We should be able to specify a bug to block for webkit-patch upload
341         https://bugs.webkit.org/show_bug.cgi?id=41648
342
343         This will be useful for working on the HTML5 parser.
344
345         * Scripts/webkitpy/tool/steps/createbug.py:
346         * Scripts/webkitpy/tool/steps/options.py:
347
348 2010-07-05  Martin Robinson  <mrobinson@igalia.com>
349
350         Reviewed by Oliver Hunt.
351
352         The style checker exempts gtk2drawing.h when it should exempt gtkdrawing.h
353         https://bugs.webkit.org/show_bug.cgi?id=41017
354
355         * Scripts/webkitpy/style/checker.py: Exempt gtkdrawing.h instead of gtk2drawing.h
356         * Scripts/webkitpy/style/checker_unittest.py: Update the unit test to reflect the change.
357
358 2010-07-04  MORITA Hajime  <morrita@google.com>
359
360         rebaseline-chromium-webkit-tests: UnicodeDecodeError
361         https://bugs.webkit.org/show_bug.cgi?id=41589
362
363         * run() method can result non-utf-8 bytes, that causes utf-8
364           decoding fail.  Fixed to disable decoding.
365         * Fixed Git.find_checkout_root() to make a test pass.
366
367         * Scripts/webkitpy/common/checkout/scm.py:
368         * Scripts/webkitpy/common/checkout/scm_unittest.py:
369
370 2010-07-03  Patrick Gansterer  <paroga@paroga.com>
371
372         Reviewed by Simon Hausmann.
373
374         [Qt] Fix DumpRenderTree userStyleSheet handling.
375         https://bugs.webkit.org/show_bug.cgi?id=41570
376
377         DumpRenderTree did only set the userStyleSheet at
378         layoutTestController.setUserStyleSheetEnabled().
379
380         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
381         (LayoutTestController::reset):
382         (LayoutTestController::setUserStyleSheetLocation):
383         (LayoutTestController::setUserStyleSheetEnabled):
384         * DumpRenderTree/qt/LayoutTestControllerQt.h:
385
386 2010-07-03  Robert Hogan  <robert@webkit.org>
387
388         Reviewed by Kenneth Rohde Christiansen.
389
390         [Qt] support dumpChildFrameScrollPositions
391
392         https://bugs.webkit.org/show_bug.cgi?id=41088
393
394         Unskip:
395
396         http/tests/navigation/anchor-subframeload.html
397         http/tests/navigation/relativeanchor-frames.html
398
399         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
400         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
401         (WebCore::DumpRenderTree::dump):
402         * DumpRenderTree/qt/DumpRenderTreeQt.h:
403         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
404         (LayoutTestController::reset):
405         * DumpRenderTree/qt/LayoutTestControllerQt.h:
406         (LayoutTestController::shouldDumpChildFrameScrollPositions):
407         (LayoutTestController::dumpChildFrameScrollPositions):
408
409 2010-07-02  Sam Weinig  <sam@webkit.org>
410
411         Reviewed by Anders Carlsson.
412
413         Rename new scripts so that they don't make autocompleting run-webkit-tests annoying.
414
415         * Scripts/debug-test-runner: Copied from Scripts/debug-webkittestrunner.
416         * Scripts/debug-webkittestrunner: Removed.
417         * Scripts/run-test-runner: Copied from Scripts/run-webkittestrunner.
418         * Scripts/run-webkittestrunner: Removed.
419
420 2010-07-02  Brian Weinstein  <bweinstein@apple.com>
421
422         Reviewed by Steve Falkenburg.
423
424         Some http tests fail on Windows with Cygwin 1.7
425         https://bugs.webkit.org/show_bug.cgi?id=41537
426         
427         With Cygwin 1.7, the registry key at SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/
428         doesn't exist anymore, because the mount points are stored in /etc/fstab. However, we
429         just need root mount point, which is defined in SOFTWARE\\Cygwin\\setup.
430
431         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
432         (resolveCygwinPath): Fall back to SOFTWARE\\Cygwin\\setup if 
433             SOFTWARE\\Cygnus Solutions\\Cygwin\\mounts v2\\/ doesn't work.
434
435 2010-06-23  Martin Robinson  <mrobinson@igalia.com>
436
437         Reviewed by Gustavo Noronha Silva.
438
439         [GTK] Separate DerivedSources per-project
440         https://bugs.webkit.org/show_bug.cgi?id=41109
441
442         The JavaScriptCore cppflags used to include the top-level DerivedSources directory
443         allowing the tools to build as a side-effect. Now that the top-level directory
444         is no longer in the list of JavaScriptCore includes, include it explicitly.
445
446         * GNUmakefile.am:
447
448 2010-07-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
449
450         Reviewed by Kenneth Rohde Christiansen.
451
452         [Qt] Make context menus show up in the right place in QTestBrowser
453
454         Context menus were shown at scene-relative coordinates for
455         QGraphicsWebView while QMenu expects them to be global. The
456         change to the QWidget case was to get rid of the mapToGlobal.
457
458         * QtTestBrowser/webview.cpp:
459
460 2010-07-01  Robert Hogan <robert@webkit.org>
461
462         Reviewed by Kenneth Rohde Christiansen.
463
464         [Qt] dump frames in ascending alphabetical order of title
465
466         https://bugs.webkit.org/show_bug.cgi?id=41261
467
468         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
469         (WebCore::dumpHistoryItem):
470
471 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
472
473         Unreviewed. 
474
475         Fix the GTK+ build after r62278.
476
477         * Scripts/webkitdirs.pm: If the make arguments have already been specified,
478         let them override the automatic CPU detection for autotools builds.
479
480 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
481
482         Unreviewed.
483
484         Fix the Windows build after r62278.
485
486         * Scripts/num-cpus: Use FindBin to add the Scripts directory to the list of library directories.
487
488 2010-07-01  Martin Robinson  <mrobinson@igalia.com>
489
490         Reviewed by Gustavo Noronha Silva.
491
492         [GTK] build-webkit does not detect the number of CPUs
493         https://bugs.webkit.org/show_bug.cgi?id=41469
494
495         Pass the appropriate -j<#> flag to make when building autotools builds.
496         This causes make to spawn that many number of child processes for doing
497         parallel builds.
498
499         * Scripts/num-cpus: Use the newly abstracted numberOfCPUs to return the number
500         of CPUs. This makes the script work across more platforms.
501         * Scripts/webkitdirs.pm: Create a numberOfCPUs/determineNumberOfCPUs to determine the
502         number of CPUs across several platforms. Use this new function to determine the appropriate
503         arguments to pass to make for doing parallel builds with autotools build files.
504
505 2010-07-01  Simon Hausmann  <simon.hausmann@nokia.com>
506
507         Rubber-stamped by Laszlo Gombos.
508
509         [Qt][Symbian] Bumped up the maximum heap size to 96MB
510
511         * QtTestBrowser/QtTestBrowser.pro: Removed explicit heap size declaration
512         and use the one from WebKit.pri instead.
513
514 2010-07-01  Adam Barth  <abarth@webkit.org>
515
516         Reviewed by Eric Seidel.
517
518         Promote webkit-patch land-safely to main help
519         https://bugs.webkit.org/show_bug.cgi?id=41446
520
521         I've been using this command a bunch and recommending it to folks.  We
522         should show it in main help as it's past the experimental phase.
523
524         * Scripts/webkitpy/tool/commands/upload.py:
525
526 2010-06-28  MORITA Hajime  <morrita@google.com>
527
528         Reviewed by Shinichiro Hamaji.
529
530         rebaseline-chromium-webkit-tests doesn't do diffs right with a Git checkout of WebKit
531         https://bugs.webkit.org/show_bug.cgi?id=38775
532
533         - Introduced SCM.show_head() and SCM.diff_for_file().
534         - Replaced direct svn invocations with newly implement SCM methods.
535
536         * Scripts/webkitpy/common/checkout/scm.py:
537         * Scripts/webkitpy/common/checkout/scm_unittest.py:
538         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
539
540 2010-06-30  Simon Fraser  <simon.fraser@apple.com>
541
542         Reviewed by Sam Weinig.
543
544         Allow MiniBrowser to open local files
545         https://bugs.webkit.org/show_bug.cgi?id=41104
546
547         Wire up the openDocument: message with an NSOpenPanel, so we can open
548         local files.
549         
550         Also change the xib so that the window remembers its size.
551         
552         * MiniBrowser/mac/AppDelegate.m:
553         (-[BrowserAppDelegate frontmostBrowserWindowController]):
554         (-[BrowserAppDelegate openDocument:]):
555         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
556         * MiniBrowser/mac/English.lproj/BrowserWindow.xib:
557
558 2010-06-30  Sam Weinig  <sam@webkit.org>
559
560         Rubber-stamped by Anders Carlsson.
561
562         Add debug-webkittestrunner and cleanup related scripts.
563
564         * Scripts/debug-webkittestrunner: Added.
565         * Scripts/run-webkittestrunner:
566         * Scripts/webkitdirs.pm:
567
568 2010-06-30  Kevin Ollivier  <kevino@theolliviers.com>
569
570         [wx] Build fix after recent changes to LayoutTestController.
571
572         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
573         (LayoutTestController::pageSizeAndMarginsInPixels):
574
575 2010-06-29  Sam Weinig  <sam@webkit.org>
576
577         Reviewed by Anders Carlsson.
578
579         Patch for https://bugs.webkit.org/show_bug.cgi?id=41389
580         Make WebKitTestRunner work with more than one test at a time.
581
582         This converts WebKitTestRunner to a similar model as DumpRenderTree,
583         where there is a single WKView and each test is run it, rather than
584         the design I was using where each test got its own WKView.
585
586         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
587         (WTR::InjectedBundle::didRecieveMessage):
588         (WTR::InjectedBundle::reset):
589         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::TestController::initialize):
592         (WTR::TestController::runTest):
593         (WTR::TestController::_didRecieveMessageFromInjectedBundle):
594         (WTR::TestController::didRecieveMessageFromInjectedBundle):
595         * WebKitTestRunner/TestController.h:
596         (WTR::TestController::mainWebView):
597         (WTR::TestController::pageNamespace):
598         (WTR::TestController::context):
599         * WebKitTestRunner/TestInvocation.cpp:
600         (WTR::TestInvocation::TestInvocation):
601         (WTR::TestInvocation::~TestInvocation):
602         (WTR::TestInvocation::invoke):
603         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
604         * WebKitTestRunner/TestInvocation.h:
605
606 2010-06-30  Simon Hausmann  <simon.hausmann@nokia.com>
607
608         Reviewed by Laszlo Gombos.
609
610         [Qt][Symbian] Only 10 websites can be loaded consecutively when using QtWebkit 2.0
611         https://bugs.webkit.org/show_bug.cgi?id=40446
612
613         We quickly run out of memory on Symbian when loading web pages. This is
614         caused by the default heap size, which is not suited for a web browser.
615
616         This change bumps the max heap size to 32MB.
617
618         * QtTestBrowser/QtTestBrowser.pro:
619
620 2010-06-30  Eric Seidel  <eric@webkit.org>
621
622         Reviewed by Adam Barth.
623
624         webkit-patch land allow the user to continue even if the builders are red
625         https://bugs.webkit.org/show_bug.cgi?id=41395
626
627         I don't think it's good that we've been teaching people
628         to always pass --ignore-builders.  At least land is now
629         useable w/o --ignore-builders.
630
631         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
632
633 2010-06-29  Robert Hogan  <robert@webkit.org>
634
635         Reviewed by Kenneth Rohde Christiansen.
636
637         [Qt] support dumpResourceResponseMIMETypes
638         https://bugs.webkit.org/show_bug.cgi?id=41260
639
640         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
641         (LayoutTestController::reset):
642         (LayoutTestController::dumpResourceResponseMIMETypes):
643         * DumpRenderTree/qt/LayoutTestControllerQt.h:
644
645 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
646
647         Reviewed by Kenneth Rohde Christiansen.
648
649         [Qt] Resize scene when Qt DRT WebPage receives a geometry change request
650         https://bugs.webkit.org/show_bug.cgi?id=41173
651
652         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
653         (WebCore::WebPage::setViewGeometry):
654         * DumpRenderTree/qt/DumpRenderTreeQt.h:
655
656 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
657
658         Reviewed by Simon Hausmann.
659
660         [Qt] Deal with postEvent in case of graphics based DRT
661         https://bugs.webkit.org/show_bug.cgi?id=41174
662
663         QGraphicsScene does not have a postEvent method, so make scene
664         send the event, in case of graphics based DRT, and delete it after that.
665
666         * DumpRenderTree/qt/EventSenderQt.cpp:
667         (EventSender::scheduleAsynchronousClick):
668         (EventSender::replaySavedEvents):
669         (EventSender::postEvent):
670         * DumpRenderTree/qt/EventSenderQt.h:
671
672 2010-06-29  Diego Gonzalez  <diegohcg@webkit.org>
673
674         Reviewed by Kenneth Rohde Christiansen.
675
676         [Qt] Make switchFocus() method works with QGraphicsWebView in Qt DRT
677         https://bugs.webkit.org/show_bug.cgi?id=41172
678
679         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
680         (WebCore::DumpRenderTree::switchFocus):
681
682 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
683
684         Reviewed by Xan Lopez.
685
686         [Gtk] Make DRT more coherent with other ports to allow reusing more tests
687         https://bugs.webkit.org/show_bug.cgi?id=40009
688
689         Make sure "AXRole: ", "AXTitle: " and "AXDescription: " prefixes
690         are used when returning those values, for coherency with other ports.
691
692         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
693         (AccessibilityUIElement::role):
694         (AccessibilityUIElement::title):
695         (AccessibilityUIElement::description):
696
697 2010-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
698
699         Unreviewed, rolling out r62106.
700         http://trac.webkit.org/changeset/62106
701         https://bugs.webkit.org/show_bug.cgi?id=41346
702
703         "Broke editing tests" (Requested by xan_ on #webkit).
704
705         * Scripts/old-run-webkit-tests:
706
707 2010-06-29  Mario Sanchez Prada  <msanchez@igalia.com>
708
709         Reviewed by Xan Lopez.
710
711         Ensure DRT loads GAIL (Gtk+ module), for a11y tests
712         https://bugs.webkit.org/show_bug.cgi?id=38648
713
714         Add the GTK_MODULES envvar (set to "gail") to the clean
715         environment when running DRT for the Gtk+ port
716
717         * Scripts/old-run-webkit-tests:
718
719 2010-06-28  Adam Barth  <abarth@webkit.org>
720
721         Unreviewed.
722
723         Switch test-html5-parser back to using runner.html.
724
725         * Scripts/test-html5-parser:
726
727 2010-06-28  Adam Barth  <abarth@webkit.org>
728
729         Reviewed by Eric Seidel.
730
731         Restore webkit-runner.html for use with new tree builder
732         https://bugs.webkit.org/show_bug.cgi?id=41317
733
734         For now, we just want to run webkit-runner when we test-html5-parser.
735
736         * Scripts/test-html5-parser:
737
738 2010-06-23  John Gregg  <johnnyg@google.com>
739
740         Reviewed by Kent Tamura.
741
742         add ENABLE_DIRECTORY_UPLOAD build support
743         https://bugs.webkit.org/show_bug.cgi?id=41100
744
745         * Scripts/build-webkit:
746
747 2010-06-28  Gustavo Noronha Silva  <gns@gnome.org>
748
749         Rubber-stamped by Xan Lopez.
750
751         Update webkitdirs's knowledge of our library's name.
752
753         * Scripts/webkitdirs.pm:
754
755 2010-06-28  Sam Weinig  <sam@webkit.org>
756
757         Reviewed by Anders Carlsson.
758
759         Patch for https://bugs.webkit.org/show_bug.cgi?id=41299
760         Build up WebKitTestRunner output in the InjectedBundle
761
762         Simplify WebKitTestRunner by building up the output in the InjectedBundle
763         and sending it over postMessage when done, instead of using the async
764         WKPageRenderTreeExternalRepresentation.
765
766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
767         (WTR::InjectedBundle::done):
768         (WTR::InjectedBundle::didRecieveMessage):
769         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
770         (WTR::InjectedBundle::os):
771         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
772         (WTR::WKStringToUTF8):
773         (WTR::InjectedBundlePage::didFinishLoadForFrame):
774         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
775         * WebKitTestRunner/TestInvocation.cpp:
776         (WTR::WKStringToUTF8):
777         (WTR::TestInvocation::TestInvocation):
778         (WTR::TestInvocation::invoke):
779         (WTR::TestInvocation::initializeMainWebView):
780         (WTR::TestInvocation::_didRecieveMessageFromInjectedBundle):
781         (WTR::TestInvocation::didRecieveMessageFromInjectedBundle):
782         * WebKitTestRunner/TestInvocation.h:
783
784 2010-06-28  Robert Hogan  <robert@webkit.org>
785
786         Unreviewed, rolling out r62021.
787         http://trac.webkit.org/changeset/62021
788         https://bugs.webkit.org/show_bug.cgi?id=41261
789
790         Broke http/navigation tests among other
791
792         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
793         (WebCore::DumpRenderTree::dumpFramesAsText):
794
795 2010-06-28  Sam Weinig  <sam@webkit.org>
796
797         Reviewed by Anders Carlsson.
798
799         Add run-webkittestrunner to run WebKitTestRunner with the appropriate
800         environment.
801
802         * Scripts/run-webkittestrunner: Added.
803         * Scripts/webkitdirs.pm:
804
805 2010-06-28  Robert Hogan  <robert@webkit.org>
806
807         Reviewed by Kenneth Rohde Christiansen.
808
809         [Qt] dump frames in ascending alphabetical order of title
810
811         https://bugs.webkit.org/show_bug.cgi?id=41261
812
813         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
814         (WebCore::DumpRenderTree::dumpFramesAsText):
815
816 2010-06-28  Robert Hogan  <robert@webkit.org>
817
818         Reviewed by Kenneth Rohde Christiansen.
819
820         [Qt] dump bf history of child windows
821
822         https://bugs.webkit.org/show_bug.cgi?id=41266
823
824         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
825         (WebCore::DumpRenderTree::dumpBackForwardList):
826         (WebCore::DumpRenderTree::dump):
827         * DumpRenderTree/qt/DumpRenderTreeQt.h:
828
829 2010-06-28  Sam Weinig  <sam@webkit.org>
830
831         Reviewed by Anders Carlsson.
832
833         Patch for https://bugs.webkit.org/show_bug.cgi?id=41288
834         WebKit2: Add frame API for InjectedBundle code
835
836         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
837         (_didClearWindowForFrame):
838
839 2010-06-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
840
841         Reviewed by Kenneth Rohde Christiansen.
842
843         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
844         https://bugs.webkit.org/show_bug.cgi?id=38597
845
846         Fix behavior so reload button really acts as a load and a reload button.
847
848         * QtTestBrowser/mainwindow.cpp:
849         (MainWindow::changeLocation):
850
851 2010-06-28  Xan Lopez  <xlopez@igalia.com>
852
853         Reviewed by Gustavo Noronha.
854
855         [GTK] Does not compile with -DGSEAL_ENABLE
856         https://bugs.webkit.org/show_bug.cgi?id=37851
857
858         Fix build with GSEAL enabled.
859
860         * DumpRenderTree/gtk/EventSender.cpp:
861         (gtk_widget_get_window):
862         (prepareMouseButtonEvent):
863         (mouseMoveToCallback):
864         (mouseWheelToCallback):
865         (keyDownCallback):
866
867 2010-06-28  Xan Lopez  <xlopez@igalia.com>
868
869         Reviewed by Gustavo Noronha.
870
871         [GTK] Add support for GTK+3
872         https://bugs.webkit.org/show_bug.cgi?id=41253
873
874         Adapt build system for 3.x support.
875
876         * GNUmakefile.am:
877
878 2010-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
879
880         Reviewed by Simon Hausmann.
881
882         [QT][S60] build-webkit scripts picks wrong make spec for windows build
883         https://bugs.webkit.org/show_bug.cgi?id=41198
884
885         Instead of checking for existence of %EPOCROOT% on windows, mandatory use of --symbian flag for symbian builds. 
886
887         * Scripts/webkitdirs.pm:
888         (determineIsSymbian): remove check for %EPOCROOT% as one can build for windows port of QT as well
889
890 2010-06-28  Eric Seidel  <eric@webkit.org>
891
892         Reviewed by Adam Barth.
893
894         Make it possible to test the new HTML5 TreeBuilder
895         https://bugs.webkit.org/show_bug.cgi?id=41276
896
897         Adam was concerned that someone might make their port
898         depend on this setting (I guess we had some trouble with that
899         with the HTML5Parser setting), so I littered the code with warnings.
900
901         test-html5-parser now tests this code path.
902
903         * DumpRenderTree/mac/DumpRenderTree.mm:
904         (resetDefaultsToConsistentValues):
905         (initializeGlobalsFromCommandLineOptions):
906         * Scripts/test-html5-parser:
907
908 2010-06-27  MORITA Hajime  <morrita@google.com>
909
910         Unreviewed. 
911         
912         Some never-called @staticmethods touched self. 
913         Fixed it to replace these self with a class.
914
915         * Scripts/webkitpy/common/checkout/scm.py:
916
917 2010-06-27  MORITA Hajime  <morrita@google.com>
918
919         Unreviewed.
920         
921         Fixed exception raising syntax that is pointed out at
922         https://bugs.webkit.org/show_bug.cgi?id=41153
923
924         * Scripts/webkitpy/common/checkout/scm.py:
925         * Scripts/webkitpy/common/checkout/scm_unittest.py: 
926           Removed a bad line that I accidentally checked-in at last revision.
927
928 2010-06-24  MORITA Hajime  <morrita@google.com>
929
930         Reviewed by Eric Seidel.
931
932         rebaseline-chromium-webkit-tests should add or remove files to local git repository
933         https://bugs.webkit.org/show_bug.cgi?id=41153
934
935         - Added SCM.add() and SCM.remove()
936         - Replaced "svn add" and "svn remove"
937           rebaseline_chromium_webkit_tests.py: in with SCM method equivalents.
938         - add "-U" and "-q" options to rebaseline_chromium_webkit_tests.py
939           for debugging purpose.
940
941         * Scripts/webkitpy/common/checkout/scm.py:
942         * Scripts/webkitpy/common/checkout/scm_unittest.py:
943         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
944
945 2010-06-25  Yuzo Fujishima  <yuzo@google.com>
946
947         Reviewed by Shinichiro Hamaji.
948
949         Improve default value handling for page format properties.
950         https://bugs.webkit.org/show_bug.cgi?id=41150
951
952         * DumpRenderTree/LayoutTestController.cpp:
953         (parsePageNumber):
954         (parsePageNumberSizeMarings):
955         (pageSizeAndMarginsInPixelsCallback):
956         (LayoutTestController::staticFunctions):
957         * DumpRenderTree/LayoutTestController.h:
958         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
959         (LayoutTestController::pageSizeAndMarginsInPixels):
960         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
961         (LayoutTestController::pageSizeAndMarginsInPixels):
962         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
963         (LayoutTestController::pageSizeAndMarginsInPixels):
964
965 2010-06-21  Robert Hogan  <robert@webkit.org>
966
967         Reviewed by Kenneth Rohde Christiansen.
968
969         [Qt] DRT Support for setCustomPolicyDelegate
970
971         https://bugs.webkit.org/show_bug.cgi?id=39564
972
973         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
974         (LayoutTestController::setCustomPolicyDelegate):
975         * DumpRenderTree/qt/LayoutTestControllerQt.h:
976
977 2010-06-26  Robert Hogan  <robert@webkit.org>
978
979         Unreviewed, Qt build fix following http://trac.webkit.org/changeset/61879
980         
981         Remove qwebscriptworld.h from LayoutTestControllerQt.cpp - it is no longer
982         exported.
983
984         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
985
986 2010-06-26  Tony Gentilcore  <tonyg@chromium.org>
987
988         Reviewed by Dimitri Glazkov.
989
990         Add a build-webkit option for enabling Web Timing support.
991         https://bugs.webkit.org/show_bug.cgi?id=38924
992
993         * Scripts/build-webkit:
994
995 2010-06-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
996
997         Reviewed by Kenneth Rohde Christiansen.
998
999         [Qt] QtTestBrowser does not have a "Load" button ; therefore, unable to load pages on touch only symbian devices (portrait mode).
1000         https://bugs.webkit.org/show_bug.cgi?id=38597
1001
1002         Make the reload button act as a load button as well.
1003
1004         * QtTestBrowser/mainwindow.cpp:
1005         (MainWindow::buildUI):
1006         (MainWindow::changeLocation):
1007
1008 2010-06-25  Prasad Tammana  <prasadt@chromium.org>
1009
1010         Reviewed by Dmitry Titov.
1011
1012         Add empty abortModal() method to all platforms.
1013         https://bugs.webkit.org/show_bug.cgi?id=40864
1014
1015         Add an empty abortModal() stub to LayoutTestController on all platforms to get rid of platform specific #ifs in
1016         platform independent LayoutTestController code.  Without this change, layout tests using LayoutTestController tests
1017         that use abortModal will become mac specific which is not desirable.
1018
1019         * DumpRenderTree/LayoutTestController.cpp:
1020         (abortModalCallback):
1021         (LayoutTestController::staticFunctions):
1022         * DumpRenderTree/LayoutTestController.h:
1023         * DumpRenderTree/chromium/LayoutTestController.cpp:
1024         (LayoutTestController::LayoutTestController):
1025         (LayoutTestController::abortModal):
1026         * DumpRenderTree/chromium/LayoutTestController.h:
1027         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1028         (LayoutTestController::abortModal):
1029         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1030         (LayoutTestController::abortModal):
1031         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1032         (LayoutTestController::abortModal):
1033         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1034         (LayoutTestController::abortModal):
1035
1036 2010-06-25  Sam Weinig  <sam@webkit.org>
1037
1038         Reviewed by Anders Carlsson.
1039
1040         Patch for https://bugs.webkit.org/show_bug.cgi?id=41226
1041         Flesh out injected bundle code for WebKitTestRunner and add basic LayoutTestController.
1042
1043         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Added.
1044         (WTR::InjectedBundle::shared):
1045         (WTR::InjectedBundle::InjectedBundle):
1046         (WTR::InjectedBundle::_didCreatePage):
1047         (WTR::InjectedBundle::_willDestroyPage):
1048         (WTR::InjectedBundle::_didRecieveMessage):
1049         (WTR::InjectedBundle::initialize):
1050         (WTR::InjectedBundle::didCreatePage):
1051         (WTR::InjectedBundle::willDestroyPage):
1052         (WTR::InjectedBundle::didRecieveMessage):
1053         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added.
1054         (WTR::InjectedBundle::layoutTestController):
1055         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1056         (WKBundleInitialize):
1057         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Added.
1058         (WTR::InjectedBundlePage::InjectedBundlePage):
1059         (WTR::InjectedBundlePage::~InjectedBundlePage):
1060         (WTR::InjectedBundlePage::_didStartProvisionalLoadForFrame):
1061         (WTR::InjectedBundlePage::_didReceiveServerRedirectForProvisionalLoadForFrame):
1062         (WTR::InjectedBundlePage::_didFailProvisionalLoadWithErrorForFrame):
1063         (WTR::InjectedBundlePage::_didCommitLoadForFrame):
1064         (WTR::InjectedBundlePage::_didFinishLoadForFrame):
1065         (WTR::InjectedBundlePage::_didFailLoadWithErrorForFrame):
1066         (WTR::InjectedBundlePage::_didReceiveTitleForFrame):
1067         (WTR::InjectedBundlePage::_didClearWindowForFrame):
1068         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1069         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1070         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1071         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1072         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1073         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1074         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1075         (WTR::InjectedBundlePage::didClearWindowForFrame):
1076         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added.
1077         (WTR::InjectedBundlePage::page):
1078         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Added.
1079         (WTR::LayoutTestController::create):
1080         (WTR::LayoutTestController::LayoutTestController):
1081         (WTR::LayoutTestController::~LayoutTestController):
1082         (WTR::dumpAsTextCallback):
1083         (WTR::layoutTestControllerObjectFinalize):
1084         (WTR::LayoutTestController::makeWindowObject):
1085         (WTR::LayoutTestController::getJSClass):
1086         (WTR::LayoutTestController::staticFunctions):
1087         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added.
1088         (WTR::LayoutTestController::dumpAsText):
1089         (WTR::LayoutTestController::setDumpAsText):
1090         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1091
1092 2010-06-25  Sam Weinig  <sam@webkit.org>
1093
1094         Reviewed by Anders Carlsson.
1095
1096         Make WebKitTestRunner really work with run-webkit-tests. 
1097
1098         - Add Forwarding headers to allow some cleanup.
1099
1100         * WebKitTestRunner/ForwardingHeaders: Added.
1101         * WebKitTestRunner/ForwardingHeaders/wtf: Added.
1102         * WebKitTestRunner/ForwardingHeaders/wtf/ASCIICType.h: Added.
1103         * WebKitTestRunner/ForwardingHeaders/wtf/Assertions.h: Added.
1104         * WebKitTestRunner/ForwardingHeaders/wtf/Atomics.h: Added.
1105         * WebKitTestRunner/ForwardingHeaders/wtf/FastMalloc.h: Added.
1106         * WebKitTestRunner/ForwardingHeaders/wtf/HashMap.h: Added.
1107         * WebKitTestRunner/ForwardingHeaders/wtf/HashSet.h: Added.
1108         * WebKitTestRunner/ForwardingHeaders/wtf/HashTraits.h: Added.
1109         * WebKitTestRunner/ForwardingHeaders/wtf/Locker.h: Added.
1110         * WebKitTestRunner/ForwardingHeaders/wtf/MainThread.h: Added.
1111         * WebKitTestRunner/ForwardingHeaders/wtf/MathExtras.h: Added.
1112         * WebKitTestRunner/ForwardingHeaders/wtf/Noncopyable.h: Added.
1113         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtr.h: Added.
1114         * WebKitTestRunner/ForwardingHeaders/wtf/OwnPtrCommon.h: Added.
1115         * WebKitTestRunner/ForwardingHeaders/wtf/PassOwnPtr.h: Added.
1116         * WebKitTestRunner/ForwardingHeaders/wtf/PassRefPtr.h: Added.
1117         * WebKitTestRunner/ForwardingHeaders/wtf/Platform.h: Added.
1118         * WebKitTestRunner/ForwardingHeaders/wtf/RefCounted.h: Added.
1119         * WebKitTestRunner/ForwardingHeaders/wtf/RefPtr.h: Added.
1120         * WebKitTestRunner/ForwardingHeaders/wtf/RetainPtr.h: Added.
1121         * WebKitTestRunner/ForwardingHeaders/wtf/StringExtras.h: Added.
1122         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
1123         * WebKitTestRunner/ForwardingHeaders/wtf/Threading.h: Added.
1124         * WebKitTestRunner/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.
1125         * WebKitTestRunner/ForwardingHeaders/wtf/Vector.h: Added.
1126         * WebKitTestRunner/TestInvocation.cpp:
1127         (WTR::TestInvocation::dump): Dump the right number of #EOFs.
1128         * WebKitTestRunner/TestInvocation.h:
1129
1130 2010-06-25  Sam Weinig  <sam@webkit.org>
1131
1132         Reviewed by Mark Rowe.
1133
1134         Add support for WebKitTestRunner to old-run-webkit-tests
1135
1136         - Also adds a script to build WebKitTestRunner for old-run-webkit-tests to use.
1137
1138         * Scripts/build-webkittestrunner: Added.
1139         * Scripts/old-run-webkit-tests:
1140
1141 2010-06-25  Adam Barth  <abarth@webkit.org>
1142
1143         Reviewed by David Levin.
1144
1145         Incremental build failed on Chromium ews
1146         https://bugs.webkit.org/show_bug.cgi?id=41011
1147
1148         The division of responsibility between update-webkit --chromium and
1149         build-webkit --chromium is slightly unclear.  In this patch, we make
1150         build-webkit --chromium also update DEPS and re-run GYP in case the
1151         developer has changed either since they updated.
1152
1153         This change is also helpful for the EWS, which wants to update DEPS and
1154         re-run GYP after applying patches, but the EWS doesn't want to run
1155         update-webkit --chromium because it has a dirty working copy.
1156
1157         * Scripts/webkitdirs.pm:
1158
1159 2010-06-25  Robert Hogan  <robert@webkit.org>
1160
1161         Reviewed by Simon Hausmann.
1162
1163         [Qt] Support evaluateScriptInIsolatedWorld()
1164
1165         https://bugs.webkit.org/show_bug.cgi?id=40079
1166
1167         Remove evaluateScriptInIsolatedWorld() from QtWebKit API.
1168         Remove QWebScriptWorld from exported headers.
1169         Confine support to DumpRenderTreeSupportQt so that the tests can pass.
1170
1171         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1172         (LayoutTestController::reset):
1173         (LayoutTestController::evaluateScriptInIsolatedWorld):
1174         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1175
1176 2010-06-25  Anders Carlsson  <andersca@apple.com>
1177
1178         Revert accidental part and add a newline.
1179
1180         * MiniBrowser/mac/AppDelegate.m:
1181         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1182
1183 2010-06-25  Anders Carlsson  <andersca@apple.com>
1184
1185         Rubber-stamped by Dan Bernstein.
1186
1187         Add a LOG macro that expands to a no-op by default.
1188
1189         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1190         * MiniBrowser/mac/AppDelegate.m:
1191         (_didRecieveMessageFromInjectedBundle):
1192         * MiniBrowser/mac/BrowserWindowController.m:
1193         (-[BrowserWindowController windowShouldClose:]):
1194         (_didStartProvisionalLoadForFrame):
1195         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1196         (_didFailProvisionalLoadWithErrorForFrame):
1197         (_didCommitLoadForFrame):
1198         (_didFinishLoadForFrame):
1199         (_didFailLoadWithErrorForFrame):
1200         (_didReceiveTitleForFrame):
1201         (_didFirstLayoutForFrame):
1202         (_didFirstVisuallyNonEmptyLayoutForFrame):
1203         (_didBecomeUnresponsive):
1204         (_didBecomeResponsive):
1205         (_decidePolicyForNavigationAction):
1206         (_decidePolicyForNewWindowAction):
1207         (_createNewPage):
1208         (_showPage):
1209         (_closePage):
1210         (_didNavigateWithNavigationData):
1211         (_didPerformClientRedirect):
1212         (_didPerformServerRedirect):
1213         (_didUpdateHistoryTitle):
1214         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1215         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1216         (_didClearWindowForFrame):
1217         (_didCreatePage):
1218         (_willDestroyPage):
1219         (_didRecieveMessage):
1220
1221 2010-06-24  Adam Barth  <abarth@webkit.org>
1222
1223         Reviewed by Eric Seidel.
1224
1225         commit-queue is taking too long to land patches because of red trees
1226         https://bugs.webkit.org/show_bug.cgi?id=41194
1227
1228         Instead of checking for the tree to be green, we'll just spin hot
1229         trying to land patches.  This is probably too extreme in ignoring the
1230         tree, but I think we should try it for a while to see if we have
1231         trouble.  That will help us find the right balance.
1232
1233         * Scripts/webkitpy/tool/commands/queues.py:
1234         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1235
1236 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1237
1238         Reviewed by Xan Lopez.
1239
1240         [GTK] Clean up the use of gdk_window_get_root_coords in EventSender
1241         https://bugs.webkit.org/show_bug.cgi?id=40843
1242
1243         Define the version for old GTK+s in a way that is forward-compatible
1244         and clean up the logic a bit.
1245
1246         * DumpRenderTree/gtk/EventSender.cpp:
1247         (gdk_window_get_root_coords): Renamed and cleaned up.
1248         (prepareMouseButtonEvent): Remove #ifdefs.
1249         (mouseMoveToCallback): Remove #ifdefs.
1250
1251 2010-06-24  Dimitri Glazkov  <dglazkov@chromium.org>
1252
1253         Reviewed by Eric Seidel.
1254
1255         Fix NewRunWebKitTests to work on Windows.
1256         https://bugs.webkit.org/show_bug.cgi?id=41180
1257
1258         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added "perl" as first arguments,
1259             because Windows fails to understand what we're asking of it.
1260
1261 2010-06-24  Martin Robinson  <mrobinson@igalia.com>
1262
1263         Reviewed by Xan Lopez.
1264
1265         [GTK] The url passed to the WebView during layout tests is invalid
1266         https://bugs.webkit.org/show_bug.cgi?id=40832
1267
1268         Set the test URL to the full real file URL and do a small cleanup.
1269         Previously a URL like file://relative/path/to/test.html was passed
1270         to the WebView. This malformed file URL would be returned by
1271         webkit_web_view_get_url and webkit_web_frame_get_url.
1272
1273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1274         (shouldLogFrameLoadDelegates): Change to take a const string& as the argument.
1275         (shouldOpenWebInspector): Change to take a const string& as the argument.
1276         (shouldEnableDeveloperExtras): Change to take a const string& as the argument.
1277         (runTest): Pass the full file:// URL to the view. Remove the superfluous url variable.
1278
1279 2010-06-24  Sam Weinig  <sam@webkit.org>
1280
1281         Reviewed by Anders Carlsson.
1282
1283         Fix WebKitTestRunner Makefile typos.
1284
1285         * WebKitTestRunner/Makefile:
1286
1287 2010-06-24  Adele Peterson  <adele@apple.com>
1288
1289         Reviewed by Eric Carlson.
1290
1291         DumpRenderTree part of testing <rdar://problem/8093680> "Paste and Match Style" should fire paste events
1292         https://bugs.webkit.org/show_bug.cgi?id=41085
1293
1294         * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
1295         Clear the general pasteboard in between tests so Cut,Copy, and setData on ClipboardData won't have lasting effects.
1296
1297 2010-06-23  Sam Weinig  <sam@webkit.org>
1298
1299         Reviewed by Anders Carlsson.
1300
1301         Patch for https://bugs.webkit.org/show_bug.cgi?id=41086
1302         Add new WebKitTestRunner project (ie. DRT for WebKit2).
1303
1304         - Mac only.
1305         - run-webkit-tests has not been modified to call it yet.
1306         - Only dumps the render tree at this time. 
1307
1308         * WebKitTestRunner: Added.
1309         * WebKitTestRunner/Configurations: Added.
1310         * WebKitTestRunner/Configurations/Base.xcconfig: Added.
1311         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Added.
1312         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Added.
1313         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Added.
1314         * WebKitTestRunner/InjectedBundle: Added.
1315         * WebKitTestRunner/InjectedBundle-Info.plist: Added.
1316         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Added.
1317         (_didStartProvisionalLoadForFrame):
1318         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1319         (_didFailProvisionalLoadWithErrorForFrame):
1320         (_didCommitLoadForFrame):
1321         (_didFinishLoadForFrame):
1322         (_didFailLoadWithErrorForFrame):
1323         (_didReceiveTitleForFrame):
1324         (_didClearWindow):
1325         (_didCreatePage):
1326         (_willDestroyPage):
1327         (_didRecieveMessage):
1328         (WKBundleInitialize):
1329         * WebKitTestRunner/Makefile: Added.
1330         * WebKitTestRunner/PlatformWebView.h: Added.
1331         (WTR::PlatformWebView::platformView):
1332         * WebKitTestRunner/TestController.cpp: Added.
1333         (WTR::TestController::shared):
1334         (WTR::TestController::TestController):
1335         (WTR::TestController::initialize):
1336         (WTR::TestController::runTest):
1337         (WTR::TestController::runTestingServerLoop):
1338         (WTR::TestController::run):
1339         * WebKitTestRunner/TestController.h: Added.
1340         (WTR::TestController::verbose):
1341         (WTR::TestController::injectedBundlePath):
1342         * WebKitTestRunner/TestInvocation.cpp: Added.
1343         (WTR::createWKURL):
1344         (WTR::TestInvocation::TestInvocation):
1345         (WTR::TestInvocation::~TestInvocation):
1346         (WTR::TestInvocation::invoke):
1347         (WTR::TestInvocation::dump):
1348         (WTR::TestInvocation::initializeMainWebView):
1349         (WTR::TestInvocation::didStartProvisionalLoadForFrame):
1350         (WTR::TestInvocation::didReceiveServerRedirectForProvisionalLoadForFrame):
1351         (WTR::TestInvocation::didFailProvisionalLoadWithErrorForFrame):
1352         (WTR::TestInvocation::didCommitLoadForFrame):
1353         (WTR::TestInvocation::didFinishLoadForFrame):
1354         (WTR::TestInvocation::didFailLoadForFrame):
1355         (WTR::TestInvocation::renderTreeExternalRepresentationFunction):
1356         (WTR::TestInvocation::renderTreeExternalRepresentationDisposeFunction):
1357         * WebKitTestRunner/TestInvocation.h: Added.
1358         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added.
1359         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added.
1360         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Added.
1361         * WebKitTestRunner/mac: Added.
1362         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Added.
1363         (WTR::PlatformWebView::PlatformWebView):
1364         (WTR::PlatformWebView::~PlatformWebView):
1365         (WTR::PlatformWebView::page):
1366         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
1367         (WTR::TestInvocation::runUntil):
1368         * WebKitTestRunner/mac/main.mm: Added.
1369         (main):
1370
1371 2010-06-24  Luiz Agostini  <luiz.agostini@openbossa.org>
1372
1373         Unreviewed. Adding myself to the committers list.
1374
1375         * Scripts/webkitpy/common/config/committers.py:
1376
1377 2010-06-23  Kevin Ollivier  <kevino@theolliviers.com>
1378
1379         [wx] Build fix, adding new LayoutTestController methods and enabling SVG_FOREIGN_OBJECT.
1380
1381         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1382         (LayoutTestController::isPageBoxVisible):
1383         (LayoutTestController::pageAreaRectInPixels):
1384         (LayoutTestController::preferredPageSizeInPixels):
1385         * wx/build/settings.py:
1386
1387 2010-06-23  James Robinson  <jamesr@chromium.org>
1388
1389         Unreviewed.  Add my IRC handle to committers.py so the sheriffbot can yell at me.
1390
1391         * Scripts/webkitpy/common/config/committers.py:
1392
1393 2010-06-23  Kent Tamura  <tkent@chromium.org>
1394
1395         Reviewed by Dimitri Glazkov.
1396
1397         Correct Chromium test configuration
1398         https://bugs.webkit.org/show_bug.cgi?id=41057
1399
1400         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1401          - Add "--use-drt" option for NRWT. It is required for Chromium and
1402            ignored for other platforms.
1403          - Skip JSC test on Chromium
1404         * BuildSlaveSupport/test-result-archive:
1405           Add Chromium support.
1406
1407 2010-06-23  Sam Weinig  <sam@webkit.org>
1408
1409         Reviewed by Anders Carlsson.
1410
1411         Fix for https://bugs.webkit.org/show_bug.cgi?id=41073
1412         WebKit2: Flesh out more of the InjectedBundle client API
1413
1414         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1415         (_didStartProvisionalLoadForFrame):
1416         (_didReceiveServerRedirectForProvisionalLoadForFrame):
1417         (_didFailProvisionalLoadWithErrorForFrame):
1418         (_didCommitLoadForFrame):
1419         (_didFinishLoadForFrame):
1420         (_didFailLoadWithErrorForFrame):
1421         (_didReceiveTitleForFrame):
1422         (_didClearWindowForFrame):
1423         (_didCreatePage):
1424         (_willDestroyPage):
1425         (WKBundleInitialize):
1426
1427 2010-06-23  Yuzo Fujishima  <yuzo@google.com>
1428
1429         Reviewed by Shinichiro Hamaji.
1430
1431         Implement page format data programming interface.
1432         Add methods for testing.
1433         https://bugs.webkit.org/show_bug.cgi?id=37538
1434
1435         * DumpRenderTree/LayoutTestController.cpp:
1436         (parsePageNumber):
1437         (isPageBoxVisibleCallback):
1438         (pageAreaRectInPixelsCallback):
1439         (preferredPageSizeInPixelsCallback):
1440         (LayoutTestController::staticFunctions):
1441         * DumpRenderTree/LayoutTestController.h:
1442         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1443         (LayoutTestController::isPageBoxVisible):
1444         (LayoutTestController::pageAreaRectInPixels):
1445         (LayoutTestController::preferredPageSizeInPixels):
1446         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1447         (LayoutTestController::isPageBoxVisible):
1448         (LayoutTestController::pageAreaRectInPixels):
1449         (LayoutTestController::preferredPageSizeInPixels):
1450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1451         (LayoutTestController::isPageBoxVisible):
1452         (LayoutTestController::pageAreaRectInPixels):
1453         (LayoutTestController::preferredPageSizeInPixels):
1454
1455 2010-06-23  Sam Magnuson  <smagnuson@netflix.com>
1456
1457         Reviewed by Shinichiro Hamaji.
1458
1459         Follow proper convention for if/switch/while as I've discovered
1460         them to be through my review processes.
1461         https://bugs.webkit.org/show_bug.cgi?id=40723
1462
1463         Modified test so that if( foo ) is not allowed as it appears not
1464         to be the accepted convention.
1465
1466         * Scripts/webkitpy/style/checkers/cpp.py:
1467         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1468
1469 2010-06-22  Eric Seidel  <eric@webkit.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         Run clean-header-guards to fix some header guards
1474         https://bugs.webkit.org/show_bug.cgi?id=41044
1475
1476         No functional changes, thus no tests.
1477
1478         This entire change was generated by running
1479         clean-header-guards, and then reverting changes
1480         to files which shouldn't be changed.  Those which
1481         are left all should be updated.
1482
1483         Some of these changes are just fixing 755 permissions
1484         to be 644, since it seems various files have the wrong
1485         execute bit which don't need it.  clean-header-guards
1486         made those (welcome) permission fixes unintentionally.
1487
1488         * DumpRenderTree/chromium/WebThemeControlDRT.h:
1489         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
1490         * QtTestBrowser/fpstimer.h:
1491
1492 2010-06-22  Adam Barth  <abarth@webkit.org>
1493
1494         Reviewed by Eric Seidel.
1495
1496         Rename HTMLDocumentParser to LegacyHTMLDocumentParser
1497         https://bugs.webkit.org/show_bug.cgi?id=41043
1498
1499         Update the hash.
1500
1501         * Scripts/do-webcore-rename:
1502
1503 2010-06-22  Sam Magnuson  <smagnuson@netflix.com>
1504
1505         Reviewed by Shinichiro Hamaji.
1506
1507         Follow proper convention for variable declaration spacing.
1508         https://bugs.webkit.org/show_bug.cgi?id=40724
1509
1510         Modified test so that 'int   a;' is not allowed.
1511
1512         * Scripts/webkitpy/style/checkers/cpp.py:
1513         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1514
1515 2010-06-22  Eric Seidel  <eric@webkit.org>
1516
1517         Unreviewed.  Add Tony Gentilcore now that he's a committer.
1518
1519         * Scripts/webkitpy/common/config/committers.py:
1520
1521 2010-06-22  Eric Seidel  <eric@webkit.org>
1522
1523         Reviewed by Adam Barth.
1524
1525         Remove Gtk 64-Release bot from core since it's broken
1526         https://bugs.webkit.org/show_bug.cgi?id=41022
1527
1528         This bot alone has been responsible for more than 72 hours of
1529         commit-queue blockage in the last week.  The bot is broken -- keeps
1530         losing its display server or similar.  Until the Gtk folks can fix the
1531         bot, we need to remove it from core.  The WebKit community can't keep
1532         it green as is.
1533
1534         * Scripts/webkitpy/common/net/buildbot.py:
1535         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1536
1537 2010-06-21  Dumitru Daniliuc  <dumi@chromium.org>
1538
1539         Reviewed by Eric Seidel.
1540
1541         Fix the Windows build.
1542         https://bugs.webkit.org/show_bug.cgi?id=40972
1543
1544         * DumpRenderTree/win/ImageDiff.vcproj:
1545
1546 2010-06-21  Prasad Tammana  <prasadt@chromium.org>
1547
1548         Reviewed by Darin Adler, Dmitry Titov.
1549
1550         DumpRenderTree should allow tests with modal dialogs
1551         https://bugs.webkit.org/show_bug.cgi?id=35350
1552
1553         * DumpRenderTree/LayoutTestController.cpp:
1554         (abortModalCallback):
1555         (LayoutTestController::staticFunctions):
1556         * DumpRenderTree/LayoutTestController.h:
1557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1558         (LayoutTestController::abortModal):
1559         Add abortModal method to LayoutTestController and make it available from script.
1560
1561         * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog.
1562         (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call
1563         abortModal from when modal window closes.
1564         (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop.
1565
1566 2010-06-21  Simon Fraser  <simon.fraser@apple.com>
1567
1568         Reviewed by Anders Carlsson.
1569         
1570         Rename DrawingAreaProxyUpdateChunk to ChunkedUpdateDrawingArea
1571         https://bugs.webkit.org/show_bug.cgi?id=40948
1572         
1573         Have the script look in WebKit2.
1574
1575         * Scripts/do-webcore-rename:
1576
1577 2010-06-21  Robert Hogan  <robert@webkit.org>
1578
1579         Reviewed by Kenneth Rohde Christiansen.
1580
1581         [Qt] Unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html
1582
1583         It's a Mac-specific test so just add the required LayoutTestController
1584         function as a no-op to avoid failing. Similar approach adopted by other
1585         ports.
1586
1587         https://bugs.webkit.org/show_bug.cgi?id=33344
1588
1589         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1590         (LayoutTestController::addDisallowedURL):
1591
1592 2010-06-21  Sam Weinig  <sam@webkit.org>
1593
1594         Reviewed by Anders Carlsson.
1595
1596         Patch for https://bugs.webkit.org/show_bug.cgi?id=40940
1597         Add message passing support to the WebKit2 API.
1598
1599         - Add some test messages.
1600
1601         * MiniBrowser/mac/AppDelegate.m:
1602         (_didRecieveMessageFromInjectedBundle):
1603         (-[BrowserAppDelegate init]):
1604         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1605         (_didClearWindow):
1606         (_didCreatePage):
1607         (_didRecieveMessage):
1608         (WKBundleInitialize):
1609
1610 2010-06-21  Drew Wilson  <atwilson@chromium.org>
1611
1612         Unreviewed.
1613
1614         Rolling back 61551 and 61555 due to test failures.
1615
1616         * DumpRenderTree/LayoutTestController.cpp:
1617         (LayoutTestController::staticFunctions):
1618         * DumpRenderTree/LayoutTestController.h:
1619         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1620         (LayoutTestController::setEditingBehavior):
1621         * DumpRenderTree/mac/UIDelegate.mm:
1622
1623 2010-06-21  Anders Carlsson  <andersca@apple.com>
1624
1625         Reviewed by Sam Weinig.
1626
1627         Make DumpRenderTree build with clang++
1628
1629         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1630         (-[LocalPasteboard setPropertyList:forType:]):
1631         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1632         (-[DumpRenderTreeWindow keyDown:]):
1633         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1634         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1635         (LayoutTestController::isCommandEnabled):
1636
1637 2010-06-21  Satish Sampath  <satish@chromium.org>
1638
1639         Reviewed by Steve Block.
1640
1641         Speech Input Patch 0: Added compilation argument to conditionally compile pending patches.
1642         https://bugs.webkit.org/show_bug.cgi?id=40878
1643
1644         * Scripts/build-webkit:
1645
1646 2010-06-21  Kent Tamura  <tkent@chromium.org>
1647
1648         Reviewed by Dimitri Glazkov.
1649
1650         [DRT/Chromium] Initialization for http/tests/loading/
1651         https://bugs.webkit.org/show_bug.cgi?id=40902
1652
1653         * DumpRenderTree/chromium/TestShell.cpp:
1654         (TestShell::runFileTest):
1655
1656 2010-06-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1657
1658         Unreviewed.
1659
1660         Adding myself to the committers list.
1661
1662         * Scripts/webkitpy/common/config/committers.py:
1663
1664 2010-06-20  Kent Tamura  <tkent@chromium.org>
1665
1666         Reviewed by Dimitri Glazkov.
1667
1668         [DRT/Chromium] Add --allow-external-pages option
1669         https://bugs.webkit.org/show_bug.cgi?id=40762
1670
1671         Add --allow-external-pages introduced by Chromium r45403.
1672         http://src.chromium.org/viewvc/chrome?view=rev&revision=45403
1673
1674         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1675         (main):
1676         * DumpRenderTree/chromium/TestShell.cpp:
1677         (TestShell::TestShell):
1678         * DumpRenderTree/chromium/TestShell.h:
1679         (TestShell::allowExternalPages):
1680         (TestShell::setAllowExternalPages):
1681         * DumpRenderTree/chromium/WebViewHost.cpp:
1682         (WebViewHost::willSendRequest):
1683
1684 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
1685
1686         Reviewed by Adam Barth.
1687
1688         Sheriffbot: Should allow "r" in SVN_REVISION
1689         https://bugs.webkit.org/show_bug.cgi?id=40889
1690
1691         * Scripts/webkitpy/tool/bot/irc_command.py: remove a leading "r" from SVN_REVISION if it exists
1692         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: test an SVN_REVISION with a leading r.
1693
1694 2010-06-20  Joseph Pecoraro  <joepeck@webkit.org>
1695
1696         Reviewed by Dimitri Glazkov.
1697
1698         Python Tests Fail after r61508
1699         https://bugs.webkit.org/show_bug.cgi?id=40891
1700
1701         Test's regex list needed to be updated to match the new
1702         regex list in the source code. Added new bots to the
1703         example_buildbots list.
1704
1705         Regex list fixed in r61512. Updated bot list.
1706
1707         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1708
1709 2010-06-20  Dimitri Glazkov  <dglazkov@chromium.org>
1710
1711         Unreviewed, build fix.
1712
1713         Tweak test regexp list to match the change in http://trac.webkit.org/changeset/61508.
1714
1715         * Scripts/webkitpy/common/net/buildbot_unittest.py: Tweaked regexp.
1716
1717 2010-06-19  Justin Schuh  <jschuh@chromium.org>
1718
1719         Unreviewed.
1720
1721         Adding myself to the committers list.
1722
1723         * Scripts/webkitpy/common/config/committers.py:
1724
1725 2010-06-19  Sam Weinig  <sam@webkit.org>
1726
1727         Reviewed by Anders Carlsson.
1728
1729         Fix for https://bugs.webkit.org/show_bug.cgi?id=40882
1730         Add ability to have a WebProcess per WebContext.
1731
1732         Move to use new shared contexts API.
1733
1734         * MiniBrowser/mac/AppDelegate.h:
1735         * MiniBrowser/mac/AppDelegate.m:
1736         (-[BrowserAppDelegate init]):
1737         (-[BrowserAppDelegate getCurrentPageNamespace]):
1738         (-[BrowserAppDelegate validateMenuItem:]):
1739         (-[BrowserAppDelegate _setProcessModel:]):
1740         (-[BrowserAppDelegate setSharedProcessProcessModel:]):
1741         (-[BrowserAppDelegate setSharedThreadProcessModel:]):
1742         * MiniBrowser/win/BrowserView.cpp:
1743         (BrowserView::create):
1744
1745 2010-06-02  Robert Hogan  <robert@webkit.org>
1746
1747         Reviewed by Adam Barth.
1748
1749         [Qt] Support evaluateScriptInIsolatedWorld()
1750
1751         https://bugs.webkit.org/show_bug.cgi?id=40079
1752
1753         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1754         (LayoutTestController::evaluateScriptInIsolatedWorld):
1755         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1756
1757 2010-06-18  Dimitri Glazkov  <dglazkov@chromium.org>
1758
1759         Reviewed by Darin Adler.
1760
1761         Add three more non-core Chromium builders to start testing DumpRenderTree.
1762         https://bugs.webkit.org/show_bug.cgi?id=40335
1763
1764         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 3 builders.
1765
1766 2010-06-18  Drew Wilson  <atwilson@chromium.org>
1767
1768         Reviewed by Darin Fisher.
1769
1770         [Chromium] Plumbing for top-level frame names
1771         https://bugs.webkit.org/show_bug.cgi?id=40430
1772
1773         * DumpRenderTree/chromium/WebViewHost.cpp:
1774         (WebViewHost::reset):
1775         Changed obsolete call to clearName() to use setName(WebString()) instead.
1776
1777 2010-06-18  Sam Weinig  <weinig@apple.com>
1778
1779         Rolling http://trac.webkit.org/changeset/61297 back in.
1780
1781         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1782         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Removed.
1783         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Added.
1784         (_didClearWindow):
1785         (_didCreatePage):
1786         (WKBundleInitialize):
1787
1788 2010-06-18  Alexey Proskuryakov  <ap@apple.com>
1789
1790         Reviewed by Darin Adler.
1791
1792         https://bugs.webkit.org/show_bug.cgi?id=40803
1793         TestNetscapePlugin has an incorrect implementation of "property" property
1794
1795         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginGetProperty): Don't
1796         pass a static string back, it's going to be released by NPAPI implementation.
1797
1798 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
1799
1800         Unreviewed.
1801
1802         Adding myself to the committers list.
1803
1804         * Scripts/webkitpy/common/config/committers.py:
1805
1806 2010-06-17  Tony Chang  <tony@chromium.org>
1807
1808         Reviewed by Kent Tamura.
1809
1810         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
1811         https://bugs.webkit.org/show_bug.cgi?id=40615
1812
1813         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
1814
1815 2010-06-17  Ada Chan  <adachan@apple.com>
1816
1817         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
1818
1819         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1820         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
1821         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
1822
1823 2010-06-17  Darin Adler  <darin@apple.com>
1824
1825         One more try at fix for Chromium build.
1826
1827         * DumpRenderTree/chromium/TestShell.cpp:
1828         (TestShell::TestShell): Use set again instead of =.
1829
1830 2010-06-17  Darin Adler  <darin@apple.com>
1831
1832         Fix Chromium build.
1833
1834         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
1835         code with all the other platforms! Wow, that should be fixed at some point.
1836
1837         * DumpRenderTree/chromium/TestShell.cpp:
1838         (TestShell::TestShell): Changed back to using "new".
1839         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
1840
1841 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
1842
1843         Unreviewed Qt build fix.
1844
1845         LayoutTestController in the Qt DRT is not using refs :)
1846
1847         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1848         (WebCore::DumpRenderTree::DumpRenderTree):
1849
1850 2010-06-17  Darin Adler  <darin@apple.com>
1851
1852         Reviewed by Sam Weinig.
1853
1854         Use adoptRef and create functions in more code paths
1855         https://bugs.webkit.org/show_bug.cgi?id=40760
1856
1857         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
1858
1859         * DumpRenderTree/LayoutTestController.cpp:
1860         (LayoutTestController::create): Added.
1861         * DumpRenderTree/LayoutTestController.h: Declare the create function.
1862
1863         * DumpRenderTree/chromium/TestShell.cpp:
1864         (TestShell::TestShell): Use create instead of new.
1865         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
1866
1867         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1868         (runTest): Use RefPtr and create instead of OwnPtr and new.
1869
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (runTest): Use RefPtr and create instead of OwnPtr and new.
1872
1873         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1874         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
1875         instead of new.
1876
1877         * DumpRenderTree/win/DumpRenderTree.cpp:
1878         (runTest): Use RefPtr and create instead of OwnPtr and new.
1879
1880         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1881         (runTest): Use RefPtr and create instead of OwnPtr and new.
1882         (MyApp::OnInit): Removed unneeded code to delete the layout
1883         test controller. This is done during each test.
1884
1885 2010-06-17  Kent Tamura  <tkent@chromium.org>
1886
1887         Reviewed by Shinichiro Hamaji.
1888
1889         [DRT/Chromium] Fix a bug of Windows pixel tests
1890         https://bugs.webkit.org/show_bug.cgi?id=40763
1891
1892         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1893         (TestShellPrinter::handleImage):
1894
1895 2010-06-16  Kent Tamura  <tkent@chromium.org>
1896
1897         Reviewed by Shinichiro Hamaji.
1898
1899         [DRT/Chromium] Fix crash on Mac Release
1900         https://bugs.webkit.org/show_bug.cgi?id=40759
1901
1902         * DumpRenderTree/chromium/WebViewHost.cpp:
1903         (WebViewHost::paintRect): We should not use m_canvas directly because
1904           it is created lazily in canvas().
1905
1906 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
1907
1908         [wx] Build fix after new method addition.
1909
1910         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1911         (LayoutTestController::pageProperty):
1912
1913 2010-06-16  Kent Tamura  <tkent@chromium.org>
1914
1915         Reviewed by Dimitri Glazkov.
1916
1917         [DRT/Chromium] Set current working directory for each of tests
1918         https://bugs.webkit.org/show_bug.cgi?id=40668
1919
1920         This change fixes tests with eventSender.beginDragWithFiles().
1921
1922         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1923         (runTest):
1924
1925 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
1926
1927         Reviewed by Gustavo Noronha Silva.
1928
1929         [GTK] r60803 broke media/controls-drag-timebar.html
1930         https://bugs.webkit.org/show_bug.cgi?id=40269
1931
1932         Only queue events while the mouse button is down, if drag mode is enabled. Some
1933         tests may disable drag mode, to prevent the queuing of events in this situation.
1934
1935         * DumpRenderTree/gtk/EventSender.cpp:
1936         (sendOrQueueEvent): Only queue events here if dragMode is true.
1937
1938 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
1939
1940         Reviewed by Gustavo Noronha Silva.
1941
1942         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
1943         https://bugs.webkit.org/show_bug.cgi?id=40600
1944
1945         * DumpRenderTree/gtk/EventSender.cpp:
1946         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
1947
1948 2010-06-16  Adam Barth  <abarth@webkit.org>
1949
1950         Reviewed by Dimitri Glazkov.
1951
1952         Add a hidden land-cowboy command to webkit-patch to help land quick
1953         build fixes.
1954
1955         * Scripts/webkitpy/tool/commands/download.py:
1956         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1957
1958 2010-06-16  Adam Roben  <aroben@apple.com>
1959
1960         Convert console messages to UTF-8 before printing them
1961
1962         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
1963         http/tests/security/xssAuditor/embed-tag-null-char.html and
1964         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
1965         Windows. (I can't test the fix because Apache is crashing on my
1966         computer.)
1967
1968         Reviewed by Alexey Proskuryakov.
1969
1970         * DumpRenderTree/win/DumpRenderTree.cpp:
1971         (toUTF8): Extracted the code into an overload that takes a wide string
1972         and a length, then added an overload that takes a wstring.
1973
1974         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
1975         overload.
1976
1977         * DumpRenderTree/win/UIDelegate.cpp:
1978         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
1979         UTF-8 instead of letting printf convert to the current code page.
1980
1981 2010-06-16  Drew Wilson  <atwilson@chromium.org>
1982
1983         Reviewed by Kent Tamura.
1984
1985         [Chromium] Plumbing for top-level frame names
1986         https://bugs.webkit.org/show_bug.cgi?id=40430
1987
1988         * DumpRenderTree/chromium/WebViewHost.cpp:
1989         (WebViewHost::createView):
1990         Migrate to new createView() API.
1991         * DumpRenderTree/chromium/WebViewHost.h:
1992         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
1993
1994 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
1995
1996         Reviewed by Kenneth Rohde Christiansen.
1997
1998         [Qt] Scroll wheel event support to graphics based DRT
1999         https://bugs.webkit.org/show_bug.cgi?id=40577
2000
2001         * DumpRenderTree/qt/EventSenderQt.cpp:
2002         (EventSender::continuousMouseScrollBy):
2003         (EventSender::createGraphicsSceneWheelEvent):
2004         * DumpRenderTree/qt/EventSenderQt.h:
2005
2006 2010-06-16  Adam Roben  <aroben@apple.com>
2007
2008         Remove a stray newline from the Windows version of TestNetscapePlugin
2009
2010         Reviewed by Alexey Proskuryakov.
2011
2012         Fixes <http://webkit.org/b/40728>
2013         plugins/geturlnotify-during-document-teardown.html fails on Windows
2014
2015         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2016         (NPP_Destroy): Removed extra newline that the Mac version doesn't
2017         have.
2018
2019 2010-06-16  Adam Roben  <aroben@apple.com>
2020
2021         Respect LayoutTestController::isPrinting on Windows
2022
2023         This gets some printing tests closer to passing (like
2024         printing/page-rule-in-media-query.html).
2025
2026         Fixes <http://webkit.org/b/40727>.
2027
2028         Reviewed by Dan Bernstein.
2029
2030         * DumpRenderTree/win/DumpRenderTree.cpp:
2031         (dump): Pass LayoutTestController::isPrinting to
2032         IWebFramePrivate::renderTreeAsExternalRepresentation.
2033
2034 2010-06-15  Adam Barth  <abarth@webkit.org>
2035
2036         Reviewed by Eric Seidel.
2037
2038         Enable HTML5 lexer
2039         https://bugs.webkit.org/show_bug.cgi?id=40650
2040
2041         * DumpRenderTree/mac/DumpRenderTree.mm:
2042         (initializeGlobalsFromCommandLineOptions):
2043
2044 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
2045
2046         Reviewed by Shinichiro Hamaji.
2047
2048         Implement render style selection for pages to support CSS3 Paged Media.
2049         https://bugs.webkit.org/show_bug.cgi?id=35961
2050
2051         * DumpRenderTree/LayoutTestController.cpp:
2052         (parsePagePropertyParameters):
2053         (pagePropertyCallback):
2054         (LayoutTestController::staticFunctions):
2055         * DumpRenderTree/LayoutTestController.h:
2056         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2057         (LayoutTestController::pageProperty):
2058         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2059         (LayoutTestController::pageProperty):
2060         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2061         (LayoutTestController::pageProperty):
2062
2063 2010-06-15  Sam Weinig  <sam@webkit.org>
2064
2065         Reviewed by Anders Carlsson.
2066
2067         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
2068         WebKit2: Add mechanism to inject code into the WebProcess on startup
2069
2070         Add initial InjectedBundle support.
2071
2072         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2073         * MiniBrowser/WebBundle-Info.plist: Added.
2074         Add test InjectedBundle to the project.
2075
2076         * MiniBrowser/mac/AppDelegate.m:
2077         (-[BrowserAppDelegate init]):
2078         Get the path to the WebBundle from the the main bundle and pass it to the new
2079         WKContextCreateWithInjectedBundlePath function.
2080
2081         * MiniBrowser/mac/BrowserWindowController.m:
2082         (_didChangeProgress):
2083         Fix the build.  This has been broken for a while.
2084
2085         * MiniBrowser/mac/WebBundle: Added.
2086         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
2087         (_didCreatePage):
2088         (WKBundleInitialize):
2089         Add really basic InjectedBundle.
2090
2091         * MiniBrowser/win/BrowserView.cpp:
2092         (BrowserView::create):
2093         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
2094
2095 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
2096
2097         Reviewed by Darin Adler.
2098
2099         Adding myself to the reviewers list.
2100         https://bugs.webkit.org/show_bug.cgi?id=40693
2101
2102         * Scripts/webkitpy/common/config/committers.py:
2103
2104 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
2105
2106         Reviewed by Xan Lopez.
2107
2108         Switch to using GIO methods instead of realpath in GtkLauncher to determine
2109         the file URI. This should remove warnings about realpath being undefined
2110         when compiling with '-ansi'.
2111
2112         * GtkLauncher/main.c:
2113         (filenameToURL): Use GIO instead of realpath to determine file URI.
2114
2115 2010-06-15  Adam Roben  <aroben@apple.com>
2116
2117         Remove the redundant set-apple-windows-environment-variables script
2118
2119         Apparently update-webkit does this for you these days.
2120
2121         Rubber-stamped by Steve Falkenburg.
2122
2123         * Scripts/set-apple-windows-environment-variables: Removed.
2124
2125 2010-06-14  Adam Roben  <aroben@apple.com>
2126
2127         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
2128         environment variables
2129
2130         Fixes <http://webkit.org/b/40595>.
2131
2132         Reviewed by Steve Falkenburg.
2133
2134         * Scripts/set-apple-windows-environment-variables: Added.
2135         (to_windows_path): Passes the passed-in path through cygpath to
2136         generate a Windows-style path.
2137         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
2138         variables to their defaults, if they aren't already set.
2139
2140 2010-06-14  Adam Roben  <aroben@apple.com>
2141
2142         Speed up run-safari/debug-safari on Windows
2143
2144         Fixes <http://webkit.org/b/40586>.
2145
2146         Reviewed by Steve Falkenburg.
2147
2148         * Scripts/webkitdirs.pm:
2149         (runSafari): When debugging, set up the environment to run Safari
2150         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
2151         actually launch the debugger. When not debugging, just run WebKit.exe
2152         and it will do the rest for us.
2153
2154 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
2155
2156         Reviewed by Kenneth Rohde Christiansen.
2157
2158         [Qt] DRT EventSender support to graphics context events
2159         https://bugs.webkit.org/show_bug.cgi?id=40324
2160
2161         * DumpRenderTree/qt/EventSenderQt.cpp:
2162         (EventSender::contextClick):
2163
2164 2010-06-14  Tony Chang  <tony@chromium.org>
2165
2166         Reviewed by Darin Fisher.
2167
2168         [chromium] checkout chromium third_party directly
2169         https://bugs.webkit.org/show_bug.cgi?id=40556
2170
2171         * Scripts/update-webkit-chromium: some migration code for the bots
2172
2173 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2174
2175         Chromium build fix.
2176
2177         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
2178         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
2179
2180 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
2181
2182         Reviewed by Darin Adler.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=40529
2185         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
2186
2187         * DumpRenderTree/mac/EventSendingController.mm:
2188         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
2189         event for "delete" - it had virtual key code from forward delete, and text from backspace.
2190         Fixed "delete" to mean forward delete.
2191
2192         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
2193         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
2194         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2195         Mac DRT confusion has propagated to other platforms, fixing those.
2196
2197 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
2198
2199         Reviewed by Xan Lopez.
2200
2201         Small GtkLauncher build fix for some systems.
2202
2203         * GtkLauncher/main.c: Add <limit.h> include.
2204
2205 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2206
2207         Reviewed by Laszlo Gombos.
2208
2209         [Qt] navigator.geolocation support for Qt port
2210         https://bugs.webkit.org/show_bug.cgi?id=39724
2211
2212         Implementation for geolocation cases to DumpRenderTreeQt
2213
2214         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2215         (WebCore::WebPage::allowGeolocationRequest):
2216         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2217         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2218         (LayoutTestController::setGeolocationPermission):
2219         (LayoutTestController::setMockGeolocationError):
2220         (LayoutTestController::setMockGeolocationPosition):
2221         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2222         (LayoutTestController::isGeolocationPermissionSet):
2223         (LayoutTestController::geolocationPermission):
2224
2225 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
2226
2227         Reviewed by Darin Adler.
2228
2229         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
2230         be a way of overwriting the Xcode system path.  Making
2231         $WEBKITOUTPUTDIR take precedence over the system default would make
2232         this possible.
2233
2234         * Scripts/webkitdirs.pm:
2235
2236 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
2237
2238         Reviewed by Darin Adler.
2239
2240         AX: link won't return linked element if URL contains #
2241         https://bugs.webkit.org/show_bug.cgi?id=40192
2242
2243         * DumpRenderTree/AccessibilityUIElement.cpp:
2244         (linkedUIElementAtIndexCallback):
2245         (AccessibilityUIElement::getJSClass):
2246         * DumpRenderTree/AccessibilityUIElement.h:
2247         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2248         (AccessibilityUIElement::linkedUIElementAtIndex):
2249         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2250         (AccessibilityUIElement::linkedUIElementAtIndex):
2251         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2252         (AccessibilityUIElement::linkedUIElementAtIndex):
2253
2254 2010-06-13  Adam Barth  <abarth@webkit.org>
2255
2256         Reviewed by Darin Adler.
2257
2258         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
2259         https://bugs.webkit.org/show_bug.cgi?id=39550
2260
2261         This can cause an extra request to bugs.webkit.org durig upload, but it
2262         shouldn't be too bad.  Also, this won't work if you remove the
2263         boilerplate created by prepare-ChangeLog.
2264
2265         * Scripts/webkitpy/common/checkout/changelog.py:
2266         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2267         * Scripts/webkitpy/common/net/bugzilla.py:
2268         * Scripts/webkitpy/tool/steps/abstractstep.py:
2269         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2270         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
2271
2272 2010-06-08  Robert Hogan  <robert@webkit.org>
2273
2274         Reviewed by Eric Seidel.
2275
2276         [Qt] Add support for callShouldCloseOnWebView() to DRT
2277         https://bugs.webkit.org/show_bug.cgi?id=40330
2278
2279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2280         (LayoutTestController::callShouldCloseOnWebView):
2281         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2282         (LayoutTestController::setCallCloseOnWebViews):
2283
2284 2010-06-12  Eric Seidel  <eric@webkit.org>
2285
2286         Reviewed by Daniel Bates.
2287
2288         do-webcore-rename should have a --verbose option
2289         https://bugs.webkit.org/show_bug.cgi?id=40497
2290
2291         * Scripts/do-webcore-rename:
2292          - Unified how we handle skipping files/directories
2293            this will allow us to "black list" certain files and
2294            directories when performing renames.
2295          - Made do-webcore-rename log what it's skipping when passed --verbose.
2296
2297 2010-06-12  Darin Adler  <darin@apple.com>
2298
2299         * Scripts/run-bindings-tests: Fixed a typo in a message.
2300
2301 2010-06-12  Kent Tamura  <tkent@chromium.org>
2302
2303         Reviewed by Dimitri Glazkov.
2304
2305         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
2306         https://bugs.webkit.org/show_bug.cgi?id=40402
2307
2308         _build_path() of each Chromium port check existence of build path
2309         of Chromium checkout first, then check existence of build path of
2310         WebKit-only checkout.
2311
2312         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2313         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2314         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2315
2316 2010-06-12  Robert Hogan  <robert@webkit.org>
2317
2318         Reviewed by Kenneth Rohde Christiansen.
2319
2320         [Qt] Back-forward list dumping is incorrect
2321
2322         https://bugs.webkit.org/show_bug.cgi?id=36392
2323
2324         Support dumping child history items in DRT.
2325
2326         Unskip:
2327
2328         fast/loader/frame-src-change-added-to-history.html
2329         fast/loader/frame-src-change-not-added-to-history.html
2330         fast/loader/frame-location-change-not-added-to-history.html
2331
2332         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2333         (WebCore::dumpHistoryItem):
2334
2335 2010-06-10  Ojan Vafai  <ojan@chromium.org>
2336
2337         Reviewed by Eric Seidel.
2338
2339         upload all patches that lack in-rietveld to rietveld
2340         https://bugs.webkit.org/show_bug.cgi?id=40444
2341
2342         If it's a patch, then we'll try to upload it as long as it
2343         doesn't have in-rietveld set. No longer set in-rietveld? since
2344         it's not needed.
2345
2346         * Scripts/webkitpy/common/net/bugzilla.py:
2347
2348 2010-06-10  Ojan Vafai  <ojan@chromium.org>
2349
2350         Reviewed by Darin Fisher.
2351
2352         Fix rietveld upload when message length > 100 characters
2353         https://bugs.webkit.org/show_bug.cgi?id=40457
2354
2355         * Scripts/webkitpy/common/net/rietveld.py:
2356
2357 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
2358
2359         Reviewed by Laszlo Gombos.
2360
2361         [Qt] There should be a way to enable popups in QtTestBrowser
2362         https://bugs.webkit.org/show_bug.cgi?id=40427
2363
2364         * QtTestBrowser/main.cpp:
2365         (LauncherWindow::toggleJavascriptCanOpenWindows):
2366         (LauncherWindow::createChrome):
2367
2368 2010-06-10  Adam Barth  <abarth@webkit.org>
2369
2370         Reviewed by Daniel Bates.
2371
2372         Make SheriffBot more chatty
2373         https://bugs.webkit.org/show_bug.cgi?id=40463
2374
2375         People seem to like to talk to SheriffBot, so let's make him chat back.
2376
2377         * Scripts/webkitpy/thirdparty/__init__.py:
2378         * Scripts/webkitpy/tool/bot/irc_command.py:
2379         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
2380         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
2381         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2382
2383 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
2384
2385         Reviewed by Darin Adler.
2386
2387         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
2388         
2389         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
2390         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
2391         WEXITSTATUS on $result instead of just comparing $result to 0.
2392
2393         * Scripts/update-webkit-auxiliary-libs:
2394
2395 2010-06-10  Ojan Vafai  <ojan@chromium.org>
2396
2397         Reviewed by Alexey Proskuryakov.
2398
2399         don't use Exception.message as it's deprecated in python 2.6+
2400         https://bugs.webkit.org/show_bug.cgi?id=40449
2401
2402         * Scripts/webkitpy/tool/commands/queues.py:
2403
2404 2010-06-10  Ojan Vafai  <ojan@chromium.org>
2405
2406         Reviewed by Adam Barth.
2407
2408         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
2409         https://bugs.webkit.org/show_bug.cgi?id=40436
2410
2411         * Scripts/webkitpy/common/system/outputcapture.py:
2412         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2413         * Scripts/webkitpy/tool/commands/queues.py:
2414         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2415         * Scripts/webkitpy/tool/commands/queuestest.py:
2416         * Scripts/webkitpy/tool/mocktool.py:
2417
2418 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2419
2420         Reviewed by Simon Hausmann.
2421
2422         [Qt] *All* WebGL layout tests fail!
2423         https://bugs.webkit.org/show_bug.cgi?id=40296
2424
2425         Added test for WebKitWebGLEnabled to
2426         LayoutTestController::overridePreference().
2427
2428         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2429         (LayoutTestController::overridePreference):
2430
2431 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
2432
2433         Reviewed by Kenneth Rohde Christiansen.
2434
2435         [Qt] DRT EventSender support to graphics mouse events activation
2436         https://bugs.webkit.org/show_bug.cgi?id=40017
2437
2438         * DumpRenderTree/qt/EventSenderQt.cpp:
2439         (EventSender::mouseDown):
2440         (EventSender::mouseUp):
2441         (EventSender::mouseMoveTo):
2442         (EventSender::keyDown):
2443         (EventSender::contextClick):
2444         (EventSender::sendTouchEvent):
2445         (EventSender::sendOrQueueEvent):
2446         (EventSender::eventFilter):
2447         (EventSender::createGraphicsSceneMouseEvent):
2448         (EventSender::sendEvent):
2449         * DumpRenderTree/qt/EventSenderQt.h:
2450         (EventSender::isGraphicsBased):
2451
2452 2010-06-09  Adam Barth  <abarth@webkit.org>
2453
2454         Reviewed by Ojan Vafai.
2455
2456         webkit-patch upload fails for security bugs because there's no rietveld flag
2457         https://bugs.webkit.org/show_bug.cgi?id=40309
2458
2459         There's probably a more elegant way of seeing whether the form control
2460         exists, but this seems to work.
2461
2462         * Scripts/webkitpy/common/net/bugzilla.py:
2463
2464 2010-06-09  Ojan Vafai  <ojan@chromium.org>
2465
2466         Reviewed by Adam Barth.
2467
2468         make rietveld upload faster and avoid posting to bug on errors
2469         https://bugs.webkit.org/show_bug.cgi?id=40389
2470
2471         Only grab the first item of the upload queue instead of trying
2472         to compute the whole list upfront (which is O(n) bugzilla lookups!).
2473
2474         Also, don't post comments to the bug when uploading fails.
2475
2476         * Scripts/webkitpy/common/net/bugzilla.py:
2477         * Scripts/webkitpy/tool/commands/queues.py:
2478         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2479         * Scripts/webkitpy/tool/commands/stepsequence.py:
2480         * Scripts/webkitpy/tool/mocktool.py:
2481
2482 2010-06-09  Ojan Vafai  <ojan@chromium.org>
2483
2484         Reviewed by Adam Barth.
2485
2486         Rietveld upload queue fails when setting in-rietveld flag
2487         https://bugs.webkit.org/show_bug.cgi?id=40371
2488
2489         Make the comment arguments to set_flag_on_attachment optional
2490         and add it to the MockBugzilla.
2491
2492         * Scripts/webkitpy/common/net/bugzilla.py:
2493         * Scripts/webkitpy/tool/bot/queueengine.py:
2494         * Scripts/webkitpy/tool/commands/download_unittest.py:
2495         * Scripts/webkitpy/tool/commands/queues.py:
2496         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2497         * Scripts/webkitpy/tool/mocktool.py:
2498
2499 2010-06-09  Kenneth Russell  <kbr@google.com>
2500
2501         Reviewed by Dimitri Glazkov.
2502
2503         Rename FloatArray to Float32Array
2504         https://bugs.webkit.org/show_bug.cgi?id=40323
2505
2506         Used do-webcore-rename to perform renaming. Manually undid
2507         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
2508         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
2509         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
2510         all layout tests on Safari; built Chromium and ran selected WebGL
2511         tests.
2512
2513         * Scripts/do-webcore-rename:
2514
2515 2010-06-08  Tony Chang  <tony@chromium.org>
2516
2517         Reviewed by David Levin.
2518
2519         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
2520         https://bugs.webkit.org/show_bug.cgi?id=40285
2521
2522         * Scripts/webkitdirs.pm:
2523         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2524
2525 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
2526
2527         Reviewed by Tamura Kent.
2528
2529         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
2530         https://bugs.webkit.org/show_bug.cgi?id=40052
2531         
2532         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
2533
2534         * DumpRenderTree/DumpRenderTree.gypi:
2535         * DumpRenderTree/chromium/TestShellWin.cpp:
2536         (platformInit):
2537         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
2538         (WebKit::):
2539         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
2540         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
2541         (WebKit::WebThemeControlDRT::box):
2542         (WebKit::WebThemeControlDRT::line):
2543         (WebKit::WebThemeControlDRT::triangle):
2544         (WebKit::WebThemeControlDRT::roundRect):
2545         (WebKit::WebThemeControlDRT::oval):
2546         (WebKit::WebThemeControlDRT::circle):
2547         (WebKit::WebThemeControlDRT::nestedBoxes):
2548         (WebKit::WebThemeControlDRT::markState):
2549         (WebKit::WebThemeControlDRT::draw):
2550         (WebKit::WebThemeControlDRT::drawTextField):
2551         (WebKit::WebThemeControlDRT::drawProgressBar):
2552         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
2553         (WebKit::WebThemeControlDRT::):
2554         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
2555         (WebKit::):
2556         (WebKit::WebThemeEngineDRT::paintButton):
2557         (WebKit::WebThemeEngineDRT::paintMenuList):
2558         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
2559         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
2560         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
2561         (WebKit::WebThemeEngineDRT::paintTextField):
2562         (WebKit::WebThemeEngineDRT::paintTrackbar):
2563         (WebKit::WebThemeEngineDRT::paintProgressBar):
2564         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
2565         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
2566
2567 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2568
2569         Unreviewed, rolling out r60878.
2570         http://trac.webkit.org/changeset/60878
2571         https://bugs.webkit.org/show_bug.cgi?id=40349
2572
2573         broke linux build (Requested by tony^work on #webkit).
2574
2575         * Scripts/webkitdirs.pm:
2576         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2577
2578 2010-06-08  Tony Chang  <tony@chromium.org>
2579
2580         Reviewed by David Levin.
2581
2582         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
2583         https://bugs.webkit.org/show_bug.cgi?id=40285
2584
2585         * Scripts/webkitdirs.pm:
2586         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2587
2588 2010-06-08  Kenneth Russell  <kbr@google.com>
2589
2590         Unreviewed, build fix.
2591
2592         Fix build breakage from 38145
2593         https://bugs.webkit.org/show_bug.cgi?id=40346
2594
2595         The fix for bug 38145 broke the Chromium Win build because
2596         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
2597         change log2(x) to log(x) / log(2). Built and ran WebGL layout
2598         tests in Safari on Mac OS X. Changed download mirrors for
2599         python-irclib to working ones.
2600
2601         * Scripts/webkitpy/thirdparty/__init__.py:
2602
2603 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
2604
2605         Reviewed by Eric Seidel.
2606
2607         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
2608         https://bugs.webkit.org/show_bug.cgi?id=39058
2609
2610         * Scripts/old-run-webkit-tests:
2611          use sourceDir() to find ensure-valid-python in checkPythonVersion()
2612
2613 2010-06-08  Andras Becsi  <abecsi@webkit.org>
2614
2615         Unreviewed buildfix after r60479.
2616
2617         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
2618         versions other than 2.17.3.
2619
2620         * DumpRenderTree/gtk/EventSender.cpp:
2621         (getRootCoords):
2622
2623 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
2624
2625         Reviewed by Oliver Hunt.
2626
2627         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
2628         https://bugs.webkit.org/show_bug.cgi?id=40267
2629
2630         When a mouse button is down, automatically queue mouse motion events and
2631         do not play them back until the mouse button is released. This matches the
2632         behavior of other ports' EventSenders.
2633
2634         * DumpRenderTree/gtk/EventSender.cpp:
2635         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
2636         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
2637
2638 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2639
2640         Reviewed by Sam Weinig.
2641
2642         Add CPP bindings generator
2643         https://bugs.webkit.org/show_bug.cgi?id=38279
2644
2645         Integrate CPP bindings in run-bindings-tests.
2646
2647         * Scripts/run-bindings-tests:
2648
2649 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
2650
2651         Reviewed by Ojan Vafai.
2652
2653         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
2654         https://bugs.webkit.org/show_bug.cgi?id=40183
2655
2656         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2657
2658 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
2659
2660         Unreviewed.
2661
2662         Add my new email and IRC nick to committers.py.
2663
2664         * Scripts/webkitpy/common/config/committers.py:
2665
2666 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
2667
2668         Unreviewed.
2669
2670         Revert changes in json_results_generator.py's _get_svn_revision.
2671
2672         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2673
2674 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
2675
2676         Reviewed by Xan Lopez.
2677
2678         [GTK] GtkLauncher should support relative file paths
2679         https://bugs.webkit.org/show_bug.cgi?id=39944
2680
2681         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
2682
2683         * GtkLauncher/main.c:
2684         (filename_to_url): Added.
2685         (main): Try to resolve arguments as relative file URLs first.
2686
2687 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
2688
2689         Reviewed by Xan Lopez.
2690
2691         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
2692         https://bugs.webkit.org/show_bug.cgi?id=40182
2693
2694         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
2695         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
2696         without breaking DRT.
2697
2698         * DumpRenderTree/gtk/EventSender.cpp:
2699         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
2700         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
2701
2702 2010-06-04  Anders Carlsson  <andersca@apple.com>
2703
2704         Reviewed by David Hyatt.
2705
2706         Make the editing/spelling/context-menu-suggestions.html test more robust
2707         https://bugs.webkit.org/show_bug.cgi?id=40178
2708
2709         Change the contextClick method to return an array of strings describing the context menu items.
2710
2711         * DumpRenderTree/mac/EventSendingController.mm:
2712         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2713         (+[EventSendingController webScriptNameForSelector:]):
2714         (-[EventSendingController contextClick]):
2715
2716 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
2717
2718         Reviewed by Shinichiro Hamaji.
2719
2720         Clean up chromium-specific code from json_results_generator.py.
2721         https://bugs.webkit.org/show_bug.cgi?id=39665
2722
2723         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2724         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2725         * Scripts/webkitpy/layout_tests/port/base.py:
2726         * Scripts/webkitpy/layout_tests/port/chromium.py:
2727
2728 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
2729
2730         Reviewed by Adam Barth.
2731
2732         Utilize new takeFirst() method where appropriate.
2733         https://bugs.webkit.org/show_bug.cgi?id=40089
2734
2735         * DumpRenderTree/chromium/EventSender.cpp:
2736         (EventSender::replaySavedEvents):
2737         * DumpRenderTree/chromium/LayoutTestController.cpp:
2738         (LayoutTestController::WorkQueue::processWork):
2739         (LayoutTestController::WorkQueue::reset):
2740
2741 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
2742
2743         Reviewed by Simon Hausmann.
2744
2745         [Qt] QtTestLauncher should allow notifications by default.
2746         https://bugs.webkit.org/show_bug.cgi?id=40078
2747
2748         * QtTestBrowser/main.cpp:
2749         (NotificationsPermissionController::NotificationsPermissionController):
2750         (NotificationsPermissionController::checkPermission):
2751         (NotificationsPermissionController::requestPermission):
2752         (LauncherWindow::LauncherWindow):
2753
2754 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
2755
2756         Reviewed by Adam Barth.
2757
2758         Detect whether the user's environment can open a browser.
2759         https://bugs.webkit.org/show_bug.cgi?id=40136
2760
2761         Some environments like cygwin silently fail webbrowser.open() causing
2762         webkit-patch upload not to display any diff. This detects environments
2763         where webbrowser.open() would fail by testing if webbrowser.get()
2764         raises an exception.
2765
2766         * Scripts/webkitpy/common/system/user.py:
2767         * Scripts/webkitpy/tool/mocktool.py:
2768         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2769
2770 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
2771
2772         Reviewed by David Levin.
2773
2774         Add dependencies required to link with VS Express 2005.
2775         https://bugs.webkit.org/show_bug.cgi?id=40038
2776
2777         Visual Studio implicitly links against these libs.
2778         VC++ Express does not.
2779
2780         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2781         * WinLauncher/WinLauncher.vcproj:
2782
2783 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
2784
2785         Reviewed by David Levin.
2786
2787         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
2788         https://bugs.webkit.org/show_bug.cgi?id=40105
2789
2790         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2791         - kill pywebsocket process when url is not alive and the process is not
2792           terminated, not to leave pywebsocket server running.
2793         - fix codecs.open parameters.
2794
2795 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
2796
2797         Reviewed by Alexey Proskuryakov.
2798
2799         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
2800         https://bugs.webkit.org/show_bug.cgi?id=39058
2801
2802         * Scripts/ensure-valid-python:
2803           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
2804           - Add --check-only and --help option.
2805           - --check-only option only checks python version and don't try to install Python 2.5.
2806           - Set executable bit.
2807         * Scripts/old-run-webkit-tests:
2808           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
2809
2810 2010-05-14  Ojan Vafai  <ojan@chromium.org>
2811
2812         Reviewed by Adam Barth.
2813
2814         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
2815         https://bugs.webkit.org/show_bug.cgi?id=38918
2816
2817         Patches with in-rietveld? get uploaded to rietveld and get marked
2818         in-rietveld+. If the upload fails, they are marked in-rietveld-
2819         and an error is logged to the bug, like the commit-queue.
2820
2821         Also, get rid of --fancy-review and the ability to upload to rietveld
2822         using webkit-patch upload/post.
2823
2824         * Scripts/webkitpy/common/net/bugzilla.py:
2825         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2826         * Scripts/webkitpy/tool/commands/download.py:
2827         * Scripts/webkitpy/tool/commands/download_unittest.py:
2828         * Scripts/webkitpy/tool/commands/queues.py:
2829         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2830         * Scripts/webkitpy/tool/commands/upload.py:
2831         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2832         * Scripts/webkitpy/tool/mocktool.py:
2833         * Scripts/webkitpy/tool/steps/options.py:
2834         * Scripts/webkitpy/tool/steps/postcodereview.py:
2835
2836 2010-05-24  Ojan Vafai  <ojan@chromium.org>
2837
2838         Reviewed by Chris Jerdonek.
2839
2840         many webkit-patch commands fail in a non-svn tracking git checkout
2841         https://bugs.webkit.org/show_bug.cgi?id=38156
2842
2843         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
2844         If neither exists, then error out. This makes webkit-patch work
2845         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
2846         to checkout webkit. The fallback to master is for people who don't
2847         do the steps on that page for tracking svn.
2848
2849         * Scripts/webkitpy/common/checkout/scm.py:
2850         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2851
2852 2010-06-03  Mike Fenton  <mifenton@rim.com>
2853
2854         Unreviewed.
2855
2856         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
2857
2858         * Scripts/webkitpy/common/config/committers.py:
2859
2860 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
2861
2862         Reviewed by Yury Semikhatsky.
2863
2864         Web Inspector: a number of fixes that make InspectorController
2865         happy with null redirects.
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=40109
2868
2869         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2870         (runTest):
2871         * DumpRenderTree/mac/DumpRenderTree.mm:
2872         (runTest):
2873         * DumpRenderTree/win/DumpRenderTree.cpp:
2874         (runTest):
2875
2876 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
2877
2878         Reviewed by Shinichiro Hamaji.
2879
2880         [Qt] Fix compilation with QT_NO_PROPERTIES
2881         https://bugs.webkit.org/show_bug.cgi?id=38324
2882
2883         * QtTestBrowser/main.cpp:
2884         (LauncherWindow::init):
2885
2886 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
2887
2888         Reviewed by Kenneth Rohde Christiansen.
2889
2890         [Qt] Make possible run DRT with QGraphicsWebView
2891         https://bugs.webkit.org/show_bug.cgi?id=40016
2892
2893         Make possible to use a environment variable for switching backend.
2894         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
2895
2896         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2897         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
2898         (WebCore::DumpRenderTree::DumpRenderTree):
2899         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2900         (WebCore::DumpRenderTree::setGraphicsBased):
2901         (WebCore::DumpRenderTree::isGraphicsBased):
2902         (WebCore::WebViewGraphicsBased::graphicsView):
2903         (WebCore::WebViewGraphicsBased::setPage):
2904         * Scripts/old-run-webkit-tests:
2905
2906 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
2907
2908         Reviewed by Eric Seidel.
2909
2910         Slave lost shouldn't be recognized as build failed.
2911         https://bugs.webkit.org/show_bug.cgi?id=39282
2912
2913         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
2914         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
2915
2916 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
2917
2918         Reviewed by Kenneth Rohde Christiansen.
2919
2920         [Qt] Fix the lifecycle of notification objects
2921         https://bugs.webkit.org/show_bug.cgi?id=40003
2922
2923         Remove the dependency of notifications on QWebPage.
2924
2925         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2926         (WebCore::requestPermissionCallback):
2927         (WebCore::WebPage::WebPage):
2928         (WebCore::DumpRenderTree::requestPermission):
2929         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2930
2931 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2932
2933         Unreviewed, rolling out r60559.
2934         http://trac.webkit.org/changeset/60559
2935         https://bugs.webkit.org/show_bug.cgi?id=40055
2936
2937         It broke python unit test (Requested by Ossy on #webkit).
2938
2939         * Scripts/webkitpy/common/net/buildbot.py:
2940
2941 2010-06-02  Csaba Osztrogonác  <ossy@webkit.org>
2942
2943         Reviewed by Eric Seidel.
2944
2945         Slave lost shouldn't be recognized as build failed.
2946         https://bugs.webkit.org/show_bug.cgi?id=39282
2947
2948         * Scripts/webkitpy/common/net/buildbot.py:
2949
2950 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
2951
2952         Reviewed by Eric Seidel.
2953
2954         Fix crash caused when assigned_to is disabled
2955         https://bugs.webkit.org/show_bug.cgi?id=40039
2956
2957         * Scripts/webkitpy/common/net/bugzilla.py:
2958
2959 2010-06-02  Sterling Swigart  <sswigart@google.com>
2960
2961         Reviewed by David Levin.
2962
2963         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
2964         https://bugs.webkit.org/show_bug.cgi?id=39906
2965
2966         * Scripts/build-webkit:
2967
2968 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
2969
2970         Reviewed by Simon Hausmann.
2971
2972         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
2973
2974         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2975         (WebCore::WebPage::WebPage):
2976         (WebCore::WebPage::resetSettings):
2977         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2978         (LayoutTestController::setJavaScriptCanAccessClipboard):
2979
2980 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2981
2982         Reviewed by Mark Rowe.
2983
2984         A nicer Tiger build fix.
2985
2986         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2987         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2988         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
2989
2990 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2991
2992         A real Tiger build fix.
2993
2994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
2995         for all configurations, not just debug.
2996
2997 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
2998
2999         Tiger build fix.
3000
3001         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
3002
3003 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3004
3005         Reviewed by Xan Lopez.
3006
3007         [GTK] Get more mouse tests passing
3008         https://bugs.webkit.org/show_bug.cgi?id=39040
3009
3010         Reproduce the logic from the Windows EventSender for mapping
3011         button numbers to GDK button numbers. Move this logic to the
3012         prepareMouseButtonEvent helper.
3013
3014         * DumpRenderTree/gtk/EventSender.cpp:
3015         (prepareMouseButtonEvent): Reproduce Windows logic.
3016         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
3017         (mouseDownCallback): Ditto.
3018         (mouseUpCallback): Ditto.
3019
3020 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
3021
3022         Reviewed by Sam Weinig.
3023
3024         https://bugs.webkit.org/show_bug.cgi?id=39434
3025         REGRESSION (r59811): Geolocation callbacks cannot be created
3026
3027         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
3028
3029         * DumpRenderTree/mac/DumpRenderTree.mm:
3030         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
3031         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
3032         into subsequent tests.
3033
3034         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3035         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
3036         (LayoutTestController::setMockGeolocationError): Ditto.
3037
3038         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
3039         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
3040         (+[MockGeolocationProvider shared]):
3041         (-[MockGeolocationProvider dealloc]):
3042         (-[MockGeolocationProvider setPosition:]):
3043         (-[MockGeolocationProvider setError:]):
3044         (-[MockGeolocationProvider registerWebView:]):
3045         (-[MockGeolocationProvider unregisterWebView:]):
3046         (-[MockGeolocationProvider lastPosition]):
3047         (-[MockGeolocationProvider stopTimer]):
3048         (-[MockGeolocationProvider timerFired]):
3049
3050         * DumpRenderTree/mac/UIDelegate.mm:
3051         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3052         This delegate method must send a response. I'm not sure what the two-stage check is supposed
3053         to achieve, it seems unnecessary.
3054
3055 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
3056
3057         Reviewed by Xan Lopez.
3058
3059         [GTK] Double clicks cause three button press events
3060         https://bugs.webkit.org/show_bug.cgi?id=38853
3061
3062         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
3063         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
3064         the GDK event queue entirely, we simply do not send the extra event.
3065
3066         * DumpRenderTree/gtk/EventSender.cpp:
3067         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
3068         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
3069
3070 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3071
3072         Not reviewed. Build fix.
3073
3074         Fix GTK+ build caused by a bad merge.
3075
3076         * DumpRenderTree/gtk/EventSender.cpp: 
3077         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
3078
3079 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
3080
3081         Reviewed by Xan Lopez.
3082
3083         [GTK] Double clicks cause three button press events
3084         https://bugs.webkit.org/show_bug.cgi?id=38853
3085
3086         Small EventSender cleanups. Consolidate some common code. Style fixes.
3087
3088         * DumpRenderTree/gtk/EventSender.cpp:
3089         (prepareMouseButtonEvent): Added.
3090         (contextClickCallback): Use prepareMouseButtonEvent.
3091         (mouseDownCallback): Use prepareMouseButtonEvent.
3092         (mouseUpCallback): Use prepareMouseButtonEvent.
3093         (mouseMoveToCallback): Small style fix.
3094
3095 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3096
3097         Reviewed by Xan Lopez.
3098
3099         [GTK] Double clicks cause three button press events
3100         https://bugs.webkit.org/show_bug.cgi?id=38853
3101
3102         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
3103         to pause for a specified amount of time. It is used in the processing of drag-
3104         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
3105         This patch enables tests that rely on the latter behavior to pass.
3106
3107         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3108         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
3109         * DumpRenderTree/gtk/EventSender.cpp:
3110         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
3111         (contextClickCallback): Use sendOrQueueEvent.
3112         (updateClickCount): Take the time offset into account when counting clicks.
3113         (mouseDownCallback): Use sendOrQueueEvent.
3114         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
3115         (mouseUpCallback): Use sendOrQueueEvent.
3116         (mouseMoveToCallback): Ditto.
3117         (mouseWheelToCallback): Ditto.
3118         (sendOrQueueEvent): Added.
3119         (dispatchEvent): Added.
3120         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
3121         (makeEventSender): Only initialize the EventSender when loading the top frame.
3122         * DumpRenderTree/gtk/EventSender.h: Ditto.
3123
3124 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
3125
3126         Reviewed by Xan Lopez.
3127
3128         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
3129         https://bugs.webkit.org/show_bug.cgi?id=39101
3130
3131         Work around timing issues for render tree dumps by pumping the
3132         main loop before doing the dump. Resize events are asynchronous
3133         in GTK+, so sometimes resize requests are still pending when DRT
3134         dumps the tree.
3135
3136         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3137         (dump): Pump the main loop before dumping the render tree.
3138
3139 2010-05-31  Kent Tamura  <tkent@chromium.org>
3140
3141         Reviewed by Dimitri Glazkov.
3142
3143         [DRT/Chromium] Fix crash of a test after another test with multiple windows
3144         https://bugs.webkit.org/show_bug.cgi?id=39942
3145
3146         If a test opens multiple windows, focuses on non-main window, and
3147         the focused window is closed, TestShell::m_focusedWidget points a
3148         deleted object.
3149
3150         * DumpRenderTree/chromium/TestShell.cpp:
3151         (TestShell::closeWindow): Clear m_focusedWidget.
3152
3153 2010-05-30  Kent Tamura  <tkent@chromium.org>
3154
3155         Reviewed by Dimitri Glazkov.
3156
3157         new-run-webkit-tests: Support DRT on Chromium-win
3158         https://bugs.webkit.org/show_bug.cgi?id=39810
3159
3160         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
3161         it behaves like test_shell about command analysis, printing
3162         format, pixel dumping, and timeout handling.
3163
3164         chromium.py and chromium_win.py supports the --test-shell flag and
3165         DRT/Chromium-win binary names.
3166         
3167         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
3168         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3169         (runTest): Support for test_shell-style command.
3170         (main): Introduce --test-shell.
3171         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
3172         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
3173           TestEventPrinter class manages stdio output and image output.
3174           TestEventPrinter.cpp has two implementations; DRTPrinter and
3175           TestShellPrinter.
3176         * DumpRenderTree/chromium/TestShell.cpp:
3177           Some changes for TestEventPrinter.
3178         (TestShell::TestShell):
3179         (TestShell::runFileTest):
3180         (TestShell::testTimedOut):
3181         (TestShell::dump):
3182         (TestShell::dumpImage):
3183         * DumpRenderTree/chromium/TestShell.h:
3184         (TestShell::printer):
3185         (TestShell::layoutTestTimeout):
3186         (TestShell::layoutTestTimeoutForWatchDog):
3187         (TestShell::setLayoutTestTimeout):
3188         * DumpRenderTree/chromium/TestShellWin.cpp:
3189         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
3190         * Scripts/webkitpy/layout_tests/port/chromium.py:
3191         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3192
3193 2010-05-30  Robert Hogan  <robert@webkit.org>
3194
3195         Reviewed by Kenneth Rohde Christiansen.
3196
3197         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
3198
3199         https://bugs.webkit.org/show_bug.cgi?id=36004
3200
3201         * DumpRenderTree/qt/EventSenderQt.cpp:
3202         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
3203                                     Scrollbar::pixelsPerLineStep() for DRT testing.
3204         (EventSender::mouseScrollBy): Added
3205         (EventSender::continuousMouseScrollBy): Added
3206         * DumpRenderTree/qt/EventSenderQt.h:
3207
3208 2010-05-28  Adam Barth  <abarth@webkit.org>
3209
3210         Reviewed by David Levin.
3211
3212         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
3213         https://bugs.webkit.org/show_bug.cgi?id=39546
3214
3215         One sublty is that we want to wait for the user to finish editing the
3216         ChangeLog before moving on to the next step.  That means we want to pass
3217         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
3218         we don't want them to have to exit the Xcode application.  For this reason,
3219         we create a new instance of the application with -n.
3220         
3221         Overall, xed seems like a better solution, so we recommend that too.
3222
3223         * Scripts/webkitpy/common/system/user.py:
3224         * Scripts/webkitpy/tool/mocktool.py:
3225         * Scripts/webkitpy/tool/steps/editchangelog.py:
3226
3227 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
3228
3229         Reviewed by Ojan Vafai.
3230
3231         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
3232         threads are wedged. Also, the script will print the results of the
3233         tests completed when the interrupt occurs.
3234
3235         https://bugs.webkit.org/show_bug.cgi?id=33238
3236
3237         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3238         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3239         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3240         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3241
3242 2010-05-28  Darin Adler  <darin@apple.com>
3243
3244         Ignore more Python messiness.
3245
3246         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
3247         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
3248         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
3249         * Scripts/webkitpy/test: Added property svn:ignore.
3250         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
3251
3252 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
3253
3254         Reviewed by Beth Dakin.
3255
3256         Adding myself as a reviewer.
3257
3258         * Scripts/webkitpy/common/config/committers.py:
3259
3260 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
3261
3262         Build fix. No review.
3263
3264         AX: need to catch NSAccessibilityExceptions in DRT
3265         https://bugs.webkit.org/show_bug.cgi?id=39881
3266
3267         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
3268
3269         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3270         (AccessibilityUIElement::rowIndexRange):
3271         (AccessibilityUIElement::columnIndexRange):
3272         (AccessibilityUIElement::selectedTextRange):
3273
3274 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
3275
3276         Reviewed by Darin Adler.
3277
3278         AX: need to catch NSAccessibilityExceptions in DRT
3279         https://bugs.webkit.org/show_bug.cgi?id=39881
3280
3281         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
3282         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
3283   
3284         So DRT should wrap exception handlers around its AX related calls.
3285
3286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3287         (attributesOfElement):
3288         (AccessibilityUIElement::getLinkedUIElements):
3289         (AccessibilityUIElement::getDocumentLinks):
3290         (AccessibilityUIElement::getChildren):
3291         (AccessibilityUIElement::getChildrenWithRange):
3292         (AccessibilityUIElement::ariaOwnsElementAtIndex):
3293         (AccessibilityUIElement::ariaFlowToElementAtIndex):
3294         (AccessibilityUIElement::disclosedRowAtIndex):
3295         (AccessibilityUIElement::selectedRowAtIndex):
3296         (AccessibilityUIElement::titleUIElement):
3297         (AccessibilityUIElement::parentElement):
3298         (AccessibilityUIElement::disclosedByRow):
3299         (AccessibilityUIElement::stringAttributeValue):
3300         (AccessibilityUIElement::boolAttributeValue):
3301         (AccessibilityUIElement::isAttributeSettable):
3302         (AccessibilityUIElement::isAttributeSupported):
3303         (AccessibilityUIElement::role):
3304         (AccessibilityUIElement::subrole):
3305         (AccessibilityUIElement::roleDescription):
3306         (AccessibilityUIElement::title):
3307         (AccessibilityUIElement::description):
3308         (AccessibilityUIElement::orientation):
3309         (AccessibilityUIElement::stringValue):
3310         (AccessibilityUIElement::language):
3311         (AccessibilityUIElement::helpText):
3312         (AccessibilityUIElement::x):
3313         (AccessibilityUIElement::y):
3314         (AccessibilityUIElement::width):
3315         (AccessibilityUIElement::height):
3316         (AccessibilityUIElement::clickPointX):
3317         (AccessibilityUIElement::clickPointY):
3318         (AccessibilityUIElement::intValue):
3319         (AccessibilityUIElement::minValue):
3320         (AccessibilityUIElement::maxValue):
3321         (AccessibilityUIElement::valueDescription):
3322         (AccessibilityUIElement::insertionPointLineNumber):
3323         (AccessibilityUIElement::isActionSupported):
3324         (AccessibilityUIElement::isEnabled):
3325         (AccessibilityUIElement::isRequired):
3326         (AccessibilityUIElement::isSelected):
3327         (AccessibilityUIElement::isExpanded):
3328         (AccessibilityUIElement::hierarchicalLevel):
3329         (AccessibilityUIElement::ariaIsGrabbed):
3330         (AccessibilityUIElement::ariaDropEffects):
3331         (AccessibilityUIElement::lineForIndex):
3332         (AccessibilityUIElement::boundsForRange):
3333         (AccessibilityUIElement::stringForRange):
3334         (AccessibilityUIElement::attributesOfColumnHeaders):
3335         (AccessibilityUIElement::attributesOfRowHeaders):
3336         (AccessibilityUIElement::attributesOfColumns):
3337         (AccessibilityUIElement::attributesOfRows):
3338         (AccessibilityUIElement::attributesOfVisibleCells):
3339         (AccessibilityUIElement::attributesOfHeader):
3340         (AccessibilityUIElement::rowCount):
3341         (AccessibilityUIElement::columnCount):
3342         (AccessibilityUIElement::indexInTable):
3343         (AccessibilityUIElement::rowIndexRange):
3344         (AccessibilityUIElement::columnIndexRange):
3345         (AccessibilityUIElement::cellForColumnAndRow):
3346         (AccessibilityUIElement::selectedTextRange):
3347         (AccessibilityUIElement::setSelectedTextRange):
3348         (AccessibilityUIElement::increment):
3349         (AccessibilityUIElement::decrement):
3350         (AccessibilityUIElement::showMenu):
3351         (AccessibilityUIElement::press):
3352         (AccessibilityUIElement::url):
3353         (AccessibilityUIElement::hasPopup):
3354
3355 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
3356
3357         Reviewed by Laszlo Gombos.
3358
3359         [Qt] Pass all web notification layout tests
3360         https://bugs.webkit.org/show_bug.cgi?id=39146
3361
3362         Mimic Chromium's test_shell security model in Qt's DRT.
3363         It makes a list of origins which were granted permission to display
3364         notifications, and only those origins can display notifications.
3365
3366         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3367         (WebCore::checkPermissionCallback):
3368         (WebCore::requestPermissionCallback):
3369         (WebCore::WebPage::WebPage):
3370         (WebCore::DumpRenderTree::checkPermission):
3371         (WebCore::DumpRenderTree::requestPermission):
3372         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3373         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3374         (LayoutTestController::reset):
3375         (LayoutTestController::grantDesktopNotificationPermission):
3376         (LayoutTestController::checkDesktopNotificationPermission):
3377         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3378
3379 2010-05-27  Philippe Normand  <pnormand@igalia.com>
3380
3381         Reviewed by Shinichiro Hamaji.
3382
3383         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
3384         https://bugs.webkit.org/show_bug.cgi?id=39372
3385
3386         Don't warn about NULL in g_*() calls. Zero can't be used instead
3387         for calls like g_build_filename and g_object_get/set.
3388
3389         * Scripts/webkitpy/style/checkers/cpp.py:
3390         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3391
3392 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
3393
3394         Reviewed by Kenneth Rohde Christiansen.
3395
3396         [Qt] Platform plugin example
3397         https://bugs.webkit.org/show_bug.cgi?id=39489
3398
3399         Exempting directory WebKit/qt/examples/ from style guide.
3400
3401         * Scripts/webkitpy/style/checker.py:
3402
3403 2010-05-26  Philippe Normand  <pnormand@igalia.com>
3404
3405         Reviewed by David Levin.
3406
3407         [style] Allow usage of NULL in gst_*_many()
3408         https://bugs.webkit.org/show_bug.cgi?id=39740
3409
3410         Don't warn if NULL is used by gst_*_many() functions. Zero can't
3411         be used for the reason explained in Bug 32858.
3412
3413         * Scripts/webkitpy/style/checkers/cpp.py:
3414         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3415
3416 2010-05-27  Adam Barth  <abarth@webkit.org>
3417
3418         Reviewed by Eric Seidel.
3419
3420         Update script to run the normal version of the parser tests.
3421
3422         * Scripts/test-html5-parser:
3423
3424 2010-05-27  Adam Barth  <abarth@webkit.org>
3425
3426         Reviewed by Eric Seidel.
3427
3428         Add HTML5 parser support to run-webkit-tests
3429         https://bugs.webkit.org/show_bug.cgi?id=39815
3430
3431         * Scripts/old-run-webkit-tests:
3432
3433 2010-05-26  Adam Barth  <abarth@webkit.org>
3434
3435         Reviewed by Eric Seidel.
3436
3437         Make HTML5 lexer not ASSERT when resuming partial parses
3438         https://bugs.webkit.org/show_bug.cgi?id=39755
3439
3440         Add webkit-resumer.html to the HTML5 parser test suite.
3441
3442         * Scripts/test-html5-parser:
3443
3444 2010-05-24  Tony Chang  <tony@chromium.org>
3445
3446         Reviewed by Kent Tamura.
3447
3448         [chromium] setup fonts on chromium linux DRT
3449         https://bugs.webkit.org/show_bug.cgi?id=39644
3450
3451         * DumpRenderTree/chromium/TestShellGtk.cpp:
3452         (setupFontconfig):
3453         (platformInit):
3454         * DumpRenderTree/chromium/WebViewHost.cpp:
3455         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
3456         * DumpRenderTree/chromium/fonts.conf: Added.
3457
3458 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
3459
3460         Reviewed by Dimitri Glazkov.
3461
3462         Re-commit r58765 - it had been rolled out to see if it was causing
3463         a perf regression (in r59787 and r59789), but that does not seem to
3464         have been the case.
3465
3466         https://bugs.webkit.org/show_bug.cgi?id=39605
3467
3468         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3469         (NotificationPresenter::show):
3470
3471 2010-05-25  Ojan Vafai  <ojan@chromium.org>
3472
3473         Reviewed by Chris Jerdonek.
3474
3475         remove suppression of rietveld logging
3476         https://bugs.webkit.org/show_bug.cgi?id=39693
3477
3478         Now that we only upload to rietveld explicitly, e.g. on the bot
3479         or via webkit-patch post-attachment-to-rietveld, we should print
3480         all the rietveld logging. It was suppressed before to avoid making
3481         webkit-patch upload too noisy.
3482
3483         * Scripts/webkitpy/common/net/rietveld.py:
3484
3485 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
3486
3487         Reviewed by Ojan Vafai.
3488
3489         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
3490         https://bugs.webkit.org/show_bug.cgi?id=39680
3491
3492         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
3493
3494         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3495         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3496         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3497         (LayoutTestController::setEditingBehavior):
3498
3499 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
3500
3501         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
3502
3503         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3504         (LayoutTestController::setEditingBehavior):
3505         * wx/build/settings.py:
3506
3507 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
3508
3509         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
3510
3511         editingBehavior settings needs to be set back to a reasonable default between tests
3512         https://bugs.webkit.org/show_bug.cgi?id=39433
3513
3514         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
3515         so that the serialized version of the setting stays in sync with expectations.
3516
3517         * DumpRenderTree/chromium/TestShell.cpp:
3518         (TestShell::resetWebSettings):
3519         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3520         (resetDefaultsToConsistentValues):
3521
3522 2010-05-24  Eric Seidel  <eric@webkit.org>
3523
3524         Reviewed by Adam Barth.
3525
3526         webkit-patch land calls scm.changed_files 4 times!
3527         https://bugs.webkit.org/show_bug.cgi?id=39584
3528
3529         * Scripts/webkitpy/tool/commands/download_unittest.py:
3530          - Assert that we don't call modified_changelogs too often.
3531         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3532          - Use cached changelogs list instead of calling modified_changelogs directly.
3533         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3534          - ditto.
3535
3536 2010-05-24  Kent Tamura  <tkent@chromium.org>
3537
3538         Reviewed by Dimitri Glazkov.
3539
3540         [DRT/Chromium] Import layout_test_helper for Windows
3541         https://bugs.webkit.org/show_bug.cgi?id=39581
3542
3543         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
3544         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
3545
3546         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
3547
3548 2010-05-24  Kent Tamura  <tkent@chromium.org>
3549
3550         Reviewed by Dimitri Glazkov.
3551
3552         [DRT/Chromium] Reset frame name
3553         https://bugs.webkit.org/show_bug.cgi?id=39586
3554
3555         This change fixes about 70 unexpected results.
3556
3557         * DumpRenderTree/chromium/WebViewHost.cpp:
3558         (WebViewHost::reset):
3559
3560 2010-05-24  Marcus Bulach  <bulach@chromium.org>
3561
3562         Reviewed by Kent Tamura.
3563
3564         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
3565         https://bugs.webkit.org/show_bug.cgi?id=39587
3566
3567         * DumpRenderTree/chromium/WebViewHost.cpp:
3568         (WebViewHost::geolocationService):
3569
3570 2010-05-24  Robert Hogan  <robert@webkit.org>
3571
3572         Reviewed by Laszlo Gombos.
3573
3574         [Qt] DRT Support for removeOriginAccessWhitelistEntry
3575
3576         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
3577
3578         [Qt] DRT Support for removeOriginAccessWhitelistEntry
3579         https://bugs.webkit.org/show_bug.cgi?id=39565
3580
3581         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3582         (LayoutTestController::removeOriginAccessWhitelistEntry):
3583
3584 2010-05-24  Marcus Bulach  <bulach@google.com>
3585
3586         Reviewed by Ojan Vafai.
3587
3588         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
3589         https://bugs.webkit.org/show_bug.cgi?id=39603
3590
3591         * Scripts/webkitpy/common/checkout/scm.py:
3592
3593 == Rolled over to ChangeLog-2010-05-24 ==