WebKitTools/ChangeLog

   1 2010-10-06  Tony Chang  <tony@chromium.org>
   2
   3         Unreviewed, rolling out r69202.
   4         http://trac.webkit.org/changeset/69202
   5         https://bugs.webkit.org/show_bug.cgi?id=46937
   6
   7         Broke compile of test_shell
   8
   9         * DumpRenderTree/chromium/EventSender.cpp:
  10         (EventSender::beginDragWithFiles):
  11         * DumpRenderTree/chromium/WebViewHost.cpp:
  12         (addDRTFakeFileToDataObject):
  13
  14 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
  15
  16         Reviewed by Tony Chang.
  17
  18         [chromium] Minor naming cleanup in WebDragData, part 2
  19         https://bugs.webkit.org/show_bug.cgi?id=46937
  20
  21         Update DRT to use the renamed methods.
  22
  23         * DumpRenderTree/chromium/EventSender.cpp:
  24         (EventSender::beginDragWithFiles):
  25         * DumpRenderTree/chromium/WebViewHost.cpp:
  26         (addDRTFakeFileToDataObject):
  27
  28 2010-10-06  David Kilzer  <ddkilzer@apple.com>
  29
  30         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
  31
  32         Reviewed by Adam Roben.
  33
  34         This is the first step in making webarchive tests work on
  35         Windows.
  36
  37         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
  38         new files to the project.
  39         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
  40         to WebArchiveDumpSupport.mm.
  41         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
  42         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
  43         (serializeWebArchiveToXML):
  44
  45 2010-10-05  Daniel Bates  <dbates@rim.com>
  46
  47         Reviewed by David Kilzer.
  48
  49         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
  50         https://bugs.webkit.org/show_bug.cgi?id=46058
  51
  52         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
  53         structure so as to support returning additional information
  54         about a change log diff.
  55
  56         Currently, VCSUtils::fixChangeLogPatch() returns a string that
  57         represents the change log diff. Towards supporting the return
  58         of additional information, such as whether the change log diff
  59         inserts an entry at the top of the ChangeLog file, we need to
  60         make VCSUtils::fixChangeLogPatch() return a reference to hash
  61         structure.
  62
  63         * Scripts/VCSUtils.pm:
  64           - Modified fixChangeLogPatch() to return a reference to a
  65             hash structure.
  66           - Added documentation to fixChangeLogPatch().
  67           - Modified call site in mergeChangeLogs() as necessary.
  68         * Scripts/svn-apply:
  69           - Modified call site in patch() as necessary.
  70         * Scripts/svn-create-patch:
  71           - Modified call site in generateDiff() as necessary.
  72         * Scripts/svn-unapply:
  73           - Modified call site in patch() as necessary.
  74         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
  75           - Modified the unit tests as necessary.
  76
  77 2010-10-05  Tony Chang  <tony@chromium.org>
  78
  79         Reviewed by Darin Adler.
  80
  81         fix the link to the expected image on windows
  82         https://bugs.webkit.org/show_bug.cgi?id=47228
  83
  84         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
  85             windows, the file must be opened in binary mode when writing
  86             binary data.
  87
  88 2010-10-05  Adam Barth  <abarth@webkit.org>
  89
  90         Update expected result of unittest to match Tony's change below.
  91
  92         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  93
  94 2010-10-05  Tony Chang  <tony@chromium.org>
  95
  96         Reviewed by Ojan Vafai (over the shoulder).
  97
  98         Paper over errors in image_diff so we don't crash the whole test run.
  99
 100         * Scripts/webkitpy/layout_tests/port/chromium.py:
 101
 102 2010-10-05  Tony Chang  <tony@chromium.org>
 103
 104         Unreviewed, make shutil.rmtree more resiliant to errors
 105         since windows was raising WindowsError: The process cannot access the file because it
 106         is being used by another process.
 107
 108         * Scripts/webkitpy/layout_tests/port/chromium.py:
 109
 110 2010-10-05  Tony Chang  <tony@chromium.org>
 111
 112         Reviewed by Ojan Vafai.
 113
 114         [chromium] fix image diffing in NRWT
 115         https://bugs.webkit.org/show_bug.cgi?id=47128
 116
 117         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
 118             NamedTemporaryFile since it doesn't work on Windows.
 119         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 120
 121 2010-10-05  Kenneth Russell  <kbr@google.com>
 122
 123         Reviewed by Tony Chang.
 124
 125         [chromium] Implement layerTreeAsText in DumpRenderTree
 126         https://bugs.webkit.org/show_bug.cgi?id=47216
 127
 128         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
 129         make it callable from DumpRenderTree.
 130
 131         No new tests; verified with existing compositor layout tests.
 132
 133         * DumpRenderTree/chromium/LayoutTestController.cpp:
 134         (LayoutTestController::LayoutTestController):
 135         (LayoutTestController::layerTreeAsText):
 136         * DumpRenderTree/chromium/LayoutTestController.h:
 137
 138 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
 139
 140         Unreviewed build correction.
 141
 142         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
 143         property sheet so proper libraries are linked.
 144
 145 2010-10-05  Robert Hogan  <robert@webkit.org>
 146
 147         Reviewed by Andreas Kling.
 148
 149         [Qt] Fix url conversion in QWebHistory
 150
 151         Converting from KURL to WFT::String to QUrl does not
 152         permit proper percent encoding later.
 153
 154         https://bugs.webkit.org/show_bug.cgi?id=47048
 155
 156         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 157         (WebCore::dumpHistoryItem):
 158
 159 2010-10-05  Anders Carlsson  <andersca@apple.com>
 160
 161         Reviewed by Sam Weinig.
 162
 163         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
 164         https://bugs.webkit.org/show_bug.cgi?id=47188
 165         <rdar://problem/8514104>
 166
 167         When constructing the std::string, use the real string length instead of the maximum buffer size.
 168
 169         * TestWebKitAPI/PlatformUtilities.h:
 170         (TestWebKitAPI::Util::toSTD):
 171         * WebKitTestRunner/StringFunctions.h:
 172         (WTR::toSTD):
 173
 174 2010-10-04  Sam Weinig  <sam@webkit.org>
 175
 176         Reviewed by Mark Rowe.
 177
 178         Add MIMEType accessor to WKFrame
 179         <rdar://problem/8347683>
 180         https://bugs.webkit.org/show_bug.cgi?id=47138
 181
 182         * TestWebKitAPI/PlatformUtilities.h:
 183         (TestWebKitAPI::Util::toSTD):
 184         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 185         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
 186         (TestWebKitAPI::didStartProvisionalLoadForFrame):
 187         (TestWebKitAPI::didCommitLoadForFrame):
 188         (TestWebKitAPI::didFinishLoadForFrame):
 189         (TestWebKitAPI::TEST):
 190         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
 191         (TestWebKitAPI::didStartProvisionalLoadForFrame):
 192         (TestWebKitAPI::didCommitLoadForFrame):
 193         (TestWebKitAPI::didFinishLoadForFrame):
 194         (TestWebKitAPI::TEST):
 195         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
 196         (TestWebKitAPI::TEST):
 197         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
 198         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
 199         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
 200         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
 201         (TestWebKitAPI::Util::createURLForResource):
 202
 203 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 204
 205         Reviewed by Ojan Vafai.
 206
 207         [NRWT] Rename current_dir to current_group because it's not a directory
 208         https://bugs.webkit.org/show_bug.cgi?id=47169
 209
 210         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 211         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 212
 213 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 214
 215         Unreviewed, build fix.
 216
 217         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
 218         which can't always be done. This test uses tempfile.mkdtemp(), which
 219         should be safe.
 220
 221         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 222
 223 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 224
 225         Unreviewed, build fix.
 226
 227         Add missing "from __future__ import with_statement" that was
 228         breaking test-webkitpy on the Leopard bots (broke in r69040).
 229
 230         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 231
 232 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
 233
 234         Unreviewed, rolling out r69066.
 235         http://trac.webkit.org/changeset/69066
 236         https://bugs.webkit.org/show_bug.cgi?id=47163
 237
 238         Made NRWT reliability worse. (Requested by tkent on #webkit).
 239
 240         * Scripts/webkitpy/layout_tests/port/chromium.py:
 241         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 242
 243 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 244
 245         Reviewed by Tony Chang.
 246
 247         [NRWT] Reverse the http tests to alphabetical order.
 248         https://bugs.webkit.org/show_bug.cgi?id=47075
 249
 250         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 251
 252 2010-10-04  Robert Hogan  <robert@webkit.org>
 253
 254         Reviewed by Andreas Kling.
 255
 256         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
 257
 258         We need to queue back and forward navigations in the DRT from the
 259         LayoutTestController so that maybeDump() knows about them.
 260
 261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 262         (LayoutTestController::queueBackNavigation):
 263         (LayoutTestController::queueForwardNavigation):
 264
 265 2010-10-04  Tony Chang  <tony@chromium.org>
 266
 267         Reviewed by Kent Tamura.
 268
 269         [chromium] fix image diffing in NRWT
 270         https://bugs.webkit.org/show_bug.cgi?id=47128
 271
 272         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
 273               temp file and check the image_diff error code more carefully
 274         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 275
 276 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 277
 278         Reviewed by Adam Barth.
 279
 280         aroben's change in r68792 actually broke new-run-webkit-tests when
 281         running the DRT code path. His change was intended to fix the
 282         way we were converting windows paths to URIs when running under
 283         Cygwin (the paths were getting one too many "/" on the front).
 284         However, the change ended up breaking the chromium_win port, which
 285         had slightly different logic.
 286
 287         This patch removes the port-specific code and adds tests to make
 288         sure we're getting the behavior we expect. The Port object no longer
 289         exposes a get_absolute_path() method that can be used outside of
 290         of converting test filenames, because it's unreliable otherwise
 291         (we don't have the right context to know which conversion is intended).
 292
 293         https://bugs.webkit.org/show_bug.cgi?id=47140
 294
 295         * Scripts/webkitpy/layout_tests/port/base.py:
 296         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 297         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 298         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 299         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 300
 301 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 302
 303         Unreviewed, build fix.
 304
 305         Handle crash introduced in r69040 if we are not running in a
 306         Chromium checkout.
 307
 308         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 309
 310 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
 311
 312         Reviewed by Tony Chang.
 313
 314         Add a way for us to have test expectations that are specific to the
 315         official builds of Google Chrome (as opposed to Chromium). This change
 316         looks for an additional "test_expectations_chrome.txt" file in
 317         Chromium's repository (webkit/tools/layout_tests), and uses the
 318         concatenation of that file and the regular test_expectations.txt
 319         file for test overrides.
 320
 321         https://bugs.webkit.org/show_bug.cgi?id=46854
 322
 323         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
 324         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 325
 326 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
 327
 328         Color tests in the list based on existing pass/fail result.
 329
 330         Fix the summary data to account for htmlOnly and nonHTML tests.
 331
 332         * CSSTestSuiteHarness/harness/harness.css:
 333         (#test-list > option.pass):
 334         (#test-list > option.fail):
 335         (#test-list > option.skipped):
 336         * CSSTestSuiteHarness/harness/harness.js:
 337         (Test):
 338         (Test.prototype.statusForFormat):
 339         (TestSuite.prototype.fillTestList):
 340         (TestSuite.prototype.updateTestList):
 341         (TestSuite.prototype.recordResult):
 342         (TestSuite.prototype.markTestCompleted):
 343         (TestSuite.prototype.countTestsWithFlag):
 344         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
 345         (TestSuite.prototype.queryDatabaseForSummary):
 346
 347 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
 348
 349         Reviewed by Beth Dakin.
 350
 351         AX: doAXRangeForLine does not work
 352         https://bugs.webkit.org/show_bug.cgi?id=47101
 353
 354         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
 355
 356         * DumpRenderTree/AccessibilityUIElement.cpp:
 357         (rangeForLineCallback):
 358         (AccessibilityUIElement::rangeForLine):
 359         (AccessibilityUIElement::getJSClass):
 360         * DumpRenderTree/AccessibilityUIElement.h:
 361         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 362         (AccessibilityUIElement::rangeForLine):
 363
 364 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
 365
 366         Unreviewed. Adding myself to the committers list.
 367
 368         * Scripts/webkitpy/common/config/committers.py:
 369
 370 2010-10-04  Sam Weinig  <sam@webkit.org>
 371
 372         Reviewed by Anders Carlsson.
 373
 374         Add ability to set the CacheModel in Webkit2
 375         https://bugs.webkit.org/show_bug.cgi?id=47066
 376
 377         * MiniBrowser/mac/AppDelegate.m:
 378         (-[BrowserAppDelegate init]): Opt minibrowser into
 379         a PrimaryWebBrowser cache model.
 380
 381 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
 382
 383         Make sure to enter all tests when creating the database
 384         for the first time.
 385
 386         When migrating to a new version of the suite, be sure to
 387         sync up the database and testinfo.data by removing old
 388         tests, and inserting new ones.
 389
 390         * CSSTestSuiteHarness/harness/harness.js:
 391         (TestSuite.prototype.openDatabase.creation):
 392         (TestSuite.prototype.databaseCreated):
 393         (TestSuite.prototype.populateDatabaseFromTestInfoData):
 394         (TestSuite.prototype.insertTest):
 395
 396 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
 397
 398         More work on treating HTML4 and XHTML1 independently; when
 399         changing the format, rebuild the test list, and update the
 400         numbers in the chapter popup.
 401
 402         * CSSTestSuiteHarness/harness/harness.js:
 403         (Test):
 404         (Test.prototype.runForFormat):
 405         (Test.prototype.completedForFormat):
 406         (ChapterSection):
 407         (ChapterSection.prototype.countTests):
 408         (Chapter):
 409         (Chapter.prototype.description):
 410         (Chapter.prototype.countTests):
 411         (Chapter.prototype.testCount):
 412         (Chapter.prototype.untestedCount):
 413         (TestSuite.prototype.buildChapters):
 414         (TestSuite.prototype.loadCurrentTest):
 415         (TestSuite.prototype.updateProgressLabel):
 416         (TestSuite.prototype.processFlags):
 417         (TestSuite.prototype.formatChanged):
 418
 419 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
 420
 421         Update test suite version 20101001.
 422
 423         Handle database migration, and delete tests from the db that are
 424         not present in testinfo.data.
 425
 426         Load about:blank into the test frame before the test url, to make
 427         missing tests more obvious.
 428
 429         * CSSTestSuiteHarness/harness/harness.js:
 430         (TestSuite.prototype.loadTest):
 431         (TestSuite.prototype.openDatabase.creation):
 432         (TestSuite.prototype.openDatabase.migration1_0To1_1):
 433         (TestSuite.prototype.openDatabase.if.return):
 434         (TestSuite.prototype.databaseReady):
 435         (TestSuite.prototype.populateDatabaseFromTestInfoData):
 436         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
 437         (TestSuite.prototype.syncDatabaseWithTestInfoData):
 438
 439 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
 440
 441         Add the ability to jump to a specific test.
 442
 443         * CSSTestSuiteHarness/harness/harness.html:
 444         * CSSTestSuiteHarness/harness/harness.js:
 445         (TestSuite.prototype.goToTestByName):
 446         (TestSuite.prototype.switchToFormat):
 447
 448 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
 449
 450         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
 451         as the test.
 452
 453         * CSSTestSuiteHarness/harness/harness.js:
 454         (TestSuite.prototype.loadRef):
 455
 456 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
 457
 458         Update the UI to reflect the fact that each test needs to be tested
 459         in both HTML4 and XHTML1 format.
 460
 461         * CSSTestSuiteHarness/harness/harness.js:
 462         (Test):
 463         (Chapter.prototype.description):
 464         (Chapter.prototype.untestedCount):
 465         (TestSuite.prototype.fillChapterPopup):
 466         (TestSuite.prototype.updateChapterPopup):
 467         (TestSuite.prototype.fillTestList):
 468         (TestSuite.prototype.updateTestList):
 469         (TestSuite.prototype.goToNextIncompleteTest):
 470         (TestSuite.prototype.firstIncompleteTestIndex):
 471         (TestSuite.prototype.recordResult):
 472         (TestSuite.prototype.formatChanged):
 473         (TestSuite.prototype.markTestCompleted):
 474         (TestSuite.prototype.resetTestStatus):
 475
 476 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
 477
 478         Add the ability to remove results for re-testing, and
 479         to import results.
 480
 481         * CSSTestSuiteHarness/harness/harness.css:
 482         (.custom button):
 483         (#overlay):
 484         (#overlay.visible):
 485         (.overlay-contents):
 486         (.overlay-contents textarea):
 487         (.overlay-contents .buttons):
 488         (.overlay-contents .note):
 489         (.overlay-contents .buttons button):
 490         * CSSTestSuiteHarness/harness/harness.html:
 491         * CSSTestSuiteHarness/harness/harness.js:
 492         (TestSuite.prototype.importResults):
 493         (TestSuite.prototype.clearResults):
 494         (TestSuite.prototype.markTestCompleted):
 495         (TestSuite.prototype.resetTestStatus):
 496         (TestSuite.prototype.storeTestResult):
 497         (TestSuite.prototype.importTestResults):
 498         (TestSuite.prototype.clearTestResults):
 499
 500 2010-10-01  Sam Weinig  <sam@webkit.org>
 501
 502         Reviewed by Jon Honeycutt.
 503
 504         Deploy the new WKString functions to remove most uses of CF from
 505         the WebKitTestRunner.
 506
 507         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 508         (WTR::InjectedBundle::didReceiveMessage):
 509         (WTR::InjectedBundle::done):
 510         * WebKitTestRunner/StringFunctions.h:
 511         (WTR::toWK):
 512         (WTR::toJS):
 513         (WTR::toSTD):
 514         (WTR::operator<<):
 515         (WTR::copyURLString):
 516         * WebKitTestRunner/TestController.cpp:
 517         (WTR::TestController::resetStateToConsistentValues):
 518         (WTR::TestController::didFinishLoadForFrame):
 519         * WebKitTestRunner/TestInvocation.cpp:
 520         (WTR::TestInvocation::invoke):
 521         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 522
 523 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
 524
 525         Unreviewed TestResultsServer change.
 526
 527         Add files introduced by http://crrev.com/61273 to the list of dashboard
 528         files to update.
 529
 530         * TestResultServer/handlers/dashboardhandler.py:
 531
 532 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
 533
 534         Build Fix for Windows.
 535
 536         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
 537             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
 538             ForwardingHeaders to the include path.
 539
 540 2010-10-01  Sam Weinig  <sam@webkit.org>
 541
 542         Reviewed by Anders Carlsson.
 543
 544         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
 545
 546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 547         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
 548         (TestWebKitAPI::TEST):
 549         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
 550         (TestWebKitAPI::TEST):
 551
 552 2010-10-01  Sam Weinig  <sam@webkit.org>
 553
 554         Reviewed by Kenneth Rohde Christiansen.
 555
 556         Add additional WKString API
 557         https://bugs.webkit.org/show_bug.cgi?id=46958
 558
 559         Add basic WKStringRef tests.
 560
 561         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 562         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
 563
 564 2010-10-01  Sam Weinig  <sam@webkit.org>
 565
 566         Reviewed by Dan Bernstein.
 567
 568         Add makefile for TestWebKitAPI and call it from the base makefile.
 569
 570         * Makefile:
 571         * TestWebKitAPI/Makefile: Added.
 572
 573 2010-10-01  Sam Weinig  <sam@webkit.org>
 574
 575         Reviewed by Adam Roben.
 576
 577         Remove unnecessary ForwardingHeaders from test runners.
 578         https://bugs.webkit.org/show_bug.cgi?id=47010
 579
 580         * TestWebKitAPI/Configurations/Base.xcconfig:
 581         * TestWebKitAPI/ForwardingHeaders: Removed.
 582         * WebKitTestRunner/Configurations/Base.xcconfig:
 583         * WebKitTestRunner/ForwardingHeaders: Removed.
 584
 585 2010-09-30  Adam Barth  <abarth@webkit.org>
 586
 587         Reviewed by Eric Seidel.
 588
 589         WebSocket tests are flaky
 590         https://bugs.webkit.org/show_bug.cgi?id=46956
 591
 592         Update these tools to understand how to run the WebSocket tests off the
 593         Apache server.
 594
 595         * Scripts/old-run-webkit-tests:
 596         * Scripts/webkitpy/layout_tests/port/base.py:
 597         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
 598         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 599
 600 2010-10-01  Adam Roben  <aroben@apple.com>
 601
 602         Encode Executive command arguments using UTF-8 on Cygwin
 603
 604         Cygwin's Python's os.execv doesn't support unicode command arguments.
 605         Cygwin's execv expects arguments to be encoded using the current code
 606         page. But code pages are limited in what characters they can handle,
 607         and our tests include characters that the English code page can't
 608         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
 609         which can handle all characters but might confuse some commands, for
 610         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
 611         good enough, but we can deal with that when the problem arises.
 612
 613         Reviewed by Adam Barth.
 614
 615         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
 616         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
 617         fails on Windows
 618
 619         * Scripts/webkitpy/common/system/executive.py:
 620         (Executive._run_command_with_teed_output):
 621         (Executive.run_command):
 622         On Cygwin, encode arguments using UTF-8.
 623
 624 2010-10-01  Sam Weinig  <sam@webkit.org>
 625
 626         Reviewed by Adam Roben.
 627
 628         Add simple API tester for WebKit2
 629         https://bugs.webkit.org/show_bug.cgi?id=46953
 630
 631         This adds a very simple testing infrastructure for testing APIs exposed
 632         through the WebKit project. It consists of two parts: 1) a project that
 633         builds the all the tests 2) a script that searches the tests directory and
 634         calls the tester once for each test.
 635
 636         This adds the infrastructure and two tests:
 637         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
 638         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
 639
 640         This currently only works on the mac, but is designed to be easily ported
 641         to any platform.
 642
 643         * Scripts/run-api-tests: Added.
 644         * Scripts/build-api-tests: Added.
 645         Scripts to build/run the tests.
 646
 647         * TestWebKitAPI: Added.
 648         * TestWebKitAPI/Configurations: Added.
 649         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
 650         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
 651         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
 652         * TestWebKitAPI/ForwardingHeaders: Added.
 653         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
 654         * TestWebKitAPI/PlatformUtilities.h: Added.
 655         * TestWebKitAPI/PlatformWebView.h: Added.
 656         (TestWebKitAPI::PlatformWebView::platformView):
 657         * TestWebKitAPI/StringFunctions.h: Added.
 658         * TestWebKitAPI/Test.h: Added.
 659         (TestWebKitAPI::Test::~Test):
 660         (TestWebKitAPI::Test::name):
 661         (TestWebKitAPI::Test::Register::Register):
 662         (TestWebKitAPI::Test::Register::create):
 663         (TestWebKitAPI::Test::Test):
 664         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
 665         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
 666         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
 667         * TestWebKitAPI/TestsController.cpp: Added.
 668         (TestWebKitAPI::TestsController::shared):
 669         (TestWebKitAPI::TestsController::TestsController):
 670         (TestWebKitAPI::TestsController::runTestNamed):
 671         (TestWebKitAPI::TestsController::testFailed):
 672         (TestWebKitAPI::TestsController::registerCreateTestFunction):
 673         * TestWebKitAPI/TestsController.h: Added.
 674         * TestWebKitAPI/mac: Added.
 675         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
 676         (TestWebKitAPI::Util::run):
 677         (TestWebKitAPI::Util::createURLForResource):
 678         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
 679         (TestWebKitAPI::PlatformWebView::PlatformWebView):
 680         (TestWebKitAPI::PlatformWebView::resizeTo):
 681         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
 682         (TestWebKitAPI::PlatformWebView::page):
 683         (TestWebKitAPI::PlatformWebView::focus):
 684         * TestWebKitAPI/mac/main.mm: Added.
 685         Infrastructure.
 686
 687         * TestWebKitAPI/Tests: Added.
 688         * TestWebKitAPI/Tests/WTF: Added.
 689         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
 690         * TestWebKitAPI/Tests/WebKit2: Added.
 691         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
 692         (TestWebKitAPI::State::State):
 693         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
 694         Proof of concept tests.
 695
 696 2010-10-01  Adam Roben  <aroben@apple.com>
 697
 698         Don't assume AccessibleObjectFromEvent succeeds
 699
 700         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
 701         DumpRenderTree!notificationListenerProc when running
 702         plugins/access-after-page-destroyed.html
 703
 704         Reviewed by Sam Weinig.
 705
 706         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
 707         (notificationListenerProc): Check both the return value of
 708         AccessibleObjectFromEvent and the object it returns, as MSDN
 709         recommends.
 710
 711 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 712
 713         Reviewed by Tony Chang.
 714
 715         [NRWT] Put the http and websocket tests first in the test list.
 716         https://bugs.webkit.org/show_bug.cgi?id=46453
 717
 718         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 719         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 720
 721 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
 722
 723         Unreviewed, adding myself to the committer list.
 724
 725         * Scripts/webkitpy/common/config/committers.py:
 726
 727 2010-10-01  Adam Roben  <aroben@apple.com>
 728
 729         Test NPN_GetValue(NPNVnetscapeWindow)
 730
 731         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
 732         Right-clicking on windowless Flash plugin in WebKit2 makes a context
 733         menu appear in the bottom-right corner of the screen
 734
 735         Reviewed by Anders Carlsson.
 736
 737         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
 738         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
 739
 740         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
 741
 742         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
 743         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
 744         (GetValueNetscapeWindow::NPP_SetWindow): Test that
 745         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
 746         isn't our HWND.
 747
 748         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
 749         Added GetValueNetscapeWindow.
 750
 751 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
 752
 753         Unreviewed, adding my webkit.org identity to reviewer list.
 754
 755         * Scripts/webkitpy/common/config/committers.py:
 756
 757 2010-09-30  Adam Barth  <abarth@webkit.org>
 758
 759         Reviewed by Eric Seidel.
 760
 761         The WebSocket server should flush its logs
 762         https://bugs.webkit.org/show_bug.cgi?id=46946
 763
 764         The WebSocket server logs are truncated because the driver just
 765         terminates the child.  It should run Python without buffering so we can
 766         see the end of the log.
 767
 768         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
 769
 770 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
 771
 772         Add a button to jump to the next untested test.
 773
 774         * CSSTestSuiteHarness/harness/harness.css:
 775         (.test-type):
 776         (.name > button):
 777         * CSSTestSuiteHarness/harness/harness.html:
 778         * CSSTestSuiteHarness/harness/harness.js:
 779         (Chapter.prototype.description):
 780         (Chapter.prototype.untestedCount):
 781         (TestSuite.prototype.testInfoDataLoaded):
 782         (TestSuite.prototype.fillChapterPopup):
 783         (TestSuite.prototype.updateChapterPopup):
 784         (TestSuite.prototype.buildTestListForChapter):
 785         (TestSuite.prototype.goToNextIncompleteTest):
 786         (TestSuite.prototype.firstIncompleteTestIndex):
 787         (TestSuite.prototype.testCompletionStateChanged):
 788
 789 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
 790
 791         WebKit2 on Windows should use Windows fonts for the various standard
 792         font families
 793         https://bugs.webkit.org/show_bug.cgi?id=43499
 794         <rdar://problem/8272758>
 795
 796         Reviewed by Adam Roben.
 797
 798         * WebKitTestRunner/TestController.cpp:
 799         (WTR::TestController::resetStateToConsistentValues):
 800         Use the Mac fonts for running tests. This matches DRT behavior.
 801
 802 2010-09-30  Adam Barth  <abarth@webkit.org>
 803
 804         Third attempt.  We need a better integration test environment.
 805
 806         * Scripts/webkitpy/common/net/failuremap.py:
 807         * Scripts/webkitpy/common/net/failuremap_unittest.py:
 808
 809 2010-09-30  Robert Hogan  <robert@webkit.org>
 810
 811         Reviewed by Andreas Kling.
 812
 813         [Qt] Support for PlainTextController
 814
 815         Unskip editing/text-iterator/basic-iteration.html
 816
 817         https://bugs.webkit.org/show_bug.cgi?id=38805
 818
 819         * DumpRenderTree/qt/DumpRenderTree.pro:
 820         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 821         (WebCore::DumpRenderTree::DumpRenderTree):
 822         (WebCore::DumpRenderTree::initJSObjects):
 823         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 824         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
 825         (PlainTextController::PlainTextController):
 826         (PlainTextController::plainText):
 827         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
 828
 829 2010-09-30  Adam Barth  <abarth@webkit.org>
 830
 831         Unreviewed.  Second attempt to fix sheriffbot.
 832
 833         * Scripts/webkitpy/common/net/buildbot.py:
 834
 835 2010-09-30  Adam Barth  <abarth@webkit.org>
 836
 837         Unreviewed.
 838
 839         This patch should stop the sheriffbot from throwing an exception.
 840
 841         * Scripts/webkitpy/common/net/buildbot.py:
 842
 843 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
 844
 845         Reviewed by Adam Roben.
 846
 847         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
 848         https://bugs.webkit.org/show_bug.cgi?id=46926
 849
 850         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows
 851             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
 852
 853 2010-09-30  Adam Barth  <abarth@webkit.org>
 854
 855         Reviewed by Eric Seidel.
 856
 857         webkit-patch find-flaky-tests should print results URLs
 858         https://bugs.webkit.org/show_bug.cgi?id=46917
 859
 860         Printing out the results URL makes find-flaky-tests more actionable
 861         because you can see what happens when a test fails.  The output from
 862         the script is still pretty noisy, but it seems useful.
 863
 864         * Scripts/webkitpy/tool/commands/queries.py:
 865
 866 2010-09-30  Chris Marrin  <cmarrin@apple.com>
 867
 868         Reviewed by Simon Fraser.
 869
 870         Make 2D accelerated canvas rendering build on Mac
 871         https://bugs.webkit.org/show_bug.cgi?id=46007
 872
 873         Added ACCELERATED_2D_CANVAS to build-webkit
 874
 875         * Scripts/build-webkit:
 876
 877 2010-09-29  Kenneth Russell  <kbr@google.com>
 878
 879         Reviewed by Dimitri Glazkov.
 880
 881         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
 882         https://bugs.webkit.org/show_bug.cgi?id=46849
 883
 884         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
 885         works with the compositor integration in both DumpRenderTree and
 886         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
 887         and thereby trigger the compositor's readback code path. Added support
 888         for --enable-accelerated-compositing to DumpRenderTree.
 889
 890         Tested in both test_shell and DumpRenderTree on Linux, the latter by
 891         modifying a compositing layout test, dumping the pixels and verifying
 892         that they matched the output when the compositor was active.
 893
 894         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 895         (main):
 896         * DumpRenderTree/chromium/TestShell.cpp:
 897         (TestShell::TestShell):
 898         (TestShell::resetWebSettings):
 899         * DumpRenderTree/chromium/TestShell.h:
 900         (TestShell::setAcceleratedCompositingEnabled):
 901         * DumpRenderTree/chromium/WebPreferences.cpp:
 902         (WebPreferences::reset):
 903         (WebPreferences::applyTo):
 904         * DumpRenderTree/chromium/WebPreferences.h:
 905         * DumpRenderTree/chromium/WebViewHost.cpp:
 906         (WebViewHost::scheduleComposite):
 907         * DumpRenderTree/chromium/WebViewHost.h:
 908
 909 2010-09-30  Adam Roben  <aroben@apple.com>
 910
 911         Ensure that QueueEngine cleans up its log files when its delegate
 912         tells it to stop processing work
 913
 914         Reviewed by Adam Barth.
 915
 916         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
 917         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
 918         Windows
 919
 920         * Scripts/webkitpy/tool/bot/queueengine.py:
 921         (QueueEngine.run): Stop ourselves normally (including cleaning up log
 922         files) when the delegate tells us to stop processing work.
 923
 924         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
 925         (LoggingDelegate.__init__): Moved code here from
 926         RaisingDelegate.__init__.
 927         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
 928         callback.
 929         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
 930         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
 931         care of for us now.
 932         (QueueEngineTest.test_trivial): Make sure we got the expected stop
 933         message.
 934         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
 935         remove the callbacks that are related to processing a single work
 936         item, rather than removing all callbacks after a certain point, as
 937         there are now more callbacks we expect to receive at the end.
 938
 939 2010-09-30  Adam Roben  <aroben@apple.com>
 940
 941         Fix path -> URL conversion on Cygwin
 942
 943         Reviewed by Adam Barth.
 944
 945         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
 946         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
 947
 948         * Scripts/webkitpy/layout_tests/port/base.py:
 949         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
 950         assuming paths already have a leading slash.
 951
 952 2010-09-30  Adam Roben  <aroben@apple.com>
 953
 954         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
 955         be called more than once
 956
 957         The NPP_SetWindow call made when the plugin is torn down was confusing
 958         us, and was causing us to spew an error into the next test.
 959
 960         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
 961         (r68520): plugins/access-after-page-destroyed.html failing on Windows
 962
 963         Reviewed by Anders Carlsson.
 964
 965         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
 966         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
 967         Initialize member.
 968         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
 969         this isn't the first time this is called.
 970
 971 2010-09-30  Eric Seidel  <eric@webkit.org>
 972
 973         Reviewed by Adam Barth.
 974
 975         webkit-patch upload warns that I'm using Xcode when I'm not
 976         https://bugs.webkit.org/show_bug.cgi?id=46869
 977
 978         String.find returns -1 when not found, so switched to "in".
 979
 980         * Scripts/webkitpy/common/system/user.py:
 981         * Scripts/webkitpy/common/system/user_unittest.py:
 982
 983 2010-09-30  Eric Seidel  <eric@webkit.org>
 984
 985         Reviewed by Adam Barth.
 986
 987         webkit-patch failure-reason dies if non-trunk commits are in the blame range
 988         https://bugs.webkit.org/show_bug.cgi?id=46866
 989
 990         I also made failure-reason use RegressionWindow in a cleaner way.
 991
 992         * Scripts/webkitpy/tool/commands/queries.py:
 993
 994 2010-09-29  Adam Barth  <abarth@webkit.org>
 995
 996         Reviewed by Eric Seidel.
 997
 998         webkit-patch find-flaky-tests
 999         https://bugs.webkit.org/show_bug.cgi?id=46876
1000
1001         This command helps us find flaky tests so we can squash them.
1002
1003         * Scripts/webkitpy/tool/commands/queries.py:
1004
1005 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1006
1007         Fix export to use '?' instead of 'null' for
1008         tests with no results.
1009
1010         * CSSTestSuiteHarness/harness/harness.js:
1011
1012 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1013
1014         Add a warning when a test requires special steps.
1015         Add a Print Preview button for 'paged' tests that
1016         brings up the print dialog, allowing the user to
1017         judge paged media tests.
1018
1019         * CSSTestSuiteHarness/harness/harness.css:
1020         * CSSTestSuiteHarness/harness/harness.html:
1021         * CSSTestSuiteHarness/harness/harness.js:
1022         (TestSuite.prototype.loadTest):
1023         (TestSuite.prototype.processFlags):
1024
1025 2010-09-29  Adam Barth  <abarth@webkit.org>
1026
1027         Reviewed by Eric Seidel.
1028
1029         Remove revisions_casuing_failures
1030         https://bugs.webkit.org/show_bug.cgi?id=46872
1031
1032         This function exists only to be unit tested.
1033
1034         * Scripts/webkitpy/common/net/failuremap.py:
1035         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1036         * Scripts/webkitpy/tool/mocktool.py:
1037
1038 2010-09-29  Adam Barth  <abarth@webkit.org>
1039
1040         Reviewed by Eric Seidel.
1041
1042         SheriffBot should post the list of failing tests to bugs
1043         https://bugs.webkit.org/show_bug.cgi?id=46871
1044
1045         * Scripts/webkitpy/common/net/buildbot.py:
1046         * Scripts/webkitpy/common/net/failuremap.py:
1047         * Scripts/webkitpy/common/net/regressionwindow.py:
1048         * Scripts/webkitpy/tool/bot/sheriff.py:
1049         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1050         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1051         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1052         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1053         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1054         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1055         * Scripts/webkitpy/tool/mocktool.py:
1056
1057 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1058
1059         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1060
1061         [WinCairo] Adds a build slave.
1062         https://bugs.webkit.org/show_bug.cgi?id=46360
1063
1064         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1065         entries for a debug build of the WinCairo port.
1066         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1067         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1068         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1069         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1070
1071 2010-09-29  Adam Barth  <abarth@webkit.org>
1072
1073         Reviewed by Eric Seidel.
1074
1075         Move more SheriffBot smarts into FailureMap
1076         https://bugs.webkit.org/show_bug.cgi?id=46703
1077
1078         This patch pushes the FailureMap model object further into the
1079         SheriffBot machine.  In addition, it moves a couple operations on this
1080         object from SheriffBot itself to the model.
1081
1082         Eventually, FailureMap will be the canonical context object for
1083         SheriffBot operations.  FailureMap represents a map of the current
1084         failures on the bots that might require remediation.
1085
1086         * Scripts/webkitpy/common/net/failuremap.py:
1087         * Scripts/webkitpy/common/net/regressionwindow.py:
1088         * Scripts/webkitpy/tool/commands/queries.py:
1089         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1090         * Scripts/webkitpy/tool/mocktool.py:
1091
1092 2010-09-29  Tony Chang  <tony@chromium.org>
1093
1094         Reviewed by James Robinson.
1095
1096         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1097         https://bugs.webkit.org/show_bug.cgi?id=46829
1098
1099         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1100         (DRTDevToolsClient::DRTDevToolsClient):
1101         * DumpRenderTree/chromium/TestShell.cpp:
1102         (TestShell::TestShell):
1103         * DumpRenderTree/chromium/WebViewHost.cpp:
1104         (WebViewHost::postAccessibilityNotification):
1105         (WebViewHost::WebViewHost):
1106
1107 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1108
1109         Reviewed by Darin Adler.
1110
1111         AX: implement CSS3 Speech "speak"
1112         https://bugs.webkit.org/show_bug.cgi?id=46827
1113
1114         * DumpRenderTree/AccessibilityUIElement.cpp:
1115         (speakCallback):
1116         (AccessibilityUIElement::speak):
1117         (AccessibilityUIElement::getJSClass):
1118         * DumpRenderTree/AccessibilityUIElement.h:
1119         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1120         (AccessibilityUIElement::speak):
1121
1122 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1123
1124         Reviewed by Adam Barth.
1125
1126         Record bot ID when updating queue status
1127         https://bugs.webkit.org/show_bug.cgi?id=46764
1128
1129         Since we now have multiple bots handling patches from the commit queue,
1130         we need to differentiate status updates from them, so that we can group
1131         the queue status page in a less confusing way.
1132
1133         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1134         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1135         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1136         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1137         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1138         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1139         * Scripts/webkitpy/tool/main.py: Add --bot-id
1140         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1141
1142 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1143
1144         No review.
1145
1146         References always refert to a file in .xht format, even
1147         for HTML tests, so fix their loading.
1148
1149         * CSSTestSuiteHarness/harness/harness.js:
1150         (TestSuite.prototype.loadRef):
1151
1152 2010-09-28  Johnny Ding  <jnd@chromium.org>
1153
1154         Reviewed by Adam Barth.
1155
1156         https://bugs.webkit.org/show_bug.cgi?id=41292
1157         Add a new parameter to the test plugin to allow specifying a script
1158         and a mouse/keyboard event. The specified script will be evaluated
1159         in the browser when the specified event is received by the plugin.
1160
1161         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1162         (pluginAllocate):
1163         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1164         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1165         (NPP_New):
1166         (handleEventCarbon):
1167         (handleEventCocoa):
1168
1169 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1170
1171         Fix export by adding missing argument.
1172
1173         * CSSTestSuiteHarness/harness/harness.js:
1174         (TestSuite.prototype.showResultsForAllTests):
1175
1176 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1177
1178         [wx] Build fix, add missing import.
1179
1180         * wx/packaging/build-win-installer.py:
1181
1182 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1183
1184         No review
1185
1186         Show which tests have been run by dimming them out in the test list.
1187
1188         Adjust some element sizes.
1189
1190         * CSSTestSuiteHarness/harness/harness.css:
1191         (#test-list > option.untested):
1192         (#test-list > option.completed):
1193         (#output):
1194         (.output-options):
1195         * CSSTestSuiteHarness/harness/harness.js:
1196         (Test):
1197         (TestSuite.prototype.fillTestList):
1198         (TestSuite.prototype.updateTestList):
1199         (TestSuite.prototype.setSelectedChapter):
1200         (TestSuite.prototype.recordResult):
1201         (TestSuite.prototype.markTestCompleted):
1202         (TestSuite.prototype.testCompletionStateChanged):
1203         (TestSuite.prototype.loadTestStatus):
1204
1205 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1206
1207         No review.
1208
1209         Implement export of various queries on the test database, sharing
1210         code with that which displays results inline.
1211
1212         * CSSTestSuiteHarness/harness/harness.js:
1213         ():
1214         (TestSuite.prototype.exportResultsCompletion.var):
1215         (TestSuite.prototype.exportResultsCompletion):
1216         (TestSuite.prototype.showResultsForCompletedTests):
1217         (TestSuite.prototype.exportResultsForCompletedTests):
1218         (TestSuite.prototype.showResultsForAllTests):
1219         (TestSuite.prototype.exportResultsForAllTests):
1220         (TestSuite.prototype.exportResultsForTestsNotRun):
1221         (TestSuite.prototype.exportResultsForTestsWithStatus):
1222         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1223
1224 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1225
1226         No review.
1227
1228         Work around uncertainty about the order of database
1229         transactions when creating the database, so that we don't
1230         try to query the table before it has been created.
1231
1232         * CSSTestSuiteHarness/harness/harness.js:
1233         (TestSuite):
1234         (TestSuite.prototype.databaseCreated):
1235         (TestSuite.prototype.storeTestResult):
1236         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1237         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1238         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1239         (TestSuite.prototype.queryDatabaseForCompletedTests):
1240         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1241
1242 2010-09-28  Tony Chang  <tony@chromium.org>
1243
1244         Reviewed by Eric Seidel.
1245
1246         add python keyring support to webkit-patch
1247         https://bugs.webkit.org/show_bug.cgi?id=41269
1248
1249         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1250             the python keyring module
1251         * Scripts/webkitpy/common/net/credentials_unittest.py:
1252         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1253         * Scripts/webkitpy/common/system/user_unittest.py:
1254         * Scripts/webkitpy/tool/mocktool.py:
1255
1256 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1257
1258         Reviewed by Gustavo Noronha Silva.
1259
1260         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1261         https://bugs.webkit.org/show_bug.cgi?id=46740
1262
1263         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1264         fonts which can be used to fully test FontConfig rendering settings.
1265
1266 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1267
1268         Reviewed by Gustavo Noronha Silva.
1269
1270         [gtk] Fedora has a different path for the liberation fonts
1271         https://bugs.webkit.org/show_bug.cgi?id=46709
1272
1273         When searching for DRT fonts, also look in the path where those fonts
1274         are commonly found on Fedora systems.
1275
1276         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1277         (initializeFonts): Include logic for looking for Fedora-style font paths.
1278
1279 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1280
1281         Reviewed by Andreas Kling.
1282
1283         run-webkit-tests needs an updated list of directories with webgl tests
1284         https://bugs.webkit.org/show_bug.cgi?id=46747
1285
1286         Update the list of directories containing WebGL tests and a unit test
1287         which depends on this list.
1288
1289         * Scripts/old-run-webkit-tests: Update the list of directories.
1290         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1291         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1292
1293 2010-09-28  Adam Barth  <abarth@webkit.org>
1294
1295         Reviewed by Eric Seidel.
1296
1297         Introduce FailureMap to summaries the failures status of all the bots
1298         https://bugs.webkit.org/show_bug.cgi?id=46700
1299
1300         This patch gives the SheriffBot a handle on the list of failing tests.
1301
1302         * Scripts/webkitpy/common/net/buildbot.py:
1303         * Scripts/webkitpy/common/net/failuremap.py: Added.
1304         * Scripts/webkitpy/tool/commands/queries.py:
1305         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1306         * Scripts/webkitpy/tool/mocktool.py:
1307
1308 2010-09-28  Adam Roben  <aroben@apple.com>
1309
1310         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1311
1312         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1313         tell a WebKit2 client application that a key event was not handled
1314
1315         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1316
1317         * MiniBrowser/mac/BrowserWindowController.m:
1318         (-[BrowserWindowController awakeFromNib]):
1319         * MiniBrowser/win/BrowserView.cpp:
1320         (BrowserView::create):
1321         * WebKitTestRunner/TestController.cpp:
1322         (WTR::createOtherPage):
1323         (WTR::TestController::initialize):
1324
1325 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1326
1327         Unreviewed.
1328
1329         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1330         for the test order, but instead use information from testinfo.data.
1331
1332         * CSSTestSuiteHarness/harness/harness.html:
1333         * CSSTestSuiteHarness/harness/harness.js:
1334
1335 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1336
1337         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1338         it causes the process to hang on the gitorious repo.
1339
1340         * wx/packaging/build-mac-installer.py:
1341         * wx/packaging/build-win-installer.py:
1342
1343 2010-09-28  Adam Roben  <aroben@apple.com>
1344
1345         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1346         called
1347
1348         Reviewed by Anders Carlsson.
1349
1350         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1351         Full-page Adobe Reader does not paint until window is resized
1352
1353         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1354         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1355         this level.
1356
1357         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1358         NPP_SetWindow.
1359
1360         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1361         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1362         the plugin's HWND has a non-zero size and that its size/position
1363         matches that specified in the NPWindow.
1364
1365         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1366         (NPP_SetWindow): Call through to the PluginTest.
1367
1368         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1369         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1370         the files as it saw fit.
1371
1372 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1373
1374         Reviewed by Andreas Kling.
1375
1376         [Qt] Remove support for Qt 4.5
1377         https://bugs.webkit.org/show_bug.cgi?id=46718
1378
1379         Remove the code for versions of Qt prior to 4.6.
1380
1381         * DumpRenderTree/qt/EventSenderQt.cpp:
1382         (EventSender::addTouchPoint):
1383         (EventSender::updateTouchPoint):
1384         (EventSender::setTouchModifier):
1385         (EventSender::touchStart):
1386         (EventSender::touchMove):
1387         (EventSender::touchEnd):
1388         (EventSender::clearTouchPoints):
1389         (EventSender::releaseTouchPoint):
1390         (EventSender::sendTouchEvent):
1391         * DumpRenderTree/qt/EventSenderQt.h:
1392         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1393         (TextInputController::setMarkedText):
1394         * QtTestBrowser/launcherwindow.cpp:
1395         (LauncherWindow::LauncherWindow):
1396         (LauncherWindow::initializeView):
1397         (LauncherWindow::createChrome):
1398         (LauncherWindow::sendTouchEvent):
1399         (LauncherWindow::eventFilter):
1400         (LauncherWindow::applyZoom):
1401         (LauncherWindow::setTouchMocking):
1402         * QtTestBrowser/launcherwindow.h:
1403         * QtTestBrowser/utils.cpp:
1404         (urlFromUserInput):
1405         * QtTestBrowser/webview.cpp:
1406         (WebViewGraphicsBased::animatedFlip):
1407         (WebViewGraphicsBased::animatedYFlip):
1408         * QtTestBrowser/webview.h:
1409         (WebViewGraphicsBased::setYRotation):
1410
1411 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1412
1413         Reviewed by Andreas Kling.
1414
1415         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1416         which should point to wcecompat installation. Needs wcecompat
1417         library from http://github.com/mauricek/wcecompat .
1418
1419         * DumpRenderTree/qt/DumpRenderTree.pro:
1420         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1421         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1422
1423 2010-09-28  Daniel Bates  <dbates@rim.com>
1424
1425         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1426         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1427
1428         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1429         In particular, this change caused Sheriffbot to raise an exception when
1430         trying to parse the bug id on a bug page. We need to look into this
1431         some more.
1432
1433         * Scripts/webkitpy/common/net/bugzilla.py:
1434         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1435         * Scripts/webkitpy/tool/bot/sheriff.py:
1436         * Scripts/webkitpy/tool/commands/download.py:
1437         * Scripts/webkitpy/tool/commands/queues.py:
1438         * Scripts/webkitpy/tool/commands/upload.py:
1439         * Scripts/webkitpy/tool/steps/closebug.py:
1440         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1441         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1442         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1443
1444 2010-09-28  Adam Barth  <abarth@webkit.org>
1445
1446         Reviewed by Eric Seidel.
1447
1448         Move RegressionWindow further up the dependency chain
1449         https://bugs.webkit.org/show_bug.cgi?id=46698
1450
1451         Baby steps towards pushing this information into bug posts.
1452
1453         * Scripts/webkitpy/common/net/buildbot.py:
1454         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1455         * Scripts/webkitpy/common/net/regressionwindow.py:
1456         * Scripts/webkitpy/tool/commands/queries.py:
1457
1458 2010-09-27  Daniel Bates  <dbates@rim.com>
1459
1460         Reviewed by Adam Barth.
1461
1462         sheriffbot can't roll out security patches
1463         https://bugs.webkit.org/show_bug.cgi?id=39136
1464
1465         Make SheriffBot determine if it's authorized to view a bug
1466         whose change it wants to rollout before it tries to rollout
1467         the change.
1468
1469         Moreover, make both webkit-patch and Sheriffbot provide human-
1470         readable error messages when they are not authorized to view
1471         a bug and when a bug number is invalid.
1472
1473         Currently, Sheriffbot does not parse Bugzilla bugs for
1474         <bug error="...">, which indicates an error when retrieving
1475         a bug. In particular, error="NotPermitted" if a person (or bot)
1476         is not authorized to view a bug. For such error="NotPermitted" bugs,
1477         Sheriffbot raises an exception when parsing the bug report and
1478         this exception does not explicitly indicate Sheriffbot's lack
1479         of authorization. Instead, Sheriffbot should explicitly check
1480         for the presence <bug error="..."> before operating on a bug
1481         and error with a human-readable message if it's not permitted
1482         to view it.
1483
1484         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1485         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1486           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1487           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1488           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1489         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1490         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1491         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1492         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1493         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1494         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1495         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1496         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1497
1498 2010-09-27  Adam Barth  <abarth@webkit.org>
1499
1500         Reviewed by Eric Seidel.
1501
1502         Expose more more failure information from Buildbot to SheriffBot
1503         https://bugs.webkit.org/show_bug.cgi?id=46697
1504
1505         This patch moves the information about what tests failured closer to
1506         SheriffBot.  There are still a couple more patches to go before
1507         SheriffBot can post this information to bugs, but this is a step in
1508         that direction.  Yay for unit tests, which caught some bugs in earlier
1509         versions of this patch.
1510
1511         * Scripts/webkitpy/common/net/buildbot.py:
1512         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1513         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1514         * Scripts/webkitpy/tool/commands/queries.py:
1515
1516 2010-09-27  Eric Seidel  <eric@webkit.org>
1517
1518         Unreviewed.  Fixing 500 error seen in the status server.
1519
1520         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1521         This should have been obvious to me, I guess, but it was not what I was expecting.
1522
1523         * QueueStatusServer/model/activeworkitems.py:
1524
1525 2010-09-27  Adam Barth  <abarth@webkit.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         commit-queue should reject patches that fail to land
1530         https://bugs.webkit.org/show_bug.cgi?id=46694
1531
1532         This can happen, for example, if there's no reviewer.  Without this
1533         patch, we'll keep retrying the patch.
1534
1535         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1536         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1537
1538 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1539
1540         Rubber-stamped by Adele Peterson.
1541
1542         Add a harness for running the CSS 2.1 test suite.
1543
1544         This harness assumes that you've got a local a copy of the suite
1545         adjacent to the 'harness' directory.
1546
1547         The harness lets you go through the tests in chapter order,
1548         denoting pass/fail/skipped for each test.
1549
1550         It uses a client-side database to store the results of testing.
1551
1552         * CSSTestSuiteHarness/harness/harness.css: Added.
1553         * CSSTestSuiteHarness/harness/harness.html: Added.
1554         * CSSTestSuiteHarness/harness/harness.js: Added.
1555
1556 2010-09-27  Eric Seidel  <eric@webkit.org>
1557
1558         Reviewed by Adam Barth.
1559
1560         Patch locks should expire if a patch is marked for retry
1561         https://bugs.webkit.org/show_bug.cgi?id=46682
1562
1563         This was part Adam's original CommitQueueTask design,
1564         but support for it was missing from the server.
1565         I added the support, but triggering lock-release based on this
1566         special "retry" status feels a bit strange so I added a FIXME.
1567
1568         I also changed the text in queuestatus.html to say "Lock Acquired"
1569         since "Last Activity" isn't really true.  We only update the lock
1570         date when the patch is started, not on every status update.
1571
1572         I also noticed an exception in next-patch, which I fixed by re-writing
1573         the unzip logic in activeworkitems.py again.
1574
1575         * QueueStatusServer/handlers/updatestatus.py:
1576         * QueueStatusServer/model/activeworkitems.py:
1577         * QueueStatusServer/templates/queuestatus.html:
1578
1579 2010-09-27  Tony Chang  <tony@chromium.org>
1580
1581         Reviewed by David Levin.
1582
1583         [chromium] fix a warning when compiling DRT on 32-bit linux
1584         https://bugs.webkit.org/show_bug.cgi?id=46641
1585
1586         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1587         (DRTPrinter::handleImage):
1588
1589 2010-09-27  Eric Seidel  <eric@webkit.org>
1590
1591         Reviewed by Adam Barth.
1592
1593         queue-status should report when the patch was last locked to a queue
1594         https://bugs.webkit.org/show_bug.cgi?id=46674
1595
1596         This isn't necessarily the best way to expose this information
1597         but having this accessible via the web interface is very
1598         useful until we come up with a nicer way to display this.
1599
1600         I also cleaned up the code in activeworkitems.py a little
1601         to use list comprehensions and to have the code work with
1602         pairs instead of two lists at once.  Eventually I think those
1603         item/time pairs need to be their own little helper class.
1604
1605         * QueueStatusServer/handlers/queuestatus.py:
1606         * QueueStatusServer/model/activeworkitems.py:
1607         * QueueStatusServer/templates/queuestatus.html:
1608
1609 2010-09-27  Tony Chang  <tony@chromium.org>
1610
1611         Reviewed by David Levin.
1612
1613         [chromium] fix detection of missing fonts on DRT
1614         https://bugs.webkit.org/show_bug.cgi?id=46651
1615
1616         * DumpRenderTree/chromium/TestShellGtk.cpp:
1617         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1618
1619 2010-09-27  Tony Chang  <tony@chromium.org>
1620
1621         Reviewed by Dimitri Glazkov.
1622
1623         add webkit unit tests to the chromium testers
1624         https://bugs.webkit.org/show_bug.cgi?id=46669
1625
1626         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1627         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1628
1629 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1630
1631         Unreviewed.
1632
1633         Adding myself to the committers list.
1634
1635         * Scripts/webkitpy/common/config/committers.py:
1636
1637 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1638
1639         Reviewed by Eric Seidel.
1640
1641         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1642         https://bugs.webkit.org/show_bug.cgi?id=46634
1643
1644         Use OutputCapture to prevent console spam (and also check for expected
1645         output).
1646
1647         * Scripts/webkitpy/common/system/user_unittest.py:
1648
1649 2010-09-27  Eric Seidel  <eric@webkit.org>
1650
1651         Reviewed by James Robinson.
1652
1653         start-commit-queue should abort any rebases in progress
1654         https://bugs.webkit.org/show_bug.cgi?id=46640
1655
1656         webkit-patch commit-queue would do this itself, but this just
1657         helps ensure that the commit-queue script is properly updated
1658         before we run it (in the case where a previous rebase is in
1659         progress the git svn rebase would not work before we run the
1660         commit-queue).
1661
1662         * EWSTools/start-commit-queue.sh:
1663
1664 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1665
1666         Reviewed by Gustavo Noronha Silva.
1667
1668         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1669         https://bugs.webkit.org/show_bug.cgi?id=46038
1670
1671         Switch to Liberation fonts for GTK+ layout tests. This will make our
1672         test results metric-compatible with many Windows/Chromium results. It
1673         also simplifies the fonts.conf that we load and prepares the way for
1674         fixing many font bugs.
1675
1676         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1677         (initializeFonts): Initialize a known list of fonts instead of loading
1678         every font in the WEBKIT_TESTFONTS directory.
1679         * DumpRenderTree/gtk/fonts.conf: Removed.
1680         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1681         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1682         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1683         we can load both fonts.conf and AHEM____.TTF from this location.
1684         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1685         it is no longer used.
1686
1687 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1688
1689         Reviewed by Ojan Vafai.
1690
1691         new-run-webkit-httpd fails if Perl is not installed
1692         https://bugs.webkit.org/show_bug.cgi?id=46602
1693
1694         Make Port._read_configuration catch all exceptions, since trying to run
1695         perl (because of _webkit_build_directory) when it's not installed throws
1696         a WindowsError or OSError, not an IOError (this became an issue after
1697         r68268, since ChromiumPort ends up calling Port.default_configuration in
1698         its constructor, which means that we're ending up on this codepath in
1699         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1700         new-run-webkit-httpd).
1701
1702         * Scripts/webkitpy/layout_tests/port/base.py:
1703         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1704
1705 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1706
1707         Reviewed by Antonio Gomes.
1708
1709         [EFL] Add setting API to set a local storage database path.
1710         https://bugs.webkit.org/show_bug.cgi?id=45446
1711
1712         Add a setting API to set local storage database path.
1713
1714         * EWebLauncher/main.c:
1715         (on_key_down):
1716         (browserCreate):
1717         (main):
1718
1719 2010-09-26  Sam Weinig  <sam@webkit.org>
1720
1721         Reviewed by Anders Carlsson.
1722
1723         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1724         https://bugs.webkit.org/show_bug.cgi?id=46587
1725
1726         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1727
1728 2010-09-26  Antonio Gomes  <agomes@rim.com>
1729
1730         Reviewed by Kenneth Rohde Christiansen.
1731
1732         DRT/Mac nodesFromRect support
1733
1734         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1735         https://bugs.webkit.org/show_bug.cgi?id=46580
1736
1737         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1738         adding stubs for GTK+ and Windows.
1739
1740         * DumpRenderTree/LayoutTestController.cpp:
1741         (nodesFromRectCallback):
1742         (LayoutTestController::staticFunctions):
1743         * DumpRenderTree/LayoutTestController.h:
1744         (LayoutTestController::LayoutTestController::nodesFromRect):
1745         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1746         (LayoutTestController::nodesFromRect):
1747
1748 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1749
1750         Reviewed by Adam Barth.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=46555
1753         Fix typo in prepare-ChangeLog's help output.
1754
1755         * Scripts/prepare-ChangeLog:
1756
1757 2010-09-24  Sam Weinig  <sam@webkit.org>
1758
1759         Reviewed by Darin Adler.
1760
1761         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1762         <rdar://problem/8359279>
1763         https://bugs.webkit.org/show_bug.cgi?id=46546
1764
1765         * MiniBrowser/mac/BrowserWindowController.m:
1766         (mouseDidMoveOverElement):
1767         (-[BrowserWindowController awakeFromNib]):
1768         * MiniBrowser/win/BrowserView.cpp:
1769         (mouseDidMoveOverElement):
1770         (BrowserView::create):
1771         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1772         (WTR::InjectedBundlePage::InjectedBundlePage):
1773         * WebKitTestRunner/TestController.cpp:
1774         (WTR::createOtherPage):
1775         (WTR::TestController::initialize):
1776
1777 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1778
1779         Reviewed by Adam Barth.
1780
1781         Allow rebaselines for webkit-patch rebaseline to be chosen
1782         https://bugs.webkit.org/show_bug.cgi?id=46407
1783
1784         Instead of always rebaselining all failing tests, allow a subset to be
1785         chosen.
1786
1787         * Scripts/webkitpy/common/system/user.py:
1788         * Scripts/webkitpy/tool/commands/rebaseline.py:
1789
1790 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1791
1792         Reviewed by Tony Chang.
1793
1794         [chromium] Implement TextInputController::firstRectForCharacterRange
1795         https://bugs.webkit.org/show_bug.cgi?id=38100
1796
1797         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1798         No new tests are added since we need to implement the same feature in chromium side
1799         in order to enable any tests that uses this function.
1800
1801         * DumpRenderTree/chromium/TextInputController.cpp:
1802         (TextInputController::firstRectForCharacterRange): Added.
1803
1804 2010-09-24  Adam Barth  <abarth@webkit.org>
1805
1806         Reviewed by Eric Seidel.
1807
1808         commit-queue reports land failures as "PASS"
1809         https://bugs.webkit.org/show_bug.cgi?id=46530
1810
1811         We were ignoring the return value of land instead of passing it back to
1812         CommitQueue.  Of course, this was the one case I forgot to test!
1813
1814         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1815         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1816
1817 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
1818
1819         Reviewed by Eric Seidel.
1820
1821         new-run-webkit-tests prints out nothing when build-dumprendertree fails
1822         https://bugs.webkit.org/show_bug.cgi?id=37563
1823
1824         Print error message when build-dumprendertree fails.
1825
1826         * Scripts/webkitpy/layout_tests/port/webkit.py:
1827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1828
1829 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1830
1831         Reviewed by Tony Chang.
1832
1833         NRWT doesn't respect config set with set-webkit-configuration
1834         https://bugs.webkit.org/show_bug.cgi?id=46278
1835
1836         Use Port.default_configuration() instead of hardcoding Release in
1837         ChromiumPort configuration initialization, so that we still inherit the
1838         configuration set by set-webkit-configuration.
1839
1840         * Scripts/webkitpy/layout_tests/port/chromium.py:
1841         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1842
1843 2010-09-24  Chang Shu  <chang.shu@nokia.com>
1844
1845         Reviewed by Csaba Osztrogonác.
1846
1847         [Qt] Fix the code to check file existence.
1848         https://bugs.webkit.org/show_bug.cgi?id=46465
1849
1850         * QtTestBrowser/main.cpp:
1851         (main):
1852
1853 2010-09-23  Tony Chang  <tony@chromium.org>
1854
1855         Unreviewed, rolling out r68232.
1856         http://trac.webkit.org/changeset/68232
1857
1858         Broken NRWT on the canary bots.
1859
1860         * Scripts/webkitpy/layout_tests/port/chromium.py:
1861
1862 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
1863
1864         Unreviewed, build fix.
1865
1866         r68008 broke new-run-webkit-tests in that the chromium ports no
1867         longer respect set-webkit-configuration. The correct fix for this
1868         is being pursued in bug 46278 (along with a bunch of unit tests),
1869         but in the meantime I'm reverting the particular lines that broke
1870         things. This was tested by hand.
1871
1872         * Scripts/webkitpy/layout_tests/port/chromium.py:
1873
1874 2010-09-23  Sam Weinig  <sam@webkit.org>
1875
1876         Reviewed by Anders Carlsson.
1877
1878         WebKit2 API: Need way to know when a frame is removed from the hierarchy
1879         <rdar://problem/8414062>
1880         https://bugs.webkit.org/show_bug.cgi?id=46432
1881
1882         * MiniBrowser/mac/BrowserWindowController.m:
1883         (didRemoveFrameFromHierarchy):
1884         (-[BrowserWindowController awakeFromNib]):
1885         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1886         (WTR::InjectedBundlePage::InjectedBundlePage):
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::initialize):
1889
1890 2010-09-23  Tony Chang  <tony@chromium.org>
1891
1892         Reviewed by Dimitri Glazkov.
1893
1894         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
1895         https://bugs.webkit.org/show_bug.cgi?id=46426
1896
1897         * DumpRenderTree/chromium/LayoutTestController.cpp:
1898         (LayoutTestController::LayoutTestController):
1899         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1900         * DumpRenderTree/chromium/LayoutTestController.h:
1901
1902 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1903
1904         Reviewed by Nate Chapin.
1905
1906         [GTK] r68199 introduced two test failures
1907         https://bugs.webkit.org/show_bug.cgi?id=46424
1908
1909         Fix a regression handling preference overrides that are attached to boolean properties.
1910
1911         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1912         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
1913         so we must check for that when converting a string to a boolean.
1914
1915 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
1916
1917         Reviewed by David Levin.
1918
1919         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
1920         https://bugs.webkit.org/show_bug.cgi?id=46406
1921
1922         This breaks when the method is called with specified size of data (image data), and the
1923         buffer hasn't yet reached this size.
1924
1925         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
1926           index larger than 0.
1927
1928 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1929
1930         Reviewed by Nate Chapin.
1931
1932         [GTK] Some tests from r68174 fail on the GTK+ bots
1933         https://bugs.webkit.org/show_bug.cgi?id=46396
1934
1935         Simplify LayoutTestController::overridePreference to make it easier for
1936         people unfamiliar with the code to keep the list of preferences up to date.
1937         Add the conversion for enable-hyperlink-auditing.
1938
1939         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1940         (LayoutTestController::overridePreference): Use a simple if-else block to determine
1941         out the property name for overrridePreference. Also simplify the logic for setting
1942         string properties. Add the conversion for enable-hyperlink-auditing.
1943
1944 2010-09-23  Tony Chang  <tony@chromium.org>
1945
1946         Reviewed by David Levin.
1947
1948         [chromium] add caretBrowsingEnabled to WebSettings and DRT
1949         https://bugs.webkit.org/show_bug.cgi?id=46388
1950
1951         * DumpRenderTree/chromium/LayoutTestController.cpp:
1952         (LayoutTestController::overridePreference):
1953         * DumpRenderTree/chromium/WebPreferences.cpp:
1954         (WebPreferences::reset):
1955         (WebPreferences::applyTo):
1956         * DumpRenderTree/chromium/WebPreferences.h:
1957
1958 2010-09-23  Nate Chapin  <japhet@chromium.org>
1959
1960         Reviewed by Darin Fisher.
1961
1962         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
1963         https://bugs.webkit.org/show_bug.cgi?id=30458
1964
1965         * DumpRenderTree/chromium/LayoutTestController.cpp:
1966         (LayoutTestController::overridePreference):
1967         * DumpRenderTree/chromium/WebPreferences.cpp:
1968         (WebPreferences::reset):
1969         (WebPreferences::applyTo):
1970         * DumpRenderTree/chromium/WebPreferences.h:
1971         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1972         (resetDefaultsToConsistentValues):
1973         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1974         (LayoutTestController::overridePreference):
1975
1976 2010-09-21  Stephen White  <senorblanco@chromium.org>
1977
1978         Reviewed by David Levin.
1979
1980         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
1981         https://bugs.webkit.org/show_bug.cgi?id=46208
1982
1983         This flag allows the layout tests to be run with or without accelerated
1984         2D canvas rendering.
1985
1986         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1987         (main):
1988         Declare the new flag string, and check for it on startup.
1989         * DumpRenderTree/chromium/TestShell.cpp:
1990         (TestShell::TestShell):
1991         Add a boolean for the new flag, in order to preserve its value over
1992         preferences reset.
1993         (TestShell::resetWebSettings):
1994         Set the new flag to the stored value on reset.
1995         * DumpRenderTree/chromium/TestShell.h:
1996         (TestShell::setAccelerated2dCanvasEnabled):
1997         Add an accessor for the new flag.
1998         * DumpRenderTree/chromium/WebPreferences.cpp:
1999         (WebPreferences::reset):
2000         Initialize the new flag to false.
2001         (WebPreferences::applyTo):
2002         Copy the flag's value to the WebSettings.
2003         * DumpRenderTree/chromium/WebPreferences.h:
2004         Add the new flag.
2005
2006 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2007
2008         Reviewed by Simon Hausmann.
2009
2010         [Qt] Refactor QtWebKitPlatformPlugin interface
2011
2012         Make it easier to keep source-compability for the
2013         QtWebKitPlatformPlugin interface, and run qmake
2014         on the example (but not build) for convenience.
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=46345
2017
2018         * Scripts/webkitdirs.pm:
2019
2020 2010-09-23  Adam Barth  <abarth@webkit.org>
2021
2022         Reviewed by Eric Seidel.
2023
2024         Tweak some status messages that Eric thought were confusing
2025         https://bugs.webkit.org/show_bug.cgi?id=46342
2026
2027         * Scripts/webkitpy/tool/commands/queues.py:
2028         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2029
2030 2010-09-22  Adam Barth  <abarth@webkit.org>
2031
2032         Reviewed by Eric Seidel.
2033
2034         Fix comm-queue typo
2035         https://bugs.webkit.org/show_bug.cgi?id=46339
2036
2037         We were missing a "self".  The real problem is that we didn't have an
2038         integration test for the failure case.
2039
2040         * Scripts/webkitpy/tool/commands/queues.py:
2041         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2042
2043 2010-09-22  Adam Barth  <abarth@webkit.org>
2044
2045         Reviewed by Eric Seidel.
2046
2047         commit-queue should log more detailed messages to the QueueStatusServer
2048         https://bugs.webkit.org/show_bug.cgi?id=46333
2049
2050         When I created CommitQueueTask, I removed most of the previous logging.
2051         This patch adds back more detailed logging so folks can see their patch
2052         progress through the queue.
2053
2054         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2055         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2056         * Scripts/webkitpy/tool/commands/queues.py:
2057         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2058
2059 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2060
2061         Reviewed by Darin Fisher.
2062
2063         [Chromium] User style layout tests don't pass on Chromium
2064         https://bugs.webkit.org/show_bug.cgi?id=46069
2065
2066         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2067         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2068         behavior from other ports.
2069
2070         * DumpRenderTree/chromium/LayoutTestController.cpp:
2071         (LayoutTestController::addUserStyleSheet):
2072
2073 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2074
2075         Reviewed by Martin Robinson.
2076
2077         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2078         https://bugs.webkit.org/show_bug.cgi?id=46303.
2079
2080         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2081         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2082         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2083         property sheet.
2084         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2085         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2086         appropriate property sheet for the build types.
2087         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2088         configuration to use appropriate property sheet for CoreFoundation
2089         and CFLite-style builds.
2090
2091 2010-09-22  Adam Barth  <abarth@webkit.org>
2092
2093         Reviewed by Eric Seidel.
2094
2095         Optimize commit-queue performance for green trees
2096         https://bugs.webkit.org/show_bug.cgi?id=46254
2097
2098         This patch redesigns the controller logic for the commit-queue.  In the
2099         new design, the controller exercises much finer-grained control over
2100         the landing process.  In particular:
2101
2102         - Patches that fail to apply now get rejected almost immediately.
2103         - Patches that fail to build get rejects after two builds (instead of
2104           three builds and one test run).
2105         - Patches that run into a flaky test now get accepted after one build
2106           and two test runs instead of three full build-and-test runs.
2107
2108         The main cost of these optimizations is that we don't find out the tree
2109         has a failing test until the very end of the process, but if the tree
2110         has a busted test, there's not much we can do anyway.  We might as well
2111         burn commit-queue resources spinning optimisticly.
2112
2113         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2114         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2115         * Scripts/webkitpy/tool/commands/queues.py:
2116
2117 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2118
2119         Reviewed by Martin Robinson.
2120
2121         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2122         https://bugs.webkit.org/show_bug.cgi?id=46303.
2123
2124         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2125         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2126         WinCairo build.
2127         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2128         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2129         build targets that use the new InjectedBundleCFLite.vsprops file.
2130
2131 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2132
2133         Unreviewed, build fix.
2134
2135         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2136         r67974. Really need better unit tests for this tool :(
2137
2138         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2139
2140 2010-09-22  Adam Roben  <aroben@apple.com>
2141
2142         Unbreak test-webkitpy
2143
2144         * Scripts/webkitpy/test/main.py:
2145         (Tester.run_tests): Add a line that mysteriously got deleted.
2146
2147 2010-09-22  Adam Roben  <aroben@apple.com>
2148
2149         Make test-webkitpy test WebKit2's scripts
2150
2151         These scripts can't be in WebKitTools due to limitations of Apple's
2152         build process. But that doesn't mean we can't test them!
2153
2154         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2155         WebKit2/Scripts
2156
2157         Reviewed by Adam Barth.
2158
2159         * Scripts/test-webkitpy:
2160         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2161         Now takes an external_package_paths parameter and cleans both webkitpy
2162         and any external packages.
2163         (init): Added an external_package_paths parameter which we pass along
2164         to _clean_packages_with_test.
2165         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2166         and pass it along to init and Tester.run_tests.
2167
2168         * Scripts/webkitpy/test/main.py:
2169         (Tester.run_tests): Added an optional external_package_paths
2170         parameter. We modify sys.path so that the external packages can be
2171         imported, and search for unittest files inside all external packages
2172         in addition to inside webkitpy.
2173
2174 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2175
2176         Reviewed by Tony Chang.
2177
2178         new-run-webkit-tests: r68063 broke linux python tests
2179
2180         Add a missing "from __future__ import with_statement" to this
2181         new file; the perils of testing only on the Mac and by review :(
2182
2183         https://bugs.webkit.org/show_bug.cgi?id=46293
2184
2185         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2186
2187 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2188
2189         Reviewed by Tony Chang.
2190
2191         Add a 'chromium-gpu' set of ports that will test the accelerated
2192         GPU paths. This patch adds:
2193
2194         - support for the '--accelerated-compositing' and
2195           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2196           'no-' flags)
2197         - adds a new set of Ports that will look under
2198           platform/chromium-gpu-$OS/ for baselines before looking in the
2199           regular chromium search path
2200         - adds a new test_expectations.txt file in platform/chromium-gpu
2201           that skips all but the tests we actually want to run with
2202           acceleration.
2203
2204         This patch will allow us to run both with and without acceleration
2205         and to change the defaults for both the regular and -gpu options
2206         as the code evolves.
2207
2208         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2209         each test bot.
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=46225
2212
2213         * Scripts/webkitpy/layout_tests/port/chromium.py:
2214         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2215         * Scripts/webkitpy/layout_tests/port/factory.py:
2216         * Scripts/webkitpy/layout_tests/port/webkit.py:
2217
2218 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2219
2220         Reviewed by Kenneth Rohde Christiansen.
2221
2222         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2223         https://bugs.webkit.org/show_bug.cgi?id=43988
2224
2225         Runs a web debug server on port specified by QtTestBrowser
2226         argument -remote-inspector-port. Property
2227         _q_webInspectorServerPort of the QWebPage instance will be set
2228         according to the argument. All pages with that property set will
2229         be remotely inspectable.
2230
2231         URL for remote inspection of first QWebPage is
2232             http://localhost:9222/webkit/inspector/inspector.html?page=1
2233         where 1 is the number of the QWebPage instance.
2234
2235         The base URL yields an index page with links to the individual inspectors:
2236             http://localhost:9222/
2237
2238         * QtTestBrowser/launcherwindow.cpp:
2239         (LauncherWindow::init):
2240         * QtTestBrowser/launcherwindow.h:
2241         * QtTestBrowser/main.cpp:
2242         (LauncherApplication::handleUserOptions):
2243
2244 2010-09-22  Adam Roben  <aroben@apple.com>
2245
2246         Fix webkit-patch failure-reason now that build.webkit.org has been
2247         updated
2248
2249         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2250         every time
2251
2252         Reviewed by Eric Seidel.
2253
2254         * Scripts/webkitpy/common/net/buildbot.py:
2255         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2256         looking for an element that contains text, then returns it.
2257         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2258         text out of the cells. This way it doesn't matter whether the cells
2259         have <b> children (as for cells in directory rows) or not (as for
2260         cells in file rows)
2261         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2262         the "directory" or "file" class, rather than rows with any class,
2263         since header rows now have a class attribute.
2264
2265         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2266         (BuildBotTest._example_directory_listing): Updated to more closely
2267         match the markup that build.webkit.org is producing now.
2268
2269 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2270
2271         Unreviewed, build fix.
2272
2273         new-run-webkit-tests: fix bug introduced in r68008 where if you
2274         specify --chromium and no --platform, and you're running on
2275         windows, you use the 'chromium-win' port by default instead of the
2276         version-specific port. This breaks the buildbots.
2277
2278         It will be good for this refactoring to settle down so I can
2279         rewrite the logic for default ports and the unit tests to be
2280         clearer (and the testing more comprehensive).
2281
2282         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2283
2284 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2285
2286         Reviewed by Adam Barth.
2287
2288         Modify the Port interface to take only a series of keyword arguments
2289         in the constructor, and modify Port/factory.get() to accomodate that,
2290         and to accept user=XXX as an argument so we can pass
2291         webkitpy.common.system.user.User objects in.
2292
2293         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2294         to use the common routine in webkitpy.common.system.user.open_url()
2295         to display HTML files.
2296
2297         There was a routine in the Port interface to do the same thing,
2298         but I see no need for a port-specific hook for this, since it is
2299         something that will always be executed by the host environment
2300         and displaying web pages has nothing to do with running layout tests.
2301
2302         Note that new-run-webkit-tests used to use test_shell to display
2303         the page; this is potentially useful so that you can actually click
2304         from a result to the broken page; however, since DumpRenderTree
2305         doesn't support this functionality, it will be going away eventually.
2306
2307         https://bugs.webkit.org/show_bug.cgi?id=46128
2308
2309         * Scripts/webkitpy/layout_tests/port/base.py:
2310         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2311         * Scripts/webkitpy/layout_tests/port/chromium.py:
2312         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2313         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2314         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2315         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2316         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2317         * Scripts/webkitpy/layout_tests/port/factory.py:
2318         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2319         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2320         * Scripts/webkitpy/layout_tests/port/gtk.py:
2321         * Scripts/webkitpy/layout_tests/port/mac.py:
2322         * Scripts/webkitpy/layout_tests/port/qt.py:
2323         * Scripts/webkitpy/layout_tests/port/test.py:
2324         * Scripts/webkitpy/layout_tests/port/webkit.py:
2325         * Scripts/webkitpy/layout_tests/port/win.py:
2326         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2328         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2329
2330 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2331
2332         Reviewed by Kenneth Rohde Christiansen.
2333
2334         [EFL] Get fresh theme when running EWebLauncher
2335         https://bugs.webkit.org/show_bug.cgi?id=46210
2336
2337         If user tried to run EWebLauncher outside of the build tree, it would
2338         not find the theme and fallback to the installed one. However, since
2339         EWebLauncher is not installed, we always want to take the theme from
2340         the just compiled source code. If user had never installed WebKit's
2341         EFL port it could even receive a segv since no theme would be found.
2342
2343         Now EWebLauncher does not fallback to the installed theme and CMake
2344         gives as DATA_DIR the directory of the theme it has just built.
2345
2346         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2347         EWebLauncher.
2348         * EWebLauncher/main.c: Use only the theme from build director. Do not
2349         fallback to others as this could hide real bugs.
2350         (quit):
2351         (browserCreate):
2352         (findThemePath):
2353         (main):
2354
2355 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2356
2357         Unreviewed, build fix.
2358
2359         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2360         it just confuses it.
2361
2362         https://bugs.webkit.org/show_bug.cgi?id=46230
2363
2364         * Scripts/webkitpy/layout_tests/port/webkit.py:
2365
2366 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2367
2368         Reviewed by Stephanie Lewis.
2369
2370         Make a new buildbot for Leopard Debug Test
2371
2372         * BuildSlaveSupport/build.webkit.org-config/config.json:
2373
2374 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2375
2376         Unreviewed, build fix.
2377
2378         Fix breakage of Chromium Mac DRT port caused by r67905.
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=46230
2381
2382         * Scripts/webkitpy/layout_tests/port/webkit.py:
2383
2384 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2385
2386         Unreviewed, build fix.
2387
2388         Add missing import of 'tempfile'.
2389
2390         * Scripts/webkitpy/layout_tests/port/chromium.py:
2391
2392 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2393
2394         Reviewed by Ojan Vafai.
2395
2396         new-run-webkit-tests: pull the list of tests from the Port, and
2397            make it possible to run with no actual test files in the filesystem.
2398
2399         This set of changes allows us to delete the special
2400         webkitpy/layout_tests/data directory and test the generic code without
2401         touching the filesystem (except to write results). This speeds up
2402         test-webkitpy substantially.
2403
2404         This also cleans up and removes several code paths in the generic
2405         code and fixes some minor bugs, notably in the test_expectations
2406         parsing, which was previously fragile if the tests weren't present.
2407
2408         We also change the way we diff image results to be able to do so
2409         in memory, without relying on files. This slows down chromium
2410         test_shell, which always writes images to files, but should speed
2411         up DRT and ImageDiff-based implementations slightly.
2412
2413         Note that pulling the list of tests to run from the Port will allow
2414         ports to specify what tests to run as an inclusive list; previously
2415         you could only do this as an exclusive list by using a
2416         test_expectations file or Skipped files; nothing actually uses this
2417         feature yet and it's unclear if it should be used.
2418
2419         Note that there are no functional changes -- apart from now
2420         always printing out the location of the checksum file when we are
2421         tracing test runs -- and the total number of lines of non-test code
2422         actually drops by two.
2423
2424         There is some more cleanup that can be done in the Port/Driver
2425         interface and in some handling of filenames, but I'll save that
2426         for another change.
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=45801
2429
2430         * Scripts/webkitpy/layout_tests/data/*: Removed.
2431             - no longer need special mock layout_tests_directory in the
2432               repository.
2433         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2434             - add code to display missing text files, checksums when tracing
2435             - update to not look at the filesystem directly.
2436         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2437             - add more unit tests
2438         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2439             - remove tests_are_present flag
2440             - update with changes in Port interface - no longer access
2441               the filesystem directly, although we still use os.path for
2442               filename manipulation.
2443         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2444             - add more unit tests
2445         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2446             - renamed to port/test_files.py
2447         * Scripts/webkitpy/layout_tests/port/base.py:
2448             - change diff_image() to expect actual image data, not filenames
2449             - add expected_checksum(), expected_image(), expected_text() to
2450               return the content of the files so that we don't need a filesystem
2451             - add path_exists(), path_isdir() for filesystem-like access.
2452             - add test_dirs() to keep clobber-test-results from needing to
2453               actually look at a real layout tests dir
2454             - add tests() to return the list of tests to run on the port
2455               (calls port/test_files to do the work).
2456             - add update_baseline() to be able to save new baselines
2457             - add uri_to_test_name() from port/dryrun.py so we can easily check
2458               filename_to_uri()
2459         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2460             - add more unit tests
2461         * Scripts/webkitpy/layout_tests/port/chromium.py:
2462             - change diff_image() to accept image content, not filenames.
2463               This will be slower for test_shell/image_diff, but faster
2464               for DRT/ImageDiff.
2465         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2466             - add more unit tests
2467         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2468             - simplify greatly
2469         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2470             - add more unit tests
2471         * Scripts/webkitpy/layout_tests/port/test.py:
2472             - massive rewrite to use in-script list of tests and expectations
2473         * Scripts/webkitpy/layout_tests/port/test_files.py:
2474             - rename from layout_package/test_files.
2475         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2476             - add unit tests
2477         * Scripts/webkitpy/layout_tests/port/webkit.py:
2478             - update diff_image() to take image contents, not files. Should
2479               make things slightly faster.
2480         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2481             - update with changes to diff_image()
2482         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2483             - update with changes to diff_image()
2484         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2485             - remove tests_are_present from test_expectations
2486             - pull the list of tests from port.tests() instead
2487               of calling test_files.py directly.
2488         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2489             - update unit tests
2490         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2491             - update with changes to
2492         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2493             - update with change in Port interface
2494         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2495             - update with change in Port interface
2496         * Scripts/webkitpy/style/checkers/test_expectations.py:
2497             - remove the tests_are_present flag
2498
2499 2010-09-21  Anders Carlsson  <andersca@apple.com>
2500
2501         Disable logging.
2502
2503         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2504
2505 2010-09-21  Tony Chang  <tony@chromium.org>
2506
2507         Reviewed by Kent Tamura.
2508
2509         add a script for running webkit_unit_tests
2510         https://bugs.webkit.org/show_bug.cgi?id=46014
2511
2512         * Scripts/run-chromium-webkit-unit-tests: Added.
2513
2514 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2515
2516         Reviewed by Martin Robinson.
2517
2518         Fix linking problems on Windows.
2519         https://bugs.webkit.org/show_bug.cgi?id=45844
2520
2521         * GNUmakefile.am: link the executables with winmm.dll
2522
2523 2010-09-21  Adam Barth  <abarth@webkit.org>
2524
2525         Reviewed by Eric Seidel.
2526
2527         feeder-queue svn updates more often than needed
2528         https://bugs.webkit.org/show_bug.cgi?id=46171
2529
2530         We don't need to poll SVN every time we feed the feeders.  Rather, we
2531         can count on the wrapper shell script to auto-update the queue.
2532
2533         * Scripts/webkitpy/tool/commands/queues.py:
2534         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2535
2536 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2537
2538         Reviewed by Andreas Kling.
2539
2540         [Qt] Add robot loader timeout and extra time options.
2541         https://bugs.webkit.org/show_bug.cgi?id=46172
2542
2543         [-robot-timeout <s>]: Load the next page after s seconds if the current
2544         page didn't finish loading.
2545         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2546         loading before loading the next one. This should allow some time for the
2547         page's JavaScript to execute.
2548
2549         * QtTestBrowser/launcherwindow.cpp:
2550         (LauncherWindow::applyPrefs):
2551         * QtTestBrowser/main.cpp:
2552         (LauncherApplication::robotTimeout):
2553         (LauncherApplication::robotExtraTime):
2554         (LauncherApplication::LauncherApplication):
2555         (LauncherApplication::handleUserOptions):
2556         (main):
2557         * QtTestBrowser/urlloader.cpp:
2558         (UrlLoader::UrlLoader):
2559         (UrlLoader::loadNext):
2560         (UrlLoader::loadUrlList):
2561         * QtTestBrowser/urlloader.h:
2562
2563 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2564
2565         Unreviewed.
2566
2567         Adding myself to the committers list.
2568
2569         * Scripts/webkitpy/common/config/committers.py:
2570
2571 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2572
2573         Reviewed by Eric Carlson.
2574
2575         [GTK] enhanced context menu for media elements
2576         https://bugs.webkit.org/show_bug.cgi?id=45021
2577
2578         EventSender::contextClick() now returns an array of js
2579         objects. Each object has a title property and a click() method.
2580
2581         * DumpRenderTree/gtk/EventSender.cpp:
2582         (getMenuItemTitleCallback):
2583         (setMenuItemTitleCallback):
2584         (menuItemClickCallback):
2585         (getMenuItemClass):
2586         (contextClickCallback):
2587
2588 2010-09-20  Hayato Ito  <hayato@chromium.org>
2589
2590         Unreviewed.
2591         Adding myself to the committers list.
2592
2593         * Scripts/webkitpy/common/config/committers.py:
2594
2595 2010-09-20  Adam Barth  <abarth@webkit.org>
2596
2597         Reviewed by Eric Seidel.
2598
2599         The tool member variable should be called _tool
2600         https://bugs.webkit.org/show_bug.cgi?id=46160
2601
2602         Created by find-and-replace.
2603
2604         * Scripts/webkitpy/tool/commands/download.py:
2605         * Scripts/webkitpy/tool/commands/openbugs.py:
2606         * Scripts/webkitpy/tool/commands/queries.py:
2607         * Scripts/webkitpy/tool/commands/queues.py:
2608         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2609         * Scripts/webkitpy/tool/commands/rebaseline.py:
2610         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2611         * Scripts/webkitpy/tool/commands/upload.py:
2612         * Scripts/webkitpy/tool/multicommandtool.py:
2613
2614 2010-09-20  Adam Barth  <abarth@webkit.org>
2615
2616         I ran the tests before landing but ignored the fact that they failed.  :(
2617
2618         * Scripts/webkitpy/tool/commands/queues.py:
2619
2620 2010-09-20  Adam Barth  <abarth@webkit.org>
2621
2622         Reviewed by Eric Seidel.
2623
2624         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2625         https://bugs.webkit.org/show_bug.cgi?id=46141
2626
2627         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2628         list of work items on the status server.  The individual commit-cluster
2629         nodes then grab the patches from the server and process them.
2630
2631         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2632         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2633         * Scripts/webkitpy/tool/commands/queues.py:
2634         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2635         * Scripts/webkitpy/tool/commands/queuestest.py:
2636
2637 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2638
2639         Reviewed by Darin Adler.
2640
2641         build-webkit: Add support for CMake build system
2642         https://bugs.webkit.org/show_bug.cgi?id=44979
2643
2644         * Scripts/build-webkit: Add "--efl" command-line option to build the
2645         EFL port of WebKit.
2646         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2647         buildEflCMakeProject() subroutines.
2648
2649 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2650
2651         Reviewed by Ojan Vafai.
2652
2653         new-run-webkit-tests: refactor command line args getting passed to DRT
2654
2655         This change cleans up some argument parsing between functions to get
2656         rid of some overlapping data structures. There should be no functional
2657         changes in this patch; it is pure refactoring in preparation for
2658         landing the Chrome GPU port and adding a generic way to pass
2659         args to DRT/TestShell.
2660
2661         https://bugs.webkit.org/show_bug.cgi?id=46135
2662
2663         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2664           - pass the options argument explicitly to the threads and drivers,
2665             also consolidate the passing of options to the driver.
2666           - pass options directly to process_output() to remove a couple
2667             parameters (minor cleanup).
2668         * Scripts/webkitpy/layout_tests/port/base.py:
2669           - pass the options argument to Port.create_driver().
2670         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2671           - update Port.create_driver() test
2672         * Scripts/webkitpy/layout_tests/port/chromium.py:
2673           - pass the options argument to Port.create_driver(), and clean up
2674             building of the cmd line for DRT.
2675         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2676           - pass the options argument to Port.create_driver()
2677         * Scripts/webkitpy/layout_tests/port/test.py:
2678           - pass the options argument to Port.create_driver()
2679         * Scripts/webkitpy/layout_tests/port/webkit.py:
2680           - pass the options argument to Port.create_driver(), and clean up
2681             building of the cmd line for DRT.
2682         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2683           - consolidate args in _get_dump_render_tree_args and rename to
2684             _get_test_args(); move all of the command-line args to the
2685             Port implementations.
2686
2687 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2688
2689         Revert change which was accidentally committed along with some expectation changes.
2690
2691         * Scripts/webkitpy/layout_tests/port/base.py:
2692
2693 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2694
2695         Reviewed by Adam Barth.
2696
2697         Add explicit --force-patch flag to webkitpy tools
2698         https://bugs.webkit.org/show_bug.cgi?id=46103
2699
2700         It wasn't obvious until I read the applypatch.py source code that
2701         --non-interfactive implies passing --force to patch. Add --force-patch
2702         as an alias to the flag, so that this behavior is more discoverable.
2703
2704         * Scripts/webkitpy/tool/steps/applypatch.py:
2705         * Scripts/webkitpy/tool/steps/options.py:
2706
2707 2010-09-20  Eric Seidel  <eric@webkit.org>
2708
2709         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2710
2711         commit-queue can't land patches
2712         https://bugs.webkit.org/show_bug.cgi?id=46138
2713
2714         Add a line of code I forgot in my last commit.
2715
2716         * Scripts/webkitpy/common/net/bugzilla.py:
2717         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2718
2719 2010-09-20  Adam Barth  <abarth@webkit.org>
2720
2721         Reviewed by Eric Seidel.
2722
2723         The commit-cluster bots still race to lock patch_ids
2724         https://bugs.webkit.org/show_bug.cgi?id=46130
2725
2726         It turns out we need to use a transaction object to make the
2727         read/modify/write lock operation atomic.  From reading the AppEngine
2728         documentation, I think this patch should do what we want.  It's hard to
2729         test locally because the test instance isn't distributed in the same
2730         way the production instance is.
2731
2732         * QueueStatusServer/handlers/nextpatch.py:
2733         * QueueStatusServer/model/activeworkitems.py: Added.
2734
2735 2010-09-20  Andy Estes  <aestes@apple.com>
2736
2737         Reviewed by Adam Barth.
2738
2739         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2740         https://bugs.webkit.org/show_bug.cgi?id=40961
2741
2742         Implement WebKitUsePreHTML5ParserQuirks preference.
2743
2744         * DumpRenderTree/mac/DumpRenderTree.mm:
2745         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2746         to false after a test finishes.
2747
2748 2010-09-20  Adam Roben  <aroben@apple.com>
2749
2750         Windows build fix
2751
2752         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2753         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2754         we'll pick up the most recent versions of the headers.
2755
2756 2010-09-20  Eric Seidel  <eric@webkit.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         commit-queue should check commit-queue+ again just before committing
2761         https://bugs.webkit.org/show_bug.cgi?id=32679
2762
2763         Added a _revalidate_patch check, right before landing.
2764
2765         Since _revalidate_patch passes the patch_id from the work item
2766         back to bugzilla, I had to fix all of the previous queue tests to
2767         use valid attachment ids (that's the majority of this change).
2768
2769         In order to validate that the bug was still open, I had to teach
2770         bugzilla.Bug about open/closed states.
2771
2772         * Scripts/webkitpy/common/net/bugzilla.py:
2773         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2774         * Scripts/webkitpy/tool/commands/queues.py:
2775         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2776         * Scripts/webkitpy/tool/commands/queuestest.py:
2777         * Scripts/webkitpy/tool/mocktool.py:
2778
2779 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2780
2781         Unreviewed.
2782
2783         Adding myself as a comitter.
2784
2785         * Scripts/webkitpy/common/config/committers.py:
2786
2787 2010-09-20  Adam Barth  <abarth@webkit.org>
2788
2789         Reviewed by Eric Seidel.
2790
2791         Two instances of commit-queue try to process the same patch
2792         https://bugs.webkit.org/show_bug.cgi?id=46113
2793
2794         This patch makes next-patch atomic so that the server won't vend the
2795         same patch twice in the same hour.
2796
2797         * QueueStatusServer/handlers/nextpatch.py:
2798
2799 2010-09-20  Adam Roben  <aroben@apple.com>
2800
2801         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2802
2803         We were previously trying to use a CFRunLoopTimer, but since Windows
2804         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
2805         Windows-style timer on Windows.
2806
2807         I also replaced all uses of "watchdog" with "watchdog timer".
2808
2809         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
2810         watchdog timer doesn't work on Windows
2811
2812         Reviewed by Anders Carlsson.
2813
2814         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2815         (WTR::InjectedBundlePage::dump): Updated for rename.
2816
2817         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
2818         platform-specific functions.
2819         (WTR::LayoutTestController::LayoutTestController): Added call to
2820         platformInitialize.
2821         (WTR::LayoutTestController::waitUntilDone): Changed to call
2822         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
2823         right in this function.
2824         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
2825         rename.
2826
2827         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
2828         members needed to support the watchdog timer abstraction. Replaced
2829         some "watchdog"s with "watchdog timer".
2830
2831         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2832         Added.
2833         (WTR::LayoutTestController::platformInitialize): Does nothing on this
2834         platform.
2835         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
2836         from LayoutTestController.cpp and changed to use an early return.
2837         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
2838         LayoutTestController.cpp.
2839         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2840         Moved code here from LayoutTestController::waitUntilDone and changed
2841         to use an early return.
2842
2843         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2844         Added.
2845         (WTR::LayoutTestController::platformInitialize): Initialize our
2846         watchdog timer.
2847         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
2848         Kills and clears the watchdog timer.
2849         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
2850         LayoutTestController member function of the same name.
2851         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2852         Added. Sets up the timer if it isn't already set.
2853
2854         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
2855         LayoutTestControllerMac.mm.
2856
2857         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
2858         LayoutTestControllerWin.cpp.
2859
2860 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
2861
2862         Reviewed by Daniel Bates.
2863
2864         [GTK] fast/forms/listbox-selection.html fails
2865         https://bugs.webkit.org/show_bug.cgi?id=45942
2866
2867         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
2868         strings in keyDownCallback.
2869
2870         * DumpRenderTree/gtk/EventSender.cpp:
2871         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the
2872         modifier parsing logic.
2873
2874 2010-09-19  Sam Weinig  <sam@webkit.org>
2875
2876         Reviewed by Anders Carlsson.
2877
2878         WebKit2 decidePolicyForNavigationAction should include mouse button information
2879         <rdar://problem/8413165>
2880         https://bugs.webkit.org/show_bug.cgi?id=46060
2881
2882         * MiniBrowser/mac/BrowserWindowController.m:
2883         (decidePolicyForNavigationAction):
2884         (decidePolicyForNewWindowAction):
2885
2886 2010-09-19  Daniel Bates  <dbates@rim.com>
2887
2888         Reviewed by Martin Robinson.
2889
2890         Add unit tests for diffs that delete or modify a change log entry
2891         or describe changes that are far apart
2892         https://bugs.webkit.org/show_bug.cgi?id=46046
2893
2894         Add additional unit tests to test change log diffs that contain
2895         deletions or changes that are far apart from each other in the
2896         ChangeLog file.
2897
2898         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2899           - Added the following unit tests:
2900           "fixChangeLogPatch: [no change] In-place change."
2901           "fixChangeLogPatch: [no change] Remove first entry."
2902           "fixChangeLogPatch: [no change] Remove entry in the middle."
2903           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
2904
2905 2010-09-19  Sam Weinig  <sam@webkit.org>
2906
2907         Reviewed by Anders Carlsson.
2908
2909         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
2910         https://bugs.webkit.org/show_bug.cgi?id=46054
2911
2912         The new one acts like WKBundleNodeHandleRef and allows for getting a
2913         wrapper in a specific world for the handle.
2914
2915         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2916         (WTR::propertyValue):
2917         (WTR::propertyValueDouble):
2918         (WTR::propertyValueInt):
2919         (WTR::numericWindowPropertyValue):
2920         (WTR::toStr):
2921         (WTR::InjectedBundlePage::shouldBeginEditing):
2922         (WTR::InjectedBundlePage::shouldEndEditing):
2923         (WTR::InjectedBundlePage::shouldInsertNode):
2924         (WTR::InjectedBundlePage::shouldInsertText):
2925         (WTR::InjectedBundlePage::shouldDeleteRange):
2926         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2927         (WTR::InjectedBundlePage::shouldApplyStyle):
2928         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2929
2930 2010-09-19  Kent Tamura  <tkent@chromium.org>
2931
2932         Unreviewed. Fix WebGL test regressions by r67809.
2933
2934         * DumpRenderTree/chromium/WebPreferences.cpp:
2935         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
2936
2937 2010-09-19  Kent Tamura  <tkent@chromium.org>
2938
2939         Reviewed by Adam Barth.
2940
2941         [DRT/Chromium] Fix a WebSettings handling bug
2942         https://bugs.webkit.org/show_bug.cgi?id=45945
2943
2944         Before this change, Chromium DRT reset WebSettings for every new
2945         window. It was wrong.
2946         If new window is not the first one, we have to apply the same
2947         settings as the first window.  So, we introduce WebPreference to
2948         store the current settings, and apply it to new windows. It's same
2949         as test_shell's behavior.
2950
2951         * DumpRenderTree/DumpRenderTree.gypi:
2952         * DumpRenderTree/chromium/LayoutTestController.cpp:
2953           Use WebPreferences instead of WebSettings.
2954         (LayoutTestController::setUserStyleSheetEnabled):
2955         (LayoutTestController::setUserStyleSheetLocation):
2956         (LayoutTestController::setAuthorAndUserStylesEnabled):
2957         (LayoutTestController::setPopupBlockingEnabled):
2958         (LayoutTestController::disableImageLoading):
2959         (LayoutTestController::setJavaScriptCanAccessClipboard):
2960         (LayoutTestController::setXSSAuditorEnabled):
2961         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2962         (LayoutTestController::setAllowFileAccessFromFileURLs):
2963         (LayoutTestController::overridePreference):
2964         (LayoutTestController::setEditingBehavior):
2965         * DumpRenderTree/chromium/TestShell.cpp:
2966         (TestShell::resetWebSettings): Use WebPreferences.
2967         (TestShell::runFileTest): ditto.
2968         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
2969         * DumpRenderTree/chromium/TestShell.h:
2970         (TestShell::preferences):
2971         (TestShell::applyPreferences):
2972         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
2973         * DumpRenderTree/chromium/WebPreferences.h: Added.
2974
2975 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
2976
2977         Reviewed by David Levin.
2978
2979         update-webkit --chromium spitting out a spurious error
2980         https://bugs.webkit.org/show_bug.cgi?id=45868
2981
2982         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
2983
2984 2010-09-18  Sam Weinig  <sam@webkit.org>
2985
2986         Reviewed by Dan Bernstein.
2987
2988         Improve/unify the PageLoadClient interfaces
2989         https://bugs.webkit.org/show_bug.cgi?id=46043
2990
2991         * MiniBrowser/mac/BrowserWindowController.m:
2992         (didStartProvisionalLoadForFrame):
2993         (didReceiveServerRedirectForProvisionalLoadForFrame):
2994         (didFailProvisionalLoadWithErrorForFrame):
2995         (didCommitLoadForFrame):
2996         (didFinishDocumentLoadForFrame):
2997         (didFinishLoadForFrame):
2998         (didFailLoadWithErrorForFrame):
2999         (didReceiveTitleForFrame):
3000         (didFirstLayoutForFrame):
3001         (didFirstVisuallyNonEmptyLayoutForFrame):
3002         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3003         (WTR::InjectedBundlePage::InjectedBundlePage):
3004         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3005         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3006         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3007         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3008         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3009         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3010         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3011         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3012         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3013         * WebKitTestRunner/TestController.cpp:
3014         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3015         (WTR::TestController::didFinishLoadForFrame):
3016         * WebKitTestRunner/TestController.h:
3017
3018 2010-09-17  Eric Seidel  <eric@webkit.org>
3019
3020         Unreviewed.  Adding a shell script I use to run the
3021         commit-queue. Now that multiple machines run the cq,
3022         it makes sense to share the script between them.
3023
3024         * EWSTools/start-commit-queue.sh: Added.
3025
3026 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3027
3028         Reviewed by Jon Honeycutt.
3029
3030         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3031         slightly harder to read, so this reverts the previous background colors for various
3032         states, making it easier to read.
3033
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3035         (.success):
3036         (.failure):
3037         (.warnings):
3038         (.exception):
3039         (.start,.running,td.building):
3040         (.offline,td.offline):
3041
3042 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3043
3044         Unreviewed, rolling out r67692.
3045         http://trac.webkit.org/changeset/67692
3046         https://bugs.webkit.org/show_bug.cgi?id=46011
3047
3048         broke layout test dashboard (Requested by johnny_g on
3049         #webkit).
3050
3051         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3052         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3053         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3054
3055 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3056
3057         Reviewed by Oliver Hunt.
3058
3059         Style bot complains about cairo forward declaration naming
3060         https://bugs.webkit.org/show_bug.cgi?id=45867
3061
3062         Exclude Cairo forward declarations from indentifiers with underscores checks.
3063
3064         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3065         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3066
3067 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3068
3069         Reviewed by Ojan Vafai.
3070
3071         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3072         https://bugs.webkit.org/show_bug.cgi?id=45408
3073
3074         This change also tries to remove duplicated upload_results_json methods
3075         in run_webkit_tests.py and json_results_generator.py.
3076
3077         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3078         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3079         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3080
3081 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3082
3083         Reviewed by Andreas Kling.
3084
3085         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3086
3087         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3088         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3089         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3090         all page specific stuff to the UI.
3091
3092         * QtTestBrowser/launcherwindow.cpp:
3093         (LauncherWindow::initializeView):
3094         * QtTestBrowser/mainwindow.cpp:
3095         (MainWindow::MainWindow):
3096         (MainWindow::buildUI):
3097         (MainWindow::setPage):
3098         * QtTestBrowser/mainwindow.h:
3099
3100 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3101
3102         Reviewed by Andreas Kling.
3103
3104         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3105
3106         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3107         object will move to the qgraphicsscene instead of the qgraphicsview.
3108
3109         * QtTestBrowser/webview.cpp:
3110         (WebViewGraphicsBased::setPage):
3111         (WebViewGraphicsBased::setResizesToContents):
3112         (WebViewGraphicsBased::resizeEvent):
3113         (WebViewGraphicsBased::animatedFlip):
3114         * QtTestBrowser/webview.h:
3115         (WebViewGraphicsBased::setItemCacheMode):
3116         (WebViewGraphicsBased::itemCacheMode):
3117
3118 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3119
3120         Reviewed by Andreas Kling.
3121
3122         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3123
3124         We usually separate methods whose body are larger than a few lines from the class definition.
3125
3126         * QtTestBrowser/webview.h:
3127         (WebViewGraphicsBased::yRotation):
3128         (WebViewGraphicsBased::setYRotation):
3129
3130 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3131
3132         Reviewed by Andreas Kling.
3133
3134         Make initializeView method of LauncherWindow private.
3135
3136         No one else needs to be able to call it but LauncherWindow.
3137         Also moving the declation of isGraphicsBased method down in the same file, in order
3138         to better group related methods.
3139
3140         * QtTestBrowser/launcherwindow.h:
3141
3142 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3143
3144         Reviewed by Andreas Kling.
3145
3146         Make the getter 'page' method of MainWindow const.
3147
3148         * QtTestBrowser/mainwindow.cpp:
3149         (MainWindow::page):
3150         * QtTestBrowser/mainwindow.h:
3151
3152 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3153
3154         Reviewed by Andreas Kling.
3155
3156         Remove useless parameter from MainWindow class' constructor.
3157
3158         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3159         not referred in the constructor body and does not make much sense.
3160
3161         * QtTestBrowser/mainwindow.cpp:
3162         (MainWindow::MainWindow):
3163         * QtTestBrowser/mainwindow.h:
3164
3165 2010-09-15  Tony Chang  <tony@chromium.org>
3166
3167         Reviewed by Kent Tamura.
3168
3169         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3170         https://bugs.webkit.org/show_bug.cgi?id=42151
3171
3172         * DumpRenderTree/chromium/LayoutTestController.cpp:
3173         (LayoutTestController::LayoutTestController):
3174         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3175         (WorkItemLoadHTMLString::run):
3176         (LayoutTestController::queueLoadHTMLString):
3177         (LayoutTestController::reset):
3178         (LayoutTestController::setDeferMainResourceDataLoad):
3179         * DumpRenderTree/chromium/LayoutTestController.h:
3180         (LayoutTestController::deferMainResourceDataLoad):
3181         * DumpRenderTree/chromium/WebViewHost.cpp:
3182         (WebViewHost::didCreateDataSource):
3183
3184 2010-09-16  Adrienne Walker  <enne@google.com>
3185
3186         Reviewed by Kenneth Russell.
3187
3188         Add script to synchronize WebKit and Khronos WebGL tests
3189         https://bugs.webkit.org/show_bug.cgi?id=42336
3190
3191         * Scripts/update-webgl-conformance-tests: Added.
3192         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3193         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3194
3195 2010-09-16  Sam Weinig  <sam@webkit.org>
3196
3197         Reviewed by Anders Carlsson.
3198
3199         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3200         <rdar://problem/8365320>
3201         https://bugs.webkit.org/show_bug.cgi?id=44785
3202
3203         * MiniBrowser/mac/AppDelegate.m:
3204         (didReceiveSynchronousMessageFromInjectedBundle):
3205         (-[BrowserAppDelegate init]):
3206         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3207         (didCreatePage):
3208         * WebKitTestRunner/TestController.cpp:
3209         (WTR::TestController::initialize):
3210
3211 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3212
3213         Reviewed by Andreas Kling.
3214
3215         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3216         https://bugs.webkit.org/show_bug.cgi?id=45885
3217
3218         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3219
3220         * QtTestBrowser/launcherwindow.cpp:
3221         (LauncherWindow::screenshot):
3222
3223 2010-09-16  Anders Carlsson  <andersca@apple.com>
3224
3225         Fix clang++ build.
3226
3227         * MiniBrowser/mac/BrowserWindowController.m:
3228         (-[BrowserWindowController zoomIn:]):
3229         (-[BrowserWindowController zoomOut:]):
3230         (-[BrowserWindowController resetZoom:]):
3231         Remove trailing semicolons.
3232
3233 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3234
3235         Unreviewed, rolling out r67628.
3236         http://trac.webkit.org/changeset/67628
3237         https://bugs.webkit.org/show_bug.cgi?id=45904
3238
3239         broke the build (Requested by eric_carlson on #webkit).
3240
3241         * DumpRenderTree/gtk/EventSender.cpp:
3242         (contextClickCallback):
3243
3244 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3245
3246         Unreviewed.
3247
3248         Adding myself as a comitter.
3249
3250         * Scripts/webkitpy/common/config/committers.py:
3251
3252 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3253
3254         Reviewed by Eric Carlson.
3255
3256         [GTK] enhanced context menu for media elements
3257         https://bugs.webkit.org/show_bug.cgi?id=45021
3258
3259         EventSender::contextClick() now returns an array of js
3260         objects. Each object has a title property and a click() method.
3261
3262         * DumpRenderTree/gtk/EventSender.cpp:
3263         (getMenuItemTitleCallback):
3264         (setMenuItemTitleCallback):
3265         (menuItemClickCallback):
3266         (getMenuItemClass):
3267         (contextClickCallback):
3268
3269 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3270
3271         Reviewed by Eric Carlson and Martin Robinson.
3272
3273         [GTK] eventSender.contextClick() should return the contents of the context menu
3274         https://bugs.webkit.org/show_bug.cgi?id=39102
3275
3276         Make the eventSender use the new private WebKitGtk+ API to
3277         retrieve the context-menu item titles and store them in an array.
3278
3279         * DumpRenderTree/gtk/EventSender.cpp:
3280         (contextClickCallback):
3281
3282 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3283
3284         Reviewed by Jian Li.
3285
3286         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3287         https://bugs.webkit.org/show_bug.cgi?id=45798
3288
3289         * Scripts/build-webkit:
3290
3291 2010-09-16  Robert Hogan  <robert@webkit.org>
3292
3293         Reviewed by Antonio Gomes.
3294
3295         [Qt] Support globalhistory tests
3296         https://bugs.webkit.org/show_bug.cgi?id=45774
3297
3298         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3299         (WebCore::isGlobalHistoryTest):
3300         (WebCore::DumpRenderTree::open):
3301         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3302         (LayoutTestController::reset):
3303         (LayoutTestController::dumpHistoryCallbacks):
3304         (LayoutTestController::removeAllVisitedLinks):
3305         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3306
3307 2010-09-10  Tony Chang  <tony@chromium.org>
3308
3309         Reviewed by Eric Seidel.
3310
3311         deduplicate-tests should be runnable from any WebKit directory
3312         https://bugs.webkit.org/show_bug.cgi?id=44709
3313
3314         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3315         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3316
3317 2010-09-15  Tony Chang  <tony@chromium.org>
3318
3319         Reviewed by Kent Tamura.
3320
3321         [chromium] sort testing methods in DRT
3322         https://bugs.webkit.org/show_bug.cgi?id=45850
3323
3324         * DumpRenderTree/chromium/EventSender.cpp:
3325         (EventSender::EventSender):
3326         * DumpRenderTree/chromium/LayoutTestController.cpp:
3327         (LayoutTestController::LayoutTestController):
3328         * DumpRenderTree/chromium/TextInputController.cpp:
3329         (TextInputController::TextInputController):
3330
3331 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3332
3333         Reviewed by Adam Barth.
3334
3335         CQ status shows items out of order
3336         https://bugs.webkit.org/show_bug.cgi?id=45846
3337
3338         Only group consecutive status items with the same patch ID into the same
3339         group, so that overall item ordering is preserved.
3340
3341         Also don't indent status items that only have a single item in their
3342         group.
3343
3344         * QueueStatusServer/handlers/queuestatus.py:
3345         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3346         * QueueStatusServer/templates/queuestatus.html:
3347
3348 2010-09-15  Eric Seidel  <eric@webkit.org>
3349
3350         Reviewed by Adam Barth.
3351
3352         Add queue start/stop messages
3353         https://bugs.webkit.org/show_bug.cgi?id=45853
3354
3355         I ended up needing to clean up a bunch of our unit testing
3356         in order to test this new code path nicely.
3357
3358         There are also a few PEP8 changes needed to pass check-webkit-style.
3359
3360         * Scripts/webkitpy/tool/bot/queueengine.py:
3361         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3362         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3363         * Scripts/webkitpy/tool/commands/queues.py:
3364         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3365         * Scripts/webkitpy/tool/commands/queuestest.py:
3366         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3367
3368 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3369
3370         https://bugs.webkit.org/show_bug.cgi?id=45849
3371         WKURLCreateWithCFURL crashes with null url
3372
3373         Fix MiniBrowser crash when the url is not parseable.
3374
3375         * MiniBrowser/mac/BrowserWindowController.m:
3376         (-[BrowserWindowController fetch:]):
3377
3378 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3379
3380         Unreviewed.
3381
3382         Adding myself to the committers list.
3383
3384         * Scripts/webkitpy/common/config/committers.py:
3385
3386 2010-09-14  Eric Seidel  <eric@webkit.org>
3387
3388         Reviewed by Adam Barth.
3389
3390         Make it possible to run more than one commit-queue instance
3391         https://bugs.webkit.org/show_bug.cgi?id=45786
3392
3393         Mostly we need to make sure the two (or more) instances get
3394         different patches to work on.  To do this, I re-worked
3395         the code responsible for getting the next work item to
3396         round trip through the status server.  The status server only
3397         vends patches from the work items list, only if those patches
3398         have not had status reported for them in the last hour.
3399
3400         This is another step towards making all queues go through the
3401         status server, thus making it possible to run more than one
3402         instance of various EWS bots (as requested in bug 44292).
3403
3404         The webkitpy changes are already covered by existing unit tests.
3405         The QueueStatusSever sadly has no testing infrastructure yet. :(
3406
3407         * QueueStatusServer/handlers/nextpatch.py: Added.
3408         * QueueStatusServer/index.yaml:
3409         * QueueStatusServer/main.py:
3410         * Scripts/webkitpy/tool/commands/queues.py:
3411
3412 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3413
3414         Reviewed by Tony Chang.
3415
3416         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3417         https://bugs.webkit.org/show_bug.cgi?id=45791
3418
3419         Force filenames to be raw bytes before running difflib.unified_diff.
3420
3421         * Scripts/webkitpy/layout_tests/port/base.py:
3422         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3423
3424 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3425
3426         Reviewed by Tor Arne Vestbø.
3427
3428         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3429         https://bugs.webkit.org/show_bug.cgi?id=35247
3430
3431         The main issue when changing the views is that the plugins and any other components that
3432         depend on view specific attributes such as the native window id are not teared down.
3433         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3434         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3435         we decided to work around this in QtTestBrowser by making toggling between QWebView
3436         and QGraphicsWebView also re-create the page.
3437
3438         * QtTestBrowser/launcherwindow.cpp:
3439         (LauncherWindow::initializeView):
3440         * QtTestBrowser/mainwindow.h:
3441
3442 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
3443
3444         Reviewed by Adam Barth.
3445
3446         Send webkit accessibility notifications to Chromium
3447         https://bugs.webkit.org/show_bug.cgi?id=45156
3448
3449         Move printf inside shouldDumpAccessibilityNotifications check.
3450
3451         * DumpRenderTree/chromium/WebViewHost.cpp:
3452         (WebViewHost::postAccessibilityNotification):
3453
3454 2010-09-14  Tony Chang  <tony@chromium.org>
3455
3456         Reviewed by Kent Tamura.
3457
3458         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
3459         https://bugs.webkit.org/show_bug.cgi?id=45788
3460
3461         * DumpRenderTree/chromium/LayoutTestController.cpp:
3462         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
3463
3464 2010-09-14  Tony Chang  <tony@chromium.org>
3465
3466         Reviewed by Ojan Vafai.
3467
3468         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
3469         https://bugs.webkit.org/show_bug.cgi?id=45768
3470
3471         * DumpRenderTree/chromium/TestShell.cpp:
3472         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
3473
3474 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3475
3476         [wx] Build fix, add newly added directories to the directory list.
3477
3478         * wx/build/settings.py:
3479
3480 2010-09-14  Sam Weinig  <sam@webkit.org>
3481
3482         Reviewed by Anders Carlsson.
3483
3484         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
3485         https://bugs.webkit.org/show_bug.cgi?id=45785
3486
3487         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3488         (WTR::propertyValue):
3489         (WTR::numericWindowPropertyValue):
3490         (WTR::dumpPath):
3491         (WTR::toStr):
3492         (WTR::operator<<):
3493         (WTR::InjectedBundlePage::InjectedBundlePage):
3494         (WTR::InjectedBundlePage::shouldInsertNode):
3495         (WTR::InjectedBundlePage::shouldBeginEditing):
3496         (WTR::InjectedBundlePage::shouldEndEditing):
3497         (WTR::InjectedBundlePage::shouldInsertText):
3498         (WTR::InjectedBundlePage::shouldDeleteRange):
3499         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3500         (WTR::InjectedBundlePage::shouldApplyStyle):
3501         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3502
3503 2010-09-14  Adam Barth  <abarth@webkit.org>
3504
3505         Fix two typos in commit-queue.  The first is harmless.  The second
3506         causes the queue to reject patches when the build is broken.  :(
3507
3508         * Scripts/webkitpy/tool/commands/queues.py:
3509         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3510
3511 2010-09-14  Chris Guillory   <chris.guillory@google.com>
3512
3513         Reviewed by Chris Fleizach.
3514
3515         Send all accessibility notifications to Chromium.
3516         https://bugs.webkit.org/show_bug.cgi?id=45156
3517
3518         * DumpRenderTree/chromium/WebViewHost.cpp:
3519         (WebViewHost::postAccessibilityNotification):
3520         * DumpRenderTree/chromium/WebViewHost.h:
3521
3522 2010-09-14  Adam Barth  <abarth@webkit.org>
3523
3524         Reviewed by Eric Seidel.
3525
3526         commit-queue is slow during the day
3527         https://bugs.webkit.org/show_bug.cgi?id=45780
3528
3529         Thanks to the new logging, we've noticed that checkout-is-out-of-date
3530         errors in the first pass of landing don't retry the land.  Instead,
3531         they're treated as failures and cause the commit-queue to do two more
3532         builds before really trying to land the patch.  Worse, in the second
3533         build, we can get bitten by a flaky test.
3534
3535         This patch takes a slightly different approach to the commit-queue's
3536         main control logic.  We now use a separate subprocess for building and
3537         testing and for landing.  This means we should very rarely see the
3538         checkout-is-out-of-date error, and when we do see it, we should retry
3539         more quickly.  If my understanding is correct, this should be a big
3540         speed win for the commit-queue.
3541
3542         * Scripts/webkitpy/tool/commands/download.py:
3543         * Scripts/webkitpy/tool/commands/queues.py:
3544         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3545
3546 2010-09-14  Tony Chang  <tony@chromium.org>
3547
3548         Reviewed by Dimitri Glazkov.
3549
3550         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
3551         https://bugs.webkit.org/show_bug.cgi?id=45762
3552
3553         * DumpRenderTree/chromium/LayoutTestController.cpp:
3554         (LayoutTestController::LayoutTestController):
3555         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3556         * DumpRenderTree/chromium/LayoutTestController.h:
3557
3558 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
3559
3560         Adding myself as a reviewer.
3561
3562         * Scripts/webkitpy/common/config/committers.py:
3563
3564 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
3565
3566         Reviewed by Kenneth Rohde Christiansen.
3567
3568         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
3569         https://bugs.webkit.org/show_bug.cgi?id=45736
3570
3571         Build-webkit has showed a warning when WebKitBuild didn't exist, add
3572         an additional condition to avoid it.
3573
3574         * Scripts/build-webkit:
3575
3576 2010-09-13  Eric Seidel  <eric@webkit.org>
3577
3578         Reviewed by Adam Barth.
3579
3580         commit-queue should log when it's retrying due to checkout out of date error
3581         https://bugs.webkit.org/show_bug.cgi?id=45725
3582
3583         This will allow us to better track how often we see these errors
3584         and how long it takes the queue to recover from them.
3585
3586         In order to pass the tests, I had to correct an error
3587         from a previous change.  The UnitTestPort should not have
3588         ever been using the base port method as that will read
3589         a file from disk.  If the unit tests haven't passed the contents
3590         it should raise an IOError as though the file doesn't exist.
3591
3592         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3593         * Scripts/webkitpy/tool/commands/queues.py:
3594         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3595
3596 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
3597
3598         Reviewed by Adam Barth.
3599
3600         Upload results when cq patch landing fails
3601         https://bugs.webkit.org/show_bug.cgi?id=45683
3602
3603         Include script errors when CommitQueue._land fails.
3604
3605         * Scripts/webkitpy/tool/commands/queues.py:
3606
3607 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3608
3609         Reviewed by David Kilzer.
3610
3611         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
3612         https://bugs.webkit.org/show_bug.cgi?id=45548
3613
3614         * DumpRenderTree/AccessibilityUIElement.cpp:
3615         (isIgnoredCallback):
3616         (AccessibilityUIElement::getJSClass):
3617         * DumpRenderTree/AccessibilityUIElement.h:
3618         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3619         (AccessibilityUIElement::isIgnored):
3620         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3621         (AccessibilityUIElement::isIgnored):
3622         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3623         (AccessibilityUIElement::isIgnored):
3624
3625 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3626
3627         Reviewed by Andreas Kling.
3628
3629         jscPath() is incorrect in Windows' cmd.exe shell
3630         https://bugs.webkit.org/show_bug.cgi?id=45651
3631
3632         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
3633
3634 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3635
3636         Reviewed by Darin Adler.
3637
3638         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
3639         https://bugs.webkit.org/show_bug.cgi?id=43807
3640
3641         * DumpRenderTree/AccessibilityUIElement.cpp:
3642         (textMarkerForPointCallback):
3643         (AccessibilityUIElement::textMarkerForPoint):
3644         (AccessibilityUIElement::getJSClass):
3645         * DumpRenderTree/AccessibilityUIElement.h:
3646         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3647         (AccessibilityUIElement::textMarkerForPoint):
3648
3649 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
3650
3651         Reviewed by Kenneth Rohde Christiansen.
3652
3653         [Qt] build-webkit: Add --v8 option to build against V8
3654
3655         Note that V8 is picked up from QtScript, so this currently requires building
3656         against the experimental qt-script-v8 branch.
3657
3658         * Scripts/build-webkit:
3659
3660 2010-09-13  Hans Wennborg  <hans@chromium.org>
3661
3662         Reviewed by Jeremy Orlow.
3663
3664         Add WebDeviceOrientationClientMock::create() and use it from DRT.
3665         https://bugs.webkit.org/show_bug.cgi?id=45650
3666
3667         Do not use the WebDeviceOrientationClientMock constructor directly,
3668         but use the create() member function.
3669
3670         This should fix the linker errors for the multi-DLL Chromium DRT build.
3671
3672         * DumpRenderTree/chromium/LayoutTestController.cpp:
3673         (LayoutTestController::setMockDeviceOrientation):
3674         (LayoutTestController::deviceOrientationClient):
3675
3676 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3677
3678         Reviewed by Antti Koivisto.
3679
3680         Add support for testing the viewport meta tag algorithm,
3681         based on the following draft spec:
3682
3683         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
3684
3685         Add common handling of viewport meta tag based on new Opera spec
3686         https://bugs.webkit.org/show_bug.cgi?id=44201
3687
3688         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3689         (LayoutTestController::dumpConfigurationForViewport):
3690         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3691
3692 2010-09-12  Kent Tamura  <tkent@chromium.org>
3693
3694         Reviewed by Tony Chang.
3695
3696         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
3697         https://bugs.webkit.org/show_bug.cgi?id=45517
3698
3699         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
3700
3701         * DumpRenderTree/chromium/ImageDiff.cpp:
3702         (Image::craeteFromStdin):
3703         (Image::createFromFilename):
3704         (diffImages):
3705         * DumpRenderTree/chromium/TestShell.cpp:
3706         (TestShell::dumpImage):
3707
3708 2010-09-10  MORITA Hajime  <morrita@google.com>
3709
3710         Reviewed by Tony Chang.
3711
3712         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3713         https://bugs.webkit.org/show_bug.cgi?id=45441
3714
3715         Added TextInputController::hasSpellingMarker().
3716
3717         * DumpRenderTree/chromium/TextInputController.cpp:
3718         (TextInputController::TextInputController):
3719         (TextInputController::hasSpellingMarker):
3720         * DumpRenderTree/chromium/TextInputController.h:
3721
3722 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
3723
3724         Unreviewed, build fix.
3725
3726         My last change accidentally contained a local change to the
3727         rebaselinig script; webkit-patch land picked it up without telling
3728         me and committed it :(
3729
3730         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3731
3732 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
3733
3734         Reviewed by Anders Carlsson.
3735
3736         Attempt to fix Windows MiniBrowser build (untested)
3737         https://bugs.webkit.org/show_bug.cgi?id=45609
3738
3739         * MiniBrowser/win/BrowserView.cpp:
3740         (runJavaScriptConfirm):
3741         (runJavaScriptPrompt):
3742
3743 2010-09-11  Sam Weinig  <sam@webkit.org>
3744
3745         Reviewed by Maciej Stachowiak.
3746
3747         Fix zoom related tests when testing WebKit2.
3748
3749         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3750         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
3751
3752 2010-09-11  Sam Weinig  <sam@webkit.org>
3753
3754         Reviewed by Dan Bernstein.
3755
3756         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
3757         <rdar://problem/8359252>
3758         https://bugs.webkit.org/show_bug.cgi?id=45605
3759
3760         * MiniBrowser/mac/BrowserWindowController.m:
3761         (setStatusText):
3762         (contentsSizeChanged):
3763         (-[BrowserWindowController awakeFromNib]):
3764         * MiniBrowser/win/BrowserView.cpp:
3765         (runJavaScriptConfirm):
3766         (runJavaScriptPrompt):
3767         (setStatusText):
3768         (contentsSizeChanged):
3769         (BrowserView::create):
3770         * WebKitTestRunner/TestController.cpp:
3771         (WTR::createOtherPage):
3772         (WTR::TestController::initialize):
3773
3774 2010-09-11  Sam Weinig  <sam@webkit.org>
3775
3776         Reviewed by Dan Bernstein.
3777
3778         Add callback mechanism for the getting the source of a frame
3779         <rdar://problem/8364681>
3780         https://bugs.webkit.org/show_bug.cgi?id=45604
3781
3782         Add ability to dump the main frame's source to the console.
3783
3784         * MiniBrowser/mac/BrowserWindowController.h:
3785         * MiniBrowser/mac/BrowserWindowController.m:
3786         (-[BrowserWindowController dumpSourceToConsole:]):
3787         * MiniBrowser/mac/MainMenu.xib:
3788
3789 2010-09-11  Eric Seidel  <eric@webkit.org>
3790
3791         Reviewed by Adam Barth.
3792
3793         Remove unneeded Empty Queue messages
3794         https://bugs.webkit.org/show_bug.cgi?id=45602
3795
3796         We already have a /gc job to delete these.
3797         recentstatus.py is already smart enough to use the
3798         most recent of the workitems last update or the most recent status,
3799         so removing these should not change the _last_status_date() return
3800         value more than a few milliseconds.
3801
3802         These messages just spam the recent status log.
3803
3804         * Scripts/webkitpy/tool/commands/queues.py:
3805
3806 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3807
3808         Reviewed by Adam Barth.
3809
3810         Fix Python exception when generating synthetic patch IDs
3811         https://bugs.webkit.org/show_bug.cgi?id=45592
3812
3813         Can't concatenate strings and numbers directly.
3814
3815         * QueueStatusServer/handlers/queuestatus.py:
3816
3817 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3818
3819         Reviewed by Adam Barth.
3820
3821         Group statuses in queue status by patch ID
3822         https://bugs.webkit.org/show_bug.cgi?id=45588
3823
3824         Group statuses by patch ID so that the status page is easier
3825         to scan.
3826
3827         * QueueStatusServer/handlers/queuestatus.py:
3828         * QueueStatusServer/stylesheets/dashboard.css:
3829         (.status-group):
3830         (.status-bug):
3831         (.status-group ul):
3832         (.status-group ul li):
3833         (.status-group ul li:hover):
3834         (.status-cell):
3835         (.status-cell:hover):
3836         (.status-cell.pass):
3837         (.status-cell.fail):
3838         (.status-cell.pending):
3839         (.status-cell.error):
3840         * QueueStatusServer/templates/dashboard.html:
3841         * QueueStatusServer/templates/queuestatus.html:
3842
3843 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3844
3845         Reviewed by Tony Chang.
3846
3847         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
3848         https://bugs.webkit.org/show_bug.cgi?id=45479
3849
3850         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
3851         implementation in ResourceLoadDelegate in the Mac port).
3852
3853         * DumpRenderTree/chromium/LayoutTestController.cpp:
3854         (LayoutTestController::LayoutTestController):
3855         (LayoutTestController::dumpResourceResponseMIMETypes):
3856         (LayoutTestController::reset):
3857         * DumpRenderTree/chromium/LayoutTestController.h:
3858         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
3859         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
3860         * DumpRenderTree/chromium/TestShell.h:
3861         (TestShell::shouldDumpResourceResponseMIMETypes):
3862         * DumpRenderTree/chromium/WebViewHost.cpp:
3863         (WebViewHost::didReceiveResponse):
3864
3865 2010-09-11  Eric Seidel  <eric@webkit.org>
3866
3867         Reviewed by Adam Barth.
3868
3869         queues.webkit.org should expose /remote_api for data upload/download
3870         https://bugs.webkit.org/show_bug.cgi?id=45559
3871
3872         * QueueStatusServer/app.yaml:
3873          - /remote_api is a standard app-engine service which allows use of
3874            the bulk uploader for data upload/download.  Exposing this
3875            (for admin access only) allows us to use
3876
3877 2010-09-10  Sam Weinig  <sam@webkit.org>
3878
3879         Reviewed by Dan Bernstein.
3880
3881         Add zoom support to WebKit2 API
3882         <rdar://problem/7660657>
3883         https://bugs.webkit.org/show_bug.cgi?id=45585
3884
3885         - Add zoom options to MiniBrowser that mimic Safari's options using
3886           the new WebKit2 zoom APIs.
3887         - Switch uses of float for the zoom APIs to use double.
3888
3889         * MiniBrowser/mac/BrowserWindowController.h:
3890         * MiniBrowser/mac/BrowserWindowController.m:
3891         (-[BrowserWindowController initWithPageNamespace:]):
3892         (-[BrowserWindowController validateMenuItem:]):
3893         (-[BrowserWindowController validateUserInterfaceItem:]):
3894         (-[BrowserWindowController currentZoomFactor]):
3895         (-[BrowserWindowController setCurrentZoomFactor:]):
3896         (-[BrowserWindowController canZoomIn]):
3897         (-[BrowserWindowController zoomIn:]):
3898         (-[BrowserWindowController canZoomOut]):
3899         (-[BrowserWindowController zoomOut:]):
3900         (-[BrowserWindowController canResetZoom]):
3901         (-[BrowserWindowController resetZoom:]):
3902         (-[BrowserWindowController toggleZoomMode:]):
3903         * MiniBrowser/mac/MainMenu.xib:
3904         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3905         (WTR::EventSendingController::textZoomIn):
3906         (WTR::EventSendingController::textZoomOut):
3907         (WTR::EventSendingController::zoomPageIn):
3908         (WTR::EventSendingController::zoomPageOut):
3909
3910 2010-09-10  Robert Hogan  <robert@webkit.org>
3911
3912         Reviewed by Andreas Kling.
3913
3914         [Qt] Fix crash in DRT in standalone mode
3915
3916         https://bugs.webkit.org/show_bug.cgi?id=45454
3917
3918         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3919         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3920
3921 2010-09-10  Sam Weinig  <sam@webkit.org>
3922
3923         Reviewed by Darin Adler.
3924
3925         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3926         Precursor to <rdar://problem/7660657>
3927         https://bugs.webkit.org/show_bug.cgi?id=45522
3928
3929         Update for changes to the Bundle API to allow separate control of page and text zoom
3930         levels.
3931
3932         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3933         (WTR::EventSendingController::textZoomIn):
3934         (WTR::EventSendingController::textZoomOut):
3935         (WTR::EventSendingController::zoomPageIn):
3936         (WTR::EventSendingController::zoomPageOut):
3937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3938         (WTR::InjectedBundlePage::reset):
3939
3940 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
3941
3942         Reviewed by Andreas Kling.
3943
3944         [Qt] Support click event for notifications
3945         https://bugs.webkit.org/show_bug.cgi?id=44836
3946
3947         Add support for simulateDesktopNotificationClick by calling
3948         back to DumpRenderTreeSupportQt.cpp.
3949
3950         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3951         (LayoutTestController::simulateDesktopNotificationClick):
3952         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3953
3954 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
3955
3956         Reviewed by Eric Seidel.
3957
3958         Update queue status when patches fail their first land attempt
3959         https://bugs.webkit.org/show_bug.cgi?id=45583
3960
3961         Add a few more _update_status calls to make it more obvious if a patch is
3962         being retried because tests failed.
3963
3964         * Scripts/webkitpy/tool/commands/queues.py:
3965
3966 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
3967
3968         Reviewed by Andreas Kling.
3969
3970         [Qt] MiniBrowser crashes with multiply windows when closing one of them
3971         https://bugs.webkit.org/show_bug.cgi?id=45536
3972
3973         * MiniBrowser/qt/BrowserView.cpp:
3974         (BrowserView::BrowserView): Reference the context instead of adopting it
3975         because it can be shared across different views.
3976
3977 2010-09-10  Tony Chang  <tony@chromium.org>
3978
3979         Unreviewed, rolling out r67241.
3980         http://trac.webkit.org/changeset/67241
3981         https://bugs.webkit.org/show_bug.cgi?id=44709
3982
3983         Accidentally committed.
3984
3985         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3986         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3987
3988 2010-09-10  Tony Chang  <tony@chromium.org>
3989
3990         Reviewed by Ojan Vafai.
3991
3992         deduplicate-tests should be runnable from any WebKit directory
3993         https://bugs.webkit.org/show_bug.cgi?id=44709
3994
3995         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3996         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3997
3998 2010-09-10  Tony Chang  <tony@chromium.org>
3999
4000         Unreviewed, rolling out r67216.
4001         http://trac.webkit.org/changeset/67216
4002         https://bugs.webkit.org/show_bug.cgi?id=44709
4003
4004         Broke
4005
4006         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4007         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4008
4009 2010-09-10  Tony Chang  <tony@chromium.org>
4010
4011         Reviewed by Ojan Vafai.
4012
4013         deduplicate-tests should be runnable from any WebKit directory
4014         https://bugs.webkit.org/show_bug.cgi?id=44709
4015
4016         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4017         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4018
4019 2010-09-09  Hans Wennborg  <hans@chromium.org>
4020
4021         Reviewed by Jeremy Orlow.
4022
4023         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
4024         https://bugs.webkit.org/show_bug.cgi?id=45460
4025
4026         This enables DumpRenderTree to run layout tests for DeviceOrientation.
4027
4028         Also declare the LayoutTestController destructor out-of-line.
4029         Otherwise the implicit destructor would cause compiler errors because
4030         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
4031
4032         * DumpRenderTree/chromium/LayoutTestController.cpp:
4033         (LayoutTestController::~LayoutTestController):
4034         (LayoutTestController::setMockDeviceOrientation):
4035         (LayoutTestController::deviceOrientationClient):
4036         * DumpRenderTree/chromium/LayoutTestController.h:
4037         * DumpRenderTree/chromium/WebViewHost.cpp:
4038         (WebViewHost::deviceOrientationClient):
4039         * DumpRenderTree/chromium/WebViewHost.h:
4040
4041 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
4042
4043         Unreviewed, rolling out r67119.
4044         http://trac.webkit.org/changeset/67119
4045         https://bugs.webkit.org/show_bug.cgi?id=45505
4046
4047         Extra newlines in results (Requested by tony^work on #webkit).
4048
4049         * DumpRenderTree/chromium/LayoutTestController.cpp:
4050         (LayoutTestController::LayoutTestController):
4051         (LayoutTestController::reset):
4052         * DumpRenderTree/chromium/LayoutTestController.h:
4053         * DumpRenderTree/chromium/TestShell.h:
4054         * DumpRenderTree/chromium/WebViewHost.cpp:
4055         (printResponseDescription):
4056         (printNodeDescription):
4057         (printRangeDescription):
4058         (WebViewHost::shouldBeginEditing):
4059         (WebViewHost::shouldEndEditing):
4060         (WebViewHost::shouldInsertNode):
4061         (WebViewHost::shouldChangeSelectedRange):
4062         (WebViewHost::shouldDeleteRange):
4063         (WebViewHost::shouldApplyStyle):
4064         (WebViewHost::didBeginEditing):
4065         (WebViewHost::didChangeSelection):
4066         (WebViewHost::didChangeContents):
4067         (WebViewHost::didEndEditing):
4068         (WebViewHost::decidePolicyForNavigation):
4069         (WebViewHost::didCancelClientRedirect):
4070         (WebViewHost::didStartProvisionalLoad):
4071         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
4072         (WebViewHost::didFailProvisionalLoad):
4073         (WebViewHost::didCommitProvisionalLoad):
4074         (WebViewHost::didFinishDocumentLoad):
4075         (WebViewHost::didHandleOnloadEvents):
4076         (WebViewHost::didFailLoad):
4077         (WebViewHost::didFinishLoad):
4078         (WebViewHost::didChangeLocationWithinPage):
4079         (WebViewHost::willSendRequest):
4080         (WebViewHost::didReceiveResponse):
4081         (WebViewHost::didFinishResourceLoad):
4082         (WebViewHost::didFailResourceLoad):
4083         (WebViewHost::didDisplayInsecureContent):
4084         (WebViewHost::didRunInsecureContent):
4085         (WebViewHost::printFrameDescription):
4086
4087 2010-09-09  Michael Saboff  <msaboff@apple.com>
4088
4089         Unreviewed, adding myself to committers list.
4090
4091         * Scripts/webkitpy/common/config/committers.py:
4092
4093 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
4094
4095         Reviewed by Tony Chang.
4096
4097         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
4098         https://bugs.webkit.org/show_bug.cgi?id=45479
4099
4100         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
4101         implementation in ResourceLoadDelegate in the Mac port).
4102
4103         * DumpRenderTree/chromium/LayoutTestController.cpp:
4104         (LayoutTestController::LayoutTestController):
4105         (LayoutTestController::dumpResourceResponseMIMETypes):
4106         (LayoutTestController::reset):
4107         * DumpRenderTree/chromium/LayoutTestController.h:
4108         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
4109         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
4110         * DumpRenderTree/chromium/TestShell.h:
4111         (TestShell::shouldDumpResourceResponseMIMETypes):
4112         * DumpRenderTree/chromium/WebViewHost.cpp:
4113         (WebViewHost::didReceiveResponse):
4114
4115 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
4116
4117         Reviewed by Daniel Bates.
4118
4119         svn-apply tries to delete directories it shouldn't
4120         https://bugs.webkit.org/show_bug.cgi?id=45424
4121
4122         isDirectoryEmptyForRemoval had the wrong check. If an item in the
4123         directory is itself a directory, then the directory is definitely
4124         not empty.
4125
4126         * Scripts/svn-apply:
4127
4128 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
4129
4130         Fixing GTK and windows build failure.
4131
4132         AX: Support AccessibilityTextMarkers in DRT
4133         https://bugs.webkit.org/show_bug.cgi?id=44778
4134
4135         * DumpRenderTree/AccessibilityTextMarker.h:
4136         (AccessibilityTextMarker::platformTextMarker):
4137         (AccessibilityTextMarkerRange::platformTextMarkerRange):
4138         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
4139         (AccessibilityTextMarker::platformTextMarker):
4140         (AccessibilityTextMarkerRange::platformTextMarkerRange):
4141
4142 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
4143
4144         Reviewed by David Kilzer.
4145
4146         AX: Support AccessibilityTextMarkers in DRT
4147         https://bugs.webkit.org/show_bug.cgi?id=44778
4148
4149         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers
4150         that WebCore uses when vending information about its VisiblePositions through AX.
4151
4152         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
4153         methods for encapsulating and checking equality.
4154
4155         This will allow future bug fixes in the text marker system to be adequately tested.
4156
4157         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
4158         (toTextMarker):
4159         (isMarkerEqualCallback):
4160         (markerFinalize):
4161         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
4162         (AccessibilityTextMarker::getJSClass):
4163         (toTextMarkerRange):
4164         (isMarkerRangeEqualCallback):
4165         (markerRangeFinalize):
4166         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
4167         (AccessibilityTextMarkerRange::getJSClass):
4168         * DumpRenderTree/AccessibilityTextMarker.h: Added.
4169         (AccessibilityTextMarker::platformTextMarker):
4170         (AccessibilityTextMarkerRange::platformTextMarkerRange):
4171         (AccessibilityTextMarker::AccessibilityTextMarker):
4172         (AccessibilityTextMarker::~AccessibilityTextMarker):
4173         (AccessibilityTextMarker::isEqual):
4174         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
4175         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
4176         (AccessibilityTextMarkerRange::isEqual):
4177         * DumpRenderTree/AccessibilityUIElement.cpp:
4178         (textMarkerRangeForElementCallback):
4179         (textMarkerRangeLengthCallback):
4180         (textMarkerRangeForMarkersCallback):
4181         (startTextMarkerForTextMarkerRangeCallback):
4182         (endTextMarkerForTextMarkerRangeCallback):
4183         (accessibilityElementForTextMarkerCallback):
4184         (AccessibilityUIElement::textMarkerRangeForElement):
4185         (AccessibilityUIElement::textMarkerRangeLength):
4186         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
4187         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
4188         (AccessibilityUIElement::accessibilityElementForTextMarker):
4189         (AccessibilityUIElement::getJSClass):
4190         * DumpRenderTree/AccessibilityUIElement.h:
4191         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4192         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
4193         (AccessibilityTextMarker::AccessibilityTextMarker):
4194         (AccessibilityTextMarker::~AccessibilityTextMarker):
4195         (AccessibilityTextMarker::isEqual):
4196         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
4197         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
4198         (AccessibilityTextMarkerRange::isEqual):
4199         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4200         (AccessibilityUIElement::textMarkerRangeForElement):
4201         (AccessibilityUIElement::textMarkerRangeLength):
4202         (AccessibilityUIElement::textMarkerRangeForMarkers):
4203         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
4204         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
4205         (AccessibilityUIElement::accessibilityElementForTextMarker):
4206         * DumpRenderTree/win/DumpRenderTree.vcproj:
4207
4208 2010-08-25  Tony Chang  <tony@chromium.org>
4209
4210         Reviewed by Ojan Vafai.
4211
4212         don't delete duplicates needed because of intermediate results
4213         https://bugs.webkit.org/show_bug.cgi?id=44653
4214
4215         Also, output the full path so we can pipe the output to rm.
4216
4217         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4218         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4219
4220 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
4221
4222         Reviewed by Andreas Kling.
4223
4224         [Qt] MiniBrowser does not starts properly
4225         https://bugs.webkit.org/show_bug.cgi?id=45459
4226
4227         Do not try set up the first window by calling newWindow on a
4228         newly created BrowserWindow since it creates a new object.
4229         * MiniBrowser/qt/BrowserWindow.cpp:
4230         (BrowserWindow::BrowserWindow):
4231         * MiniBrowser/qt/main.cpp:
4232         (main):
4233
4234 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
4235
4236         Reviewed by Xan Lopez.
4237
4238         [GTK] Get ImageDiff building on Win32
4239         https://bugs.webkit.org/show_bug.cgi?id=45353
4240
4241         * DumpRenderTree/gtk/ImageDiff.cpp:
4242         (main): Switch from using strtok to g_strsplit.
4243