2010-03-02 Arno Renevier <arno@renevier.net>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-03-02  Arno Renevier  <arno@renevier.net>
2
3         Reviewed by Gustavo Noronha Silva.
4
5         [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
6         https://bugs.webkit.org/show_bug.cgi?id=35210
7
8         * DumpRenderTree/gtk/DumpRenderTree.cpp:
9         (geolocationPolicyDecisionRequested):
10         (createWebView):
11
12 2010-03-02  Dirk Pranke  <dpranke@chromium.org>
13
14         Reviewed by David Levin.
15
16         Revert r55339 - the Chromium codebase downstream had a temporary
17         need for WebKitTools/pywebsocket to still exist after Chris Jerdonek
18         had moved it (scripts still referenced the old location). Those
19         scripts have been updated to the new location, so it should be safe
20         to delete this now.
21
22         https://bugs.webkit.org/show_bug.cgi?id=35614
23
24         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
25
26 2010-03-02  Dirk Pranke  <dpranke@chromium.org>
27
28         Reviewed by Dimitri Glazkov.
29
30         new-run-webkit-tests on chromium-linux tests to see if
31         layout_test_helper exists, but we don't use layout_test_helper on
32         linux. The test derefences a None object, and we crash. This fixes
33         that.
34
35         https://bugs.webkit.org/show_bug.cgi?id=35602
36
37         * Scripts/webkitpy/layout_tests/port/chromium.py:
38
39  2010-03-02  Dirk Pranke  <dpranke@chromium.org>
40
41         Reviewed by Dimitri Glazkov.
42
43         r55388 (bug 35553) worked around a bug in Python's subprocess.Popen()
44         that was causing DRT to hang on exit in new-run-webkit-tests.
45         Unfortunately, that workaround doesn't work on chromium-win
46         (and the script fails completely). The good news is that the check
47         isn't actually necessary, and so this change makes it conditional.
48
49         https://bugs.webkit.org/show_bug.cgi?id=35601
50
51         * Scripts/webkitpy/layout_tests/port/chromium.py:
52
53 2010-03-02  Mark Rowe  <mrowe@apple.com>
54
55         Reviewed by Darin Adler.
56
57         Bug 35576: WebKit should tell plug-in instances when private browsing state changes
58         <http://webkit.org/b/35576>
59
60         TestNetscapePlugin is another bit of plug-in code where copy-paste was heavily used
61         when porting.  Update the Windows and UNIX implementations of NPP_New and NPP_SetValue
62         to provide the expected behavior related to NPNVprivateModeBool.  Hopefully this code
63         duplication can be cleaned up in the future.
64
65         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
66         (webkit_test_plugin_new_instance):
67         (webkit_test_plugin_set_value):
68         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
69         (NPP_New):
70         (NPP_SetValue):
71
72 2010-03-02  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
73
74         Reviewed by Alexey Proskuryakov.
75
76         Test plugin still has issues with releasing objects, and variants
77         https://bugs.webkit.org/show_bug.cgi?id=35587
78
79         Fix the conditions for releasing the variants after calling
80         invoke, and avoid having a number of objects leak.
81
82         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
83         (testDocumentOpen):
84         (testWindowOpen):
85
86 2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>
87
88         Reviewed by Shinichiro Hamaji.
89
90         Refactored the StyleChecker class's file-processing method
91         _process_file().  This will make it easier to add new
92         file-processing capabilities to check-webkit-style.
93
94         https://bugs.webkit.org/show_bug.cgi?id=35490
95
96         * Scripts/webkitpy/style/checker.py:
97           - Added a _read_lines() method to the StyleChecker class
98             that extracts the lines from a file.
99           - Replaced part of _process_file() with a call to the new
100             _read_lines() method.
101           - Replaced another part of _process_file() with a call
102             to the new CarriageReturnProcessor.process() method.
103
104         * Scripts/webkitpy/style/processors/common.py:
105           - Replaced the check_no_carriage_return() function with a
106             new CarriageReturnProcessor class.
107
108         * Scripts/webkitpy/style/processors/common_unittest.py:
109           - Renamed the CarriageReturnTest class to
110             CarriageReturnProcessorTest and updated it as necessary.
111
112 2010-03-02  Chris Jerdonek  <cjerdonek@webkit.org>
113
114         Reviewed by Shinichiro Hamaji.
115
116         Started using the logging module in check-webkit-style.
117         This provides more options for debugging and a more flexible,
118         uniform way to report messages to the end-user.
119
120         https://bugs.webkit.org/show_bug.cgi?id=35484
121
122         Also included classes in a central location to facilitate
123         the unit testing of logging code (setUp and tearDown of unit
124         test logging configurations, etc).
125
126         * Scripts/check-webkit-style:
127           - Added a call to configure_logging() in the beginning of main().
128           - Replaced two calls to sys.stderr.write() with appropriate
129             logging calls.
130
131         * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
132
133         * Scripts/webkitpy/init/logtesting.py: Added.
134           - Added a UnitTestLogStream class to capture log output
135             during unit tests.
136           - Added a UnitTestLog class that provides convenience methods
137             for unit-testing logging code.
138
139         * Scripts/webkitpy/style/checker.py:
140           - Added a configure_logging() method.
141           - Added a _LevelLoggingFilter class to filter out log messages
142             above a certain logging level.
143           - Removed the _stderr_write() method from the StyleChecker class
144             and replaced its use with appropriate logging calls.
145
146         * Scripts/webkitpy/style/checker_unittest.py:
147           - Added a ConfigureLoggingTest class to unit test the
148             configure_logging() method.
149           - Updated the StyleCheckerCheckFileTest class as necessary.
150
151         * Scripts/webkitpy/style_references.py:
152           - Added references to logtesting.UnitTestLog and
153             logtesting.UnitTestLogStream.
154
155 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
156
157         Fixing broken DRT on Leopard/Tiger. Second try.
158
159         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
160         https://bugs.webkit.org/show_bug.cgi?id=35514
161
162         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
163
164 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
165
166         Fixing broken DRT on Leopard/Tiger.
167
168         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
169         https://bugs.webkit.org/show_bug.cgi?id=35514
170
171         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
172
173 2010-03-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
174
175         Reviewed by Eric Seidel.
176
177         [GTK] plugins/setProperty.html fails on 64bit Release
178         https://bugs.webkit.org/show_bug.cgi?id=35425
179
180         Check invoke's return code before releasing the variant, since
181         there's a chance it won't be properly initialized, leading to
182         memory corruption, in some cases.
183
184         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
185         (testCallback):
186         (testEnumerate):
187         (testDocumentOpen):
188         (testWindowOpen):
189         (handleCallback):
190
191 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
192
193         Reviewed by nobody. Build bustage :(
194
195         Fix stupid typo that I committed even after David Levin pointed
196         it out to me :(
197
198         https://bugs.webkit.org/show_bug.cgi?id=35553
199
200         * Scripts/webkitpy/layout_tests/port/mac.py:
201
202 2010-03-01  Chris Fleizach  <cfleizach@apple.com>
203
204         Reviewed by Darin Adler.
205
206         AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
207         https://bugs.webkit.org/show_bug.cgi?id=35514
208
209         Add rowCount, columnCount for tables.
210
211         * DumpRenderTree/AccessibilityUIElement.cpp:
212         (rowCountCallback):
213         (columnCountCallback):
214         (AccessibilityUIElement::getJSClass):
215         * DumpRenderTree/AccessibilityUIElement.h:
216         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
217         (AccessibilityUIElement::rowCount):
218         (AccessibilityUIElement::columnCount):
219         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
220         (AccessibilityUIElement::rowCount):
221         (AccessibilityUIElement::columnCount):
222         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
223         (AccessibilityUIElement::rowCount):
224         (AccessibilityUIElement::columnCount):
225
226 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
227
228         Reviewed by Eric Seidel.
229
230         Work around a bug in Python's subprocess.Popen() that keeps us from
231         cleaning up DumpRenderTree / test_shell properly when we finish the
232         tests in new-run-webkit-tests.
233
234         https://bugs.webkit.org/show_bug.cgi?id=35553
235
236         * Scripts/webkitpy/layout_tests/port/chromium.py:
237         * Scripts/webkitpy/layout_tests/port/mac.py:
238
239 2010-03-01  Arno Renevier  <arno@renevier.net>
240
241         Reviewed by Xan Lopez.
242
243         webkit-build could pass unknown arguments to autogen.sh
244         https://bugs.webkit.org/show_bug.cgi?id=35454
245
246         * Scripts/build-webkit:
247
248 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
249
250         Rubber-stamped by Dimitri Glazkov.
251
252         Fix breakage from r55372.
253
254         https://bugs.webkit.org/show_bug.cgi?id=35549
255
256         * Scripts/webkitpy/layout_tests/port/chromium.py:
257
258 2010-03-01  Adam Barth  <abarth@webkit.org>
259
260         Reviewed by Eric Seidel.
261
262         EWS can hang for five hours when compile output is too big
263         https://bugs.webkit.org/show_bug.cgi?id=35545
264
265         * Scripts/webkitpy/commands/queues.py: Limit uploads to 1MB instead of
266         5MB.  AppEngine seems to not like 5MB uploads.  I'm not sure what the
267         limit is.  Let's try 1MB for a while and see how it goes.
268         * Scripts/webkitpy/networktransaction.py: Tune the default parameters
269         to our exponential backoff.  I'm not sure why I picked five hours as
270         the retry limit.  That seems way too large.
271
272 2010-03-01  Brady Eidson  <beidson@apple.com>
273
274         Reviewed by Sam Weinig.
275
276         REGRESSION: Telling a WebView to go to its current WebHistoryItem is broken.
277         <rdar://problem/7699371> and https://bugs.webkit.org/show_bug.cgi?id=35532
278
279         * DumpRenderTree/LayoutTestController.cpp:
280         (apiTestGoToCurrentBackForwardItemCallback):
281         (LayoutTestController::staticFunctions):
282         * DumpRenderTree/LayoutTestController.h:
283         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
284         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
285
286         Stubs for now:
287         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
288         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
289         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
290         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
291         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
292         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
293
294 2010-03-01  Dirk Pranke  <dpranke@chromium.org>
295
296         Reviewed by David Levin.
297
298         General cleanup of error handling in new-run-webkit-tests.
299
300         Add Port.check_build() call that is separate from Port.check_sys_deps()
301         (and add a --nocheck-build flag to skip). This breaks a circular
302         dependency where you would start the layout test helper before
303         checking sys deps, but checking sys deps was the thing that told
304         you if your binaries where there.
305
306         Also, made Port.check_sys_deps(), start_helper() and stop_helper()
307         optional by providing default implementations in the base class
308         rather than requiring ports to implement the routines regardless
309         of whether or not they were needed.
310
311         Lastly, tweak a bunch of log messages to be cleaner, including
312         changing messages in thirdparty/autoinstall.py to be silent at
313         the default log level.
314
315         http://bugs.webkit.org/show_bug.cgi?id=35416
316
317         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
318         * Scripts/webkitpy/layout_tests/port/base.py:
319         * Scripts/webkitpy/layout_tests/port/chromium.py:
320         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
321         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
322         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
323         * Scripts/webkitpy/layout_tests/port/mac.py:
324         * Scripts/webkitpy/layout_tests/port/passing.py:
325         * Scripts/webkitpy/layout_tests/port/test.py:
326         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
327         * Scripts/webkitpy/thirdparty/autoinstall.py
328
329 2010-03-01  Dirk Pranke <dpranke@chromium.org>
330
331          Reviewed by David Levin.
332
333          new-chromium-webkit-tests --platform=mac-leopard diffs are backwards
334          https://bugs.webkit.org/show_bug.cgi?id=35265
335
336          Some parts of the code passed arguments as
337          "actual, expected" and some passed as "expected, actual".
338          As you might imagine, this lead to great confusion and wrongness.
339          Standardize on "expected, actual" as that's the order which is
340          passed to the underlying diff tool.
341
342          Based on a patch by Eric Siedel <eric@webkit.org>.
343
344          * Scripts/webkitpy/layout_tests/port/base.py:
345          * Scripts/webkitpy/layout_tests/port/chromium.py:
346          * Scripts/webkitpy/layout_tests/port/test.py:
347          * Scripts/webkitpy/layout_tests/test_types/image_diff.py
348
349 2010-03-01  Chris Jerdonek  <cjerdonek@webkit.org>
350
351         Unreviewed.
352
353         Rolling out: http://trac.webkit.org/changeset/55348
354
355         https://bugs.webkit.org/show_bug.cgi?id=35163
356
357         Rolling out since the changes to autoinstall do not work
358         with Python 2.4. In particular, ZipFile.extractall() was
359         added in Python 2.6.
360
361         * Scripts/webkitpy/__init__.py:
362         * Scripts/webkitpy/bugzilla.py:
363         * Scripts/webkitpy/init/__init__.py: Removed.
364         * Scripts/webkitpy/init/autoinstall.py: Removed.
365         * Scripts/webkitpy/networktransaction.py:
366         * Scripts/webkitpy/networktransaction_unittest.py:
367         * Scripts/webkitpy/statusserver.py:
368         * Scripts/webkitpy/thirdparty/autoinstall.py: Added.
369
370 2010-03-01  Chris Jerdonek  <cjerdonek@webkit.org>
371
372         Unreviewed.
373
374         Rolling out r55350: http://trac.webkit.org/changeset/55350
375
376         https://bugs.webkit.org/show_bug.cgi?id=33639
377
378         Need to roll out because this patch (pep8) depends on the newly
379         rewritten autoinstall.py (r55348), which is breaking for people
380         with Python 2.4:
381
382         https://bugs.webkit.org/show_bug.cgi?id=35163#c21
383
384         That revision also needs to be rolled out and will be rolled out next.
385
386         * Scripts/webkitpy/style/checker.py:
387         * Scripts/webkitpy/style/checker_unittest.py:
388         * Scripts/webkitpy/style/processors/python.py: Removed.
389         * Scripts/webkitpy/style/processors/python_unittest.py: Removed.
390         * Scripts/webkitpy/style/processors/python_unittest_input.py: Removed.
391         * Scripts/webkitpy/style/unittests.py:
392         * Scripts/webkitpy/style_references.py:
393
394 2010-02-28  Chris Jerdonek  <cjerdonek@webkit.org>
395
396         Reviewed by Shinichiro Hamaji.
397
398         Exempted WebKitTools/Scripts/webkitpy/thirdparty from all
399         style checks except for the whitespace/carriage_return check
400         and the pep8 tab and trailing white space checks.
401
402         https://bugs.webkit.org/show_bug.cgi?id=35497
403
404         * Scripts/webkitpy/style/checker.py:
405           - Adjusted the _PATH_RULES_SPECIFIER configuration as necessary.
406           - Added enough pep8 categories to _all_categories() for the
407             unit tests to pass.
408
409         * Scripts/webkitpy/style/checker_unittest.py:
410           - Updated the test_path_rules_specifier() unit test.
411
412 2010-02-27  Chris Jerdonek  <cjerdonek@webkit.org>
413
414         Reviewed by David Levin.
415
416         Added Python style checking to check-webkit-style using
417         the third-party pep8 module (via autoinstall).
418
419         https://bugs.webkit.org/show_bug.cgi?id=33639
420
421         * Scripts/webkitpy/style/checker.py:
422           - Added PYTHON to FileType.
423           - Updated ProcessorDispatcher to return a PythonProcessor
424             for *.py files.
425
426         * Scripts/webkitpy/style/checker_unittest.py:
427           - Updated the ProcessorDispatcher unit tests for *.py files.
428
429         * Scripts/webkitpy/style/processors/python.py: Added.
430           - Added PythonProcessor class.
431
432         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
433           - Added PythonProcessor unit tests.
434
435         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
436           - Added a sample Python file to test the PythonProcessor.process()
437             code path (since pep8 accepts a file path).
438
439         * Scripts/webkitpy/style/unittests.py:
440           - Updated the style unit test file to import python_unittest.py.
441
442         * Scripts/webkitpy/style_references.py:
443           - Adjusted style references to import pep8.
444
445 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
446
447         Reviewed by David Levin.
448
449         Rewrote autoinstall.py to support unzipping *.zip files after
450         download, unzipping and extracting *.tar.gz files after download,
451         and copying installed files to a destination directory.
452
453         https://bugs.webkit.org/show_bug.cgi?id=35163
454
455         These changes will allow us to autoinstall pep8.py from the web
456         and to put our third-party autoinstalled code in an explicit
457         directory like webkitpy/thirdparty/autoinstalled. They should
458         also speed up imports from autoinstalled *.zip packages slightly
459         since *.pyc files cannot be generated when importing from
460         zipped packages.
461
462         * Scripts/webkitpy/__init__.py:
463           - Updated the autoinstall lines to use the new autoinstall methods.
464           - Added pep8.py to the list of auto-installed packages.
465
466         * Scripts/webkitpy/bugzilla.py:
467           - Updated mechanize import path.
468
469         * Scripts/webkitpy/init/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
470
471         * Scripts/webkitpy/init/autoinstall.py: Added.
472           - Added AutoInstaller class.
473           - Added sample testing usage to __main__.
474
475         * Scripts/webkitpy/networktransaction.py:
476           - Updated mechanize import path.
477
478         * Scripts/webkitpy/networktransaction_unittest.py:
479           - Updated mechanize import path.
480
481         * Scripts/webkitpy/statusserver.py:
482           - Updated mechanize import path.
483
484         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
485           - Replaced with rewritten autoinstall in init/autoinstall.py.
486
487 2010-02-26  Dirk Pranke  <dpranke@chromium.org>
488
489         Reviewed by Adam Barth.
490
491         Change the default port for new-run-webkit-tests when running on
492         a Mac from 'chromium-mac' to 'mac'. Add a '--chromium' switch to
493         pick up the default platform-specific version of chromium instead.
494
495         https://bugs.webkit.org/show_bug.cgi?id=35462
496
497         * Scripts/webkitpy/layout_tests/port/factory.py:
498         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
499
500 2010-02-26  Dirk Pranke  <dpranke@chromium.org>
501
502         Unreviewed, build fix
503
504         third time's the charm getting this path right?
505
506         * pywebsocket/mod_pywebsocket/standalone.py:
507
508 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
509
510         Unreviewed, build fix.
511
512         * pywebsocket/mod_pywebsocket/standalone.py:
513
514 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
515
516         Reviewed by Dimitri Glazkov.
517
518         Moving the script to the right location.
519
520         * pywebsocket/mod_pywebsocket: Added.
521         * pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
522         * pywebsocket/standalone.py: Removed.
523
524 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
525
526         Unreviewed, fixing the license.
527
528         * pywebsocket/standalone.py:
529
530 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
531
532         Reviewed by Adam Barth.
533
534         Adding pywebsocket/standalone.py back to fix the Chromium webkit
535         canaries. Once all layout tests pass, we can get in the patch that
536         moves this directorty to WebKitTools/Scripts, update all Chromium
537         scripts, and revert this patch.
538
539         https://bugs.webkit.org/show_bug.cgi?id=35464
540
541         * pywebsocket: Added.
542         * pywebsocket/standalone.py: Added.
543
544 2010-02-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
545
546         Reviewed by Xan Lopez.
547
548         [GTK] Needs proper reporting of frame loader callbacks, in DRT
549         https://bugs.webkit.org/show_bug.cgi?id=32170
550
551         Fix reporting of unload handlers, so that it is emitted where
552         needed, not after it.
553
554         * DumpRenderTree/gtk/DumpRenderTree.cpp:
555         (webViewLoadFinished):
556         (webViewDocumentLoadFinished):
557         (createWebView):
558
559 2010-02-26  Antonio Gomes  <tonikitoo@webkit.org>
560
561         Reviewed by Gustavo Noronha.
562         Patch by Antonio Gomes <tonikitoo@webkit.org>
563
564         [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
565         https://bugs.webkit.org/show_bug.cgi?id=35432
566
567         When a directional key-press event (arrow keys, End, Home, PageUp,
568         PageDown, etc) is synthesized by DRT's EventSender and it targets
569         an editor (e.g. <input type=text>, <textare>, etc), event is processed
570         by WebCore::EventHandler. On the other hand, if event target is not
571         an editor, event is bubbled up to Gtk+ for processing. In such cases,
572         if 'hardware_keycode' is not provided at event synthesize time
573         its processing fails (at some point in gtk_bindings_activate_event),
574         and no scroll action is performed.
575
576         Unskip fast/events/node-event-anchor-lock.html
577
578         * DumpRenderTree/win/EventSender.cpp:
579         (keyDownCallback):
580         * platform/gtk/Skipped:
581
582 2010-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
583
584         Reviewed by David Levin.
585
586         new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
587         https://bugs.webkit.org/show_bug.cgi?id=35436
588
589          * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
590
591 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
592
593         Reviewed by David Levin.
594
595         Moved pywebsocket into the webkitpy/thirdparty directory and added
596         an associated README.webkit file to the pywebsocket directory.
597         This makes pywebsocket more consistent with the other third-party
598         Python code in our repository.
599
600         https://bugs.webkit.org/show_bug.cgi?id=35198
601
602         * Scripts/run-webkit-tests:
603           - Updated paths to pywebsocket.
604
605         * Scripts/run-webkit-websocketserver:
606           - Updated paths to pywebsocket.
607
608         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
609           - Updated paths to pywebsocket.
610
611         * Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
612         * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
613           - Added a file containing information about the contents
614             of the pywebsocket directory. This will make it easier to
615             understand where the third-party code came from and what
616             local changes have been made.
617
618         * pywebsocket: Removed.
619         * pywebsocket/COPYING: Removed.
620         * pywebsocket/MANIFEST.in: Removed.
621         * pywebsocket/README: Removed.
622         * pywebsocket/example: Removed.
623         * pywebsocket/example/echo_client.py: Removed.
624         * pywebsocket/example/echo_wsh.py: Removed.
625         * pywebsocket/mod_pywebsocket: Removed.
626         * pywebsocket/mod_pywebsocket/__init__.py: Removed.
627         * pywebsocket/mod_pywebsocket/dispatch.py: Removed.
628         * pywebsocket/mod_pywebsocket/handshake.py: Removed.
629         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
630         * pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
631         * pywebsocket/mod_pywebsocket/msgutil.py: Removed.
632         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
633         * pywebsocket/mod_pywebsocket/util.py: Removed.
634         * pywebsocket/setup.py: Removed.
635         * pywebsocket/test: Removed.
636         * pywebsocket/test/config.py: Removed.
637         * pywebsocket/test/mock.py: Removed.
638         * pywebsocket/test/run_all.py: Removed.
639         * pywebsocket/test/test_dispatch.py: Removed.
640         * pywebsocket/test/test_handshake.py: Removed.
641         * pywebsocket/test/test_memorizingfile.py: Removed.
642         * pywebsocket/test/test_mock.py: Removed.
643         * pywebsocket/test/test_msgutil.py: Removed.
644         * pywebsocket/test/test_util.py: Removed.
645         * pywebsocket/test/testdata: Removed.
646         * pywebsocket/test/testdata/handlers: Removed.
647         * pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
648         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
649         * pywebsocket/test/testdata/handlers/sub: Removed.
650         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
651         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
652         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
653         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
654         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
655         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
656
657 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
658
659         Reviewed by Eric Seidel.
660
661         Changed the diff_parser module to log to a module-specific
662         logging.logger rather than the root logger.
663
664         https://bugs.webkit.org/show_bug.cgi?id=35391
665
666         * Scripts/webkitpy/diff_parser.py:
667
668 2010-02-26  Csaba Osztrogonác  <ossy@webkit.org>
669
670         Reviewed by Kenneth Rohde Christiansen.
671
672         [Qt] LayoutTestController.numberOfPages() should have default parameters
673         https://bugs.webkit.org/show_bug.cgi?id=35428
674
675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to
676         LayoutTestController to converge to platform independent implementation.
677         (WebCore::DumpRenderTree::DumpRenderTree):
678         (WebCore::DumpRenderTree::open):
679         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
680         * DumpRenderTree/qt/LayoutTestControllerQt.h:
681          - Default parameters for LayoutTestController.numberOfPages() added.
682          - maxViewWidth and maxViewHeight members added.
683
684 2010-02-26  Jamey Hicks  <jamey.hicks@nokia.com>
685
686         Reviewed by Laszlo Gombos.
687
688         [Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
689
690         Enables the use of alternate Web Inspector frontends by changing
691         the location of the frontend. The location is specified by providing 
692             -inspector-url url
693         as an argument to QtLauncher.
694
695         This is required so that the Web Inspector may be run from an
696         external process or an external tool such as Eclipse or Aptana may
697         be used instead of the in-process Web Inspector UI.
698         
699         https://bugs.webkit.org/show_bug.cgi?id=35340
700
701         * QtLauncher/main.cpp:
702         (LauncherWindow::init):
703         (LauncherApplication::handleUserOptions):
704
705 2010-02-25  Dirk Pranke  <dpranke@chromium.org>
706
707         Reviewed by Eric Seidel.
708
709         Add a 'passing' port implementation to new-run-webkit-tests that
710         acts as a wrapper around an existing implementation but stubs out
711         the actual test invocations (instead, the expected results are echoed
712         back to the harness). This is useful for coverage and perf testing
713         of the harness (especially perf testing as it essentially provides
714         a lower bound on how fast the harness can run).
715
716         Also added a --nostart-helper flag to new-run-webkit-tests so that
717         you can skip starting the layout_test_helper and actually run the
718         harness even if you don't have a build of that port.
719
720         Also fix a bug in the 'test' port implementation to actually
721         create the results directory under /tmp instead of /.
722
723         https://bugs.webkit.org/show_bug.cgi?id=35370
724
725         * Scripts/webkitpy/layout_tests/port/factory.py: Modified.
726         * Scripts/webkitpy/layout_tests/port/passing.py: Added.
727         * Scripts/webkitpy/layout_tests/port/test.py: Added.
728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
729
730 2010-02-25  Eric Seidel  <eric@webkit.org>
731
732         Fix typo in my last change.  No review.
733
734         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
735         https://bugs.webkit.org/show_bug.cgi?id=35408
736
737         * Scripts/new-run-webkit-tests:
738
739 2010-02-25  Eric Seidel  <eric@webkit.org>
740
741         Reviewed by Adam Barth.
742
743         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
744         https://bugs.webkit.org/show_bug.cgi?id=35408
745
746         * Scripts/new-run-webkit-tests: Added.
747         * Scripts/run-chromium-webkit-tests: Removed.
748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
749
750 2010-02-25  Adam Barth  <abarth@webkit.org>
751
752         Reviewed by David Levin.
753
754         EWS leaks memory slowly
755         https://bugs.webkit.org/show_bug.cgi?id=35395
756
757         The EWS bots leak memory very slowly.  If you run them for about a
758         month, each one will take up around 1 GB of virutal memory.  If you run
759         several of them on one machine, you'll eventually exhaust all available
760         memory and grind the bots to a halt.
761
762         This patch introduces a --exit-after-iteration option to the queues so
763         that we run them for a finite amount of time.  Once they exit and
764         restart, they'll reclaim the leaked memory.  I'm not sure how many
765         iterations I'll end up running them for.  I'll need to sort that out
766         operationally, but my initial guess is around 1000.
767
768         * Scripts/webkitpy/commands/queues.py:
769         * Scripts/webkitpy/commands/queues_unittest.py:
770
771 2010-02-25  Jarkko Sakkinen  <jarkko.sakkinen@tieto.com>
772
773         Reviewed by Kenneth Rohde Christiansen.
774
775         Qt WebGL support
776
777         Adds toggling of WebGL support to QtLauncher.
778         https://bugs.webkit.org/show_bug.cgi?id=35153
779
780         * QtLauncher/main.cpp:
781         (LauncherWindow::toggleWebGL):
782         (LauncherWindow::setupUI):
783
784 2010-02-25  Ben Murdoch  <benm@google.com>
785
786         Reviewed by Kenneth Rohde Christiansen.
787
788         The target element of a Touch should be the target where that touch originated, not where it is now.
789         https://bugs.webkit.org/show_bug.cgi?id=34585
790
791         * DumpRenderTree/qt/EventSenderQt.cpp:
792         (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
793
794 2010-02-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
795
796         Reviewed by Kenneth Rohde Christiansen.
797
798         [Qt] QtLauncher has a border when running on QGraphicsView mode
799         https://bugs.webkit.org/show_bug.cgi?id=35352
800
801         Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.
802
803         * QtLauncher/webview.cpp:
804         (WebViewGraphicsBased::WebViewGraphicsBased):
805
806 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
807
808         Reviewed by David Levin.
809
810         When the run-chromium-webkit-tests code was landed and the code was
811         refactored into the 'port' package, I accidentally broke using
812         http_server.py or websocket_server.py as command-line scripts
813         (the constructors needed a port object they weren't getting). This
814         change fixes them so that --server start|stop actually works.
815
816         As a part of this, the two files need to be able to call port.get(),
817         but doing that is awkward from a file inside the package, so I moved
818         get() into factory.py and imported that into __init__.py so that
819         http_server.py and websocket_server.py can just import factory.
820
821         https://bugs.webkit.org/show_bug.cgi?id=35316
822
823         * Scripts/webkitpy/layout_tests/port/__init__.py:
824         * Scripts/webkitpy/layout_tests/port/factory.py:
825         * Scripts/webkitpy/layout_tests/port/http_server.py:
826         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
827
828 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
829
830         Reviewed by David Levin.
831
832         Fix the function signature for check_sys_deps on the mac port, and
833         fix the ordering of port_obj.check_sys_deps() and
834         port_obj.start_helper() (helper needs to be started before we check
835         the system configuration).
836
837         http://bugs.webkit.org/show_bug.cgi?id=35367
838
839         * Scripts/webkitpy/layout_tests/port/mac.py:
840         * Scripts/webkitpy/layout_tests/port/test.py:
841         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
842
843 2010-02-24  James Robinson  <jamesr@chromium.org>
844
845         Reviewed by Eric Seidel.
846
847         Provide default username parameter to SVN.commit_with_message().
848
849         * Scripts/webkitpy/scm.py:
850
851 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
852
853         Reviewed by Eric Siedel.
854
855         Check the proper directory for a WebKit SVN version (Chromium does
856         not check out the entire WebKit tree directly, but rather pulls
857         individual subdirectories. So, checking for the SVN version in
858         WebKit/WebCore rather than just in WebKit works more reliably across
859         different ports).
860
861         http://bugs.webkit.org/show_bug.cgi?id=35321
862
863         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
864
865 2010-02-24  Alexey Proskuryakov  <ap@apple.com>
866
867         Reviewed by Dan Bernstein.
868
869         https://bugs.webkit.org/show_bug.cgi?id=35357
870         Two editing tests fail after DumpRenderTree run loop changes
871
872         AppKit decided that it wanted to group all editing commands for some reason (and thus undo
873         reverted them all at once).
874
875         * DumpRenderTree/mac/DumpRenderTree.mm:
876         (dump): Reverted the change that made DumpRenderTree use -[NSApplication run].
877         (runTest): Ditto.
878         (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always
879         returns YES. This is another way to make the Java plug-in work.
880
881 2010-02-23  Adam Roben  <aroben@apple.com>
882
883         Make commit-log-editor find just-added ChangeLog files
884
885         Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find
886         just-added ChangeLog files
887
888         Reviewed by Dave Levin.
889
890         * Scripts/commit-log-editor:
891         (top level): Modified the regular expression that's used to find
892         modified ChangeLog files to also look for just-added ChangeLog files.
893
894 2010-02-24  Shinichiro Hamaji  <hamaji@chromium.org>
895
896         Reviewed by Darin Adler.
897
898         check-webkit-style false positive for WebCore forwarding header
899         https://bugs.webkit.org/show_bug.cgi?id=34604
900
901         * Scripts/webkitpy/style/checker.py:
902         * Scripts/webkitpy/style/checker_unittest.py:
903
904 2010-02-23  Alexey Proskuryakov  <ap@apple.com>
905
906         Reviewed by Mark Rowe.
907
908         https://bugs.webkit.org/show_bug.cgi?id=22602
909         Enable Java in DumpRenderTree (on Mac)
910
911         * DumpRenderTree/mac/DumpRenderTree.mm:
912         (exitApplicationRunLoop):
913         (dump):
914         (runTest):
915         DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in
916         can start without freezing.
917
918         * Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
919
920 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
921
922         Reviewed by Kenneth Rohde Christiansen.
923
924         [Qt] Need a final integration between QtLauncher and QGVLauncher
925         https://bugs.webkit.org/show_bug.cgi?id=35292
926
927         WebKit coding style fixes.
928
929         * QtLauncher/main.cpp:
930         (LauncherWindow::resetZoom):
931
932 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
933
934         Reviewed by Kenneth Rohde Christiansen.
935
936         [Qt] Need a final integration between QtLauncher and QGVLauncher
937         https://bugs.webkit.org/show_bug.cgi?id=35292
938
939         Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
940
941         * QtLauncher/main.cpp:
942         (LauncherWindow::LauncherWindow):
943         (LauncherWindow::~LauncherWindow):
944         (LauncherWindow::init):
945         (LauncherWindow::cloneWindow):
946         (LauncherWindow::setupUI):
947
948 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
949
950         Reviewed by Dimitri Glazkov.
951
952         Fix handling of check_wdiff_install when wdiff isn't installed.
953
954         http://bugs.webkit.org/show_bug.cgi?id=35304
955
956         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
957
958 2010-02-23  Leandro Pereira  <leandro@profusion.mobi>
959
960         Reviewed by NOBODY.
961
962         Fix false positives for 'delete *pointer' statements.
963         http://webkit.org/b/35235
964
965         * WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
966
967 2010-02-23  Shinichiro Hamaji  <hamaji@chromium.org>
968
969         Reviewed by Eric Seidel.
970
971         [Gtk] Implement layoutTestController.numberOfPages
972         https://bugs.webkit.org/show_bug.cgi?id=35228
973
974         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
975         (LayoutTestController::numberOfPages):
976
977 2010-02-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
978
979         Reviewed by Kenneth Rohde Christiansen.
980
981         [Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
982         https://bugs.webkit.org/show_bug.cgi?id=35248
983
984         * QtLauncher/QtLauncher.pro:
985         * QtLauncher/utils.h:
986
987 2010-02-23  Daniel Bates  <dbates@rim.com>
988
989         Reviewed by Eric Seidel.
990
991         https://bugs.webkit.org/show_bug.cgi?id=34439
992
993         Prompts a person for their SVN username if not already cached (by Subversion).
994
995         Currently, webkit-patch is unable to commit to the SVN repo. unless the
996         WebKit SVN username is already cached (from of a prior commit by hand)
997         because "svn commit" (called by webkit-patch) defaults to using the system
998         login name unless the username is already cached or specified on the
999         command line.
1000
1001         * Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and
1002         modified SVN.commit_with_message to call it. Added optional username parameter
1003         to method SVN.commit_with_message.
1004         * Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username,
1005         SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
1006
1007 2010-02-22  Dirk Pranke  <dpranke@chromium.org>
1008
1009         Reviewed by Eric Siedel.
1010
1011         Add more checking for missing binaries and packages to check_sys_deps()
1012
1013         https://bugs.webkit.org/show_bug.cgi?id=35062
1014
1015         * Scripts/webkitpy/layout_tests/port/base.py:
1016         * Scripts/webkitpy/layout_tests/port/chromium.py:
1017         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1018         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1019         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1020         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1021
1022 2010-02-22  Shinichiro Hamaji  <hamaji@chromium.org>
1023
1024         Reviewed by David Levin.
1025
1026         [Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
1027         https://bugs.webkit.org/show_bug.cgi?id=35229
1028
1029         * Scripts/webkitpy/style/checker.py:
1030         * Scripts/webkitpy/style/checker_unittest.py:
1031
1032 2010-02-22  James Robinson  <jamesr@chromium.org>
1033
1034         Unreviewed. Adding myself to committers list.
1035
1036         * Scripts/webkitpy/committers.py:
1037
1038 2010-02-22  Simon Fraser  <simon.fraser@apple.com>
1039
1040         Reviewed by Darin Adler.
1041
1042         Remove DRT hack that turns off hardware acceleration with older QuickTimes
1043         https://bugs.webkit.org/show_bug.cgi?id=35275
1044         
1045         Now that WebKit does a version check to avoid a QuickTime-related
1046         crash (r55100), DumpRenderTree does not need to.
1047
1048         * DumpRenderTree/mac/DumpRenderTree.mm:
1049         (resetDefaultsToConsistentValues):
1050
1051 2010-02-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1052
1053         Reviewed by Kenneth Rohde Christiansen.
1054
1055         [Qt] Build the DRT in debug on Mac OS X
1056
1057         * DumpRenderTree/qt/DumpRenderTree.pro:
1058
1059 2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1060
1061         Reviewed by Kenneth Rohde Christiansen.
1062
1063         [Qt] Add support for layout tests on Symbian
1064         https://bugs.webkit.org/show_bug.cgi?id=31589
1065
1066         * DumpRenderTree/qt/DumpRenderTree.pro:
1067         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1068         * DumpRenderTree/qt/main.cpp:
1069         (main):
1070
1071 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
1072
1073         Reviewed by Adam Barth.
1074
1075         Moved simplejson into webkitpy/thirdparty directory.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=35196
1078
1079         * Scripts/run-chromium-webkit-tests:
1080           - Added webkitpy/thirdparty to the script's search path.
1081
1082         * Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
1083           - Copied simplejson directory.
1084
1085         * simplejson: Removed.
1086         * simplejson/LICENSE.txt: Removed.
1087         * simplejson/README.txt: Removed.
1088         * simplejson/__init__.py: Removed.
1089         * simplejson/_speedups.c: Removed.
1090         * simplejson/decoder.py: Removed.
1091         * simplejson/encoder.py: Removed.
1092         * simplejson/jsonfilter.py: Removed.
1093         * simplejson/scanner.py: Removed.
1094
1095 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
1096
1097         Reviewed by Adam Barth.
1098
1099         Moved BeautifulSoup to webkitpy/thirdparty directory.
1100
1101         https://bugs.webkit.org/show_bug.cgi?id=35195
1102
1103         * Scripts/webkitpy/BeautifulSoup.py: Removed.
1104           - Moved to webkitpy/thirdparty.
1105
1106         * Scripts/webkitpy/bugzilla.py:
1107           - Updated import statement.
1108
1109         * Scripts/webkitpy/bugzilla_unittest.py:
1110           - Updated import statement.
1111
1112         * Scripts/webkitpy/buildbot.py:
1113           - Updated import statement.
1114
1115         * Scripts/webkitpy/buildbot_unittest.py:
1116           - Updated import statement.
1117
1118         * Scripts/webkitpy/statusserver.py:
1119           - Updated import statement.
1120
1121         * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
1122
1123 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
1124
1125         Reviewed by Adam Barth.
1126
1127         Created a directory for third-party Python code, and moved
1128         autoinstall.py into it.
1129
1130         https://bugs.webkit.org/show_bug.cgi?id=34540
1131
1132         * Scripts/webkitpy/__init__.py:
1133           - Updated "import autoinstall" statement.
1134
1135         * Scripts/webkitpy/autoinstall.py: Removed.
1136           - Moved to thirdparty/autoinstall.py.
1137
1138         * Scripts/webkitpy/thirdparty: Added.
1139         * Scripts/webkitpy/thirdparty/__init__.py: Added.
1140         * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
1141
1142 2010-02-20  Gustavo Noronha Silva  <gns@gnome.org>
1143
1144         Unreviewed, obvious fix for the python failure in our new buildbot
1145         step:
1146
1147         http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
1148
1149         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1150
1151 2010-02-19  Maciej Stachowiak  <mjs@apple.com>
1152
1153         Reviewed by David Levin.
1154
1155         Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
1156         https://bugs.webkit.org/show_bug.cgi?id=35147
1157
1158         * Scripts/build-webkit: Handle new flag.
1159
1160 2010-02-19  Leandro Pereira  <leandro@profusion.mobi>
1161
1162         Reviewed by Shinichiro Hamaji.
1163
1164         [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
1165         https://bugs.webkit.org/show_bug.cgi?id=35091
1166
1167         White list unix_hacker_style names in WebKit/efl/ewk because these
1168         are used in the EFL API.
1169
1170         * Scripts/webkitpy/style/checker.py:
1171          - Filter out readability/naming on WebKit/efl/ewk.
1172
1173 2010-02-19  Eric Seidel  <eric@webkit.org>
1174
1175         Reviewed by Adam Barth.
1176
1177         Split out "prepare-rollout" from "rollout" and make --complete-rollout default
1178         https://bugs.webkit.org/show_bug.cgi?id=33745
1179
1180         * Scripts/webkitpy/commands/download.py:
1181          - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
1182          - Add PrepareRollout
1183         * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
1184         * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step.
1185         * Scripts/webkitpy/steps/completerollout.py: Removed.
1186         * Scripts/webkitpy/steps/options.py: remove complete_rollout
1187         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
1188
1189 2010-02-19  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1190
1191         Reviewed by Kenneth Rohde Christiansen.
1192
1193         [Qt] Need a final integration between QtLauncher and QGVLauncher
1194         https://bugs.webkit.org/show_bug.cgi?id=35161
1195
1196         Add animated flip support to QtLauncher when running on QGraphicsView mode.
1197
1198         * QtLauncher/main.cpp:
1199         (LauncherWindow::initializeView):
1200         (LauncherWindow::setupUI):
1201         * QtLauncher/webview.cpp:
1202         (WebViewGraphicsBased::WebViewGraphicsBased):
1203         (WebViewGraphicsBased::animatedFlip):
1204         (WebViewGraphicsBased::animatedYFlip):
1205         * QtLauncher/webview.h:
1206         (WebViewGraphicsBased::setYRotation):
1207         (WebViewGraphicsBased::yRotation):
1208
1209 2010-02-19  Andras Becsi  <abecsi@webkit.org>
1210
1211         Reviewed by Kenneth Rohde Christiansen.
1212
1213         [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
1214         for passing new tests and unskip the passing ones from the Skipped list.
1215         https://bugs.webkit.org/show_bug.cgi?id=35159
1216
1217         * DumpRenderTree/qt/EventSenderQt.cpp:
1218         (EventSender::textZoomIn):
1219         (EventSender::textZoomOut):
1220         * DumpRenderTree/qt/EventSenderQt.h:
1221
1222 2010-02-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1223
1224         Reviewed by Eric Seidel.
1225
1226         [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
1227         https://bugs.webkit.org/show_bug.cgi?id=35004
1228
1229         DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up 
1230         and enables all HTML5 persistent data. All the other calls for setting the 
1231         persistent path or enabling the persistent feature are redundant. 
1232
1233         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1234         (WebCore::WebPage::WebPage): No need to enable AppCache again.
1235         * DumpRenderTree/qt/main.cpp:
1236         (main): No need to setup and enable HTML5 LocalStorage again.
1237
1238 2010-02-19  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1239
1240         Reviewed by Kenneth Rohde Christiansen.
1241
1242         Send the context menu event from contextClick() of EventSender
1243         and do not show context menu in DRT.
1244
1245         LayoutTests:
1246             fast/events/contextmenu-scrolled-page-with-frame.html
1247
1248         [Qt] DRT: Send context menu event from EventSender
1249         https://bugs.webkit.org/show_bug.cgi?id=35131
1250
1251         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1252         (WebCore::DumpRenderTree::DumpRenderTree):
1253         * DumpRenderTree/qt/EventSenderQt.cpp:
1254         (EventSender::contextClick):
1255
1256 2010-02-18  Chris Jerdonek  <cjerdonek@webkit.org>
1257
1258         Reviewed by Shinichiro Hamaji.
1259
1260         Moved parsing-related code to a separate file. Also increased
1261         the unit test coverage in some affected areas.
1262
1263         https://bugs.webkit.org/show_bug.cgi?id=34675
1264
1265         This revision contains no new functionality.
1266
1267         * Scripts/check-webkit-style:
1268           - Adjusted to call check_webkit_style_parser().
1269
1270         * Scripts/webkitpy/style/checker.py:
1271           - Added check_webkit_style_parser() to pass checker.py
1272             configuration settings to optparser.py.
1273           - Moved _create_usage() and the CommandOptionValues,
1274             DefaultCommandOptionValues, ArgumentPrinter, and
1275             ArgumentParser classes to optparser.py.
1276
1277         * Scripts/webkitpy/style/checker_unittest.py:
1278           - Moved the ProcessorOptionsTest, ArgumentPrinterTest, and
1279             ArgumentParserTest classes to optparser.py.
1280           - Added the CheckWebKitStyleFunctionTest class to check
1281             the check_webkit_style_configuration() and
1282             check_webkit_style_parser() code paths.
1283
1284         * Scripts/webkitpy/style/optparser.py: Added.
1285           - From checker.py, added _create_usage() and the
1286             CommandOptionValues, DefaultCommandOptionValues,
1287             ArgumentPrinter, and ArgumentParser classes.
1288           - In the ArgumentParser constructor--
1289             - Added all_categories as a required parameter.
1290             - Removed the default value from the default_options parameter.
1291
1292         * Scripts/webkitpy/style/optparser_unittest.py: Added.
1293           - From checker_unittest.py, added the ProcessorOptionsTest,
1294             ArgumentPrinterTest, and ArgumentParserTest classes.
1295           - Added the CreateUsageTest class to test _create_usage().
1296
1297         * Scripts/webkitpy/style/unittests.py:
1298           - Added optparser_unittest import.
1299
1300 2010-02-18  Alexey Proskuryakov  <ap@apple.com>
1301
1302         Reviewed by Dan Bernstein.
1303
1304         https://bugs.webkit.org/show_bug.cgi?id=35134
1305         <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
1306
1307         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1308         (testSetStatus):
1309         (pluginInvoke):
1310         Added a setStatus() method.
1311
1312 2010-02-18  Brady Eidson  <beidson@apple.com>
1313
1314         Reviewed by Sam Weinig.
1315
1316         Particularly constructed WebFrames can try to access a null HistoryItem
1317         <rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
1318
1319         Add the specific ability to test this API pattern. 
1320
1321         For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.
1322
1323         * DumpRenderTree/LayoutTestController.cpp:
1324         (apiTestNewWindowDataLoadBaseURLCallback):
1325         (LayoutTestController::staticFunctions):
1326         * DumpRenderTree/LayoutTestController.h:
1327
1328         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1329         (-[APITestDelegate initWithCompletionCondition:]):
1330         (-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
1331         (-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1332         (-[APITestDelegate webView:didFinishLoadForFrame:]):
1333         (LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its
1334           mainFrame, and synchronously wait for main load completion.
1335
1336         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1337         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1338         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1339         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1340         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1341         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
1342
1343 2010-02-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1344
1345         Reviewed by Eric Seidel.
1346
1347         Teach resolve-ChangeLogs to act as a merge-driver for Git
1348
1349         https://bugs.webkit.org/show_bug.cgi?id=28721
1350
1351         To enable automatic merging of ChangeLog files, use the following command:
1352
1353         git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
1354
1355         The driver always works in "downstream" merge mode, meaning
1356         it will always put the user's changelog entries on top.
1357
1358         * Scripts/resolve-ChangeLogs:
1359
1360 2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>
1361
1362         Reviewed by Eric Seidel.
1363
1364         Enable running of GTK+ API tests.
1365
1366         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1367         * Scripts/run-gtk-tests: Added.
1368
1369 2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>
1370
1371         Reviewed by Adam Barth.
1372
1373         debug-safari doesn't pass --debug option to gdb-safari on MacOSX
1374         https://bugs.webkit.org/show_bug.cgi?id=34411
1375
1376         * Scripts/webkitdirs.pm:
1377
1378 2010-02-18  Eric Seidel  <eric@webkit.org>
1379
1380         Reviewed by Adam Barth.
1381
1382         run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
1383         https://bugs.webkit.org/show_bug.cgi?id=35053
1384
1385         * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
1386         * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
1387         * Scripts/webkitpy/layout_tests/port/mac.py:
1388          - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
1389          - Call build-dumprendertree (and make sure it succeeds) before running the tests.
1390
1391 2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>
1392
1393         Reviewed by Shinichiro Hamaji.
1394
1395         Refactored check-webkit-style's ProcessorOptions class into two
1396         classes. This revision contains no new functionality.
1397
1398         https://bugs.webkit.org/show_bug.cgi?id=34674
1399
1400         Divided the ProcessorOptions class into a CommandOptionValues
1401         class (the result of parsing the command-line options) and
1402         a StyleCheckerConfiguration class (which configures the main
1403         StyleChecker).
1404
1405         * Scripts/check-webkit-style:
1406           - Updated main() to convert the parsed command option values
1407             to a StyleCheckConfiguration instance prior to constructing
1408             a StyleChecker.
1409
1410         * Scripts/webkitpy/style/checker.py:
1411           - Added check_webkit_style_configuration() to convert a
1412             CommandOptionValues instance into a StyleCheckerConfiguration
1413             instance.
1414           - Renamed the ProcessorOptions class to CommandOptionValues.
1415           - In the CommandOptionValues class--
1416             - Replaced the filter_configuration attribute with the
1417               simpler filter_rules attribute.
1418             - Removed the max_reports_per_error attribute.
1419             - Moved the is_reportable() method to the new
1420               StyleCheckerConfiguration class.
1421           - Removed the base_filter_rules attribute from the
1422             DefaultCommandOptionValues class.
1423           - In the ArgumentParser class--
1424             - Added base_filter_rules to the constructor.
1425             - Changed the parse() method to return a CommandOptionValues
1426               instance instead of a ProcessorOptions instance.
1427           - Created a StyleCheckerConfiguration class.
1428             - Added the data attributes max_reports_per_category,
1429               stderr_write, and verbosity.
1430             - Added is_reportable() (moved from the ProcessorOptions
1431               class) and write_style_error() (moved from the
1432               DefaultStyleErrorHandler class).
1433           - In the StyleChecker class--
1434             - Replaced the ProcessorOptions options attribute with the
1435               StyleCheckerConfiguration _configuration attribute.
1436             - Removed the _stderr_write attribute.
1437
1438         * Scripts/webkitpy/style/checker_unittest.py:
1439           - Updated the existing unit test classes as necessary.
1440           - Added a StyleCheckerConfigurationTest class.
1441
1442         * Scripts/webkitpy/style/error_handlers.py:
1443           - Updated the DefaultStyleErrorHandler class to accept a
1444             StyleCheckerConfiguration instance instead of a ProcessorOptions
1445             instance and an stderr_write method.
1446
1447         * Scripts/webkitpy/style/error_handlers_unittest.py:
1448           - Updated the unit test classes as necessary.
1449
1450         * Scripts/webkitpy/style/filter.py:
1451           - Addressed the FIXME in the FilterConfiguration class to change
1452             the user_rules attribute to _user_rules (since it is now
1453             accessed only internally).
1454
1455         * Scripts/webkitpy/style/filter_unittest.py:
1456           - Updated to reflect the change from user_rules to _user_rules.
1457
1458 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1459
1460         Reviewed by Eric Seidel.
1461
1462         Share the DRT values maxViewWidth/Height among ports
1463         https://bugs.webkit.org/show_bug.cgi?id=34474
1464
1465         * DumpRenderTree/LayoutTestController.cpp:
1466         (pageNumberForElementByIdCallback):
1467         * DumpRenderTree/LayoutTestController.h:
1468         (LayoutTestController::maxViewWidth):
1469         (LayoutTestController::maxViewHeight):
1470         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1471         (runTest):
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (createWebViewAndOffscreenWindow):
1474         (sizeWebViewForCurrentTest):
1475         * DumpRenderTree/win/DumpRenderTree.cpp:
1476         (dump):
1477         (createWebViewAndOffscreenWindow):
1478
1479 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         [Win] Implement test functions for printing
1484         https://bugs.webkit.org/show_bug.cgi?id=34570
1485
1486         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1487         (LayoutTestController::pageNumberForElementById):
1488         (LayoutTestController::numberOfPages):
1489
1490 2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
1491
1492         Reviewed by Eric Seidel.
1493
1494         websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
1495         https://bugs.webkit.org/show_bug.cgi?id=35001
1496
1497         * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
1498
1499 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1500
1501         Reviewed by Eric Seidel.
1502
1503         check-webkit-style: Misses variables that contain underscores.
1504         https://bugs.webkit.org/show_bug.cgi?id=33724
1505
1506         - Check identifiers whose types are unsigned.
1507         - Check bitfields properly.
1508
1509         * Scripts/webkitpy/style/processors/cpp.py:
1510         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1511
1512 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1513
1514         Reviewed by Eric Seidel.
1515
1516         check-webkit-style should report the number of files checked
1517         https://bugs.webkit.org/show_bug.cgi?id=34971
1518
1519         * Scripts/check-webkit-style:
1520         * Scripts/webkitpy/style/checker.py:
1521         * Scripts/webkitpy/style/checker_unittest.py:
1522
1523 2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1524
1525         Reviewed by Ariya Hidayat.
1526
1527         Make possible Qt DRT to get total number of pages to be printed
1528
1529         LayoutTests:
1530             printing/numberOfPages.html
1531
1532         [Qt] DRT: Get total number of pages to be printed
1533         https://bugs.webkit.org/show_bug.cgi?id=34955
1534
1535         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1536         (LayoutTestController::numberOfPages):
1537         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1538
1539 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1540
1541         Reviewed by Gustavo Noronha.
1542
1543         Update to use new property name.
1544
1545         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1546         (resetDefaultsToConsistentValues):
1547
1548 2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>
1549
1550         Reviewed by Ariya Hidayat.
1551
1552         Remove some warnings seen when building Qt
1553         https://bugs.webkit.org/show_bug.cgi?id=35017
1554
1555         Using a machine without the needed tools to build WebKit leads to
1556         several errors and warnings.
1557
1558         * Scripts/webkitdirs.pm: Refactored the code testing the command's
1559         presence into a commandExists routine. While doing so removed, stderr
1560         output as it usually does not give anything more than our message. Also
1561         added a Qt check for qmake that was missing.
1562
1563 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1564
1565         Rubber-stamped by Gustavo Noronha.
1566
1567         Disable Java by default in DRT.
1568
1569         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1570         (resetDefaultsToConsistentValues):
1571
1572 2010-02-15  Chris Jerdonek  <cjerdonek@webkit.org>
1573
1574         Reviewed by Shinichiro Hamaji.
1575
1576         Some minor check-webkit-style code clean-ups.  This revision
1577         contains no new functionality.
1578
1579         https://bugs.webkit.org/show_bug.cgi?id=34932
1580
1581         * Scripts/check-webkit-style:
1582           - Replaced the call to webkit_argument_defaults() with a
1583             default parameter in the ArgumentParser constructor.
1584
1585         * Scripts/webkitpy/style/checker.py:
1586           - Removed the WEBKIT prefix from the default global variables.
1587           - Prefixed several of the global variables with an underscore
1588             to reflect that they are used internally.
1589           - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
1590           - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
1591             configuration from list-tuple pairs to list-list pairs.
1592           - Renamed style_categories() to _all_categories().
1593           - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
1594           - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
1595           - In the ArgumentParser class--
1596             - Renamed the doc_print attribute to stderr_write.
1597             - Other minor updates.
1598
1599         * Scripts/webkitpy/style/checker_unittest.py:
1600           - Updated the import statements and unit test classes as necessary.
1601           - Added assertions to test _PATH_RULES_SPECIFIER more fully.
1602
1603         * Scripts/webkitpy/style/error_handlers_unittest.py:
1604           - Updated the unit test classes as necessary.
1605           - Changed StyleErrorHandlerTestBase to store a list of error
1606             messages rather than just the last one.
1607
1608         * Scripts/webkitpy/style/filter.py:
1609           - Altered FilterConfiguration._path_rules_from_path()
1610             to convert the path_rules list to a tuple.
1611
1612         * Scripts/webkitpy/style/filter_unittest.py:
1613           - Updated the unit tests to reflect the change from tuples to
1614             lists in the _PATH_RULES_SPECIFIER configuration variable.
1615
1616 2010-02-16  Mark Rowe  <mrowe@apple.com>
1617
1618         Let's not check garbage in to common build scripts and hose the world now eh guys?
1619
1620         * Scripts/webkitdirs.pm:
1621
1622 2010-02-16  Eric Seidel  <eric@webkit.org>
1623
1624         Reviewed by Adam Barth.
1625
1626         re-factor Skipped list parsing code into multiple functions and unit test it
1627         https://bugs.webkit.org/show_bug.cgi?id=34986
1628
1629         * Scripts/test-webkitpy: Add new unit test.
1630         * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1631         * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
1632         * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
1633
1634 2010-02-16  Xan Lopez  <xlopez@igalia.com>
1635
1636         Reviewed by Gustavo Noronha.
1637
1638         Enable 'auto-resize-window' in our DRT.
1639
1640         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1641         (resetDefaultsToConsistentValues):
1642
1643 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
1644
1645         Reviewed by Darin Adler.
1646
1647         check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
1648         https://bugs.webkit.org/show_bug.cgi?id=34834
1649
1650         * Scripts/webkitpy/style/processors/cpp.py:
1651         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1652
1653 2010-02-12  Alexey Proskuryakov  <ap@apple.com>
1654
1655         Reviewed by Kevin Decker.
1656
1657         <rdar://problem/7130641> Browser objects identity is not preserved by Safari
1658
1659         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1660         (pluginInvoke): Added methods for checking object identity (via refcount).
1661
1662 2010-02-15  Robert Hogan  <robert@roberthogan.net>
1663
1664         Reviewed by Simon Hausmann.
1665
1666         [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
1667
1668         Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
1669
1670         https://bugs.webkit.org/show_bug.cgi?id=33096
1671
1672         This allows the following tests to pass:
1673
1674         inspector/console-format-collections.html
1675         inspector/styles-iframe.html
1676         inspector/syntax-highlight-css.html
1677         inspector/syntax-highlight-javascript.html
1678         inspector/timeline-enum-stability.html
1679         inspector/timeline-layout.html
1680         inspector/timeline-mark-timeline.html
1681         inspector/timeline-paint.html
1682         inspector/timeline-parse-html.html
1683         inspector/timeline-recalculate-styles.html
1684         inspector/timeline-script-tag-1.html
1685         inspector/timeline-script-tag-2.html
1686         inspector/timeline-trivial.html
1687         inspector/cookie-resource-match.html
1688         inspector/elements-img-tooltip.html
1689         inspector/elements-panel-selection-on-refresh.html
1690         inspector/inspected-objects-not-overriden.html
1691         inspector/timeline-event-dispatch.html
1692         inspector/timeline-network-resource.html
1693         inspector/elements-panel-rewrite-href.html
1694         inspector/console-dir.html
1695         inspector/console-dirxml.html
1696         inspector/console-format.html
1697         inspector/console-tests.html
1698         inspector/elements-panel-structure.html
1699         inspector/evaluate-in-frontend.html
1700         inspector/console-clear.html
1701
1702         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1703         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1704         (WebCore::isWebInspectorTest):
1705         (WebCore::DumpRenderTree::open):
1706         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1707         (WebCore::DumpRenderTree::display):
1708         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1709         (LayoutTestController::closeWebInspector):
1710         (LayoutTestController::showWebInspector):
1711         (LayoutTestController::evaluateInWebInspector):
1712         (LayoutTestController::setTimelineProfilingEnabled):
1713         (LayoutTestController::display):
1714         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1715
1716 2010-02-14  Dirk Pranke  <dpranke@chromium.org>
1717
1718         Reviewed by Eric Seidel.
1719
1720         Update rebaseline-chromium-webkit-tests to work with the new code
1721         structure (port objects instead of path_utils and platform_utils).
1722
1723         Added a path_to_test_expectations_file() to the Port interface.
1724   
1725         Fixed a bug in the chromium_* platform implementations where the
1726         'target' option was assumed to be set.
1727
1728         * Scripts/rebaseline-chromium-webkit-tests:
1729         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1730         * Scripts/webkitpy/layout_tests/port/base.py:
1731         * Scripts/webkitpy/layout_tests/port/chromium.py:
1732         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1733         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1734         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1735         * Scripts/webkitpy/layout_tests/port/test.py:
1736         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1737
1738 2010-02-14  Eric Seidel  <eric@webkit.org>
1739
1740         Reviewed by Darin Adler.
1741
1742         webkit-build-directory misuses terms
1743         https://bugs.webkit.org/show_bug.cgi?id=34822
1744
1745         * Scripts/webkit-build-directory:
1746          - Add --top-level and --configuration options and make using one of them required.
1747         * Scripts/webkitpy/layout_tests/port/mac.py:
1748          - Use --top-level instead of --base.
1749
1750 2010-02-14  Chang Shu  <Chang.Shu@nokia.com>
1751
1752         Reviewed by Laszlo Gombos.
1753
1754         [Qt] Enable appcache feature.
1755         https://bugs.webkit.org/show_bug.cgi?id=34713
1756
1757         Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
1758         Persistent storage for AppCache is already initialized in
1759         DumpRenderTreeQt.cpp.
1760
1761         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1762         (WebCore::WebPage::WebPage):
1763
1764 2010-02-12  Chang Shu  <Chang.Shu@nokia.com>
1765
1766         Not Reviewed.
1767
1768         Change case of my email address as a work-around for the following bug.
1769         https://bugs.webkit.org/show_bug.cgi?id=34717
1770
1771         * Scripts/webkitpy/committers.py:
1772
1773 2010-02-12  Darin Adler  <darin@apple.com>
1774
1775         Ignore compiled Python in more of webkitpy.
1776
1777         * Scripts/webkitpy/style/processors: Added property svn:ignore.
1778
1779 2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1780
1781         Reviewed by Kenneth Rohde Christiansen.
1782
1783         Qt DRT now dump the frame loader callbacks when LayoutTestController()
1784         method is called.
1785
1786         LayoutTests:
1787             http/tests/security/mixedContent/data-url-script-in-iframe.html
1788             http/tests/security/mixedContent/empty-url-plugin-in-frame.html
1789             http/tests/security/mixedContent/insecure-css-in-iframe.html
1790             http/tests/security/mixedContent/insecure-iframe-in-iframe.html
1791             http/tests/security/mixedContent/insecure-image-in-iframe.html
1792             http/tests/security/mixedContent/insecure-plugin-in-iframe.html
1793             http/tests/security/mixedContent/insecure-script-in-iframe.html
1794             http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
1795             http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
1796
1797         [Qt] Make possible Qt DRT dump frame load callbacks
1798         https://bugs.webkit.org/show_bug.cgi?id=34702
1799
1800         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1801         (LayoutTestController::reset):
1802         (LayoutTestController::dumpFrameLoadCallbacks):
1803         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1804
1805 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1806
1807         Reviewed by Antti Koivisto.
1808
1809         Make QtLauncher somewhat useable on S60.
1810
1811         Show the window fullscreen to make scrollbars appear, resize
1812         the toolbar buttons to 16x16 to give more screen space to
1813         web content and moved the location lineedit into a separate
1814         line.
1815
1816         * QtLauncher/main.cpp:
1817         (LauncherWindow::LauncherWindow):
1818         * QtLauncher/mainwindow.cpp:
1819         (MainWindow::buildUI):
1820
1821 2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1822
1823         Reviewed by Kenneth Rohde Christiansen.
1824
1825         Support frameset flattening
1826         https://bugs.webkit.org/show_bug.cgi?id=32717
1827
1828         Add FrameSet Flattening support to Mac DRT.
1829
1830         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1831         (LayoutTestController::setFrameSetFlatteningEnabled):
1832         * DumpRenderTree/win/DumpRenderTree.cpp:
1833         (resetDefaultsToConsistentValues):
1834         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1835         (LayoutTestController::setXSSAuditorEnabled):
1836         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1837         (LayoutTestController::setFrameSetFlatteningEnabled):
1838         * DumpRenderTree/LayoutTestController.cpp:
1839         (setFrameSetFlatteningEnabledCallback):
1840         (LayoutTestController::staticFunctions):
1841         * DumpRenderTree/LayoutTestController.h:
1842         * DumpRenderTree/mac/DumpRenderTree.mm:
1843         (resetDefaultsToConsistentValues):
1844         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1845         (LayoutTestController::setFrameSetFlatteningEnabled):
1846
1847 2010-02-12  Dirk Pranke  <dpranke@chromium.org>
1848
1849         Reviewed by Eric Seidel.
1850
1851         Fix typos in driver_test.py 
1852
1853         https://bugs.webkit.org/show_bug.cgi?id=34810
1854
1855         * Scripts/webkitpy/layout_tests/driver_test.py:
1856
1857 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1858
1859         Reviewed by Kenneth Rohde Christiansen.
1860
1861         [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
1862         https://bugs.webkit.org/show_bug.cgi?id=34844
1863
1864         * QtLauncher/main.cpp:
1865         (LauncherWindow::LauncherWindow):
1866         (LauncherWindow::initializeView):
1867         (LauncherWindow::setupUI):
1868         * QtLauncher/webview.cpp:
1869         (WebViewGraphicsBased::WebViewGraphicsBased):
1870
1871 2010-02-11  Fumitoshi Ukai  <ukai@chromium.org>
1872
1873         Reviewed by Alexey Proskuryakov.
1874
1875         WebSocket ignores HttpOnly cookies, but should use in Handshake.
1876         https://bugs.webkit.org/show_bug.cgi?id=34289
1877
1878         Update pywebsocket to 0.4.8, which supports cgi directories.
1879         run-webkit-tests and run-webkit-websocketserver will run
1880         pywebsocket, specifying /websocket/test/cookies as cgi directory.
1881
1882         * Scripts/run-webkit-tests:
1883         * Scripts/run-webkit-websocketserver:
1884         * pywebsocket/mod_pywebsocket/standalone.py:
1885         * pywebsocket/setup.py:
1886
1887 2010-02-11  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1888
1889         Reviewed by Dan Bernstein.
1890
1891         [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
1892         https://bugs.webkit.org/show_bug.cgi?id=34798
1893
1894         Remove duplicated setXSSAuditorEnabled preference at Mac DRT
1895
1896         * DumpRenderTree/mac/DumpRenderTree.mm:
1897         (resetDefaultsToConsistentValues):
1898
1899 2010-02-11  Eric Seidel  <eric@webkit.org>
1900
1901         No review, build fix only.
1902
1903         webkitdirs.pm has a crazy amount of duplicated feature detection code
1904         https://bugs.webkit.org/show_bug.cgi?id=34869
1905
1906         * Scripts/build-webkit: Fix typo which broke bots.
1907
1908 2010-02-11  Eric Seidel  <eric@webkit.org>
1909
1910         Reviewed by Adam Barth.
1911
1912         webkitdirs.pm has a crazy amount of duplicated feature detection code
1913         https://bugs.webkit.org/show_bug.cgi?id=34869
1914
1915         * Scripts/build-webkit: Use the new hotness.
1916         * Scripts/run-webkit-tests: ditto
1917         * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
1918         * Scripts/webkitperl/features.pm: Added.
1919          - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
1920
1921 2010-02-11  Daniel Bates  <dbates@rim.com>
1922
1923         Reviewed by Adam Barth.
1924
1925         https://bugs.webkit.org/show_bug.cgi?id=34830
1926
1927         Makes method User.prompt static and adds the parameter repeat
1928         to prompt the user up to repeat times.
1929
1930         * Scripts/test-webkitpy:
1931         * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
1932         * Scripts/webkitpy/commands/upload.py: Ditto
1933         * Scripts/webkitpy/credentials.py: Ditto
1934         * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
1935         * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
1936         * Scripts/webkitpy/user_unittest.py: Added.
1937
1938 2010-02-10  Yuzo Fujishima  <yuzo@google.com>
1939
1940         Reviewed by Darin Adler.
1941
1942         Allow underscored identifiers in CSSParser.cpp
1943
1944         Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
1945         WebCore/css/CSSParser.cpp needs to handle some such identifiers.
1946         We should relax the style rule for the file to allow underscored identifiers.
1947
1948         https://bugs.webkit.org/show_bug.cgi?id=34787
1949
1950         * Scripts/webkitpy/style/checker.py:
1951
1952 2010-02-11  Eric Seidel  <eric@webkit.org>
1953
1954         Rubber-stamped by Adam Barth.
1955
1956         Remove DrawTest, the application I used when bringing up SVG support on the Mac.
1957         The code hasn't been touched (or used) in years.  No sense in keeping it in trunk.
1958
1959         * Scripts/build-drawtest: Removed.
1960         * Scripts/run-drawtest: Removed.
1961         * DrawTest: Removed.
1962
1963 2010-02-11  Eric Seidel  <eric@webkit.org>
1964
1965         Reviewed by Adam Barth.
1966
1967         Need a command to clear r+ on obsolete patches in the pending-commit queue.
1968         https://bugs.webkit.org/show_bug.cgi?id=34863
1969
1970         Unfortunately our http://webkit.org/pending-commit bugzilla query is not
1971         smart enough to ignore obsolete patches, so bugs show up there which are
1972         still open, but do not have patches ready for landing on them.
1973         This new command "clean-pending-commit" will remove r+ from obsolete patches
1974         in the pending-commit list.
1975
1976         * Scripts/test-webkitpy: Add grammar_unittest
1977         * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
1978         * Scripts/webkitpy/grammar.py: Add join_with_separators
1979         * Scripts/webkitpy/grammar_unittest.py: Added.
1980
1981 2010-02-11  Eric Seidel  <eric@webkit.org>
1982
1983         Reviewed by Adam Barth.
1984
1985         run-chromium-webkit-tests fails random pixel tests on Mac
1986         https://bugs.webkit.org/show_bug.cgi?id=34862
1987
1988         This is due to the fact that the Mac port has an
1989         invalid path to the image diff tool.  Currently it points
1990         to image_diff even though ImageDiff would be correct.  We
1991         can't change it to the right path yet without causing the
1992         script to hang.  ImageDiff expects to be long-running and
1993         be passed image data over stdin.  image_diff (chromium's fork)
1994         expects to be passed command line arguments.
1995         This fix works around the random failures by disabling pixel
1996         tests on mac and logging if the user was trying to run with pixel
1997         tests enabled.
1998
1999         * Scripts/webkitpy/layout_tests/port/mac.py:
2000
2001 2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
2002
2003         Reviewed by Adam Roben.
2004         Try to fix build breakage from r54665.
2005         
2006         * Scripts/check-for-global-initializers:
2007
2008 2010-02-11  Simon Hausmann  <simon.hausmann@nokia.com>
2009
2010         Reviewed by Tor Arne Vestbø.
2011
2012         Make it possible to toggle accelerated compositing from the menu
2013         at run-time.
2014
2015         * QtLauncher/main.cpp:
2016         (LauncherWindow::toggleAcceleratedCompositing):
2017         (LauncherWindow::setupUI):
2018
2019 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
2020
2021         Reviewed by Cameron Zwarich.
2022
2023         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
2024         https://bugs.webkit.org/show_bug.cgi?id=34698
2025
2026         * Scripts/build-webkit:
2027
2028 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
2029
2030         Reviewed by Eric Seidel.
2031
2032         Fix various minor bugs keeping run-chromium-webkit-tests from actually
2033         working on the linux and win ports of Chromium.
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=34739
2036
2037         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2038         * Scripts/webkitpy/layout_tests/port/__init__.py:
2039         * Scripts/webkitpy/layout_tests/port/base.py:
2040         * Scripts/webkitpy/layout_tests/port/chromium.py:
2041         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2042         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2043         * Scripts/webkitpy/layout_tests/port/http_server.py:
2044         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2045
2046 2010-02-10  Eric Seidel  <eric@webkit.org>
2047
2048         Reviewed by David Levin.
2049
2050         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
2051         https://bugs.webkit.org/show_bug.cgi?id=34817
2052
2053         This doesn't fix the root cause of us not
2054         correctly failing when support binaries are missing.
2055         This only causes the DumpRenderTree binary not to be
2056         missing in the custom build directory case.
2057         Later patches will make us correctly fail fast when
2058         support binaries (like DumpRenderTree or ImageDiff) are missing.
2059
2060         * Scripts/webkit-build-directory: Added.
2061          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
2062         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
2063         * Scripts/webkitpy/layout_tests/port/mac.py:
2064          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
2065         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
2066
2067 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
2068
2069         Reviewed by Kevin Ollivier.
2070
2071         [wx] Add Windows complex text support.
2072         
2073         https://bugs.webkit.org/show_bug.cgi?id=34759
2074
2075         * wx/build/settings.py:
2076
2077 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
2078
2079         [wx] Build fix. Add stub for new LayoutTestController method.
2080
2081         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2082         (LayoutTestController::numberOfPages):
2083
2084 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
2085
2086         Unreviewed. Roll out r54626, because it broke GTK and Win build.
2087         https://bugs.webkit.org/show_bug.cgi?id=32717
2088
2089         * DumpRenderTree/LayoutTestController.cpp:
2090         (LayoutTestController::staticFunctions):
2091         * DumpRenderTree/LayoutTestController.h:
2092         * DumpRenderTree/mac/DumpRenderTree.mm:
2093         (resetDefaultsToConsistentValues):
2094         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2095
2096 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2097
2098         Reviewed by Kenneth Rohde Christiansen.
2099
2100         Support frameset flattening
2101         https://bugs.webkit.org/show_bug.cgi?id=32717
2102
2103         Add FrameSet Flattening support to Mac DRT.
2104
2105         * DumpRenderTree/LayoutTestController.cpp:
2106         (setFrameSetFlatteningEnabledCallback):
2107         (LayoutTestController::staticFunctions):
2108         * DumpRenderTree/LayoutTestController.h:
2109         * DumpRenderTree/mac/DumpRenderTree.mm:
2110         (resetDefaultsToConsistentValues):
2111         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2112         (LayoutTestController::setFrameSetFlatteningEnabled):
2113
2114 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
2115
2116         <rdar://problem/7436875> Crash in Flash when visiting
2117         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
2118
2119         Reviewed by Darin Adler.
2120
2121         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2122         (executeScript):
2123         Moved to an earlier point in the file.
2124         (NPP_New):
2125         If the plug-in has an onDestroy attribute, store its value.
2126         (NPP_Destroy):
2127         If the plug-in has code to run on destruction, run it and free it.
2128
2129 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2130
2131         Reviewed by Kenneth Rohde Christiansen.
2132
2133         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
2134         to make Qt DRT able to get page number.
2135
2136         LayoutTests:
2137             printing/page-break-always.html
2138             printing/pageNumerForElementById.html
2139             printing/css2.1/page-break-before-000.html
2140             printing/css2.1/page-break-after-000.html
2141             printing/css2.1/page-break-after-004.html
2142             printing/css2.1/page-break-before-001.html
2143             printing/css2.1/page-break-after-001.html
2144             printing/css2.1/page-break-after-002.html
2145             printing/css2.1/page-break-before-002.html
2146             printing/css2.1/page-break-inside-000.html
2147
2148         [Qt] Make possible Qt DRT get a page number for element by ID
2149         https://bugs.webkit.org/show_bug.cgi?id=34777
2150
2151         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2152         (LayoutTestController::pageNumberForElementById):
2153         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2154
2155 2010-02-10  Andras Becsi  <abecsi@webkit.org>
2156
2157         Reviewed by Adam Barth.
2158
2159         Make run-iexploder-tests work on Linux.
2160         https://bugs.webkit.org/show_bug.cgi?id=34748
2161
2162         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
2163         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
2164
2165         * Scripts/run-iexploder-tests:
2166         * Scripts/webkitperl/httpd.pm:
2167
2168 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2169
2170         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
2171         https://bugs.webkit.org/show_bug.cgi?id=34713
2172
2173         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2174         (WebCore::WebPage::WebPage):
2175         * DumpRenderTree/qt/main.cpp:
2176         (main):
2177
2178 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
2179
2180         Unreviewed; added myself to committers
2181
2182         * Scripts/webkitpy/committers.py:
2183
2184 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
2185
2186         Reviewed by Kenneth Rohde Christiansen.
2187
2188         [Qt] Webkit in Qt does not have window.showModalDialog
2189         https://bugs.webkit.org/show_bug.cgi?id=25585
2190
2191         Set the modality flag when createWindow is called with window type WebWindowDialog.
2192
2193         * QtLauncher/main.cpp:
2194         (WebPage::createWindow):
2195
2196 2010-02-09  Andras Becsi  <abecsi@webkit.org>
2197
2198         Unreviewed trivial warning fix.
2199
2200         * Scripts/build-webkit:
2201
2202 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
2203
2204         Reviewed by Tor Arne Vestbø.
2205
2206         Add possibility of passing parameters to build-webkit by environment variable,
2207         because the buildbot slaves can't control the arguments.
2208
2209         * Scripts/build-webkit:
2210
2211 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
2212
2213         Reviewed by Laszlo Gombos.
2214
2215         [Qt] Enable appcache feature.
2216         https://bugs.webkit.org/show_bug.cgi?id=34713
2217
2218
2219         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2220         (WebCore::WebPage::WebPage):
2221         * DumpRenderTree/qt/main.cpp:
2222         (main):
2223
2224 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
2225
2226         Reviewed by Darin Adler.
2227
2228         Provide a way to get total number of pages to be printed
2229         https://bugs.webkit.org/show_bug.cgi?id=34699
2230
2231         * DumpRenderTree/LayoutTestController.cpp:
2232         (parsePageParameters):
2233         (pageNumberForElementByIdCallback):
2234         (numberOfPagesCallback):
2235         (LayoutTestController::staticFunctions):
2236         * DumpRenderTree/LayoutTestController.h:
2237         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2238         (LayoutTestController::numberOfPages):
2239         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2240         (LayoutTestController::numberOfPages):
2241         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2242         (LayoutTestController::numberOfPages):
2243
2244 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
2245
2246         Reviewed by Darin Adler.
2247
2248         https://bugs.webkit.org/show_bug.cgi?id=34727
2249         Assertion crashes and freezes when plug-in property access results in an exception
2250
2251         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2252         (pluginGetProperty): Raise an exception when accessing a particular property.
2253         (pluginSetProperty): Ditto.
2254         (pluginInvoke): Added methods to get and set host object properties.
2255
2256 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2257
2258         Reviewed by Ariya Hidayat.
2259
2260         [Qt] Backport No'am Rosenthal's frame rate measurement
2261
2262         * QtLauncher/main.cpp:
2263         (LauncherWindow::LauncherWindow):
2264         (LauncherApplication::handleUserOptions):
2265         * QtLauncher/webview.cpp:
2266         (WebViewGraphicsBased::WebViewGraphicsBased):
2267         (WebViewGraphicsBased::enableFrameRateMeasurement):
2268         (WebViewGraphicsBased::updateFrameRate):
2269         (WebViewGraphicsBased::paintEvent):
2270         * QtLauncher/webview.h:
2271
2272 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2273
2274         Reviewed by Tor Arne Vestbø.
2275
2276         [Qt] Make overridePreference complain when it does not
2277         support the preference given.
2278
2279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2280         (LayoutTestController::overridePreference):
2281
2282 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2283
2284         Reviewed by Kenneth Rohde Christiansen.
2285
2286         [Qt] Set stdout/stderr to binary mode for DRT on Windows
2287
2288         This makes sure we don't end up with lots of CRLFs in the
2289         DRT output, which breaks tons of results. Matches what
2290         the Windows DRT does.
2291
2292         * DumpRenderTree/qt/main.cpp:
2293
2294 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2295
2296         Reviewed by Kenneth Rohde Christiansen.
2297
2298         Build fix for Qt on Windows.
2299
2300         Don't use noreturn directly since it's a gcc attribute.
2301         Instead use the NO_RETURN macro from AlwaysInline.h
2302
2303         * QtLauncher/QtLauncher.pro:
2304         * QtLauncher/utils.h:
2305
2306 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
2307
2308         Reviewed by Shinichiro Hamaji.
2309
2310         Suppressed check-webkit-style's underscore check in Qt's autotests.
2311         Also made the path-specific filter check case-insensitive.
2312
2313         https://bugs.webkit.org/show_bug.cgi?id=34574
2314
2315         * Scripts/webkitpy/style/checker.py:
2316           - Added a list element to _PATH_RULES_SPECIFIER for
2317             directories that should be excluded from the
2318             "readability/naming" category (the category that relates to
2319             underscores in identifiers, for example).
2320
2321         * Scripts/webkitpy/style/checker_unittest.py:
2322           - Added an "end-to-end" test for "WebKit/qt/tests/".
2323
2324         * Scripts/webkitpy/style/filter.py:
2325           - Altered FilterConfiguration's should_check() method to
2326             check for path substring matches case-insensitively.
2327
2328         * Scripts/webkitpy/style/filter_unittest.py:
2329           - Added a test to check case-insensitive path substring matching.
2330
2331         * Scripts/webkitpy/style/processors/cpp.py:
2332           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
2333             since this is now taken care of by the _PATH_RULES_SPECIFIER
2334             configuration variable.
2335
2336         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2337           - Removed the unit test for the GTK directory since this
2338             is now taken care of by the checker._PATH_RULES_SPECIFIER
2339             end-to-end tests.
2340
2341 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
2342
2343         Reviewed by Darin Adler.
2344
2345         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
2346         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
2347         environemnt variables when there is a space in the user's /home path.
2348
2349         * Scripts/webkitdirs.pm:
2350          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
2351
2352 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
2353
2354         Reviewed by Oliver Hunt.
2355
2356         https://bugs.webkit.org/show_bug.cgi?id=34670
2357         TestNetscapePlugin should work with Firefox
2358
2359         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
2360         browser doesn't tell what it supports.
2361
2362 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
2363
2364         Reviewed by Gustavo Noronha Silva.
2365
2366         [Gtk] Implement layoutTestController.pageNumberForElementById
2367         https://bugs.webkit.org/show_bug.cgi?id=34572
2368
2369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2370         (LayoutTestController::pageNumberForElementById):
2371
2372 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2373
2374         Reviewed by Eric Seidel.
2375
2376         Add a simple test implementation and the WebKit Mac implementation
2377         for the layout_tests/port package. Also add a simple test driver of
2378         that interface.
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=34511
2381
2382         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
2383         * Scripts/webkitpy/layout_tests/port/__init__.py:
2384         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
2385         * Scripts/webkitpy/layout_tests/port/test.py: Added.
2386
2387 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2388
2389         Reviewed by Eric Siedel.
2390
2391         Refactor the port package into an object-oriented style and merge
2392         path_utils into it. We add a 'base' and a 'chromium' object to the
2393         port package; this will allow us to easily add new ports (like
2394         WebKit Mac).
2395
2396         https://bugs.webkit.org/show_bug.cgi?id=34511
2397
2398         * Scripts/rebaseline-chromium-webkit-tests:
2399         * Scripts/run-chromium-webkit-tests:
2400         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2401         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2402         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2403         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2404         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2405         * Scripts/webkitpy/layout_tests/port/__init__.py:
2406         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2407         * Scripts/webkitpy/layout_tests/port/base.py: Added.
2408         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
2409         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2410         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2411         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2412         * Scripts/webkitpy/layout_tests/port/http_server.py:
2413         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2414         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
2415         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2416         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2417         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2418         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2419         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2420         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2421         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2422
2423 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2424
2425         Reviewed by Dave Hyatt.
2426
2427         Implement flattening of framesets
2428         https://bugs.webkit.org/show_bug.cgi?id=32717
2429
2430         Add support for testing frame flattening with the Qt DRT
2431
2432         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2433         (LayoutTestController::setFrameSetFlatteningEnabled):
2434         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2435
2436 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
2437
2438         Reviewed by Shinichiro Hamaji.
2439
2440         Provided a way in check-webkit-style to specify filter rules
2441         on a per file or folder basis, via a configuration variable.
2442
2443         https://bugs.webkit.org/show_bug.cgi?id=33684
2444
2445         * Scripts/webkitpy/style/checker.py:
2446           - Added _PATH_RULES_SPECIFIER configuration variable.
2447           - In ProcessorOptions class--
2448             - Changed the CategoryFilter attribute to FilterConfiguration.
2449             - Added path parameter to is_reportable().
2450           - Renamed ArgumentDefaults filter_rules attribute to
2451             base_filter_rules.
2452           - Updated ArgumentPrinter class.
2453           - Added filter rule validation to ArgumentParser (instead of
2454             in CategoryFilter constructor).
2455
2456         * Scripts/webkitpy/style/checker_unittest.py:
2457           - Updated unit tests as necessary.
2458           - Added unit tests for PATH_RULES_SPECIFIER.
2459
2460         * Scripts/webkitpy/style/error_handlers.py:
2461           - Updated DefaultStyleErrorHandler to use file path when
2462             calling is_reportable().
2463
2464         * Scripts/webkitpy/style/error_handlers_unittest.py:
2465           - Updated unit tests as necessary.
2466
2467         * Scripts/webkitpy/style/filter.py:
2468           - Marked CategoryFilter internal with an underscore.
2469           - Removed argument validation from CategoryFilter.
2470           - Added FilterConfiguration class.
2471
2472         * Scripts/webkitpy/style/filter_unittest.py:
2473           - Updated CategoryFilterTest class.
2474           - Added FilterConfigurationTest unit tests.
2475
2476         * Scripts/webkitpy/style/processors/cpp.py:
2477           - Removed _is_test_filename() code.
2478           - Removed hard-coded path checks from check_include_line().
2479
2480         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2481           - Removed three unit tests related to exempted files.
2482
2483 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2484
2485         Reviewed by Ariya Hidayat.
2486
2487         [Qt] Apply the command line options as settings to the
2488         graphics system.
2489
2490         * QtLauncher/main.cpp:
2491         (LauncherWindow::LauncherWindow):
2492         (requiresGraphicsView):
2493         (LauncherApplication::handleUserOptions):
2494         * QtLauncher/webview.h:
2495         (WebViewGraphicsBased::setItemCacheMode):
2496
2497 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2498
2499         Reviewed by Simon Hausmann.
2500
2501         Notify user that run-webkit-tests has to be run under Cygwin
2502
2503         The script will bail out if run under Windows shell or Msys.
2504
2505         * Scripts/run-webkit-tests:
2506         * Scripts/webkitdirs.pm:
2507
2508 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2509
2510         Reviewed by Simon Hausmann.
2511
2512         [Qt] Generate convenience headers (QWebView, etc) using qmake
2513
2514         In Qt this is done using syncqt, but we use a pro-file instead
2515         that generates makefile-rules for each of the extra headers.
2516
2517         These extra headers are installed alongside the normal headers.
2518
2519         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
2520
2521 2010-02-05  Andras Becsi  <abecsi@webkit.org>
2522
2523         Unreviewed typo fix.
2524
2525         Fix wrong whitespace alignment introduced in r54342.
2526
2527         * Scripts/run-webkit-tests:
2528
2529 2010-02-04  Mark Rowe  <mrowe@apple.com>
2530
2531         Reviewed by Timothy Hatcher.
2532
2533         Build fix.  Remove a symbol corresponding to an inline function from the linker export
2534         file to prevent a weak external failure.
2535
2536         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
2537         Teach the script how to detect weak external symbols so that these errors can be caught immediately
2538         in the future.
2539
2540 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2541
2542         Rubberstamped by Oliver Hunt.
2543
2544         [Qt] Make it possible to choose whether the launcher should
2545         use the traditional QWidget based QWebView or the newer
2546         QGraphics based QGraphicsWebView on a QGraphicsView.
2547
2548         * QtLauncher/main.cpp:
2549         (LauncherWindow::LauncherWindow):
2550         (LauncherWindow::eventFilter):
2551         (LauncherWindow::loadStarted):
2552         (LauncherWindow::print):
2553         (LauncherWindow::screenshot):
2554         (LauncherWindow::setEditable):
2555         (LauncherWindow::setupUI):
2556         (main):
2557         * QtLauncher/webview.cpp:
2558         (WebViewGraphicsBased::WebViewGraphicsBased):
2559         (WebViewGraphicsBased::resizeEvent):
2560         (GraphicsWebView::mousePressEvent):
2561         (GraphicsWebView::contextMenuEvent):
2562         * QtLauncher/webview.h:
2563         (WebViewTraditional::WebViewTraditional):
2564         (GraphicsWebView::GraphicsWebView):
2565         (WebViewGraphicsBased::setPage):
2566
2567 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2568
2569         Rubberstamped by Oliver Hunt.
2570
2571         [Qt] QtLauncher cleanup.
2572
2573         Refactor option handling out in utility functions and make the
2574         arguments more Qt compatible.
2575
2576         * QtLauncher/main.cpp:
2577         (requiresGraphicsView):
2578         (LauncherApplication::handleUserOptions):
2579         * QtLauncher/utils.cpp:
2580         (takeOptionValue):
2581         (formatKeys):
2582         (enumToKeys):
2583         (appQuit):
2584         * QtLauncher/utils.h:
2585
2586 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
2587
2588         Reviewed by Tor Arne Vestbø.
2589
2590         Implement a locking and scheduling mechanism for http testing sessions to be able
2591         to run multiple instances of run-webkit-tests parallel on the same machine.
2592         If a test session wants to run http tests and this feature is enabled, the pending
2593         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
2594         the running test sessions in first come first served order. An exclusive lock ensures
2595         that the lock numbers are sequential to avoid deadlocks and starvation.
2596         Because the buildbot master specifies the flags used by slaves we need an environment
2597         variable too to be able to use the feature per-slave.
2598         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
2599         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
2600
2601         https://bugs.webkit.org/show_bug.cgi?id=33153
2602
2603         * Scripts/run-webkit-tests:
2604         * Scripts/webkitperl/httpd.pm:
2605
2606 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2607
2608         Reviewed by Simon Hausmann.
2609
2610         Make run-webkit-tests work under Cygwin for the Qt port
2611
2612         setPathForRunningWebKitApp() is implemented for the Qt port
2613         by using qmake to query for the location of the Qt libraries.
2614
2615         This requires the original environment (%ENV) to be untouched,
2616         so launchWithCurrentEnv() was refactored to launchWithEnv(),
2617         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
2618         instead. This has the added benefit of getting rid of the temp
2619         variables used for storing the current env.
2620
2621         openDumpTool() is also refactored a bit into platform-spesific,
2622         port-spesific, and generic environment variables.
2623
2624         Checks for undef was added a few places to fix Perl concat
2625         warnings when run-webkit-tests is aborted.
2626
2627         https://bugs.webkit.org/show_bug.cgi?id=33895
2628
2629         * Scripts/run-webkit-tests:
2630         * Scripts/webkitdirs.pm:
2631
2632 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
2633
2634         Unreviewed.
2635
2636         Add Yuzo to the committers list.
2637
2638         * Scripts/webkitpy/committers.py:
2639
2640 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2641
2642         Rubber-stamped by Eric Seidel.
2643
2644         Change "the Chromium name" to "the name of Google Inc." in the licenses
2645
2646         https://bugs.webkit.org/show_bug.cgi?id=34511
2647
2648         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2649         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2650         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2651         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2652         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2653         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2654         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2655         * Scripts/webkitpy/layout_tests/port/__init__.py:
2656         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2657         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2658         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2659         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2660         * Scripts/webkitpy/layout_tests/port/http_server.py:
2661         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2662         * Scripts/webkitpy/layout_tests/port/path_utils.py:
2663         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2664         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2665         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2666         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2667         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2668         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2669         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2670
2671 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2672
2673         Rubber-stamped by Eric Siedel.
2674
2675         Rename files as part of refactoring the layout_tests package. All
2676         the platform_utils* module, the path_utils.py module, and
2677         the http server and web socket server modules are moved into a new
2678         port/ package.
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=34511
2681
2682         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
2683         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
2684         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
2685         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
2686         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2687         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2688         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
2689         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
2690         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
2691         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
2692         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
2693         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
2694         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2695         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2696         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2697         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
2698         * Scripts/webkitpy/layout_tests/port: Added.
2699         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
2700         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
2701         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
2702         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
2703         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
2704         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
2705         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
2706         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
2707         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
2708         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
2709         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
2710         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2711         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2712         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2713         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2714         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2715         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2716
2717
2718 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2719
2720         Rubber-stamped by Eric Seidel.
2721
2722         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
2723         https://bugs.webkit.org/show_bug.cgi?id=34399
2724
2725         * Scripts/run-iexploder-tests:
2726         * Scripts/run-webkit-httpd:
2727         * Scripts/run-webkit-tests:
2728         * Scripts/webkitperl/httpd.pm: Added.
2729
2730 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2731
2732         Rubber-stamped by Eric Seidel.
2733
2734         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
2735
2736         * Scripts/run-iexploder-tests:
2737         * Scripts/run-webkit-httpd:
2738         * Scripts/run-webkit-tests:
2739         * Scripts/webkitperl/httpd.pm: Removed.
2740
2741 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2742
2743         Rubber-stamped by Ariya Hidayat.
2744
2745         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
2746         https://bugs.webkit.org/show_bug.cgi?id=34399
2747
2748         * DumpRenderTree/win/EventSender.cpp:
2749         (buildModifierFlags):
2750         (mouseDownCallback):
2751         (mouseUpCallback):
2752         (keyDownCallback):
2753
2754 2010-02-03  Eric Seidel  <eric@webkit.org>
2755
2756         No review, just fixing copyrights.
2757
2758         Concerns were expressed about "The Chromium Authors" being
2759         a valid legal entity for copyright assignment in the WebKit repository,
2760         so this change removes all "The Chromium Authors".
2761
2762         I looked at the svn logs in src.chromium.org and failed to find any
2763         non-google contributions to these files, so they are all now
2764         marked as copyright "Google Inc" as all Google contributers assign
2765         copyright to "Google Inc" as part of their employment agreement.
2766
2767         * Scripts/rebaseline-chromium-webkit-tests:
2768         * Scripts/run-chromium-webkit-tests:
2769         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
2770         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
2771         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
2772         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2773         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2774         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2775         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
2776         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
2777         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
2778         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
2779         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
2780         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2781         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2782         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2783         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2784         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
2785         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2786         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2787         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2788         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2789         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2790         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2791
2792 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2793
2794         Reviewed by Ariya Hidayat.
2795
2796         [Qt] QtLauncher, refactor argument handling in preparation of merge
2797         with QGVLauncher
2798
2799         * QtLauncher/main.cpp:
2800         (LauncherApplication::urls):
2801         (LauncherApplication::isRobotized):
2802         (LauncherApplication::applyDefaultSettings):
2803         (LauncherApplication::LauncherApplication):
2804         (LauncherApplication::formatKeys):
2805         (LauncherApplication::enumToKeys):
2806         (fail):
2807         (LauncherApplication::handleUserOptions):
2808         (main):
2809
2810 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2811
2812         Rubber-stamped by Ariya Hidayat.
2813
2814         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
2815         https://bugs.webkit.org/show_bug.cgi?id=34399
2816
2817         * DumpRenderTree/win/EventSender.cpp:
2818         (mouseDownCallback):
2819         (mouseUpCallback):
2820         (keyDownCallback):
2821
2822 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2823
2824         Reviewed by Ariya Hidayat.
2825
2826         [Qt] Fix pixel tests support.
2827         https://bugs.webkit.org/show_bug.cgi?id=27813
2828
2829         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2830         (WebCore::DumpRenderTree::open):
2831         (WebCore::DumpRenderTree::processLine):
2832          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
2833         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
2834
2835 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
2836
2837         Reviewed by Kevin Ollivier.
2838
2839         [wx] Enable JIT compilation for wx.
2840         
2841         https://bugs.webkit.org/show_bug.cgi?id=34536
2842
2843         * wx/build/settings.py:
2844
2845 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
2846
2847         [wx] Build fix after introduction of pageNumberForElementById.
2848
2849         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2850         (LayoutTestController::pageNumberForElementById):
2851
2852 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
2853
2854         Unreviewed.
2855
2856         Add myself to list of committers.
2857
2858         * Scripts/webkitpy/committers.py:
2859
2860 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
2861
2862         Reviewed by Shinichiro Hamaji.
2863
2864         Moved filter-related check-webkit-style code into a separate
2865         filter module.
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=34408
2868
2869         This is preparatory refactoring for Bug 33684, which will allow
2870         file and folder-specific filter rules.
2871
2872         * Scripts/webkitpy/style/checker.py:
2873           - Removed CategoryFilter class (moved to filter.py).
2874
2875         * Scripts/webkitpy/style/checker_unittest.py:
2876           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
2877
2878         * Scripts/webkitpy/style/filter.py: Added.
2879           - Added CategoryFilter class (moved from checker.py).
2880
2881         * Scripts/webkitpy/style/filter_unittest.py: Added.
2882           - Added CategoryFilter unit tests (moved from checker_unittest.py).
2883
2884         * Scripts/webkitpy/style/unittests.py:
2885           - Added reference to filter_unittest.py.
2886
2887 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
2888
2889         Reviewed by Shinichiro Hamaji.
2890
2891         Addressed FIXME in check-webkit-style so that the carriage-return
2892         check will work for patches.
2893
2894         https://bugs.webkit.org/show_bug.cgi?id=34260
2895
2896         Also added support for limiting the number of errors reported
2897         per category, per file.
2898
2899         * Scripts/webkitpy/style/checker.py:
2900           - Added new "whitespace/carriage_return" category from common.py.
2901           - Added MAX_REPORTS_PER_CATEGORY dictionary.
2902           - Added max_reports_per_category attribute to ProcessorOptions class.
2903           - Refactored StyleChecker._process_file().
2904
2905         * Scripts/webkitpy/style/checker_unittest.py:
2906           - Updated ProcessorOptionsTest tests.
2907           - Added test to check MAX_REPORTS_PER_CATEGORY.
2908
2909         * Scripts/webkitpy/style/error_handlers.py:
2910           - Added support for suppressing the display of errors after
2911             reaching a per-category maximum (from max_reports_per_category).
2912
2913         * Scripts/webkitpy/style/error_handlers_unittest.py:
2914           - Added test for suppressing error display.
2915
2916         * Scripts/webkitpy/style/processors/common.py: Added.
2917           - Moved carriage-return check to new file.
2918
2919         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
2920           - Added unit tests for carriage-return check.
2921
2922         * Scripts/webkitpy/style/unittests.py:
2923           - Added reference to common_unittest.py.
2924
2925 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2926
2927         Reviewed by Eric Seidel.
2928
2929         Provide a way to get page number with layoutTestController
2930         https://bugs.webkit.org/show_bug.cgi?id=33840
2931
2932         * DumpRenderTree/LayoutTestController.cpp:
2933         (pageNumberForElementByIdCallback):
2934         (LayoutTestController::staticFunctions):
2935         * DumpRenderTree/LayoutTestController.h:
2936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2937         (LayoutTestController::pageNumberForElementById):
2938         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2939         (LayoutTestController::pageNumberForElementById):
2940         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2941         (LayoutTestController::pageNumberForElementById):
2942
2943 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2944
2945         Unreviewed fix for an invalid function call.
2946
2947         check-webkit-style: Remove filename parameter from all functions where no longer used
2948         https://bugs.webkit.org/show_bug.cgi?id=34249
2949
2950         * Scripts/webkitpy/style/checker.py:
2951
2952 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2953
2954         Reviewed by Kenneth Rohde Christiansen.
2955
2956         [Qt] DRT Provide global flag ability
2957         https://bugs.webkit.org/show_bug.cgi?id=34418
2958
2959         Add the globalFlag property to the Qt LayoutTestController to allow
2960         cross-domain indications.
2961
2962         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2963         (LayoutTestController::reset):
2964         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2965         (LayoutTestController::globalFlag):
2966         (LayoutTestController::setGlobalFlag):
2967
2968 2010-02-01  Brady Eidson  <beidson@apple.com>
2969
2970         Reviewed by Adele Peterson.
2971
2972         Crash in Safari opening new tabs to "same page"
2973         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
2974
2975         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
2976
2977         * DumpRenderTree/LayoutTestController.cpp:
2978         (LayoutTestController::LayoutTestController):
2979         (setNewWindowsCopyBackForwardListCallback):
2980         (LayoutTestController::staticFunctions):
2981
2982         * DumpRenderTree/LayoutTestController.h:
2983         (LayoutTestController::newWindowsCopyBackForwardList):
2984         (LayoutTestController::setNewWindowsCopyBackForwardList):
2985
2986         * DumpRenderTree/mac/UIDelegate.mm:
2987         (-[UIDelegate webView:createWebViewWithRequest:]):
2988
2989 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
2990
2991         Unreviewed.
2992
2993         Add myself to list of committers.
2994
2995         * Scripts/webkitpy/committers.py:
2996
2997 2010-02-01  Nate Chapin  <japhet@chromium.org>
2998
2999         Rubber-stamped by David Levin.
3000
3001         Add myself to reviewer list.
3002
3003         * Scripts/webkitpy/committers.py:
3004
3005 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
3006
3007         Reviewed by Shinichiro Hamaji.
3008
3009         Moved style error handler code to their own classes, and
3010         related refactoring. Increased unit test code coverage of
3011         style error handling.
3012
3013         https://bugs.webkit.org/show_bug.cgi?id=34379
3014
3015         * Scripts/check-webkit-style:
3016           - Minor change: added error_count variable.
3017
3018         * Scripts/webkitpy/style/checker.py:
3019           - Renamed ProcessorOptions.should_report_error() to is_reportable().
3020           - In the StyleChecker class--
3021             - Removed _default_style_error_handler().
3022             - Added _increment_error_count().
3023             - Refactored to use DefaultStyleErrorHandler and
3024               PatchStyleErrorHandler constructors.
3025
3026         * Scripts/webkitpy/style/checker_unittest.py:
3027           - In the StyleStyleCheckerTest class--
3028             - Removed write_sample_error().
3029             - Removed test_default_style_error_handler().
3030
3031         * Scripts/webkitpy/style/error_handlers.py: Added.
3032           - Added DefaultStyleErrorHandler class.
3033           - Added PatchStyleErrorHandler class.
3034
3035         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
3036           - Added unit tests for DefaultStyleErrorHandler and
3037             PatchStyleErrorHandler.
3038
3039         * Scripts/webkitpy/style/unittests.py:
3040           - Added error_handlers unit tests.
3041
3042 2010-01-29  Mark Rowe  <mrowe@apple.com>
3043
3044         Rubber-stamped by Stephanie Lewis.
3045
3046         Fix run-leaks with newer versions of the leaks tool.
3047
3048         * Scripts/run-leaks:
3049
3050 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3051
3052         Reviewed by Eric Siedel.
3053
3054         Top-level test drivers for running the Chromium port of run-webkit-tests
3055         and being able to rebaseline test results from the test bots.  The
3056         files in the Scripts directory are simply wrappers around the files
3057         in webkitpy/layout_tests for convenience.
3058  
3059         https://bugs.webkit.org/show_bug.cgi?id=31498
3060
3061         * Scripts/rebaseline-chromium-webkit-tests: Added.
3062         * Scripts/run-chromium-webkit-tests: Added.
3063         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
3064         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
3065
3066 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3067
3068         Reviewed by Eric Siedel.
3069
3070         Add in the second block of python code for the Chromium port
3071         of run-webkit-tests. These files execute different diffs to classify
3072         the various types of failures from a test.
3073
3074         * Scripts/webkitpy/layout_tests/test_types: Added.
3075         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
3076         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
3077         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
3078         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
3079         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
3080
3081 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3082
3083         Reviewed by Eric Siedel.
3084
3085         Check in the first part of the Chromium Python port of the 
3086         run-webkit-tests test driver. The files under 
3087         layout_tests/layout_layout constitute most of the implementation;
3088         they can be roughly divided into code that parses the 
3089         "test_expectations.txt" file that describes how we expect tests to
3090         pass or fail, platform-specific hooks for the different Chromium 
3091         ports (in platform_utils*), code for parsing the output of the
3092         tests and generating results files and HTML and JSON for the
3093         dashboards, auxiliary scripts for starting and stopping HTTP and
3094         Web Socket servers, and then one of the actual driver files 
3095         (test_shell_thread). Code for actually parsing test output for 
3096         failures and the top-level driver scripts will follow shortly.
3097
3098         https://bugs.webkit.org/show_bug.cgi?id=31498
3099
3100         * Scripts/webkitpy/layout_tests: Added.
3101         * Scripts/webkitpy/layout_tests/layout_package: Added.
3102         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
3103         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
3104         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
3105         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
3106         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
3107           - scripts to start and stop apache. Note that the apache file
3108             generates a conf file dynamically, and we should switch to 
3109             using the same static conf file that the regular run-webkit-tests
3110             uses, and we can also use the same httpd2.pem file.
3111
3112         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
3113         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
3114           - scripts to generate the JSON layout test dashboard and the
3115             flakiness dashboard
3116         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
3117           - default configuration for LigHTTPd (used on Windows)
3118         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
3119           - utility class that implements progress bars on the console to
3120             be displayed while the tests are running
3121         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
3122           - various routines for manipulating paths and URIs
3123         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
3124         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
3125         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
3126         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
3127           - platform-specific aspects of the drivers (binary names, paths,
3128             process control, etc.)
3129         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
3130           - code for parsing the 'test_expectations.txt' file to determine
3131             which tests are expected to fail (and how) on which platforms
3132         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
3133           - code for handling different kinds of failures (generating output
3134             in the results, etc.)
3135         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
3136           - code to gather the lists of tests
3137         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
3138           - code to actually execute tests via TestShell and process
3139             the output
3140         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
3141           - scripts to start and stop the pywebsocket server
3142
3143 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3144
3145         Reviewed by Eric Seidel.
3146
3147         Check in a copy of the simplejson library; it will be used by
3148         the Chromium port of run-webkit-tests.
3149         
3150         https://bugs.webkit.org/show_bug.cgi?id=31498
3151
3152         * simplejson: Added.
3153         * simplejson/LICENSE.txt: Added.
3154         * simplejson/README.txt: Added.
3155         * simplejson/__init__.py: Added.
3156         * simplejson/_speedups.c: Added.
3157         (ascii_escape_char):
3158         (ascii_escape_unicode):
3159         (ascii_escape_str):
3160         (py_encode_basestring_ascii):
3161         (init_speedups):
3162         * simplejson/decoder.py: Added.
3163         * simplejson/encoder.py: Added.
3164         * simplejson/jsonfilter.py: Added.
3165         * simplejson/scanner.py: Added.
3166
3167 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
3168
3169         No review
3170
3171         Add myself to the committers list
3172
3173         * Scripts/webkitpy/committers.py:
3174
3175 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
3176
3177         Reviewed by Dimitri Glazkov.
3178
3179         A first step towards the Indexed Database API
3180         https://bugs.webkit.org/show_bug.cgi?id=34342
3181
3182         Add indexed database API.
3183
3184         * Scripts/build-webkit:
3185
3186 2010-01-29  Andras Becsi  <abecsi@webkit.org>
3187
3188         Reviewed by Alexey Proskuryakov.
3189
3190         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
3191         This fixes a regression introduced in r53559.
3192
3193         https://bugs.webkit.org/show_bug.cgi?id=34336
3194
3195         * Scripts/webkitperl/httpd.pm:
3196
3197 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
3198
3199         MSAA: Crash when posting a notification for a detached object
3200
3201         https://bugs.webkit.org/show_bug.cgi?id=34309
3202         <rdar://problem/7409759>
3203
3204         Reviewed by Darin Adler.
3205
3206         * DumpRenderTree/AccessibilityController.h:
3207         Declare new functions. Add new members to store the event hook and the
3208         mapping of accessibility elements to their JS callbacks.
3209
3210         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3211         (AccessibilityController::notificationReceived):
3212         Stubbed.
3213         (AccessibilityController::addNotificationListener):
3214         Stubbed.
3215
3216         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3217         (AccessibilityController::notificationReceived):
3218         Stubbed.
3219         (AccessibilityController::addNotificationListener):
3220         Stubbed.
3221
3222         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3223         (AccessibilityController::AccessibilityController):
3224         Initialize the event hook.
3225         (AccessibilityController::~AccessibilityController):
3226         Remove the event hook. Unprotect all of the JS functions that are stored
3227         in the map.
3228         (logEventProc):
3229         Clean-up a variable.
3230         (stringEvent):
3231         Return a string description of the MSAA event code.
3232         (notificationListenerProc):
3233         Get the accessible object from the event, and query it for IAccessible.
3234         Call the AccessibilityController's notificationReceived().
3235         (comparableObject):
3236         Use QueryService to obtain the IAccessibleComparable for the
3237         IServiceProvider.
3238         (AccessibilityController::notificationReceived):
3239         Iterate the map of objects that have registered for notification
3240         callbacks. Query each for IServiceProvider, then use comparableObject()
3241         to get an IAccessibleComparable. If we find an object matching the
3242         notified object, call its callback, passing the event that was received.
3243         (AccessibilityController::addNotificationListener):
3244         If we have not created the event hook, create it. Protect the JS
3245         callback function object, and add the object and its callback to our
3246         map.
3247
3248         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3249         (AccessibilityUIElement::addNotificationListener):
3250         Call through to the AccessibilityController's addNotificationListener().
3251
3252         * DumpRenderTree/win/DumpRenderTreeWin.h:
3253         Add an extern declaration for the shared FrameLoadDelegate extern, so we
3254         can access it from AccessibilityController.
3255
3256         * DumpRenderTree/win/FrameLoadDelegate.h:
3257         (FrameLoadDelegate::accessibilityController):
3258         Return the AccessibilityController.
3259
3260 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
3261
3262         Reviewed by Darin Adler.
3263
3264         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
3265         https://bugs.webkit.org/show_bug.cgi?id=34313
3266
3267         * Scripts/prepare-ChangeLog:
3268
3269 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3270
3271         Rubberstamped by Simon Hausmann.
3272
3273         [Qt] Separate implementation from class definition.
3274
3275         * QtLauncher/main.cpp:
3276         (LauncherWindow::webView):
3277         (LauncherWindow::LauncherWindow):
3278         (LauncherWindow::~LauncherWindow):
3279         (LauncherWindow::keyPressEvent):
3280         (LauncherWindow::grabZoomKeys):
3281         (LauncherWindow::sendTouchEvent):
3282         (LauncherWindow::eventFilter):
3283         (LauncherWindow::loadStarted):
3284         (LauncherWindow::loadFinished):
3285         (LauncherWindow::showLinkHover):
3286         (LauncherWindow::zoomIn):
3287         (LauncherWindow::zoomOut):
3288         (LauncherWindow::resetZoom):
3289         (LauncherWindow::toggleZoomTextOnly):
3290         (LauncherWindow::print):
3291         (LauncherWindow::screenshot):
3292         (LauncherWindow::setEditable):
3293         (LauncherWindow::dumpHtml):
3294         (LauncherWindow::selectElements):
3295         (LauncherWindow::setTouchMocking):
3296         (LauncherWindow::newWindow):
3297         (LauncherWindow::setupUI):
3298
3299 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3300
3301         Reviewed by Ariya Hidayat.
3302
3303         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
3304         should result in all text selected.
3305
3306         * QtLauncher/locationedit.cpp:
3307         (LocationEdit::focusInEvent):
3308         * QtLauncher/locationedit.h:
3309
3310 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3311
3312         Reviewed by Ariya Hidayat.
3313
3314         [Qt] Show progress reaching 100% for loads.
3315
3316         * QtLauncher/locationedit.cpp:
3317         (LocationEdit::LocationEdit):
3318         (LocationEdit::setProgress):
3319         (LocationEdit::reset):
3320         (LocationEdit::paintEvent):
3321         * QtLauncher/locationedit.h:
3322
3323 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
3324
3325         Reviewed by Kenneth Rohde Christiansen.
3326
3327         [Qt] Disable the QtLauncher statusbar on Maemo
3328
3329         https://bugs.webkit.org/show_bug.cgi?id=34330
3330
3331         * QtLauncher/main.cpp:
3332         (LauncherWindow::showLinkHover):
3333         (LauncherWindow::selectElements):
3334
3335 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
3336
3337         Reviewed by Kenneth Rohde Christiansen.
3338
3339         [Qt] Display page loading progress inside the QtLauncher location bar
3340
3341         https://bugs.webkit.org/show_bug.cgi?id=34210
3342
3343         * QtLauncher/QtLauncher.pro:
3344         * QtLauncher/locationedit.cpp: Added.
3345         (LocationEdit::LocationEdit):
3346         (LocationEdit::setProgress):
3347         (LocationEdit::paintEvent):
3348         * QtLauncher/locationedit.h: Added.
3349         * QtLauncher/mainwindow.cpp:
3350         (MainWindow::buildUI):
3351         * QtLauncher/mainwindow.h:
3352
3353 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
3354
3355         Reviewed by Kenneth Rohde Christiansen.
3356
3357         [Qt] Add support for Maemo zoom keys in QtLauncher
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=34160
3360
3361         * QtLauncher/main.cpp:
3362         (LauncherWindow::LauncherWindow):
3363         (LauncherWindow::~LauncherWindow):
3364         (LauncherWindow::keyPressEvent):
3365         (LauncherWindow::grabZoomKeys):
3366
3367 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
3368
3369         Reviewed by Kenneth Rohde Christiansen.
3370
3371         [Qt] Implement the display() method of the layout test controller
3372         https://bugs.webkit.org/show_bug.cgi?id=34258
3373
3374         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3375         (WebCore::DumpRenderTree::DumpRenderTree):
3376         (WebCore::DumpRenderTree::showPage):
3377         (WebCore::DumpRenderTree::hidePage):
3378         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3379         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3380         (LayoutTestController::reset):
3381         (LayoutTestController::display):
3382         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3383
3384 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
3385
3386         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
3387         implements pthread_t in a way that makes it impossible to check its validity,
3388         which is needed by ThreadingPthreads.cpp.
3389
3390         * DumpRenderTree/wscript:
3391         * wx/build/settings.py:
3392
3393 2010-01-28  Andras Becsi  <abecsi@webkit.org>
3394
3395         Adding myself to the committer list. No review needed.
3396
3397         * Scripts/webkitpy/committers.py:
3398
3399 2010-01-28  Hayato Ito  <hayato@chromium.org>
3400
3401         Reviewed by David Levin.
3402
3403         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
3404
3405         https://bugs.webkit.org/show_bug.cgi?id=34252
3406
3407         * Scripts/make-script-test-wrappers:
3408
3409 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
3410
3411         [wx] Build fix after removal of the zlib image decoder.
3412
3413         * wx/build/settings.py:
3414
3415 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
3416
3417         [Qt] Unreviewed, roll out r54000.
3418
3419         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3420         (WebCore::DumpRenderTree::DumpRenderTree):
3421         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3422         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3423         (LayoutTestController::reset):
3424         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3425         (LayoutTestController::display):
3426
3427 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
3428
3429         Reviewed by Kenneth Rohde Christiansen.
3430
3431         [Qt] Implement the display() method of the layout test controller
3432         https://bugs.webkit.org/show_bug.cgi?id=34258
3433
3434         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3435         (WebCore::DumpRenderTree::DumpRenderTree):
3436         (WebCore::DumpRenderTree::showPage):
3437         (WebCore::DumpRenderTree::hidePage):
3438         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3439         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3440         (LayoutTestController::reset):
3441         (LayoutTestController::display):
3442         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3443
3444 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
3445
3446         Reviewed by Shinichiro Hamaji.
3447
3448         Eliminated the filename parameter from functions in
3449         check-webkit-style's cpp.py where it is no longer used.
3450
3451         https://bugs.webkit.org/show_bug.cgi?id=34249
3452
3453         * Scripts/webkitpy/style/processors/cpp.py:
3454           - Reduced number of occurrences of "filename" variable from
3455             approximately 200 to 120.
3456
3457         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3458           - Refactored unit tests as necessary to accommodate changes to cpp.py.
3459           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
3460             where the incorrect file extension was getting passed to
3461             cpp_style.check_language().
3462
3463 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
3464
3465         Reviewed by Shinichiro Hamaji.
3466
3467         In check-webkit-style, eliminated the dependency of
3468         processors/cpp_unittest.py on checker.py.
3469
3470         https://bugs.webkit.org/show_bug.cgi?id=34205
3471
3472         * Scripts/webkitpy/style/checker.py:
3473           - Addressed FIXME by removing STYLE_CATEGORIES data.
3474           - Added style_categories().
3475
3476         * Scripts/webkitpy/style/checker_unittest.py:
3477           - Minor changes.
3478
3479         * Scripts/webkitpy/style/processors/cpp.py:
3480           - Added categories attribute to CppProcessor class (data
3481             was originally checker.STYLE_CATEGORIES).
3482
3483         * Scripts/webkitpy/style/processors/cpp_unittest.py:
3484           - Addressed FIXME by eliminating "import" from checker.py.
3485
3486 2010-01-28  Anton Muhin  <antonm@chromium.org>
3487
3488         Reviewed by Shinichiro Hamaji.
3489
3490         Improve treatment of conditions and rest of the line for if, else, switch and alikes
3491         https://bugs.webkit.org/show_bug.cgi?id=34173
3492
3493         * Scripts/webkitpy/style/cpp_style.py:
3494         * Scripts/webkitpy/style/cpp_style_unittest.py:
3495
3496 2010-01-28  Joe Mason  <jmason@rim.com>
3497
3498         Reviewed by Adam Barth.
3499
3500         Limit login retries to 5
3501         https://bugs.webkit.org/show_bug.cgi?id=34193
3502
3503         * Scripts/webkitpy/bugzilla.py:
3504
3505 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
3506
3507         Adding myself to the committer list. No review necessary.
3508
3509         * Scripts/webkitpy/committers.py:
3510
3511 2010-01-27  George Wright  <gwright@rim.com>
3512
3513         Reviewed by Adam Treat.
3514
3515         https://bugs.webkit.org/show_bug.cgi?id=34216
3516
3517         Add missing include for wtf/Platform.h
3518
3519         * DumpRenderTree/AccessibilityController.h:
3520
3521 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3522
3523         Reviewed by Kenneth Rohde Christiansen.
3524
3525         [Qt] DRT Provide worker thread ability to track counters
3526         https://bugs.webkit.org/show_bug.cgi?id=34221
3527
3528         Implement workerThreadCount() in LayoutTestController of Qt DRT
3529
3530         Tests:
3531         fast/workers/dedicated-worker-lifecycle.html
3532         fast/workers/shared-worker-frame-lifecycle.html
3533         fast/workers/shared-worker-lifecycle.html
3534         fast/workers/worker-lifecycle.html
3535
3536         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3537         (LayoutTestController::workerThreadCount):
3538         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3539
3540 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3541
3542         Rubberstamped by Simon Hausmann.
3543
3544         [Qt] QtLauncher refactoring:
3545
3546         Make the LauncherWindow depend less on the view, so that more
3547         code can be shared in near future.
3548
3549         * QtLauncher/main.cpp:
3550         (LauncherWindow::sendTouchEvent):
3551         (LauncherWindow::loadFinished):
3552         (LauncherWindow::zoomIn):
3553         (LauncherWindow::zoomOut):
3554         (LauncherWindow::resetZoom):
3555         (LauncherWindow::toggleZoomTextOnly):
3556         (LauncherWindow::dumpHtml):
3557         (LauncherWindow::selectElements):
3558         (LauncherWindow::setupUI):
3559
3560 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
3561
3562         Reviewed by Eric Seidel.
3563
3564         Correctly handle the KeyLocation argument that has been introduced
3565         recently to test location-dependent key events in EventSender.keyDown.
3566         http://bugs.webkit.org/show_bug.cgi?id=28247
3567
3568         Test: fast/events/keydown-numpad-keys.html
3569
3570         * DumpRenderTree/gtk/EventSender.cpp:
3571         (keyDownCallback):
3572
3573 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3574
3575         Rubberstamped by Simon Hausmann.
3576
3577         [Qt] QtLauncher refactoring:
3578
3579         Move out code from the MainWindow (renamed to LauncherWindow)
3580         that is not depending on the view, and add it to a new class
3581         called MainWindow.
3582
3583         * QtLauncher/QtLauncher.pro:
3584         * QtLauncher/main.cpp:
3585         (LauncherWindow::LauncherWindow):
3586         (LauncherWindow::eventFilter):
3587         (LauncherWindow::loadStarted):
3588         (LauncherWindow::loadFinished):
3589         (LauncherWindow::newWindow):
3590         (LauncherWindow::setupUI):
3591         (WebPage::createWindow):
3592         (main):
3593         * QtLauncher/mainwindow.cpp: Added.
3594         (MainWindow::MainWindow):
3595         (MainWindow::buildUI):
3596         (MainWindow::page):
3597         (MainWindow::setAddressUrl):
3598         (MainWi