20ea2f6e2ce78e5544c3930c4a0818673b5b4bd7
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-04-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2
3         Rubber-stamped by Tor Arne Vestbø.
4
5         Add /Programs to the productDir for GTK+, instead of adding
6         /JavaScriptCore, when running jsc.
7
8         * Scripts/run-sunspider:
9
10 2009-04-04  Kevin Ollivier  <kevino@theolliviers.com>
11
12         Build fixes for wxMac/Tiger and PPC builds.
13
14         * wx/build-wxwebkit:
15
16 2009-04-04  Kevin Ollivier  <kevino@theolliviers.com>
17
18         wx build fix. Update the version of ICU dlls.
19
20         * wx/build-wxwebkit:
21
22 2009-04-03  Stephanie Lewis  <slewis@apple.com>
23
24         Reviewed by Mark Rowe.
25
26         Fix running DumpRenderTree with a root.
27
28         * Scripts/run-webkit-tests:
29
30 2009-04-02  Adam Roben  <aroben@apple.com>
31
32         Build fix for Windows machines that don't have WebKitTools/Scipts in
33         their PATH
34
35         * Scripts/pdevenv: Add WebKitTools/Scripts to PATH when launching
36         Visual Studio/VC++ Express.
37
38 2009-04-02  Adam Roben  <aroben@apple.com>
39
40         Use pdevenv when building .vcproj files via our scripts
41
42         Reviewed by Mark Rowe.
43
44         * Scripts/webkitdirs.pm:
45         (sub buildVisualStudioProject): Use pdevenv instead of invoking Visual
46         Studio/VC++ Express directly.
47
48 2009-04-01  Mark Rowe  <mrowe@apple.com>
49
50         Windows support for built-product-archive.
51
52         * BuildSlaveSupport/built-product-archive:
53
54 2009-03-31  Adam Roben  <aroben@apple.com>
55
56         Make resolve-ChangeLogs -f work when the working tree has spaces in
57         its path
58
59         Reviewed by Mark Rowe and David Kilzer.
60
61         * Scripts/resolve-ChangeLogs:
62         (sub fixMergedChangeLogs): Quote the path to resolve-ChangeLogs in
63         case it contains spaces.
64
65 2009-03-31  Alexey Proskuryakov  <ap@webkit.org>
66
67         Reviewed by Darin Adler.
68
69         https://bugs.webkit.org/show_bug.cgi?id=24777
70         WebKit tools are broken on Tiger
71
72         * Scripts/webkitdirs.pm: Don't use arch command with options on Tiger.
73
74 2009-03-31  Darin Adler  <darin@apple.com>
75
76         * Scripts/add-include: Added.
77
78 2009-03-31  Mark Rowe  <mrowe@apple.com>
79
80         Fix use of incorrect constant.
81
82         * BuildSlaveSupport/built-product-archive:
83
84 2009-03-30  Mark Rowe  <mrowe@apple.com>
85
86         Rubber-stamped by Stephanie Lewis.
87
88         Add a script in support of the new build.webkit.org configuration.
89
90         * BuildSlaveSupport/built-product-archive: Added.
91
92 2009-03-30  Darin Adler  <darin@apple.com>
93
94         Reviewed by Sam Weinig.
95
96         Make policy-delegate logging work even for local files by processing the URLs as we
97         do for other delegates.
98
99         * DumpRenderTree/mac/PolicyDelegate.mm:
100         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
101         Use _drt_descriptionSuitableForTestResult on the URL.
102
103         * DumpRenderTree/win/PolicyDelegate.cpp:
104         (PolicyDelegate::decidePolicyForNavigationAction): Use urlSuitableForTestResult on the URL.
105
106 2009-03-30  Adam Roben  <aroben@apple.com>
107
108         Windows build fix
109
110         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
111         (LayoutTestController::waitForPolicyDelegate): Added this empty stub.
112
113         * DumpRenderTree/win/WorkQueueItemWin.cpp:
114         (LoadItem::invoke):
115         (ScriptItem::invoke):
116         Changed to use data members instead of removed member functions.
117
118 2009-03-30  Jan Michael Alonzo  <jmalonzo@webkit.org>
119
120         Gtk DRT build fix per changeset
121         http://trac.webkit.org/changeset/42082. Not reviewed.
122
123         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
124         (LoadItem::invoke):
125         (ScriptItem::invoke):
126
127 2009-03-29  Darin Adler  <darin@apple.com>
128
129         * DumpRenderTree/qt/jsobjects.cpp: Rolled out changes to this file. Maybe this will fix
130         Qt building of DumpRenderTree.
131
132 2009-03-29  Darin Adler  <darin@apple.com>
133
134         Reviewed by Cameron Zwarich.
135
136         Bug 24922: change WorkQueue-based navigation tests to not depend on synchronous form submission
137         https://bugs.webkit.org/show_bug.cgi?id=24922
138
139         Don't rely on delegate methods to guess whether a queued step starts a load or not, because
140         script-triggered loads can't be detected that way. Instead have the steps themselves indicate
141         whether or not a load was triggered.
142
143         * DumpRenderTree/LayoutTestController.cpp:
144         (queueLoadingScriptCallback): Added. Version for scripts that perform loads.
145         (queueNonLoadingScriptCallback): Added. Version for scripts that do not perform loads.
146         (LayoutTestController::staticFunctions): Replaced queueScript with queueLoadingScript and
147         queueNonLoadingScript.
148         (LayoutTestController::queueBackNavigation): Moved here since it's platform-independent now.
149         (LayoutTestController::queueForwardNavigation): Ditto.
150         (LayoutTestController::queueLoadingScript): Replacement for queueScript. Here since it's
151         platform-independent.
152         (LayoutTestController::queueNonLoadingScript): Ditto.
153         (LayoutTestController::queueReload): Moved here since it's platform-independent now.
154         * DumpRenderTree/LayoutTestController.h: Ditto.
155
156         * DumpRenderTree/WorkQueue.cpp:
157         (WorkQueue::processWork): Added. Shared by the different platform's work queue implementations.
158         * DumpRenderTree/WorkQueue.h: Ditto.
159
160         * DumpRenderTree/WorkQueueItem.h: Changed the invoke function to return true if the item
161         started a load. Removed unused getter functions. Made invoke functions private.
162         Added LoadingScriptItem and NonLoadingScriptItem, making ScriptItem an abstract base.
163
164         * DumpRenderTree/gtk/DumpRenderTree.cpp:
165         (processWork): Use the new WorkQueue::processWork function to implement the new rule.
166         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed queue functions that are now
167         platform-independent and in LayoutTestController.cpp.
168         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
169         (LoadItem::invoke): Return true.
170         (ReloadItem::invoke): Ditto.
171         (ScriptItem::invoke): Ditto.
172         (BackForwardItem::invoke): Ditto.
173
174         * DumpRenderTree/mac/FrameLoadDelegate.mm:
175         (-[FrameLoadDelegate processWork:]): Use the new WorkQueue::processWork function to implement
176         the new rule.
177         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed queue functions that are now
178         platform-independent and in LayoutTestController.cpp.
179         * DumpRenderTree/mac/WorkQueueItemMac.mm:
180         (LoadItem::invoke): Return true.
181         (ReloadItem::invoke): Ditto.
182         (ScriptItem::invoke): Ditto.
183         (BackForwardItem::invoke): Ditto.
184
185         * DumpRenderTree/qt/jsobjects.cpp:
186         (LayoutTestController::processWork): Use the new WorkQueue::processWork function to implement
187         the new rule. Removed queue functions that are now platform-independent and in
188         LayoutTestController.cpp.
189
190         * DumpRenderTree/win/FrameLoadDelegate.cpp:
191         (FrameLoadDelegate::processWork): Use the new WorkQueue::processWork function to implement
192         the new rule.
193         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed queue functions that are now
194         platform-independent and in LayoutTestController.cpp.
195         * DumpRenderTree/win/WorkQueueItemWin.cpp:
196         (LoadItem::invoke): Return false when we fail, true when we succeed.
197         (ReloadItem::invoke): Ditto.
198         (ScriptItem::invoke): Ditto.
199         (BackForwardItem::invoke): Ditto.
200
201 2009-03-28  Kevin Ollivier  <kevino@theolliviers.com>
202
203         Reviewed by Eric Seidel.
204         
205         Always use wxGraphicsContext on Mac to ensure path, matrix, etc. support.
206
207         * wx/build-wxwebkit:
208
209 2009-03-27  Darin Adler  <darin@apple.com>
210
211         Reviewed by Sam Weinig.
212
213         * Scripts/extract-localizable-strings: Fixed version check for perl 5.10 compatibility.
214
215 2009-03-27  Darin Adler  <darin@apple.com>
216
217         Reviewed by Sam Weinig.
218
219         Added waitForPolicyDelegate, a more-reliable way to make our mailto form submission
220         tests work.
221
222         * DumpRenderTree/AccessibilityController.cpp:
223         (getFocusedElementCallback): Use static_cast instead of reinterpret_cast because there's
224         no reason to use reinterpret_cast just to get from void* to a specific type.
225         (getRootElementCallback): Ditto.
226         * DumpRenderTree/AccessibilityUIElement.cpp:
227         (toAXElement): Ditto.
228         * DumpRenderTree/GCController.cpp:
229         (collectCallback): Ditto.
230         (collectOnAlternateThreadCallback): Ditto.
231         (getJSObjectCountCallback): Ditto.
232         * DumpRenderTree/LayoutTestController.cpp:
233         (many functions):  Ditto.
234         (waitForPolicyDelegateCallback): Added.
235         (LayoutTestController::staticFunctions): Sorted functions by name.
236         Added waitForPolicyDelegate.
237
238         * DumpRenderTree/LayoutTestController.h: Sorted functions by name.
239         Added waitForPolicyDelegate.
240
241         * DumpRenderTree/mac/DumpRenderTree.mm:
242         (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
243         policy delegate.
244         (runTest): Added an additional call to resetWebViewToConsistentStateBeforeTesting just
245         before loading an empty page. This prevents extra policy delegate calls from being logged.
246
247         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
248         (LayoutTestController::waitForPolicyDelegate): Added. Puts us into wait mode, and then
249         tells the policy delegate to notify when done, then points the web view at the policy delegate.
250
251         * DumpRenderTree/mac/PolicyDelegate.h: Added setControllerToNotifyDone: method.
252
253         * DumpRenderTree/mac/PolicyDelegate.mm:
254         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
255         Added code to do notifyDone if controllerToNotifyDone is set.
256         (-[PolicyDelegate setControllerToNotifyDone:]): Added.
257
258         * DumpRenderTree/win/DumpRenderTree.cpp:
259         (resetWebViewToConsistentStateBeforeTesting): Added code to reset the state of the
260         policy delegate. Also moved the call to resetUndoManager in here.
261         (runTest): Removed the call to resetUndoManager (see above). Added an additional call to
262         resetWebViewToConsistentStateBeforeTesting to match the Mac code.
263
264         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
265         (LayoutTestController::setCustomPolicyDelegate): 0, not NULL.
266
267         * DumpRenderTree/win/PolicyDelegate.cpp:
268         (PolicyDelegate::PolicyDelegate): Initialize m_controllerToNotifyDone to 0.
269         (PolicyDelegate::decidePolicyForNavigationAction): Added code to do notifyDone if
270         m_controllerToNotifyDone is set.
271
272         * DumpRenderTree/win/PolicyDelegate.h: Added setControllerToNotifyDone and
273         m_controllerToNotifyDone.
274
275 2009-03-27  Sam Weinig  <sam@webkit.org>
276
277         Reviewed by Gavin Barraclough.
278
279         Fix for https://bugs.webkit.org/show_bug.cgi?id=24765
280         prepare-ChangeLog and svn-create-patch doesn't work with svn 1.6
281
282         * Scripts/prepare-ChangeLog:
283         * Scripts/svn-create-patch:
284
285 2009-03-26  Darin Adler  <darin@apple.com>
286
287         Reviewed by Geoff Garen.
288
289         * Scripts/do-webcore-rename:Update for rename of JSUnprotectedEventListener to
290         JSEventListener.
291
292 2009-03-26  Darin Adler  <darin@apple.com>
293
294         Reviewed by Geoff Garen.
295
296         * Scripts/do-webcore-rename: Update for rename of JSEventListener to
297         JSProtectedEventListener. This includes all the related renames, but
298         not that one because that one renames the file.
299
300 2009-03-26  Adam Roben  <aroben@apple.com>
301
302         Reduce run-webkit-tests's time out limit to 15 seconds (or 2.5 minutes
303         under GuardMalloc)
304
305         The previous limit was 60 seconds (or 10 minutes under GuardMalloc).
306         There's no evidence that we need the limit to be this long, and having
307         it be so long just makes timed-out tests take forever to complete.
308         DRT's watchdog timer is 10 seconds, so still has time to fire before
309         run-webkit-tests will cut it off.
310
311         Reviewed by Simon Fraser.
312
313         * Scripts/run-webkit-tests:
314         (sub readFromDumpToolWithTimer): Reduced the limit to 15 seconds (or
315         2.5 mintues under GuardMalloc).
316
317 2009-03-26  Adam Roben  <aroben@apple.com>
318
319         Make DRT's watchdog timer actually work on Windows
320
321         We were previously trying to use a CFRunLoopTimer for the watchdog
322         timer on Windows. This doesn't work because we don't use a CFRunLoop
323         on the main thread on Windows.
324
325         This patch changes the watchdog timer on Windows be a normal Windows
326         timer.
327
328         Reviewed by Simon Fraser.
329
330         * DumpRenderTree/DumpRenderTree.h: Moved declaration of
331         waitToDumpWatchdog from here...
332         * DumpRenderTree/mac/DumpRenderTreeMac.h: ...to here.
333
334         * DumpRenderTree/win/DumpRenderTree.cpp:
335         (invalidateAnyPreviousWaitToDumpWatchdog): Added. This function
336         cancels an existing watchdog timer.
337         (dump): Call invalidateAnyPreviousWaitToDumpWatchdog. This will
338         prevent watchdogs from previous tests firing during subsequent ones.
339         This matches Mac's behavior.
340
341         * DumpRenderTree/win/DumpRenderTreeWin.h: Added a declaration of
342         waitToDumpWatchdog.
343
344         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
345         (waitUntilDoneWatchdogFired): Converted this to be a Windows
346         TIMERPROC.
347         (LayoutTestController::setWaitToDump): Changed to use SetTimer instead
348         of CFRunLoopAddTimer.
349
350 2009-03-25  Mark Rowe  <mrowe@apple.com>
351
352         Rubber-stamped by Steve Falkenburg.
353
354         Update test result search path for Windows now that it has updated versions of ICU, libxml2, and friends.
355
356         * Scripts/run-webkit-tests:
357
358 2009-03-24  Mark Rowe  <mrowe@apple.com>
359
360         Fix the Tiger build some more.
361
362         * DumpRenderTree/mac/TextInputController.m:
363
364 2009-03-24  Mark Rowe  <mrowe@apple.com>
365
366         Fix the Tiger build.
367
368         * DumpRenderTree/mac/TextInputController.m:
369
370 2009-03-24  Mark Rowe  <mrowe@apple.com>
371
372         Reviewed by Jon "The Most Boring Man in the World" Honeycutt.
373
374         Explicitly map NSNotFound to -1 so that the result of-characterIndexForPointX:Y: does
375         not differ between 32- and 64-bit.
376
377         * DumpRenderTree/mac/TextInputController.m:
378         (-[TextInputController characterIndexForPointX:Y:]):
379
380 2009-03-24  Mark Rowe  <mrowe@apple.com>
381
382         Reviewed by Sam Weinig.
383
384         Use a different platform search path for tests and skip lists, so that Tiger doesn't end up
385         using the Leopard skip list.  Tests and skip lists are now looked for in the directory for
386         the current OS and the generic "mac" directory.  Tests and skip lists for newer OS versions are
387         ignored.
388
389         * Scripts/run-webkit-tests:
390
391 2009-03-23  Stephanie  <slewis@apple.com>
392
393         Fix root build.
394
395         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
396
397 2009-03-23  Stephanie Lewis  <slewis@apple.com>
398
399         Reviewed by Mark Rowe.
400
401         Add production configuration for creating roots of WebKitTools.
402
403         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
404
405 2009-03-23  Oliver Hunt  <oliver@apple.com>
406
407         Reviewed by Geoff Garen.
408
409         Make testapi run as part of the standard JavaScriptCore tests.
410
411         We only run testapi on the mac as currently windows webkit doesn't
412         place all the necessary files for testapi, and we also test the
413         JSC/CF APIs as well.
414
415         * Scripts/run-javascriptcore-tests:
416
417 2009-03-21  Oliver Hunt  <oliver@apple.com>
418
419         Reviewed by Mark Rowe.
420
421         Make build-jsc build testapi and minidom in addition to jsc itself.
422
423         * Scripts/build-jsc:
424
425 2009-03-20  Anders Carlsson  <andersca@apple.com>
426
427         Reviewed by Darin Adler.
428
429         Only release the result NPVariant if the call to NPN_Invoke was successful.
430         
431         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
432         (testNPRuntime):
433
434 2009-03-19  Gustavo Noronha Silva  <gns@gnome.org>
435
436         Reviewed by Mark Rowe.
437
438         Make determinePassedArchitecture always consume the --32-bit
439         option, also in non-AppleMacWebkit platforms. Solution pointed out
440         by Mark Rowe.
441
442         * Scripts/webkitdirs.pm:
443
444 2009-03-19  Mark Rowe  <mrowe@apple.com>
445
446         Reviewed by Oliver Hunt.
447
448         Work around <rdar://problem/6698023> by activating fonts from disk.
449
450         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Copy fonts into DumpRenderTree.resources
451         in the built products directory.
452         * DumpRenderTree/mac/DumpRenderTree.mm:
453         (activateFonts): Activate the fonts from disk.
454
455 2009-03-18  Mark Rowe  <mrowe@apple.com>
456
457         Reviewed by Dan Bernstein.
458
459         <rdar://problem/6693300> Don't rely on printf from TestNetscapePlugIn appearing in test results
460
461         Switch from using printf to using the NPAPI to invoke console.log so that plug-in messages appear
462         in test results even when the plug-in's stdout differs from DumpRenderTree's stdout.
463
464         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
465         (log): Invoke console.log via the NPAPI.
466         (NPP_Destroy): Call log instead of printf.
467         (NPP_SetWindow): Ditto.
468         (handleEventCarbon): Ditto.
469         (handleEventCocoa): Ditto.
470         (NPP_HandleEvent): Pass the instance in to the event handler.
471
472 2009-03-17  Mark Rowe  <mrowe@apple.com>
473
474         Reviewed by Oliver Hunt.
475
476         Use the normal search rules for tests inside the platform directory.
477
478         This allows tests inside the platform directory to have different results
479         on different versions of Mac OS X.
480
481         * Scripts/run-webkit-tests:
482
483 2009-03-17  David Kilzer  <ddkilzer@apple.com>
484
485         resolve-ChangeLogs should not die on unmerged non-ChangeLog files
486
487         Reviewed by Adam Roben.
488
489         Fixes the following bug in resolve-ChangeLogs:
490
491             Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
492             Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.
493
494         * Scripts/resolve-ChangeLogs:
495         (findUnmergedChangeLogs): Check the result of findChangeLog() to
496         make sure we don't add undef values to the list of files being
497         returned.
498
499 2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>
500
501         Reviewed by Simon Fraser.
502
503         Fix the usage of the $architecture variable for non-Apple-Mac
504         ports.
505
506         * Scripts/webkitdirs.pm:
507
508 2009-03-17  David Kilzer  <ddkilzer@apple.com>
509
510         Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string)
511
512         <https://bugs.webkit.org/show_bug.cgi?id=24645>
513
514         Reviewed by Mark Rowe.
515
516         * Scripts/bisect-builds:
517         (makeNightlyList): Added checks for Safari 4 Public Beta on
518         Tiger and Leopard.
519
520 2009-03-17  Simon Fraser  <simon.fraser@apple.com>
521
522         Reviewed by Darin Adler
523
524         https://bugs.webkit.org/show_bug.cgi?id=24396
525
526         Change the terminology from '3D transforms' to '3D rendering'.
527
528         * Scripts/build-webkit:
529         * Scripts/run-webkit-tests:
530         * Scripts/webkitdirs.pm:
531
532 2009-03-17  Gustavo Noronha Silva  <gns@gnome.org>
533
534         Reviewed by Mark Rowe.
535
536         Enable HTML5 media elements support by default also for the GTK+
537         port.
538
539         * Scripts/build-webkit:
540
541 2009-03-17  Kevin Ollivier  <kevino@theolliviers.com>
542
543         Reviewed by Mark Rowe.
544         
545         Tweak the BUILDING_ON_* defines so that they work with the default values set by
546         AvailabilityMacros.h.
547         
548         https://bugs.webkit.org/show_bug.cgi?id=24630
549
550         * DumpRenderTree/mac/DumpRenderTreeMac.h:
551
552 2009-03-17  Oliver Hunt  <oliver@apple.com>
553
554         Reviewed by Alexey Proskuryakov.
555
556         Make coverage testing more reliable by ensuring --coverage does not
557         clobber configuration settings, and by removing the unnecessary 
558         dependency on matplotlib.
559
560         * CodeCoverage/regenerate-coverage-display:
561         * Scripts/webkitdirs.pm:
562
563 2009-03-16  Anders Carlsson  <andersca@apple.com>
564
565         Reviewed by Darin Adler and John Sullivan.
566
567         When a plug-in instance is torn down, all plug-in objects will first be invalidated and then deallocated.
568         Since objects can be deallocated in any order, it is not safe to call NPN_ReleaseObject on member variables.
569         
570         Instead, just zero out the member variable in invalidate.
571         
572         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
573         (pluginInvalidate):
574         (pluginDeallocate):
575
576 2009-03-16  Eric Seidel  <eric@webkit.org>
577
578         Reviewed by Sam Weinig.
579         
580         REGRESSION: undo-iframe-location-change.html is failing on the buildbots
581         https://bugs.webkit.org/show_bug.cgi?id=24626
582         
583         Added a call to [[webview undoManager] removeAllActions]
584         to make sure anything left on the undo stack after one test
585         will not affect any later test.
586
587         * DumpRenderTree/mac/DumpRenderTree.mm:
588         (resetWebViewToConsistentStateBeforeTesting):
589
590 2009-03-14  Mark Rowe  <mrowe@apple.com>
591
592         Reviewed by Dan Bernstein.
593
594         Change the layout test result search policy for Mac OS X to fit better with the idea of
595         newer OS versions improving on previous OS versions.
596
597         The results for the latest version of Mac OS X are placed in the "mac" directory.  The
598         results for older versions of Mac OS X are structured as a series of overlays.  When
599         running on Leopard, the results in "mac-leopard" are searched before those in "mac".
600         When running on Tiger, the results in "mac-tiger" are searched before those in
601         "mac-leopard" and "mac".
602
603         * Scripts/run-webkit-tests:
604
605 2009-03-13  Mark Rowe  <mrowe@apple.com>
606
607         Rubber-stamped by Dan Bernstein.
608
609         Take advantage of the ability of recent versions of Xcode to easily switch the active
610         architecture.
611
612         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
613
614 2009-03-13  Mark Rowe  <mrowe@apple.com>
615
616         Reviewed by Timothy Hatcher.
617
618         Remove the --64-bit argument from scripts in favor of them detecting when 64-bit should be preferred.
619
620         The scripts will automatically target 64-bit if the system and hardware support it.  This can be
621         overridden by passing --32-bit to individual scripts, or using set-webkit-configuration --32-bit
622         to make the override persistent.
623
624         * Scripts/build-webkit: Remove architecture-related code.
625         * Scripts/gdb-safari: Remove architecture-related code, and clean up how the environment variables are passed to gdb.
626         * Scripts/run-javascriptcore-tests: Remove architecture-related code.
627         * Scripts/run-safari: Ditto.
628         * Scripts/run-webkit-tests: Ditto.
629         * Scripts/set-webkit-configuration: Handle the --32-bit and --64-bit arguments.  The --32-bit argument will set the
630         architecture preference to the 32-bit architecture of the machine.  The --64-bit argument will remove any architecture
631         override that is in effect so that 64-bit support will be automatically detected.
632         * Scripts/webkitdirs.pm: Add auto-detection of the best architecture for the machine, and the ability to override the
633         auto-detection.
634
635 2009-03-13  Anders Carlsson  <andersca@apple.com>
636
637         Reviewed by Dan Bernstein.
638
639         <rdar://problem/6610666> Revise the Cocoa event model text API
640
641         Add a case statement for NPCocoaEventTextInput.
642         
643         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
644         (handleEventCocoa):
645
646 2009-03-12  Kevin Ollivier  <kevino@theolliviers.com>
647
648         wx build fix. Let DerivedSources.make know we want database APIs.
649
650         * wx/build-wxwebkit:
651
652 2009-03-12  David Kilzer  <ddkilzer@apple.com>
653
654         Bug 24378: resolve-ChangeLogs should use git status or svn status to find and fix unmerged ChangeLogs
655
656         <https://bugs.webkit.org/show_bug.cgi?id=24378>
657
658         Reviewed by Adam Roben.
659
660         * Scripts/resolve-ChangeLogs: If -f|--fix-merged is not passed
661         and no file or directory names are specified on the command-line
662         then try to find unmerged ChangeLog files based on 'svn stat' or
663         'git diff'.  Added global $isGit and $isSVN variables so that
664         isGit() and isSVN() only have to be called once.
665         (findUnmergedChangeLogs): Added.
666
667 2009-03-11  David Kilzer  <ddkilzer@apple.com>
668
669         Clarify comments regarding order of FEATURE_DEFINES
670
671         Rubber-stamped by Mark Rowe.
672
673         * Scripts/build-webkit: Added warning about keeping
674         FEATURE_DEFINES in order and the consequences when they are not.
675
676 2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>
677
678         Reviewed by Holger Freyther.
679
680         Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
681         https://bugs.webkit.org/show_bug.cgi?id=24487
682
683         Also reset WebSettings to its default state for JavaScript
684         profiling, Developer Extras and Private Browsing before running
685         the test (can be after each test but we want to be consistent with
686         other ports in this regard)
687
688         * DumpRenderTree/gtk/DumpRenderTree.cpp:
689         (resetWebViewToConsistentStateBeforeTesting):
690         (runTest):
691         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
692         (LayoutTestController::setPrivateBrowsingEnabled):
693
694 2009-03-11  Jan Michael Alonzo  <jmalonzo@webkit.org>
695
696         Reviewed by Holger Freyther.
697
698         [GTK]DumpRenderTree doesn't compile for non-X11 GTK ports anymore
699         https://bugs.webkit.org/show_bug.cgi?id=2260
700
701         Add plugin support only for X11 builds
702
703         * DumpRenderTree/gtk/DumpRenderTree.cpp:
704         (setDefaultsToConsistentStateValuesForTesting):
705         * GNUmakefile.am:
706
707 2009-03-08  Holger Hans Peter Freyther  <zecke@selfish.org>
708
709         Reviewed by Mark Rowe.
710
711         Implement setJavaScriptProfilingEnabled by enabling the Developer
712         Extras and the JavaScript profiling on the WebKitWebInspector. After
713         this change we pass the three enabled tests in fast/profiler.
714
715         * DumpRenderTree/gtk/DumpRenderTree.cpp:
716         (runTest): Reset setJavaScriptProfilingEnabled after each test run
717         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
718         (LayoutTestController::setJavaScriptProfilingEnabled):
719
720 2009-03-07  Jan Michael Alonzo  <jmalonzo@webkit.org>
721
722         Reviewed by Holger Freyther.
723
724         [Gtk] Enable http history tests
725         https://bugs.webkit.org/show_bug.cgi?id=24394
726
727         Get the index of the current item from the list of (history) items
728         to print before adding the back history items to the list. This
729         will make the 'curr' pointer point to the correct item in the
730         actual results, therefore, passing some of the http/tests/history
731         tests.
732
733         * DumpRenderTree/gtk/DumpRenderTree.cpp:
734         (dumpBackForwardListForWebView):
735
736 2009-03-06  Adam Treat  <adam.treat@torchmobile.com>
737
738         Reviewed by George Staikos.
739
740         When building QtWebKit in release mode make sure that QT_SHARED is defined
741         otherwise none of the public API will be exported.  This leads to missing
742         symbols and link errors if hidden-visibility is used.
743
744         * Scripts/webkitdirs.pm:
745
746 2009-03-06  Adam Roben  <aroben@apple.com>
747
748         Change the isCygwin check in update-webkit to isAppleWinWebKit
749
750         This matches a similar check in build-webkit, and is more correct.
751
752         Reviewed by Alexey Proskuryakov.
753
754         * Scripts/update-webkit: Only call update-webkit-auxiliary-libs if
755         isAppleWinWebKit is true.
756
757 2009-03-06  Adam Roben  <aroben@apple.com>
758
759         Make update-webkit-support-libs fail if WebKitSupportLibrary.zip is
760         present but out of date
761
762         Reviewed by Alexey Proskuryakov.
763
764         * Scripts/update-webkit-support-libs: Changed to use
765         dieAndInstructToDownload when the zip file doesn't exist. Added an MD5
766         check to make sure the file is up-to-date. If it is out of date, print
767         an error message and quit.
768         (sub dieAndInstructToDownload): Added. Prints an error message and
769         quits with an error.
770
771 2009-03-03  Anders Carlsson  <andersca@apple.com>
772
773         Reviewed by John Sullivan.
774
775         https://bugs.webkit.org/show_bug.cgi?id=22884
776         <rdar://problem/6449783>
777         modified layout test crashes Safari
778
779         Add destroyNullStream test function to the test plug-in.
780         
781         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
782         (destroyNullStream):
783         (pluginInvoke):
784
785 2009-03-03  Brady Eidson  <beidson@apple.com>
786
787         Reviewed by Darin Adler
788
789         Support layout test covering <rdar://problem/6616664>
790
791         Change NSURLRequest/IWebURLRequest dumping to include the mainDocumentURL
792
793         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
794         (-[NSURLRequest _drt_descriptionSuitableForTestResult]): Return both the request URL and the 
795           mainDocumentURL.
796         
797         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
798         (descriptionSuitableForTestResult): Return both the request URL and the mainDocumentURL.
799
800 2009-03-02  Sam Weinig  <sam@webkit.org>
801
802         Reviewed by Mark Rowe.
803
804         Enable Geolocation (except on Tiger and Leopard).
805
806         * Scripts/build-webkit:
807
808 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
809
810         Build fixes for wxWidgets Mac trunk build.
811
812         * wx/build-wxwebkit:
813
814 2009-03-02  Timothy Hatcher  <timothy@apple.com>
815
816         Allow for multiline quoted text in JavaScript files when looking for function names.
817
818         https://bugs.webkit.org/show_bug.cgi?id=24296
819
820         Reviewed by David Kilzer.
821
822         * Scripts/prepare-ChangeLog:
823
824 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
825
826         Reviewed by Eric Seidel.
827
828         Add three new drt helper functions that enable all of the tests in
829         LayoutTests/animation/* and LayoutTests/transitions/* to now pass.
830
831         * DumpRenderTree/qt/jsobjects.cpp:
832         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
833         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
834         (LayoutTestController::numberOfActiveAnimations):
835         * DumpRenderTree/qt/jsobjects.h:
836
837 2009-03-02  Adam Roben  <aroben@apple.com>
838
839         Windows build fix after r41349
840
841         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
842         (AccessibilityUIElement::getChildrenWithRange):
843
844 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
845
846         Reviewed by Oliver Hunt.
847
848         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
849
850         Change getChildAtIndex() to get a range of children instead of all the children.
851         This exercises code in WebCore that returns elements when asked for from a range.
852
853         * DumpRenderTree/AccessibilityUIElement.h:
854         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
855         (AccessibilityUIElement::getChildrenWithRange):
856         (AccessibilityUIElement::getChildAtIndex):
857         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
858         (AccessibilityUIElement::getChildrenWithRange):
859
860 2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
861
862         Reviewed by Holger Freyther.
863
864          [Gtk] get the HTTP layout tests going
865          https://bugs.webkit.org/show_bug.cgi?id=24259
866
867         Determine the frame's response and decide whether to dump as text
868         or the render tree
869
870         * DumpRenderTree/gtk/DumpRenderTree.cpp:
871         (dump):
872
873 2009-03-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
874
875         Reviewed by Holger Freyther.
876
877         [Gtk] get the HTTP layout tests going
878         https://bugs.webkit.org/show_bug.cgi?id=24259
879
880          Implement dumping of WebKitWebBackForwardList and its history
881          items.
882
883         * DumpRenderTree/gtk/DumpRenderTree.cpp:
884         (compareHistoryItems):
885         (dumpHistoryItem):
886         (dumpBackForwardListForWebView):
887         (dump):
888         (runTest):
889         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
890         (LayoutTestController::clearBackForwardList):
891         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
892         (BackForwardItem::invoke):
893
894 2009-02-28  Zan Dobersek  <zandobersek@gmail.com>
895
896          Reviewed by Holger Freyther.
897
898          Set the resolution for the default screen to 72.0.
899          This way, setting font sizes results in expected values.
900
901          * DumpRenderTree/gtk/DumpRenderTree.cpp:
902          (setDefaultsToConsistentStateValuesForTesting):
903
904 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
905
906         Reviewed by Holger Freyther.
907
908         Adds a WebKitMakeArguments environment variable to enable passing
909         of arguments such as '-j2' to make for the autotools build.
910
911         * Scripts/webkitdirs.pm:
912
913 2009-02-28  Gustavo Noronha Silva  <gns@gnome.org>
914
915         Reviewed by Holger Freyther.
916
917         Add a GTK+-only option to enable GNOME Keyring when building.
918
919         * Scripts/build-webkit:
920
921 2009-02-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
922
923         Reviewed by Holger Freyther.
924
925         [Gtk] webkitdirs.pm modify path in when detecting 3D transforms and accelerated compositing
926         https://bugs.webkit.org/show_bug.cgi?id=24076
927
928         Refactor gtk lib detection and put it in builtDylibPathForName
929
930         * Scripts/webkitdirs.pm:
931
932 2009-02-28  Christian Dywan  <christian@twotoasts.de>
933
934         Rubber-stamped by Holger Freyther.
935
936         * GtkLauncher/main.c:
937         (activate_uri_entry_cb):
938         (main): Use the new webkit_web_view_load_uri to open URIs.
939
940 2009-02-27  Xan Lopez  <xan@gnome.org>
941
942         Rubber-stamped by Alexey Proskuryakov.
943
944         https://bugs.webkit.org/show_bug.cgi?id=24222
945         [GTK] Remove checks for old glib versions
946
947         libsoup, which is a hard dependency, needs at least glib 2.15.3,
948         so remove all glib checks for versions older than that.
949
950         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
951         (LayoutTestController::setWaitToDump):
952
953 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
954
955         Reviewed by Eric Seidel
956
957         Fix spew about a WebView being deallocated while key value observers are
958         still registered with it by making sure that we always stop observing
959         _isUsingAcceleratedCompositing in -[DumpRenderTreeWindow close].
960         
961         * DumpRenderTree/mac/DumpRenderTree.mm:
962         (dumpRenderTree):
963         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
964         (-[DumpRenderTreeWindow close]):
965
966 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
967
968         Reviewed by Alexey Proskuryakov.
969
970         Do not queue the calls to 'DumpRenderTree::dump()' as this can result
971         in more than one call as a test that calls 'notifyDone()' can then be
972         subsequently fully loaded and initiate a second dump.  Also make sure
973         to stop any existing page load that is happening before running the next
974         test.  Combined this serves to produce 217 more passing tests for the
975         Qt port or roughly 5% at this point.
976
977         * DumpRenderTree/qt/DumpRenderTree.cpp:
978         (WebCore::DumpRenderTree::DumpRenderTree):
979         (WebCore::DumpRenderTree::open):
980
981 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
982
983         Reviewed by Dan Bernstein
984
985         https://bugs.webkit.org/show_bug.cgi?id=23854
986
987         Have the DumpRenderTreeWindow observe the -_isUsingAcceleratedCompositing
988         property of the WebView, and use that to turn -autodisplay on and off.
989         This is necessary so that accelerated animations start correctly.
990         We can thus remove the -display hack in createBitmapContextFromWebView().
991
992         * DumpRenderTree/mac/DumpRenderTree.mm:
993         (createWebViewAndOffscreenWindow):
994         (dumpRenderTree):
995         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
996         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
997         (-[DumpRenderTreeWindow close]):
998         (-[DumpRenderTreeWindow webView]):
999         (-[DumpRenderTreeWindow startObservingWebView]):
1000         (-[DumpRenderTreeWindow stopObservingWebView]):
1001         (-[DumpRenderTreeWindow observeValueForKeyPath:ofObject:change:context:]):
1002         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1003         (createBitmapContextFromWebView):
1004
1005 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
1006
1007         Reviewed by Zack Rusin.
1008
1009         https://bugs.webkit.org/show_bug.cgi?id=24158
1010         Implement the queue*() methods of the layoutTestController and begin
1011         implementing the dump of the back/forward list.  This results in 2% more
1012         tests passing as well as 23 currently skipped tests now passing.
1013
1014         * DumpRenderTree/qt/DumpRenderTree.cpp:
1015         (WebCore::DumpRenderTree::dumpBackForwardList):
1016         (WebCore::DumpRenderTree::dump):
1017         * DumpRenderTree/qt/DumpRenderTree.h:
1018         * DumpRenderTree/qt/DumpRenderTree.pro:
1019         * DumpRenderTree/qt/jsobjects.cpp:
1020         (findFrameNamed):
1021         (LoadItem::invoke):
1022         (ReloadItem::invoke):
1023         (ScriptItem::invoke):
1024         (BackForwardItem::invoke):
1025         (LayoutTestController::reset):
1026         (LayoutTestController::processWork):
1027         (LayoutTestController::maybeDump):
1028         (LayoutTestController::queueBackNavigation):
1029         (LayoutTestController::queueForwardNavigation):
1030         (LayoutTestController::queueLoad):
1031         (LayoutTestController::queueReload):
1032         (LayoutTestController::queueScript):
1033         * DumpRenderTree/qt/jsobjects.h:
1034         (LayoutTestController::shouldDumpBackForwardList):
1035         (LayoutTestController::dumpBackForwardList):
1036
1037 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
1038
1039         Reviewed by Alexey Proskuryakov.
1040
1041         Don't print out that you are generating new results if you are not in fact
1042         generating new results and disable generating new results by default for
1043         the all ports other than the canonical Apple Mac port since this can litter
1044         the source directory with hundreds of new results since other ports
1045         are not as up to date.
1046
1047         * Scripts/run-webkit-tests:
1048
1049 2009-02-24  Adam Treat  <adam.treat@torchmobile.com>
1050
1051         Reviewed by Cameron Zwarich.
1052
1053         The Qt port does not support these yet nor does the nm check work with
1054         QMake based build.
1055
1056         * Scripts/webkitdirs.pm:
1057
1058 2009-02-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
1059
1060         Reviewed by Alexey Proskuryakov.
1061
1062         [Gtk] add options for 3D transforms and HTML5 channel messaging to the build
1063         https://bugs.webkit.org/show_bug.cgi?id=24072
1064
1065         Allow toggling of 3D transforms and HTML5 channel messaging
1066         support for the Autotools (Gtk) build.
1067
1068         Also add '--gtk' in the build-webkit help doc and fix autotools
1069         option for web-workers support.
1070
1071         * Scripts/build-webkit:
1072
1073 2009-02-23  Xan Lopez  <xan@gnome.org>
1074
1075         Reviewed by Alexey Proskuryakov.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=22624
1078         [SOUP][GTK] Need API to get SoupSession from WebKit.
1079
1080         Add soup flags now that dependency is explicit.
1081
1082         * GNUmakefile.am:
1083
1084 2009-02-22  Mark Rowe  <mrowe@apple.com>
1085
1086         Reviewed by Oliver Hunt.
1087
1088         Fix assertion failures in editing/pasteboard/paste-RTFD.html and editing/pasteboard/paste-TIFF.html in 64-bit.
1089
1090         * DumpRenderTree/mac/DumpRenderTree.mm:
1091         (swizzleAllMethods): When adding a new method to a class, use the implementation and type of the new method rather
1092         than of an arbitrary existing method on the class.
1093
1094 2009-02-13  Eric Seidel  <eric@webkit.org>
1095
1096         Rubber-stamped by Alexey Proskuryakov.
1097
1098         Add a few ignores to make-js-test-wrappers.
1099
1100         * Scripts/make-js-test-wrappers:
1101
1102 2009-02-17  Holger Hans Peter Freyther  <zecke@selfish.org>
1103
1104         Reviewed by Alexey Proskuryakov.
1105
1106         Prepend file:// to the test result filename to make
1107         GtkLauncher display the result page.
1108
1109         * Scripts/run-webkit-tests:
1110
1111 2009-02-16  Gustavo Noronha Silva  <gns@gnome.org>
1112
1113         Reviewed by Adam Roben
1114
1115         Actually use the installation prefix defined in WebKitInstallationPrefix,
1116         in autotools builds.
1117
1118         * Scripts/webkitdirs.pm:
1119
1120 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
1121
1122         No review.
1123
1124         Remove debugging code which was committed by mistake.
1125
1126         * Scripts/run-webkit-tests:
1127
1128 2009-02-12  Simon Fraser  <simon.fraser@apple.com>
1129
1130         Reviewed by Adam Roben
1131
1132         https://bugs.webkit.org/show_bug.cgi?id=23928
1133
1134         Add detection of accelerated compositing and 3d transforms,
1135         and add various directories to $ignoredDirectories when these
1136         features are off.
1137
1138         * Scripts/run-webkit-tests:
1139         * Scripts/webkitdirs.pm:
1140
1141 2009-02-12  Adam Roben  <aroben@apple.com>
1142
1143         Fix Bug 23922: Warning message from run-webkit-tests when Skipped file
1144         contains non-existent tests is confusing and is given for disabled
1145         tests
1146
1147         <https://bugs.webkit.org/show_bug.cgi?id=23922>
1148
1149         We now no longer warn about disabled tests. The warning now reads:
1150
1151         Skipped list contained '$item', but no file of that name could be
1152         found
1153
1154         Reviewed by John Sullivan.
1155
1156         * Scripts/run-webkit-tests:
1157         (top level): Pass the list name to processIgnoreTests so it can print
1158         out a reasonable warning message.
1159         (processIgnoreTests): Take a list name as a second parameter and use
1160         it to display a better warning message. Also check for a "-disabled"
1161         version of the test before warning about it not existing.
1162
1163 2009-02-11  Adam Roben  <aroben@apple.com>
1164
1165         Windows fix for Bug 22239: Implement missing animation & transition
1166         APIs on LayoutTestController for non-mac platforms
1167
1168         <https://bugs.webkit.org/show_bug.cgi?id=22239>
1169
1170         Reviewed by Simon Fraser.
1171
1172         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1173         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1174         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1175         (LayoutTestController::numberOfActiveAnimations):
1176         Implemented these by calling through to IWebFramePrivate.
1177
1178 2009-02-10  Chris Marrin  <cmarrin@apple.com>
1179
1180         Reviewed by Simon Fraser.
1181
1182         * Scripts/build-webkit:
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=23883
1185
1186         Added support --3d-transforms. Defaults to off
1187
1188 2009-02-11  Adam Roben  <aroben@apple.com>
1189
1190         Fix crashes in http/tests/history/redirect-301.pl and friends on
1191         Windows
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1196         (LayoutTestController::webHistoryItemCount): Null-check the shared
1197         WebHistory instance before dereferencing it.
1198
1199 2009-02-10  Adam Roben  <aroben@apple.com>
1200
1201         Fix Bug 23869: Pixel tests can't be run on Windows
1202
1203         <https://bugs.webkit.org/show_bug.cgi?id=23869>
1204
1205         This patch gets the pixel tests limping along on Windows again.
1206
1207         Reviewed by Dan Bernstein.
1208
1209         * DumpRenderTree/DumpRenderTree.sln: Changed to use the new
1210         Debug_Internal configuration of ImageDiff in the Debug_Internal
1211         configuration of this solution.
1212
1213         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1214         (printPNG): Changed to call fwrite in a loop, since this call was
1215         failing due to the buffer being too large on Windows.
1216         (dumpWebViewAsPixelsAndCompareWithExpected): Removed an unnecessary
1217         #if PLATFORM(MAC)/#endif.
1218
1219         * DumpRenderTree/win/ImageDiff.vcproj: Added a Debug_Internal
1220         configuration that matches the Debug configuration but also references
1221         debug_internal.vsprops.
1222
1223         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1224         (createBitmapContextFromWebView): Renamed from
1225         getBitmapContextFromWebView to match the name used in the
1226         cross-platform code.
1227
1228 2009-02-10  Adam Roben  <aroben@apple.com>
1229
1230         Robustify DumpRenderTree/win a little
1231
1232         DumpRenderTree was previously not holding a ref to the WebViews it
1233         created via window.open. It was getting away with this because
1234         WebViews get reffed by being preference notification observers and by
1235         registering for drag-n-drop messages. Now DRT does hold a ref, in case
1236         this situation changes in the future.
1237
1238         Reviewed by Alexey Proskuryakov.
1239
1240         * DumpRenderTree/win/DumpRenderTree.cpp:
1241         (dumpBackForwardListForAllWindows): Added a .get().
1242         (windowToWebViewMap): Changed to use the WindowToWebViewMap typedef.
1243         * DumpRenderTree/win/DumpRenderTreeWin.h: Changed the
1244         windowToWebViewMap() to hold a ref to the WebViews it contains.
1245
1246 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
1247
1248         Fix the #include file order, per review comments.
1249
1250         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1251
1252 2009-02-05  Simon Fraser  <simon.fraser@apple.com>
1253
1254         Reviewed by Dan Bernstein
1255
1256         https://bugs.webkit.org/show_bug.cgi?id=23362
1257
1258         If the WebHTMLView uses accelerated compositing, we need for force
1259         the on-screen capture path and also force animations to start with -display
1260         since the DRT window has autodisplay disabled.
1261
1262         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1263         (createBitmapContextFromWebView):
1264
1265 2009-02-03  miggilin  <mr.diggilin@gmail.com>
1266
1267         Reviewed by Darin Adler.
1268
1269         Change the way wxWidgets build gets arguments.
1270         Change "checkForArgumentAndRemoveFromARGV" in build-webkit to check if the
1271         argument passed matches one in ARGV exactly (allows, ie, --wx-args not to be
1272         removed when --wx is checked for).
1273
1274         https://bugs.webkit.org/show_bug.cgi?id=23701
1275
1276         * Scripts/build-webkit:
1277         * Scripts/webkitdirs.pm:
1278
1279 2009-01-30  Chris Fleizach  <cfleizach@apple.com>
1280
1281         Reviewed by Oliver Hunt.
1282
1283         Catch exceptions thrown by AppKit when accessing an attribute than an element
1284         doesn't return.
1285
1286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1287         (attributesOfElement):
1288
1289 2009-01-29  David Kilzer  <ddkilzer@apple.com>
1290
1291         Remove semi-colons from the end of ObjC method implementations
1292
1293         Rubber-stamped by Adam Roben.
1294
1295         $ find WebKitTools -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;
1296
1297         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1298         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1299         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1300         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1301         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1302         * DumpRenderTree/mac/UIDelegate.mm:
1303         (-[UIDelegate webViewFrame:]):
1304
1305 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
1306
1307         Build fix for GTK.
1308
1309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1310         (LayoutTestController::webHistoryItemCount):
1311
1312 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
1313
1314         Reviewed by Sam Weinig.
1315
1316         Added support for querying how many history items were created during a
1317         layout test.
1318
1319         * DumpRenderTree/LayoutTestController.cpp:
1320         (getWebHistoryItemCountCallback):
1321         (LayoutTestController::staticValues):
1322         * DumpRenderTree/LayoutTestController.h:
1323         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1324         (LayoutTestController::webHistoryItemCount):
1325         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1326         (LayoutTestController::webHistoryItemCount):
1327
1328 2009-01-26  Pierre-Olivier Latour  <pol@apple.com>
1329
1330         Tweaked again earlier fix, this time just to print a warning and not abort if
1331         attempting to generate pixel results and Perian is installed.
1332
1333         https://bugs.webkit.org/show_bug.cgi?id=22615
1334
1335         * Scripts/run-webkit-tests:
1336
1337 2009-01-26  Christian Dywan  <christian@twotoasts.de>
1338
1339         Rubber stamped by Holger Freyther.
1340
1341         * GtkLauncher/main.c:
1342         (main): Initialize threads, which is required for libSoup.
1343
1344 2009-01-23  David Kilzer  <ddkilzer@apple.com>
1345
1346         * Scripts/do-webcore-rename: Removed 10 header guard renames that
1347         had already been fixed, and updated 4 renames whose original values
1348         had changed.
1349
1350 2009-01-22  Anders Carlsson  <andersca@apple.com>
1351
1352         Fix Windows build.
1353
1354         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1355
1356 2009-01-22  Anders Carlsson  <andersca@apple.com>
1357
1358         Reviewed by Sam Weinig.
1359
1360         Clean up the test plug-in code. We now always use the CG drawing model and the
1361         Cocoa event model. It is however possible to revert to the old Carbon event model by
1362         specifying forcecarbon=true in the embed/object tag.
1363
1364         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1365         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1366         (NPP_New):
1367         (handleEventCarbon):
1368         (handleEventCocoa):
1369         (NPP_HandleEvent):
1370
1371 2009-01-21  Pierre-Olivier Latour  <pol@apple.com>
1372
1373         Tweaked earlier fix to only print a warning when Perian is installed,
1374         and fail completely only if attempting to generate new pixel test results.
1375
1376         https://bugs.webkit.org/show_bug.cgi?id=23392
1377
1378         * Scripts/run-webkit-tests:
1379
1380 2009-01-20  Darin Adler  <darin@apple.com>
1381
1382         Reviewed by Alexey Proskuryakov.
1383
1384         Bug 23450: string leaks seen in DumpRenderTree accessibility test code
1385         https://bugs.webkit.org/show_bug.cgi?id=23450
1386
1387         * DumpRenderTree/AccessibilityUIElement.cpp:
1388         (isAttributeSettableCallback): Add the missing JSStringRelease call.
1389         (attributeValueCallback): Ditto.
1390
1391 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
1392
1393         Reviewed by Darin Adler.
1394
1395         Print warning regarding display color profile change in run-webkit-tests instead of DRT.
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=23392
1398
1399         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1400         (setupMainDisplayColorProfile):
1401         * Scripts/run-webkit-tests:
1402
1403 2009-01-20  Pierre-Olivier Latour  <pol@apple.com>
1404
1405         Reviewed by Darin Adler.
1406
1407         Changed run-webkit-tests to abort on the Mac if pixel tests are enabled and Perian is installed,
1408         in order to avoid result differences in some media tests.
1409
1410         https://bugs.webkit.org/show_bug.cgi?id=22615
1411
1412         * Scripts/run-webkit-tests:
1413         * Scripts/webkitdirs.pm:
1414
1415 2009-01-19  Sam Weinig  <sam@webkit.org>
1416
1417         * Scripts/do-webcore-rename: Add JSValuePtr and ProtectedJSValuePtr.
1418
1419 2009-01-16  Gabor Loki  <loki@inf.u-szeged.hu>
1420
1421         Reviewed by Darin Adler.
1422
1423         * Scripts/webkitdirs.pm: Added '--makeargs' parameter which can pass additional
1424         parameters to make command in QMake projects.
1425
1426 2009-01-16  Chris Fleizach  <cfleizach@apple.com>
1427
1428         Reviewed by Beth Dakin.
1429
1430         Add AX methods to retrieve the parent of an element.
1431
1432         * DumpRenderTree/AccessibilityUIElement.cpp:
1433         (parentElementCallback):
1434         (AccessibilityUIElement::getJSClass):
1435         * DumpRenderTree/AccessibilityUIElement.h:
1436         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1437         (AccessibilityUIElement::parentElement):
1438         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1439         (AccessibilityUIElement::parentElement):
1440
1441 2009-01-16  Anders Carlsson  <andersca@apple.com>
1442
1443         Reviewed by Adam Roben.
1444
1445         Set the count to the right number of elements.
1446
1447         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1448         (testEnumerate):
1449
1450 2009-01-14  David Kilzer  <ddkilzer@apple.com>
1451
1452         BUILD FIX: Use COM API on Windows in LayoutTestController::setIconDatabaseEnabled()
1453
1454         Rubber-stamped by Alice Liu.
1455
1456         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1457         (LayoutTestController::setIconDatabaseEnabled): Use COM API
1458         to get the shared WebIconDatabase.
1459
1460 2009-01-14  Jeremy Moskovich  <jeremy@chromium.org>
1461
1462         Reviewed by Eric Seidel.
1463
1464         <https://bugs.webkit.org/show_bug.cgi?id=16829>
1465         Implement NPN_SetException()
1466
1467         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1468         (pluginInvoke):
1469         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1470         (initializeIdentifiers):
1471         (testHasMethod):
1472         (testInvoke):
1473
1474 2009-01-13  Dmitry Titov  <dimich@chromium.org>
1475
1476         Reviewed by David Kilzer.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=23304
1479         Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
1480
1481         * Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
1482
1483 2009-01-14  David Kilzer  <ddkilzer@apple.com>
1484
1485         BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
1486
1487         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1488         (runTest): Added call to reset the icon database to match Mac
1489         and Windows ports.
1490         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1491         (LayoutTestController::setIconDatabaseEnabled): Implemented
1492         stub method.
1493
1494 2009-01-14  David Kilzer  <ddkilzer@apple.com>
1495
1496         Bug 22795: favicons should be saved to webarchives
1497
1498         <https://bugs.webkit.org/show_bug.cgi?id=22795>
1499
1500         Reviewed by Darin Adler.
1501
1502         * DumpRenderTree/LayoutTestController.cpp:
1503         (setIconDatabaseEnabledCallback): Added.
1504         (setJavaScriptProfilingEnabledCallback): Realphabetized.
1505         (LayoutTestController::staticFunctions): Added entry for calling
1506         LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
1507         * DumpRenderTree/LayoutTestController.h:
1508         (setIconDatabaseEnabledCallback): Added declaration.
1509         (setJavaScriptProfilingEnabledCallback): Realphabetized.
1510
1511         * DumpRenderTree/mac/DumpRenderTree.mm:
1512         (runTest): Disable the icon database before each test.
1513         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1514         (LayoutTestController::setIconDatabaseEnabled): Added.
1515         (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
1516
1517         * DumpRenderTree/win/DumpRenderTree.cpp:
1518         (runTest): Disable the icon database before each test.
1519         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1520         (LayoutTestController::setIconDatabaseEnabled): Added.
1521
1522 2009-01-14  Steve Falkenburg  <sfalken@apple.com>
1523
1524         Update copyright year in version resources.
1525
1526         Reviewed by Adam Roben.
1527
1528         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
1529
1530 2009-01-14  Dan Bernstein  <mitz@apple.com>
1531
1532         Reviewed by John Sullivan.
1533
1534         - update copyright
1535
1536         * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
1537         * WebKitLauncher/Info.plist:
1538
1539 2009-01-13  Anders Carlsson  <andersca@apple.com>
1540
1541         Reviewed by Sam Weinig.
1542
1543         Add NPRuntime test.
1544
1545         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1546         (testNPRuntime):
1547         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1548         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1549         (NPP_New):
1550         (NPP_GetValue):
1551
1552 2009-01-12  Mark Rowe  <mrowe@apple.com>
1553
1554         Use the modern spelling of WebKit.
1555
1556         * Scripts/find-extra-includes:
1557         * Scripts/report-include-statistics:
1558         * Scripts/run-webkit-app:
1559         * Scripts/svn-unapply:
1560         * Scripts/update-webkit:
1561
1562 2009-01-11  Darin Adler  <darin@apple.com>
1563
1564         * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
1565         directory that aren't using standard wrappers.
1566
1567 2009-01-11  Robert Blaut  <webkit@blaut.biz>
1568
1569         Reviewed by Eric Seidel.
1570
1571         <https://bugs.webkit.org/show_bug.cgi?id=23134>
1572         Update bisect-builds for Safari 3.2 to prevent crashes
1573
1574         * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
1575
1576 2009-01-08  Adam Treat  <adam.treat@torchmobile.com>
1577
1578         Reviewed by Simon Hausmann.
1579
1580         Explicitly set these so that the layout tests do not break.
1581
1582         * DumpRenderTree/qt/DumpRenderTree.cpp:
1583         (WebCore::WebPage::WebPage):
1584
1585 2009-01-07  Glenn Wilson  <gwilson@chromium.org>
1586
1587         Reviewed by Eric Seidel.
1588
1589         Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
1590         This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
1591
1592         * DumpRenderTree/mac/DumpRenderTree.mm:
1593         (testStringByEvaluatingJavaScriptFromString):
1594         (setDefaultsToConsistentValuesForTesting):
1595
1596 2009-01-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1597
1598         Reviewed by Maciej Stachowiak.
1599
1600         Implement numberOfActiveAnimations to fix the build
1601
1602         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1603         (LayoutTestController::numberOfActiveAnimations):
1604
1605 2009-01-07  Adam Treat  <adam.treat@torchmobile.com>
1606
1607         Reviewed by George Staikos.
1608
1609         Fix unused variable warnings
1610
1611         * DumpRenderTree/qt/DumpRenderTree.cpp:
1612         (WebCore::WebPage::javaScriptAlert):
1613         (WebCore::WebPage::javaScriptConfirm):
1614         (WebCore::WebPage::javaScriptPrompt):
1615         * DumpRenderTree/qt/jsobjects.cpp:
1616         (LayoutTestController::maybeDump):
1617         * DumpRenderTree/qt/main.cpp:
1618         (get_backtrace):
1619         * DumpRenderTree/qt/testplugin.cpp:
1620         (TestPlugin::create):
1621
1622 2009-01-06  Pierre-Olivier Latour  <pol@apple.com>
1623
1624         Reviewed by Darin Adler.
1625
1626         Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
1627         This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
1628
1629         https://bugs.webkit.org/show_bug.cgi?id=23126
1630
1631         * DumpRenderTree/LayoutTestController.cpp:
1632         (numberOfActiveAnimationsCallback):
1633         (LayoutTestController::staticFunctions):
1634         * DumpRenderTree/LayoutTestController.h:
1635         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1636         (LayoutTestController::numberOfActiveAnimations):
1637         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1638         (LayoutTestController::numberOfActiveAnimations):
1639
1640 2009-01-04  David Kilzer  <ddkilzer@apple.com>
1641
1642         Don't install internal headers in WebKit framework
1643
1644         Reviewed by Darin Adler.
1645
1646         Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
1647         no longer installed in WebKit.framework/PrivateHeaders, use the
1648         special relationship of DumpRenderTree within the WebKit source
1649         tree to include the internal headers through relative paths.
1650         Created the concept of mac/InternalHeaders to hide the ugly
1651         paths.
1652
1653         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added
1654         mac/InternalHeaders to HEADER_SEARCH_PATHS.
1655         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
1656         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
1657
1658 2009-01-02  Adam Treat  <treat@kde.org>
1659
1660         Reviewed by George Staikos.
1661
1662         Add support for fixedLayoutSize to the qt DRT
1663
1664         * DumpRenderTree/qt/jsobjects.cpp:
1665         (LayoutTestController::setFixedLayoutSize):
1666         (LayoutTestController::setUseFixedLayout):
1667         * DumpRenderTree/qt/jsobjects.h:
1668
1669 2009-01-03  David D. Kilzer  <ddkilzer@webkit.org>
1670
1671         Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
1672
1673         <https://bugs.webkit.org/show_bug.cgi?id=23091>
1674
1675         Reviewed by Darin Adler.
1676
1677         * DumpRenderTree/mac/DumpRenderTree.mm:
1678         (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
1679         Connection headers from webarchive results.
1680
1681 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
1682
1683         Reviewed by Holger Freyther.
1684
1685         https://bugs.webkit.org/show_bug.cgi?id=22812
1686
1687         Prevent TestNetscapePlugin from installing system-wide.
1688
1689         * GNUmakefile.am:
1690
1691 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
1692
1693         Reviewed by Holger Freyther.
1694
1695         https://bugs.webkit.org/show_bug.cgi?id=22842
1696
1697         Move WebKitWebView's size allocation into a proper place.
1698
1699         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1700         (dump):
1701         (runTest):
1702
1703 2008-12-24  Mark Rowe  <mrowe@apple.com>
1704
1705         Reviewed by Timothy Hatcher.
1706
1707         Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
1708         and make it work for git too.
1709
1710         * Scripts/VCSUtils.pm:
1711         * Scripts/webkitdirs.pm:
1712
1713 2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1714
1715         Reviewed by George Staikos.
1716
1717         Ignore http/tests/wml, if no WML support is present.
1718         Add http/tests/wml to list of HTTP tests, allowed to access local resources.
1719
1720         * Scripts/run-webkit-tests:
1721
1722 2008-12-19  David Levin  <levin@chromium.org>
1723
1724         Reviewed by Mark Rowe.
1725
1726         https://bugs.webkit.org/show_bug.cgi?id=22930
1727
1728         Make the git diff command used for preparing the change log avoid using any external diff tools.
1729
1730         * Scripts/prepare-ChangeLog:
1731
1732 2008-12-19  Gustavo Noronha Silva  <gns@gnome.org>
1733
1734         Reviewed by Holger Freyther.
1735
1736         https://bugs.webkit.org/show_bug.cgi?id=22686
1737
1738         Added files which were missing from the TestNetscapePlugin
1739         directory to the SOURCES variable, so that they will be
1740         distributed in a make dist.
1741
1742         * GNUMakefile.am:
1743
1744 2008-12-18  Cameron Zwarich  <zwarich@apple.com>
1745
1746         Reviewed by Geoff Garen.
1747
1748         Add tests for bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
1749         <https://bugs.webkit.org/show_bug.cgi?id=21855>
1750         <rdar://problem/6278244>
1751
1752         Add support for scheduling asynchronous clicks to DumpRenderTree, but
1753         only on the Mac.
1754
1755         * DumpRenderTree/mac/EventSendingController.h:
1756         * DumpRenderTree/mac/EventSendingController.mm:
1757         (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
1758         scheduleAsynchronousClick to JavaScript.
1759         (-[EventSendingController scheduleAsynchronousClick]): Add.
1760
1761 2008-12-15  Darin Adler  <darin@apple.com>
1762
1763         * Scripts/make-js-test-wrappers: Added another exception to avoid overwriting
1764         a custom-written test.
1765
1766 2008-12-15  Simon Hausmann  <hausmann@webkit.org>
1767
1768         Reviewed by Holger Freyther.
1769
1770         Implement setJavaScriptProfilingEnabled in the Qt DRT to pass fast/profiler.
1771
1772         * DumpRenderTree/qt/jsobjects.cpp:
1773         (LayoutTestController::setJavaScriptProfilingEnabled):
1774         * DumpRenderTree/qt/jsobjects.h:
1775
1776 2008-12-13  Zan Dobersek  <zandobersek@gmail.com>
1777
1778         Reviewed by Darin Adler.
1779
1780         https://bugs.webkit.org/show_bug.cgi?id=22039
1781
1782         Implement animation and transition pausing.
1783
1784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1785         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1786         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1787
1788 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
1789
1790         Reviewed by Adam Roben.
1791
1792         https://bugs.webkit.org/show_bug.cgi?id=22809
1793
1794         Increase timeout in call to initWithURL so that people actually see
1795         new web pages when they type URLs rather than a blank screen.
1796
1797         * WinLauncher/WinLauncher.cpp:
1798         (loadURL):  Increase timeout in initWithURL from 0 to 60 seconds.
1799
1800 2008-12-12  Darin Adler  <darin@apple.com>
1801
1802         * Scripts/do-webcore-rename: Add a renaming idea.
1803
1804 2008-12-12  Holger Hans Peter Freyther  <zecke@selfish.org>
1805
1806         Reviewed by Simon Hausmann.
1807
1808         Update the WebKit.qrc and add a script to automatically generate the file.
1809
1810         With the way rcc and qmake work this can not be done at build time
1811         as the WebKit.qrc must sit inside the directory that contains the files
1812         and at build time we may not change the content of the source directory.
1813
1814         * Scripts/generate-qt-inspector-resource: Added.
1815
1816 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
1817
1818         Rubber-stamped by Mark Rowe.
1819
1820         Roll out r39212 due to assertion failures during layout tests, multiple
1821         layout test failures, memory leaks, and obvious incorrectness.
1822
1823         * DumpRenderTree/LayoutTestController.cpp:
1824         (LayoutTestController::staticFunctions):
1825         * DumpRenderTree/LayoutTestController.h:
1826         * DumpRenderTree/mac/DumpRenderTree.mm:
1827         (resetWebViewToConsistentStateBeforeTesting):
1828         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1829         * DumpRenderTree/win/DumpRenderTree.cpp:
1830         (resetWebViewToConsistentStateBeforeTesting):
1831         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1832         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1833
1834 2008-12-10  Glenn Wilson  <gwilson@google.com>
1835
1836         Reviewed by Adam Roben.
1837
1838         Changed LayoutTestController and DumpRenderTree to allow for manual
1839         overriding of default preferences at test time.  Also added support for
1840         resetting the preferences after each test.
1841         https://bugs.webkit.org/show_bug.cgi?id=20534
1842
1843         * DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
1844         * DumpRenderTree/LayoutTestController.h: Added signature for callback
1845         * DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
1846         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
1847         * DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
1848         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
1849
1850 2008-12-10  Brady Eidson  <beidson@apple.com>
1851
1852         Reviewed by Darin Adler.
1853
1854         Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
1855
1856         * DumpRenderTree/win/DumpRenderTree.cpp:
1857         * DumpRenderTree/win/DumpRenderTreeWin.h:
1858
1859         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1860         (LayoutTestController::setCustomPolicyDelegate):
1861
1862         * DumpRenderTree/win/PolicyDelegate.cpp:
1863         (PolicyDelegate::PolicyDelegate):
1864         (PolicyDelegate::decidePolicyForNavigationAction):
1865         * DumpRenderTree/win/PolicyDelegate.h:
1866         (PolicyDelegate::setPermissive):
1867
1868 2008-12-10  Brady Eidson  <beidson@apple.com>
1869
1870         Reviewed by Darin
1871
1872         Change the custom policy delegate to actually allow navigation for tests that need it.
1873         The new behavior is opt-in and doesn't require any changes in old tests.
1874
1875         * DumpRenderTree/LayoutTestController.cpp:
1876         (setCustomPolicyDelegateCallback):  Allow for a second boolean argument to set the permissive flag on the custom
1877           policy delegate, which will be false by default to maintain original behavior.
1878         * DumpRenderTree/LayoutTestController.h:
1879         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1880         (LayoutTestController::setCustomPolicyDelegate):
1881
1882         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1883         (LayoutTestController::setCustomPolicyDelegate):  Partially stubbed out for now.
1884         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1885         (LayoutTestController::setCustomPolicyDelegate):  Still stubbed out, but with new param.
1886
1887         * DumpRenderTree/mac/PolicyDelegate.h:
1888         * DumpRenderTree/mac/PolicyDelegate.mm:
1889         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):  If the permissive flag
1890           is set, allow the navigation.
1891         (-[PolicyDelegate setPermissive:]):  Change the behavior between "use" and "ignore" - allowing navigation or not.
1892
1893 2008-12-09  Mark Rowe  <mrowe@apple.com>
1894
1895         Rubber-stamped by Ada Chan.
1896
1897         Fix gdb-safari on Tiger.
1898
1899         gdb on Tiger does not take the -arch flag, so do not pass it.
1900
1901         * Scripts/gdb-safari:
1902
1903 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
1904
1905         Reviewed by Alexey Proskuryakov.
1906
1907         Ignore WML tests, if no WML support available.
1908
1909         * Scripts/run-webkit-tests:
1910
1911 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
1912
1913         Reviewed by Oliver Hunt.
1914
1915         Added a shortcut for --jsDriver-args, which I use a lot.
1916
1917         * Scripts/run-javascriptcore-tests:
1918
1919 2008-12-08  Stephanie Lewis  <slewis@apple.com>
1920
1921         Fix Tiger build.
1922
1923         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1924
1925 2008-12-08  Darin Adler  <darin@apple.com>
1926
1927         Reviewed by John Sullivan.
1928
1929         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
1930           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
1931
1932         * DumpRenderTree/LayoutTestController.cpp:
1933         (isCommandEnabledCallback): Added.
1934         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
1935         * DumpRenderTree/LayoutTestController.h: Ditto.
1936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1937         (LayoutTestController::isCommandEnabled): Ditto.
1938         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1939         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
1940         command validation system to tell us if a comment is enabled.
1941         (-[CommandValidationTarget action]): Ditto.
1942         (-[CommandValidationTarget tag]): Ditto.
1943         (LayoutTestController::isCommandEnabled): Ditto.
1944         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1945         (LayoutTestController::isCommandEnabled): Ditto.
1946
1947 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1948
1949         Bug 22555: Sort "children" sections in Xcode project files
1950
1951         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1952
1953         Reviewed by Eric Seidel.
1954
1955         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
1956         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
1957         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
1958
1959 2008-12-08  David Kilzer  <ddkilzer@apple.com>
1960
1961         Bug 22555: Sort "children" sections in Xcode project files
1962
1963         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1964
1965         Reviewed by Timothy Hatcher.
1966
1967         * Scripts/sort-Xcode-project-file: By popular request, don't sort
1968         the mainGroup in the project (the list of items below the top-level
1969         project file).
1970
1971 2008-12-05  David Kilzer  <ddkilzer@apple.com>
1972
1973         Bug 22555: Sort "children" sections in Xcode project files
1974
1975         <https://bugs.webkit.org/show_bug.cgi?id=22555>
1976
1977         Reviewed by Darin Adler.
1978
1979         Sort "children" sections alphabetically, moving groups (folders) to
1980         the top of each of the lists.  Files are assumed to have extensions,
1981         so %isFile is used to override this behavior.
1982
1983         * Scripts/sort-Xcode-project-file:
1984         (sortChildrenByFileName): Added.
1985         (sortFilesByFileName): Renamed from sortByFileName().
1986
1987 2008-12-05  Eric Seidel  <eric@webkit.org>
1988
1989         Reviewed by Geoff Garen.
1990
1991         https://bugs.webkit.org/show_bug.cgi?id=22683
1992         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
1993         Add a new argumentsForConfiguration() function and clean up some old code to use it.
1994         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
1995
1996         * Scripts/run-javascriptcore-tests:
1997         * Scripts/run-launcher:
1998         * Scripts/run-webkit-tests:
1999         * Scripts/webkitdirs.pm:
2000
2001 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
2002
2003         Reviewed by Cameron Zwarich.
2004
2005         Further preparations for WML layout tests.
2006         Ignore WMLTestCase.js, that's going to be in trunk soon.
2007
2008         * Scripts/make-js-test-wrappers:
2009
2010 2008-12-03  Eric Seidel  <eric@webkit.org>
2011
2012         Build fix for --gtk and --chromium, no review.
2013
2014         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
2015         through to build-jsc.
2016
2017         * Scripts/build-jsc:
2018         * Scripts/webkitdirs.pm:
2019
2020 2008-12-03  Eric Seidel  <eric@webkit.org>
2021
2022         Build fix only, no review.
2023
2024         Remove support for build-webkit --svg-experimental.
2025         All of the "experimental" svg features have their own toggles anyway.
2026         I broke --svg-experimental in my last commit (which then broke clean builds)
2027         I can't find any use of --svg-experimental in our source tree, so removing it.
2028
2029         * Scripts/build-webkit:
2030
2031 2008-12-02  Eric Seidel  <eric@webkit.org>
2032
2033         Reviewed by David Hyatt (and Mark Rowe).
2034
2035         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
2036         Move --coverage support out of run-javascriptcore-tests and into build-jsc
2037
2038         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
2039         there from build-webkit (to allow future sharing with other build-* scripts)
2040
2041         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
2042         picking through ARGV with a blacklist of what arguments weren't jsDriver args
2043         this makes run-javascriptcore-tests transparently support all arguments which
2044         webkitdirs.pm gives it support for.
2045
2046         Make run-javascriptcore-tests actually print what commands it's running before running them.
2047
2048         Add --help support to build-jsc and run-javascriptcore-tests!
2049
2050         Make code to support --svg-experimental defaults take up half as many lines.
2051
2052         * Scripts/build-jsc:
2053         * Scripts/build-webkit:
2054         * Scripts/run-javascriptcore-tests:
2055         * Scripts/webkitdirs.pm:
2056
2057 2008-12-03  Adam Roben  <aroben@apple.com>
2058
2059         Fix a leak in WinLauncher shutdown
2060
2061         Reviewed by Sam Weinig.
2062
2063         * WinLauncher/WinLauncher.cpp:
2064         (_tWinMain): Replaced a delete with a Release. We can't delete the
2065         WebView properly since we only have a pointer to one of its
2066         interfaces. We also shouldn't be deleting COM objects directly anyway,
2067         for a number of reasons.
2068
2069 2008-12-03  Adam Roben  <aroben@apple.com>
2070
2071         Fix a crash on exit in WinLauncher
2072
2073         Reviewed by Sam Weinig.
2074
2075         * WinLauncher/WinLauncher.cpp:
2076         (_tWinMain): Call shutDownWebKit before exiting.
2077
2078 2008-12-03  Adam Roben  <aroben@apple.com>
2079
2080         Add a Debug_Internal configuration to WinLauncher
2081
2082         This matches our other projects.
2083
2084         Reviewed by Sam Weinig.
2085
2086         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
2087         configuration, which is identical to Debug except that it also
2088         references debug_internal.vsprops. Also removed some settings that we
2089         should be picking up from the .vsprops files.
2090
2091 2008-12-02  Eric Seidel  <eric@webkit.org>
2092
2093         Reviewed by David Kilzer.
2094
2095         Hack build-webkit --chromium to use Win32 python instead
2096         of using the default cygwin python.  Scons + CYGWIN tries
2097         to build with GCC by default, we force MSVC in our file
2098         but that just results in errors from Scons.  Until we can fix
2099         this latest round of errors, at least make build-webkit --chromium
2100         actually "work" under CYGWIN instead of forcing users to use
2101         a cmd shell directly.
2102
2103         This is working around a Scons bug:
2104         http://scons.tigris.org/issues/show_bug.cgi?id=2266
2105
2106         * Scripts/webkitdirs.pm:
2107
2108 2008-12-01  David Kilzer  <ddkilzer@apple.com>
2109
2110         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
2111
2112         <https://bugs.webkit.org/show_bug.cgi?id=22466>
2113         <rdar://problem/6403593>
2114
2115         Reviewed by Brady Eidson.
2116
2117         * DumpRenderTree/mac/DumpRenderTree.mm:
2118         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
2119         Keep-Alive, Last-Modified and Server header fields to prevent false
2120         positive test failures.
2121         (convertWebResourceResponseToDictionary): Call
2122         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
2123         header fields.
2124
2125 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
2126
2127         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
2128
2129         <https://bugs.webkit.org/show_bug.cgi?id=22559>
2130
2131         Reviewed by Adam Roben.
2132
2133         * Scripts/bisect-builds: Updated status message to report the
2134         maximum number of builds left to test after the current one.
2135         (max): Added.
2136
2137 2008-11-27  Alp Toker  <alp@nuanti.com>
2138
2139         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
2140         API header breakage at build time.
2141
2142         * GNUmakefile.am:
2143
2144 2008-11-26  Eric Seidel  <eric@webkit.org>
2145
2146         Reviewed by Nikolas Zimmermann and Mark Rowe.
2147
2148         Add support for build-webkit --chromium
2149         https://bugs.webkit.org/show_bug.cgi?id=22515
2150         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
2151
2152         * Scripts/build-dumprendertree:
2153         * Scripts/build-jsc:
2154         * Scripts/build-webkit:
2155         * Scripts/gdb-safari:
2156         * Scripts/run-webkit-tests:
2157         * Scripts/webkitdirs.pm:
2158
2159 2008-11-26  Eric Seidel  <eric@webkit.org>
2160
2161         Reviewed by Nikolas Zimmermann.
2162
2163         Add support for build-webkit --chromium (tested on mac)
2164         https://bugs.webkit.org/show_bug.cgi?id=22515
2165         Also simplified some code using checkArgv
2166
2167         * Scripts/build-webkit:
2168         * Scripts/webkitdirs.pm:
2169
2170 2008-11-26  Eric Seidel  <eric@webkit.org>
2171
2172         Reviewed by Nikolas Zimmermann.
2173
2174         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
2175         https://bugs.webkit.org/show_bug.cgi?id=22515
2176         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
2177         in preparation for having a chromium cygwin and chromium mac build
2178
2179         * Scripts/build-webkit:
2180         * Scripts/webkitdirs.pm:
2181
2182 2008-11-26  Eric Seidel  <eric@webkit.org>
2183
2184         Reviewed by Nikolas Zimmermann.
2185
2186         Pre-work for getting build-webkit --chromium to work
2187         https://bugs.webkit.org/show_bug.cgi?id=22515
2188         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
2189
2190         * Scripts/build-dumprendertree:
2191         * Scripts/build-jsc:
2192         * Scripts/build-webkit:
2193         * Scripts/gdb-safari:
2194         * Scripts/run-javascriptcore-tests:
2195         * Scripts/run-webkit-tests:
2196         * Scripts/webkitdirs.pm:
2197
2198 2008-11-26  David Kilzer  <ddkilzer@apple.com>
2199
2200         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
2201
2202         <https://bugs.webkit.org/show_bug.cgi?id=22488>
2203
2204         Reviewed by Brady Eidson.
2205
2206         * DumpRenderTree/mac/DumpRenderTree.mm:
2207         (convertWebResourceDataToString): If an IANA charset encoding string
2208         is provided, convert it to a CFStringEncoding value and then to an
2209         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
2210         also nil-check dataAsString, so the worst-case scenario is that the
2211         data won't be decoded to a string (versus crashing DumpRenderTree).
2212
2213 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
2214
2215         Reviewed by Holger Freyther.
2216
2217         [Gtk] add/remove tests from Skipped and fix netscape plugin test
2218         https://bugs.webkit.org/show_bug.cgi?id=22484
2219
2220         Remove print'ing to stderr
2221
2222         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2223         (NP_Initialize):
2224         (NP_Shutdown):
2225
2226 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
2227
2228         Windows build fix.
2229
2230         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2231
2232 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
2233
2234         Windows build fix.
2235
2236         * DumpRenderTree/cg/ImageDiffCG.cpp:
2237
2238 2008-11-24  Darin Fisher  <darin@chromium.org>
2239
2240         Fix bustage.
2241
2242         https://bugs.webkit.org/show_bug.cgi?id=15643
2243
2244         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2245         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2246
2247 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
2248
2249         Reviewed by Alexey Proskuryakov.
2250
2251         http://bugs.webkit.org/show_bug.cgi?id=15643
2252
2253         Added support for changing the "trailing whitespace" work-around
2254         in LayoutTestController (so layout tests can verify this functionality)
2255
2256         * DumpRenderTree/LayoutTestController.cpp:
2257         (setSelectTrailingWhitespaceEnabledCallback):
2258         (LayoutTestController::staticFunctions):
2259         * DumpRenderTree/LayoutTestController.h:
2260         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2261         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2262         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2263         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2264
2265 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
2266
2267         Reviewed by Darin Adler
2268
2269         https://bugs.webkit.org/show_bug.cgi?id=22433
2270
2271         Add script that attempts to detect virtual methods
2272         whose signatures differ only by constness (which can
2273         indicate a programming error).
2274
2275         * Scripts/detect-mismatched-virtual-const: Added.
2276
2277 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
2278
2279         Reviewed by Holger Freyther.
2280
2281         https://bugs.webkit.org/show_bug.cgi?id=22039
2282
2283         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
2284         build.
2285
2286         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2287         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2288         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2289         (setDefaultsToConsistentStateValuesForTesting):
2290         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
2291         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
2292         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
2293         * GNUmakefile.am:
2294
2295 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
2296
2297         Reviewed by Mark Rowe.
2298
2299         [Gtk+] Add configure option to enable Web Workers and enable it by default
2300
2301         Add --enable-workers to the buildsystem (used by build-webkit) add
2302         the to be build files to the GNUmakefile.am and change build-webkit
2303         to enable Web Workers by default.
2304
2305         * Scripts/build-webkit:
2306
2307 2008-11-24  Mark Rowe  <mrowe@apple.com>
2308
2309         Reviewed by Alexey Proskuryakov.
2310
2311         Let gdb-safari accept the --debug and --release options once more.
2312
2313         * Scripts/gdb-safari:
2314
2315 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
2316
2317         Reviewed by Holger Freyther. Landed by Jan Alonzo.
2318
2319         Get SVG tests tested on GTK port.
2320
2321         * Scripts/webkitdirs.pm:
2322
2323 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
2324
2325         Reviewed by Darin Adler.
2326
2327         https://bugs.webkit.org/show_bug.cgi?id=21810
2328         Remove use of static C++ objects that are destroyed at exit time (destructors)
2329
2330         All static C++ objects that create atexit calls are gone. Update script
2331         to indicate how to fix the problem should a new one appear.
2332
2333         * Scripts/check-for-exit-time-destructors:
2334
2335 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
2336
2337         Reviewed by Darin Adler.
2338
2339         https://bugs.webkit.org/show_bug.cgi?id=22337
2340         Enable workers by default
2341
2342         * Scripts/build-webkit: Changed the default to enabled.
2343
2344 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
2345
2346         Rubber-stamped by Darin Adler.
2347
2348         https://bugs.webkit.org/show_bug.cgi?id=22306
2349         Disable channel messaging support
2350
2351         * Scripts/build-webkit: Add an option to enable channel messaging.
2352
2353 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
2354
2355         Reviewed by George Staikos.
2356
2357         Add --(no-)wml build flags.
2358
2359         * Scripts/build-webkit:
2360         * Scripts/run-webkit-tests:
2361         * Scripts/webkitdirs.pm:
2362
2363 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
2364
2365         Not reviewed.
2366
2367         Try to fix gtk build.
2368
2369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2370         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2371         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2372
2373 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
2374
2375         Reviewed by Maciej.
2376
2377         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
2378         on Tiger.
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=22271
2381
2382         * Scripts/run-webkit-tests:
2383
2384 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
2385
2386         Reviewed by Sam Weinig.
2387
2388         Added new JavaScript API on LayoutController to pause a running
2389         CSS transition or animation at a given time.
2390
2391         https://bugs.webkit.org/show_bug.cgi?id=21261
2392
2393         * DumpRenderTree/LayoutTestController.cpp:
2394         (pauseAnimationAtTimeOnElementWithIdCallback):
2395         (pauseTransitionAtTimeOnElementWithIdCallback):
2396         (LayoutTestController::staticFunctions):
2397         * DumpRenderTree/LayoutTestController.h:
2398         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2399         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2400         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2401         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2402         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2403         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2404
2405 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
2406
2407         Reviewed by Darin Adler.
2408
2409         <https://bugs.webkit.org/show_bug.cgi?id=22309>
2410         Pass the remaining options to build system on Qt-port
2411
2412         * Scripts/build-webkit:
2413         * Scripts/webkitdirs.pm:
2414
2415 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
2416
2417         Reviewed by Darin Adler.
2418
2419         https://bugs.webkit.org/show_bug.cgi?id=21810
2420         Remove use of static C++ objects that are destroyed at exit time (destructors)
2421
2422         Remove .o files from the exclude list that have had their exit-time destructors removed.
2423         Handle case when there is no current symbol.
2424
2425         * Scripts/check-for-exit-time-destructors:
2426
2427 2008-11-16  Sam Weinig  <sam@webkit.org>
2428
2429         * Scripts/do-webcore-rename: Remove now fixed renames.
2430
2431 2008-11-16  Darin Adler  <darin@apple.com>
2432
2433         * Scripts/do-webcore-rename: Plan some future renames.
2434
2435 2008-11-15  Darin Adler  <darin@apple.com>
2436
2437         Rubber stamped by Geoff Garen.
2438
2439         - do the long-planned StructureID -> Structure rename
2440
2441         * Scripts/check-for-global-initializers: Update name of StructureID.o.
2442         * Scripts/do-webcore-rename: Renaming script that I used.
2443
2444 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
2445
2446         Reviewed by Darin Adler.
2447
2448         https://bugs.webkit.org/show_bug.cgi?id=21810
2449         Remove use of static C++ objects that are destroyed at exit time (destructors)
2450
2451         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
2452         exit-time destructor. Update code that was changed to fix this issue that ran
2453         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
2454         in gcc build 5465). Also typdefs for template types needed to be added in some
2455         cases so the type could make it through the macro successfully.
2456
2457         Basically code of the form:
2458         static T m;
2459         becomes:
2460         DEFINE_STATIC_LOCAL(T, m, ());
2461
2462         Also any code of the form:
2463         static T& m = *new T;
2464         also becomes:
2465         DEFINE_STATIC_LOCAL(T, m, ());
2466
2467         Remove .o files from the exclude list that have had their exit-time destructors removed.
2468
2469         * Scripts/check-for-exit-time-destructors:
2470
2471 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
2472
2473         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
2474
2475         * wx/install-unix-extras:
2476
2477 2008-11-14  Alp Toker  <alp@nuanti.com>
2478
2479         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
2480
2481         Fixes Debian bug #505723
2482         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
2483
2484         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2485
2486 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
2487
2488         Reviewed by Simon Hausmann.
2489
2490         Fix hanging DRT with Qt.
2491
2492         https://bugs.webkit.org/show_bug.cgi?id=22209
2493
2494         * DumpRenderTree/qt/DumpRenderTree.cpp:
2495         (WebCore::DumpRenderTree::dump):
2496         Send empty pixel test data 'block', which is now
2497         expected by run-layout-tests.
2498
2499 2008-11-12  Dmitry Titov  <dimich@chromium.org>
2500
2501         Reviewed by Alexey Proskuryakov.
2502
2503         https://bugs.webkit.org/show_bug.cgi?id=22216
2504
2505         * Scripts/build-webkit:
2506         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
2507
2508 2008-11-06  David Kilzer  <ddkilzer@apple.com>
2509
2510         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
2511
2512         Apparently older versions of gcc have issues with this patch.
2513         Backing out a second time until the issues are resolved.
2514
2515 2008-11-06  David Kilzer  <ddkilzer@apple.com>
2516
2517         BUILD WAS NOT BROKEN: Rolling r38189 back in.
2518
2519         Please perform a clean build if you see crashes.
2520
2521 2008-11-06  David Kilzer  <ddkilzer@apple.com>
2522
2523         BUILD FIX: Backed out r38189 since it apparently broke the world.
2524
2525 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
2526
2527         Reviewed by Beth Dakin.
2528
2529         Add ability to query an attribute's settable status and the
2530         ability to retrieve a single attribute from an AXObject
2531
2532         * DumpRenderTree/AccessibilityUIElement.cpp:
2533         (isAttributeSettableCallback):
2534         (attributeValueCallback):
2535         (AccessibilityUIElement::getJSClass):
2536         * DumpRenderTree/AccessibilityUIElement.h:
2537         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2538         (+[NSString stringWithJSStringRef:]):
2539         (AccessibilityUIElement::attributeValue):
2540         (AccessibilityUIElement::isAttributeSettable):
2541         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2542         (AccessibilityUIElement::attributeValue):
2543         (AccessibilityUIElement::isAttributeSettable):
2544
2545 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
2546
2547         Reviewed by Darin Adler.
2548
2549         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
2550         https://bugs.webkit.org/show_bug.cgi?id=21810
2551
2552         Remove .o files from the exclude list that have had their exit-time destructors removed.
2553
2554         * Scripts/check-for-exit-time-destructors:
2555
2556 2008-11-05  Alp Toker  <alp@nuanti.com>
2557
2558         GTK build script tweak.
2559
2560         Make the path relative since it will appear in all -I compiler flags.
2561         Long argument lists cause bizarre slowdowns in libtool and result
2562         in huge build logs.
2563
2564         * Scripts/webkitdirs.pm:
2565
2566 2008-11-05  Anders Carlsson  <andersca@apple.com>
2567
2568         Fix 64-bit build.
2569
2570         * DumpRenderTree/mac/DumpRenderTree.mm:
2571         (setDefaultsToConsistentValuesForTesting):
2572
2573 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
2574
2575         Add AccessibilityObject.o to the exclude list for the
2576         check for global destructors.
2577
2578         * Scripts/check-for-exit-time-destructors:
2579
2580 2008-11-04  Darin Adler  <darin@apple.com>
2581
2582         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
2583         bot, but for some reason not on my computer.
2584
2585 2008-11-03  Darin Adler  <darin@apple.com>
2586
2587         Reviewed by Tim Hatcher.
2588
2589         - https://bugs.webkit.org/show_bug.cgi?id=22061
2590           create script to check for exit-time destructors
2591
2592         * Scripts/check-for-exit-time-destructors: Added.
2593         Started as a copy of check-for-global-initializers.
2594
2595         * Scripts/check-for-global-initializers: Added code to make
2596         this script rerun any time it's modified, and also to properly
2597         run again after the first time it reports an error.
2598
2599 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
2600
2601         Reviewed by Dan Bernstein.
2602
2603         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
2604
2605         https://bugs.webkit.org/show_bug.cgi?id=22054
2606
2607         * DumpRenderTree/mac/DumpRenderTree.mm:
2608         (setDefaultsToConsistentValuesForTesting):
2609
2610 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
2611
2612         Not reviewed.
2613
2614         * Scripts/do-webcore-rename:
2615
2616         Add some renames to contemplate for the future.
2617
2618 2008-10-31  Darin Adler  <darin@apple.com>
2619
2620         Requested by Mark Rowe.
2621
2622         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
2623
2624 2008-10-31  David Kilzer  <ddkilzer@apple.com>
2625
2626         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
2627
2628         <https://bugs.webkit.org/show_bug.cgi?id=21997>
2629
2630         Reviewed by Darin Adler.
2631
2632         * Scripts/prepare-ChangeLog:
2633         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
2634         This prevents them from showing up in the new ChangeLog entry.  They
2635         were already excluded from @{$changedFiles}.
2636
2637 2008-10-30  Mark Rowe  <mrowe@apple.com>
2638
2639         Reviewed by Jon Homeycutt.
2640
2641         Explicitly default to building for only the native architecture in debug and release builds.
2642
2643         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2644
2645 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
2646
2647         Reviewed by Dan Bernstein.
2648
2649         Fixed 64 bit build failure.
2650
2651         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2652         (setupMainDisplayColorProfile):
2653         (createBitmapContextFromWebView):
2654
2655 2008-10-28  Alp Toker  <alp@nuanti.com>
2656
2657         Fix GTK DRT following build breakage in r37928.
2658
2659         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2660         (dump):
2661         (runTest):
2662         (main):
2663
2664 2008-10-28  Alp Toker  <alp@nuanti.com>
2665
2666         Reviewed by Mark Rowe.
2667
2668         Fix recently introduced double-free crashes in GTK DRT.
2669
2670         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
2671         were updated to call ->deref() but GTK DRT was still deleting
2672         gLayoutTestController manually. This patch updates GTK to match the
2673         other ports and resolves the memory allocation issues.
2674
2675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2676         (runTest):
2677
2678 2008-10-28  Alp Toker  <alp@nuanti.com>
2679
2680         Reviewed by Mark Rowe.
2681
2682         Fix GTK DRT hang when running the tests.
2683
2684         Update output from the DRT tool to print an additional '#EOF' to match
2685         breaking changes that were made in r37434.
2686
2687         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2688         (dump):
2689
2690 2008-10-28  Adele Peterson  <adele@apple.com>
2691
2692         Reviewed by Sam Weinig.
2693
2694         Specify which Localizable.strings to update since we don't always want to update the file in the same
2695         directory where we're searching for the strings to localize.
2696
2697         * Scripts/extract-localizable-strings:
2698         * Scripts/update-webkit-localizable-strings:
2699
2700 2008-10-28  Timothy Hatcher  <timothy@apple.com>
2701
2702         Add support for enabling the profiler, so the profiling tests can continue
2703         work now that the profiler is not always enabled.
2704
2705         https://bugs.webkit.org/show_bug.cgi?id=21927
2706
2707         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
2708         not slow down JavaScript all the time
2709
2710         Reviewed by Darin Adler and Kevin McCullough.
2711
2712         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
2713         * DumpRenderTree/LayoutTestController.cpp:
2714         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
2715         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
2716         * DumpRenderTree/LayoutTestController.h:
2717         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2718         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
2719         * DumpRenderTree/mac/DumpRenderTree.mm:
2720         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
2721         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2722         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
2723         * DumpRenderTree/win/DumpRenderTree.cpp:
2724         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
2725         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2726         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
2727
2728 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
2729
2730         Reviewed by Dan Bernstein
2731
2732         Primary changes in DumpRenderTree:
2733         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
2734         is different from regular font CG anti-aliasing) as font-smoothing settings
2735         depends on the display and can also be changed by the user
2736         - Use a new cleared buffer for each test instead of the reusing same one to
2737         avoid potential result corruption across tests
2738         - Can now receive the expected pixel hash as a suffix to the test path or
2739         url as "path'hash"
2740         - Make sure hash is computed in a endian-independent way
2741         - Improve the code that sets/restores the screen color profile
2742         - Make the code more cross-platformy with std::string goodness
2743         - Added an "on-screen" mode where the snapshot will take into account surfaces
2744         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
2745         reading from the display framebuffer on 10.4. This mode is not active by
2746         default for performance reason, but must be explicitly activated from the test
2747         file using the new "testOnscreen()" JS API.
2748
2749         Primary changes in ImageDiff:
2750         - Provide a new comparison algorithm that is more tolerant to "acceptable"
2751         failures (i.e. very small differences in font rendering, which --threshold is
2752         not really good at handling)
2753         - Generate normalized intensity-only diff images
2754
2755         Primary changes in run-webkit-tests:
2756         - Take advantage of hashes for pixel tests which makes them much faster by
2757         minimizing image comparisons
2758         - Removed repaint options as these should be set from within test files using
2759         JS API
2760         - Replaced "threshold" option in  by "tolerance" expressed in percents
2761         - Added more logging when in "verbose" mode
2762
2763         https://bugs.webkit.org/show_bug.cgi?id=21322
2764         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2765         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
2766         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
2767         * DumpRenderTree/LayoutTestController.cpp:
2768         (LayoutTestController::LayoutTestController):
2769         (testOnscreenCallback):
2770         (LayoutTestController::staticFunctions):
2771         * DumpRenderTree/LayoutTestController.h:
2772         (LayoutTestController::testOnscreen):
2773         (LayoutTestController::setTestOnscreen):
2774         (LayoutTestController::testPathOrURL):
2775         (LayoutTestController::expectedPixelHash):
2776         * DumpRenderTree/PixelDumpSupport.h:
2777         * DumpRenderTree/cg/ImageDiffCG.cpp:
2778         (strtof):
2779         (releaseMallocBuffer):
2780         (createDifferenceImage):
2781         (imageHasAlpha):
2782         (main):
2783         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2784         (computeMD5HashStringForBitmapContext):
2785         (dumpWebViewAsPixelsAndCompareWithExpected):
2786         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2787         (BitmapContext::createByAdoptingBitmapAndContext):
2788         (BitmapContext::~BitmapContext):
2789         (BitmapContext::cgContext):
2790         (BitmapContext::BitmapContext):
2791         * DumpRenderTree/mac/DumpRenderTree.mm:
2792         (shouldIgnoreWebCoreNodeLeaks):
2793         (setDefaultsToConsistentValuesForTesting):
2794         (crashHandler):
2795         (initializeGlobalsFromCommandLineOptions):
2796         (prepareConsistentTestingEnvironment):
2797         (dumpRenderTree):
2798         (sizeWebViewForCurrentTest):
2799         (dump):
2800         (runTest):
2801         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2802         (restoreMainDisplayColorProfile):
2803         (setupMainDisplayColorProfile):
2804         (createBitmapContextFromWebView):
2805         * DumpRenderTree/win/DumpRenderTree.cpp:
2806         (dump):
2807         (runTest):
2808         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2809         (getBitmapContextFromWebView):
2810         * Scripts/run-webkit-tests:
2811
2812 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
2813
2814         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
2815
2816         * wx/build-wxwebkit:
2817
2818 2008-10-24  Anders Carlsson  <andersca@apple.com>
2819
2820         Try fixing the 64-bit build.
2821
2822         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2823         (testGetProperty):
2824
2825 2008-10-24  Anders Carlsson  <andersca@apple.com>
2826
2827         Reviewed by Sam Weinig.
2828
2829         <rdar://problem/5440917> Support NPN_Construct
2830
2831         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2832         (testCallback):
2833         Fix a memory leak.
2834
2835         (testConstruct):
2836         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
2837
2838         (pluginInvoke):
2839         Handle testConstruct.
2840
2841         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
2842         (testGetProperty):
2843         Add objectPointer property.
2844
2845         (testEnumerate):
2846         Only enumerate the two first properties.
2847
2848         (testConstruct):
2849         Add a simple construct implementation that just returns the test object.
2850
2851 2008-10-24  David Kilzer  <ddkilzer@apple.com>
2852
2853         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
2854
2855         <https://bugs.webkit.org/show_bug.cgi?id=21850>
2856
2857         Reviewed by Adam Roben.
2858
2859         * Scripts/svn-apply: Save end-of-line characters when stripping them
2860         off each line of a patch so that they may be restored after
2861         processing the line.
2862         * Scripts/svn-unapply: Ditto.
2863
2864 2008-10-23  David Kilzer  <ddkilzer@apple.com>
2865
2866         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
2867
2868         <https://bugs.webkit.org/show_bug.cgi?id=21832>
2869
2870         Reviewed by Sam Weinig.
2871
2872         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
2873         instead of 'new File::Temp' to make the script work with Perl 5.10.
2874         * Scripts/sort-Xcode-project-file: Ditto.
2875
2876 2008-10-22  Brady Eidson  <beidson@apple.com>
2877
2878         Reviewed by Adam Roben
2879
2880         <rdar://6261773> - autocomplete="off" doesn't work on Windows
2881
2882         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
2883
2884         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2885
2886 2008-10-22  Darin Adler  <darin@apple.com>
2887
2888         * Scripts/do-webcore-rename: More renaming plans.
2889
2890 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
2891
2892         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
2893
2894         * Scripts/extract-localizable-strings:
2895
2896 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2897
2898         Reviewed by Mark Rowe.
2899
2900         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
2901         excess different stack logs.
2902
2903         (Also fix a small bug in my last change.)
2904
2905         * Scripts/run-webkit-tests:
2906
2907 2008-10-17  Stephanie Lewis  <slewis@apple.com>
2908
2909         Reviewed by Mark Rowe.
2910
2911         Fix layout tests that use prologues and epilogues.
2912
2913         * Scripts/run-webkit-tests:
2914
2915 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2916
2917         Reviewed by Mark Rowe.
2918
2919         - make sure MallocStackLogging is only on for tools we want to
2920         leak check, not other random stuff as well.
2921
2922         * Scripts/run-webkit-tests:
2923
2924 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
2925
2926         Reviewed by Stephanie Lewis.
2927
2928         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
2929
2930         This should reduce or eliminate crashes on the buildbot due to
2931         running out of memory while stack logging.
2932
2933         * Scripts/run-webkit-tests:
2934
2935 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
2936
2937         Gtk build fix. Not reviewed.
2938
2939         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2940         (LayoutTestController::setSmartInsertDeleteEnabled):
2941
2942 2008-10-15  Glenn Wilson  <gwilson@google.com>
2943
2944         Added new method to allow tests to disable smart editing in the course of a test.
2945         This is a possible solution to bug .20655
2946
2947         Reviewed by Tim Hatcher.
2948
2949         * DumpRenderTree/LayoutTestController.cpp:
2950         (setSmartInsertDeleteEnabledCallback): new method
2951         (LayoutTestController::staticFunctions): added new method to static list of callbacks
2952         * DumpRenderTree/LayoutTestController.h: added signature of new method
2953         * DumpRenderTree/mac/DumpRenderTree.mm:
2954         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2955         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2956         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2957         * DumpRenderTree/win/DumpRenderTree.cpp:
2958         (resetWebViewToConsistentStateBeforeTesting): added state resetting
2959         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2960         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
2961
2962 2008-10-14  Ada Chan  <adachan@apple.com>
2963
2964         Fix windows build.
2965
2966         Reviewed by Sam Weinig.
2967
2968         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2969         * DumpRenderTree/config.h:
2970         * DumpRenderTree/win/DumpRenderTreeWin.h:
2971         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2972         * DumpRenderTree/win/UIDelegate.cpp:
2973
2974 2008-10-13  Timothy Hatcher  <timothy@apple.com>
2975
2976         Make prepare-ChangeLog populate the changed functions for JavaScript files.
2977
2978         https://bugs.webkit.org/show_bug.cgi?id=21567
2979
2980         Reviewed by David Kilzer.
2981
2982         * Scripts/prepare-ChangeLog:
2983         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
2984         files that end with ".js".
2985         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
2986         and getters/setters.
2987
2988 2008-10-14  Alp Toker  <alp@nuanti.com>
2989
2990         Reviewed by Sam Weinig.
2991
2992         https://bugs.webkit.org/show_bug.cgi?id=16299
2993         Add a config.h file to DRT
2994
2995         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
2996         an ad-hoc config header.
2997
2998         * DumpRenderTree/AccessibilityController.cpp:
2999         * DumpRenderTree/AccessibilityUIElement.cpp:
3000         * DumpRenderTree/AccessibilityUIElement.h:
3001         * DumpRenderTree/DumpRenderTree.h:
3002         * DumpRenderTree/GCController.cpp:
3003         * DumpRenderTree/LayoutTestController.cpp:
3004         * DumpRenderTree/WorkQueue.cpp:
3005         * DumpRenderTree/config.h: Added.
3006         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3007         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3008         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3009         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3010         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3011         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3012         * DumpRenderTree/win/DumpRenderTree.cpp:
3013         * DumpRenderTree/win/DumpRenderTreeWin.h:
3014         * DumpRenderTree/win/EditingDelegate.cpp:
3015         * DumpRenderTree/win/EventSender.cpp:
3016         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3017         * DumpRenderTree/win/GCControllerWin.cpp:
3018         * DumpRenderTree/win/MD5.cpp:
3019         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3020         * DumpRenderTree/win/PolicyDelegate.cpp:
3021         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3022         * DumpRenderTree/win/WorkQueueItemWin.cpp:
3023         * GNUmakefile.am:
3024
3025 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
3026
3027         Reviewed by Beth Dakin.
3028
3029         Added a method to get the links in a webpage
3030
3031         * DumpRenderTree/AccessibilityUIElement.cpp:
3032         (attributesOfDocumentLinksCallback):
3033         (AccessibilityUIElement::getJSClass):
3034         * DumpRenderTree/AccessibilityUIElement.h:
3035         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3036         (AccessibilityUIElement::getDocumentLinks):
3037         (AccessibilityUIElement::attributesOfDocumentLinks):
3038         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3039         (AccessibilityUIElement::getDocumentLinks):
3040         (AccessibilityUIElement::attributesOfDocumentLinks):
3041
3042 2008-10-13  David Kilzer  <ddkilzer@apple.com>
3043
3044         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
3045
3046         <https://bugs.webkit.org/show_bug.cgi?id=21457>
3047
3048         Reviewed by Adam.
3049
3050         * Scripts/resolve-ChangeLogs: Added optional parameter to
3051         -f|--fix-merged switch to run the script on a revision range.
3052         Updated command-line validation checks.
3053         (findChangeLog): Fixed long-standing bug that should have used
3054         $_[0] instead of $_.
3055         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
3056         to work when called from git filter-branch.  It always restores a
3057         copy of the previous revision before reapplying the patch.
3058         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
3059         to re-merge ChangeLog files across a revision range.  Removes
3060         .git/refs/original directory on success.
3061         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
3062         switch.
3063         (removeChangeLogArguments): Added.  Removes items from @ARGV when
3064         they are ChangeLog paths, and return a list of paths.  This makes it
3065         easier to validate the command-line.
3066         (resolveChangeLog): Added.  Extracted from main code block.  Runs
3067         the traditional single-file merge algorithm.
3068         (usageAndExit): Added.  Extracted from main code block.  Prints
3069         usage statement and exits with error status.
3070
3071 2008-10-12  Darin Adler  <darin@apple.com>
3072
3073         * Scripts/make-js-test-wrappers: Update exceptions list so the script
3074         won't overwrite files and mangle tests.
3075
3076 2008-10-11  Dan Bernstein  <mitz@apple.com>
3077
3078         Reviewed by Sam Weinig and Anders Carlsson.
3079
3080         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
3081           complex text code path
3082         - add --complex-text support to Windows DumpRenderTree
3083
3084         * DumpRenderTree/mac/DumpRenderTree.mm:
3085         (dumpRenderTree):
3086         * DumpRenderTree/win/DumpRenderTree.cpp:
3087         (createWebViewAndOffscreenWindow):
3088         (main):
3089         * Scripts/run-webkit-tests:
3090
3091 2008-10-09  Eric Seidel  <eric@webkit.org>
3092
3093         Reviewed by Oliver Hunt.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=21498
3096
3097         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
3098
3099 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
3100
3101         Not reviewed.
3102
3103         Add StructureID.o to the exclusion list in the global initializers
3104         script to fix the Debug build.
3105
3106         * Scripts/check-for-global-initializers:
3107
3108 2008-10-08  Mark Rowe  <mrowe@apple.com>
3109
3110         Fix the Windows build after r37434.
3111
3112         * DumpRenderTree/win/DumpRenderTree.cpp:
3113         (dump): Update code to approximate valid C++ syntax.
3114
3115 2008-10-08  Timothy Hatcher  <timothy@apple.com>
3116
3117         Add SVGElementInstance to the list of exceptions that have
3118         global initializers in debug builds.
3119
3120         Rubber-stamped by Mark Rowe.
3121
3122         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
3123
3124 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
3125
3126         Reviewed by Dan Bernstein
3127
3128         Avoid disconnect between DRT and run-webkit-tests
3129         about whether to expect PNG dumps by having DRT always
3130         print two blocks terminated by #EOF, the second of which
3131         may be empty.
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=21483
3134
3135         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3136         (printPNG):
3137         (dumpWebViewAsPixelsAndCompareWithExpected):
3138         * DumpRenderTree/mac/DumpRenderTree.mm:
3139         (dump):
3140         * DumpRenderTree/win/DumpRenderTree.cpp:
3141         (dump):
3142         * Scripts/run-webkit-tests:
3143
3144 2008-10-07  Adam Roben  <aroben@apple.com>
3145
3146         Make sure short functions get included in ChangeLog output for git
3147         repositories
3148
3149         Reviewed by Dave Kilzer.
3150
3151         * Scripts/prepare-ChangeLog:
3152         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
3153         will get its own chunk without any surrounding context.
3154         (sub extractLineRange): Use the line numbers from the chunk header
3155         without modifying them now that they're accurate.
3156
3157 2008-10-04  Mark Rowe  <mrowe@apple.com>
3158
3159         Reviewed by Tim Hatcher.
3160
3161         Update check-for-weak-vtables to check only the final linked image for weak vtables.
3162         This gives more useful results than checking each object file independently.
3163
3164         * Scripts/check-for-weak-vtables:
3165
3166 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
3167
3168         Reviewed by Darin Adler
3169
3170         Render images to RGBA8 bitmaps independently of platform endianness.
3171
3172         Create image difference bitmap in reference image colorspace instead of device colorspace
3173         (which depends on the main display profile), so that no color matching happens.
3174
3175         https://bugs.webkit.org/show_bug.cgi?id=21336
3176
3177         * DumpRenderTree/cg/ImageDiffCG.cpp:
3178         (createDifferenceBitmap):
3179         (computePercentageDifferent):
3180         (compareImages):
3181
3182 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
3183
3184         Reviewed by Darin Adler
3185
3186         Fix hang when running with --pixel --reset, which occurs
3187         because DRT spews PNG data when the script does not expect it.
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=21323
3190
3191         * Scripts/run-webkit-tests:
3192
3193 2008-09-30  Mark Rowe  <mrowe@apple.com>
3194
3195         Reviewed by Dan Bernstein.
3196
3197         Add a leak counter for CachedResources since we've had two recent leaks involving them.
3198
3199         * Scripts/check-for-global-initializers:
3200
3201 2008-09-30  Mark Rowe  <mrowe@apple.com>
3202
3203         Rubber-stamped by Dan Bernstein.
3204
3205         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
3206
3207         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
3208         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
3209         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
3210         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
3211         torn down before we exit.
3212
3213         * DumpRenderTree/mac/DumpRenderTree.mm:
3214         (dumpRenderTree):
3215         (main):
3216
3217 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
3218
3219         Reviewed by Dan Bernstein
3220
3221         Don't run pixel comparison for text-only tests.
3222         https://bugs.webkit.org/show_bug.cgi?id=21124
3223
3224         * DumpRenderTree/mac/DumpRenderTree.mm:
3225         (dump):
3226         * Scripts/run-webkit-tests:
3227
3228 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
3229
3230         Reviewed by Simon.
3231
3232         Changed copyright from Trolltech ASA to Nokia.
3233
3234         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
3235
3236
3237         * DumpRenderTree/qt/DumpRenderTree.cpp:
3238         * DumpRenderTree/qt/jsobjects.cpp:
3239         * DumpRenderTree/qt/jsobjects.h:
3240         * DumpRenderTree/qt/main.cpp:
3241         * DumpRenderTree/qt/testplugin.cpp:
3242         * DumpRenderTree/qt/testplugin.h:
3243
3244 2008-09-28  David Kilzer  <ddkilzer@apple.com>
3245
3246         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
3247
3248         <https://bugs.webkit.org/show_bug.cgi?id=21185>
3249
3250         Reviewed by Adam.
3251
3252         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
3253         will attempt to reapply the last commit to a ChangeLog file such
3254         that the ChangeLog entry appears at the top of the file.
3255         (findChangeLog): Added prototype and moved method below the exit
3256         statement.
3257         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
3258         ChangeLog entries.
3259
3260 2008-09-27  Anders Carlsson  <andersca@apple.com>
3261
3262         Reviewed by Sam Weinig.
3263
3264         https://bugs.webkit.org/show_bug.cgi?id=21178
3265         <rdar://problem/6248651>
3266
3267         Return the result value from getURL.
3268
3269         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3270         (getURL):
3271
3272 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
3273
3274         Reviewed by Tim Hatcher.
3275
3276         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
3277
3278         * Scripts/build-webkit:
3279
3280 2008-09-26  Alice Liu  <alice.liu@apple.com>
3281
3282         Remove usage of atlstr.h and CString for VCExpress compatibility
3283
3284         Reviewed by Stephanie Lewis.
3285
3286         * record-memory-win/main.cpp:
3287         (ProcessArgs):
3288         (UseImage):
3289         (QueryContinuously):
3290         (OneQuery):
3291         (OneQueryMP):
3292
3293 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
3294
3295         wx build fix. Update the version of libpng.
3296
3297         * wx/install-unix-extras:
3298
3299 2008-09-24  Sam Weinig  <sam@webkit.org>
3300
3301         Reviewed by Darin Adler.
3302
3303         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
3304         <rdar://problem/6243534>
3305         Crash below Function.apply when using a runtime array as the argument list
3306
3307         Add method to ObjCController to return a runtime array.
3308
3309         * DumpRenderTree/mac/ObjCController.m:
3310         (+[ObjCController isSelectorExcludedFromWebScript:]):
3311         (+[ObjCController webScriptNameForSelector:]):
3312         (-[ObjCController testArray]):
3313
3314 2008-09-24  Beth Dakin  <bdakin@apple.com>
3315
3316         Reviewed by Sam Weinig.
3317
3318         Speculative build fix.
3319
3320         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3321         (AccessibilityUIElement::supportsPressAction):
3322
3323 2008-09-23  Beth Dakin  <bdakin@apple.com>
3324
3325         Reviewed by Sam Weinig.
3326
3327         This patch extends DumpRenderTree's AccessibilityController to ask
3328         if the focused element supports the press action.
3329
3330         * DumpRenderTree/AccessibilityUIElement.cpp:
3331         (getSupportsPressActionCallback):
3332         (AccessibilityUIElement::getJSClass):
3333         * DumpRenderTree/AccessibilityUIElement.h:
3334         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3335         (AccessibilityUIElement::supportsPressAction):
3336
3337 2008-09-22  Alice Liu  <alice.liu@apple.com>
3338
3339         Adding a stand-alone Windows console application to record a process's memory usage
3340
3341         Reviewed by Steve Falkenburg.
3342
3343         * record-memory-win: Added.
3344         * record-memory-win/main.cpp: Added.
3345         * record-memory-win/record-memory-win.vcproj: Added.
3346
3347 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
3348
3349         Reviewed by Darin Adler.
3350
3351         Support ability to get/set selected text ranges for text controls through AX.
3352
3353         * DumpRenderTree/AccessibilityUIElement.cpp:
3354         (setSelectedTextRangeCallback):
3355         (getSelectedTextRangeCallback):
3356         (AccessibilityUIElement::getJSClass):
3357         * DumpRenderTree/AccessibilityUIElement.h:
3358         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3359         (AccessibilityUIElement::attributesOfRowHeaders):
3360         (AccessibilityUIElement::attributesOfVisibleCells):
3361         (AccessibilityUIElement::rowIndexRange):
3362         (AccessibilityUIElement::columnIndexRange):
3363         (AccessibilityUIElement::cellForColumnAndRow):
3364         (AccessibilityUIElement::selectedTextRange):
3365         (AccessibilityUIElement::setSelectedTextRange):
3366         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3367         (AccessibilityUIElement::selectedTextRange):
3368         (AccessibilityUIElement::setSelectedTextRange):
3369
3370 2008-09-20  Darin Adler  <darin@apple.com>
3371
3372         * DumpRenderTree/mac/DumpRenderTree.mm:
3373         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
3374
3375 2008-09-19  Alp Toker  <alp@nuanti.com>
3376
3377         Build fix for the 'gold' linker and recent binutils. New behaviour
3378         requires that we link to used libraries explicitly.
3379
3380         * GNUmakefile.am:
3381
3382 2008-09-19  Stephanie Lewis  <slewis@apple.com>
3383
3384         Reviewed by Oliver Hunt.
3385
3386         Implement a workaround for an incorrect mime-type on machines with
3387         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
3388         See radar <rdar://problem/6234318>.
3389
3390         * DumpRenderTree/mac/DumpRenderTree.mm:
3391         (convertMIMEType):
3392
3393 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
3394
3395         Fixed Windows bustage
3396
3397         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3398         (AccessibilityUIElement::titleUIElement):
3399
3400 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
3401
3402         Reviewed by Darin Adler.
3403
3404         Expose titleUIElement call for DumpRenderTree
3405
3406         * ChangeLog:
3407         * DumpRenderTree/AccessibilityUIElement.cpp:
3408         (titleUIElementCallback):
3409         (AccessibilityUIElement::getJSClass):
3410         * DumpRenderTree/AccessibilityUIElement.h:
3411         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3412         (AccessibilityUIElement::titleUIElement):
3413
3414 2008-09-18  Darin Adler  <darin@apple.com>
3415
3416         * Scripts/do-webcore-rename: More renaming plans.
3417
3418 2008-09-18  Mark Rowe  <mrowe@apple.com>
3419
3420         Reviewed by Dan Bernstein.
3421
3422         Clear the main frame's name between tests to get more consistent test results
3423         when running the WebKit tests with --nthly.
3424
3425         * DumpRenderTree/mac/DumpRenderTree.mm:
3426         (resetWebViewToConsistentStateBeforeTesting):
3427         * DumpRenderTree/win/DumpRenderTree.cpp:
3428         (resetWebViewToConsistentStateBeforeTesting):
3429
3430 2008-09-18  Stephanie Lewis  <slewis@apple.com>
3431
3432         Really fix tiger jsc tests.
3433
3434         * Scripts/run-javascriptcore-tests:
3435
3436 2008-09-18  Stephanie Lewis  <slewis@apple.com>
3437
3438         Reviewed by Maciej Stachowiak.
3439
3440         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
3441
3442         * Scripts/run-javascriptcore-tests:
3443         * Scripts/webkitdirs.pm:
3444
3445 2008-09-18  Mark Rowe  <mrowe@apple.com>
3446
3447         Rubber-stamped by Sam Weinig.
3448
3449         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
3450         This should make it more obvious when a test does this, as stderr output tends to be obscured
3451         by noise in the test results.
3452
3453         Also fixes some coding style issues in ResourceLoadDelegate.mm.
3454
3455         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3456         (-[NSError _drt_descriptionSuitableForTestResult]):
3457         (-[NSURL _drt_descriptionSuitableForTestResult]):
3458         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3459         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3460         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3461         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3462         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3463         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3464
3465 2008-09-18  Stephanie Lewis  <slewis@apple.com>
3466
3467         Reviewed by Mark Rowe and Maciej Stachowiak..
3468
3469         add a --64-bit option and specify which architecture to run on Mac.
3470
3471         * Scripts/run-javascriptcore-tests:
3472
3473 2008-09-17  Mark Rowe  <mrowe@apple.com>
3474
3475         Reviewed by Sam Weinig.
3476
3477         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
3478
3479         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
3480         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
3481         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
3482
3483         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
3484         * DumpRenderTree/LayoutTestController.cpp:
3485         (LayoutTestController::LayoutTestController):
3486         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
3487         (layoutTestControllerObjectFinalize): Deref the wrapped object.
3488         (LayoutTestController::makeWindowObject): Ref the wrapped object.
3489         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
3490         * DumpRenderTree/mac/DumpRenderTree.mm:
3491         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
3492         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
3493         * DumpRenderTree/win/DumpRenderTree.cpp:
3494         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
3495
3496 2008-09-16  Sam Weinig  <sam@webkit.org>
3497
3498         Reviewed by Mark Rowe.
3499
3500         Add flag to disable running sample on tests that timeout.
3501
3502         * Scripts/run-webkit-tests:
3503
3504 2008-09-16  Adam Roben  <aroben@apple.com>
3505
3506         Windows build fix after r36511
3507
3508         Update for rename of layoutTestController to gLayoutTestController.
3509
3510         * DumpRenderTree/LayoutTestController.cpp:
3511         * DumpRenderTree/win/EditingDelegate.cpp:
3512         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3513         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3514         * DumpRenderTree/win/UIDelegate.cpp:
3515
3516 2008-09-16  Adam Roben  <aroben@apple.com>
3517
3518         Add a script to print out the dependency tree of a Visual Studio
3519         solution file
3520
3521         * Scripts/print-msvc-project-dependencies: Added.
3522
3523 2008-09-16  Mark Rowe  <mrowe@apple.com>
3524
3525         Fix the build.
3526
3527         * DumpRenderTree/LayoutTestController.cpp:
3528         (notifyDoneCallback): Call fprintf in a safer manner.
3529
3530 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
3531
3532         Reviewed by Eric Seidel
3533
3534         Protect against tests that call layoutTestController.notifyDone()
3535         more than once, which would lead to memory corruption, by nulling
3536         out the LayoutTestController on the JSObjectRef on destruction. Also
3537         add a finalize callback on the class so that if the LTC outlives
3538         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
3539         nulled out.
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=20875
3542
3543         * DumpRenderTree/LayoutTestController.cpp:
3544         (LayoutTestController::LayoutTestController):
3545         (notifyDoneCallback):
3546         (layoutTestControllerObjectFinalize):
3547         (LayoutTestController::makeWindowObject):
3548         (LayoutTestController::getJSClass):
3549         * DumpRenderTree/LayoutTestController.h:
3550         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3551         (LayoutTestController::~LayoutTestController):
3552
3553 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
3554
3555         Reviewed by Eric Seidel
3556
3557         Step 1 patch: rename global variable for clarity.
3558         https://bugs.webkit.org/show_bug.cgi?id=20875
3559
3560         * DumpRenderTree/DumpRenderTree.h:
3561         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3562         (dumpWebViewAsPixelsAndCompareWithExpected):
3563         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3564         (dumpFramesAsText):
3565         (dump):
3566         (runTest):
3567         (processWork):
3568         (webViewLoadFinished):
3569         (webViewWindowObjectCleared):
3570         * DumpRenderTree/mac/DumpRenderTree.mm:
3571         (allocateGlobalControllers):
3572         (dumpFrameScrollPosition):
3573         (dumpFramesAsText):
3574         (methodNameStringForFailedTest):
3575         (dump):
3576         (runTest):
3577         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3578         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3579         * DumpRenderTree/mac/EditingDelegate.mm:
3580         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3581         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3582         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3583         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3584         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3585         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3586         (-[EditingDelegate webViewDidBeginEditing:]):
3587         (-[EditingDelegate webViewDidChange:]):
3588         (-[EditingDelegate webViewDidEndEditing:]):
3589         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3590         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3591         (-[FrameLoadDelegate processWork:]):
3592         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3593         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3594         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3595         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3596         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3597         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3598         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3599         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3600         * DumpRenderTree/mac/UIDelegate.mm:
3601         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3602         (-[UIDelegate webViewFocus:]):
3603         (-[UIDelegate webViewUnfocus:]):
3604         (-[UIDelegate webView:createWebViewWithRequest:]):
3605         (-[UIDelegate webViewClose:]):
3606         * DumpRenderTree/win/DumpRenderTree.cpp:
3607         (dumpFrameScrollPosition):
3608         (dumpFramesAsText):
3609         (dump):
3610         (runTest):
3611
3612 2008-09-15  Alice Liu  <alice.liu@apple.com>
3613
3614         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
3615
3616         Reviewed by Stephanie Lewis.
3617
3618         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3619         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
3620         but not Intel.  Add a check for nil before calling.
3621         (AccessibilityUIElement::rowIndexRange):
3622         (AccessibilityUIElement::columnIndexRange):
3623
3624 2008-09-14  Mark Rowe  <mrowe@apple.com>
3625
3626         Build fix.
3627
3628         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3629         (waitUntilDoneWatchdogFired):
3630         * DumpRenderTree/mac/ObjCPlugin.m:
3631
3632 2008-09-08  Dan Bernstein  <mitz@apple.com>
3633
3634         Reviewed by Mark Rowe.
3635
3636         - add an option to run-webkit-tests to always use the complex text code path
3637
3638         * DumpRenderTree/mac/DumpRenderTree.mm:
3639         (initializeGlobalsFromCommandLineOptions):
3640         (dumpRenderTree):
3641         * Scripts/run-webkit-tests:
3642
3643 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
3644
3645         Another Windows nightly build fix.
3646
3647         Reviewed by Sam Weinig.
3648
3649         * FindSafari/FindSafari.cpp:
3650         (_tmain): Delete existing WebKitNightly directory in temp.
3651         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
3652
3653 2008-09-07  Stephanie Lewis  <slewis@apple.com>
3654
3655         Reviewed by Mark Rowe.
3656
3657         Fix DRT build
3658
3659         * DumpRenderTree/DumpRenderTreePrefix.h:
3660         * DumpRenderTree/win/DumpRenderTree.vcproj:
3661
3662 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
3663
3664         Fix Windows nightlies.
3665
3666         Copy WebKit.dll alongside application so registry-free COM can find it.
3667         Update embedded manifest to force use registry-free COM.
3668
3669         Reviewed by Dave Hyatt.
3670
3671         * FindSafari/FindSafari.cpp:
3672         (copyManifest):
3673         (replaceManifest):
3674         (_tmain):
3675         * FindSafari/FindSafari.rc: Added.
3676         * FindSafari/FindSafari.vcproj:
3677         * FindSafari/Safari.exe.manifest: Added.
3678         * FindSafari/resource.h: Added.
3679
3680 === End merge of squirrelfish-extreme ===
3681
3682 2008-08-31  Mark Rowe  <mrowe@apple.com>
3683
3684         Reviewed by Maciej Stachowiak.
3685
3686         Add a --profile flag to run-sunspider.
3687
3688         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
3689         to build scripts as indicating that we should use the "Profiling" configuration.  At present
3690         this is only supported by JavaScriptCore, so using this argument to build any other project
3691         will likely result in unexpected behaviour.
3692
3693 2008-08-27  Mark Rowe  <mrowe@apple.com>
3694
3695         Reviewed by Oliver Hunt.
3696
3697         Fix run-webkit-tests to handle DRT exiting early.
3698
3699         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
3700
3701 === Start merge of squirrelfish-extreme ===
3702
3703 2008-09-04  Mark Rowe  <mrowe@apple.com>
3704
3705         Reviewed by Eric Seidel.
3706
3707         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
3708         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
3709
3710         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
3711
3712 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3713
3714         Reviewed by Oliver Hunt.
3715
3716         Bug 20616: Incorporate V8 benchmarks in testing
3717         <https://bugs.webkit.org/show_bug.cgi?id=20616>
3718
3719         Add support for the --v8 option to run-sunspider.
3720
3721         * Scripts/run-sunspider:
3722
3723 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
3724
3725         wx buildbot fix. More robust handling of clean when makefiles are not built or
3726         are not completely made.
3727
3728         * wx/build-wxwebkit:
3729
3730 2008-09-03  Mark Rowe  <mrowe@apple.com>
3731
3732         More Mac build fixes.
3733
3734         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
3735         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
3736         default configuration specified in the .xcconfig files.
3737
3738         * Scripts/build-webkit:
3739
3740 2008-09-03  Mark Rowe  <mrowe@apple.com>
3741
3742         Mac build fix.  Ensure that dashboard support is enabled.
3743
3744         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3745
3746 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
3747
3748         Build fix. Copy correct version of ICU.
3749
3750         * DumpRenderTree/win/DumpRenderTree.vcproj:
3751
3752 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3753
3754         Reviewed by Simon.
3755
3756         [run-webkit-tests] Use QtLauncher to show the results of the tests
3757         konqueror might not be installed, xdg-open might not be installed but the
3758         QtLauncher should be present.
3759
3760         * Scripts/run-webkit-tests:
3761
3762 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
3763
3764         Initial support for accessibility layout tests on Windows.
3765         https://bugs.webkit.org/show_bug.cgi?id=20497
3766
3767         Reviewed by Sam Weinig.
3768
3769         * DumpRenderTree/AccessibilityController.h: Fix typos.
3770         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
3771         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
3772         prevent oleacc.h, which includes windows.h, from including winsock.h.
3773         Fixed typos.
3774         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
3775         (AccessibilityController::AccessibilityController):
3776         (AccessibilityController::~AccessibilityController):
3777         (AccessibilityController::focusedElement): Get the root element, and
3778         request its focused object.
3779         (AccessibilityController::rootElement): Query Windows for the
3780         accessible client object for the WebView's window.
3781         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
3782         (AccessibilityUIElement::AccessibilityUIElement):
3783         (AccessibilityUIElement::~AccessibilityUIElement):
3784         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
3785         (AccessibilityUIElement::getChildren): Get the child count, and append
3786         each child.
3787         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
3788         index offset by 1. In MSAA, child 0 is the object itself.
3789         (AccessibilityUIElement::allAttributes): Not implemented.
3790         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
3791         (AccessibilityUIElement::attributesOfChildren): Same.
3792         (AccessibilityUIElement::parameterizedAttributeNames): Same.
3793         (self): Return a VARIANT representing the "self" object. This is used
3794         when calling methods that require a child variant.
3795         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
3796         convert it into a string with GetRoleText().
3797         (AccessibilityUIElement::title): Get the element's title, and convert
3798         it to a JS String.
3799         (AccessibilityUIElement::description): Same, for description.
3800         (AccessibilityUIElement::width):
3801         (AccessibilityUIElement::height):
3802         (AccessibilityUIElement::intValue): Get the object's value as a string,
3803         and convert the string to a double.
3804         (AccessibilityUIElement::minValue): Not implemented.
3805         (AccessibilityUIElement::maxValue): Same.
3806         (AccessibilityUIElement::insertionPointLineNumber): Same.
3807         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
3808         (AccessibilityUIElement::attributesOfRowHeaders): Same.
3809         (AccessibilityUIElement::attributesOfColumns): Same.
3810         (AccessibilityUIElement::attributesOfRows): Same.
3811         (AccessibilityUIElement::attributesOfVisibleCells): Same.
3812         (AccessibilityUIElement::attributesOfHeader): Same.
3813         (AccessibilityUIElement::indexInTable): Same.
3814         (AccessibilityUIElement::rowIndexRange): Same.
3815         (AccessibilityUIElement::columnIndexRange): Same.
3816         (AccessibilityUIElement::lineForIndex): Same.
3817         (AccessibilityUIElement::boundsForRange): Same.
3818         (AccessibilityUIElement::cellForColumnAndRow): Same.
3819         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
3820         project.  Link to oleacc.lib, the MSAA library.
3821         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3822         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
3823         controller.
3824         (FrameLoadDelegate::didClearWindowObject): Create a new window object
3825         for the accessibility controller.
3826         * DumpRenderTree/win/FrameLoadDelegate.h:
3827
3828 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
3829
3830         Reviewed by Mark Rowe
3831
3832         Make build-launcher-app work when run from a git repository.
3833         https://bugs.webkit.org/show_bug.cgi?id=20478
3834
3835         * BuildSlaveSupport/build-launcher-app:
3836
3837 2008-08-20  Maxime Britto  <britto@apple.com>
3838
3839         Reviewed by Ada Chan.
3840
3841          rdar://5259746
3842         Mouse events are sent to page while resizing window (affects Gmail)
3843
3844         * DumpRenderTree/win/UIDelegate.h:
3845         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
3846
3847 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
3848
3849         Reviewed by Beth Dakin.
3850
3851         Add snowleopard platform in layout tests
3852
3853         Added support for accessing the attributes of
3854         accessibility tables through the accessibility controller
3855         in DumpRenderTree
3856
3857         * DumpRenderTree/AccessibilityUIElement.cpp:
3858         (attributesOfColumnHeadersCallback):
3859         (attributesOfRowHeadersCallback):
3860         (attributesOfColumnsCallback):
3861         (attributesOfRowsCallback):
3862         (attributesOfVisibleCellsCallback):
3863         (attributesOfHeaderCallback):
3864         (indexInTableCallback):
3865         (rowIndexRangeCallback):
3866         (columnIndexRangeCallback):
3867         (childAtIndexCallback):
3868         (cellForColumnAndRowCallback):
3869         (AccessibilityUIElement::getJSClass):
3870         * DumpRenderTree/AccessibilityUIElement.h:
3871         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3872         (convertNSArrayToVector):
3873         (descriptionOfElements):
3874         (AccessibilityUIElement::getLinkedUIElements):
3875         (AccessibilityUIElement::getChildren):
3876         (AccessibilityUIElement::attributesOfLinkedUIElements):
3877         (AccessibilityUIElement::attributesOfChildren):
3878         (AccessibilityUIElement::attributesOfColumnHeaders):
3879         (AccessibilityUIElement::attributesOfRowHeaders):
3880         (AccessibilityUIElement::attributesOfColumns):
3881         (AccessibilityUIElement::attributesOfRows):
3882         (AccessibilityUIElement::attributesOfVisibleCells):
3883         (AccessibilityUIElement::attributesOfHeader):
3884         (AccessibilityUIElement::indexInTable):
3885         (AccessibilityUIElement::rowIndexRange):
3886         (AccessibilityUIElement::columnIndexRange):
3887         (AccessibilityUIElement::cellForColumnAndRow):
3888         * Scripts/run-webkit-tests:
3889
3890 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3891
3892         Reviewed by Darin Adler.
3893
3894         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
3895         is waiting for crash reporter to let it exit.
3896
3897         The fix does not work on Tiger, because the state of the process is indistinguishable from
3898         other waiting processes, at least not with this technique.
3899
3900         * Scripts/run-webkit-tests:
3901
3902 2008-08-18  Alp Toker  <alp@nuanti.com>
3903
3904         Reviewed by Holger Freyther.
3905
3906         https://bugs.webkit.org/show_bug.cgi?id=20350
3907         [GTK] Get DumpRenderTree working
3908
3909         Fixes and enhancements to DumpRenderTree. With these changes, the test
3910         suite can now complete a run producing text and render tree dumps.
3911
3912         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3913         (dumpFramesAsText):
3914         (dump):
3915         (runTest):
3916         (webViewLoadFinished):
3917         (webViewWindowObjectCleared):
3918         (webViewConsoleMessage):
3919         (webViewScriptAlert):
3920         (webViewScriptPrompt):
3921         (webViewScriptConfirm):
3922         (webViewTitleChanged):
3923         (main):
3924         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3925         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3926         (LayoutTestController::clearBackForwardList):
3927         (LayoutTestController::pathToLocalResource):
3928         (LayoutTestController::setAcceptsEditing):
3929         (LayoutTestController::setUserStyleSheetEnabled):
3930         (LayoutTestController::setUserStyleSheetLocation):
3931         (waitToDumpWatchdogFired):
3932         (LayoutTestController::windowCount):
3933         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
3934         (JSStringCopyUTF8CString):
3935         (ScriptItem::invoke):
3936
3937 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
3938
3939         Reviewed by Cameron Zwarich.
3940
3941         Updated project files to XCode 3.1.
3942
3943         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3944         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3945
3946 2008-08-15  Mark Rowe  <mrowe@apple.com>
3947
3948         Rubber-stamped by Geoff Garen.
3949
3950         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
3951
3952         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
3953
3954 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
3955
3956         Rubber-stamped by Holger.
3957
3958         Revert r31585 and disable http tests for the Qt build again unless
3959         explicitly enabled.
3960
3961         Running the http tests unfortunately currently still triggers
3962         failures in non-http tests due to side-effects. Disable them by default for
3963         now, for more reliable results.
3964
3965         * Scripts/run-webkit-tests:
3966
3967 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
3968
3969         Reviewed (and updated) by Alp Toker.
3970
3971         https://bugs.webkit.org/show_bug.cgi?id=16620
3972         [GTK] Autotools make dist and make check support
3973
3974         Get make dist working.
3975
3976         Note that not all possible configurations have been tested yet.
3977
3978         * GNUmakefile.am:
3979
3980 2008-08-10  Alp Toker  <alp@nuanti.com>
3981
3982         Remove leftover qmake/GTK+ build files.
3983
3984         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
3985         * GtkLauncher/GtkLauncher.pro: Removed.
3986
3987 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
3988
3989         Reviewed by Beth Dakin
3990
3991         AX functions shouldn't return position information because it changes
3992         based on the platform
3993
3994         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3995         (AccessibilityUIElement::boundsForRange):
3996
3997 2008-08-06  Eric Seidel  <eric@webkit.org>
3998
3999         Reviewed by darin.
4000
4001         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
4002         <https://bugs.webkit.org/show_bug.cgi?id=20297>
4003         <rdar://problem/6093153>
4004
4005         I've made AccessibilityUIElement a stack object for now.  It could be
4006         made RefCounted, but I figured that might be overkill for the moment.
4007         Essentially it's just a RefPtr itself. :)
4008
4009         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
4010         which was causing additional leaks. :)
4011
4012         I added toAXElement to remove a bunch of copy/paste code.
4013
4014         * DumpRenderTree/AccessibilityController.h:
4015         * DumpRenderTree/AccessibilityUIElement.cpp:
4016         (toAXElement):
4017         (allAttributesCallback):
4018         (attributesOfLinkedUIElementsCallback):
4019         (attributesOfChildrenCallback):
4020         (lineForIndexCallback):
4021         (boundsForRangeCallback):
4022         (childAtIndexCallback):
4023         (getRoleCallback):
4024         (getTitleCallback):
4025         (getDescriptionCallback):
4026         (getWidthCallback):
4027         (getHeightCallback):
4028         (getIntValueCallback):
4029         (getMinValueCallback):
4030         (getMaxValueCallback):
4031         (getInsertionPointLineNumberCallback):
4032         (finalize):
4033         * DumpRenderTree/AccessibilityUIElement.h:
4034         (AccessibilityUIElement::platformUIElement):
4035         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4036         (AccessibilityController::focusedElement):
4037         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4038         (AccessibilityUIElement::AccessibilityUIElement):
4039         (AccessibilityUIElement::getLinkedUIElements):
4040         (AccessibilityUIElement::getChildren):
4041         (AccessibilityUIElement::getChildAtIndex):
4042         (AccessibilityUIElement::attributesOfLinkedUIElements):
4043         (AccessibilityUIElement::attributesOfChildren):
4044
4045 2008-08-06  Eric Seidel  <eric@webkit.org>
4046
4047         Reviewed by Cameron Zwarich.
4048
4049         Speculative fix for an error I keep seeing in my Cygwin build
4050
4051         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
4052
4053 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
4054
4055         Forgot to commit licensing correction in last commit.
4056
4057         * wx/packaging/wxWebKitInstaller.iss.in:
4058
4059 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
4060
4061         Reviewed by Eric Seidel.
4062
4063         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
4064         be used for nightlies.
4065
4066         https://bugs.webkit.org/show_bug.cgi?id=20036
4067
4068         * wx/packaging: Added.
4069         * wx/packaging/build-win-installer.py: Added.
4070         * wx/packaging/wxWebKitInstaller.iss.in: Added.
4071
4072 2008-07-31  Adam Roben  <aroben@apple.com>
4073
4074         Follow-up to r35500
4075
4076         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
4077         Release configuration, too.
4078
4079 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
4080
4081         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
4082         the box
4083
4084         <https://bugs.webkit.org/show_bug.cgi?id=20245>
4085
4086         Reviewed by Adam Roben.
4087
4088         * WinLauncher/WinLauncher.vcproj: adding the following properties to
4089         WinLauncher > Properties > Manifest Tool > Isolated COM
4090         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
4091         Component File Name: WebKit$(WebKitDLLConfigSuffix)
4092         Doing the change on "All Configurations"
4093
4094 2008-07-31  Adam Roben  <aroben@apple.com>
4095
4096         Windows build bot fix
4097
4098         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
4099         exist for people at Apple can't be found. Also updated the ICU version
4100         to 3.8.
4101
4102 2008-07-31  David Kilzer  <ddkilzer@apple.com>
4103
4104         Fix layout test results for webarchive/test-xml-stylesheet.xml
4105
4106         Reviewed by Darin Adler.
4107
4108         * DumpRenderTree/mac/DumpRenderTree.mm:
4109         (convertMIMEType): Work around the "text/xml" local file type
4110         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
4111         stop mangling "application/x-javascript" into "text/javascript".
4112         (convertWebResourceDataToString): When checking whether to dump a
4113         resource as text, also check to see if the MIME type is in the
4114         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
4115         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
4116         macro.
4117
4118 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
4119
4120         Reviewed by Alice Liu
4121
4122         Add AX support to get the bounds for a range of text
4123         Add AX support to get the child of an element
4124         Add AX support to get all the parameterized attribute names of an element
4125
4126         * DumpRenderTree/AccessibilityUIElement.cpp:
4127         (parameterizedAttributeNamesCallback):
4128         (boundsForRangeCallback):
4129         (childAtIndexCallback):
4130         (AccessibilityUIElement::getJSClass):
4131         * DumpRenderTree/AccessibilityUIElement.h:
4132         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4133         (AccessibilityUIElement::getChildAtIndex):
4134         (AccessibilityUIElement::parameterizedAttributeNames):
4135         (AccessibilityUIElement::boundsForRange):
4136
4137 2008-07-31  Erik Bunce  <elbunce@thehive.com>
4138
4139         Reviewed by Simon.
4140
4141         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
4142
4143         * Scripts/run-launcher:
4144
4145 2008-07-30  Jessica Kahn  <jess@apple.com>
4146
4147         Reviewed by Adam Roben.
4148
4149         Slightly stricter checking for previous change, suggested by Adam.
4150
4151         * Scripts/extract-localizable-strings:
4152
4153 2008-07-30  Jessica Kahn  <jess@apple.com>
4154
4155         Reviewed by Darin Adler.
4156
4157         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
4158
4159         * Scripts/extract-localizable-strings:
4160
4161 2008-07-30  Anders Carlsson  <andersca@apple.com>
4162
4163         Reviewed by Adam.
4164
4165         Copy icu38* files instead of icu36* files.
4166
4167         * DumpRenderTree/win/DumpRenderTree.vcproj:
4168
4169 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
4170
4171         DRT/Gtk build fix for r35362
4172
4173         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4174         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
4175
4176 2008-07-25  Brady Eidson  <beidson@apple.com>
4177
4178         Reviewed by Sam
4179
4180         Add the ability to dump whether-or-not an element should have autocomplete enabled,
4181         from the perspective of the WebKit API
4182
4183         * DumpRenderTree/LayoutTestController.cpp:
4184         (elementDoesAutoCompleteForElementWithIdCallback):
4185         (LayoutTestController::staticFunctions):
4186
4187         * DumpRenderTree/LayoutTestController.h:
4188         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4189         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
4190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4191         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
4192
4193 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
4194
4195         Reviewed by Beth Dakin
4196
4197         Add support for AXLineForIndex and AXInsertionPointIndex through the
4198         accessibility controller
4199
4200         * DumpRenderTree/AccessibilityUIElement.cpp:
4201         (lineForIndexCallback):
4202         (getInsertionPointLineNumberCallback):
4203         (AccessibilityUIElement::getJSClass):
4204         * DumpRenderTree/AccessibilityUIElement.h:
4205         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4206         (AccessibilityUIElement::insertionPointLineNumber):
4207         (AccessibilityUIElement::lineForIndex):
4208
4209 2008-07-25  Adam Roben  <aroben@apple.com>
4210
4211         Try to fix the Windows build bot
4212
4213         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
4214         that don't exist for people outside of Apple.
4215
4216 2008-07-18  Landry Breuil  <landry@openbsd.org>
4217
4218         Bug 19975: [OpenBSD] Patches to enable build of WebKit
4219
4220         <https://bugs.webkit.org/show_bug.cgi?id=19975>
4221
4222         Reviewed by David Kilzer.
4223
4224         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
4225
4226 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
4227
4228         CygwinDownloader fails to install necessary packages
4229         https://bugs.webkit.org/show_bug.cgi?id=20075
4230
4231         Reviewed by Mark Rowe.
4232
4233         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
4234         mirrors removed in r34116. Set MIME type to application/octet-stream.
4235
4236 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
4237
4238         CygwinDownloader's make-zip.sh script fails
4239         https://bugs.webkit.org/show_bug.cgi?id=20074
4240
4241         Reviewed by Mark Rowe.
4242
4243         * CygwinDownloader/cygwin-downloader.py:
4244
4245 2008-07-15  Sam Weinig  <sam@webkit.org>
4246
4247         Reviewed by Anders Carlsson.
4248
4249         Refactor accessibility testing code.
4250
4251         We now have:
4252         - AccessibilityController
4253           Controller which has access to the WebView and can provide the focused element, root element
4254           and in the future, elementAtPoint.
4255
4256         - AccessibilityUIElement
4257           Object which provides access to the data provided by the Accessibility APIs.
4258
4259         * DumpRenderTree/AccessibilityController.cpp:
4260         (getFocusedElementCallback):
4261         (getRootElementCallback):
4262         (AccessibilityController::getJSClass):
4263         * DumpRenderTree/AccessibilityController.h:
4264         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
4265         (allAttributesCallback):
4266         (attributesOfLinkedUIElementsCallback):
4267         (attributesOfChildrenCallback):
4268         (getRoleCallback):
4269         (getTitleCallback):
4270         (getDescriptionCallback):
4271         (getWidthCallback):
4272         (getHeightCallback):
4273         (getIntValueCallback):
4274         (getMinValueCallback):
4275         (getMaxValueCallback):
4276         (finalize):
4277         (AccessibilityUIElement::makeJSAccessibilityUIElement):
4278         (AccessibilityUIElement::getJSClass):
4279         * DumpRenderTree/AccessibilityUIElement.h: Added.
4280         (AccessibilityUIElement::platformUIElement):
4281         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4282         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4283         (AccessibilityController::AccessibilityController):
4284         (AccessibilityController::~AccessibilityController):
4285         (AccessibilityController::focusedElement):
4286         (AccessibilityController::rootElement):
4287         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
4288         (AccessibilityUIElement::AccessibilityUIElement):
4289         (descriptionOfValue):
4290         (attributesOfElement):
4291         (nsStringToJSStringRef):
4292         (concatenateAttributeAndValue):
4293         (AccessibilityUIElement::getLinkedUIElements):
4294         (AccessibilityUIElement::getChildren):
4295         (AccessibilityUIElement::attributesOfLinkedUIElements):
4296         (AccessibilityUIElement::attributesOfChildren):
4297         (AccessibilityUIElement::allAttributes):
4298         (AccessibilityUIElement::role):
4299         (AccessibilityUIElement::title):
4300         (AccessibilityUIElement::description):
4301         (AccessibilityUIElement::width):
4302         (AccessibilityUIElement::height):
4303         (AccessibilityUIElement::intValue):
4304         (AccessibilityUIElement::minValue):
4305         (AccessibilityUIElement::maxValue):
4306
4307 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
4308
4309         Reviewed by Beth Dakin
4310
4311         Add support to get attributes of the AXChildren of an objecty
4312
4313         * DumpRenderTree/AccessibilityController.cpp:
4314         (attributesOfChildrenForFocusedElementCallback):
4315         (AccessibilityController::staticFunctions):
4316         * DumpRenderTree/AccessibilityController.h:
4317         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4318         (descriptionOfValue):
4319         (AccessibilityController::attributesOfChildrenForFocusedElement):
4320
4321 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
4322
4323         Build fix.
4324
4325         * DumpRenderTree/win/DumpRenderTree.vcproj:
4326
4327 2008-07-14  Adam Roben  <aroben@apple.com>
4328
4329         Attempted Windows build fix
4330
4331         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add