WebKitTools/ChangeLog

   1 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
   2
   3         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
   4
   5         <https://bugs.webkit.org/show_bug.cgi?id=22559>
   6
   7         Reviewed by Adam Roben.
   8
   9         * Scripts/bisect-builds: Updated status message to report the
  10         maximum number of builds left to test after the current one.
  11         (max): Added.
  12
  13 2008-11-27  Alp Toker  <alp@nuanti.com>
  14
  15         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
  16         API header breakage at build time.
  17
  18         * GNUmakefile.am:
  19
  20 2008-11-26  Eric Seidel  <eric@webkit.org>
  21
  22         Reviewed by Nikolas Zimmermann and Mark Rowe.
  23
  24         Add support for build-webkit --chromium
  25         https://bugs.webkit.org/show_bug.cgi?id=22515
  26         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
  27
  28         * Scripts/build-dumprendertree:
  29         * Scripts/build-jsc:
  30         * Scripts/build-webkit:
  31         * Scripts/gdb-safari:
  32         * Scripts/run-webkit-tests:
  33         * Scripts/webkitdirs.pm:
  34
  35 2008-11-26  Eric Seidel  <eric@webkit.org>
  36
  37         Reviewed by Nikolas Zimmermann.
  38
  39         Add support for build-webkit --chromium (tested on mac)
  40         https://bugs.webkit.org/show_bug.cgi?id=22515
  41         Also simplified some code using checkArgv
  42
  43         * Scripts/build-webkit:
  44         * Scripts/webkitdirs.pm:
  45
  46 2008-11-26  Eric Seidel  <eric@webkit.org>
  47
  48         Reviewed by Nikolas Zimmermann.
  49
  50         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
  51         https://bugs.webkit.org/show_bug.cgi?id=22515
  52         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
  53         in preparation for having a chromium cygwin and chromium mac build
  54
  55         * Scripts/build-webkit:
  56         * Scripts/webkitdirs.pm:
  57
  58 2008-11-26  Eric Seidel  <eric@webkit.org>
  59
  60         Reviewed by Nikolas Zimmermann.
  61
  62         Pre-work for getting build-webkit --chromium to work
  63         https://bugs.webkit.org/show_bug.cgi?id=22515
  64         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
  65
  66         * Scripts/build-dumprendertree:
  67         * Scripts/build-jsc:
  68         * Scripts/build-webkit:
  69         * Scripts/gdb-safari:
  70         * Scripts/run-javascriptcore-tests:
  71         * Scripts/run-webkit-tests:
  72         * Scripts/webkitdirs.pm:
  73
  74 2008-11-26  David Kilzer  <ddkilzer@apple.com>
  75
  76         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
  77
  78         <https://bugs.webkit.org/show_bug.cgi?id=22488>
  79
  80         Reviewed by Brady Eidson.
  81
  82         * DumpRenderTree/mac/DumpRenderTree.mm:
  83         (convertWebResourceDataToString): If an IANA charset encoding string
  84         is provided, convert it to a CFStringEncoding value and then to an
  85         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
  86         also nil-check dataAsString, so the worst-case scenario is that the
  87         data won't be decoded to a string (versus crashing DumpRenderTree).
  88
  89 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
  90
  91         Reviewed by Holger Freyther.
  92
  93         [Gtk] add/remove tests from Skipped and fix netscape plugin test
  94         https://bugs.webkit.org/show_bug.cgi?id=22484
  95
  96         Remove print'ing to stderr
  97
  98         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
  99         (NP_Initialize):
 100         (NP_Shutdown):
 101
 102 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
 103
 104         Windows build fix.
 105
 106         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 107
 108 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
 109
 110         Windows build fix.
 111
 112         * DumpRenderTree/cg/ImageDiffCG.cpp:
 113
 114 2008-11-24  Darin Fisher  <darin@chromium.org>
 115
 116         Fix bustage.
 117
 118         https://bugs.webkit.org/show_bug.cgi?id=15643
 119
 120         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 121         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
 122
 123 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
 124
 125         Reviewed by Alexey Proskuryakov.
 126
 127         http://bugs.webkit.org/show_bug.cgi?id=15643
 128
 129         Added support for changing the "trailing whitespace" work-around
 130         in LayoutTestController (so layout tests can verify this functionality)
 131
 132         * DumpRenderTree/LayoutTestController.cpp:
 133         (setSelectTrailingWhitespaceEnabledCallback):
 134         (LayoutTestController::staticFunctions):
 135         * DumpRenderTree/LayoutTestController.h:
 136         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 137         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
 138         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 139         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
 140
 141 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
 142
 143         Reviewed by Darin Adler
 144
 145         https://bugs.webkit.org/show_bug.cgi?id=22433
 146
 147         Add script that attempts to detect virtual methods
 148         whose signatures differ only by constness (which can
 149         indicate a programming error).
 150
 151         * Scripts/detect-mismatched-virtual-const: Added.
 152
 153 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
 154
 155         Reviewed by Holger Freyther.
 156
 157         https://bugs.webkit.org/show_bug.cgi?id=22039
 158
 159         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
 160         build.
 161
 162         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 163         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
 164         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 165         (setDefaultsToConsistentStateValuesForTesting):
 166         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
 167         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
 168         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
 169         * GNUmakefile.am:
 170
 171 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
 172
 173         Reviewed by Mark Rowe.
 174
 175         [Gtk+] Add configure option to enable Web Workers and enable it by default
 176
 177         Add --enable-workers to the buildsystem (used by build-webkit) add
 178         the to be build files to the GNUmakefile.am and change build-webkit
 179         to enable Web Workers by default.
 180
 181         * Scripts/build-webkit:
 182
 183 2008-11-24  Mark Rowe  <mrowe@apple.com>
 184
 185         Reviewed by Alexey Proskuryakov.
 186
 187         Let gdb-safari accept the --debug and --release options once more.
 188
 189         * Scripts/gdb-safari:
 190
 191 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
 192
 193         Reviewed by Holger Freyther. Landed by Jan Alonzo.
 194
 195         Get SVG tests tested on GTK port.
 196
 197         * Scripts/webkitdirs.pm:
 198
 199 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
 200
 201         Reviewed by Darin Adler.
 202
 203         https://bugs.webkit.org/show_bug.cgi?id=21810
 204         Remove use of static C++ objects that are destroyed at exit time (destructors)
 205
 206         All static C++ objects that create atexit calls are gone. Update script
 207         to indicate how to fix the problem should a new one appear.
 208
 209         * Scripts/check-for-exit-time-destructors:
 210
 211 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
 212
 213         Reviewed by Darin Adler.
 214
 215         https://bugs.webkit.org/show_bug.cgi?id=22337
 216         Enable workers by default
 217
 218         * Scripts/build-webkit: Changed the default to enabled.
 219
 220 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
 221
 222         Rubber-stamped by Darin Adler.
 223
 224         https://bugs.webkit.org/show_bug.cgi?id=22306
 225         Disable channel messaging support
 226
 227         * Scripts/build-webkit: Add an option to enable channel messaging.
 228
 229 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
 230
 231         Reviewed by George Staikos.
 232
 233         Add --(no-)wml build flags.
 234
 235         * Scripts/build-webkit:
 236         * Scripts/run-webkit-tests:
 237         * Scripts/webkitdirs.pm:
 238
 239 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
 240
 241         Not reviewed.
 242
 243         Try to fix gtk build.
 244
 245         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 246         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 247         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 248
 249 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
 250
 251         Reviewed by Maciej.
 252
 253         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
 254         on Tiger.
 255
 256         https://bugs.webkit.org/show_bug.cgi?id=22271
 257
 258         * Scripts/run-webkit-tests:
 259
 260 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
 261
 262         Reviewed by Sam Weinig.
 263
 264         Added new JavaScript API on LayoutController to pause a running
 265         CSS transition or animation at a given time.
 266
 267         https://bugs.webkit.org/show_bug.cgi?id=21261
 268
 269         * DumpRenderTree/LayoutTestController.cpp:
 270         (pauseAnimationAtTimeOnElementWithIdCallback):
 271         (pauseTransitionAtTimeOnElementWithIdCallback):
 272         (LayoutTestController::staticFunctions):
 273         * DumpRenderTree/LayoutTestController.h:
 274         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 275         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 276         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 277         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 278         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 279         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 280
 281 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
 282
 283         Reviewed by Darin Adler.
 284
 285         <https://bugs.webkit.org/show_bug.cgi?id=22309>
 286         Pass the remaining options to build system on Qt-port
 287
 288         * Scripts/build-webkit:
 289         * Scripts/webkitdirs.pm:
 290
 291 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
 292
 293         Reviewed by Darin Adler.
 294
 295         https://bugs.webkit.org/show_bug.cgi?id=21810
 296         Remove use of static C++ objects that are destroyed at exit time (destructors)
 297
 298         Remove .o files from the exclude list that have had their exit-time destructors removed.
 299         Handle case when there is no current symbol.
 300
 301         * Scripts/check-for-exit-time-destructors:
 302
 303 2008-11-16  Sam Weinig  <sam@webkit.org>
 304
 305         * Scripts/do-webcore-rename: Remove now fixed renames.
 306
 307 2008-11-16  Darin Adler  <darin@apple.com>
 308
 309         * Scripts/do-webcore-rename: Plan some future renames.
 310
 311 2008-11-15  Darin Adler  <darin@apple.com>
 312
 313         Rubber stamped by Geoff Garen.
 314
 315         - do the long-planned StructureID -> Structure rename
 316
 317         * Scripts/check-for-global-initializers: Update name of StructureID.o.
 318         * Scripts/do-webcore-rename: Renaming script that I used.
 319
 320 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
 321
 322         Reviewed by Darin Adler.
 323
 324         https://bugs.webkit.org/show_bug.cgi?id=21810
 325         Remove use of static C++ objects that are destroyed at exit time (destructors)
 326
 327         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid
 328         exit-time destructor. Update code that was changed to fix this issue that ran
 329         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference
 330         in gcc build 5465). Also typdefs for template types needed to be added in some
 331         cases so the type could make it through the macro successfully.
 332
 333         Basically code of the form:
 334         static T m;
 335         becomes:
 336         DEFINE_STATIC_LOCAL(T, m, ());
 337
 338         Also any code of the form:
 339         static T& m = *new T;
 340         also becomes:
 341         DEFINE_STATIC_LOCAL(T, m, ());
 342
 343         Remove .o files from the exclude list that have had their exit-time destructors removed.
 344
 345         * Scripts/check-for-exit-time-destructors:
 346
 347 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
 348
 349         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
 350
 351         * wx/install-unix-extras:
 352
 353 2008-11-14  Alp Toker  <alp@nuanti.com>
 354
 355         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
 356
 357         Fixes Debian bug #505723
 358         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
 359
 360         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 361
 362 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
 363
 364         Reviewed by Simon Hausmann.
 365
 366         Fix hanging DRT with Qt.
 367
 368         https://bugs.webkit.org/show_bug.cgi?id=22209
 369
 370         * DumpRenderTree/qt/DumpRenderTree.cpp:
 371         (WebCore::DumpRenderTree::dump):
 372         Send empty pixel test data 'block', which is now
 373         expected by run-layout-tests.
 374
 375 2008-11-12  Dmitry Titov  <dimich@chromium.org>
 376
 377         Reviewed by Alexey Proskuryakov.
 378
 379         https://bugs.webkit.org/show_bug.cgi?id=22216
 380
 381         * Scripts/build-webkit:
 382         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
 383
 384 2008-11-06  David Kilzer  <ddkilzer@apple.com>
 385
 386         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
 387
 388         Apparently older versions of gcc have issues with this patch.
 389         Backing out a second time until the issues are resolved.
 390
 391 2008-11-06  David Kilzer  <ddkilzer@apple.com>
 392
 393         BUILD WAS NOT BROKEN: Rolling r38189 back in.
 394
 395         Please perform a clean build if you see crashes.
 396
 397 2008-11-06  David Kilzer  <ddkilzer@apple.com>
 398
 399         BUILD FIX: Backed out r38189 since it apparently broke the world.
 400
 401 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
 402
 403         Reviewed by Beth Dakin.
 404
 405         Add ability to query an attribute's settable status and the
 406         ability to retrieve a single attribute from an AXObject
 407
 408         * DumpRenderTree/AccessibilityUIElement.cpp:
 409         (isAttributeSettableCallback):
 410         (attributeValueCallback):
 411         (AccessibilityUIElement::getJSClass):
 412         * DumpRenderTree/AccessibilityUIElement.h:
 413         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 414         (+[NSString stringWithJSStringRef:]):
 415         (AccessibilityUIElement::attributeValue):
 416         (AccessibilityUIElement::isAttributeSettable):
 417         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 418         (AccessibilityUIElement::attributeValue):
 419         (AccessibilityUIElement::isAttributeSettable):
 420
 421 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
 422
 423         Reviewed by Darin Adler.
 424
 425         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
 426         https://bugs.webkit.org/show_bug.cgi?id=21810
 427
 428         Remove .o files from the exclude list that have had their exit-time destructors removed.
 429
 430         * Scripts/check-for-exit-time-destructors:
 431
 432 2008-11-05  Alp Toker  <alp@nuanti.com>
 433
 434         GTK build script tweak.
 435
 436         Make the path relative since it will appear in all -I compiler flags.
 437         Long argument lists cause bizarre slowdowns in libtool and result
 438         in huge build logs.
 439
 440         * Scripts/webkitdirs.pm:
 441
 442 2008-11-05  Anders Carlsson  <andersca@apple.com>
 443
 444         Fix 64-bit build.
 445
 446         * DumpRenderTree/mac/DumpRenderTree.mm:
 447         (setDefaultsToConsistentValuesForTesting):
 448
 449 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
 450
 451         Add AccessibilityObject.o to the exclude list for the
 452         check for global destructors.
 453
 454         * Scripts/check-for-exit-time-destructors:
 455
 456 2008-11-04  Darin Adler  <darin@apple.com>
 457
 458         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
 459         bot, but for some reason not on my computer.
 460
 461 2008-11-03  Darin Adler  <darin@apple.com>
 462
 463         Reviewed by Tim Hatcher.
 464
 465         - https://bugs.webkit.org/show_bug.cgi?id=22061
 466           create script to check for exit-time destructors
 467
 468         * Scripts/check-for-exit-time-destructors: Added.
 469         Started as a copy of check-for-global-initializers.
 470
 471         * Scripts/check-for-global-initializers: Added code to make
 472         this script rerun any time it's modified, and also to properly
 473         run again after the first time it reports an error.
 474
 475 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
 476
 477         Reviewed by Dan Bernstein.
 478
 479         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
 480
 481         https://bugs.webkit.org/show_bug.cgi?id=22054
 482
 483         * DumpRenderTree/mac/DumpRenderTree.mm:
 484         (setDefaultsToConsistentValuesForTesting):
 485
 486 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
 487
 488         Not reviewed.
 489
 490         * Scripts/do-webcore-rename:
 491
 492         Add some renames to contemplate for the future.
 493
 494 2008-10-31  Darin Adler  <darin@apple.com>
 495
 496         Requested by Mark Rowe.
 497
 498         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
 499
 500 2008-10-31  David Kilzer  <ddkilzer@apple.com>
 501
 502         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
 503
 504         <https://bugs.webkit.org/show_bug.cgi?id=21997>
 505
 506         Reviewed by Darin Adler.
 507
 508         * Scripts/prepare-ChangeLog:
 509         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
 510         This prevents them from showing up in the new ChangeLog entry.  They
 511         were already excluded from @{$changedFiles}.
 512
 513 2008-10-30  Mark Rowe  <mrowe@apple.com>
 514
 515         Reviewed by Jon Homeycutt.
 516
 517         Explicitly default to building for only the native architecture in debug and release builds.
 518
 519         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 520
 521 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
 522
 523         Reviewed by Dan Bernstein.
 524
 525         Fixed 64 bit build failure.
 526
 527         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 528         (setupMainDisplayColorProfile):
 529         (createBitmapContextFromWebView):
 530
 531 2008-10-28  Alp Toker  <alp@nuanti.com>
 532
 533         Fix GTK DRT following build breakage in r37928.
 534
 535         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 536         (dump):
 537         (runTest):
 538         (main):
 539
 540 2008-10-28  Alp Toker  <alp@nuanti.com>
 541
 542         Reviewed by Mark Rowe.
 543
 544         Fix recently introduced double-free crashes in GTK DRT.
 545
 546         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
 547         were updated to call ->deref() but GTK DRT was still deleting
 548         gLayoutTestController manually. This patch updates GTK to match the
 549         other ports and resolves the memory allocation issues.
 550
 551         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 552         (runTest):
 553
 554 2008-10-28  Alp Toker  <alp@nuanti.com>
 555
 556         Reviewed by Mark Rowe.
 557
 558         Fix GTK DRT hang when running the tests.
 559
 560         Update output from the DRT tool to print an additional '#EOF' to match
 561         breaking changes that were made in r37434.
 562
 563         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 564         (dump):
 565
 566 2008-10-28  Adele Peterson  <adele@apple.com>
 567
 568         Reviewed by Sam Weinig.
 569
 570         Specify which Localizable.strings to update since we don't always want to update the file in the same
 571         directory where we're searching for the strings to localize.
 572
 573         * Scripts/extract-localizable-strings:
 574         * Scripts/update-webkit-localizable-strings:
 575
 576 2008-10-28  Timothy Hatcher  <timothy@apple.com>
 577
 578         Add support for enabling the profiler, so the profiling tests can continue
 579         work now that the profiler is not always enabled.
 580
 581         https://bugs.webkit.org/show_bug.cgi?id=21927
 582
 583         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
 584         not slow down JavaScript all the time
 585
 586         Reviewed by Darin Adler and Kevin McCullough.
 587
 588         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
 589         * DumpRenderTree/LayoutTestController.cpp:
 590         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
 591         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
 592         * DumpRenderTree/LayoutTestController.h:
 593         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 594         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
 595         * DumpRenderTree/mac/DumpRenderTree.mm:
 596         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
 597         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 598         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
 599         * DumpRenderTree/win/DumpRenderTree.cpp:
 600         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
 601         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 602         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
 603
 604 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
 605
 606         Reviewed by Dan Bernstein
 607
 608         Primary changes in DumpRenderTree:
 609         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
 610         is different from regular font CG anti-aliasing) as font-smoothing settings
 611         depends on the display and can also be changed by the user
 612         - Use a new cleared buffer for each test instead of the reusing same one to
 613         avoid potential result corruption across tests
 614         - Can now receive the expected pixel hash as a suffix to the test path or
 615         url as "path'hash"
 616         - Make sure hash is computed in a endian-independent way
 617         - Improve the code that sets/restores the screen color profile
 618         - Make the code more cross-platformy with std::string goodness
 619         - Added an "on-screen" mode where the snapshot will take into account surfaces
 620         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
 621         reading from the display framebuffer on 10.4. This mode is not active by
 622         default for performance reason, but must be explicitly activated from the test
 623         file using the new "testOnscreen()" JS API.
 624
 625         Primary changes in ImageDiff:
 626         - Provide a new comparison algorithm that is more tolerant to "acceptable"
 627         failures (i.e. very small differences in font rendering, which --threshold is
 628         not really good at handling)
 629         - Generate normalized intensity-only diff images
 630
 631         Primary changes in run-webkit-tests:
 632         - Take advantage of hashes for pixel tests which makes them much faster by
 633         minimizing image comparisons
 634         - Removed repaint options as these should be set from within test files using
 635         JS API
 636         - Replaced "threshold" option in  by "tolerance" expressed in percents
 637         - Added more logging when in "verbose" mode
 638
 639         https://bugs.webkit.org/show_bug.cgi?id=21322
 640         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 641         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
 642         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
 643         * DumpRenderTree/LayoutTestController.cpp:
 644         (LayoutTestController::LayoutTestController):
 645         (testOnscreenCallback):
 646         (LayoutTestController::staticFunctions):
 647         * DumpRenderTree/LayoutTestController.h:
 648         (LayoutTestController::testOnscreen):
 649         (LayoutTestController::setTestOnscreen):
 650         (LayoutTestController::testPathOrURL):
 651         (LayoutTestController::expectedPixelHash):
 652         * DumpRenderTree/PixelDumpSupport.h:
 653         * DumpRenderTree/cg/ImageDiffCG.cpp:
 654         (strtof):
 655         (releaseMallocBuffer):
 656         (createDifferenceImage):
 657         (imageHasAlpha):
 658         (main):
 659         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 660         (computeMD5HashStringForBitmapContext):
 661         (dumpWebViewAsPixelsAndCompareWithExpected):
 662         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 663         (BitmapContext::createByAdoptingBitmapAndContext):
 664         (BitmapContext::~BitmapContext):
 665         (BitmapContext::cgContext):
 666         (BitmapContext::BitmapContext):
 667         * DumpRenderTree/mac/DumpRenderTree.mm:
 668         (shouldIgnoreWebCoreNodeLeaks):
 669         (setDefaultsToConsistentValuesForTesting):
 670         (crashHandler):
 671         (initializeGlobalsFromCommandLineOptions):
 672         (prepareConsistentTestingEnvironment):
 673         (dumpRenderTree):
 674         (sizeWebViewForCurrentTest):
 675         (dump):
 676         (runTest):
 677         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 678         (restoreMainDisplayColorProfile):
 679         (setupMainDisplayColorProfile):
 680         (createBitmapContextFromWebView):
 681         * DumpRenderTree/win/DumpRenderTree.cpp:
 682         (dump):
 683         (runTest):
 684         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
 685         (getBitmapContextFromWebView):
 686         * Scripts/run-webkit-tests:
 687
 688 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
 689
 690         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
 691
 692         * wx/build-wxwebkit:
 693
 694 2008-10-24  Anders Carlsson  <andersca@apple.com>
 695
 696         Try fixing the 64-bit build.
 697
 698         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
 699         (testGetProperty):
 700
 701 2008-10-24  Anders Carlsson  <andersca@apple.com>
 702
 703         Reviewed by Sam Weinig.
 704
 705         <rdar://problem/5440917> Support NPN_Construct
 706
 707         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 708         (testCallback):
 709         Fix a memory leak.
 710
 711         (testConstruct):
 712         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
 713
 714         (pluginInvoke):
 715         Handle testConstruct.
 716
 717         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
 718         (testGetProperty):
 719         Add objectPointer property.
 720
 721         (testEnumerate):
 722         Only enumerate the two first properties.
 723
 724         (testConstruct):
 725         Add a simple construct implementation that just returns the test object.
 726
 727 2008-10-24  David Kilzer  <ddkilzer@apple.com>
 728
 729         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
 730
 731         <https://bugs.webkit.org/show_bug.cgi?id=21850>
 732
 733         Reviewed by Adam Roben.
 734
 735         * Scripts/svn-apply: Save end-of-line characters when stripping them
 736         off each line of a patch so that they may be restored after
 737         processing the line.
 738         * Scripts/svn-unapply: Ditto.
 739
 740 2008-10-23  David Kilzer  <ddkilzer@apple.com>
 741
 742         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
 743
 744         <https://bugs.webkit.org/show_bug.cgi?id=21832>
 745
 746         Reviewed by Sam Weinig.
 747
 748         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
 749         instead of 'new File::Temp' to make the script work with Perl 5.10.
 750         * Scripts/sort-Xcode-project-file: Ditto.
 751
 752 2008-10-22  Brady Eidson  <beidson@apple.com>
 753
 754         Reviewed by Adam Roben
 755
 756         <rdar://6261773> - autocomplete="off" doesn't work on Windows
 757
 758         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
 759
 760         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 761
 762 2008-10-22  Darin Adler  <darin@apple.com>
 763
 764         * Scripts/do-webcore-rename: More renaming plans.
 765
 766 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
 767
 768         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
 769
 770         * Scripts/extract-localizable-strings:
 771
 772 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
 773
 774         Reviewed by Mark Rowe.
 775
 776         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
 777         excess different stack logs.
 778
 779         (Also fix a small bug in my last change.)
 780
 781         * Scripts/run-webkit-tests:
 782
 783 2008-10-17  Stephanie Lewis  <slewis@apple.com>
 784
 785         Reviewed by Mark Rowe.
 786
 787         Fix layout tests that use prologues and epilogues.
 788
 789         * Scripts/run-webkit-tests:
 790
 791 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
 792
 793         Reviewed by Mark Rowe.
 794
 795         - make sure MallocStackLogging is only on for tools we want to
 796         leak check, not other random stuff as well.
 797
 798         * Scripts/run-webkit-tests:
 799
 800 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
 801
 802         Reviewed by Stephanie Lewis.
 803
 804         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
 805
 806         This should reduce or eliminate crashes on the buildbot due to
 807         running out of memory while stack logging.
 808
 809         * Scripts/run-webkit-tests:
 810
 811 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
 812
 813         Gtk build fix. Not reviewed.
 814
 815         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 816         (LayoutTestController::setSmartInsertDeleteEnabled):
 817
 818 2008-10-15  Glenn Wilson  <gwilson@google.com>
 819
 820         Added new method to allow tests to disable smart editing in the course of a test.
 821         This is a possible solution to bug .20655
 822
 823         Reviewed by Tim Hatcher.
 824
 825         * DumpRenderTree/LayoutTestController.cpp:
 826         (setSmartInsertDeleteEnabledCallback): new method
 827         (LayoutTestController::staticFunctions): added new method to static list of callbacks
 828         * DumpRenderTree/LayoutTestController.h: added signature of new method
 829         * DumpRenderTree/mac/DumpRenderTree.mm:
 830         (resetWebViewToConsistentStateBeforeTesting): added state resetting
 831         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 832         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
 833         * DumpRenderTree/win/DumpRenderTree.cpp:
 834         (resetWebViewToConsistentStateBeforeTesting): added state resetting
 835         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 836         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
 837
 838 2008-10-14  Ada Chan  <adachan@apple.com>
 839
 840         Fix windows build.
 841
 842         Reviewed by Sam Weinig.
 843
 844         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 845         * DumpRenderTree/config.h:
 846         * DumpRenderTree/win/DumpRenderTreeWin.h:
 847         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 848         * DumpRenderTree/win/UIDelegate.cpp:
 849
 850 2008-10-13  Timothy Hatcher  <timothy@apple.com>
 851
 852         Make prepare-ChangeLog populate the changed functions for JavaScript files.
 853
 854         https://bugs.webkit.org/show_bug.cgi?id=21567
 855
 856         Reviewed by David Kilzer.
 857
 858         * Scripts/prepare-ChangeLog:
 859         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
 860         files that end with ".js".
 861         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
 862         and getters/setters.
 863
 864 2008-10-14  Alp Toker  <alp@nuanti.com>
 865
 866         Reviewed by Sam Weinig.
 867
 868         https://bugs.webkit.org/show_bug.cgi?id=16299
 869         Add a config.h file to DRT
 870
 871         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
 872         an ad-hoc config header.
 873
 874         * DumpRenderTree/AccessibilityController.cpp:
 875         * DumpRenderTree/AccessibilityUIElement.cpp:
 876         * DumpRenderTree/AccessibilityUIElement.h:
 877         * DumpRenderTree/DumpRenderTree.h:
 878         * DumpRenderTree/GCController.cpp:
 879         * DumpRenderTree/LayoutTestController.cpp:
 880         * DumpRenderTree/WorkQueue.cpp:
 881         * DumpRenderTree/config.h: Added.
 882         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 883         * DumpRenderTree/gtk/GCControllerGtk.cpp:
 884         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 885         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 886         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
 887         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 888         * DumpRenderTree/win/DumpRenderTree.cpp:
 889         * DumpRenderTree/win/DumpRenderTreeWin.h:
 890         * DumpRenderTree/win/EditingDelegate.cpp:
 891         * DumpRenderTree/win/EventSender.cpp:
 892         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 893         * DumpRenderTree/win/GCControllerWin.cpp:
 894         * DumpRenderTree/win/MD5.cpp:
 895         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
 896         * DumpRenderTree/win/PolicyDelegate.cpp:
 897         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
 898         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 899         * GNUmakefile.am:
 900
 901 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
 902
 903         Reviewed by Beth Dakin.
 904
 905         Added a method to get the links in a webpage
 906
 907         * DumpRenderTree/AccessibilityUIElement.cpp:
 908         (attributesOfDocumentLinksCallback):
 909         (AccessibilityUIElement::getJSClass):
 910         * DumpRenderTree/AccessibilityUIElement.h:
 911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 912         (AccessibilityUIElement::getDocumentLinks):
 913         (AccessibilityUIElement::attributesOfDocumentLinks):
 914         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 915         (AccessibilityUIElement::getDocumentLinks):
 916         (AccessibilityUIElement::attributesOfDocumentLinks):
 917
 918 2008-10-13  David Kilzer  <ddkilzer@apple.com>
 919
 920         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
 921
 922         <https://bugs.webkit.org/show_bug.cgi?id=21457>
 923
 924         Reviewed by Adam.
 925
 926         * Scripts/resolve-ChangeLogs: Added optional parameter to
 927         -f|--fix-merged switch to run the script on a revision range.
 928         Updated command-line validation checks.
 929         (findChangeLog): Fixed long-standing bug that should have used
 930         $_[0] instead of $_.
 931         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
 932         to work when called from git filter-branch.  It always restores a
 933         copy of the previous revision before reapplying the patch.
 934         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
 935         to re-merge ChangeLog files across a revision range.  Removes
 936         .git/refs/original directory on success.
 937         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
 938         switch.
 939         (removeChangeLogArguments): Added.  Removes items from @ARGV when
 940         they are ChangeLog paths, and return a list of paths.  This makes it
 941         easier to validate the command-line.
 942         (resolveChangeLog): Added.  Extracted from main code block.  Runs
 943         the traditional single-file merge algorithm.
 944         (usageAndExit): Added.  Extracted from main code block.  Prints
 945         usage statement and exits with error status.
 946
 947 2008-10-12  Darin Adler  <darin@apple.com>
 948
 949         * Scripts/make-js-test-wrappers: Update exceptions list so the script
 950         won't overwrite files and mangle tests.
 951
 952 2008-10-11  Dan Bernstein  <mitz@apple.com>
 953
 954         Reviewed by Sam Weinig and Anders Carlsson.
 955
 956         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
 957           complex text code path
 958         - add --complex-text support to Windows DumpRenderTree
 959
 960         * DumpRenderTree/mac/DumpRenderTree.mm:
 961         (dumpRenderTree):
 962         * DumpRenderTree/win/DumpRenderTree.cpp:
 963         (createWebViewAndOffscreenWindow):
 964         (main):
 965         * Scripts/run-webkit-tests:
 966
 967 2008-10-09  Eric Seidel  <eric@webkit.org>
 968
 969         Reviewed by Oliver Hunt.
 970
 971         https://bugs.webkit.org/show_bug.cgi?id=21498
 972
 973         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
 974
 975 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
 976
 977         Not reviewed.
 978
 979         Add StructureID.o to the exclusion list in the global initializers
 980         script to fix the Debug build.
 981
 982         * Scripts/check-for-global-initializers:
 983
 984 2008-10-08  Mark Rowe  <mrowe@apple.com>
 985
 986         Fix the Windows build after r37434.
 987
 988         * DumpRenderTree/win/DumpRenderTree.cpp:
 989         (dump): Update code to approximate valid C++ syntax.
 990
 991 2008-10-08  Timothy Hatcher  <timothy@apple.com>
 992
 993         Add SVGElementInstance to the list of exceptions that have
 994         global initializers in debug builds.
 995
 996         Rubber-stamped by Mark Rowe.
 997
 998         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
 999
1000 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
1001
1002         Reviewed by Dan Bernstein
1003
1004         Avoid disconnect between DRT and run-webkit-tests
1005         about whether to expect PNG dumps by having DRT always
1006         print two blocks terminated by #EOF, the second of which
1007         may be empty.
1008
1009         https://bugs.webkit.org/show_bug.cgi?id=21483
1010
1011         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1012         (printPNG):
1013         (dumpWebViewAsPixelsAndCompareWithExpected):
1014         * DumpRenderTree/mac/DumpRenderTree.mm:
1015         (dump):
1016         * DumpRenderTree/win/DumpRenderTree.cpp:
1017         (dump):
1018         * Scripts/run-webkit-tests:
1019
1020 2008-10-07  Adam Roben  <aroben@apple.com>
1021
1022         Make sure short functions get included in ChangeLog output for git
1023         repositories
1024
1025         Reviewed by Dave Kilzer.
1026
1027         * Scripts/prepare-ChangeLog:
1028         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
1029         will get its own chunk without any surrounding context.
1030         (sub extractLineRange): Use the line numbers from the chunk header
1031         without modifying them now that they're accurate.
1032
1033 2008-10-04  Mark Rowe  <mrowe@apple.com>
1034
1035         Reviewed by Tim Hatcher.
1036
1037         Update check-for-weak-vtables to check only the final linked image for weak vtables.
1038         This gives more useful results than checking each object file independently.
1039
1040         * Scripts/check-for-weak-vtables:
1041
1042 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
1043
1044         Reviewed by Darin Adler
1045
1046         Render images to RGBA8 bitmaps independently of platform endianness.
1047
1048         Create image difference bitmap in reference image colorspace instead of device colorspace
1049         (which depends on the main display profile), so that no color matching happens.
1050
1051         https://bugs.webkit.org/show_bug.cgi?id=21336
1052
1053         * DumpRenderTree/cg/ImageDiffCG.cpp:
1054         (createDifferenceBitmap):
1055         (computePercentageDifferent):
1056         (compareImages):
1057
1058 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
1059
1060         Reviewed by Darin Adler
1061
1062         Fix hang when running with --pixel --reset, which occurs
1063         because DRT spews PNG data when the script does not expect it.
1064
1065         https://bugs.webkit.org/show_bug.cgi?id=21323
1066
1067         * Scripts/run-webkit-tests:
1068
1069 2008-09-30  Mark Rowe  <mrowe@apple.com>
1070
1071         Reviewed by Dan Bernstein.
1072
1073         Add a leak counter for CachedResources since we've had two recent leaks involving them.
1074
1075         * Scripts/check-for-global-initializers:
1076
1077 2008-09-30  Mark Rowe  <mrowe@apple.com>
1078
1079         Rubber-stamped by Dan Bernstein.
1080
1081         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
1082
1083         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
1084         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
1085         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
1086         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
1087         torn down before we exit.
1088
1089         * DumpRenderTree/mac/DumpRenderTree.mm:
1090         (dumpRenderTree):
1091         (main):
1092
1093 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
1094
1095         Reviewed by Dan Bernstein
1096
1097         Don't run pixel comparison for text-only tests.
1098         https://bugs.webkit.org/show_bug.cgi?id=21124
1099
1100         * DumpRenderTree/mac/DumpRenderTree.mm:
1101         (dump):
1102         * Scripts/run-webkit-tests:
1103
1104 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
1105
1106         Reviewed by Simon.
1107
1108         Changed copyright from Trolltech ASA to Nokia.
1109
1110         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
1111
1112
1113         * DumpRenderTree/qt/DumpRenderTree.cpp:
1114         * DumpRenderTree/qt/jsobjects.cpp:
1115         * DumpRenderTree/qt/jsobjects.h:
1116         * DumpRenderTree/qt/main.cpp:
1117         * DumpRenderTree/qt/testplugin.cpp:
1118         * DumpRenderTree/qt/testplugin.h:
1119
1120 2008-09-28  David Kilzer  <ddkilzer@apple.com>
1121
1122         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
1123
1124         <https://bugs.webkit.org/show_bug.cgi?id=21185>
1125
1126         Reviewed by Adam.
1127
1128         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
1129         will attempt to reapply the last commit to a ChangeLog file such
1130         that the ChangeLog entry appears at the top of the file.
1131         (findChangeLog): Added prototype and moved method below the exit
1132         statement.
1133         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
1134         ChangeLog entries.
1135
1136 2008-09-27  Anders Carlsson  <andersca@apple.com>
1137
1138         Reviewed by Sam Weinig.
1139
1140         https://bugs.webkit.org/show_bug.cgi?id=21178
1141         <rdar://problem/6248651>
1142
1143         Return the result value from getURL.
1144
1145         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1146         (getURL):
1147
1148 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
1149
1150         Reviewed by Tim Hatcher.
1151
1152         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
1153
1154         * Scripts/build-webkit:
1155
1156 2008-09-26  Alice Liu  <alice.liu@apple.com>
1157
1158         Remove usage of atlstr.h and CString for VCExpress compatibility
1159
1160         Reviewed by Stephanie Lewis.
1161
1162         * record-memory-win/main.cpp:
1163         (ProcessArgs):
1164         (UseImage):
1165         (QueryContinuously):
1166         (OneQuery):
1167         (OneQueryMP):
1168
1169 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
1170
1171         wx build fix. Update the version of libpng.
1172
1173         * wx/install-unix-extras:
1174
1175 2008-09-24  Sam Weinig  <sam@webkit.org>
1176
1177         Reviewed by Darin Adler.
1178
1179         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
1180         <rdar://problem/6243534>
1181         Crash below Function.apply when using a runtime array as the argument list
1182
1183         Add method to ObjCController to return a runtime array.
1184
1185         * DumpRenderTree/mac/ObjCController.m:
1186         (+[ObjCController isSelectorExcludedFromWebScript:]):
1187         (+[ObjCController webScriptNameForSelector:]):
1188         (-[ObjCController testArray]):
1189
1190 2008-09-24  Beth Dakin  <bdakin@apple.com>
1191
1192         Reviewed by Sam Weinig.
1193
1194         Speculative build fix.
1195
1196         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1197         (AccessibilityUIElement::supportsPressAction):
1198
1199 2008-09-23  Beth Dakin  <bdakin@apple.com>
1200
1201         Reviewed by Sam Weinig.
1202
1203         This patch extends DumpRenderTree's AccessibilityController to ask
1204         if the focused element supports the press action.
1205
1206         * DumpRenderTree/AccessibilityUIElement.cpp:
1207         (getSupportsPressActionCallback):
1208         (AccessibilityUIElement::getJSClass):
1209         * DumpRenderTree/AccessibilityUIElement.h:
1210         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1211         (AccessibilityUIElement::supportsPressAction):
1212
1213 2008-09-22  Alice Liu  <alice.liu@apple.com>
1214
1215         Adding a stand-alone Windows console application to record a process's memory usage
1216
1217         Reviewed by Steve Falkenburg.
1218
1219         * record-memory-win: Added.
1220         * record-memory-win/main.cpp: Added.
1221         * record-memory-win/record-memory-win.vcproj: Added.
1222
1223 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
1224
1225         Reviewed by Darin Adler.
1226
1227         Support ability to get/set selected text ranges for text controls through AX.
1228
1229         * DumpRenderTree/AccessibilityUIElement.cpp:
1230         (setSelectedTextRangeCallback):
1231         (getSelectedTextRangeCallback):
1232         (AccessibilityUIElement::getJSClass):
1233         * DumpRenderTree/AccessibilityUIElement.h:
1234         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1235         (AccessibilityUIElement::attributesOfRowHeaders):
1236         (AccessibilityUIElement::attributesOfVisibleCells):
1237         (AccessibilityUIElement::rowIndexRange):
1238         (AccessibilityUIElement::columnIndexRange):
1239         (AccessibilityUIElement::cellForColumnAndRow):
1240         (AccessibilityUIElement::selectedTextRange):
1241         (AccessibilityUIElement::setSelectedTextRange):
1242         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1243         (AccessibilityUIElement::selectedTextRange):
1244         (AccessibilityUIElement::setSelectedTextRange):
1245
1246 2008-09-20  Darin Adler  <darin@apple.com>
1247
1248         * DumpRenderTree/mac/DumpRenderTree.mm:
1249         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
1250
1251 2008-09-19  Alp Toker  <alp@nuanti.com>
1252
1253         Build fix for the 'gold' linker and recent binutils. New behaviour
1254         requires that we link to used libraries explicitly.
1255
1256         * GNUmakefile.am:
1257
1258 2008-09-19  Stephanie Lewis  <slewis@apple.com>
1259
1260         Reviewed by Oliver Hunt.
1261
1262         Implement a workaround for an incorrect mime-type on machines with
1263         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
1264         See radar <rdar://problem/6234318>.
1265
1266         * DumpRenderTree/mac/DumpRenderTree.mm:
1267         (convertMIMEType):
1268
1269 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
1270
1271         Fixed Windows bustage
1272
1273         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1274         (AccessibilityUIElement::titleUIElement):
1275
1276 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
1277
1278         Reviewed by Darin Adler.
1279
1280         Expose titleUIElement call for DumpRenderTree
1281
1282         * ChangeLog:
1283         * DumpRenderTree/AccessibilityUIElement.cpp:
1284         (titleUIElementCallback):
1285         (AccessibilityUIElement::getJSClass):
1286         * DumpRenderTree/AccessibilityUIElement.h:
1287         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1288         (AccessibilityUIElement::titleUIElement):
1289
1290 2008-09-18  Darin Adler  <darin@apple.com>
1291
1292         * Scripts/do-webcore-rename: More renaming plans.
1293
1294 2008-09-18  Mark Rowe  <mrowe@apple.com>
1295
1296         Reviewed by Dan Bernstein.
1297
1298         Clear the main frame's name between tests to get more consistent test results
1299         when running the WebKit tests with --nthly.
1300
1301         * DumpRenderTree/mac/DumpRenderTree.mm:
1302         (resetWebViewToConsistentStateBeforeTesting):
1303         * DumpRenderTree/win/DumpRenderTree.cpp:
1304         (resetWebViewToConsistentStateBeforeTesting):
1305
1306 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1307
1308         Really fix tiger jsc tests.
1309
1310         * Scripts/run-javascriptcore-tests:
1311
1312 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1313
1314         Reviewed by Maciej Stachowiak.
1315
1316         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
1317
1318         * Scripts/run-javascriptcore-tests:
1319         * Scripts/webkitdirs.pm:
1320
1321 2008-09-18  Mark Rowe  <mrowe@apple.com>
1322
1323         Rubber-stamped by Sam Weinig.
1324
1325         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
1326         This should make it more obvious when a test does this, as stderr output tends to be obscured
1327         by noise in the test results.
1328
1329         Also fixes some coding style issues in ResourceLoadDelegate.mm.
1330
1331         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1332         (-[NSError _drt_descriptionSuitableForTestResult]):
1333         (-[NSURL _drt_descriptionSuitableForTestResult]):
1334         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1335         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1336         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1337         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1338         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1339         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1340
1341 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1342
1343         Reviewed by Mark Rowe and Maciej Stachowiak..
1344
1345         add a --64-bit option and specify which architecture to run on Mac.
1346
1347         * Scripts/run-javascriptcore-tests:
1348
1349 2008-09-17  Mark Rowe  <mrowe@apple.com>
1350
1351         Reviewed by Sam Weinig.
1352
1353         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
1354
1355         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
1356         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
1357         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
1358
1359         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
1360         * DumpRenderTree/LayoutTestController.cpp:
1361         (LayoutTestController::LayoutTestController):
1362         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
1363         (layoutTestControllerObjectFinalize): Deref the wrapped object.
1364         (LayoutTestController::makeWindowObject): Ref the wrapped object.
1365         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
1366         * DumpRenderTree/mac/DumpRenderTree.mm:
1367         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1368         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
1369         * DumpRenderTree/win/DumpRenderTree.cpp:
1370         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1371
1372 2008-09-16  Sam Weinig  <sam@webkit.org>
1373
1374         Reviewed by Mark Rowe.
1375
1376         Add flag to disable running sample on tests that timeout.
1377
1378         * Scripts/run-webkit-tests:
1379
1380 2008-09-16  Adam Roben  <aroben@apple.com>
1381
1382         Windows build fix after r36511
1383
1384         Update for rename of layoutTestController to gLayoutTestController.
1385
1386         * DumpRenderTree/LayoutTestController.cpp:
1387         * DumpRenderTree/win/EditingDelegate.cpp:
1388         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1389         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1390         * DumpRenderTree/win/UIDelegate.cpp:
1391
1392 2008-09-16  Adam Roben  <aroben@apple.com>
1393
1394         Add a script to print out the dependency tree of a Visual Studio
1395         solution file
1396
1397         * Scripts/print-msvc-project-dependencies: Added.
1398
1399 2008-09-16  Mark Rowe  <mrowe@apple.com>
1400
1401         Fix the build.
1402
1403         * DumpRenderTree/LayoutTestController.cpp:
1404         (notifyDoneCallback): Call fprintf in a safer manner.
1405
1406 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1407
1408         Reviewed by Eric Seidel
1409
1410         Protect against tests that call layoutTestController.notifyDone()
1411         more than once, which would lead to memory corruption, by nulling
1412         out the LayoutTestController on the JSObjectRef on destruction. Also
1413         add a finalize callback on the class so that if the LTC outlives
1414         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
1415         nulled out.
1416
1417         https://bugs.webkit.org/show_bug.cgi?id=20875
1418
1419         * DumpRenderTree/LayoutTestController.cpp:
1420         (LayoutTestController::LayoutTestController):
1421         (notifyDoneCallback):
1422         (layoutTestControllerObjectFinalize):
1423         (LayoutTestController::makeWindowObject):
1424         (LayoutTestController::getJSClass):
1425         * DumpRenderTree/LayoutTestController.h:
1426         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1427         (LayoutTestController::~LayoutTestController):
1428
1429 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1430
1431         Reviewed by Eric Seidel
1432
1433         Step 1 patch: rename global variable for clarity.
1434         https://bugs.webkit.org/show_bug.cgi?id=20875
1435
1436         * DumpRenderTree/DumpRenderTree.h:
1437         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1438         (dumpWebViewAsPixelsAndCompareWithExpected):
1439         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1440         (dumpFramesAsText):
1441         (dump):
1442         (runTest):
1443         (processWork):
1444         (webViewLoadFinished):
1445         (webViewWindowObjectCleared):
1446         * DumpRenderTree/mac/DumpRenderTree.mm:
1447         (allocateGlobalControllers):
1448         (dumpFrameScrollPosition):
1449         (dumpFramesAsText):
1450         (methodNameStringForFailedTest):
1451         (dump):
1452         (runTest):
1453         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1454         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1455         * DumpRenderTree/mac/EditingDelegate.mm:
1456         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1457         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1458         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1459         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1460         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1461         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1462         (-[EditingDelegate webViewDidBeginEditing:]):
1463         (-[EditingDelegate webViewDidChange:]):
1464         (-[EditingDelegate webViewDidEndEditing:]):
1465         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1466         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1467         (-[FrameLoadDelegate processWork:]):
1468         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1469         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1470         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1471         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1472         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1473         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1474         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1475         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1476         * DumpRenderTree/mac/UIDelegate.mm:
1477         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
1478         (-[UIDelegate webViewFocus:]):
1479         (-[UIDelegate webViewUnfocus:]):
1480         (-[UIDelegate webView:createWebViewWithRequest:]):
1481         (-[UIDelegate webViewClose:]):
1482         * DumpRenderTree/win/DumpRenderTree.cpp:
1483         (dumpFrameScrollPosition):
1484         (dumpFramesAsText):
1485         (dump):
1486         (runTest):
1487
1488 2008-09-15  Alice Liu  <alice.liu@apple.com>
1489
1490         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
1491
1492         Reviewed by Stephanie Lewis.
1493
1494         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1495         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC,
1496         but not Intel.  Add a check for nil before calling.
1497         (AccessibilityUIElement::rowIndexRange):
1498         (AccessibilityUIElement::columnIndexRange):
1499
1500 2008-09-14  Mark Rowe  <mrowe@apple.com>
1501
1502         Build fix.
1503
1504         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1505         (waitUntilDoneWatchdogFired):
1506         * DumpRenderTree/mac/ObjCPlugin.m:
1507
1508 2008-09-08  Dan Bernstein  <mitz@apple.com>
1509
1510         Reviewed by Mark Rowe.
1511
1512         - add an option to run-webkit-tests to always use the complex text code path
1513
1514         * DumpRenderTree/mac/DumpRenderTree.mm:
1515         (initializeGlobalsFromCommandLineOptions):
1516         (dumpRenderTree):
1517         * Scripts/run-webkit-tests:
1518
1519 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
1520
1521         Another Windows nightly build fix.
1522
1523         Reviewed by Sam Weinig.
1524
1525         * FindSafari/FindSafari.cpp:
1526         (_tmain): Delete existing WebKitNightly directory in temp.
1527         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
1528
1529 2008-09-07  Stephanie Lewis  <slewis@apple.com>
1530
1531         Reviewed by Mark Rowe.
1532
1533         Fix DRT build
1534
1535         * DumpRenderTree/DumpRenderTreePrefix.h:
1536         * DumpRenderTree/win/DumpRenderTree.vcproj:
1537
1538 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
1539
1540         Fix Windows nightlies.
1541
1542         Copy WebKit.dll alongside application so registry-free COM can find it.
1543         Update embedded manifest to force use registry-free COM.
1544
1545         Reviewed by Dave Hyatt.
1546
1547         * FindSafari/FindSafari.cpp:
1548         (copyManifest):
1549         (replaceManifest):
1550         (_tmain):
1551         * FindSafari/FindSafari.rc: Added.
1552         * FindSafari/FindSafari.vcproj:
1553         * FindSafari/Safari.exe.manifest: Added.
1554         * FindSafari/resource.h: Added.
1555
1556 === End merge of squirrelfish-extreme ===
1557
1558 2008-08-31  Mark Rowe  <mrowe@apple.com>
1559
1560         Reviewed by Maciej Stachowiak.
1561
1562         Add a --profile flag to run-sunspider.
1563
1564         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
1565         to build scripts as indicating that we should use the "Profiling" configuration.  At present
1566         this is only supported by JavaScriptCore, so using this argument to build any other project
1567         will likely result in unexpected behaviour.
1568
1569 2008-08-27  Mark Rowe  <mrowe@apple.com>
1570
1571         Reviewed by Oliver Hunt.
1572
1573         Fix run-webkit-tests to handle DRT exiting early.
1574
1575         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
1576
1577 === Start merge of squirrelfish-extreme ===
1578
1579 2008-09-04  Mark Rowe  <mrowe@apple.com>
1580
1581         Reviewed by Eric Seidel.
1582
1583         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
1584         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
1585
1586         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
1587
1588 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1589
1590         Reviewed by Oliver Hunt.
1591
1592         Bug 20616: Incorporate V8 benchmarks in testing
1593         <https://bugs.webkit.org/show_bug.cgi?id=20616>
1594
1595         Add support for the --v8 option to run-sunspider.
1596
1597         * Scripts/run-sunspider:
1598
1599 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
1600
1601         wx buildbot fix. More robust handling of clean when makefiles are not built or
1602         are not completely made.
1603
1604         * wx/build-wxwebkit:
1605
1606 2008-09-03  Mark Rowe  <mrowe@apple.com>
1607
1608         More Mac build fixes.
1609
1610         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
1611         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
1612         default configuration specified in the .xcconfig files.
1613
1614         * Scripts/build-webkit:
1615
1616 2008-09-03  Mark Rowe  <mrowe@apple.com>
1617
1618         Mac build fix.  Ensure that dashboard support is enabled.
1619
1620         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1621
1622 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
1623
1624         Build fix. Copy correct version of ICU.
1625
1626         * DumpRenderTree/win/DumpRenderTree.vcproj:
1627
1628 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1629
1630         Reviewed by Simon.
1631
1632         [run-webkit-tests] Use QtLauncher to show the results of the tests
1633         konqueror might not be installed, xdg-open might not be installed but the
1634         QtLauncher should be present.
1635
1636         * Scripts/run-webkit-tests:
1637
1638 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
1639
1640         Initial support for accessibility layout tests on Windows.
1641         https://bugs.webkit.org/show_bug.cgi?id=20497
1642
1643         Reviewed by Sam Weinig.
1644
1645         * DumpRenderTree/AccessibilityController.h: Fix typos.
1646         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
1647         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
1648         prevent oleacc.h, which includes windows.h, from including winsock.h.
1649         Fixed typos.
1650         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
1651         (AccessibilityController::AccessibilityController):
1652         (AccessibilityController::~AccessibilityController):
1653         (AccessibilityController::focusedElement): Get the root element, and
1654         request its focused object.
1655         (AccessibilityController::rootElement): Query Windows for the
1656         accessible client object for the WebView's window.
1657         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
1658         (AccessibilityUIElement::AccessibilityUIElement):
1659         (AccessibilityUIElement::~AccessibilityUIElement):
1660         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
1661         (AccessibilityUIElement::getChildren): Get the child count, and append
1662         each child.
1663         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
1664         index offset by 1. In MSAA, child 0 is the object itself.
1665         (AccessibilityUIElement::allAttributes): Not implemented.
1666         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
1667         (AccessibilityUIElement::attributesOfChildren): Same.
1668         (AccessibilityUIElement::parameterizedAttributeNames): Same.
1669         (self): Return a VARIANT representing the "self" object. This is used
1670         when calling methods that require a child variant.
1671         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
1672         convert it into a string with GetRoleText().
1673         (AccessibilityUIElement::title): Get the element's title, and convert
1674         it to a JS String.
1675         (AccessibilityUIElement::description): Same, for description.
1676         (AccessibilityUIElement::width):
1677         (AccessibilityUIElement::height):
1678         (AccessibilityUIElement::intValue): Get the object's value as a string,
1679         and convert the string to a double.
1680         (AccessibilityUIElement::minValue): Not implemented.
1681         (AccessibilityUIElement::maxValue): Same.
1682         (AccessibilityUIElement::insertionPointLineNumber): Same.
1683         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
1684         (AccessibilityUIElement::attributesOfRowHeaders): Same.
1685         (AccessibilityUIElement::attributesOfColumns): Same.
1686         (AccessibilityUIElement::attributesOfRows): Same.
1687         (AccessibilityUIElement::attributesOfVisibleCells): Same.
1688         (AccessibilityUIElement::attributesOfHeader): Same.
1689         (AccessibilityUIElement::indexInTable): Same.
1690         (AccessibilityUIElement::rowIndexRange): Same.
1691         (AccessibilityUIElement::columnIndexRange): Same.
1692         (AccessibilityUIElement::lineForIndex): Same.
1693         (AccessibilityUIElement::boundsForRange): Same.
1694         (AccessibilityUIElement::cellForColumnAndRow): Same.
1695         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
1696         project.  Link to oleacc.lib, the MSAA library.
1697         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1698         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
1699         controller.
1700         (FrameLoadDelegate::didClearWindowObject): Create a new window object
1701         for the accessibility controller.
1702         * DumpRenderTree/win/FrameLoadDelegate.h:
1703
1704 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
1705
1706         Reviewed by Mark Rowe
1707
1708         Make build-launcher-app work when run from a git repository.
1709         https://bugs.webkit.org/show_bug.cgi?id=20478
1710
1711         * BuildSlaveSupport/build-launcher-app:
1712
1713 2008-08-20  Maxime Britto  <britto@apple.com>
1714
1715         Reviewed by Ada Chan.
1716
1717          rdar://5259746
1718         Mouse events are sent to page while resizing window (affects Gmail)
1719
1720         * DumpRenderTree/win/UIDelegate.h:
1721         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
1722
1723 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
1724
1725         Reviewed by Beth Dakin.
1726
1727         Add snowleopard platform in layout tests
1728
1729         Added support for accessing the attributes of
1730         accessibility tables through the accessibility controller
1731         in DumpRenderTree
1732
1733         * DumpRenderTree/AccessibilityUIElement.cpp:
1734         (attributesOfColumnHeadersCallback):
1735         (attributesOfRowHeadersCallback):
1736         (attributesOfColumnsCallback):
1737         (attributesOfRowsCallback):
1738         (attributesOfVisibleCellsCallback):
1739         (attributesOfHeaderCallback):
1740         (indexInTableCallback):
1741         (rowIndexRangeCallback):
1742         (columnIndexRangeCallback):
1743         (childAtIndexCallback):
1744         (cellForColumnAndRowCallback):
1745         (AccessibilityUIElement::getJSClass):
1746         * DumpRenderTree/AccessibilityUIElement.h:
1747         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1748         (convertNSArrayToVector):
1749         (descriptionOfElements):
1750         (AccessibilityUIElement::getLinkedUIElements):
1751         (AccessibilityUIElement::getChildren):
1752         (AccessibilityUIElement::attributesOfLinkedUIElements):
1753         (AccessibilityUIElement::attributesOfChildren):
1754         (AccessibilityUIElement::attributesOfColumnHeaders):
1755         (AccessibilityUIElement::attributesOfRowHeaders):
1756         (AccessibilityUIElement::attributesOfColumns):
1757         (AccessibilityUIElement::attributesOfRows):
1758         (AccessibilityUIElement::attributesOfVisibleCells):
1759         (AccessibilityUIElement::attributesOfHeader):
1760         (AccessibilityUIElement::indexInTable):
1761         (AccessibilityUIElement::rowIndexRange):
1762         (AccessibilityUIElement::columnIndexRange):
1763         (AccessibilityUIElement::cellForColumnAndRow):
1764         * Scripts/run-webkit-tests:
1765
1766 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
1767
1768         Reviewed by Darin Adler.
1769
1770         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
1771         is waiting for crash reporter to let it exit.
1772
1773         The fix does not work on Tiger, because the state of the process is indistinguishable from
1774         other waiting processes, at least not with this technique.
1775
1776         * Scripts/run-webkit-tests:
1777
1778 2008-08-18  Alp Toker  <alp@nuanti.com>
1779
1780         Reviewed by Holger Freyther.
1781
1782         https://bugs.webkit.org/show_bug.cgi?id=20350
1783         [GTK] Get DumpRenderTree working
1784
1785         Fixes and enhancements to DumpRenderTree. With these changes, the test
1786         suite can now complete a run producing text and render tree dumps.
1787
1788         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1789         (dumpFramesAsText):
1790         (dump):
1791         (runTest):
1792         (webViewLoadFinished):
1793         (webViewWindowObjectCleared):
1794         (webViewConsoleMessage):
1795         (webViewScriptAlert):
1796         (webViewScriptPrompt):
1797         (webViewScriptConfirm):
1798         (webViewTitleChanged):
1799         (main):
1800         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1801         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1802         (LayoutTestController::clearBackForwardList):
1803         (LayoutTestController::pathToLocalResource):
1804         (LayoutTestController::setAcceptsEditing):
1805         (LayoutTestController::setUserStyleSheetEnabled):
1806         (LayoutTestController::setUserStyleSheetLocation):
1807         (waitToDumpWatchdogFired):
1808         (LayoutTestController::windowCount):
1809         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1810         (JSStringCopyUTF8CString):
1811         (ScriptItem::invoke):
1812
1813 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
1814
1815         Reviewed by Cameron Zwarich.
1816
1817         Updated project files to XCode 3.1.
1818
1819         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1820         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1821
1822 2008-08-15  Mark Rowe  <mrowe@apple.com>
1823
1824         Rubber-stamped by Geoff Garen.
1825
1826         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
1827
1828         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
1829
1830 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
1831
1832         Rubber-stamped by Holger.
1833
1834         Revert r31585 and disable http tests for the Qt build again unless
1835         explicitly enabled.
1836
1837         Running the http tests unfortunately currently still triggers
1838         failures in non-http tests due to side-effects. Disable them by default for
1839         now, for more reliable results.
1840
1841         * Scripts/run-webkit-tests:
1842
1843 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
1844
1845         Reviewed (and updated) by Alp Toker.
1846
1847         https://bugs.webkit.org/show_bug.cgi?id=16620
1848         [GTK] Autotools make dist and make check support
1849
1850         Get make dist working.
1851
1852         Note that not all possible configurations have been tested yet.
1853
1854         * GNUmakefile.am:
1855
1856 2008-08-10  Alp Toker  <alp@nuanti.com>
1857
1858         Remove leftover qmake/GTK+ build files.
1859
1860         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
1861         * GtkLauncher/GtkLauncher.pro: Removed.
1862
1863 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
1864
1865         Reviewed by Beth Dakin
1866
1867         AX functions shouldn't return position information because it changes
1868         based on the platform
1869
1870         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1871         (AccessibilityUIElement::boundsForRange):
1872
1873 2008-08-06  Eric Seidel  <eric@webkit.org>
1874
1875         Reviewed by darin.
1876
1877         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
1878         <https://bugs.webkit.org/show_bug.cgi?id=20297>
1879         <rdar://problem/6093153>
1880
1881         I've made AccessibilityUIElement a stack object for now.  It could be
1882         made RefCounted, but I figured that might be overkill for the moment.
1883         Essentially it's just a RefPtr itself. :)
1884
1885         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
1886         which was causing additional leaks. :)
1887
1888         I added toAXElement to remove a bunch of copy/paste code.
1889
1890         * DumpRenderTree/AccessibilityController.h:
1891         * DumpRenderTree/AccessibilityUIElement.cpp:
1892         (toAXElement):
1893         (allAttributesCallback):
1894         (attributesOfLinkedUIElementsCallback):
1895         (attributesOfChildrenCallback):
1896         (lineForIndexCallback):
1897         (boundsForRangeCallback):
1898         (childAtIndexCallback):
1899         (getRoleCallback):
1900         (getTitleCallback):
1901         (getDescriptionCallback):
1902         (getWidthCallback):
1903         (getHeightCallback):
1904         (getIntValueCallback):
1905         (getMinValueCallback):
1906         (getMaxValueCallback):
1907         (getInsertionPointLineNumberCallback):
1908         (finalize):
1909         * DumpRenderTree/AccessibilityUIElement.h:
1910         (AccessibilityUIElement::platformUIElement):
1911         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1912         (AccessibilityController::focusedElement):
1913         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1914         (AccessibilityUIElement::AccessibilityUIElement):
1915         (AccessibilityUIElement::getLinkedUIElements):
1916         (AccessibilityUIElement::getChildren):
1917         (AccessibilityUIElement::getChildAtIndex):
1918         (AccessibilityUIElement::attributesOfLinkedUIElements):
1919         (AccessibilityUIElement::attributesOfChildren):
1920
1921 2008-08-06  Eric Seidel  <eric@webkit.org>
1922
1923         Reviewed by Cameron Zwarich.
1924
1925         Speculative fix for an error I keep seeing in my Cygwin build
1926
1927         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
1928
1929 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
1930
1931         Forgot to commit licensing correction in last commit.
1932
1933         * wx/packaging/wxWebKitInstaller.iss.in:
1934
1935 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
1936
1937         Reviewed by Eric Seidel.
1938
1939         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
1940         be used for nightlies.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=20036
1943
1944         * wx/packaging: Added.
1945         * wx/packaging/build-win-installer.py: Added.
1946         * wx/packaging/wxWebKitInstaller.iss.in: Added.
1947
1948 2008-07-31  Adam Roben  <aroben@apple.com>
1949
1950         Follow-up to r35500
1951
1952         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
1953         Release configuration, too.
1954
1955 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
1956
1957         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
1958         the box
1959
1960         <https://bugs.webkit.org/show_bug.cgi?id=20245>
1961
1962         Reviewed by Adam Roben.
1963
1964         * WinLauncher/WinLauncher.vcproj: adding the following properties to
1965         WinLauncher > Properties > Manifest Tool > Isolated COM
1966         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
1967         Component File Name: WebKit$(WebKitDLLConfigSuffix)
1968         Doing the change on "All Configurations"
1969
1970 2008-07-31  Adam Roben  <aroben@apple.com>
1971
1972         Windows build bot fix
1973
1974         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
1975         exist for people at Apple can't be found. Also updated the ICU version
1976         to 3.8.
1977
1978 2008-07-31  David Kilzer  <ddkilzer@apple.com>
1979
1980         Fix layout test results for webarchive/test-xml-stylesheet.xml
1981
1982         Reviewed by Darin Adler.
1983
1984         * DumpRenderTree/mac/DumpRenderTree.mm:
1985         (convertMIMEType): Work around the "text/xml" local file type
1986         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
1987         stop mangling "application/x-javascript" into "text/javascript".
1988         (convertWebResourceDataToString): When checking whether to dump a
1989         resource as text, also check to see if the MIME type is in the
1990         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
1991         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
1992         macro.
1993
1994 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
1995
1996         Reviewed by Alice Liu
1997
1998         Add AX support to get the bounds for a range of text
1999         Add AX support to get the child of an element
2000         Add AX support to get all the parameterized attribute names of an element
2001
2002         * DumpRenderTree/AccessibilityUIElement.cpp:
2003         (parameterizedAttributeNamesCallback):
2004         (boundsForRangeCallback):
2005         (childAtIndexCallback):
2006         (AccessibilityUIElement::getJSClass):
2007         * DumpRenderTree/AccessibilityUIElement.h:
2008         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2009         (AccessibilityUIElement::getChildAtIndex):
2010         (AccessibilityUIElement::parameterizedAttributeNames):
2011         (AccessibilityUIElement::boundsForRange):
2012
2013 2008-07-31  Erik Bunce  <elbunce@thehive.com>
2014
2015         Reviewed by Simon.
2016
2017         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
2018
2019         * Scripts/run-launcher:
2020
2021 2008-07-30  Jessica Kahn  <jess@apple.com>
2022
2023         Reviewed by Adam Roben.
2024
2025         Slightly stricter checking for previous change, suggested by Adam.
2026
2027         * Scripts/extract-localizable-strings:
2028
2029 2008-07-30  Jessica Kahn  <jess@apple.com>
2030
2031         Reviewed by Darin Adler.
2032
2033         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
2034
2035         * Scripts/extract-localizable-strings:
2036
2037 2008-07-30  Anders Carlsson  <andersca@apple.com>
2038
2039         Reviewed by Adam.
2040
2041         Copy icu38* files instead of icu36* files.
2042
2043         * DumpRenderTree/win/DumpRenderTree.vcproj:
2044
2045 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2046
2047         DRT/Gtk build fix for r35362
2048
2049         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2050         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2051
2052 2008-07-25  Brady Eidson  <beidson@apple.com>
2053
2054         Reviewed by Sam
2055
2056         Add the ability to dump whether-or-not an element should have autocomplete enabled,
2057         from the perspective of the WebKit API
2058
2059         * DumpRenderTree/LayoutTestController.cpp:
2060         (elementDoesAutoCompleteForElementWithIdCallback):
2061         (LayoutTestController::staticFunctions):
2062
2063         * DumpRenderTree/LayoutTestController.h:
2064         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2065         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2066         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2067         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
2068
2069 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
2070
2071         Reviewed by Beth Dakin
2072
2073         Add support for AXLineForIndex and AXInsertionPointIndex through the
2074         accessibility controller
2075
2076         * DumpRenderTree/AccessibilityUIElement.cpp:
2077         (lineForIndexCallback):
2078         (getInsertionPointLineNumberCallback):
2079         (AccessibilityUIElement::getJSClass):
2080         * DumpRenderTree/AccessibilityUIElement.h:
2081         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2082         (AccessibilityUIElement::insertionPointLineNumber):
2083         (AccessibilityUIElement::lineForIndex):
2084
2085 2008-07-25  Adam Roben  <aroben@apple.com>
2086
2087         Try to fix the Windows build bot
2088
2089         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
2090         that don't exist for people outside of Apple.
2091
2092 2008-07-18  Landry Breuil  <landry@openbsd.org>
2093
2094         Bug 19975: [OpenBSD] Patches to enable build of WebKit
2095
2096         <https://bugs.webkit.org/show_bug.cgi?id=19975>
2097
2098         Reviewed by David Kilzer.
2099
2100         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
2101
2102 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2103
2104         CygwinDownloader fails to install necessary packages
2105         https://bugs.webkit.org/show_bug.cgi?id=20075
2106
2107         Reviewed by Mark Rowe.
2108
2109         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
2110         mirrors removed in r34116. Set MIME type to application/octet-stream.
2111
2112 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2113
2114         CygwinDownloader's make-zip.sh script fails
2115         https://bugs.webkit.org/show_bug.cgi?id=20074
2116
2117         Reviewed by Mark Rowe.
2118
2119         * CygwinDownloader/cygwin-downloader.py:
2120
2121 2008-07-15  Sam Weinig  <sam@webkit.org>
2122
2123         Reviewed by Anders Carlsson.
2124
2125         Refactor accessibility testing code.
2126
2127         We now have:
2128         - AccessibilityController
2129           Controller which has access to the WebView and can provide the focused element, root element
2130           and in the future, elementAtPoint.
2131
2132         - AccessibilityUIElement
2133           Object which provides access to the data provided by the Accessibility APIs.
2134
2135         * DumpRenderTree/AccessibilityController.cpp:
2136         (getFocusedElementCallback):
2137         (getRootElementCallback):
2138         (AccessibilityController::getJSClass):
2139         * DumpRenderTree/AccessibilityController.h:
2140         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
2141         (allAttributesCallback):
2142         (attributesOfLinkedUIElementsCallback):
2143         (attributesOfChildrenCallback):
2144         (getRoleCallback):
2145         (getTitleCallback):
2146         (getDescriptionCallback):
2147         (getWidthCallback):
2148         (getHeightCallback):
2149         (getIntValueCallback):
2150         (getMinValueCallback):
2151         (getMaxValueCallback):
2152         (finalize):
2153         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2154         (AccessibilityUIElement::getJSClass):
2155         * DumpRenderTree/AccessibilityUIElement.h: Added.
2156         (AccessibilityUIElement::platformUIElement):
2157         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2158         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2159         (AccessibilityController::AccessibilityController):
2160         (AccessibilityController::~AccessibilityController):
2161         (AccessibilityController::focusedElement):
2162         (AccessibilityController::rootElement):
2163         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
2164         (AccessibilityUIElement::AccessibilityUIElement):
2165         (descriptionOfValue):
2166         (attributesOfElement):
2167         (nsStringToJSStringRef):
2168         (concatenateAttributeAndValue):
2169         (AccessibilityUIElement::getLinkedUIElements):
2170         (AccessibilityUIElement::getChildren):
2171         (AccessibilityUIElement::attributesOfLinkedUIElements):
2172         (AccessibilityUIElement::attributesOfChildren):
2173         (AccessibilityUIElement::allAttributes):
2174         (AccessibilityUIElement::role):
2175         (AccessibilityUIElement::title):
2176         (AccessibilityUIElement::description):
2177         (AccessibilityUIElement::width):
2178         (AccessibilityUIElement::height):
2179         (AccessibilityUIElement::intValue):
2180         (AccessibilityUIElement::minValue):
2181         (AccessibilityUIElement::maxValue):
2182
2183 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
2184
2185         Reviewed by Beth Dakin
2186
2187         Add support to get attributes of the AXChildren of an objecty
2188
2189         * DumpRenderTree/AccessibilityController.cpp:
2190         (attributesOfChildrenForFocusedElementCallback):
2191         (AccessibilityController::staticFunctions):
2192         * DumpRenderTree/AccessibilityController.h:
2193         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2194         (descriptionOfValue):
2195         (AccessibilityController::attributesOfChildrenForFocusedElement):
2196
2197 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
2198
2199         Build fix.
2200
2201         * DumpRenderTree/win/DumpRenderTree.vcproj:
2202
2203 2008-07-14  Adam Roben  <aroben@apple.com>
2204
2205         Attempted Windows build fix
2206
2207         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
2208         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
2209         include path.
2210
2211 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
2212
2213         Reviewed by Geoff Garen.
2214
2215         Eliminate per-thread JavaScript global data instance support and make arbitrary
2216         global data/global object combinations possible.
2217
2218         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2219         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
2220         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
2221         chance for a different thread to cause GC after the context was released.
2222
2223 2008-07-11  Stephanie Lewis  <slewis@apple.com>
2224
2225         Reviewed by Darin Adler.
2226
2227         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
2228
2229         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
2230
2231         * DumpRenderTree/mac/DumpRenderTree.mm:
2232         (setDefaultsToConsistentValuesForTesting):
2233         (resetWebViewToConsistentStateBeforeTesting):
2234         * Scripts/run-webkit-tests:
2235
2236 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
2237
2238         Build fix.
2239
2240         * DumpRenderTree/win/DumpRenderTree.vcproj:
2241
2242 2008-07-09  Eric Seidel  <eric@webkit.org>
2243
2244         Reviewed by Mark Rowe.
2245
2246         Print <div> backgrounds when printing from DRT.
2247
2248         * DumpRenderTree/mac/DumpRenderTree.mm:
2249         (setDefaultsToConsistentValuesForTesting):
2250
2251 2008-07-09  Eric Seidel  <eric@webkit.org>
2252
2253         Reviewed by Mark Rowe.
2254
2255         Fix copying of expected results to correct location
2256
2257         * Scripts/run-webkit-tests:
2258
2259 2008-07-09  Eric Seidel  <eric@webkit.org>
2260
2261         Reviewed by aroben.
2262
2263         * DumpRenderTree/LayoutTestController.cpp:
2264         (LayoutTestController::LayoutTestController):
2265         (dumpAsPDFCallback):
2266         (LayoutTestController::staticFunctions):
2267         * DumpRenderTree/LayoutTestController.h:
2268         (LayoutTestController::dumpAsPDF):
2269         (LayoutTestController::setDumpAsPDF):
2270         * DumpRenderTree/mac/DumpRenderTree.mm:
2271         (dumpFrameAsPDF):
2272         (dump):
2273
2274 2008-07-09  Eric Seidel  <eric@webkit.org>
2275
2276         Reviewed by weinig.
2277
2278         Add Content-Type support to DumpRenderTree and run-webkit-tests
2279         and move expected.txt files to expected.webarchive
2280
2281         https://bugs.webkit.org/show_bug.cgi?id=15565
2282
2283         * DumpRenderTree/cg/ImageDiffCG.cpp:
2284         (compareImages):
2285         (main):
2286         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2287         (printPNG):
2288         * DumpRenderTree/mac/DumpRenderTree.mm:
2289         (dump):
2290         * Scripts/run-webkit-tests:
2291
2292 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
2293
2294         Reviewed by Anders.
2295
2296         Port r34988 to Mac: allow tests to define JavaScript to execute when
2297         NPP_DestroyStream or NPP_URLNotify is called.
2298
2299         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2300         (NPP_New): Remove initialization that happens in pluginAllocate. Look
2301         for new arguments onStreamDestroy and onURLNotify.
2302         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
2303         (executeScript): Code moved from onStreamLoad.
2304         (NPP_NewStream): Call executeScript.
2305         (NPP_DestroyStream): Same.
2306         (NPP_URLNotify): Same.
2307
2308 2008-07-07  Beth Dakin  <bdakin@apple.com>
2309
2310         Reviewed by Anders.
2311
2312         This patch extends DRT accessibility tests to add the ability to
2313         query the intValue, minValue, and maxValue of the focused element.
2314
2315         * DumpRenderTree/AccessibilityController.cpp:
2316         (intValueOfFocusedElementCallback):
2317         (minValueOfFocusedElementCallback):
2318         (maxValueOfFocusedElementCallback):
2319         (AccessibilityController::staticFunctions):
2320         * DumpRenderTree/AccessibilityController.h:
2321         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2322         (AccessibilityController::intValueOfFocusedElement):
2323         (AccessibilityController::minValueOfFocusedElement):
2324         (AccessibilityController::maxValueOfFocusedElement):
2325
2326 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
2327
2328         Fix build.
2329
2330         * DumpRenderTree/win/ImageDiff.vcproj:
2331
2332 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
2333
2334         Allow tests to define JavaScript to execute when NPP_DestroyStream or
2335         NPP_URLNotify is called.
2336
2337         Reviewed by Anders.
2338
2339         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
2340         property, "returnErrorFromNewStream." This is to support the test for
2341         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
2342         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
2343         error from NPP_NewStream.
2344         (pluginGetProperty):
2345         (pluginSetProperty):
2346         (pluginAllocate):
2347         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
2348         members, onStreamDestroy and onURLNotify.
2349         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2350         (NPP_New): Remove initialization of onStreamLoad; this was moved to
2351         pluginAllocate. Look for new arguments onStreamDestroy and
2352         onURLNotify, and store their values.
2353         (NPP_Destroy): Free new members.
2354         (executeScript): Code moved from onStreamLoad
2355         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
2356         return a generic error code. If onStreamLoad is set, execute it as
2357         JavaScript.
2358         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
2359         (NPP_URLNotify): Same, for onURLNotify.
2360
2361 2008-07-02  Brady Eidson  <beidson@apple.com>
2362
2363         Reviewed by Mitz Pettel and John Sullivan
2364
2365         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
2366         load delegate.
2367
2368         Required to add a layout test for the fix for <rdar://problem/5549871>
2369
2370         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2371         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
2372           [WebFrame stopLoading] to test for the crash reflected in 5549871
2373
2374         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
2375         * DumpRenderTree/LayoutTestController.cpp:
2376         (LayoutTestController::LayoutTestController):
2377         (setStopProvisionalFrameLoadsCallback):
2378         (LayoutTestController::staticFunctions):
2379         * DumpRenderTree/LayoutTestController.h:
2380         (LayoutTestController::stopProvisionalFrameLoads):
2381         (LayoutTestController::setStopProvisionalFrameLoads):
2382
2383 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
2384
2385         Reviewed by Beth Dakin
2386
2387         Support ability to get width and height of an element through accessibility
2388
2389         * DumpRenderTree/AccessibilityController.cpp:
2390         (widthOfFocusedElementCallback):
2391         (heightOfFocusedElementCallback):
2392         (AccessibilityController::staticFunctions):
2393         * DumpRenderTree/AccessibilityController.h:
2394         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2395         (AccessibilityController::widthOfFocusedElement):
2396         (AccessibilityController::heightOfFocusedElement):
2397
2398 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
2399
2400         Reviewed by Beth Dakin
2401
2402         Support the ability to get the linked ui elements of an object
2403
2404         * DumpRenderTree/AccessibilityController.cpp:
2405         (attributesOfLinkedUIElementsForFocusedElementCallback):
2406         (AccessibilityController::staticFunctions):
2407         * DumpRenderTree/AccessibilityController.h:
2408         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2409         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
2410         (AccessibilityController::allAttributesOfFocusedElement):
2411         (attributesOfElement):
2412         (nsStringToJSStringRef):
2413
2414 2008-06-29  Sam Weinig  <sam@webkit.org>
2415
2416         Fix Tiger build.
2417
2418         * DumpRenderTree/mac/EventSendingController.mm:
2419         (eventTypeForMouseButtonAndAction):
2420
2421 2008-06-27  Eric Seidel  <eric@webkit.org>
2422
2423         Reviewed by darin.
2424
2425         Add multi-button mouseevent support to DRT
2426         https://bugs.webkit.org/show_bug.cgi?id=15173
2427
2428         It's now possible to specify the mouse button with:
2429         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
2430
2431         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2432         * DumpRenderTree/mac/EventSendingController.h:
2433         * DumpRenderTree/mac/EventSendingController.mm:
2434         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2435         (+[EventSendingController webScriptNameForSelector:]):
2436         (eventTypeForMouseButtonAndAction):
2437         (-[EventSendingController updateClickCountForButton:]):
2438         (-[EventSendingController mouseDown:]):
2439         (-[EventSendingController mouseUp:]):
2440         (-[EventSendingController mouseMoveToX:Y:]):
2441         (-[EventSendingController contextClick]):
2442
2443 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
2444
2445         Reviewed by Oliver.
2446
2447         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
2448         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
2449
2450         * Scripts/run-webkit-tests:
2451
2452 2008-06-27  Jan Michael Alonzo  <jmalonzo@webkit.org>
2453
2454         Reviewed by Christian Dywan.
2455
2456         [Gtk] Initialize webview settings before running DRT tests
2457         http://bugs.webkit.org/show_bug.cgi?id=19778
2458
2459         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2460         (setDefaultsToConsistentStateValuesForTesting):
2461         (main):
2462
2463 2008-06-26  Darin Adler  <darin@apple.com>
2464
2465         * Scripts/check-for-weak-vtables: Fixed comment.
2466
2467 2008-06-26  Darin Adler  <darin@apple.com>
2468
2469         * Scripts/check-for-weak-vtables: Added.
2470
2471 2008-06-26  Beth Dakin  <bdakin@apple.com>
2472
2473         Reviewed by Sam.
2474
2475         Do not include AXPosition in the dump of all of the accessibility
2476         attributes since it is screen-specific.
2477
2478         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2479         (AccessibilityController::allAttributesOfFocusedElement):
2480
2481 2008-06-26  Beth Dakin  <bdakin@apple.com>
2482
2483         Reviewed by Anders.
2484
2485         This is a speculative fix for the failing layout test on the build
2486         bot. It seems that the problem that the Build Bot is having is
2487         Tiger-specific. On Tiger, [NSValue description] was not very smart.
2488         So I replaced our call to description with a hand-rolled equivalent
2489         that will match on both platforms.
2490
2491         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2492         (descriptionOfValue):
2493
2494 2008-06-25  Beth Dakin  <bdakin@apple.com>
2495
2496         Reviewed by Sam Weinig.
2497
2498         This patch adds support to the AccessibilityController to query the
2499         following attributes specifically, without a full attribute dump:
2500         AXRole, AXTitle, and AXDescription.
2501
2502         * DumpRenderTree/AccessibilityController.cpp:
2503         (allAttributesForFocusedElementCallback):
2504         (roleOfFocusedElementCallback):
2505         (titleOfFocusedElementCallback):
2506         (descriptionOfFocusedElementCallback):
2507         (AccessibilityController::staticFunctions):
2508         * DumpRenderTree/AccessibilityController.h:
2509         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2510         (AccessibilityController::allAttributesForFocusedElement):
2511         (concatenateAttributeAndValue):
2512         (AccessibilityController::roleOfFocusedElement):
2513         (AccessibilityController::titleOfFocusedElement):
2514         (AccessibilityController::descriptionOfFocusedElement):
2515
2516 2008-06-24  Dan Bernstein  <mitz@apple.com>
2517
2518         Reviewed by Stephanie Lewis.
2519
2520         - move the linker flags from the debug configuration in the project
2521           to the shared configuration
2522
2523         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2524         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2525
2526 2008-06-24  Dan Bernstein  <mitz@apple.com>
2527
2528         - try to fix the Tiger build
2529
2530         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2531
2532 2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
2533
2534         Reviewed by Darin Adler.
2535
2536         Fix for <rdar://problem/5884881> Make DumpRenderTree support
2537         accessibility tests
2538
2539         This patch adds some basic support for accessibility layout tests
2540         on the Mac.
2541
2542         * DumpRenderTree/AccessibilityController.cpp: Added.
2543         (AccessibilityController::AccessibilityController):
2544         (AccessibilityController::~AccessibilityController):
2545         (dumpCurrentAttributesCallback):
2546         (AccessibilityController::makeWindowObject):
2547         (AccessibilityController::getJSClass):
2548         (AccessibilityController::staticFunctions):
2549         * DumpRenderTree/AccessibilityController.h: Added.
2550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2551         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
2552         (descriptionOfValue):
2553         (AccessibilityController::dumpCurrentAttributes):
2554         * DumpRenderTree/mac/DumpRenderTree.mm:
2555         * DumpRenderTree/mac/FrameLoadDelegate.h:
2556         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2557         (-[FrameLoadDelegate init]):
2558         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2559
2560 2008-06-24  John Sullivan  <sullivan@apple.com>
2561
2562         Reviewed by Dan Bernstein
2563
2564         * Scripts/extract-localizable-strings:
2565         add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the
2566         list of debugging macros, to avoid noise when keeping the list of localized string
2567         exceptions up to date
2568
2569 2008-06-24  Dan Bernstein  <mitz@apple.com>
2570
2571         Rubber-stamped by Darin Adler.
2572
2573         - add a font family for testing font-weight
2574
2575         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
2576         flags to create data sections for the WeightWatcher fonts.
2577         * DumpRenderTree/fonts: Added.
2578         * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
2579         * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
2580         * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
2581         * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
2582         * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
2583         * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
2584         * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
2585         * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
2586         * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
2587         * DumpRenderTree/mac/DumpRenderTree.mm:
2588         (activateFonts): Renamed activateAhemFont to this and made it activate
2589         the WeightWatcher fonts in addition to Ahem.
2590         (prepareConsistentTestingEnvironment): Adjusted for the name change.
2591         * DumpRenderTree/win/DumpRenderTree.cpp:
2592         (initialize): Added the WeightWatcher fonts.
2593
2594 2008-06-20  Brent Fulgham  <bfulgham@gmail.com>
2595
2596         Reviewed by Darin Adler.
2597
2598         Extend the build-webkit (and set-webkit-configuration) script to
2599         support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)
2600
2601         * Scripts/build-webkit:  Add --cairo-win32 to the help message
2602         * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
2603           subroutine to recognize the --cairo-win32 flag.  When present,
2604           the build configuration is changed from Debug/Release to
2605           Debug_Cairo/Release_Cairo.  This flag is only active when the
2606           isCygwin() test is true.
2607
2608 2008-06-17  Dan Bernstein  <mitz@apple.com>
2609
2610         Reviewed by Justin Garcia.
2611
2612         - prefer Leopard results when running on Snow Leopard.
2613
2614         * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
2615           mac-leopard.
2616         * Scripts/webkitdirs.pm: Added isSnowLeopard().
2617
2618 2008-06-15  Darin Adler  <darin@apple.com>
2619
2620         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2621
2622 2008-06-15  Darin Adler  <darin@apple.com>
2623
2624         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2625
2626 2008-06-15  Darin Adler  <darin@apple.com>
2627
2628         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2629
2630 2008-06-15  Darin Adler  <darin@apple.com>
2631
2632         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2633
2634 2008-06-15  Darin Adler  <darin@apple.com>
2635
2636         * Scripts/do-file-rename: Updated.
2637         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2638
2639 2008-06-15  Darin Adler  <darin@apple.com>
2640
2641         * Scripts/do-file-rename: Updated for the latest round of renaming.
2642         * Scripts/do-webcore-rename: Tweaked and reorganized a bit.
2643
2644 2008-06-15  Darin Adler  <darin@apple.com>
2645
2646         * Scripts/create-exports: Added.
2647         * Scripts/do-file-rename: Added some planned renames.
2648         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2649
2650 2008-06-15  Darin Adler  <darin@apple.com>
2651
2652         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2653
2654 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
2655
2656         Reviewed by Oliver.
2657
2658         - rename testkjs to jsc
2659
2660         * Scripts/build-jsc: Copied from Scripts/build-testkjs.
2661         * Scripts/build-testkjs: Removed.
2662         * Scripts/run-javascriptcore-tests:
2663         * Scripts/run-jsc: Copied from Scripts/run-testkjs.
2664         * Scripts/run-sunspider:
2665         * Scripts/run-testkjs: Removed.
2666         * Scripts/sunspider-compare-results:
2667
2668 2008-06-14  Darin Adler  <darin@apple.com>
2669
2670         * Scripts/do-webcore-rename: Moved planned renames into a separate hash
2671         from the actual renames. Removed many renames that are either done or
2672         no longer planned.
2673
2674 2008-06-14  Darin Adler  <darin@apple.com>
2675
2676         * Scripts/do-webcore-rename: Fixed obvious typo.
2677
2678 2008-06-13  Darin Adler  <darin@apple.com>
2679
2680         * Scripts/make-js-test-wrappers: Added three more exceptions.
2681
2682 2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>
2683
2684         Reviewed by Simon.
2685
2686         For the qmake based build make it possible to build against makespecs where
2687         QMAKE_CC is defined in a configuration file included from qmake.conf.
2688
2689         * Scripts/webkitdirs.pm: Added support for include() statements in
2690         qmake.conf.
2691
2692 2008-06-09  Alp Toker  <alp@nuanti.com>
2693
2694         gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
2695         each of the tools since these are no longer set globally.
2696
2697         * GNUmakefile.am:
2698
2699 2008-06-08  Darin Adler  <darin@apple.com>
2700
2701         * Scripts/make-js-test-wrappers: Added another exception.
2702
2703 2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2704
2705         Reviewed by Timothy.
2706
2707         Remove the --squirrelfish option from SunSpider, as it is no longer needed.
2708
2709         * Scripts/run-sunspider:
2710
2711 2008-06-05  Alp Toker  <alp@nuanti.com>
2712
2713         Build fix for r34387.
2714
2715         * GNUmakefile.am:
2716
2717 2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2718
2719         Reviewed by Oliver.
2720
2721         Add an exception for Opcode.o to the global initializers check so that
2722         we can dump instruction statistics in the JavaScript virtual machine.
2723
2724         * Scripts/check-for-global-initializers:
2725
2726 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
2727
2728         Generate an isolated COM manifest for registry free COM.
2729
2730         * DumpRenderTree/win/DumpRenderTree.vcproj:
2731
2732 2008-06-02  Anders Carlsson  <andersca@apple.com>
2733
2734         Reviewed by David Hyatt and Mitz.
2735
2736         <rdar://problem/5704119>
2737         repro crash in WebCore::RenderPart::setWidget (plugin-related?)
2738
2739         Call -[WebView display] in the "plug-in" failed delegate method, simulating
2740         the sheet that Safari puts up.
2741
2742         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2743         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2744
2745 2008-05-30  Timothy Hatcher  <timothy@apple.com>
2746
2747         Made the starting line number of scripts be 1-based throughout the engine.
2748         This cleans up script line numbers so they are all consistent now.
2749
2750         Reviewed by Oliver Hunt.
2751
2752         * DumpRenderTree/mac/ObjCController.m:
2753         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
2754         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2755         (runJavaScriptThread): Ditto.
2756         * DumpRenderTree/win/DumpRenderTree.cpp:
2757         (runJavaScriptThread): Ditto.
2758
2759 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
2760
2761         Reviewed by Adam Roben.
2762
2763         Fixed VCSUtils.pm to work with git repositories inside symlinks.
2764
2765         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
2766         root, instead of the root of the filesystem, to work around a bug in
2767         abs2rel when traversing symlinked home directories.
2768
2769 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
2770
2771         Reviewed by Darin Adler.
2772
2773         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
2774
2775         https://bugs.webkit.org/show_bug.cgi?id=19311
2776
2777         * Scripts/webkitdirs.pm:
2778
2779 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
2780
2781         Reviewed by Adam Roben.
2782
2783         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
2784         configuration files.
2785
2786         * Scripts/run-iexploder-tests:
2787         * Scripts/run-mangleme-tests:
2788         Renamed runSafari to not conflict with the one in webkitdirs.
2789         Added SSLCertificateFile option for httpd, as now needed.
2790
2791 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
2792
2793         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
2794
2795         * wx/browser/browser.cpp:
2796         (MyApp::OnInit):
2797
2798 2008-05-24  Andreia Gaita  <shana@isninja.com>
2799
2800         Reviewed by Alp Toker.
2801
2802         cygwin-downloader.py fixes.
2803
2804         Remove two non-working mirrors. Add a check for missing dependency
2805         packages to avoid bailing out on an inconsistent Cygwin package list.
2806
2807         * CygwinDownloader/cygwin-downloader.py:
2808
2809 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
2810
2811         Reviewed by Darin Adler.
2812
2813         Remove useQmake usage. QMake build doesn't support Gtk port
2814         anymore.
2815
2816         Also fix 2 occurences of "Web Kit". Should be WebKit.
2817
2818         * Scripts/build-webkit:
2819         * Scripts/run-javascriptcore-tests:
2820         * Scripts/run-launcher:
2821         * Scripts/run-webkit-tests:
2822         * Scripts/webkitdirs.pm:
2823
2824 2008-05-22  Stephanie Lewis  <slewis@apple.com>
2825
2826         Reviewed by Dan.
2827
2828         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
2829
2830         * DumpRenderTree/mac/UIDelegate.mm:
2831         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
2832         * DumpRenderTree/win/UIDelegate.cpp:
2833         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
2834
2835 2008-05-21  Adele Peterson  <adele@apple.com>
2836
2837         Reviewed by Adam.
2838
2839         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
2840
2841         * DumpRenderTree/win/UIDelegate.cpp:
2842         (UIDelegate::webViewFocus): Added.
2843         (UIDelegate::webViewUnfocus): Added.
2844         * DumpRenderTree/win/UIDelegate.h:
2845
2846 2008-05-21  Mark Rowe  <mrowe@apple.com>
2847
2848         Rubber-stamped by Stephanie Lewis.
2849
2850         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
2851         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
2852         once more.
2853
2854         * Scripts/run-safari:
2855
2856 2008-05-21  Stephanie Lewis  <slewis@apple.com>
2857
2858         Reviewed by Maciej, Mark.
2859
2860         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
2861
2862         * Scripts/run-webkit-tests:
2863         * Scripts/webkitdirs.pm:
2864
2865 2008-05-20  Mark Rowe  <mrowe@apple.com>
2866
2867         Reviewed by Stephanie Lewis.
2868
2869         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
2870
2871         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
2872         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
2873         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
2874         pass an argument to run-webkit-tests after having built with "make x86_64".
2875
2876         * Scripts/gdb-safari:
2877         * Scripts/run-safari:
2878         * Scripts/run-webkit-tests:
2879         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
2880         preferred architecture, and exporting of the environment variables for 'arch' out into
2881         separate subroutines.
2882
2883 2008-05-20  Mark Rowe  <mrowe@apple.com>
2884
2885         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
2886
2887         * Makefile:
2888
2889 === End merge of squirrelfish ===
2890
2891 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
2892
2893         Reviewed by Oliver.
2894
2895         - added support for --ubench mode
2896
2897         * Scripts/run-sunspider:
2898
2899 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
2900
2901         Reviewed by Oliver Hunt.
2902
2903         --squirrelfish mode: pared down tests for squirrelfish to chew on.
2904
2905         * Scripts/run-sunspider:
2906
2907 === Start merge of squirrelfish ===
2908
2909 2008-05-21  Darin Adler  <darin@apple.com>
2910
2911         * Scripts/make-js-test-wrappers: Added another exception.
2912
2913 2008-05-19  Stephanie Lewis  <slewis@apple.com>
2914
2915         Reviewed by Adam.
2916
2917         Explicitly set run mode to 32bit unless overridden to avoid
2918         confusion when running tests
2919
2920         * Scripts/build-dumprendertree:
2921         * Scripts/gdb-safari:
2922         * Scripts/run-webkit-tests:
2923         * Scripts/webkitdirs.pm:
2924
2925 2008-05-16  Stephanie Lewis  <slewis@apple.com>
2926
2927         Reviewed by Steve.
2928
2929         Print out pending unload event count. Also print out main frame name to match Mac.
2930
2931         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2932         (descriptionSuitableForTestResult):
2933         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2934
2935 2008-05-16  Timothy Hatcher  <timothy@apple.com>
2936
2937         Remove the Drosera project, code and resources since it has been
2938         replaced with the Web Inspector's debugger. Removes references to
2939         Drosera in various scripts and makefiles.
2940
2941         Rubber-stamped by Mark Rowe.
2942
2943         * BuildSlaveSupport/build-launcher-app:
2944         * Drosera/DebuggerDocument.cpp: Removed.
2945         * Drosera/DebuggerDocument.h: Removed.
2946         * Drosera/Drosera.icns: Removed.
2947         * Drosera/DroseraWin.make: Removed.
2948         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
2949         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
2950         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
2951         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
2952         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
2953         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
2954         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2955         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
2956         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2957         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2958         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
2959         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
2960         * Drosera/Images/Drosera.ico: Removed.
2961         * Drosera/Images/SourceArrow.png: Removed.
2962         * Drosera/Images/SourceArrowBlank.png: Removed.
2963         * Drosera/Images/SourceArrowOpen.png: Removed.
2964         * Drosera/Images/background_stripe.png: Removed.
2965         * Drosera/Images/breakPoint.tif: Removed.
2966         * Drosera/Images/breakPointDisabled.tif: Removed.
2967         * Drosera/Images/breakpointeditor.png: Removed.
2968         * Drosera/Images/close.tif: Removed.
2969         * Drosera/Images/close_active.tif: Removed.
2970         * Drosera/Images/close_hover.tif: Removed.
2971         * Drosera/Images/console.png: Removed.
2972         * Drosera/Images/continue.tif: Removed.
2973         * Drosera/Images/fileIcon.jpg: Removed.
2974         * Drosera/Images/finishFunction.tif: Removed.
2975         * Drosera/Images/glossyFooterFill.tif: Removed.
2976         * Drosera/Images/glossyHeader.png: Removed.
2977         * Drosera/Images/glossyHeaderPressed.png: Removed.
2978         * Drosera/Images/gradientBackground.png: Removed.
2979         * Drosera/Images/gutter.png: Removed.
2980         * Drosera/Images/navLeftDisabled.png: Removed.
2981         * Drosera/Images/navLeftNormal.png: Removed.
2982         * Drosera/Images/navLeftPressed.png: Removed.
2983         * Drosera/Images/navRightDisabled.png: Removed.
2984         * Drosera/Images/navRightNormal.png: Removed.
2985         * Drosera/Images/navRightPressed.png: Removed.
2986         * Drosera/Images/pause.tif: Removed.
2987         * Drosera/Images/popUpArrows.png: Removed.
2988         * Drosera/Images/programCounter.tif: Removed.
2989         * Drosera/Images/programCounterBreakPoint.tif: Removed.
2990         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
2991         * Drosera/Images/run.tif: Removed.
2992         * Drosera/Images/siteCollapsed.tif: Removed.
2993         * Drosera/Images/siteExpanded.tif: Removed.
2994         * Drosera/Images/siteIcon.tif: Removed.
2995         * Drosera/Images/small.ico: Removed.
2996         * Drosera/Images/splitterBar.tif: Removed.
2997         * Drosera/Images/splitterDimple.tif: Removed.
2998         * Drosera/Images/step.tif: Removed.
2999         * Drosera/Images/stepOut.tif: Removed.
3000         * Drosera/Images/stepOver.tif: Removed.
3001         * Drosera/Images/stop.tif: Removed.
3002         * Drosera/Images/toolbarBackground.png: Removed.
3003         * Drosera/Images/verticalSplitterBar.tiff: Removed.
3004         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
3005         * Drosera/Makefile: Removed.
3006         * Drosera/breakpointEditor.html: Removed.
3007         * Drosera/config.h: Removed.
3008         * Drosera/console.css: Removed.
3009         * Drosera/console.html: Removed.
3010         * Drosera/console.js: Removed.
3011         * Drosera/debugger.css: Removed.
3012         * Drosera/debugger.html: Removed.
3013         * Drosera/debugger.js: Removed.
3014         * Drosera/mac/DebuggerApplication.h: Removed.
3015         * Drosera/mac/DebuggerApplication.mm: Removed.
3016         * Drosera/mac/DebuggerClient.h: Removed.
3017         * Drosera/mac/DebuggerClient.mm: Removed.
3018         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
3019         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
3020         * Drosera/mac/Info.plist: Removed.
3021         * Drosera/mac/LauncherInfo.plist: Removed.
3022         * Drosera/mac/Makefile: Removed.
3023         * Drosera/mac/ServerConnection.h: Removed.
3024         * Drosera/mac/ServerConnection.mm: Removed.
3025         * Drosera/mac/launcher.m: Removed.
3026         * Drosera/mac/main.m: Removed.
3027         * Drosera/viewer.css: Removed.
3028         * Drosera/viewer.html: Removed.
3029         * Drosera/win/BaseDelegate.h: Removed.
3030         * Drosera/win/DebuggerClient.cpp: Removed.
3031         * Drosera/win/DebuggerClient.h: Removed.
3032         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3033         * Drosera/win/Drosera.cpp: Removed.
3034         * Drosera/win/Drosera.h: Removed.
3035         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
3036         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
3037         * Drosera/win/DroseraPrefix.cpp: Removed.
3038         * Drosera/win/DroseraPrefix.h: Removed.
3039         * Drosera/win/Info.plist: Removed.
3040         * Drosera/win/ServerConnection.cpp: Removed.
3041         * Drosera/win/ServerConnection.h: Removed.
3042         * Drosera/win/resource.h: Removed.
3043         * Makefile:
3044         * Scripts/build-drosera: Removed.
3045         * Scripts/gdb-drosera: Removed.
3046         * Scripts/run-drosera: Removed.
3047         * Scripts/run-drosera-nightly.cmd: Removed.
3048         * Scripts/run-drosera.cmd: Removed.
3049         * Scripts/webkitdirs.pm:
3050
3051 2008-05-15  Stephanie Lewis  <slewis@apple.com>
3052
3053         Reviewed by Anders.
3054
3055         Dump the unload count for a frame after parsing is finished.
3056
3057         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3058         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3059
3060 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
3061
3062         Reviewed by Dan Bernstein.
3063
3064         https://bugs.webkit.org/show_bug.cgi?id=10707
3065         DumpRenderTree should not be able to access non-local resources
3066
3067         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3068         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3069         Block them, and complain.
3070
3071 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
3072
3073         wx build fix. Update the version of libpng to download and instsall.
3074
3075         * wx/install-unix-extras:
3076
3077 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
3078
3079         Reviewed by Eric.
3080
3081         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
3082           We now force the return value to be numeric.
3083
3084         - Removed platform checks as it was a work around the previous issue.
3085
3086         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
3087
3088         * Scripts/build-webkit:
3089         * Scripts/webkitdirs.pm:
3090
3091 2008-05-12  Adam Roben  <aroben@apple.com>
3092
3093         Support for testing NPN_PostURL
3094
3095         Reviewed by Anders Carlsson.
3096
3097         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3098         (toCString): Added this helper function.
3099         (testPostURLFile): Added. Writes the passed-in content to the
3100         passed-in file and calls NPN_PostURL with the passed-in URL and
3101         target.
3102         (pluginInvoke): Added a case for testPostURLFile.
3103         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3104         (followShortcuts): Changed to allow paths that don't yet exist.
3105
3106 2008-05-12  Mark Rowe  <mrowe@apple.com>
3107
3108         Reviewed by Sam Weinig.
3109
3110         Minor cleanup of the DRT Xcode project.
3111
3112         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
3113         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
3114         not need to be there.
3115
3116 2008-05-12  Anders Carlsson  <andersca@apple.com>
3117
3118         Reviewed by Adam.
3119
3120         Add support for testing application caches.
3121
3122         * DumpRenderTree/mac/DumpRenderTree.mm:
3123         (dumpRenderTree):
3124         Empty the cache.
3125
3126         (resetWebViewToConsistentStateBeforeTesting):
3127         Turn on support for the application cache.
3128
3129 2008-05-09  Mark Rowe  <mrowe@apple.com>
3130
3131         Reviewed by Anders Carlsson.
3132
3133         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
3134
3135         It currently does not attempt to print events which means that plugins/mouse-events.html
3136         will fail when run 64-bit.  All other tests that use this plugin pass.
3137
3138         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3139         (testGetIntIdentifier):
3140         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3141         (NPP_New):
3142         (NPP_HandleEvent):
3143
3144 2008-05-09  Brady Eidson  <beidson@apple.com>
3145
3146         Reviewed by Adam Roben
3147
3148         Explicitly call shutDownWebKit() before quitting.
3149
3150         * Drosera/win/Drosera.cpp:
3151         (_tWinMain):
3152
3153         * DumpRenderTree/win/DumpRenderTree.cpp:
3154         (main):
3155
3156 2008-05-09  Mark Rowe  <mrowe@apple.com>
3157
3158         Fix the Tiger build of Drosera.
3159
3160         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
3161
3162 2008-05-09  Sam Weinig  <sam@webkit.org>
3163
3164         Rubber-stamped by Mark Rowe.
3165
3166         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
3167
3168         * Scripts/build-webkit:
3169
3170 2008-05-08  Mark Rowe  <mrowe@apple.com>
3171
3172         Another attempt at a Tiger build fix.
3173
3174         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
3175
3176         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3177
3178 2008-05-08  Mark Rowe  <mrowe@apple.com>
3179
3180         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
3181
3182         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3183
3184 2008-05-08  Mark Rowe  <mrowe@apple.com>
3185
3186         Reviewed by Oliver Hunt and Dan Bernstein.
3187
3188         Update DumpRenderTree to build 64-bit.
3189
3190         The three major changes here are:
3191         1) Use NSInteger in the appropriate places.
3192         2) Use ColorSync API that is available in 64-bit to switch display profiles.
3193         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
3194
3195         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
3196         needs updated to successfully build.
3197
3198         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
3199         * DumpRenderTree/mac/DumpRenderTree.mm:
3200         (swizzleAllMethods):
3201         (poseAsClass):
3202         (prepareConsistentTestingEnvironment):
3203         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3204         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3205         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3206         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3207         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3208         (restoreColorSpace):
3209         (failedGettingCurrentProfile):
3210         (setDefaultColorProfileToRGB):
3211
3212 2008-05-08  Mark Rowe  <mrowe@apple.com>
3213
3214         Reviewed by Darin Adler.
3215
3216         Clean up Drosera so that it will build 64-bit.
3217
3218         * Drosera/mac/DebuggerApplication.mm:
3219         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
3220         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
3221         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
3222
3223 2008-05-07  David Kilzer  <ddkilzer@apple.com>
3224
3225         Use File::Find and Getopt::Long in make-js-test-wrappers
3226
3227         Reviewed by Darin Adler.
3228
3229         * Scripts/make-js-test-wrappers:
3230         - Updated Apple copyright statement.
3231         - Added command-line switch parsing and -h|--help switch.
3232         - Allowed user to pass list of files/directories on which to do
3233           a restricted search for TEMPLATE.html files.  The default
3234           behavior is still to search the entire LayoutTests directory.
3235         - Removed duplicate 'use strict' statement.
3236         - Replaced use of `find` statements with File::Find::find().
3237         - Remove unneeded chomp() calls now that we use File::Find.
3238         (directoryFilter): Added.  Filters .svn directories when used
3239         with File::Find::find().
3240         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
3241         files found.
3242
3243 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
3244
3245         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
3246
3247         * DumpRenderTree/win/DumpRenderTree.vcproj:
3248         * DumpRenderTree/win/ImageDiff.vcproj:
3249
3250 2008-05-05  Adele Peterson  <adele@apple.com>
3251
3252         Reviewed by Adam.
3253
3254         Look for the right ImageDiff executable for debug builds.
3255
3256         * Scripts/run-webkit-tests:
3257
3258 2008-05-05  Darin Adler  <darin@apple.com>
3259
3260         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
3261         leak tests.
3262
3263 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3264
3265         Reviewed by Simon.
3266
3267         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
3268         tests expect to be 480x360)
3269
3270         * DumpRenderTree/qt/DumpRenderTree.cpp:
3271         (WebCore::DumpRenderTree::open):
3272
3273 2008-05-02  Dan Bernstein  <mitz@apple.com>
3274
3275         Reviewed by Adam Roben.
3276
3277         - add an option to svn-apply to set the reviewer name in change logs
3278
3279         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
3280
3281 2008-05-01  David Kilzer  <ddkilzer@apple.com>
3282
3283         Clean up configuration usage in run-webkit-tests
3284
3285         Reviewed by Adam.
3286
3287         * Scripts/run-webkit-tests: Parse configuration switches using
3288         passedConfiguration() from webkitdirs.pm like every other script.
3289         Note that we must still call setConfiguration() afterwards in
3290         case the --configuration switch was used.  Use $configurationOption
3291         when running build-dumprendertree instead of recreating the switch.
3292
3293 2008-04-29  Adam Roben  <aroben@apple.com>
3294
3295         Restore the beloved COMPtr::operator&
3296
3297 2008-04-29  Adam Roben  <aroben@apple.com>
3298
3299         Windows build fixes
3300
3301         Replace COMPtr::operator& with COMPtr::adoptionPointer.
3302
3303 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
3304
3305         Reviewed by Darin Adler.
3306
3307         Fix run-webkit-tests --threading
3308         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
3309         Proxy server issue in Sunday's Nightly
3310
3311         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3312         (runJavaScriptThread):
3313         (startJavaScriptThreads):
3314         (stopJavaScriptThreads):
3315         Spawned threads were immediately detached, unlike the original ones, so joining them
3316         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
3317         waits for them all to exit.
3318
3319 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3320
3321         Reviewed by Simon.
3322
3323         Reset dumping resource load callbacks to false for the next test
3324
3325
3326         * DumpRenderTree/qt/jsobjects.cpp:
3327         (LayoutTestController::reset):
3328
3329 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
3330
3331         Reviewed by Simon.
3332
3333         Adapt to the latest API changes in WebKit/qt/Api.
3334
3335         * DumpRenderTree/qt/DumpRenderTree.cpp:
3336         (WebCore::DumpRenderTree::DumpRenderTree):
3337         * DumpRenderTree/qt/jsobjects.cpp:
3338
3339 2008-04-26  Robin Dunn  <robin@alldunn.com>
3340
3341         Reviewed by Kevin Ollivier.
3342
3343         Delete the DerivedSources after make clean has been done so that the DerivedSources
3344         don't get re-created. Also, use the proper extension for the Win wxPython extension.
3345
3346         https://bugs.webkit.org/show_bug.cgi?id=18756
3347
3348         * wx/build-wxwebkit:
3349
3350 2008-04-26  Adam Barth <hk9565@gmail.com>
3351
3352         Reviewed by Adam Roben and Sam Weinig.
3353
3354         Updates LayoutTestController to use host instead of domain.
3355
3356         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
3357
3358         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3359         (LayoutTestController::setDatabaseQuota):
3360         * DumpRenderTree/mac/UIDelegate.mm:
3361         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3362
3363 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3364
3365         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
3366
3367         * wx/install-unix-extras:
3368
3369 2008-04-26  Robin Dunn  <robin@alldunn.com>
3370
3371         Reviewed by Kevin Ollivier.
3372
3373         Allow the user to set the path to SWIG using an environment variable.
3374
3375         https://bugs.webkit.org/show_bug.cgi?id=18660
3376
3377         * wx/build-wxwebkit:
3378
3379 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3380
3381         wx build fix. Download the latest libpng version for building the
3382         dependencies.
3383
3384         * wx/install-unix-extras:
3385
3386 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3387
3388         Reviewed by Simon.
3389
3390         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
3391
3392         Similar to Editing and Frameloading we do the dumping within WebCore
3393
3394
3395         * DumpRenderTree/qt/jsobjects.cpp:
3396         (LayoutTestController::dumpResourceLoadCallbacks):
3397         * DumpRenderTree/qt/jsobjects.h:
3398
3399 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3400
3401         Reviewed by Maciej Stachowiak.
3402
3403         http://bugs.webkit.org/show_bug.cgi?id=18485
3404         Typo and documentation fix for build-webkit
3405
3406         * Scripts/build-webkit:
3407
3408 2008-04-24  Anders Carlsson  <andersca@apple.com>
3409
3410         Reviewed by Sam.
3411
3412         Don't call fprintf from the signal handler.
3413
3414         * DumpRenderTree/mac/DumpRenderTree.mm:
3415         (crashHandler):
3416
3417 2008-04-23  Adam Roben  <aroben@apple.com>
3418
3419         Make crashes be reported as crashes, not hangs
3420
3421         Reviewed by David Kilzer.
3422
3423         * Scripts/run-webkit-tests:
3424         (top level): Use the new status field of the output from
3425         readFromDumpToolWithTimer to determine if the test crashed or hung.
3426         (sub readFromDumpToolWithTimer):
3427           - If we fail to read a line and $! is not EAGAIN, then we've crashed
3428             and should not try to read any more.
3429           - Changed the timedout field to a more general status field.
3430
3431 2008-04-22  David Kilzer  <ddkilzer@apple.com>
3432
3433         Bug 18683: update-webkit returns 0 even if it fails
3434
3435         <https://bugs.webkit.org/show_bug.cgi?id=18683>
3436
3437         Reviewed by Mitz Pettel.
3438
3439         * Scripts/update-webkit:
3440         (runSvnUpdate): Die if close() fails.
3441
3442 2008-04-21  Adam Roben  <aroben@apple.com>
3443
3444         Flush stdout/stderr after printing every #EOF separator
3445
3446         This fixes a hang when running the pixel tests on Windows
3447
3448         Reviewed by Mitz Pettel.
3449
3450         * DumpRenderTree/win/DumpRenderTree.cpp:
3451         (dump):
3452         (main): We don't have to flush stdout/stderr in the arguments loop
3453         anymore, as runTest flushes for us.
3454
3455 2008-04-21  Adam Roben  <aroben@apple.com>
3456
3457         Fix pixel tests
3458
3459         * Scripts/run-webkit-tests:
3460         (sub readFromDumpToolWithTimer): Use readline instead of read to
3461         ensure that we don't read past the #EOF marker.
3462
3463 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3464
3465         Reviewed by Simon.
3466
3467         Build fix for Qt 4.3
3468
3469         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
3470         always defined. Do this by adding defines to the compiler line
3471
3472         * DumpRenderTree/qt/DumpRenderTree.pro:
3473
3474 2008-04-19  Mike Hommey  <glandium@debian.org>
3475
3476         Reviewed by Alp Toker.
3477
3478         Don't build GtkLauncher and DumpRenderTree with rpath.
3479
3480         * GNUmakefile.am:
3481
3482 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3483
3484         Reviewed by Alp Toker.
3485
3486         http://bugs.webkit.org/show_bug.cgi?id=16620
3487         [GTK] Autotools make dist and make check support
3488
3489         Cleanups.
3490
3491         * GNUmakefile.am:
3492
3493 2008-04-18  Adam Roben  <aroben@apple.com>
3494
3495         Drop the hang timer to 30 seconds
3496
3497         This matches what DRT/mac was using.
3498
3499         Reviewed by Mitz Pettel.
3500
3501         * Scripts/run-webkit-tests:
3502
3503 2008-04-18  Adam Roben  <aroben@apple.com>
3504
3505         Get rid of DRT's Watchdog
3506
3507         run-webkit-tests now detects hangs and samples DRT as needed.
3508
3509         Reviewed by Mitz Pettel.
3510
3511         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
3512         Watchdog* files from the project.
3513         * DumpRenderTree/Watchdog.cpp: Removed.
3514         * DumpRenderTree/Watchdog.h: Removed.
3515         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
3516         (dumpRenderTree):
3517         (runTest):
3518         * DumpRenderTree/mac/WatchdogMac.h: Removed.
3519         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
3520         * Scripts/run-webkit-tests:
3521         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
3522         (sub sampleDumpTool): Added. Writes a sample report to
3523         ~/Library/Logs/DumpRenderTree/HangReport.txt.
3524
3525 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
3526
3527         Reviewed by Holger.
3528
3529         Adapt to the API changes in WebKit/qt
3530
3531         * DumpRenderTree/qt/DumpRenderTree.cpp:
3532         (WebCore::WebPage::WebPage):
3533         (WebCore::DumpRenderTree::DumpRenderTree):
3534         (WebCore::DumpRenderTree::initJSObjects):
3535         (WebCore::DumpRenderTree::dumpFramesAsText):
3536         (WebCore::DumpRenderTree::dump):
3537
3538 2008-04-17  Adam Roben  <aroben@apple.com>
3539
3540         Fix many tests on Windows
3541
3542         * Scripts/run-webkit-tests:
3543         (readFromDumpToolWithTimer):
3544          - Use read instead of sysread to ensure that we don't interfere with
3545            other uses of buffered IO in this script.
3546         (setFileHandleNonBlocking): Actually set the filehandle to blocking
3547         when specified.
3548
3549 2008-04-17  Adam Roben  <aroben@apple.com>
3550
3551         Fix ~10 tests
3552
3553         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
3554         whatever newline happens to be at the end of what we've read.
3555
3556 2008-04-17  Adam Roben  <aroben@apple.com>
3557
3558         Remove DRT/win's hang timer
3559
3560         run-webkit-tests takes care of this for us now
3561
3562         Reviewed by Anders Carlsson.
3563
3564         * DumpRenderTree/win/DumpRenderTree.cpp:
3565
3566 2008-04-17  Adam Roben  <aroben@apple.com>
3567
3568         Don't wait for the hang timer twice in the case of a hang
3569
3570         Previously we'd wait for a hang while reading both stdout and stderr
3571         from DRT. Now we'll only wait for one or the other.
3572
3573         Reviewed by Anders Carlsson.
3574
3575         * Scripts/run-webkit-tests:
3576         (top level): Don't wait for stderr to time out if stdout already timed
3577         out.
3578         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
3579         after the first read that returns no data.
3580
3581 2008-04-17  Adam Roben  <aroben@apple.com>
3582
3583         Don't throw away the output from timed out tests
3584
3585         Reviewed by Anders Carlsson.
3586
3587         * Scripts/run-webkit-tests:
3588         (top level): Updated for changes to readFromDumpToolWithTimer.
3589         (readFromDumpToolWithTimer): Return a hash that contains both the
3590         output and whether or not the test timed out.
3591
3592 2008-04-17  Adam Roben  <aroben@apple.com>
3593
3594         Make the hang timer 60 seconds
3595
3596         * Scripts/run-webkit-tests:
3597
3598 2008-04-17  Adam Roben  <aroben@apple.com>
3599
3600         Get rid of carriage returns in DRT/win's stderr
3601
3602         Reviewed by Eric Seidel.
3603
3604         * DumpRenderTree/win/DumpRenderTree.cpp:
3605         (main): Mark stderr as binary like we already do for stdout.
3606
3607 2008-04-17  Adam Roben  <aroben@apple.com>
3608
3609         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
3610         timeout long tests)
3611
3612         <https://bugs.webkit.org/show_bug.cgi?id=17678>
3613
3614         We now abort tests that take longer than 60 seconds to produce output.
3615         This matches the watchdog timer in DRT/mac and DRT/win (which we can
3616         now remove).
3617
3618         Reviewed by Eric Seidel.
3619
3620         * Scripts/run-webkit-tests:
3621         (top level): Read DRT's output using the new readFromDumpToolWithTimer
3622         subroutine. If readFromDumpToolWithTimer returns undefined it means
3623         the test timed out, so we register the test as a hang and move on.
3624         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
3625         both crashed and timed out tests. If the test timed out, we kill DRT
3626         before returning.
3627         (sub linksForTimedOutTest): Added. We don't have any output to link to for
3628         tests that timed out.
3629         (sub recordActualResultsAndDiff): Don't call length on undefined.
3630         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
3631         from a filehandle until an #EOF is reached or
3632         $maximumSecondsWithoutOutput have elapsed.
3633         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
3634         non-blocking.
3635
3636 2008-04-17  Adam Roben  <aroben@apple.com>
3637
3638         Refactor test results page generation
3639
3640         Reviewed by Eric Seidel.
3641
3642         * Scripts/run-webkit-tests:
3643         (sub htmlForResultsSection): Added. Takes a set of tests, a
3644         description, and a subroutine to generate the links for each test, and
3645         creates a HTML string containing a table of the tests and their
3646         links.
3647         (sub linksForExpectedAndActualResults): Added. Replaces the
3648         htmlForExpectedAndActualResults subroutine.
3649         (sub linksForMismatchTest): Added.
3650         (sub linksForCrashOrErrorTest): Added.
3651         (sub linksForNewTest): Added.
3652
3653 2008-04-17  Adam Roben  <aroben@apple.com>
3654
3655         Print the extension for all tests in the test results page
3656
3657         Reviewed by Eric Seidel.
3658
3659         * Scripts/run-webkit-tests:
3660
3661 2008-04-17  Adam Roben  <aroben@apple.com>
3662
3663         Move code that counts finished tests into a subroutine
3664
3665         Reviewed by Eric Seidel.
3666
3667         * Scripts/run-webkit-tests:
3668         (sub countFinishedTest): Added.
3669
3670 2008-04-17  Adam Roben  <aroben@apple.com>
3671
3672         Move code that handles a crash into a subroutine
3673
3674         Reviewed by Eric Seidel.
3675
3676         * Scripts/run-webkit-tests:
3677         (sub testCrashed): Added.
3678
3679 2008-04-17  Eric Seidel  <eric@webkit.org>
3680
3681         Reviewed by hyatt.
3682
3683         Rename RenderView to RenderViewport in the next rename patch.
3684
3685         * Scripts/do-webcore-rename:
3686
3687 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
3688
3689         Reviewed by Alp Toker.
3690
3691         http://bugs.webkit.org/show_bug.cgi?id=18543
3692         DumpRenderTree gtk freeze
3693
3694         fix DumpRenderTree gtk freeze
3695
3696         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3697         (dump):
3698
3699 2008-04-15  Anders Carlsson  <andersca@apple.com>
3700
3701         Add missing ;
3702
3703         * Scripts/build-webkit:
3704
3705 2008-04-15  Anders Carlsson  <andersca@apple.com>
3706
3707         Reviewed by Adam.
3708
3709         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
3710
3711         * Scripts/build-webkit:
3712
3713 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
3714
3715         Reviewed by Simon.
3716
3717         Fix compilation with Qt namespaces
3718
3719         Qt can be configured to have all of its classes inside a specified namespaces.
3720         This is for example used in plugin/component environments like Eclipse.
3721
3722         This change makes it possible to let the Qt port compile against a namespaced
3723         Qt by the use of macros Qt provides to properly forward declare Qt classes in
3724         the namespace.
3725
3726         * DumpRenderTree/qt/DumpRenderTree.h:
3727
3728 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
3729
3730         Reviewed by Darin Adler.
3731
3732         Add a script that propagates any file changes made to the Bakefiles
3733         over to GTK and Qt build systems. Still needs to be wired into
3734         those ports though.
3735
3736         * Scripts/update-sources-list.py: Added.
3737
3738 2008-04-08  Mark Rowe  <mrowe@apple.com>
3739
3740         Clean up after Brady.
3741
3742         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
3743
3744 2008-04-08  Brady Eidson  <beidson@apple.com>
3745
3746         Reviewed by Mitzpettel
3747
3748         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
3749         -WebArchive subresources dump in random order, intermittent failures
3750
3751         * DumpRenderTree/mac/DumpRenderTree.mm:
3752         (compareResourceURLs): Sorting function based on the resource URLs
3753         (serializeWebArchiveToXML): Sort the subresource array
3754
3755 2008-04-07  Brady Eidson  <beidson@apple.com>
3756
3757         OMG, BUILD - please!
3758
3759         * Scripts/build-webkit:
3760
3761 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3762
3763         Reviewed by Simon.
3764
3765         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
3766         * Running these tests on windows and other platforms might need some work.
3767
3768         * Scripts/run-webkit-tests:
3769
3770 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3771
3772         Reviewed by Simon.
3773
3774         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
3775         is not exporting enough to create the output in DRT itself. Settle with the approach
3776         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
3777         * run-webkit-tests http/tests(/loading) can now be executed.
3778         * For tests in loading/ directories we are going to throw away the dirty
3779         QWebPage to start with something clean.
3780
3781
3782         * DumpRenderTree/qt/DumpRenderTree.cpp:
3783
3784 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3785
3786         Reviewed by Simon.
3787
3788         * Treat http and https as special URLs as well. Change the main.cpp and
3789         DumpRenderTree.cpp to handle http and https URIs as input.
3790         * I'm not doing the clean up and merging of these two checks now.
3791
3792
3793         * DumpRenderTree/qt/DumpRenderTree.cpp:
3794         (WebCore::DumpRenderTree::readStdin):
3795         * DumpRenderTree/qt/main.cpp:
3796         (main):
3797
3798 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3799
3800         Reviewed by Simon.
3801
3802         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
3803         located in a directory with the name "loading". And this will autoamtically
3804         enable dumping.
3805         * Remove this method from the LayoutTestController as it is unused now and this
3806         avoids adding it to the DRT of the Qt port.
3807
3808
3809         * DumpRenderTree/LayoutTestController.cpp:
3810         (setPrivateBrowsingEnabledCallback):
3811
3812 2008-04-01  Christian Dywan  <christian@imendio.com>
3813
3814         Build fix for GCC 4.3.
3815
3816         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
3817
3818 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
3819
3820         Reviewed by Holger.
3821
3822         Fix Qt DRT run by also printing EOF on stderr, as expected by
3823         run-webkit-tests.
3824
3825         * DumpRenderTree/qt/DumpRenderTree.cpp:
3826         (WebCore::DumpRenderTree::dump):
3827
3828 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
3829
3830         Reviewed by Darin Adler.
3831
3832         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
3833
3834         Remove trailing '/' in $sourceDir in determineSourceDir().
3835
3836         Fix suggested by Dmitriy Kazachkov.
3837
3838         * Scripts/webkitdirs.pm:
3839
3840 2008-03-29  Adam Roben  <aroben@apple.com>
3841
3842         Update for rename of an IWebViewPrivate method
3843
3844         Reviewed by Mitz Pettel.
3845
3846         * DumpRenderTree/win/DumpRenderTree.cpp:
3847         (createWebViewAndOffscreenWindow):
3848
3849 2008-03-26  Antti Koivisto  <antti@apple.com>
3850
3851         Reviewed by Anders.
3852
3853         Enable SVG animation support by default.
3854
3855         * Scripts/build-webkit:
3856
3857 2008-03-25  Adam Roben  <aroben@apple.com>
3858
3859         Windows build fix
3860
3861         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3862         Add $(WebKitLibrariesDir)\include to the include path so we can find
3863         stdint.h there.
3864
3865 2008-03-24  Eric Seidel  <eric@webkit.org>
3866
3867         Reviewed by Mark.
3868
3869         Clean up SVG features message to be less confusing.
3870
3871         * Scripts/build-webkit:
3872
3873 2008-03-24  Sam Weinig  <sam@webkit.org>
3874
3875         Reviewed by Dave Hyatt.
3876
3877         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
3878
3879         * DumpRenderTree/mac/DumpRenderTree.mm:
3880         (resetWebViewToConsistentStateBeforeTesting):
3881         * DumpRenderTree/mac/EventSendingController.mm:
3882         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3883         (-[EventSendingController zoomPageIn]):
3884         (-[EventSendingController zoomPageOut]):
3885         * DumpRenderTree/win/DumpRenderTree.cpp:
3886         (resetWebViewToConsistentStateBeforeTesting):
3887         * DumpRenderTree/win/EventSender.cpp:
3888         (textZoomInCallback):
3889         (textZoomOutCallback):
3890         (zoomPageInCallback):
3891         (zoomPageOutCallback):
3892
3893 2008-03-24  Dan Bernstein  <mitz@apple.com>
3894
3895         Reviewed by Mark Rowe.
3896
3897         - update bisect-builds for Safari 3.1
3898
3899         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
3900         revision, r29711.
3901
3902 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
3903
3904         Reviewed by Holger.
3905
3906         http://bugs.webkit.org/show_bug.cgi?id=17981
3907
3908         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
3909
3910         * GNUmakefile.am:
3911
3912 2008-03-21  Adam Roben  <aroben@apple.com>
3913
3914         Remove a non-working mirror from cygwin-downloader and add the ruby package
3915
3916         * CygwinDownloader/cygwin-downloader.py:
3917         * CygwinDownloader/cygwin-downloader.zip: Updated.
3918
3919 2008-03-20  Mark Rowe  <mrowe@apple.com>
3920
3921         Reviewed by Sam Weinig.
3922
3923         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
3924         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
3925         command-line.
3926
3927         * Scripts/build-webkit:
3928
3929 2008-03-17  Eric Seidel  <eric@webkit.org>
3930
3931         Reviewed by Dan Bernstein.
3932
3933         Fix bogus argCount check breaking plugin test.
3934
3935         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3936
3937 2008-03-17  Eric Seidel  <eric@webkit.org>
3938
3939         Reviewed by darin.
3940
3941         Cleanup PluginObject.cpp and add support for testing
3942         converting from int -> identifier -> string
3943         and from string -> identifier -> int
3944         as well as round-tripping ints and stings through identifiers
3945
3946         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3947         (pluginGetProperty):
3948         (pluginSetProperty):
3949         (testDOMAccess):
3950         (stringVariantToIdentifier):
3951         (int32VariantToIdentifier):
3952         (doubleVariantToIdentifier):
3953         (variantToIdentifier):
3954         (testIdentifierToString):
3955         (testIdentifierToInt):
3956         (testCallback):
3957         (getURL):
3958         (removeDefaultMethod):
3959         (getURLNotify):
3960         (testInvokeDefault):
3961         (destroyStream):
3962         (testEnumerate):
3963         (testGetIntIdentifier):
3964         (testGetProperty):
3965         (testEvaluate):
3966         (testGetPropertyReturnValue):
3967         (pluginInvoke):
3968         (pluginInvokeDefault):
3969         (pluginInvalidate):
3970         (pluginAllocate):
3971         (pluginDeallocate):
3972         (handleCallback):
3973
3974 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
3975
3976         Rubber stamped by Darin Adler.
3977
3978         Add set-webkit-configuration support for wx port, and centralize
3979         build dir location setting.
3980
3981         http://bugs.webkit.org/show_bug.cgi?id=17790
3982
3983         * wx/browser/browser.bkl:
3984         * wx/build-wxwebkit:
3985
3986 2008-03-15  Darin Adler  <darin@apple.com>
3987
3988         * Scripts/commit-log-editor: Include the name line of the change log entry.
3989         A long time ago I designed this script to not include the name because I
3990         thought it was redundant (same as the name of the person checking in), but
3991         nowadays it's more common for someone to check something in done by someone
3992         else.
3993
3994         * Scripts/do-webcore-rename: Added some more planned renames and removed
3995         some that were already done "by hand".
3996
3997 2008-03-13  Brent Fulgham  <bfulgham@gmail.com>
3998
3999         Reviewed by Darin Adler.
4000
4001         Correct paths to vsprops files so they use the environment
4002         variable, rather than hard-coded path.
4003         http://bugs.webkit.org/show_bug.cgi?id=17797.
4004
4005         * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.
4006
4007 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
4008
4009         VSExpress build fix
4010
4011         * WinLauncher/WinLauncher.vcproj:
4012
4013 2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>
4014
4015         Reviewed by Alp Toker.
4016
4017         Run testkjs in the correct productsDir in the GTK+ port.
4018
4019         * Scripts/run-javascriptcore-tests:
4020
4021 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
4022
4023         Reviewed by Adam Roben.
4024
4025         Enabled WinLauncher as part of normal Windows build.
4026         http://bugs.webkit.org/show_bug.cgi?id=17715.
4027
4028         * WinLauncher/WinLauncher.vcproj: Update to use vsprops so that
4029           it can find the proper libraries to link against.
4030
4031 2008-03-10  Julien Chaffraix  <julien.chaffraix@gmail.com>
4032
4033         Reviewed and landed by Darin Adler.
4034
4035         http://bugs.webkit.org/show_bug.cgi?id=17581
4036         Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
4037
4038         Remove the previous warning which occurs when the --random option is used.
4039
4040         * Scripts/run-webkit-tests: verify that $component[0] is defined before checking for
4041         its inequality
4042
4043 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
4044
4045         Reviewed by Darin Adler.
4046
4047         Done with Lars.
4048
4049         Ported the netscape test plugin to QWebPluginFactory.
4050
4051         * DumpRenderTree/qt/DumpRenderTree.cpp:
4052         (WebCore::WebPage::WebPage):
4053         * DumpRenderTree/qt/main.cpp:
4054         * DumpRenderTree/qt/testplugin.cpp:
4055         (TestPlugin::plugins):
4056         (TestPlugin::create):
4057         * DumpRenderTree/qt/testplugin.h:
4058
4059 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
4060
4061         Stop Windows build if an error occurs in a prior project.
4062
4063         Rubber stamped by Darin Adler.
4064
4065         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
4066         * DumpRenderTree/win/DumpRenderTree.vcproj:
4067         * DumpRenderTree/win/ImageDiff.vcproj:
4068         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4069
4070 2008-03-08  Julien Chaffraix  <julien.chaffraix@gmail.com>
4071
4072         Reviewed by Mark Rowe.
4073
4074         DRT build fix for Tiger.
4075
4076         * DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
4077
4078 2008-03-07  Mark Rowe  <mrowe@apple.com>
4079
4080         Reviewed by Oliver Hunt.
4081
4082         Fix WebKit build with GCC 4.2.
4083
4084         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
4085
4086 2008-03-07  Stephanie Lewis <slewis@apple.com>
4087
4088         Reviewed by Oliver.
4089
4090         Add Windows part of <rdar://problem/5693690>
4091
4092         * DumpRenderTree/win/DumpRenderTree.cpp:
4093         (dump):
4094         (main):
4095
4096 2008-03-07  Alp Toker  <alp@atoker.com>
4097
4098         Back out the r30818, r30819 build fix attempts now the GTK+ build
4099         server has been upgraded.
4100
4101         * Scripts/webkitdirs.pm:
4102
4103 2008-03-07  Stephanie Lewis <slewis@apple.com>
4104
4105         Reviewed by Geoff.
4106
4107         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
4108
4109         * DumpRenderTree/mac/DumpRenderTree.mm:
4110         (dump): push EOF to stderr after every test
4111         * Scripts/run-webkit-tests: collect stderr output and print it
4112
4113 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
4114
4115         Get pdevenv working with Visual Studio Express.
4116
4117         Reviewed by Adam.
4118
4119         * Scripts/pdevenv:
4120
4121 2008-03-06  Adele Peterson  <adele@apple.com>
4122
4123         Reviewed by Darin Adler.
4124
4125         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
4126
4127         * DumpRenderTree/mac/UIDelegate.mm:
4128         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
4129         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
4130          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
4131
4132 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
4133
4134         Reviewed by Adam Roben.
4135
4136         Bug 17691: REGRESSION: FindSafari doesn't work
4137         http://bugs.webkit.org/show_bug.cgi?id=17691
4138
4139         Swap my change from r30394 to use the Release libraries instead of Debug
4140         since some machines don't have the Debug version.
4141
4142         * FindSafari/FindSafari.vcproj:
4143
4144 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
4145
4146         Reviewed by Sam and Tim.
4147
4148         <rdar://5631450> Drosera: breakpoint indicators disappear after the
4149         script is finished running.
4150         - If there is a pre-existing breakpoint on a line when the file is
4151         updated we need to redraw it.
4152
4153         * Drosera/debugger.js:
4154
4155 2008-03-06  Brady Eidson  <beidson@apple.com>
4156
4157         Tiger build fix...?
4158
4159         * DumpRenderTree/mac/WatchdogMac.mm:
4160
4161 2008-03-06  Brady Eidson  <beidson@apple.com>
4162
4163         Reviewed by Darin
4164
4165         Added a cross-platform Watchdog thread to DRT.
4166
4167         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
4168         main thread hangs still affect DRT.
4169
4170         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
4171         and true deadlocks can be caught.
4172
4173         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
4174         `sample` available, the Mac implementation of this hook samples the process before it is killed.
4175
4176         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
4177
4178         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4179         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
4180
4181         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
4182         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
4183
4184         * DumpRenderTree/Watchdog.cpp: Added.
4185         (Watchdog::Watchdog):
4186         (Watchdog::~Watchdog):
4187         (Watchdog::start):
4188         (Watchdog::stop):
4189         (Watchdog::checkIn):
4190         (Watchdog::setWatchdogInterval):
4191         (Watchdog::handleHang):
4192         (Watchdog::watchdogThreadStart):
4193         (Watchdog::watchdogThread):
4194         * DumpRenderTree/Watchdog.h: Added.
4195
4196         * DumpRenderTree/mac/WatchdogMac.h: Added.
4197         * DumpRenderTree/mac/WatchdogMac.mm: Added.
4198         (WatchdogMac::handleHang): Sample the process and write it out to a file
4199
4200         * DumpRenderTree/mac/DumpRenderTree.mm:
4201         (dumpRenderTree): Setup and start the watchdog before running any tests
4202         (runTest): Checkin with the watchdog after each test
4203
4204 2008-03-05  Alp Toker  <alp@atoker.com>
4205
4206         Attempt to get the autotools build working again on the bot with
4207         build-webkit.
4208
4209         Force the use of /bin/bash since we seem to have bash-isms in the
4210         configure script right now.
4211
4212         * Scripts/webkitdirs.pm:
4213
4214 2008-03-05  Alp Toker  <alp@atoker.com>
4215
4216         Re-attempt to switch to the autotools build system for GTK+.
4217
4218         Change scripts to continue when distclean fails.
4219
4220         * Scripts/webkitdirs.pm:
4221
4222 2008-03-05  Alp Toker  <alp@atoker.com>
4223
4224         Force qmake for the GTK+ build until we get the build bot to succeed
4225         with autotools (currently dies at make distclean)
4226
4227         * Scripts/webkitdirs.pm:
4228
4229 2008-03-04  Alp Toker  <alp@atoker.com>
4230
4231         Reviewed by Mark Rowe.
4232
4233         Switch the default GTK+ build system from qmake to autotools.
4234
4235         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
4236
4237         * Scripts/build-webkit:
4238         * Scripts/run-launcher:
4239         * Scripts/run-webkit-tests:
4240         * Scripts/webkitdirs.pm:
4241
4242 2008-03-04  Sam Weinig  <sam@webkit.org>
4243
4244         Reviewed by Darin Adler.
4245
4246         * Scripts/do-webcore-rename: Update renaming plan.
4247
4248 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
4249
4250         Reviewed by Alp Toker.
4251
4252         Remove some needless LIBS.
4253
4254         * GNUmakefile.am:
4255
4256 2008-03-02  Alp Toker  <alp@atoker.com>
4257
4258         Reviewed by Mark Rowe.
4259
4260         Split the WebKit GTK+ build out of the WebCore build and change the
4261         shared object name to match the package name.
4262
4263         * GNUmakefile.am:
4264
4265 2008-03-01  Mark Rowe  <mrowe@apple.com>
4266
4267         Reviewed by Tim Hatcher.
4268
4269         Update Xcode configuration to support building debug and release from the mysterious future.
4270
4271         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4272
4273 2008-02-29  David Kilzer  <ddkilzer@apple.com>
4274
4275         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
4276
4277         Reviewed by Dan.
4278
4279         Originally broken in r26838.
4280
4281         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
4282         not local, unused @args variable.
4283
4284 2008-02-29  David Kilzer  <ddkilzer@apple.com>
4285
4286         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
4287
4288         <http://bugs.webkit.org/show_bug.cgi?id=15754>
4289
4290         Reviewed by Geoff and Darin.
4291
4292         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
4293         then removing that path from all file:/// URLs in the WebArchive output so these tests
4294         would pass no matter where they were run.
4295
4296         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
4297         current working directory, but the WebArchive does not.  This left the current working
4298         directory in all file:/// URLs in the test output, and thus all tests failed, for any
4299         developer that used symlinks to get to their WebKit source directory.
4300
4301         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
4302         remove the current working directory path (no matter what it is) after "file://" but
4303         before "/LayoutTests/".
4304
4305         * DumpRenderTree/mac/DumpRenderTree.mm:
4306         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
4307         current working directory as described above.
4308         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
4309         calls to normalizeWebResourceURL().
4310         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
4311         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
4312
4313 2008-02-26  Robin Dunn <robin@alldunn.com>
4314
4315         Reviewed by Kevin Ollivier.
4316
4317         Improvements to the wx build script.
4318
4319         http://bugs.webkit.org/show_bug.cgi?id=17492
4320
4321         * wx/build-wxwebkit:
4322         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
4323         - Allow the build script to properly find wxPython includes under different setups
4324         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
4325
4326 2008-02-26  Timothy Hatcher  <timothy@apple.com>
4327
4328         Reviewed by Darin Adler.
4329
4330         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
4331         64-bit architectures easy. Combine the two flags to build 4-way universal.
4332         * Makefile: Add