Fix Windows debug build for opensource developers.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2
3         Reviewed by Oliver.
4
5         Enable SVG Fonts support by default.
6
7         * Scripts/build-webkit:
8
9 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
10
11         Reviewed by Adam.
12
13         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
14         DRT doesn't handle platform specific pixel test results correctly.
15
16         <test>-expected.txt files and <test>-expected.png files may now live
17         in different directories (ie. a cross-platform <test>-expected.txt file
18         and a platform-specific <test>-expected.png file).
19
20         * Scripts/run-webkit-tests:
21
22 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
23
24         Reviewed by Darin.
25
26         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
27         DRT did not correctly handle printing the '\0' char.  Now it does.
28
29         * DumpRenderTree/win/DumpRenderTree.cpp:
30         (dumpFramesAsText):
31         (dump):
32
33 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
34
35         Reviewed by Lars.
36
37         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
38         
39
40         * DumpRenderTree/qt/main.cpp:
41         * DumpRenderTree/qt/testplugin.cpp:
42         * DumpRenderTree/qt/testplugin.h:
43
44 2008-01-05  Mark Rowe  <mrowe@apple.com>
45
46         Reviewed by Alp Toker.
47
48         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
49
50         * DumpRenderTree/gtk/DumpRenderTree.cpp:
51         (processWork): Process pending work.
52         (webViewLoadFinished): Schedule processing of pending work.
53         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
54
55 2008-01-05  Darin Adler  <darin@apple.com>
56
57         * Scripts/do-webcore-rename: Some more renaming plans.
58
59 2008-01-04  Alice Liu  <alice.liu@apple.com>
60
61         Reviewed by Alexey and Darin.
62
63         Adding "home" and "end" to DRT's keydown since
64         DOM key events can't handle keyIdentifiers at this point. 
65
66         * DumpRenderTree/mac/EventSendingController.mm:
67         (-[EventSendingController keyDown:withModifiers:]):
68         * DumpRenderTree/win/EventSender.cpp:
69         (keyDownCallback):
70
71 2008-01-04  Lars Knoll  <lars@trolltech.com>
72
73         Reviewed by Simon.
74
75         fix DRT after the changes to QWebPage.
76         
77         The great thing is that we actually don't have
78         any regressions from the QWebPage change :)
79         
80
81         * DumpRenderTree/qt/DumpRenderTree.cpp:
82         (WebCore::DumpRenderTree::DumpRenderTree):
83
84 2008-01-04  Lars Knoll  <lars@trolltech.com>
85
86         Reviewed by Simon.
87
88         make QWebPage a QObject and get things to compile.
89         
90         Nothing works currently though.
91         
92
93         * DumpRenderTree/qt/DumpRenderTree.cpp:
94         (WebCore::DumpRenderTree::DumpRenderTree):
95
96 2008-01-04  Lars Knoll  <lars@trolltech.com>
97
98         Reviewed by Simon.
99
100         take a QString as identifier in QWebFrame::addToJSWindowObject.
101
102         * DumpRenderTree/qt/DumpRenderTree.cpp:
103         (WebCore::DumpRenderTree::initJSObjects):
104
105 2008-01-04  Alp Toker  <alp@atoker.com>
106
107         GTK+ DRT build fix for breakage introduced in r29149.
108
109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
110         (LayoutTestController::execCommand):
111
112 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
113
114         Reviewed by Darin.
115
116         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
117
118         Added layoutTestController.execCommand to access editor commands that are not available
119         via document.execCommand.
120
121         * DumpRenderTree/LayoutTestController.cpp:
122         (execCommandCallback):
123         (LayoutTestController::staticFunctions):
124         * DumpRenderTree/LayoutTestController.h:
125         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
126         (LayoutTestController::execCommand):
127         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
128         (LayoutTestController::queueLoad):
129         (LayoutTestController::execCommand):
130
131 2008-01-03  Alice Liu  <alice.liu@apple.com>
132
133         Reviewed by Darin, Mitz.
134
135         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
136
137         the clickcount should not increase if the last click was at a different location.  it's a new click.
138
139         * DumpRenderTree/mac/DumpRenderTree.mm:
140         (runTest):
141         * DumpRenderTree/mac/EventSendingController.h:
142         * DumpRenderTree/mac/EventSendingController.mm:
143         (-[EventSendingController mouseDown]):
144         (-[EventSendingController mouseUp]):
145
146 2008-01-03  Darin Adler  <darin@apple.com>
147
148         Reviewed by Adam.
149
150         * Scripts/update-webkit: Make this work a little better for the people at Apple
151         who have a directory named Internal.
152
153 2008-01-03  Adam Roben  <aroben@apple.com>
154
155         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
156
157         Rubberstamped by Mark.
158
159         * Scripts/update-webkit-auxiliary-libs:
160
161 2008-01-03  Adam Roben  <aroben@apple.com>
162
163         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
164
165         http://bugs.webkit.org/show_bug.cgi?id=15663
166
167         Added a fuzz factor into the Last-Modified comparison for downloading
168         WebKitAuxiliaryLibrary.zip.
169
170         The zip file is served from a set of mirrors who give Last-Modified
171         times that are off by 1-3 seconds from each other. This was causing
172         the build bots to redownload WebKitAuxiliaryLibrary for every build,
173         which would then cause all of WebCore to rebuild each time.
174
175         Reviewed by Mark.
176
177         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
178         at least 30 seconds newer than the old one -- otherwise we assume that
179         the difference in time is due to the mirrors being slightly offset
180         from each other.
181         (sub lastModifiedToUnixTime): Added.
182
183 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
184
185         Windows build fix.
186
187         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
188
189 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
190
191         Reviewed by Lars.
192
193         Moved QWebPage::open to QWebFrame::load and added setHtml.
194         
195
196         * DumpRenderTree/qt/DumpRenderTree.cpp:
197         (WebCore::DumpRenderTree::open):
198
199 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
200
201         Reviewed by Lars.
202
203         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
204         
205
206         * DumpRenderTree/qt/DumpRenderTree.cpp:
207         (WebCore::DumpRenderTree::DumpRenderTree):
208
209 2008-01-02  Sam Weinig  <sam@webkit.org>
210
211         * Scripts/do-webcore-rename: Yet more renaming ideas.
212
213 2008-01-02  Darin Adler  <darin@apple.com>
214
215         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
216
217 2008-01-02  Alice Liu  <alice.liu@apple.com>
218
219         Reviewed by Sam Weinig.
220
221         fixing assertion hit with editing/selection/move-begin-end.html
222
223         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
224         * DumpRenderTree/win/DumpRenderTree.vcproj:
225         * DumpRenderTree/win/EventSender.cpp:
226         (keyDownCallback):
227         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
228
229 2008-01-02  Darin Adler  <darin@apple.com>
230
231         * Scripts/do-webcore-rename: Some more name change plans.
232
233 2008-01-02  Alice Liu  <alice.liu@apple.com>
234
235         Reviewed by Maciej.
236
237         Added handling for page up and page down in EventSender
238
239         * DumpRenderTree/mac/EventSendingController.mm:
240         (-[EventSendingController keyDown:withModifiers:]):
241         * DumpRenderTree/win/EventSender.cpp:
242         (keyDownCallback):
243
244 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
245
246         Reviewed by Darin.
247
248         Fix fast/events/arrow-keys-on-body.html for real.
249
250         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
251
252 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
253
254         Reviewed by Darin.
255
256         http://bugs.webkit.org/show_bug.cgi?id=16674
257         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
258
259         * Scripts/run-launcher:
260
261 2007-12-31  Darin Adler  <darin@apple.com>
262
263         Suggested by Antti.
264
265         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
266         we get it installed on the build bots.
267
268 2007-12-30  Eric Seidel  <eric@webkit.org>
269
270         Reviewed by Sam.
271
272         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
273
274 2007-12-29  Darin Adler  <darin@apple.com>
275
276         Reviewed by Oliver.
277
278         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
279           leak bot shows createCStringFromNPVariant result leaking
280
281         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
282         (pluginInvoke): Added a missing free.
283
284 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
285
286         Reviewed by Alp Toker.
287
288         http://bugs.webkit.org/show_bug.cgi?id=16390
289         Use autotools or GNU make as the build system for the GTK port
290
291         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
292         * GNUmakefile.am: Added.
293
294 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
295
296         Reviewed by Oliver.
297
298         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
299
300         * DumpRenderTree/win/EventSender.cpp:
301         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
302         of 1, even though WebKit currently ignores it.
303
304 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
305
306         wx buildbot fix. Update libpng dl script to the latest version.
307
308         * wx/install-unix-extras:
309
310 2007-12-22  Antti Koivisto  <antti@apple.com>
311
312         Fix a typo.
313
314         * Scripts/webkitdirs.pm:
315
316 2007-12-21  Sam Weinig  <sam@webkit.org>
317
318         Reviewed by Mark Rowe.
319
320         - Disable the back/forward cache using the new WebPreferences API
321           instead of through the BackForwardList.  This makes us match what
322           we do on Windows.
323
324         * DumpRenderTree/mac/DumpRenderTree.mm:
325         (createWebViewAndOffscreenWindow):
326         (setDefaultsToConsistentValuesForTesting):
327
328 2007-12-21  Dan Bernstein  <mitz@apple.com>
329
330         Reviewed by Mark Rowe.
331
332         - disable the back/forward cache in Windows DumpRenderTree. It is
333           already disabled in Mac DumpRenderTree.
334
335         * DumpRenderTree/win/DumpRenderTree.cpp:
336         (initializePreferences):
337
338 2007-12-13  Antti Koivisto  <antti@apple.com>
339
340         Reviewed by Darin and Steve.
341         
342         - check for QuickTime SDK on Windows.
343         - build media support on Windows by default
344
345         * Scripts/build-webkit:
346         * Scripts/webkitdirs.pm:
347
348 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
349
350         Build script fix for buildbot.
351
352         * wx/build-wxwebkit:
353
354 2007-12-20  Eric Seidel  <eric@webkit.org>
355
356         Reviewed by mjs.
357
358         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
359
360 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
361
362         Reviewed by Steve.
363
364         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
365         WebKit.
366
367         - Drosera and Safari need to use the same ProgIDs in order for
368         CoCreateInstance to work properly.  The most robust way to do this is
369         for WebKit to dynamically publish those ProgIDs.
370
371         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
372         (DebuggerClient::createWebViewWithRequest):
373         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
374         statics.
375         (Drosera::initUI):
376         (Drosera::attach):
377         (Drosera::attemptToCreateServerConnection):
378         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
379         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
380         make use of the published ProgIDs.
381         (ServerConnection::attemptToCreateServerConnection):
382
383 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
384
385         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
386         - Build bot and leak fix.
387
388         * DumpRenderTree/LayoutTestController.cpp:
389         (pathToLocalResourceCallback):
390
391 2007-12-19  David Kilzer  <ddkilzer@apple.com>
392
393         Make svn-apply/svn-unapply work with patches from git-format-patch.
394
395         Reviewed by Darin.
396
397         * Scripts/svn-apply:
398         (patch): If 'Index:' can't be found in the text passed in, print it
399         out with a warning and return early.
400         * Scripts/svn-unapply:
401         (patch): Ditto.
402
403 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
404
405         Reviewed by Alp Toker.
406
407         Build related fixes.
408
409         * wx/build-wxwebkit:
410         - Check to make sure the user is running a supported wx port
411         - More robust checks for Cygwin
412         - Only run install-unix-extras on Mac, it's not the right solution
413           for Linux distros.
414         - Remove outdated Linux instructions after successful build
415         - Clean Bakefile-generated files during a clean operation
416
417 2007-12-18  Darin Adler  <darin@apple.com>
418
419         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
420
421 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
422
423         Add script to run Drosera as part of the nightly.
424         
425         Reviewed by Kevin M.
426
427         * Scripts/run-drosera.cmd: Added.
428
429 2007-12-18  Darin Adler  <darin@apple.com>
430
431         * Scripts/do-webcore-rename: Remove a stray K.
432
433 2007-12-18  Darin Adler  <darin@apple.com>
434
435         * Scripts/do-webcore-rename: Plan more renaming.
436
437 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
438
439         Reviewed by Alp Toker.
440
441         http://bugs.webkit.org/show_bug.cgi?id=16042
442         [GTK] Eliminate webkit_init()
443
444         Moving webkit initialization to WebView class init.
445
446         * DumpRenderTree/gtk/DumpRenderTree.cpp:
447         (main):
448         * GtkLauncher/main.c:
449         (main):
450
451 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
452
453         Reviewed by Alp Toker.
454
455         http://bugs.webkit.org/show_bug.cgi?id=13542
456         gdklauncher doesnt change URL in adress GTKEntry.
457
458         * GtkLauncher/main.c:
459         (load_commit_cb): added
460         (title_change_cb):
461         (create_browser):
462
463 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
464
465         Reviewed by Adam Roben.
466
467         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
468
469         * FindSafari/FindSafari.cpp:
470         (_tmain):
471
472 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
473
474         Reviewed by Adam Roben.
475
476         http://bugs.webkit.org/show_bug.cgi?id=16315
477         FindSafari needs a path-only option.
478
479         * FindSafari/FindSafari.cpp:
480         (_tmain):
481
482 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
483
484         Reviewed by Darin.
485
486         http://bugs.webkit.org/show_bug.cgi?id=16462
487         REGRESSION: access keys broken on Windows
488
489         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
490         if Alt is pressed.
491
492 2007-12-15  Sam Weinig  <sam@webkit.org>
493
494         Reviewed by Mark Rowe.
495
496         Fix urlSuitableForTestResult to correctly identify wstring::npos as
497         the case when wstring.find doesn't find anything.
498
499         * DumpRenderTree/win/DumpRenderTree.cpp:
500         (urlSuitableForTestResult):
501
502 2007-12-15  Alp Toker  <alp@atoker.com>
503
504         GTK+ DRT build fix for GLib < 2.14.
505
506         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
507         (LayoutTestController::setWaitToDump):
508
509 2007-12-05  Mark Rowe  <mrowe@apple.com>
510
511         Reviewed by Alp Toker.
512
513         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
514         many layout tests from hanging while waiting on user responses to dialogs.
515
516         * DumpRenderTree/gtk/DumpRenderTree.cpp:
517         (invalidateAnyPreviousWaitToDumpWatchdog):
518         (webViewScriptAlert):
519         (webViewScriptPrompt):
520         (webViewScriptConfirm):
521         (main):
522         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
523         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
524         (waitToDumpWatchdogFired):
525         (LayoutTestController::setWaitToDump):
526
527 2007-12-05  Mark Rowe  <mrowe@apple.com>
528
529         Reviewed by Alp Toker.
530
531         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
532
533         * DumpRenderTree/gtk/DumpRenderTree.cpp:
534         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
535         (dump):
536         (runTest):
537         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
538         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
539         work queue is empty.
540         (webViewWindowObjectCleared): Set up window.layoutTestController.
541         (webViewConsoleMessage): Match the console message format expected by the layout test results.
542         (main): Hook up the new signals.
543         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
544         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
545         dumping multiple times.
546         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
547         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
548
549 2007-12-14  Anders Carlsson  <andersca@apple.com>
550
551         Reviewed by Brady.
552
553         Assert that a web frame that's loading a resource always has either a data source or 
554         a provisional data source.
555         
556         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
557         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
558
559 2007-12-14  Darin Adler  <darin@apple.com>
560
561         - fix mistake causing nearly all tests to fail on Windows
562
563         * DumpRenderTree/win/UIDelegate.cpp:
564         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
565         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
566
567         * DumpRenderTree/mac/UIDelegate.mm:
568         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
569         than passing the entire message.
570
571 2007-12-14  Darin Adler  <darin@apple.com>
572
573         - fix Tiger build
574
575         * DumpRenderTree/mac/UIDelegate.mm:
576         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
577         new-to-Leopard methods.
578
579 2007-12-14  Darin Adler  <darin@apple.com>
580
581         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
582         since it now triggers unwanted icon loading. We only had it because we implemented "all"
583         delegate methods here.
584
585 2007-12-14  Anders Carlsson  <andersca@apple.com>
586
587         Reviewed by Darin and Geoff.
588
589         <rdar://problem/5619295> 
590         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
591         
592         Add property getting methods to the plug-in.
593         
594         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
595         (pluginInvoke):
596
597 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
598
599         Reviewed by Darin.
600
601         - Layout test fix for mac. When dumped to the console local file paths
602         now only show the name of the resource not the whole path.  This is to
603         make the results machine and OS independent.
604
605         * DumpRenderTree/mac/UIDelegate.mm:
606         (-[UIDelegate webView:addMessageToConsole:]):
607
608 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
609
610         Reviewed by Adam.
611
612         - Layout tests fix.  We need a way to remove machine-dependent
613         information from paths in layout test results. The UIDelegate now does
614         this.
615
616         * DumpRenderTree/DumpRenderTree.h:
617         * DumpRenderTree/win/DumpRenderTree.cpp:
618         (urlSuitableForTestResult):
619         * DumpRenderTree/win/DumpRenderTreeWin.h:
620         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
621         * DumpRenderTree/win/UIDelegate.cpp:
622         (UIDelegate::webViewAddMessageToConsole):
623
624 2007-12-13  Alp Toker  <alp@atoker.com>
625
626         Build fix for DRT breakage introduced in r28690.
627
628         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
629         (LayoutTestController::pathToLocalResource):
630
631 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
632
633         Reviewed by Alice and Sam.
634
635         - <rdar://5621435> Need a way to specify local resources (being loaded
636         from HTTP tests) on Windows.
637         - Implemented pathToLocalResource which exposes the functionality of
638         converting a given unix path to the correct location on Windows.
639
640         * DumpRenderTree/LayoutTestController.cpp:
641         (pathToLocalResourceCallback):
642         (LayoutTestController::staticFunctions):
643         * DumpRenderTree/LayoutTestController.h:
644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
645         (LayoutTestController::pathToLocalResource):
646         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
647         (LayoutTestController::pathToLocalResource):
648
649 2007-12-12  Anders Carlsson  <andersca@apple.com>
650
651         Reviewed by Sam.
652
653         <rdar://problem/5132003>
654         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
655
656         * DumpRenderTree/win/DumpRenderTree.cpp:
657         (main):
658         Set the resource load delegate.
659         
660         * DumpRenderTree/win/DumpRenderTree.vcproj:
661         
662         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
663         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
664
665 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
666
667         Reviewed by Adam Roben.
668
669         Fix conversion from double to LPARAM in dispatchMessage().
670
671         * DumpRenderTree/win/EventSender.cpp:
672         (dispatchMessageCallback):
673
674 2007-12-11  Dan Bernstein  <mitz@apple.com>
675
676         Reviewed by Mark Rowe and Sam Weinig too!
677
678         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
679           fonts DumpRenderTree registers.
680
681         * DumpRenderTree/win/DumpRenderTree.cpp:
682         (initialize):
683
684 2007-12-11  Brady Eidson  <beidson@apple.com>
685
686         Reviewed by Anders
687
688         Make DumpRenderTree on mac use its own path for Databases testing
689
690         * DumpRenderTree/mac/DumpRenderTree.mm:
691         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
692           for future DRT-only use, then use it to construct the Databases path and set that default
693
694 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
695
696         Reviewed by Darin.
697
698         <rdar://problem/5535636>
699         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
700
701         http://bugs.webkit.org/show_bug.cgi?id=13916
702         JavaScript detects Tab as a character input on a textfield validation
703
704         * DumpRenderTree/mac/EventSendingController.mm:
705         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
706         Dispatch a keyup to better match what happens when a key is physically pressed.
707
708         * DumpRenderTree/win/EventSender.cpp:
709         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
710         returning from keyDown().
711         (getConstantCallback): Fixed a couple copy/paste mistakes.
712
713 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
714
715         Reviewed by Oliver.
716
717         - <rdar://5599845> Drosera: Does not show loal files in the file list
718         on the left side.
719
720         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
721         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
722         so the open source community can build.
723
724 2007-12-10  Brady Eidson  <beidson@apple.com>
725
726         Rubberstamped by Sam Weinig
727
728         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
729
730         * DumpRenderTree/mac/UIDelegate.mm:
731         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
732         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
733
734 2007-12-08  Oliver Hunt  <oliver@apple.com>
735
736         Reviewed by Sam W.
737
738         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
739         
740         Fixes <rdar://problem/5620249> Must disable SVG animation
741         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
742         
743         In order to allow finer grained control over the set of SVG features
744         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
745         distinct flags:
746         ENABLE_SVG_ANIMATION
747         ENABLE_SVG_FILTERS
748         ENABLE_SVG_FONTS
749         ENABLE_SVG_AS_IMAGE
750         ENABLE_SVG_USE
751         
752         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
753         
754         Script handles all the new build flags, and allows --svg-experimental
755         to automatically enable all features.
756
757         * Scripts/build-webkit:
758
759 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
760
761         Fix version parsing.
762
763         Rubber-stamped by Oliver.
764
765         * Drosera/win/Drosera.vcproj/auto-version.sh:
766
767 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
768
769         Build modifications for Drosera.
770
771         Reviewed by Adam.
772
773         * Drosera/DroseraWin.make: Added.
774         * Drosera/win/Drosera.vcproj/Drosera.rc:
775         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
776         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
777         * Drosera/win/Drosera.vcproj/VERSION: Added.
778         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
779
780 2007-12-06  Adam Roben  <aroben@apple.com>
781
782         Explicitly turn on the Mac font ascent hack on Windows
783
784         This keeps our font metrics matching those from Mac.
785
786         Reviewed by Hyatt.
787
788         * DumpRenderTree/win/DumpRenderTree.cpp:
789         (main):
790
791 2007-12-06  Anders Carlsson  <andersca@apple.com>
792
793         Rename main.c to main.cpp here too.
794         
795         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
796
797 2007-12-06  Sam Weinig  <sam@webkit.org>
798
799         Rubber stamped by Geoff.
800
801         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
802
803 2007-12-06  Darin Adler  <darin@apple.com>
804
805         * Scripts/do-webcore-rename: Some more renaming plans.
806
807 2007-12-06  Anders Carlsson  <andersca@apple.com>
808
809         Restore implementation of testGetIntIdentifier that was accidentally
810         removed somehow (possibly when I made PluginObject be a cpp file).
811         
812         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
813         (pluginInvoke):
814
815 2007-12-05  Anders Carlsson  <andersca@apple.com>
816
817         Make the entry points extern "C".
818         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
819         
820 2007-12-05  Anders Carlsson  <andersca@apple.com>
821
822         C++ warning fixes.
823         
824         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
825         (NPP_New):
826         (NPP_Destroy):
827         (NPP_SetWindow):
828         (NPP_NewStream):
829         (NPP_HandleEvent):
830         (NPP_URLNotify):
831         (NPP_GetValue):
832
833 2007-12-05  Anders Carlsson  <andersca@apple.com>
834
835         Add the .cpp files to the TestNetscapePlugIn target.
836
837         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
838
839 2007-12-05  Anders Carlsson  <andersca@apple.com>
840
841         Reviewed by Geoff.
842         
843         Rename the TestNetscapePlugIn .c files to be .cpp.
844
845         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
846         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
847         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
848         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
849         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
850         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
851         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
852         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
853
854 2007-12-05  Adam Roben  <aroben@apple.com>
855
856         Fix case of keypresses from the Windows implementation of eventSender.keyDown
857
858         This fixes several regression tests.
859
860         Reviewed by Alice.
861
862         * DumpRenderTree/win/EventSender.cpp:
863         (keyDownCallback): Virtual keycodes for ASCII characters are always
864         uppercase, so we need to check the case of the original character
865         passed in to eventSender.keyDown.
866
867 2007-12-05  Adam Roben  <aroben@apple.com>
868
869         Learn from Tim's mistakes
870
871         * DumpRenderTree/win/DumpRenderTree.cpp:
872         (runTest): Reset the authorAndUserStylesEnabled preference for each
873         test.
874
875 2007-12-05  Alp Toker  <alp@atoker.com>
876
877         Reviewed by Mark Rowe.
878
879         Initialize GTK+ and WebKit so the tests can run.
880
881         Reorganize the headers a little.
882
883         * DumpRenderTree/gtk/DumpRenderTree.cpp:
884         (main):
885
886 2007-12-04  Anders Carlsson  <andersca@apple.com>
887
888         Remove IWebScriptScope include.
889         
890         * Drosera/win/DebuggerDocumentPlatform.cpp:
891
892 2007-12-04  Sam Weinig  <sam@webkit.org>
893
894         Rubber stamped by Mark Rowe.
895
896         Define CF as platform for mac and revert r28409
897
898         * DumpRenderTree/DumpRenderTree.h:
899         * DumpRenderTree/mac/DumpRenderTreeMac.h:
900
901 2007-12-04  Sam Weinig  <sam@webkit.org>
902
903         Define CF as platform for windows.
904
905         Reviewed by Adam Roben.
906
907         * DumpRenderTree/win/DumpRenderTreeWin.h:
908
909 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
910
911         Reviewed by Adam and Darin.
912
913         - Removed a needless BSTR cleanup.
914
915         * Drosera/win/DebuggerDocumentPlatform.cpp:
916         (DebuggerDocument::getPlatformCurrentFunctionStack):
917
918 2007-11-27  Adam Roben  <aroben@apple.com>
919
920         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
921
922         Reviewed by Maciej.
923
924         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
925         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
926
927 2007-12-04  Alp Toker  <alp@atoker.com>
928
929         Prospective Win DRT build fix.
930
931         * DumpRenderTree/DumpRenderTree.h:
932
933 2007-12-04  Alp Toker  <alp@atoker.com>
934
935         Fix a clobbered copyright header.
936
937         * DumpRenderTree/gtk/DumpRenderTree.cpp:
938
939 2007-12-04  Xan Lopez  <xan@gnome.org>
940
941         Reviewed by Alp Toker.
942
943         http://bugs.webkit.org/show_bug.cgi?id=15561
944         GTK port needs DumpRenderTree implementation
945
946         Start work on the GTK+ DRT.
947
948         This does not work yet, and there are a few lingering style issues
949         (nothing major) but this patch has been stuck in the bug tracker for
950         too long already.
951
952         * DumpRenderTree/DumpRenderTree.h:
953         * DumpRenderTree/gtk: Added.
954         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
955         (autocorrectURL):
956         (shouldLogFrameLoadDelegates):
957         (dumpFrameScrollPosition):
958         (displayWebView):
959         (appendString):
960         (dumpFramesAsText):
961         (dumpRenderTreeAsText):
962         (dump):
963         (runTest):
964         (main):
965         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
966         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
967         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
968         (GCController::collect):
969         (GCController::collectOnAlternateThread):
970         (GCController::getJSObjectCount):
971         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
972         (LayoutTestController::~LayoutTestController):
973         (LayoutTestController::addDisallowedURL):
974         (LayoutTestController::clearBackForwardList):
975         (LayoutTestController::copyDecodedHostName):
976         (LayoutTestController::copyEncodedHostName):
977         (LayoutTestController::display):
978         (LayoutTestController::keepWebHistory):
979         (LayoutTestController::notifyDone):
980         (LayoutTestController::queueBackNavigation):
981         (LayoutTestController::queueForwardNavigation):
982         (LayoutTestController::queueLoad):
983         (LayoutTestController::queueReload):
984         (LayoutTestController::queueScript):
985         (LayoutTestController::setAcceptsEditing):
986         (LayoutTestController::setCustomPolicyDelegate):
987         (LayoutTestController::setMainFrameIsFirstResponder):
988         (LayoutTestController::setTabKeyCyclesThroughElements):
989         (LayoutTestController::setUseDashboardCompatibilityMode):
990         (LayoutTestController::setUserStyleSheetEnabled):
991         (LayoutTestController::setUserStyleSheetLocation):
992         (LayoutTestController::setWindowIsKey):
993         (LayoutTestController::setWaitToDump):
994         (LayoutTestController::windowCount):
995         (LayoutTestController::setPrivateBrowsingEnabled):
996         (LayoutTestController::setAuthorAndUserStylesEnabled):
997         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
998         (JSStringCopyUTF8CString):
999         (LoadItem::invoke):
1000         (ReloadItem::invoke):
1001         (ScriptItem::invoke):
1002         (BackForwardItem::invoke):
1003
1004 2007-12-03  Sam Weinig  <sam@webkit.org>
1005
1006         Move JavaScriptCore thread testing code to pthread specific directory
1007         and remove the dependance on CoreFoundation by using WTF::HashSet.
1008
1009         Reviewed by Geoff and Oliver.
1010
1011         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1012         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1013         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1014         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1015         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1016         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1017         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1018         * DumpRenderTree/pthreads: Added.
1019         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1020         (javaScriptThreads):
1021         (runJavaScriptThread):
1022         (startJavaScriptThreads):
1023         (stopJavaScriptThreads):
1024
1025 2007-12-03  Andrew Bonventre  <andybons@google.com>
1026
1027         Reviewed by Darin Adler.
1028
1029         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1030         Symbol lookup menu broken in debugger view
1031
1032         * Drosera/debugger.js: Fixed javascript error where document property
1033         should have been used instead of contentDocument in switchFunction that
1034         was breaking the select symbol dropdown menu.  This is because
1035         window.frames will return a Window object and not a frame object like
1036         the author was originally expecting.
1037
1038 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1039
1040         Reviewed by Adam.
1041
1042         - <rdar://5618942> Drosera: Console window does not process everything
1043         correctly.
1044         - <rdar://5619005> Drosera: could be sped up by moving the 
1045         WebScriptScope stuff into the WebScriptCallFrame.
1046         - Now the console can correctly process objects and does not receive
1047         notifications from JavaScriptCore about the JavaScript in Drosera's
1048         own process.
1049
1050         * Drosera/win/DebuggerDocumentPlatform.cpp:
1051         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1052         (DebuggerDocument::platformValueForScopeVariableNamed):
1053
1054 2007-12-03  Stephanie  <slewis@apple.com>
1055
1056         Reviewed by Darin.
1057
1058         Check to see if we are building a debug root
1059
1060         * Scripts/check-for-global-initializers: 
1061
1062 2007-12-03  Dan Bernstein  <mitz@apple.com>
1063
1064         Reviewed by Darin Adler.
1065
1066         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1067
1068         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1069         (pluginInvoke):
1070
1071 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1072
1073         Reviewed by Oliver.
1074
1075         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1076         in a more fine-grained manner than eventSender.keyDown().
1077
1078         * DumpRenderTree/win/EventSender.cpp:
1079         (getConstantCallback):
1080         (dispatchMessageCallback):
1081
1082 2007-12-02  Darin Adler  <darin@apple.com>
1083
1084         * Scripts/do-webcore-rename: More planned renaming.
1085
1086 2007-12-02  Sam Weinig  <sam@webkit.org>
1087
1088         Rubber stamped by Anders.
1089
1090         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1091         more uniform results cross platform.
1092
1093         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1094         (-[NSURL _drt_descriptionSuitableForTestResult]):
1095
1096 2007-12-02  Sam Weinig  <sam@webkit.org>
1097
1098         Rubber stamped by Niko.
1099
1100         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1101
1102         * DumpRenderTree/win/DumpRenderTree.cpp:
1103         * DumpRenderTree/win/DumpRenderTree.vcproj:
1104         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1105         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1106         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1107         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1108
1109 2007-12-01  Alp Toker  <alp@atoker.com>
1110
1111         Reviewed by Adam Roben.
1112
1113         Make use of the newly introduced webkit.h convenience header.
1114
1115         * GtkLauncher/main.c:
1116
1117 2007-12-01  Adam Treat  <treat@kde.org>
1118
1119         Reviewed by Simon.
1120
1121         * Check to see if the directory exists and exit if not.
1122
1123         * DumpRenderTree/qt/main.cpp:
1124         (main):
1125
1126 2007-12-01  Adam Treat  <treat@kde.org>
1127
1128         Reviewed by Simon.
1129
1130         * Don't hide symbols when in Debug mode
1131         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1132
1133
1134         * DumpRenderTree/qt/main.cpp:
1135         (messageHandler):
1136
1137 2007-11-30  Alp Toker  <alp@atoker.com>
1138
1139         Reviewed by Adam Roben.
1140
1141         http://bugs.webkit.org/show_bug.cgi?id=15691
1142         [GTK] Public API does not follow GTK+ conventions
1143
1144         Refactor the WebKit/GTK+ public API. Changes:
1145           WebKitPage -> WebKitWebView
1146           WebKitFrame -> WebKitWebFrame
1147
1148         Public API source and header names have been updated to mirror the API
1149         changes.
1150
1151         The API is now kept in WebKit/gtk/WebView to match other ports in the
1152         same class such as Mac and Win.
1153
1154         * GtkLauncher/main.c:
1155         (activate_uri_entry_cb):
1156         (link_hover_cb):
1157         (title_change_cb):
1158         (progress_change_cb):
1159         (go_back_cb):
1160         (go_forward_cb):
1161         (create_browser):
1162         (main):
1163
1164 2007-11-30  Adam Roben  <aroben@apple.com>
1165
1166         Hopefully the final build fix
1167
1168         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1169         pull in WTF's assertion/logging functions.
1170
1171 2007-11-30  Adam Roben  <aroben@apple.com>
1172
1173         Another build fix
1174
1175         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1176         WebKit.lib.
1177
1178 2007-11-30  Adam Roben  <aroben@apple.com>
1179
1180         Debug build fix
1181
1182         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1183         configuration.
1184         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1185         projects.
1186         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1187         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1188         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1189
1190 2007-11-30  Sam Weinig  <sam@webkit.org>
1191
1192         Reviewed by Adam Roben.
1193
1194         Fix drawSelectionRect to actually draw the selection rect.
1195
1196         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1197         (drawSelectionRect):
1198
1199 2007-11-30  Darin Adler  <darin@apple.com>
1200
1201         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1202
1203 2007-11-30  Darin Adler  <darin@apple.com>
1204
1205         * Scripts/do-webcore-rename: Get ready for some future renaming.
1206
1207 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1208
1209         Reviewed by Adam.
1210
1211         - Removed some unnecessary functions and changed an unused return type. 
1212
1213         * Drosera/win/DebuggerClient.cpp:
1214         (registerConsoleClass):
1215         * Drosera/win/DebuggerClient.h:
1216         * Drosera/win/Drosera.cpp:
1217         (registerDroseraClass):
1218
1219 2007-11-28  Alp Toker  <alp@atoker.com>
1220
1221         Reviewed by Timothy Hatcher.
1222
1223         http://bugs.webkit.org/show_bug.cgi?id=16174
1224         [GTK] Use "URI" not "URL" in public API
1225
1226         Replace use of the term "URL" with "URI" in public headers,
1227         documentation and some internal code to match GLib/GTK+ convention.
1228
1229         This is now mentioned in the API guidelines:
1230           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1231
1232         * GtkLauncher/main.c:
1233         (activate_uri_entry_cb):
1234         (title_change_cb):
1235         (create_toolbar):
1236         (main):
1237
1238 2007-11-29  Anders Carlsson  <andersca@apple.com>
1239
1240         Reviewed by Sam.
1241
1242         <rdar://problem/5230478>
1243         FrameLoadDelegate callbacks are not dumped in DRT.
1244         
1245         * DumpRenderTree/win/DumpRenderTree.cpp:
1246         (shouldLogFrameLoadDelegates):
1247         (runTest):
1248         (main):
1249         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1250         (BSTRtoString):
1251         (descriptionSuitableForTestResult):
1252         (FrameLoadDelegate::QueryInterface):
1253         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1254         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1255         (FrameLoadDelegate::didCommitLoadForFrame):
1256         (FrameLoadDelegate::didFinishLoadForFrame):
1257         (FrameLoadDelegate::willCloseFrame):
1258         (FrameLoadDelegate::didClearWindowObject):
1259         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1260         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1261         * DumpRenderTree/win/FrameLoaderDelegate.h:
1262         (FrameLoadDelegate::windowScriptObjectAvailable):
1263         (FrameLoadDelegate::didFirstLayoutInFrame):
1264
1265 2007-11-29  Sam Weinig  <sam@webkit.org>
1266
1267         Reviewed by Anders.
1268
1269         Add database quota UIDelegates methods to DRT UIDelegate.
1270
1271         * DumpRenderTree/mac/UIDelegate.mm:
1272         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1273         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1274
1275 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1276
1277         Reviewed by Sam.
1278
1279         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1280         dying and vice versa.
1281         - This fix will allow Drosera and Safari to reconnect if either of them
1282         closes correctly, but does not fix the case where one of them dies
1283         silently.
1284
1285         * Drosera/win/ServerConnection.cpp:
1286         (ServerConnection::attemptToCreateServerConnection): Added a safety
1287         check, because it's possilbe to try to connect to a server that's dying.
1288         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1289         the server has died.
1290         * Drosera/win/ServerConnection.h: Added the new function and removed
1291         an unnecessary member.
1292
1293 2007-11-29  Anders Carlsson  <andersca@apple.com>
1294
1295         * DumpRenderTree/win/DumpRenderTree.vcproj:
1296         Add shlwapi.lib to all configurations.
1297
1298 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1299
1300         - Build fix.  Added additional includes for VS Express to the Release
1301         project.
1302
1303         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1304
1305 2007-11-29  Anders Carlsson  <andersca@apple.com>
1306
1307         Reviewed by Adam.
1308
1309         <rdar://problem/5132005>
1310         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1311         
1312         * DumpRenderTree/win/DumpRenderTree.vcproj:
1313         Add shlwapi.lib
1314         
1315         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1316         (LayoutTestController::setUserStyleSheetEnabled):
1317         Implement this.
1318         
1319         (appendComponentToPath):
1320         New method which wraps the Win32 API PathAppend.
1321         
1322         (followShortcuts):
1323         New method which checks if a file points to a shortcut and
1324         follows the shortcut.
1325         
1326         (resolveCygwinPath):
1327         New method that takes a cygwin unix-style path and returns the Win32 path.
1328         
1329         (cfStringRefToWString):
1330         
1331         (LayoutTestController::setUserStyleSheetLocation):
1332         Implement this.
1333
1334 2007-11-29  Alice Liu  <alice.liu@apple.com>
1335
1336         Reviewed by Adam.
1337
1338         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1339
1340         * DumpRenderTree/win/EventSender.cpp:
1341         (keyDownCallback):
1342         uppercase letters were being sent as lowercase letters without the shift key down.
1343
1344 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1345
1346         - Windows build fix. VS express needs some love.
1347
1348         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1349
1350 2007-11-28  Darin Adler  <darin@apple.com>
1351
1352         Reviewed by Adam Roben.
1353
1354         * DumpRenderTree/mac/EventSendingController.mm:
1355         (-[EventSendingController keyDown:withModifiers:]):
1356         Send capital letters through as lowercase letters with the shift key down
1357         rather than sending them as if they were highly unusual "capital letter keys".
1358
1359         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1360         where you need to update results and more tests are failing than before.
1361
1362 2007-11-28  Anders Carlsson  <andersca@apple.com>
1363
1364         Reviewed by Darin.
1365
1366         <rdar://problem/5132001>
1367         contextClick is not implemented in DRT on Windows.
1368         
1369         * DumpRenderTree/win/EventSender.cpp:
1370         (contextClickCallback):
1371         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1372         by a WM_RBUTTONUP message.
1373         
1374         * DumpRenderTree/win/UIDelegate.cpp:
1375         (UIDelegate::hasCustomMenuImplementation):
1376         (UIDelegate::trackCustomPopupMenu):
1377         * DumpRenderTree/win/UIDelegate.h:
1378         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1379         menu from being shown (and causing the DRT to hang).
1380
1381 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1382
1383         Reviewed by Darin.
1384
1385         Fix DumpRenderTree ObjC bug comparing strings.
1386
1387         * DumpRenderTree/mac/ObjCController.m:
1388         (-[ObjCController identityIsEqual::]): Compare strings with string
1389         equality instead of identiy equality.
1390
1391 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1392
1393         Reviewed by Sam.
1394
1395         Reset the authorAndUserStylesEnabled preference
1396         back to YES for each test. Fixes the broken tests.
1397
1398         * DumpRenderTree/mac/DumpRenderTree.mm:
1399         (resetWebViewToConsistentStateBeforeTesting):
1400
1401 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1402
1403         Reviewed by Adam.
1404
1405         - Drosera now displays the console window, although it cannot currently
1406         process JavaScript.
1407
1408         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1409         (registerConsoleClass): Implemented.
1410         (consoleWndProc): Implemented.
1411         (DebuggerClient::onSize): Implemented.
1412         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1413         new window.
1414         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1415         creating and maintaining a new window.
1416         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1417         lines of code to more appropriate places.
1418         (Drosera::handleCommand):
1419         (Drosera::initUI):
1420         (Drosera::onSize):
1421         (Drosera::attach):
1422
1423 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1424
1425         Reviewed by Dave Hyatt.
1426
1427         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1428         
1429         Add support for disabling author and user styles for testing.
1430
1431         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1432         * DumpRenderTree/LayoutTestController.cpp:
1433         (setAuthorAndUserStylesEnabledCallback):
1434         (LayoutTestController::staticFunctions):
1435         * DumpRenderTree/LayoutTestController.h:
1436         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1437         (LayoutTestController::setAuthorAndUserStylesEnabled):
1438         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1439         (LayoutTestController::setAuthorAndUserStylesEnabled):
1440
1441 2007-11-26  Dan Bernstein  <mitz@apple.com>
1442
1443         - Tiger build fix.
1444
1445         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1446
1447 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1448
1449         Reviewed by Maciej.
1450
1451         - Implemented displaying variables for Drosera on Win.
1452
1453         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1454         that retrieve variables to not hold onto the return value since it's
1455         not returned.  Also changed to use the new signatures of the retrieval
1456         functions.
1457         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1458         (DebuggerDocument::platformValueForScopeVariableNamed):
1459         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1460         (droseraWndProc):
1461
1462 2007-11-26  Sam Weinig  <sam@webkit.org>
1463
1464         Cleanup names of painting and repainting functions.
1465
1466         Reviewed by Adam Roben.
1467
1468         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1469         (drawSelectionRect): was drawSelectionRectIntoContext.
1470         (dumpWebViewAsPixelsAndCompareWithExpected):
1471         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1472         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1473         (paintWebView): was drawWebViewIntoContext.
1474         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1475
1476 2007-11-26  Sam Weinig  <sam@webkit.org>
1477
1478         Reviewed by Dan Bernstein.
1479
1480         - Leopard build fix
1481
1482         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1483
1484 2007-11-26  Sam Weinig  <sam@webkit.org>
1485
1486         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1487         Use shared PixelDumpSupport for Mac DRT
1488
1489         Reviewed by Adam Roben.
1490
1491         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1492         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1493         * DumpRenderTree/cg/ImageDiffCG.cpp:
1494         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1495         (drawSelectionRectIntoContext):
1496         (dumpWebViewAsPixelsAndCompareWithExpected):
1497         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1498         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1499         * DumpRenderTree/mac/DumpRenderTree.mm:
1500         (dump):
1501         * DumpRenderTree/mac/ImageDiff.m: Removed.
1502         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1503         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1504         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1505         (setDefaultColorProfileToRGB):
1506         (getBitmapContextFromWebView):
1507         (drawWebViewIntoContext):
1508         (repaintWithVerticalSweep):
1509         (repaintWithHorizontalSweep):
1510         (getSelectionRect):
1511         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1512
1513 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1514
1515         Bug 16052: prepare-ChangeLog doesn't report deleted files
1516         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1517
1518         Reviewed by Sam.
1519
1520         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1521
1522 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1523
1524         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1525         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1526
1527         Reviewed by Adam.
1528
1529         Roll functionality of merge-changelog into resolve-ChangeLogs
1530         script.  The script now checks for ChangeLog.rej and
1531         ChangeLog.orig files first.  If it finds them, it uses the
1532         ChangeLog.rej file as a patch (in old contextual diff format) to
1533         apply with --fuzz=3.
1534
1535         * Scripts/merge-changelog: Removed.
1536         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1537
1538 2007-11-25  Sam Weinig  <sam@webkit.org>
1539
1540         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1541
1542         Reviewed by Mark Rowe.
1543
1544         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1545         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1546         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1547         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1548         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1549
1550 2007-11-25  Sam Weinig  <sam@webkit.org>
1551
1552         Convert DumpRenderTree to ues .xcconfig files.
1553
1554         Reviewed by Mark Rowe.
1555
1556         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1557         * DumpRenderTree/mac/Configurations: Added.
1558         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1559         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1560         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1561
1562 2007-11-25  Sam Weinig  <sam@webkit.org>
1563
1564         Add ForwardingHeaders to wtf for DumpRenderTree.
1565
1566         Reviewed by Mark Rowe.
1567
1568         * DumpRenderTree/DumpRenderTree.h:
1569         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1570         * DumpRenderTree/ForwardingHeaders: Added.
1571         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1572         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1573         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1574         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1575         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1576         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1577         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1578         * DumpRenderTree/LayoutTestController.cpp:
1579         * DumpRenderTree/WorkQueue.cpp:
1580         * DumpRenderTree/mac/DumpRenderTree.mm:
1581         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1582         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1583         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1584         * DumpRenderTree/mac/ObjCController.m:
1585         * DumpRenderTree/mac/UIDelegate.mm:
1586         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1587
1588 2007-11-25  Adam Roben  <aroben@apple.com>
1589
1590         Fix some test failures caused by r28019
1591
1592         Now that stdout is in binary mode, we need to always use printf
1593         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1594         the output.
1595
1596         Reviewed by Sam.
1597
1598         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1599         printf.
1600         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1601         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1602         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1603         (UIDelegate::webViewAddMessageToConsole):
1604
1605 2007-11-25  Adam Roben  <aroben@apple.com>
1606
1607         Set the font smoothing preference in DRT
1608
1609         This makes the pixel results on Windows closer to the Mac results.
1610
1611         Reviewed by Mitz.
1612
1613         * DumpRenderTree/win/DumpRenderTree.cpp:
1614         (initializePreferences):
1615
1616 2007-11-25  Adam Roben  <aroben@apple.com>
1617
1618         Port ImageDiff to CG and C++
1619
1620         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1621         <rdar://5071708>
1622
1623         Reviewed by Sam.
1624
1625         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1626         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1627         (main):
1628         (createImageFromStdin):
1629         (compareImages):
1630         (getDifferenceBitmap):
1631         (computePercentageDifferent):
1632         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1633
1634 2007-11-25  Adam Roben  <aroben@apple.com>
1635
1636         Fix image diff link generation on Windows
1637
1638         Reviewed by Sam.
1639
1640         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1641         to toURL.
1642
1643 2007-11-25  Adam Roben  <aroben@apple.com>
1644
1645         Implement pixel dumping in Windows DRT
1646
1647         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1648         <rdar://5071708>
1649
1650         Reviewed by Sam.
1651
1652         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1653         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1654         Content-Length header.
1655         (getMD5HashStringForBitmap):
1656         (dumpWebViewAsPixelsAndCompareWithExpected):
1657         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1658         * DumpRenderTree/win/DumpRenderTree.cpp:
1659         (dump): Do a pixel dump if requested.
1660         (main): Parse pixel test options.
1661         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1662         the cg/ subdirectory to the include path.
1663         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1664         available in a header or import library, so we have to go through this
1665         LoadLibrary/GetProcAddress dance to use them.
1666         (cryptDLL):
1667         (init):
1668         (update):
1669         (final):
1670         (MD5_Init):
1671         (MD5_Update):
1672         (MD5_Final):
1673         * DumpRenderTree/win/MD5.h: Added.
1674         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1675         moved up to the top level to share it with Mac eventually.
1676         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1677         (getBitmapContextFromWebView): Forces the WebView to paint using a
1678         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1679
1680 2007-11-25  Adam Roben  <aroben@apple.com>
1681
1682         Clean up Windows DRT's option parsing a little bit
1683
1684         Reviewed by Sam.
1685
1686         * DumpRenderTree/win/DumpRenderTree.cpp:
1687         (main): Put non-option arguments into a Vector.
1688
1689 2007-11-25  Adam Roben  <aroben@apple.com>
1690
1691         Make Windows DRT stop changing LF into CRLF
1692
1693         Reviewed by Sam.
1694
1695         * DumpRenderTree/win/DumpRenderTree.cpp:
1696         (main): Put stdout in binary mode.
1697         * Scripts/run-webkit-tests: Remove the CRLF hack.
1698
1699 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1700
1701         Removed empty directory.
1702
1703         * Scripts/resources: Removed.
1704
1705 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1706
1707         Fix bisect-builds to work with recent WebKit nightly builds.
1708
1709         Reviewed by Dan.
1710
1711         * Scripts/bisect-builds: Check for the 
1712         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1713         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1714         to WebKit.app/Contents/Resources.
1715
1716 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1717
1718         Reviewed by Maciej.
1719
1720         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1721         not closed (affects digg.com)
1722
1723         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1724         one after finishing with a test to avoid having its delayed onload handler firing when
1725         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1726         but it helps somewhat.
1727
1728 2007-11-22  Mark Rowe  <mrowe@apple.com>
1729
1730         Reviewed by Alp Toker.
1731
1732         Fix build-webkit to propagate make's exit status if it fails.
1733
1734         * Scripts/webkitdirs.pm:
1735
1736 2007-11-22  Dan Bernstein  <mitz@apple.com>
1737
1738         Reviewed by Mark Rowe.
1739
1740         - fix crash when running pixel tests
1741
1742         * DumpRenderTree/mac/DumpRenderTree.mm:
1743         (dumpRenderTree): Parse the command line options before setting up the
1744         environment so that we know if we need to set up the pixel dump
1745         machinery.
1746
1747 2007-11-21  Eric Seidel  <eric@webkit.org>
1748
1749         Speculative build fix for Tiger.
1750
1751         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1752
1753 2007-11-21  Eric Seidel  <eric@webkit.org>
1754
1755         Reviewed by Tim Hatcher.
1756
1757         Break out more of DumpRenderTree.mm into individual files
1758
1759         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1760         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1761         (checkedMalloc):
1762         (checkedRealloc):
1763         (makeLargeMallocFailSilently):
1764         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1765         * DumpRenderTree/mac/DumpRenderTree.mm:
1766         (crashHandler):
1767         (dump):
1768         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1769         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1770         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1771         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1772         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1773         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1774         (javaScriptThreads):
1775         (runJavaScriptThread):
1776         (startJavaScriptThreads):
1777         (stopJavaScriptThreads):
1778         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1779         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1780         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1781         (restoreColorSpace):
1782         (setDefaultColorProfileToRGB):
1783         (initializeColorSpaceAndScreeBufferForPixelTests):
1784         (md5HashStringForBitmap):
1785         (dumpWebViewAsPixelsAndCompareWithExpected):
1786
1787 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1788
1789         Move install-unix-extras to wx directory as it seems only to be used by that 
1790         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1791         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1792         have install-unix-extras install into WebKitLibraries as per
1793         convention.
1794         
1795         Reviewed by Mark Rowe.
1796
1797         * Scripts/install-unix-extras: Removed.
1798         * wx/build-wxwebkit:
1799         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1800
1801 2007-11-21  Eric Seidel  <eric@webkit.org>
1802
1803         Reviewed by Adam.
1804
1805         More refactoring for greater code readability
1806
1807         * DumpRenderTree/mac/DumpRenderTree.mm:
1808         (initializeGlobalsFromCommandLineOptions):
1809         (initializeColorSpaceAndScreeBufferForPixelTests):
1810         (addTestPluginsToPluginSearchPath):
1811         (useLongRunningServerMode):
1812         (runTestingServerLoop):
1813         (prepareConsistentTestingEnvironment):
1814         (dumpRenderTree):
1815         (main):
1816         (dumpFramesAsText):
1817         (dumpBackForwardListForWebView):
1818         (sizeWebViewForCurrentTest):
1819         (methodNameStringForFailedTest):
1820         (dumpBackForwardListForAllWindows):
1821         (dumpWebViewAsPixelsAndCompareWithExpected):
1822         (invalidateAnyPreviousWaitToDumpWatchdog):
1823         (dump):
1824         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1825         * DumpRenderTree/mac/UIDelegate.mm:
1826         (-[UIDelegate webView:createWebViewWithRequest:]):
1827
1828 2007-11-21  Eric Seidel  <eric@webkit.org>
1829
1830         Reviewed by Tim Hatcher.
1831
1832         Abstract more of DRT into static methods
1833
1834         * DumpRenderTree/mac/DumpRenderTree.mm:
1835         (setDefaultsToConsistentValuesForTesting):
1836         (setupSignalHandlers):
1837         (allocateGlobalControllers):
1838         (releaseAndZero):
1839         (releaseGlobalControllers):
1840         (dumpRenderTree):
1841         (shouldLogFrameLoadDelegates):
1842         (createCFURLFromPathOrURL):
1843         (resetWebViewToConsistentStateBeforeTesting):
1844         (runTest):
1845
1846 2007-11-21  Eric Seidel  <eric@webkit.org>
1847
1848         Reviewed by Tim Hatcher.
1849
1850         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1851
1852         * DumpRenderTree/DumpRenderTree.h:
1853         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1854         * DumpRenderTree/mac/DumpRenderTree.mm:
1855         (dumpRenderTree):
1856         (dump):
1857         (runTest):
1858         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1859         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1860         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1861         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1862         (-[DumpRenderTreePasteboard declareType:owner:]):
1863         (+[LocalPasteboard alloc]):
1864         (-[LocalPasteboard init]):
1865         (-[LocalPasteboard dealloc]):
1866         (-[LocalPasteboard name]):
1867         (-[LocalPasteboard releaseGlobally]):
1868         (-[LocalPasteboard declareTypes:owner:]):
1869         (-[LocalPasteboard addTypes:owner:]):
1870         (-[LocalPasteboard changeCount]):
1871         (-[LocalPasteboard types]):
1872         (-[LocalPasteboard availableTypeFromArray:]):
1873         (-[LocalPasteboard setData:forType:]):
1874         (-[LocalPasteboard dataForType:]):
1875         (-[LocalPasteboard setPropertyList:forType:]):
1876         (-[LocalPasteboard setString:forType:]):
1877         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1878         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1879         (+[DumpRenderTreeWindow allWindows]):
1880         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1881         (-[DumpRenderTreeWindow dealloc]):
1882         (-[DumpRenderTreeWindow isKeyWindow]):
1883         (-[DumpRenderTreeWindow keyDown:]):
1884
1885 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1886
1887         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1888         it indiscriminately copies any headers inside JavaScriptCore,
1889         which includes Tiger ICU headers. 
1890
1891         * wx/build-wxwebkit:
1892         Don't run WebCore/move-js-headers.sh any longer.
1893
1894 2007-11-20  Adam Treat  <treat@kde.org>
1895
1896         Reviewed by David Kilzer.
1897
1898         * Prepend git branch name to $baseProductDir
1899
1900         * Scripts/VCSUtils.pm:
1901         * Scripts/webkitdirs.pm:
1902
1903 2007-11-20  Mark Rowe  <mrowe@apple.com>
1904
1905         Reviewed by Simon Hausmann.
1906
1907         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1908         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1909         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1910         built product and generated Makefile's are removed.
1911
1912 2007-11-19  Alp Toker  <alp@atoker.com>
1913
1914         Reviewed by Mark Rowe.
1915
1916         http://bugs.webkit.org/show_bug.cgi?id=16040
1917         [GTK] GtkLauncher should be written in C
1918
1919         Port GtkLauncher to plain C.
1920
1921         Use a more conventional GTK+ coding style.
1922
1923         Use a toolbar instead of menus.
1924
1925         Various signature fixes and cleanups.
1926
1927         Add a license header. Assume all previous modifications were copyright
1928         assigned to Apple Inc. by default.
1929
1930         * GtkLauncher/GtkLauncher.pro:
1931         * GtkLauncher/main.c: Added.
1932         (activate_url_entry_cb):
1933         (update_title):
1934         (link_hover_cb):
1935         (title_change_cb):
1936         (progress_change_cb):
1937         (destroy_cb):
1938         (go_back_cb):
1939         (go_forward_cb):
1940         (create_browser):
1941         (create_statusbar):
1942         (create_toolbar):
1943         (create_window):
1944         (main):
1945         * GtkLauncher/main.cpp: Removed.
1946
1947 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1948
1949         Build script fixes to ensure they do the right thing for the 
1950         wx port, and update build-wxwebkit to reflect the way the
1951         build scripts now work.
1952
1953         Reviewed by Adam.
1954
1955         * Scripts/build-testkjs:
1956         * Scripts/build-webkit:
1957         * Scripts/run-javascriptcore-tests:
1958         * Scripts/webkitdirs.pm:
1959         * wx/build-wxwebkit:
1960
1961 2007-11-18  Eric Seidel  <eric@webkit.org>
1962
1963         Reviewed by Anders.
1964
1965         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1966
1967         * Scripts/run-javascriptcore-tests:
1968
1969 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1970
1971         Reviewed by Adam Roben.
1972
1973         Make run-webkit-tests work with Windows debug build.
1974
1975         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1976         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1977         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1978         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1979         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1980
1981 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1982
1983         Add wxWebKit sample and build script, and integrate it with 
1984         build-webkit. Also make build-webkit --clean work for all
1985         ports.
1986
1987         Reviewed by Darin Adler.
1988
1989         * Scripts/build-webkit:
1990         * Scripts/webkitdirs.pm:
1991         * wx: Added.
1992         * wx/browser: Added.
1993         * wx/browser/browser.bkl: Added.
1994         * wx/browser/browser.cpp: Added.
1995         * wx/build-wxwebkit: Added.
1996
1997 2007-11-17  Adam Roben  <aroben@apple.com>
1998
1999         Make it easy to run Safari in the debugger on Windows
2000
2001         I've added a new script, debug-safari, which launches Safari in the
2002         debugger. On OS X it just calls gdb-safari.
2003
2004         Reviewed by Mark Rowe.
2005
2006         * FindSafari/FindSafari.cpp:
2007         (_tmain): Added a /debugger flag, which in combination with
2008         /printSafariLauncher will print a script that launches Safari in the
2009         debugger.
2010         * Scripts/debug-safari: Added.
2011         * Scripts/run-safari: Changed to call runSafari().
2012         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2013         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2014         first argument along to FindSafari.
2015         * Scripts/webkitdirs.pm:
2016         (sub runSafari): Added.
2017
2018 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2019
2020         Reviewed by Adam Roben.
2021
2022         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2023
2024 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2025
2026         Reviewed by David Kilzer.
2027
2028         The git config command was renamed to repo-config at some point. This
2029         change tries git config and then git repo-config if the first fails.
2030
2031         * Scripts/prepare-ChangeLog:
2032         (gitConfig):
2033
2034 2007-11-16  Dan Bernstein  <mitz@apple.com>
2035
2036         Reviewed by Darin Adler and Sam Weinig.
2037
2038         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2039
2040         * DumpRenderTree/win/EventSender.cpp:
2041         (keyDownCallback): For characters that cannot be entered on the active
2042         keyboard layout, send a WM_CHAR message with the character along with
2043         a WM_KEYDOWN message with a virtual key code of 255.
2044
2045 2007-11-16  Mark Rowe  <mrowe@apple.com>
2046
2047         Reviewed by Tim Hatcher.
2048
2049         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2050
2051         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2052         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2053
2054 2007-11-15  Adam Roben  <aroben@apple.com>
2055
2056         Make run-safari actually work on Windows
2057
2058         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2059         chdir call.
2060
2061 2007-11-14  Adam Roben  <aroben@apple.com>
2062
2063         Updates to Safari launching now that 3.0.4 is released
2064
2065         Reviewed by Sam.
2066
2067         * FindSafari/FindSafari.cpp:
2068         (getWebViewCLSID): Use version-independent ProgID.
2069         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2070
2071 2007-11-14  Anders Carlsson  <andersca@apple.com>
2072
2073         Reviewed by Adam.
2074
2075         <rdar://problem/5309081>
2076         In DRT, "plugin.logDestroy = true" not working on Windows.
2077         
2078         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2079         (NPP_Destroy):
2080
2081 2007-11-14  Eric Seidel  <eric@webkit.org>
2082
2083         Reviewed by Sam.
2084
2085         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2086
2087 2007-11-14  Anders Carlsson  <andersca@apple.com>
2088
2089         Reviewed by Adam.
2090
2091         <rdar://problem/5141186>
2092         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2093         
2094         Implement setWindowIsKey.
2095         
2096         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2097         (LayoutTestController::setWindowIsKey):
2098
2099 2007-11-13  Sam Weinig  <sam@webkit.org>
2100
2101         Reviewed by Adam Roben.
2102
2103         Fix for <rdar://problem/5382579>
2104         http/tests/security/cross-frame-access-put.html reports large 
2105         negative numbers for screenLeft and screenTop (Mac reports "0")
2106
2107         * DumpRenderTree/win/UIDelegate.cpp:
2108         (UIDelegate::UIDelegate): Initialize the RECT.
2109         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2110         (UIDelegate::webViewFrame): ditto.
2111         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2112
2113 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2114
2115         Reviewed by Adam.
2116
2117         - Make Drosera show source, source URLs, and function stack on Windows,
2118         and some minor fixes.
2119
2120         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2121         (DebuggerDocument::updateFileSource):
2122         * Drosera/debugger.js: Force source to always update display.
2123         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2124         menu controls.
2125         (DebuggerClient::resume):
2126         (DebuggerClient::pause):
2127         (DebuggerClient::stepInto):
2128         (DebuggerClient::stepOver):
2129         (DebuggerClient::stepOut):
2130         (DebuggerClient::showConsole):
2131         (DebuggerClient::closeCurrentFile):
2132         * Drosera/win/DebuggerClient.h: Ditto.
2133         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2134         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2135         removed two bugs.  1) caller could be in a bad state when asked to
2136         assign into it. 2) BSTRs were not created correctly.
2137         (DebuggerDocument::getPlatformCurrentFunctionStack):
2138         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2139         (droseraWndProc):
2140         (handleCommand):
2141         (Drosera::resume):
2142         (Drosera::pause):
2143         (Drosera::stepInto):
2144         (Drosera::stepOver):
2145         (Drosera::stepOut):
2146         (Drosera::showConsole):
2147         (Drosera::closeCurrentFile):
2148         * Drosera/win/Drosera.h: Hook up the menu controls.
2149         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2150         functions, added a null check, and fixed another bug where caller could
2151         be in a bad state when asked to assign into it.
2152         (ServerConnection::didLoadMainResourceForDataSource):
2153         (ServerConnection::getCallerFrame):
2154         * Drosera/win/ServerConnection.h: Safety first.
2155
2156 2007-11-13  Dan Bernstein  <mitz@apple.com>
2157
2158         Reviewed by Darin Adler.
2159
2160         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2161           DumpRenderTree --pixel-tests renders each test twice
2162
2163         * DumpRenderTree/mac/DumpRenderTree.mm:
2164         (dumpRenderTree): Removed the --paint option because the painting code
2165         is always exercised as a result of
2166         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2167         calling -displayIfNeeded.
2168         (dump): Changed to always grab the image from the window since the view
2169         is always displayed.
2170         (runTest):
2171         (displayWebView):
2172         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2173         because it always paints.
2174
2175 2007-11-12  Antti Koivisto  <antti@apple.com>
2176
2177         Reviewed by Adele.
2178         
2179         Add support for http media tests
2180
2181         * Scripts/run-webkit-tests:
2182
2183 2007-11-12  Sam Weinig  <sam@webkit.org>
2184
2185         Reviewed by Adam Roben.
2186
2187         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2188
2189         * DumpRenderTree/win/DumpRenderTree.cpp:
2190         (runTest):
2191         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2192         (LayoutTestController::setPrivateBrowsingEnabled):
2193
2194 2007-11-12  Adam Roben  <aroben@apple.com>
2195
2196         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2197         mac and win subdirectories.
2198
2199 2007-11-11  Adam Roben  <aroben@apple.com>
2200
2201         Fix <rdar://5133816> keepWebHistory is not implemented
2202
2203         Fixes fast/history/clicked-link-is-visited.html.
2204
2205         Reviewed by Darin.
2206
2207         * DumpRenderTree/win/DumpRenderTree.cpp:
2208         (runTest): Clear the optionalSharedHistory.
2209         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2210         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2211
2212 2007-11-10  Sam Weinig  <sam@webkit.org>
2213
2214         Reviewed by Tim Hatcher.
2215
2216         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2217         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2218         is turned on)
2219
2220         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2221
2222         Added test: http/tests/security/cross-frame-access-private-browsing.html
2223
2224         * DumpRenderTree/LayoutTestController.cpp:
2225         (setPrivateBrowsingEnabledCallback):
2226         (LayoutTestController::staticFunctions):
2227         * DumpRenderTree/LayoutTestController.h:
2228         * DumpRenderTree/mac/DumpRenderTree.mm:
2229         (runTest): Default to private browsing disabled.
2230         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2231         (LayoutTestController::setPrivateBrowsingEnabled):
2232         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2233         (LayoutTestController::setPrivateBrowsingEnabled):
2234
2235 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2236
2237         Reviewed by Adam.
2238
2239         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2240         WebCore's!
2241
2242         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2243         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2244         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2245         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2246         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2247         * Drosera/win/Drosera.cpp:
2248         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2249
2250 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2251
2252         Reviewed by Sam.
2253
2254         - Use the new IWebFrame [local] function signature and get the shared
2255         server correctly.
2256
2257         * Drosera/win/DebuggerClient.cpp:
2258         (DebuggerClient::didFinishLoadForFrame):
2259         * Drosera/win/ServerConnection.cpp:
2260         (ServerConnection::attemptToCreateServerConnection):
2261
2262 2007-11-07  Dan Bernstein  <mitz@apple.com>
2263
2264         Reviewed by Darin Adler.
2265
2266         - add an option to run-webkit-tests to ignore pixel test failures where
2267           all pixels differ by no more than a specified threshold
2268
2269         * DumpRenderTree/mac/ImageDiff.m:
2270         (main):
2271         (compareImages):
2272         (computePercentageDifferent):
2273         * Scripts/run-webkit-tests:
2274
2275 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2276
2277         Reviewed by Lars.
2278
2279         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2280
2281         * DumpRenderTree/qt/DumpRenderTree.cpp:
2282
2283 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2284
2285         Reviewed by Lars.
2286
2287         Reworked the QWebSettings API.
2288         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2289
2290         * DumpRenderTree/qt/DumpRenderTree.cpp:
2291
2292 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2293
2294         Reviewed by Lars.
2295
2296         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2297
2298         * DumpRenderTree/qt/jsobjects.cpp:
2299
2300 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2301
2302         Reviewed by Lars Knoll <lars@trolltech.com>.
2303
2304         Add a QWebPage::frameCreated() signal and fix DRT
2305         
2306         The removal of createFrame in QWebPage broke the re-implementation
2307         in DumpRenderTree. Instead emit a frameCreated() signal and
2308         connect to it in DumpRenderTree.
2309         
2310
2311         * DumpRenderTree/qt/DumpRenderTree.cpp:
2312         (WebCore::WebPage::WebPage):
2313         (WebCore::DumpRenderTree::dump):
2314         (WebCore::DumpRenderTree::connectFrame):
2315         * DumpRenderTree/qt/DumpRenderTree.h:
2316
2317 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2318
2319         Reviewed by Lars Knoll <lars@trolltech.com>.
2320
2321         Moved all the event handlers from QWebFrame into QWebPage.
2322         
2323         This cleans up the public API and allows us to remove the
2324         HackWebFrame hack in DumpRenderTree.
2325         
2326
2327         * DumpRenderTree/qt/jsobjects.cpp:
2328         (EventSender::mouseDown):
2329         (EventSender::mouseUp):
2330         (EventSender::mouseMoveTo):
2331
2332 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2333
2334         Reviewed by Mark.
2335
2336         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2337         to prevent the default implementation from popping up messageboxes.
2338
2339         * DumpRenderTree/qt/DumpRenderTree.cpp:
2340         (WebCore::WebPage::javaScriptConfirm):
2341         (WebCore::WebPage::javaScriptPrompt):
2342
2343 2007-11-06  Eric Seidel  <eric@webkit.org>
2344
2345         * Scripts/build-testkjs: build fix... too many $$
2346
2347 2007-11-06  Eric Seidel  <eric@webkit.org>
2348
2349         Reviewed by Mark Rowe.
2350
2351         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2352
2353 2007-11-05  Adam Roben  <aroben@apple.com>
2354
2355         Add support on Windows for WEBKIT_TESTFONTS
2356
2357         This environment variable lets you specify where the fonts to be used
2358         by DumpRenderTree reside. The Qt port is already using this, so I'm
2359         just following their lead.
2360
2361         Reviewed by Darin.
2362
2363         * DumpRenderTree/win/DumpRenderTree.cpp:
2364         (exePath): Refactored code out of initialize().
2365         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2366         DumpRenderTree.resources.
2367         (initialize): Use the new fontsPath function.
2368         (main): Use the new exePath function.
2369         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2370         variable to DRT, like Qt does.
2371
2372 2007-11-05  Mark Rowe  <mrowe@apple.com>
2373
2374         Rubber-stamped by Alp Toker.
2375
2376         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2377
2378         * GtkLauncher/main.cpp:
2379         (goToURLBarText):
2380         (main):
2381
2382 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2383
2384         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2385         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2386
2387         Reviewed by Timothy.
2388
2389         Restrict the range of nightly builds used by the bisect-builds script
2390         based on the version of Safari and the version of Mac OS X being used.
2391
2392         Mac OS X 10.4: Safari 2.0: r11976 or newer
2393         Mac OS X 10.4: Safari 3.0: r19992 or newer
2394
2395         Mac OS X 10.5: Safari 2.0: r19594 or newer
2396         Mac OS X 10.5: Safari 3.0: r25124 or newer
2397
2398         * Scripts/bisect-builds:
2399         (findMacOSXVersion): Added.
2400         (makeNightlyList): Added argument to provide version of Mac OS X.
2401         Restrict range of nightly builds based on Safari and Mac OS X versions.
2402
2403 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2404
2405         Reviewed by Maciej.
2406
2407         - This patch involves several changes, all of them were noticed that
2408         they were needed by the work being done in WebKit to get Drosera and
2409         WebKit working together on Windows.
2410         - The changes are:
2411         1) Added a debugger console for output messages.
2412         2) Drosera now listens for the WebKit server (before, the server would
2413         have to be running before Drosera was started.)
2414         3) Fixed a bug where the WebView started out as 0x0 pixels.
2415         4) Fixed a bug when there is no scope.
2416         5) Added the HTML, JS, and CSS to the project file to make them easy to
2417         find.
2418         6) Made the ServerConnection functions virtual.
2419
2420         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2421         for the WebKit server.
2422         (DebuggerClient::DebuggerClient):
2423         (DebuggerClient::~DebuggerClient):
2424         (DebuggerClient::didFinishLoadForFrame):
2425         (DebuggerClient::serverConnected):
2426         (DebuggerClient::attemptToCreateServerConnection):
2427         * Drosera/win/DebuggerClient.h: Ditto.
2428         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2429         scope.
2430         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2431         (DebuggerDocument::platformValueForScopeVariableNamed):
2432         * Drosera/win/Drosera.cpp:
2433         (_tWinMain): Added a console in debug for output messages.
2434         (Drosera::Drosera): Listen for server.
2435         (Drosera::initUI): The server now Initializes COM.
2436         (Drosera::serverConnected): Part of the listening for the server.
2437         (Drosera::attemptToCreateServerConnection): Ditto.
2438         * Drosera/win/Drosera.h: New interface for listening for the server.
2439         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2440         files to the VS project.
2441         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2442         connection.
2443         (ServerConnection::ServerConnection):
2444         (ServerConnection::attemptToCreateServerConnection):
2445         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2446         methods.
2447         (ServerConnection::serverConnected):
2448
2449 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2450
2451         Reviewed by Maciej.
2452
2453         http://bugs.webkit.org/show_bug.cgi?id=15832
2454         fast/dom/gc-10.html crashes when run alone
2455
2456         Check for !done before using objects that can be already deallocated.
2457
2458         * DumpRenderTree/mac/EditingDelegate.mm:
2459         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2460         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2461         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2462         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2463         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2464         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2465         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2466         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2467         (-[EditingDelegate webViewDidBeginEditing:]):
2468         (-[EditingDelegate webViewDidChange:]):
2469         (-[EditingDelegate webViewDidEndEditing:]):
2470         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2471         (-[EditingDelegate webViewDidChangeSelection:]):
2472         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2473         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2474         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2475         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2476         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2477         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2478         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2479         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2480         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2481         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2482         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2483         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2484         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2485         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2486         (-[FrameLoadDelegate webView:willCloseFrame:]):
2487         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2488         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2489         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2490         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2491         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2492         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2493         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2494         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2495         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2496
2497 2007-11-04  Mark Rowe  <mrowe@apple.com>
2498
2499         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2500         warnings that would otherwise be suppressed due to it being a system header.
2501
2502         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2503
2504 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2505
2506         Rubber stamped by Adam.
2507         
2508         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2509
2510         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2511
2512 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2513
2514         Sort files(...); sections of Xcode project files.
2515
2516         Rubber-stamped by Darin.
2517
2518         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2519         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2520         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2521         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2522
2523 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2524
2525         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2526
2527         Reviewed by Darin.
2528
2529         * Scripts/sort-Xcode-project-file: Added.
2530
2531 2007-11-02  Darin Adler  <darin@apple.com>
2532
2533         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2534
2535 2007-11-02  Darin Adler  <darin@apple.com>
2536
2537         Reviewed by Maciej.
2538
2539         * Scripts/run-sunspider: Pass the "--base" option through.
2540
2541         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2542         the real script do that. Default configuration to Release to match run-sunspider
2543         so we don't end up building Debug just to compare results.
2544
2545 2007-11-01  Adam Roben  <aroben@apple.com>
2546
2547         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2548
2549         Reviewed by Sam.
2550
2551         * Scripts/commit-log-editor: Show all the directories beneath the
2552         source root, instead of just the last one.
2553
2554 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2555
2556         Reviewed by Adam Roben.
2557
2558         Print out an error message when the Windows build fails
2559         and provide guidance on how to find out what went wrong.
2560
2561         * Scripts/build-webkit:
2562         * Scripts/webkitdirs.pm:
2563
2564 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2565
2566         Rubber-stamped by Adam Roben.
2567
2568         Rolled out r27326 - debug CRT seems to cause no problems after all.
2569
2570         * DumpRenderTree/win/DumpRenderTree.vcproj:
2571
2572 2007-10-31  Adam Roben  <aroben@apple.com>
2573
2574         Switch the Debug configuration to using the non-debug CRT
2575
2576         This matches WebKit.
2577
2578         Reviewed by Steve.
2579
2580         * DumpRenderTree/win/DumpRenderTree.vcproj:
2581
2582 2007-10-31  Antti Koivisto  <antti@apple.com>
2583
2584         Reviewed by bdash.
2585         
2586         Disable media tests when doing leak checking on Tiger.
2587         They crash in QuickTime (rdar://problem/5537157).
2588
2589         * Scripts/run-webkit-tests:
2590
2591 2007-10-29  Antti Koivisto  <antti@apple.com>
2592
2593         Reviewed by Maciej.
2594         
2595         Build media support by default on OSX only.
2596
2597         * Scripts/build-webkit:
2598
2599 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2600
2601         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2602         get caught by the pre-commit hooks.
2603
2604 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2605
2606         Reviewed by Adam.
2607
2608         - This is a collection of relatively unrelated changes and cleanups
2609         to Drosera to prepare it for interacting with WebKit.  A lot of these
2610         changes are just correcting mistakes, for example removing included
2611         headers that are no longer needed.
2612
2613         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2614         this will be needed by the DebuggerClient.
2615         (DebuggerDocument::server):
2616         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2617         * Drosera/win/DebuggerClient.cpp: 
2618         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2619         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2620         (DebuggerClient::createWebViewWithRequest): Added comment about its
2621         purpose. 
2622         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2623         declarations.
2624         (DebuggerClient::webViewLoaded): Moved.
2625         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2626         file, since this was the only place it was used.
2627         (cfStringToBSTR):
2628         * Drosera/win/Drosera.h: Cleaned up the includes.
2629         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2630         * Drosera/win/HelperFunctions.h: Removed.
2631
2632 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2633
2634         Reviewed by Adam.
2635
2636         - Small cleanup in the ServerConnection class.
2637
2638         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2639         and added an include.
2640         (ServerConnection::currentFrame):
2641         (ServerConnection::getCallerFrame):
2642         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2643         made a pointer into a COMPtr, and cleaned up the includes.
2644
2645 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2646
2647         Reviewed by John Sullivan.
2648         
2649         - Place the Localizable.strings file in mac or win directories
2650           if that location exists.
2651         - Also look for UI_STRING in .c files.
2652
2653         * Scripts/extract-localizable-strings:
2654
2655 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2656
2657         Reviewed by Adam.
2658
2659         - Set the eol-style to native and made all the line endings the same
2660         so that I avoid messy diffs that show eol changes.
2661
2662         * Drosera/win/ServerConnection.cpp:
2663         (ServerConnection::didParseSource):
2664         (ServerConnection::didEnterCallFrame):
2665         (ServerConnection::willExecuteStatement):
2666         (ServerConnection::willLeaveCallFrame):
2667         (ServerConnection::exceptionWasRaised):
2668
2669 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2670
2671         Reviewed by Adam.
2672
2673         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2674         functionality that could not have existed previously without the new
2675         interfaces.
2676         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2677         from a BSTR to a JSValueRef.
2678         (DebuggerDocument::platformEvaluateScript): Implemented.
2679         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2680         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2681         Implemented.
2682         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2683         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2684         * Drosera/win/ServerConnection.cpp: Added a helper function.
2685         (ServerConnection::getCallerFrame):
2686         * Drosera/win/ServerConnection.h: Added a helper function.
2687
2688 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2689
2690         updated reviewers for my previous changelog.
2691
2692 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2693         Reviewed by Maciej and Adam and Geoff.
2694
2695         - Minor mac-side improvements including moving a function to a more
2696         appropriate location, fixing a warning, and correctly checking
2697         exceptions.
2698
2699         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2700         (DebuggerDocument::willExecuteStatement):
2701         (DebuggerDocument::didEnterCallFrame):
2702         (DebuggerDocument::willLeaveCallFrame):
2703         (DebuggerDocument::windowScriptObjectAvailable):
2704         (DebuggerDocument::callFunctionOnObject):
2705         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2706         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2707         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2708         because it doesn't require the ServerConnection at all.
2709         (NSStringCreateWithJSStringRef): Made an argument const.
2710         (JSValueRefCreateWithNSString): Made an argument const.
2711         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2712         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2713         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2714         * Drosera/mac/ServerConnection.mm: Ditto.
2715         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2716
2717 2007-10-29  Sam Weinig  <sam@webkit.org>
2718
2719         Reviewed by Adam Roben.
2720
2721         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2722
2723         * DumpRenderTree/LayoutTestController.cpp:
2724         (LayoutTestController::LayoutTestController):
2725         (getGlobalFlagCallback):
2726         (setGlobalFlagCallback):
2727         (LayoutTestController::getJSClass):
2728         (LayoutTestController::staticValues):
2729         * DumpRenderTree/LayoutTestController.h:
2730         (LayoutTestController::globalFlag):
2731         (LayoutTestController::setGlobalFlag):
2732
2733 2007-10-29  Darin Adler  <darin@apple.com>
2734
2735         Reviewed by Maciej.
2736
2737         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2738         resolution instead of its default.
2739
2740 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2741
2742         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2743
2744         Reviewed by Mark Rowe.
2745
2746         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2747         was successfully resolved, but this would not show any status because the change had
2748         already been cached in the index using "git add".  The solution is to add an optional
2749         second argument to showStatus() which adds the "--cached" switch to the command.
2750
2751         * Scripts/resolve-ChangeLogs:
2752         (showStatus):
2753
2754 2007-10-28  Eric Seidel  <eric@webkit.org>
2755
2756         Reviewed by Maciej and Geoff, in unison.
2757
2758         * Scripts/run-webkit-tests: remove broken --svg option
2759
2760 2007-10-28  Darin Adler  <darin@apple.com>
2761
2762         Reviewed by Adam.
2763
2764         * Scripts/run-sunspider: Default to "Release" configuration rather than
2765         defaulting to the last configuration used as other scripts do. This can
2766         still be overriden on the command line with "--debug" if there's some
2767         reason to do so. Also fix a typo.
2768
2769         * Scripts/sunspider-compare-results: Fix a typo.
2770
2771 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2772
2773         Reviewed by Adam.
2774
2775         - Implemented the WebScriptDebugListener functions now that the
2776         WebScriptDebugServer exists
2777
2778         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2779         functions.
2780         (ServerConnection::currentFrame):
2781         (ServerConnection::didLoadMainResourceForDataSource):
2782         (ServerConnection::didParseSource):
2783         (ServerConnection::failedToParseSource):
2784         (ServerConnection::didEnterCallFrame):
2785         (ServerConnection::willExecuteStatement):
2786         (ServerConnection::willLeaveCallFrame):
2787         (ServerConnection::exceptionWasRaised):
2788         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2789         members arguments list.
2790
2791 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2792
2793         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2794         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2795
2796         Reviewed by Darin.
2797
2798         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2799         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2800         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2801         file.  Note that it may also be used as a stand-alone script.
2802
2803         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2804         * Scripts/resolve-ChangeLogs: Added.
2805         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2806
2807 2007-10-26  Mark Rowe  <mrowe@apple.com>
2808
2809         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2810         to the Qt port on the assumption that it was an implementation of the cross-platform
2811         LayoutTestController class.  It is not, so it did not need to be changed.
2812
2813         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2814
2815 2007-10-25  Mark Rowe  <mrowe@apple.com>
2816
2817         Reviewed by Maciej.
2818
2819         Fix builds with code coverage enabled.
2820
2821         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2822
2823 2007-10-25  Darin Adler  <darin@apple.com>
2824
2825         Reviewed by Mark Rowe.
2826
2827         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2828         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2829
2830 2007-10-25  Stephanie  <slewis@apple.com>
2831
2832         build Fix
2833
2834         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2835
2836 2007-10-25  Stephanie  <slewis@apple.com>
2837
2838         Reviewed by Mark Rowe, Adam Roben.
2839
2840         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2841
2842         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2843
2844 2007-10-25  Alice Liu  <alice.liu@apple.com>
2845
2846         Reviewed by Adam.
2847
2848         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2849
2850         Moving destructor into platform-specific files
2851         * DumpRenderTree/LayoutTestController.cpp:
2852         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2853         (LayoutTestController::~LayoutTestController):
2854         * DumpRenderTree/qt/jsobjects.cpp:
2855         (LayoutTestController::~LayoutTestController):
2856
2857         LayoutTestController wasn't being destroyed
2858         * DumpRenderTree/win/DumpRenderTree.cpp:
2859         (runTest):
2860
2861         Added declspec
2862         * DumpRenderTree/win/EditingDelegate.h:
2863
2864         Reset certain values on the webview (or related delegate) that might 
2865         have changed while running a test
2866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2867         (LayoutTestController::~LayoutTestController):
2868
2869 2007-10-25  Adam Roben  <aroben@apple.com>
2870
2871         Make sunspider-compare-results work with relative paths
2872
2873         Reviewed by Sam.
2874
2875         * Scripts/sunspider-compare-results: Convert arguments to absolute
2876         paths before we chdir.
2877
2878 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2879
2880         Reviewed by Sam.
2881
2882         - Implemented server calls now the WebScriptDebugServer exists.
2883         - Also removed no longer needed call to initialize CG.
2884
2885         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2886         automatically now.
2887         (_tWinMain):
2888         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2889         (ServerConnection::ServerConnection):
2890         (ServerConnection::~ServerConnection):
2891         (ServerConnection::pause):
2892         (ServerConnection::resume):
2893         (ServerConnection::stepInto):
2894         (ServerConnection::applicationTerminating):
2895         (ServerConnection::serverConnectionDidDie):
2896         * Drosera/win/ServerConnection.h: Now uses the COM class.
2897
2898 2007-10-24  George Staikos  <staikos@kde.org>
2899
2900         Unbreak Qt build.
2901
2902         * Scripts/build-webkit:
2903
2904 2007-10-24  Adam Roben  <aroben@apple.com>
2905
2906         Remove now-unnecessary call to InitializeCoreGraphics
2907
2908         WebKit takes care of this now.
2909
2910         Reviewed by Ada.
2911
2912         * DumpRenderTree/win/DumpRenderTree.cpp:
2913         (initialize):
2914
2915 2007-10-24  Adam Roben  <aroben@apple.com>
2916
2917         Use WebTextRenderer in DRT
2918
2919         Reviewed by Ada.
2920
2921         * DumpRenderTree/win/DumpRenderTree.cpp:
2922         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2923
2924 2007-10-24  Sven Herzberg  <sven@imendio.com>
2925
2926         Reviewed by Mark Rowe.
2927
2928         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2929         Bug 15614: [GTK] qmake based backends don't build on OS X
2930
2931         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2932         GTK backend on a Mac
2933         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2934         isDarwin() to make it reusable in other places (like the workaround-
2935         for-prebuilt-qmake in build-webkit)
2936
2937 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2938
2939         Refurbish update-webkit script.
2940
2941         Reviewed by Adam.
2942
2943         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2944         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2945         multi-argument version of system() for flexibility and security.  Check for existence
2946         of Internal directory using -d test instead of -x.
2947
2948 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2949
2950         Minor clean-up of prepare-ChangeLog script.
2951
2952         Reviewed by Adam.
2953
2954         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2955         of a string.  Use multi-argument versions of open() and system() for flexibility and
2956         security.
2957
2958 2007-10-24  Alice Liu  <alice.liu@apple.com>
2959
2960         Reviewed by Oliver.
2961
2962         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2963
2964         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2965         replay the saved events when we're still processing the mousedown that starts the drag
2966         * DumpRenderTree/win/EventSender.cpp:
2967         (doMouseMove):
2968         * DumpRenderTree/win/UIDelegate.cpp:
2969         (UIDelegate::doDragDrop):
2970
2971 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2972
2973         Reviewed by Sam, Steve and Darin.
2974
2975         - Stubbed out the WebScriptDebugListener functionality in the Server
2976         Connection class to prepare it for receiving those callbacks.
2977         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2978         and the ServerConnection to not need to be initialized with a server
2979         name, since that is not the way we connect to the WebKit server. 
2980
2981         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2982         no exception.  Now it only loggs when there is an exception
2983         (DebuggerDocument::willExecuteStatement):
2984         (DebuggerDocument::didEnterCallFrame):
2985         (DebuggerDocument::willLeaveCallFrame):
2986         (DebuggerDocument::windowScriptObjectAvailable):
2987         (DebuggerDocument::callFunctionOnObject):
2988         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2989         to be instantiated with a server's name.
2990         (DebuggerClient::DebuggerClient):
2991         (DebuggerClient::didFinishLoadForFrame):
2992         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2993         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2994         a server name.
2995         (Drosera::init):
2996         (Drosera::initServer):
2997         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2998         instantiated with a server's name.
2999         * Drosera/win/ServerConnection.cpp: 
3000         (ServerConnection::ServerConnection): No longer needs a server name
3001         (ServerConnection::~ServerConnection): Only release the global context
3002         if there is one.
3003         (ServerConnection::serverConnectionDidDie): Stub for
3004         IWebScriptDebugListener
3005         (ServerConnection::QueryInterface): ditto
3006         (ServerConnection::AddRef): ditto
3007         (ServerConnection::Release): ditto
3008         (ServerConnection::didLoadMainResourceForDataSource): ditto
3009         (ServerConnection::didParseSource): ditto
3010         (ServerConnection::failedToParseSource): ditto
3011         (ServerConnection::didEnterCallFrame): ditto
3012         (ServerConnection::willExecuteStatement): ditto
3013         (ServerConnection::willLeaveCallFrame): ditto
3014         (ServerConnection::exceptionWasRaised): ditto
3015         * Drosera/win/ServerConnection.h: Stubbed out the
3016         IWebScriptDebugListener functions, and this class no longer needs to be
3017         instantiated with a server name.
3018
3019 2007-10-24  Lars Knoll  <lars@trolltech.com>
3020
3021         Reviewed by Simon.
3022
3023         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3024
3025         * DumpRenderTree/qt/jsobjects.h:
3026
3027 2007-10-24  Lars Knoll  <lars@trolltech.com>
3028
3029         Reviewed by Simon.
3030
3031         add another command.
3032
3033         * DumpRenderTree/qt/jsobjects.cpp:
3034         (TextInputController::doCommand):
3035
3036 2007-10-24  Lars Knoll  <lars@trolltech.com>
3037
3038         Reviewed by Simon.
3039
3040         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3041
3042         * DumpRenderTree/qt/jsobjects.cpp:
3043         (EventSender::keyDown):
3044         * DumpRenderTree/qt/jsobjects.h:
3045
3046 2007-10-24  Lars Knoll  <lars@trolltech.com>
3047
3048         Reviewed by Simon.
3049
3050         implement eventSender.keyDown().
3051
3052         * DumpRenderTree/qt/jsobjects.cpp:
3053         (EventSender::keyDown):
3054
3055 2007-10-24  Lars Knoll  <lars@trolltech.com>
3056
3057         Reviewed by Simon.
3058
3059         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3060
3061         * DumpRenderTree/qt/DumpRenderTree.cpp:
3062         (WebCore::DumpRenderTree::DumpRenderTree):
3063         (WebCore::DumpRenderTree::initJSObjects):
3064         * DumpRenderTree/qt/jsobjects.cpp:
3065         (TextInputController::doCommand):
3066
3067 2007-10-24  Lars Knoll  <lars@trolltech.com>
3068
3069         Reviewed by Simon.
3070
3071         first bit of implementation for the textinputcontroller.
3072
3073         * DumpRenderTree/qt/DumpRenderTree.cpp:
3074         (WebCore::DumpRenderTree::DumpRenderTree):
3075         * DumpRenderTree/qt/DumpRenderTree.h:
3076         * DumpRenderTree/qt/jsobjects.cpp:
3077         (TextInputController::TextInputController):
3078         (TextInputController::doCommand):
3079         * DumpRenderTree/qt/jsobjects.h:
3080
3081 2007-10-24  Lars Knoll  <lars@trolltech.com>
3082
3083         Reviewed by Simon.
3084
3085         make the man webpage believe it has focus, so the editing tests work correctly.
3086
3087         * DumpRenderTree/qt/DumpRenderTree.cpp:
3088         (WebCore::DumpRenderTree::DumpRenderTree):
3089
3090 2007-10-24  Lars Knoll  <lars@trolltech.com>
3091
3092         Reviewed by Simon.
3093
3094         implement layoutTestController.dumpEditingCallbacks() correctly.
3095
3096         * DumpRenderTree/qt/DumpRenderTree.cpp:
3097         (WebCore::DumpRenderTree::DumpRenderTree):
3098         * DumpRenderTree/qt/jsobjects.cpp:
3099         (LayoutTestController::reset):
3100         (LayoutTestController::dumpEditingCallbacks):
3101
3102 2007-10-24  Lars Knoll  <lars@trolltech.com>
3103
3104         Reviewed by Simon.
3105
3106         Implement support for testing editing.
3107
3108         * DumpRenderTree/qt/DumpRenderTree.cpp:
3109         (WebCore::DumpRenderTree::DumpRenderTree):
3110
3111 2007-10-23  Sam Weinig  <sam@webkit.org>
3112
3113         Check for null BSTR that can be passed to the UIDelegate methods
3114         from javascript null and undefined.  Fixes a failing test case on
3115         Windows (fast/dom/Window/alert-undefined.html)
3116
3117         Reviewed by Eric Seidel.
3118
3119         * DumpRenderTree/win/UIDelegate.cpp:
3120         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3121         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3122         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3123         (UIDelegate::webViewAddMessageToConsole):
3124
3125 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3126
3127         Reviewed by Darin.
3128         
3129         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3130
3131         * Scripts/build-testkjs:
3132
3133 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3134
3135         Reviewed by Darin.
3136
3137         - add wrapper that finds the right copy of testkjs
3138         
3139         * Scripts/sunspider-compare-results: Added.
3140
3141 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3142
3143         Reviewed by Sam.
3144
3145         - After talking with Steve I now see that the WebKit server must be
3146         running for DCOM to create the distributed objects, which makes sense
3147         and currently WebKit only allows one instance to be running at a time
3148         which avoids accidentally connecting to the wrong server
3149         - In light of this I have removed the code for the attach box and
3150         NotificationServer and known server names, since they are all extranious
3151         now.
3152
3153         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3154         names.
3155         (_tWinMain): Uses init instead of initUI.
3156         (droseraWndProc): No longer creats an attach dialog box.
3157         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3158         it's not manditory to call init before doing COM stuff.
3159         (Drosera::init): calls initUI and will call attach when the
3160         functionality exists. 
3161         (Drosera::initUI): Has changed very little.
3162         (Drosera::attach): Changed the signature to reflect that we no longer
3163         need the dictionary of known server names.
3164         * Drosera/win/Drosera.h: Removed notification classes and known server
3165         names.  Also renamed and moved some functions.
3166         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3167         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3168         headers to the resources folder. 
3169         * Drosera/win/resource.h: Removed the Attach box.
3170
3171 2007-10-22  Adam Roben  <aroben@apple.com>
3172
3173         Windows build fix
3174
3175         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3176
3177 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3178
3179         - Removed a leak that was fixed.
3180
3181         * Scripts/run-webkit-tests:
3182
3183 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3184
3185         Reviewed by Darin.
3186
3187         - Changed the Client so that the DebuggerDocument now own the
3188         ServerConnection.  This simplifies ownership and cleanup. 
3189
3190         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3191         ServerConnection.
3192         (DebuggerClient::initWithServerName):
3193         (DebuggerClient::didFinishLoadForFrame):
3194         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3195         ServerConnection.
3196         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3197         until after we have a server which we are attached to.
3198         (Drosera::initUI):
3199         (Drosera::attach):
3200         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3201         out previously.
3202
3203 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3204
3205         Reviewed by Nikolas.
3206
3207         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3208
3209         * Scripts/run-javascriptcore-tests:
3210
3211 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3212
3213         Reviewed by Nikolas.
3214
3215         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3216
3217         * Scripts/build-drosera:
3218         * Scripts/build-dumprendertree:
3219         * Scripts/build-testkjs:
3220         * Scripts/build-webkit:
3221         * Scripts/run-javascriptcore-tests:
3222         * Scripts/run-sunspider:
3223         * Scripts/run-webkit-tests:
3224         * Scripts/webkitdirs.pm:
3225
3226 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3227
3228         Reviewed by Mark Rowe.
3229         
3230         Fix for local database support after r26879
3231         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3232
3233         * Scripts/build-webkit:
3234
3235 2007-10-22  Holger Freyther  <zecke@selfish.org>
3236
3237         Reviewed by Simon Hausmann <hausmann@kde.org>.
3238
3239         - Do not build testkjs as an application bundle. This is
3240         needed for run-javascriptcore-tests on OSX.
3241         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3242         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3243         as we do not have -rpath on OSX.
3244
3245         * DumpRenderTree/qt/DumpRenderTree.pro:
3246         * Scripts/run-webkit-tests:
3247
3248 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3249
3250         Reviewed by aroben.
3251
3252         Fix support for Signed-off-by detection in prepare-ChangeLog
3253         --git-commit. The Signed-off-by tag does not appear in the header
3254         but usually at the end.
3255
3256         * Scripts/prepare-ChangeLog:
3257
3258 2007-10-21  Mark Rowe  <mrowe@apple.com>
3259
3260         Reviewed by Eric.
3261
3262         Fix run-javascriptcore-tests for Gtk.
3263
3264         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3265
3266 2007-10-20  Eric Seidel  <eric@webkit.org>
3267
3268         Reviewed by aroben.
3269
3270         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3271
3272 2007-10-20  Eric Seidel  <eric@webkit.org>
3273
3274         Reviewed by darin.
3275         
3276         Add improved argument handling to run-sunspider, including
3277         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3278         Also re-factor code into subroutines
3279
3280         * Scripts/build-dumprendertree: removed bogus comments
3281         * Scripts/build-testkjs: Added.
3282         * Scripts/run-javascriptcore-tests: use build-testkjs
3283         * Scripts/run-sunspider: improved argument handling, abstraction
3284         * Scripts/run-webkit-tests: improved abstraction
3285
3286 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3287
3288         Not reviewed, Windows build fix.
3289
3290         * DumpRenderTree/win/EventSender.cpp:
3291         (keyDownCallback):
3292
3293 2007-10-20  Darin Adler  <darin@apple.com>
3294
3295         Reviewed by Tim Hatcher.
3296
3297         - http://bugs.webkit.org/show_bug.cgi?id=15544
3298           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3299           not rely on Apple-specific key codes
3300
3301         * DumpRenderTree/mac/EventSendingController.mm:
3302         (-[EventSendingController keyDown:withModifiers:]):
3303         Added named key "rightArrow". Later we could have a whole table of these.
3304         Also tweaked modifiers code a little.
3305
3306         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3307
3308 2007-10-19  Darin Adler  <darin@apple.com>
3309
3310         Reviewed by Eric.
3311
3312         - http://bugs.webkit.org/show_bug.cgi?id=15566
3313           possible fix for leak seen in DumpRenderTree
3314
3315         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3316         Delete the item if it's not put on the queue, since the caller has
3317         no way of knowing that. Would be better to have the parameter type
3318         be auto_ptr to express the fact that we take ownership.
3319
3320         - unrelated change
3321
3322         * Drosera/mac/main.m: Add missing include.
3323
3324 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3325
3326         Reviewed by Adam.
3327
3328         - This change should be identical but for some reason was not working
3329         on my machine.
3330
3331         * Scripts/prepare-ChangeLog:
3332
3333 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3334
3335         Reviewed by Oliver and Tim.
3336
3337         - Made use of RetainPtr to avoid retain and release issues and moved the
3338         log function to DebuggerDocumentPlatform, which seems to be a more
3339         logical place for it to live.
3340         - Also moved knownServers from the ServerConnection to
3341         DebuggerApplication to match the Windows code and because it makes sense
3342         that a connection knows its own server but not all of them.
3343
3344         * Drosera/mac/DebuggerClient.h: Moved the log function to
3345           DebuggerDocumentPlatform.
3346         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3347           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3348           call for the server name up from the ServerConnection class.
3349         (-[DebuggerClient dealloc]):
3350         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3351           for the server name up from the ServerConnection.
3352         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3353         (DebuggerDocument::platformPause):
3354         (DebuggerDocument::platformResume):
3355         (DebuggerDocument::platformStepInto):
3356         (DebuggerDocument::platformEvaluateScript):
3357         (DebuggerDocument::getPlatformCurrentFunctionStack):
3358         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3359         (DebuggerDocument::platformValueForScopeVariableNamed):
3360         (DebuggerDocument::platformLog): Log directly from here. No need to call
3361           DebuggerClient.
3362         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3363           way I see it, a ServerConnection should only know about its connection
3364           and the group of all possible servers should be kept by the
3365           application.
3366         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3367           currentServerName, it makes sense that the connection should know that
3368           name.
3369         (-[ServerConnection currentServerName]):
3370
3371 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3372
3373         Reviewed by Adam.
3374
3375         - Integrated changes from mac drosera.  Recently I've encapsulated
3376         out the server connection object from the rest of Drosera because
3377         it is very platform dependent right now and RPC is not implemented on
3378         windows.  This functionality, of communicating with the WebKit server
3379         is the next area I will be focusing on in Windows.
3380
3381         - Other changes and cleanup were made to organize the code and add notes
3382         on which parts still need work.  Also some mac code is added and
3383         commented out, to act as pseudocode for the logic of those parts.
3384
3385         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3386           pointer.
3387         * Drosera/config.h: Added whitespace.
3388         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3389           these files got moved into Drosera.h/cpp
3390         * Drosera/win/DebuggerApplication.h: Removed.
3391         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3392           happened here to better match the logic flow of the same code on the 
3393           mac side and to use the new ServerConnection class.
3394         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3395         (DebuggerClient::initWithServerName): Initializer that will set up the
3396           class to use a ServerConnection object.  This was necessary so I could
3397           create a DebuggerClient without having to initilaize it at
3398           construction.
3399         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3400           will be the UIDelegate and FrameLoadDelegate.
3401         (DebuggerClient::AddRef): For IUnknown.
3402         (DebuggerClient::Release): For IUnknown.
3403         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3404           this still needs to set the global context of the server, but
3405           IWebFrame does not have an accessor for the global context yet. 
3406         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3407           this is a pass through for the same function in the document.
3408         (DebuggerClient::didReceiveTitle): Unimplemented part of
3409           FrameLoadDelegate this would change the title of the window.
3410         (DebuggerClient::createWebViewWithRequest): Part of the
3411           FrameLoadDelegate.  This is about new windows via Window.open() and
3412           how their delegates are set.
3413         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3414           UIDelegate.  Just a debug function for printing messages.
3415         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3416           because the Client should be the UIDelegate and FrameLoadDelegate
3417           to match the delegates on mac.
3418         (DebuggerClient::webViewLoaded): Added accessor method.
3419         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3420           forgotten to add this file before.  This is where the platform
3421           dependent versions of the Documents functions live. Most of these are
3422           unimplemented because some piece of functionality does not exist on
3423           Windows yet.
3424         (DebuggerDocument::platformPause):
3425         (DebuggerDocument::platformResume):
3426         (DebuggerDocument::platformStepInto):
3427         (DebuggerDocument::platformEvaluateScript):
3428         (DebuggerDocument::getPlatformCurrentFunctionStack):
3429         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3430         (DebuggerDocument::platformValueForScopeVariableNamed):
3431         (DebuggerDocument::platformLog):
3432         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3433           responsibilities becaue they belong in the Client. Also I laid the
3434           groundwork for attaching Drosera to a WebKit process
3435         (attachWndProc): Now if a server is selected the Client becomes it's
3436           delegate.
3437         (Drosera::Drosera): Added the construction of the Client and dictionary
3438           of server names. 
3439         (Drosera::initUI): This is no longer the delegates, the Client is.
3440         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3441           state. 
3442         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3443           notification registration when it's possible to implement.
3444         (Drosera::serverLoaded): Ditto
3445         (Drosera::serverUnloaded): Ditto
3446         (Drosera::attach): Attach Drosera to the WebKit server.
3447         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3448         (Drosera::getInst): 
3449         (Drosera::setInst):
3450         (Drosera::knownServers):
3451         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3452           and added the ServerConnection.
3453         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3454         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3455           Most of the functions are completely unimlemented because they cannot
3456           connect with the WebKit server, because one does not exist on Windows
3457           yet.
3458         (ServerConnection::initWithServerName): 
3459         (ServerConnection::~ServerConnection):
3460         (ServerConnection::setGlobalContext):
3461         (ServerConnection::pause):
3462         (ServerConnection::resume):
3463         (ServerConnection::stepInto):
3464         (ServerConnection::switchToServerNamed):
3465         (ServerConnection::applicationTerminating):
3466         (ServerConnection::serverConnectionDidDie):
3467         (ServerConnection::currentFrame):
3468         * Drosera/win/ServerConnection.h: Added. Ditto.
3469         (ServerConnection::ServerConnection):
3470
3471 2007-10-19  Alice Liu  <alice.liu@apple.com>
3472
3473         Reviewed by Darin.
3474
3475         Fix for these broken layout tests on Windows:
3476         
3477         fast/forms/focus-selection-input.html
3478         fast/forms/focus-selection-textarea.html
3479         fast/forms/select-accesskey.html
3480         
3481         * DumpRenderTree/win/EventSender.cpp:
3482         (keyDownCallback):
3483         correct the VK code for alt key.
3484         
3485 2007-10-19  Eric Seidel  <eric@webkit.org>
3486
3487         Reviewed by Mark Rowe.
3488         
3489         Make the GtkLauncher code slightly more readable.
3490
3491         * GtkLauncher/main.cpp:
3492         (setupMainMenu): Added.
3493         (setupMainWindowUI): Added.
3494         (main):
3495
3496 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3497
3498         Rubber stamped by Adam.
3499         
3500         - don't delay-load WebKit in DumpRenderTree.
3501
3502         * DumpRenderTree/win/DumpRenderTree.vcproj:
3503
3504 2007-10-18  Dan Bernstein  <mitz@apple.com>
3505
3506         Reviewed by Adam Roben.
3507
3508         - fix <rdar://problem/5313523>
3509         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3510
3511         * DumpRenderTree/mac/DumpRenderTree.mm:
3512         (dump): Changed to use _responseMIMEType.
3513
3514 2007-10-17  Adam Roben  <aroben@apple.com>
3515
3516         Make it possible to have Windows-specific tests and results
3517
3518         When searching for tests to run and the Skipped file, we will only
3519         look in platform/win and the cross-platform directory. When looking
3520         for expected results, we will look in platform/win, then
3521         platform/mac-leopard, then platform/mac, then finally the
3522         cross-platform directory.
3523
3524         Reviewed by Sam.
3525
3526         * Scripts/run-webkit-tests:
3527         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3528         searching in the cross-platform directory.
3529         (sub buildPlatformHierarchy): Removed some unneeded calls to
3530         dirname/basename.
3531
3532 2007-10-17  Adam Roben  <aroben@apple.com>
3533
3534         Add back the call to register WebKit that we had before WebKitInitializer existed
3535
3536         This is needed to ensure that the right WebKit is used when
3537         instantiating COM objects.
3538
3539         Reviewed by Oliver.
3540
3541         * DumpRenderTree/win/debug_internal.vsprops: Define
3542         DEBUG_WEBKIT_HAS_SUFFIX.
3543         * DumpRenderTree/win/DumpRenderTree.cpp:
3544         (initialize):
3545
3546 2007-10-17  Adam Roben  <aroben@apple.com>
3547
3548         Import File::Basename in webkitdirs since we use it
3549
3550         * Scripts/webkitdirs.pm:
3551
3552 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3553
3554         - Updated the tiger leaks list to make the internal bots green.
3555
3556         * Scripts/run-webkit-tests:
3557
3558 2007-10-17  Adam Roben  <aroben@apple.com>
3559
3560         Build fix for VC++ Express
3561
3562         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3563         and ole32.lib.
3564
3565 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3566
3567         Reviewed by Sam.
3568
3569         - Minor mac improvements based on observations I made while implementing the
3570         Windows code.
3571
3572         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3573         then hand it to the Client who will retain it, it should just be the client who
3574         creates and owns the server.
3575         (-[DebuggerApplication attach:]):
3576         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3577         * Drosera/mac/DebuggerClient.mm: Creates the server.
3578         (-[DebuggerClient initWithServerName:]):
3579         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3580         can instead forward declare what it needs.
3581
3582 2007-10-16  Darin Adler  <darin@apple.com>
3583
3584         Reviewed by Geoff Garen.
3585
3586         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3587         want to turn failing tests into platform-specific test results. Also did a
3588         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3589         would take the type of results into account only some of the time.
3590
3591 2007-10-16  Adam Roben  <aroben@apple.com>
3592
3593         Add a new nightly launcher script for Windows
3594
3595         This new script is for versions of Safari that don't delay-load
3596         WebKit. I had to make FindSafari be able to print out the nightly
3597         launcher script on stdout because Windows shell scripts can't capture
3598         the output from a command into an environment variable.
3599
3600         Reviewed by Steve.
3601
3602         * FindSafari/FindSafari.cpp:
3603         (_tmain): Added /printSafariLauncher option.
3604         * Scripts/run-webkit-nightly.cmd: Added.
3605
3606 2007-10-16  Adam Roben  <aroben@apple.com>
3607
3608         Replace WebKitInitializer with FindSafari
3609
3610         We now rely on setting the PATH environment variable to tell Windows
3611         where to find WebKit and its dependencies (similar to
3612         DYLD_FRAMEWORK_PATH on Mac).
3613
3614         This change also make DumpRenderTree no longer delay-load WebKit.
3615
3616         Reviewed by Sam.
3617
3618         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3619         FindSafari.
3620         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3621         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3622         WebKitInitializer, don't delay-load WebKit.
3623         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3624         * Scripts/run-webkit-tests: Ditto.
3625         * Scripts/webkitdirs.pm:
3626         (sub setPathForRunningWebKitApp): Added.
3627         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3628         * WebKitInitializer/WebKitInitializer.h: Removed.
3629         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3630         * WebKitInitializer/debug.vsprops: Removed.
3631         * WebKitInitializer/debug_internal.vsprops: Removed.
3632         * WebKitInitializer/release.vsprops: Removed.
3633