1412ee20d9456e0673ea96e5d1792d9931301abf
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2
3         Unreviewed.
4
5         Add my other email address to committers.py.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
10
11         Reviewed by Csaba Osztrogonác.
12
13         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
14         https://bugs.webkit.org/show_bug.cgi?id=49975
15
16         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
17         to enable the script to define it 0 in case of a minimal build.
18
19 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
20
21         Reviewed by Xan Lopez.
22
23         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
24         https://bugs.webkit.org/show_bug.cgi?id=49143
25
26         * DumpRenderTree/gtk/DumpRenderTree.cpp:
27         (createWebView): Call the new connectEditingCallbacks function.
28         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
29         (dumpNodePath):
30         (dumpRange):
31         (insertActionString):
32         (selectionAffinityString):
33         (shouldBeginEditing):
34         (shouldEndEditing):
35         (shouldInsertNode):
36         (shouldInsertText):
37         (shouldDeleteRange):
38         (shouldShowDeleteInterfaceForElement):
39         (shouldChangeSelectedRange):
40         (shouldApplyStyle):
41         (editingBegan):
42         (userChangedContents):
43         (editingEnded):
44         (selectionChanged):
45         (connectEditingCallbacks):
46         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
47         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
48
49 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
50
51         Reviewed by Andreas Kling.
52
53         [Qt] Make QtTestBrowser remember the selected user agent
54         https://bugs.webkit.org/show_bug.cgi?id=50021
55
56         Set user agent for a new page by using the old page's
57
58         * QtTestBrowser/mainwindow.cpp:
59         (MainWindow::setPage):
60
61 2010-11-24 Patrick Gansterer <paroga@webkit.org>
62
63         Reviewed by Csaba Osztrogonác.
64
65         Remove Bakefile build system files
66         https://bugs.webkit.org/show_bug.cgi?id=49983
67
68         r53757 only removed the content, but not the files.
69         This patch removes that empty files.
70
71         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
72         * wx/browser/browser.bkl: Removed.
73         * wx/build-wxwebkit: Removed.
74
75 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
76
77         Reviewed by Tony Chang.
78
79         This patch cleans up the logic used to shard tests into groups a
80         bit and adds the --worker-model flag to NRWT. The flag is only
81         used at the moment to control whether to run single-threaded or
82         not, but eventually will also allow toggling between threads and
83         processes.
84
85         Also add a minor cleanup with _test_is_slow(), which just
86         eliminates some repetition and gives slightly better encapsulation.
87
88         https://bugs.webkit.org/show_bug.cgi?id=49773
89
90         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
91         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
92
93 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
94
95         Reviewed by Tony Chang.
96
97         Rebaseline server: list current baselines and platforms
98         https://bugs.webkit.org/show_bug.cgi?id=49991
99         
100         List existing baselines (with Trac links) for tests.
101         
102         Add dropdowns for choosing with platform baselines to target (and what
103         to do with existing ones).
104
105         Also fix MockFileSystem.join to behave more like os.path.join (unit
106         test was ending up with two consecutive slashes in a layout test
107         path).        
108
109         * Scripts/webkitpy/common/system/filesystem_mock.py:
110         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
111         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
112         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
113         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
114         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
115         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
116         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
117
118 2010-11-23  Ojan Vafai  <ojan@chromium.org>
119
120         Reviewed by Tony Chang.
121
122         remove timeout argument to urlopen
123         https://bugs.webkit.org/show_bug.cgi?id=49995
124
125         Apparently the version of python we have on the bots doesn't accept a timeout argument.
126
127         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
128
129 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
130
131         Unreviewed, rolling out r72628.
132         http://trac.webkit.org/changeset/72628
133         https://bugs.webkit.org/show_bug.cgi?id=49994
134
135         This patch is causing layout-test failtures on GTK Linux
136         64-bit Debug (Requested by ctguil on #webkit).
137
138         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
139         (AccessibilityUIElement::AccessibilityUIElement):
140         (AccessibilityUIElement::parentElementCallback):
141         * DumpRenderTree/chromium/AccessibilityUIElement.h:
142         * DumpRenderTree/chromium/CppBoundClass.cpp:
143         * DumpRenderTree/chromium/CppBoundClass.h:
144
145 2010-11-22  Ojan Vafai  <ojan@chromium.org>
146
147         Reviewed by Tony Chang.
148
149         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
150         https://bugs.webkit.org/show_bug.cgi?id=49944
151
152         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
153
154 2010-11-23  Chris Guillory  <chris.guillory@google.com>
155
156         Reviewed by Dimitri Glazkov.
157
158         Include the FrameView widget of a RenderWidget in the accessibility tree.
159         https://bugs.webkit.org/show_bug.cgi?id=49106
160
161         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
162         (AccessibilityUIElement::AccessibilityUIElement):
163         (AccessibilityUIElement::parentElementCallback):
164         (AccessibilityUIElement::isEqualCallback):
165         * DumpRenderTree/chromium/AccessibilityUIElement.h:
166         * DumpRenderTree/chromium/CppBoundClass.cpp:
167         (CppBoundClass::getFromCppVariant):
168         * DumpRenderTree/chromium/CppBoundClass.h:
169
170 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
171
172         Reviewed by Kenneth Rohde Christiansen.
173
174         [EFL] Add tiled backing store to EWebLauncher
175         https://bugs.webkit.org/show_bug.cgi?id=45777
176
177         Allow EWebLauncher to choose between single and tiled backing store
178
179         * EWebLauncher/main.c:
180         (on_key_down):
181         (browserCreate):
182         (main):
183
184 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
185
186         Reviewed by Tor Arne Vestbø.
187
188         [Qt] Review the setUserPermission & friends API
189         https://bugs.webkit.org/show_bug.cgi?id=46810
190
191         Renamed requestPermissionFromUser to featurePermissionRequested
192         and cancelRequestsForPermission to featurePermissionRequestCanceled.
193
194         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
195         (WebCore::WebPage::WebPage):
196         * QtTestBrowser/webpage.cpp:
197         (WebPage::WebPage):
198         (WebPage::featurePermissionRequestCanceled):
199         * QtTestBrowser/webpage.h:
200
201 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
202
203         Reviewed by Tor Arne Vestbø.
204
205         [Qt] Review the setUserPermission & friends API
206         https://bugs.webkit.org/show_bug.cgi?id=46810
207
208         Rename setUserPermission to setFeaturePermission
209
210         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
211         (WebCore::WebPage::requestPermission):
212         (WebCore::WebPage::permissionSet):
213         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
214         (LayoutTestController::grantDesktopNotificationPermission):
215         * QtTestBrowser/webpage.cpp:
216         (WebPage::requestPermission):
217
218 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
219
220         Reviewed by Tor Arne Vestbø.
221
222         [Qt] Review the setUserPermission & friends API
223         https://bugs.webkit.org/show_bug.cgi?id=46810
224
225         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
226         and GeolocationPermissionDomain to Geolocation.
227
228         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
229         (WebCore::WebPage::WebPage):
230         (WebCore::WebPage::requestPermission):
231         (WebCore::WebPage::cancelPermission):
232         (WebCore::WebPage::permissionSet):
233         (WebCore::DumpRenderTree::geolocationPermissionSet):
234         * DumpRenderTree/qt/DumpRenderTreeQt.h:
235         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
236         (LayoutTestController::grantDesktopNotificationPermission):
237         * QtTestBrowser/webpage.cpp:
238         (WebPage::WebPage):
239         (WebPage::requestPermission):
240         (WebPage::cancelRequestsForPermission):
241         * QtTestBrowser/webpage.h:
242
243 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
244
245         Reviewed by Tor Arne Vestbø.
246
247         [Qt] Review the setUserPermission & friends API
248         https://bugs.webkit.org/show_bug.cgi?id=46810
249
250         Add a ByUser suffix to PermissionGranted/Denied. In the future
251         we can add PermissionGrantedByDefault.
252
253
254         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
255         (WebCore::WebPage::requestPermission):
256         (WebCore::WebPage::permissionSet):
257         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
258         (LayoutTestController::grantDesktopNotificationPermission):
259         * QtTestBrowser/webpage.cpp:
260         (WebPage::requestPermission):
261
262 2010-11-18  Satish Sampath  <satish@chromium.org>
263
264         Reviewed by Jeremy Orlow.
265
266         For speech input event, send an event object containing all the recognition results and metadata.
267         https://bugs.webkit.org/show_bug.cgi?id=49736
268
269         Updated DRT by renaming the mock result method on all platforms to the new signature.
270
271         * DumpRenderTree/LayoutTestController.cpp:
272         (addMockSpeechInputResultCallback):
273         (LayoutTestController::staticFunctions):
274         * DumpRenderTree/LayoutTestController.h:
275         * DumpRenderTree/chromium/LayoutTestController.cpp:
276         (LayoutTestController::LayoutTestController):
277         (LayoutTestController::addMockSpeechInputResult):
278         * DumpRenderTree/chromium/LayoutTestController.h:
279         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
280         (LayoutTestController::addMockSpeechInputResult):
281         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
282         (LayoutTestController::addMockSpeechInputResult):
283         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
284         (LayoutTestController::addMockSpeechInputResult):
285         * DumpRenderTree/qt/LayoutTestControllerQt.h:
286         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
287         (LayoutTestController::addMockSpeechInputResult):
288         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
289         (LayoutTestController::addMockSpeechInputResult):
290
291 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
292
293         Reviewed by Tony Chang.
294
295         Fix some spacing issues with log messages with
296         new-run-webkit-tests --verbose.
297
298         https://bugs.webkit.org/show_bug.cgi?id=49936
299
300         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
301
302 2010-11-22  Ojan Vafai  <ojan@chromium.org>
303
304         Reviewed by Adam Barth.
305
306         update scm to work with different remote branches
307         https://bugs.webkit.org/show_bug.cgi?id=49949
308
309         This works if there are multiple svn tracking branches
310         and/or if the tracking branch is refs/remots/origin/master
311         instead of refs/remotes/trunk which is the direction we're trying
312         to head since that makes fetches faster.
313
314         * Scripts/webkitpy/common/checkout/scm.py:
315         * Scripts/webkitpy/common/checkout/scm_unittest.py:
316
317 2010-11-22  Hayato Ito  <hayato@chromium.org>
318
319         Reviewed by Shinichiro Hamaji.
320
321         Ignore reference files which will be used by reftests when collecting
322         test cases.
323         https://bugs.webkit.org/show_bug.cgi?id=49835
324
325         * Scripts/webkitpy/layout_tests/port/test_files.py:
326         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
327
328 2010-11-22  Adam Roben  <aroben@apple.com>
329
330         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
331
332         Apple's Windows build allows placing header files and import libraries for WebKit's
333         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
334         $WebKitLibrariesDir environment variable. This is both required for production builds and
335         convenient for Apple-internal developer builds. Apple's production builds also require that
336         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
337         builds, the files are copied into that directory tree by the
338         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
339         copying is done by
340         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
341
342         This .vsprops copying is problematic in one very important case: when a developer updates
343         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
344         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
345         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
346         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
347         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
348         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
349
350         To fix this, we now use normal relative paths to access the .vsprops files in the source
351         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
352         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
353         unset, so the normal relative paths are used to read the .vsprops files out of the source
354         tree directly. In production builds, this environment variable is set to a fake directory
355         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
356         is resolved.
357         
358         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
359
360         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
361
362         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
363         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
364         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
365         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
366         FeatureDefines.vsprops becomes:
367
368         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
369
370         which resolves to:
371
372         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
373
374         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
375         actually exist since they are matched by an equal number of ".." path components.)
376
377         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
378         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
379
380         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
381         updated
382
383         Reviewed by Dave Hyatt.
384
385         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
386         * DumpRenderTree/win/DumpRenderTree.vcproj:
387         * DumpRenderTree/win/ImageDiff.vcproj:
388         * FindSafari/FindSafari.vcproj:
389         * MiniBrowser/MiniBrowser.vcproj:
390         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
391         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
392         * WebKitAPITest/WebKitAPITest.vcproj:
393         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
394         * WebKitTestRunner/win/InjectedBundle.vcproj:
395         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
396         * WinLauncher/WinLauncher.vcproj:
397         * record-memory-win/record-memory-win.vcproj:
398         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
399         files.
400
401 2010-11-22  Adam Roben  <aroben@apple.com>
402
403         Make it possible to run tests on Windows without Visual Studio or VC++
404         Express installed
405
406         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
407         are not installed. But this function doesn't need to be called when we
408         already have a build available and are just trying to run the tests.
409
410         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
411         because Visual Studio/VC++ Express aren't installed
412
413         Reviewed by Dave Hyatt.
414
415         * Scripts/webkitdirs.pm:
416         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
417         it is not needed by this function. Also added a FIXME.
418
419         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
420         relying on determineConfigurationForVisualStudio doing it.
421
422 2010-11-19  Hayato Ito  <hayato@chromium.org>
423
424         Reviewed by Shinichiro Hamaji.
425
426         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
427
428         https://bugs.webkit.org/show_bug.cgi?id=49812
429
430         * Scripts/webkitpy/layout_tests/driver_test.py:
431         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
432         * Scripts/webkitpy/layout_tests/port/base.py:
433         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
434         * Scripts/webkitpy/layout_tests/port/chromium.py:
435         * Scripts/webkitpy/layout_tests/port/dryrun.py:
436         * Scripts/webkitpy/layout_tests/port/test.py:
437         * Scripts/webkitpy/layout_tests/port/webkit.py:
438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
439         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
440
441 2010-11-22  Hayato Ito  <hayato@chromium.org>
442
443         Reviewed by Tony Chang.
444
445         [NRWT] Retry a few times in reading a png image to avoid a race condition.
446
447         https://bugs.webkit.org/show_bug.cgi?id=49924
448
449         * Scripts/webkitpy/layout_tests/port/chromium.py:
450
451 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
452
453         Reviewed by Kenneth Rohde Christiansen.
454
455         Fix EWebLauncher zoom discretization
456         https://bugs.webkit.org/show_bug.cgi?id=49810
457
458         * EWebLauncher/main.c:
459         (nearest_zoom_level_get):
460         (zoom_level_set):
461         (on_load_finished):
462         (on_key_down):
463
464 2010-11-21  Sam Weinig  <sam@webkit.org>
465
466         Rubber-stamped by Dan Bernstein.
467
468         Fix ~300 WebKit2 tests by enabling developer extras preference.
469
470         * WebKitTestRunner/TestController.cpp:
471         (WTR::TestController::resetStateToConsistentValues):
472
473 2010-11-21  Sam Weinig  <sam@webkit.org>
474
475         Reviewed by Dan Bernstein.
476
477         Textareas should be resizable by default
478         https://bugs.webkit.org/show_bug.cgi?id=49892
479
480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
481         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
482         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
483         Add preferences test.
484
485 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
486
487         Reviewed by Tony Chang.
488
489         Rebaseline server: checksum-only differences and prefetching
490         https://bugs.webkit.org/show_bug.cgi?id=49841
491         
492         Add support for image test results where the only difference is in the
493         checksum.
494         
495         Add prefetching of the image results from the next test.
496         
497         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
498         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
499         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
500
501 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
502
503         Reviewed by Tony Chang.
504
505         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
506
507         Add the 'worker number' and 'worker name' concepts to the 
508         TestShellThread objects, and move test_types and test_args from
509         the TestRunner to the TestShellThread.
510
511         https://bugs.webkit.org/show_bug.cgi?id=49768
512
513         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
514         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
515
516 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
517
518         Reviewed by Ojan Vafai.
519
520         Do some minor cleanup and bug fixing.
521
522         https://bugs.webkit.org/show_bug.cgi?id=49777
523
524         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
525         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
526
527 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
528
529         Reviewed by Ojan Vafai.
530
531         nrwt - config.build_directory() is busted
532
533         Fixes a typo that was causing us to usually return the top level
534         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
535         bug was hidden by test stubs that were too simplistic :(.
536
537         https://bugs.webkit.org/show_bug.cgi?id=49815
538
539         * Scripts/webkitpy/common/system/executive_mock.py:
540         * Scripts/webkitpy/layout_tests/port/config.py:
541         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
542
543 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
544
545         Reviewed by Adam Roben.
546
547         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
548         https://bugs.webkit.org/show_bug.cgi?id=49819
549
550         * DumpRenderTree/DumpRenderTree.sln:
551         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
552         * DumpRenderTree/win/DumpRenderTree.vcproj:
553         * DumpRenderTree/win/ImageDiff.vcproj:
554         * FindSafari/FindSafari.vcproj:
555         * MiniBrowser/MiniBrowser.vcproj:
556         * TestWebKitAPI/win/TestWebKitAPI.sln:
557         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
558         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
559         * WebKitAPITest/WebKitAPITest.vcproj:
560         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
561         * WebKitTestRunner/win/InjectedBundle.vcproj:
562         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
563         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
564         * WinLauncher/WinLauncher.vcproj:
565         * record-memory-win/record-memory-win.vcproj:
566
567 2010-11-19  Adam Roben  <aroben@apple.com>
568
569         Add some more Windows slaves
570
571         This is probably more than we will be using in the immediate future,
572         but having some extra slave names makes experimenting with different
573         configurations easier.
574
575         Reviewed by Jon Honeycutt.
576
577         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
578         Windows slaves and distributed them among the three different Test
579         builders.
580
581 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
582
583         Reviewed by Ojan Vafai.
584
585         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
586         https://bugs.webkit.org/show_bug.cgi?id=49702
587
588         Re-landing r72357 with a test fix.
589
590         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
591         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
592         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
593
594 2010-11-19  Avi Drissman  <avi@google.com>
595
596         Reviewed by Antonio Gomes.
597
598         Complete support for Unix editing mode
599         https://bugs.webkit.org/show_bug.cgi?id=49757
600
601         * DumpRenderTree/LayoutTestController.cpp:
602         (setEditingBehaviorCallback):
603         * DumpRenderTree/chromium/LayoutTestController.cpp:
604         (LayoutTestController::setEditingBehavior):
605
606 2010-11-19  Adam Roben  <aroben@apple.com>
607
608         Fix run-javascriptcore-tests when there's a space in the path to
609         testapi
610
611         Reviewed by Sam Weinig.
612
613         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
614         system() to force it to interpret spaces in the path correctly.
615
616 2010-11-19  Adam Roben  <aroben@apple.com>
617
618         Update scripts for .exe name changes after r72327
619
620         As of r72327, the "_debug" suffix is only used in Debug_All builds.
621
622         Reviewed by Sam Weinig.
623
624         * Scripts/run-javascriptcore-tests:
625         (testapiPath):
626
627         * Scripts/sunspider-compare-results:
628         (pathToBuiltJSC):
629
630         * Scripts/webkitdirs.pm:
631         (jscPath):
632         (safariPath):
633
634 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
635
636         Reviewed by Darin Adler.
637
638         Normalize Cairo/CFLite project/solution configuration names
639         https://bugs.webkit.org/show_bug.cgi?id=49818
640
641         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
642         * DumpRenderTree/win/DumpRenderTree.vcproj:
643         * DumpRenderTree/win/ImageDiff.vcproj:
644         * MiniBrowser/MiniBrowser.vcproj:
645         * TestWebKitAPI/win/TestWebKitAPI.sln:
646         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
647         * WebKitAPITest/WebKitAPITest.vcproj:
648         * WebKitTestRunner/win/InjectedBundle.vcproj:
649         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
650         * WinLauncher/WinLauncher.vcproj:
651         * Scripts/webkitdirs.pm: Updated cairo build configs.
652
653 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
654
655         Reviewed by Adam Roben.
656
657         Windows vcproj configuration names should be normalized across projects
658         https://bugs.webkit.org/show_bug.cgi?id=49776
659
660         * DumpRenderTree/DumpRenderTree.sln:
661         * FindSafari/FindSafari.vcproj:
662         * TestWebKitAPI/win/TestWebKitAPI.sln:
663         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
664         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
665         * WebKitAPITest/WebKitAPITest.vcproj:
666         * WebKitAPITest/WebKitAPITestCommon.vsprops:
667         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
668         * WebKitTestRunner/WebKitTestRunner.sln:
669         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
670         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
671         * record-memory-win/record-memory-win.vcproj:
672
673 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
674
675         Build fix - as per DRT-mac, always enabled developer extras,
676         in win/qt/gtk DRT.
677
678         This is necessary to enable rich exception messages to be generated
679         following https://bugs.webkit.org/show_bug.cgi?id=49708.
680
681         * DumpRenderTree/gtk/DumpRenderTree.cpp:
682         (shouldEnableDeveloperExtras):
683         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
684         (WebCore::shouldEnableDeveloperExtras):
685         * DumpRenderTree/win/DumpRenderTree.cpp:
686         (shouldEnableDeveloperExtras):
687
688 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
689
690         Unreviewed, rolling out r72357.
691         http://trac.webkit.org/changeset/72357
692         https://bugs.webkit.org/show_bug.cgi?id=49784
693
694         It broke test-webkitpy tests since the patch didn't have the
695         corresponding test update (Requested by kinuko on #webkit).
696
697         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
698         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
699
700 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
701
702         Reviewed by Tony Chang.
703
704         Rebaseline server: add rebaseline queue
705         https://bugs.webkit.org/show_bug.cgi?id=49763
706         
707         Add a UI queue (a multi-item <select>) where tests to be baselined
708         can be enqueued (also supports basic removal). A queue is used instead
709         of immediately doing rebaselines since SCM operations can take a while.
710         It's better to go through lots of tests quickly to mark them as
711         needing rebaselining and then batch the SCM operations.
712         
713         Also adds a simple log where results can be displayed.
714
715         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
716         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
717         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
718         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
719         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
720         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
721
722 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
723
724         Reviewed by Oliver Hunt.
725
726         Bug 49708 - Stop recompiling functions to regenerate exception info.
727
728         Instead only hold info as necessary – keep divot info is the inspector
729         is enabled, line number info is debugging or profiling, and handler
730         info for functions with try/catch.
731
732         * DumpRenderTree/mac/DumpRenderTree.mm:
733         (shouldEnableDeveloperExtras):
734             - always enable the developer tools from DRT, to ensure we
735               produce rich error messages on JavaScript exceptions.
736
737 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
738
739         Reviewed by Ojan Vafai.
740
741         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
742         https://bugs.webkit.org/show_bug.cgi?id=49702
743
744         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
745         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
746
747 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
748
749         Reviewed by Tony Chang.
750
751         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
752
753         Create the first version of the 'message_broker' package. This
754         class will encapsulate all of the threading/multiprocessing and
755         message-sending details for the communication between the
756         'manager' object and the 'worker' objects. For the moment, it
757         just holds some routines and tests for logging thread stacks.
758
759         There should be no functional changes in this patch, just moving stuff
760         around.
761
762         https://bugs.webkit.org/show_bug.cgi?id=49707
763
764         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
765         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
766         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
767         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
769         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
770
771 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
772
773         Reviewed by Adam Roben.
774
775         Remove leftover Windows Debug_Internal configurations
776         https://bugs.webkit.org/show_bug.cgi?id=49758
777
778         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
779         * DumpRenderTree/win/DumpRenderTree.vcproj:
780         * DumpRenderTree/win/ImageDiff.vcproj:
781         * MiniBrowser/MiniBrowser.vcproj:
782         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
783         * WebKitAPITest/WebKitAPITest.vcproj:
784         * WebKitTestRunner/win/InjectedBundle.vcproj:
785         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
786         * WinLauncher/WinLauncher.vcproj:
787
788 2010-11-18  Adam Roben  <aroben@apple.com>
789
790         Add three new Windows XP build slaves
791
792         Reviewed by Steve Falkenburg.
793
794         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
795         new slaves, and added them to the Windows XP Debug (Tests) builder.
796
797 2010-11-18  Daniel Bates  <dbates@rim.com>
798
799         Reviewed by Adam Roben.
800
801         update-webkit-support-libs should fall back to existing
802         WebKitSupportLibrary version if there is no internet connectivity
803         https://bugs.webkit.org/show_bug.cgi?id=49503
804
805         Fall back to existing support libraries (if present) when there is
806         no internet connection.
807
808         Currently, update-webkit-support-libs dies with an "out-of-date"
809         error when there is no internet connection because it cannot
810         retrieve versioning information from developer.apple.com. Because
811         update-webkit-support-libs fails, build-webkit fails. Instead,
812         if there is no internet connection and the support libraries are
813         present then we should warn the user and exit() with success so
814         that build-webkit can work without an internet connection.
815
816         * Scripts/update-webkit-support-libs:
817
818 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
819
820         Reviewed by Adam Roben.
821
822         Debug_Internal Windows configuration is unnecessary, should be removed
823         https://bugs.webkit.org/show_bug.cgi?id=49753
824
825         * DumpRenderTree/win/DumpRenderTree.cpp:
826         * MiniBrowser/win/stdafx.h:
827         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
828         * WebKitTestRunner/win/TestControllerWin.cpp:
829
830 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
831
832         Reviewed by Adam Roben.
833
834         Clean up vcproj errors
835         https://bugs.webkit.org/show_bug.cgi?id=49741
836
837         * MiniBrowser/MiniBrowser.vcproj:
838         * WebKitAPITest/WebKitAPITest.vcproj:
839         * WebKitTestRunner/win/InjectedBundle.vcproj:
840         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
841
842 2010-11-18  Hayato Ito  <hayato@chromium.org>
843
844         Reviewed by Shinichiro Hamaji.
845
846         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
847         which is caused by r72249.
848
849         https://bugs.webkit.org/show_bug.cgi?id=49751
850
851         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
852
853 2010-11-18  Adam Roben  <aroben@apple.com>
854
855         Implement layoutTestController.waitForPolicyDelegate on Windows
856
857         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
858
859         Reviewed by Simon Fraser.
860
861         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
862         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
863         code from LayoutTestControllerMac.mm.
864
865 2010-11-18  Hayato Ito  <hayato@chromium.org>
866
867         Reviewed by Shinichiro Hamaji.
868
869         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
870
871         https://bugs.webkit.org/show_bug.cgi?id=49740
872
873         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
874
875 2010-11-18  Tony Chang  <tony@chromium.org>
876
877         Reviewed by Adam Barth.
878
879         run platform/chromium/plugins/refcount-leaks.html on all platforms
880         https://bugs.webkit.org/show_bug.cgi?id=49485
881
882         Add PluginObject.testObjectCount which returns the number of allocated
883         TestObjects. Add PluginObject.testCreateTestObject which allocates
884         and returns a TestObject.
885
886         Add TestObject.refCount which returns the number of refs on the
887         TestObject.
888
889         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
890         (pluginGetProperty):
891         (pluginInvoke):
892         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
893         (getTestObjectCount):
894         (testAllocate):
895         (testDeallocate):
896         (testGetProperty):
897         (testScriptObjectInvoke): Release a ref to a plugin object that was
898             previously leaked.
899         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
900
901 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
902
903         Reviewed by Adam Roben.
904
905         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
906         https://bugs.webkit.org/show_bug.cgi?id=49711
907
908         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
909         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
910         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
911         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
912         * record-memory-win/record-memory-win-common.vsprops: Added.
913         * record-memory-win/record-memory-win.vcproj:
914
915 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
916
917         Reviewed by Csaba Osztrogonác.
918
919         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
920
921         * MiniBrowser/qt/BrowserWindow.cpp:
922         (BrowserWindow::updateUserAgentList):
923
924 2010-11-17  Adam Roben  <aroben@apple.com>
925
926         Don't trigger Windows builds when chromium-win test results change
927
928         Reviewed by Mark Rowe.
929
930         * Scripts/webkitpy/common/config/build.py:
931         (_should_file_trigger_build): Changed the regular expression used to
932         search for directory names to only consider full directory names,
933         rather than matching directory names where the string we care about is
934         a suffix of the name.
935
936         * Scripts/webkitpy/common/config/build_unittest.py:
937         (ShouldBuildTest): Added a test.
938
939 2010-11-17  Hayato Ito  <hayato@chromium.org>
940
941         Reviewed by Shinichiro Hamaji.
942
943         Remove a uri member from TestInput class.
944
945         https://bugs.webkit.org/show_bug.cgi?id=49691
946
947         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
948         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
949
950 2010-11-17  Adam Roben  <aroben@apple.com>
951
952         Move FindSafari's settings into a vsprops file
953
954         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
955
956         Reviewed by Steve Falkenburg.
957
958         * FindSafari/FindSafari.vcproj:
959         * FindSafari/FindSafariCommon.vsprops: Added.
960
961 2010-11-17  Adam Roben  <aroben@apple.com>
962
963         Use a minimum font size of 0 in DRT on Windows
964
965         This is the Windows equivalent of r72164.
966
967         Rubber-stamped by Dave Hyatt.
968
969         * DumpRenderTree/win/DumpRenderTree.cpp:
970         (resetDefaultsToConsistentValues):
971
972 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
973
974         Reviewed by Andreas Kling.
975
976         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
977         https://bugs.webkit.org/show_bug.cgi?id=49639
978
979         * Scripts/webkitpy/common/checkout/scm.py:
980
981 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
982
983         Reviewed by Tony Chang.
984
985         Rebaseline server: add loupe for image diffs
986         https://bugs.webkit.org/show_bug.cgi?id=49692
987         
988         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
989         enlarged area of the expected, actual and diff images side by side.
990
991         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
992         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
993         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
994         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
995
996 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
997
998         Reviewed by Adam Roben.
999
1000         WebKitLauncherWin should use vsprops for shared build settings
1001         https://bugs.webkit.org/show_bug.cgi?id=49696
1002
1003         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1004         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1005
1006 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1007
1008         Reviewed by Adam Roben.
1009
1010         WinLauncher should use vsprops for shared build settings
1011         https://bugs.webkit.org/show_bug.cgi?id=49695
1012
1013         * WinLauncher/WinLauncher.cpp:
1014         (_tWinMain):
1015         (PrintView):
1016         (WndProc):
1017         (MyEditProc):
1018         * WinLauncher/WinLauncher.vcproj:
1019         * WinLauncher/WinLauncherCommon.vsprops: Added.
1020
1021 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1022
1023         Delete unused file unintentionally added in last change.
1024
1025         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1026
1027 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1028
1029         Reviewed by Adam Roben.
1030
1031         DumpRenderTree on Windows should use a vsprops file for shared project settings
1032         https://bugs.webkit.org/show_bug.cgi?id=49690
1033
1034         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1035         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1036         * DumpRenderTree/win/DumpRenderTree.vcproj:
1037         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1038         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1039         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1040         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1041         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1042         * DumpRenderTree/win/ImageDiff.vcproj:
1043         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1044
1045 2010-11-17  Hayato Ito  <hayato@chromium.org>
1046
1047         Refactor TestTypeBase.compare_output().
1048
1049         Introduce a TestOutput class and update compare_output() of each test
1050         types so that they can take both actual and expected TestOutput objects.
1051
1052         https://bugs.webkit.org/show_bug.cgi?id=49431
1053
1054         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1055         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1056         * Scripts/webkitpy/layout_tests/port/base.py:
1057         * Scripts/webkitpy/layout_tests/port/chromium.py:
1058         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1059         * Scripts/webkitpy/layout_tests/port/test.py:
1060         * Scripts/webkitpy/layout_tests/port/webkit.py:
1061         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1062         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1063         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1064         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1065
1066 2010-11-17  Adam Roben  <aroben@apple.com>
1067
1068         Make each Windows Test builder use the same OS for all its slaves
1069
1070         Currently each WebKit1 Windows Test builder has one Windows XP slave
1071         and one Windows 7 slave. Having different OSes in a single builder
1072         meant that the builders would alternate between red and green when
1073         there were OS-specific failures.
1074
1075         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1076         between red and green because of multiple OS versions
1077
1078         Reviewed by Mark Rowe.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1081         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1082         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1083         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1084         builders for the two WebKit1 builders so that they would all use the
1085         appropriate OS.
1086
1087 2010-11-17  James Robinson  <jamesr@chromium.org>
1088
1089         Reviewed by Dan Bernstein.
1090
1091         [chromium] Set minimum font size to 0 for DRT
1092         https://bugs.webkit.org/show_bug.cgi?id=49677
1093
1094         Followup for http://trac.webkit.org/changeset/72141.
1095
1096         Test: http/tests/misc/acid3.html
1097
1098         * DumpRenderTree/chromium/WebPreferences.cpp:
1099         (WebPreferences::reset):
1100
1101 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1102
1103         Unreviewed build fix.
1104
1105         [Qt] Add missing file I forgot in r72220.
1106
1107         * MiniBrowser/MiniBrowser.qrc: Added.
1108
1109 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1110
1111         Reviewed by Andreas Kling.
1112
1113         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1114         https://bugs.webkit.org/show_bug.cgi?id=49627
1115
1116         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1117
1118         * MiniBrowser/MiniBrowser.qrc: Added.
1119         Add it here to prevent qmake from detecting it
1120         since it needs to be copied to the build directory.
1121         * MiniBrowser/qt/BrowserWindow.cpp:
1122         (BrowserWindow::BrowserWindow):
1123         (BrowserWindow::updateUserAgentList):
1124         (BrowserWindow::showUserAgentDialog):
1125         * MiniBrowser/qt/BrowserWindow.h:
1126         * MiniBrowser/qt/MiniBrowser.pro:
1127
1128 2010-11-17  Adam Roben  <aroben@apple.com>
1129
1130         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1131
1132         We use that file on Windows!
1133
1134         Fixes <http://webkit.org/b/49643> Changes to
1135         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1136
1137         Reviewed by Steve Falkenburg.
1138
1139         * Scripts/webkitpy/common/config/build.py:
1140         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1141         trigger builds on SnowLeopard and Windows.
1142
1143         * Scripts/webkitpy/common/config/build_unittest.py:
1144         (ShouldBuildTest.test_should_build): Added a test.
1145
1146 2010-11-17  Satish Sampath  <satish@chromium.org>
1147
1148         Reviewed by Jeremy Orlow.
1149
1150         Clear the speech input mock explicitly before each test.
1151         https://bugs.webkit.org/show_bug.cgi?id=49660
1152
1153         * DumpRenderTree/chromium/LayoutTestController.cpp:
1154         (LayoutTestController::setMockSpeechInputResult):
1155         * DumpRenderTree/chromium/LayoutTestController.h:
1156         * DumpRenderTree/chromium/WebViewHost.cpp:
1157         (WebViewHost::speechInputController):
1158         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1159         * DumpRenderTree/chromium/WebViewHost.h:
1160         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1161
1162 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1163
1164         Unreviewed, specify IRC nickname in committers.py.
1165
1166         * Scripts/webkitpy/common/config/committers.py:
1167
1168 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1169
1170         Reviewed by Tony Chang.
1171
1172         [NRWT] Make http locking similar to perl implementation
1173         https://bugs.webkit.org/show_bug.cgi?id=49187
1174
1175         * Scripts/webkitpy/common/system/file_lock.py: Added.
1176         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1177         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1178
1179 2010-11-17  MORITA Hajime  <morrita@google.com>
1180
1181         Reviewed by Kent Tamura.
1182
1183         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1184         https://bugs.webkit.org/show_bug.cgi?id=49366
1185
1186         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1187           according to the spellchecker suggestion
1188         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1189
1190         test_expectations.txt will be changed after this change is ported to test_shell.
1191         
1192         * DumpRenderTree/chromium/EventSender.cpp:
1193         (makeMenuItemStringsFor):
1194         (EventSender::contextClick):
1195         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1196         (MockSpellCheck::fillSuggestionList):
1197         (MockSpellCheck::initializeIfNeeded):
1198         * DumpRenderTree/chromium/MockSpellCheck.h:
1199         * DumpRenderTree/chromium/WebViewHost.cpp:
1200         (WebViewHost::mockSpellCheck):
1201         * DumpRenderTree/chromium/WebViewHost.h:
1202
1203 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1204
1205         Reviewed by Sam Weinig.
1206
1207         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1208         since the bots have 1 stuck in their plist otherwise.
1209
1210         * DumpRenderTree/mac/DumpRenderTree.mm:
1211         (resetDefaultsToConsistentValues):
1212
1213 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1214
1215         Reviewed by Tony Chang.
1216
1217         Rebaseline server: compute diffs client-side
1218         https://bugs.webkit.org/show_bug.cgi?id=49640
1219         
1220         The image diff output from the DRT is pretty bad on some ports (at
1221         least the Mac one), so it's better to compute diffs on the client by
1222         using <canvas>.
1223
1224         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1225         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1226         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1227
1228 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1229
1230         Reviewed by Tony Chang.
1231
1232         Rebaseline server: display test results
1233         https://bugs.webkit.org/show_bug.cgi?id=49626
1234         
1235         Adds basic result display to the rebaseline server. On the Python side
1236         this involves:
1237         - Parsing the unexpected_results.json into a dictionary.
1238         - Serving it as JSON under /results.json.
1239         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
1240         but I'll need to have access to the parsed results on the Python side
1241         for follow-up changes).
1242         
1243         On the web UI side this adds:
1244         - Markup for display image and text results (expected, actual, diff),
1245           and JS for populating it.
1246         - Markup for breaking down test results by failure type and directory,
1247           and JS for populating it.
1248
1249         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1250         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1251         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1252         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
1253         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1254
1255 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1256
1257         Reviewed by Ojan Vafai.
1258
1259         See Chromium issue http://codereview.chromium.org/5133001/ - we
1260         are modifying the build bots to pass in the builder name with
1261         the "GPU" string appended instead of appending it in the code.
1262
1263         https://bugs.webkit.org/show_bug.cgi?id=49636
1264
1265         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1266
1267 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
1268
1269         Reviewed by Adam Roben.
1270
1271         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
1272         https://bugs.webkit.org/show_bug.cgi?id=49632
1273
1274         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1275         * DumpRenderTree/win/DumpRenderTree.vcproj:
1276         * DumpRenderTree/win/ImageDiff.vcproj:
1277         * MiniBrowser/MiniBrowser.vcproj:
1278         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1279         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1280         * WebKitTestRunner/win/InjectedBundle.vcproj:
1281         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1282         * WinLauncher/WinLauncher.vcproj:
1283         * record-memory-win/record-memory-win.vcproj:
1284
1285 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1286
1287         Reviewed by Ojan Vafai.
1288
1289         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
1290
1291         Rename the TestInfo class to TestInput to be clearer about its
1292         function, and move the checksum-reading code into dump_render_tree_thread
1293         to avoid cross-thread access.
1294
1295         https://bugs.webkit.org/show_bug.cgi?id=49573
1296
1297         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1298         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1299         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1300
1301 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1302
1303         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
1304
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (resetDefaultsToConsistentValues):
1307
1308 2010-11-16  Stephanie Lewis  <slewis@apple.com>
1309
1310         Reviewed by Geoff Garen.
1311
1312         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
1313
1314         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
1315         for every WebView, and the WebKit API doesn't support that ownership model.
1316
1317         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
1318
1319         * DumpRenderTree/mac/DumpRenderTree.mm:
1320         (createWebViewAndOffscreenWindow):
1321         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1322         (LayoutTestController::setMockDeviceOrientation):
1323
1324 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
1325
1326         Reviewed by Ojan Vafai.
1327
1328         new-run-webkit-tests: log the process id in --verbose mode
1329
1330         As part of the switch to multi-process mode, we should log the
1331         process id when running w/ --verbose.
1332
1333         https://bugs.webkit.org/show_bug.cgi?id=49571
1334
1335         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1336
1337 2010-11-16  Adam Roben  <aroben@apple.com>
1338
1339         Only trigger Windows builds when files that we actually use on Windows
1340         are changed
1341
1342         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
1343         It uses the new webkitpy.common.config.build module to determine
1344         whether a particular change should trigger a build on a particular
1345         platform. The Windows builders have been switched to use a
1346         PlatformSpecificScheduler.
1347
1348         The logic to determine whether or not a particular change should
1349         trigger a build on a given platform has only been implemented/tested
1350         for Windows. I tried to make it easy to add more platforms in the
1351         future, but I don't have enough familiarity with all platforms to be
1352         able to implement it for them.
1353
1354         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
1355         lots irrelevant changes (e.g., rebaselining Chromium test results)
1356
1357         Reviewed by Eric Seidel.
1358
1359         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
1360         PlatformSpecificScheduler for the Windows builders.
1361
1362         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1363         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
1364         up a ChangeFilter that filters to our branch and will call through to
1365         our filter method, and calls up to our base class.
1366         (PlatformSpecificScheduler.filter): Calls through to
1367         build.should_build to find out whether we should trigger a build for
1368         this change.
1369
1370         * Scripts/webkitpy/common/net/build.py: Added.
1371         (_should_file_trigger_build): Uses a set of directories and regexp
1372         patterns to determine whether the given file should trigger a build on
1373         the given platform. As mentioned earlier, this has only been
1374         implemented for Windows, though I did try to make some guesses about
1375         other platforms.
1376         (should_build): Returns true if any of the files should trigger a
1377         build on the given platform.
1378
1379         * Scripts/webkitpy/common/net/build_unittest.py: Added.
1380         (ShouldBuildTest.test_should_build): Does some basic testing to make
1381         sure we're triggering builds for the right files. It only tests
1382         Windows for now, though I tried to make some guesses about other
1383         platforms.
1384
1385 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1386
1387         Reviewed by Andreas Kling.
1388
1389         [Qt] Remove synchronous QWebPage::checkPermissions signal
1390         https://bugs.webkit.org/show_bug.cgi?id=46810
1391
1392         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1393         (WebCore::WebPage::WebPage):
1394         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1395         (LayoutTestController::grantDesktopNotificationPermission): When granting
1396         permission, grant it directly on the QWebPage/Frame, that will remember it.
1397         * QtTestBrowser/webpage.cpp:
1398         (WebPage::WebPage):
1399         * QtTestBrowser/webpage.h:
1400
1401
1402 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
1403
1404         Reviewed by Csaba Osztrogonác.
1405
1406         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
1407
1408         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1409         (LayoutTestController::reset):
1410         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1411         (LayoutTestController::isPrinting):
1412         (LayoutTestController::setPrinting):
1413
1414 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
1415
1416         Reviewed by Andreas Kling.
1417
1418         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
1419         https://bugs.webkit.org/show_bug.cgi?id=49587
1420
1421         * MiniBrowser/qt/BrowserView.cpp:
1422         (BrowserView::BrowserView): Added BackingStoreType
1423         argument to ctor. Propagating it to the QGraphicsWKView.
1424         * MiniBrowser/qt/BrowserView.h:
1425         * MiniBrowser/qt/BrowserWindow.cpp:
1426         (BrowserWindow::BrowserWindow):
1427         (BrowserWindow::newWindow): Create the new BrowserWindow
1428         with the same BackingStoreType that this instance has.
1429         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
1430         * MiniBrowser/qt/main.cpp:
1431         (main): Use tiled backing store if got -tiled command line argument.
1432         Avoid redundant copy of command line args.
1433
1434 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
1435
1436         Reviewed by Jeremy Orlow.
1437
1438         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
1439         https://bugs.webkit.org/show_bug.cgi?id=48506
1440
1441         This ensures that there is one mock per page WebView / WebViewHost. This is a
1442         design constraint of the DeviceOrientationClientMock because the m_controller
1443         field can only store a pointer to a single instance of the corresponding
1444         DeviceOrientationController.
1445
1446         Test: fast/dom/DeviceOrientation/no-page-cache.html
1447
1448         * DumpRenderTree/chromium/LayoutTestController.cpp:
1449         (LayoutTestController::setMockDeviceOrientation):
1450         (LayoutTestController::deviceOrientationClientMock):
1451         * DumpRenderTree/chromium/LayoutTestController.h:
1452         * DumpRenderTree/chromium/WebViewHost.cpp:
1453         (WebViewHost::deviceOrientationClientMock):
1454         (WebViewHost::deviceOrientationClient):
1455         (WebViewHost::reset):
1456         * DumpRenderTree/chromium/WebViewHost.h:
1457
1458 2010-11-15  Andras Becsi  <abecsi@webkit.org>
1459
1460         Reviewed by Andreas Kling.
1461
1462         [Qt][WK2] Avoid polling in WebKitTestRunner.
1463         https://bugs.webkit.org/show_bug.cgi?id=49542
1464
1465         Make the WK2 testing session about 10-15% faster and decrease random flakiness
1466         resulting from timing skew by removing the millisecond polling from TestControllerQt.
1467
1468         * WebKitTestRunner/TestController.cpp:
1469         (WTR::TestController::didFinishLoadForFrame):
1470         * WebKitTestRunner/TestController.h:
1471         * WebKitTestRunner/TestInvocation.cpp:
1472         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1473         * WebKitTestRunner/mac/TestControllerMac.mm:
1474         (WTR::TestController::notifyDone): Add method stub.
1475         * WebKitTestRunner/qt/TestControllerQt.cpp:
1476         (WTR::TestControllerRunLoop::instance):
1477         (WTR::TestControllerRunLoop::start):
1478         (WTR::TestControllerRunLoop::stop):
1479         (WTR::TestControllerRunLoop::TestControllerRunLoop):
1480         (WTR::TestControllerRunLoop::timerEvent):
1481         (WTR::TestController::notifyDone):
1482         (WTR::TestController::platformRunUntil):
1483         * WebKitTestRunner/win/TestControllerWin.cpp:
1484         (WTR::TestController::notifyDone): Add method stub.
1485
1486 2010-11-15  Darin Adler  <darin@apple.com>
1487
1488         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
1489
1490 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
1491
1492         Reviewed by Andreas Kling.
1493
1494         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
1495         https://bugs.webkit.org/show_bug.cgi?id=49544
1496
1497         Add the shortcut to BrowserWindow.
1498
1499         * MiniBrowser/qt/BrowserWindow.cpp:
1500         (BrowserWindow::BrowserWindow):
1501         (BrowserWindow::openLocation):
1502         * MiniBrowser/qt/BrowserWindow.h:
1503
1504 2010-11-14  David Levin  <levin@chromium.org>
1505
1506         Reviewed by Daniel Bates.
1507
1508         check-webkit-style should detect PassRefPtr usage in functions.
1509         https://bugs.webkit.org/show_bug.cgi?id=49513
1510
1511         * Scripts/webkitpy/style/checkers/cpp.py:
1512         (check_for_function_lengths): Revert a comment change that I
1513          accidentally made in r71986.
1514         (check_pass_ptr_usage): Added the code to do the check.
1515         (process_line): Added the call to check_pass_ptr_usage.
1516         (CppChecker): Added the new error category.
1517         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1518         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
1519          testing purposes.
1520         (PassPtrTest::*): The class/functions to unit test the new
1521          functionality.
1522
1523 2010-11-14  David Levin  <levin@chromium.org>
1524
1525         Reviewed by Shinichiro Hamaji.
1526
1527         check-webkit-style function detection and the line count style checks should be separate.
1528         https://bugs.webkit.org/show_bug.cgi?id=49512
1529
1530         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
1531         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
1532           call the detection function and fix line counts in two places now that
1533           the code really only counts the lines in the body of the function.
1534
1535 2010-11-14  Andreas Kling  <kling@webkit.org>
1536
1537         Reviewed by Antonio Gomes.
1538
1539         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
1540         https://bugs.webkit.org/show_bug.cgi?id=33438
1541
1542         Stifle "Unhandled variable" warning to match what the other
1543         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
1544         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
1545
1546         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1547         (webkit_test_plugin_get_value):
1548
1549 2010-11-13  David Levin  <levin@chromium.org>
1550
1551         Reviewed by Eric Seidel.
1552
1553         check-webkit-style function detection crashes on functions in templates.
1554         https://bugs.webkit.org/show_bug.cgi?id=49504
1555
1556         For example "template <bool shouldClose(const Element*)>".
1557
1558         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
1559         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
1560           function detection test to expose this issue.
1561
1562 2010-11-12  David Levin  <levin@chromium.org>
1563
1564         Reviewed by Shinichiro Hamaji.
1565
1566         check-webkit-style function detection doesn't detect indented functions declaractions.
1567         https://bugs.webkit.org/show_bug.cgi?id=49446
1568
1569         Indented function declarations occur inside class definitions, so
1570         they are a pretty common (and worth detecting).
1571
1572         * Scripts/webkitpy/style/checkers/cpp.py:
1573           Changed regex to allow indentation.
1574           Changed the function start detection to only happen when not in a
1575           function.
1576           Changed function end detection to work based on matching braces
1577           instead of finding a close brace at the beginning of the line.
1578           Fixed close_expression to do what it says when it doesn't find
1579           the close.
1580         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
1581
1582 2010-11-12  Daniel Bates  <dbates@rim.com>
1583
1584         Rubber-stamped by Nikolas Zimmermann.
1585
1586         Make do-file-rename rename files in the directory WebKit2.
1587
1588         This also makes the list of searched directories in do-file-rename
1589         consistent with the list of searched directories in the script do-webcore-rename.
1590
1591         * Scripts/do-file-rename:
1592
1593 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
1594
1595         Reviewed by James Robinson.
1596
1597         Attempt yet again to land the fix for bug 49360 (respecting
1598         set-webkit-configuration). We need to handle the cases where
1599         trying to run webkit-build-directory to find out where the
1600         default configuration might be fails (that shows up on some
1601         Chromium bots that apparently don't have perl installed).
1602
1603         https://bugs.webkit.org/show_bug.cgi?id=49360
1604
1605         * Scripts/webkitpy/layout_tests/port/config.py:
1606         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
1607         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1608
1609 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
1610
1611         Reviewed by Adam Barth.
1612
1613         webkit-patch land logs commit message twice
1614         https://bugs.webkit.org/show_bug.cgi?id=49482
1615         
1616         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
1617         that's just the commit message, which we now output following the
1618         actual commit.
1619
1620         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1621
1622 2010-11-12  Tony Chang  <tony@chromium.org>
1623
1624         Reviewed by Adam Barth.
1625
1626         run platform/chromium/plugins/script-object-invoke.html on all platforms
1627         https://bugs.webkit.org/show_bug.cgi?id=49280
1628
1629         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1630         (testScriptObjectInvoke):
1631         (pluginInvoke):
1632
1633 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
1634
1635         Reviewed by Adam Barth.
1636
1637         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
1638         https://bugs.webkit.org/show_bug.cgi?id=49471
1639
1640         Right now there's no indication of a successful commit.
1641         
1642         * Scripts/webkitpy/tool/commands/download_unittest.py:
1643         * Scripts/webkitpy/tool/steps/commit.py:
1644
1645 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
1646
1647         Reviewed by Ojan Vafai.
1648
1649         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
1650         https://bugs.webkit.org/show_bug.cgi?id=49354
1651
1652         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
1653
1654         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1655         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1656         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1657         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1658
1659 2010-11-12  Tony Chang  <tony@chromium.org>
1660
1661         Reviewed by Kent Tamura.
1662
1663         [chromium] Load a blank page when closing DRT WebViewHosts
1664         https://bugs.webkit.org/show_bug.cgi?id=49417
1665
1666         In test_shell, when we close a window, we first load about:blank
1667         and run GC to fire the destruction logic of the page.  In test_shell,
1668         this happens in ~TestShell.  In DRT, we manage virtual windows as
1669         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
1670
1671         Managing focus is a bit trickier, since normally you would get window
1672         events to reset the focus to the right window.  We do it manually
1673         instead.
1674
1675         This fixes 2 plugin tests on DRT.
1676
1677         * DumpRenderTree/chromium/TestShell.cpp:
1678         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
1679         (TestShell::closeWindow): Move widget close() to WVH destructor and
1680             manage focus manually.
1681         (TestShell::closeRemainingWindows): Comment typo.
1682         * DumpRenderTree/chromium/WebViewHost.cpp:
1683         (WebViewHost::closeWidget):
1684         (invokeCloseWidget):
1685         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
1686             test_shell).
1687         (WebViewHost::~WebViewHost):
1688         * DumpRenderTree/chromium/WebViewHost.h:
1689
1690 2010-11-12  David Levin  <levin@chromium.org>
1691
1692         Reviewed by Adam Barth.
1693
1694         cpp.py needs some tidying.
1695         https://bugs.webkit.org/show_bug.cgi?id=49443
1696
1697         * Scripts/webkitpy/style/checkers/cpp.py:
1698           Fix parameter ordering for iteratively_replace_matches_with_char
1699           to mirror other similar functions (and improved comments, etc.)
1700           Also, use a python-ism (for/else) to get rid of a variable that
1701           was there to determine if something had been found in the loop.
1702
1703 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
1704
1705         Reviewed by James Robinson.
1706
1707         [Chromium/DRT] Make EventSendingController send complete touch events.
1708         https://bugs.webkit.org/show_bug.cgi?id=49285
1709
1710         * DumpRenderTree/chromium/EventSender.cpp:
1711         (EventSender::addTouchPoint):
1712         (EventSender::updateTouchPoint):
1713         (EventSender::sendCurrentTouchEvent):
1714
1715 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
1716
1717         Unreviewed rollout of r71858.
1718
1719         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
1720         NaCl tests.
1721
1722         * Scripts/webkitpy/layout_tests/port/config.py:
1723         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
1724         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1725
1726 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
1727
1728         Reviewed by Kenneth Rohde Christiansen.
1729
1730         [Qt] TestController::runUntil doesn't honor the timeout parameter
1731         https://bugs.webkit.org/show_bug.cgi?id=48941
1732
1733         Implement the missing timeout of WebKitTestRunner for Qt.
1734
1735         A QElapsedTimer has been added to RunUntilConditionLoop in order
1736         to measure how long the loop has been running. When the timer
1737         is bigger or equal than the timeout, the loop ends even if the
1738         condition is not met.
1739
1740         * WebKitTestRunner/qt/TestControllerQt.cpp:
1741         (WTR::RunUntilConditionLoop::start):
1742         (WTR::RunUntilConditionLoop::run):
1743         (WTR::RunUntilConditionLoop::timerEvent):
1744         (WTR::TestController::platformRunUntil):
1745
1746 2010-11-11  David Levin  <levin@chromium.org>
1747
1748         Reviewed by Shinichiro Hamaji.
1749
1750         check-webkit-style function detection doesn't handle templates with spaces.
1751         https://bugs.webkit.org/show_bug.cgi?id=49427
1752
1753         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
1754           finding the function name.
1755         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
1756           template with a space.
1757
1758 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1759
1760         Reviewed by Shinichiro Hamaji.
1761
1762         Enable check-webkit-style on Qt files
1763         https://bugs.webkit.org/show_bug.cgi?id=48322
1764
1765         Adding exception for _q_... private slots and
1766         ..._data() methods in tests
1767
1768         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
1769         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
1770
1771 2010-11-11  David Levin  <levin@chromium.org>
1772
1773         Reviewed by Shinichiro Hamaji.
1774
1775         check-webkit-style function detection doesn't work for templates and destructors.
1776         https://bugs.webkit.org/show_bug.cgi?id=49425
1777
1778         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
1779         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
1780
1781 2010-11-11  Joone Hur  <joone@kldp.org>
1782
1783         Reviewed by Antonio Gomes.
1784
1785         [GTK][DRT] Implement LayoutTestController::nodesFromRect
1786         https://bugs.webkit.org/show_bug.cgi?id=46598
1787
1788         Support nodesFromRect in DRT
1789
1790         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1791         (LayoutTestController::nodesFromRect):
1792
1793 2010-11-11  MORITA Hajime  <morrita@google.com>
1794
1795         Reviewed by Kent Tamura.
1796
1797         editing/selection/context-menu-on-text.html fails on chromium
1798         https://bugs.webkit.org/show_bug.cgi?id=45898
1799
1800         Enhance Chromium's EventSender::contextClick() to return
1801         array of menu strings. The implementation incomplete because
1802         Although actual context menu is implemented by the browser,
1803         it reflects editability of underlying context thus makes
1804         context-menu-on-text.html passed.
1805         
1806         * DumpRenderTree/chromium/EventSender.cpp:
1807         (makeMenuItemStringsFor): Added.
1808         (EventSender::contextClick): Now returns array of menu strings.
1809         * DumpRenderTree/chromium/WebViewHost.cpp:
1810         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
1811         (WebViewHost::clearContextMenuData): Added.
1812         (WebViewHost::lastContextMenuData): Added.
1813         * DumpRenderTree/chromium/WebViewHost.h:
1814
1815 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
1816
1817         Unreviewed, build fix.
1818
1819         fix build breakage caused by fix for bug 49380 (r71858).
1820
1821         config_standalone needs to ensure that the packages it needs are
1822         in sys.path.
1823
1824         https://bugs.webkit.org/show_bug.cgi?id=49419
1825
1826         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1827
1828 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
1829
1830         Reviewed by Adam Roben.
1831
1832         Fix NRWT to respect set-webkit-configuration again :(
1833
1834         This change fixes a typo in config.py that was causing the wrong
1835         value to be read initially and us never actually looking into
1836         the filesystem to get the default configuration.
1837         
1838         * Scripts/webkitpy/layout_tests/port/config.py:
1839         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
1840         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1841
1842 2010-11-11  Eric Seidel  <eric@webkit.org>
1843
1844         Reviewed by Adam Barth.
1845
1846         Split out Bug, Attachment and CommitterValidator from bugzilla.py
1847         https://bugs.webkit.org/show_bug.cgi?id=49403
1848
1849         CommitterValidator really had nothing to do with bugzilla.py.
1850         I've put it next to committers.py for now since its rather tied to that file.
1851
1852         * Scripts/webkitpy/common/config/committervalidator.py: Added.
1853         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
1854         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
1855         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
1856         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
1857         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
1858         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1859         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1860         * Scripts/webkitpy/tool/bot/feeders.py:
1861         * Scripts/webkitpy/tool/commands/queues.py:
1862
1863 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
1864
1865         Reviewed by Eric Seidel.
1866
1867         fix missing 'pid' argument for http lockfile checking on win32
1868         https://bugs.webkit.org/show_bug.cgi?id=49363
1869
1870         * Scripts/webkitpy/common/system/executive.py:
1871
1872 2010-11-11  Eric Seidel  <eric@webkit.org>
1873
1874         Rubber-stamped by Adam Barth.
1875
1876         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
1877         https://bugs.webkit.org/show_bug.cgi?id=49402
1878
1879         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
1880         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
1881         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
1882
1883 2010-11-10  Chris Guillory  <chris.guillory@google.com>
1884
1885         Reviewed by Chris Fleizach.
1886
1887         Use IAccessibleComparable to compare accessibility objects.
1888         https://bugs.webkit.org/show_bug.cgi?id=49118
1889
1890         * DumpRenderTree/AccessibilityUIElement.cpp:
1891         (AccessibilityUIElement::isEqual):
1892         * DumpRenderTree/AccessibilityUIElement.h:
1893         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1894         (comparableObject):
1895         (AccessibilityUIElement::isEqual):
1896
1897 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1898
1899         Reviewed by David Hyatt.
1900
1901         HTML5 Ruby support should be mandatory feature
1902         https://bugs.webkit.org/show_bug.cgi?id=49272
1903
1904         Remove Ruby as optional feature.
1905
1906         * Scripts/build-webkit:
1907
1908 2010-11-10  Adam Roben  <aroben@apple.com>
1909
1910         Print VC++ Express build logs in the same order that the projects are
1911         built
1912
1913         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
1914         in an unhelpful order
1915
1916         Reviewed by Eric Seidel.
1917
1918         * Scripts/print-vse-failure-logs:
1919         (PrintVisualStudioExpressLogs._build_order): Added. Uses
1920         print-msvc-project-dependencies to figure out the order in which
1921         projects are built.
1922         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
1923         based on their build order and project name.
1924         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
1925         scripts directory from here...
1926         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
1927         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
1928         them.
1929
1930 2010-11-10  Adam Roben  <aroben@apple.com>
1931
1932         Only print the interesting text from VC++ Express build logs
1933
1934         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
1935         output from print-vse-failure-logs
1936
1937         Reviewed by Eric Seidel.
1938
1939         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
1940         added newly-required imports. Removed a comment that was essentially a
1941         FIXME, and is now fixed.
1942         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
1943         BeautifulSoup to extract the relevant text from the build log.
1944         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
1945
1946 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
1947
1948         Reviewed by Tony Chang.
1949
1950         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
1951         https://bugs.webkit.org/show_bug.cgi?id=49286
1952         
1953         The tests in http/tests/security/XFrameOptions started to fail after
1954         r71297, since it changed the WebViewHost::assignIdentifierToRequest
1955         logic to always assign identifiers to requests, even if we're not going
1956         to be dumping resource load callbacks at that point. These tests
1957         only call LayoutTestController.dumpResourceLoadCallbacks after the
1958         request is started, thus their expectations have "<unknown>" as the
1959         identifier. Change WebViewHost to the previous behavior, which also
1960         match the other ports'.
1961
1962         * DumpRenderTree/chromium/WebViewHost.cpp:
1963         (WebViewHost::assignIdentifierToRequest):
1964         (WebViewHost::removeIdentifierForRequest):
1965
1966 2010-11-08  Tony Chang  <tony@chromium.org>
1967
1968         Reviewed by Adam Barth.
1969
1970         run platform/chromium/plugins/return-npobject.html on all platforms
1971         https://bugs.webkit.org/show_bug.cgi?id=49103
1972
1973         This tests that we can get an NPObject returned through a method on
1974         an NPAPI Object.
1975
1976         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1977         (testCallbackReturn):
1978         (pluginInvoke):
1979
1980 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1981
1982         Unreviewed, rolling out r71672.
1983         http://trac.webkit.org/changeset/71672
1984         https://bugs.webkit.org/show_bug.cgi?id=49276
1985
1986         It doesn't work on Chromium Windows bot (Requested by Ossy on
1987         #webkit).
1988
1989         * Scripts/webkitpy/common/system/file_lock.py: Removed.
1990         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
1991         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1992
1993 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1994
1995         Reviewed by Tony Chang.
1996
1997         [NRWT] Make http locking similar to perl implementation
1998         https://bugs.webkit.org/show_bug.cgi?id=49187
1999
2000         * Scripts/webkitpy/common/system/file_lock.py: Added.
2001         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2002         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2003
2004 2010-11-09  James Kozianski  <koz@chromium.org>
2005
2006         Reviewed by Eric Seidel.
2007
2008         Clean up imports for webkit-patch.
2009         https://bugs.webkit.org/show_bug.cgi?id=49083
2010
2011         Move some imports from commands into main.py where they are used.
2012         Move command imports into the __init__ of the commands module.
2013
2014         * Scripts/webkitpy/tool/commands/__init__.py:
2015         * Scripts/webkitpy/tool/commands/download.py:
2016         * Scripts/webkitpy/tool/commands/queues.py:
2017         * Scripts/webkitpy/tool/main.py:
2018
2019 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2020
2021         Reviewed by Andreas Kling.
2022
2023         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2024         https://bugs.webkit.org/show_bug.cgi?id=49047
2025
2026         * QtTestBrowser/mainwindow.cpp:
2027         (MainWindow::setAddressUrl):
2028
2029 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2030
2031         Reviewed by Csaba Osztrogonác.
2032
2033         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2034         https://bugs.webkit.org/show_bug.cgi?id=49252
2035
2036         * Scripts/old-run-webkit-tests:
2037
2038 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2039
2040         Reviewed by Tor Arne Vestbø.
2041
2042         Output of old-run-webkit-tests is buggy in verbose mode
2043         https://bugs.webkit.org/show_bug.cgi?id=49249
2044
2045         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2046
2047 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2048
2049         Reviewed by Martin Robinson.
2050
2051         [GTK] Link with target name set does not work
2052         https://bugs.webkit.org/show_bug.cgi?id=48865
2053
2054         When a new page is created with a name (target=myFrame), the new
2055         mainFrame could not be found because they where not stored in the
2056         same PageGroup. As PageGroup are not exposed externally so the
2057         simpliest solution is to use a global page group name. This also fixes
2058         issue with visited link coloration across pages. After this change the
2059         private function webkit_web_view_set_group_name() was no longer used
2060         so it was removed completly.
2061
2062         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2063         (createWebView):
2064
2065 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2066
2067         Reviewed by Kent Tamura.
2068
2069         WebViewHost::reset() uses placement new.
2070         https://bugs.webkit.org/show_bug.cgi?id=49069
2071
2072         WebViewHost is using placement destruction / new to simulate a fresh
2073         WebViewHost object at the same address. This is because the WebView remains
2074         open across tests and maintains a pointer to the WebViewHost.
2075         This change resets member variables explictly instead of the placement new dance.
2076
2077         * DumpRenderTree/chromium/WebViewHost.cpp:
2078         (WebViewHost::WebViewHost):
2079         (WebViewHost::reset):
2080
2081 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2082
2083         Reviewed by Eric Seidel.
2084
2085         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2086         It turns out that NRWT can't use the code in scm.find_checkout_root()
2087         because the Chromium bots don't do full checkouts of the WebKit
2088         tree; they only check out subdirectories like WebKitTools/Scripts.
2089         Until we can figure out a better approach for this, I've
2090         restored the base_dir-detecting code from NRWT, which works in
2091         any directory tree, scm or no.
2092
2093         This also restores the files modified in r71475 and r71474.
2094
2095         https://bugs.webkit.org/show_bug.cgi?id=49151
2096
2097         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2098         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2099
2100 2010-11-08  Eric Seidel  <eric@webkit.org>
2101
2102         Reviewed by Adam Barth.
2103
2104         webkit-patch failure-reason explodes if a build is missing
2105         https://bugs.webkit.org/show_bug.cgi?id=49195
2106
2107         This is likely a recent regression.  Adding a unit test for this case.
2108
2109         * Scripts/webkitpy/common/net/buildbot.py:
2110         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2111
2112 2010-11-08  Dan Bernstein  <mitz@apple.com>
2113
2114         Reviewed by Darin Adler.
2115
2116         Ignore the system scrollbar setting.
2117
2118         * DumpRenderTree/mac/DumpRenderTree.mm:
2119         (resetDefaultsToConsistentValues): Set the scrollbar default.
2120
2121 2010-11-05  Adam Roben  <aroben@apple.com>
2122
2123         Make webkitpy.common.system.executive_unittest pass when running under
2124         Win32 Python
2125
2126         Fixes <http://webkit.org/b/49033>.
2127
2128         Reviewed by Dave Levin and Eric Seidel.
2129
2130         * Scripts/webkitpy/common/system/executive.py:
2131         (Executive._run_command_with_teed_output): Pass the arguments through
2132         encode_argument_if_needed rather than using Cygwin-specific code here.
2133         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2134         the output.
2135         (Executive.run_command): Use encode_argument_if_needed to encode the
2136         arguments and child_process_encoding to decode the output.
2137         (Executive._child_process_encoding): Returns the encoding that should be
2138         used when communicating with child processes. On Windows we use mbcs,
2139         which maps to the current code page. On all other platforms we use
2140         UTF-8.
2141         (Executive._should_encode_child_process_arguments): Returns True if
2142         arguments to child processes need to be encoded. This is currently
2143         only needed on Cygwin and Win32 Python 2.x.
2144         (Executive._encode_argument_if_needed): Encode the argument using
2145         child_process_encoding if we need to encode arguments to child
2146         processes on this platform.
2147
2148         * Scripts/webkitpy/common/system/executive_unittest.py:
2149         (never_ending_command): Added. Returns arguments to run a command that
2150         will not quit until we kill it. On Windows we use wmic, on other
2151         platforms we use yes.
2152         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2153         mbcs encoding to be used and for output from the child processes to
2154         have been roundtripped through encode/decode on Win32 Python. When
2155         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2156         it's possible that some characters will not be able to be converted
2157         and will be replaced by question marks; the round-tripping allows us
2158         to expect this result.
2159
2160         (ExecutiveTest.test_kill_process):
2161         (ExecutiveTest.test_kill_all):
2162         Use never_ending_command instead of invoking "yes" directly. Expect an
2163         exit code of 1 when using Win32 Python, as that's what seems to happen.
2164
2165 2010-11-08  Adam Roben  <aroben@apple.com>
2166
2167         Roll out r71532
2168
2169         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2170         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2171
2172         * Scripts/webkitdirs.pm:
2173
2174 2010-11-08  Tony Chang  <tony@chromium.org>
2175
2176         Reviewed by Adam Barth.
2177
2178         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2179         https://bugs.webkit.org/show_bug.cgi?id=49094
2180
2181         This tests that objects created by plugins are proplery cleaned up.
2182
2183         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2184         (testPassTestObject):
2185         (pluginInvoke):
2186         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2187         (testAllocate):
2188         (testDeallocate):
2189         (testGetProperty):
2190         (testConstruct):
2191
2192 2010-11-08  Adam Roben  <aroben@apple.com>
2193
2194         Mark Windows builds triggered from Perl as being non-interactive
2195
2196         This affects whether some of our scripts will show alerts vs. printing
2197         to the build log.
2198
2199         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2200         .vsprops files are updated
2201
2202         Reviewed by Steve Falkenburg.
2203
2204         * Scripts/webkitdirs.pm:
2205         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2206
2207 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2208
2209         Reviewed by Ojan Vafai.
2210
2211         Make http locking default in NRWT.
2212         https://bugs.webkit.org/show_bug.cgi?id=48053
2213
2214         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2216
2217 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2218
2219         Reviewed by Csaba Osztrogonác.
2220
2221         [NRWT] If the http lock fails we shouldn't do any locking
2222         https://bugs.webkit.org/show_bug.cgi?id=49164
2223
2224         If something goes wrong with the locking, the test should keep going.
2225
2226         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2227
2228 2010-11-08  Adam Roben  <aroben@apple.com>
2229
2230         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2231         pixel dumps on Windows
2232
2233         I changed this behavior in r71418 thinking that it was required for
2234         getting plugins to show up in pixel dumps. But it doesn't seem to be
2235         necessary, and was making it impossible to compare new Windows pixel
2236         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
2237         compare an image with alpha to an image without alpha).
2238
2239         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
2240         new Windows pixel results to existing Windows or Mac results
2241
2242         Reviewed by Antti Koivisto.
2243
2244         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2245         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
2246         with kCGImageAlphaPremultipliedFirst.
2247
2248 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
2249
2250         Unreviewed, rolling out r71466.
2251         http://trac.webkit.org/changeset/71466
2252         https://bugs.webkit.org/show_bug.cgi?id=48865
2253
2254         It broke layout tests on GTK bots.
2255
2256         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2257         (createWebView):
2258
2259 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2260
2261         Reviewed by Csaba Osztrogonác.
2262
2263         Enable running of Qt API tests on BuildBot
2264         https://bugs.webkit.org/show_bug.cgi?id=49004
2265
2266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2267
2268 2010-11-08  Eric Seidel  <eric@webkit.org>
2269
2270         Reviewed by Adam Barth.
2271
2272         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
2273         https://bugs.webkit.org/show_bug.cgi?id=49160
2274
2275         Bugzilla doesn't automatically remove r? when a bug gets closed.
2276         This script takes care of that for webkit.org.
2277
2278         * Scripts/webkitpy/common/net/bugzilla.py:
2279         * Scripts/webkitpy/tool/commands/upload.py:
2280
2281 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2282
2283         Unreviewed, rolling out r71474.
2284         http://trac.webkit.org/changeset/71474
2285         https://bugs.webkit.org/show_bug.cgi?id=48280
2286
2287         breaks chromium webkit tests
2288         https://bugs.webkit.org/show_bug.cgi?id=49151
2289
2290         * Scripts/webkitpy/layout_tests/port/base.py:
2291         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2292         * Scripts/webkitpy/layout_tests/port/config.py:
2293         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2294         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2295         * Scripts/webkitpy/layout_tests/port/webkit.py:
2296         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2297         * Scripts/webkitpy/tool/mocktool.py:
2298
2299 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
2300
2301         Unreviewed, rolling out r71475.
2302         http://trac.webkit.org/changeset/71475
2303  
2304         breaks chromium webkit tests
2305         https://bugs.webkit.org/show_bug.cgi?id=49151
2306
2307         * Scripts/webkitpy/common/newstringio.py: Removed.
2308         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
2309         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
2310         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
2311         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
2312
2313 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2314
2315         Unreviewed, build fix.
2316
2317         Add files inexplicably not committed in r71474 as part of the
2318         fix for bug 48280.
2319
2320         * Scripts/webkitpy/common/newstringio.py: Added.
2321         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2322         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2323         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2324         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
2325
2326 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2327
2328         Reviewed by Eric Siedel.
2329
2330         new-run-webkit-tests: update port/base and port/webkit to use the
2331         new FileSystem and Config abstractions, pulling more logic out of
2332         the base Port classes into separate, mockable objects.
2333
2334         Also create a MockFileSystem object, a MockConfig object, move
2335         MockExecutive into common/system to be next to executive, and
2336         update the config object to use a FileSystem.
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=48280
2339
2340         * Scripts/webkitpy/common/newstringio.py: Added.
2341         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
2342         * Scripts/webkitpy/common/system/executive_mock.py: Added.
2343         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
2344         * Scripts/webkitpy/layout_tests/port/base.py:
2345         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2346         * Scripts/webkitpy/layout_tests/port/config.py:
2347         * Scripts/webkitpy/layout_tests/port/config_mock.py:
2348         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2349         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2350         * Scripts/webkitpy/layout_tests/port/webkit.py:
2351         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2352         * Scripts/webkitpy/tool/mocktool.py:
2353
2354 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2355
2356         Unreviewed, build breakage.
2357
2358         Apparently I uploaded the wrong version of the file to fix 49122
2359         and neither Eric or I noticed - it was missing a dirname() call.
2360         Fixing ...
2361
2362         https://bugs.webkit.org/show_bug.cgi?id=49122
2363
2364         * Scripts/webkitpy/common/checkout/scm.py:
2365
2366 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
2367
2368         Reviewed by Eric Seidel.
2369
2370         webkitpy/tool/* unittests change cwd and don't clean up properly
2371
2372         https://bugs.webkit.org/show_bug.cgi?id=49122
2373
2374         * Scripts/webkitpy/common/checkout/scm.py:
2375
2376 2010-11-05  Chris Marrin  <cmarrin@apple.com>
2377
2378         Reviewed by Simon Fraser.
2379
2380         suspendAnimations/resumeAnimations not present in WebKit2
2381         https://bugs.webkit.org/show_bug.cgi?id=49109
2382
2383         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2384         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2385         (WTR::LayoutTestController::suspendAnimations):
2386         (WTR::LayoutTestController::resumeAnimations):
2387         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2388
2389 2010-11-05  Tony Chang  <tony@chromium.org>
2390
2391         Reviewed by David Levin.
2392
2393         cleanup style in TestNetscapePlugIn/PluginObject.cpp
2394         https://bugs.webkit.org/show_bug.cgi?id=49044
2395
2396         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2397         (getPluginClass):
2398         (pluginGetProperty):
2399         (pluginSetProperty):
2400         (variantToIdentifier):
2401         (testCallback):
2402         (getURL):
2403         (getURLNotify):
2404         (testInvokeDefault):
2405         (testGetProperty):
2406         (testDocumentOpen):
2407         (testWindowOpen):
2408         (pluginInvoke):
2409         (handleCallback):
2410         (notifyStream):
2411         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2412
2413 2010-11-05  Eric Seidel  <eric@webkit.org>
2414
2415         Reviewed by David Levin.
2416
2417         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
2418         https://bugs.webkit.org/show_bug.cgi?id=49032
2419
2420         I wrote this file as part of bug 47847, but I forgot to commit it.
2421         No one else noticed it missing because test-webkitpy knows how
2422         to recover in the case where it can't import QueueStatusServer
2423         (which generally occurs due to not having installed the AppEngine SDK).
2424
2425         * QueueStatusServer/__init__.py: Added.
2426         * QueueStatusServer/model/workitems_unittest.py:
2427          - Remove a test which fails.  This was probably landed (by me)
2428            from my other machine, which since this __init__.py was missing
2429            I never noticed the failure and landed this invalid test.
2430            Sadly we can't really test remove_work_item as it depends
2431            on .key() working.  .key() will throw unless the object
2432            has already been saved it seems.
2433            This may be a mis-design in our remove_work_item implementation,
2434            but for now, just removing the test.
2435
2436 2010-11-04  Adam Roben  <aroben@apple.com>
2437
2438         Teach check-webkit-style about TestNetscapePlugIn
2439
2440         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
2441         TestNetscapePlugIn's coding conventions
2442
2443         Reviewed by John Sullivan.
2444
2445         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
2446         WebKitAPITest and TestWebKitAPI in having different include order and
2447         naming conventions than WebCore. Added some comments about why the
2448         exceptions exist.
2449
2450 2010-11-04  Adam Roben  <aroben@apple.com>
2451
2452         Add a test that shows that windowed plugins are able to paint
2453
2454         Somehow we never had a test for this before.
2455
2456         Fixes <http://webkit.org/b/49029> Should add a test that shows
2457         windowed plugins can paint
2458
2459         Reviewed by Jon Honeycutt.
2460
2461         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
2462         (DrawsGradient::DrawsGradient):
2463         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
2464
2465         (DrawsGradient::onPaint):
2466         (DrawsGradient::onPrintClient):
2467         These both just call through to paint.
2468
2469         (DrawsGradient::paint): Fills our client area with some gradients.
2470
2471         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
2472         against Msimg32.lib for ::GradientFill and added DrawsGradient.
2473
2474         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2475         (createBitmapContextFromWebView): Use WM_PRINT instead of
2476         WM_PRINTCLIENT so that ::DefWindowProc will send
2477         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
2478         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
2479         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
2480         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
2481         will run on a big-endian platform.
2482
2483 2010-11-04  Adam Roben  <aroben@apple.com>
2484
2485         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
2486         WindowedPluginTest base class
2487
2488         The base class takes care of subclassing the plugin's window so that a
2489         custom WNDPROC is called. This will make it easier to write tests that
2490         need to handle window messages.
2491
2492         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
2493         a custom WNDPROC
2494
2495         Reviewed by Jon Honeycutt.
2496
2497         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
2498         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
2499         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
2500         (NPNInvalidateRectInvalidatesWindow::wndProc):
2501         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
2502         Moved code from here to WindowedPluginTest. Changed to use window()
2503         instead of m_window.
2504
2505         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2506         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
2507         include path. Also reordered the include path to make a little more
2508         sense and simplified the entry that added TestNetscapePlugIn itself to
2509         the include path.
2510
2511         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
2512         (WindowedPluginTest::WindowedPluginTest):
2513         (WindowedPluginTest::NPP_SetWindow):
2514         (WindowedPluginTest::staticWndProc):
2515         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
2516         (WindowedPluginTest::window):
2517         Code came from NPNInvalidateRectInvalidatesWindow.
2518
2519 2010-11-04  Adam Roben  <aroben@apple.com>
2520
2521         Add a plugin test to show that windowed plugins are clipped correctly
2522
2523         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
2524         plugins aren't clipped in WebKit2 on Windows
2525
2526         Reviewed by Jon Honeycutt.
2527
2528         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
2529         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
2530         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
2531         region matches the clip rect we know we should have based on
2532         window-region-is-set-to-clip-rect.html, and check that our window class
2533         doesn't have the CS_PARENTDC style.
2534
2535         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2536         Added WindowRegionIsSetToClipRect.
2537
2538 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
2539
2540         Reviewed by Martin Robinson.
2541
2542         [GTK] Avoid font hinting in the DRT
2543         https://bugs.webkit.org/show_bug.cgi?id=48548
2544
2545         Change the settings to avoid font hinting, it was causing
2546         different results depending on the distribution.
2547
2548         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2549         (initializeGtkFontSettings):
2550         * DumpRenderTree/gtk/fonts/fonts.conf:
2551
2552 2010-11-05  Eric Seidel  <eric@webkit.org>
2553
2554         Reviewed by Adam Barth.
2555
2556         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
2557         https://bugs.webkit.org/show_bug.cgi?id=49051
2558
2559         This is a speculative fix.  The unit tests cover these methods, however
2560         I don't know if this will fully stop the system.log spam.
2561
2562         * Scripts/webkitpy/layout_tests/port/base.py:
2563         * Scripts/webkitpy/layout_tests/port/webkit.py:
2564
2565 2010-11-05  Eric Seidel  <eric@webkit.org>
2566
2567         Reviewed by Adam Barth.
2568
2569         Add basic support for showing bot id on /queue-status/ pages
2570         https://bugs.webkit.org/show_bug.cgi?id=49037
2571
2572         This support is really simple.  Eventually we'll want to
2573         show the bot id in the lock table too, but we don't have
2574         that information stored in the server yet.
2575
2576         * QueueStatusServer/handlers/queuestatus.py:
2577         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
2578         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2579
2580 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
2581
2582         Reviewed by Adam Barth.
2583
2584         Create a filesystem wrapper that we can use to enforce
2585         particular conventions and use for mocking and dependency
2586         injection down the line.
2587
2588         https://bugs.webkit.org/show_bug.cgi?id=48144
2589
2590         * Scripts/webkitpy/common/system/filesystem.py: Added.
2591         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
2592
2593 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2594
2595         Reviewed by Tony Chang.
2596
2597         run_webkit_tests_unittest fails under Python 2.5
2598         https://bugs.webkit.org/show_bug.cgi?id=49043
2599         
2600         Switch from itertools.chain.from_iterable (which was added in 2.6)
2601         to using itertools.chain directly.
2602
2603         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2604
2605 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2606
2607         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
2608         Python 2.5 (it needs an import to use the with statement).
2609
2610         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2611
2612 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
2613
2614         Reviewed by Adam Barth.
2615
2616         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
2617
2618         The current NRWT code has webkit-specific configuration code (like
2619         _script_path, default configuration, etc.) mixed in with
2620         layout-test-specific stuff in port/base. The configuration code
2621         should be split out into a separate module for easier mocking,
2622         testing, and isolation.
2623
2624         https://bugs.webkit.org/show_bug.cgi?id=48264
2625
2626         * Scripts/webkitpy/layout_tests/port/config.py: Added.
2627         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
2628
2629 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2630
2631         Reviewed by Tony Chang.
2632
2633         Rebaseline server: initial framework
2634         https://bugs.webkit.org/show_bug.cgi?id=48892
2635         
2636         Adds the basic framework for the rebaseline server (details at 
2637         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
2638         command, which starts an HTTP server that can serve static files or
2639         invoke handler methods on a class.
2640
2641         * Scripts/webkitpy/tool/commands/__init__.py:
2642         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
2643         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
2644         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
2645         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
2646
2647 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
2648
2649         Reviewed by James Robinson.
2650
2651         new-run-webkit-tests wasn't using DRT by default for
2652         --platform chromium-gpu
2653
2654         The default value was set to False instead of None, which meant
2655         that the platform specific logic wasn't firing to change the
2656         value to True (b/c we were afraid we'd be overriding the user
2657         preference).
2658
2659         https://bugs.webkit.org/show_bug.cgi?id=49038
2660
2661         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2662
2663 2010-11-04  Tony Chang  <tony@chromium.org>
2664
2665         Reviewed by Adam Barth.
2666
2667         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
2668         https://bugs.webkit.org/show_bug.cgi?id=49026
2669
2670         Have the testObject.bar property return the string "bar".  This lets
2671         us run and pass platform/chromium/plugins/multiple-plugins.html on all
2672         platforms.
2673
2674         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2675         (testGetProperty):
2676
2677 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
2678
2679         Reviewed by Tony Chang.
2680
2681         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
2682         https://bugs.webkit.org/show_bug.cgi?id=48878
2683         
2684         Add get_tests_run so that it's easy to see which tests get run (and with
2685         what batching) for a given flag combination. Flesh out the various
2686         test cases that have FIXMEs.
2687         
2688         Also fixes an off-by-one error (batch sizes were one larger than 
2689         expected) and makes --run-part also have wraparound behavior, like
2690         --run-chunk.
2691
2692         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2693         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2694         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2695
2696 2010-11-04  Erik Arvidsson  <arv@chromium.org>
2697
2698         Reviewed by Dimitri Glazkov.
2699
2700         Support box-sizing without the vendor prefix
2701         https://bugs.webkit.org/show_bug.cgi?id=36713
2702
2703         Based on patch by Peter Beverloo <peter@lvp-media.com>
2704
2705         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
2706
2707 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
2708
2709         Unreviewed rollout r71340, because it broke Chromium Windows bot.
2710
2711         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2712         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2713
2714 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2715
2716         Reviewed by Ojan Vafai.
2717
2718         Make http locking default in NRWT.
2719         https://bugs.webkit.org/show_bug.cgi?id=48053
2720
2721         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2722         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2723
2724 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2725
2726         Reviewed by Eric Seidel.
2727
2728         [NRWT] Clear invalid http locks on Windows platform as well
2729         https://bugs.webkit.org/show_bug.cgi?id=48515
2730
2731         * Scripts/webkitpy/common/system/executive.py:
2732         * Scripts/webkitpy/common/system/executive_unittest.py:
2733         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2734
2735 2010-11-02  Adam Roben  <aroben@apple.com>
2736
2737         Reduce our dependence on coreutils when running Python tests
2738
2739         This patch introduces versions of the standard echo and cat utilities
2740         implemented in Python. They are probably missing features of their
2741         coreutils equivalents, but they can do what's necessary for our Python
2742         tests. This is useful on Windows, where these utilities typically
2743         aren't available.
2744
2745         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
2746         and cat utilities from coreutils, which are not present on Windows
2747
2748         Reviewed by Eric Seidel.
2749
2750         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
2751         our Python-based echo and cat.
2752
2753         * Scripts/webkitpy/common/system/fileutils.py: Added.
2754         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
2755         that \n won't be translated into \r\n. I couldn't think of a good way
2756         to test this directly without touching the filesystem, but it is tested
2757         indirectly by echo_unittest.
2758
2759         * Scripts/webkitpy/test/cat.py: Added.
2760         (command_arguments): Returns a list for invoking cat with the given arguments.
2761         (main): Acts like a simplified version of the coreutils cat utility.
2762
2763         * Scripts/webkitpy/test/cat_unittest.py: Added.
2764         (CatTest.assert_cat): Runs cat with the given input and ensures the
2765         output matches the input.
2766         (CatTest.test_basic): Performs a simple test of cat.
2767         (CatTest.test_no_newline): Tests what happens when the input string
2768         doesn't have a trailing newline.
2769         (CatTest.test_unicode): Tests passing a unicode string to cat.
2770         (CatTest.test_as_command): Tests running cat as a separate command.
2771
2772         * Scripts/webkitpy/test/echo.py: Added.
2773         (command_arguments): Returns a list for invoking echo with the given arguments.
2774         (main): Acts like a simplified version of the coreutils echo utility.
2775
2776         * Scripts/webkitpy/test/echo_unittest.py: Added.
2777         (EchoTest.test_basic): Performs a simple test of echo.
2778         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
2779         trailing newline.
2780         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
2781         to echo.
2782         (EchoTest.test_argument_order): Tests what happens when -n is not the
2783         first argument.
2784         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
2785         echo.main.
2786         (EchoTest.test_no_arguments): Tests what happens when you call
2787         echo.main with no arguments.
2788         (EchoTest.test_as_command): Tests running echo as a separate command.
2789
2790 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
2791
2792         Unreviewed: Add myself to the list of Committers.
2793
2794         * Scripts/webkitpy/common/config/committers.py:
2795
2796 2010-11-04  Andreas Kling  <kling@webkit.org>
2797
2798         Reviewed by Kenneth Rohde Christiansen.
2799
2800         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
2801
2802         In RTC mode the QGraphicsWebView item is the size of the contents,
2803         scrolling works a bit differently  (we need to react to scrollRequested.)
2804
2805         Normally QGraphicsView will replay the last mouse event when scrolling,
2806         so to prevent WebKit from getting confused by this we temporarily make
2807         the QGraphicsView non-interactive.
2808
2809         * QtTestBrowser/webview.cpp:
2810         (WebViewGraphicsBased::setPage):
2811         (WebViewGraphicsBased::scrollRequested):
2812         * QtTestBrowser/webview.h:
2813
2814 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2815
2816         Reviewed by Andreas Kling.
2817
2818         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
2819
2820         PLATFORM(MAC) is not defined for the Qt port, as it refers to
2821         the Mac-port, not the Mac OS X operating system.
2822
2823         * WebKitTestRunner/qt/TestControllerQt.cpp:
2824         (WTR::isExistingLibrary):
2825
2826 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
2827
2828         Reviewed by Andreas Kling.
2829
2830         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
2831         https://bugs.webkit.org/show_bug.cgi?id=48869
2832
2833         * QtTestBrowser/useragentlist.txt:
2834
2835 2010-11-03  Adam Roben  <aroben@apple.com>
2836
2837         Always use uppercase drive names in strings returned by abspath_to_uri
2838
2839         Some versions of cygpath use lowercase drive letters while others use
2840         uppercase, which makes it hard to test the output of code that uses
2841         cygpath.
2842
2843         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
2844         fails with Cygwin 1.5
2845
2846         Reviewed by Eric Seidel.
2847
2848         * Scripts/webkitpy/common/system/path.py:
2849         (cygpath): Updated the docstring to indicate that only absolute paths
2850         should be passed for now (though relative paths will work fine).
2851         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
2852
2853 2010-11-03  George Guo  <George.Guo@Nokia.com>
2854
2855         Reviewed by Andreas Kling.
2856
2857         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
2858         https://bugs.webkit.org/show_bug.cgi?id=48767
2859     
2860         Paging is needd on Symbian devices to support benchmarks tests like
2861         dromaeo.com and Celtic Kane that need a lot of memory to run  
2862
2863         * QtTestBrowser/QtTestBrowser.pro:
2864
2865 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
2866
2867         Reviewed by Dmitry Titov.
2868
2869         Chromium: Update resource tracking when moving a frame between documents
2870         https://bugs.webkit.org/show_bug.cgi?id=48363
2871
2872         * DumpRenderTree/chromium/WebViewHost.cpp:
2873         (WebViewHost::assignIdentifierToRequest):
2874         Always put resource id in map so we can make assumptions about its
2875         presence.
2876         (WebViewHost::removeIdentifierForRequest):
2877         Added.
2878         (WebViewHost::didFinishResourceLoad):
2879         (WebViewHost::didFailResourceLoad):
2880         Check existence of resource id before removing from map.
2881         * DumpRenderTree/chromium/WebViewHost.h:
2882
2883 2010-11-03  Victor Wang  <victorw@chromium.org>
2884
2885         Reviewed by Adam Barth.
2886
2887         [Chromium] update buildbot names in chromium rebaseline tool.
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=48881
2890
2891         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2892
2893 2010-11-03  Darin Adler  <darin@apple.com>
2894
2895         Updated Xcode projects by opening them with Xcode 3.2.4.
2896         Updated svn:ignore for Xcode projects.
2897
2898         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
2899         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
2900         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2901         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
2902
2903 2010-11-03  Adam Roben  <aroben@apple.com>
2904
2905         Stop waiting for messages from the web process after a timeout elapses
2906
2907         TestController::runUntil now takes a timeout parameter that specifies
2908         how long to wait for the condition to become true. WebKitTestRunner
2909         takes a --timeout flag that specifies how long the timeout should be.
2910         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
2911         will be similar to run-webkit-tests.
2912
2913         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
2914         WebKitTestRunner waits forever if the web process crashes
2915
2916         Reviewed by Darin Adler and Anders Carlsson.
2917
2918         * Scripts/old-run-webkit-tests:
2919         (top level): Moved the GuardMalloc timeout adjustment here from
2920         readFromDumpToolWithTimer.
2921         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
2922         than the one that was specified on the command line.
2923
2924         * WebKitTestRunner/TestController.cpp:
2925         (WTR::TestController::TestController): Initialize our timeout values.
2926         (WTR::TestController::initialize): Parse the --timeout flag and use it
2927         to modify our timeout values.
2928         (WTR::TestController::resetStateToConsistentValues): Changed to use a
2929         short timeout while waiting for the web process to reset and to return
2930         a boolean indicating whether we were able to reset the web process.
2931         Uses a 5-second timeout while waiting for the process to be reset.
2932         (WTR::TestController::runTest): Changed to return a boolean indicating
2933         whether we were able to reset the web process (and thus run the test).
2934         (WTR::TestController::runUntil): Call through to platformRunUntil.
2935
2936         (WTR::TestController::runTestingServerLoop):
2937         (WTR::TestController::run):
2938         Changed to bail if any test can't be run. This will cause the process
2939         to exit. (Unfortunately this will make run-webkit-tests think we
2940         crashed; see <http://webkit.org/b/48943>.)
2941
2942         * WebKitTestRunner/TestController.h: Added platformRunUntil,
2943         m_longTimeout, and m_shortTimeout.
2944
2945         * WebKitTestRunner/TestInvocation.cpp:
2946         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
2947         initial response and a long timeout when waiting for the test to
2948         complete. Check whether runUntil timed out and print an error message
2949         if so.
2950
2951         * WebKitTestRunner/mac/TestControllerMac.mm:
2952         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
2953         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
2954         won't block waiting for the run loop. Only loop until the timeout
2955         elapses.
2956
2957         * WebKitTestRunner/qt/TestControllerQt.cpp:
2958         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
2959         FIXME about honoring the timeout.
2960
2961         * WebKitTestRunner/win/TestControllerWin.cpp:
2962         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
2963         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
2964         ::PeekMessageW so that we don't block waiting for messages to become
2965         available.
2966
2967 2010-11-03  Adam Roben  <aroben@apple.com>
2968
2969         Add a plugin test that evaluates JS after removing the plugin element
2970         from the document
2971
2972         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
2973         That test was made to prevent a crash very similar to this one, but
2974         unfortunately tested only the mechanism that prevented the crash and
2975         not whether the crash itself was prevented. Since WebKit2 uses a
2976         different mechanism to prevent the crash, the test was failing even
2977         though WebKit2 was not vulnerable to the crash. This new test crashes
2978         if there is no mechanism in place to prevent it and passes in both
2979         WebKit1 and WebKit2.
2980
2981         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
2982         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
2983
2984         Reviewed by Anders Carlsson.
2985
2986         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2987         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2988         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2989         * GNUmakefile.am:
2990         Added new file.
2991
2992         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2993         (pluginDeallocate): Make sure we delete the PluginTest object. This
2994         prevents a leak and also allows us to test the crash.
2995
2996         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2997         (PluginTest::executeScript): Made this into a non-static member
2998         function.
2999
3000         (PluginTest::waitUntilDone):
3001         (PluginTest::notifyDone):
3002         Updated for changes to executeScript.
3003
3004         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
3005
3006         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
3007         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
3008         Initialize ourselves and tell the test harness to wait.
3009         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
3010         plugin element from the document, then execute some JavaScript. If
3011         WebKit does not have appropriate mechanisms in place, we'll be
3012         destroyed inside the first call to executeScript and crash on the
3013         second call.
3014
3015 2010-11-02  Stephen White  <senorblanco@chromium.org>
3016
3017         Reviewed by Tony Chang.
3018
3019         [chromium] Fix LayoutTestController UMRs.
3020         https://bugs.webkit.org/show_bug.cgi?id=48872
3021
3022         * DumpRenderTree/chromium/LayoutTestController.cpp:
3023         (LayoutTestController::LayoutTestController):
3024
3025 2010-11-03  Kent Tamura  <tkent@chromium.org>
3026
3027         Reviewed by Dimitri Glazkov.
3028
3029         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
3030         image dup detection
3031         https://bugs.webkit.org/show_bug.cgi?id=48744
3032
3033         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3034          - Make a function for option parsing for ease of test
3035          - Set 0 to options.tolerance
3036         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3037          - Add a test for this change
3038
3039 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3040
3041         Unreviewed: Add myself to the list of Committers.
3042
3043         * Scripts/webkitpy/common/config/committers.py:
3044
3045 2010-11-02  Anders Carlsson  <andersca@apple.com>
3046
3047         Fix build.
3048
3049         * TestWebKitAPI/PlatformUtilities.cpp:
3050         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3051
3052 2010-11-02  Sam Weinig  <sam@webkit.org>
3053
3054         Reviewed by Anders Carlsson.
3055
3056         Add a way to send startup messages on the context which can be posted when a process launches
3057         <rdar://problem/8617928>
3058         https://bugs.webkit.org/show_bug.cgi?id=48838
3059
3060         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3061         (WKBundleInitialize):
3062         * TestWebKitAPI/InjectedBundleController.cpp:
3063         (TestWebKitAPI::InjectedBundleController::initialize):
3064         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
3065         * TestWebKitAPI/InjectedBundleController.h:
3066         * TestWebKitAPI/InjectedBundleMain.cpp:
3067         (WKBundleInitialize):
3068         * TestWebKitAPI/PlatformUtilities.cpp:
3069         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3070         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3071         (WKBundleInitialize):
3072         Update implementations of WKBundleInitialize to take an initial userData
3073         argument.  Change TestWebKitAPI to use the new initial userData to initialize
3074         each test's bundle.
3075
3076 2010-11-02  Benjamin Kalman  <kalman@google.com>
3077
3078         Reviewed by Ojan Vafai.
3079
3080         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
3081         https://bugs.webkit.org/show_bug.cgi?id=48794
3082
3083         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
3084
3085 2010-11-02  Adam Roben  <aroben@apple.com>
3086
3087         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
3088         Python 2.5.x
3089
3090         It is known to hang on that version of Python. See
3091         <http://webkit.org/b/48614>.
3092
3093         Reviewed by Adam Barth.
3094
3095         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
3096         skip_if to skip MainTest on Cygwin Python 2.5.x.
3097
3098         * Scripts/webkitpy/test/skip.py: Added.
3099         (skip_if): If the passed-in condition is false, find all the test_*
3100         methods of the given class and replace them with a function that just
3101         logs that we're skipping these tests. This is loosely based on the
3102         unittest.skip_if decorator added in Python 3.1.
3103         (_skipped_method): Returns a function that just logs that the tests are
3104         being skipped. This is used in place of the actual test_* functions.
3105
3106         * Scripts/webkitpy/test/skip_unittest.py: Added.
3107         (SkipTest.setUp): Create a logger for ourselves and give it a handler
3108         that logs to a private stream.
3109         (SkipTest.tearDown): Reset the logger.
3110         (SkipTest.create_fixture_class): Returns a class that we use to test
3111         skip_if. It has a single test_* method, test_foo, that just calls
3112         through to a callback.
3113         (SkipTest.foo_callback): Record that test_foo was called.
3114         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
3115         that test_foo does get called.
3116         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
3117         that test_foo does not get called and the appropriate message gets
3118         logged.
3119
3120 2010-11-02  Adam Barth  <abarth@webkit.org>
3121
3122         Reviewed by Eric Seidel.
3123
3124         webkit-patch should tell check-webkit-style which files were changed so
3125         check-webkit-style doesn't have to stat the whole working copy again
3126         https://bugs.webkit.org/show_bug.cgi?id=48792
3127
3128         * Scripts/webkitpy/tool/mocktool.py:
3129         * Scripts/webkitpy/tool/steps/checkstyle.py:
3130
3131 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
3132
3133         Reviewed by James Robinson.
3134
3135         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
3136         https://bugs.webkit.org/show_bug.cgi?id=48777
3137
3138         * DumpRenderTree/chromium/EventSender.cpp:
3139         (EventSender::sendCurrentTouchEvent):
3140
3141 2010-11-02  Adam Roben  <aroben@apple.com>
3142
3143         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
3144         is on
3145
3146         This reverts Windows to our pre-r71097 behavior. That patch made us
3147         track all resource identifiers, including the main resource, so the
3148         main resource's URL started appearing in test output instead of
3149         "<unknown>". Arguably having the main resource's URL is better, but all
3150         other platforms print "<unknown>" and we want to match.
3151
3152         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
3153         (r71097): Many http tests failing on Windows
3154
3155         Reviewed by Anders Carlsson.
3156
3157         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3158         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
3159         identifier to the URL map if we're not supposed to dump resource load
3160         callbacks.
3161         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
3162         identifier from the URL map even if we're already "done". There's no
3163         point in keeping out-of-date identifiers around.
3164
3165 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
3166
3167         Reviewed by Adam Roben.
3168
3169         Windows: Update resource tracking when moving a frame between documents
3170         https://bugs.webkit.org/show_bug.cgi?id=48364
3171
3172         * DumpRenderTree/win/DumpRenderTree.cpp:
3173         (createWebViewAndOffscreenWindow):
3174         (main):
3175         Give each WebView its own ResourceLoadDelegate instance in order to
3176         make assertions about resource ids on a particular WebView.
3177         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3178         (ResourceLoadDelegate::identifierForInitialRequest):
3179         Always add id to the map.
3180         (ResourceLoadDelegate::removeIdentifierForRequest):
3181         Added.
3182         (ResourceLoadDelegate::willSendRequest):
3183         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3184         (ResourceLoadDelegate::didReceiveResponse):
3185         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3186         (ResourceLoadDelegate::didFailLoadingWithError):
3187         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3188         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
3189         * DumpRenderTree/win/ResourceLoadDelegate.h:
3190         (ResourceLoadDelegate::urlMap):
3191         Moved within class so that each WebView has its own id map.
3192
3193 2010-11-01  Ojan Vafai  <ojan@chromium.org>
3194
3195         Reviewed by Dimitri Glazkov.
3196
3197         remove debug code from run_webkit_tests.py
3198         https://bugs.webkit.org/show_bug.cgi?id=48800
3199
3200         Remove temporary debug code and make --master-name required
3201         if --test-results-server is set now that all clients set
3202         --master-name.
3203
3204         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3205
3206 2010-11-01  Tony Chang  <tony@chromium.org>
3207
3208         Reviewed by Kent Tamura.
3209
3210         add plugin event logging for linux
3211         https://bugs.webkit.org/show_bug.cgi?id=48779
3212
3213         This is taken from Chromium's fork of the layout test plugin:
3214         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
3215
3216         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3217         (handleEventX11):
3218         (NPP_HandleEvent):
3219
3220 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
3221
3222         Reviewed by James Robinson.
3223
3224         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
3225         https://bugs.webkit.org/show_bug.cgi?id=48790
3226
3227         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3228         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3229
3230 2010-11-01  Adam Barth  <abarth@webkit.org>
3231
3232         Reviewed by Eric Seidel.
3233
3234         Teach check-webkit-style how to accept a list of files to diff on the
3235         command line
3236         https://bugs.webkit.org/show_bug.cgi?id=48784
3237
3238         In a future patch, webkit-patch will use this option to improve
3239         performance.  I'm landing this in two pieces to avoid causing a version
3240         skew problem for the style-bot.
3241
3242         * Scripts/check-webkit-style:
3243         * Scripts/webkitpy/style/optparser.py:
3244         * Scripts/webkitpy/style/optparser_unittest.py:
3245         * Scripts/webkitpy/style_references.py:
3246
3247 2010-11-01  Anders Carlsson  <andersca@apple.com>
3248
3249         Reviewed by John Sullivan.
3250
3251         Tear down the related WebProcessProxy when a WebContext is deallocated
3252         https://bugs.webkit.org/show_bug.cgi?id=48769
3253
3254         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3255         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
3256         We don't support empty URLs anymore, update test to expect a null URL instead.
3257
3258 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
3259
3260         Reviewed by Andreas Kling.
3261
3262         Fix warning when compiling the chromium port of DumpRenderShell
3263         with clang.
3264         https://bugs.webkit.org/show_bug.cgi?id=48414
3265
3266         * DumpRenderTree/chromium/TestShell.h:
3267         (TestShell::javaScriptFlagsForLoad):
3268
3269 2010-11-01  Adam Roben  <aroben@apple.com>
3270
3271         Fix typo from r71022
3272
3273         * BuildSlaveSupport/build.webkit.org-config/config.json:
3274
3275 2010-11-01  Adam Roben  <aroben@apple.com>
3276
3277         Trigger the Windows Release WebKit2 tests when a Release build
3278         finishes, not when a Debug build finishes
3279
3280         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
3281         triggered at the wrong time
3282
3283         Reviewed by Sam Weinig.
3284
3285         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
3286         triggerable name and trigger.
3287
3288 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
3289
3290         Unreviewed. Adding my IRC nickname to the list of committers.
3291
3292         * Scripts/webkitpy/common/config/committers.py:
3293
3294 2010-10-31  Robert Hogan  <robert@webkit.org>
3295
3296         Reviewed by Antonio Gomes.
3297
3298         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
3299
3300         Qt and Gtk are case-sensitive when storing the declared mime-type
3301         of plugins. Since plugin mime-types are lowercased prior to searching
3302         for them in the plugin database, ensure they are loaded with the
3303         mime-type in lower case too.
3304
3305         Change the test netscape plugin to declare its mimetype in sentence
3306         case so that the correct behaviour is enforced.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=36815
3309
3310         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3311         (NP_GetMIMEDescription):
3312
3313 2010-10-31  Robert Hogan  <robert@webkit.org>
3314
3315         Reviewed by Antonio Gomes.
3316
3317         [Qt] Support nodesFromRect in DRT
3318
3319         https://bugs.webkit.org/show_bug.cgi?id=48716
3320
3321         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3322         (LayoutTestController::nodesFromRect):
3323         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3324
3325 2010-10-30  Andreas Kling  <kling@webkit.org>
3326
3327         Reviewed by Antonio Gomes.
3328
3329         [Qt] QtTestBrowser: Switching view type moves the embedded inspector
3330         https://bugs.webkit.org/show_bug.cgi?id=48705
3331
3332         Reinsert the embedded inspector into the splitter after changing
3333         between QWebView/QGraphicsWebView.
3334
3335         * QtTestBrowser/launcherwindow.cpp:
3336         (LauncherWindow::init):
3337         (LauncherWindow::initializeView):
3338         * QtTestBrowser/webinspector.h:
3339         (WebInspector::WebInspector):
3340
3341 2010-10-28  Antonio Gomes  <agomes@rim.com>
3342
3343         Reviewed by Ojan Vafai.
3344
3345         Needs a "LinuxEditingBehavior", perhaps with a better name
3346         https://bugs.webkit.org/show_bug.cgi?id=36627
3347
3348         Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
3349
3350         * DumpRenderTree/chromium/LayoutTestController.cpp:
3351         (LayoutTestController::setEditingBehavior):
3352         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3353         (LayoutTestController::setEditingBehavior):
3354         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3355         (LayoutTestController::setEditingBehavior):
3356         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3357         (LayoutTestController::setEditingBehavior):
3358
3359 2010-10-29  Andreas Kling  <kling@webkit.org>
3360
3361         Reviewed by Kenneth Rohde Christiansen.
3362
3363         [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
3364         https://bugs.webkit.org/show_bug.cgi?id=48695
3365
3366         * QtTestBrowser/launcherwindow.cpp:
3367         (LauncherWindow::createChrome):
3368
3369 2010-10-29  Andreas Kling  <kling@webkit.org>
3370
3371         Reviewed by Kenneth Rohde Christiansen.
3372
3373         [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
3374         https://bugs.webkit.org/show_bug.cgi?id=48675
3375
3376         FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
3377         on startup with in -graphicsbased mode.
3378
3379         * QtTestBrowser/fpstimer.cpp:
3380         (FpsTimer::FpsTimer):
3381         (FpsTimer::numFrames):
3382         (FpsTimer::stop):
3383         (FpsTimer::timerEvent):
3384         * QtTestBrowser/fpstimer.h:
3385
3386 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
3387
3388         Reviewed by Tony Chang.
3389
3390         new-run-webkit-tests: change TestResults to be serializable
3391
3392         In preparation for changing new-run-webkit-tests from
3393         multithreaded to multiprocess, we need to make sure the data
3394         going between the threads is easily serialized over a socket.
3395
3396         This change adds serialization/pickling for the TestResults and
3397         TestFailure objects (using cPickle).
3398
3399         The TestFailure objects included a "has_wdiff" flag for Text
3400         results, but the flag wasn't being used, so I've removed it,
3401         simplifying the state to basically a set of enum objects with
3402         associated methods.
3403
3404         https://bugs.webkit.org/show_bug.cgi?id=48616
3405
3406         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3407         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3408         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3409         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
3410         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
3411         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added. 
3412         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3413         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3414
3415 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
3416
3417         Reviewed by Ojan Vafai.
3418
3419         new-run-webkit-tests: need to provide separate dashboard results for GPU tests
3420         https://bugs.webkit.org/show_bug.cgi?id=48687
3421
3422         Modify the steps to upload the JSON files to the dashboards so
3423         that the GPU tests don't conflict with the regular tests on a
3424         port. We do this by modifying the --builder-name parameter to
3425         append " - GPU", which should cause the app to treat the results
3426         as a completely new builder. This is a little non-obvious, but
3427         keeps us from having to restructure the app.
3428
3429         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3430         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3431         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3432
3433 2010-10-29  Ojan Vafai  <ojan@chromium.org>
3434
3435         Reviewed by Tony Chang.
3436
3437         [chromium] add debug logging to help diagnose flakiness dashboard issues
3438         https://bugs.webkit.org/show_bug.cgi?id=48657
3439
3440         The appengine app thinks it's getting empty files uploaded. Add some logging
3441         to see if new-run-webkit-tests agrees.
3442         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3443
3444 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
3445
3446         Reviewed by Ojan Vafai.
3447
3448         [Chromium/DRT] Add master-name flag to new-run-webkit-tests.
3449         https://bugs.webkit.org/show_bug.cgi?id=48649
3450
3451         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
3452
3453 2010-10-29  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3454
3455         Reviewed by Martin Robinson.
3456
3457         Enable popup window in GtkLauncher
3458         https://bugs.webkit.org/show_bug.cgi?id=48335
3459
3460         The GtkLauncher application does not support opening new window when
3461         a link with "target=_blank" is clicked or similar call to
3462         window.open(). Instead, GtkLauncher does nothing which breaks
3463         navigation of some websites.
3464
3465         * GtkLauncher/main.c:
3466         (activate_uri_entry_cb):
3467         (update_title):
3468         (link_hover_cb):
3469         (notify_title_cb):
3470         (notify_load_status_cb):
3471         (notify_progress_cb):
3472         (destroy_cb):
3473         (go_back_cb):
3474         (go_forward_cb):
3475         (create_web_view_cb):
3476         (web_view_ready_cb):
3477         (close_web_view_cb):
3478         (create_browser):
3479         (create_statusbar):
3480         (create_toolbar):
3481         (create_window):
3482         (main):
3483
3484 2010-10-29  Adam Roben  <aroben@apple.com>
3485
3486         Teach check-webkit-style about WebKit2's idiosyncracies
3487
3488         Fixes <http://webkit.org/b/48638> Style bot complains about a number
3489         of WebKit2 conventions
3490
3491         Reviewed by Anders Carlsson.
3492
3493         * Scripts/webkitpy/style/checker.py: Excluded some rules for various
3494         WebKit2-related files. Also updated the excluded rules for
3495         WebKitAPITest to match the current code.
3496
3497 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
3498
3499         Reviewed by Adam Roben and David Kilzer.
3500
3501         Fix and cleanup of build systems
3502         https://bugs.webkit.org/show_bug.cgi?id=48342
3503
3504         * Scripts/build-webkit:
3505          - Remove unnecessary ENABLE_SANDBOX option.
3506          - Add ENABLE_FULLSCREEN_API option.
3507
3508 2010-10-28  Adam Roben  <aroben@apple.com>
3509
3510         Switch the Windows WebKit2 bot to the Release configuration
3511
3512         We only have one machine testing WebKit2 on Windows right now, and
3513         Debug is just too slow for it to keep up.
3514
3515         Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
3516         always way behind
3517
3518         Reviewed by Jon Honeycutt.
3519
3520         * BuildSlaveSupport/build.webkit.org-config/config.json:
3521
3522 2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>
3523
3524         Reviewed by Jeremy Orlow.
3525
3526         Added a second parameter to setMockSpeechInputResult for
3527         the language used in speech input.
3528         https://bugs.webkit.org/show_bug.cgi?id=47089
3529
3530         * DumpRenderTree/LayoutTestController.cpp:
3531         (setMockSpeechInputResultCallback):
3532         * DumpRenderTree/LayoutTestController.h:
3533         * DumpRenderTree/chromium/LayoutTestController.cpp:
3534         (LayoutTestController::setMockSpeechInputResult):
3535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3536         (LayoutTestController::setMockSpeechInputResult):
3537         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3538         (LayoutTestController::setMockSpeechInputResult):
3539         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3540         (LayoutTestController::setMockSpeechInputResult):
3541         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3542         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3543         (LayoutTestController::setMockSpeechInputResult):
3544         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3545         (LayoutTestController::setMockSpeechInputResult):
3546         (LayoutTestController::pageSizeAndMarginsInPixels):
3547
3548 2010-10-28  Ojan Vafai  <ojan@chromium.org>
3549
3550         Reviewed by Tony Chang.
3551
3552         [chromium] add a result-small.json file for the test dashboard
3553         https://bugs.webkit.org/show_bug.cgi?id=48547
3554
3555         Output both a results.json file and a results-small.json file.
3556         The dashboard will load results-small.json by default so it loads faster.
3557
3558         * TestResultServer/model/jsonresults.py:
3559         * TestResultServer/model/jsonresults_unittest.py:
3560         Added a bunch of sys.path hackery. Unforunately, this uses hardcoded
3561         paths. That obviously needs to be fixed, but at least this way it
3562         clearly documents what paths are necessary.
3563
3564 2010-10-28  Eric Seidel  <eric@webkit.org>
3565
3566         Reviewed by Adam Barth.
3567
3568         webkit-patch upload calls changed_files more often than it should
3569         https://bugs.webkit.org/show_bug.cgi?id=48567
3570
3571         Passing changed_files around everywhere isn't a very elegant solution
3572         but it's the one we have for the moment.  I think keeping an explicit
3573         cache on Checkout (or making StepState() a real class) is a better
3574         long-term option.
3575
3576         Previously bug_id_for_this_commit was calling changed_files and the
3577         result was never getting cached on the state.  Now we're explicitly
3578         caching the result on the state and passing that to the bug_id_for_this_commit call.
3579
3580         I looked into building unit tests for this.  Doing so would require
3581         using a real Checkout object with a MockSCM and overriding the appropriate
3582         calls on SCM to count how often we're stating the file system.
3583         That's a useful set of tests to build for a separate change.
3584
3585         * Scripts/webkitpy/common/checkout/api.py:
3586         * Scripts/webkitpy/tool/commands/download.py:
3587         * Scripts/webkitpy/tool/commands/upload.py:
3588         * Scripts/webkitpy/tool/mocktool.py:
3589
3590 2010-10-28  Eric Seidel  <eric@webkit.org>
3591
3592         Reviewed by Adam Barth.
3593
3594         Make suggest-reviewers slightly faster
3595         https://bugs.webkit.org/show_bug.cgi?id=48562
3596
3597         Add @memoized to one more common call.
3598
3599         * Scripts/webkitpy/common/checkout/api.py:
3600
3601 2010-10-28  Eric Seidel  <eric@webkit.org>
3602
3603         Reviewed by Adam Barth.
3604
3605         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
3606         https://bugs.webkit.org/show_bug.cgi?id=48536
3607
3608         This patch makes it about 40 seconds faster, but it still
3609         takes 1:40.  This will require more refinement.
3610
3611         The suggested reviewers list appears to be the same.
3612
3613         I think the next step may be to have it stop the search after
3614         5 reviewers are found.  We never want to suggest 30 people.
3615
3616         * Scripts/webkitpy/common/checkout/scm.py:
3617          - Using --remove-empty to theoretically stop lookups past
3618            when a file is removed.  I'm not entirely clear that the option
3619            does what it says it does.  Example:
3620            git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
3621            returns only one commit
3622            vs.
3623            git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
3624            which returns 5.  I was not aware that wx files were ever removed from the repository?
3625
3626 2010-10-28  Kinuko Yasuda  <kinuko@chromium.org>
3627
3628         Reviewed by David Levin.
3629
3630         [Chromium] Support FileSystem in chromium DRT
3631         https://bugs.webkit.org/show_bug.cgi?id=47643
3632
3633         * DumpRenderTree/chromium/WebViewHost.cpp:
3634         (WebViewHost::openFileSystem): Added.
3635         * DumpRenderTree/chromium/WebViewHost.h:
3636         (WebViewHost::openFileSystem): Added.
3637
3638 2010-10-28  Sam Weinig  <sam@webkit.org>
3639
3640         Reviewed by Anders Carlsson.
3641
3642         WKURLRefs should be allowed to be null
3643         <rdar://problem/8575621>
3644         https://bugs.webkit.org/show_bug.cgi?id=48535
3645
3646         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3647         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3648         (TestWebKitAPI::didStartProvisionalLoadForFrame):
3649         (TestWebKitAPI::didCommitLoadForFrame):
3650         (TestWebKitAPI::didFinishLoadForFrame):
3651         Test that URLs are null pointers when unset.
3652
3653 2010-10-28  Chris Fleizach  <cfleizach@apple.com>
3654
3655         Reviewed by Adele Peterson.
3656
3657         AX: multi select group option does not handle setting of AXSelectedChildren correctly
3658         https://bugs.webkit.org/show_bug.cgi?id=48464
3659
3660         Add support for querying information about selected children to DRT, including:
3661            selectedChildAtIndex
3662            selectedChildrenCount
3663            setSelectedChild
3664
3665         * DumpRenderTree/AccessibilityUIElement.cpp:
3666         (selectedChildAtIndexCallback):
3667         (setSelectedChildCallback):
3668         (selectedChildrenCountCallback):
3669         (AccessibilityUIElement::setSelectedChild):
3670         (AccessibilityUIElement::selectedChildrenCount):
3671         (AccessibilityUIElement::selectedChildAtIndex):
3672         (AccessibilityUIElement::getJSClass):
3673         * DumpRenderTree/AccessibilityUIElement.h:
3674         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3675         (AccessibilityUIElement::selectedChildAtIndex):
3676         (AccessibilityUIElement::selectedChildrenCount):
3677         (AccessibilityUIElement::setSelectedChild):
3678
3679 2010-10-27  Sam Weinig  <sam@webkit.org>
3680
3681         Reviewed by Anders Carlsson.
3682
3683         Add WebKit2 API for window feature getter/setters
3684         <rdar://problem/8590373>
3685         https://bugs.webkit.org/show_bug.cgi?id=48496
3686
3687         * MiniBrowser/mac/BrowserWindowController.m:
3688         (-[BrowserWindowController awakeFromNib]):
3689         * MiniBrowser/win/BrowserView.cpp:
3690         (BrowserView::create):
3691         * WebKitTestRunner/TestController.cpp:
3692         (WTR::createOtherPage):
3693         (WTR::TestController::initialize):
3694
3695 2010-10-28  Søren Gjesse  <sgjesse@chromium.org>
3696
3697         Reviewed by Tony Chang.
3698
3699         Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
3700         https://bugs.webkit.org/show_bug.cgi?id=48236
3701
3702         * Scripts/webkitpy/layout_tests/port/chromium.py:
3703         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3704
3705 2010-10-28  Sergio Villar Senin  <svillar@igalia.com>
3706
3707         Reviewed by Martin Robinson.
3708
3709         [GTK] WebKitWebFrame's load-status is not properly notified to the tests
3710         https://bugs.webkit.org/show_bug.cgi?id=48048
3711
3712         DRT now listens to WebKitWebFrame load-status signals for each
3713         created frame instead of the load-status signal of the
3714         WebKitWebView that only notifies about changes in the main frame.
3715
3716         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3717         (webViewLoadFinished):
3718         (webFrameLoadStatusNotified):
3719         (frameCreatedCallback):
3720         (createWebView):
3721         (main):
3722
3723 2010-10-28  Tony Chang  <tony@chromium.org>
3724
3725         Reviewed by Kent Tamura.
3726
3727         [chromium] fix textInputController.{selectedRange,markedRange}
3728         https://bugs.webkit.org/show_bug.cgi?id=48487
3729
3730         * DumpRenderTree/chromium/TextInputController.cpp:
3731         (TextInputController::markedRange): Return arrays of ints, rather than a string
3732         (TextInputController::selectedRange): Ditto.
3733
3734 2010-10-27  Ojan Vafai  <ojan@chromium.org>
3735
3736         Reviewed by Tony Chang.
3737
3738         [chromium] add a master-name flag to new-run-webkit-tests
3739         https://bugs.webkit.org/show_bug.cgi?id=48488
3740
3741         The test results server now allows adding a master name to
3742         the uploaded files. This lets us distinguish bots that have
3743         the same name, but are on different masters.
3744
3745         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3746
3747 2010-10-28  Adam Roben  <aroben@apple.com>
3748
3749         Don't append a newline to the test output if the frame has no document
3750         element in WebKitTestRunner
3751
3752         Fixes <http://webkit.org/b/48526> Extra trailing newline when running
3753         plugins/document-open.html in WebKitTestRunner
3754
3755         Reviewed by Anders Carlsson.
3756
3757         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3758         (WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
3759         (WTR::hasDocumentElement): Added. Uses the JSC API to figure out
3760         whether the frame has a document element.
3761         (WTR::dumpFrameText): Match DRT by bailing (rather than appending an
3762         empty string and a newline) if the frame has no document element.
3763
3764 2010-10-28  Adam Roben  <aroben@apple.com>
3765
3766         Skip npn-invalidate-rect-invalidates-window.html on headless XP
3767         machines
3768
3769         TestNetscapePlugIn never receives a WM_PAINT message on headless XP
3770         machines, so this test times out. Fixing the test is covered by
3771         <http://webkit.org/b/48333>.
3772
3773         * Scripts/old-run-webkit-tests: Skip
3774         npn-invalidate-rect-invalidates-window.html on Windows if accelerated
3775         compositing support is disabled, which likely means we're on a headless
3776         XP machine.
3777
3778 2010-10-28  Kimmo Kinnunen  <kimmok@iki.fi>
3779
3780         Adding myself as a committer.
3781
3782         * Scripts/webkitpy/common/config/committers.py:
3783
3784 2010-10-27  Eric Seidel  <eric@webkit.org>
3785
3786         Reviewed by Adam Barth.
3787
3788         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow
3789         https://bugs.webkit.org/show_bug.cgi?id=48500
3790
3791         This doesn't fix the problem, but it makes things slightly better.
3792         Each git svn find-rev call takes about .25 seconds on my desktop.
3793         This patch uses a new memoized class to avoid those calls when possible.
3794
3795         The real slowness is still git log on some files, like:
3796         git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
3797         I'm not yet sure how to make the pathological git logs better.
3798
3799         * Scripts/webkitpy/common/checkout/scm.py:
3800         * Scripts/webkitpy/common/memoized.py: Added.
3801         * Scripts/webkitpy/common/memoized_unittest.py: Added.
3802
3803 2010-10-27  Eric Seidel  <eric@webkit.org>
3804
3805         Reviewed by Ojan Vafai.
3806
3807         EWS bots should not use --quiet when running build-webkit
3808         https://bugs.webkit.org/show_bug.cgi?id=48482
3809
3810         --quiet is only correct when the sub-process does the error reporting.
3811         In the case of _can_build() the parent process is reporting the error.
3812         We'd like the full build log at queues.webkit.org so someone can look
3813         at the log and understand why the EWS is failing to build trunk.
3814
3815         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3816         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3817         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3818         * Scripts/webkitpy/tool/mocktool.py:
3819
3820 2010-10-27  Brian Weinstein  <bweinstein@apple.com>
3821
3822         More Windows build fixage. Rename a variable that was named string.
3823
3824         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3825         (WTR::hasPrefix):
3826
3827 2010-10-27  Ojan Vafai  <ojan@chromium.org>
3828
3829         Reviewed by Dimitri Glazkov.
3830
3831         [chromium] Make the test results server store which master the bot is on
3832         https://bugs.webkit.org/show_bug.cgi?id=48478
3833
3834         The chromium bots recently changed so that there are multiple slaves with
3835         the same name on different masters. Up till now, the test results server
3836         assumed slave names were unique. Adds a master field to the file in order
3837         to distinguish.
3838
3839         Also, for files that currently lack a master or testtype, set them appropriately.
3840
3841         * TestResultServer/handlers/testfilehandler.py:
3842         * TestResultServer/index.yaml:
3843         * TestResultServer/model/jsonresults.py:
3844         * TestResultServer/model/testfile.py:
3845         * TestResultServer/templates/showfilelist.html:
3846         * TestResultServer/templates/uploadform.html:
3847
3848 2010-10-26  Darin Adler  <darin@apple.com>
3849
3850         Reviewed by Sam Weinig.
3851
3852         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
3853         https://bugs.webkit.org/show_bug.cgi?id=42322
3854         rdar://problem/8193631
3855
3856         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
3857         https://bugs.webkit.org/show_bug.cgi?id=42333
3858         rdar://problem/8193643
3859
3860         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3861         Renamed the product to WebKitTestRunnerInjectedBundle to avoid
3862         name conflicts in the build directory.
3863
3864         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3865         Added dumpBackForwardList and clearBackForwardList.
3866
3867         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3868         (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage.
3869         (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore.
3870         (WTR::InjectedBundle::willDestroyPage): Ditto.
3871         (WTR::InjectedBundle::didReceiveMessage): Ditto.
3872         (WTR::InjectedBundle::initialize): Ditto.
3873         (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages
3874         instead of m_mainPage and m_otherPages.
3875         (WTR::InjectedBundle::willDestroyPage): Ditto.
3876         (WTR::InjectedBundle::page): Ditto.
3877         (WTR::InjectedBundle::beginTesting): Ditto.
3878         (WTR::InjectedBundle::done): Ditto.
3879         (WTR::InjectedBundle::closeOtherPages): Ditto.
3880         (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
3881
3882         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed
3883         page function to longer be inline, and pageCount function
3884         to use m_pages. Added dumpBackForwardListsForAllPages, and
3885         removed some underscores. Replaced m_mainPage and m_otherPageas
3886         with m_pages.
3887
3888         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3889         (WTR::adoptWK): Added.
3890         (WTR::hasPrefix): Added.
3891         (WTR::InjectedBundlePage::reset): Added code to set up
3892         m_previousTestBackForwardListItem.
3893         (WTR::InjectedBundlePage::dump): Added code to call
3894         dumpBackForwardListsForAllPages.
3895         (WTR::compareByTargetName): Added.
3896         (WTR::dumpBackForwardListItem): Added.
3897         (WTR::InjectedBundlePage::dumpBackForwardList): Added.
3898
3899         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added
3900         dumpBackForwardList and m_previousTestBackForwardListItem.
3901
3902         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3903         (WTR::LayoutTestController::LayoutTestController): Initialize
3904         m_shouldDumpBackForwardListsForAllWindows to false.
3905         (WTR::LayoutTestController::clearBackForwardList): Added.
3906
3907         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3908         Added dumpBackForwardList, clearBackForwardList,
3909         shouldDumpBackForwardListsForAllWindows, and
3910         m_shouldDumpBackForwardListsForAllWindows.
3911
3912         * WebKitTestRunner/TestController.cpp:
3913         (WTR::TestController::initialize): Set up
3914         didReceiveSynchronousMessageFromInjectedBundle.
3915         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3916         Added.
3917         * WebKitTestRunner/TestController.h: Ditto.
3918
3919         * WebKitTestRunner/TestInvocation.cpp:
3920         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3921         Added.
3922         * WebKitTestRunner/TestInvocation.h: Ditto.
3923
3924         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3925         Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
3926         * WebKitTestRunner/mac/TestControllerMac.mm:
3927         (WTR::TestController::initializeInjectedBundlePath): Ditto.
3928
3929 2010-10-27  Chris Rogers  <crogers@google.com>
3930
3931         Reviewed by Chris Marrin.
3932
3933         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
3934         https://bugs.webkit.org/show_bug.cgi?id=48279
3935
3936         * Scripts/build-webkit:
3937
3938 2010-10-27  Eric Seidel  <eric@webkit.org>
3939
3940         Unreviewed.
3941
3942         build-webkit should collect Visual Studio Express logs and display them
3943         https://bugs.webkit.org/show_bug.cgi?id=39199
3944
3945         It turns out my previous patch wasn't actually working on the win-ews
3946         machine.  So I've fixed my mistakes from before.
3947
3948         * Scripts/build-webkit:
3949          - Windows VSE builds change the CWD while building.  Why?  Who knows.
3950         * Scripts/print-vse-failure-logs:
3951          - windows VSE builds don't use Debug/Release as I expected, so I've
3952            moved off of --configuration to --top-level and added the /obj
3953            optimization while I was there.
3954
3955 2010-10-27  Dimitri Glazkov  <dglazkov@chromium.org>
3956
3957         Unreviewed, rolling out r70674.
3958         http://trac.webkit.org/changeset/70674
3959         https://bugs.webkit.org/show_bug.cgi?id=48053
3960
3961         Broke Chromium Windows build.
3962
3963         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3965
3966 2010-10-25  Tony Chang  <tony@chromium.org>
3967
3968         Reviewed by Anders Carlsson.
3969
3970         compile TestNetscapePlugIn on chromium linux
3971         https://bugs.webkit.org/show_bug.cgi?id=48274
3972
3973         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3974         (NP_Initialize): On Linux, plugin funcs are set in initialize.
3975         (NPP_New): Mark the plugin as windowless.
3976         (NPP_GetValue): Handle mime type values.
3977         (NP_GetMIMEDescription):
3978         (NP_GetValue):
3979         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h.
3980         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h)
3981
3982 2010-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3983
3984         Reviewed by Anders Carlsson.
3985
3986         Remove contentSizeChanged callbacks as it is no longer
3987         part of the public UIClient.
3988
3989         Make WKPageContentsSizeChangedCallback be a private API
3990         https://bugs.webkit.org/show_bug.cgi?id=48409
3991
3992         * MiniBrowser/mac/BrowserWindowController.m:
3993         (-[BrowserWindowController awakeFromNib]):
3994         * MiniBrowser/win/BrowserView.cpp:
3995         (BrowserView::create):
3996         * WebKitTestRunner/TestController.cpp:
3997         (WTR::createOtherPage):
3998         (WTR::TestController::initialize):
3999
4000 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4001
4002         Reviewed by Ojan Vafai.
4003
4004         Make http locking default in NRWT.
4005         https://bugs.webkit.org/show_bug.cgi?id=48053
4006
4007         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4009
4010 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4011
4012         Reviewed by Tony Chang.
4013
4014         [NRWT] Fix http lock on Windows platform
4015         https://bugs.webkit.org/show_bug.cgi?id=48321
4016
4017         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4018
4019 2010-10-27  Satish Sampath  <satish@chromium.org>
4020
4021         Unreviewed, rolling out r70665.
4022         http://trac.webkit.org/changeset/70665
4023         https://bugs.webkit.org/show_bug.cgi?id=47089
4024
4025         Need to address Alexey's review comments.
4026
4027         * DumpRenderTree/LayoutTestController.cpp:
4028         (setMockSpeechInputResultCallback):
4029         * DumpRenderTree/LayoutTestController.h:
4030         * DumpRenderTree/chromium/LayoutTestController.cpp:
4031         (LayoutTestController::setMockSpeechInputResult):
4032         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4033         (LayoutTestController::setMockSpeechInputResult):
4034         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4035         (LayoutTestController::setMockSpeechInputResult):
4036         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4037         (LayoutTestController::setMockSpeechInputResult):
4038         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4039         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4040         (LayoutTestController::setMockSpeechInputResult):
4041         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4042         (LayoutTestController::setMockSpeechInputResult):
4043
4044 2010-10-27  Leandro Gracia Gil  <leandrogracia@google.com>
4045
4046         Reviewed by Jeremy Orlow.
4047
4048         Added a second parameter to setMockSpeechInputResult for
4049         the language used in speech input.
4050         https://bugs.webkit.org/show_bug.cgi?id=47089
4051
4052         * DumpRenderTree/LayoutTestController.cpp:
4053         (setMockSpeechInputResultCallback):
4054         * DumpRenderTree/LayoutTestController.h:
4055         * DumpRenderTree/chromium/LayoutTestController.cpp:
4056         (LayoutTestController::setMockSpeechInputResult):
4057         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4058         (LayoutTestController::setMockSpeechInputResult):
4059         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4060         (LayoutTestController::setMockSpeechInputResult):
4061         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4062         (LayoutTestController::setMockSpeechInputResult):
4063         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4064         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4065         (LayoutTestController::setMockSpeechInputResult):
4066         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4067         (LayoutTestController::setMockSpeechInputResult):
4068         (LayoutTestController::pageSizeAndMarginsInPixels):
4069
4070 2010-10-27  Adam Roben  <aroben@apple.com>
4071
4072         Reset TestNetscapePlugIn's NPP_GetValue pointer when
4073         NullNPPGetValuePointer finishes running
4074
4075         Fixes <http://webkit.org/b/48435> REGRESSION (r70655): Many plugins
4076         tests are failing on Qt
4077
4078         Reviewed by Anders Carlsson.
4079
4080         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4081         (PluginTest::NPP_Destroy):
4082         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4083         Added a do-nothing NPP_Destroy implementation.
4084
4085         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
4086         (NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original
4087         NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore
4088         it later.
4089         (NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original
4090         NPP_GetValue pointer so it can be used in other tests.
4091
4092         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4093         (NPP_Destroy):
4094         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4095         (webkit_test_plugin_destroy_instance):
4096         Call through to the PluginTest when NPP_Destroy is called.
4097
4098 2010-10-26  Brian Weinstein  <bweinstein@apple.com>
4099
4100         Reviewed by Adam Roben.
4101
4102         WebKit2 shouldn't try to send an empty user agent
4103         https://bugs.webkit.org/show_bug.cgi?id=48397
4104         
4105         Add a test that when we set our custom user agent to an empty string, we don't send
4106         an empty user agent.
4107
4108         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added.
4109         (TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty.
4110         (TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent.
4111         
4112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file.
4113         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
4114
4115 2010-10-27  Adam Roben  <aroben@apple.com>
4116
4117         Check in file I forgot in r70653
4118
4119         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4120         (NP_Initialize): Save the NPPluginFuncs struct the browser passed to us
4121         so we can be naughty and modify it later.
4122
4123 2010-10-27  Adam Roben  <aroben@apple.com>
4124
4125         Test that WebKit doesn't crash if the plugin passes 0 for its
4126         NPP_GetValue pointer
4127
4128         Test for <http://webkit.org/b/48433> Crash in
4129         NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in
4130         WebKit2 on Windows
4131
4132         Reviewed by Eric Carlson.
4133
4134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4135         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4136         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4137         * GNUmakefile.am:
4138         Added NullNPPGetValuePointer.cpp.
4139
4140         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4141         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
4142         Set up a place to store the NPPluginFuncs struct the browser passed to us.
4143
4144         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added.
4145         (NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the
4146         NPP_GetValue pointer we passed to the browser to simulate a plugin that
4147         doesn't implement NPP_GetValue.
4148         (NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this
4149         function is called, it means that WebKit has changed in a way that
4150         makes this test invalid.
4151
4152         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4153         (NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed
4154         to us so we can be naughty and modify it later.
4155
4156 2010-10-27  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
4157
4158         Reviewed by Andreas Kling.
4159
4160         Remove references to ancient QGVLauncher and QtLauncher
4161         https://bugs.webkit.org/show_bug.cgi?id=48430
4162
4163         QtTestBrowser substitutes both and has checks enabled.
4164
4165         * Scripts/webkitpy/style/checker.py: remove references
4166         * Scripts/webkitpy/style/checker_unittest.py: ditto
4167
4168 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4169
4170         Reviewed by Ojan Vafai.
4171
4172         [NRWT] Don't use image hash when it's no need in single test mode.
4173         https://bugs.webkit.org/show_bug.cgi?id=48326
4174
4175         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4176
4177 2010-10-27  David Kilzer  <ddkilzer@apple.com>
4178
4179         Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData()
4180
4181         Reviewed by Adam Roben.
4182
4183         Follow-up fix for: <https://bugs.webkit.org/show_bug.cgi?id=48278>
4184
4185         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
4186         (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a
4187         leak introduced in r70613.
4188
4189 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4190
4191         Reviewed by Csaba Osztrogonác.
4192
4193         [NRWT] Add platform specific baseline search paths for Qt port
4194         https://bugs.webkit.org/show_bug.cgi?id=48428
4195
4196         * Scripts/webkitpy/layout_tests/port/qt.py:
4197
4198 2010-10-27  Adam Roben  <aroben@apple.com>
4199
4200         Catch exceptions when checking if we're inside a git working directory
4201
4202         Fixes <http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy
4203         fails on systems without git installed
4204
4205         Reviewed by Anders Carlsson.
4206
4207         * Scripts/webkitpy/common/net/credentials.py:
4208         (Credentials._credentials_from_git): Put the call to
4209         Git.in_working_directory inside the try/except since it, too, attempts
4210         to execute git and thus will throw on systems that don't have git
4211         installed.
4212
4213 2010-10-27  Nikolas Zimmermann  <nzimmermann@rim.com>
4214
4215         Reviewed by David Kilzer.
4216
4217         Convert DumpRenderTree webarchive code to CoreFoundation
4218         https://bugs.webkit.org/show_bug.cgi?id=48278
4219
4220         CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+.
4221         Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream.
4222         Replace CFPropertyListCreateData by CFPropertyListCreateXMLData.