V8 build fix
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-17  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Mark Rowe.
4
5         Add BUILDING_ON_SNOW_LEOPARD #define.
6
7         * DumpRenderTree/mac/DumpRenderTreeMac.h:
8
9 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
10
11         Reviewed by Alexey Proskuryakov.
12
13         Update pywebsocket to 0.4.5 and make handshake checking stricter
14         https://bugs.webkit.org/show_bug.cgi?id=32249
15
16         * Scripts/run-webkit-tests:
17         * pywebsocket/mod_pywebsocket/handshake.py:
18         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
19         * pywebsocket/mod_pywebsocket/standalone.py:
20         * pywebsocket/setup.py:
21         * pywebsocket/test/test_handshake.py:
22         * pywebsocket/test/test_memorizingfile.py: Added.
23
24 2009-12-17  Eric Seidel  <eric@webkit.org>
25
26         Reviewed by Adam Barth.
27
28         Command.show_in_main_help should default to False
29         https://bugs.webkit.org/show_bug.cgi?id=32686
30
31         * Scripts/modules/commands/download.py:
32         * Scripts/modules/commands/queries.py:
33         * Scripts/modules/commands/queues.py:
34         * Scripts/modules/commands/upload.py:
35         * Scripts/modules/multicommandtool.py:
36
37 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
38
39         Reviewed by Eric Seidel.
40
41         Added the key WebKitEnableCaretBrowsing to the
42         layoutTestController.overridePreference in order to activate caret
43         browsing.
44         https://bugs.webkit.org/show_bug.cgi?id=32612
45
46         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
47         the setting.
48         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
49         key in the keytable.
50
51 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
52
53         Reviewed by David Kilzer.
54
55         AX: DRT needs to support URL for accessibility
56         https://bugs.webkit.org/show_bug.cgi?id=32666
57
58         * DumpRenderTree/AccessibilityUIElement.cpp:
59         (getURLCallback):
60         (AccessibilityUIElement::getJSClass):
61         * DumpRenderTree/AccessibilityUIElement.h:
62         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
63         (AccessibilityUIElement::url):
64         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
65         (AccessibilityUIElement::url):
66         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
67         (AccessibilityUIElement::url):
68
69 2009-12-17  Philippe Normand  <pnormand@igalia.com>
70
71         Unreviewed; added myself to committers
72
73         * Scripts/modules/committers.py:
74
75 2009-12-17  Benjamin Otte  <otte@gnome.org>
76
77         Unreviewed; added myself to committers
78
79         * Scripts/modules/committers.py:
80
81 2009-12-17  Adam Barth  <abarth@webkit.org>
82
83         Rubber stamp by Seidel.
84
85         Clean up exception handling in WorkQueue.  Basically, a bunch of the
86         delegate messages can throw exceptions because of network errors.  We
87         want the queues to keep on ticking instead of erroring out.  That means
88         we want to catch generic exceptions and continue looping.
89
90         Also, cleaned up the exception handling in the EWS to properly log
91         failures.
92
93         * Scripts/modules/commands/early_warning_system.py:
94         * Scripts/modules/commands/queues.py:
95         * Scripts/modules/workqueue.py:
96
97 2009-12-16  Adam Barth  <abarth@webkit.org>
98
99         Reviewed by Eric Seidel.
100
101         [bzt] Make UpdateStep quiet
102         https://bugs.webkit.org/show_bug.cgi?id=32599
103
104         * Scripts/modules/buildsteps.py:
105         * Scripts/modules/buildsteps_unittest.py:
106
107 2009-12-16  Evan Martin  <evan@chromium.org>
108
109         Reviewed by Adam Barth.
110
111         Add Gtk to the early warning system WebKit port list.
112
113         https://bugs.webkit.org/show_bug.cgi?id=32629
114
115         * Scripts/modules/commands/early_warning_system.py:
116         * Scripts/modules/webkitport.py:
117         * Scripts/modules/webkitport_unittest.py:
118
119 2009-12-16  Eric Seidel  <eric@webkit.org>
120
121         Reviewed by Adam Barth.
122
123         post-diff is failing with exception under guess_reviewer_from_bug
124         https://bugs.webkit.org/show_bug.cgi?id=32642
125
126         Also refactor output capturing code into
127         OutputCapture.assert_outputs to share more code between tests.
128
129         * Scripts/modules/buildsteps.py:
130          - Add the missing include.
131          - Give guess_reviewer_from_bug a private underscore.
132         * Scripts/modules/buildsteps_unittest.py: Added.
133          - Test to make sure _guess_reviewer_from_bug works as expected.
134         * Scripts/modules/commands/commandtest.py:
135          - Custom code is now obsoleted by OutputCapture.assert_outputs
136         * Scripts/modules/commands/queues_unittest.py:
137          - ditto
138         * Scripts/modules/credentials_unittest.py:
139          - ditto
140         * Scripts/modules/mock_bugzillatool.py:
141          - fetch_reviewed_patches_from_bug can never return None
142         * Scripts/modules/multicommandtool_unittest.py:
143          - Custom code is now obsoleted by OutputCapture.assert_outputs
144         * Scripts/modules/outputcapture.py:
145          - Add assert_outputs to share more code between tests.
146         * Scripts/run-webkit-unittests:
147          - Add buildsteps_unittest.py
148
149 2009-12-16  Adam Barth  <abarth@webkit.org>
150
151         Unreviewed.  Added a default argument to _update_status so that callers
152         don't have to explictly pass None when they don't have a patch object.
153
154         * Scripts/modules/commands/queues.py:
155
156 2009-12-16  Kent Tamura  <tkent@chromium.org>
157
158         Reviewed by David Levin.
159
160         check-webkit-style supports for TAB check against text files.
161         https://bugs.webkit.org/show_bug.cgi?id=32538
162
163         * Scripts/check-webkit-style:
164           Move process_patch() to style.py.
165         * Scripts/modules/cpp_style.py:
166           Add can_handle().
167         * Scripts/modules/cpp_style_unittest.py:
168           Add tests for can_handle().
169         * Scripts/modules/style.py:
170           Added. This is a front-end of cpp_style and text_style. It dispatches
171           files to an appropriate linter.
172         * Scripts/modules/text_style.py:
173           Added. This is a linter module for generic text files. It supports
174           only for TAB checking at this moment.
175         * Scripts/modules/text_style_unittest.py:
176           Added. Tests for text_style.py.
177         * Scripts/run-webkit-unittests:
178           Add text_style_unittest.
179
180 2009-12-16  Eric Seidel  <eric@webkit.org>
181
182         Reviewed by David Levin.
183
184         bugzilla-tool should not require users to install mechanize
185         https://bugs.webkit.org/show_bug.cgi?id=32635
186
187         Centralize our import logic.
188
189         * Scripts/modules/bugzilla.py: use webkit_mechanize
190         * Scripts/modules/statusbot.py: use webkit_mechanize
191         * Scripts/modules/webkit_mechanize.py: Added.
192
193 2009-12-16  Eric Seidel  <eric@webkit.org>
194
195         Reviewed by Adam Barth.
196
197         Generalize commit-queue recent status page for all queues
198         https://bugs.webkit.org/show_bug.cgi?id=32633
199
200         * QueueStatusServer/index.html:
201          - Generalize to support other queues.
202         * QueueStatusServer/queue_status.py:
203          - Generalize MainPage to support other queues.
204
205 2009-12-16  Evan Martin  <evan@chromium.org>
206
207         Reviewed by Adam Barth.
208
209         Early warning system server should display output as UTF-8.
210
211         https://bugs.webkit.org/show_bug.cgi?id=32625
212
213         * QueueStatusServer/queue_status.py:
214
215 2009-12-16  Adam Barth  <abarth@webkit.org>
216
217         Reviewed by Eric Seidel.
218
219         [bzt] Add error handling to the early warning system
220         https://bugs.webkit.org/show_bug.cgi?id=32594
221
222         This should be the last step in making the EWS operational.  When we
223         have a build error, we post the log to QueueStatusServer and add a link
224         to the bug.
225
226         * Scripts/modules/commands/early_warning_system.py:
227         * Scripts/modules/commands/queues.py:
228         * Scripts/modules/executive.py:
229
230 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
231
232         Reviewed by Holger Freyther.
233
234         Fix crash with tests that use custom font faces.
235
236         https://bugs.webkit.org/show_bug.cgi?id=32600
237
238         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
239         that custom font faces between tests don't influence each other. Calling this
240         function in Qt however also invalidates all existing handles with QFontDatabase.
241
242         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
243         which implies a call to WebCore::FontCache::fontCache()->invalidate().
244
245         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
246         (WebCore::DumpRenderTree::open):
247
248 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
249
250         Reviewed by Simon Hausmann.
251
252         [Qt] Maintain button state between mouse events.
253
254         This allows eventSender to generate drag events.
255
256         https://bugs.webkit.org/show_bug.cgi?id=32601
257
258         * DumpRenderTree/qt/EventSenderQt.cpp:
259         (EventSender::mouseDown):
260         (EventSender::mouseUp):
261         (EventSender::mouseMoveTo):
262         * DumpRenderTree/qt/EventSenderQt.h:
263
264 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
265
266         Reviewed by David Levin.
267
268         Code clean-up in check-webkit-style as described below.
269         The only functional changes are minor improvements to the
270         script's help output.
271         
272         https://bugs.webkit.org/show_bug.cgi?id=32487
273
274         * Scripts/check-webkit-style:
275           - Added the module docstring from cpp_style.py.
276           - Improved wording of the --help output and added some of the
277             default values as substitution strings.
278           - Called cpp_style.exit_with_usage instead of sys.stderr.write
279             in main function.
280           - Made changes caused by changes to cpp_style.py.
281
282         * Scripts/modules/cpp_style.py:
283           - Removed module docstring, as well as redundant _USAGE string
284             and main() function obsoleted by check-webkit-style.
285           - Moved specification of default script values from within a
286             function definition to global variables.
287           - Moved the default webkit filter rules to be near the other
288             global variables.
289           - Renamed "FILTER" global variables to "FILTER_RULES" to
290             establish unambiguous terminology.
291           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
292           - Changed _STYLE_CATEGORIES from a string to a list.
293           - Added default webkit filter rules to --filter= output.
294           - Renamed "print_" methods to "exit_with_" since they exist
295             and added a temporary display_help parameter.
296           - Added a temporary display_help parameter to parse_arguments.
297
298         * Scripts/modules/cpp_style_unittest.py:
299           - Made changes caused by changes to cpp_style.py.
300           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
301             variables since they are not global.
302
303 2009-12-15  Adam Barth  <abarth@webkit.org>
304
305         Unreviewed fix for the style-queue.
306         Typo: _updates_status -> _update_status
307
308         We need to improve our testing infrastructure for the queues.
309
310         * Scripts/modules/commands/queues.py:
311
312 2009-12-15  Adam Barth  <abarth@webkit.org>
313
314         Unreviewed fix for the style-queue.  I suspect this is a recent
315         regression from Eric's change below.
316
317         * Scripts/modules/commands/queues.py:
318
319 2009-12-15  Yaar Schnitman  <yaar@chromium.org>
320
321         Reviewed by Darin Fisher.
322
323         update-webkit-chromium to auto-install gclient
324
325         https://bugs.webkit.org/show_bug.cgi?id=32587
326
327         * Scripts/update-webkit-chromium:
328
329 2009-12-15  Eric Seidel  <eric@webkit.org>
330
331         Reviewed by Adam Barth.
332
333         bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
334         https://bugs.webkit.org/show_bug.cgi?id=32546
335
336         You can see an example of this working in:
337         https://bugs.webkit.org/show_bug.cgi?id=32585#c3
338
339         * QueueStatusServer/queue_status.py:
340          - Output the id of the newly created status.
341         * Scripts/modules/commands/queues.py:
342          - Tweak the commit-queue logging to include a full status link.
343         * Scripts/modules/statusbot.py:
344          - update_status should return the newly created status id.
345
346 2009-12-15  Andras Becsi  <abecsi@inf.u-szeged.hu>
347
348         Reviewed by Tor Arne Vestbø.
349
350         [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
351
352         * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
353         * DumpRenderTree/qt/DumpRenderTree.h: Removed.
354         * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
355         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
356         * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
357         * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
358         (GCController::GCController):
359         * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
360         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
361         * DumpRenderTree/qt/WorkQueueItem.h: Removed.
362         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
363         * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
364         * DumpRenderTree/qt/jsobjects.cpp: Removed.
365         * DumpRenderTree/qt/jsobjects.h: Removed.
366         * DumpRenderTree/qt/main.cpp: Updated includes.
367
368 2009-12-15  Adam Barth  <abarth@webkit.org>
369
370         Reviewed by Eric Seidel.
371
372         We have two mark-fixed commands
373         https://bugs.webkit.org/show_bug.cgi?id=32073
374
375         * Scripts/mark-bug-fixed: Removed.
376         * Scripts/modules/commands/upload.py:
377         * Scripts/modules/commands/upload_unittest.py:
378
379 2009-12-15  Eric Seidel  <eric@webkit.org>
380
381         Reviewed by Adam Barth.
382
383         bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
384         https://bugs.webkit.org/show_bug.cgi?id=28286
385
386         * QueueStatusServer/index.html:
387          - Show [results] links if a results log was uploaded.
388         * QueueStatusServer/queue_status.py:
389          - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
390         * Scripts/modules/commands/queues.py:
391          - Post to the status bot when a patch fails and include the failure log as a results file.
392
393 2009-12-15  Eric Seidel  <eric@webkit.org>
394
395         Reviewed by Adam Barth.
396
397         queue sub-commands need --status-host so they can report status
398         https://bugs.webkit.org/show_bug.cgi?id=32313
399
400         Make --status-bot a global option and make
401         run_bugzilla_tool pass --status-bot to sub-commands.
402
403         * Scripts/bugzilla-tool:
404          - Rename _status to status_bot and make it non-lazy.
405         * Scripts/modules/commands/queues.py:
406          - Move status updates out of WorkQueue and into individual queues.
407         * Scripts/modules/commands/queues_unittest.py:
408          - Test that --status-host is passed to bugzilla-tool when run as subcommand.
409         * Scripts/modules/mock_bugzillatool.py:
410          - Add a MockStatusBot
411         * Scripts/modules/workqueue.py:
412          - Remove status_host and work_work_logs_directory callbacks.
413          - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
414         * Scripts/modules/workqueue_unittest.py:
415          - Update unit tests to reflect new callbacks.
416
417 2009-12-15  Adam Barth  <abarth@webkit.org>
418
419         Reviewed by Eric Seidel.
420
421         scm_unittest.py is too slow
422         https://bugs.webkit.org/show_bug.cgi?id=31818
423
424         Now we don't run the SCM unit tests unless we get the --all flag on the
425         command line.  Eric and I were commenting out this test because it was
426         too painful to run.
427
428         * Scripts/run-webkit-unittests:
429
430 2009-12-14  Adam Barth  <abarth@webkit.org>
431
432         Unreviewed.  Fix failing unittest.
433
434         * Scripts/modules/bugzilla_unittest.py:
435
436 2009-12-14  Eric Seidel  <eric@webkit.org>
437
438         Reviewed by Adam Barth.
439
440         Move Credential handling out into a separate module
441         https://bugs.webkit.org/show_bug.cgi?id=32531
442
443         * Scripts/modules/bugzilla.py:
444         * Scripts/modules/credentials.py: Added.
445         * Scripts/modules/credentials_unittest.py: Added.
446         * Scripts/run-webkit-unittests:
447
448 2009-12-14  Adam Barth  <abarth@webkit.org>
449
450         Reviewed by Eric Seidel.
451
452         Kill _create_step_sequence
453         https://bugs.webkit.org/show_bug.cgi?id=32539
454
455         It's cleaner to represent not having these sequences as an empty
456         sequence instead of None.
457
458         * Scripts/modules/commands/download.py:
459         * Scripts/modules/stepsequence.py:
460
461 2009-12-14  Adam Barth  <abarth@webkit.org>
462
463         Unreviewed.  Address reviewer comments from an earlier patch.  I didn't
464         do this earlier because I was worried about conflicts in dependent
465         patches.
466
467         * Scripts/modules/commands/download.py:
468
469 2009-12-14  Adam Barth  <abarth@webkit.org>
470
471         Reviewed by Eric Seidel.
472
473         [bzt] Make download commands declarative
474         https://bugs.webkit.org/show_bug.cgi?id=32469
475
476         This patch "properly" factors most of the download commands.  These
477         commands are now largely declarative, which is the final step of this
478         grand refactoring.
479
480         * Scripts/modules/buildsteps.py:
481         * Scripts/modules/commands/download.py:
482
483 2009-12-14  Adam Barth  <abarth@webkit.org>
484
485         Reviewed by Eric Seidel.
486
487         [bzt] Add AbstractPatchSequencingCommand to remove redundant code
488         https://bugs.webkit.org/show_bug.cgi?id=32468
489
490         Redundant code is bad.  This patch moves us towards more declarative
491         commands.
492
493         * Scripts/modules/commands/download.py:
494
495 2009-12-14  Adam Barth  <abarth@webkit.org>
496
497         Reviewed by Eric Seidel.
498
499         [bzt] Kill WebKitApplyingScripts
500         https://bugs.webkit.org/show_bug.cgi?id=32467
501
502         Ah!  I've been wanting to do this for a long time.  This patch brings
503         the applying commands into the patch processing fold.
504
505         * Scripts/bugzilla-tool:
506         * Scripts/modules/buildsteps.py:
507         * Scripts/modules/commands/download.py:
508         * Scripts/modules/commands/download_unittest.py:
509         * Scripts/modules/mock_bugzillatool.py:
510
511 2009-12-14  Adam Barth  <abarth@webkit.org>
512
513         Reviewed by Eric Seidel.
514
515         [bzt] Convert rollout to StepSequence
516         https://bugs.webkit.org/show_bug.cgi?id=32406
517
518         * Scripts/modules/buildsteps.py:
519         * Scripts/modules/commands/download.py:
520         * Scripts/modules/commands/download_unittest.py:
521         * Scripts/modules/mock_bugzillatool.py:
522
523 2009-12-14  Adam Barth  <abarth@webkit.org>
524
525         Reviewed by Eric Seidel.
526
527         [bzt] Kill LandingSequence
528         https://bugs.webkit.org/show_bug.cgi?id=32464
529
530         Removes LandingSequence in favor of StepSequence.  This required
531         changing the Step API slightly to carry a general notion of state
532         instead of carrying patches specifically.
533
534         * Scripts/modules/buildsteps.py:
535         * Scripts/modules/commands/download.py:
536         * Scripts/modules/commands/queues.py:
537         * Scripts/modules/landingsequence.py: Removed.
538         * Scripts/modules/stepsequence.py:
539
540 2009-12-14  Robert Hogan  <robert@roberthogan.net>
541
542         Reviewed by Eric Seidel.
543
544         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
545         
546         Amend the behaviour of DRT::notifyDone to dump only when
547         the page has finished loading.
548         
549         This fix permits removal of the following tests from the Qt skipped list:
550         fast/forms/textarea-linewrap-dynamic.html
551         fast/forms/textarea-setvalue-submit.html
552         fast/forms/textarea-hard-linewrap-empty.html
553         fast/forms/submit-to-url-fragment.html
554         http/tests/misc/percent-sign-in-form-field-name.html
555         http/tests/security/escape-form-data-field-names.html
556         
557         However it also requires the following two to be added to the skipped list:
558         
559         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
560         svg/custom/use-instanceRoot-as-event-target.xhtml
561         
562         It appears the behaviour of notifyDone was masking problems with these two
563         tests.
564
565         * DumpRenderTree/qt/DumpRenderTree.cpp:
566         (WebCore::DumpRenderTree::DumpRenderTree):
567         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
568         (LayoutTestController::reset):
569         (LayoutTestController::processWork):
570         (LayoutTestController::maybeDump):
571         (LayoutTestController::notifyDone):
572         (LayoutTestController::provisionalLoad):
573         * DumpRenderTree/qt/LayoutTestControllerQt.h:
574         (LayoutTestController::resetLoadFinished):
575
576 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
577
578         Reviewed by Holger Freyther.
579
580         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
581
582         https://bugs.webkit.org/show_bug.cgi?id=32482
583
584         * DumpRenderTree/qt/EventSenderQt.cpp:
585         (EventSender::setTouchModifier):
586         (EventSender::clearTouchPoints):
587         (EventSender::sendTouchEvent):
588         * DumpRenderTree/qt/EventSenderQt.h:
589
590 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
591
592         Reviewed by Gavin Barraclaugh.
593
594         Fix minor problem in sunspider-compare-results which left it broken.
595
596         * Scripts/sunspider-compare-results: Declare $parseonly
597
598 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
599
600         Reviewed by Oliver Hunt.
601
602         Give command-line sunspider the ability to handle multiple suites and versions
603         https://bugs.webkit.org/show_bug.cgi?id=32477
604
605         * Scripts/run-sunspider: Updated for changes to command-line parameters.
606         * Scripts/sunspider-compare-results: ditto
607
608 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
609
610         Not reviewed, fixing previous comment.
611
612         Remove accidental change to sunspider-compare-results
613
614         * Scripts/sunspider-compare-results:
615
616 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
617
618         Unreviewed build fix for Qt versions < 4.6. 
619         Guard every slot individually with #ifdef.
620
621         * DumpRenderTree/qt/EventSenderQt.cpp:
622         (EventSender::addTouchPoint):
623         (EventSender::updateTouchPoint):
624         (EventSender::touchStart):
625         (EventSender::touchMove):
626         (EventSender::touchEnd):
627         (EventSender::clearTouchPoints):
628         (EventSender::releaseTouchPoint):
629         (EventSender::sendTouchEvent):
630         * DumpRenderTree/qt/EventSenderQt.h:
631
632 2009-12-11  Eric Seidel  <eric@webkit.org>
633
634         Reviewed by Adam Barth.
635
636         CommandsTest.assert_execute_outputs doesn't check stderr
637         https://bugs.webkit.org/show_bug.cgi?id=32352
638
639         Fix assert_execute_outputs to check stderr
640         and then fix all the unit tests which needed to
641         pass stderr output.
642
643         * Scripts/modules/commands/commandtest.py:
644         * Scripts/modules/commands/download_unittest.py:
645         * Scripts/modules/commands/upload_unittest.py:
646
647 2009-12-11  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Eric Seidel.
650
651         [check-webkit-style] False positive for tst_QWebFrame
652         https://bugs.webkit.org/show_bug.cgi?id=32436
653
654         Add an exception for function names that start with "tst_".  These are
655         used by the Qt unit testing framework.
656
657         * Scripts/modules/cpp_style.py:
658         * Scripts/modules/cpp_style_unittest.py:
659
660 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
661
662         Reviewed by Antti Koivisto.
663
664         Added support for creating synthetic touch events with EventSender
665         in Qt's DumpRenderTree.
666
667         https://bugs.webkit.org/show_bug.cgi?id=32114
668
669         * DumpRenderTree/qt/EventSenderQt.cpp:
670         (EventSender::addTouchPoint):
671         (EventSender::updateTouchPoint):
672         (EventSender::touchStart):
673         (EventSender::touchMove):
674         (EventSender::touchEnd):
675         (EventSender::clearTouchPoints):
676         (EventSender::releaseTouchPoint):
677         (EventSender::sendTouchEvent):
678         * DumpRenderTree/qt/EventSenderQt.h:
679
680 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
681
682         Reviewed by Darin Adler.
683
684         The values of RuntimeArray are not enumerable
685         https://bugs.webkit.org/show_bug.cgi?id=29005
686
687         * DumpRenderTree/mac/ObjCController.m:
688         (+[ObjCController isSelectorExcludedFromWebScript:]):
689         (+[ObjCController webScriptNameForSelector:]):
690         (-[ObjCController arrayOfString]):
691
692 2009-12-10  Eric Seidel  <eric@webkit.org>
693
694         No review, just updating unit tests to match recent checkins.
695
696         * Scripts/modules/mock_bugzillatool.py:
697          - Add missing red_core_builders_names method causing exception.
698         * Scripts/modules/workqueue_unittest.py:
699          - processutils is dead, use executive.py instead.
700
701 2009-12-10  Eric Seidel  <eric@webkit.org>
702
703         Reviewed by Adam Barth.
704
705         Move run_command onto Executive to make code which uses run_command testable
706         https://bugs.webkit.org/show_bug.cgi?id=32396
707
708         * Scripts/modules/executive.py:
709          - Move run_command and error handlers onto Executive.
710         * Scripts/modules/scm.py:
711         * Scripts/modules/scm_unittest.py:
712
713 2009-12-09  Eric Seidel  <eric@webkit.org>
714
715         Reviewed by Adam Barth.
716
717         bugzilla-tool needs a command to list patches needing cq+
718         https://bugs.webkit.org/show_bug.cgi?id=32351
719
720         * Scripts/modules/bugzilla.py:
721          - Parse attacher_email from attachment xml.
722         * Scripts/modules/bugzilla_unittest.py:
723          - Test new attacher_email parsing.
724         * Scripts/modules/commands/queries.py:
725          - Add PatchesToCommitQueue
726         * Scripts/modules/commands/queries_unittest.py:
727          - Tests for PatchesToCommitQueue
728         * Scripts/modules/mock_bugzillatool.py:
729          - Add necessary mock methods for running PatchesToCommitQueue
730
731 2009-12-10  Adam Barth  <abarth@webkit.org>
732
733         Unreviewed.  Turns out every StepSequence command needs a --quiet
734         option.
735
736         * Scripts/modules/stepsequence.py:
737
738 2009-12-10  Eric Z. Ayers  <zundel@google.com>
739
740         Reviewed by Pavel Feldman.
741
742         Implements displayWebView() to force an invalidation and repaint.
743         This fixes a problem running the timeline-paint.html unit test.
744
745         https://bugs.webkit.org/show_bug.cgi?id=31729
746
747         * DumpRenderTree/gtk/DumpRenderTree.cpp:
748         (displayWebView):
749
750 2009-12-10  Adam Barth  <abarth@webkit.org>
751
752         Reviewed by Eric Seidel.
753
754         [bzt] Convert more commands to StepSequences
755         https://bugs.webkit.org/show_bug.cgi?id=32362
756
757         We should eventually convert all the commands, but I'm starting with
758         the easy ones.
759
760         * Scripts/modules/commands/download.py:
761
762 2009-12-10  Xan Lopez  <xlopez@igalia.com>
763
764         Reviewed by Jan Alonzo.
765
766         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
767         https://bugs.webkit.org/show_bug.cgi?id=31103
768
769         Give focus to the webviews when we create them, since some tests expect this.
770
771         * DumpRenderTree/gtk/DumpRenderTree.cpp:
772         (main):
773
774 2009-12-10  Eric Seidel  <eric@webkit.org>
775
776         Reviewed by Adam Barth.
777
778         bugzilla-tool "builders are red" error should tell you which builders
779         https://bugs.webkit.org/show_bug.cgi?id=32211
780
781         * Scripts/modules/buildsteps.py:
782
783 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
784
785         Reviewed by Adam Roben.
786
787         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
788         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
789         in Windows as part of running update_webkit.
790
791         * Scripts/update-webkit:
792          - Run setupAppleWinEnv() on Apple's Windows port.
793         * Scripts/webkitdirs.pm:
794          - Added functions that return the source directory, libraries directory and default build directory on Windows.
795          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
796          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
797            and Cygwin to their desired values.
798
799 2009-12-09  Adam Barth  <abarth@webkit.org>
800
801         Reviewed by Eric Seidel.
802
803         exception thrown when running apply-patches
804         https://bugs.webkit.org/show_bug.cgi?id=32344
805
806         The update step now takes a port option.  Once we finish the Steps
807         refactoring, we won't have to worry about this kind of bug again.
808
809         * Scripts/modules/commands/download.py:
810
811 2009-12-09  Adam Barth  <abarth@webkit.org>
812
813         Unreviewed.  Fix ScriptError includes.  I don't understand why these
814         didn't throw during unit testing...
815
816         * Scripts/modules/commands/download.py:
817         * Scripts/modules/logging_unittest.py:
818         * Scripts/modules/workqueue.py:
819
820 2009-12-09  Adam Barth  <abarth@webkit.org>
821
822         Reviewed by Eric Seidel.
823
824         [bzt] Remove unused PatchCollection class
825         https://bugs.webkit.org/show_bug.cgi?id=32312
826
827         It's dead code.
828
829         * Scripts/modules/patchcollection.py:
830         * Scripts/modules/patchcollection_unittest.py: Removed.
831
832 2009-12-09  Adam Barth  <abarth@webkit.org>
833
834         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
835
836         * Scripts/modules/commands/download.py:
837
838 2009-12-09  Adam Barth  <abarth@webkit.org>
839
840         Reviewed by Eric Seidel.
841
842         [bzt] Convert Build to use Sequence
843         https://bugs.webkit.org/show_bug.cgi?id=32310
844
845         So much prettier.
846
847         * Scripts/modules/buildsteps.py:
848         * Scripts/modules/commands/download.py:
849         * Scripts/modules/landingsequence.py:
850         * Scripts/modules/stepsequence.py: Added.
851
852 2009-12-09  Adam Barth  <abarth@webkit.org>
853
854         Add missing file.
855
856         * Scripts/modules/executive.py: Added.
857
858 2009-12-09  Adam Barth  <abarth@webkit.org>
859
860         Unreviewed "build" fix.
861
862         * Scripts/modules/landingsequence.py:
863
864 2009-12-09  Adam Barth  <abarth@webkit.org>
865
866         Reviewed by Eric Seidel.
867
868         [bzt] Implement abstract Steps
869         https://bugs.webkit.org/show_bug.cgi?id=32212
870
871         This is a fairly disruptive change that refactors how we build
872         commands.  Instead of using a landing sequence, we can now assemble a
873         sequence of steps directly.  We still use the landing sequence in the
874         interim, but this will be removed soon.
875
876         * Scripts/bugzilla-tool:
877         * Scripts/modules/buildsteps.py:
878         * Scripts/modules/commands/download.py:
879         * Scripts/modules/commands/early_warning_system.py:
880         * Scripts/modules/commands/queues.py:
881         * Scripts/modules/commands/queues_unittest.py:
882         * Scripts/modules/landingsequence.py:
883         * Scripts/modules/mock_bugzillatool.py:
884         * Scripts/modules/processutils.py: Removed.
885         * Scripts/modules/scm.py:
886         * Scripts/modules/scm_unittest.py:
887         * Scripts/modules/webkitport.py:
888
889 2009-12-08  Eric Seidel  <eric@webkit.org>
890
891         Reviewed by Adam Barth.
892
893         run_command and ScriptError should move into processutils.py
894         https://bugs.webkit.org/show_bug.cgi?id=32305
895
896         Turns out there are a zillion callers to run_command.
897
898         * Scripts/modules/commands/download.py:
899         * Scripts/modules/commands/early_warning_system.py:
900         * Scripts/modules/commands/queues.py:
901         * Scripts/modules/landingsequence.py:
902         * Scripts/modules/logging_unittest.py:
903         * Scripts/modules/processutils.py:
904         * Scripts/modules/scm.py:
905         * Scripts/modules/scm_unittest.py:
906         * Scripts/modules/workqueue.py:
907         * Scripts/modules/workqueue_unittest.py:
908
909 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
910
911         Reviewed by Kevin Ollivier.
912
913         [wx] Mac plugins support.
914         
915         https://bugs.webkit.org/show_bug.cgi?id=32236
916
917         * wx/browser/wscript:
918
919 2009-12-08  David Levin  <levin@chromium.org>
920
921         Reviewed by Adam Barth.
922
923         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
924         https://bugs.webkit.org/show_bug.cgi?id=32193
925
926         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
927           at the beginning of line, ignore lines which then have a macro.
928         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
929           new behavior.
930
931 2009-12-08  Dmitry Titov  <dimich@chromium.org>
932
933         Rubber-stamped by David Levin.
934
935         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
936         It may have caused massive increase of reported leaks on the bots.
937         https://bugs.webkit.org/show_bug.cgi?id=31639
938
939         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
940
941 2009-12-08  Dmitry Titov  <dimich@chromium.org>
942
943         Reviewed by Darin Adler.
944
945         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
946         https://bugs.webkit.org/show_bug.cgi?id=31639
947
948         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
949
950 2009-12-08  David Levin  <levin@chromium.org>
951
952         Reviewed by Adam Barth.
953
954         [check-webkit-style] False positive for camel case of JSC op codes
955         https://bugs.webkit.org/show_bug.cgi?id=32192
956
957         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
958           code functions and const_iterator as well since I noticed a false
959           positive there when testing the fix.
960         * Scripts/modules/cpp_style_unittest.py: Added tests for these
961           changes.
962
963 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
964
965         Rubber-stamped by Maciej Stachowiak.
966
967         Turn on (SVG) Filters for Win.
968         https://bugs.webkit.org/show_bug.cgi?id=32224
969
970         * Scripts/webkitdirs.pm:
971
972 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
973
974         Rubber-stamped by Maciej Stachowiak.
975
976         Turn on (SVG) Filters for Gtk.
977         https://bugs.webkit.org/show_bug.cgi?id=32224
978
979         * Scripts/build-webkit:
980
981 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
982
983         Reviewed by David Levin.
984
985         [check-webkit-style] S_OK is a fine identifier
986         https://bugs.webkit.org/show_bug.cgi?id=32225
987
988         * Scripts/modules/cpp_style.py:
989         * Scripts/modules/cpp_style_unittest.py:
990
991 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
992
993         Rubber-stamped by Maciej Stachowiak.
994
995         Turn on (SVG) Filters for Qt.
996         https://bugs.webkit.org/show_bug.cgi?id=32224
997
998         * Scripts/build-webkit:
999
1000 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
1001
1002         Reviewed by Alexey Proskuryakov.
1003
1004         Make run-webkit-websocketserver log to stderr rather than to a file.
1005         https://bugs.webkit.org/show_bug.cgi?id=32234
1006
1007         * Scripts/run-webkit-websocketserver:
1008
1009 2009-12-07  Dmitry Titov  <dimich@chromium.org>
1010
1011         Rubber-stamped by Darin Adler.
1012
1013         Remove ENABLE_SHARED_SCRIPT flags
1014         https://bugs.webkit.org/show_bug.cgi?id=32245
1015         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
1016
1017         * Scripts/build-webkit:
1018
1019 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
1020
1021         Reviewed by Darin Adler.
1022
1023         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
1024
1025         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
1026         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
1027         This caused one compositing test make DumpRenderTree think that all subsequent tests
1028         were compositing too.
1029
1030         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
1031         notification informs the client that a WebHTMLView entered compositing mode (or an already-
1032         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
1033         compositing subviews were removed, since this is tricky to get right.
1034         
1035         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
1036         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
1037         We ensure that window autodisplay is turned off before every test.
1038
1039         * DumpRenderTree/mac/DumpRenderTree.mm:
1040         (createWebViewAndOffscreenWindow):
1041         (resetWebViewToConsistentStateBeforeTesting):
1042         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1043         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1044         (-[DumpRenderTreeWindow close]):
1045         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
1046         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
1047
1048 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1049
1050         Reviewed by Holger Hans Peter Freyther.
1051
1052         Turn on (SVG) Filters support, by default.
1053         https://bugs.webkit.org/show_bug.cgi?id=32224
1054
1055         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
1056
1057         * Scripts/build-webkit:
1058
1059 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
1060
1061         Reviewed by Darin Fisher.
1062
1063         Chromium buildbots are not red when they fail
1064         https://bugs.webkit.org/show_bug.cgi?id=32235
1065
1066         * Scripts/build-webkit:
1067
1068 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
1069
1070         Reviewed by Darin Fisher.
1071
1072         Typo in chromium linux builder
1073         https://bugs.webkit.org/show_bug.cgi?id=32238
1074
1075         * Scripts/webkitdirs.pm:
1076
1077 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
1078
1079         Reviewed by Darin Fisher.
1080
1081         fixes to build-webkit --chromium
1082         https://bugs.webkit.org/show_bug.cgi?id=32179
1083
1084         * Scripts/webkitdirs.pm:
1085
1086 2009-12-07  Eric Seidel  <eric@webkit.org>
1087
1088         No review, just adding two recently approved committers.
1089
1090         * Scripts/modules/committers.py:
1091
1092 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
1093
1094         * Scripts/run-webkit-websocketserver: Added property svn:executable.
1095
1096 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
1097
1098         Reviewed by Alexey Proskuryakov.
1099
1100         Add run-webkit-websocketserver
1101
1102         https://bugs.webkit.org/show_bug.cgi?id=31390
1103
1104         * Scripts/run-webkit-websocketserver: Added.
1105
1106 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
1107
1108         Build fix. Be flexible about which version of ICU is used on Windows.
1109
1110         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
1111
1112 2009-12-07  Dirk Schulze  <krit@webkit.org>
1113
1114         Not reviewed, adding myself to the reviewers list.
1115
1116         * Scripts/modules/committers.py:
1117
1118 2009-12-06  Eric Seidel  <eric@webkit.org>
1119
1120         Reviewed by Adam Barth.
1121
1122         Add an API for uploading results files to StatusBot
1123         https://bugs.webkit.org/show_bug.cgi?id=32210
1124
1125         Add Content-Type: plain/text which was forgotten
1126         from the previous commit when I landed with land-patches
1127         instead of land-diff.
1128
1129         * QueueStatusServer/queue_status.py:
1130
1131 2009-12-06  Eric Seidel  <eric@webkit.org>
1132
1133         Reviewed by Adam Barth.
1134
1135         Status Server needs a way to handle uploaded results
1136         https://bugs.webkit.org/show_bug.cgi?id=32209
1137
1138         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
1139         * QueueStatusServer/update_status.html: Add file upload.
1140
1141 2009-12-06  Eric Seidel  <eric@webkit.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         Add an API for uploading results files to StatusBot
1146         https://bugs.webkit.org/show_bug.cgi?id=32210
1147
1148         * Scripts/modules/statusbot.py:
1149
1150 2009-12-06  Eric Seidel  <eric@webkit.org>
1151
1152         Reviewed by Adam Barth.
1153
1154         Status Server needs a way to handle uploaded results
1155         https://bugs.webkit.org/show_bug.cgi?id=32209
1156
1157         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
1158         * QueueStatusServer/update_status.html: Add file upload.
1159
1160 2009-12-06  Adam Barth  <abarth@webkit.org>
1161
1162         Reviewed by Eric Seidel.
1163
1164         [bzt] BuildAttachment should not check the builders
1165         https://bugs.webkit.org/show_bug.cgi?id=32207
1166
1167         This is code that got copied here by accident when the class was created.
1168
1169         * Scripts/modules/commands/download.py:
1170
1171 2009-12-06  Adam Barth  <abarth@webkit.org>
1172
1173         Reviewed by Eric Seidel.
1174
1175         [bzt] Make LandingSequence.update aware of ports
1176         https://bugs.webkit.org/show_bug.cgi?id=32208
1177
1178         This is required to make build work on the Chromium port because
1179         Chromium has a custom update-webkit.
1180
1181         * Scripts/modules/landingsequence.py:
1182
1183 2009-12-06  Adam Barth  <abarth@webkit.org>
1184
1185         Reviewed by Eric Seidel.
1186
1187         Add early warning system commands to bugzilla-tool.
1188
1189         * Scripts/bugzilla-tool:
1190         * Scripts/modules/landingsequence.py:
1191         * Scripts/modules/webkitport.py:
1192
1193 2009-12-06  Adam Barth  <abarth@webkit.org>
1194
1195         Reviewed by Eric Seidel.
1196
1197         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
1198         https://bugs.webkit.org/show_bug.cgi?id=32205
1199
1200         * Scripts/modules/commands/early_warning_system.py: Added.
1201         * Scripts/modules/commands/queues.py:
1202
1203 2009-12-06  Dan Bernstein  <mitz@apple.com>
1204
1205         Reviewed by Adele Peterson.
1206
1207         REGRESSION (r51728): update-webkit fails when the current directory is
1208         not inside a Subversion working copy
1209         https://bugs.webkit.org/show_bug.cgi?id=32204
1210
1211         * Scripts/update-webkit: Invoke isSVN() in the correct working
1212         directory.
1213
1214 2009-12-06  Adam Barth  <abarth@webkit.org>
1215
1216         Reviewed by Eric Seidel.
1217
1218         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
1219         https://bugs.webkit.org/show_bug.cgi?id=32202
1220
1221         * Scripts/modules/commands/queues.py:
1222
1223 2009-12-05  Adam Barth  <abarth@webkit.org>
1224
1225         Reviewed by Eric Seidel.
1226
1227         [bzt] Implement ChromiumPort
1228         https://bugs.webkit.org/show_bug.cgi?id=32182
1229
1230         * Scripts/modules/webkitport.py:
1231         * Scripts/modules/webkitport_unittest.py:
1232
1233 2009-12-05  Adam Barth  <abarth@webkit.org>
1234
1235         Reviewed by Eric Seidel.
1236
1237         Move update-webkit into BuildSteps
1238         https://bugs.webkit.org/show_bug.cgi?id=32181
1239
1240         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
1241         that WebKit exists.  The proper place for the knowledge of the existence of
1242         update-webkit is in WebKitPort because some ports have specialized update
1243         scripts (analogous to build-webkit).
1244
1245         * Scripts/modules/buildsteps.py:
1246         * Scripts/modules/commands/download.py:
1247         * Scripts/modules/landingsequence.py:
1248         * Scripts/modules/scm.py:
1249         * Scripts/modules/webkitport.py:
1250
1251 2009-12-05  Adam Barth  <abarth@webkit.org>
1252
1253         Reviewed by Eric Seidel.
1254
1255         update-webkit should call git svn rebase and resolve-ChangeLogs -f
1256         https://bugs.webkit.org/show_bug.cgi?id=27162
1257
1258         Teach update-webkit about Git.  I didn't add the call to
1259         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
1260         can iterate from here, however.
1261
1262         * Scripts/update-webkit:
1263
1264 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
1265
1266         Unreviewed build fix.
1267
1268         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
1269
1270         * DumpRenderTree/qt/DumpRenderTree.cpp:
1271
1272 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1273
1274         Reviewed by Adam Treat.
1275
1276         Add some missing methods for showing and hiding the
1277         Web Inspector.
1278
1279         * DumpRenderTree/qt/DumpRenderTree.cpp:
1280         (WebCore::WebPage::WebPage):
1281         (WebCore::WebPage::~WebPage):
1282         (WebCore::WebPage::webInspector):
1283         * DumpRenderTree/qt/DumpRenderTree.h:
1284         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1285         (LayoutTestController::showWebInspector):
1286         (LayoutTestController::hideWebInspector):
1287         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1288
1289 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1290
1291         Reviewed by Adam Treat.
1292
1293         Implement the setAllowUniversalAccessFromFileURLs method
1294         for the Qt LayoutTestController.
1295
1296         * DumpRenderTree/qt/DumpRenderTree.cpp:
1297         (WebCore::WebPage::resetSettings):
1298         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1299         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1300         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1301
1302 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
1303
1304         Reviewed by Darin Adler.
1305
1306         REGRESSION: AX: buttons now extremely repetitive
1307         https://bugs.webkit.org/show_bug.cgi?id=32164
1308
1309         * DumpRenderTree/AccessibilityUIElement.cpp:
1310         (isAttributeSupportedCallback):
1311         (AccessibilityUIElement::getJSClass):
1312         * DumpRenderTree/AccessibilityUIElement.h:
1313         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1314         (AccessibilityUIElement::isAttributeSupported):
1315         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1316         (AccessibilityUIElement::isAttributeSupported):
1317         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1318         (AccessibilityUIElement::isAttributeSupported):
1319
1320 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
1321
1322         Reviewed by David Levin.
1323
1324         check-webkit-style should check for camelCase variable names
1325         https://bugs.webkit.org/show_bug.cgi?id=32051
1326
1327         * Scripts/modules/cpp_style.py:
1328         * Scripts/modules/cpp_style_unittest.py:
1329
1330 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1331
1332         Reviewed by Eric Seidel.
1333
1334         AX: VO just says "term" on many web sites
1335         https://bugs.webkit.org/show_bug.cgi?id=32139
1336
1337         * DumpRenderTree/AccessibilityUIElement.cpp:
1338         (getRoleDescriptionCallback):
1339         (AccessibilityUIElement::getJSClass):
1340         * DumpRenderTree/AccessibilityUIElement.h:
1341         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1342         (AccessibilityUIElement::roleDescription):
1343         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1344         (AccessibilityUIElement::roleDescription):
1345         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1346         (AccessibilityUIElement::roleDescription):
1347
1348 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
1349
1350         Reviewed by Beth Dakin.
1351
1352         Implement WAI-ARIA scrollbar role and related property aria-orientation
1353         https://bugs.webkit.org/show_bug.cgi?id=32126
1354
1355         * DumpRenderTree/AccessibilityUIElement.cpp:
1356         (getOrientationCallback):
1357         (AccessibilityUIElement::getJSClass):
1358         * DumpRenderTree/AccessibilityUIElement.h:
1359         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1360         (AccessibilityUIElement::orientation):
1361         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1362         (AccessibilityUIElement::orientation):
1363         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1364         (AccessibilityUIElement::orientation):
1365
1366 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
1367
1368         Reviewed by Adam Roben.
1369
1370         Minor correction to r51663.
1371
1372         * DumpRenderTree/win/DumpRenderTree.cpp:
1373         (addQTDirToPATH):
1374             GetEnvironmentVariable -> GetEnvironmentVariableW.
1375
1376 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
1377
1378         Reviewed by Adam Roben.
1379
1380         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
1381         https://bugs.webkit.org/show_bug.cgi?id=30256
1382
1383         Add the QuickTime dll directory to the PATH environment variable so
1384         inialization can succeed.
1385
1386         * DumpRenderTree/win/DumpRenderTree.cpp:
1387         (addQTDirToPATH):
1388         (initialize):
1389
1390 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
1391
1392         Reviewed by Kenneth Rohde Christiansen.
1393
1394         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
1395
1396         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1397         (LayoutTestController::maybeDump):
1398
1399 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
1400
1401         Reviewed by Eric Seidel.
1402
1403         Update pywebsocket to 0.4.3
1404         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
1405         Stack trace is logged now in INFO level.
1406         https://bugs.webkit.org/show_bug.cgi?id=32097
1407
1408         * pywebsocket/mod_pywebsocket/dispatch.py:
1409         * pywebsocket/mod_pywebsocket/msgutil.py:
1410         * pywebsocket/mod_pywebsocket/standalone.py:
1411         * pywebsocket/mod_pywebsocket/util.py:
1412         * pywebsocket/setup.py:
1413         * pywebsocket/test/test_dispatch.py:
1414         * pywebsocket/test/test_util.py:
1415
1416 2009-12-03  Sam Weinig  <sam@webkit.org>
1417
1418         Reviewed by Gavin Barraclough.
1419
1420         Fix JSClassRef leak.
1421
1422         * DumpRenderTree/AccessibilityController.cpp:
1423         (AccessibilityController::makeWindowObject):
1424         * DumpRenderTree/GCController.cpp:
1425         (GCController::makeWindowObject):
1426         * DumpRenderTree/LayoutTestController.cpp:
1427         (LayoutTestController::makeWindowObject):
1428
1429 2009-12-03  Brady Eidson  <beidson@apple.com>
1430
1431         Reviewed by Sam Weinig.
1432
1433         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
1434
1435         Keep DRT-win building...
1436
1437         * DumpRenderTree/win/FrameLoadDelegate.h:
1438         (FrameLoadDelegate::didPushStateWithinPageForFrame):
1439         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
1440         (FrameLoadDelegate::didPopStateWithinPageForFrame):
1441
1442 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
1443
1444         Unreviewed build fix.
1445
1446         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
1447
1448         * DumpRenderTree/qt/DumpRenderTree.cpp:
1449
1450 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
1451
1452         Reviewed by Kenneth Rohde Christiansen.
1453
1454         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
1455         Prevent DRT from showing the main view if these childs get deleted.
1456         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
1457
1458         * DumpRenderTree/qt/DumpRenderTree.cpp:
1459         (WebCore::WebPage::WebPage):
1460         (WebCore::DumpRenderTree::DumpRenderTree):
1461         (WebCore::DumpRenderTree::~DumpRenderTree):
1462         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1463         (WebCore::DumpRenderTree::open):
1464         (WebCore::DumpRenderTree::closeRemainingWindows):
1465         (WebCore::DumpRenderTree::createWindow):
1466         (WebCore::DumpRenderTree::windowCount):
1467         * DumpRenderTree/qt/DumpRenderTree.h:
1468
1469 2009-12-02  Eric Seidel  <eric@webkit.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         REGRESSION(51595): commit-queue is throwing exceptions
1474         https://bugs.webkit.org/show_bug.cgi?id=32083
1475
1476         * Scripts/modules/commands/queues.py:
1477          - Don't use default value of [] as it ends up getting shared.
1478          - Make log_progress accept arrays of ints as well as strings.
1479          - Return an exit code from execute()
1480         * Scripts/modules/commands/queues_unittest.py: Added.
1481          - Test to make sure log_progress will accept ints.
1482          - Test to make sure run_bugzilla_tool will accept ints.
1483         * Scripts/modules/workqueue.py:
1484          - Print the stack trace on unexpected exceptions for easier debugging.
1485         * Scripts/run-webkit-unittests:
1486          - Add queues_unittest.
1487
1488         * Scripts/modules/commands/queues.py:
1489         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
1490         * Scripts/modules/mock_bugzillatool.py:
1491         * Scripts/modules/workqueue.py:
1492         * Scripts/run-webkit-unittests:
1493
1494 2009-12-02  David Levin  <levin@chromium.org>
1495
1496         Reviewed by Adam Barth.
1497
1498         check-webkit-style is too noisy about namespace indenting issues.
1499         https://bugs.webkit.org/show_bug.cgi?id=32096
1500
1501         * Scripts/modules/cpp_style.py:
1502         Added a _FileState object to be able to track file level information. In this
1503         case, it simply tracks whether the error has already been given, so that it isn't
1504         done again.
1505         * Scripts/modules/cpp_style_unittest.py:
1506         Modified test cases to pass in the _FileState object and fix a test that expected
1507         to see the namespace error twice (now it only occurs once). No new tests because
1508         existing tests cover the change in functionality.
1509
1510 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
1511
1512         Reviewed by Eric Seidel.
1513
1514         [wx] Get DumpRenderTree building after waf switch.
1515         
1516         https://bugs.webkit.org/show_bug.cgi?id=32041
1517
1518         * DumpRenderTree/wscript: Added.
1519         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1520         (LayoutTestController::setTimelineProfilingEnabled):
1521         (LayoutTestController::evaluateScriptInIsolatedWorld):
1522         (LayoutTestController::disableImageLoading):
1523         (LayoutTestController::whiteListAccessFromOrigin):
1524         (LayoutTestController::counterValueForElementById):
1525         * Scripts/build-webkit:
1526
1527 2009-12-02  Adam Barth  <abarth@webkit.org>
1528
1529         Reviewed by Eric Seidel.
1530
1531         [bzt] build-attachment shouldn't check whether the builders are red
1532         https://bugs.webkit.org/show_bug.cgi?id=32062
1533
1534         build-attachment doesn't touch the remote repository, so there isn't a
1535         need to hold off when the builders are red.
1536
1537         * Scripts/modules/commands/download.py:
1538         * Scripts/modules/landingsequence.py:
1539
1540 2009-12-02  Eric Seidel  <eric@webkit.org>
1541
1542         Reviewed by Adam Barth.
1543
1544         REGRESSION(51590): style-queue and build-queue think their empty when they are not
1545         https://bugs.webkit.org/show_bug.cgi?id=32061
1546
1547         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
1548         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
1549
1550 2009-12-02  Eric Seidel  <eric@webkit.org>
1551
1552         Reviewed by Adam Barth.
1553
1554         build-queue is throwing exceptions and complaining about
1555         lack of --no-update on build-attachment.  Make it stop.
1556
1557         * Scripts/modules/buildsteps.py:
1558         * Scripts/modules/commands/download.py:
1559
1560 2009-12-02  Adam Barth  <abarth@webkit.org>
1561
1562         Unreviewed "build" fix.  Forgot to declare my variables.  :(
1563
1564         * QueueStatusServer/queue_status.py:
1565
1566 2009-12-02  Adam Barth  <abarth@webkit.org>
1567
1568         Reviewed by Eric Seidel.
1569
1570         [bzt] Implement status bubble view
1571         https://bugs.webkit.org/show_bug.cgi?id=32057
1572
1573         The status bubble is a compact representation of the queue status for a
1574         given patch.  This will eventually help us reduce the comment spam from
1575         the queues.
1576
1577         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
1578         * QueueStatusServer/queue_status.py:
1579         * QueueStatusServer/status_bubble.html: Added.
1580
1581 2009-12-02  Eric Seidel  <eric@webkit.org>
1582
1583         Reviewed by Adam Barth.
1584
1585         trim commands/*.py includes now that commands are unit tested
1586         https://bugs.webkit.org/show_bug.cgi?id=32056
1587
1588         In the course of ensuring that the unit tests still
1589         passed after this change, I had to actually make them
1590         pass in the first place.
1591
1592         * Scripts/modules/bugzilla.py:
1593          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
1594         * Scripts/modules/commands/download.py: Remove unneeded imports.
1595         * Scripts/modules/commands/queries.py: Ditto.
1596         * Scripts/modules/commands/queues.py: Ditto.
1597         * Scripts/modules/commands/upload.py: Ditto.
1598         * Scripts/modules/scm_unittest.py:
1599          - Fix to expect the \n after the path since echo adds an \n.
1600
1601 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
1602
1603         build-webkit: Remove flex,bison,gperf check for chromium
1604         https://bugs.webkit.org/show_bug.cgi?id=32043
1605
1606         * Scripts/webkitdirs.pm:
1607
1608 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1609
1610         Build fixage for Windows/GTK for DumpRenderTree.
1611
1612         WAI-ARIA: implement support for ARIA drag and drop
1613         https://bugs.webkit.org/show_bug.cgi?id=32007
1614
1615         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1616         (AccessibilityUIElement::ariaIsGrabbed):
1617         (AccessibilityUIElement::ariaDropEffects):
1618         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1619         (AccessibilityUIElement::ariaIsGrabbed):
1620         (AccessibilityUIElement::ariaDropEffects):
1621
1622 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1623
1624         Reviewed by Darin Adler.
1625
1626         WAI-ARIA: implement support for ARIA drag and drop
1627         https://bugs.webkit.org/show_bug.cgi?id=32007
1628
1629         * DumpRenderTree/AccessibilityUIElement.cpp:
1630         (getARIADropEffectsCallback):
1631         (getARIAIsGrabbedCallback):
1632         (AccessibilityUIElement::getJSClass):
1633         * DumpRenderTree/AccessibilityUIElement.h:
1634         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1635         (AccessibilityUIElement::ariaIsGrabbed):
1636         (AccessibilityUIElement::ariaDropEffects):
1637
1638 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1639
1640         Not reviewed. GTK DRT try 2.
1641
1642         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1643         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1644
1645 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1646
1647         Not reviewed. Try to fix gtk DRT build.
1648
1649         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1650
1651 2009-12-01  David Levin  <levin@chromium.org>
1652
1653         Reviewed by Eric Seidel.
1654
1655         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
1656         https://bugs.webkit.org/show_bug.cgi?id=32033
1657
1658         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
1659                                         instead of startswith.
1660         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
1661
1662 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1663
1664         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
1665
1666         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
1667
1668 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1669
1670         Reviewed by Simon Fraser.
1671
1672         Add SVG animation test framework with 'snapshot' functionality
1673         https://bugs.webkit.org/show_bug.cgi?id=31897
1674
1675         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
1676         used by the new SVG animation testing framework, implemented
1677         for qt/gtk/win/mac.
1678
1679         * DumpRenderTree/LayoutTestController.cpp:
1680         (sampleSVGAnimationForElementAtTimeCallback):
1681         (LayoutTestController::staticFunctions):
1682         * DumpRenderTree/LayoutTestController.h:
1683         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1684         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1685         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1686         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1687         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1688         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1689         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1690         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1691         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1692         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1693         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1694
1695 2009-12-01  Adam Roben  <aroben@apple.com>
1696
1697         Remove user content before running each test on Windows
1698
1699         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
1700
1701         Reviewed by Alexey Proskuryakov.
1702
1703         * DumpRenderTree/win/DumpRenderTree.cpp:
1704         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
1705         before each test, which matches Mac.
1706
1707 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
1708
1709         Reviewed by Alexey Proskuryakov.
1710
1711         Make pywebsocket log errors to a file
1712         https://bugs.webkit.org/show_bug.cgi?id=31604
1713
1714         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
1715         (by passing the path to the server via a recently added -l option).
1716
1717 2009-12-01  Adam Roben  <aroben@apple.com>
1718
1719         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
1720
1721         Reviewed by Ada Chan.
1722
1723         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
1724         TestNetscapePlugin fail in Debug_Internal builds
1725
1726         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
1727         directory in Debug and Debug_All builds, but not in Debug_Internal
1728         builds.
1729
1730 2009-12-01  Adam Roben  <aroben@apple.com>
1731
1732         Re-enable DRT's watchdog timer on Windows
1733
1734         It was accidentally disabled in r50907.
1735
1736         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1737         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
1738         into an if condition.
1739
1740 2009-12-01  Adam Barth  <abarth@webkit.org>
1741
1742         Reviewed by Eric Seidel.
1743
1744         check-webkit-style complains about #imports with / in them
1745         https://bugs.webkit.org/show_bug.cgi?id=32022
1746
1747         We need to exclude #import directives in addition to #include from the
1748         binary operator whitespace checks.
1749
1750         * Scripts/modules/cpp_style.py:
1751         * Scripts/modules/cpp_style_unittest.py:
1752
1753 2009-11-30  Adam Barth  <abarth@webkit.org>
1754
1755         Reviewed by Eric Seidel.
1756
1757         check-webkit-style is slightly too verbose
1758         https://bugs.webkit.org/show_bug.cgi?id=32010
1759
1760         check-webkit-style prints out a bunch of "done" lines that seem redundant,
1761         especially for the style-queue.
1762
1763         * Scripts/modules/cpp_style.py:
1764
1765 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
1766
1767         Reviewed by Eric Seidel.
1768
1769         [GTK] Moved the functions that are closing the result log of the
1770         tests to the last line of the runTest function, this avoids
1771         reporting crashes in the wrong test if there is a problem when
1772         reseting the state after the test.
1773
1774         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1775         (dump):
1776         (runTest):
1777
1778 2009-11-30  Sam Weinig  <sam@webkit.org>
1779
1780         Reviewed by Geoffrey Garen.
1781
1782         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
1783         fast/js/date-proto-generic-invocation breaks another test
1784
1785         Don't cache JSClassRefs, a change to the prototype chain will
1786         last between tests.
1787
1788         * DumpRenderTree/AccessibilityController.cpp:
1789         (AccessibilityController::getJSClass):
1790         * DumpRenderTree/GCController.cpp:
1791         (GCController::getJSClass):
1792         * DumpRenderTree/GCController.h:
1793         * DumpRenderTree/LayoutTestController.cpp:
1794         (LayoutTestController::getJSClass):
1795
1796 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
1797
1798         Reviewed by Alexey Proskuryakov.
1799
1800         Update pywebsocket to 0.4.2.1.
1801         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
1802         https://bugs.webkit.org/show_bug.cgi?id=31976
1803
1804         * pywebsocket/mod_pywebsocket/standalone.py:
1805         * pywebsocket/setup.py:
1806
1807 2009-11-30  Adam Barth  <abarth@webkit.org>
1808
1809         Reviewed by Eric Seidel.
1810
1811         [bzt] Generate pass messages for style-queue
1812         https://bugs.webkit.org/show_bug.cgi?id=31995
1813
1814         With this change, the style-queue posts "pass" messages to bugs as
1815         well.  Also, added more information to the state store w.r.t. passing
1816         and failing.
1817
1818         * Scripts/modules/commands/queues.py:
1819         * Scripts/modules/patchcollection.py:
1820
1821 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1822
1823         Reviewed by Simon Fraser.
1824
1825         Check for WEBKIT_TESTFONTS environment variable in
1826         run-webkit-tests, for GTK+, to have a more prominent error
1827         message.
1828
1829         * Scripts/run-webkit-tests:
1830
1831 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
1832
1833         Reviewed by Dimitri Glazkov.
1834
1835         update-webkit --chromium forces gclient sync
1836
1837         https://bugs.webkit.org/show_bug.cgi?id=31967
1838
1839         * Scripts/update-webkit-chromium:
1840
1841 2009-11-29  Eric Seidel  <eric@webkit.org>
1842
1843         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
1844
1845         * Scripts/modules/committers.py:
1846
1847 2009-11-29  Eric Seidel  <eric@webkit.org>
1848
1849         No review, just adding missing svn property.
1850
1851         Set svn:executable property on new scripts.
1852         These were added by commit-queue commits, but the executable
1853         property was lost due to a bug in svn-apply:
1854         https://bugs.webkit.org/show_bug.cgi?id=27204
1855
1856         * Scripts/update-webkit-chromium: Added property svn:executable.
1857         * Scripts/validate-committer-lists: Added property svn:executable.
1858
1859 2009-11-29  Eric Seidel  <eric@webkit.org>
1860
1861         Reviewed by Adam Barth.
1862
1863         Need a way to validate that committers.py includes all committers/reviewers
1864         https://bugs.webkit.org/show_bug.cgi?id=30970
1865
1866         Add a script which knows how to compare our public committer/reviewer
1867         lists and show discrepancies between them.
1868
1869         Validates mailing lists vs. committers.py:
1870         - committers.py committers missing from webkit-committers@lists
1871         - webkit-committers@lists members missing from committers.py
1872         - committers.py reviewers missing from webkit-reviewers@lists
1873         - webkit-reviewers@lists members missing from committers.py
1874         - webkit-reviewers@lists members missing from committers.py reviewer list
1875
1876         Validates committers.py vs. trunk/ SVN history:
1877         - committers who have not committed in over a year
1878         - SVN committers missing from committers.py
1879         - committers.py members who have no record in SVN.
1880
1881         All of these lists still show "false positives" until a few more committers.py updates are made, like:
1882         https://bugs.webkit.org/show_bug.cgi?id=31366
1883
1884         * Scripts/validate-committer-lists: Added.
1885
1886 2009-11-28  Adam Barth  <abarth@webkit.org>
1887
1888         Reviewed by Eric Seidel.
1889
1890         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
1891         https://bugs.webkit.org/show_bug.cgi?id=31950
1892
1893         Now we cache the last status that we get back from QueueStatusServer.
1894         Eventually we'll have to do something more fancy if we want to support
1895         a "try again" button on QueueStatusServer, but we can cross that bridge
1896         when we come to it.
1897
1898         * Scripts/modules/patchcollection.py:
1899
1900 2009-11-28  Adam Barth  <abarth@webkit.org>
1901
1902         Reviewed by Eric Seidel.
1903
1904         StyleQueue scans ~100 bug pages every 5 minutes
1905         https://bugs.webkit.org/show_bug.cgi?id=31947
1906
1907         Instead of getting the pending-review attachment ids by scanning each
1908         bug (which results in a network request), we should just get them all
1909         from webkit.org/pending-review in one shot.
1910
1911         * Scripts/modules/bugzilla.py:
1912         * Scripts/modules/bugzilla_unittest.py:
1913         * Scripts/modules/commands/queries.py:
1914         * Scripts/modules/commands/queries_unittest.py:
1915         * Scripts/modules/commands/queues.py:
1916         * Scripts/modules/mock_bugzillatool.py:
1917         * Scripts/modules/patchcollection.py:
1918
1919 2009-11-28  Adam Barth  <abarth@webkit.org>
1920
1921         Reviewed by Eric Seidel.
1922
1923         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
1924         https://bugs.webkit.org/show_bug.cgi?id=31952
1925
1926         The mailing list is open for anyone to subscribe.
1927
1928         * Scripts/modules/bugzilla.py:
1929         * Scripts/modules/commands/queues.py:
1930
1931 2009-11-28  Adam Barth  <abarth@webkit.org>
1932
1933         Reviewed by Eric Seidel.
1934
1935         [bzt] style-queue should report style errors to bugzilla
1936         https://bugs.webkit.org/show_bug.cgi?id=31945
1937
1938         Currently, we're just logging the style errors locally.  With this
1939         patch we'll actually log the errors to bugzilla.  Note: I plan to run
1940         with the "local-only" logging during development.
1941
1942         * Scripts/modules/commands/queues.py:
1943         * Scripts/modules/scm.py:
1944
1945 2009-11-28  Adam Barth  <abarth@webkit.org>
1946
1947         Reviewed by Eric Seidel.
1948
1949         [bzt] style-queue shouldn't reject patches from the commit-queue
1950         https://bugs.webkit.org/show_bug.cgi?id=31944
1951
1952         Currently the style-queue subprocess gets confused and thinks its the
1953         commit-queue.  If the patch has an error, it rejects it from the
1954         commit-queue.  Instead, we should have style-queue specific logic.
1955         This patch doesn't add that logic, but it gives us a callback we can
1956         use to add that logic.
1957
1958         * Scripts/modules/buildsteps.py:
1959         * Scripts/modules/commands/queues.py:
1960         * Scripts/modules/landingsequence.py:
1961
1962 2009-11-27  Adam Barth  <abarth@webkit.org>
1963
1964         Rubber stamped by Eric Seidel.
1965
1966         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
1967
1968         * CommitQueueStatus: Removed.
1969         * CommitQueueStatus/app.yaml: Removed.
1970         * CommitQueueStatus/filters: Removed.
1971         * CommitQueueStatus/filters/__init__.py: Removed.
1972         * CommitQueueStatus/filters/webkit_extras.py: Removed.
1973         * CommitQueueStatus/index.html: Removed.
1974         * CommitQueueStatus/index.yaml: Removed.
1975         * CommitQueueStatus/queue_status.py: Removed.
1976         * CommitQueueStatus/stylesheets: Removed.
1977         * CommitQueueStatus/stylesheets/main.css: Removed.
1978         * CommitQueueStatus/update_status.html: Removed.
1979         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
1980
1981 2009-11-27  Adam Barth  <abarth@webkit.org>
1982
1983         Reviewed by Eric Seidel.
1984
1985         style-queue should only process each patch once
1986         https://bugs.webkit.org/show_bug.cgi?id=31939
1987
1988         Actually address reviewer comments!
1989
1990         * Scripts/bugzilla-tool:
1991
1992 2009-11-27  Adam Barth  <abarth@webkit.org>
1993
1994         Reviewed by Eric Seidel.
1995
1996         [bzt] style-queue fails to apply a bunch of patches for no reason
1997         https://bugs.webkit.org/show_bug.cgi?id=31942
1998
1999         By passing --non-interactive to check-style, we convince check-style
2000         to pass --force to svn-apply, which lets it apply more patches.
2001
2002         * Scripts/modules/commands/queues.py:
2003
2004 2009-11-27  Adam Barth  <abarth@webkit.org>
2005
2006         Reviewed by Eric Seidel.
2007
2008         [bzt] Support --status-host in style-queue
2009         https://bugs.webkit.org/show_bug.cgi?id=31941
2010
2011         * Scripts/modules/commands/queues.py:
2012         * Scripts/modules/statusbot.py:
2013
2014 2009-11-27  Adam Barth  <abarth@webkit.org>
2015
2016         Reviewed by Eric Seidel.
2017
2018         style-queue should only process each patch once
2019         https://bugs.webkit.org/show_bug.cgi?id=31939
2020
2021         Before processing a patch, the try-queues now ask the web service
2022         whether they have already processed the patch.  This is an initial cut
2023         of this functionality.  I expect we're make it richer over time.
2024
2025         * Scripts/bugzilla-tool:
2026         * Scripts/modules/commands/queues.py:
2027         * Scripts/modules/patchcollection.py:
2028
2029 2009-11-27  Adam Barth  <abarth@webkit.org>
2030
2031         Reviewed by Eric Seidel.
2032
2033         PatchStatus does not return status
2034         https://bugs.webkit.org/show_bug.cgi?id=31938
2035
2036         We need to parse attachment_id as an int.  Otherwise, we can't find
2037         anything in the datastore.
2038
2039         * CommitQueueStatus/queue_status.py:
2040
2041 2009-11-27  Adam Barth  <abarth@webkit.org>
2042
2043         Reviewed by Eric Seidel.
2044
2045         Make commit-queue status not throw an exception where there is not
2046         status
2047         https://bugs.webkit.org/show_bug.cgi?id=31936
2048
2049         We need to actually fetch the results of the query to see what's in the
2050         datastore.
2051
2052         * CommitQueueStatus/queue_status.py:
2053
2054 2009-11-27  Adam Barth  <abarth@webkit.org>
2055
2056         Reviewed by Eric Seidel.
2057
2058         [bzt] unit test ApplyPatches and ApplyAttachment
2059         https://bugs.webkit.org/show_bug.cgi?id=31935
2060
2061         * Scripts/modules/commands/download.py:
2062         * Scripts/modules/commands/download_unittest.py:
2063
2064 2009-11-27  Adam Barth  <abarth@webkit.org>
2065
2066         Reviewed by Eric Seidel.
2067
2068         [bzt] Unit test download commands
2069         https://bugs.webkit.org/show_bug.cgi?id=31923
2070
2071         Adds download_unittest and fixes a bug found while testing.
2072
2073         * Scripts/modules/commands/commandtest.py:
2074         * Scripts/modules/commands/download.py:
2075             Fixed a bug where we'd throw an error because [].append returns
2076             None.
2077         * Scripts/modules/commands/download_unittest.py: Added.
2078         * Scripts/modules/mock_bugzillatool.py:
2079         * Scripts/run-webkit-unittests:
2080
2081 2009-11-27  Adam Barth  <abarth@webkit.org>
2082
2083         Unreviewed "build" fix found while writing unit tests.
2084
2085         * Scripts/modules/commands/download.py:
2086
2087 2009-11-27  Adam Barth  <abarth@webkit.org>
2088
2089         Reviewed by Eric Seidel.
2090
2091         [bzt] Kill WebKitLandingScripts
2092         https://bugs.webkit.org/show_bug.cgi?id=31904
2093
2094         Step 6: Kill the rest.
2095
2096         * Scripts/modules/buildsteps.py:
2097         * Scripts/modules/commands/download.py:
2098         * Scripts/modules/commands/queries.py:
2099         * Scripts/modules/commands/upload.py:
2100         * Scripts/modules/landingsequence.py:
2101         * Scripts/modules/scm.py:
2102         * Scripts/modules/webkitlandingscripts.py: Removed.
2103
2104 2009-11-27  Adam Barth  <abarth@webkit.org>
2105
2106         Reviewed by Eric Seidel.
2107
2108         [bzt] Unit test upload commands
2109         https://bugs.webkit.org/show_bug.cgi?id=31903
2110
2111         Adds unit tests for all but two of the upload commands.  The two
2112         remaining ones are more difficult.  I'll return to them later.  The
2113         goal of these tests is just to run the commands.  We can test more
2114         detailed behavior later.
2115
2116         * Scripts/modules/commands/commandtest.py:
2117         * Scripts/modules/commands/upload.py:
2118         * Scripts/modules/commands/upload_unittest.py:
2119         * Scripts/modules/mock.py: Added.
2120         * Scripts/modules/mock_bugzillatool.py:
2121
2122 2009-11-26  Adam Barth  <abarth@webkit.org>
2123
2124         Reviewed by Eric Seidel.
2125
2126         [bzt] Kill WebKitLandingScripts
2127         https://bugs.webkit.org/show_bug.cgi?id=31904
2128
2129         Step 5: Kill run_and_throw_if_fail.
2130
2131         * Scripts/modules/buildsteps.py:
2132         * Scripts/modules/processutils.py: Added.
2133         * Scripts/modules/webkitlandingscripts.py:
2134
2135 2009-11-26  Adam Barth  <abarth@webkit.org>
2136
2137         Reviewed by Eric Seidel.
2138
2139         [bzt] Kill WebKitLandingScripts
2140         https://bugs.webkit.org/show_bug.cgi?id=31904
2141
2142         Step 4: Kill run_webkit_script.
2143
2144         * Scripts/modules/buildsteps.py:
2145         * Scripts/modules/commands/download.py:
2146         * Scripts/modules/webkitlandingscripts.py:
2147
2148 2009-11-26  Adam Barth  <abarth@webkit.org>
2149
2150         Reviewed by Eric Seidel.
2151
2152         [bzt] Kill WebKitLandingScripts
2153         https://bugs.webkit.org/show_bug.cgi?id=31904
2154
2155         Step 3: Kill build_webkit.
2156
2157         * Scripts/modules/buildsteps.py:
2158         * Scripts/modules/landingsequence.py:
2159         * Scripts/modules/webkitlandingscripts.py:
2160
2161 2009-11-26  Adam Barth  <abarth@webkit.org>
2162
2163         Reviewed by Eric Seidel.
2164
2165         [bzt] Kill WebKitLandingScripts
2166         https://bugs.webkit.org/show_bug.cgi?id=31904
2167
2168         Step 2: Kill ensure_builders_are_green.
2169
2170         * Scripts/modules/buildsteps.py:
2171         * Scripts/modules/commands/download.py:
2172         * Scripts/modules/landingsequence.py:
2173         * Scripts/modules/webkitlandingscripts.py:
2174
2175 2009-11-26  Adam Barth  <abarth@webkit.org>
2176
2177         Reviewed by Eric Seidel.
2178
2179         [bzt] Kill WebKitLandingScripts
2180         https://bugs.webkit.org/show_bug.cgi?id=31904
2181
2182         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
2183
2184         * Scripts/bugzilla-tool:
2185         * Scripts/modules/buildsteps.py: Added.
2186         * Scripts/modules/commands/download.py:
2187         * Scripts/modules/landingsequence.py:
2188         * Scripts/modules/webkitlandingscripts.py:
2189
2190 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
2191
2192         Reviewed by Adam Barth.
2193
2194         Remove directory prefixes from linux commands
2195
2196         SCM unittests can cause errors on some systems if we use absolute reference to
2197         the commands, so directory prefixes have been removed.
2198
2199         * Scripts/modules/scm_unittest.py:
2200
2201 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
2202
2203         Reviewed by Kenneth Rohde Christiansen.
2204
2205         Link DumpRenderTree to the Qt Ui Tools
2206         https://bugs.webkit.org/show_bug.cgi?id=31203
2207
2208         Implement QWebPage::createPlugin using the Qt Ui Tools
2209         to be able to create classes like QProgressBar from within
2210         the <object></object> tags This is required for the
2211         new automatic test of Qt Plugins.
2212
2213         * DumpRenderTree/qt/DumpRenderTree.cpp:
2214         (WebCore::WebPage::createPlugin):
2215         * DumpRenderTree/qt/DumpRenderTree.h:
2216         * DumpRenderTree/qt/DumpRenderTree.pro:
2217
2218 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
2219
2220         Reviewed by Eric Seidel.
2221
2222         Update pywebsocket to 0.4.2
2223
2224         Update pywebsocket to 0.4.2
2225         https://bugs.webkit.org/show_bug.cgi?id=31861
2226
2227         * pywebsocket/example/echo_client.py:
2228         * pywebsocket/example/echo_wsh.py:
2229         * pywebsocket/mod_pywebsocket/__init__.py:
2230         * pywebsocket/mod_pywebsocket/dispatch.py:
2231         * pywebsocket/mod_pywebsocket/msgutil.py:
2232         * pywebsocket/mod_pywebsocket/standalone.py:
2233         * pywebsocket/setup.py:
2234         * pywebsocket/test/test_dispatch.py:
2235         * pywebsocket/test/test_msgutil.py:
2236
2237 2009-11-25  Adam Barth  <abarth@webkit.org>
2238
2239         Reviewed by Eric Seidel.
2240
2241         Add unit test for mark-fixed
2242         https://bugs.webkit.org/show_bug.cgi?id=31896
2243
2244         * Scripts/modules/commands/commandtest.py: Added.
2245         * Scripts/modules/commands/queries_unittest.py:
2246         * Scripts/modules/commands/upload_unittest.py: Added.
2247         * Scripts/modules/mock_bugzillatool.py:
2248         * Scripts/run-webkit-unittests:
2249
2250 2009-11-25  Adam Barth  <abarth@webkit.org>
2251
2252         Reviewed by Eric Seidel.
2253
2254         bugzilla-tool should have a mark-fixed command
2255         https://bugs.webkit.org/show_bug.cgi?id=31853
2256
2257         Pretty simple stuff.
2258
2259         * Scripts/modules/commands/upload.py:
2260
2261 2009-11-25  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Adam Barth.
2264
2265         'bugzilla-tool help' should only show common commands like how 'git help' does
2266         https://bugs.webkit.org/show_bug.cgi?id=31772
2267
2268         I also took this opportunity to make 'help' a real Command.
2269         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
2270
2271         * Scripts/bugzilla-tool:
2272          - change should_show_command_help to should_show_in_main_help
2273         * Scripts/modules/commands/download.py:
2274          - Mark commands as being shown in main help or not.
2275          - show_in_main_help = False is not required (default is false),
2276            but it seemed to make the commands more self-documenting.
2277         * Scripts/modules/commands/queries.py: ditto
2278         * Scripts/modules/commands/queues.py: ditto
2279         * Scripts/modules/commands/upload.py: ditto
2280         * Scripts/modules/multicommandtool.py:
2281          - Make Command hold a pointer to tool in self.tool.  Most Command
2282            subclasses do not take advantage of this yet, but it was required
2283            for HelpCommand to be able to reach the tool from _help_epilog().
2284          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
2285          - Move MultiCommandTool._help_epilog to Command._help_epilog
2286          - Move "help" logic into HelpCommand.execute()
2287          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
2288         * Scripts/modules/multicommandtool_unittest.py:
2289          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
2290
2291 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
2292
2293         Reviewed by Dan Bernstein.
2294         
2295         Patch by Mark Rowe.
2296
2297         The buildbots are failing on Windows because when they were upgraded
2298         to 4.0.4, Apple Application Support was not in their path. Add it to
2299         the path to fix the buildots.
2300
2301         * Scripts/webkitdirs.pm:
2302
2303 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2304
2305         Reviewed by David Kilzer.
2306
2307         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
2308         https://bugs.webkit.org/show_bug.cgi?id=31799
2309
2310         * Scripts/run-webkit-tests: Fixed.
2311
2312 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
2313
2314         Reviewed by Eric Seidel.
2315
2316         Change run_command to give back stderr by default
2317         https://bugs.webkit.org/show_bug.cgi?id=31734
2318
2319         Change run_command to give back stderr by default.
2320         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
2321         Change the related unittest call.
2322
2323         * Scripts/modules/scm.py:
2324         * Scripts/modules/scm_unittest.py:
2325
2326 2009-11-25  Eric Seidel  <eric@webkit.org>
2327
2328         Reviewed by Adam Barth.
2329
2330         Centralize required argument parsing in Command
2331         https://bugs.webkit.org/show_bug.cgi?id=31872
2332
2333         * Scripts/modules/commands/download.py: remove custom required arg message.
2334         * Scripts/modules/commands/upload.py: ditto.
2335         * Scripts/modules/multicommandtool.py:
2336          - Add _parse_required_arguments.
2337          - Pass program name off to OptionParser.
2338          - Add name() for access to tool name.
2339          - Add check_arguments_and_execute and make it return a return code.
2340          - Replace a couple uses of + with %.
2341         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
2342
2343 2009-11-25  Eric Seidel  <eric@webkit.org>
2344
2345         Reviewed by Adam Barth.
2346
2347         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
2348         https://bugs.webkit.org/show_bug.cgi?id=31870
2349
2350         * Scripts/modules/commands/queries_unittest.py: Use the new class.
2351         * Scripts/modules/multicommandtool_unittest.py: Ditto.
2352         * Scripts/modules/outputcapture.py: Added.
2353
2354 2009-11-24  Dmitry Titov  <dimich@chromium.org>
2355
2356         Reviewed by Eric Seidel.
2357
2358         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
2359         https://bugs.webkit.org/show_bug.cgi?id=31444
2360
2361         * Scripts/build-webkit:
2362
2363 2009-11-24  Chris Marrin  <cmarrin@apple.com>
2364
2365         Reviewed by Simon Fraser.
2366
2367         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
2368         https://bugs.webkit.org/show_bug.cgi?id=27314
2369         
2370         Now the script allows the directories with these tests to be included on all
2371         platforms but Mac, where they behave the same as always. For all other platforms
2372         the tests need to be excluded using the Skipped files, which is currently done
2373         for all platforms (including win since we're not turned on yet)
2374
2375         * Scripts/webkitdirs.pm:
2376
2377 2009-11-24  Eric Seidel  <eric@webkit.org>
2378
2379         Reviewed by Adam Barth.
2380
2381         queries_unittest.py should test command output
2382         https://bugs.webkit.org/show_bug.cgi?id=31845
2383
2384         * Scripts/modules/commands/queries_unittest.py:
2385          - Capture stdout and stderr and compare with expected strings.
2386
2387 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
2388
2389         No Review.
2390
2391         Fix spelling error ("depenedencies").
2392
2393         * Scripts/build-webkit:
2394
2395 2009-11-24  Mark Rowe  <mrowe@apple.com>
2396
2397         Land the configuration that includes the two debug GTK Linux builders.
2398
2399         * BuildSlaveSupport/build.webkit.org-config/config.json:
2400
2401 2009-11-24  David Kilzer  <ddkilzer@apple.com>
2402
2403         <http://webkit.org/b/31840> bisect-builds broke after r50080
2404
2405         Reviewed by Dan Bernstein.
2406
2407         * Scripts/bisect-builds:
2408         (mountAndRunNightly): Switched back to using backticks to run
2409         the hdiutil command since exec() will terminate the existing
2410         script, which is not what we want.  Store the output of
2411         File::Spec->devnull() in a variable for use in the hdiutil
2412         detach commands.
2413
2414 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2415
2416         Reviewed by Kenneth Rohde Christiansen.
2417
2418         Include "config.h" to meet Coding Style Guidelines
2419         https://bugs.webkit.org/show_bug.cgi?id=31792
2420
2421         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2422         * DumpRenderTree/qt/jsobjects.cpp:
2423         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2424
2425 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2426
2427         Reviewed by Oliver Hunt.
2428
2429         Implement new required function to pass test we used to pass. This
2430         change is required since r51294.
2431
2432         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2433         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2434
2435 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
2436
2437         Reviewed by Kenneth Rohde Christiansen.
2438
2439         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
2440         https://bugs.webkit.org/show_bug.cgi?id=31775
2441
2442         LayoutTestController::dumpBackForwardList() should work with local URLs
2443         as well as with normal URLs (in http tests for instance).
2444         Currently it does not output the latter properly.
2445
2446         Unskip a bunch of passing http/navigation tests.
2447
2448         * DumpRenderTree/qt/DumpRenderTree.cpp:
2449         (WebCore::dumpHistoryItem):
2450
2451 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
2452
2453         Reviewed by Oliver Hunt.
2454
2455         ARIA: support aria-flowto
2456         https://bugs.webkit.org/show_bug.cgi?id=31762
2457
2458         * DumpRenderTree/AccessibilityUIElement.cpp:
2459         (ariaFlowToElementAtIndexCallback):
2460         (AccessibilityUIElement::getJSClass):
2461         * DumpRenderTree/AccessibilityUIElement.h:
2462         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2463         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2465         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2466         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2467         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2468
2469 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
2470
2471         Reviewed by Kenneth Christiansen.
2472
2473         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
2474         https://bugs.webkit.org/show_bug.cgi?id=31638
2475
2476         Unfreeze WorkQueue after each test execution.
2477
2478         * DumpRenderTree/qt/DumpRenderTree.cpp:
2479         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2480
2481 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
2482
2483         Reviewed by Adam Barth.
2484
2485         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
2486         for localhost and 127.0.0.1.
2487         https://bugs.webkit.org/show_bug.cgi?id=31783
2488
2489         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
2490
2491         * DumpRenderTree/qt/DumpRenderTree.cpp:
2492         (WebCore::NetworkAccessManager::NetworkAccessManager):
2493         (WebCore::NetworkAccessManager::sslErrorsEncountered):
2494         (WebCore::WebPage::WebPage):
2495         * DumpRenderTree/qt/DumpRenderTree.h:
2496
2497 2009-11-22  Chris Evans  <cevans@chromium.org>
2498
2499         Reviewed by Adam Barth.
2500
2501         Disable access to file:/// directory listings
2502         https://bugs.webkit.org/show_bug.cgi?id=31329
2503
2504         Implemented setAllowUniversalAccessFromFileURLs to support testing of
2505         file URL security.
2506
2507         * DumpRenderTree/LayoutTestController.cpp:
2508         (setAllowUniversalAccessFromFileURLsCallback):
2509         (LayoutTestController::staticFunctions):
2510         * DumpRenderTree/LayoutTestController.h:
2511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2512         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2513         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2514         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2515         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2516         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2517         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2518         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2519
2520 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
2521
2522         Reviewed by Kenneth Rohde Christiansen.
2523
2524         [Qt] Fix the timeout of fast/frames/frame-navigation.html
2525         https://bugs.webkit.org/show_bug.cgi?id=31638
2526
2527         The test is timeouting, because it uses the WorkQueue to load a document in one
2528         of the child frames and once the loading is finished, the DRT does not dump the
2529         tree. This is because it waits for the QWebFrame::loadFinished() signal from
2530         the main frame, while it should connect to QWebPage::loadFinished().
2531
2532         * DumpRenderTree/qt/DumpRenderTree.cpp:
2533         (WebCore::DumpRenderTree::DumpRenderTree):
2534
2535 2009-11-21  Eric Seidel  <eric@webkit.org>
2536
2537         Reviewed by Adam Barth.
2538
2539         bugzilla-tool --help spews way too much text
2540         https://bugs.webkit.org/show_bug.cgi?id=31771
2541
2542         * Scripts/bugzilla-tool:
2543          - Remove self.cached_scm initialization hack.
2544         * Scripts/modules/buildbot.py:
2545          - Make default_host accessible to callers.
2546         * Scripts/modules/commands/download.py:
2547          - Phrase help for all commands consistently and remove spurious help text punctuation.
2548         * Scripts/modules/commands/queries.py: Ditto.
2549         * Scripts/modules/commands/queues.py: Ditto.
2550         * Scripts/modules/commands/upload.py: Ditto.
2551         * Scripts/modules/multicommandtool.py:
2552          - Add HelpPrintingOptionParser.format_epilog to replace
2553            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
2554            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
2555          - Make --help only show a list of commands like "svn help" and "git help" do --
2556            previously --help was listing all commands and options.
2557          - Sort list of commands alphabetically.
2558
2559 2009-11-21  Eric Seidel  <eric@webkit.org>
2560
2561         No review.  Fixing a typo from the previous patch for bug 31767.
2562
2563         AbstractQueue.run_bugzilla_tool throws an exception
2564         https://bugs.webkit.org/show_bug.cgi?id=31769
2565
2566         * Scripts/modules/commands/queues.py:
2567
2568 2009-11-21  Eric Seidel  <eric@webkit.org>
2569
2570         Reviewed by Adam Barth.
2571
2572         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
2573         https://bugs.webkit.org/show_bug.cgi?id=31767
2574
2575         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
2576         Since we don't have a good way to test BugzillaTool pieces, I've
2577         left out a test for now.
2578
2579         * Scripts/bugzilla-tool:
2580          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
2581         * Scripts/modules/commands/queues.py:
2582          - Use tool.path() instead of __file__.
2583         * Scripts/modules/multicommandtool.py:
2584          - Add a new path() method to MultiComandTool.
2585         * Scripts/modules/multicommandtool_unittest.py:
2586          - Provide a path() method.  Little point in testing this mock implementation.
2587
2588 2009-11-21  Adam Barth  <abarth@webkit.org>
2589
2590         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
2591         WebKitTools.
2592
2593         * Scripts/modules/commands/download.py:
2594
2595 2009-11-21  Adam Barth  <abarth@webkit.org>
2596
2597         Reviewed by Eric Seidel.
2598
2599         Convert check-style to use LandingSequence
2600         https://bugs.webkit.org/show_bug.cgi?id=31763
2601
2602         Instead of manipulating the working copy by hand, we should use the
2603         LandingSequence in CheckStyle.  This will make this code eaiser to
2604         test.
2605
2606         * Scripts/modules/commands/download.py:
2607
2608 2009-11-20  Adam Barth  <abarth@webkit.org>
2609
2610         Reviewed by Eric Seidel.
2611
2612         Unit test query commands
2613         https://bugs.webkit.org/show_bug.cgi?id=31755
2614
2615         These tests are pretty rough, but hopefully they'll grow.
2616
2617         * Scripts/modules/commands/queries_unittest.py: Added.
2618         * Scripts/modules/mock_bugzillatool.py: Added.
2619         * Scripts/run-webkit-unittests:
2620
2621 2009-11-20  Eric Seidel  <eric@webkit.org>
2622
2623         Reviewed by Adam Barth.
2624
2625         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
2626         https://bugs.webkit.org/show_bug.cgi?id=31758
2627
2628         * Scripts/modules/multicommandtool.py:
2629          - Allow passing of explicit commands to MultiCommandTool.__init__
2630         * Scripts/modules/multicommandtool_unittest.py:
2631          - Use new Command.name naming system.
2632          - Test Command auto-discovery.
2633         * Scripts/modules/workqueue.py:
2634          - bug_id no longer exists, use patch['bug_id'] instead.
2635         * Scripts/modules/workqueue_unittest.py:
2636          - WorkQueues require names now.
2637          - should_proceed_with_work_item must return a patch object.
2638
2639 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
2640
2641         Reviewed by Beth Dakin.
2642
2643         WAI-ARIA: add support for aria-owns
2644         https://bugs.webkit.org/show_bug.cgi?id=31702
2645
2646         * DumpRenderTree/AccessibilityUIElement.cpp:
2647         (ariaOwnsElementAtIndexCallback):
2648         (AccessibilityUIElement::getJSClass):
2649         * DumpRenderTree/AccessibilityUIElement.h:
2650         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2651         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2652         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2653         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2654         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2655         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2656
2657 2009-11-20  Eric Seidel  <eric@webkit.org>
2658
2659         Reviewed by Adam Barth.
2660
2661         Fix exception thrown when running the commit-queue.
2662
2663         * Scripts/modules/statusbot.py: patch is optional.
2664         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
2665
2666 2009-11-20  Eric Seidel  <eric@webkit.org>
2667
2668         Reviewed by Adam Barth.
2669
2670         Teach the StatusBot how to support more than just the commit-queue
2671         https://bugs.webkit.org/show_bug.cgi?id=31754
2672
2673         * Scripts/modules/workqueue.py: Another typo.
2674
2675 2009-11-20  Eric Seidel  <eric@webkit.org>
2676
2677         Reviewed by Adam Barth.
2678
2679         Teach the StatusBot how to support more than just the commit-queue
2680         https://bugs.webkit.org/show_bug.cgi?id=31754
2681
2682         * Scripts/modules/commands/queues.py: Fix silly typo.
2683
2684 2009-11-20  Eric Seidel  <eric@webkit.org>
2685
2686         Reviewed by Adam Barth.
2687
2688         Teach the StatusBot how to support more than just the commit-queue
2689         https://bugs.webkit.org/show_bug.cgi?id=31754
2690
2691         * CommitQueueStatus/index.yaml:
2692          - Add indices required for the new queries.
2693         * CommitQueueStatus/queue_status.py:
2694          - Add a patch-status page and move update_status to update-status.
2695          - Only display "commit-queue" status records for the commit-queue.
2696          - Add support for a queue_name property on status records.
2697          - Fix _int_from_request to actually work.
2698         * CommitQueueStatus/update_status.html:
2699          - Add support for a queue_name on status records.
2700          - Remove unused list of bug ids.
2701          * Scripts/modules/commands/queues.py
2702           - Make the queues pass the patch instead of the bug_id to StatusBot.
2703         * Scripts/modules/statusbot.py:
2704          - Support passing the queue_name to the status updates.
2705          - Support fetching patch status with patch_status().
2706         * Scripts/modules/workqueue.py:
2707          - Pass the patch to the StatusBot instead of the bug_id.
2708          - Let WorkQueues have a name.
2709
2710 2009-11-20  Adam Barth  <abarth@webkit.org>
2711
2712         Reviewed by Eric Seidel.
2713
2714         Move bugzilla-tool commands into their own file
2715         https://bugs.webkit.org/show_bug.cgi?id=31752
2716
2717         This will let us write unit tests.
2718
2719         * Scripts/bugzilla-tool:
2720         * Scripts/modules/commands/__init__.py: Added.
2721         * Scripts/modules/commands/download.py: Added.
2722         * Scripts/modules/commands/queries.py: Added.
2723         * Scripts/modules/commands/queues.py: Added.
2724         * Scripts/modules/commands/upload.py: Added.
2725         * Scripts/modules/grammar.py: Added.
2726
2727 2009-11-20  Adam Barth  <abarth@webkit.org>
2728
2729         Reviewed by Eric Seidel.
2730
2731         BuildQueue should check if the tree is currently buildable
2732         https://bugs.webkit.org/show_bug.cgi?id=31744
2733
2734         * Scripts/bugzilla-tool:
2735         * Scripts/modules/landingsequence.py:
2736         * Scripts/modules/webkitlandingscripts.py:
2737
2738 2009-11-20  Adam Barth  <abarth@webkit.org>
2739
2740         Reviewed by Eric Seidel.
2741
2742         Move prepare_clean_working_directory into the LandingSequence
2743         https://bugs.webkit.org/show_bug.cgi?id=31743
2744
2745         * Scripts/bugzilla-tool:
2746         * Scripts/modules/landingsequence.py:
2747
2748 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
2749
2750         Reviewed by Kenneth Rohde Christiansen.
2751
2752         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
2753         https://bugs.webkit.org/show_bug.cgi?id=30460
2754
2755         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
2756
2757         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2758         (pluginInvoke):
2759
2760 2009-11-20  Adam Barth  <abarth@webkit.org>
2761
2762         Reviewed by Eric Seidel.
2763
2764         Pass the port information to the child process
2765         https://bugs.webkit.org/show_bug.cgi?id=31736
2766
2767         We need to do this so the child process knows what to build!
2768
2769         * Scripts/bugzilla-tool:
2770         * Scripts/modules/landingsequence.py:
2771         * Scripts/modules/webkitport.py:
2772         * Scripts/modules/webkitport_unittest.py:
2773
2774 2009-11-20  Adam Barth  <abarth@webkit.org>
2775
2776         Reviewed by Eric Seidel.
2777
2778         Support Qt port in build-queue
2779         https://bugs.webkit.org/show_bug.cgi?id=31733
2780
2781         * Scripts/bugzilla-tool:
2782
2783 2009-11-20  Adam Barth  <abarth@webkit.org>
2784
2785         Reviewed by Eric Seidel.
2786
2787         Implement a build-queue
2788         https://bugs.webkit.org/show_bug.cgi?id=31725
2789
2790         Currently this just builds the first 10 patches in the review queue.
2791         We'll want to do something smarter soon.
2792
2793         * Scripts/bugzilla-tool:
2794
2795 2009-11-20  Adam Barth  <abarth@webkit.org>
2796
2797         Reviewed by Eric Seidel.
2798
2799         Make commit-queue and style-queue show up in help
2800         https://bugs.webkit.org/show_bug.cgi?id=31724
2801
2802         We need to store their names on their class to make these commands
2803         properly register themselves with MultiCommandTool.
2804
2805         * Scripts/bugzilla-tool:
2806
2807 2009-11-20  Adam Barth  <abarth@webkit.org>
2808
2809         Reviewed by Eric Seidel.
2810
2811         Implement bugzilla-tool build-attachment
2812         https://bugs.webkit.org/show_bug.cgi?id=31722
2813
2814         This command builds an attachment from bugzilla.  It leaves the built
2815         patch in the working copy.
2816
2817         * Scripts/bugzilla-tool:
2818         * Scripts/modules/landingsequence.py:
2819         * Scripts/modules/webkitlandingscripts.py:
2820
2821 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
2822
2823         Reviewed by Xan Lopez.
2824
2825         [GTK] DRT release event does not create the state correctly
2826         https://bugs.webkit.org/show_bug.cgi?id=31717
2827
2828         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2829
2830 2009-11-20  Eric Seidel  <eric@webkit.org>
2831
2832         Reviewed by Adam Barth.
2833
2834         MultiCommandTool should find Command objects automatically instead of with a manual list
2835         https://bugs.webkit.org/show_bug.cgi?id=31710
2836
2837         * Scripts/bugzilla-tool:
2838         * Scripts/modules/multicommandtool.py:
2839          - Use some wild python-fu to crawl all the known subclasses of Command.
2840
2841 2009-11-20  Adam Barth  <abarth@webkit.org>
2842
2843         Unreviewed "build" fix.  Added missing import.
2844
2845         * Scripts/bugzilla-tool:
2846
2847 2009-11-20  Adam Barth  <abarth@webkit.org>
2848
2849         Unreviewed "build" fix.  I failed to update LandingSequence.test
2850         properly.
2851
2852         * Scripts/modules/landingsequence.py:
2853
2854 2009-11-20  Adam Barth  <abarth@webkit.org>
2855
2856         Reviewed by Eric Seidel.
2857
2858         Create LandingSequence as the all-sing, all-dance landing class
2859         https://bugs.webkit.org/show_bug.cgi?id=31709
2860
2861         Client can inherit from this class to carefully control exactly which
2862         steps they wish to have happen in the landing sequence.
2863
2864         * Scripts/bugzilla-tool:
2865         * Scripts/modules/landingsequence.py: Added.
2866         * Scripts/modules/webkitlandingscripts.py: Added.
2867
2868 2009-11-19  Adam Barth  <abarth@webkit.org>
2869
2870         Reviewed by Eric Seidel.
2871
2872         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
2873         https://bugs.webkit.org/show_bug.cgi?id=31707
2874
2875         This is to help when we implement build-attachment.
2876
2877         * Scripts/bugzilla-tool:
2878
2879 2009-11-19  Adam Barth  <abarth@webkit.org>
2880
2881         Reviewed by Eric Seidel.
2882
2883         Support Qt port in bugzilla-tool
2884         https://bugs.webkit.org/show_bug.cgi?id=31701
2885
2886         Now we support building with Qt!
2887
2888         * Scripts/bugzilla-tool:
2889         * Scripts/modules/webkitport.py: Added.
2890         * Scripts/modules/webkitport_unittest.py: Added.
2891         * Scripts/run-webkit-unittests:
2892
2893 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
2894
2895         Reviewed by Adam Barth.
2896
2897         Remove inserting stderr into patch in bugzilla-tool
2898         https://bugs.webkit.org/show_bug.cgi?id=29914
2899
2900         Modify SCM python module's run_command function to avoid return of stderr
2901         by default, so stderr won't be inserted into the patches.
2902         Modify the related unit test.
2903
2904         * Scripts/modules/scm.py:
2905         * Scripts/modules/scm_unittest.py:
2906
2907 2009-11-19  Eric Seidel  <eric@webkit.org>
2908
2909         Reviewed by Adam Barth.
2910
2911         bugzilla-tool needs per-command help
2912         https://bugs.webkit.org/show_bug.cgi?id=31697
2913
2914         Added support for "bugzilla-tool help command-name"
2915         and a unit test to make sure it works.
2916
2917         * Scripts/modules/multicommandtool.py:
2918         * Scripts/modules/multicommandtool_unittest.py:
2919
2920 2009-11-19  Eric Seidel  <eric@webkit.org>
2921
2922         Reviewed by Adam Barth.
2923
2924         Move MultiCommandTool and Command into a separate file and add some basic unit tests
2925         https://bugs.webkit.org/show_bug.cgi?id=31695
2926
2927         * Scripts/bugzilla-tool:
2928         * Scripts/modules/multicommandtool.py: Added.
2929         * Scripts/modules/multicommandtool_unittest.py: Added.
2930         * Scripts/run-webkit-unittests:
2931
2932 2009-11-19  Eric Seidel  <eric@webkit.org>
2933
2934         No review, just adding a FIXME.
2935
2936         Split out command parsing and help printing from BugzillaTool
2937         https://bugs.webkit.org/show_bug.cgi?id=31688
2938
2939         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
2940
2941 2009-11-19  Eric Seidel  <eric@webkit.org>
2942
2943         Reviewed by Adam Barth.
2944
2945         Split out command parsing and help printing from BugzillaTool
2946         https://bugs.webkit.org/show_bug.cgi?id=31688
2947
2948         * Scripts/bugzilla-tool:
2949          - Add new MultiCommandTool class to contain option parsing and help printing logic.
2950          - Rename private methods to use _ pattern.
2951          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
2952          - 
2953
2954 2009-11-19  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         Re-factor help printing to use modern python idioms
2959         https://bugs.webkit.org/show_bug.cgi?id=31685
2960
2961         * Scripts/bugzilla-tool:
2962
2963 2009-11-19  Eric Seidel  <eric@webkit.org>
2964
2965         Reviewed by Darin Adler.
2966
2967         commit-queue empty queue logs twice
2968         https://bugs.webkit.org/show_bug.cgi?id=31679
2969
2970         * Scripts/bugzilla-tool:
2971
2972 2009-11-19  Eric Seidel  <eric@webkit.org>
2973
2974         Reviewed by Darin Adler.
2975
2976         bugzilla-tool's reviewer/committer rejection message should be clearer
2977         https://bugs.webkit.org/show_bug.cgi?id=31126
2978
2979         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
2980
2981         * Scripts/modules/bugzilla.py:
2982
2983 2009-11-19  Eric Z. Ayers  <zundel@google.com>
2984
2985         Reviewed by Pavel Feldman.
2986
2987         Forces a WM_PAINT event on calling layoutTestController.display()
2988         in order to enable the timeline-paint.html test on Windows.
2989         ::UpdateWindow() does not force an event becaue the window is 
2990         not visible.
2991
2992         https://bugs.webkit.org/show_bug.cgi?id=31402
2993
2994         * DumpRenderTree/win/DumpRenderTree.cpp:
2995         (displayWebView):
2996
2997 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
2998
2999         No review needed.
3000
3001         Added myself to committers list.
3002
3003         * Scripts/modules/committers.py:
3004
3005 2009-11-19  Adam Barth  <abarth@webkit.org>
3006
3007         Reviewed by Eric Seidel.
3008
3009         Bugzilla-tool command classes should match command names
3010         https://bugs.webkit.org/show_bug.cgi?id=31666
3011
3012         I renamed all the commands except CommitMessageForCurrentDiff because
3013         the new name would conflict with an existing class.
3014
3015         * Scripts/bugzilla-tool:
3016
3017 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
3018
3019         Reviewed by Gustavo Noronha Silva.
3020
3021         Web Inspector: Implement "show inspector" in WebKit GTK
3022         API and enable console tests.
3023
3024         https://bugs.webkit.org/show_bug.cgi?id=31669
3025
3026         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3027         (LayoutTestController::showWebInspector):
3028
3029 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3030
3031         Reviewed by Simon Hausmann.
3032
3033         Minor refactoring + more documentation.
3034
3035         * DumpRenderTree/qt/DumpRenderTree.cpp:
3036         (WebCore::clearHistory):
3037         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3038
3039 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
3040
3041         Reviewed by Eric Seidel.
3042
3043         Ignore websocket tests when --no-http is specified.
3044         https://bugs.webkit.org/show_bug.cgi?id=31662
3045
3046         * Scripts/run-webkit-tests:
3047
3048 2009-11-18  Adam Barth  <abarth@webkit.org>
3049
3050         Reviewed by Eric Seidel.
3051
3052         Normalize ' and " in bugzilla-tool
3053         https://bugs.webkit.org/show_bug.cgi?id=31655
3054
3055         We decided " is better than ' and we should be consistent.
3056
3057         * Scripts/bugzilla-tool:
3058
3059 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3060
3061         Reviewed by Kenneth Rohde Christiansen.
3062
3063         [Qt] Remove support for Qt v4.3 or older versions
3064         https://bugs.webkit.org/show_bug.cgi?id=29469
3065
3066         * DumpRenderTree/qt/DumpRenderTree.pro:
3067         * DumpRenderTree/qt/ImageDiff.pro:
3068
3069 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
3070
3071         Reviewed by Eric Seidel.
3072
3073         GitTest.test_create_binary_patch fails if /tmp is symlink
3074         https://bugs.webkit.org/show_bug.cgi?id=31536
3075
3076         * Scripts/modules/scm_unittest.py:
3077
3078 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
3079
3080         Reviewed by Darin Adler.
3081
3082         Configuration for Chromium Build Slaves.
3083
3084         https://bugs.webkit.org/show_bug.cgi?id=31442
3085
3086         * BuildSlaveSupport/build.webkit.org-config/config.json:
3087         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3088
3089 2009-11-18  Eric Seidel  <eric@webkit.org>
3090
3091         Reviewed by Darin Adler.
3092
3093         workqueue.py results in totally broken commit-queue UI
3094         https://bugs.webkit.org/show_bug.cgi?id=31645
3095
3096         * Scripts/bugzilla-tool:
3097          - Remove unneeded use of PatchCollection.
3098          - Grab a new copy of the cq'd patches every run of the queue.
3099
3100 2009-11-18  Sam Weinig  <sam@webkit.org>
3101
3102         Reviewed by Anders Carlsson.
3103
3104         Make the Mac Geolocation API async.
3105
3106         Update DRT to use the new async Mac Geolocation API.
3107
3108         * DumpRenderTree/mac/UIDelegate.mm:
3109         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3110
3111 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3112
3113         Reviewed by Kenneth Rohde Christiansen.
3114
3115         Add and option to toggle HTML5 datalist support to build-webkit
3116         https://bugs.webkit.org/show_bug.cgi?id=31599
3117
3118         * Scripts/build-webkit:
3119
3120 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
3121
3122         Reviewed by Kevin Ollivier.
3123
3124         Enable wx plugin support using the Windows implementation as a base.
3125         
3126         https://bugs.webkit.org/show_bug.cgi?id=31636
3127
3128         * wx/build/settings.py:
3129
3130 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3131
3132         Reviewed by Simon Hausmann.
3133
3134         Change the initialization order so that the controllers
3135         will be created before exporting them to the JS DOM window.
3136
3137         * DumpRenderTree/qt/DumpRenderTree.cpp:
3138         (WebCore::DumpRenderTree::DumpRenderTree):
3139
3140 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3141
3142         Reviewed by Simon Hausmann.
3143
3144         Fix a code copy and paste error. m_page should be page.
3145
3146         * DumpRenderTree/qt/DumpRenderTree.cpp:
3147         (WebCore::DumpRenderTree::createWindow):
3148
3149 2009-11-17  Mark Rowe  <mrowe@apple.com>
3150
3151         Reviewed by Alexey Proskuryakov.
3152
3153         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
3154
3155         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
3156         This prevents symlinks from confusing the descendant check.
3157
3158 2009-11-17  Mark Rowe  <mrowe@apple.com>
3159
3160         Reviewed by Alexey Proskuryakov.
3161
3162         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
3163
3164         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
3165         server to be up rather than having run-webkit-tests abort immediately.
3166
3167         * Scripts/run-webkit-tests:
3168
3169 2009-11-17  Eric Seidel  <eric@webkit.org>
3170
3171         Reviewed by Darin Adler.
3172
3173         commit-queue is failing to set reviewer in ChangeLogs
3174         https://bugs.webkit.org/show_bug.cgi?id=31592
3175
3176         * Scripts/bugzilla-tool: Clarify the "applying" log message.
3177         * Scripts/modules/bugzilla.py:
3178          - Add a new _validate_committer_and_reviewer function as a
3179            temporary solution until we can make a real Attachment object
3180            which knows how to fill in its committer/reviewer fields automatically.
3181
3182 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3183
3184         Unreviewed buildbot fix.
3185
3186         Revert part of earlier patch and add comment, as it
3187         was causing timeouts on the buildbot.
3188
3189         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3190         (LayoutTestController::notifyDone):
3191
3192 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3193
3194         Reviewed by Oliver Hunt.
3195
3196         Make the timeout 15 sec as for the other DRT's and make
3197         it print out the same output when a test timeout.
3198
3199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3200         (LayoutTestController::waitUntilDone):
3201         (LayoutTestController::notifyDone):
3202         (LayoutTestController::timerEvent):
3203
3204 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
3205
3206         Reviewed by Timothy Hatcher.
3207
3208         Fixed typos in comments.
3209
3210         * Scripts/modules/committers.py:
3211
3212 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
3213
3214         Reviewed by Timothy Hatcher.
3215
3216         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
3217         - Updated DRT to show/close inspector for all tests under /inspector
3218         - Introduced LayoutTestController::setTimelineProfilingEnabled and
3219           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
3220         - Removed reload on each inspector test
3221         - Renamed fast/inspector to fast/inspector-support in order not to trigger
3222         inspector for those.
3223         - Reimplemented timeline tests in order to get rid of reload there.
3224         - Moved tests that don't require harness into the fast group.
3225
3226         https://bugs.webkit.org/show_bug.cgi?id=31472
3227
3228         * DumpRenderTree/LayoutTestController.cpp:
3229         (setTimelineProfilingEnabledCallback):
3230         (closeWebInspectorCallback):
3231         (LayoutTestController::staticFunctions):
3232         * DumpRenderTree/LayoutTestController.h:
3233         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3234         (shouldOpenWebInspector):
3235         (runTest):
3236         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3237         (LayoutTestController::setTimelineProfilingEnabled):
3238         * DumpRenderTree/mac/DumpRenderTree.mm:
3239         (shouldOpenWebInspector):
3240         (runTest):
3241         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3242         (LayoutTestController::setTimelineProfilingEnabled):
3243         * DumpRenderTree/win/DumpRenderTree.cpp:
3244         (shouldOpenWebInspector):
3245         (runTest):
3246         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3247         (LayoutTestController::setTimelineProfilingEnabled):
3248
3249 2009-11-17  Oliver Hunt  <oliver@apple.com>
3250
3251         Reviewed by Maciej Stachowiak.
3252
3253         Incorrect use of JavaScriptCore API in DumpRenderTree
3254         https://bugs.webkit.org/show_bug.cgi?id=31577
3255
3256         Return undefined rather than a literal null.
3257
3258         * DumpRenderTree/AccessibilityUIElement.cpp:
3259         (setSelectedTextRangeCallback):
3260         (incrementCallback):
3261         (decrementCallback):
3262         (showMenuCallback):
3263
3264 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
3265
3266         Reviewed by Beth Dakin.
3267
3268         AX: aria-labelledby duplicates some of its WAI-ARIA label
3269         https://bugs.webkit.org/show_bug.cgi?id=31565
3270
3271         * DumpRenderTree/AccessibilityUIElement.cpp:
3272         (titleUIElementCallback):
3273         (getIsValidCallback):
3274         (AccessibilityUIElement::getJSClass):
3275
3276 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3277
3278         Reviewed by Simon Hausmann.
3279
3280         r50942 broke output from created windows. Make the
3281         m_enableTextOutput a member of the DRT and not the
3282         WebPage.
3283
3284         * DumpRenderTree/qt/DumpRenderTree.cpp:
3285         (WebCore::WebPage::WebPage):
3286         (WebCore::WebPage::javaScriptAlert):
3287         (WebCore::WebPage::javaScriptConsoleMessage):
3288         (WebCore::WebPage::javaScriptConfirm):
3289         (WebCore::WebPage::javaScriptPrompt):
3290         (WebCore::WebPage::acceptNavigationRequest):
3291         (WebCore::DumpRenderTree::DumpRenderTree):
3292         (WebCore::DumpRenderTree::open):
3293         (WebCore::DumpRenderTree::createWindow):
3294         * DumpRenderTree/qt/DumpRenderTree.h:
3295         (WebCore::DumpRenderTree::setTextOutputEnabled):
3296         (WebCore::DumpRenderTree::isTextOutputEnabled):
3297         (WebCore::WebPage::shouldInterruptJavaScript):
3298         (WebCore::WebPage::isTextOutputEnabled):
3299         (WebCore::WebPage::setViewGeometry):
3300
3301 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3302
3303         Reviewed by Gustavo Noronha Silva.
3304
3305         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
3306         as the implementation is being used by at least Qt and Gtk+.
3307
3308         Update buildsystems as well.
3309
3310         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3311         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3312         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
3313         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3314         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3315         * GNUmakefile.am:
3316
3317 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
3318
3319         Reviewed by Alexey Proskuryakov.
3320
3321         Disable wss until all platforms support pyOpenSSL
3322
3323         https://bugs.webkit.org/show_bug.cgi?id=31479
3324
3325         * Scripts/run-webkit-tests:
3326
3327 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
3328
3329         Reviewed by Kenneth Christiansen.
3330
3331         [Qt] Implement load error pages support for Qt's DRT.
3332         https://bugs.webkit.org/show_bug.cgi?id=31509
3333
3334         For now, it will not be a default feature, and layout tests
3335         that want to make use of this have to explicitily call
3336         'handleErrorPages();' for the test source.
3337
3338         Any of the other DumpRenderTree's (mac, win and gtk)
3339         support handling error pages. Qt's will be the first.
3340
3341         * DumpRenderTree/qt/DumpRenderTree.cpp:
3342         (WebCore::WebPage::supportsExtension):
3343         (WebCore::WebPage::extension):
3344         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3345         (LayoutTestController::reset):
3346         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3347         (LayoutTestController::shouldHandleErrorPages):
3348         (LayoutTestController::handleErrorPages):
3349
3350 2009-11-16  Eric Seidel  <eric@webkit.org>
3351
3352         Reviewed by Adam Barth.
3353
3354         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
3355         https://bugs.webkit.org/show_bug.cgi?id=31549
3356
3357         Renamed --commit-queue to --non-interactive in most places
3358         and remove the code in land-patches which is no longer needed.
3359
3360         * Scripts/bugzilla-tool:
3361
3362 2009-11-16  Eric Seidel  <eric@webkit.org>
3363
3364         Reviewed by Adam Barth.
3365
3366         The commit-queue should use land-attachment
3367         https://bugs.webkit.org/show_bug.cgi?id=31548
3368
3369         * Scripts/bugzilla-tool:
3370
3371 2009-11-16  Adam Barth  <abarth@webkit.org>
3372
3373         Reviewed by Eric Seidel.
3374
3375         Convert CommitQueue over to PatchCollection
3376         https://bugs.webkit.org/show_bug.cgi?id=31547
3377
3378         Also fixes a bug in workqueue and adds a test!
3379
3380         * Scripts/bugzilla-tool:
3381         * Scripts/modules/workqueue.py:
3382         * Scripts/modules/workqueue_unittest.py:
3383
3384 2009-11-16  Adam Barth  <abarth@webkit.org>
3385
3386         Reviewed by Eric Seidel.
3387
3388         Move StyleQueue over to using PatchCollection
3389         https://bugs.webkit.org/show_bug.cgi?id=31544
3390
3391         That's what the class it's for.
3392
3393         * Scripts/bugzilla-tool:
3394         * Scripts/modules/patchcollection.py:
3395         * Scripts/modules/patchcollection_unittest.py:
3396
3397 2009-11-16  Eric Seidel  <eric@webkit.org>
3398
3399         Reviewed by Adam Barth.
3400
3401         bugzilla-tool needs a land-attachment command
3402         https://bugs.webkit.org/show_bug.cgi?id=31546
3403
3404         * Scripts/bugzilla-tool:
3405          - Move all the logic into AbstractLandingCommand and
3406            add a new LandAttachment command subclass.
3407          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
3408
3409 2009-11-16  Eric Seidel  <eric@webkit.org>
3410
3411         Reviewed by Adam Barth.
3412
3413         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
3414         https://bugs.webkit.org/show_bug.cgi?id=31543
3415
3416         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
3417
3418         * Scripts/bugzilla-tool:
3419
3420 2009-11-16  Eric Seidel  <eric@webkit.org>
3421
3422         Reviewed by Adam Barth.
3423
3424         Disable the style queue from posting to the commit queue status page.
3425
3426         * Scripts/bugzilla-tool:
3427
3428 2009-11-16  Adam Barth  <abarth@webkit.org>
3429
3430         Reviewed by Eric Seidel.
3431
3432         Implement PatchCollection
3433         https://bugs.webkit.org/show_bug.cgi?id=31541
3434
3435         This class holds a set of patches and lets clients iterate through
3436         them.  Optionally, clients can install a filter.
3437
3438         * Scripts/modules/patchcollection.py: Added.
3439         * Scripts/modules/patchcollection_unittest.py: Added.
3440         * Scripts/run-webkit-unittests:
3441
3442 2009-11-16  Eric Seidel  <eric@webkit.org>
3443
3444         Reviewed by Adam Barth.
3445
3446         bugzilla-tool land-patches will close bugs with patches r=?
3447         https://bugs.webkit.org/show_bug.cgi?id=28230
3448
3449         The commit-queue shouldn't close patches with outstanding reviews on them,
3450         even if many reviewers seem to be against multi-patch bugs.
3451
3452         * Scripts/bugzilla-tool:
3453
3454 2009-11-16  Eric Seidel  <eric@webkit.org>
3455
3456         Reviewed by Adam Barth.
3457
3458         bugzilla-tool check-style should work with attachment ids instead of bug ids
3459         https://bugs.webkit.org/show_bug.cgi?id=31540
3460
3461         * Scripts/bugzilla-tool:
3462
3463 2009-11-16  Eric Seidel  <eric@webkit.org>
3464
3465         Reviewed by Adam Barth.
3466
3467         WorkQueue is the only place that should know about special exit codes
3468         https://bugs.webkit.org/show_bug.cgi?id=31534
3469
3470         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
3471         and add tests for handling exit codes.
3472         I also cleaned up workqueue_unittest.py more.
3473
3474         * Scripts/bugzilla-tool:
3475         * Scripts/modules/workqueue.py:
3476         * Scripts/modules/workqueue_unittest.py:
3477
3478 2009-11-16  Eric Seidel  <eric@webkit.org>
3479
3480         Reviewed by Adam Barth.
3481
3482         Re-factor workqueue_unittest to allow for more than one test.
3483         https://bugs.webkit.org/show_bug.cgi?id=31535
3484
3485         * Scripts/modules/workqueue_unittest.py:
3486
3487 2009-11-16  Eric Seidel  <eric@webkit.org>
3488
3489         Reviewed by Adam Barth.
3490
3491         land-patches needs to be re-factored into smaller chunks
3492         https://bugs.webkit.org/show_bug.cgi?id=31532
3493
3494         * Scripts/bugzilla-tool: fix a couple obvious typos.
3495
3496 2009-11-16  Eric Seidel  <eric@webkit.org>
3497
3498         Reviewed by Adam Barth.
3499
3500         land-patches needs to be re-factored into smaller chunks
3501         https://bugs.webkit.org/show_bug.cgi?id=31532
3502
3503         The next patch will move these methods into WebKitLandingScripts.
3504
3505         * Scripts/bugzilla-tool:
3506          - Split out _land_patch and _close_bug_if_no_active_patches.
3507
3508 2009-11-16  Adam Barth  <abarth@webkit.org>
3509
3510         Reviewed by Eric Seidel.
3511
3512         Fix silly copy-and-paste code.  I am a terrible coder.
3513
3514         * Scripts/modules/bugzilla.py:
3515
3516 2009-11-16  Adam Barth  <abarth@webkit.org>
3517
3518         Reviewed by Eric Seidel.
3519
3520         Implement a StyleQueue
3521         https://bugs.webkit.org/show_bug.cgi?id=31537
3522
3523         The first iteration of the style queue only produces output locally.
3524         There is also a limit of 10 patches because it's not that useful to
3525         iterate through the entire review queue at this point.  We can remove
3526         the limit later.
3527
3528         * Scripts/bugzilla-tool:
3529         * Scripts/modules/bugzilla.py:
3530
3531 2009-11-16  Adam Barth  <abarth@webkit.org>
3532
3533         Reviewed by Eric Seidel.
3534
3535         Unit test WorkQueue
3536         https://bugs.webkit.org/show_bug.cgi?id=31531
3537
3538         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
3539
3540         * Scripts/bugzilla-tool:
3541         * Scripts/modules/statusbot.py:
3542         * Scripts/modules/workqueue.py:
3543         * Scripts/modules/workqueue_unittest.py: Added.
3544         * Scripts/run-webkit-unittests:
3545
3546 2009-11-16  Eric Seidel  <eric@webkit.org>
3547
3548         Reviewed by Adam Barth.
3549
3550         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
3551         https://bugs.webkit.org/show_bug.cgi?id=31530
3552
3553         * Scripts/bugzilla-tool:
3554
3555 2009-11-16  Eric Seidel  <eric@webkit.org>
3556
3557         Reviewed by Adam Barth.
3558
3559         bugzilla-tool needs apply-attachment
3560         https://bugs.webkit.org/show_bug.cgi?id=31528
3561
3562         * Scripts/bugzilla-tool:
3563          - Add ApplyAttachment command.
3564          - Abstract applying code into WebKitApplyingScripts.
3565          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
3566         * Scripts/modules/bugzilla.py:
3567          - Add fetch_attachment and bug_id_for_attachment_id.
3568         * Scripts/modules/bugzilla_unittest.py:
3569          - Add test for new parsing.
3570          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
3571
3572 2009-11-16  Eric Seidel  <eric@webkit.org>
3573
3574         Reviewed by Adam Barth.
3575
3576         Document check-style's use of force_clean.
3577
3578         * Scripts/bugzilla-tool:
3579         * Scripts/modules/scm.py:
3580
3581 2009-11-16  Adam Barth  <abarth@webkit.org>
3582
3583         Reviewed by Eric Seidel.
3584
3585         Move WorkQueue to its own file
3586         https://bugs.webkit.org/show_bug.cgi?id=31529
3587
3588         WorkQueue and WorkQueueDelegate are separate concerns from
3589         bugzilla-tool.  Also added a missing include to logging.py.
3590
3591         * Scripts/bugzilla-tool:
3592         * Scripts/modules/logging.py:
3593         * Scripts/modules/workqueue.py:
3594
3595 2009-11-16  Adam Barth  <abarth@webkit.org>
3596
3597         Reviewed by Eric Seidel.
3598
3599         Move OutputTee to logging.py.
3600
3601         * Scripts/bugzilla-tool:
3602         * Scripts/modules/logging.py:
3603
3604 2009-11-15  Adam Barth  <abarth@webkit.org>
3605
3606         Reviewed by Eric Seidel.
3607
3608         Refactor bugzilla-tool to allow for multiple queues
3609         https://bugs.webkit.org/show_bug.cgi?id=31513
3610
3611         Divide the commit queue class into three class to make creating
3612         additional queues easier.
3613
3614         * Scripts/bugzilla-tool:
3615
3616 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3617
3618         Reviewed by Eric Seidel.
3619
3620         svn-apply may not handle git patches created by bugzilla-tool
3621         https://bugs.webkit.org/show_bug.cgi?id=31457
3622
3623         * Scripts/modules/scm.py:
3624         * Scripts/modules/scm_unittest.py:
3625
3626 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
3627
3628         Reviewed by Eric Seidel.
3629
3630         bugzilla-tool should post git binary diff
3631         https://bugs.webkit.org/show_bug.cgi?id=31458
3632
3633         Add --binary option to Git.create_patch.
3634
3635         * Scripts/modules/scm.py:
3636         * Scripts/modules/scm_unittest.py:
3637
3638 2009-11-15  Adam Barth  <abarth@webkit.org>
3639
3640         Reviewed by Darin Adler.
3641
3642         Add bugzilla-tool check-style
3643         https://bugs.webkit.org/show_bug.cgi?id=31515
3644
3645         * Scripts/bugzilla-tool:
3646         * Scripts/modules/bugzilla.py:
3647
3648 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3649
3650         Reviewed by Simon Hausmann.
3651
3652         Make the Qt Linux only --valgrind feature, suppress errors
3653         defined in the SuppressedValgrindErrors file.
3654
3655         * Scripts/run-webkit-tests:
3656
3657 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3658
3659         Reviewed by Simon Hausmann.
3660
3661         Set the locale to C and not to the current one in use on the system.
3662
3663         * DumpRenderTree/qt/DumpRenderTree.cpp:
3664         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3665
3666 2009-11-13  Adam Roben  <aroben@apple.com>
3667
3668         Add support for
3669         http/tests/security/isolatedWorld/didClearWindowObject.html
3670
3671         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3672         window objects in isolated worlds are cleared
3673
3674         Reviewed by Dave Hyatt.
3675
3676         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
3677
3678         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3679         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
3680         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
3681         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
3682         Added. Sets a __worldID property on the global object whose value is
3683         the ID of this world.
3684         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
3685         Respond to this new delegate callback by calling through to one of the
3686         above new methods.
3687         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3688         (worldMap): Added. Returns a HashMap containing all the worlds we've
3689         created.