Fix focus chain handling and cycling through focusable objects (links) using tab...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
2
3         Reviewed by Holger.
4
5         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
6         
7         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
8         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
9         and make the return value depend on whether we successfully determined a focusable
10         node or not.
11         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
12         if we could not handle the focus chain ourselves.
13         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
14         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
15         used to control the situation of stepping out of the focus chain inside the page.
16         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
17         The layout tests expect this to be disabled but for the user it seems sensible to have it
18         on by default, hence the default in qwebsettings.cpp
19         
20
21         * DumpRenderTree/qt/DumpRenderTree.cpp:
22         (WebCore::WebPage::WebPage):
23
24 2008-01-19  Mark Rowe  <mrowe@apple.com>
25
26         Reviewed by Alp Toker.
27
28         Allow the --http flag to run-webkit-tests to override
29         the default behaviour of disabling HTTP tests for Qt,
30         Gtk and Wx.
31
32         * Scripts/run-webkit-tests:
33
34 2008-01-19  David Kilzer  <ddkilzer@apple.com>
35
36         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
37
38         Reviewed by Darin.
39
40         We now touch a check-for-global-initializers.timestamp file in
41         the TARGET_TEMP_DIR directory to determine when new object files
42         have been compiled and thus need to be checked.  If the timestamp
43         file doesn't exist, all object files will be checked.
44
45         Previously the modification time of the "executable" (the
46         framework binary, e.g., WebKit.framework/WebKit) was used, but
47         since this was the last file modified at the end of the compile
48         phase, no object files would ever get checked!
49
50         Also added JSCustomSQLTransactionCallback.o to the list of files
51         since it has static initializers in Debug builds of WebCore.
52
53         * Scripts/check-for-global-initializers:
54
55 2008-01-18  Adam Roben  <aroben@apple.com>
56
57         Build fix
58
59         * Scripts/build-webkit:
60
61 2008-01-18  Beth Dakin  <bdakin@apple.com>
62
63         Reviewed by Oliver.
64
65         Update build-webkit to account for foreign-object being disabled by 
66         default.
67
68         * Scripts/build-webkit:
69
70 2008-01-18  Adam Roben  <aroben@apple.com>
71
72         Updated for method renames
73
74         Reviewed by Adele.
75
76         * DumpRenderTree/mac/FrameLoadDelegate.mm:
77         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
78         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
79         (LayoutTestController::setMainFrameIsFirstResponder):
80         (LayoutTestController::setWindowIsKey):
81         * DumpRenderTree/mac/UIDelegate.mm:
82         (-[UIDelegate webViewFocus:]):
83         * DumpRenderTree/win/FrameLoadDelegate.cpp:
84         (FrameLoadDelegate::didCommitLoadForFrame):
85
86 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
87
88         Reviewed by Adam Roben.
89
90         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
91         between DRT and TestNetscapePlugin.
92
93         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
94         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
95
96 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
97
98         Reviewed by Holger.
99
100         Fix fast/dom/Window/window-resize.html
101         
102         In DRT connect the page's geometryChangeRequest signal to a slot that
103         sets the geometry of the view widget.
104         
105
106         * DumpRenderTree/qt/DumpRenderTree.cpp:
107         (WebCore::WebPage::setViewGeometry):
108         (WebCore::WebPage::WebPage):
109
110 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
111
112         Build fix.
113
114         * Drosera/DroseraWin.make:
115
116 2008-01-17  Darin Adler  <darin@apple.com>
117
118         * Scripts/run-webkit-tests: Fixed a bug number.
119
120 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
121
122         Reviewed by Adam Roben.
123
124         http://bugs.webkit.org/show_bug.cgi?id=16908
125         run-webkit-tests complains about missing FindSafari.exe
126
127         * Scripts/webkitdirs.pm: Append _debug as appropriate.
128
129 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
130
131         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
132         
133         Rubber-stamped by Jon Honeycutt.
134
135         * DumpRenderTree/win/DumpRenderTree.vcproj:
136
137 2008-01-16  Alp Toker  <alp@atoker.com>
138
139         Reviewed by Mark Rowe.
140
141         http://bugs.webkit.org/show_bug.cgi?id=16218
142         [GTK] API: Should this entry point be called go_back rather than go_backward?
143
144         Track back/forward API changes in the tools.
145
146         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
147         (BackForwardItem::invoke):
148         * GtkLauncher/main.c:
149         (go_back_cb):
150
151 2008-01-16  Adam Roben  <aroben@apple.com>
152
153         Windows build fix after r29488
154
155         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
156         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
157         expects to find the plugin.
158
159 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
160
161         Reviewed by Sam Weinig.
162         
163         Fixed the waitUntilDone watchdog timer -- the old code never added the
164         timer to the run loop, so it didn't do anything.
165
166         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
167         (LayoutTestController::setWaitToDump):
168         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
169         (LayoutTestController::setWaitToDump):
170
171 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
172
173         Use shared vsprops for most vcproj properties.
174         
175         Reviewed by Darin.
176
177         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
178         * DumpRenderTree/win/DumpRenderTree.vcproj:
179         * DumpRenderTree/win/ImageDiff.vcproj:
180         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
181         * FindSafari/FindSafari.vcproj:
182
183 2008-01-14  Stephanie  <slewis@apple.com>
184
185        Reviewed by NOBODY.
186   
187        revert accidental character.
188
189        * Scripts/run-webkit-tests:
190
191 2008-01-14  Stephanie  <slewis@apple.com>
192
193         RS=Oliver
194
195         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
196
197         * Scripts/run-webkit-tests:
198
199 2008-01-14  Darin Adler  <darin@apple.com>
200
201         * Scripts/do-webcore-rename: Queue up another rename.
202
203 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
204
205         Reviewed by Darin.
206
207         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
208         the tests were ran.
209         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
210
211         * Scripts/run-webkit-tests:
212
213 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
214
215         Reviewed by Darin.
216
217         * Randomize tests array to spot test cases where the results depends on the order
218         the tests are ran.
219         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
220
221         * Scripts/run-webkit-tests:
222
223 2008-01-14  Darin Adler  <darin@apple.com>
224
225         * Scripts/run-webkit-tests: More ignore list tweaking.
226
227 2008-01-14  Darin Adler  <darin@apple.com>
228
229         * Scripts/run-webkit-tests: Add another leak to the ignore list.
230
231 2008-01-14  Dan Bernstein  <mitz@apple.com>
232
233         Reviewed by Adam Roben.
234
235         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
236           build bots
237
238         * DumpRenderTree/win/DumpRenderTree.cpp:
239         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
240
241 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
242
243         Share common files across projects.
244         
245         Unify vsprops files
246         Debug:          common.vsprops, debug.vsprops
247         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
248         Release:        common.vsprops, release.vsprops
249         
250         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
251         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
252
253         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
254
255         Reviewed by Adam Roben.
256
257         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
258         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
259         * Drosera/win/Drosera.vcproj/VERSION: Removed.
260         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
261         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
262         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
263         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
264         * DumpRenderTree/win/DumpRenderTree.vcproj:
265         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
266         * DumpRenderTree/win/debug.vsprops: Removed.
267         * DumpRenderTree/win/debug_internal.vsprops: Removed.
268         * DumpRenderTree/win/release.vsprops: Removed.
269
270 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
271
272         Reviewed by Maciej.
273
274         - http://bugs.webkit.org/show_bug.cgi?id=16314
275           Script to launch Drosera
276
277         * Scripts/gdb-drosera: Added.
278         * Scripts/run-drosera: Added.
279         * Scripts/run-drosera-nightly.cmd: Added.
280         * Scripts/webkitdirs.pm: Added runDrosera function.
281
282 2008-01-13  Dan Bernstein  <mitz@apple.com>
283
284         - fix breakage due to last-minute change
285
286         * DumpRenderTree/win/DumpRenderTree.cpp:
287         (runTest): Declare the loop variable.
288
289 2008-01-13  Dan Bernstein  <mitz@apple.com>
290
291         Reviewed by Adam Roben.
292
293         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
294
295         * DumpRenderTree/win/DumpRenderTree.cpp:
296         (DumpRenderTreeWndProc):
297         (initialize):
298         (dumpBackForwardList):
299         (dumpBackForwardListForAllWindows):
300         (dump):
301         (resetWebViewToConsistentStateBeforeTesting): Factored out of
302         runTest().
303         (runTest):
304         (allWindows): Added. Returns a vector of all open windows.
305         (windowToWebViewMap): Added. Returns a map from open windows to their
306         WebViews.
307         (createWebViewAndOffscreenWindow): Factored out of main() to be
308         reusable for creating extra windows.
309         (main):
310         * DumpRenderTree/win/DumpRenderTreeWin.h:
311         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
312         (LayoutTestController::windowCount): Implemented.
313         * DumpRenderTree/win/UIDelegate.cpp:
314         (UIDelegate::createWebViewWithRequest): Implemented.
315         (UIDelegate::webViewClose): Implemented.
316         * DumpRenderTree/win/UIDelegate.h:
317
318 2008-01-12  Alp Toker  <alp@atoker.com>
319
320         Reviewed by Mark Rowe.
321
322         Hide non-public symbols in GTK+/autotools release builds.
323
324         * GNUmakefile.am:
325
326 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
327
328         Reviewed by Ap.
329
330         * Make launching of the WebKit httpd work on GNU/Debian/Linux
331         
332         The configuration of Apache2 and installation does not depend on
333         the kernel but on the distribution policy. Make launching of httpd
334         work for Debian derived distributions.
335
336         * Scripts/run-webkit-httpd:
337         * Scripts/run-webkit-tests:
338         * Scripts/webkitdirs.pm:
339
340 2008-01-12  Mark Rowe  <mrowe@apple.com>
341
342         Reviewed by Maciej Stachowiak.
343
344         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
345
346         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
347         match the callers expectations that it can take ownership of the string.
348
349 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
350
351         Reviewed by Adam Roben.
352
353         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
354
355         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
356         as these are only posted because the test window is not a normal visible one, and
357         they confuse drag&drop machinery.
358
359 2008-01-11  Adam Roben  <aroben@apple.com>
360
361         Fix a crash when pathToLocalResource fails and a leak
362
363         Reviewed by Darin.
364
365         * DumpRenderTree/LayoutTestController.cpp:
366         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
367         sure not to pass null to JSValueMakeString.
368         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
369         (LayoutTestController::pathToLocalResource): Print an error message if
370         the conversion fails so it's clear what happened.
371
372 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
373
374         Reviewed by John Sullivan.
375
376         * DumpRenderTree/mac/GCControllerMac.mm:
377         (GCController::collectOnAlternateThread): Updated for name change.
378
379 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
380
381         wx build fix. Don't build dftables any longer since it's now a Perl
382         script.
383
384         * wx/build-wxwebkit:
385
386 2008-01-10  Sam Weinig  <sam@webkit.org>
387
388         Reviewed by Anders Carlsson.
389
390         Make DRT track open windows instead of allocated windows so that
391         we can avoid ASSERTION due to late deallocs out of our control.
392
393         * DumpRenderTree/mac/DumpRenderTree.mm:
394         (dumpBackForwardListForAllWindows):
395         (runTest):
396         * DumpRenderTree/mac/DumpRenderTreeMac.h:
397         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
398         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
399         (+[DumpRenderTreeWindow openWindows]):
400         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
401         (-[DumpRenderTreeWindow close]):
402         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
403         (LayoutTestController::windowCount):
404
405 2008-01-10  Ada Chan  <adachan@apple.com>
406
407         Meta key is not the same as Alt key on windows.
408
409         Reviewed by Darin.
410
411         * DumpRenderTree/win/EventSender.cpp:
412         (keyDownCallback):
413
414 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
415
416         Reviewed by Darin, Sam and Adam.
417
418         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
419         link in gmail message displays JavaScript alert falsely complaining
420         about pop-up blocking.
421         - Added the ability to enable the pop-up blocker via the
422         LayoutTestController.
423
424         * DumpRenderTree/LayoutTestController.cpp:
425         (setPopupBlockingEnabledCallback):
426         (LayoutTestController::staticFunctions):
427         * DumpRenderTree/LayoutTestController.h:
428         * DumpRenderTree/mac/DumpRenderTree.mm:
429         (setDefaultsToConsistentValuesForTesting):
430         (resetWebViewToConsistentStateBeforeTesting):
431         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
432         (LayoutTestController::setPopupBlockingEnabled):
433
434 2008-01-10  Lars Knoll  <lars@trolltech.com>
435
436         Reviewed by Simon.
437
438         rename QWebPageHistory to QWebHistory.
439         
440
441         * DumpRenderTree/qt/jsobjects.cpp:
442
443 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
444
445         Reviewed by Darin.
446         
447         - add some more renames, adjust some
448
449         * Scripts/do-webcore-rename:
450
451 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
452
453         Reviewed by Oliver.
454
455         Enable SVG Fonts support by default.
456
457         * Scripts/build-webkit:
458
459 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
460
461         Reviewed by Adam.
462
463         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
464         DRT doesn't handle platform specific pixel test results correctly.
465
466         <test>-expected.txt files and <test>-expected.png files may now live
467         in different directories (ie. a cross-platform <test>-expected.txt file
468         and a platform-specific <test>-expected.png file).
469
470         * Scripts/run-webkit-tests:
471
472 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
473
474         Reviewed by Darin.
475
476         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
477         DRT did not correctly handle printing the '\0' char.  Now it does.
478
479         * DumpRenderTree/win/DumpRenderTree.cpp:
480         (dumpFramesAsText):
481         (dump):
482
483 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
484
485         Reviewed by Lars.
486
487         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
488         
489
490         * DumpRenderTree/qt/main.cpp:
491         * DumpRenderTree/qt/testplugin.cpp:
492         * DumpRenderTree/qt/testplugin.h:
493
494 2008-01-05  Mark Rowe  <mrowe@apple.com>
495
496         Reviewed by Alp Toker.
497
498         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
499
500         * DumpRenderTree/gtk/DumpRenderTree.cpp:
501         (processWork): Process pending work.
502         (webViewLoadFinished): Schedule processing of pending work.
503         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
504
505 2008-01-05  Darin Adler  <darin@apple.com>
506
507         * Scripts/do-webcore-rename: Some more renaming plans.
508
509 2008-01-04  Alice Liu  <alice.liu@apple.com>
510
511         Reviewed by Alexey and Darin.
512
513         Adding "home" and "end" to DRT's keydown since
514         DOM key events can't handle keyIdentifiers at this point. 
515
516         * DumpRenderTree/mac/EventSendingController.mm:
517         (-[EventSendingController keyDown:withModifiers:]):
518         * DumpRenderTree/win/EventSender.cpp:
519         (keyDownCallback):
520
521 2008-01-04  Lars Knoll  <lars@trolltech.com>
522
523         Reviewed by Simon.
524
525         fix DRT after the changes to QWebPage.
526         
527         The great thing is that we actually don't have
528         any regressions from the QWebPage change :)
529         
530
531         * DumpRenderTree/qt/DumpRenderTree.cpp:
532         (WebCore::DumpRenderTree::DumpRenderTree):
533
534 2008-01-04  Lars Knoll  <lars@trolltech.com>
535
536         Reviewed by Simon.
537
538         make QWebPage a QObject and get things to compile.
539         
540         Nothing works currently though.
541         
542
543         * DumpRenderTree/qt/DumpRenderTree.cpp:
544         (WebCore::DumpRenderTree::DumpRenderTree):
545
546 2008-01-04  Lars Knoll  <lars@trolltech.com>
547
548         Reviewed by Simon.
549
550         take a QString as identifier in QWebFrame::addToJSWindowObject.
551
552         * DumpRenderTree/qt/DumpRenderTree.cpp:
553         (WebCore::DumpRenderTree::initJSObjects):
554
555 2008-01-04  Alp Toker  <alp@atoker.com>
556
557         GTK+ DRT build fix for breakage introduced in r29149.
558
559         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
560         (LayoutTestController::execCommand):
561
562 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
563
564         Reviewed by Darin.
565
566         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
567
568         Added layoutTestController.execCommand to access editor commands that are not available
569         via document.execCommand.
570
571         * DumpRenderTree/LayoutTestController.cpp:
572         (execCommandCallback):
573         (LayoutTestController::staticFunctions):
574         * DumpRenderTree/LayoutTestController.h:
575         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
576         (LayoutTestController::execCommand):
577         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
578         (LayoutTestController::queueLoad):
579         (LayoutTestController::execCommand):
580
581 2008-01-03  Alice Liu  <alice.liu@apple.com>
582
583         Reviewed by Darin, Mitz.
584
585         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
586
587         the clickcount should not increase if the last click was at a different location.  it's a new click.
588
589         * DumpRenderTree/mac/DumpRenderTree.mm:
590         (runTest):
591         * DumpRenderTree/mac/EventSendingController.h:
592         * DumpRenderTree/mac/EventSendingController.mm:
593         (-[EventSendingController mouseDown]):
594         (-[EventSendingController mouseUp]):
595
596 2008-01-03  Darin Adler  <darin@apple.com>
597
598         Reviewed by Adam.
599
600         * Scripts/update-webkit: Make this work a little better for the people at Apple
601         who have a directory named Internal.
602
603 2008-01-03  Adam Roben  <aroben@apple.com>
604
605         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
606
607         Rubberstamped by Mark.
608
609         * Scripts/update-webkit-auxiliary-libs:
610
611 2008-01-03  Adam Roben  <aroben@apple.com>
612
613         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
614
615         http://bugs.webkit.org/show_bug.cgi?id=15663
616
617         Added a fuzz factor into the Last-Modified comparison for downloading
618         WebKitAuxiliaryLibrary.zip.
619
620         The zip file is served from a set of mirrors who give Last-Modified
621         times that are off by 1-3 seconds from each other. This was causing
622         the build bots to redownload WebKitAuxiliaryLibrary for every build,
623         which would then cause all of WebCore to rebuild each time.
624
625         Reviewed by Mark.
626
627         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
628         at least 30 seconds newer than the old one -- otherwise we assume that
629         the difference in time is due to the mirrors being slightly offset
630         from each other.
631         (sub lastModifiedToUnixTime): Added.
632
633 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
634
635         Windows build fix.
636
637         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
638
639 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
640
641         Reviewed by Lars.
642
643         Moved QWebPage::open to QWebFrame::load and added setHtml.
644         
645
646         * DumpRenderTree/qt/DumpRenderTree.cpp:
647         (WebCore::DumpRenderTree::open):
648
649 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
650
651         Reviewed by Lars.
652
653         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
654         
655
656         * DumpRenderTree/qt/DumpRenderTree.cpp:
657         (WebCore::DumpRenderTree::DumpRenderTree):
658
659 2008-01-02  Sam Weinig  <sam@webkit.org>
660
661         * Scripts/do-webcore-rename: Yet more renaming ideas.
662
663 2008-01-02  Darin Adler  <darin@apple.com>
664
665         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
666
667 2008-01-02  Alice Liu  <alice.liu@apple.com>
668
669         Reviewed by Sam Weinig.
670
671         fixing assertion hit with editing/selection/move-begin-end.html
672
673         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
674         * DumpRenderTree/win/DumpRenderTree.vcproj:
675         * DumpRenderTree/win/EventSender.cpp:
676         (keyDownCallback):
677         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
678
679 2008-01-02  Darin Adler  <darin@apple.com>
680
681         * Scripts/do-webcore-rename: Some more name change plans.
682
683 2008-01-02  Alice Liu  <alice.liu@apple.com>
684
685         Reviewed by Maciej.
686
687         Added handling for page up and page down in EventSender
688
689         * DumpRenderTree/mac/EventSendingController.mm:
690         (-[EventSendingController keyDown:withModifiers:]):
691         * DumpRenderTree/win/EventSender.cpp:
692         (keyDownCallback):
693
694 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
695
696         Reviewed by Darin.
697
698         Fix fast/events/arrow-keys-on-body.html for real.
699
700         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
701
702 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
703
704         Reviewed by Darin.
705
706         http://bugs.webkit.org/show_bug.cgi?id=16674
707         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
708
709         * Scripts/run-launcher:
710
711 2007-12-31  Darin Adler  <darin@apple.com>
712
713         Suggested by Antti.
714
715         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
716         we get it installed on the build bots.
717
718 2007-12-30  Eric Seidel  <eric@webkit.org>
719
720         Reviewed by Sam.
721
722         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
723
724 2007-12-29  Darin Adler  <darin@apple.com>
725
726         Reviewed by Oliver.
727
728         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
729           leak bot shows createCStringFromNPVariant result leaking
730
731         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
732         (pluginInvoke): Added a missing free.
733
734 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
735
736         Reviewed by Alp Toker.
737
738         http://bugs.webkit.org/show_bug.cgi?id=16390
739         Use autotools or GNU make as the build system for the GTK port
740
741         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
742         * GNUmakefile.am: Added.
743
744 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
745
746         Reviewed by Oliver.
747
748         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
749
750         * DumpRenderTree/win/EventSender.cpp:
751         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
752         of 1, even though WebKit currently ignores it.
753
754 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
755
756         wx buildbot fix. Update libpng dl script to the latest version.
757
758         * wx/install-unix-extras:
759
760 2007-12-22  Antti Koivisto  <antti@apple.com>
761
762         Fix a typo.
763
764         * Scripts/webkitdirs.pm:
765
766 2007-12-21  Sam Weinig  <sam@webkit.org>
767
768         Reviewed by Mark Rowe.
769
770         - Disable the back/forward cache using the new WebPreferences API
771           instead of through the BackForwardList.  This makes us match what
772           we do on Windows.
773
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (createWebViewAndOffscreenWindow):
776         (setDefaultsToConsistentValuesForTesting):
777
778 2007-12-21  Dan Bernstein  <mitz@apple.com>
779
780         Reviewed by Mark Rowe.
781
782         - disable the back/forward cache in Windows DumpRenderTree. It is
783           already disabled in Mac DumpRenderTree.
784
785         * DumpRenderTree/win/DumpRenderTree.cpp:
786         (initializePreferences):
787
788 2007-12-13  Antti Koivisto  <antti@apple.com>
789
790         Reviewed by Darin and Steve.
791         
792         - check for QuickTime SDK on Windows.
793         - build media support on Windows by default
794
795         * Scripts/build-webkit:
796         * Scripts/webkitdirs.pm:
797
798 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
799
800         Build script fix for buildbot.
801
802         * wx/build-wxwebkit:
803
804 2007-12-20  Eric Seidel  <eric@webkit.org>
805
806         Reviewed by mjs.
807
808         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
809
810 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
811
812         Reviewed by Steve.
813
814         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
815         WebKit.
816
817         - Drosera and Safari need to use the same ProgIDs in order for
818         CoCreateInstance to work properly.  The most robust way to do this is
819         for WebKit to dynamically publish those ProgIDs.
820
821         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
822         (DebuggerClient::createWebViewWithRequest):
823         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
824         statics.
825         (Drosera::initUI):
826         (Drosera::attach):
827         (Drosera::attemptToCreateServerConnection):
828         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
829         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
830         make use of the published ProgIDs.
831         (ServerConnection::attemptToCreateServerConnection):
832
833 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
834
835         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
836         - Build bot and leak fix.
837
838         * DumpRenderTree/LayoutTestController.cpp:
839         (pathToLocalResourceCallback):
840
841 2007-12-19  David Kilzer  <ddkilzer@apple.com>
842
843         Make svn-apply/svn-unapply work with patches from git-format-patch.
844
845         Reviewed by Darin.
846
847         * Scripts/svn-apply:
848         (patch): If 'Index:' can't be found in the text passed in, print it
849         out with a warning and return early.
850         * Scripts/svn-unapply:
851         (patch): Ditto.
852
853 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
854
855         Reviewed by Alp Toker.
856
857         Build related fixes.
858
859         * wx/build-wxwebkit:
860         - Check to make sure the user is running a supported wx port
861         - More robust checks for Cygwin
862         - Only run install-unix-extras on Mac, it's not the right solution
863           for Linux distros.
864         - Remove outdated Linux instructions after successful build
865         - Clean Bakefile-generated files during a clean operation
866
867 2007-12-18  Darin Adler  <darin@apple.com>
868
869         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
870
871 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
872
873         Add script to run Drosera as part of the nightly.
874         
875         Reviewed by Kevin M.
876
877         * Scripts/run-drosera.cmd: Added.
878
879 2007-12-18  Darin Adler  <darin@apple.com>
880
881         * Scripts/do-webcore-rename: Remove a stray K.
882
883 2007-12-18  Darin Adler  <darin@apple.com>
884
885         * Scripts/do-webcore-rename: Plan more renaming.
886
887 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
888
889         Reviewed by Alp Toker.
890
891         http://bugs.webkit.org/show_bug.cgi?id=16042
892         [GTK] Eliminate webkit_init()
893
894         Moving webkit initialization to WebView class init.
895
896         * DumpRenderTree/gtk/DumpRenderTree.cpp:
897         (main):
898         * GtkLauncher/main.c:
899         (main):
900
901 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
902
903         Reviewed by Alp Toker.
904
905         http://bugs.webkit.org/show_bug.cgi?id=13542
906         gdklauncher doesnt change URL in adress GTKEntry.
907
908         * GtkLauncher/main.c:
909         (load_commit_cb): added
910         (title_change_cb):
911         (create_browser):
912
913 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
914
915         Reviewed by Adam Roben.
916
917         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
918
919         * FindSafari/FindSafari.cpp:
920         (_tmain):
921
922 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
923
924         Reviewed by Adam Roben.
925
926         http://bugs.webkit.org/show_bug.cgi?id=16315
927         FindSafari needs a path-only option.
928
929         * FindSafari/FindSafari.cpp:
930         (_tmain):
931
932 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
933
934         Reviewed by Darin.
935
936         http://bugs.webkit.org/show_bug.cgi?id=16462
937         REGRESSION: access keys broken on Windows
938
939         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
940         if Alt is pressed.
941
942 2007-12-15  Sam Weinig  <sam@webkit.org>
943
944         Reviewed by Mark Rowe.
945
946         Fix urlSuitableForTestResult to correctly identify wstring::npos as
947         the case when wstring.find doesn't find anything.
948
949         * DumpRenderTree/win/DumpRenderTree.cpp:
950         (urlSuitableForTestResult):
951
952 2007-12-15  Alp Toker  <alp@atoker.com>
953
954         GTK+ DRT build fix for GLib < 2.14.
955
956         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
957         (LayoutTestController::setWaitToDump):
958
959 2007-12-05  Mark Rowe  <mrowe@apple.com>
960
961         Reviewed by Alp Toker.
962
963         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
964         many layout tests from hanging while waiting on user responses to dialogs.
965
966         * DumpRenderTree/gtk/DumpRenderTree.cpp:
967         (invalidateAnyPreviousWaitToDumpWatchdog):
968         (webViewScriptAlert):
969         (webViewScriptPrompt):
970         (webViewScriptConfirm):
971         (main):
972         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
973         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
974         (waitToDumpWatchdogFired):
975         (LayoutTestController::setWaitToDump):
976
977 2007-12-05  Mark Rowe  <mrowe@apple.com>
978
979         Reviewed by Alp Toker.
980
981         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
982
983         * DumpRenderTree/gtk/DumpRenderTree.cpp:
984         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
985         (dump):
986         (runTest):
987         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
988         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
989         work queue is empty.
990         (webViewWindowObjectCleared): Set up window.layoutTestController.
991         (webViewConsoleMessage): Match the console message format expected by the layout test results.
992         (main): Hook up the new signals.
993         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
994         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
995         dumping multiple times.
996         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
997         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
998
999 2007-12-14  Anders Carlsson  <andersca@apple.com>
1000
1001         Reviewed by Brady.
1002
1003         Assert that a web frame that's loading a resource always has either a data source or 
1004         a provisional data source.
1005         
1006         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1007         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1008
1009 2007-12-14  Darin Adler  <darin@apple.com>
1010
1011         - fix mistake causing nearly all tests to fail on Windows
1012
1013         * DumpRenderTree/win/UIDelegate.cpp:
1014         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1015         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1016
1017         * DumpRenderTree/mac/UIDelegate.mm:
1018         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1019         than passing the entire message.
1020
1021 2007-12-14  Darin Adler  <darin@apple.com>
1022
1023         - fix Tiger build
1024
1025         * DumpRenderTree/mac/UIDelegate.mm:
1026         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1027         new-to-Leopard methods.
1028
1029 2007-12-14  Darin Adler  <darin@apple.com>
1030
1031         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1032         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1033         delegate methods here.
1034
1035 2007-12-14  Anders Carlsson  <andersca@apple.com>
1036
1037         Reviewed by Darin and Geoff.
1038
1039         <rdar://problem/5619295> 
1040         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1041         
1042         Add property getting methods to the plug-in.
1043         
1044         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1045         (pluginInvoke):
1046
1047 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1048
1049         Reviewed by Darin.
1050
1051         - Layout test fix for mac. When dumped to the console local file paths
1052         now only show the name of the resource not the whole path.  This is to
1053         make the results machine and OS independent.
1054
1055         * DumpRenderTree/mac/UIDelegate.mm:
1056         (-[UIDelegate webView:addMessageToConsole:]):
1057
1058 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1059
1060         Reviewed by Adam.
1061
1062         - Layout tests fix.  We need a way to remove machine-dependent
1063         information from paths in layout test results. The UIDelegate now does
1064         this.
1065
1066         * DumpRenderTree/DumpRenderTree.h:
1067         * DumpRenderTree/win/DumpRenderTree.cpp:
1068         (urlSuitableForTestResult):
1069         * DumpRenderTree/win/DumpRenderTreeWin.h:
1070         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1071         * DumpRenderTree/win/UIDelegate.cpp:
1072         (UIDelegate::webViewAddMessageToConsole):
1073
1074 2007-12-13  Alp Toker  <alp@atoker.com>
1075
1076         Build fix for DRT breakage introduced in r28690.
1077
1078         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1079         (LayoutTestController::pathToLocalResource):
1080
1081 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1082
1083         Reviewed by Alice and Sam.
1084
1085         - <rdar://5621435> Need a way to specify local resources (being loaded
1086         from HTTP tests) on Windows.
1087         - Implemented pathToLocalResource which exposes the functionality of
1088         converting a given unix path to the correct location on Windows.
1089
1090         * DumpRenderTree/LayoutTestController.cpp:
1091         (pathToLocalResourceCallback):
1092         (LayoutTestController::staticFunctions):
1093         * DumpRenderTree/LayoutTestController.h:
1094         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1095         (LayoutTestController::pathToLocalResource):
1096         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1097         (LayoutTestController::pathToLocalResource):
1098
1099 2007-12-12  Anders Carlsson  <andersca@apple.com>
1100
1101         Reviewed by Sam.
1102
1103         <rdar://problem/5132003>
1104         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1105
1106         * DumpRenderTree/win/DumpRenderTree.cpp:
1107         (main):
1108         Set the resource load delegate.
1109         
1110         * DumpRenderTree/win/DumpRenderTree.vcproj:
1111         
1112         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1113         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1114
1115 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1116
1117         Reviewed by Adam Roben.
1118
1119         Fix conversion from double to LPARAM in dispatchMessage().
1120
1121         * DumpRenderTree/win/EventSender.cpp:
1122         (dispatchMessageCallback):
1123
1124 2007-12-11  Dan Bernstein  <mitz@apple.com>
1125
1126         Reviewed by Mark Rowe and Sam Weinig too!
1127
1128         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1129           fonts DumpRenderTree registers.
1130
1131         * DumpRenderTree/win/DumpRenderTree.cpp:
1132         (initialize):
1133
1134 2007-12-11  Brady Eidson  <beidson@apple.com>
1135
1136         Reviewed by Anders
1137
1138         Make DumpRenderTree on mac use its own path for Databases testing
1139
1140         * DumpRenderTree/mac/DumpRenderTree.mm:
1141         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1142           for future DRT-only use, then use it to construct the Databases path and set that default
1143
1144 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1145
1146         Reviewed by Darin.
1147
1148         <rdar://problem/5535636>
1149         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1150
1151         http://bugs.webkit.org/show_bug.cgi?id=13916
1152         JavaScript detects Tab as a character input on a textfield validation
1153
1154         * DumpRenderTree/mac/EventSendingController.mm:
1155         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1156         Dispatch a keyup to better match what happens when a key is physically pressed.
1157
1158         * DumpRenderTree/win/EventSender.cpp:
1159         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1160         returning from keyDown().
1161         (getConstantCallback): Fixed a couple copy/paste mistakes.
1162
1163 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1164
1165         Reviewed by Oliver.
1166
1167         - <rdar://5599845> Drosera: Does not show loal files in the file list
1168         on the left side.
1169
1170         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1171         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1172         so the open source community can build.
1173
1174 2007-12-10  Brady Eidson  <beidson@apple.com>
1175
1176         Rubberstamped by Sam Weinig
1177
1178         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1179
1180         * DumpRenderTree/mac/UIDelegate.mm:
1181         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1182         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1183
1184 2007-12-08  Oliver Hunt  <oliver@apple.com>
1185
1186         Reviewed by Sam W.
1187
1188         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1189         
1190         Fixes <rdar://problem/5620249> Must disable SVG animation
1191         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1192         
1193         In order to allow finer grained control over the set of SVG features
1194         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1195         distinct flags:
1196         ENABLE_SVG_ANIMATION
1197         ENABLE_SVG_FILTERS
1198         ENABLE_SVG_FONTS
1199         ENABLE_SVG_AS_IMAGE
1200         ENABLE_SVG_USE
1201         
1202         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1203         
1204         Script handles all the new build flags, and allows --svg-experimental
1205         to automatically enable all features.
1206
1207         * Scripts/build-webkit:
1208
1209 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1210
1211         Fix version parsing.
1212
1213         Rubber-stamped by Oliver.
1214
1215         * Drosera/win/Drosera.vcproj/auto-version.sh:
1216
1217 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1218
1219         Build modifications for Drosera.
1220
1221         Reviewed by Adam.
1222
1223         * Drosera/DroseraWin.make: Added.
1224         * Drosera/win/Drosera.vcproj/Drosera.rc:
1225         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1226         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1227         * Drosera/win/Drosera.vcproj/VERSION: Added.
1228         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1229
1230 2007-12-06  Adam Roben  <aroben@apple.com>
1231
1232         Explicitly turn on the Mac font ascent hack on Windows
1233
1234         This keeps our font metrics matching those from Mac.
1235
1236         Reviewed by Hyatt.
1237
1238         * DumpRenderTree/win/DumpRenderTree.cpp:
1239         (main):
1240
1241 2007-12-06  Anders Carlsson  <andersca@apple.com>
1242
1243         Rename main.c to main.cpp here too.
1244         
1245         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1246
1247 2007-12-06  Sam Weinig  <sam@webkit.org>
1248
1249         Rubber stamped by Geoff.
1250
1251         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1252
1253 2007-12-06  Darin Adler  <darin@apple.com>
1254
1255         * Scripts/do-webcore-rename: Some more renaming plans.
1256
1257 2007-12-06  Anders Carlsson  <andersca@apple.com>
1258
1259         Restore implementation of testGetIntIdentifier that was accidentally
1260         removed somehow (possibly when I made PluginObject be a cpp file).
1261         
1262         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1263         (pluginInvoke):
1264
1265 2007-12-05  Anders Carlsson  <andersca@apple.com>
1266
1267         Make the entry points extern "C".
1268         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1269         
1270 2007-12-05  Anders Carlsson  <andersca@apple.com>
1271
1272         C++ warning fixes.
1273         
1274         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1275         (NPP_New):
1276         (NPP_Destroy):
1277         (NPP_SetWindow):
1278         (NPP_NewStream):
1279         (NPP_HandleEvent):
1280         (NPP_URLNotify):
1281         (NPP_GetValue):
1282
1283 2007-12-05  Anders Carlsson  <andersca@apple.com>
1284
1285         Add the .cpp files to the TestNetscapePlugIn target.
1286
1287         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1288
1289 2007-12-05  Anders Carlsson  <andersca@apple.com>
1290
1291         Reviewed by Geoff.
1292         
1293         Rename the TestNetscapePlugIn .c files to be .cpp.
1294
1295         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1296         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1297         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1298         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1299         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1300         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1301         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1302         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1303
1304 2007-12-05  Adam Roben  <aroben@apple.com>
1305
1306         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1307
1308         This fixes several regression tests.
1309
1310         Reviewed by Alice.
1311
1312         * DumpRenderTree/win/EventSender.cpp:
1313         (keyDownCallback): Virtual keycodes for ASCII characters are always
1314         uppercase, so we need to check the case of the original character
1315         passed in to eventSender.keyDown.
1316
1317 2007-12-05  Adam Roben  <aroben@apple.com>
1318
1319         Learn from Tim's mistakes
1320
1321         * DumpRenderTree/win/DumpRenderTree.cpp:
1322         (runTest): Reset the authorAndUserStylesEnabled preference for each
1323         test.
1324
1325 2007-12-05  Alp Toker  <alp@atoker.com>
1326
1327         Reviewed by Mark Rowe.
1328
1329         Initialize GTK+ and WebKit so the tests can run.
1330
1331         Reorganize the headers a little.
1332
1333         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1334         (main):
1335
1336 2007-12-04  Anders Carlsson  <andersca@apple.com>
1337
1338         Remove IWebScriptScope include.
1339         
1340         * Drosera/win/DebuggerDocumentPlatform.cpp:
1341
1342 2007-12-04  Sam Weinig  <sam@webkit.org>
1343
1344         Rubber stamped by Mark Rowe.
1345
1346         Define CF as platform for mac and revert r28409
1347
1348         * DumpRenderTree/DumpRenderTree.h:
1349         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1350
1351 2007-12-04  Sam Weinig  <sam@webkit.org>
1352
1353         Define CF as platform for windows.
1354
1355         Reviewed by Adam Roben.
1356
1357         * DumpRenderTree/win/DumpRenderTreeWin.h:
1358
1359 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1360
1361         Reviewed by Adam and Darin.
1362
1363         - Removed a needless BSTR cleanup.
1364
1365         * Drosera/win/DebuggerDocumentPlatform.cpp:
1366         (DebuggerDocument::getPlatformCurrentFunctionStack):
1367
1368 2007-11-27  Adam Roben  <aroben@apple.com>
1369
1370         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1371
1372         Reviewed by Maciej.
1373
1374         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1375         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1376
1377 2007-12-04  Alp Toker  <alp@atoker.com>
1378
1379         Prospective Win DRT build fix.
1380
1381         * DumpRenderTree/DumpRenderTree.h:
1382
1383 2007-12-04  Alp Toker  <alp@atoker.com>
1384
1385         Fix a clobbered copyright header.
1386
1387         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1388
1389 2007-12-04  Xan Lopez  <xan@gnome.org>
1390
1391         Reviewed by Alp Toker.
1392
1393         http://bugs.webkit.org/show_bug.cgi?id=15561
1394         GTK port needs DumpRenderTree implementation
1395
1396         Start work on the GTK+ DRT.
1397
1398         This does not work yet, and there are a few lingering style issues
1399         (nothing major) but this patch has been stuck in the bug tracker for
1400         too long already.
1401
1402         * DumpRenderTree/DumpRenderTree.h:
1403         * DumpRenderTree/gtk: Added.
1404         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1405         (autocorrectURL):
1406         (shouldLogFrameLoadDelegates):
1407         (dumpFrameScrollPosition):
1408         (displayWebView):
1409         (appendString):
1410         (dumpFramesAsText):
1411         (dumpRenderTreeAsText):
1412         (dump):
1413         (runTest):
1414         (main):
1415         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1416         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1417         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1418         (GCController::collect):
1419         (GCController::collectOnAlternateThread):
1420         (GCController::getJSObjectCount):
1421         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1422         (LayoutTestController::~LayoutTestController):
1423         (LayoutTestController::addDisallowedURL):
1424         (LayoutTestController::clearBackForwardList):
1425         (LayoutTestController::copyDecodedHostName):
1426         (LayoutTestController::copyEncodedHostName):
1427         (LayoutTestController::display):
1428         (LayoutTestController::keepWebHistory):
1429         (LayoutTestController::notifyDone):
1430         (LayoutTestController::queueBackNavigation):
1431         (LayoutTestController::queueForwardNavigation):
1432         (LayoutTestController::queueLoad):
1433         (LayoutTestController::queueReload):
1434         (LayoutTestController::queueScript):
1435         (LayoutTestController::setAcceptsEditing):
1436         (LayoutTestController::setCustomPolicyDelegate):
1437         (LayoutTestController::setMainFrameIsFirstResponder):
1438         (LayoutTestController::setTabKeyCyclesThroughElements):
1439         (LayoutTestController::setUseDashboardCompatibilityMode):
1440         (LayoutTestController::setUserStyleSheetEnabled):
1441         (LayoutTestController::setUserStyleSheetLocation):
1442         (LayoutTestController::setWindowIsKey):
1443         (LayoutTestController::setWaitToDump):
1444         (LayoutTestController::windowCount):
1445         (LayoutTestController::setPrivateBrowsingEnabled):
1446         (LayoutTestController::setAuthorAndUserStylesEnabled):
1447         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1448         (JSStringCopyUTF8CString):
1449         (LoadItem::invoke):
1450         (ReloadItem::invoke):
1451         (ScriptItem::invoke):
1452         (BackForwardItem::invoke):
1453
1454 2007-12-03  Sam Weinig  <sam@webkit.org>
1455
1456         Move JavaScriptCore thread testing code to pthread specific directory
1457         and remove the dependance on CoreFoundation by using WTF::HashSet.
1458
1459         Reviewed by Geoff and Oliver.
1460
1461         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1462         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1463         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1464         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1465         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1466         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1467         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1468         * DumpRenderTree/pthreads: Added.
1469         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1470         (javaScriptThreads):
1471         (runJavaScriptThread):
1472         (startJavaScriptThreads):
1473         (stopJavaScriptThreads):
1474
1475 2007-12-03  Andrew Bonventre  <andybons@google.com>
1476
1477         Reviewed by Darin Adler.
1478
1479         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1480         Symbol lookup menu broken in debugger view
1481
1482         * Drosera/debugger.js: Fixed javascript error where document property
1483         should have been used instead of contentDocument in switchFunction that
1484         was breaking the select symbol dropdown menu.  This is because
1485         window.frames will return a Window object and not a frame object like
1486         the author was originally expecting.
1487
1488 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1489
1490         Reviewed by Adam.
1491
1492         - <rdar://5618942> Drosera: Console window does not process everything
1493         correctly.
1494         - <rdar://5619005> Drosera: could be sped up by moving the 
1495         WebScriptScope stuff into the WebScriptCallFrame.
1496         - Now the console can correctly process objects and does not receive
1497         notifications from JavaScriptCore about the JavaScript in Drosera's
1498         own process.
1499
1500         * Drosera/win/DebuggerDocumentPlatform.cpp:
1501         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1502         (DebuggerDocument::platformValueForScopeVariableNamed):
1503
1504 2007-12-03  Stephanie  <slewis@apple.com>
1505
1506         Reviewed by Darin.
1507
1508         Check to see if we are building a debug root
1509
1510         * Scripts/check-for-global-initializers: 
1511
1512 2007-12-03  Dan Bernstein  <mitz@apple.com>
1513
1514         Reviewed by Darin Adler.
1515
1516         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1517
1518         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1519         (pluginInvoke):
1520
1521 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1522
1523         Reviewed by Oliver.
1524
1525         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1526         in a more fine-grained manner than eventSender.keyDown().
1527
1528         * DumpRenderTree/win/EventSender.cpp:
1529         (getConstantCallback):
1530         (dispatchMessageCallback):
1531
1532 2007-12-02  Darin Adler  <darin@apple.com>
1533
1534         * Scripts/do-webcore-rename: More planned renaming.
1535
1536 2007-12-02  Sam Weinig  <sam@webkit.org>
1537
1538         Rubber stamped by Anders.
1539
1540         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1541         more uniform results cross platform.
1542
1543         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1544         (-[NSURL _drt_descriptionSuitableForTestResult]):
1545
1546 2007-12-02  Sam Weinig  <sam@webkit.org>
1547
1548         Rubber stamped by Niko.
1549
1550         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1551
1552         * DumpRenderTree/win/DumpRenderTree.cpp:
1553         * DumpRenderTree/win/DumpRenderTree.vcproj:
1554         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1555         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1556         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1557         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1558
1559 2007-12-01  Alp Toker  <alp@atoker.com>
1560
1561         Reviewed by Adam Roben.
1562
1563         Make use of the newly introduced webkit.h convenience header.
1564
1565         * GtkLauncher/main.c:
1566
1567 2007-12-01  Adam Treat  <treat@kde.org>
1568
1569         Reviewed by Simon.
1570
1571         * Check to see if the directory exists and exit if not.
1572
1573         * DumpRenderTree/qt/main.cpp:
1574         (main):
1575
1576 2007-12-01  Adam Treat  <treat@kde.org>
1577
1578         Reviewed by Simon.
1579
1580         * Don't hide symbols when in Debug mode
1581         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1582
1583
1584         * DumpRenderTree/qt/main.cpp:
1585         (messageHandler):
1586
1587 2007-11-30  Alp Toker  <alp@atoker.com>
1588
1589         Reviewed by Adam Roben.
1590
1591         http://bugs.webkit.org/show_bug.cgi?id=15691
1592         [GTK] Public API does not follow GTK+ conventions
1593
1594         Refactor the WebKit/GTK+ public API. Changes:
1595           WebKitPage -> WebKitWebView
1596           WebKitFrame -> WebKitWebFrame
1597
1598         Public API source and header names have been updated to mirror the API
1599         changes.
1600
1601         The API is now kept in WebKit/gtk/WebView to match other ports in the
1602         same class such as Mac and Win.
1603
1604         * GtkLauncher/main.c:
1605         (activate_uri_entry_cb):
1606         (link_hover_cb):
1607         (title_change_cb):
1608         (progress_change_cb):
1609         (go_back_cb):
1610         (go_forward_cb):
1611         (create_browser):
1612         (main):
1613
1614 2007-11-30  Adam Roben  <aroben@apple.com>
1615
1616         Hopefully the final build fix
1617
1618         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1619         pull in WTF's assertion/logging functions.
1620
1621 2007-11-30  Adam Roben  <aroben@apple.com>
1622
1623         Another build fix
1624
1625         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1626         WebKit.lib.
1627
1628 2007-11-30  Adam Roben  <aroben@apple.com>
1629
1630         Debug build fix
1631
1632         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1633         configuration.
1634         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1635         projects.
1636         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1637         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1638         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1639
1640 2007-11-30  Sam Weinig  <sam@webkit.org>
1641
1642         Reviewed by Adam Roben.
1643
1644         Fix drawSelectionRect to actually draw the selection rect.
1645
1646         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1647         (drawSelectionRect):
1648
1649 2007-11-30  Darin Adler  <darin@apple.com>
1650
1651         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1652
1653 2007-11-30  Darin Adler  <darin@apple.com>
1654
1655         * Scripts/do-webcore-rename: Get ready for some future renaming.
1656
1657 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1658
1659         Reviewed by Adam.
1660
1661         - Removed some unnecessary functions and changed an unused return type. 
1662
1663         * Drosera/win/DebuggerClient.cpp:
1664         (registerConsoleClass):
1665         * Drosera/win/DebuggerClient.h:
1666         * Drosera/win/Drosera.cpp:
1667         (registerDroseraClass):
1668
1669 2007-11-28  Alp Toker  <alp@atoker.com>
1670
1671         Reviewed by Timothy Hatcher.
1672
1673         http://bugs.webkit.org/show_bug.cgi?id=16174
1674         [GTK] Use "URI" not "URL" in public API
1675
1676         Replace use of the term "URL" with "URI" in public headers,
1677         documentation and some internal code to match GLib/GTK+ convention.
1678
1679         This is now mentioned in the API guidelines:
1680           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1681
1682         * GtkLauncher/main.c:
1683         (activate_uri_entry_cb):
1684         (title_change_cb):
1685         (create_toolbar):
1686         (main):
1687
1688 2007-11-29  Anders Carlsson  <andersca@apple.com>
1689
1690         Reviewed by Sam.
1691
1692         <rdar://problem/5230478>
1693         FrameLoadDelegate callbacks are not dumped in DRT.
1694         
1695         * DumpRenderTree/win/DumpRenderTree.cpp:
1696         (shouldLogFrameLoadDelegates):
1697         (runTest):
1698         (main):
1699         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1700         (BSTRtoString):
1701         (descriptionSuitableForTestResult):
1702         (FrameLoadDelegate::QueryInterface):
1703         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1704         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1705         (FrameLoadDelegate::didCommitLoadForFrame):
1706         (FrameLoadDelegate::didFinishLoadForFrame):
1707         (FrameLoadDelegate::willCloseFrame):
1708         (FrameLoadDelegate::didClearWindowObject):
1709         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1710         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1711         * DumpRenderTree/win/FrameLoaderDelegate.h:
1712         (FrameLoadDelegate::windowScriptObjectAvailable):
1713         (FrameLoadDelegate::didFirstLayoutInFrame):
1714
1715 2007-11-29  Sam Weinig  <sam@webkit.org>
1716
1717         Reviewed by Anders.
1718
1719         Add database quota UIDelegates methods to DRT UIDelegate.
1720
1721         * DumpRenderTree/mac/UIDelegate.mm:
1722         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1723         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1724
1725 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1726
1727         Reviewed by Sam.
1728
1729         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1730         dying and vice versa.
1731         - This fix will allow Drosera and Safari to reconnect if either of them
1732         closes correctly, but does not fix the case where one of them dies
1733         silently.
1734
1735         * Drosera/win/ServerConnection.cpp:
1736         (ServerConnection::attemptToCreateServerConnection): Added a safety
1737         check, because it's possilbe to try to connect to a server that's dying.
1738         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1739         the server has died.
1740         * Drosera/win/ServerConnection.h: Added the new function and removed
1741         an unnecessary member.
1742
1743 2007-11-29  Anders Carlsson  <andersca@apple.com>
1744
1745         * DumpRenderTree/win/DumpRenderTree.vcproj:
1746         Add shlwapi.lib to all configurations.
1747
1748 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1749
1750         - Build fix.  Added additional includes for VS Express to the Release
1751         project.
1752
1753         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1754
1755 2007-11-29  Anders Carlsson  <andersca@apple.com>
1756
1757         Reviewed by Adam.
1758
1759         <rdar://problem/5132005>
1760         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1761         
1762         * DumpRenderTree/win/DumpRenderTree.vcproj:
1763         Add shlwapi.lib
1764         
1765         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1766         (LayoutTestController::setUserStyleSheetEnabled):
1767         Implement this.
1768         
1769         (appendComponentToPath):
1770         New method which wraps the Win32 API PathAppend.
1771         
1772         (followShortcuts):
1773         New method which checks if a file points to a shortcut and
1774         follows the shortcut.
1775         
1776         (resolveCygwinPath):
1777         New method that takes a cygwin unix-style path and returns the Win32 path.
1778         
1779         (cfStringRefToWString):
1780         
1781         (LayoutTestController::setUserStyleSheetLocation):
1782         Implement this.
1783
1784 2007-11-29  Alice Liu  <alice.liu@apple.com>
1785
1786         Reviewed by Adam.
1787
1788         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1789
1790         * DumpRenderTree/win/EventSender.cpp:
1791         (keyDownCallback):
1792         uppercase letters were being sent as lowercase letters without the shift key down.
1793
1794 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1795
1796         - Windows build fix. VS express needs some love.
1797
1798         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1799
1800 2007-11-28  Darin Adler  <darin@apple.com>
1801
1802         Reviewed by Adam Roben.
1803
1804         * DumpRenderTree/mac/EventSendingController.mm:
1805         (-[EventSendingController keyDown:withModifiers:]):
1806         Send capital letters through as lowercase letters with the shift key down
1807         rather than sending them as if they were highly unusual "capital letter keys".
1808
1809         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1810         where you need to update results and more tests are failing than before.
1811
1812 2007-11-28  Anders Carlsson  <andersca@apple.com>
1813
1814         Reviewed by Darin.
1815
1816         <rdar://problem/5132001>
1817         contextClick is not implemented in DRT on Windows.
1818         
1819         * DumpRenderTree/win/EventSender.cpp:
1820         (contextClickCallback):
1821         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1822         by a WM_RBUTTONUP message.
1823         
1824         * DumpRenderTree/win/UIDelegate.cpp:
1825         (UIDelegate::hasCustomMenuImplementation):
1826         (UIDelegate::trackCustomPopupMenu):
1827         * DumpRenderTree/win/UIDelegate.h:
1828         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1829         menu from being shown (and causing the DRT to hang).
1830
1831 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1832
1833         Reviewed by Darin.
1834
1835         Fix DumpRenderTree ObjC bug comparing strings.
1836
1837         * DumpRenderTree/mac/ObjCController.m:
1838         (-[ObjCController identityIsEqual::]): Compare strings with string
1839         equality instead of identiy equality.
1840
1841 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1842
1843         Reviewed by Sam.
1844
1845         Reset the authorAndUserStylesEnabled preference
1846         back to YES for each test. Fixes the broken tests.
1847
1848         * DumpRenderTree/mac/DumpRenderTree.mm:
1849         (resetWebViewToConsistentStateBeforeTesting):
1850
1851 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1852
1853         Reviewed by Adam.
1854
1855         - Drosera now displays the console window, although it cannot currently
1856         process JavaScript.
1857
1858         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1859         (registerConsoleClass): Implemented.
1860         (consoleWndProc): Implemented.
1861         (DebuggerClient::onSize): Implemented.
1862         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1863         new window.
1864         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1865         creating and maintaining a new window.
1866         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1867         lines of code to more appropriate places.
1868         (Drosera::handleCommand):
1869         (Drosera::initUI):
1870         (Drosera::onSize):
1871         (Drosera::attach):
1872
1873 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1874
1875         Reviewed by Dave Hyatt.
1876
1877         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1878         
1879         Add support for disabling author and user styles for testing.
1880
1881         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1882         * DumpRenderTree/LayoutTestController.cpp:
1883         (setAuthorAndUserStylesEnabledCallback):
1884         (LayoutTestController::staticFunctions):
1885         * DumpRenderTree/LayoutTestController.h:
1886         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1887         (LayoutTestController::setAuthorAndUserStylesEnabled):
1888         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1889         (LayoutTestController::setAuthorAndUserStylesEnabled):
1890
1891 2007-11-26  Dan Bernstein  <mitz@apple.com>
1892
1893         - Tiger build fix.
1894
1895         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1896
1897 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1898
1899         Reviewed by Maciej.
1900
1901         - Implemented displaying variables for Drosera on Win.
1902
1903         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1904         that retrieve variables to not hold onto the return value since it's
1905         not returned.  Also changed to use the new signatures of the retrieval
1906         functions.
1907         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1908         (DebuggerDocument::platformValueForScopeVariableNamed):
1909         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1910         (droseraWndProc):
1911
1912 2007-11-26  Sam Weinig  <sam@webkit.org>
1913
1914         Cleanup names of painting and repainting functions.
1915
1916         Reviewed by Adam Roben.
1917
1918         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1919         (drawSelectionRect): was drawSelectionRectIntoContext.
1920         (dumpWebViewAsPixelsAndCompareWithExpected):
1921         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1922         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1923         (paintWebView): was drawWebViewIntoContext.
1924         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1925
1926 2007-11-26  Sam Weinig  <sam@webkit.org>
1927
1928         Reviewed by Dan Bernstein.
1929
1930         - Leopard build fix
1931
1932         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1933
1934 2007-11-26  Sam Weinig  <sam@webkit.org>
1935
1936         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1937         Use shared PixelDumpSupport for Mac DRT
1938
1939         Reviewed by Adam Roben.
1940
1941         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1942         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1943         * DumpRenderTree/cg/ImageDiffCG.cpp:
1944         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1945         (drawSelectionRectIntoContext):
1946         (dumpWebViewAsPixelsAndCompareWithExpected):
1947         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1948         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1949         * DumpRenderTree/mac/DumpRenderTree.mm:
1950         (dump):
1951         * DumpRenderTree/mac/ImageDiff.m: Removed.
1952         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1953         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1954         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1955         (setDefaultColorProfileToRGB):
1956         (getBitmapContextFromWebView):
1957         (drawWebViewIntoContext):
1958         (repaintWithVerticalSweep):
1959         (repaintWithHorizontalSweep):
1960         (getSelectionRect):
1961         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1962
1963 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1964
1965         Bug 16052: prepare-ChangeLog doesn't report deleted files
1966         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1967
1968         Reviewed by Sam.
1969
1970         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1971
1972 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1973
1974         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1975         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1976
1977         Reviewed by Adam.
1978
1979         Roll functionality of merge-changelog into resolve-ChangeLogs
1980         script.  The script now checks for ChangeLog.rej and
1981         ChangeLog.orig files first.  If it finds them, it uses the
1982         ChangeLog.rej file as a patch (in old contextual diff format) to
1983         apply with --fuzz=3.
1984
1985         * Scripts/merge-changelog: Removed.
1986         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1987
1988 2007-11-25  Sam Weinig  <sam@webkit.org>
1989
1990         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1991
1992         Reviewed by Mark Rowe.
1993
1994         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1995         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1996         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1997         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1998         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1999
2000 2007-11-25  Sam Weinig  <sam@webkit.org>
2001
2002         Convert DumpRenderTree to ues .xcconfig files.
2003
2004         Reviewed by Mark Rowe.
2005
2006         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2007         * DumpRenderTree/mac/Configurations: Added.
2008         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2009         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2010         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2011
2012 2007-11-25  Sam Weinig  <sam@webkit.org>
2013
2014         Add ForwardingHeaders to wtf for DumpRenderTree.
2015
2016         Reviewed by Mark Rowe.
2017
2018         * DumpRenderTree/DumpRenderTree.h:
2019         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2020         * DumpRenderTree/ForwardingHeaders: Added.
2021         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2022         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2023         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2024         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2025         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2026         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2027         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2028         * DumpRenderTree/LayoutTestController.cpp:
2029         * DumpRenderTree/WorkQueue.cpp:
2030         * DumpRenderTree/mac/DumpRenderTree.mm:
2031         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2032         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2033         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2034         * DumpRenderTree/mac/ObjCController.m:
2035         * DumpRenderTree/mac/UIDelegate.mm:
2036         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2037
2038 2007-11-25  Adam Roben  <aroben@apple.com>
2039
2040         Fix some test failures caused by r28019
2041
2042         Now that stdout is in binary mode, we need to always use printf
2043         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2044         the output.
2045
2046         Reviewed by Sam.
2047
2048         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2049         printf.
2050         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2051         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2052         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2053         (UIDelegate::webViewAddMessageToConsole):
2054
2055 2007-11-25  Adam Roben  <aroben@apple.com>
2056
2057         Set the font smoothing preference in DRT
2058
2059         This makes the pixel results on Windows closer to the Mac results.
2060
2061         Reviewed by Mitz.
2062
2063         * DumpRenderTree/win/DumpRenderTree.cpp:
2064         (initializePreferences):
2065
2066 2007-11-25  Adam Roben  <aroben@apple.com>
2067
2068         Port ImageDiff to CG and C++
2069
2070         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2071         <rdar://5071708>
2072
2073         Reviewed by Sam.
2074
2075         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2076         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2077         (main):
2078         (createImageFromStdin):
2079         (compareImages):
2080         (getDifferenceBitmap):
2081         (computePercentageDifferent):
2082         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2083
2084 2007-11-25  Adam Roben  <aroben@apple.com>
2085
2086         Fix image diff link generation on Windows
2087
2088         Reviewed by Sam.
2089
2090         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2091         to toURL.
2092
2093 2007-11-25  Adam Roben  <aroben@apple.com>
2094
2095         Implement pixel dumping in Windows DRT
2096
2097         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2098         <rdar://5071708>
2099
2100         Reviewed by Sam.
2101
2102         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2103         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2104         Content-Length header.
2105         (getMD5HashStringForBitmap):
2106         (dumpWebViewAsPixelsAndCompareWithExpected):
2107         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2108         * DumpRenderTree/win/DumpRenderTree.cpp:
2109         (dump): Do a pixel dump if requested.
2110         (main): Parse pixel test options.
2111         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2112         the cg/ subdirectory to the include path.
2113         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2114         available in a header or import library, so we have to go through this
2115         LoadLibrary/GetProcAddress dance to use them.
2116         (cryptDLL):
2117         (init):
2118         (update):
2119         (final):
2120         (MD5_Init):
2121         (MD5_Update):
2122         (MD5_Final):
2123         * DumpRenderTree/win/MD5.h: Added.
2124         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2125         moved up to the top level to share it with Mac eventually.
2126         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2127         (getBitmapContextFromWebView): Forces the WebView to paint using a
2128         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2129
2130 2007-11-25  Adam Roben  <aroben@apple.com>
2131
2132         Clean up Windows DRT's option parsing a little bit
2133
2134         Reviewed by Sam.
2135
2136         * DumpRenderTree/win/DumpRenderTree.cpp:
2137         (main): Put non-option arguments into a Vector.
2138
2139 2007-11-25  Adam Roben  <aroben@apple.com>
2140
2141         Make Windows DRT stop changing LF into CRLF
2142
2143         Reviewed by Sam.
2144
2145         * DumpRenderTree/win/DumpRenderTree.cpp:
2146         (main): Put stdout in binary mode.
2147         * Scripts/run-webkit-tests: Remove the CRLF hack.
2148
2149 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2150
2151         Removed empty directory.
2152
2153         * Scripts/resources: Removed.
2154
2155 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2156
2157         Fix bisect-builds to work with recent WebKit nightly builds.
2158
2159         Reviewed by Dan.
2160
2161         * Scripts/bisect-builds: Check for the 
2162         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2163         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2164         to WebKit.app/Contents/Resources.
2165
2166 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2167
2168         Reviewed by Maciej.
2169
2170         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2171         not closed (affects digg.com)
2172
2173         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2174         one after finishing with a test to avoid having its delayed onload handler firing when
2175         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2176         but it helps somewhat.
2177
2178 2007-11-22  Mark Rowe  <mrowe@apple.com>
2179
2180         Reviewed by Alp Toker.
2181
2182         Fix build-webkit to propagate make's exit status if it fails.
2183
2184         * Scripts/webkitdirs.pm:
2185
2186 2007-11-22  Dan Bernstein  <mitz@apple.com>
2187
2188         Reviewed by Mark Rowe.
2189
2190         - fix crash when running pixel tests
2191
2192         * DumpRenderTree/mac/DumpRenderTree.mm:
2193         (dumpRenderTree): Parse the command line options before setting up the
2194         environment so that we know if we need to set up the pixel dump
2195         machinery.
2196
2197 2007-11-21  Eric Seidel  <eric@webkit.org>
2198
2199         Speculative build fix for Tiger.
2200
2201         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2202
2203 2007-11-21  Eric Seidel  <eric@webkit.org>
2204
2205         Reviewed by Tim Hatcher.
2206
2207         Break out more of DumpRenderTree.mm into individual files
2208
2209         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2210         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2211         (checkedMalloc):
2212         (checkedRealloc):
2213         (makeLargeMallocFailSilently):
2214         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2215         * DumpRenderTree/mac/DumpRenderTree.mm:
2216         (crashHandler):
2217         (dump):
2218         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2219         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2220         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2221         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2222         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2223         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2224         (javaScriptThreads):
2225         (runJavaScriptThread):
2226         (startJavaScriptThreads):
2227         (stopJavaScriptThreads):
2228         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2229         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2230         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2231         (restoreColorSpace):
2232         (setDefaultColorProfileToRGB):
2233         (initializeColorSpaceAndScreeBufferForPixelTests):
2234         (md5HashStringForBitmap):
2235         (dumpWebViewAsPixelsAndCompareWithExpected):
2236
2237 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2238
2239         Move install-unix-extras to wx directory as it seems only to be used by that 
2240         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2241         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2242         have install-unix-extras install into WebKitLibraries as per
2243         convention.
2244         
2245         Reviewed by Mark Rowe.
2246
2247         * Scripts/install-unix-extras: Removed.
2248         * wx/build-wxwebkit:
2249         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2250
2251 2007-11-21  Eric Seidel  <eric@webkit.org>
2252
2253         Reviewed by Adam.
2254
2255         More refactoring for greater code readability
2256
2257         * DumpRenderTree/mac/DumpRenderTree.mm:
2258         (initializeGlobalsFromCommandLineOptions):
2259         (initializeColorSpaceAndScreeBufferForPixelTests):
2260         (addTestPluginsToPluginSearchPath):
2261         (useLongRunningServerMode):
2262         (runTestingServerLoop):
2263         (prepareConsistentTestingEnvironment):
2264         (dumpRenderTree):
2265         (main):
2266         (dumpFramesAsText):
2267         (dumpBackForwardListForWebView):
2268         (sizeWebViewForCurrentTest):
2269         (methodNameStringForFailedTest):
2270         (dumpBackForwardListForAllWindows):
2271         (dumpWebViewAsPixelsAndCompareWithExpected):
2272         (invalidateAnyPreviousWaitToDumpWatchdog):
2273         (dump):
2274         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2275         * DumpRenderTree/mac/UIDelegate.mm:
2276         (-[UIDelegate webView:createWebViewWithRequest:]):
2277
2278 2007-11-21  Eric Seidel  <eric@webkit.org>
2279
2280         Reviewed by Tim Hatcher.
2281
2282         Abstract more of DRT into static methods
2283
2284         * DumpRenderTree/mac/DumpRenderTree.mm:
2285         (setDefaultsToConsistentValuesForTesting):
2286         (setupSignalHandlers):
2287         (allocateGlobalControllers):
2288         (releaseAndZero):
2289         (releaseGlobalControllers):
2290         (dumpRenderTree):
2291         (shouldLogFrameLoadDelegates):
2292         (createCFURLFromPathOrURL):
2293         (resetWebViewToConsistentStateBeforeTesting):
2294         (runTest):
2295
2296 2007-11-21  Eric Seidel  <eric@webkit.org>
2297
2298         Reviewed by Tim Hatcher.
2299
2300         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2301
2302         * DumpRenderTree/DumpRenderTree.h:
2303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2304         * DumpRenderTree/mac/DumpRenderTree.mm:
2305         (dumpRenderTree):
2306         (dump):
2307         (runTest):
2308         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2309         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2310         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2311         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2312         (-[DumpRenderTreePasteboard declareType:owner:]):
2313         (+[LocalPasteboard alloc]):
2314         (-[LocalPasteboard init]):
2315         (-[LocalPasteboard dealloc]):
2316         (-[LocalPasteboard name]):
2317         (-[LocalPasteboard releaseGlobally]):
2318         (-[LocalPasteboard declareTypes:owner:]):
2319         (-[LocalPasteboard addTypes:owner:]):
2320         (-[LocalPasteboard changeCount]):
2321         (-[LocalPasteboard types]):
2322         (-[LocalPasteboard availableTypeFromArray:]):
2323         (-[LocalPasteboard setData:forType:]):
2324         (-[LocalPasteboard dataForType:]):
2325         (-[LocalPasteboard setPropertyList:forType:]):
2326         (-[LocalPasteboard setString:forType:]):
2327         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2328         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2329         (+[DumpRenderTreeWindow allWindows]):
2330         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2331         (-[DumpRenderTreeWindow dealloc]):
2332         (-[DumpRenderTreeWindow isKeyWindow]):
2333         (-[DumpRenderTreeWindow keyDown:]):
2334
2335 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2336
2337         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2338         it indiscriminately copies any headers inside JavaScriptCore,
2339         which includes Tiger ICU headers. 
2340
2341         * wx/build-wxwebkit:
2342         Don't run WebCore/move-js-headers.sh any longer.
2343
2344 2007-11-20  Adam Treat  <treat@kde.org>
2345
2346         Reviewed by David Kilzer.
2347
2348         * Prepend git branch name to $baseProductDir
2349
2350         * Scripts/VCSUtils.pm:
2351         * Scripts/webkitdirs.pm:
2352
2353 2007-11-20  Mark Rowe  <mrowe@apple.com>
2354
2355         Reviewed by Simon Hausmann.
2356
2357         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2358         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2359         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2360         built product and generated Makefile's are removed.
2361
2362 2007-11-19  Alp Toker  <alp@atoker.com>
2363
2364         Reviewed by Mark Rowe.
2365
2366         http://bugs.webkit.org/show_bug.cgi?id=16040
2367         [GTK] GtkLauncher should be written in C
2368
2369         Port GtkLauncher to plain C.
2370
2371         Use a more conventional GTK+ coding style.
2372
2373         Use a toolbar instead of menus.
2374
2375         Various signature fixes and cleanups.
2376
2377         Add a license header. Assume all previous modifications were copyright
2378         assigned to Apple Inc. by default.
2379
2380         * GtkLauncher/GtkLauncher.pro:
2381         * GtkLauncher/main.c: Added.
2382         (activate_url_entry_cb):
2383         (update_title):
2384         (link_hover_cb):
2385         (title_change_cb):
2386         (progress_change_cb):
2387         (destroy_cb):
2388         (go_back_cb):
2389         (go_forward_cb):
2390         (create_browser):
2391         (create_statusbar):
2392         (create_toolbar):
2393         (create_window):
2394         (main):
2395         * GtkLauncher/main.cpp: Removed.
2396
2397 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2398
2399         Build script fixes to ensure they do the right thing for the 
2400         wx port, and update build-wxwebkit to reflect the way the
2401         build scripts now work.
2402
2403         Reviewed by Adam.
2404
2405         * Scripts/build-testkjs:
2406         * Scripts/build-webkit:
2407         * Scripts/run-javascriptcore-tests:
2408         * Scripts/webkitdirs.pm:
2409         * wx/build-wxwebkit:
2410
2411 2007-11-18  Eric Seidel  <eric@webkit.org>
2412
2413         Reviewed by Anders.
2414
2415         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2416
2417         * Scripts/run-javascriptcore-tests:
2418
2419 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2420
2421         Reviewed by Adam Roben.
2422
2423         Make run-webkit-tests work with Windows debug build.
2424
2425         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2426         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2427         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2428         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2429         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2430
2431 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2432
2433         Add wxWebKit sample and build script, and integrate it with 
2434         build-webkit. Also make build-webkit --clean work for all
2435         ports.
2436
2437         Reviewed by Darin Adler.
2438
2439         * Scripts/build-webkit:
2440         * Scripts/webkitdirs.pm:
2441         * wx: Added.
2442         * wx/browser: Added.
2443         * wx/browser/browser.bkl: Added.
2444         * wx/browser/browser.cpp: Added.
2445         * wx/build-wxwebkit: Added.
2446
2447 2007-11-17  Adam Roben  <aroben@apple.com>
2448
2449         Make it easy to run Safari in the debugger on Windows
2450
2451         I've added a new script, debug-safari, which launches Safari in the
2452         debugger. On OS X it just calls gdb-safari.
2453
2454         Reviewed by Mark Rowe.
2455
2456         * FindSafari/FindSafari.cpp:
2457         (_tmain): Added a /debugger flag, which in combination with
2458         /printSafariLauncher will print a script that launches Safari in the
2459         debugger.
2460         * Scripts/debug-safari: Added.
2461         * Scripts/run-safari: Changed to call runSafari().
2462         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2463         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2464         first argument along to FindSafari.
2465         * Scripts/webkitdirs.pm:
2466         (sub runSafari): Added.
2467
2468 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2469
2470         Reviewed by Adam Roben.
2471
2472         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2473
2474 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2475
2476         Reviewed by David Kilzer.
2477
2478         The git config command was renamed to repo-config at some point. This
2479         change tries git config and then git repo-config if the first fails.
2480
2481         * Scripts/prepare-ChangeLog:
2482         (gitConfig):
2483
2484 2007-11-16  Dan Bernstein  <mitz@apple.com>
2485
2486         Reviewed by Darin Adler and Sam Weinig.
2487
2488         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2489
2490         * DumpRenderTree/win/EventSender.cpp:
2491         (keyDownCallback): For characters that cannot be entered on the active
2492         keyboard layout, send a WM_CHAR message with the character along with
2493         a WM_KEYDOWN message with a virtual key code of 255.
2494
2495 2007-11-16  Mark Rowe  <mrowe@apple.com>
2496
2497         Reviewed by Tim Hatcher.
2498
2499         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2500
2501         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2502         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2503
2504 2007-11-15  Adam Roben  <aroben@apple.com>
2505
2506         Make run-safari actually work on Windows
2507
2508         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2509         chdir call.
2510
2511 2007-11-14  Adam Roben  <aroben@apple.com>
2512
2513         Updates to Safari launching now that 3.0.4 is released
2514
2515         Reviewed by Sam.
2516
2517         * FindSafari/FindSafari.cpp:
2518         (getWebViewCLSID): Use version-independent ProgID.
2519         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2520
2521 2007-11-14  Anders Carlsson  <andersca@apple.com>
2522
2523         Reviewed by Adam.
2524
2525         <rdar://problem/5309081>
2526         In DRT, "plugin.logDestroy = true" not working on Windows.
2527         
2528         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2529         (NPP_Destroy):
2530
2531 2007-11-14  Eric Seidel  <eric@webkit.org>
2532
2533         Reviewed by Sam.
2534
2535         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2536
2537 2007-11-14  Anders Carlsson  <andersca@apple.com>
2538
2539         Reviewed by Adam.
2540
2541         <rdar://problem/5141186>
2542         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2543         
2544         Implement setWindowIsKey.
2545         
2546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2547         (LayoutTestController::setWindowIsKey):
2548
2549 2007-11-13  Sam Weinig  <sam@webkit.org>
2550
2551         Reviewed by Adam Roben.
2552
2553         Fix for <rdar://problem/5382579>
2554         http/tests/security/cross-frame-access-put.html reports large 
2555         negative numbers for screenLeft and screenTop (Mac reports "0")
2556
2557         * DumpRenderTree/win/UIDelegate.cpp:
2558         (UIDelegate::UIDelegate): Initialize the RECT.
2559         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2560         (UIDelegate::webViewFrame): ditto.
2561         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2562
2563 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2564
2565         Reviewed by Adam.
2566
2567         - Make Drosera show source, source URLs, and function stack on Windows,
2568         and some minor fixes.
2569
2570         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2571         (DebuggerDocument::updateFileSource):
2572         * Drosera/debugger.js: Force source to always update display.
2573         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2574         menu controls.
2575         (DebuggerClient::resume):
2576         (DebuggerClient::pause):
2577         (DebuggerClient::stepInto):
2578         (DebuggerClient::stepOver):
2579         (DebuggerClient::stepOut):
2580         (DebuggerClient::showConsole):
2581         (DebuggerClient::closeCurrentFile):
2582         * Drosera/win/DebuggerClient.h: Ditto.
2583         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2584         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2585         removed two bugs.  1) caller could be in a bad state when asked to
2586         assign into it. 2) BSTRs were not created correctly.
2587         (DebuggerDocument::getPlatformCurrentFunctionStack):
2588         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2589         (droseraWndProc):
2590         (handleCommand):
2591         (Drosera::resume):
2592         (Drosera::pause):
2593         (Drosera::stepInto):
2594         (Drosera::stepOver):
2595         (Drosera::stepOut):
2596         (Drosera::showConsole):
2597         (Drosera::closeCurrentFile):
2598         * Drosera/win/Drosera.h: Hook up the menu controls.
2599         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2600         functions, added a null check, and fixed another bug where caller could
2601         be in a bad state when asked to assign into it.
2602         (ServerConnection::didLoadMainResourceForDataSource):
2603         (ServerConnection::getCallerFrame):
2604         * Drosera/win/ServerConnection.h: Safety first.
2605
2606 2007-11-13  Dan Bernstein  <mitz@apple.com>
2607
2608         Reviewed by Darin Adler.
2609
2610         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2611           DumpRenderTree --pixel-tests renders each test twice
2612
2613         * DumpRenderTree/mac/DumpRenderTree.mm:
2614         (dumpRenderTree): Removed the --paint option because the painting code
2615         is always exercised as a result of
2616         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2617         calling -displayIfNeeded.
2618         (dump): Changed to always grab the image from the window since the view
2619         is always displayed.
2620         (runTest):
2621         (displayWebView):
2622         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2623         because it always paints.
2624
2625 2007-11-12  Antti Koivisto  <antti@apple.com>
2626
2627         Reviewed by Adele.
2628         
2629         Add support for http media tests
2630
2631         * Scripts/run-webkit-tests:
2632
2633 2007-11-12  Sam Weinig  <sam@webkit.org>
2634
2635         Reviewed by Adam Roben.
2636
2637         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2638
2639         * DumpRenderTree/win/DumpRenderTree.cpp:
2640         (runTest):
2641         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2642         (LayoutTestController::setPrivateBrowsingEnabled):
2643
2644 2007-11-12  Adam Roben  <aroben@apple.com>
2645
2646         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2647         mac and win subdirectories.
2648
2649 2007-11-11  Adam Roben  <aroben@apple.com>
2650
2651         Fix <rdar://5133816> keepWebHistory is not implemented
2652
2653         Fixes fast/history/clicked-link-is-visited.html.
2654
2655         Reviewed by Darin.
2656
2657         * DumpRenderTree/win/DumpRenderTree.cpp:
2658         (runTest): Clear the optionalSharedHistory.
2659         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2660         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2661
2662 2007-11-10  Sam Weinig  <sam@webkit.org>
2663
2664         Reviewed by Tim Hatcher.
2665
2666         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2667         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2668         is turned on)
2669
2670         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2671
2672         Added test: http/tests/security/cross-frame-access-private-browsing.html
2673
2674         * DumpRenderTree/LayoutTestController.cpp:
2675         (setPrivateBrowsingEnabledCallback):
2676         (LayoutTestController::staticFunctions):
2677         * DumpRenderTree/LayoutTestController.h:
2678         * DumpRenderTree/mac/DumpRenderTree.mm:
2679         (runTest): Default to private browsing disabled.
2680         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2681         (LayoutTestController::setPrivateBrowsingEnabled):
2682         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2683         (LayoutTestController::setPrivateBrowsingEnabled):
2684
2685 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2686
2687         Reviewed by Adam.
2688
2689         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2690         WebCore's!
2691
2692         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2693         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2694         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2695         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2696         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2697         * Drosera/win/Drosera.cpp:
2698         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2699
2700 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2701
2702         Reviewed by Sam.
2703
2704         - Use the new IWebFrame [local] function signature and get the shared
2705         server correctly.
2706
2707         * Drosera/win/DebuggerClient.cpp:
2708         (DebuggerClient::didFinishLoadForFrame):
2709         * Drosera/win/ServerConnection.cpp:
2710         (ServerConnection::attemptToCreateServerConnection):
2711
2712 2007-11-07  Dan Bernstein  <mitz@apple.com>
2713
2714         Reviewed by Darin Adler.
2715
2716         - add an option to run-webkit-tests to ignore pixel test failures where
2717           all pixels differ by no more than a specified threshold
2718
2719         * DumpRenderTree/mac/ImageDiff.m:
2720         (main):
2721         (compareImages):
2722         (computePercentageDifferent):
2723         * Scripts/run-webkit-tests:
2724
2725 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2726
2727         Reviewed by Lars.
2728
2729         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2730
2731         * DumpRenderTree/qt/DumpRenderTree.cpp:
2732
2733 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2734
2735         Reviewed by Lars.
2736
2737         Reworked the QWebSettings API.
2738         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2739
2740         * DumpRenderTree/qt/DumpRenderTree.cpp:
2741
2742 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2743
2744         Reviewed by Lars.
2745
2746         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2747
2748         * DumpRenderTree/qt/jsobjects.cpp:
2749
2750 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2751
2752         Reviewed by Lars Knoll <lars@trolltech.com>.
2753
2754         Add a QWebPage::frameCreated() signal and fix DRT
2755         
2756         The removal of createFrame in QWebPage broke the re-implementation
2757         in DumpRenderTree. Instead emit a frameCreated() signal and
2758         connect to it in DumpRenderTree.
2759         
2760
2761         * DumpRenderTree/qt/DumpRenderTree.cpp:
2762         (WebCore::WebPage::WebPage):
2763         (WebCore::DumpRenderTree::dump):
2764         (WebCore::DumpRenderTree::connectFrame):
2765         * DumpRenderTree/qt/DumpRenderTree.h:
2766
2767 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2768
2769         Reviewed by Lars Knoll <lars@trolltech.com>.
2770
2771         Moved all the event handlers from QWebFrame into QWebPage.
2772         
2773         This cleans up the public API and allows us to remove the
2774         HackWebFrame hack in DumpRenderTree.
2775         
2776
2777         * DumpRenderTree/qt/jsobjects.cpp:
2778         (EventSender::mouseDown):
2779         (EventSender::mouseUp):
2780         (EventSender::mouseMoveTo):
2781
2782 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2783
2784         Reviewed by Mark.
2785
2786         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2787         to prevent the default implementation from popping up messageboxes.
2788
2789         * DumpRenderTree/qt/DumpRenderTree.cpp:
2790         (WebCore::WebPage::javaScriptConfirm):
2791         (WebCore::WebPage::javaScriptPrompt):
2792
2793 2007-11-06  Eric Seidel  <eric@webkit.org>
2794
2795         * Scripts/build-testkjs: build fix... too many $$
2796
2797 2007-11-06  Eric Seidel  <eric@webkit.org>
2798
2799         Reviewed by Mark Rowe.
2800
2801         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2802
2803 2007-11-05  Adam Roben  <aroben@apple.com>
2804
2805         Add support on Windows for WEBKIT_TESTFONTS
2806
2807         This environment variable lets you specify where the fonts to be used
2808         by DumpRenderTree reside. The Qt port is already using this, so I'm
2809         just following their lead.
2810
2811         Reviewed by Darin.
2812
2813         * DumpRenderTree/win/DumpRenderTree.cpp:
2814         (exePath): Refactored code out of initialize().
2815         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2816         DumpRenderTree.resources.
2817         (initialize): Use the new fontsPath function.
2818         (main): Use the new exePath function.
2819         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2820         variable to DRT, like Qt does.
2821
2822 2007-11-05  Mark Rowe  <mrowe@apple.com>
2823
2824         Rubber-stamped by Alp Toker.
2825
2826         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2827
2828         * GtkLauncher/main.cpp:
2829         (goToURLBarText):
2830         (main):
2831
2832 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2833
2834         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2835         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2836
2837         Reviewed by Timothy.
2838
2839         Restrict the range of nightly builds used by the bisect-builds script
2840         based on the version of Safari and the version of Mac OS X being used.
2841
2842         Mac OS X 10.4: Safari 2.0: r11976 or newer
2843         Mac OS X 10.4: Safari 3.0: r19992 or newer
2844
2845         Mac OS X 10.5: Safari 2.0: r19594 or newer
2846         Mac OS X 10.5: Safari 3.0: r25124 or newer
2847
2848         * Scripts/bisect-builds:
2849         (findMacOSXVersion): Added.
2850         (makeNightlyList): Added argument to provide version of Mac OS X.
2851         Restrict range of nightly builds based on Safari and Mac OS X versions.
2852
2853 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2854
2855         Reviewed by Maciej.
2856
2857         - This patch involves several changes, all of them were noticed that
2858         they were needed by the work being done in WebKit to get Drosera and
2859         WebKit working together on Windows.
2860         - The changes are:
2861         1) Added a debugger console for output messages.
2862         2) Drosera now listens for the WebKit server (before, the server would
2863         have to be running before Drosera was started.)
2864         3) Fixed a bug where the WebView started out as 0x0 pixels.
2865         4) Fixed a bug when there is no scope.
2866         5) Added the HTML, JS, and CSS to the project file to make them easy to
2867         find.
2868         6) Made the ServerConnection functions virtual.
2869
2870         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2871         for the WebKit server.
2872         (DebuggerClient::DebuggerClient):
2873         (DebuggerClient::~DebuggerClient):
2874         (DebuggerClient::didFinishLoadForFrame):
2875         (DebuggerClient::serverConnected):
2876         (DebuggerClient::attemptToCreateServerConnection):
2877         * Drosera/win/DebuggerClient.h: Ditto.
2878         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2879         scope.
2880         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2881         (DebuggerDocument::platformValueForScopeVariableNamed):
2882         * Drosera/win/Drosera.cpp:
2883         (_tWinMain): Added a console in debug for output messages.
2884         (Drosera::Drosera): Listen for server.
2885         (Drosera::initUI): The server now Initializes COM.
2886         (Drosera::serverConnected): Part of the listening for the server.
2887         (Drosera::attemptToCreateServerConnection): Ditto.
2888         * Drosera/win/Drosera.h: New interface for listening for the server.
2889         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2890         files to the VS project.
2891         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2892         connection.
2893         (ServerConnection::ServerConnection):
2894         (ServerConnection::attemptToCreateServerConnection):
2895         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2896         methods.
2897         (ServerConnection::serverConnected):
2898
2899 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2900
2901         Reviewed by Maciej.
2902
2903         http://bugs.webkit.org/show_bug.cgi?id=15832
2904         fast/dom/gc-10.html crashes when run alone
2905
2906         Check for !done before using objects that can be already deallocated.
2907
2908         * DumpRenderTree/mac/EditingDelegate.mm:
2909         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2910         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2911         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2912         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2913         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2914         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2915         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2916         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2917         (-[EditingDelegate webViewDidBeginEditing:]):
2918         (-[EditingDelegate webViewDidChange:]):
2919         (-[EditingDelegate webViewDidEndEditing:]):
2920         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2921         (-[EditingDelegate webViewDidChangeSelection:]):
2922         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2923         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2924         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2925         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2926         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2927         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2928         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2929         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2930         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2931         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2932         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2933         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2934         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2935         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2936         (-[FrameLoadDelegate webView:willCloseFrame:]):
2937         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2938         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2939         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2940         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2941         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2942         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2943         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2944         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2945         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2946
2947 2007-11-04  Mark Rowe  <mrowe@apple.com>
2948
2949         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2950         warnings that would otherwise be suppressed due to it being a system header.
2951
2952         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2953
2954 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2955
2956         Rubber stamped by Adam.
2957         
2958         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2959
2960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2961
2962 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2963
2964         Sort files(...); sections of Xcode project files.
2965
2966         Rubber-stamped by Darin.
2967
2968         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2969         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2970         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2971         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2972
2973 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2974
2975         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2976
2977         Reviewed by Darin.
2978
2979         * Scripts/sort-Xcode-project-file: Added.
2980
2981 2007-11-02  Darin Adler  <darin@apple.com>
2982
2983         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2984
2985 2007-11-02  Darin Adler  <darin@apple.com>
2986
2987         Reviewed by Maciej.
2988
2989         * Scripts/run-sunspider: Pass the "--base" option through.
2990
2991         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2992         the real script do that. Default configuration to Release to match run-sunspider
2993         so we don't end up building Debug just to compare results.
2994
2995 2007-11-01  Adam Roben  <aroben@apple.com>
2996
2997         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2998
2999         Reviewed by Sam.
3000
3001         * Scripts/commit-log-editor: Show all the directories beneath the
3002         source root, instead of just the last one.
3003
3004 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3005
3006         Reviewed by Adam Roben.
3007
3008         Print out an error message when the Windows build fails
3009         and provide guidance on how to find out what went wrong.
3010
3011         * Scripts/build-webkit:
3012         * Scripts/webkitdirs.pm:
3013
3014 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3015
3016         Rubber-stamped by Adam Roben.
3017
3018         Rolled out r27326 - debug CRT seems to cause no problems after all.
3019
3020         * DumpRenderTree/win/DumpRenderTree.vcproj:
3021
3022 2007-10-31  Adam Roben  <aroben@apple.com>
3023
3024         Switch the Debug configuration to using the non-debug CRT
3025
3026         This matches WebKit.
3027
3028         Reviewed by Steve.
3029
3030         * DumpRenderTree/win/DumpRenderTree.vcproj:
3031
3032 2007-10-31  Antti Koivisto  <antti@apple.com>
3033
3034         Reviewed by bdash.
3035         
3036         Disable media tests when doing leak checking on Tiger.
3037         They crash in QuickTime (rdar://problem/5537157).
3038
3039         * Scripts/run-webkit-tests:
3040
3041 2007-10-29  Antti Koivisto  <antti@apple.com>
3042
3043         Reviewed by Maciej.
3044         
3045         Build media support by default on OSX only.
3046
3047         * Scripts/build-webkit:
3048
3049 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3050
3051         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3052         get caught by the pre-commit hooks.
3053
3054 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3055
3056         Reviewed by Adam.
3057
3058         - This is a collection of relatively unrelated changes and cleanups
3059         to Drosera to prepare it for interacting with WebKit.  A lot of these
3060         changes are just correcting mistakes, for example removing included
3061         headers that are no longer needed.
3062
3063         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3064         this will be needed by the DebuggerClient.
3065         (DebuggerDocument::server):
3066         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3067         * Drosera/win/DebuggerClient.cpp: 
3068         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3069         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3070         (DebuggerClient::createWebViewWithRequest): Added comment about its
3071         purpose. 
3072         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3073         declarations.
3074         (DebuggerClient::webViewLoaded): Moved.
3075         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3076         file, since this was the only place it was used.
3077         (cfStringToBSTR):
3078         * Drosera/win/Drosera.h: Cleaned up the includes.
3079         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3080         * Drosera/win/HelperFunctions.h: Removed.
3081
3082 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3083
3084         Reviewed by Adam.
3085
3086         - Small cleanup in the ServerConnection class.
3087
3088         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3089         and added an include.
3090         (ServerConnection::currentFrame):
3091         (ServerConnection::getCallerFrame):
3092         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3093         made a pointer into a COMPtr, and cleaned up the includes.
3094
3095 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3096
3097         Reviewed by John Sullivan.
3098         
3099         - Place the Localizable.strings file in mac or win directories
3100           if that location exists.
3101         - Also look for UI_STRING in .c files.
3102
3103         * Scripts/extract-localizable-strings:
3104
3105 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3106
3107         Reviewed by Adam.
3108
3109         - Set the eol-style to native and made all the line endings the same
3110         so that I avoid messy diffs that show eol changes.
3111
3112         * Drosera/win/ServerConnection.cpp:
3113         (ServerConnection::didParseSource):
3114         (ServerConnection::didEnterCallFrame):
3115         (ServerConnection::willExecuteStatement):
3116         (ServerConnection::willLeaveCallFrame):
3117         (ServerConnection::exceptionWasRaised):
3118
3119 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3120
3121         Reviewed by Adam.
3122
3123         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3124         functionality that could not have existed previously without the new
3125         interfaces.
3126         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3127         from a BSTR to a JSValueRef.
3128         (DebuggerDocument::platformEvaluateScript): Implemented.
3129         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3130         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3131         Implemented.
3132         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3133         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3134         * Drosera/win/ServerConnection.cpp: Added a helper function.
3135         (ServerConnection::getCallerFrame):
3136         * Drosera/win/ServerConnection.h: Added a helper function.
3137
3138 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3139
3140         updated reviewers for my previous changelog.
3141
3142 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3143         Reviewed by Maciej and Adam and Geoff.
3144
3145         - Minor mac-side improvements including moving a function to a more
3146         appropriate location, fixing a warning, and correctly checking
3147         exceptions.
3148
3149         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3150         (DebuggerDocument::willExecuteStatement):
3151         (DebuggerDocument::didEnterCallFrame):
3152         (DebuggerDocument::willLeaveCallFrame):
3153         (DebuggerDocument::windowScriptObjectAvailable):
3154         (DebuggerDocument::callFunctionOnObject):
3155         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3156         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3157         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3158         because it doesn't require the ServerConnection at all.
3159         (NSStringCreateWithJSStringRef): Made an argument const.
3160         (JSValueRefCreateWithNSString): Made an argument const.
3161         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3162         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3163         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3164         * Drosera/mac/ServerConnection.mm: Ditto.
3165         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3166
3167 2007-10-29  Sam Weinig  <sam@webkit.org>
3168
3169         Reviewed by Adam Roben.
3170
3171         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3172
3173         * DumpRenderTree/LayoutTestController.cpp:
3174         (LayoutTestController::LayoutTestController):
3175         (getGlobalFlagCallback):
3176         (setGlobalFlagCallback):
3177         (LayoutTestController::getJSClass):
3178         (LayoutTestController::staticValues):
3179         * DumpRenderTree/LayoutTestController.h:
3180         (LayoutTestController::globalFlag):
3181         (LayoutTestController::setGlobalFlag):
3182
3183 2007-10-29  Darin Adler  <darin@apple.com>
3184
3185         Reviewed by Maciej.
3186
3187         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3188         resolution instead of its default.
3189
3190 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3191
3192         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3193
3194         Reviewed by Mark Rowe.
3195
3196         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3197         was successfully resolved, but this would not show any status because the change had
3198         already been cached in the index using "git add".  The solution is to add an optional
3199         second argument to showStatus() which adds the "--cached" switch to the command.
3200
3201         * Scripts/resolve-ChangeLogs:
3202         (showStatus):
3203
3204 2007-10-28  Eric Seidel  <eric@webkit.org>
3205
3206         Reviewed by Maciej and Geoff, in unison.
3207
3208         * Scripts/run-webkit-tests: remove broken --svg option
3209
3210 2007-10-28  Darin Adler  <darin@apple.com>
3211
3212         Reviewed by Adam.
3213
3214         * Scripts/run-sunspider: Default to "Release" configuration rather than
3215         defaulting to the last configuration used as other scripts do. This can
3216         still be overriden on the command line with "--debug" if there's some
3217         reason to do so. Also fix a typo.
3218
3219         * Scripts/sunspider-compare-results: Fix a typo.
3220
3221 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3222
3223         Reviewed by Adam.
3224
3225         - Implemented the WebScriptDebugListener functions now that the
3226         WebScriptDebugServer exists
3227
3228         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3229         functions.
3230         (ServerConnection::currentFrame):
3231         (ServerConnection::didLoadMainResourceForDataSource):
3232         (ServerConnection::didParseSource):
3233         (ServerConnection::failedToParseSource):
3234         (ServerConnection::didEnterCallFrame):
3235         (ServerConnection::willExecuteStatement):
3236         (ServerConnection::willLeaveCallFrame):
3237         (ServerConnection::exceptionWasRaised):
3238         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3239         members arguments list.
3240
3241 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3242
3243         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3244         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3245
3246         Reviewed by Darin.
3247
3248         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3249         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3250         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3251         file.  Note that it may also be used as a stand-alone script.
3252
3253         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3254         * Scripts/resolve-ChangeLogs: Added.
3255         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3256
3257 2007-10-26  Mark Rowe  <mrowe@apple.com>
3258
3259         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3260         to the Qt port on the assumption that it was an implementation of the cross-platform
3261         LayoutTestController class.  It is not, so it did not need to be changed.
3262
3263         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3264
3265 2007-10-25  Mark Rowe  <mrowe@apple.com>
3266
3267         Reviewed by Maciej.
3268
3269         Fix builds with code coverage enabled.
3270
3271         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3272
3273 2007-10-25  Darin Adler  <darin@apple.com>
3274
3275         Reviewed by Mark Rowe.
3276
3277         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3278         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3279
3280 2007-10-25  Stephanie  <slewis@apple.com>
3281
3282         build Fix
3283
3284         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3285
3286 2007-10-25  Stephanie  <slewis@apple.com>
3287
3288         Reviewed by Mark Rowe, Adam Roben.
3289
3290         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3291
3292         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3293
3294 2007-10-25  Alice Liu  <alice.liu@apple.com>
3295
3296         Reviewed by Adam.
3297
3298         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3299
3300         Moving destructor into platform-specific files
3301         * DumpRenderTree/LayoutTestController.cpp:
3302         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3303         (LayoutTestController::~LayoutTestController):
3304         * DumpRenderTree/qt/jsobjects.cpp:
3305         (LayoutTestController::~LayoutTestController):
3306
3307         LayoutTestController wasn't being destroyed
3308         * DumpRenderTree/win/DumpRenderTree.cpp:
3309         (runTest):
3310
3311         Added declspec
3312         * DumpRenderTree/win/EditingDelegate.h:
3313
3314         Reset certain values on the webview (or related delegate) that might 
3315         have changed while running a test
3316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3317         (LayoutTestController::~LayoutTestController):
3318
3319 2007-10-25  Adam Roben  <aroben@apple.com>
3320
3321         Make sunspider-compare-results work with relative paths
3322
3323         Reviewed by Sam.
3324
3325         * Scripts/sunspider-compare-results: Convert arguments to absolute
3326         paths before we chdir.
3327
3328 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3329
3330         Reviewed by Sam.
3331
3332         - Implemented server calls now the WebScriptDebugServer exists.
3333         - Also removed no longer needed call to initialize CG.
3334
3335         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3336         automatically now.
3337         (_tWinMain):
3338         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3339         (ServerConnection::ServerConnection):
3340         (ServerConnection::~ServerConnection):
3341         (ServerConnection::pause):
3342         (ServerConnection::resume):
3343         (ServerConnection::stepInto):
3344         (ServerConnection::applicationTerminating):
3345         (ServerConnection::serverConnectionDidDie):
3346         * Drosera/win/ServerConnection.h: Now uses the COM class.
3347
3348 2007-10-24  George Staikos  <staikos@kde.org>
3349
3350         Unbreak Qt build.
3351
3352         * Scripts/build-webkit:
3353
3354 2007-10-24  Adam Roben  <aroben@apple.com>
3355
3356         Remove now-unnecessary call to InitializeCoreGraphics
3357
3358         WebKit takes care of this now.
3359
3360         Reviewed by Ada.
3361
3362         * DumpRenderTree/win/DumpRenderTree.cpp:
3363         (initialize):
3364
3365 2007-10-24  Adam Roben  <aroben@apple.com>
3366
3367         Use WebTextRenderer in DRT
3368
3369         Reviewed by Ada.
3370
3371         * DumpRenderTree/win/DumpRenderTree.cpp:
3372         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3373
3374 2007-10-24  Sven Herzberg  <sven@imendio.com>
3375
3376         Reviewed by Mark Rowe.
3377
3378         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3379         Bug 15614: [GTK] qmake based backends don't build on OS X
3380
3381         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3382         GTK backend on a Mac
3383         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3384         isDarwin() to make it reusable in other places (like the workaround-
3385         for-prebuilt-qmake in build-webkit)
3386
3387 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3388
3389         Refurbish update-webkit script.
3390
3391         Reviewed by Adam.
3392
3393         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3394         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3395         multi-argument version of system() for flexibility and security.  Check for existence
3396         of Internal directory using -d test instead of -x.
3397
3398 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3399
3400         Minor clean-up of prepare-ChangeLog script.
3401
3402         Reviewed by Adam.
3403
3404         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3405         of a string.  Use multi-argument versions of open() and system() for flexibility and
3406         security.
3407
3408 2007-10-24  Alice Liu  <alice.liu@apple.com>
3409
3410         Reviewed by Oliver.
3411
3412         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3413
3414         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3415         replay the saved events when we're still processing the mousedown that starts the drag
3416         * DumpRenderTree/win/EventSender.cpp:
3417         (doMouseMove):
3418         * DumpRenderTree/win/UIDelegate.cpp:
3419         (UIDelegate::doDragDrop):
3420
3421 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3422
3423         Reviewed by Sam, Steve and Darin.
3424
3425         - Stubbed out the WebScriptDebugListener functionality in the Server
3426         Connection class to prepare it for receiving those callbacks.
3427         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3428         and the ServerConnection to not need to be initialized with a server
3429         name, since that is not the way we connect to the WebKit server. 
3430
3431         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3432         no exception.  Now it only loggs when there is an exception
3433         (DebuggerDocument::willExecuteStatement):
3434         (DebuggerDocument::didEnterCallFrame):
3435         (DebuggerDocument::willLeaveCallFrame):
3436         (DebuggerDocument::windowScriptObjectAvailable):
3437         (DebuggerDocument::callFunctionOnObject):
3438         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3439         to be instantiated with a server's name.
3440         (DebuggerClient::DebuggerClient):
3441         (DebuggerClient::didFinishLoadForFrame):
3442         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3443         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3444         a server name.
3445         (Drosera::init):
3446         (Drosera::initServer):
3447         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3448         instantiated with a server's name.
3449         * Drosera/win/ServerConnection.cpp: 
3450         (ServerConnection::ServerConnection): No longer needs a server name
3451         (ServerConnection::~ServerConnection): Only release the global context
3452         if there is one.
3453         (ServerConnection::serverConnectionDidDie): Stub for
3454         IWebScriptDebugListener
3455         (ServerConnection::QueryInterface): ditto
3456         (ServerConnection::AddRef): ditto
3457         (ServerConnection::Release): ditto
3458         (ServerConnection::didLoadMainResourceForDataSource): ditto
3459         (ServerConnection::didParseSource): ditto
3460         (ServerConnection::failedToParseSource): ditto
3461         (ServerConnection::didEnterCallFrame): ditto
3462         (ServerConnection::willExecuteStatement): ditto
3463         (ServerConnection::willLeaveCallFrame): ditto
3464         (ServerConnection::exceptionWasRaised): ditto
3465         * Drosera/win/ServerConnection.h: Stubbed out the
3466         IWebScriptDebugListener functions, and this class no longer needs to be
3467         instantiated with a server name.
3468
3469 2007-10-24  Lars Knoll  <lars@trolltech.com>
3470
3471         Reviewed by Simon.
3472
3473         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3474
3475         * DumpRenderTree/qt/jsobjects.h:
3476
3477 2007-10-24  Lars Knoll  <lars@trolltech.com>
3478
3479         Reviewed by Simon.
3480
3481         add another command.
3482
3483         * DumpRenderTree/qt/jsobjects.cpp:
3484         (TextInputController::doCommand):
3485
3486 2007-10-24  Lars Knoll  <lars@trolltech.com>
3487
3488         Reviewed by Simon.
3489
3490         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3491
3492         * DumpRenderTree/qt/jsobjects.cpp:
3493         (EventSender::keyDown):
3494         * DumpRenderTree/qt/jsobjects.h:
3495
3496 2007-10-24  Lars Knoll  <lars@trolltech.com>
3497
3498         Reviewed by Simon.
3499
3500         implement eventSender.keyDown().
3501
3502         * DumpRenderTree/qt/jsobjects.cpp:
3503         (EventSender::keyDown):
3504
3505 2007-10-24  Lars Knoll  <lars@trolltech.com>
3506
3507         Reviewed by Simon.
3508
3509         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3510
3511         * DumpRenderTree/qt/DumpRenderTree.cpp:
3512         (WebCore::DumpRenderTree::DumpRenderTree):
3513         (WebCore::DumpRenderTree::initJSObjects):
3514         * DumpRenderTree/qt/jsobjects.cpp:
3515         (TextInputController::doCommand):
3516
3517 2007-10-24  Lars Knoll  <lars@trolltech.com>
3518
3519         Reviewed by Simon.
3520
3521         first bit of implementation for the textinputcontroller.
3522
3523         * DumpRenderTree/qt/DumpRenderTree.cpp:
3524         (WebCore::DumpRenderTree::DumpRenderTree):
3525         * DumpRenderTree/qt/DumpRenderTree.h:
3526         * DumpRenderTree/qt/jsobjects.cpp:
3527         (TextInputController::TextInputController):
3528         (TextInputController::doCommand):
3529         * DumpRenderTree/qt/jsobjects.h:
3530
3531 2007-10-24  Lars Knoll  <lars@trolltech.com>
3532
3533         Reviewed by Simon.
3534
3535         make the man webpage believe it has focus, so the editing tests work correctly.
3536
3537         * DumpRenderTree/qt/DumpRenderTree.cpp:
3538         (WebCore::DumpRenderTree::DumpRenderTree):
3539
3540 2007-10-24  Lars Knoll  <lars@trolltech.com>
3541
3542         Reviewed by Simon.
3543
3544         implement layoutTestController.dumpEditingCallbacks() correctly.
3545
3546         * DumpRenderTree/qt/DumpRenderTree.cpp:
3547         (WebCore::DumpRenderTree::DumpRenderTree):
3548         * DumpRenderTree/qt/jsobjects.cpp:
3549         (LayoutTestController::reset):
3550         (LayoutTestController::dumpEditingCallbacks):
3551
3552 2007-10-24  Lars Knoll  <lars@trolltech.com>
3553
3554         Reviewed by Simon.
3555
3556         Implement support for testing editing.
3557
3558         * DumpRenderTree/qt/DumpRenderTree.cpp:
3559         (WebCore::DumpRenderTree::DumpRenderTree):
3560
3561 2007-10-23  Sam Weinig  <sam@webkit.org>
3562
3563         Check for null BSTR that can be passed to the UIDelegate methods
3564         from javascript null and undefined.  Fixes a failing test case on
3565         Windows (fast/dom/Window/alert-undefined.html)
3566
3567         Reviewed by Eric Seidel.
3568
3569         * DumpRenderTree/win/UIDelegate.cpp:
3570         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3571         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3572         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3573         (UIDelegate::webViewAddMessageToConsole):
3574
3575 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3576
3577         Reviewed by Darin.
3578         
3579         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3580
3581         * Scripts/build-testkjs:
3582
3583 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3584
3585         Reviewed by Darin.
3586
3587         - add wrapper that finds the right copy of testkjs
3588         
3589         * Scripts/sunspider-compare-results: Added.
3590
3591 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3592
3593         Reviewed by Sam.
3594
3595         - After talking with Steve I now see that the WebKit server must be
3596         running for DCOM to create the distributed objects, which makes sense
3597         and currently WebKit only allows one instance to be running at a time
3598         which avoids accidentally connecting to the wrong server
3599         - In light of this I have removed the code for the attach box and
3600         NotificationServer and known server names, since they are all extranious
3601         now.
3602
3603         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3604         names.
3605         (_tWinMain): Uses init instead of initUI.
3606         (droseraWndProc): No longer creats an attach dialog box.
3607         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3608         it's not manditory to call init before doing COM stuff.
3609         (Drosera::init): calls initUI and will call attach when the
3610         functionality exists. 
3611         (Drosera::initUI): Has changed very little.
3612         (Drosera::attach): Changed the signature to reflect that we no longer
3613         need the dictionary of known server names.
3614         * Drosera/win/Drosera.h: Removed notification classes and known server
3615         names.  Also renamed and moved some functions.
3616         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3617         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3618         headers to the resources folder. 
3619         * Drosera/win/resource.h: Removed the Attach box.
3620
3621 2007-10-22  Adam Roben  <aroben@apple.com>
3622
3623         Windows build fix
3624
3625         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3626
3627 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3628
3629         - Removed a leak that was fixed.
3630
3631         * Scripts/run-webkit-tests:
3632
3633 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3634
3635         Reviewed by Darin.
3636
3637         - Changed the Client so that the DebuggerDocument now own the
3638         ServerConnection.  This simplifies ownership and cleanup. 
3639
3640         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3641         ServerConnection.
3642         (DebuggerClient::initWithServerName):
3643         (DebuggerClient::didFinishLoadForFrame):
3644         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3645         ServerConnection.
3646         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3647         until after we have a server which we are attached to.
3648         (Drosera::initUI):
3649         (Drosera::attach):
3650         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3651         out previously.
3652
3653 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3654
3655         Reviewed by Nikolas.
3656
3657         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3658