12be5e57b7d3995c1292001e824ad7bbb92f22df
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
2
3         Reviewed by Adam Roben.
4
5         Set project dependencies so that they build serially. This fixes
6         issues when running run-webkit-tests if DRT is not built yet.
7
8         * DumpRenderTree/DumpRenderTree.sln:
9
10 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
11
12         Reviewed by Adam Barth.
13
14         Fix reading configuraiton in NWRT to work on Windows.
15         https://bugs.webkit.org/show_bug.cgi?id=45180
16
17         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
18             with the file otherwise.
19
20 2010-09-03  Chris Rogers  <crogers@google.com>
21
22         Unreviewed
23
24         Add myself to the committers list
25         https://bugs.webkit.org/show_bug.cgi?id=45189
26
27         * Scripts/webkitpy/common/config/committers.py:
28
29 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
30
31         Reviewed by Yury Semikhatsky.
32
33         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
34         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
35         https://bugs.webkit.org/show_bug.cgi?id=45137
36
37         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
38
39 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
40
41         Reviewed by Eric Seidel.
42
43         Add feature detection support to NRWT.
44         https://bugs.webkit.org/show_bug.cgi?id=41842
45
46         * Scripts/webkitpy/layout_tests/port/base.py:
47         * Scripts/webkitpy/layout_tests/port/qt.py:
48         * Scripts/webkitpy/layout_tests/port/webkit.py:
49         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
50
51 2010-09-03  Hironori Bono  <hbono@chromium.org>
52
53         Reviewed by Kent Tamura.
54
55         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
56         and implements it for Mac.
57         https://bugs.webkit.org/show_bug.cgi?id=41832
58
59         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
60         and bind it so we can call it from JavaScript.
61         (+[TextInputController isSelectorExcludedFromWebScript:]):
62         (+[TextInputController webScriptNameForSelector:]):
63         (-[TextInputController hasSpellingMarker:length:]):
64
65 2010-09-02  Eric Seidel  <eric@webkit.org>
66
67         Reviewed by Adam Barth.
68
69         Add a unit test for commit-queue retries
70         https://bugs.webkit.org/show_bug.cgi?id=45162
71
72         I think commit-queue retries are not correctly avoiding
73         build and test on retries.  So I started testing the code.
74         Unfortunately this test did not find the bug.  But now
75         that we have the test we might as well keep it.
76         I also fixed a broken import in validate-committer-lists.
77
78         * Scripts/validate-committer-lists:
79         * Scripts/webkitpy/tool/commands/queues_unittest.py:
80
81 2010-09-02  Kent Tamura  <tkent@chromium.org>
82
83         Reviewed by Dimitri Glazkov.
84
85         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
86         https://bugs.webkit.org/show_bug.cgi?id=45091
87
88         Task.{cpp,h} introduces a simpler version of Chromium
89         base/task.h. It doesn't have TupleN and Method.
90
91         * DumpRenderTree/DumpRenderTree.gypi:
92          Add Task.cpp and Task.h
93         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
94         (DRTDevToolsAgent::DRTDevToolsAgent):
95         (DRTDevToolsAgent::reset):
96         (DRTDevToolsAgent::asyncCall):
97         (DRTDevToolsAgent::frontendLoaded):
98         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
99         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
100         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
101         (DRTDevToolsClient::DRTDevToolsClient):
102         (DRTDevToolsClient::~DRTDevToolsClient):
103         (DRTDevToolsClient::reset):
104         (DRTDevToolsClient::asyncCall):
105         * DumpRenderTree/chromium/DRTDevToolsClient.h:
106         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
107         * DumpRenderTree/chromium/EventSender.cpp:
108         (EventSender::EventSender):
109         (EventSender::reset):
110         (EventSender::scheduleAsynchronousClick):
111         * DumpRenderTree/chromium/EventSender.h:
112         (EventSender::taskList): Added to use MethodTask<T>.
113         * DumpRenderTree/chromium/LayoutTestController.cpp:
114         (LayoutTestController::LayoutTestController):
115         (LayoutTestController::WorkQueue::processWorkSoon):
116         (LayoutTestController::waitUntilDone):
117         (LayoutTestController::notifyDone):
118         (LayoutTestController::reset):
119         * DumpRenderTree/chromium/LayoutTestController.h:
120         (LayoutTestController::taskList): Added to use MethodTask<T>.
121         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
122         * DumpRenderTree/chromium/NotificationPresenter.cpp:
123         (deferredDisplayDispatch):
124         (NotificationPresenter::show):
125         * DumpRenderTree/chromium/Task.cpp: Added.
126         * DumpRenderTree/chromium/Task.h: Added.
127
128 2010-09-02  Steve Block  <steveblock@google.com>
129
130         Reviewed by Adam Barth.
131
132         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
133         https://bugs.webkit.org/show_bug.cgi?id=43181
134
135         * DumpRenderTree/mac/DumpRenderTree.mm:
136         (createWebViewAndOffscreenWindow):
137         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
138         (LayoutTestController::setMockDeviceOrientation):
139
140 2010-08-31  Adam Roben  <aroben@apple.com>
141
142         Fix flashiness when resizing the browser window on Windows
143
144         Reviewed by Sam Weinig.
145
146         * MiniBrowser/win/BrowserWindow.cpp:
147         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
148         periodically fill the window with white.
149
150 2010-09-02  Peter Kasting  <pkasting@google.com>
151
152         Reviewed by Dimitri Glazkov.
153
154         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
155         https://bugs.webkit.org/show_bug.cgi?id=45073
156
157         * DumpRenderTree/chromium/EventSender.cpp:
158         (EventSender::EventSender):
159         (EventSender::mouseScrollBy):
160         (EventSender::continuousMouseScrollBy):
161         (EventSender::sendCurrentTouchEvent):
162         (EventSender::handleMouseWheel):
163         * DumpRenderTree/chromium/EventSender.h:
164         * DumpRenderTree/gtk/EventSender.cpp:
165         (mouseScrollByCallback):
166         (continuousMouseScrollByCallback):
167
168 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
169
170         Reviewed by Tony Chang.
171
172         Land a patched version of r66542 - change TestRunner to have an
173         separate cleanup method and fix the ordering of cleanup between
174         TestRunner and the printing module, and then wrap everything in a
175         try/finally block to ensure reliable cleanup without needing to
176         rely on stuff happening in the destructor of the TestRunner.
177
178         Also refactor run_webkit_tests.run() to be much smaller and cleaner
179         by creating a bunch of helper methods and moving more stuff into
180         the TestRunner class.
181
182         This fixes the crash at the end of the linux test run of
183         new-run-webkit-tests (and undoes the rollout in 66547).
184
185         https://bugs.webkit.org/show_bug.cgi?id=44902
186
187         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
188         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
189         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
190         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
191         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
192         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
193         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
194         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
195         * Scripts/webkitpy/layout_tests/port/base.py:
196         * Scripts/webkitpy/layout_tests/port/test.py:
197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
198         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
199
200 2010-09-01  Mark Rowe  <mrowe@apple.com>
201
202         Reviewed by Adam Roben.
203
204         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
205
206         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
207
208 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
209
210         Reviewed by Adam Roben.
211
212         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
213         and WebKitTestRunner.
214
215         * BuildSlaveSupport/win/kill-old-processes:
216
217 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
218
219         Reviewed by Antonio Gomes.
220
221         [Qt] Remove obsolete include path from DumpRenderTree.pro
222
223         * DumpRenderTree/qt/DumpRenderTree.pro:
224
225 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
226
227         Reviewed by Laszlo Gombos.
228
229         [Qt] QWebPage::allowGeolocationRequest should be async API
230         https://bugs.webkit.org/show_bug.cgi?id=41364
231
232         Implements new async API for geolocation permission similar to
233         Notification. WebPage maintains list of geolocation permission request
234         QtWebkit and set's when LayoutTestController gets the access from test JS
235
236         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
237         (WebCore::WebPage::WebPage):
238         (WebCore::WebPage::resetSettings):
239         (WebCore::WebPage::requestPermission):
240         (WebCore::WebPage::cancelPermission):
241         (WebCore::WebPage::permissionSet):
242         (WebCore::DumpRenderTree::DumpRenderTree):
243         (WebCore::DumpRenderTree::processLine):
244         (WebCore::DumpRenderTree::geolocationPermissionSet):
245         * DumpRenderTree/qt/DumpRenderTreeQt.h:
246         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
247         (LayoutTestController::reset):
248         (LayoutTestController::setGeolocationPermission):
249         (LayoutTestController::setGeolocationPermissionCommon):
250         * DumpRenderTree/qt/LayoutTestControllerQt.h:
251
252 2010-09-01  Andras Becsi  <abecsi@webkit.org>
253
254         Reviewed by Antti Koivisto.
255
256         [Qt] Auto-generate WebKit2 forwarding headers
257         https://bugs.webkit.org/show_bug.cgi?id=44692
258
259         * MiniBrowser/qt/BrowserWindow.h: use source style includes
260         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
261         * Scripts/enumerate-included-framework-headers: Removed.
262
263 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
264
265         Reviewed by Adam Barth.
266
267         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
268         https://bugs.webkit.org/show_bug.cgi?id=44789
269
270         * Scripts/webkitpy/common/net/bugzilla.py:
271
272 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
273
274         Reviewed by Adam Barth.
275
276         ews: Add support for EFL-EWS
277         https://bugs.webkit.org/show_bug.cgi?id=44982
278
279         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
280         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
281         and add it to the ports dict.
282         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
283         EflEWS class.
284         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
285         a test case for the EFL EWS.
286
287 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
288
289         Reviewed by Sam Weinig.
290
291         https://bugs.webkit.org/show_bug.cgi?id=42195
292         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
293
294         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
295         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
296         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
297         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
298         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
299
300         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
301         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
302         which forgets its override.
303
304 2010-08-31  Sam Weinig  <sam@webkit.org>
305
306         Reviewed by Gavin Barraclough.
307
308         WebKitTestRunner needs layoutTestController.addUserStyleSheet
309         https://bugs.webkit.org/show_bug.cgi?id=42680
310
311         WebKitTestRunner needs layoutTestController.addUserScript
312         https://bugs.webkit.org/show_bug.cgi?id=42681
313
314         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
315         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
316         (WTR::InjectedBundle::beginTesting):
317         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
318         (WTR::LayoutTestController::addUserScript):
319         (WTR::LayoutTestController::addUserStyleSheet):
320         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
321
322 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
323
324         Unreviewed, rolling out r66542.
325         http://trac.webkit.org/changeset/66542
326         https://bugs.webkit.org/show_bug.cgi?id=44902
327
328         r66542 - the weird logging dependencies in Python stuck again ...
329
330         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
331         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
332         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
333         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
334         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
335         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
336         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
337         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
338         * Scripts/webkitpy/layout_tests/port/base.py:
339         * Scripts/webkitpy/layout_tests/port/test.py:
340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
341         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
342
343 2010-08-31  Dumitru Daniliuc  <dumi@chromium.org>
344
345         Reviewed by Tony Chang.
346
347         Implementing LayoutTestController::markerTextForListItem() in Chromium's DRT.
348
349         * DumpRenderTree/chromium/LayoutTestController.cpp:
350         (LayoutTestController::LayoutTestController):
351         (LayoutTestController::markerTextForListItem):
352         * DumpRenderTree/chromium/LayoutTestController.h:
353
354 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
355
356         Reviewed by Ojan Vafai.
357
358         new-run-webkit-tests: add more unit tests
359
360         Add more unit tests for new-run-webkit-tests; we now cover all but
361         the most obscure code paths in the generic code. We still need to
362         add coverage for the http server and web socket paths, and add better
363         coverage of the platform-specific logic. Note that the rebaselining
364         tool is still not well tested.
365
366         Also clean up some of the configuration logic for the printing
367         module and the way it interacts with the Python logging module; that
368         is a crufty interface, to be certain.
369         
370         https://bugs.webkit.org/show_bug.cgi?id=44902
371
372         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
373         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
374         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
375         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
376         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
377         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
378         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
379         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
380         * Scripts/webkitpy/layout_tests/port/base.py:
381         * Scripts/webkitpy/layout_tests/port/test.py:
382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
383         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
384
385 2010-08-31  Darin Adler  <darin@apple.com>
386
387         Reviewed by Anders Carlsson.
388
389         * Scripts/check-for-global-initializers: Add a file that ends up having global initializers
390         in a debug build when built with certain compilers.
391
392 2010-08-31  Martin Robinson  <mrobinson@igalia.com>
393
394         Reviewed by Gustavo Noronha Silva.
395
396         [GTK] Isolate all GTK+ typedefs into one file
397         https://bugs.webkit.org/show_bug.cgi?id=44900
398
399         * DumpRenderTree/gtk/EventSender.h: Remove GTK+ typedefs.
400
401 2010-08-31  Eric Seidel  <eric@webkit.org>
402
403         Reviewed by Adam Barth.
404
405         Show more status on queue status pages
406         https://bugs.webkit.org/show_bug.cgi?id=44938
407
408         I upped the number of status lines from 6 to 15 --
409         this has been bugging me for a while...
410
411         I also disabled showing the chromium-win EWS queue
412         since it's been down for almost 5 months now.
413
414         * QueueStatusServer/handlers/dashboard.py:
415         * QueueStatusServer/handlers/queuestatus.py:
416         * QueueStatusServer/model/queues.py:
417
418 2010-08-31  Zoltan Horvath  <zoltan@webkit.org>
419
420         Reviewed by Antonio Gomes.
421
422         [Qt] Read command line arguments and open them as URLs in new windows
423         https://bugs.webkit.org/show_bug.cgi?id=44944
424
425         Extend MiniBrowser to accept command line arguments and open them as URLs in new browser windows.
426
427         * MiniBrowser/qt/main.cpp:
428         (main):
429
430 2010-08-31  Adrian Perez  <aperez@igalia.com>
431
432         Reviewed by Martin Robinson.
433
434         Support scripts to run Buildbot slaves under daemontools (gtk related)
435         https://bugs.webkit.org/show_bug.cgi?id=40053
436
437         * BuildSlaveSupport/gtk: Added.
438         * BuildSlaveSupport/gtk/README: Added.
439         * BuildSlaveSupport/gtk/buildbot: Added.
440         * BuildSlaveSupport/gtk/buildbot/log: Added.
441         * BuildSlaveSupport/gtk/buildbot/log/run: Added.
442         * BuildSlaveSupport/gtk/buildbot/run: Added.
443         * BuildSlaveSupport/gtk/crashmon: Added.
444         * BuildSlaveSupport/gtk/crashmon/crashmon: Added.
445         * BuildSlaveSupport/gtk/crashmon/log: Added.
446         * BuildSlaveSupport/gtk/crashmon/log/run: Added.
447         * BuildSlaveSupport/gtk/crashmon/run: Added.
448         * BuildSlaveSupport/gtk/daemontools-buildbot.conf: Added.
449         * BuildSlaveSupport/gtk/pulseaudio: Added.
450         * BuildSlaveSupport/gtk/pulseaudio/run: Added.
451         * BuildSlaveSupport/gtk/xvfb: Added.
452         * BuildSlaveSupport/gtk/xvfb/log: Added.
453         * BuildSlaveSupport/gtk/xvfb/log/run: Added.
454         * BuildSlaveSupport/gtk/xvfb/run: Added.
455
456 2010-08-27  John Gregg  <johnnyg@google.com>
457
458         Reviewed by David Levin.
459
460         Notifications should support a click event.
461         Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
462         can be simulated during a layout test.  Requires storing a list of active
463         notifications so that they can be referred to later for clicking.
464         https://bugs.webkit.org/show_bug.cgi?id=44800
465
466         * DumpRenderTree/chromium/LayoutTestController.cpp:
467         (LayoutTestController::LayoutTestController):
468         (LayoutTestController::simulateDesktopNotificationClick):
469         * DumpRenderTree/chromium/LayoutTestController.h:
470         * DumpRenderTree/chromium/NotificationPresenter.cpp:
471         (NotificationPresenter::simulateClick):
472         (NotificationPresenter::show):
473         (NotificationPresenter::cancel):
474         (NotificationPresenter::objectDestroyed):
475         * DumpRenderTree/chromium/NotificationPresenter.h:
476
477 2010-08-30  Alice Liu  <alice.liu@apple.com>
478
479         Reviewed by Darin Adler.
480
481         Add missing parts of didFinishDocumentLoadForFrame
482         https://bugs.webkit.org/show_bug.cgi?id=44913
483
484         * MiniBrowser/mac/BrowserWindowController.m:
485         (didFinishDocumentLoadForFrame): Added
486         (-[BrowserWindowController awakeFromNib]): Updated struct
487         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
488         (WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
489         * WebKitTestRunner/TestController.cpp:
490         (WTR::TestController::initialize): Updated struct
491
492 2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>
493
494         Unreviewed: Add myself to the list of Committers.
495
496         * Scripts/webkitpy/common/config/committers.py:
497
498 2010-08-30  Kent Tamura  <tkent@chromium.org>
499
500         Reviewed by Adam Barth.
501
502         Fix fast/notifications/notifications-display-close-events.html failure
503         https://bugs.webkit.org/show_bug.cgi?id=44585
504
505         Apply http://crrev.com/48893. We should dispatch display events
506         asynchronously.
507
508         * DumpRenderTree/chromium/NotificationPresenter.cpp:
509         (deferredDisplayDispatch):
510         (NotificationPresenter::show):
511
512 2010-08-30  Robert Hogan  <robert@webkit.org>
513
514         Reviewed by Simon Hausmann.
515
516         allow ports with windowed plugins to support windowless plugin tests
517
518         https://bugs.webkit.org/show_bug.cgi?id=40730
519
520         Ports that implement plugins windowed by default need to have a way of
521         supporting plugin tests that assume the plugin is windowless. Add this
522         feature to the tests and support it in the webkit test plugin. Also
523         add mouse and keyboard event logging to the webkit-test plugin on Unix.
524
525         Unskip the following tests on Qt:
526
527         plugins/mouse-events.html
528         plugins/keyboard-events.html
529         plugins/mouse-events-fixedpos.html
530
531         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
532         (pluginSetProperty):
533         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
534         (NPP_New):
535         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
536         (webkit_test_plugin_handle_event):
537
538 2010-08-30  Kevin Ollivier  <kevino@theolliviers.com>
539
540         [wx] Build fix after addition of fileapi directory in WebCore.
541
542         * wx/build/settings.py:
543
544 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
545
546         Reviewed by Xan Lopez.
547
548         Fixed compilation error, now that we have included the
549         GtkVersioning.h we have to remove some version dependent code from
550         EventSender.
551
552         * DumpRenderTree/gtk/EventSender.cpp:
553
554 2010-08-30  Alejandro G. Castro  <alex@igalia.com>
555
556         Reviewed by Martin Robinson.
557
558         [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
559         are deprecated
560         https://bugs.webkit.org/show_bug.cgi?id=44787
561
562         We have replaced GtkVersioning.cpp with GtkVersioning.c and
563         created a function (getDefaultGDKPointerDevice) to get the pointer
564         of the window with the new APIs. We added that function to DRT and
565         copyandpaste unit test.
566
567         * DumpRenderTree/gtk/EventSender.cpp:
568         (prepareMouseButtonEvent):
569         (mouseMoveToCallback):
570         (keyDownCallback):
571         * GNUmakefile.am:
572
573 2010-08-30  Zoltan Horvath  <zoltan@webkit.org>
574
575         Reviewed by Kenneth Rohde Christiansen.
576
577         [Qt] Add new window menu to MiniBrowser
578
579         Implement newWindow function and add a menu item for opening new window in MiniBrowser.
580
581         * MiniBrowser/qt/BrowserWindow.cpp:
582         (BrowserWindow::BrowserWindow):
583         (BrowserWindow::newWindow):
584         * MiniBrowser/qt/BrowserWindow.h:
585         * MiniBrowser/qt/main.cpp:
586         (main):
587
588 2010-08-29  James Robinson  <jamesr@chromium.org>
589
590         Reviewed by David Levin.
591
592         Make failing the download step fail the build
593         https://bugs.webkit.org/show_bug.cgi?id=44298
594
595         If the download step fails on a test bot, this ensures that
596         the build goes red instead of only the download step going red
597         and the overall build staying green.
598
599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
600
601 2010-08-29  Kent Tamura  <tkent@chromium.org>
602
603         Reviewed by Dimitri Glazkov.
604
605         [DRT/Chromium] Remove dependency to base/keyboard_codes.h
606         https://bugs.webkit.org/show_bug.cgi?id=44847
607
608         * DumpRenderTree/chromium/EventSender.cpp:
609          Use webkit_support::VKEY_* instead of base::VKEY_*.
610
611 2010-08-29  Darin Adler  <darin@apple.com>
612
613         https://bugs.webkit.org/show_bug.cgi?id=40589
614
615         * Scripts/prepare-ChangeLog: Only prepend namespaces to non-empty
616         function names.
617
618 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
619
620         Reviewed by Darin Adler.
621
622         [iExploder] Add new CSS Properties and HTML Attributes
623         https://bugs.webkit.org/show_bug.cgi?id=44746
624
625         Updated the files with the update-iexploder-cssproperties script
626         and manually readded the -webkit-binding CSS Property to the list.
627
628         * iExploder/htdocs/cssproperties.in:
629         * iExploder/htdocs/htmlattrs.in:
630         * iExploder/htdocs/htmltags.in:
631
632 2010-08-26  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
633
634         Reviewed by Darin Adler.
635
636         Fix Coverage build after the addition of ANGLE
637         https://bugs.webkit.org/show_bug.cgi?id=44744
638
639         ANGLE is using libtool to build a static library and the version of
640         libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
641         parameters. The easiest way to handle this is to not build ANGLE with
642         coverage information.
643
644         This is achieved by applying the XCode options for each project
645         separately and exclude ANGLE.
646
647         * Scripts/build-webkit: Remove -framework AppKit due link errors.
648         * Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
649
650 2010-08-28  Kevin Ollivier  <kevino@theolliviers.com>
651
652         [wx] Build fix after directory addition.
653
654         * wx/build/settings.py:
655
656 2010-08-28  Chris Guillory   <chris.guillory@google.com>
657
658         Reviewed by Chris Fleizach.
659
660         Add AX notification for childrenChanged
661         https://bugs.webkit.org/show_bug.cgi?id=44472
662
663         * DumpRenderTree/chromium/AccessibilityController.cpp:
664         (AccessibilityController::AccessibilityController):
665         (AccessibilityController::reset):
666         (AccessibilityController::getRootElement):
667         (AccessibilityController::dumpAccessibilityNotifications):
668         * DumpRenderTree/chromium/AccessibilityController.h:
669         (AccessibilityController::shouldDumpAccessibilityNotifications):
670         * DumpRenderTree/chromium/WebViewHost.cpp:
671         (WebViewHost::didChangeAccessibilityObjectChildren):
672         * DumpRenderTree/chromium/WebViewHost.h:
673
674 2010-08-28  Eric Seidel  <eric@webkit.org>
675
676         Reviewed by Adam Barth.
677
678         Update commit-queue failure message
679         https://bugs.webkit.org/show_bug.cgi?id=44798
680
681         The commit-queue auto-restarts itself and has for a very long time.
682         No need for people to email me to request a restart anymore.
683
684         * Scripts/webkitpy/common/net/bugzilla.py:
685         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
686         * Scripts/webkitpy/tool/commands/queues_unittest.py:
687
688 2010-07-27  Jer Noble  <jer.noble@apple.com>
689
690         Reviewed by Eric Carlson.
691
692         Add JavaScript API to allow a page to go fullscreen.
693         rdar://problem/6867795
694         
695         Added basic full screen support to DumpRenderTree: when a webView requests
696         that DumpRenderTree go "full screen", just call the provided callback listener object's
697         will/did Enter/Exit full screen methods.  Also, register a new user default which 
698         enables full screen support.
699
700         * DumpRenderTree/mac/DumpRenderTree.mm:
701         (resetDefaultsToConsistentValues):
702         * DumpRenderTree/mac/UIDelegate.mm:
703         (-[UIDelegate webView:supportsFullscreenForElement:]):
704         (-[UIDelegate webView:enterFullscreenForElement:listener:]):
705         (-[UIDelegate webView:exitFullscreenForElement:listener:]):
706
707 2010-08-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
708
709         Unreviewed. Add myself to the committers list.
710
711         * Scripts/webkitpy/common/config/committers.py:
712
713 2010-08-27  Kent Tamura  <tkent@chromium.org>
714
715         Reviewed by Pavel Feldman.
716
717         [DRT/Chromium] Fix inspector test failures
718         https://bugs.webkit.org/show_bug.cgi?id=44748
719
720         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
721         (DRTDevToolsAgent::createClientMessageLoop):
722           Returns a valid WebKitClientMessageLoop instance
723         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
724
725 2010-08-26  Jon Honeycutt  <jhoneycutt@apple.com>
726
727         Add Windows WebKit2 Tester to buildbot
728         <rdar://problem/7887703>
729
730         Reviewed by Dan Bernstein.
731
732         * BuildSlaveSupport/build.webkit.org-config/config.json:
733
734 2010-08-26  Philippe Normand  <pnormand@igalia.com>
735
736         Reviewed by Martin Robinson.
737
738         [GTK] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
739         https://bugs.webkit.org/show_bug.cgi?id=42152
740
741         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
742         (LoadHTMLStringItem::invoke): Implementation using
743         webkit_web_frame_load_string().
744
745 2010-08-25  Jon Honeycutt  <jhoneycutt@apple.com>
746
747         <rdar://problem/8334338> run-webkit-tests sometimes hangs when using
748         WebKitTestRunner (44331)
749
750         Reviewed by Darin Adler.
751
752         * WebKitTestRunner/TestController.cpp:
753         (WTR::TestController::initialize):
754         The hang occurs when WebKitTestRunner begins launching the WebKit2
755         web process then exits before it finishes launching. Work around this by
756         looking for the --print-supported-features argument and exiting without
757         creating the web process.
758
759 2010-08-26  Dirk Pranke  <dpranke@chromium.org>
760
761         Reviewed by Tony Chang.
762
763         new-run-webkit-tests: add rebaselining tests for test_expectations
764         
765         This patch adds more unit tests for the rebaselining code in the
766         test_expectations module. It doesn't add any tests for
767         rebaseline_chromium_webkit_tests itself; that will come some other
768         time.
769
770         https://bugs.webkit.org/show_bug.cgi?id=44648
771
772         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
773         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
774
775 2010-08-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
776
777         Reviewed by Martin Robinson.
778
779         [GTK] Add HTTP caching support
780         https://bugs.webkit.org/show_bug.cgi?id=44261
781
782         Ignore new soup API that we decided to merge into the soup backend
783         while it is being cooked. It follows the libsoup style, and will
784         be removed from WebKit as soon as it is merged into libsoup.
785
786         * Scripts/webkitpy/style/checker.py:
787
788 2010-08-26  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
789
790         Reviewed by Kenneth Rohde Christiansen.
791
792         [Qt] DumpRenderTree runs only one test from command mode
793         https://bugs.webkit.org/show_bug.cgi?id=44012
794
795         Enables support to run multiple test files and single
796         folder containing html files in stand alone mode
797
798         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
799         (WebCore::DumpRenderTree::DumpRenderTree):
800         (WebCore::DumpRenderTree::processArgsLine):
801         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
802         (WebCore::DumpRenderTree::processLine):
803         (WebCore::DumpRenderTree::dump):
804         * DumpRenderTree/qt/DumpRenderTreeQt.h:
805         (WebCore::DumpRenderTree::setStandAloneMode):
806         (WebCore::DumpRenderTree::isStandAloneMode):
807         * DumpRenderTree/qt/main.cpp:
808         (main):
809
810 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
811
812         Updating webkitpy test expectations.
813
814         * Scripts/webkitpy/tool/steps/steps_unittest.py:
815
816 2010-08-25  Ojan Vafai  <ojan@chromium.org>
817
818         Reviewed by Eric Seidel.
819
820         fix the always squash git config
821         https://bugs.webkit.org/show_bug.cgi?id=44651
822
823         Fix help text and apparently underscores are not allowed
824         in git config keys.
825
826         * Scripts/webkitpy/common/checkout/scm.py:
827         * Scripts/webkitpy/tool/steps/commit.py:
828
829 2010-08-25  Darin Adler  <darin@apple.com>
830
831         Reviewed by John Sullivan.
832
833         * Scripts/commit-log-editor: Fix perl warning for people who have no
834         value for SVN_LOG_EDITOR or CVS_LOG_EDITOR.
835
836 2010-08-25  Ojan Vafai  <ojan@chromium.org>
837
838         Reviewed by Eric Seidel.
839
840         stop blocking commits when the bots are red
841         https://bugs.webkit.org/show_bug.cgi?id=44644
842
843         This check currently is just annoying. It doesn't actually
844         help keep the tree green. We can always add it back later
845         if we decide the tree is generally more green.
846
847         * Scripts/webkitpy/tool/commands/download_unittest.py:
848         * Scripts/webkitpy/tool/mocktool.py:
849         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
850
851 2010-08-25  Eric Seidel  <eric@webkit.org>
852
853         Reviewed by Simon Fraser.
854
855         REGRESSION: media/video-loop.html is timing out on the commit-queue Leopard Bot
856         https://bugs.webkit.org/show_bug.cgi?id=38912
857
858         I know of nothing else to do but skip all media tests for the cq.
859
860         * Scripts/webkitpy/tool/steps/runtests.py:
861
862 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
863
864         Reviewed by Ojan Vafai.
865
866         new-run-webkit-tests: add more unit tests for test_expectations
867         This adds unit tests to cover (almost?) all of the non-rebaselining
868         functionality.
869
870         https://bugs.webkit.org/show_bug.cgi?id=44579
871
872         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
873         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
874
875 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
876
877         Reviewed by Ojan Vafai.
878
879         new-run-webkit-tests: add more unit tests
880
881         This change adds more unit tests for the image_diff, test_failures,
882         and test_files modules, bringing them to 100% coverage (and adds a
883         couple tests to run_webkit_tests while we're at it).
884
885         This test also turns on the "dryrun" port for testing when run on
886         the mac, increasing coverage in a few other places.
887
888         https://bugs.webkit.org/show_bug.cgi?id=44578
889
890         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.checksum: Added.
891         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.png: Added.
892         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum-expected.txt: Added.
893         * Scripts/webkitpy/layout_tests/data/failures/expected/checksum.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html.
894         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.png: Added.
895         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check-expected.txt: Added.
896         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_check.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html.
897         * Scripts/webkitpy/layout_tests/data/failures/expected/timeout.html: Added.
898         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
899         * Scripts/webkitpy/layout_tests/data/resources/README.txt: Added.
900         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
901         * Scripts/webkitpy/layout_tests/port/test.py:
902         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
903
904 2010-08-25  Dirk Pranke  <dpranke@chromium.org>
905
906         Reviewed by Ojan Vafai.
907
908         new-run-webkit-tests: add more unit tests for layout_package/printing.py
909
910         This change adds more unit tests to get the test coverage to 100%
911         for the printing module. This code is actually pretty crufty and
912         has some layering violations that need to be cleaned up but I'll
913         save that for another CL after we get all the unit tests written and
914         we fix the multithreading issues. At least now we'll be able to tell
915         if we break things.
916
917         https://bugs.webkit.org/show_bug.cgi?id=44576
918
919         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
920         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
921
922 2010-08-25  Ojan Vafai  <ojan@chromium.org>
923
924         Reviewed by Adam Barth.
925
926         new-run-webkit-tests should respect set-webkit-configuration
927         https://bugs.webkit.org/show_bug.cgi?id=44633
928
929         Moves the getting of the configuration into the base Port so that
930         chromium ports use it as well. In the downstream chromium port,
931         this should still just return Release.
932
933         * Scripts/webkitpy/layout_tests/port/base.py:
934         * Scripts/webkitpy/layout_tests/port/webkit.py:
935
936 2010-08-25  Tony Chang  <tony@chromium.org>
937
938         Not reviewed, changing svn props for a script.
939
940         * Scripts/deduplicate-tests: Added properties svn:executable and svn:eol-style.
941
942 2010-08-25  Adam Barth  <abarth@webkit.org>
943
944         Reviewed by Eric Seidel.
945
946         Remove WebKit2 from core builders
947         https://bugs.webkit.org/show_bug.cgi?id=44625
948
949         This builder was added to the core builders by accident.  It doesn't
950         appear to be green enough to be a core builder yet.
951
952         * Scripts/webkitpy/common/net/buildbot.py:
953         * Scripts/webkitpy/common/net/buildbot_unittest.py:
954
955 2010-08-19  Adam Roben  <aroben@apple.com>
956
957         Test that NP_Initialize and NP_GetEntryPoints are called in the
958         correct order
959
960         The order differs between Mac and Windows (see r38858).
961
962         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
963         NP_Initialize when loading QuickTime when running
964         plugins/embed-attributes-setting.html in WebKit2 on Windows
965
966         Reviewed by John Sullivan.
967
968         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
969         a boolean to record whether NP_GetEntryPoints has been called.
970         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
971         called yet. This matches Flash and QuickTime's behavior.
972         (NP_GetEntryPoints): Crash on Mac if NP_Initialize hasn't been called
973         yet. This matches Silverlight's behavior.
974
975 2010-08-25  Martin Robinson  <mrobinson@igalia.com>
976
977         Reviewed by Gustavo Noronha Silva.
978
979         Cairo and EFL port shouldn't depend on glib.
980         https://bugs.webkit.org/show_bug.cgi?id=44354
981
982         Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
983         adoptPlatformRef.
984
985         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
986         (AccessibilityUIElement::isSelected):
987
988 2010-08-25  Ojan Vafai  <ojan@chromium.org>
989
990         Fix order of Timothy's email address. The script, and
991         other tools all assume that the first email is the bugzilla address.
992
993         * Scripts/webkitpy/common/config/committers.py:
994
995 2010-08-24  Kent Tamura  <tkent@chromium.org>
996
997         Reviewed by Pavel Feldman.
998
999         [DRT/Chromium] Fix 26 inspector test crashes
1000         https://bugs.webkit.org/show_bug.cgi?id=44580
1001
1002         - DRTDevToolsAgent has a reference to the main WebView. So we
1003           should not clear it in closeDevTools() and should clear it in
1004           ~TestShell().
1005         - DRTDevToolsClient has a reference to a DevTools WebView and no
1006           way to update it. So we should delete DRTDevToolsClient instances
1007           in closeDevTools().
1008
1009         * DumpRenderTree/chromium/TestShell.cpp:
1010         (TestShell::~TestShell):
1011         (TestShell::closeDevTools):
1012
1013 2010-08-24  Eric Seidel  <eric@webkit.org>
1014
1015         Reviewed by Adam Barth.
1016
1017         unicode(Exception(\u"0x1234")) is busted in python 2.5, disable tests which hit this
1018         https://bugs.webkit.org/show_bug.cgi?id=44584
1019
1020         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1021
1022 2010-08-24  Eric Seidel  <eric@webkit.org>
1023
1024         Reviewed by Adam Barth.
1025
1026         commit-queue and EWS bots should report all failures
1027         https://bugs.webkit.org/show_bug.cgi?id=41820
1028
1029         Right now commit-queue/EWS only report failures when the
1030         patch under testing fails.  We should report all failures
1031         to the status server so that we can diagnose when the bots
1032         are wedged w/o needing to log into the machines.
1033
1034         I also reduced the amount of data we upload since we've seen
1035         timeouts during status upload.
1036
1037         * Scripts/webkitpy/common/system/executive.py:
1038         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1039         * Scripts/webkitpy/tool/commands/queues.py:
1040         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1041
1042 2010-08-24  Eric Seidel  <eric@webkit.org>
1043
1044         Reviewed by Adam Barth.
1045
1046         Remove HTML5 parser testing infrastructure now that we don't need it
1047         https://bugs.webkit.org/show_bug.cgi?id=44581
1048
1049         * DumpRenderTree/mac/DumpRenderTree.mm:
1050         (resetDefaultsToConsistentValues):
1051         (initializeGlobalsFromCommandLineOptions):
1052         * Scripts/old-run-webkit-tests:
1053         * Scripts/test-html5-parser: Removed.
1054
1055 2010-08-24  Kent Tamura  <tkent@chromium.org>
1056
1057         Reviewed by Dimitri Glazkov.
1058
1059         [DRT/Chromium] Fix 28 inspector test crashes
1060         https://bugs.webkit.org/show_bug.cgi?id=44574
1061
1062         Reset DevToolsClient and DevToolsAgent before closing a DevTools
1063         WebView in order to avoid accessing to a deleted WebView instance.
1064
1065         * DumpRenderTree/chromium/TestShell.cpp:
1066         (TestShell::closeDevTools):
1067
1068 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1069
1070         Reviewed by Ojan Vafai.
1071
1072         new-run-webkit-tests: clean up code for test_types, test_failures
1073
1074         Add a bunch of unit tests for webkitpy.layout_tests.test_types and
1075         webkitpy.layout_tests.layout_package.test_failures, and remove
1076         some dead code and otherwise clean up things.
1077
1078         https://bugs.webkit.org/show_bug.cgi?id=44559
1079
1080         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1081         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Added.
1082         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1083         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1084         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1085         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Added.
1086         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1087
1088 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1089
1090         Reviewed by Eric Seidel.
1091
1092         new-run-webkit-tests: revise unit testing strategy for test failures
1093     
1094         This change revamps the way we store test data for new-run-webkit-tests.
1095         Previously we had a few copies of test files from the main test tree.
1096         Now we have a bunch of completely fake test data and use the test
1097         data to generate different kinds of test failures, getting
1098         much better coverage.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=44556
1101
1102         * Scripts/webkitpy/layout_tests/data/failures/expected/crash.html: Added.
1103         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.checksum: Added.
1104         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.png: Added.
1105         * Scripts/webkitpy/layout_tests/data/failures/expected/image-expected.txt: Added.
1106         * Scripts/webkitpy/layout_tests/data/failures/expected/image.html: Added.
1107         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.checksum: Added.
1108         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.png: Added.
1109         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum-expected.txt: Added.
1110         * Scripts/webkitpy/layout_tests/data/failures/expected/image_checksum.html: Added.
1111         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_image.html: Added.
1112         * Scripts/webkitpy/layout_tests/data/failures/expected/missing_text.html: Added.
1113         * Scripts/webkitpy/layout_tests/data/failures/expected/text-expected.txt: Added.
1114         * Scripts/webkitpy/layout_tests/data/failures/expected/text.html: Added.
1115         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.checksum: Added.
1116         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.png: Added.
1117         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum-expected.txt: Added.
1118         * Scripts/webkitpy/layout_tests/data/failures/unexpected/text-image-checksum.html: Added.
1119         * Scripts/webkitpy/layout_tests/data/image/canvas-bg.html: Removed.
1120         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.checksum: Removed.
1121         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.png: Removed.
1122         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom-expected.txt: Removed.
1123         * Scripts/webkitpy/layout_tests/data/image/canvas-zoom.html: Removed.
1124         * Scripts/webkitpy/layout_tests/data/misc/crash-expected.txt: Removed.
1125         * Scripts/webkitpy/layout_tests/data/misc/crash.html: Removed.
1126         * Scripts/webkitpy/layout_tests/data/misc/missing-expectation.html: Removed.
1127         * Scripts/webkitpy/layout_tests/data/misc/passing-expected.txt: Removed.
1128         * Scripts/webkitpy/layout_tests/data/misc/passing.html: Removed.
1129         * Scripts/webkitpy/layout_tests/data/passes/image-expected.checksum: Added.
1130         * Scripts/webkitpy/layout_tests/data/passes/image-expected.png: Added.
1131         * Scripts/webkitpy/layout_tests/data/passes/image-expected.txt: Added.
1132         * Scripts/webkitpy/layout_tests/data/passes/image.html: Added.
1133         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.checksum: Added.
1134         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.png: Added.
1135         * Scripts/webkitpy/layout_tests/data/passes/platform_image-expected.txt: Added.
1136         * Scripts/webkitpy/layout_tests/data/passes/platform_image.html: Added.
1137         * Scripts/webkitpy/layout_tests/data/passes/text-expected.txt: Added.
1138         * Scripts/webkitpy/layout_tests/data/passes/text.html: Added.
1139         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.checksum: Removed.
1140         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.png: Removed.
1141         * Scripts/webkitpy/layout_tests/data/platform/test/image/canvas-bg-expected.txt: Removed.
1142         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.checksum: Added.
1143         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.png: Added.
1144         * Scripts/webkitpy/layout_tests/data/platform/test/passes/platform_image-expected.txt: Added.
1145         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
1146         * Scripts/webkitpy/layout_tests/data/text/article-element-expected.txt: Removed.
1147         * Scripts/webkitpy/layout_tests/data/text/article-element.html: Removed.
1148         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1149         * Scripts/webkitpy/layout_tests/port/test.py:
1150         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1151         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1152
1153 2010-08-24  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Reviewed by Eric Seidel.
1156
1157         speed up new-run-webkit-tests unit tests
1158
1159         Add a --no-record-results flag that turns off generating the JSON
1160         results file on every test run. Generating the file requires us to
1161         fetch the old results down from the bots, which can be slow. This
1162         flag is off by default.
1163     
1164         Reduce the sleep time in wait_for_threads_to_finish from 0.1s to 0.01s.
1165     
1166         These changes together shorten the test cycle from ~4.5s to ~1.5s
1167         - a 3x speedup.
1168
1169         https://bugs.webkit.org/show_bug.cgi?id=44553
1170
1171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1172         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1173
1174 2010-08-24  Tony Chang  <tony@chromium.org>
1175
1176         Reviewed by Eric Seidel.
1177
1178         [chromium] fix the platform result fallback order on mac/win
1179         https://bugs.webkit.org/show_bug.cgi?id=44483
1180
1181         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1182
1183 2010-08-24  Xan Lopez  <xlopez@igalia.com>
1184
1185         Reviewed by Martin Robinson.
1186
1187         Set a device to the event struct when building with GTK+ 3.x, it's
1188         mandatory.
1189
1190         * DumpRenderTree/gtk/EventSender.cpp:
1191         (keyDownCallback):
1192
1193 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1194
1195         Reviewed by Xan Lopez.
1196
1197         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1198         https://bugs.webkit.org/show_bug.cgi?id=44534
1199
1200         Fix two double-frees introduced in my previous commit.
1201
1202         * DumpRenderTree/gtk/EventSender.cpp:
1203         (contextClickCallback): Copy the event before using it again.
1204         (keyDownCallback): Ditto.
1205
1206 2010-08-24  Martin Robinson  <mrobinson@igalia.com>
1207
1208         Reviewed by Xan Lopez.
1209
1210         [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1211         https://bugs.webkit.org/show_bug.cgi?id=44534
1212
1213         * DumpRenderTree/gtk/EventSender.cpp:
1214         (prepareMouseButtonEvent): Use gdk_event_new and reference the reference the GdkWindow
1215         when setting it on the event. It is dereferenced by gdk_event_free(...).
1216         (contextClickCallback): Ditto.
1217         (mouseDownCallback): Ditto.
1218         (mouseUpCallback): Ditto.
1219         (mouseMoveToCallback): Ditto.
1220         (mouseWheelToCallback): Ditto.
1221         (sendOrQueueEvent): Take a GdkEvent* instead of a GdkEvent.
1222         (dispatchEvent): Ditto. Also free the event when we are done with it.
1223         (keyDownCallback): Use gdk_event_new and reference the GdkWindow.
1224
1225 2010-08-24  Andras Becsi  <abecsi@webkit.org>
1226
1227         [Qt] WebKit2 build fix.
1228
1229         * Scripts/enumerate-included-framework-headers:
1230         Remove stray global option form sed.
1231
1232 2010-08-24  Kent Tamura  <tkent@chromium.org>
1233
1234         Reviewed by Jeremy Orlow.
1235
1236         [DRT/Chromium] Support for IndexedDB tests
1237         https://bugs.webkit.org/show_bug.cgi?id=44490
1238
1239         * DumpRenderTree/chromium/TestShell.cpp:
1240         (TestShell::TestShell): Enable IndexedDB.
1241
1242 2010-08-23  Martin Robinson  <mrobinson@igalia.com>
1243
1244         Reviewed by Gustavo Noronha Silva.
1245
1246         [GTK] The 64-bit Release bot is showing crashes on tests that use mouse buttons
1247         https://bugs.webkit.org/show_bug.cgi?id=44465
1248
1249         Initialize the axes field of mouse button and motion events to null.
1250         This is the value that should be used for events originating from the
1251         mouse device.
1252
1253         * DumpRenderTree/gtk/EventSender.cpp:
1254         (prepareMouseButtonEvent): Initalize button event axes field to null.
1255         (mouseMoveToCallback): Initialize motion event axes field to null.
1256
1257 2010-08-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1258
1259         Unreviewed, rolling out r65703.
1260         http://trac.webkit.org/changeset/65703
1261         https://bugs.webkit.org/show_bug.cgi?id=44460
1262
1263         "Causing lots of crashes on Snow Leopard when running the
1264         layout tests" (Requested by eseidel2 on #webkit).
1265
1266         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1267         (NP_Initialize):
1268         (NP_GetEntryPoints):
1269
1270 2010-08-23  Jon Honeycutt  <jhoneycutt@apple.com>
1271
1272         Layout tests do not run when using WebKitTestRunner in a Debug build.
1273         https://bugs.webkit.org/show_bug.cgi?id=44409
1274
1275         Reviewed by Dan Bernstein.
1276
1277         * WebKitTestRunner/win/TestControllerWin.cpp:
1278         (WTR::TestController::initializeInjectedBundlePath):
1279         Use InjectedBundle_debug.dll when building Debug.
1280
1281 2010-08-23  Xan Lopez  <xlopez@igalia.com>
1282
1283         Reviewed by Martin Robinson.
1284
1285         [GTK] run-launcher fails if WebKitGTK+ compiled with GTK+-3.0 support
1286         https://bugs.webkit.org/show_bug.cgi?id=42026
1287
1288         If a GTK+ 3.x build is present return that as the library to use,
1289         otherwise fallback to the GTK+ 2.x build.
1290
1291         * Scripts/webkitdirs.pm:
1292
1293 2010-08-23  Balazs Kelemen  <kb@inf.u-szeged.hu>
1294
1295         Reviewed by Ariya Hidayat.
1296
1297         [Qt] Find needed forwarding headers for WebKit2 automatically
1298         https://bugs.webkit.org/show_bug.cgi?id=44336
1299
1300         * MiniBrowser/qt/BrowserWindow.cpp: Use normal (not framework style) includes here.
1301         The new script does not satisfy the needs of this file however using normal includes
1302         is generally better here.
1303         * MiniBrowser/qt/MiniBrowser.pro: Added include paths.
1304         * Scripts/enumerate-included-framework-headers: Enumerates headers included from the 
1305         given frameworks by files in the current directory (and subdirectories).
1306         In the future this needs to be rewritten in perl for being able to use on Windows.
1307
1308 2010-08-22  No'am Rosenthal  <noam.rosenthal@nokia.com>
1309
1310         Reviewed by Ariya Hidayat.
1311
1312         [Qt] Qt test browser: enable a QGLWidget viewport with a command line argument
1313         https://bugs.webkit.org/show_bug.cgi?id=43010
1314
1315         * QtTestBrowser/launcherwindow.cpp:
1316         (LauncherWindow::applyPrefs):
1317         * QtTestBrowser/main.cpp:
1318         (LauncherApplication::handleUserOptions):
1319
1320 2010-08-21  Sam Weinig  <sam@webkit.org>
1321
1322         Reviewed by Dan Bernstein.
1323
1324         Remove specialized retain/release functions in favor of a single one for WKTypeRefs
1325         https://bugs.webkit.org/show_bug.cgi?id=44386
1326
1327         * MiniBrowser/mac/AppDelegate.m:
1328         (didRecieveMessageFromInjectedBundle):
1329         (didNavigateWithNavigationData):
1330         (-[BrowserAppDelegate init]):
1331         (-[BrowserAppDelegate applicationWillTerminate:]):
1332         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1333         (-[BrowserStatisticsWindowController initWithThreadedWKContextRef:processWKContextRef:]):
1334         (-[BrowserStatisticsWindowController dealloc]):
1335         * MiniBrowser/mac/BrowserWindowController.m:
1336         (-[BrowserWindowController initWithPageNamespace:]):
1337         (-[BrowserWindowController fetch:]):
1338         (-[BrowserWindowController windowWillClose:]):
1339         (-[BrowserWindowController applicationTerminating]):
1340         (closePage):
1341         (runJavaScriptAlert):
1342         (runJavaScriptConfirm):
1343         (runJavaScriptPrompt):
1344         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1345         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1346         (didClearWindowObjectForFrame):
1347         * MiniBrowser/win/BrowserView.cpp:
1348         (BrowserView::goToURL):
1349         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1350         (WTR::PlatformWebView::~PlatformWebView):
1351
1352 2010-08-20  Benjamin Poulain  <benjamin.poulain@nokia.com>
1353
1354         Reviewed by Kenneth Rohde Christiansen.
1355
1356         WebKit does not build with Python 2.3
1357         https://bugs.webkit.org/show_bug.cgi?id=44373
1358
1359         Replaced the function sorted() by a call to sort()
1360         on the entry list.
1361         The function sorted() has been added to Python 2.4.
1362         The function method sort() of List works with older
1363         versions of Python.
1364
1365         * Scripts/create-html-entity-table:
1366
1367 2010-08-20  Martin Robinson  <mrobinson@igalia.com>
1368
1369         Reviewed by Pavel Feldman.
1370
1371         Web Inspector: Inspector tests were disabled for GTK.
1372         https://bugs.webkit.org/show_bug.cgi?id=43977
1373
1374         * Scripts/old-run-webkit-tests: Set the WEBKIT_INSPECTOR_PATH to the appropriate
1375         path before running tests.
1376
1377 2010-08-20  Daniel Bates  <dbates@rim.com>
1378
1379         Reviewed by Eric Seidel.
1380
1381         svn-apply doesn't detect empty line with Windows line endings
1382         after property value
1383         https://bugs.webkit.org/show_bug.cgi?id=43981
1384
1385         Part 2 of 2
1386
1387         Add unit tests that were not landed in the first commit.
1388
1389         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1390           - Added the following test cases:
1391             "SVN: binary file (isBinary true) using Windows line endings"
1392             "SVN: property diff, followed by file change diff using Windows line endings"
1393             "SVN: two consecutive property diffs using Windows line endings"
1394             "SVN: binary file with executable bit change usng Windows line endings"
1395             "SVN: binary file followed by property change on different file using Windows line endings"
1396             "SVN: binary file followed by file change on different file using Windows line endings"
1397             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1398             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1399         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1400           - Added the following test cases:
1401             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1402             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1403             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1404             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1405             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1406             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1407             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1408             "single-line '+' with trailing new line using Windows line endings"
1409             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1410             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1411             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1412         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1413           - Added the following test cases:
1414             "single-line '-' change followed by empty line with Windows line endings"
1415             "multi-line '+' change and start of binary patch with Windows line endings"
1416
1417 2010-08-20  Daniel Bates  <dbates@rim.com>
1418
1419         Reviewed by Eric Seidel.
1420
1421         svn-apply doesn't detect empty line with Windows line endings
1422         after property value
1423         https://bugs.webkit.org/show_bug.cgi?id=43981
1424
1425         Fixes an issue where an empty line following the property value
1426         in an SVN property change diff would not be detected if it had
1427         Windows line endings (i.e. ended in CRLF). Hence it was consumed
1428         as if it was part of a multi-line property value. 
1429
1430         * Scripts/VCSUtils.pm:
1431           - Modified parseSvnPropertyValue() to detect empty line
1432             with Windows line endings.
1433           - Added toWindowsLineEndings().
1434         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1435           - Added the following test cases:
1436             "SVN: binary file (isBinary true) using Windows line endings"
1437             "SVN: property diff, followed by file change diff using Windows line endings"
1438             "SVN: two consecutive property diffs using Windows line endings"
1439             "SVN: binary file with executable bit change usng Windows line endings"
1440             "SVN: binary file followed by property change on different file using Windows line endings"
1441             "SVN: binary file followed by file change on different file using Windows line endings"
1442             "SVN: file change diff with property change, followed by property change diff using Windows line endings"
1443             "SVN: file change diff with property change, followed by file change diff using Windows line endings"
1444         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1445           - Added the following test cases:
1446             "add svn:executable, followed by empty line and start of next diff using Windows line endings"
1447             "add svn:executable, followed by empty line and start of next property diff using Windows line endings"
1448             "multi-line '+' change, followed by empty line and start of next diff using Windows line endings"
1449             "multi-line '+' change, followed by empty line and start of next property diff using Windows line endings"
1450             "add svn:executable, followed by empty line and start of binary patch using Windows line endings"
1451             "multi-line '+' change, followed by empty line and start of binary patch using Windows line endings"
1452             "multi-line '-' change, followed by multi-line '+' change, empty line, and start of binary patch using Windows line endings"
1453             "single-line '+' with trailing new line using Windows line endings"
1454             "single-line '+' with trailing new line, followed by empty line and start of binary patch using Windows line endings"
1455             "single-line '-' change with trailing new line, and single-line '+' change using Windows line endings"
1456             "multi-line '-' change with trailing new line, and multi-line '+' change using Windows line endings"
1457         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1458           - Added the following test cases:
1459             "single-line '-' change followed by empty line with Windows line endings"
1460             "multi-line '+' change and start of binary patch with Windows line endings"
1461
1462 2010-08-19  David Kilzer  <ddkilzer@apple.com>
1463
1464         BUILD FIX: Fix Mac build after Windows WebKit2 changes for Netscape Plug-ins
1465
1466         * MiniBrowser/mac/BrowserWindowController.m:
1467         (decidePolicyForNavigationAction): Updated method signature.
1468         (decidePolicyForNewWindowAction): Updated method signature.
1469
1470 2010-08-19  Adam Roben  <aroben@apple.com>
1471
1472         Test that NP_Initialize and NP_GetEntryPoints are called in the
1473         correct order
1474
1475         The order differs between Mac and Windows (see r38858).
1476
1477         Fixes <http://webkit.org/b/44270> <rdar://problem/8330393> Crash in
1478         NP_Initialize when loading QuickTime when running
1479         plugins/embed-attributes-setting.html in WebKit2 on Windows
1480
1481         Reviewed by Sam Weinig.
1482
1483         * DumpRenderTree/TestNetscapePlugIn/main.cpp: Added a CRASH macro and
1484         a boolean to record whether NP_GetEntryPoints has been called.
1485         (NP_Initialize): Crash on Windows if NP_GetEntryPoints hasn't been
1486         called yet. This matches Flash and QuickTime's behavior. Crash on Mac
1487         if NP_GetEntryPoints has been called already. This matches
1488         Silverlight's behavior.
1489
1490 2010-08-19  Adam Roben  <aroben@apple.com>
1491
1492         Make build-webkittestrunner build TestNetscapePlugIn on Windows
1493
1494         Fixes <http://webkit.org/b/44268> <rdar://problem/8330388>
1495
1496         Reviewed by Sam Weinig.
1497
1498         * WebKitTestRunner/WebKitTestRunner.sln: Added TestNetscapePlugIn.
1499         Threaded it in between ImageDiff and InjectedBundleGenerated.
1500
1501 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1502
1503         Reviewed by Adam Barth.
1504
1505         install rietveld's upload script from a versioned url
1506         https://bugs.webkit.org/show_bug.cgi?id=44291
1507
1508         autoinstall expects the file at a given URL to never change.
1509         In order to be able to update the file, we need to be able to
1510         change the path.
1511
1512         * Scripts/webkitpy/thirdparty/__init__.py:
1513
1514 2010-08-19  Ojan Vafai  <ojan@chromium.org>
1515
1516         Reviewed by Adam Barth.
1517
1518         add --webkit_patch_id to reitveld uploads
1519         https://bugs.webkit.org/show_bug.cgi?id=44289
1520
1521         This is the first step in having rietveld store which
1522         patches have been uploaded and getting rid of the
1523         in-rietveld flag.
1524
1525         * Scripts/webkitpy/common/net/rietveld.py:
1526         * Scripts/webkitpy/tool/mocktool.py:
1527         * Scripts/webkitpy/tool/steps/postcodereview.py:
1528
1529 2010-08-19  Kenneth Russell  <kbr@google.com>
1530
1531         Reviewed by David Levin.
1532
1533         Adjust my status from committer to reviewer
1534         https://bugs.webkit.org/show_bug.cgi?id=44277
1535
1536         * Scripts/webkitpy/common/config/committers.py:
1537
1538 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
1539
1540         Reviewed by Yury Semikhatsky.
1541
1542         Chromium DevTools: remove injected script fetcher from test harness.
1543         https://bugs.webkit.org/show_bug.cgi?id=44266
1544
1545         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1546         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1547
1548 2010-08-19  Pavel Feldman  <pfeldman@chromium.org>
1549
1550         Reviewed by Yury Semikhatsky.
1551
1552         Chromium DevTools: There is no need in resource-based InjectedScript.js source.
1553         Now that we populate front-end after its onload handler, we don't need
1554         to install injected script early. Exposing injected script source on the WebCore
1555         level here.
1556         https://bugs.webkit.org/show_bug.cgi?id=44029
1557
1558         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
1559         (DRTDevToolsAgent::runtimePropertyChanged):
1560         (DRTDevToolsAgent::delayedFrontendLoaded):
1561         (DRTDevToolsAgent::frontendLoaded):
1562         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
1563
1564 2010-08-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1565
1566         Reviewed by Kenneth Rohde Christiansen.
1567
1568         [Gtk] Enable view mode media feature layout test
1569         https://bugs.webkit.org/show_bug.cgi?id=43278
1570
1571         Add view mode media feature testing infrastructure, and add
1572         placeholder methods for the other platforms'
1573         LayoutTestControllers.
1574
1575         * DumpRenderTree/LayoutTestController.cpp:
1576         (setViewModeMediaFeatureCallback):
1577         (LayoutTestController::staticFunctions):
1578         * DumpRenderTree/LayoutTestController.h:
1579         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1580         (LayoutTestController::setViewModeMediaFeature):
1581         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1582         (LayoutTestController::setViewModeMediaFeature):
1583         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1584         (LayoutTestController::setViewModeMediaFeature):
1585         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1586         (LayoutTestController::setViewModeMediaFeature):
1587
1588 2010-08-18  Mark Rowe  <mrowe@apple.com>
1589
1590         Reviewed by Sam Weinig.
1591
1592         Make it so the WebKit2 test slave runs the WebKit2 tests
1593
1594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1595
1596 2010-08-18  Sam Weinig  <sam@webkit.org>
1597
1598         Reviewed by Mark Rowe.
1599
1600         Make run-webkit-tests --webkit-test-runner build DumpRenderTree
1601         in addition to WebKitTestRunner to get the DumpRenderTreeSupport
1602         module and the TestNetscapePlugin.
1603
1604         * Scripts/old-run-webkit-tests:
1605
1606 2010-08-18  Adam Roben  <aroben@apple.com>
1607
1608         Fix hang when saving crash logs on Windows
1609
1610         * Scripts/old-run-webkit-tests:
1611         (setUpWindowsCrashLogSaving):
1612         (END):
1613         Pass -s to regtool so it will write the Auto value as a string instead
1614         of as a number. This was causing a "do you want to debug?" dialog to
1615         appear.
1616
1617 2010-08-17  Victor Wang  <victorw@chromium.org>
1618
1619         Unreviewed. Fixed chromium incremental test json upload.
1620         Quote builder name and test results server in url.
1621
1622         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1623
1624 2010-08-17  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1625
1626         Reviewed by Ariya Hidayat.
1627
1628         [Qt] [Symbian] Consistently use Q_OS_SYMBIAN to guard all Symbian platform dependencies
1629         https://bugs.webkit.org/show_bug.cgi?id=44124
1630
1631         Q_WS_S60 is not defined for Symbian^4 devices as Q_WS_S60 used to guard 
1632         Avkon UI framework dependencies. Use Q_OS_SYMBIAN everywhere to mark
1633         Symbian dependencies.
1634
1635         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1636         (WebCore::DumpRenderTree::open):
1637         * QtTestBrowser/launcherwindow.cpp:
1638         (LauncherWindow::init):
1639         (LauncherWindow::toggleFullScreenMode):
1640         (LauncherWindow::showFPS):
1641         (LauncherWindow::updateFPS):
1642         * QtTestBrowser/launcherwindow.h:
1643         (WindowOptions::WindowOptions):
1644         * QtTestBrowser/mainwindow.cpp:
1645         (MainWindow::buildUI):
1646
1647 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1648
1649         Reviewed by David Levin.
1650
1651         new-run-webkit-tests: remove --show-sources option
1652
1653         --show-sources is pretty much obsolete with --trace everything, so
1654         I'm removing it.
1655
1656         Also rename a couple of methods in the TestTextDiff class to make their
1657         intended visibility (private) more obvious.
1658
1659         https://bugs.webkit.org/show_bug.cgi?id=44143
1660
1661         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1662         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1663         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1664         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1665         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1666
1667 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1668
1669         Reviewed by David Levin.
1670
1671         remove --fuzzy-image-diff in new-run-webkit-tests (it doesn't work)
1672
1673         This code bit-rotted at some point more than a year ago, and nobody seems
1674         to miss it. old-run-webkit-tests has a --tolerance flag that new-run-webkit-tests
1675         should support instead, making this flag unnecessary anyway.
1676
1677         https://bugs.webkit.org/show_bug.cgi?id=44141
1678
1679         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1681         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Removed.
1682
1683 2010-08-17  Victor Wang  <victorw@chromium.org>
1684
1685         Reviewed by Ojan Vafai.
1686
1687         Update json results generator to have incremental json including
1688         results for tests that pass in current run but failed before.
1689
1690         https://bugs.webkit.org/show_bug.cgi?id=44119
1691
1692         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1693         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1694         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1695
1696 2010-08-17  Dirk Pranke  <dpranke@chromium.org>
1697
1698         Reviewed by Eric Seidel.
1699
1700         fix test-webkitpy, add easy way to find a checkout root
1701
1702         test-webkitpy currently doesn't work right if run from someplace other
1703         than the checkout root, and it spews a bunch of debug logging because
1704         the deduplicate_tests tests contaminates the test environment.
1705
1706         This patch cleans up the deduplicate_tests unit tests, and creates
1707         two new methods in scm.py: find_checkout_root() and default_scm(),
1708         both of which use a single algorithm for guessing what checkout root
1709         to use if you aren't explicitly told one from a path.
1710
1711         https://bugs.webkit.org/show_bug.cgi?id=44001
1712
1713         * Scripts/deduplicate-tests:
1714         * Scripts/webkitpy/common/checkout/scm.py:
1715         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1716         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
1717         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1718         * Scripts/webkitpy/layout_tests/port/test.py:
1719         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1720         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1721         * Scripts/webkitpy/tool/main.py:
1722
1723 2010-08-17  Victor Wang  <victorw@chromium.org>
1724
1725         Reviewed by Ojan Vafai.
1726
1727         Add support to the test results server for downloading json that
1728         contains test list only.
1729
1730         This is for json results generator to generate incremental json
1731         results so that it includes results not only for tests failed in
1732         current run, but also tests failed before.
1733
1734         Also set the results type to "N" (no data) instead of "P" (pass)
1735         if test results cannot be found in incremental json file.
1736
1737         https://bugs.webkit.org/show_bug.cgi?id=44117
1738
1739         * TestResultServer/handlers/testfilehandler.py:
1740         * TestResultServer/model/jsonresults.py:
1741         * TestResultServer/model/jsonresults_unittest.py:
1742
1743 2010-08-17  Adam Roben  <aroben@apple.com>
1744
1745         Use the right path style
1746
1747         * Scripts/old-run-webkit-tests:
1748
1749 2010-08-17  Adam Roben  <aroben@apple.com>
1750
1751         Fix typo
1752
1753         * Scripts/old-run-webkit-tests:
1754
1755 2010-08-17  Adam Roben  <aroben@apple.com>
1756
1757         Don't hang when running run-webkit-tests as a non-Administrator on
1758         Vista/7
1759
1760         * Scripts/old-run-webkit-tests:
1761         (setUpWindowsCrashLogSaving): Use regtool to set NTSD as the
1762         post-mortem debugger, rather than using NTSD itself. The latter waits
1763         for user input when it fails to set the registry values; the former
1764         does not.
1765
1766 2010-08-17  Adam Roben  <aroben@apple.com>
1767
1768         Teach run-webkit-tests, DumpRenderTree, and WebKitTestRunner how to
1769         save crash logs on Windows
1770
1771         The crash logs are saved to /tmp/layout-test-results and have names
1772         like CrashLog_02bc_2010-08-17_14-36-20-108.txt.
1773
1774         Unfortunately, crashes in the WebKit2 web process are recorded as
1775         time-outs by run-webkit-tests. Fixing this is covered by
1776         <http://webkit.org/b/44121>.
1777
1778         Fixes <http://webkit.org/b/37859> <rdar://problem/7883560>
1779         DumpRenderTree should save a stack trace and/or dump file when it
1780         crashes
1781
1782         Reviewed by Sam Weinig.
1783
1784         * DumpRenderTree/win/DumpRenderTree.cpp:
1785         (exceptionFilter):
1786         (main):
1787         * WebKitTestRunner/win/TestControllerWin.cpp:
1788         (WTR::exceptionFilter):
1789         (WTR::TestController::platformInitialize):
1790         These changes set up an exception filter that prints #CRASHED to
1791         stderr, then lets the exception propagate normally. This allows
1792         run-webkit-tests to detect when we've crashed even when a post-mortem
1793         debugger attaches to the process.
1794
1795         * Scripts/old-run-webkit-tests:
1796         (top level): Declared some variables used by the crash-log-saving
1797         code.
1798         (openDumpTool): Copy _NT_SYMBOL_PATH into the clean environment so
1799         that the post-mortem debugger has access to it.
1800         (toCygwinPath): Added. This is the opposite of toWindowsPath.
1801         (readFromDumpToolWithTimer): If the dump tool prints #CRASHED to
1802         stderr, consider it a crash.
1803         (setUpWindowsCrashLogSaving): Added. Saves the current post-mortem
1804         debugger, then sets ntsd as the post-mortem debugger. ntsd is
1805         configured to save a crash log and then quit automatically.
1806         (END): Added. Restores the previous post-mortem debugger when the
1807         script exits.
1808
1809 2010-08-17  Victor Wang  <victorw@chromium.org>
1810
1811         Reviewed by ojan@chromium.org.
1812
1813         Update test results server:
1814         1. Normalize test results and times after merging (prune tests where
1815            all runs pass or do not have data, truncate all test items to max
1816            number of builds)
1817         2. times should be int not string.
1818         3. when inserting a new test item, should keep old data regardless
1819            whether or not they have same item type with new one.
1820
1821         https://bugs.webkit.org/show_bug.cgi?id=43861
1822
1823         * TestResultServer/model/jsonresults.py:
1824         * TestResultServer/model/jsonresults_unittest.py:
1825
1826 2010-08-16  Sam Weinig  <sam@webkit.org>
1827
1828         Reviewed by Mark Rowe.
1829
1830         Add WebKit2 Mac tester to buildbot.
1831
1832         * BuildSlaveSupport/build.webkit.org-config/config.json:
1833         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1834
1835 2010-08-16  Paul Sawaya  <psawaya@apple.com>
1836
1837         Reviewed by Chris Marrin.
1838
1839         Added shader validation via ANGLE
1840         https://bugs.webkit.org/show_bug.cgi?id=42405
1841
1842         Added ANGLE to webkit build
1843
1844         * Scripts/build-webkit:
1845
1846 2010-08-16  Kevin Ollivier  <kevino@theolliviers.com>
1847
1848         [wx] Build fix, do not build WebCore as a convenience library as this leads to
1849         errors in the Win build w/export symbols and causes problems with DOM bindings
1850         debugging in gdb.
1851
1852         * DumpRenderTree/wscript:
1853         * Scripts/build-webkit:
1854         * wx/browser/wscript:
1855         * wx/build/settings.py:
1856         * wx/build/waf_extensions.py:
1857
1858 2010-08-16  Dan Bernstein  <mitz@apple.com>
1859
1860         Build fix.
1861
1862         * WebKitTestRunner/TestController.cpp:
1863         (WTR::createOtherPage): Initialize the contentsSizeChanged member.
1864         (WTR::TestController::initialize): Ditto.
1865
1866 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1867
1868         Reviewed by Kenneth Rohde Christiansen.
1869
1870         Handle content size change in WebKit2
1871         Re-landing after fix.
1872
1873         https://bugs.webkit.org/show_bug.cgi?id=43198
1874
1875         * MiniBrowser/mac/BrowserWindowController.m:
1876         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1877         * MiniBrowser/win/BrowserView.cpp:
1878         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1879
1880 2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1881
1882         Unreviewed, rolling out r65419.
1883         http://trac.webkit.org/changeset/65419
1884         https://bugs.webkit.org/show_bug.cgi?id=44053
1885
1886         Broke the Windows build (Requested by bbandix on #webkit).
1887
1888         * MiniBrowser/mac/BrowserWindowController.m:
1889         (-[BrowserWindowController awakeFromNib]):
1890         * MiniBrowser/win/BrowserView.cpp:
1891         (BrowserView::create):
1892
1893 2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>
1894
1895         Reviewed by Kenneth Rohde Christiansen.
1896
1897         Handle content size change in WebKit2
1898
1899         https://bugs.webkit.org/show_bug.cgi?id=43198
1900
1901         * MiniBrowser/mac/BrowserWindowController.m:
1902         (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
1903         * MiniBrowser/win/BrowserView.cpp:
1904         (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
1905
1906 2010-08-16  Ariya Hidayat  <ariya@sencha.com>
1907
1908         Add my new email address to committers.py.
1909
1910         * Scripts/webkitpy/common/config/committers.py:
1911
1912 2010-08-16  Zoltan Horvath  <zoltan@webkit.org>
1913
1914         Add my old e-mail addresses to committers.py.
1915
1916         * Scripts/webkitpy/common/config/committers.py:
1917
1918 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1919
1920         WebEditorClient::didBeginEditing is never called in WebKit2
1921         https://bugs.webkit.org/show_bug.cgi?id=42939
1922
1923         Reviewed by Sam Weinig.
1924
1925         * WebKitTestRunner/PlatformWebView.h:
1926         Declare focus().
1927
1928         * WebKitTestRunner/TestController.cpp:
1929         (WTR::TestController::resetStateToConsistentValues):
1930         Focus the PlatformWebView.
1931
1932         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1933         (WTR::PlatformWebView::focus):
1934         Stubbed.
1935
1936         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1937         (WTR::PlatformWebView::focus):
1938         Focus the view.
1939
1940 2010-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
1941
1942         run-webkit-tests should not strip editing callbacks when using
1943         WebKitTestRunner on Windows
1944         https://bugs.webkit.org/show_bug.cgi?id=44000
1945
1946         Reviewed by Mark Rowe.
1947
1948         * Scripts/old-run-webkit-tests:
1949         Leave $stripEditingCallbacks undefined until we look for command-line
1950         arguments. If using WebKit2, set it to 0 if not explicity set on the
1951         command line. Later, set it to isCygwin() to match old behavior if it is
1952         not yet defined.
1953
1954 2010-08-15  Kevin Ollivier  <kevino@theolliviers.com>
1955
1956         [wx] Build fix, remove define always set to the correct value by wtf/Platform.h.
1957
1958         * wx/build/settings.py:
1959
1960 2010-08-14  Martin Robinson  <mrobinson@igalia.com>
1961
1962         Reviewed by Kenneth Rohde Christiansen.
1963
1964         [GTK] autogen.sh not executed if build-webkit options change
1965         https://bugs.webkit.org/show_bug.cgi?id=42266
1966
1967         Rerun autogen.sh in situations where the arguments to build-webkit have
1968         changed since the previous build. This will fix some issues on the bots
1969         where the build does not notice changes to default build-webkit arguments.
1970
1971         * Scripts/webkitdirs.pm: Add special logic for detecting changes to build-webkit arguments.
1972
1973 2010-08-14  Eric Seidel  <eric@webkit.org>
1974
1975         Unreviewed.  Another fix to support python 2.3.
1976
1977         Add support for MathML entities
1978         https://bugs.webkit.org/show_bug.cgi?id=43949
1979
1980         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
1981          - It looks like our simplejson is version 1.7.3 which
1982            should be python 2.3 compatible.  But someone modified
1983            our copy slightly from the original source.
1984            I've removed the relative import in hopes this fixes
1985            the problem.
1986
1987 2010-08-13  Eric Seidel  <eric@webkit.org>
1988
1989         Unreviewed.  Build fix only.
1990
1991         Add support for MathML entities
1992         https://bugs.webkit.org/show_bug.cgi?id=43949
1993
1994         * Scripts/create-html-entity-table:
1995          - Hack sys.path to avoid executing 2.5 dependent python
1996            on systems (like chromium-win and Tiger) which do not have 2.5 python.
1997
1998 2010-08-13  Adam Barth  <abarth@webkit.org>
1999
2000         Reviewed by Eric Seidel.
2001
2002         Rename some concepts in HTML entity search to be more self-documenting
2003         https://bugs.webkit.org/show_bug.cgi?id=44004
2004
2005         Reflect name change in generator script.
2006
2007         * Scripts/create-html-entity-table:
2008
2009 2010-08-12  Adam Barth  <abarth@webkit.org>
2010
2011         Reviewed by Eric Seidel.
2012
2013         Add support for MathML entities
2014         https://bugs.webkit.org/show_bug.cgi?id=43949
2015
2016         A script for generating the C++ state data structure describing all the
2017         entities from a JSON description.
2018
2019         * Scripts/create-html-entity-table: Added.
2020
2021 2010-08-13  Dirk Pranke  <dpranke@chromium.org>
2022
2023         Reviewed by Eric Seidel.
2024
2025         Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to
2026         check for exceptions on all threads, not just the first thread.
2027         
2028         This change also changes the logging behavior for wedged threads
2029         to only dump the stacks of threads that are actually wedged.
2030
2031         Refactor the thread classes in the dump_render_tree_thread module
2032         to make the contract between TestRunner and TestShellThread clearer.
2033
2034         Added a bunch of unit tests.
2035         https://bugs.webkit.org/show_bug.cgi?id=38561
2036
2037         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2038         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2039         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2040
2041 2010-08-13  Kenichi Ishibashi  <bashi@google.com>
2042
2043         Reviewed by Shinichiro Hamaji.
2044
2045         Add test_expectations.txt syntax checker to check-webkit-style.
2046         https://bugs.webkit.org/show_bug.cgi?id=43899
2047
2048         Just utilizing layout_tests/layout_package/test_expectations.py for checking
2049         the syntax of test_expectations.txt.
2050         This change also moves tab checking class from style/checkers/text.py to
2051         style/checkers/common.py for sharing code.
2052
2053         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2054         * Scripts/webkitpy/style/checker.py:
2055         * Scripts/webkitpy/style/checkers/common.py:
2056         * Scripts/webkitpy/style/checkers/common_unittest.py:
2057         * Scripts/webkitpy/style/checkers/test_expectations.py: Added.
2058         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added.
2059         * Scripts/webkitpy/style/checkers/text.py:
2060         * Scripts/webkitpy/style_references.py:
2061
2062 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2063
2064         WebKitTestRunner does not correctly resize WebView for W3C SVG tests
2065         https://bugs.webkit.org/show_bug.cgi?id=43945
2066
2067         Reviewed by Sam Weinig.
2068
2069         * WebKitTestRunner/TestInvocation.cpp:
2070         (WTR::sizeWebViewForCurrentTest):
2071         Allow for a Windows-style path.
2072
2073         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2074         (WTR::PlatformWebView::resizeTo):
2075         Call SetWindowPos to resize the view window.
2076
2077 2010-08-12  David Levin  <levin@chromium.org>
2078
2079         Build break fix.
2080
2081         * WebKitTestRunner/TestController.cpp:
2082         (WTR::TestController::resetStateToConsistentValues): Removed usage
2083         of a variable that doesn't exist in the class.
2084
2085 2010-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2086
2087         WebKitTestRunner needs to run tests without using native controls
2088         https://bugs.webkit.org/show_bug.cgi?id=43772
2089
2090         Reviewed by Sam Weinig.
2091
2092         * WebKitTestRunner/TestController.cpp:
2093         (WTR::TestController::initialize):
2094         Call platformInitializeContext().
2095
2096         * WebKitTestRunner/TestController.h:
2097         Declare platformInitializeContext().
2098
2099         * WebKitTestRunner/mac/TestControllerMac.mm:
2100         (WTR::TestController::platformInitializeContext):
2101         Stubbed.
2102
2103         * WebKitTestRunner/win/TestControllerWin.cpp:
2104         (WTR::TestController::platformInitializeContext):
2105         Call WKContextSetShouldPaintNativeControls() to disable native control
2106         drawing.
2107
2108 2010-08-12  Sam Weinig  <sam@webkit.org>
2109
2110         Reviewed by Alexey Proskuryakov.
2111
2112         WebKitTestRunner should be more aggressive about ensuring consistent state between tests
2113         https://bugs.webkit.org/show_bug.cgi?id=43653
2114
2115         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2116         (WTR::InjectedBundle::InjectedBundle):
2117         (WTR::InjectedBundle::didReceiveMessage):
2118         (WTR::InjectedBundle::beginTesting):
2119         (WTR::InjectedBundle::done):
2120         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2121         (WTR::InjectedBundle::isTestRunning):
2122         (WTR::InjectedBundle::):
2123         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2124         (WTR::InjectedBundlePage::stopLoading):
2125         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2126         (WTR::InjectedBundlePage::dump):
2127         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2128         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2129         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2130         (WTR::InjectedBundlePage::didClearWindowForFrame):
2131         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2132         (WTR::InjectedBundlePage::willAddMessageToConsole):
2133         (WTR::InjectedBundlePage::willSetStatusbarText):
2134         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2135         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2136         (WTR::InjectedBundlePage::shouldBeginEditing):
2137         (WTR::InjectedBundlePage::shouldEndEditing):
2138         (WTR::InjectedBundlePage::shouldInsertNode):
2139         (WTR::InjectedBundlePage::shouldInsertText):
2140         (WTR::InjectedBundlePage::shouldDeleteRange):
2141         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2142         (WTR::InjectedBundlePage::shouldApplyStyle):
2143         (WTR::InjectedBundlePage::didBeginEditing):
2144         (WTR::InjectedBundlePage::didEndEditing):
2145         (WTR::InjectedBundlePage::didChange):
2146         (WTR::InjectedBundlePage::didChangeSelection):
2147         Don't do any work if we are not currently running a test.
2148
2149         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2150         * WebKitTestRunner/StringFunctions.h:
2151         (WTR::toCF):
2152         Add conversion function for WKURLRef -> CFURLRef
2153
2154         * WebKitTestRunner/TestController.cpp:
2155         (WTR::TestController::TestController):
2156         (WTR::TestController::initialize):
2157         (WTR::TestController::resetStateToConsistentValues):
2158         (WTR::TestController::runTest):
2159         (WTR::TestController::didFinishLoadForFrame):
2160         * WebKitTestRunner/TestController.h:
2161         (WTR::TestController::):
2162         * WebKitTestRunner/TestInvocation.cpp:
2163         (WTR::TestInvocation::invoke):
2164         * WebKitTestRunner/TestInvocation.h:
2165         Move resetting code to TestController.
2166
2167         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2168         * WebKitTestRunner/mac/TestControllerMac.mm:
2169         (WTR::TestController::runUntil):
2170         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2171         * WebKitTestRunner/win/TestControllerWin.cpp:
2172         (WTR::TestController::runUntil):
2173         * WebKitTestRunner/win/TestInvocationWin.cpp: Removed.
2174         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2175         Move runUntil to TestController.
2176
2177 2010-08-12  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2178
2179         Unreviewed.
2180
2181         Adding myself to the committers list.
2182
2183         * Scripts/webkitpy/common/config/committers.py:
2184
2185 2010-08-12  Hayato Ito  <hayato@chromium.org>
2186
2187         Reviewed by Tony Chang.
2188
2189         Merge pretty printers for gdb.
2190         https://bugs.webkit.org/show_bug.cgi?id=43850
2191
2192         We need to update webcore.py because basic string classes have moved to WTF from WebCore.
2193         It is good timing to merge webcore.py and wtf.py and name it 'webkit.py'.
2194         webcore.py is left for backward compatibility.
2195
2196         * gdb/webcore.py:
2197         * gdb/webkit.py: Added.
2198         * gdb/wtf.py: Removed.
2199
2200 2010-08-11  Tony Chang  <tony@chromium.org>
2201
2202         Reviewed by David Levin.
2203
2204         [chromium] add google-chrome layout test result directories
2205         https://bugs.webkit.org/show_bug.cgi?id=43889
2206
2207         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2208         * Scripts/webkitpy/layout_tests/port/factory.py:
2209         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Added.
2210         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2211
2212 2010-08-11  Kent Tamura  <tkent@chromium.org>
2213
2214         Reviewed by Dimitri Glazkov.
2215
2216         [DRT/Chromium] Disable accelerated compositing
2217         https://bugs.webkit.org/show_bug.cgi?id=43894
2218
2219         Disable accelerated compositing because DRT is not ready for
2220         it. This change fixes hundreds of test crashes on Windows and
2221         Linux.
2222
2223         * DumpRenderTree/chromium/TestShell.cpp:
2224         (TestShell::resetWebSettings):
2225
2226 2010-08-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2227
2228         Unreviewed. Adding my Collabora personality to the list.
2229
2230         * Scripts/webkitpy/common/config/committers.py:
2231
2232 2010-08-11  Martin Robinson  <mrobinson@igalia.com>
2233
2234         Adding myself as a reviewer.
2235
2236         * Scripts/webkitpy/common/config/committers.py:
2237
2238 2010-08-11  Daniel Bates  <dbates@rim.com>
2239
2240         Reviewed by Darin Adler.
2241
2242         Perl warnings when running commit-log-editor
2243         https://bugs.webkit.org/show_bug.cgi?id=43856
2244
2245         Fixes Perl warnings introduced by the patch for Bug #40548.
2246
2247         Perl doesn't have symbolic names for True/False. Instead, we
2248         should use boolean values. Moreover, the variable installedEditorApplication
2249         is not be used and should be renamed builtEditorApplication so that it
2250         uses the existing machinery to set the commit log editor application.
2251
2252         * Scripts/commit-log-editor:
2253
2254 2010-08-11  Adam Barth  <abarth@webkit.org>
2255
2256         Reviewed by Eric Seidel.
2257
2258         Trying waiting for httpd lock in the EWS
2259         https://bugs.webkit.org/show_bug.cgi?id=43833
2260
2261         If this works, we can probably run the tests on the mac-ews, which
2262         would be very exciting.  :)
2263
2264         * Scripts/webkitpy/tool/steps/runtests.py:
2265
2266 2010-08-11  Marcus Bulach  <bulach@chromium.org>
2267
2268         Reviewed by Eric Seidel.
2269
2270         Check in a script to list redundant test outputs.
2271         https://bugs.webkit.org/show_bug.cgi?id=37630
2272
2273         If e.g. platform/mac-leopard is missing an expected test output, we
2274         fall back on platform/mac.  This means it's possible to grow redundant
2275         test outputs, where we have the same expected data in both a platform
2276         directory and another platform it falls back on.
2277         (original patch by Evan Marting <evan@chromium.org> https://bugs.webkit.org/attachment.cgi?id=53398)
2278
2279         * Scripts/deduplicate-tests: Added.
2280         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Added.
2281         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Added.
2282
2283 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2284
2285         Reviewed by Ariya Hidayat.
2286
2287         [Qt] QtTestBrowser: after switching between QWebView and QGraphicsWebView, rotation actions get broken
2288         https://bugs.webkit.org/show_bug.cgi?id=43853
2289
2290         LauncherWindow::createChrome is connecting menu itens to WebViewGraphicsBased's slots directly.
2291         It behaviors badly when user launches the QtTestBrowser in QWebView mode, since then switching to
2292         QGraphicsWebView mode, createChrome is not called again, and menu items end up not getting connected
2293         to slots at all.
2294
2295         * QtTestBrowser/launcherwindow.cpp:
2296         (LauncherWindow::createChrome):
2297         (LauncherWindow::animatedFlip):
2298         (LauncherWindow::animatedYFlip):
2299         * QtTestBrowser/launcherwindow.h:
2300
2301 2010-08-11  Antonio Gomes  <tonikitoo@webkit.org>
2302
2303         Reviewed by Simon Hausmann.
2304
2305         [Qt] QtTestBrowser: switching between QWebView and QGraphicsWebView modes is broken
2306         https://bugs.webkit.org/show_bug.cgi?id=43851
2307
2308         All window options data (including the bool holding if the view is either QWebView or
2309         QGraphicsWebView based) is stored in m_windowOptions, a class member of LauncherWindow.
2310         When toggle the view from QWebView to QGraphicsWebView based (and vice-versa), we were
2311         not updating LauncherWindow::WindowOptions::m_useGraphicsView bit, and then things were
2312         getting broken.
2313
2314         Patch addresses this issue.
2315
2316         * QtTestBrowser/launcherwindow.cpp:
2317         (LauncherWindow::createChrome):
2318         (LauncherWindow::toggleWebView):
2319         (LauncherWindow::toggleAcceleratedCompositing):
2320
2321 2010-08-10  Antonio Gomes  <tonikitoo@webkit.org>
2322
2323         Reviewed by Ariya Hidayat.
2324
2325         [Qt] QtTestBrowser: lazy instantiate "YRotation" state machine and related objects
2326         https://bugs.webkit.org/show_bug.cgi?id=43831
2327
2328         Only instantiate QStateMachine and friends associated to the YRotation action on demand.
2329
2330         * QtTestBrowser/webview.cpp:
2331         (WebViewGraphicsBased::WebViewGraphicsBased):
2332         (WebViewGraphicsBased::animatedYFlip):
2333
2334 2010-08-11  Darin Adler  <darin@apple.com>
2335
2336         Reviewed by John Sullivan.
2337
2338         Improved editor options for prepare-ChangeLog and commit-log-editor
2339         https://bugs.webkit.org/show_bug.cgi?id=40548
2340
2341         * Scripts/commit-log-editor: Split editor strings on spaces so EDITOR
2342         values like "xed --launch --wait" work properly.
2343
2344         * Scripts/prepare-ChangeLog: Added a new CHANGE_LOG_EDITOR so we can
2345         use a command line tool with the $openChangeLogs feature.
2346
2347 2010-08-11  Yury Semikhatsky  <yurys@chromium.org>
2348
2349         Reviewed by Pavel Feldman.
2350
2351         Web Inspector: remove InjectDispatch.js
2352         https://bugs.webkit.org/show_bug.cgi?id=43835
2353
2354         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2355         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2356
2357 2010-08-10  Dirk Pranke  <dpranke@chromium.org>
2358
2359         Reviewed by Eric Seidel.
2360
2361         webkit-patch should refuse to run under Win32 Python
2362         https://bugs.webkit.org/show_bug.cgi?id=40962
2363
2364         Given that there are lots of places in webkit-patch's code that
2365         assume unix-style filenames (forward slashes), webkit-patch fails
2366         with weird file-not-found errors when run under a native windows
2367         Python. It would be nice if we just trapped this and errored out
2368         at the beginning, rather than producing unpredictable errors.
2369
2370         * Scripts/webkit-patch:
2371
2372 2010-08-10  Kent Tamura  <tkent@chromium.org>
2373
2374         Unreviewed, build fix.
2375         
2376         Chromium build fix for r65107.
2377
2378         * DumpRenderTree/chromium/LayoutTestController.cpp:
2379         (LayoutTestController::suspendAnimations):
2380         (LayoutTestController::resumeAnimations):
2381
2382 2010-08-10  Sergio Villar Senin  <svillar@igalia.com>
2383
2384         Reviewed by Xan Lopez.
2385
2386         [GTK] http/tests/media/video-cookie.html fails
2387         https://bugs.webkit.org/show_bug.cgi?id=42240
2388
2389         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2390         (LayoutTestController::setAlwaysAcceptCookies): create the
2391         SoupCookieJar if it does not exist. Otherwise the accept policy
2392         won't be set.
2393
2394 2010-08-10  Chris Marrin  <cmarrin@apple.com>
2395
2396         Reviewed by Oliver Hunt.
2397
2398         Add suspendAnimations/resumeAnimation API to DRT
2399         https://bugs.webkit.org/show_bug.cgi?id=43733
2400         
2401         Adds suspendAnimations() and resumeAnimations() to LayoutTestController.
2402         Calls functions with the same names on AnimationController for the 
2403         mainFrame.
2404
2405         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2406         * DumpRenderTree/LayoutTestController.cpp:
2407         (suspendAnimationsCallback):
2408         (resumeAnimationsCallback):
2409         (LayoutTestController::staticFunctions):
2410         * DumpRenderTree/LayoutTestController.h:
2411         * DumpRenderTree/chromium/LayoutTestController.cpp:
2412         (LayoutTestController::LayoutTestController):
2413         (LayoutTestController::suspendAnimations):
2414         (LayoutTestController::resumeAnimations):
2415         * DumpRenderTree/chromium/LayoutTestController.h:
2416         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2417         (LayoutTestController::suspendAnimations):
2418         (LayoutTestController::resumeAnimations):
2419         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2420         (LayoutTestController::suspendAnimations):
2421         (LayoutTestController::resumeAnimations):
2422         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2423         (LayoutTestController::suspendAnimations):
2424         (LayoutTestController::resumeAnimations):
2425         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2426         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2427         (LayoutTestController::suspendAnimations):
2428         (LayoutTestController::resumeAnimations):
2429         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2430         (LayoutTestController::suspendAnimations):
2431         (LayoutTestController::resumeAnimations):
2432
2433 2010-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
2434
2435         Reviewed by Ojan Vafai.
2436
2437         [Chromium/DRT] Enable saving layout test results.
2438         https://bugs.webkit.org/show_bug.cgi?id=43796
2439
2440         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added more
2441             parameters to the new-run-webkit-tests, including the name
2442             of the test results server.
2443
2444 2010-08-10  Jian Li  <jianli@chromium.org>
2445
2446         More chromium build fix.
2447
2448         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2449         (MockSpellCheck::spellCheckWord):
2450         (MockSpellCheck::initializeIfNeeded):
2451         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2452         (NotificationPresenter::grantPermission):
2453         (NotificationPresenter::show):
2454         (NotificationPresenter::checkPermission):
2455
2456 2010-08-10  Jian Li  <jianli@chromium.org>
2457
2458         Chromium build fix.
2459
2460         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2461         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2462
2463 2010-08-10  Victor Wang  <victorw@chromium.org>
2464
2465         Reviewed by Ojan Vafai.
2466
2467         Update test results server merge logic so the aggregated
2468         results and times are updated for tests that are
2469         in aggragated json but not in incremental json.
2470
2471         Also update unittest to test this case.
2472
2473         https://bugs.webkit.org/show_bug.cgi?id=43769
2474
2475         * TestResultServer/model/jsonresults.py:
2476         * TestResultServer/model/jsonresults_unittest.py:
2477
2478 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2479
2480         Reviewed by Ariya Hidayat.
2481
2482         [Qt] QtTestBrowser: proper set scene rect
2483
2484         When resizesToContents is ON scene's rect is set to the boundary of
2485         the mainFrame. However, navigating to other web page should keep resizing
2486         scene's rect according to the new document loaded. Patch addresses this issue.
2487
2488         Now resizesToContents and scrolling properly work on QtTestBrowser.
2489
2490         * QtTestBrowser/webview.cpp:
2491         (WebViewGraphicsBased::setPage):
2492         (WebViewGraphicsBased::contentsSizeChanged):
2493         (WebViewGraphicsBased::setResizesToContents):
2494         (WebViewGraphicsBased::resizeEvent):
2495         * QtTestBrowser/webview.h:
2496
2497 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2498
2499         Reviewed by Ariya Hidayat.
2500
2501         [Qt] QtTestBrowser: Clean up LauncherWindow code.
2502
2503         * QtTestBrowser/launcherwindow.cpp:
2504         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
2505         (LauncherWindow::init): Fixed comments.
2506         (LauncherWindow::applyPrefs): Move the method around.
2507         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
2508
2509 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2510
2511         Reviewed by Ariya Hidayat.
2512
2513         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
2514
2515         It gets control+0 the same visual effect as control++ or control-.
2516
2517         * QtTestBrowser/launcherwindow.cpp:
2518         (LauncherWindow::toggleZoomTextOnly):
2519
2520 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
2521
2522         Reviewed by Ariya Hidayat.
2523
2524         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
2525
2526         Not all instances of LauncherWindow need its own m_zoomLevel.
2527
2528         * QtTestBrowser/launcherwindow.cpp:
2529         * QtTestBrowser/launcherwindow.h:
2530
2531 2010-08-09  Sam Weinig  <sam@webkit.org>
2532
2533         Reviewed by Geoffrey Garen.
2534
2535         Add zoom support for injected bundle
2536         https://bugs.webkit.org/show_bug.cgi?id=43759
2537
2538         Use zoom factor SPI to implement zoom related eventSender functions.
2539
2540         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2541         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2542         (WTR::EventSendingController::textZoomIn):
2543         (WTR::EventSendingController::textZoomOut):
2544         (WTR::EventSendingController::zoomPageIn):
2545         (WTR::EventSendingController::zoomPageOut):
2546         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2547         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2548         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
2549
2550 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
2551
2552         Speculative chromium build fix III.
2553
2554         * DumpRenderTree/chromium/MockSpellCheck.h:
2555         * DumpRenderTree/chromium/NotificationPresenter.h:
2556         * DumpRenderTree/chromium/WebViewHost.h:
2557         (WebViewHost::addClearHeader):
2558         (WebViewHost::clearHeaders):
2559
2560 2010-08-09  Ojan Vafai  <ojan@chromium.org>
2561
2562         Reviewed by Tony Chang.
2563
2564         increase the number of test results that we save
2565         https://bugs.webkit.org/show_bug.cgi?id=43763
2566
2567         Now that we do incremental uploads, we can increase the number of
2568         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
2569
2570         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2571
2572 2010-08-09  Evan Martin  <evan@chromium.org>
2573
2574         Reviewed by Tony Chang.
2575
2576         [chromium] DRT error print statement incorrectly tries to print a FILE*
2577         https://bugs.webkit.org/show_bug.cgi?id=43747
2578
2579         * DumpRenderTree/chromium/ImageDiff.cpp:
2580         (writeFile): pass the correct pointer.
2581
2582 2010-08-09  Victor Wang  <victorw@chromium.org>
2583
2584         Reviewed by Ojan Vafai.
2585
2586         Upload incremental test results json to server by default.
2587
2588         https://bugs.webkit.org/show_bug.cgi?id=43743
2589
2590         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2591
2592 2010-08-09  Eric Seidel  <eric@webkit.org>
2593
2594         Reviewed by Adam Barth.
2595
2596         EWS bots wait 2 minutes between patches
2597         https://bugs.webkit.org/show_bug.cgi?id=43731
2598
2599         * Scripts/webkitpy/tool/bot/queueengine.py:
2600          - Don't sleep after failures.  This was a hold-over from
2601            an earlier design.
2602         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2603          - EWS bots were not properly reporting true/false from process_work_item.
2604            They were always returning None, thus false, thus always logging
2605            as a failure and sleeping 2 minutes after each patch.
2606
2607 2010-08-09  Sam Weinig  <sam@webkit.org>
2608
2609         Reviewed by Anders Carlsson.
2610
2611         Stub out EventSender for WebKitTestRunner
2612         https://bugs.webkit.org/show_bug.cgi?id=43703
2613
2614         * WebKitTestRunner/DerivedSources.make:
2615         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2616         Add ability to pass javascript arguments to the wrapped object.
2617
2618         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
2619         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
2620         (WTR::EventSendingController::create):
2621         (WTR::EventSendingController::EventSendingController):
2622         (WTR::EventSendingController::~EventSendingController):
2623         (WTR::EventSendingController::wrapperClass):
2624         (WTR::setExceptionForString):
2625         (WTR::EventSendingController::mouseDown):
2626         (WTR::EventSendingController::mouseUp):
2627         (WTR::EventSendingController::mouseMoveTo):
2628         (WTR::EventSendingController::keyDown):
2629         (WTR::EventSendingController::contextClick):
2630         (WTR::EventSendingController::leapForward):
2631         (WTR::EventSendingController::textZoomIn):
2632         (WTR::EventSendingController::textZoomOut):
2633         (WTR::EventSendingController::zoomPageIn):
2634         (WTR::EventSendingController::zoomPageOut):
2635         (WTR::EventSendingController::makeWindowObject):
2636         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
2637         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2638         (WTR::InjectedBundle::reset):
2639         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2640         (WTR::InjectedBundle::eventSendingController):
2641         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2642         (WTR::InjectedBundlePage::didClearWindowForFrame):
2643         Add stubbed out EventSenderController.
2644
2645         * WebKitTestRunner/InjectedBundle/GCController.h:
2646         Remove incorrect comment.
2647
2648         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2649         * WebKitTestRunner/win/InjectedBundle.vcproj:
2650         Add new files.
2651
2652 2010-08-08  Kent Tamura  <tkent@chromium.org>
2653
2654         Unreviewed, trivial fix.
2655
2656         Fix "WindowsError: [Error 32] The process cannot access the file
2657         because it is being used by another process" introduced by r64959.
2658
2659         * BuildSlaveSupport/test-result-archive:
2660
2661 2010-08-08  Kent Tamura  <tkent@chromium.org>
2662
2663         Reviewed by Tony Chang.
2664
2665         Chromium buildbot: Avoid "zip" command dependency
2666         https://bugs.webkit.org/show_bug.cgi?id=43470
2667
2668         * BuildSlaveSupport/test-result-archive:
2669          For Chromium port, creates a zip archive with zipfile package of Python
2670          instead of external "zip" command. We'd like to avoid additional
2671          command installation.
2672
2673 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
2674
2675         WebKitTestRunner should add the QuickTime dir to the PATH environment
2676         variable
2677         https://bugs.webkit.org/show_bug.cgi?id=43686
2678
2679         Reviewed by Dan Bernstein.
2680
2681         * WebKitTestRunner/win/TestControllerWin.cpp:
2682         (WTR::addQTDirToPATH):
2683         Copied from DRT.
2684         (WTR::TestController::platformInitialize):
2685         Call addQTDirToPath().
2686         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2687         Link to shlwapi.lib for SHGetValue.
2688
2689 2010-08-07  Sam Weinig  <sam@webkit.org>
2690
2691         Reviewed by Maciej Stachowiak.
2692
2693         WebKitTestRunner needs layoutTestController.dumpTitleChanges
2694         <rdar://problem/8213861>
2695         https://bugs.webkit.org/show_bug.cgi?id=42683
2696
2697         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2698         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2699         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2700         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2701         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2702         (WTR::LayoutTestController::LayoutTestController):
2703         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2704         (WTR::LayoutTestController::dumpTitleChanges):
2705         (WTR::LayoutTestController::shouldDumpTitleChanges):
2706
2707 2010-08-07  Sam Weinig  <sam@webkit.org>
2708
2709         Reviewed by Anders Carlsson.
2710
2711         WebKitTestRunner needs to print onunload handler information
2712         <rdar://problem/8213831>
2713         https://bugs.webkit.org/show_bug.cgi?id=42703
2714
2715         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2716         (WTR::operator<<):
2717         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2718
2719 2010-08-07  Sam Weinig  <sam@webkit.org>
2720
2721         Reviewed by Anders Carlsson.
2722
2723         Add additional loader client functions need to complete WebKitTestRunner
2724         https://bugs.webkit.org/show_bug.cgi?id=43684
2725
2726         Remove unnecessary and jarring underscores as well.
2727
2728         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2729         (didClearWindowObjectForFrame):
2730         (didCreatePage):
2731         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2732         (WTR::InjectedBundlePage::InjectedBundlePage):
2733         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2734         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2735         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2736         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2737         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2738         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2739         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2740         (WTR::InjectedBundlePage::didClearWindowForFrame):
2741         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
2742         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
2743         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2744         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2745         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
2746         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
2747         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
2748         (WTR::InjectedBundlePage::willAddMessageToConsole):
2749         (WTR::InjectedBundlePage::willSetStatusbarText):
2750         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2751         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2752         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2753         (WTR::InjectedBundlePage::shouldBeginEditing):
2754         (WTR::InjectedBundlePage::shouldEndEditing):
2755         (WTR::InjectedBundlePage::shouldInsertNode):
2756         (WTR::InjectedBundlePage::shouldInsertText):
2757         (WTR::InjectedBundlePage::shouldDeleteRange):
2758         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2759         (WTR::InjectedBundlePage::shouldApplyStyle):
2760         (WTR::InjectedBundlePage::didBeginEditing):
2761         (WTR::InjectedBundlePage::didEndEditing):
2762         (WTR::InjectedBundlePage::didChange):
2763         (WTR::InjectedBundlePage::didChangeSelection):
2764         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2765
2766 2010-08-07  Dan Bernstein  <mitz@apple.com>
2767
2768         Build fix.
2769
2770         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
2771         to JSGCController.{cpp,h} relative to the build root.
2772
2773 2010-08-07  Sam Weinig  <sam@webkit.org>
2774
2775         Reviewed by Anders Carlsson.
2776
2777         WebKitTestRunner needs GCController
2778         <rdar://problem/8213834>
2779         https://bugs.webkit.org/show_bug.cgi?id=42701
2780
2781         * WebKitTestRunner/DerivedSources.make:
2782         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
2783         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
2784         (WTR::setProperty):
2785         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
2786         (WTR::GCController::create):
2787         (WTR::GCController::GCController):
2788         (WTR::GCController::~GCController):
2789         (WTR::GCController::wrapperClass):
2790         (WTR::GCController::collect):
2791         (WTR::GCController::collectOnAlternateThread):
2792         (WTR::GCController::getJSObjectCount):
2793         (WTR::GCController::makeWindowObject):
2794         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
2795         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2796         (WTR::InjectedBundle::reset):
2797         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2798         (WTR::InjectedBundle::bundle):
2799         (WTR::InjectedBundle::gcController):
2800         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2801         (WTR::InjectedBundlePage::didClearWindowForFrame):
2802         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2803         (WTR::LayoutTestController::keepWebHistory):
2804         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2805         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2806         * WebKitTestRunner/win/InjectedBundle.vcproj:
2807
2808 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
2809
2810         WebKitTestRunner needs to be able to set the font smoothing type
2811         https://bugs.webkit.org/show_bug.cgi?id=43406
2812
2813         Reviewed by Adam Roben.
2814
2815         * WebKitTestRunner/TestInvocation.cpp:
2816         (WTR::TestInvocation::resetPreferencesToConsistentValues):
2817         Set the font smoothing level to
2818         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
2819
2820 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2821
2822         Fix a missed variable rename.
2823
2824         Unreviewed.
2825
2826         * Scripts/old-run-webkit-tests:
2827
2828 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
2829
2830         mac-wk2/Skipped should be used on Windows when running regression tests
2831         https://bugs.webkit.org/show_bug.cgi?id=43494
2832
2833         Reviewed by Adam Roben.
2834
2835         * Scripts/old-run-webkit-tests:
2836         If the platform is win-wk2, also read the mac-wk2 skipped list.
2837
2838 2010-08-06  Kent Tamura  <tkent@chromium.org>
2839
2840         Reviewed by Dimitri Glazkov.
2841
2842         [DRT/Chromium] Should revoke scheduled tasks
2843         https://bugs.webkit.org/show_bug.cgi?id=43560
2844
2845         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2846         (DRTDevToolsAgent::reset): Calls RevokeAll().
2847         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2848         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2849         (DRTDevToolsClient::reset): Calls RevokeAll().
2850         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2851         * DumpRenderTree/chromium/EventSender.cpp:
2852         (EventSender::reset): Calls RevokeAll().
2853         * DumpRenderTree/chromium/LayoutTestController.cpp:
2854         (LayoutTestController::reset): Calls RevokeAll().
2855         * DumpRenderTree/chromium/TestShell.cpp:
2856         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
2857
2858 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2859
2860         Reviewed by Antonio Gomes.
2861
2862         [Qt] Fix the DRT build on Mac OS X
2863
2864         * DumpRenderTree/qt/DumpRenderTree.pro:
2865
2866 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
2867
2868         Reviewed by Pavel Feldman.
2869
2870         Rietvield's upload.py moved to a different location.
2871         https://bugs.webkit.org/show_bug.cgi?id=43613
2872
2873         * Scripts/webkitpy/thirdparty/__init__.py:
2874
2875 2010-05-23  Eric Seidel  <eric@webkit.org>
2876
2877         Reviewed by Adam Barth.
2878
2879         QueueStatusServer needs better queue-status pages
2880         https://bugs.webkit.org/show_bug.cgi?id=39562
2881
2882         The primary goal of this patch is to display queue
2883         positions somewhere on the site so that it's easier
2884         for commit-queue users to know when their pach will
2885         be landed.  I also tried to improve the root page
2886         to be more useful than the previous wall of status text.
2887
2888         * QueueStatusServer/handlers/recentstatus.py:
2889         * QueueStatusServer/main.py:
2890         * QueueStatusServer/model/queues.py:
2891         * QueueStatusServer/templates/recentstatus.html:
2892
2893 2010-08-05  Victor Wang  <victorw@chromium.org>
2894
2895         Reviewed by Ojan Vafai.
2896
2897         Add option to generate/upload incremental json results to test result server.
2898         Also refactor the json results generator unittest code to test
2899         incremental and aggregated json results.
2900
2901         https://bugs.webkit.org/show_bug.cgi?id=43519
2902
2903         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2904         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2905         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2906         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2907
2908 2010-08-05  Jian Li  <jianli@chromium.org>
2909
2910         Reviewed by David Levin.
2911
2912         Unify blob related feature defines to ENABLE(BLOB).
2913         https://bugs.webkit.org/show_bug.cgi?id=43081
2914
2915         * Scripts/build-webkit:
2916
2917 2010-08-05  Satish Sampath  <satish@chromium.org>
2918
2919         Reviewed by Jeremy Orlow.
2920
2921         Add speech input controller mock in WebKit and a layout test.
2922         https://bugs.webkit.org/show_bug.cgi?id=43477
2923
2924         Added LayoutTestController::setMockSpeechInputResultCallback method.
2925
2926         * DumpRenderTree/LayoutTestController.cpp:
2927         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
2928         (LayoutTestController::staticFunctions):
2929         * DumpRenderTree/LayoutTestController.h:
2930         * DumpRenderTree/chromium/LayoutTestController.cpp:
2931         (LayoutTestController::LayoutTestController):
2932         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
2933         (LayoutTestController::speechInputController): Creates the mock controller.
2934         * DumpRenderTree/chromium/LayoutTestController.h:
2935         * DumpRenderTree/chromium/WebViewHost.cpp:
2936         (WebViewHost::speechInputController): Creates the mock controller.
2937         * DumpRenderTree/chromium/WebViewHost.h:
2938         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2939         (LayoutTestController::setMockSpeechInputResult): dummy method.
2940         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2941         (LayoutTestController::setMockSpeechInputResult): dummy method.
2942         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2943         (LayoutTestController::setMockSpeechInputResult): dummy method.
2944         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2945         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
2946         (LayoutTestController::setMockSpeechInputResult):
2947         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
2948         (LayoutTestController::setMockSpeechInputResult):
2949
2950 2010-08-04  Adam Roben  <aroben@apple.com>
2951
2952         Fix the path to TestNetscapePlugin's directory on Windows
2953
2954         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
2955         load TestNetscapePlugin
2956
2957         Reviewed by Jon Honeycutt.
2958
2959         * WebKitTestRunner/win/TestControllerWin.cpp:
2960         (WTR::TestController::initializeTestPluginDirectory):
2961         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
2962         next to WebKitTestRunner.exe. Previously we were passing the directory
2963         that contains WebKitTestRunner.exe. Also fixed some leaks.
2964
2965 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
2966
2967         Reviewed by Shinichiro Hamaji.
2968
2969         check-webkit-style returns non-zero when patch is entirely minus lines.
2970         https://bugs.webkit.org/show_bug.cgi?id=38169
2971
2972         * Scripts/check-webkit-style:
2973         Check whether a patch contains modified files that are entirely minus lines.
2974         * Scripts/webkitpy/style/filereader.py:
2975         Add a variable that holds number of files that contain only deleted lines.
2976         * Scripts/webkitpy/style/patchreader.py:
2977         Count up modified files that contain only deleted lines.
2978
2979 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
2980
2981         Reviewed by Yury Semikhatsky.
2982
2983         DevTools: get rid of delayed command dispatching on front-end side.
2984
2985         https://bugs.webkit.org/show_bug.cgi?id=43479
2986
2987         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2988         (DRTDevToolsAgent::detach):
2989         (DRTDevToolsAgent::frontendLoaded):
2990         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2991         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2992         (DRTDevToolsClient::~DRTDevToolsClient):
2993         (DRTDevToolsClient::sendFrontendLoaded):
2994         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2995
2996 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
2997
2998         Reviewed by Shinichiro Hamaji.
2999
3000         Fixes check-webkit-style false positive on "new uint32_t."
3001         https://bugs.webkit.org/show_bug.cgi?id=43077
3002
3003         * Scripts/webkitpy/style/checkers/cpp.py:
3004         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3005
3006 2010-08-04  Kent Tamura  <tkent@chromium.org>
3007
3008         Reviewed by Dimitri Glazkov.
3009
3010         [DRT/Chromium] Remove base/linked_ptr.h dependency
3011         https://bugs.webkit.org/show_bug.cgi?id=43472
3012
3013         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
3014         We need to use RefPtr<> because m_pendingEntry points an object in
3015         m_entries or not in m_entries.
3016
3017         * DumpRenderTree/chromium/TestNavigationController.cpp:
3018         (TestNavigationEntry::create): Added.
3019         (TestNavigationController::activeEntry):
3020         (TestNavigationController::didNavigateToEntry):
3021         (TestNavigationController::discardPendingEntry):
3022         (TestNavigationController::insertEntry):
3023         (TestNavigationController::navigateToPendingEntry):
3024         * DumpRenderTree/chromium/TestNavigationController.h:
3025         * DumpRenderTree/chromium/WebViewHost.cpp:
3026         (WebViewHost::loadURLForFrame):
3027          Use TestNavigationEntry::create().
3028         (WebViewHost::updateURL):
3029          Use RefPtr<>.
3030         (WebViewHost::updateSessionHistory):
3031          Remove unnecessary static_cast<>.
3032
3033 2010-08-04  Kent Tamura  <tkent@chromium.org>
3034
3035         Reviewed by Dimitri Glazkov.
3036
3037         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
3038         https://bugs.webkit.org/show_bug.cgi?id=43333
3039
3040         * BuildSlaveSupport/test-result-archive:
3041           - Make layoutTestResultsDir local and pass it to archiveTestResults()
3042           - Adjust layoutTestResultsDir for Chromium
3043
3044 2010-08-04  Kent Tamura  <tkent@chromium.org>
3045
3046         Reviewed by Dimitri Glazkov.
3047
3048         NRWT: websocket_server startup detection failure
3049         https://bugs.webkit.org/show_bug.cgi?id=43466
3050
3051         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
3052          Increase timeout value: 5 second -> 10 second
3053
3054 2010-08-04  Victor Wang  <victorw@chromium.org>
3055
3056         Reviewed by Ojan Vafai.
3057
3058         -. Add result.json incremental merging functionality to test results app engine.
3059         -. blobstore is not suitable for AE data merging and there is no API to
3060            programatically edit existing blob or write a new one yet, so replace blobstore
3061            with datastore. If file is oversize (>1000*1000 bytes), store file data in
3062            multiple datastore entries.
3063         -. Fix styles.
3064
3065         Test: jsonresults_unittest to test merging logics.
3066
3067         https://bugs.webkit.org/show_bug.cgi?id=38599
3068
3069         * TestResultServer/handlers/dashboardhandler.py:
3070         * TestResultServer/handlers/menu.py:
3071         * TestResultServer/handlers/testfilehandler.py:
3072         * TestResultServer/main.py:
3073         * TestResultServer/model/dashboardfile.py:
3074         * TestResultServer/model/datastorefile.py: Added.
3075         * TestResultServer/model/jsonresults.py: Added.
3076         * TestResultServer/model/jsonresults_unittest.py: Added.
3077         * TestResultServer/model/testfile.py:
3078         * TestResultServer/templates/uploadform.html:
3079
3080 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3081
3082         Reviewed by Kenneth Christiansen.
3083
3084         [Qt] [QtTestBrowser] Remove unneeded QAction class members
3085         https://bugs.webkit.org/show_bug.cgi?id=43518
3086
3087         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
3088         m_flipYAnimated. Also, in initializeView method there are some dead code block
3089         trying to connect them at the wrong time, when they have not been instanciated.
3090
3091         This patch:
3092
3093         - removes the two cited class members in favor of local variables in createChrome method;
3094         - removes the dead code block.
3095
3096         * QtTestBrowser/launcherwindow.cpp:
3097         (LauncherWindow::LauncherWindow):
3098         (LauncherWindow::initializeView):
3099         (LauncherWindow::createChrome):
3100         * QtTestBrowser/launcherwindow.h:
3101
3102 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
3103
3104         Reviewed by Simon Hausmann and Kenneth Christiansen.
3105
3106         [Qt] [QtTestBrowser] Clean up static and global menu state controls
3107         https://bugs.webkit.org/show_bug.cgi?id=43448
3108
3109         After LauncherWindow class was refactored out of from main.cpp, all global variables that
3110         were hanging in main.cpp became temporarily public static class members of newly added
3111         LauncherWindow class. This design was not properly handling the initial purpose of the
3112         global variables: newly created launcher windows should inherit the settings of the originating
3113         one.
3114
3115         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
3116         comprises all data needed to handling the goal described above.
3117
3118         * QtTestBrowser/launcherwindow.cpp:
3119         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
3120                                           holding all user settings configured in the menus and command line.
3121                                           It also receices an optional QGraphicsScene points in case we are doing
3122                                           a "Clone Window".
3123         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
3124                                 value.
3125         (LauncherWindow::initializeView): Ditto.
3126         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
3127         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
3128                                       apply the preferences is provided by m_userData.
3129         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
3130         (LauncherWindow::toggleResizesToContents): Ditto.
3131         (LauncherWindow::toggleWebGL): Ditto.
3132         (LauncherWindow::toggleFrameFlattening): Ditto.
3133         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
3134         (LauncherWindow::changeViewportUpdateMode): Ditto.
3135         (LauncherWindow::showFPS): Ditto.
3136         (LauncherWindow::newWindow): Changed to pass the userData.
3137         (LauncherWindow::cloneWindow): Ditto.
3138         * QtTestBrowser/launcherwindow.h:
3139         (WindowOptions::WindowOptions):
3140         * QtTestBrowser/main.cpp:
3141         (requiresGraphicsView):
3142         (LauncherApplication::handleUserOptions):
3143         (main):
3144
3145 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
3146
3147         [wx] Build fix for gcc not importing all symbols from convenience libraries.
3148         Works on 10.6 only for Mac until the build system is reworked. 
3149
3150         * wx/build/settings.py:
3151
3152 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
3153
3154         Reviewed by Simon Hausmann.
3155
3156         [Qt] Change wording in QtTestBrowser
3157         https://bugs.webkit.org/show_bug.cgi?id=43241
3158
3159         * QtTestBrowser/launcherwindow.cpp:
3160         (LauncherWindow::createChrome):
3161
3162 2010-08-04  Aaron Boodman  <aa@chromium.org>
3163
3164         Reviewed by Eric Seidel.
3165
3166         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
3167         https://bugs.webkit.org/show_bug.cgi?id=43460
3168
3169         * Scripts/prepare-ChangeLog:
3170
3171 2010-08-03  MORITA Hajime  <morrita@google.com>
3172
3173         Reviewed by Tony Chang.
3174
3175         [DRT] Assertion failed when drag and move a draggable element.
3176         https://bugs.webkit.org/show_bug.cgi?id=41695
3177
3178         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
3179         But Cocoa doesn't call mouseDragged() until dragging is done.
3180         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
3181         on UIDelegate failed when mouseDragged() is called during dragging.
3182         This change eliminated the mouseDragged() call when dragging begins,
3183         which is implicated by draggingInfo instance.
3184         
3185         * DumpRenderTree/mac/EventSendingController.mm:
3186         (-[EventSendingController mouseMoveToX:Y:]):
3187
3188         Test: fast/events/dragging-mouse-moves.html
3189         
3190 2010-08-02  Steve Block  <steveblock@google.com>
3191
3192         Reviewed by Alexey Proskuryakov.
3193
3194         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
3195         https://bugs.webkit.org/show_bug.cgi?id=40002
3196
3197         The code in LayoutTestController::setGeolocationPermission() was moved to
3198         setGeolocationPermissionCommon() to allow each port to provide its own
3199         implementation of setGeolocationPermission().
3200
3201         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
3202         new permission, so it can call back to WebCore if permission requests are in
3203         progress and are waiting for a response. A minor fix to the Mac
3204         MockGeolocationProvider was also required to make sure that the mock provider
3205         calls back to WebCore when it is first started.
3206
3207         For other ports, LayoutTestController::setGeolocationPermission() is not
3208         implemented.
3209
3210         * DumpRenderTree/LayoutTestController.cpp:
3211         (LayoutTestController::setGeolocationPermissionCommon):
3212         * DumpRenderTree/LayoutTestController.h:
3213         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3214         (LayoutTestController::setGeolocationPermission):
3215         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3216         (LayoutTestController::setGeolocationPermission):
3217         * DumpRenderTree/mac/MockGeolocationProvider.mm:
3218         (-[MockGeolocationProvider registerWebView:]):
3219         * DumpRenderTree/mac/UIDelegate.h:
3220         * DumpRenderTree/mac/UIDelegate.mm:
3221         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
3222         (-[UIDelegate setGeolocationPermission:]):
3223         (-[UIDelegate dealloc]):
3224         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3225         (LayoutTestController::setGeolocationPermission):
3226         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3227         (LayoutTestController::setGeolocationPermission):
3228
3229 2010-08-03  Kent Tamura  <tkent@chromium.org>
3230
3231         Reviewed by Dimitri Glazkov.
3232
3233         [DRT/Chromium] Implement --testshell-startup-dialog
3234         https://bugs.webkit.org/show_bug.cgi?id=40616
3235
3236         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3237         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
3238         if it is specfied.
3239         * DumpRenderTree/chromium/TestShell.h:
3240           Declare openStartUpDialog().
3241         * DumpRenderTree/chromium/TestShellGtk.cpp:
3242         (openStartupDialog):
3243         * DumpRenderTree/chromium/TestShellMac.mm:
3244         (openStartupDialog):
3245         * DumpRenderTree/chromium/TestShellWin.cpp:
3246         (openStartupDialog):
3247
3248 2010-08-03  Kent Tamura  <tkent@chromium.org>
3249
3250         Reviewed by Dimitri Glazkov.
3251
3252         [DRT/Chromium] Remove dependency of base/md5.h
3253         https://bugs.webkit.org/show_bug.cgi?id=43403
3254
3255         * DumpRenderTree/chromium/TestShell.cpp:
3256         (TestShell::dumpImage): Use wtf/MD5.h
3257
3258 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
3259
3260         Reviewed by David Kilzer.
3261
3262         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
3263         https://bugs.webkit.org/show_bug.cgi?id=40627
3264
3265         Part 6 - LayoutTest and Cleanup
3266
3267           Allow tests to delete application caches and set application cache
3268           origin quotas, so they can be tested.
3269
3270         * DumpRenderTree/LayoutTestController.cpp:
3271         (LayoutTestController::LayoutTestController):
3272         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
3273         (clearAllApplicationCachesCallback): should delete all application caches.
3274         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
3275         (LayoutTestController::staticFunctions):
3276         * DumpRenderTree/LayoutTestController.h:
3277         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
3278         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
3279
3280           Mac implementation.
3281
3282         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3283         (LayoutTestController::clearAllApplicationCaches): delete application caches.
3284         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
3285         * DumpRenderTree/mac/UIDelegate.mm:
3286         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
3287         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
3288
3289           Stub implementations for other platforms.
3290
3291         * DumpRenderTree/chromium/LayoutTestController.cpp:
3292         (LayoutTestController::LayoutTestController):
3293         (LayoutTestController::clearAllApplicationCaches):
3294         (LayoutTestController::setApplicationCacheOriginQuota):
3295         * DumpRenderTree/chromium/LayoutTestController.h:
3296         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3297         (LayoutTestController::clearAllApplicationCaches):
3298         (LayoutTestController::setApplicationCacheOriginQuota):
3299         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3300         (LayoutTestController::clearAllApplicationCaches):
3301         (LayoutTestController::setApplicationCacheOriginQuota):
3302         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3303         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3304         (LayoutTestController::clearAllApplicationCaches):
3305         (LayoutTestController::setApplicationCacheOriginQuota):
3306         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3307         (LayoutTestController::clearAllApplicationCaches):
3308         (LayoutTestController::setApplicationCacheOriginQuota):
3309
3310 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
3311
3312         Reviewed by David Kilzer.
3313
3314         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
3315         https://bugs.webkit.org/show_bug.cgi?id=40627
3316
3317         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
3318
3319           Change old style calls to make use of the managers.
3320
3321         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3322         (LayoutTestController::setDatabaseQuota):
3323         * DumpRenderTree/mac/UIDelegate.mm:
3324         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3325
3326 2010-08-03  Mark Rowe  <mrowe@apple.com>
3327
3328         Add a new Leopard build slave to run the release tests.
3329
3330         * BuildSlaveSupport/build.webkit.org-config/config.json:
3331
3332 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
3333
3334         WebKitTestRunner needs to activate the Mac font ascent hack
3335         https://bugs.webkit.org/show_bug.cgi?id=43404
3336
3337         Reviewed by Darin Adler.
3338
3339         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3340         (WTR::InjectedBundle::initialize):
3341         Call WKBundleActivateMacFontAscentHack().
3342
3343 2010-08-03  Alex Milowski  <alex@milowski.com>
3344
3345         Reviewed by Beth Dakin.
3346
3347         Changed the default for MathML support so that is is enabled by default.
3348
3349         * Scripts/build-webkit:
3350
3351 2010-08-03  Sam Weinig  <sam@webkit.org>
3352
3353         Roll r64566 back in this time with all the overloads in place..
3354
3355         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3356         (WTR::InjectedBundlePage::shouldInsertNode):
3357         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3358         * WebKitTestRunner/StringFunctions.h:
3359         * WebKitTestRunner/TestInvocation.cpp:
3360         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3361         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3362         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3363
3364 2010-08-03  Sam Weinig  <sam@webkit.org>
3365
3366         Rollout r64566. It broke all the WebKit2 tests.
3367
3368         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3369         (WTR::operator<<):
3370         (WTR::InjectedBundlePage::shouldInsertNode):
3371         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3372         * WebKitTestRunner/StringFunctions.h: Removed.
3373         * WebKitTestRunner/TestInvocation.cpp:
3374         (WTR::createWKURL):
3375         (WTR::WKStringToUTF8):
3376         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3377         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3378         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3379
3380 2010-08-03  Sam Weinig  <sam@webkit.org>
3381
3382         Reviewed by Anders Carlsson.
3383
3384         WTR: Move all the utility functions for working with strings to a shared header.
3385         https://bugs.webkit.org/show_bug.cgi?id=43386
3386
3387         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3388         (WTR::InjectedBundlePage::shouldInsertNode):
3389         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3390         * WebKitTestRunner/StringFunctions.h: Added.
3391         * WebKitTestRunner/TestInvocation.cpp:
3392         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3393         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3394         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3395
3396 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
3397
3398         Reviewed by Kenneth Christiansen.
3399
3400         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
3401         https://bugs.webkit.org/show_bug.cgi?id=43168
3402
3403         QGraphicsWebView resizesToContents property has to work together with QWebPage's
3404         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
3405
3406         * QtTestBrowser/launcherwindow.cpp:
3407         (LauncherWindow::applyPrefs):
3408         * QtTestBrowser/webview.cpp:
3409         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
3410                                                       needed when toggle resizesToContents on/off.
3411         (WebViewGraphicsBased::resizeEvent):
3412         * QtTestBrowser/webview.h:
3413         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
3414         (WebViewGraphicsBased::customLayoutSize): Getter helper.
3415
3416 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
3417
3418         Unreviewed. Adding myself as committer.
3419
3420         * Scripts/webkitpy/common/config/committers.py:
3421
3422 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
3423
3424         Reviewed by Yury Semikhatsky.
3425
3426         Chromium DevTools: Get rid of DevTools RPC.
3427
3428         https://bugs.webkit.org/show_bug.cgi?id=43335
3429
3430         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3431         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
3432         (DRTDevToolsAgent::call):
3433         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3434         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
3435         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
3436         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3437         (DRTDevToolsClient::sendMessageToBackend):
3438         (DRTDevToolsClient::call):
3439         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3440
3441 2010-08-02  Kent Tamura  <tkent@chromium.org>
3442
3443         Reviewed by Dimitri Glazkov.
3444
3445         [DRT/Chromium] Remove dependencies to some Chromium headers
3446         https://bugs.webkit.org/show_bug.cgi?id=43396
3447
3448         * DumpRenderTree/chromium/CppVariant.h:
3449          Remove base/basictypes.h because webkit_support.h contains it.
3450         * DumpRenderTree/chromium/EventSender.cpp:
3451         (getCurrentEventTimeSec): Use new wrapper function.
3452         * DumpRenderTree/chromium/TestNavigationController.h:
3453          Remove base/basictypes.h because webkit_support.h contains it.
3454         * DumpRenderTree/chromium/TestShell.cpp:
3455         (dumpHistoryItem): Use new wrapper function.
3456         * DumpRenderTree/chromium/WebViewHost.cpp:
3457         (WebViewHost::cancelledError): Use new wrapper function.
3458         (WebViewHost::didFailResourceLoad): Use new wrapper function.
3459
3460 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3461
3462         Reviewed by Xan Lopez.
3463
3464         [GTK] DRT implement execCommand()
3465         https://bugs.webkit.org/show_bug.cgi?id=35351
3466
3467         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3468         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
3469         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
3470         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
3471
3472 2010-08-02  Sam Weinig  <sam@webkit.org>
3473
3474         Reviewed by Anders Carlsson.
3475
3476         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
3477
3478         * Scripts/old-run-webkit-tests:
3479
3480 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
3481
3482         WebKitTestRunner needs to support loading custom fonts (via the
3483         WEBKIT_TESTFONTS environment variable)
3484         https://bugs.webkit.org/show_bug.cgi?id=42782
3485
3486         Reviewed by Adam Roben.
3487
3488         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
3489         (WTR::fontsPath):
3490         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
3491         as this directory doesn't appear to be created anymore.
3492         (WTR::activateFonts):
3493         Loop through the fonts, and call AddFontResourceExW() for each.
3494
3495 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
3496
3497         Restore the WebKitTestRunner.sln that was removed, and remove the
3498         correct one.
3499
3500         Rubber-stamped by Sam Weinig.
3501
3502         * WebKitTestRunner/WebKitTestRunner.sln: Added.
3503         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
3504
3505 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
3506
3507         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
3508
3509         Remove the unused WebKitTestRunner.sln.
3510
3511         Reviewed by Sam Weinig.
3512
3513         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3514         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
3515         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
3516         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
3517         * WebKitTestRunner/win/WebKitTestRunner.sln:
3518
3519 2010-08-02  Sam Weinig  <sam@webkit.org>
3520
3521         Fix the windows build.
3522
3523         * WebKitTestRunner/win/main.cpp:
3524
3525 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
3526
3527         Add a Skipped list on Windows, and have run-webkit-tests respect it.
3528
3529         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
3530         there are zero tests failing
3531         https://bugs.webkit.org/show_bug.cgi?id=43374
3532
3533         Reviewed by Adam Roben.
3534
3535         * Scripts/old-run-webkit-tests:
3536         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
3537         win-wk2. When building the result hierarchy, if the platform is win-wk2,
3538         add it first to the list of platforms.
3539
3540 2010-08-02  Darin Adler  <darin@apple.com>
3541
3542         Reviewed by Sam Weinig.
3543
3544         WebKitTestRunner needs layoutTestController.setCanOpenWindows
3545         https://bugs.webkit.org/show_bug.cgi?id=42321
3546
3547         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
3548         https://bugs.webkit.org/show_bug.cgi?id=42779
3549
3550         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
3551         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
3552
3553         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3554         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
3555         waiting for the first call to didCreatePage.
3556         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
3557         is created. Put other pages into a map.
3558         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
3559         of the main page.
3560         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
3561         the main page.
3562         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
3563         closeOtherPages functions.
3564
3565         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3566         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
3567         the main page affect dumping.
3568         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
3569
3570         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3571         (WTR::LayoutTestController::LayoutTestController): Initialize the new
3572         m_shouldCloseExtraWindows member.
3573         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
3574         (WTR::LayoutTestController::windowCount): Added.
3575
3576         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3577         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
3578         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
3579         m_shouldCloseExtraWindows.
3580
3581         * WebKitTestRunner/TestController.cpp:
3582         (WTR::TestController::shared): Return a pointer to the shared copy, but
3583         don't allocate and leak it. This seemed cleaner than adding an explicit
3584         finalize call to go along with the explicit initialize call.
3585         (WTR::TestController::TestController): Added calls to the initialize and
3586         run function, which are now done automatically.
3587         (WTR::TestController::~TestController): Added, since it's called now.
3588         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
3589         (WTR::createOtherPage): Added. Used to create pages other than the main page.
3590         (WTR::TestController::initialize): Added code to set up createOtherPage.
3591         (WTR::TestController::run): Removed unused return value.
3592         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
3593         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
3594
3595         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3596         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
3597         to avoid releasing the window twice. Another way to handle it would be to
3598         remove the release, but this approach is slightly more robust because it works
3599         even if some other code calls the close method an extra time.
3600
3601         * WebKitTestRunner/mac/main.mm:
3602         (main): Use a stack-allocated TestController object instead of calling
3603         initalize and run on a globally allocated one.
3604
3605 2010-08-02  Tony Chang  <tony@chromium.org>
3606
3607         Reviewed by David Levin.
3608
3609         add myself to the reviewers list
3610         https://bugs.webkit.org/show_bug.cgi?id=43366
3611
3612         * Scripts/webkitpy/common/config/committers.py:
3613
3614 2010-08-02  Anders Carlsson  <andersca@apple.com>
3615
3616         Reviewed by Sam Weinig.
3617
3618         Cache JSNPObjects and fix bugs in the object map
3619         https://bugs.webkit.org/show_bug.cgi?id=43368
3620
3621         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
3622         wrap an NPObject that came from a plug-in that is now destroyed.
3623
3624         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3625         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3626         (PluginTest::Object::getProperty):
3627         (PluginTest::Object::NP_GetProperty):
3628         (PluginTest::Object::npClass):
3629         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
3630         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
3631         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3632         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
3633         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
3634         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3635         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3636         * GNUmakefile.am:
3637
3638 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3639
3640         Reviewed by Xan Lopez.
3641
3642         [Gtk] DOM listeners get wrong keycodes for some keys
3643         https://bugs.webkit.org/show_bug.cgi?id=35170
3644
3645         Add support to all event senders for simulating keypad insert
3646         and print screen keys.
3647
3648         * DumpRenderTree/chromium/EventSender.cpp:
3649         (EventSender::keyDown): Add support for generating keypad insert and print screen.
3650         * DumpRenderTree/gtk/EventSender.cpp:
3651         (keyDownCallback): Ditto.
3652         * DumpRenderTree/mac/EventSendingController.mm:
3653         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
3654         * DumpRenderTree/qt/EventSenderQt.cpp:
3655         (EventSender::keyDown): Ditto.
3656         * DumpRenderTree/win/EventSender.cpp:
3657         (keyDownCallback): Ditto.
3658
3659 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
3660
3661         Build fix for building against development versions of GTK+. GTK 2.22
3662         has not yet been released, so these function definitions must be conditionalized
3663         on the development version.
3664
3665         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
3666
3667 2010-08-02  Tony Chang  <tony@chromium.org>
3668
3669         Reviewed by Kent Tamura.
3670
3671         [chromium] use ChromiumDriver on Linux when running webkit tests
3672         https://bugs.webkit.org/show_bug.cgi?id=43273
3673
3674         * Scripts/webkitpy/layout_tests/port/chromium.py:
3675
3676 2010-08-02  Kent Tamura  <tkent@chromium.org>
3677
3678         Reviewed by Dimitri Glazkov.
3679
3680         [DRT/Chromium] Always initialize GTK
3681         https://bugs.webkit.org/show_bug.cgi?id=43327
3682
3683         Call gtk_init() in order to fix plugin test crash.
3684
3685         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3686         (main): Pass argc/argv to platformInit().
3687         * DumpRenderTree/chromium/TestShell.h:
3688         * DumpRenderTree/chromium/TestShellGtk.cpp:
3689         (platformInit): Update parameters, call gtk_init().
3690         * DumpRenderTree/chromium/TestShellMac.mm:
3691         (platformInit): Update parameters.
3692         * DumpRenderTree/chromium/TestShellWin.cpp:
3693         (platformInit): Update parameters.
3694
3695 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
3696
3697         Reviewed by Simon Hausmann.
3698
3699         [Qt] Generate forwarding headers for WebKit2
3700
3701         https://bugs.webkit.org/show_bug.cgi?id=43336
3702
3703         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
3704
3705 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
3706
3707         Reviewed by Kent Tamura.
3708
3709         WebSocket server should start with SO_REUSEADDR
3710         https://bugs.webkit.org/show_bug.cgi?id=43329
3711
3712         Pulls in pywebsocket-0.5.2.
3713         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
3714         http://code.google.com/p/pywebsocket/source/detail?r=273
3715
3716         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
3717
3718 2010-08-01  Kent Tamura  <tkent@chromium.org>
3719
3720         Reviewed by Dimitri Glazkov.
3721
3722         [DRT/Chromium] Remove string_util.h dependency
3723         https://bugs.webkit.org/show_bug.cgi?id=43312
3724
3725         * DumpRenderTree/chromium/LayoutTestController.cpp:
3726         (LayoutTestController::pathToLocalResource):
3727          Use string::find() instead of StartsWithASCII().
3728         (LayoutTestController::cppVariantToInt32):
3729          Use strtol() instead of StringToNumber().
3730
3731 2010-08-01  Sam Weinig  <sam@webkit.org>
3732
3733         Reviewed by Anders Carlsson.
3734
3735         Add ability to reset frame names for WebKitTestRunner
3736         https://bugs.webkit.org/show_bug.cgi?id=43316
3737
3738         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3739         (WTR::InjectedBundle::reset):
3740         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3741         (WTR::InjectedBundlePage::reset):
3742         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3743
3744 2010-08-01  Anders Carlsson  <andersca@apple.com>
3745
3746         Reviewed by Sam Weinig.
3747
3748         Implement NPN_RemoveProperty
3749         https://bugs.webkit.org/show_bug.cgi?id=43315
3750
3751         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3752         Add NPRuntimeRemoveProperty.cpp
3753         
3754         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3755         (PluginTest::NPN_GetStringIdentifier):
3756         (PluginTest::NPN_GetIntIdentifier):
3757         (PluginTest::NPN_RemoveProperty):
3758         Add NPN_ helpers.
3759
3760         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3761         Support more NPClass functions.
3762
3763         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
3764         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
3765         Test for NPN_RemoveProperty.
3766
3767         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
3768         (NPRuntimeRemoveProperty::TestObject::invoke):
3769         Add a testRemoveProperty method.
3770
3771         (NPRuntimeRemoveProperty::NPP_GetValue):
3772         Return the test object.
3773
3774         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3775         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3776         * GNUmakefile.am:
3777         Add NPRuntimeRemoveProperty.cpp
3778
3779 2010-07-30  Anders Carlsson  <andersca@apple.com>
3780
3781         Reviewed by Sam Weinig.
3782
3783         Add an NPObject class template helper to TestNetscapePlugin
3784         https://bugs.webkit.org/show_bug.cgi?id=43288
3785
3786         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3787         Add some template magic to be able to figure out if a class has a member function of a given type.
3788
3789         (PluginTest::Object::create):
3790         Create an object.
3791
3792         (PluginTest::Object::invokeDefault):
3793         Add dummy function, this should never be called.
3794
3795         (PluginTest::Object::Object):
3796         Initialize m_pluginTest to 0.
3797
3798         (PluginTest::Object::~Object):
3799         Add virtual destructor.
3800
3801         (PluginTest::Object::NP_Allocate):
3802         Create a new object.
3803
3804         (PluginTest::Object::NP_Deallocate):
3805         Delete the object.
3806
3807         (PluginTest::Object::NP_InvokeDefault):
3808         Call invokeDefault.
3809
3810         (PluginTest::Object::npClass):
3811         Initialize the NPClass struct.
3812
3813         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3814         (DocumentOpenInDestroyStream::NPP_DestroyStream):
3815         Move this inline.
3816
3817         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
3818         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
3819         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
3820         Use the PluginTest::Object class template.
3821
3822 2010-07-31  Sam Weinig  <sam@webkit.org>
3823
3824         Reviewed by Dan Bernstein.
3825
3826         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
3827         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
3828         due to SVGElements not having the innerText function.
3829
3830         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3831         (WTR::dumpFrameText):
3832
3833 2010-07-30  Sam Weinig  <sam@webkit.org>
3834
3835         Reviewed by Maciej Stachowiak.
3836
3837         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
3838         Add structured message passing from the injected bundle to UIProcess
3839
3840         * MiniBrowser/mac/AppDelegate.m:
3841         (didRecieveMessageFromInjectedBundle):
3842         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3843         (didClearWindowForFrame):
3844         (didRecieveMessage):
3845         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3846         (WTR::InjectedBundle::done):
3847         (WTR::InjectedBundle::didReceiveMessage):
3848         * WebKitTestRunner/TestController.cpp:
3849         (WTR::TestController::initialize):
3850         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3851         * WebKitTestRunner/TestController.h:
3852         * WebKitTestRunner/TestInvocation.cpp:
3853         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3854         * WebKitTestRunner/TestInvocation.h:
3855         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3856
3857 2010-07-30  Sam Weinig  <sam@webkit.org>
3858
3859         Reviewed by Anders Carlsson.
3860
3861         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
3862         Make WKArrayRef more usable.
3863
3864         Remove now unnecessary const_casts.
3865
3866         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3867         (WTR::dumpDescendantFrameScrollPositions):
3868         (WTR::dumpDescendantFramesText):
3869
3870 2010-07-30  Sam Weinig  <sam@webkit.org>
3871
3872         Reviewed by Anders Carlsson.
3873
3874         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
3875         Add first pass of structured message passing.
3876
3877         Update Minibrowser and WebKitTestRunner to work with the new post message
3878         function.
3879
3880         * MiniBrowser/mac/AppDelegate.m:
3881         (didRecieveMessageFromInjectedBundle):
3882         (-[BrowserAppDelegate init]):
3883         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3884         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3885         (didStartProvisionalLoadForFrame):
3886         (didReceiveServerRedirectForProvisionalLoadForFrame):
3887         (didFailProvisionalLoadWithErrorForFrame):
3888         (didCommitLoadForFrame):
3889         (didFinishLoadForFrame):
3890         (didFailLoadWithErrorForFrame):
3891         (didReceiveTitleForFrame):
3892         (didClearWindowForFrame):
3893         (didCreatePage):
3894         (willDestroyPage):
3895         (didRecieveMessage):
3896         (WKBundleInitialize):
3897         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3898         (WTR::InjectedBundle::_didReceiveMessage):
3899         (WTR::InjectedBundle::didReceiveMessage):
3900         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3901         * WebKitTestRunner/TestInvocation.cpp:
3902         (WTR::TestInvocation::invoke):
3903         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3904
3905 2010-07-30  Anders Carlsson  <andersca@apple.com>
3906
3907         Try to fix the layout test failures.
3908
3909         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3910         (webkit_test_plugin_get_value):
3911
3912 2010-07-29  Anders Carlsson  <andersca@apple.com>
3913
3914         Reviewed by Adam Roben.
3915
3916         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
3917         https://bugs.webkit.org/show_bug.cgi?id=43232
3918
3919         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3920         Add PluginScriptableNPObjectInvokeDefault.cpp.
3921
3922         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3923         Remove invokeDefault callback function.
3924
3925         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3926         (PluginTest::create):
3927         Move this to the top of the file.
3928
3929         (PluginTest::NPP_GetValue):
3930         Add default implementation.
3931
3932         (PluginTest::NPN_CreateObject):
3933         Add NPN_ wrapper.
3934
3935         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3936         (PluginTest::identifier):
3937         Add identifier getter.
3938
3939         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
3940         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
3941         Add "using namespace std".
3942
3943         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3944         (NPP_GetValue):
3945         Give PluginTest a chance to return a value.
3946
3947         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3948         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3949         * GNUmakefile.am:
3950         Add PluginScriptableNPObjectInvokeDefault.cpp.
3951         
3952         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3953         (webkit_test_plugin_get_value):
3954         Give PluginTest a chance to return a value.
3955
3956 2010-07-30  Steve Block  <steveblock@google.com>
3957
3958         Reviewed by Steve Block.
3959
3960         Add LayoutTestController methods to test DeviceOrientation
3961         https://bugs.webkit.org/show_bug.cgi?id=39589
3962
3963         * DumpRenderTree/LayoutTestController.cpp:
3964         (setMockDeviceOrientationCallback):
3965         (LayoutTestController::staticFunctions):
3966         * DumpRenderTree/LayoutTestController.h:
3967         * DumpRenderTree/chromium/LayoutTestController.cpp:
3968         (LayoutTestController::LayoutTestController):
3969         (LayoutTestController::setMockDeviceOrientation):
3970         * DumpRenderTree/chromium/LayoutTestController.h:
3971         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3972         (LayoutTestController::setMockDeviceOrientation):
3973         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3974         (LayoutTestController::setMockDeviceOrientation):
3975         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3976         (LayoutTestController::setMockDeviceOrientation):
3977         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3978         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3979         (LayoutTestController::setMockDeviceOrientation):
3980         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3981         (LayoutTestController::setMockDeviceOrientation):
3982         * Scripts/build-webkit:
3983
3984 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
3985
3986         Reviewed by Kenneth Christiansen.
3987
3988         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
3989         https://bugs.webkit.org/show_bug.cgi?id=43209
3990
3991         When -resizes-to-content was being passed as a command line parameter it was simply
3992         not being set (although the corresponding menu item was marked as ON).
3993         User had to toggle the menu OFF and then ON again for it to take place.
3994
3995         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
3996         the command line, but not resizesToContents. Patch addresses that.
3997
3998         * QtTestBrowser/launcherwindow.cpp:
3999         (LauncherWindow::createChrome):
4000         (LauncherWindow::applyPrefs):
4001         (LauncherWindow::toggleResizesToContents):
4002         * QtTestBrowser/webview.h:
4003         (WebViewGraphicsBased::resizesToContents):
4004
4005 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
4006
4007         Rubber-stamped by Simon Fraser.
4008
4009         [Qt] QtTestBrowser: more method grouping and clean ups.
4010
4011         Moving blocks of code around. Basically grouping related methods close to each.
4012
4013         * QtTestBrowser/launcherwindow.cpp:
4014         (LauncherWindow::initializeView):
4015         (LauncherWindow::createChrome):
4016         (LauncherWindow::changeViewportUpdateMode):
4017         (LauncherWindow::showFPS):
4018         (LauncherWindow::newWindow):
4019         (LauncherWindow::cloneWindow):
4020         * QtTestBrowser/launcherwindow.h:
4021
4022 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
4023
4024         Reviewed by Tor Arne Vestbø.
4025
4026         [QT][Symbian] QtTestBrowser missing location capabilities
4027         https://bugs.webkit.org/show_bug.cgi?id=43235
4028
4029         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
4030
4031         * QtTestBrowser/QtTestBrowser.pro:
4032
4033 2010-07-29  Anders Carlsson  <andersca@apple.com>
4034
4035         Add PluginTest.cpp
4036
4037         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4038
4039 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
4040
4041         Reviewed by Eric Seidel.
4042
4043         Update download URLs for python irclib package; the old URLs 
4044         pointed at a specific mirror host and not the general sourceforge
4045         URLs.
4046
4047         https://bugs.webkit.org/show_bug.cgi?id=43228
4048
4049         * Scripts/webkitpy/thirdparty/__init__.py:
4050
4051 2010-07-29  Anders Carlsson  <andersca@apple.com>
4052
4053         Fix typo.
4054
4055         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4056
4057 2010-07-29  Anders Carlsson  <andersca@apple.com>
4058
4059         Another attempt at fixing the Qt and GTK+ build.
4060
4061         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4062         (webkit_test_plugin_new_instance):
4063         (webkit_test_plugin_destroy_stream):
4064
4065 2010-07-29  Anders Carlsson  <andersca@apple.com>
4066
4067         Another build fix attempt.
4068
4069         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4070         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4071         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4072         (webkit_test_plugin_new_instance):
4073         * GNUmakefile.am:
4074
4075 2010-07-29  Anders Carlsson  <andersca@apple.com>
4076
4077         Try to fix Windows and Unix builds.
4078
4079         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4080         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4081         (webkit_test_plugin_new_instance):
4082         (webkit_test_plugin_destroy_stream):
4083
4084 2010-07-29  Anders Carlsson  <andersca@apple.com>
4085
4086         Reviewed by Sam Weinig.
4087
4088         Refactor TestNetscapePlugin so tests can be split in separate files
4089         https://bugs.webkit.org/show_bug.cgi?id=43220
4090
4091         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4092         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
4093
4094         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4095         (pluginAllocate):
4096         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
4097
4098         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
4099         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
4100         (PluginTest::PluginTest):
4101         Initialize m_npp and the test identifier.
4102         
4103         (PluginTest::createTestFunctions):
4104         Return the map from identifiers to createTest functions.
4105
4106         (PluginTest::registerCreateTestFunction):
4107         Insert the identifier and create function pair in the map.
4108
4109         (PluginTest::create):
4110         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
4111
4112         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
4113         (PluginTest::Register::Register):
4114         Helper class template for registering plug-in tests.
4115         
4116         (PluginTest::Register::create):
4117         Create a new test of the given type.
4118
4119         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
4120         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
4121         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
4122
4123         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4124         (NPP_New):
4125         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
4126
4127         (NPP_DestroyStream):
4128         Call the plug-in test NPP_DestroyStream member function.
4129
4130         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4131         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
4132
4133 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
4134
4135         Unreviewed build fix.
4136
4137         Add missing second argument to assert_lint in new style checker tests.
4138
4139         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4140
4141 2010-07-29  Anders Carlsson  <andersca@apple.com>
4142
4143         Reviewed by Adam Roben.
4144
4145         check-webkit-style shouldn't complain about NPAPI functions
4146         https://bugs.webkit.org/show_bug.cgi?id=43211
4147
4148         Allow underscores in functions that start with NPN_, NPP_ or NP_.
4149
4150         * Scripts/webkitpy/style/checkers/cpp.py:
4151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4152
4153 2010-07-29  Victor Wang  <victorw@chromium.org>
4154
4155         Unreviewed, rolling out r64270.
4156         http://trac.webkit.org/changeset/64270
4157         https://bugs.webkit.org/show_bug.cgi?id=39589
4158
4159         The patch breaks chromium webkit unittest
4160
4161         * DumpRenderTree/LayoutTestController.cpp:
4162         (LayoutTestController::staticFunctions):
4163         * DumpRenderTree/LayoutTestController.h:
4164         * DumpRenderTree/chromium/LayoutTestController.cpp:
4165         (LayoutTestController::LayoutTestController):
4166         * DumpRenderTree/chromium/LayoutTestController.h:
4167         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4169         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4170         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4171         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4172         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4173         * Scripts/build-webkit:
4174
4175 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
4176
4177         Reviewed by Kenneth Christiansen.
4178
4179         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
4180         https://bugs.webkit.org/show_bug.cgi?id=43199
4181
4182         There is no sense in keeping WebPage method definitions in main.cpp once
4183         webpage.cpp already exists.
4184
4185         No behavior change.
4186
4187         * QtTestBrowser/main.cpp:
4188         * QtTestBrowser/webpage.cpp:
4189         (WebPage::createWindow):
4190         (WebPage::createPlugin):
4191
4192 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
4193
4194         Reviewed by Kenneth Christiansen.
4195
4196         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
4197         https://bugs.webkit.org/show_bug.cgi?id=43170
4198
4199         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
4200         launcherwindow.{cpp|h}
4201
4202         No behavior change.
4203
4204         Also changed all global static variables (named "gXXX") from main.cpp to
4205         static public variables of the LauncherWindow class.
4206
4207         * QtTestBrowser/QtTestBrowser.pro:
4208         * QtTestBrowser/launcherwindow.cpp: Added.
4209         * QtTestBrowser/launcherwindow.h: Added.
4210         * QtTestBrowser/main.cpp:
4211         (LauncherApplication::handleUserOptions):
4212         (main):
4213
4214 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
4215
4216         Reviewed by Xan Lopez.
4217
4218         Build fix for building against GTK+ 3.x. GSEAL requires that we
4219         access internals of the GdkDragContext via methods. For older versions
4220         of GTK+, define those methods.