2010-10-08 Balazs Kelemen <kbalazs@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Csaba Osztrogonác.
4
5         [Qt] Turn on building WTR
6         https://bugs.webkit.org/show_bug.cgi?id=47349
7
8         * Scripts/webkitdirs.pm:
9
10 2010-10-08  Balazs Kelemen  <kbalazs@webkit.org>
11
12         Reviewed by Andreas Kling.
13
14         [Qt] TestController needs its platform dependent methods
15         https://bugs.webkit.org/show_bug.cgi?id=47413
16
17         * WebKitTestRunner/qt/TestControllerQt.cpp:
18         (WTR::TestController::initializeInjectedBundlePath):
19         If the WTR_INJECTEDBUNDLE_PATH environmental variable is
20         set then use that otherwise use the path where the bundle
21         lives in a normal trunk build.
22         (WTR::TestController::initializeTestPluginDirectory):
23         Set the bundle's value. It is not used currently.
24         (WTR::TestController::platformInitializeContext):
25         * WebKitTestRunner/qt/WebKitTestRunner.pro:
26
27 2010-10-08  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
28
29         Reviewed by Kenneth Rohde Christiansen.
30
31         WTR: Prevent sending the Done message twice on test timeout.
32         https://bugs.webkit.org/show_bug.cgi?id=47410
33
34         When InjectedBundle::done() calls stopLoading, this may trigger
35         InjectedBundlePage::didFailLoadWithErrorForFrame which calls
36         InjectedBundle::done() itself later in the stack.
37         This would output the timeout failure message twice and confuse
38         the run-webkit-tests script.
39
40         This patch adds a third state, Stopping, which prevents WebCore
41         errors to trigger done() when testing is over.
42
43         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
44         (WTR::InjectedBundle::done):
45         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
46
47 2010-10-08  Andras Becsi  <abecsi@webkit.org>
48
49         Reviewed by Kenneth Rohde Christiansen.
50
51         [Qt] Add an activateFonts() implementation similar to DRT's initializeFonts().
52         Original code by Simon Hausmann.
53         https://bugs.webkit.org/show_bug.cgi?id=47402
54
55         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Added.
56         (WTR::activateFonts):
57
58 2010-10-08  Andras Becsi  <abecsi@webkit.org>
59
60         Reviewed by Csaba Osztrogonác.
61
62         [Qt] Add support for Qt's WebKitTestRunner to old-run-webkit-tests.
63         https://bugs.webkit.org/show_bug.cgi?id=47401
64
65         * Scripts/build-webkittestrunner:
66         * Scripts/old-run-webkit-tests:
67
68 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
69
70         Reviewed by Kenneth Rohde Christiansen.
71
72         [Qt] WTR first compile: fix compile issues.
73         https://bugs.webkit.org/show_bug.cgi?id=47343
74
75         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
76         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
77         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
78         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
79         * WebKitTestRunner/TestController.cpp:
80         * WebKitTestRunner/TestInvocation.cpp:
81
82 2010-10-07  Antonio Gomes  <agomes@rim.com>
83
84         Reviewed by Simon Fraser.
85
86         [Mac] [DRT] implement setSpatialNavigationEnabled
87         https://bugs.webkit.org/show_bug.cgi?id=47291
88
89         Implemented LayoutTestController::setSpatialNavigationEnabled for Mac's DRT
90         so it can track regression on the existing implementation and future improvements
91         we are making.
92
93         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
94         (LayoutTestController::setSpatialNavigationEnabled):
95
96 2010-10-07  Dirk Pranke  <dpranke@chromium.org>
97
98         Reviewed by Adam Barth.
99
100         rebaseline-chromium-webkit-tests relied on the filename_to_uri()
101         hook in the Port infrastructure to generate URIs for the files
102         in its summary HTML report; however, that method is supposed to only
103         be used for test files (and should really be renamed), so this would
104         crash.
105
106         This change adds a new "path" module to the system package with a
107         routine called abspath_to_uri() that handles converting paths to
108         file: URIs independently of anything in the layout_tests package,
109         and changes the code to use this. At some point in the near future
110         the layout_tests/port/* code should use this as well.
111
112         This change also deletes a bunch of unused code and fixes some
113         comments in rebaseline_chromium_webkit_tests.py.
114
115         https://bugs.webkit.org/show_bug.cgi?id=47319
116
117         * Scripts/webkitpy/common/system/path.py: Added.
118         * Scripts/webkitpy/common/system/path_unittest.py: Added.
119         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
120         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
121
122 2010-10-07  Martin Robinson  <mrobinson@igalia.com>
123
124         Reviewed by Gustavo Noronha Silva.
125
126         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
127         https://bugs.webkit.org/show_bug.cgi?id=46216
128
129         Fix my latest commit, as it contained some bad changes from a merge gone wrong.
130
131         * DumpRenderTree/gtk/DumpRenderTree.cpp:
132         (initializeFonts): Also initialize the DevaVu Sans font.
133
134 2010-10-07  Daniel Cheng  <dcheng@chromium.org>
135
136         Reviewed by Tony Chang.
137
138         [chromium] Minor naming cleanup in WebDragData, part 2
139         https://bugs.webkit.org/show_bug.cgi?id=47227
140
141         Update DRT to use the renamed methods.
142
143         * DumpRenderTree/chromium/EventSender.cpp:
144         (EventSender::beginDragWithFiles):
145         * DumpRenderTree/chromium/WebViewHost.cpp:
146         (addDRTFakeFileToDataObject):
147
148 2010-10-07  Anders Carlsson  <andersca@apple.com>
149
150         Reviewed by Sam Weinig.
151
152         Add a WKPageFindClient, hook up WKPageCountStringMatches
153         https://bugs.webkit.org/show_bug.cgi?id=47373
154
155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
156         Remove hard coded paths.
157
158         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
159         (TestWebKitAPI::TEST):
160         Fix expected result.
161
162         * TestWebKitAPI/Tests/WebKit2/Find.cpp: Added.
163         (TestWebKitAPI::didFinishLoadForFrame):
164         (TestWebKitAPI::didCountStringMatches):
165         (TestWebKitAPI::TEST):
166         * TestWebKitAPI/Tests/WebKit2/find.html: Added.
167         Add test for WKPageCountStringMatches.
168
169 2010-09-21  Martin Robinson  <mrobinson@igalia.com>
170
171         Reviewed by Chris Fleizach.
172
173         [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
174         https://bugs.webkit.org/show_bug.cgi?id=46216
175
176         * DumpRenderTree/gtk/fonts/fonts.conf: Add a setting which enables FC_EMBOLDEN
177         for DejaVu Serif when there is no bold version available. This is necessary to
178         properly test the property in layout tests.
179
180 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
181
182         Reviewed by Kenneth Rohde Christiansen.
183
184         [Qt] Add WTR's InjectedBundle build files.
185         https://bugs.webkit.org/show_bug.cgi?id=47333
186
187         * Scripts/webkitdirs.pm:
188         * WebKitTestRunner/DerivedSources.pro: Added.
189         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
190         * WebKitTestRunner/WebKitTestRunner.pro: Added.
191         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
192         Content merged in ../DerivedSources.pro
193
194 2010-10-07  Sheriff Bot  <webkit.review.bot@gmail.com>
195
196         Unreviewed, rolling out r69315.
197         http://trac.webkit.org/changeset/69315
198         https://bugs.webkit.org/show_bug.cgi?id=47363
199
200         Forgot to add the new files (Requested by kbalazs on #webkit).
201
202         * Scripts/webkitdirs.pm:
203         * WebKitTestRunner/qt/DerivedSources.pro: Added.
204
205 2010-10-07  Sam Weinig  <sam@webkit.org>
206
207         Reviewed by Anders Carlsson.
208
209         Change API tester to ask the executable for the list of all
210         tests instead of relying on the directory structure.
211         https://bugs.webkit.org/show_bug.cgi?id=47359
212
213         * Scripts/run-test-webkit-api: Added.
214         * Scripts/webkitdirs.pm:
215         Add additional script to just launch the api tester with the correct settings.
216
217         * Scripts/run-api-tests:
218         Change to use the new --dump-tests options to build the list of tests and change
219         output to reflect a (suite, testcase) tuple for each test. Also adds some color.
220
221         * TestWebKitAPI/Test.h:
222         (TestWebKitAPI::Test::Register::Register):
223         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
224         (TestWebKitAPI::TEST):
225         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
226         (TestWebKitAPI::TEST):
227         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
228         (TestWebKitAPI::TEST):
229         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
230         (TestWebKitAPI::TEST):
231         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
232         (TestWebKitAPI::TEST):
233         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
234         (TestWebKitAPI::TEST):
235         Give each test a suite name in addition to the test name.
236
237         * TestWebKitAPI/TestsController.cpp:
238         (TestWebKitAPI::TestsController::dumpTestNames):
239         (TestWebKitAPI::TestsController::runTestNamed):
240         * TestWebKitAPI/TestsController.h:
241         * TestWebKitAPI/mac/main.mm:
242         (main):
243         Add option to print all registered tests.
244
245 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
246
247         Reviewed by Kenneth Rohde Christiansen.
248
249         [Qt] Add WTR's InjectedBundle build files.
250         https://bugs.webkit.org/show_bug.cgi?id=47333
251
252         * Scripts/webkitdirs.pm:
253         * WebKitTestRunner/DerivedSources.pro: Added.
254         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
255         * WebKitTestRunner/WebKitTestRunner.pro: Added.
256         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
257         Content merged in ../DerivedSources.pro
258
259 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
260
261         Unreviewed. Do a renaming that was recommended by the reviewer
262         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
263
264         * WebKitTestRunner/qt/TestControllerQt.cpp:
265         (WTR::RunUntilConditionLoop::start):
266         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
267         (WTR::TestController::runUntil):
268
269 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
270
271         Reviewed by Kenneth Rohde Christiansen.
272
273         [Qt] Watchdog timer implementation for WTR
274         https://bugs.webkit.org/show_bug.cgi?id=47337
275
276         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
277         the definition of the timer type to a typedef.
278         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
279         Timer implementation with QTimer and a helper QObject class.
280         (WTR::WatchdogTimerHelper::instance):
281         (WTR::WatchdogTimerHelper::timerFired):
282         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
283         (WTR::LayoutTestController::platformInitialize):
284         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
285         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
286
287 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
288
289         Unreviewed buildfix for 69297 again
290
291         * WebKitTestRunner/TestController.cpp:
292         (WTR::blankURL):
293
294 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
295
296         Unreviewed trivial build fix for r69297
297
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::blankURL):
300
301 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
302
303         Reviewed by Kenneth Rohde Christiansen.
304
305         WebKitTestRunner should be portable
306         https://bugs.webkit.org/show_bug.cgi?id=45393
307
308         Use only the WebKit API for working with urls.
309         * WebKitTestRunner/StringFunctions.h:
310         (WTR::createWKURL):
311         * WebKitTestRunner/TestController.cpp:
312         (WTR::blankURL):
313         (WTR::TestController::resetStateToConsistentValues):
314         (WTR::TestController::didFinishLoadForFrame):
315
316 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
317
318         Reviewed by Xan Lopez.
319
320         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
321         https://bugs.webkit.org/show_bug.cgi?id=47332
322
323         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
324         (createBitmapContextFromWebView):
325
326 2010-10-06  Chris Guillory  <chris.guillory@google.com>
327
328         Reviewed by Chris Fleizach.
329
330         Remove unused accessibility functions from webkit.
331         https://bugs.webkit.org/attachment.cgi?bugid=46707
332
333         * DumpRenderTree/chromium/WebViewHost.cpp:
334         (WebViewHost::postAccessibilityNotification):
335         * DumpRenderTree/chromium/WebViewHost.h:
336
337 2010-10-06  Lucas Forschler  <lforschler@apple.com>
338
339         Reviewed by Adam Roben.
340
341         Fix the sunspider-compare-results to actually use the passed in value for $root.
342
343         * Scripts/sunspider-compare-results:
344
345 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
346
347         Reviewed by Kenneth Rohde Christiansen.
348
349         [Qt] Runloop implementation for WTR
350         https://bugs.webkit.org/show_bug.cgi?id=47280
351
352         * WebKitTestRunner/qt/TestControllerQt.cpp:
353         Implemented TestController::runUntil by a timerEvent
354         and a QEventLoop. We step into the event loop from runUntil.
355         While we are waiting in the loop a timerEvent is periodically
356         checking the value of the condition. Once the condition has
357         becoming true the timerEvent wakes us up.
358         (WTR::RunUntilLoop::start):
359         (WTR::RunUntilLoop::RunUntilLoop):
360         (WTR::RunUntilLoop::run):
361         (WTR::RunUntilLoop::timerEvent):
362         (WTR::TestController::platformInitialize):
363         (WTR::TestController::runUntil):
364         * WebKitTestRunner/qt/main.cpp:
365         Start the main event loop first and creating the TestController later.
366         (Launcher::Launcher):
367         (Launcher::~Launcher):
368         (Launcher::launch): Creating the TestController.
369         (main): Setting up a timer for calling Launcher::launch from
370         the main event loop.
371
372 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
373
374         Reviewed by Kenneth Russell.
375
376         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
377         enable 'accelerated-composting' instead of 'accelerated-compositing'.
378
379         https://bugs.webkit.org/show_bug.cgi?id=47312
380
381         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
382         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
383
384 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
385
386         Reviewed by Kenneth Rohde Christiansen.
387
388         [Qt] PlatformWebView implementation for WebKitTestRunner
389         https://bugs.webkit.org/show_bug.cgi?id=47276
390
391         The implementation follows the way how
392         we use the API in MiniBrowser.
393         * WebKitTestRunner/PlatformWebView.h:
394         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
395         (WTR::WebView::wkView):
396         (WTR::WebView::~WebView):
397         (WTR::WebView::WebView):
398         (WTR::PlatformWebView::PlatformWebView):
399         (WTR::PlatformWebView::~PlatformWebView):
400         (WTR::PlatformWebView::resizeTo):
401         (WTR::PlatformWebView::page):
402         (WTR::PlatformWebView::focus):
403         * WebKitTestRunner/qt/WebKitTestRunner.pro:
404
405 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
406
407         Reviewed by Kenneth Rohde Christiansen.
408
409         [Qt] Add WebKitTestRunner's build files
410         https://bugs.webkit.org/show_bug.cgi?id=44155
411
412         Parts was taken by Zoltan Horvath's patch.
413
414         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
415         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
416         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
417         PlatformWKView and PlatformWindow (void* for now).
418         Buildfix the case when __APPLE__ is not defined.
419         * WebKitTestRunner/qt/DerivedSources.pro: Added.
420         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
421         Empty stub implementation.
422         (WTR::registerWindowClass):
423         (WTR::PlatformWebView::PlatformWebView):
424         (WTR::PlatformWebView::~PlatformWebView):
425         (WTR::PlatformWebView::resizeTo):
426         (WTR::PlatformWebView::page):
427         (WTR::PlatformWebView::focus):
428         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
429         Empty stub implementation.
430         (WTR::registerWindowClass):
431         (WTR::TestController::runUntil):
432         (WTR::TestController::platformInitialize):
433         (WTR::TestController::initializeInjectedBundlePath):
434         (WTR::TestController::initializeTestPluginDirectory):
435         (WTR::TestController::platformInitializeContext):
436         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
437         * WebKitTestRunner/qt/main.cpp: Added.
438         (main):
439
440 2010-10-06  Tony Chang  <tony@chromium.org>
441
442         Unreviewed, rolling out r69202.
443         http://trac.webkit.org/changeset/69202
444         https://bugs.webkit.org/show_bug.cgi?id=46937
445
446         Broke compile of test_shell
447
448         * DumpRenderTree/chromium/EventSender.cpp:
449         (EventSender::beginDragWithFiles):
450         * DumpRenderTree/chromium/WebViewHost.cpp:
451         (addDRTFakeFileToDataObject):
452
453 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
454
455         Reviewed by Tony Chang.
456
457         [chromium] Minor naming cleanup in WebDragData, part 2
458         https://bugs.webkit.org/show_bug.cgi?id=46937
459
460         Update DRT to use the renamed methods.
461
462         * DumpRenderTree/chromium/EventSender.cpp:
463         (EventSender::beginDragWithFiles):
464         * DumpRenderTree/chromium/WebViewHost.cpp:
465         (addDRTFakeFileToDataObject):
466
467 2010-10-06  David Kilzer  <ddkilzer@apple.com>
468
469         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
470
471         Reviewed by Adam Roben.
472
473         This is the first step in making webarchive tests work on
474         Windows.
475
476         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
477         new files to the project.
478         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
479         to WebArchiveDumpSupport.mm.
480         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
481         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
482         (serializeWebArchiveToXML):
483
484 2010-10-05  Daniel Bates  <dbates@rim.com>
485
486         Reviewed by David Kilzer.
487
488         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
489         https://bugs.webkit.org/show_bug.cgi?id=46058
490
491         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
492         structure so as to support returning additional information
493         about a change log diff.
494
495         Currently, VCSUtils::fixChangeLogPatch() returns a string that
496         represents the change log diff. Towards supporting the return
497         of additional information, such as whether the change log diff
498         inserts an entry at the top of the ChangeLog file, we need to
499         make VCSUtils::fixChangeLogPatch() return a reference to hash
500         structure.
501
502         * Scripts/VCSUtils.pm:
503           - Modified fixChangeLogPatch() to return a reference to a
504             hash structure.
505           - Added documentation to fixChangeLogPatch().
506           - Modified call site in mergeChangeLogs() as necessary.
507         * Scripts/svn-apply:
508           - Modified call site in patch() as necessary.
509         * Scripts/svn-create-patch:
510           - Modified call site in generateDiff() as necessary.
511         * Scripts/svn-unapply:
512           - Modified call site in patch() as necessary.
513         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
514           - Modified the unit tests as necessary.
515
516 2010-10-05  Tony Chang  <tony@chromium.org>
517
518         Reviewed by Darin Adler.
519
520         fix the link to the expected image on windows
521         https://bugs.webkit.org/show_bug.cgi?id=47228
522
523         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
524             windows, the file must be opened in binary mode when writing
525             binary data.
526
527 2010-10-05  Adam Barth  <abarth@webkit.org>
528
529         Update expected result of unittest to match Tony's change below.
530
531         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
532
533 2010-10-05  Tony Chang  <tony@chromium.org>
534
535         Reviewed by Ojan Vafai (over the shoulder).
536
537         Paper over errors in image_diff so we don't crash the whole test run.
538
539         * Scripts/webkitpy/layout_tests/port/chromium.py:
540
541 2010-10-05  Tony Chang  <tony@chromium.org>
542
543         Unreviewed, make shutil.rmtree more resiliant to errors
544         since windows was raising WindowsError: The process cannot access the file because it
545         is being used by another process.
546
547         * Scripts/webkitpy/layout_tests/port/chromium.py:
548
549 2010-10-05  Tony Chang  <tony@chromium.org>
550
551         Reviewed by Ojan Vafai.
552
553         [chromium] fix image diffing in NRWT
554         https://bugs.webkit.org/show_bug.cgi?id=47128
555
556         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
557             NamedTemporaryFile since it doesn't work on Windows.
558         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
559
560 2010-10-05  Kenneth Russell  <kbr@google.com>
561
562         Reviewed by Tony Chang.
563
564         [chromium] Implement layerTreeAsText in DumpRenderTree
565         https://bugs.webkit.org/show_bug.cgi?id=47216
566
567         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
568         make it callable from DumpRenderTree.
569
570         No new tests; verified with existing compositor layout tests.
571
572         * DumpRenderTree/chromium/LayoutTestController.cpp:
573         (LayoutTestController::LayoutTestController):
574         (LayoutTestController::layerTreeAsText):
575         * DumpRenderTree/chromium/LayoutTestController.h:
576
577 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
578
579         Unreviewed build correction.
580
581         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
582         property sheet so proper libraries are linked.
583
584 2010-10-05  Robert Hogan  <robert@webkit.org>
585
586         Reviewed by Andreas Kling.
587
588         [Qt] Fix url conversion in QWebHistory
589
590         Converting from KURL to WFT::String to QUrl does not
591         permit proper percent encoding later.
592
593         https://bugs.webkit.org/show_bug.cgi?id=47048
594
595         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
596         (WebCore::dumpHistoryItem):
597
598 2010-10-05  Anders Carlsson  <andersca@apple.com>
599
600         Reviewed by Sam Weinig.
601
602         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
603         https://bugs.webkit.org/show_bug.cgi?id=47188
604         <rdar://problem/8514104>
605
606         When constructing the std::string, use the real string length instead of the maximum buffer size.
607
608         * TestWebKitAPI/PlatformUtilities.h:
609         (TestWebKitAPI::Util::toSTD):
610         * WebKitTestRunner/StringFunctions.h:
611         (WTR::toSTD):
612
613 2010-10-04  Sam Weinig  <sam@webkit.org>
614
615         Reviewed by Mark Rowe.
616
617         Add MIMEType accessor to WKFrame
618         <rdar://problem/8347683>
619         https://bugs.webkit.org/show_bug.cgi?id=47138
620
621         * TestWebKitAPI/PlatformUtilities.h:
622         (TestWebKitAPI::Util::toSTD):
623         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
624         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
625         (TestWebKitAPI::didStartProvisionalLoadForFrame):
626         (TestWebKitAPI::didCommitLoadForFrame):
627         (TestWebKitAPI::didFinishLoadForFrame):
628         (TestWebKitAPI::TEST):
629         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
630         (TestWebKitAPI::didStartProvisionalLoadForFrame):
631         (TestWebKitAPI::didCommitLoadForFrame):
632         (TestWebKitAPI::didFinishLoadForFrame):
633         (TestWebKitAPI::TEST):
634         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
635         (TestWebKitAPI::TEST):
636         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
637         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
638         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
639         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
640         (TestWebKitAPI::Util::createURLForResource):
641
642 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
643
644         Reviewed by Ojan Vafai.
645
646         [NRWT] Rename current_dir to current_group because it's not a directory
647         https://bugs.webkit.org/show_bug.cgi?id=47169
648
649         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
650         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
651
652 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
653
654         Unreviewed, build fix.
655
656         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
657         which can't always be done. This test uses tempfile.mkdtemp(), which
658         should be safe.
659
660         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
661
662 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
663
664         Unreviewed, build fix.
665
666         Add missing "from __future__ import with_statement" that was
667         breaking test-webkitpy on the Leopard bots (broke in r69040).
668
669         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
670
671 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
672
673         Unreviewed, rolling out r69066.
674         http://trac.webkit.org/changeset/69066
675         https://bugs.webkit.org/show_bug.cgi?id=47163
676
677         Made NRWT reliability worse. (Requested by tkent on #webkit).
678
679         * Scripts/webkitpy/layout_tests/port/chromium.py:
680         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
681
682 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
683
684         Reviewed by Tony Chang.
685
686         [NRWT] Reverse the http tests to alphabetical order.
687         https://bugs.webkit.org/show_bug.cgi?id=47075
688
689         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
690
691 2010-10-04  Robert Hogan  <robert@webkit.org>
692
693         Reviewed by Andreas Kling.
694
695         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
696
697         We need to queue back and forward navigations in the DRT from the
698         LayoutTestController so that maybeDump() knows about them.
699
700         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
701         (LayoutTestController::queueBackNavigation):
702         (LayoutTestController::queueForwardNavigation):
703
704 2010-10-04  Tony Chang  <tony@chromium.org>
705
706         Reviewed by Kent Tamura.
707
708         [chromium] fix image diffing in NRWT
709         https://bugs.webkit.org/show_bug.cgi?id=47128
710
711         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
712               temp file and check the image_diff error code more carefully
713         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
714
715 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
716
717         Reviewed by Adam Barth.
718
719         aroben's change in r68792 actually broke new-run-webkit-tests when
720         running the DRT code path. His change was intended to fix the
721         way we were converting windows paths to URIs when running under
722         Cygwin (the paths were getting one too many "/" on the front).
723         However, the change ended up breaking the chromium_win port, which
724         had slightly different logic.
725
726         This patch removes the port-specific code and adds tests to make
727         sure we're getting the behavior we expect. The Port object no longer
728         exposes a get_absolute_path() method that can be used outside of
729         of converting test filenames, because it's unreliable otherwise
730         (we don't have the right context to know which conversion is intended).
731
732         https://bugs.webkit.org/show_bug.cgi?id=47140
733
734         * Scripts/webkitpy/layout_tests/port/base.py:
735         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
736         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
738         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
739
740 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
741
742         Unreviewed, build fix.
743
744         Handle crash introduced in r69040 if we are not running in a
745         Chromium checkout.
746
747         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
748
749 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
750
751         Reviewed by Tony Chang.
752
753         Add a way for us to have test expectations that are specific to the
754         official builds of Google Chrome (as opposed to Chromium). This change
755         looks for an additional "test_expectations_chrome.txt" file in
756         Chromium's repository (webkit/tools/layout_tests), and uses the
757         concatenation of that file and the regular test_expectations.txt
758         file for test overrides.
759
760         https://bugs.webkit.org/show_bug.cgi?id=46854
761
762         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
763         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
764
765 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
766
767         Color tests in the list based on existing pass/fail result.
768         
769         Fix the summary data to account for htmlOnly and nonHTML tests.
770
771         * CSSTestSuiteHarness/harness/harness.css:
772         (#test-list > option.pass):
773         (#test-list > option.fail):
774         (#test-list > option.skipped):
775         * CSSTestSuiteHarness/harness/harness.js:
776         (Test):
777         (Test.prototype.statusForFormat):
778         (TestSuite.prototype.fillTestList):
779         (TestSuite.prototype.updateTestList):
780         (TestSuite.prototype.recordResult):
781         (TestSuite.prototype.markTestCompleted):
782         (TestSuite.prototype.countTestsWithFlag):
783         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
784         (TestSuite.prototype.queryDatabaseForSummary):
785
786 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
787
788         Reviewed by Beth Dakin.
789
790         AX: doAXRangeForLine does not work
791         https://bugs.webkit.org/show_bug.cgi?id=47101
792
793         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
794
795         * DumpRenderTree/AccessibilityUIElement.cpp:
796         (rangeForLineCallback):
797         (AccessibilityUIElement::rangeForLine):
798         (AccessibilityUIElement::getJSClass):
799         * DumpRenderTree/AccessibilityUIElement.h:
800         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
801         (AccessibilityUIElement::rangeForLine):
802
803 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
804
805         Unreviewed. Adding myself to the committers list.
806
807         * Scripts/webkitpy/common/config/committers.py:
808
809 2010-10-04  Sam Weinig  <sam@webkit.org>
810
811         Reviewed by Anders Carlsson.
812
813         Add ability to set the CacheModel in Webkit2
814         https://bugs.webkit.org/show_bug.cgi?id=47066
815
816         * MiniBrowser/mac/AppDelegate.m:
817         (-[BrowserAppDelegate init]): Opt minibrowser into
818         a PrimaryWebBrowser cache model.
819
820 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
821
822         Make sure to enter all tests when creating the database
823         for the first time.
824         
825         When migrating to a new version of the suite, be sure to
826         sync up the database and testinfo.data by removing old
827         tests, and inserting new ones.
828
829         * CSSTestSuiteHarness/harness/harness.js:
830         (TestSuite.prototype.openDatabase.creation):
831         (TestSuite.prototype.databaseCreated):
832         (TestSuite.prototype.populateDatabaseFromTestInfoData):
833         (TestSuite.prototype.insertTest):
834
835 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
836
837         More work on treating HTML4 and XHTML1 independently; when 
838         changing the format, rebuild the test list, and update the 
839         numbers in the chapter popup.
840
841         * CSSTestSuiteHarness/harness/harness.js:
842         (Test):
843         (Test.prototype.runForFormat):
844         (Test.prototype.completedForFormat):
845         (ChapterSection):
846         (ChapterSection.prototype.countTests):
847         (Chapter):
848         (Chapter.prototype.description):
849         (Chapter.prototype.countTests):
850         (Chapter.prototype.testCount):
851         (Chapter.prototype.untestedCount):
852         (TestSuite.prototype.buildChapters):
853         (TestSuite.prototype.loadCurrentTest):
854         (TestSuite.prototype.updateProgressLabel):
855         (TestSuite.prototype.processFlags):
856         (TestSuite.prototype.formatChanged):
857
858 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
859
860         Update test suite version 20101001.
861         
862         Handle database migration, and delete tests from the db that are
863         not present in testinfo.data.
864         
865         Load about:blank into the test frame before the test url, to make
866         missing tests more obvious.
867         
868         * CSSTestSuiteHarness/harness/harness.js:
869         (TestSuite.prototype.loadTest):
870         (TestSuite.prototype.openDatabase.creation):
871         (TestSuite.prototype.openDatabase.migration1_0To1_1):
872         (TestSuite.prototype.openDatabase.if.return):
873         (TestSuite.prototype.databaseReady):
874         (TestSuite.prototype.populateDatabaseFromTestInfoData):
875         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
876         (TestSuite.prototype.syncDatabaseWithTestInfoData):
877
878 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
879
880         Add the ability to jump to a specific test.
881
882         * CSSTestSuiteHarness/harness/harness.html:
883         * CSSTestSuiteHarness/harness/harness.js:
884         (TestSuite.prototype.goToTestByName):
885         (TestSuite.prototype.switchToFormat):
886
887 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
888
889         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
890         as the test.
891
892         * CSSTestSuiteHarness/harness/harness.js:
893         (TestSuite.prototype.loadRef):
894
895 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
896
897         Update the UI to reflect the fact that each test needs to be tested
898         in both HTML4 and XHTML1 format.
899         
900         * CSSTestSuiteHarness/harness/harness.js:
901         (Test):
902         (Chapter.prototype.description):
903         (Chapter.prototype.untestedCount):
904         (TestSuite.prototype.fillChapterPopup):
905         (TestSuite.prototype.updateChapterPopup):
906         (TestSuite.prototype.fillTestList):
907         (TestSuite.prototype.updateTestList):
908         (TestSuite.prototype.goToNextIncompleteTest):
909         (TestSuite.prototype.firstIncompleteTestIndex):
910         (TestSuite.prototype.recordResult):
911         (TestSuite.prototype.formatChanged):
912         (TestSuite.prototype.markTestCompleted):
913         (TestSuite.prototype.resetTestStatus):
914
915 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
916
917         Add the ability to remove results for re-testing, and
918         to import results.
919
920         * CSSTestSuiteHarness/harness/harness.css:
921         (.custom button):
922         (#overlay):
923         (#overlay.visible):
924         (.overlay-contents):
925         (.overlay-contents textarea):
926         (.overlay-contents .buttons):
927         (.overlay-contents .note):
928         (.overlay-contents .buttons button):
929         * CSSTestSuiteHarness/harness/harness.html:
930         * CSSTestSuiteHarness/harness/harness.js:
931         (TestSuite.prototype.importResults):
932         (TestSuite.prototype.clearResults):
933         (TestSuite.prototype.markTestCompleted):
934         (TestSuite.prototype.resetTestStatus):
935         (TestSuite.prototype.storeTestResult):
936         (TestSuite.prototype.importTestResults):
937         (TestSuite.prototype.clearTestResults):
938
939 2010-10-01  Sam Weinig  <sam@webkit.org>
940
941         Reviewed by Jon Honeycutt.
942
943         Deploy the new WKString functions to remove most uses of CF from
944         the WebKitTestRunner.
945
946         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
947         (WTR::InjectedBundle::didReceiveMessage):
948         (WTR::InjectedBundle::done):
949         * WebKitTestRunner/StringFunctions.h:
950         (WTR::toWK):
951         (WTR::toJS):
952         (WTR::toSTD):
953         (WTR::operator<<):
954         (WTR::copyURLString):
955         * WebKitTestRunner/TestController.cpp:
956         (WTR::TestController::resetStateToConsistentValues):
957         (WTR::TestController::didFinishLoadForFrame):
958         * WebKitTestRunner/TestInvocation.cpp:
959         (WTR::TestInvocation::invoke):
960         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
961
962 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
963
964         Unreviewed TestResultsServer change.
965
966         Add files introduced by http://crrev.com/61273 to the list of dashboard 
967         files to update.
968
969         * TestResultServer/handlers/dashboardhandler.py:
970
971 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
972
973         Build Fix for Windows.
974
975         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
976             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
977             ForwardingHeaders to the include path.
978
979 2010-10-01  Sam Weinig  <sam@webkit.org>
980
981         Reviewed by Anders Carlsson.
982
983         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
984
985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
986         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
987         (TestWebKitAPI::TEST):
988         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
989         (TestWebKitAPI::TEST):
990
991 2010-10-01  Sam Weinig  <sam@webkit.org>
992
993         Reviewed by Kenneth Rohde Christiansen.
994
995         Add additional WKString API
996         https://bugs.webkit.org/show_bug.cgi?id=46958
997
998         Add basic WKStringRef tests.
999
1000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1001         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
1002
1003 2010-10-01  Sam Weinig  <sam@webkit.org>
1004
1005         Reviewed by Dan Bernstein.
1006
1007         Add makefile for TestWebKitAPI and call it from the base makefile.
1008
1009         * Makefile:
1010         * TestWebKitAPI/Makefile: Added.
1011
1012 2010-10-01  Sam Weinig  <sam@webkit.org>
1013
1014         Reviewed by Adam Roben.
1015
1016         Remove unnecessary ForwardingHeaders from test runners.
1017         https://bugs.webkit.org/show_bug.cgi?id=47010
1018
1019         * TestWebKitAPI/Configurations/Base.xcconfig:
1020         * TestWebKitAPI/ForwardingHeaders: Removed.
1021         * WebKitTestRunner/Configurations/Base.xcconfig:
1022         * WebKitTestRunner/ForwardingHeaders: Removed.
1023
1024 2010-09-30  Adam Barth  <abarth@webkit.org>
1025
1026         Reviewed by Eric Seidel.
1027
1028         WebSocket tests are flaky
1029         https://bugs.webkit.org/show_bug.cgi?id=46956
1030
1031         Update these tools to understand how to run the WebSocket tests off the
1032         Apache server.
1033
1034         * Scripts/old-run-webkit-tests:
1035         * Scripts/webkitpy/layout_tests/port/base.py:
1036         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1037         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1038
1039 2010-10-01  Adam Roben  <aroben@apple.com>
1040
1041         Encode Executive command arguments using UTF-8 on Cygwin
1042
1043         Cygwin's Python's os.execv doesn't support unicode command arguments.
1044         Cygwin's execv expects arguments to be encoded using the current code
1045         page. But code pages are limited in what characters they can handle,
1046         and our tests include characters that the English code page can't
1047         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
1048         which can handle all characters but might confuse some commands, for
1049         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
1050         good enough, but we can deal with that when the problem arises.
1051
1052         Reviewed by Adam Barth.
1053
1054         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
1055         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
1056         fails on Windows
1057
1058         * Scripts/webkitpy/common/system/executive.py:
1059         (Executive._run_command_with_teed_output):
1060         (Executive.run_command):
1061         On Cygwin, encode arguments using UTF-8.
1062
1063 2010-10-01  Sam Weinig  <sam@webkit.org>
1064
1065         Reviewed by Adam Roben.
1066
1067         Add simple API tester for WebKit2
1068         https://bugs.webkit.org/show_bug.cgi?id=46953
1069
1070         This adds a very simple testing infrastructure for testing APIs exposed
1071         through the WebKit project. It consists of two parts: 1) a project that
1072         builds the all the tests 2) a script that searches the tests directory and
1073         calls the tester once for each test.
1074
1075         This adds the infrastructure and two tests:
1076         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
1077         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
1078
1079         This currently only works on the mac, but is designed to be easily ported 
1080         to any platform.
1081
1082         * Scripts/run-api-tests: Added.
1083         * Scripts/build-api-tests: Added.
1084         Scripts to build/run the tests.
1085
1086         * TestWebKitAPI: Added.
1087         * TestWebKitAPI/Configurations: Added.
1088         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
1089         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
1090         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
1091         * TestWebKitAPI/ForwardingHeaders: Added.
1092         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
1093         * TestWebKitAPI/PlatformUtilities.h: Added.
1094         * TestWebKitAPI/PlatformWebView.h: Added.
1095         (TestWebKitAPI::PlatformWebView::platformView):
1096         * TestWebKitAPI/StringFunctions.h: Added.
1097         * TestWebKitAPI/Test.h: Added.
1098         (TestWebKitAPI::Test::~Test):
1099         (TestWebKitAPI::Test::name):
1100         (TestWebKitAPI::Test::Register::Register):
1101         (TestWebKitAPI::Test::Register::create):
1102         (TestWebKitAPI::Test::Test):
1103         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
1104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
1105         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
1106         * TestWebKitAPI/TestsController.cpp: Added.
1107         (TestWebKitAPI::TestsController::shared):
1108         (TestWebKitAPI::TestsController::TestsController):
1109         (TestWebKitAPI::TestsController::runTestNamed):
1110         (TestWebKitAPI::TestsController::testFailed):
1111         (TestWebKitAPI::TestsController::registerCreateTestFunction):
1112         * TestWebKitAPI/TestsController.h: Added.
1113         * TestWebKitAPI/mac: Added.
1114         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
1115         (TestWebKitAPI::Util::run):
1116         (TestWebKitAPI::Util::createURLForResource):
1117         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
1118         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1119         (TestWebKitAPI::PlatformWebView::resizeTo):
1120         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
1121         (TestWebKitAPI::PlatformWebView::page):
1122         (TestWebKitAPI::PlatformWebView::focus):
1123         * TestWebKitAPI/mac/main.mm: Added.
1124         Infrastructure.
1125
1126         * TestWebKitAPI/Tests: Added.
1127         * TestWebKitAPI/Tests/WTF: Added.
1128         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
1129         * TestWebKitAPI/Tests/WebKit2: Added.
1130         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
1131         (TestWebKitAPI::State::State):
1132         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
1133         Proof of concept tests.
1134
1135 2010-10-01  Adam Roben  <aroben@apple.com>
1136
1137         Don't assume AccessibleObjectFromEvent succeeds
1138
1139         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
1140         DumpRenderTree!notificationListenerProc when running
1141         plugins/access-after-page-destroyed.html
1142
1143         Reviewed by Sam Weinig.
1144
1145         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1146         (notificationListenerProc): Check both the return value of
1147         AccessibleObjectFromEvent and the object it returns, as MSDN
1148         recommends.
1149
1150 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1151
1152         Reviewed by Tony Chang.
1153
1154         [NRWT] Put the http and websocket tests first in the test list.
1155         https://bugs.webkit.org/show_bug.cgi?id=46453
1156
1157         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1158         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1159
1160 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
1161
1162         Unreviewed, adding myself to the committer list.
1163
1164         * Scripts/webkitpy/common/config/committers.py:
1165
1166 2010-10-01  Adam Roben  <aroben@apple.com>
1167
1168         Test NPN_GetValue(NPNVnetscapeWindow)
1169
1170         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
1171         Right-clicking on windowless Flash plugin in WebKit2 makes a context
1172         menu appear in the bottom-right corner of the screen
1173
1174         Reviewed by Anders Carlsson.
1175
1176         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1177         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
1178
1179         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
1180
1181         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
1182         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
1183         (GetValueNetscapeWindow::NPP_SetWindow): Test that
1184         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
1185         isn't our HWND.
1186
1187         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1188         Added GetValueNetscapeWindow.
1189
1190 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
1191
1192         Unreviewed, adding my webkit.org identity to reviewer list.
1193
1194         * Scripts/webkitpy/common/config/committers.py:
1195
1196 2010-09-30  Adam Barth  <abarth@webkit.org>
1197
1198         Reviewed by Eric Seidel.
1199
1200         The WebSocket server should flush its logs
1201         https://bugs.webkit.org/show_bug.cgi?id=46946
1202
1203         The WebSocket server logs are truncated because the driver just
1204         terminates the child.  It should run Python without buffering so we can
1205         see the end of the log.
1206
1207         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1208
1209 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
1210
1211         Add a button to jump to the next untested test.
1212         
1213         * CSSTestSuiteHarness/harness/harness.css:
1214         (.test-type):
1215         (.name > button):
1216         * CSSTestSuiteHarness/harness/harness.html:
1217         * CSSTestSuiteHarness/harness/harness.js:
1218         (Chapter.prototype.description):
1219         (Chapter.prototype.untestedCount):
1220         (TestSuite.prototype.testInfoDataLoaded):
1221         (TestSuite.prototype.fillChapterPopup):
1222         (TestSuite.prototype.updateChapterPopup):
1223         (TestSuite.prototype.buildTestListForChapter):
1224         (TestSuite.prototype.goToNextIncompleteTest):
1225         (TestSuite.prototype.firstIncompleteTestIndex):
1226         (TestSuite.prototype.testCompletionStateChanged):
1227
1228 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
1229
1230         WebKit2 on Windows should use Windows fonts for the various standard
1231         font families
1232         https://bugs.webkit.org/show_bug.cgi?id=43499
1233         <rdar://problem/8272758>
1234
1235         Reviewed by Adam Roben.
1236
1237         * WebKitTestRunner/TestController.cpp:
1238         (WTR::TestController::resetStateToConsistentValues):
1239         Use the Mac fonts for running tests. This matches DRT behavior.
1240
1241 2010-09-30  Adam Barth  <abarth@webkit.org>
1242
1243         Third attempt.  We need a better integration test environment.
1244
1245         * Scripts/webkitpy/common/net/failuremap.py:
1246         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1247
1248 2010-09-30  Robert Hogan  <robert@webkit.org>
1249
1250         Reviewed by Andreas Kling.
1251
1252         [Qt] Support for PlainTextController
1253
1254         Unskip editing/text-iterator/basic-iteration.html
1255
1256         https://bugs.webkit.org/show_bug.cgi?id=38805
1257
1258         * DumpRenderTree/qt/DumpRenderTree.pro:
1259         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1260         (WebCore::DumpRenderTree::DumpRenderTree):
1261         (WebCore::DumpRenderTree::initJSObjects):
1262         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1263         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1264         (PlainTextController::PlainTextController):
1265         (PlainTextController::plainText):
1266         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1267
1268 2010-09-30  Adam Barth  <abarth@webkit.org>
1269
1270         Unreviewed.  Second attempt to fix sheriffbot.
1271
1272         * Scripts/webkitpy/common/net/buildbot.py:
1273
1274 2010-09-30  Adam Barth  <abarth@webkit.org>
1275
1276         Unreviewed.
1277
1278         This patch should stop the sheriffbot from throwing an exception.
1279
1280         * Scripts/webkitpy/common/net/buildbot.py:
1281
1282 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1283
1284         Reviewed by Adam Roben.
1285
1286         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1287         https://bugs.webkit.org/show_bug.cgi?id=46926
1288
1289         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1290             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1291
1292 2010-09-30  Adam Barth  <abarth@webkit.org>
1293
1294         Reviewed by Eric Seidel.
1295
1296         webkit-patch find-flaky-tests should print results URLs
1297         https://bugs.webkit.org/show_bug.cgi?id=46917
1298
1299         Printing out the results URL makes find-flaky-tests more actionable
1300         because you can see what happens when a test fails.  The output from
1301         the script is still pretty noisy, but it seems useful.
1302
1303         * Scripts/webkitpy/tool/commands/queries.py:
1304
1305 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1306
1307         Reviewed by Simon Fraser.
1308
1309         Make 2D accelerated canvas rendering build on Mac
1310         https://bugs.webkit.org/show_bug.cgi?id=46007
1311         
1312         Added ACCELERATED_2D_CANVAS to build-webkit
1313
1314         * Scripts/build-webkit:
1315
1316 2010-09-29  Kenneth Russell  <kbr@google.com>
1317
1318         Reviewed by Dimitri Glazkov.
1319
1320         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1321         https://bugs.webkit.org/show_bug.cgi?id=46849
1322
1323         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1324         works with the compositor integration in both DumpRenderTree and
1325         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1326         and thereby trigger the compositor's readback code path. Added support
1327         for --enable-accelerated-compositing to DumpRenderTree.
1328
1329         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1330         modifying a compositing layout test, dumping the pixels and verifying
1331         that they matched the output when the compositor was active.
1332
1333         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1334         (main):
1335         * DumpRenderTree/chromium/TestShell.cpp:
1336         (TestShell::TestShell):
1337         (TestShell::resetWebSettings):
1338         * DumpRenderTree/chromium/TestShell.h:
1339         (TestShell::setAcceleratedCompositingEnabled):
1340         * DumpRenderTree/chromium/WebPreferences.cpp:
1341         (WebPreferences::reset):
1342         (WebPreferences::applyTo):
1343         * DumpRenderTree/chromium/WebPreferences.h:
1344         * DumpRenderTree/chromium/WebViewHost.cpp:
1345         (WebViewHost::scheduleComposite):
1346         * DumpRenderTree/chromium/WebViewHost.h:
1347
1348 2010-09-30  Adam Roben  <aroben@apple.com>
1349
1350         Ensure that QueueEngine cleans up its log files when its delegate
1351         tells it to stop processing work
1352
1353         Reviewed by Adam Barth.
1354
1355         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1356         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1357         Windows
1358
1359         * Scripts/webkitpy/tool/bot/queueengine.py:
1360         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1361         files) when the delegate tells us to stop processing work.
1362
1363         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1364         (LoggingDelegate.__init__): Moved code here from
1365         RaisingDelegate.__init__.
1366         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1367         callback.
1368         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1369         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1370         care of for us now.
1371         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1372         message.
1373         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1374         remove the callbacks that are related to processing a single work
1375         item, rather than removing all callbacks after a certain point, as
1376         there are now more callbacks we expect to receive at the end.
1377
1378 2010-09-30  Adam Roben  <aroben@apple.com>
1379
1380         Fix path -> URL conversion on Cygwin
1381
1382         Reviewed by Adam Barth.
1383
1384         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1385         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1386
1387         * Scripts/webkitpy/layout_tests/port/base.py:
1388         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1389         assuming paths already have a leading slash.
1390
1391 2010-09-30  Adam Roben  <aroben@apple.com>
1392
1393         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1394         be called more than once
1395
1396         The NPP_SetWindow call made when the plugin is torn down was confusing
1397         us, and was causing us to spew an error into the next test.
1398
1399         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1400         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1401
1402         Reviewed by Anders Carlsson.
1403
1404         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1405         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1406         Initialize member.
1407         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1408         this isn't the first time this is called.
1409
1410 2010-09-30  Eric Seidel  <eric@webkit.org>
1411
1412         Reviewed by Adam Barth.
1413
1414         webkit-patch upload warns that I'm using Xcode when I'm not
1415         https://bugs.webkit.org/show_bug.cgi?id=46869
1416
1417         String.find returns -1 when not found, so switched to "in".
1418
1419         * Scripts/webkitpy/common/system/user.py:
1420         * Scripts/webkitpy/common/system/user_unittest.py:
1421
1422 2010-09-30  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Adam Barth.
1425
1426         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1427         https://bugs.webkit.org/show_bug.cgi?id=46866
1428
1429         I also made failure-reason use RegressionWindow in a cleaner way.
1430
1431         * Scripts/webkitpy/tool/commands/queries.py:
1432
1433 2010-09-29  Adam Barth  <abarth@webkit.org>
1434
1435         Reviewed by Eric Seidel.
1436
1437         webkit-patch find-flaky-tests
1438         https://bugs.webkit.org/show_bug.cgi?id=46876
1439
1440         This command helps us find flaky tests so we can squash them.
1441
1442         * Scripts/webkitpy/tool/commands/queries.py:
1443
1444 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1445
1446         Fix export to use '?' instead of 'null' for
1447         tests with no results.
1448         
1449         * CSSTestSuiteHarness/harness/harness.js:
1450
1451 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1452
1453         Add a warning when a test requires special steps.
1454         Add a Print Preview button for 'paged' tests that
1455         brings up the print dialog, allowing the user to 
1456         judge paged media tests.
1457
1458         * CSSTestSuiteHarness/harness/harness.css:
1459         * CSSTestSuiteHarness/harness/harness.html:
1460         * CSSTestSuiteHarness/harness/harness.js:
1461         (TestSuite.prototype.loadTest):
1462         (TestSuite.prototype.processFlags):
1463
1464 2010-09-29  Adam Barth  <abarth@webkit.org>
1465
1466         Reviewed by Eric Seidel.
1467
1468         Remove revisions_casuing_failures
1469         https://bugs.webkit.org/show_bug.cgi?id=46872
1470
1471         This function exists only to be unit tested.
1472
1473         * Scripts/webkitpy/common/net/failuremap.py:
1474         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1475         * Scripts/webkitpy/tool/mocktool.py:
1476
1477 2010-09-29  Adam Barth  <abarth@webkit.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         SheriffBot should post the list of failing tests to bugs
1482         https://bugs.webkit.org/show_bug.cgi?id=46871
1483
1484         * Scripts/webkitpy/common/net/buildbot.py:
1485         * Scripts/webkitpy/common/net/failuremap.py:
1486         * Scripts/webkitpy/common/net/regressionwindow.py:
1487         * Scripts/webkitpy/tool/bot/sheriff.py:
1488         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1489         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1490         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1491         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1492         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1493         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1494         * Scripts/webkitpy/tool/mocktool.py:
1495
1496 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1497
1498         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1499
1500         [WinCairo] Adds a build slave.
1501         https://bugs.webkit.org/show_bug.cgi?id=46360
1502
1503         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1504         entries for a debug build of the WinCairo port.
1505         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1506         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1507         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1508         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1509
1510 2010-09-29  Adam Barth  <abarth@webkit.org>
1511
1512         Reviewed by Eric Seidel.
1513
1514         Move more SheriffBot smarts into FailureMap
1515         https://bugs.webkit.org/show_bug.cgi?id=46703
1516
1517         This patch pushes the FailureMap model object further into the
1518         SheriffBot machine.  In addition, it moves a couple operations on this
1519         object from SheriffBot itself to the model.
1520
1521         Eventually, FailureMap will be the canonical context object for
1522         SheriffBot operations.  FailureMap represents a map of the current
1523         failures on the bots that might require remediation.
1524
1525         * Scripts/webkitpy/common/net/failuremap.py:
1526         * Scripts/webkitpy/common/net/regressionwindow.py:
1527         * Scripts/webkitpy/tool/commands/queries.py:
1528         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1529         * Scripts/webkitpy/tool/mocktool.py:
1530
1531 2010-09-29  Tony Chang  <tony@chromium.org>
1532
1533         Reviewed by James Robinson.
1534
1535         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1536         https://bugs.webkit.org/show_bug.cgi?id=46829
1537
1538         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1539         (DRTDevToolsClient::DRTDevToolsClient):
1540         * DumpRenderTree/chromium/TestShell.cpp:
1541         (TestShell::TestShell):
1542         * DumpRenderTree/chromium/WebViewHost.cpp:
1543         (WebViewHost::postAccessibilityNotification):
1544         (WebViewHost::WebViewHost):
1545
1546 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1547
1548         Reviewed by Darin Adler.
1549
1550         AX: implement CSS3 Speech "speak"
1551         https://bugs.webkit.org/show_bug.cgi?id=46827
1552
1553         * DumpRenderTree/AccessibilityUIElement.cpp:
1554         (speakCallback):
1555         (AccessibilityUIElement::speak):
1556         (AccessibilityUIElement::getJSClass):
1557         * DumpRenderTree/AccessibilityUIElement.h:
1558         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1559         (AccessibilityUIElement::speak):
1560
1561 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1562
1563         Reviewed by Adam Barth.
1564
1565         Record bot ID when updating queue status
1566         https://bugs.webkit.org/show_bug.cgi?id=46764
1567         
1568         Since we now have multiple bots handling patches from the commit queue,
1569         we need to differentiate status updates from them, so that we can group
1570         the queue status page in a less confusing way.
1571
1572         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1573         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1574         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1575         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1576         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1577         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1578         * Scripts/webkitpy/tool/main.py: Add --bot-id
1579         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1580
1581 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1582
1583         No review.
1584         
1585         References always refert to a file in .xht format, even
1586         for HTML tests, so fix their loading.
1587
1588         * CSSTestSuiteHarness/harness/harness.js:
1589         (TestSuite.prototype.loadRef):
1590
1591 2010-09-28  Johnny Ding  <jnd@chromium.org>
1592
1593         Reviewed by Adam Barth.
1594
1595         https://bugs.webkit.org/show_bug.cgi?id=41292
1596         Add a new parameter to the test plugin to allow specifying a script 
1597         and a mouse/keyboard event. The specified script will be evaluated
1598         in the browser when the specified event is received by the plugin.
1599
1600         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1601         (pluginAllocate):
1602         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1603         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1604         (NPP_New):
1605         (handleEventCarbon):
1606         (handleEventCocoa):
1607
1608 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1609
1610         Fix export by adding missing argument.
1611
1612         * CSSTestSuiteHarness/harness/harness.js:
1613         (TestSuite.prototype.showResultsForAllTests):
1614
1615 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1616
1617         [wx] Build fix, add missing import.
1618
1619         * wx/packaging/build-win-installer.py:
1620
1621 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1622
1623         No review
1624         
1625         Show which tests have been run by dimming them out in the test list.
1626         
1627         Adjust some element sizes.
1628         
1629         * CSSTestSuiteHarness/harness/harness.css:
1630         (#test-list > option.untested):
1631         (#test-list > option.completed):
1632         (#output):
1633         (.output-options):
1634         * CSSTestSuiteHarness/harness/harness.js:
1635         (Test):
1636         (TestSuite.prototype.fillTestList):
1637         (TestSuite.prototype.updateTestList):
1638         (TestSuite.prototype.setSelectedChapter):
1639         (TestSuite.prototype.recordResult):
1640         (TestSuite.prototype.markTestCompleted):
1641         (TestSuite.prototype.testCompletionStateChanged):
1642         (TestSuite.prototype.loadTestStatus):
1643
1644 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1645
1646         No review.
1647         
1648         Implement export of various queries on the test database, sharing
1649         code with that which displays results inline.
1650
1651         * CSSTestSuiteHarness/harness/harness.js:
1652         ():
1653         (TestSuite.prototype.exportResultsCompletion.var):
1654         (TestSuite.prototype.exportResultsCompletion):
1655         (TestSuite.prototype.showResultsForCompletedTests):
1656         (TestSuite.prototype.exportResultsForCompletedTests):
1657         (TestSuite.prototype.showResultsForAllTests):
1658         (TestSuite.prototype.exportResultsForAllTests):
1659         (TestSuite.prototype.exportResultsForTestsNotRun):
1660         (TestSuite.prototype.exportResultsForTestsWithStatus):
1661         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1662
1663 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1664
1665         No review.
1666
1667         Work around uncertainty about the order of database
1668         transactions when creating the database, so that we don't
1669         try to query the table before it has been created.
1670
1671         * CSSTestSuiteHarness/harness/harness.js:
1672         (TestSuite):
1673         (TestSuite.prototype.databaseCreated):
1674         (TestSuite.prototype.storeTestResult):
1675         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1676         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1677         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1678         (TestSuite.prototype.queryDatabaseForCompletedTests):
1679         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1680
1681 2010-09-28  Tony Chang  <tony@chromium.org>
1682
1683         Reviewed by Eric Seidel.
1684
1685         add python keyring support to webkit-patch
1686         https://bugs.webkit.org/show_bug.cgi?id=41269
1687
1688         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1689             the python keyring module
1690         * Scripts/webkitpy/common/net/credentials_unittest.py:
1691         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1692         * Scripts/webkitpy/common/system/user_unittest.py:
1693         * Scripts/webkitpy/tool/mocktool.py:
1694
1695 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1696
1697         Reviewed by Gustavo Noronha Silva.
1698
1699         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1700         https://bugs.webkit.org/show_bug.cgi?id=46740
1701
1702         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1703         fonts which can be used to fully test FontConfig rendering settings.
1704
1705 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1706
1707         Reviewed by Gustavo Noronha Silva.
1708
1709         [gtk] Fedora has a different path for the liberation fonts
1710         https://bugs.webkit.org/show_bug.cgi?id=46709
1711
1712         When searching for DRT fonts, also look in the path where those fonts
1713         are commonly found on Fedora systems.
1714
1715         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1716         (initializeFonts): Include logic for looking for Fedora-style font paths.
1717
1718 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1719
1720         Reviewed by Andreas Kling.
1721
1722         run-webkit-tests needs an updated list of directories with webgl tests
1723         https://bugs.webkit.org/show_bug.cgi?id=46747
1724
1725         Update the list of directories containing WebGL tests and a unit test
1726         which depends on this list.
1727
1728         * Scripts/old-run-webkit-tests: Update the list of directories.
1729         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1730         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1731
1732 2010-09-28  Adam Barth  <abarth@webkit.org>
1733
1734         Reviewed by Eric Seidel.
1735
1736         Introduce FailureMap to summaries the failures status of all the bots
1737         https://bugs.webkit.org/show_bug.cgi?id=46700
1738
1739         This patch gives the SheriffBot a handle on the list of failing tests.
1740
1741         * Scripts/webkitpy/common/net/buildbot.py:
1742         * Scripts/webkitpy/common/net/failuremap.py: Added.
1743         * Scripts/webkitpy/tool/commands/queries.py:
1744         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1745         * Scripts/webkitpy/tool/mocktool.py:
1746
1747 2010-09-28  Adam Roben  <aroben@apple.com>
1748
1749         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1750
1751         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1752         tell a WebKit2 client application that a key event was not handled
1753
1754         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1755
1756         * MiniBrowser/mac/BrowserWindowController.m:
1757         (-[BrowserWindowController awakeFromNib]):
1758         * MiniBrowser/win/BrowserView.cpp:
1759         (BrowserView::create):
1760         * WebKitTestRunner/TestController.cpp:
1761         (WTR::createOtherPage):
1762         (WTR::TestController::initialize):
1763
1764 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1765
1766         Unreviewed.
1767
1768         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1769         for the test order, but instead use information from testinfo.data.
1770         
1771         * CSSTestSuiteHarness/harness/harness.html:
1772         * CSSTestSuiteHarness/harness/harness.js:
1773
1774 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1775
1776         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1777         it causes the process to hang on the gitorious repo.
1778
1779         * wx/packaging/build-mac-installer.py:
1780         * wx/packaging/build-win-installer.py:
1781
1782 2010-09-28  Adam Roben  <aroben@apple.com>
1783
1784         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1785         called
1786
1787         Reviewed by Anders Carlsson.
1788
1789         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1790         Full-page Adobe Reader does not paint until window is resized
1791
1792         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1793         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1794         this level.
1795
1796         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1797         NPP_SetWindow.
1798
1799         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1800         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1801         the plugin's HWND has a non-zero size and that its size/position
1802         matches that specified in the NPWindow.
1803
1804         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1805         (NPP_SetWindow): Call through to the PluginTest.
1806
1807         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1808         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1809         the files as it saw fit.
1810
1811 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1812
1813         Reviewed by Andreas Kling.
1814
1815         [Qt] Remove support for Qt 4.5
1816         https://bugs.webkit.org/show_bug.cgi?id=46718
1817
1818         Remove the code for versions of Qt prior to 4.6.
1819
1820         * DumpRenderTree/qt/EventSenderQt.cpp:
1821         (EventSender::addTouchPoint):
1822         (EventSender::updateTouchPoint):
1823         (EventSender::setTouchModifier):
1824         (EventSender::touchStart):
1825         (EventSender::touchMove):
1826         (EventSender::touchEnd):
1827         (EventSender::clearTouchPoints):
1828         (EventSender::releaseTouchPoint):
1829         (EventSender::sendTouchEvent):
1830         * DumpRenderTree/qt/EventSenderQt.h:
1831         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1832         (TextInputController::setMarkedText):
1833         * QtTestBrowser/launcherwindow.cpp:
1834         (LauncherWindow::LauncherWindow):
1835         (LauncherWindow::initializeView):
1836         (LauncherWindow::createChrome):
1837         (LauncherWindow::sendTouchEvent):
1838         (LauncherWindow::eventFilter):
1839         (LauncherWindow::applyZoom):
1840         (LauncherWindow::setTouchMocking):
1841         * QtTestBrowser/launcherwindow.h:
1842         * QtTestBrowser/utils.cpp:
1843         (urlFromUserInput):
1844         * QtTestBrowser/webview.cpp:
1845         (WebViewGraphicsBased::animatedFlip):
1846         (WebViewGraphicsBased::animatedYFlip):
1847         * QtTestBrowser/webview.h:
1848         (WebViewGraphicsBased::setYRotation):
1849
1850 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1851
1852         Reviewed by Andreas Kling.
1853
1854         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1855         which should point to wcecompat installation. Needs wcecompat
1856         library from http://github.com/mauricek/wcecompat .
1857
1858         * DumpRenderTree/qt/DumpRenderTree.pro:
1859         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1860         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1861
1862 2010-09-28  Daniel Bates  <dbates@rim.com>
1863
1864         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1865         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1866
1867         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1868         In particular, this change caused Sheriffbot to raise an exception when
1869         trying to parse the bug id on a bug page. We need to look into this
1870         some more.
1871
1872         * Scripts/webkitpy/common/net/bugzilla.py:
1873         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1874         * Scripts/webkitpy/tool/bot/sheriff.py:
1875         * Scripts/webkitpy/tool/commands/download.py:
1876         * Scripts/webkitpy/tool/commands/queues.py:
1877         * Scripts/webkitpy/tool/commands/upload.py:
1878         * Scripts/webkitpy/tool/steps/closebug.py:
1879         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1880         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1881         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1882
1883 2010-09-28  Adam Barth  <abarth@webkit.org>
1884
1885         Reviewed by Eric Seidel.
1886
1887         Move RegressionWindow further up the dependency chain
1888         https://bugs.webkit.org/show_bug.cgi?id=46698
1889
1890         Baby steps towards pushing this information into bug posts.
1891
1892         * Scripts/webkitpy/common/net/buildbot.py:
1893         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1894         * Scripts/webkitpy/common/net/regressionwindow.py:
1895         * Scripts/webkitpy/tool/commands/queries.py:
1896
1897 2010-09-27  Daniel Bates  <dbates@rim.com>
1898
1899         Reviewed by Adam Barth.
1900
1901         sheriffbot can't roll out security patches
1902         https://bugs.webkit.org/show_bug.cgi?id=39136
1903
1904         Make SheriffBot determine if it's authorized to view a bug
1905         whose change it wants to rollout before it tries to rollout
1906         the change.
1907
1908         Moreover, make both webkit-patch and Sheriffbot provide human-
1909         readable error messages when they are not authorized to view
1910         a bug and when a bug number is invalid.
1911
1912         Currently, Sheriffbot does not parse Bugzilla bugs for
1913         <bug error="...">, which indicates an error when retrieving
1914         a bug. In particular, error="NotPermitted" if a person (or bot)
1915         is not authorized to view a bug. For such error="NotPermitted" bugs,
1916         Sheriffbot raises an exception when parsing the bug report and
1917         this exception does not explicitly indicate Sheriffbot's lack
1918         of authorization. Instead, Sheriffbot should explicitly check
1919         for the presence <bug error="..."> before operating on a bug
1920         and error with a human-readable message if it's not permitted
1921         to view it.
1922
1923         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1924         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1925           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1926           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1927           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1928         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1929         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1930         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1931         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1932         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1933         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1934         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1935         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1936
1937 2010-09-27  Adam Barth  <abarth@webkit.org>
1938
1939         Reviewed by Eric Seidel.
1940
1941         Expose more more failure information from Buildbot to SheriffBot
1942         https://bugs.webkit.org/show_bug.cgi?id=46697
1943
1944         This patch moves the information about what tests failured closer to
1945         SheriffBot.  There are still a couple more patches to go before
1946         SheriffBot can post this information to bugs, but this is a step in
1947         that direction.  Yay for unit tests, which caught some bugs in earlier
1948         versions of this patch.
1949
1950         * Scripts/webkitpy/common/net/buildbot.py:
1951         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1952         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1953         * Scripts/webkitpy/tool/commands/queries.py:
1954
1955 2010-09-27  Eric Seidel  <eric@webkit.org>
1956
1957         Unreviewed.  Fixing 500 error seen in the status server.
1958
1959         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1960         This should have been obvious to me, I guess, but it was not what I was expecting.
1961
1962         * QueueStatusServer/model/activeworkitems.py:
1963
1964 2010-09-27  Adam Barth  <abarth@webkit.org>
1965
1966         Reviewed by Eric Seidel.
1967
1968         commit-queue should reject patches that fail to land
1969         https://bugs.webkit.org/show_bug.cgi?id=46694
1970
1971         This can happen, for example, if there's no reviewer.  Without this
1972         patch, we'll keep retrying the patch.
1973
1974         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1975         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1976
1977 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1978
1979         Rubber-stamped by Adele Peterson.
1980
1981         Add a harness for running the CSS 2.1 test suite.
1982         
1983         This harness assumes that you've got a local a copy of the suite
1984         adjacent to the 'harness' directory.
1985         
1986         The harness lets you go through the tests in chapter order,
1987         denoting pass/fail/skipped for each test.
1988         
1989         It uses a client-side database to store the results of testing.
1990
1991         * CSSTestSuiteHarness/harness/harness.css: Added.
1992         * CSSTestSuiteHarness/harness/harness.html: Added.
1993         * CSSTestSuiteHarness/harness/harness.js: Added.
1994
1995 2010-09-27  Eric Seidel  <eric@webkit.org>
1996
1997         Reviewed by Adam Barth.
1998
1999         Patch locks should expire if a patch is marked for retry
2000         https://bugs.webkit.org/show_bug.cgi?id=46682
2001
2002         This was part Adam's original CommitQueueTask design,
2003         but support for it was missing from the server.
2004         I added the support, but triggering lock-release based on this
2005         special "retry" status feels a bit strange so I added a FIXME.
2006
2007         I also changed the text in queuestatus.html to say "Lock Acquired"
2008         since "Last Activity" isn't really true.  We only update the lock
2009         date when the patch is started, not on every status update.
2010
2011         I also noticed an exception in next-patch, which I fixed by re-writing
2012         the unzip logic in activeworkitems.py again.
2013
2014         * QueueStatusServer/handlers/updatestatus.py:
2015         * QueueStatusServer/model/activeworkitems.py:
2016         * QueueStatusServer/templates/queuestatus.html:
2017
2018 2010-09-27  Tony Chang  <tony@chromium.org>
2019
2020         Reviewed by David Levin.
2021
2022         [chromium] fix a warning when compiling DRT on 32-bit linux
2023         https://bugs.webkit.org/show_bug.cgi?id=46641
2024
2025         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2026         (DRTPrinter::handleImage):
2027
2028 2010-09-27  Eric Seidel  <eric@webkit.org>
2029
2030         Reviewed by Adam Barth.
2031
2032         queue-status should report when the patch was last locked to a queue
2033         https://bugs.webkit.org/show_bug.cgi?id=46674
2034
2035         This isn't necessarily the best way to expose this information
2036         but having this accessible via the web interface is very
2037         useful until we come up with a nicer way to display this.
2038
2039         I also cleaned up the code in activeworkitems.py a little
2040         to use list comprehensions and to have the code work with
2041         pairs instead of two lists at once.  Eventually I think those
2042         item/time pairs need to be their own little helper class.
2043
2044         * QueueStatusServer/handlers/queuestatus.py:
2045         * QueueStatusServer/model/activeworkitems.py:
2046         * QueueStatusServer/templates/queuestatus.html:
2047
2048 2010-09-27  Tony Chang  <tony@chromium.org>
2049
2050         Reviewed by David Levin.
2051
2052         [chromium] fix detection of missing fonts on DRT
2053         https://bugs.webkit.org/show_bug.cgi?id=46651
2054
2055         * DumpRenderTree/chromium/TestShellGtk.cpp:
2056         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
2057
2058 2010-09-27  Tony Chang  <tony@chromium.org>
2059
2060         Reviewed by Dimitri Glazkov.
2061
2062         add webkit unit tests to the chromium testers
2063         https://bugs.webkit.org/show_bug.cgi?id=46669
2064
2065         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2066         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
2067
2068 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
2069
2070         Unreviewed.
2071
2072         Adding myself to the committers list.
2073
2074         * Scripts/webkitpy/common/config/committers.py:
2075
2076 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
2077
2078         Reviewed by Eric Seidel.
2079
2080         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
2081         https://bugs.webkit.org/show_bug.cgi?id=46634
2082         
2083         Use OutputCapture to prevent console spam (and also check for expected
2084         output).
2085
2086         * Scripts/webkitpy/common/system/user_unittest.py:
2087
2088 2010-09-27  Eric Seidel  <eric@webkit.org>
2089
2090         Reviewed by James Robinson.
2091
2092         start-commit-queue should abort any rebases in progress
2093         https://bugs.webkit.org/show_bug.cgi?id=46640
2094
2095         webkit-patch commit-queue would do this itself, but this just
2096         helps ensure that the commit-queue script is properly updated
2097         before we run it (in the case where a previous rebase is in
2098         progress the git svn rebase would not work before we run the
2099         commit-queue).
2100
2101         * EWSTools/start-commit-queue.sh:
2102
2103 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
2104
2105         Reviewed by Gustavo Noronha Silva.
2106
2107         [GTK] Clean up the DRT fonts.conf and switch to Liberation
2108         https://bugs.webkit.org/show_bug.cgi?id=46038
2109
2110         Switch to Liberation fonts for GTK+ layout tests. This will make our
2111         test results metric-compatible with many Windows/Chromium results. It
2112         also simplifies the fonts.conf that we load and prepares the way for
2113         fixing many font bugs.
2114
2115         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2116         (initializeFonts): Initialize a known list of fonts instead of loading
2117         every font in the WEBKIT_TESTFONTS directory.
2118         * DumpRenderTree/gtk/fonts.conf: Removed.
2119         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2120         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
2121         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
2122         we can load both fonts.conf and AHEM____.TTF from this location.
2123         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
2124         it is no longer used.
2125
2126 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
2127
2128         Reviewed by Ojan Vafai.
2129
2130         new-run-webkit-httpd fails if Perl is not installed
2131         https://bugs.webkit.org/show_bug.cgi?id=46602
2132         
2133         Make Port._read_configuration catch all exceptions, since trying to run
2134         perl (because of _webkit_build_directory) when it's not installed throws
2135         a WindowsError or OSError, not an IOError (this became an issue after 
2136         r68268, since ChromiumPort ends up calling Port.default_configuration in
2137         its constructor, which means that we're ending up on this codepath in
2138         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
2139         new-run-webkit-httpd).
2140
2141         * Scripts/webkitpy/layout_tests/port/base.py:
2142         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2143
2144 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2145
2146         Reviewed by Antonio Gomes.
2147
2148         [EFL] Add setting API to set a local storage database path.
2149         https://bugs.webkit.org/show_bug.cgi?id=45446
2150
2151         Add a setting API to set local storage database path.
2152
2153         * EWebLauncher/main.c:
2154         (on_key_down):
2155         (browserCreate):
2156         (main):
2157
2158 2010-09-26  Sam Weinig  <sam@webkit.org>
2159
2160         Reviewed by Anders Carlsson.
2161
2162         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
2163         https://bugs.webkit.org/show_bug.cgi?id=46587
2164
2165         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2166
2167 2010-09-26  Antonio Gomes  <agomes@rim.com>
2168
2169         Reviewed by Kenneth Rohde Christiansen.
2170
2171         DRT/Mac nodesFromRect support
2172
2173         [Mac][DRT] Implement LayoutTestController::nodesFromRect
2174         https://bugs.webkit.org/show_bug.cgi?id=46580
2175
2176         Implements LayoutTestController::nodesFromRect for Mac DRT, and
2177         adding stubs for GTK+ and Windows.
2178
2179         * DumpRenderTree/LayoutTestController.cpp:
2180         (nodesFromRectCallback):
2181         (LayoutTestController::staticFunctions):
2182         * DumpRenderTree/LayoutTestController.h:
2183         (LayoutTestController::LayoutTestController::nodesFromRect):
2184         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2185         (LayoutTestController::nodesFromRect):
2186
2187 2010-09-25  Nicolas Weber  <thakis@chromium.org>
2188
2189         Reviewed by Adam Barth.
2190
2191         https://bugs.webkit.org/show_bug.cgi?id=46555
2192         Fix typo in prepare-ChangeLog's help output.
2193
2194         * Scripts/prepare-ChangeLog:
2195
2196 2010-09-24  Sam Weinig  <sam@webkit.org>
2197
2198         Reviewed by Darin Adler.
2199
2200         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
2201         <rdar://problem/8359279>
2202         https://bugs.webkit.org/show_bug.cgi?id=46546
2203
2204         * MiniBrowser/mac/BrowserWindowController.m:
2205         (mouseDidMoveOverElement):
2206         (-[BrowserWindowController awakeFromNib]):
2207         * MiniBrowser/win/BrowserView.cpp:
2208         (mouseDidMoveOverElement):
2209         (BrowserView::create):
2210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2211         (WTR::InjectedBundlePage::InjectedBundlePage):
2212         * WebKitTestRunner/TestController.cpp:
2213         (WTR::createOtherPage):
2214         (WTR::TestController::initialize):
2215
2216 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2217
2218         Reviewed by Adam Barth.
2219
2220         Allow rebaselines for webkit-patch rebaseline to be chosen
2221         https://bugs.webkit.org/show_bug.cgi?id=46407
2222         
2223         Instead of always rebaselining all failing tests, allow a subset to be
2224         chosen.
2225
2226         * Scripts/webkitpy/common/system/user.py:
2227         * Scripts/webkitpy/tool/commands/rebaseline.py:
2228
2229 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
2230
2231         Reviewed by Tony Chang.
2232
2233         [chromium] Implement TextInputController::firstRectForCharacterRange
2234         https://bugs.webkit.org/show_bug.cgi?id=38100
2235
2236         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
2237         No new tests are added since we need to implement the same feature in chromium side
2238         in order to enable any tests that uses this function.
2239
2240         * DumpRenderTree/chromium/TextInputController.cpp:
2241         (TextInputController::firstRectForCharacterRange): Added.
2242
2243 2010-09-24  Adam Barth  <abarth@webkit.org>
2244
2245         Reviewed by Eric Seidel.
2246
2247         commit-queue reports land failures as "PASS"
2248         https://bugs.webkit.org/show_bug.cgi?id=46530
2249
2250         We were ignoring the return value of land instead of passing it back to
2251         CommitQueue.  Of course, this was the one case I forgot to test!
2252
2253         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2254         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2255
2256 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2257
2258         Reviewed by Eric Seidel.
2259
2260         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2261         https://bugs.webkit.org/show_bug.cgi?id=37563
2262
2263         Print error message when build-dumprendertree fails.
2264
2265         * Scripts/webkitpy/layout_tests/port/webkit.py:
2266         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2267
2268 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2269
2270         Reviewed by Tony Chang.
2271
2272         NRWT doesn't respect config set with set-webkit-configuration
2273         https://bugs.webkit.org/show_bug.cgi?id=46278
2274         
2275         Use Port.default_configuration() instead of hardcoding Release in
2276         ChromiumPort configuration initialization, so that we still inherit the
2277         configuration set by set-webkit-configuration.
2278
2279         * Scripts/webkitpy/layout_tests/port/chromium.py:
2280         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2281
2282 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2283
2284         Reviewed by Csaba Osztrogonác.
2285
2286         [Qt] Fix the code to check file existence.
2287         https://bugs.webkit.org/show_bug.cgi?id=46465
2288
2289         * QtTestBrowser/main.cpp:
2290         (main):
2291
2292 2010-09-23  Tony Chang  <tony@chromium.org>
2293
2294         Unreviewed, rolling out r68232.
2295         http://trac.webkit.org/changeset/68232
2296
2297         Broken NRWT on the canary bots.
2298
2299         * Scripts/webkitpy/layout_tests/port/chromium.py:
2300
2301 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2302
2303         Unreviewed, build fix.
2304
2305         r68008 broke new-run-webkit-tests in that the chromium ports no
2306         longer respect set-webkit-configuration. The correct fix for this
2307         is being pursued in bug 46278 (along with a bunch of unit tests),
2308         but in the meantime I'm reverting the particular lines that broke
2309         things. This was tested by hand.
2310
2311         * Scripts/webkitpy/layout_tests/port/chromium.py:
2312
2313 2010-09-23  Sam Weinig  <sam@webkit.org>
2314
2315         Reviewed by Anders Carlsson.
2316
2317         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2318         <rdar://problem/8414062>
2319         https://bugs.webkit.org/show_bug.cgi?id=46432
2320
2321         * MiniBrowser/mac/BrowserWindowController.m:
2322         (didRemoveFrameFromHierarchy):
2323         (-[BrowserWindowController awakeFromNib]):
2324         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2325         (WTR::InjectedBundlePage::InjectedBundlePage):
2326         * WebKitTestRunner/TestController.cpp:
2327         (WTR::TestController::initialize):
2328
2329 2010-09-23  Tony Chang  <tony@chromium.org>
2330
2331         Reviewed by Dimitri Glazkov.
2332
2333         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2334         https://bugs.webkit.org/show_bug.cgi?id=46426
2335
2336         * DumpRenderTree/chromium/LayoutTestController.cpp:
2337         (LayoutTestController::LayoutTestController):
2338         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2339         * DumpRenderTree/chromium/LayoutTestController.h:
2340
2341 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2342
2343         Reviewed by Nate Chapin.
2344
2345         [GTK] r68199 introduced two test failures
2346         https://bugs.webkit.org/show_bug.cgi?id=46424
2347
2348         Fix a regression handling preference overrides that are attached to boolean properties.
2349
2350         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2351         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2352         so we must check for that when converting a string to a boolean.
2353
2354 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2355
2356         Reviewed by David Levin.
2357
2358         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2359         https://bugs.webkit.org/show_bug.cgi?id=46406
2360
2361         This breaks when the method is called with specified size of data (image data), and the
2362         buffer hasn't yet reached this size.
2363
2364         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2365           index larger than 0.
2366
2367 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2368
2369         Reviewed by Nate Chapin.
2370
2371         [GTK] Some tests from r68174 fail on the GTK+ bots
2372         https://bugs.webkit.org/show_bug.cgi?id=46396
2373
2374         Simplify LayoutTestController::overridePreference to make it easier for
2375         people unfamiliar with the code to keep the list of preferences up to date.
2376         Add the conversion for enable-hyperlink-auditing.
2377
2378         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2379         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2380         out the property name for overrridePreference. Also simplify the logic for setting
2381         string properties. Add the conversion for enable-hyperlink-auditing.
2382
2383 2010-09-23  Tony Chang  <tony@chromium.org>
2384
2385         Reviewed by David Levin.
2386
2387         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2388         https://bugs.webkit.org/show_bug.cgi?id=46388
2389
2390         * DumpRenderTree/chromium/LayoutTestController.cpp:
2391         (LayoutTestController::overridePreference):
2392         * DumpRenderTree/chromium/WebPreferences.cpp:
2393         (WebPreferences::reset):
2394         (WebPreferences::applyTo):
2395         * DumpRenderTree/chromium/WebPreferences.h:
2396
2397 2010-09-23  Nate Chapin  <japhet@chromium.org>
2398
2399         Reviewed by Darin Fisher.
2400
2401         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2402         https://bugs.webkit.org/show_bug.cgi?id=30458
2403
2404         * DumpRenderTree/chromium/LayoutTestController.cpp:
2405         (LayoutTestController::overridePreference):
2406         * DumpRenderTree/chromium/WebPreferences.cpp:
2407         (WebPreferences::reset):
2408         (WebPreferences::applyTo):
2409         * DumpRenderTree/chromium/WebPreferences.h:
2410         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2411         (resetDefaultsToConsistentValues):
2412         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2413         (LayoutTestController::overridePreference):
2414
2415 2010-09-21  Stephen White  <senorblanco@chromium.org>
2416
2417         Reviewed by David Levin.
2418
2419         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2420         https://bugs.webkit.org/show_bug.cgi?id=46208
2421
2422         This flag allows the layout tests to be run with or without accelerated
2423         2D canvas rendering.
2424
2425         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2426         (main):
2427         Declare the new flag string, and check for it on startup.
2428         * DumpRenderTree/chromium/TestShell.cpp:
2429         (TestShell::TestShell):
2430         Add a boolean for the new flag, in order to preserve its value over
2431         preferences reset.
2432         (TestShell::resetWebSettings):
2433         Set the new flag to the stored value on reset.
2434         * DumpRenderTree/chromium/TestShell.h:
2435         (TestShell::setAccelerated2dCanvasEnabled):
2436         Add an accessor for the new flag.
2437         * DumpRenderTree/chromium/WebPreferences.cpp:
2438         (WebPreferences::reset):
2439         Initialize the new flag to false.
2440         (WebPreferences::applyTo):
2441         Copy the flag's value to the WebSettings.
2442         * DumpRenderTree/chromium/WebPreferences.h:
2443         Add the new flag.
2444
2445 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2446
2447         Reviewed by Simon Hausmann.
2448
2449         [Qt] Refactor QtWebKitPlatformPlugin interface
2450
2451         Make it easier to keep source-compability for the
2452         QtWebKitPlatformPlugin interface, and run qmake
2453         on the example (but not build) for convenience. 
2454
2455         https://bugs.webkit.org/show_bug.cgi?id=46345
2456
2457         * Scripts/webkitdirs.pm:
2458
2459 2010-09-23  Adam Barth  <abarth@webkit.org>
2460
2461         Reviewed by Eric Seidel.
2462
2463         Tweak some status messages that Eric thought were confusing
2464         https://bugs.webkit.org/show_bug.cgi?id=46342
2465
2466         * Scripts/webkitpy/tool/commands/queues.py:
2467         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2468
2469 2010-09-22  Adam Barth  <abarth@webkit.org>
2470
2471         Reviewed by Eric Seidel.
2472
2473         Fix comm-queue typo
2474         https://bugs.webkit.org/show_bug.cgi?id=46339
2475
2476         We were missing a "self".  The real problem is that we didn't have an
2477         integration test for the failure case.
2478
2479         * Scripts/webkitpy/tool/commands/queues.py:
2480         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2481
2482 2010-09-22  Adam Barth  <abarth@webkit.org>
2483
2484         Reviewed by Eric Seidel.
2485
2486         commit-queue should log more detailed messages to the QueueStatusServer
2487         https://bugs.webkit.org/show_bug.cgi?id=46333
2488
2489         When I created CommitQueueTask, I removed most of the previous logging.
2490         This patch adds back more detailed logging so folks can see their patch
2491         progress through the queue.
2492
2493         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2494         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2495         * Scripts/webkitpy/tool/commands/queues.py:
2496         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2497
2498 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2499
2500         Reviewed by Darin Fisher.
2501
2502         [Chromium] User style layout tests don't pass on Chromium
2503         https://bugs.webkit.org/show_bug.cgi?id=46069
2504
2505         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2506         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2507         behavior from other ports.
2508
2509         * DumpRenderTree/chromium/LayoutTestController.cpp:
2510         (LayoutTestController::addUserStyleSheet):
2511
2512 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2513
2514         Reviewed by Martin Robinson.
2515
2516         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2517         https://bugs.webkit.org/show_bug.cgi?id=46303.
2518
2519         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2520         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2521         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2522         property sheet.
2523         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2524         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2525         appropriate property sheet for the build types.
2526         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2527         configuration to use appropriate property sheet for CoreFoundation
2528         and CFLite-style builds.
2529
2530 2010-09-22  Adam Barth  <abarth@webkit.org>
2531
2532         Reviewed by Eric Seidel.
2533
2534         Optimize commit-queue performance for green trees
2535         https://bugs.webkit.org/show_bug.cgi?id=46254
2536
2537         This patch redesigns the controller logic for the commit-queue.  In the
2538         new design, the controller exercises much finer-grained control over
2539         the landing process.  In particular:
2540
2541         - Patches that fail to apply now get rejected almost immediately.
2542         - Patches that fail to build get rejects after two builds (instead of
2543           three builds and one test run).
2544         - Patches that run into a flaky test now get accepted after one build
2545           and two test runs instead of three full build-and-test runs.
2546
2547         The main cost of these optimizations is that we don't find out the tree
2548         has a failing test until the very end of the process, but if the tree
2549         has a busted test, there's not much we can do anyway.  We might as well
2550         burn commit-queue resources spinning optimisticly.
2551
2552         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2553         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2554         * Scripts/webkitpy/tool/commands/queues.py:
2555
2556 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2557
2558         Reviewed by Martin Robinson.
2559
2560         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2561         https://bugs.webkit.org/show_bug.cgi?id=46303.
2562
2563         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2564         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2565         WinCairo build.
2566         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2567         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2568         build targets that use the new InjectedBundleCFLite.vsprops file.
2569
2570 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2571
2572         Unreviewed, build fix.
2573
2574         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2575         r67974. Really need better unit tests for this tool :(
2576
2577         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2578
2579 2010-09-22  Adam Roben  <aroben@apple.com>
2580
2581         Unbreak test-webkitpy
2582
2583         * Scripts/webkitpy/test/main.py:
2584         (Tester.run_tests): Add a line that mysteriously got deleted.
2585
2586 2010-09-22  Adam Roben  <aroben@apple.com>
2587
2588         Make test-webkitpy test WebKit2's scripts
2589
2590         These scripts can't be in WebKitTools due to limitations of Apple's
2591         build process. But that doesn't mean we can't test them!
2592
2593         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2594         WebKit2/Scripts
2595
2596         Reviewed by Adam Barth.
2597
2598         * Scripts/test-webkitpy:
2599         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2600         Now takes an external_package_paths parameter and cleans both webkitpy
2601         and any external packages.
2602         (init): Added an external_package_paths parameter which we pass along
2603         to _clean_packages_with_test.
2604         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2605         and pass it along to init and Tester.run_tests.
2606
2607         * Scripts/webkitpy/test/main.py:
2608         (Tester.run_tests): Added an optional external_package_paths
2609         parameter. We modify sys.path so that the external packages can be
2610         imported, and search for unittest files inside all external packages
2611         in addition to inside webkitpy.
2612
2613 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2614
2615         Reviewed by Tony Chang.
2616
2617         new-run-webkit-tests: r68063 broke linux python tests
2618
2619         Add a missing "from __future__ import with_statement" to this
2620         new file; the perils of testing only on the Mac and by review :(
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=46293
2623
2624         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2625
2626 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2627
2628         Reviewed by Tony Chang.
2629
2630         Add a 'chromium-gpu' set of ports that will test the accelerated
2631         GPU paths. This patch adds:
2632
2633         - support for the '--accelerated-compositing' and
2634           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2635           'no-' flags)
2636         - adds a new set of Ports that will look under
2637           platform/chromium-gpu-$OS/ for baselines before looking in the
2638           regular chromium search path
2639         - adds a new test_expectations.txt file in platform/chromium-gpu
2640           that skips all but the tests we actually want to run with
2641           acceleration.
2642
2643         This patch will allow us to run both with and without acceleration
2644         and to change the defaults for both the regular and -gpu options
2645         as the code evolves.
2646
2647         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2648         each test bot.
2649
2650         https://bugs.webkit.org/show_bug.cgi?id=46225
2651
2652         * Scripts/webkitpy/layout_tests/port/chromium.py:
2653         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2654         * Scripts/webkitpy/layout_tests/port/factory.py:
2655         * Scripts/webkitpy/layout_tests/port/webkit.py:
2656
2657 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2658
2659         Reviewed by Kenneth Rohde Christiansen.
2660
2661         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2662         https://bugs.webkit.org/show_bug.cgi?id=43988
2663
2664         Runs a web debug server on port specified by QtTestBrowser
2665         argument -remote-inspector-port. Property
2666         _q_webInspectorServerPort of the QWebPage instance will be set
2667         according to the argument. All pages with that property set will
2668         be remotely inspectable.
2669
2670         URL for remote inspection of first QWebPage is
2671             http://localhost:9222/webkit/inspector/inspector.html?page=1
2672         where 1 is the number of the QWebPage instance.
2673
2674         The base URL yields an index page with links to the individual inspectors:
2675             http://localhost:9222/
2676
2677         * QtTestBrowser/launcherwindow.cpp:
2678         (LauncherWindow::init):
2679         * QtTestBrowser/launcherwindow.h:
2680         * QtTestBrowser/main.cpp:
2681         (LauncherApplication::handleUserOptions):
2682
2683 2010-09-22  Adam Roben  <aroben@apple.com>
2684
2685         Fix webkit-patch failure-reason now that build.webkit.org has been
2686         updated
2687
2688         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2689         every time
2690
2691         Reviewed by Eric Seidel.
2692
2693         * Scripts/webkitpy/common/net/buildbot.py:
2694         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2695         looking for an element that contains text, then returns it.
2696         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2697         text out of the cells. This way it doesn't matter whether the cells
2698         have <b> children (as for cells in directory rows) or not (as for
2699         cells in file rows)
2700         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2701         the "directory" or "file" class, rather than rows with any class,
2702         since header rows now have a class attribute.
2703
2704         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2705         (BuildBotTest._example_directory_listing): Updated to more closely
2706         match the markup that build.webkit.org is producing now.
2707
2708 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2709
2710         Unreviewed, build fix.
2711
2712         new-run-webkit-tests: fix bug introduced in r68008 where if you
2713         specify --chromium and no --platform, and you're running on
2714         windows, you use the 'chromium-win' port by default instead of the
2715         version-specific port. This breaks the buildbots.
2716
2717         It will be good for this refactoring to settle down so I can
2718         rewrite the logic for default ports and the unit tests to be
2719         clearer (and the testing more comprehensive).
2720
2721         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2722
2723 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2724
2725         Reviewed by Adam Barth.
2726
2727         Modify the Port interface to take only a series of keyword arguments
2728         in the constructor, and modify Port/factory.get() to accomodate that,
2729         and to accept user=XXX as an argument so we can pass
2730         webkitpy.common.system.user.User objects in.
2731
2732         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2733         to use the common routine in webkitpy.common.system.user.open_url()
2734         to display HTML files.
2735
2736         There was a routine in the Port interface to do the same thing,
2737         but I see no need for a port-specific hook for this, since it is
2738         something that will always be executed by the host environment
2739         and displaying web pages has nothing to do with running layout tests.
2740
2741         Note that new-run-webkit-tests used to use test_shell to display
2742         the page; this is potentially useful so that you can actually click
2743         from a result to the broken page; however, since DumpRenderTree
2744         doesn't support this functionality, it will be going away eventually.
2745
2746         https://bugs.webkit.org/show_bug.cgi?id=46128
2747
2748         * Scripts/webkitpy/layout_tests/port/base.py:
2749         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2750         * Scripts/webkitpy/layout_tests/port/chromium.py:
2751         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2752         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2753         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2754         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2755         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2756         * Scripts/webkitpy/layout_tests/port/factory.py:
2757         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2758         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2759         * Scripts/webkitpy/layout_tests/port/gtk.py:
2760         * Scripts/webkitpy/layout_tests/port/mac.py:
2761         * Scripts/webkitpy/layout_tests/port/qt.py:
2762         * Scripts/webkitpy/layout_tests/port/test.py:
2763         * Scripts/webkitpy/layout_tests/port/webkit.py:
2764         * Scripts/webkitpy/layout_tests/port/win.py:
2765         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2766         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2767         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2768
2769 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2770
2771         Reviewed by Kenneth Rohde Christiansen.
2772
2773         [EFL] Get fresh theme when running EWebLauncher
2774         https://bugs.webkit.org/show_bug.cgi?id=46210
2775
2776         If user tried to run EWebLauncher outside of the build tree, it would
2777         not find the theme and fallback to the installed one. However, since
2778         EWebLauncher is not installed, we always want to take the theme from
2779         the just compiled source code. If user had never installed WebKit's
2780         EFL port it could even receive a segv since no theme would be found.
2781
2782         Now EWebLauncher does not fallback to the installed theme and CMake
2783         gives as DATA_DIR the directory of the theme it has just built.
2784
2785         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2786         EWebLauncher.
2787         * EWebLauncher/main.c: Use only the theme from build director. Do not
2788         fallback to others as this could hide real bugs.
2789         (quit):
2790         (browserCreate):
2791         (findThemePath):
2792         (main):
2793
2794 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2795
2796         Unreviewed, build fix.
2797
2798         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2799         it just confuses it.
2800
2801         https://bugs.webkit.org/show_bug.cgi?id=46230
2802
2803         * Scripts/webkitpy/layout_tests/port/webkit.py:
2804
2805 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2806
2807         Reviewed by Stephanie Lewis.
2808
2809         Make a new buildbot for Leopard Debug Test
2810
2811         * BuildSlaveSupport/build.webkit.org-config/config.json:
2812
2813 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2814
2815         Unreviewed, build fix.
2816
2817         Fix breakage of Chromium Mac DRT port caused by r67905.
2818
2819         https://bugs.webkit.org/show_bug.cgi?id=46230
2820
2821         * Scripts/webkitpy/layout_tests/port/webkit.py:
2822
2823 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2824
2825         Unreviewed, build fix.
2826
2827         Add missing import of 'tempfile'.
2828
2829         * Scripts/webkitpy/layout_tests/port/chromium.py:
2830
2831 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2832
2833         Reviewed by Ojan Vafai.
2834
2835         new-run-webkit-tests: pull the list of tests from the Port, and
2836            make it possible to run with no actual test files in the filesystem.
2837
2838         This set of changes allows us to delete the special
2839         webkitpy/layout_tests/data directory and test the generic code without
2840         touching the filesystem (except to write results). This speeds up
2841         test-webkitpy substantially.
2842
2843         This also cleans up and removes several code paths in the generic
2844         code and fixes some minor bugs, notably in the test_expectations
2845         parsing, which was previously fragile if the tests weren't present.
2846
2847         We also change the way we diff image results to be able to do so
2848         in memory, without relying on files. This slows down chromium
2849         test_shell, which always writes images to files, but should speed
2850         up DRT and ImageDiff-based implementations slightly.
2851
2852         Note that pulling the list of tests to run from the Port will allow
2853         ports to specify what tests to run as an inclusive list; previously
2854         you could only do this as an exclusive list by using a 
2855         test_expectations file or Skipped files; nothing actually uses this
2856         feature yet and it's unclear if it should be used.
2857
2858         Note that there are no functional changes -- apart from now 
2859         always printing out the location of the checksum file when we are
2860         tracing test runs -- and the total number of lines of non-test code
2861         actually drops by two.
2862
2863         There is some more cleanup that can be done in the Port/Driver 
2864         interface and in some handling of filenames, but I'll save that
2865         for another change.
2866
2867         https://bugs.webkit.org/show_bug.cgi?id=45801
2868
2869         * Scripts/webkitpy/layout_tests/data/*: Removed.
2870             - no longer need special mock layout_tests_directory in the
2871               repository.
2872         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2873             - add code to display missing text files, checksums when tracing
2874             - update to not look at the filesystem directly.
2875         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2876             - add more unit tests
2877         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2878             - remove tests_are_present flag
2879             - update with changes in Port interface - no longer access
2880               the filesystem directly, although we still use os.path for
2881               filename manipulation.
2882         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2883             - add more unit tests
2884         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2885             - renamed to port/test_files.py
2886         * Scripts/webkitpy/layout_tests/port/base.py:
2887             - change diff_image() to expect actual image data, not filenames
2888             - add expected_checksum(), expected_image(), expected_text() to
2889               return the content of the files so that we don't need a filesystem
2890             - add path_exists(), path_isdir() for filesystem-like access.
2891             - add test_dirs() to keep clobber-test-results from needing to
2892               actually look at a real layout tests dir
2893             - add tests() to return the list of tests to run on the port
2894               (calls port/test_files to do the work).
2895             - add update_baseline() to be able to save new baselines
2896             - add uri_to_test_name() from port/dryrun.py so we can easily check
2897               filename_to_uri()
2898         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2899             - add more unit tests
2900         * Scripts/webkitpy/layout_tests/port/chromium.py:
2901             - change diff_image() to accept image content, not filenames.
2902               This will be slower for test_shell/image_diff, but faster
2903               for DRT/ImageDiff.
2904         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2905             - add more unit tests
2906         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2907             - simplify greatly
2908         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2909             - add more unit tests
2910         * Scripts/webkitpy/layout_tests/port/test.py:
2911             - massive rewrite to use in-script list of tests and expectations
2912         * Scripts/webkitpy/layout_tests/port/test_files.py:
2913             - rename from layout_package/test_files.
2914         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2915             - add unit tests
2916         * Scripts/webkitpy/layout_tests/port/webkit.py:
2917             - update diff_image() to take image contents, not files. Should
2918               make things slightly faster.
2919         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2920             - update with changes to diff_image()
2921         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2922             - update with changes to diff_image()
2923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2924             - remove tests_are_present from test_expectations
2925             - pull the list of tests from port.tests() instead
2926               of calling test_files.py directly.
2927         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2928             - update unit tests
2929         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2930             - update with changes to 
2931         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2932             - update with change in Port interface
2933         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2934             - update with change in Port interface
2935         * Scripts/webkitpy/style/checkers/test_expectations.py:
2936             - remove the tests_are_present flag
2937
2938 2010-09-21  Anders Carlsson  <andersca@apple.com>
2939
2940         Disable logging.
2941
2942         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2943
2944 2010-09-21  Tony Chang  <tony@chromium.org>
2945
2946         Reviewed by Kent Tamura.
2947
2948         add a script for running webkit_unit_tests
2949         https://bugs.webkit.org/show_bug.cgi?id=46014
2950
2951         * Scripts/run-chromium-webkit-unit-tests: Added.
2952
2953 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2954
2955         Reviewed by Martin Robinson.
2956
2957         Fix linking problems on Windows.
2958         https://bugs.webkit.org/show_bug.cgi?id=45844
2959
2960         * GNUmakefile.am: link the executables with winmm.dll
2961
2962 2010-09-21  Adam Barth  <abarth@webkit.org>
2963
2964         Reviewed by Eric Seidel.
2965
2966         feeder-queue svn updates more often than needed
2967         https://bugs.webkit.org/show_bug.cgi?id=46171
2968
2969         We don't need to poll SVN every time we feed the feeders.  Rather, we
2970         can count on the wrapper shell script to auto-update the queue.
2971
2972         * Scripts/webkitpy/tool/commands/queues.py:
2973         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2974
2975 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2976
2977         Reviewed by Andreas Kling.
2978
2979         [Qt] Add robot loader timeout and extra time options.
2980         https://bugs.webkit.org/show_bug.cgi?id=46172
2981
2982         [-robot-timeout <s>]: Load the next page after s seconds if the current
2983         page didn't finish loading.
2984         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2985         loading before loading the next one. This should allow some time for the
2986         page's JavaScript to execute.
2987
2988         * QtTestBrowser/launcherwindow.cpp:
2989         (LauncherWindow::applyPrefs):
2990         * QtTestBrowser/main.cpp:
2991         (LauncherApplication::robotTimeout):
2992         (LauncherApplication::robotExtraTime):
2993         (LauncherApplication::LauncherApplication):
2994         (LauncherApplication::handleUserOptions):
2995         (main):
2996         * QtTestBrowser/urlloader.cpp:
2997         (UrlLoader::UrlLoader):
2998         (UrlLoader::loadNext):
2999         (UrlLoader::loadUrlList):
3000         * QtTestBrowser/urlloader.h:
3001
3002 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
3003
3004         Unreviewed.
3005
3006         Adding myself to the committers list.
3007
3008         * Scripts/webkitpy/common/config/committers.py:
3009
3010 2010-09-20  Philippe Normand  <pnormand@igalia.com>
3011
3012         Reviewed by Eric Carlson.
3013
3014         [GTK] enhanced context menu for media elements
3015         https://bugs.webkit.org/show_bug.cgi?id=45021
3016
3017         EventSender::contextClick() now returns an array of js
3018         objects. Each object has a title property and a click() method.
3019
3020         * DumpRenderTree/gtk/EventSender.cpp:
3021         (getMenuItemTitleCallback):
3022         (setMenuItemTitleCallback):
3023         (menuItemClickCallback):
3024         (getMenuItemClass):
3025         (contextClickCallback):
3026
3027 2010-09-20  Hayato Ito  <hayato@chromium.org>
3028
3029         Unreviewed.
3030         Adding myself to the committers list.
3031
3032         * Scripts/webkitpy/common/config/committers.py:
3033
3034 2010-09-20  Adam Barth  <abarth@webkit.org>
3035
3036         Reviewed by Eric Seidel.
3037
3038         The tool member variable should be called _tool
3039         https://bugs.webkit.org/show_bug.cgi?id=46160
3040
3041         Created by find-and-replace.
3042
3043         * Scripts/webkitpy/tool/commands/download.py:
3044         * Scripts/webkitpy/tool/commands/openbugs.py:
3045         * Scripts/webkitpy/tool/commands/queries.py:
3046         * Scripts/webkitpy/tool/commands/queues.py:
3047         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3048         * Scripts/webkitpy/tool/commands/rebaseline.py:
3049         * Scripts/webkitpy/tool/commands/sheriffbot.py:
3050         * Scripts/webkitpy/tool/commands/upload.py:
3051         * Scripts/webkitpy/tool/multicommandtool.py:
3052
3053 2010-09-20  Adam Barth  <abarth@webkit.org>
3054
3055         I ran the tests before landing but ignored the fact that they failed.  :(
3056
3057         * Scripts/webkitpy/tool/commands/queues.py:
3058
3059 2010-09-20  Adam Barth  <abarth@webkit.org>
3060
3061         Reviewed by Eric Seidel.
3062
3063         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
3064         https://bugs.webkit.org/show_bug.cgi?id=46141
3065
3066         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
3067         list of work items on the status server.  The individual commit-cluster
3068         nodes then grab the patches from the server and process them.
3069
3070         * Scripts/webkitpy/tool/bot/feeders.py: Added.
3071         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
3072         * Scripts/webkitpy/tool/commands/queues.py:
3073         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3074         * Scripts/webkitpy/tool/commands/queuestest.py:
3075
3076 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
3077
3078         Reviewed by Darin Adler.
3079
3080         build-webkit: Add support for CMake build system
3081         https://bugs.webkit.org/show_bug.cgi?id=44979
3082
3083         * Scripts/build-webkit: Add "--efl" command-line option to build the
3084         EFL port of WebKit.
3085         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
3086         buildEflCMakeProject() subroutines.
3087
3088 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
3089
3090         Reviewed by Ojan Vafai.
3091
3092         new-run-webkit-tests: refactor command line args getting passed to DRT
3093
3094         This change cleans up some argument parsing between functions to get
3095         rid of some overlapping data structures. There should be no functional
3096         changes in this patch; it is pure refactoring in preparation for
3097         landing the Chrome GPU port and adding a generic way to pass
3098         args to DRT/TestShell.
3099
3100         https://bugs.webkit.org/show_bug.cgi?id=46135
3101
3102         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3103           - pass the options argument explicitly to the threads and drivers,
3104             also consolidate the passing of options to the driver.
3105           - pass options directly to process_output() to remove a couple
3106             parameters (minor cleanup).
3107         * Scripts/webkitpy/layout_tests/port/base.py:
3108           - pass the options argument to Port.create_driver().
3109         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3110           - update Port.create_driver() test
3111         * Scripts/webkitpy/layout_tests/port/chromium.py:
3112           - pass the options argument to Port.create_driver(), and clean up
3113             building of the cmd line for DRT.
3114         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3115           - pass the options argument to Port.create_driver()
3116         * Scripts/webkitpy/layout_tests/port/test.py:
3117           - pass the options argument to Port.create_driver()
3118         * Scripts/webkitpy/layout_tests/port/webkit.py:
3119           - pass the options argument to Port.create_driver(), and clean up
3120             building of the cmd line for DRT.
3121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3122           - consolidate args in _get_dump_render_tree_args and rename to
3123             _get_test_args(); move all of the command-line args to the
3124             Port implementations.
3125
3126 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
3127
3128         Revert change which was accidentally committed along with some expectation changes.
3129
3130         * Scripts/webkitpy/layout_tests/port/base.py:
3131
3132 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3133
3134         Reviewed by Adam Barth.
3135
3136         Add explicit --force-patch flag to webkitpy tools
3137         https://bugs.webkit.org/show_bug.cgi?id=46103
3138         
3139         It wasn't obvious until I read the applypatch.py source code that
3140         --non-interfactive implies passing --force to patch. Add --force-patch
3141         as an alias to the flag, so that this behavior is more discoverable.
3142
3143         * Scripts/webkitpy/tool/steps/applypatch.py:
3144         * Scripts/webkitpy/tool/steps/options.py:
3145
3146 2010-09-20  Eric Seidel  <eric@webkit.org>
3147
3148         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
3149
3150         commit-queue can't land patches
3151         https://bugs.webkit.org/show_bug.cgi?id=46138
3152
3153         Add a line of code I forgot in my last commit.
3154
3155         * Scripts/webkitpy/common/net/bugzilla.py:
3156         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3157
3158 2010-09-20  Adam Barth  <abarth@webkit.org>
3159
3160         Reviewed by Eric Seidel.
3161
3162         The commit-cluster bots still race to lock patch_ids
3163         https://bugs.webkit.org/show_bug.cgi?id=46130
3164
3165         It turns out we need to use a transaction object to make the
3166         read/modify/write lock operation atomic.  From reading the AppEngine
3167         documentation, I think this patch should do what we want.  It's hard to
3168         test locally because the test instance isn't distributed in the same
3169         way the production instance is.
3170
3171         * QueueStatusServer/handlers/nextpatch.py:
3172         * QueueStatusServer/model/activeworkitems.py: Added.
3173
3174 2010-09-20  Andy Estes  <aestes@apple.com>
3175
3176         Reviewed by Adam Barth.
3177
3178         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
3179         https://bugs.webkit.org/show_bug.cgi?id=40961
3180
3181         Implement WebKitUsePreHTML5ParserQuirks preference.
3182
3183         * DumpRenderTree/mac/DumpRenderTree.mm:
3184         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
3185         to false after a test finishes.
3186
3187 2010-09-20  Adam Roben  <aroben@apple.com>
3188
3189         Windows build fix
3190
3191         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
3192         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
3193         we'll pick up the most recent versions of the headers.
3194
3195 2010-09-20  Eric Seidel  <eric@webkit.org>
3196
3197         Reviewed by Adam Barth.
3198
3199         commit-queue should check commit-queue+ again just before committing
3200         https://bugs.webkit.org/show_bug.cgi?id=32679
3201
3202         Added a _revalidate_patch check, right before landing.
3203
3204         Since _revalidate_patch passes the patch_id from the work item
3205         back to bugzilla, I had to fix all of the previous queue tests to
3206         use valid attachment ids (that's the majority of this change).
3207
3208         In order to validate that the bug was still open, I had to teach
3209         bugzilla.Bug about open/closed states.
3210
3211         * Scripts/webkitpy/common/net/bugzilla.py:
3212         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3213         * Scripts/webkitpy/tool/commands/queues.py:
3214         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3215         * Scripts/webkitpy/tool/commands/queuestest.py:
3216         * Scripts/webkitpy/tool/mocktool.py:
3217
3218 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
3219
3220         Unreviewed.
3221
3222         Adding myself as a comitter.
3223
3224         * Scripts/webkitpy/common/config/committers.py:
3225
3226 2010-09-20  Adam Barth  <abarth@webkit.org>
3227
3228         Reviewed by Eric Seidel.
3229
3230         Two instances of commit-queue try to process the same patch
3231         https://bugs.webkit.org/show_bug.cgi?id=46113
3232
3233         This patch makes next-patch atomic so that the server won't vend the
3234         same patch twice in the same hour.
3235
3236         * QueueStatusServer/handlers/nextpatch.py:
3237
3238 2010-09-20  Adam Roben  <aroben@apple.com>
3239
3240         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
3241
3242         We were previously trying to use a CFRunLoopTimer, but since Windows
3243         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3244         Windows-style timer on Windows.
3245
3246         I also replaced all uses of "watchdog" with "watchdog timer".
3247
3248         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3249         watchdog timer doesn't work on Windows
3250
3251         Reviewed by Anders Carlsson.
3252
3253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3254         (WTR::InjectedBundlePage::dump): Updated for rename.
3255
3256         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3257         platform-specific functions.
3258         (WTR::LayoutTestController::LayoutTestController): Added call to
3259         platformInitialize.
3260         (WTR::LayoutTestController::waitUntilDone): Changed to call
3261         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3262         right in this function.
3263         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3264         rename.
3265
3266         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3267         members needed to support the watchdog timer abstraction. Replaced
3268         some "watchdog"s with "watchdog timer".
3269
3270         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3271         Added.
3272         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3273         platform.
3274         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3275         from LayoutTestController.cpp and changed to use an early return.
3276         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3277         LayoutTestController.cpp.
3278         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3279         Moved code here from LayoutTestController::waitUntilDone and changed
3280         to use an early return.
3281
3282         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3283         Added.
3284         (WTR::LayoutTestController::platformInitialize): Initialize our
3285         watchdog timer.
3286         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3287         Kills and clears the watchdog timer.
3288         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3289         LayoutTestController member function of the same name.
3290         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3291         Added. Sets up the timer if it isn't already set.
3292
3293         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3294         LayoutTestControllerMac.mm.
3295
3296         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3297         LayoutTestControllerWin.cpp.
3298
3299 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3300
3301         Reviewed by Daniel Bates.
3302
3303         [GTK] fast/forms/listbox-selection.html fails
3304         https://bugs.webkit.org/show_bug.cgi?id=45942
3305
3306         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3307         strings in keyDownCallback.
3308
3309         * DumpRenderTree/gtk/EventSender.cpp:
3310         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3311         modifier parsing logic.
3312
3313 2010-09-19  Sam Weinig  <sam@webkit.org>
3314
3315         Reviewed by Anders Carlsson.
3316
3317         WebKit2 decidePolicyForNavigationAction should include mouse button information
3318         <rdar://problem/8413165>
3319         https://bugs.webkit.org/show_bug.cgi?id=46060
3320
3321         * MiniBrowser/mac/BrowserWindowController.m:
3322         (decidePolicyForNavigationAction):
3323         (decidePolicyForNewWindowAction):
3324
3325 2010-09-19  Daniel Bates  <dbates@rim.com>
3326
3327         Reviewed by Martin Robinson.
3328
3329         Add unit tests for diffs that delete or modify a change log entry
3330         or describe changes that are far apart
3331         https://bugs.webkit.org/show_bug.cgi?id=46046
3332
3333         Add additional unit tests to test change log diffs that contain
3334         deletions or changes that are far apart from each other in the
3335         ChangeLog file.
3336
3337         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3338           - Added the following unit tests:
3339           "fixChangeLogPatch: [no change] In-place change."
3340           "fixChangeLogPatch: [no change] Remove first entry."
3341           "fixChangeLogPatch: [no change] Remove entry in the middle."
3342           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3343
3344 2010-09-19  Sam Weinig  <sam@webkit.org>
3345
3346         Reviewed by Anders Carlsson.
3347
3348         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3349         https://bugs.webkit.org/show_bug.cgi?id=46054
3350
3351         The new one acts like WKBundleNodeHandleRef and allows for getting a
3352         wrapper in a specific world for the handle.
3353
3354         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3355         (WTR::propertyValue):
3356         (WTR::propertyValueDouble):
3357         (WTR::propertyValueInt):
3358         (WTR::numericWindowPropertyValue):
3359         (WTR::toStr):
3360         (WTR::InjectedBundlePage::shouldBeginEditing):
3361         (WTR::InjectedBundlePage::shouldEndEditing):
3362         (WTR::InjectedBundlePage::shouldInsertNode):
3363         (WTR::InjectedBundlePage::shouldInsertText):
3364         (WTR::InjectedBundlePage::shouldDeleteRange):
3365         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3366         (WTR::InjectedBundlePage::shouldApplyStyle):
3367         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3368
3369 2010-09-19  Kent Tamura  <tkent@chromium.org>
3370
3371         Unreviewed. Fix WebGL test regressions by r67809.
3372
3373         * DumpRenderTree/chromium/WebPreferences.cpp:
3374         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3375
3376 2010-09-19  Kent Tamura  <tkent@chromium.org>
3377
3378         Reviewed by Adam Barth.
3379
3380         [DRT/Chromium] Fix a WebSettings handling bug
3381         https://bugs.webkit.org/show_bug.cgi?id=45945
3382
3383         Before this change, Chromium DRT reset WebSettings for every new
3384         window. It was wrong.
3385         If new window is not the first one, we have to apply the same
3386         settings as the first window.  So, we introduce WebPreference to
3387         store the current settings, and apply it to new windows. It's same
3388         as test_shell's behavior.
3389
3390         * DumpRenderTree/DumpRenderTree.gypi:
3391         * DumpRenderTree/chromium/LayoutTestController.cpp:
3392           Use WebPreferences instead of WebSettings.
3393         (LayoutTestController::setUserStyleSheetEnabled):
3394         (LayoutTestController::setUserStyleSheetLocation):
3395         (LayoutTestController::setAuthorAndUserStylesEnabled):
3396         (LayoutTestController::setPopupBlockingEnabled):
3397         (LayoutTestController::disableImageLoading):
3398         (LayoutTestController::setJavaScriptCanAccessClipboard):
3399         (LayoutTestController::setXSSAuditorEnabled):
3400         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3401         (LayoutTestController::setAllowFileAccessFromFileURLs):
3402         (LayoutTestController::overridePreference):
3403         (LayoutTestController::setEditingBehavior):
3404         * DumpRenderTree/chromium/TestShell.cpp:
3405         (TestShell::resetWebSettings): Use WebPreferences.
3406         (TestShell::runFileTest): ditto.
3407         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3408         * DumpRenderTree/chromium/TestShell.h:
3409         (TestShell::preferences):
3410         (TestShell::applyPreferences):
3411         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3412         * DumpRenderTree/chromium/WebPreferences.h: Added.
3413
3414 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3415
3416         Reviewed by David Levin.
3417
3418         update-webkit --chromium spitting out a spurious error
3419         https://bugs.webkit.org/show_bug.cgi?id=45868
3420
3421         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3422
3423 2010-09-18  Sam Weinig  <sam@webkit.org>
3424
3425         Reviewed by Dan Bernstein.
3426
3427         Improve/unify the PageLoadClient interfaces
3428         https://bugs.webkit.org/show_bug.cgi?id=46043
3429
3430         * MiniBrowser/mac/BrowserWindowController.m:
3431         (didStartProvisionalLoadForFrame):
3432         (didReceiveServerRedirectForProvisionalLoadForFrame):
3433         (didFailProvisionalLoadWithErrorForFrame):
3434         (didCommitLoadForFrame):
3435         (didFinishDocumentLoadForFrame):
3436         (didFinishLoadForFrame):
3437         (didFailLoadWithErrorForFrame):
3438         (didReceiveTitleForFrame):
3439         (didFirstLayoutForFrame):
3440         (didFirstVisuallyNonEmptyLayoutForFrame):
3441         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3442         (WTR::InjectedBundlePage::InjectedBundlePage):
3443         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3444         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3445         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3446         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3447         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3448         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3449         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3450         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3451         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3452         * WebKitTestRunner/TestController.cpp:
3453         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3454         (WTR::TestController::didFinishLoadForFrame):
3455         * WebKitTestRunner/TestController.h:
3456
3457 2010-09-17  Eric Seidel  <eric@webkit.org>
3458
3459         Unreviewed.  Adding a shell script I use to run the
3460         commit-queue. Now that multiple machines run the cq,
3461         it makes sense to share the script between them.
3462
3463         * EWSTools/start-commit-queue.sh: Added.
3464
3465 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3466
3467         Reviewed by Jon Honeycutt.
3468
3469         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3470         slightly harder to read, so this reverts the previous background colors for various
3471         states, making it easier to read.
3472
3473         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3474         (.success):
3475         (.failure):
3476         (.warnings):
3477         (.exception):
3478         (.start,.running,td.building):
3479         (.offline,td.offline):
3480
3481 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3482
3483         Unreviewed, rolling out r67692.
3484         http://trac.webkit.org/changeset/67692
3485         https://bugs.webkit.org/show_bug.cgi?id=46011
3486
3487         broke layout test dashboard (Requested by johnny_g on
3488         #webkit).
3489
3490         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3491         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3492         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3493
3494 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3495
3496         Reviewed by Oliver Hunt.
3497
3498         Style bot complains about cairo forward declaration naming
3499         https://bugs.webkit.org/show_bug.cgi?id=45867
3500
3501         Exclude Cairo forward declarations from indentifiers with underscores checks.
3502
3503         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3504         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3505
3506 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3507
3508         Reviewed by Ojan Vafai.
3509
3510         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3511         https://bugs.webkit.org/show_bug.cgi?id=45408
3512
3513         This change also tries to remove duplicated upload_results_json methods
3514         in run_webkit_tests.py and json_results_generator.py.
3515
3516         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3517         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3518         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3519
3520 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3521
3522         Reviewed by Andreas Kling.
3523
3524         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3525
3526         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3527         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3528         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3529         all page specific stuff to the UI.
3530
3531         * QtTestBrowser/launcherwindow.cpp:
3532         (LauncherWindow::initializeView):
3533         * QtTestBrowser/mainwindow.cpp:
3534         (MainWindow::MainWindow):
3535         (MainWindow::buildUI):
3536         (MainWindow::setPage):
3537         * QtTestBrowser/mainwindow.h:
3538
3539 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3540
3541         Reviewed by Andreas Kling.
3542
3543         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3544
3545         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3546         object will move to the qgraphicsscene instead of the qgraphicsview.
3547
3548         * QtTestBrowser/webview.cpp:
3549         (WebViewGraphicsBased::setPage):
3550         (WebViewGraphicsBased::setResizesToContents):
3551         (WebViewGraphicsBased::resizeEvent):
3552         (WebViewGraphicsBased::animatedFlip):
3553         * QtTestBrowser/webview.h:
3554         (WebViewGraphicsBased::setItemCacheMode):
3555         (WebViewGraphicsBased::itemCacheMode):
3556
3557 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3558
3559         Reviewed by Andreas Kling.
3560
3561         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3562
3563         We usually separate methods whose body are larger than a few lines from the class definition.
3564
3565         * QtTestBrowser/webview.h:
3566         (WebViewGraphicsBased::yRotation):
3567         (WebViewGraphicsBased::setYRotation):
3568
3569 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3570
3571         Reviewed by Andreas Kling.
3572
3573         Make initializeView method of LauncherWindow private.
3574
3575         No one else needs to be able to call it but LauncherWindow.
3576         Also moving the declation of isGraphicsBased method down in the same file, in order
3577         to better group related methods.
3578
3579         * QtTestBrowser/launcherwindow.h:
3580
3581 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3582
3583         Reviewed by Andreas Kling.