2009-11-01 Jessie Berlin <jberlin@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2
3         Adding myself to the committers list.
4
5         * Scripts/modules/committers.py:
6
7 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
8
9         Fix an issue that Adam noticed in DRT.
10
11         Reviewed by Darin Adler.
12
13         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
14         (AccessibilityUIElement::role):
15         Get the length of the role text, and create a buffer dynamically.
16
17 2009-10-30  Eric Seidel  <eric@webkit.org>
18
19         No review, rolling out r50105.
20         http://trac.webkit.org/changeset/50105
21
22         This commit was causing:
23         https://bugs.webkit.org/show_bug.cgi?id=30869
24         We'll re-implement the feature a different way.
25
26         * Scripts/bugzilla-tool:
27
28 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
29
30         Test for MSAA: Accessibility of headings is not correct
31
32         https://bugs.webkit.org/show_bug.cgi?id=30937
33
34         Reviewed by Adam Roben.
35
36         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
37         (AccessibilityUIElement::role):
38         Allow the role returned to be a BSTR.
39         (AccessibilityUIElement::description):
40         Fix a copy/paste error.
41
42 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
43
44         Test for MSAA: Accessibility of links is wrong
45
46         https://bugs.webkit.org/show_bug.cgi?id=30928
47
48         Reviewed by Darin Adler.
49
50         * DumpRenderTree/AccessibilityUIElement.cpp:
51         (getAccessibilityValueCallback):
52         Return the accessibility value.
53         (AccessibilityUIElement::getJSClass):
54         Added "accessibilityValue" value.
55
56         * DumpRenderTree/AccessibilityUIElement.h:
57
58         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
59         (AccessibilityUIElement::accessibilityValue):
60         Stubbed.
61
62         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
63         (AccessibilityUIElement::accessibilityValue):
64         Stubbed.
65
66         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
67         (AccessibilityUIElement::accessibilityValue):
68         Get the object's value, and return it as a JS string.
69
70 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
71
72         Fix typo in command name used by wx build system.
73
74         * wx/build/build_utils.py:
75
76 2009-10-30  Adam Barth  <abarth@webkit.org>
77
78         Reviewed by Darin Adler.
79
80         Patch v1 is a dumb default name for patches
81         https://bugs.webkit.org/show_bug.cgi?id=30952
82
83         Let's use "Patch" instead.
84
85         * Scripts/bugzilla-tool:
86
87 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
88
89         Unreviewed trivial buildfix.
90
91         [Qt] Buildfix for r50333.
92
93         * DumpRenderTree/qt/DumpRenderTree.pro:
94
95 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
96
97         Reviewed by Holger Freyther.
98
99         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
100         https://bugs.webkit.org/show_bug.cgi?id=30953
101
102         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
103         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
104         makes qt DRT to share this implementation (as gtk and mac ports do).
105
106         * DumpRenderTree/qt/DumpRenderTree.pro:
107         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
108         * DumpRenderTree/qt/WorkQueue.h: Removed.
109
110 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
111
112         Unreviewed potential buildbot fix.
113
114         Second try: Reset page history before running each test.
115
116         Apparently the QWebHistory::clear() keeps the current page
117         in history which is not what we want, so we not additionally
118         sets the history capacity to 0 (forces removing everything)
119         and then sets it back to its original value.
120
121         * DumpRenderTree/qt/DumpRenderTree.cpp:
122         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
123
124 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
125
126         Unreviewed potential buildbot fix.
127
128         Reset page history before running each test.
129
130         * DumpRenderTree/qt/DumpRenderTree.cpp:
131         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
132
133 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
134
135         Reviewed by Eric Seidel.
136
137         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
138
139         Bug 28420 -  Implement HTML5 <ruby> rendering
140         (https://bugs.webkit.org/show_bug.cgi?id=28420)
141
142         No new tests (no functional change).
143
144         * Scripts/build-webkit:
145
146 2009-10-29  Dan Bernstein  <mitz@apple.com>
147
148         Reviewed by Mark Rowe.
149
150         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
151         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
152         define it.
153
154         * Scripts/VCSUtils.pm:
155         * Scripts/svn-apply:
156         * Scripts/svn-unapply:
157
158 2009-10-29  Xan Lopez  <xlopez@igalia.com>
159
160         Reviewed by Gustavo Noronha.
161
162         Use the GTK+ main loop instead of rolling our own mini-version of
163         it.
164
165         * DumpRenderTree/gtk/DumpRenderTree.cpp:
166         (dump):
167         (runTest):
168         (webViewLoadFinished):
169
170 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
171
172         Reviewed by Oliver Hunt.
173
174         Implement the Qt version of DRT dumpBackForwardList().
175
176         * DumpRenderTree/qt/DumpRenderTree.cpp:
177         (WebCore::dumpHistoryItem):
178         (WebCore::DumpRenderTree::dumpBackForwardList):
179
180 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
181
182         Reviewed by Adam Roben.
183
184         Implement DRT functionality for Qt introduced in
185         r28690 and r28705.
186
187         - Implemented pathToLocalResource which exposes the functionality of
188         converting a given unix path to the correct location on Windows.
189         - Implemented a way to remove machine-dependent information from paths
190         in layout test results.
191
192         * DumpRenderTree/qt/DumpRenderTree.cpp:
193         (WebCore::urlSuitableForTestResult):
194         (WebCore::WebPage::javaScriptConsoleMessage):
195         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
196         (LayoutTestController::pathToLocalResource):
197         * DumpRenderTree/qt/LayoutTestControllerQt.h:
198
199 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
200
201         Adding myself to the committers list.
202
203         * Scripts/modules/committers.py:
204
205 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
206
207         Adding myself to the committers list.
208
209         * Scripts/modules/committers.py:
210
211 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
212
213         Reviewed by Jan Alonzo.
214
215         [GTK] API to start inspector for a WebView
216         https://bugs.webkit.org/show_bug.cgi?id=22551
217
218         Use the new inspector API to implement the LayoutTestController
219         interfaces used to test the inspector.
220
221         * DumpRenderTree/gtk/DumpRenderTree.cpp:
222         (webInspectorInspectWebView):
223         (createWebView):
224         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
225         (LayoutTestController::showWebInspector):
226         (LayoutTestController::closeWebInspector):
227         (LayoutTestController::evaluateInWebInspector):
228
229 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
230
231         Reviewed by Eric Seidel.
232
233         [Qt] WebFrame::counterValueForElementById must not be exposed
234         https://bugs.webkit.org/show_bug.cgi?id=30882
235
236         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
237         (LayoutTestController::counterValueForElementById):
238
239 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
240
241         Rubberstamped by Oliver Hunt.
242
243         Fix the warning:
244
245         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
246         declared with attribute warn_unused_result".
247
248         by actually checking the result. In the case it is null, an
249         error has occoured, so treat it as the other fatal errors.
250
251         * DumpRenderTree/qt/DumpRenderTree.cpp:
252         (WebCore::DumpRenderTree::initializeFonts):
253
254 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
255
256         Reviewed by Darin Adler.
257
258         Provide a way to get counter values with layoutTestContoller
259         https://bugs.webkit.org/show_bug.cgi?id=30555
260
261         Define layoutTestContoller.counterValueForElementById.
262
263         * DumpRenderTree/LayoutTestController.cpp:
264         (counterValueForElementByIdCallback):
265         (LayoutTestController::staticFunctions):
266         * DumpRenderTree/LayoutTestController.h:
267         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
268         (LayoutTestController::counterValueForElementById):
269
270 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
271
272         Rubberstamped by Oliver Hunt.
273
274         Change two methods to be internal for DRT use only.
275
276         Part of [Qt] Review all new API in Qt 4.6
277         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
278
279         * DumpRenderTree/qt/DumpRenderTree.cpp:
280         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
281         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
282         (LayoutTestController::whiteListAccessFromOrigin):
283
284 2009-10-27  Eric Seidel  <eric@webkit.org>
285
286         Reviewed by Adam Barth.
287
288         REGRESSION: svn-apply exits(1) when applying a patch with a file add
289         https://bugs.webkit.org/show_bug.cgi?id=30826
290
291         * Scripts/svn-apply:
292          - Add () around all system() calls.
293          - Use the correct system() == 0 or die instead of system() or die
294          - Add descriptive messages to all die statements.
295
296 2009-10-27  Steve Block  <steveblock@google.com>
297
298         Reviewed by NOBODY.
299
300         Adds steveblock@google.com to list of committers.
301
302         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
303
304 2009-10-27  Eric Seidel  <eric@webkit.org>
305
306         Reviewed by Adam Barth.
307
308         svn-apply can exit(0) even on patch failure
309         https://bugs.webkit.org/show_bug.cgi?id=29622
310
311         * Scripts/svn-apply:
312          - Add a bunch of "or die" statements, hopefully catching all
313            possible cases where failure could still exit(0).
314
315 2009-10-27  Eric Seidel  <eric@webkit.org>
316
317         Reviewed by Adam Barth.
318
319         svn-* scripts should share code through VCSUtils.pm
320         https://bugs.webkit.org/show_bug.cgi?id=30791
321
322         Just moving code into a shared location.
323
324         * Scripts/VCSUtils.pm:
325         * Scripts/prepare-ChangeLog:
326         * Scripts/resolve-ChangeLogs:
327         * Scripts/svn-apply:
328         * Scripts/svn-create-patch:
329         * Scripts/svn-unapply:
330         * Scripts/update-webkit:
331
332 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
333
334         Suppress a huge number of MSVC warnings when building wxWebKit.
335
336         * wx/build/settings.py:
337
338 2009-10-26  Eric Seidel  <eric@webkit.org>
339
340         No review, just adding Mike Belshe to the committers list.
341
342         * Scripts/modules/committers.py:
343
344 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
345
346         Reviewed by Darin Adler.
347
348         Make .rc files compile on Windows without depending on MFC headers
349         https://bugs.webkit.org/show_bug.cgi?id=30750
350
351         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
352         windows.h instead of afxres.h because it exists even when MFC is not 
353         installed, and is all that's needed here.
354
355         * FindSafari/FindSafari.rc: Ditto
356
357 2009-10-24  Eric Seidel  <eric@webkit.org>
358
359         Reviewed by Adam Barth.
360
361         bugzilla-tool post-diff should know how to mark commit-queue=?
362         https://bugs.webkit.org/show_bug.cgi?id=29202
363
364         * Scripts/bugzilla-tool:
365          - Add --commit-queue option to post-diff, post-commits and create-bug.
366         * Scripts/modules/bugzilla.py:
367          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
368          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
369
370 2009-10-23  Eric Seidel  <eric@webkit.org>
371
372         Reviewed by Adam Barth.
373
374         bugzilla-tool commit-queue does not notice modifications to committers.py
375         https://bugs.webkit.org/show_bug.cgi?id=30084
376
377         * Scripts/bugzilla-tool:
378          - Make commit-queue re-exec itself instead of using while(1).
379          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
380          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
381
382 2009-10-22  Eric Seidel  <eric@webkit.org>
383
384         Reviewed by Adam Barth.
385
386         commit-queue will get stuck on patches if land-patches terminates unexpectedly
387         https://bugs.webkit.org/show_bug.cgi?id=30634
388
389         * Scripts/bugzilla-tool:
390          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
391          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
392
393 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
394
395         Reviewed by Eric Seidel.
396
397         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
398
399         https://bugs.webkit.org/show_bug.cgi?id=30763
400
401         * pywebsocket/mod_pywebsocket/__init__.py:
402         * pywebsocket/mod_pywebsocket/dispatch.py:
403         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
404         * pywebsocket/mod_pywebsocket/standalone.py:
405         * pywebsocket/setup.py:
406         * pywebsocket/test/test_dispatch.py:
407
408 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
409
410         Reviewed by David Levin.
411
412         REGRESSION: 2 failures in run-webkit-unittests
413         https://bugs.webkit.org/show_bug.cgi?id=30645
414
415         * Scripts/modules/cpp_style_unittest.py:
416         Fixed a few test scenarios which apparently lost some spaces from 
417         text literals.
418
419 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
420
421         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
422
423         * Scripts/webkitdirs.pm:
424
425 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
426
427         Reviewed by Darin Adler.
428
429         Unification of using null device in perl scripts.
430         https://bugs.webkit.org/show_bug.cgi?id=30572
431
432         * Scripts/VCSUtils.pm:
433         * Scripts/bisect-builds:
434         * Scripts/resolve-ChangeLogs:
435         * Scripts/run-iexploder-tests:
436         * Scripts/run-jsc:
437         * Scripts/run-mangleme-tests:
438         * Scripts/run-webkit-tests:
439         * Scripts/webkitdirs.pm:
440         Using File::Spec->devnull() instead of hard coded /dev/null.
441
442 2009-10-26  Eric Seidel  <eric@webkit.org>
443
444         Reviewed by Holger Freyther.
445
446         Reviewers are missing from committers.py
447         https://bugs.webkit.org/show_bug.cgi?id=30733
448
449         * Scripts/modules/committers.py:
450
451 2009-10-23  Eric Seidel  <eric@webkit.org>
452
453         No review, only adding Alice to the list of reviewers.
454
455         * Scripts/modules/committers.py:
456
457 2009-10-23  Eric Seidel  <eric@webkit.org>
458
459         Reviewed by Eric Carlson.
460
461         fast/media/mq-transform-02.html failed on Leopard Commit Bot
462         https://bugs.webkit.org/show_bug.cgi?id=30700
463
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         (resetDefaultsToConsistentValues): Update QuickTime version check.
466
467 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
468
469         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
470         character measurement APIs that are private on Tiger.
471
472         * wx/build/settings.py:
473
474 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
475
476         Reviewed by NOBODY (build fix).
477         Build fix following bug #30696.
478
479         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
480         (LayoutTestController::evaluateScriptInIsolatedWorld):
481
482 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
483
484         Reviewed by Sam Weinig & Geoff Garen.
485
486         https://bugs.webkit.org/show_bug.cgi?id=30696
487         Enable isolated-worlds tests on mac.
488
489         Add private interface for DRT to invoke execution in a given world.
490
491         * DumpRenderTree/LayoutTestController.cpp:
492         (evaluateScriptInIsolatedWorldCallback):
493         (LayoutTestController::staticFunctions):
494         * DumpRenderTree/LayoutTestController.h:
495         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
496         (LayoutTestController::evaluateScriptInIsolatedWorld):
497         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
498         (LayoutTestController::evaluateScriptInIsolatedWorld):
499
500 2009-10-21  Eric Seidel  <eric@webkit.org>
501
502         Reviewed by Adam Barth.
503
504         bugzilla-tool's "patch failed to download an apply" error should give more information
505         https://bugs.webkit.org/show_bug.cgi?id=30632
506
507         * Scripts/modules/scm.py:
508          - Use the common run_command method instead of custom POpen code.
509          - Make run_command know how to take pipes as input.
510         * Scripts/modules/scm_unittest.py:
511          - Add new tests to cover change.
512          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
513
514 2009-10-21  Kent Tamura  <tkent@chromium.org>
515
516         Unreviewed.  Adding myself to the committers list.
517
518         * Scripts/modules/committers.py:
519
520 2009-10-21  Robin Dunn  <robin@alldunn.com>
521
522         Reviewed by Kevin Ollivier.
523
524         Update the Windows installer builder to work with Vista / Win 7 and with git.
525         
526         https://bugs.webkit.org/show_bug.cgi?id=30649
527
528         * wx/build/build_utils.py:
529         * wx/packaging/build-mac-installer.py:
530         * wx/packaging/build-win-installer.py:
531         * wx/packaging/wxWebKitInstaller.iss.in:
532
533 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
534
535         Reviewed by Gustavo Noronha.
536
537         [GTK] Added conditional code to avoid using
538         gdk_window_get_root_coords if we do not have a gtk+ release newer
539         than 2.17.3.
540         https://bugs.webkit.org/show_bug.cgi?id=30636
541
542         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
543
544 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
545
546         Reviewed by Eric Seidel.
547
548         [Qt] Added dummy implementation for keepWebHistory()
549         https://bugs.webkit.org/show_bug.cgi?id=30592
550
551         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
552         (LayoutTestController::keepWebHistory):
553         * DumpRenderTree/qt/LayoutTestControllerQt.h:
554
555 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
556
557         Reviewed by Xan Lopez.
558
559         [GTK] Fixed the double click condition, it is not double click if
560         we move in just in one direction.
561         https://bugs.webkit.org/show_bug.cgi?id=30636
562
563         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
564
565 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
566
567         Reviewed by Xan Lopez.
568
569         [GTK] Initialize the events completly before emitting them.
570         https://bugs.webkit.org/show_bug.cgi?id=30633
571
572         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
573
574 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
575
576         wx build fix. Fix for when linking using --as-needed with gcc.
577
578         * wx/browser/wscript:
579
580 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
581
582         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
583         to support all the features used by CURL backend.
584         
585         * wx/build/settings.py:
586         * wx/install-unix-extras:
587
588 2009-10-20  Anton Muhin  <antonm@chromium.org>
589
590         Reviewed by Adam Barth.
591
592         Add {ager,antonm,yurys}@chromium.org into committers.py
593         https://bugs.webkit.org/show_bug.cgi?id=30560
594
595         * Scripts/modules/committers.py:
596
597 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
598
599         Reviewed by Tor Arne Vestbø.
600
601         Make the Netscape Test plugin available to the Qt launcher.
602
603         * Scripts/run-launcher:
604
605 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
606
607         Reviewed by David Levin.
608
609         Removed WebSocket runtime settings.
610         https://bugs.webkit.org/show_bug.cgi?id=29896
611
612         WebSocket runtime configuration is supported by chromium/v8 only.
613
614         * DumpRenderTree/mac/DumpRenderTree.mm:
615         (resetDefaultsToConsistentValues):
616         * DumpRenderTree/win/DumpRenderTree.cpp:
617         (resetDefaultsToConsistentValues):
618
619 2009-10-19  Nate Chapin  <japhet@chromium.org>
620
621         Reviewed by Adam Barth.
622
623         Add testFail() to test plugin so we can test our handling of a
624         plugin invoke call returning false.
625
626         https://bugs.webkit.org/show_bug.cgi?id=30239
627
628         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
629         (pluginInvoke):
630         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
631
632 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
633
634         Reviewed by Gustavo Noronha.
635
636         Enable DOM pasting when running layout tests.
637
638         * DumpRenderTree/gtk/DumpRenderTree.cpp:
639         (resetDefaultsToConsistentValues):
640
641 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
642
643         Reviewed by Simon Hausmann.
644
645         Use the setPreferredContentsSize method instead
646         of setFixedContentsSize, as the method has been renamed.
647
648         * DumpRenderTree/qt/DumpRenderTree.cpp:
649         (WebCore::DumpRenderTree::open):
650         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
651         (LayoutTestController::setFixedContentsSize):
652
653 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
654
655         Reviewed by Dan Bernstein.
656
657         https://bugs.webkit.org/show_bug.cgi?id=30456
658         Fixes for new Debug_All Windows build configuration.
659
660         * DumpRenderTree/win/DumpRenderTree.cpp:
661         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
662         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
663
664 2009-10-16  Eric Seidel  <eric@webkit.org>
665
666         Reviewed by Adam Barth.
667
668         commit-queue status bot should list which buildbot is blocking the queue
669         https://bugs.webkit.org/show_bug.cgi?id=30452
670
671         Add new methods and testing.
672
673         * Scripts/bugzilla-tool:
674         * Scripts/modules/buildbot.py:
675         * Scripts/modules/buildbot_unittest.py:
676
677 2009-10-16  Eric Seidel  <eric@webkit.org>
678
679         Reviewed by Adam Barth.
680
681         run-webkit-tests fails when CWD is not inside a WebKit checkout
682         https://bugs.webkit.org/show_bug.cgi?id=30451
683
684         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
685         * Scripts/modules/scm_unittest.py:
686           - Remove use of original_path (we don't need to restore the CWD).
687           - Don't use '.' to find the webkit checkout, use __file__ instead.
688
689 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
690
691         Reviewed by Adam Roben.
692
693         Add a Debug_All configuration to build entire stack as debug.
694         Change Debug_Internal to:
695         - stop using _debug suffix for all WebKit/Safari binaries
696         - not use _debug as a DLL naming suffix
697         - use non-debug C runtime lib.
698
699         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
700         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
701         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
702         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
703         Add missing debug.vsprops inherited property sheet.
704         Add Debug_All configuration.
705         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
706         * WinLauncher/WinLauncher.vcproj:
707         Removed extraneous definitions inherited from vsprops.
708         Add Debug_All configuration.
709
710 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
711
712         Reviewed by David Levin.
713
714         check-webkit-style is wrong about indent checking in namespaces
715         in header files and a few other things
716         https://bugs.webkit.org/show_bug.cgi?id=30362
717
718         The few other things include:
719         + check-webkit-style does not require spaces around the equal sign
720           inside 'if' statements and around binary operators that take 
721           numeric literals.
722         + check-webkit-style reports false errors for the / operator
723           when part of a filename in the #include directive.
724
725         * Scripts/modules/cpp_style.py:
726         Improved indentation checking and space checking around
727         binary operators. While the checks are still not perfect,
728         they are clearly better than before.
729         * Scripts/modules/cpp_style_unittest.py:
730         Added test cases for the newly supported checks and modified old
731         test cases to match the new guidelines
732
733 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
734
735         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
736
737         * wx/build/settings.py:
738
739 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
740
741         Reviewed by David Levin.
742
743         Add mod_pywebsocket to test Web Sockets.
744         http://code.google.com/p/pywebsocket/
745         https://bugs.webkit.org/show_bug.cgi?id=27490
746
747         * pywebsocket/COPYING: Added.
748         * pywebsocket/MANIFEST.in: Added.
749         * pywebsocket/README: Added.
750         * pywebsocket/example/echo_client.py: Added.
751         * pywebsocket/example/echo_wsh.py: Added.
752         * pywebsocket/mod_pywebsocket/__init__.py: Added.
753         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
754         * pywebsocket/mod_pywebsocket/handshake.py: Added.
755         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
756         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
757         * pywebsocket/mod_pywebsocket/standalone.py: Added.
758         * pywebsocket/mod_pywebsocket/util.py: Added.
759         * pywebsocket/setup.py: Added.
760         * pywebsocket/test/config.py: Added.
761         * pywebsocket/test/mock.py: Added.
762         * pywebsocket/test/run_all.py: Added.
763         * pywebsocket/test/test_dispatch.py: Added.
764         * pywebsocket/test/test_handshake.py: Added.
765         * pywebsocket/test/test_mock.py: Added.
766         * pywebsocket/test/test_msgutil.py: Added.
767         * pywebsocket/test/test_util.py: Added.
768         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
769         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
770         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
771         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
772         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
773         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
774         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
775         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
776
777 2009-10-15  James Robinson  <jamesr@google.com>
778
779         Reviewed by David Levin.
780
781         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
782
783         https://bugs.webkit.org/show_bug.cgi?id=30426
784
785         * Scripts/modules/cpp_style.py:
786         * Scripts/modules/cpp_style_unittest.py:
787
788 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
789
790         Reviewed by Adam Roben.
791
792         Fixes <http://webkit.org/b/30411>.
793         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
794         
795         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
796         building Chromium.
797
798         * Scripts/pdevenv:
799
800 2009-10-15  Robin Dunn  <robin@alldunn.com>
801
802         Reviewed by Kevin Ollivier.
803
804         Add Mac package building scripts for wx.
805         
806         https://bugs.webkit.org/show_bug.cgi?id=30405
807
808         * wx/build/build_utils.py:
809         * wx/build/settings.py:
810         * wx/packaging/build-mac-installer.py: Added.
811
812 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
813
814         Reviewed by Gustavo Noronha.
815
816         Enable Web Sockets support when running layout tests.
817
818         * DumpRenderTree/gtk/DumpRenderTree.cpp:
819         (resetDefaultsToConsistentValues):
820
821 2009-10-15  Xan Lopez  <xlopez@igalia.com>
822
823         Reviewed by Gustavo Noronha.
824
825         Need to initialize event.button.button, since in most cases a
826         button number is not passed as an argument.
827
828         * DumpRenderTree/gtk/EventSender.cpp:
829         (mouseDownCallback):
830         (mouseUpCallback):
831
832 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
833
834         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
835         the OS if none was explicitly set.
836
837         * wx/build/settings.py:
838
839 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
840
841         Reviewed by Timothy Hatcher.
842
843         Web Inspector: enable developers extras within inspector layout tests.
844
845         https://bugs.webkit.org/show_bug.cgi?id=30014
846
847         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
848         (LayoutTestController::showWebInspector):
849         (LayoutTestController::closeWebInspector):
850         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
851         (LayoutTestController::showWebInspector):
852         (LayoutTestController::closeWebInspector):
853
854 2009-10-14  José Millán Soto  <jmillan@igalia.com>
855
856         Reviewed by Jan Alonzo.
857
858         GtkLauncher is using a deprecated signal
859         https://bugs.webkit.org/show_bug.cgi?id=30364
860
861         Modified GtkLauncher to use notify::title signal instead of
862         deprecated title-changed signal
863
864         * GtkLauncher/main.c:
865         (notify_title_cb):
866         (create_browser):
867
868 2009-10-14  Brady Eidson  <beidson@apple.com>
869
870         Reviewed by Sam Weinig.
871
872         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
873         1 - Disables WebHistory
874         2 - Doesn't make sense in that context anyway.
875
876         * DumpRenderTree/win/DumpRenderTree.cpp:
877         (createWebViewAndOffscreenWindow):
878
879 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
880
881         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
882         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
883
884         * wx/build/settings.py:
885         * wx/install-unix-extras:
886
887 2009-10-14  Brady Eidson  <beidson@apple.com>
888
889         Reviewed by Sam Weinig.
890
891         WebKit Win API should provide a delegate interface for global history.
892         https://bugs.webkit.org/show_bug.cgi?id=29905
893
894         * DumpRenderTree/LayoutTestController.cpp:
895         (LayoutTestController::LayoutTestController):
896         * DumpRenderTree/LayoutTestController.h:
897         (LayoutTestController::dumpHistoryDelegateCallbacks):
898         (LayoutTestController::setDumpHistoryDelegateCallbacks):
899                 
900         * DumpRenderTree/win/DumpRenderTree.cpp:
901         (shouldLogHistoryDelegates):
902         (runTest):
903         (createWebViewAndOffscreenWindow):
904         (main):
905         * DumpRenderTree/win/DumpRenderTree.vcproj:
906         
907         Add the IWebHistoryDelegate to DRT Windows:
908         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
909         (wstringFromBSTR):
910         (HistoryDelegate::HistoryDelegate):
911         (HistoryDelegate::~HistoryDelegate):
912         (HistoryDelegate::QueryInterface):
913         (HistoryDelegate::AddRef):
914         (HistoryDelegate::Release):
915         (HistoryDelegate::didNavigateWithNavigationData):
916         (HistoryDelegate::didPerformClientRedirectFromURL):
917         (HistoryDelegate::didPerformServerRedirectFromURL):
918         (HistoryDelegate::updateHistoryTitle):
919         (HistoryDelegate::populateVisitedLinksForWebView):
920         * DumpRenderTree/win/HistoryDelegate.h: Added.
921
922         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
923         (LayoutTestController::removeAllVisitedLinks):
924
925 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
926
927         Reviewed by Simon Hausmann.
928
929         [Qt] Implement support for setPOSIXLocale on Qt.
930         https://bugs.webkit.org/show_bug.cgi?id=30268 
931  
932         * DumpRenderTree/qt/DumpRenderTree.cpp:
933         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
934         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
935         (LayoutTestController::setPOSIXLocale):
936         * DumpRenderTree/qt/LayoutTestControllerQt.h:
937
938 2009-10-13  Stephanie Lewis  <slewis@apple.com>
939
940         Unreviewed, adding myself to reviewers list.
941
942         * Scripts/modules/committers.py:
943
944 2009-10-13  Stephanie Lewis  <slewis@apple.com>
945
946         Reviewed by Mark Rowe.
947
948         Fix null assignment so root tests work again.
949
950         * Scripts/webkitdirs.pm:
951
952 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
953
954         Reviewed by Simon Hausmann.
955
956         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
957         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
958         This is done in preparation of implementing missing features in DRT.
959         No functionality changes made yet.
960
961         * DumpRenderTree/qt/DumpRenderTree.cpp:
962         * DumpRenderTree/qt/DumpRenderTree.pro:
963         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
964         (EventSender::EventSender):
965         (EventSender::mouseDown):
966         (EventSender::mouseUp):
967         (EventSender::mouseMoveTo):
968         (EventSender::leapForward):
969         (EventSender::keyDown):
970         (EventSender::contextClick):
971         (EventSender::scheduleAsynchronousClick):
972         (EventSender::frameUnderMouse):
973         * DumpRenderTree/qt/EventSenderQt.h: Added.
974         (EventSender::clearKillRing):
975         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
976         (LayoutTestController::LayoutTestController):
977         (LayoutTestController::reset):
978         (LayoutTestController::processWork):
979         (LayoutTestController::maybeDump):
980         (LayoutTestController::waitUntilDone):
981         (LayoutTestController::notifyDone):
982         (LayoutTestController::windowCount):
983         (LayoutTestController::clearBackForwardList):
984         (LayoutTestController::dumpEditingCallbacks):
985         (LayoutTestController::dumpResourceLoadCallbacks):
986         (LayoutTestController::queueBackNavigation):
987         (LayoutTestController::queueForwardNavigation):
988         (LayoutTestController::queueLoad):
989         (LayoutTestController::queueReload):
990         (LayoutTestController::queueScript):
991         (LayoutTestController::provisionalLoad):
992         (LayoutTestController::timerEvent):
993         (LayoutTestController::encodeHostName):
994         (LayoutTestController::decodeHostName):
995         (LayoutTestController::setJavaScriptProfilingEnabled):
996         (LayoutTestController::setFixedContentsSize):
997         (LayoutTestController::setPrivateBrowsingEnabled):
998         (LayoutTestController::setPopupBlockingEnabled):
999         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1000         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1001         (LayoutTestController::numberOfActiveAnimations):
1002         (LayoutTestController::disableImageLoading):
1003         (LayoutTestController::dispatchPendingLoadRequests):
1004         (LayoutTestController::setDatabaseQuota):
1005         (LayoutTestController::clearAllDatabases):
1006         (LayoutTestController::whiteListAccessFromOrigin):
1007         (LayoutTestController::waitForPolicyDelegate):
1008         (LayoutTestController::overridePreference):
1009         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1010         (LayoutTestController::isLoading):
1011         (LayoutTestController::setLoading):
1012         (LayoutTestController::shouldDumpAsText):
1013         (LayoutTestController::shouldDumpBackForwardList):
1014         (LayoutTestController::shouldDumpChildrenAsText):
1015         (LayoutTestController::shouldDumpDatabaseCallbacks):
1016         (LayoutTestController::shouldDumpStatusCallbacks):
1017         (LayoutTestController::shouldWaitUntilDone):
1018         (LayoutTestController::canOpenWindows):
1019         (LayoutTestController::shouldDumpTitleChanges):
1020         (LayoutTestController::waitForPolicy):
1021         (LayoutTestController::dumpAsText):
1022         (LayoutTestController::dumpChildFramesAsText):
1023         (LayoutTestController::dumpDatabaseCallbacks):
1024         (LayoutTestController::dumpStatusCallbacks):
1025         (LayoutTestController::setCanOpenWindows):
1026         (LayoutTestController::dumpBackForwardList):
1027         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1028         (LayoutTestController::display):
1029         (LayoutTestController::dumpTitleChanges):
1030         (LayoutTestController::dumpSelectionRect):
1031         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1032         (TextInputController::TextInputController):
1033         (TextInputController::doCommand):
1034         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1035         * DumpRenderTree/qt/WorkQueue.cpp:
1036         * DumpRenderTree/qt/WorkQueue.h:
1037         * DumpRenderTree/qt/WorkQueueItem.h:
1038         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1039         (findFrameNamed):
1040         (LoadItem::invoke):
1041         (ReloadItem::invoke):
1042         (ScriptItem::invoke):
1043         (BackForwardItem::invoke):
1044         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1045         * DumpRenderTree/qt/jsobjects.h:
1046
1047 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1048
1049         Not reviewed, adding myself to the list of reviewers.
1050
1051         * Scripts/modules/committers.py:
1052
1053 2009-10-13  Anders Carlsson  <andersca@apple.com>
1054
1055         Reviewed by Sam Weinig.
1056
1057         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1058
1059         Make the private browsing mode testable by the test plug-in.
1060         
1061         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1062         (pluginGetProperty):
1063         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1064         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1065         (NPP_New):
1066         (NPP_SetValue):
1067
1068 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1069
1070         No review, just adding self to the list of reviewers.
1071
1072         * Scripts/modules/committers.py:
1073
1074 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1075
1076         Reviewed by Adam Roben.
1077
1078         Web Inspector: Use proper web view in inspector layout
1079         tests for windows.
1080
1081         https://bugs.webkit.org/show_bug.cgi?id=30298
1082
1083         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1084         (LayoutTestController::showWebInspector):
1085         (LayoutTestController::closeWebInspector):
1086         (LayoutTestController::evaluateInWebInspector):
1087
1088 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1089
1090         Reviewed by Sam Weinig.
1091
1092         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1093         https://bugs.webkit.org/show_bug.cgi?id=29841
1094
1095         * DumpRenderTree/mac/DumpRenderTree.mm:
1096         (resetDefaultsToConsistentValues):
1097         * DumpRenderTree/win/DumpRenderTree.cpp:
1098         (resetDefaultsToConsistentValues):
1099
1100 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1101
1102         Reviewed by Dimitri Glazkov.
1103
1104         Chromium Port - Windows
1105         https://bugs.webkit.org/show_bug.cgi?id=29969
1106
1107         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1108         * Scripts/webkitdirs.pm:
1109
1110 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1111
1112         Reviewed by Darin Adler.
1113
1114         jsc scripts cleanup and Qt/GTK fix
1115         https://bugs.webkit.org/show_bug.cgi?id=30288
1116
1117         Duplicated jscPath() moved to webkitdirs.pm.
1118         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1119         Configuration added (release/debug) to path for Qt-port on Windows.
1120
1121         * Scripts/run-javascriptcore-tests:
1122         * Scripts/run-jsc:
1123         * Scripts/run-sunspider:
1124         * Scripts/sunspider-compare-results:
1125         * Scripts/webkitdirs.pm:
1126
1127 2009-10-11  Adam Barth  <abarth@webkit.org>
1128
1129         Unreviewed.  Add Collin to committers.py.
1130
1131         * Scripts/modules/committers.py:
1132
1133 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
1134
1135         wx build fix, add bindings to source/include dirs now that there are sources there.
1136
1137         * wx/build/settings.py:
1138
1139 2009-10-09  Mark Rowe  <mrowe@apple.com>
1140
1141         Reviewed by Brady Eidson.
1142
1143         Enable plug-in halting in DumpRenderTree.
1144
1145         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
1146         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
1147
1148         * DumpRenderTree/mac/DumpRenderTree.mm:
1149         (resetDefaultsToConsistentValues):
1150         * DumpRenderTree/mac/UIDelegate.mm:
1151         (-[UIDelegate webView:shouldHaltPlugin:]):
1152
1153 2009-10-08  Brady Eidson  <beidson@apple.com>
1154
1155         Reviewed by Dan Bernstein.
1156
1157         Ask the History Delegate to populate the visited links hash.
1158         <rdar://problem/7285293> and https://webkit.org/b/29904
1159
1160         Add the ability for LayoutTestController to clear all visited links.
1161         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
1162
1163         * DumpRenderTree/LayoutTestController.cpp:
1164         (LayoutTestController::LayoutTestController):
1165         (removeAllVisitedLinksCallback):
1166         (LayoutTestController::staticFunctions):
1167         * DumpRenderTree/LayoutTestController.h:
1168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1169         (LayoutTestController::removeAllVisitedLinks):
1170
1171         * DumpRenderTree/mac/HistoryDelegate.mm:
1172         (-[HistoryDelegate populateVisitedLinksForWebView:]):
1173
1174         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1175         (LayoutTestController::removeAllVisitedLinks):
1176         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1177         (LayoutTestController::removeAllVisitedLinks):
1178         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1179         (LayoutTestController::removeAllVisitedLinks):
1180
1181
1182 2009-10-08  Daniel Bates  <dbates@webkit.org>
1183
1184         Reviewed by Adam Roben.
1185
1186         https://bugs.webkit.org/show_bug.cgi?id=30175
1187         
1188         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
1189         the OLE drag-and-drop return value like the function it emulates. Currently, 
1190         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
1191         whether the drag-and-drop operation was successful or was cancelled.
1192         
1193         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
1194         return value according to whether the drop operation was successful or not.
1195
1196         * DumpRenderTree/win/EventSender.cpp:
1197         (doMouseUp): Added parameter oleDragAndDropReturnValue.
1198         (replaySavedEvents): Ditto.
1199         * DumpRenderTree/win/EventSender.h:
1200         * DumpRenderTree/win/UIDelegate.cpp:
1201         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
1202
1203 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1204
1205         Reviewed by Xan Lopez.
1206
1207         [GTK] Added support for a parameter setting the button that was
1208         pressed in the mouseDown function.
1209         https://bugs.webkit.org/show_bug.cgi?id=30220
1210
1211         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1212
1213 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1214
1215         Reviewed by Xan Lopez.
1216
1217         [GTK] Added a line to the bottom of the expected result to match
1218         the output of the test.
1219         https://bugs.webkit.org/show_bug.cgi?id=30220
1220
1221         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
1222         expected.txt:
1223
1224 2009-10-08  Adam Roben  <aroben@apple.com>
1225
1226         Use QueryInterface to get IWebInspectorPrivate
1227
1228         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
1229         accessed in a more standard way
1230
1231         Reviewed by John Sullivan and Tim Hatcher.
1232
1233         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1234         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
1235         by calling IWebViewPrivate::inspector, then use QueryInterface to get
1236         to the IWebInspectorPrivate interface.
1237
1238 2009-10-07  Adam Roben  <aroben@apple.com>
1239
1240         Implement DRT support for origin whitelisting
1241
1242         Fixes <http://webkit.org/b/30185>.
1243
1244         Reviewed by Eric Seidel.
1245
1246         * DumpRenderTree/win/DumpRenderTree.cpp:
1247         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
1248         whitelist, to match Mac DRT.
1249         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1250         (LayoutTestController::whiteListAccessFromOrigin): Call through to
1251         IWebViewPrivate::whiteListAccessFromOrigin.
1252
1253 2009-10-07  Brady Eidson  <beidson@apple.com>
1254
1255         Reviewed by Darin Adler.
1256
1257         Send title changes to the global history delegate.
1258         <rdar://problem/7285293> and https://webkit.org/b/29904
1259
1260         * DumpRenderTree/mac/HistoryDelegate.mm:
1261         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
1262
1263 2009-10-07  Adam Barth  <abarth@webkit.org>
1264
1265         Unreviewed.  Remove some folks from committers.py who were listed on
1266         the WebKit Team wiki page but who weren't actually listed as commit+.
1267         At some point, we should coorelate this list with the committers
1268         mailing list.
1269
1270         * Scripts/modules/committers.py:
1271
1272 2009-10-07  Adam Barth  <abarth@webkit.org>
1273
1274         Unreviewed.  Import a bunch of committers from the WebKit Team page on
1275         the wiki into committers.py.
1276
1277         * Scripts/modules/committers.py:
1278
1279 2009-10-07  Adam Barth  <abarth@webkit.org>
1280
1281         Unreviewed.  Added Aaron Boodman to committers.py.
1282
1283         * Scripts/modules/committers.py:
1284
1285 2009-10-07  Evan Martin  <evan@chromium.org>
1286
1287         Reviewed by Darin Adler.
1288
1289         Add API to LayoutTestController for re/setting the system locale.
1290         https://bugs.webkit.org/show_bug.cgi?id=18994
1291
1292         * DumpRenderTree/LayoutTestController.cpp:
1293         (setLocaleCallback):
1294         (LayoutTestController::staticFunctions):
1295         (LayoutTestController::setLocale):
1296         * DumpRenderTree/LayoutTestController.h:
1297
1298 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
1299
1300         Reviewed by Jan Alonzo.
1301
1302         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1303         https://bugs.webkit.org/show_bug.cgi?id=29689
1304
1305         Build fix by adding -lfontconfig for DumpRenderTree.
1306
1307         * GNUmakefile.am:
1308
1309 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1310
1311         Reviewed by Simon Hausmann.
1312
1313         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
1314
1315         * Scripts/run-webkit-tests:
1316
1317 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1318
1319         Reviewed by Gustavo Noronha.
1320
1321         "delete" in EventSender is the backspace key, not the delete one.
1322
1323         * DumpRenderTree/gtk/EventSender.cpp:
1324         (keyDownCallback):
1325
1326 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1327
1328         Reviewed by Gustavo Noronha.
1329
1330         getChildrenWithRange expects as last parameter the end index, not
1331         the length of the range. Correct this and clarify the variable
1332         names to reflect how the code works.
1333
1334         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1335         (AccessibilityUIElement::getChildrenWithRange):
1336         (AccessibilityUIElement::getChildAtIndex):
1337
1338 2009-10-06  Mark Rowe  <mrowe@apple.com>
1339
1340         Reviewed by Simon Fraser.
1341
1342         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
1343
1344         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
1345         the fact we have already changed the working directory to the top of the open source tree.
1346
1347 2009-10-06  Julie Parent  <jparent@chromium.org>
1348
1349         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
1350         rather than my committer email.
1351
1352         * Scripts/modules/committers.py:
1353
1354 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1355
1356         Reviewed by Eric Seidel.
1357
1358         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
1359
1360         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
1361         it after each layout test as it should do, making the DRT dump additional output
1362         for all of the subsequent layout tests.
1363
1364         * DumpRenderTree/qt/jsobjects.cpp:
1365         (LayoutTestController::reset):
1366
1367 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1368
1369         Reviewed by Simon Hausmann.
1370
1371         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
1372         fast/dom/assign-to-window-status.html test, which is passing as a result.
1373
1374         https://bugs.webkit.org/show_bug.cgi?id=30127
1375
1376         * DumpRenderTree/qt/DumpRenderTree.cpp:
1377         (WebCore::DumpRenderTree::DumpRenderTree):
1378         (WebCore::DumpRenderTree::statusBarMessage):
1379         * DumpRenderTree/qt/DumpRenderTree.h:
1380         * DumpRenderTree/qt/jsobjects.h:
1381         (LayoutTestController::shouldDumpStatusCallbacks):
1382         (LayoutTestController::dumpStatusCallbacks):
1383
1384 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1385
1386         Reviewed by Simon Hausmann.
1387
1388         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
1389         ignores the argument indicating which mouse button to trigger.
1390         https://bugs.webkit.org/show_bug.cgi?id=30048
1391
1392         This affects the fast/events/mouse-click-events.html layout test.
1393
1394         * DumpRenderTree/qt/jsobjects.cpp:
1395         (EventSender::mouseDown):
1396         (EventSender::mouseUp):
1397         * DumpRenderTree/qt/jsobjects.h:
1398
1399 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1400
1401         Reviewed by Simon Hausmann.
1402
1403         [Qt] Fix the EventSender::keyDown() implementation
1404         https://bugs.webkit.org/show_bug.cgi?id=30043
1405
1406         It should post both a key press event and a key release event,
1407         just like other ports do.
1408
1409         * DumpRenderTree/qt/jsobjects.cpp:
1410         (EventSender::keyDown):
1411
1412 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
1413
1414         wx build fix. Add jpeg to the list of libs to link against.
1415
1416         * wx/build/settings.py:
1417
1418 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
1419
1420         Reviewed by Simon Hausmann.
1421
1422         [Qt] EventSender::keyDown() cannot send function-key events.
1423         https://bugs.webkit.org/show_bug.cgi?id=30044
1424
1425         This affects the fast/events/keydown-function-keys.html layout test.
1426
1427         * DumpRenderTree/qt/jsobjects.cpp:
1428         (EventSender::keyDown):
1429
1430 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
1431
1432         Added --wx-compiler-prefix waf option to allow building wxWebKit with
1433         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
1434
1435         * wx/build/settings.py:
1436         * wx/build/wxpresets.py:
1437
1438 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
1439
1440         Reviewed by Timothy Hatcher.
1441
1442         Web Inspector: add testing harness for Web Inspector.
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=30010
1445
1446         * DumpRenderTree/LayoutTestController.cpp:
1447         (showWebInspectorCallback):
1448         (closeWebInspectorCallback):
1449         (evaluateInWebInspectorCallback):
1450         (LayoutTestController::staticFunctions):
1451         * DumpRenderTree/LayoutTestController.h:
1452         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1453         (LayoutTestController::showWebInspector):
1454         (LayoutTestController::closeWebInspector):
1455         (LayoutTestController::evaluateInWebInspector):
1456         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1457         (LayoutTestController::showWebInspector):
1458         (LayoutTestController::closeWebInspector):
1459         (LayoutTestController::evaluateInWebInspector):
1460         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1461         (LayoutTestController::showWebInspector):
1462         (LayoutTestController::closeWebInspector):
1463         (LayoutTestController::evaluateInWebInspector):
1464         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1465         (LayoutTestController::showWebInspector):
1466         (LayoutTestController::closeWebInspector):
1467         (LayoutTestController::evaluateInWebInspector):
1468
1469 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1470
1471         Reviewed by Ariyha Hidayat.
1472
1473         Pass arguments to system() as a string instead of array
1474
1475         When passed as an array entries with a space fail to translate
1476         to two arguments to the child process, so instead of manually
1477         splitting all the entries in @buildArgs we pass the whole thing
1478         as a string instead.
1479
1480         * Scripts/webkitdirs.pm:
1481
1482 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
1483
1484         Reviewed by David Levin.
1485
1486         check-webkit-style misses whitespace errors for operators:
1487         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
1488         https://bugs.webkit.org/show_bug.cgi?id=30021
1489
1490         * Scripts/modules/cpp_style.py:
1491         Added the operators mentioned above to the same list as == and !=.
1492
1493 2009-10-02  Julie Parent  <jparent@chromium.org>
1494
1495         Unreviewed.
1496
1497         Adding myself and Ojan Vafai as committers, because we are committers.
1498
1499         * Scripts/modules/committers.py:
1500
1501 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
1502
1503         Reviewed by Adam Roben.
1504
1505         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
1506         this will help the patch merging process when TryBots are used.
1507
1508         * Scripts/svn-create-patch:
1509
1510 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
1511
1512         Reviewed by Simon Hausmann.
1513
1514         [Qt] Implement layoutTestController.overridePreference().
1515         https://bugs.webkit.org/show_bug.cgi?id=29970
1516
1517         * DumpRenderTree/qt/DumpRenderTree.cpp:
1518         (WebCore::WebPage::WebPage):
1519         (WebCore::WebPage::resetSettings):
1520         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1521         * DumpRenderTree/qt/jsobjects.cpp:
1522         (LayoutTestController::reset):
1523         (LayoutTestController::setPrivateBrowsingEnabled):
1524         (LayoutTestController::setPopupBlockingEnabled):
1525         (LayoutTestController::overridePreference):
1526         * DumpRenderTree/qt/jsobjects.h:
1527
1528 2009-10-01  Chris Marrin  <cmarrin@apple.com>
1529
1530         Reviewed by Oliver Hunt.
1531
1532         Turn on ENABLE_3D_CANVAS in TOT
1533         https://bugs.webkit.org/show_bug.cgi?id=29906
1534
1535         * Scripts/build-webkit:
1536
1537 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1538
1539         Rubberstamped by Simon Hausmann.
1540
1541         Enable HTTP tests for Qt
1542
1543         * Scripts/run-webkit-tests:
1544
1545 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
1546
1547         Reviewed by Dimitri Glazkov.
1548
1549         build-webkit --chromium now also works on cygwin.
1550
1551         https://bugs.webkit.org/show_bug.cgi?id=29973
1552
1553         * Scripts/webkitdirs.pm:
1554
1555 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
1556
1557         Reviewed by Simon Hausmann.
1558
1559         [Qt] Don't use TCmalloc in DumpRenderTree
1560         https://bugs.webkit.org/show_bug.cgi?id=27029
1561
1562         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
1563
1564         * DumpRenderTree/qt/DumpRenderTree.pro:
1565
1566 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1567
1568         Reviewed by Simon Hausmann.
1569
1570         [Qt] Implement eventSender.scheduleAsynchronousClick().
1571
1572         https://bugs.webkit.org/show_bug.cgi?id=29931
1573
1574         * DumpRenderTree/qt/jsobjects.cpp:
1575         (EventSender::scheduleAsynchronousClick):
1576         * DumpRenderTree/qt/jsobjects.h:
1577
1578 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1579
1580         Reviewed by Simon Hausmann.
1581
1582         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
1583         fast/events/open-window-from-another-frame.html from the Skipped list.
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=29930
1586
1587         * DumpRenderTree/qt/jsobjects.cpp:
1588         (LayoutTestController::setPopupBlockingEnabled):
1589         * DumpRenderTree/qt/jsobjects.h:
1590
1591 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
1592
1593         Unreviewed.
1594
1595         Added myself to the list of committers.
1596
1597         * Scripts/modules/committers.py:
1598
1599 2009-09-30  Eric Seidel  <eric@webkit.org>
1600
1601         No review, just adding Geoff to the list of reviewers.
1602
1603         * Scripts/modules/committers.py:
1604
1605 2009-09-30  Dan Bernstein  <mitz@apple.com>
1606
1607         Reviewed by Sam Weinig.
1608
1609         Added the WebKit Layout Tests fonts that are referenced in
1610         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
1611
1612         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
1613         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
1614
1615 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1616
1617         Reviewed by David Kilzer.
1618
1619         Make sunspider scripts work on Windows platform.
1620         https://bugs.webkit.org/show_bug.cgi?id=29656
1621
1622         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
1623         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
1624         * Scripts/webkitdirs.pm: currentPerlPath() added.
1625
1626 2009-09-29  Brady Eidson  <beidson@apple.com>
1627
1628         Rubberstamped by Dan Bernstein.
1629
1630         Fix license and some sorting in new files.
1631
1632         * DumpRenderTree/mac/HistoryDelegate.h:
1633         * DumpRenderTree/mac/HistoryDelegate.mm:
1634
1635 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
1636
1637         Reviewed by David Kilzer.
1638
1639         Fixed how error codes are handled.
1640         https://bugs.webkit.org/show_bug.cgi?id=29898
1641
1642         * Scripts/update-webkit:
1643         * Scripts/update-webkit-chromium:
1644
1645 2009-09-29  Brady Eidson  <beidson@apple.com>
1646
1647         Reviewed by John Sullivan.
1648
1649         Updated way-out-of-date sorting throughout the dump methods/flags.
1650
1651         * DumpRenderTree/LayoutTestController.cpp:
1652         (LayoutTestController::LayoutTestController):
1653         (dumpAsPDFCallback):
1654         (dumpAsTextCallback):
1655         (dumpFrameLoadCallbacksCallback):
1656         (dumpResourceLoadCallbacksCallback):
1657         (LayoutTestController::staticFunctions):
1658
1659         * DumpRenderTree/LayoutTestController.h:
1660         (LayoutTestController::dumpAsText):
1661         (LayoutTestController::setDumpAsText):
1662         (LayoutTestController::dumpFrameLoadCallbacks):
1663         (LayoutTestController::setDumpFrameLoadCallbacks):
1664         (LayoutTestController::dumpSelectionRect):
1665         (LayoutTestController::setDumpSelectionRect):
1666         (LayoutTestController::dumpSourceAsWebArchive):
1667         (LayoutTestController::setDumpSourceAsWebArchive):
1668         (LayoutTestController::dumpStatusCallbacks):
1669         (LayoutTestController::setDumpStatusCallbacks):
1670         (LayoutTestController::dumpTitleChanges):
1671         (LayoutTestController::setDumpTitleChanges):
1672         (LayoutTestController::dumpWillCacheResponse):
1673         (LayoutTestController::setDumpWillCacheResponse):
1674
1675 2009-09-29  Brady Eidson  <beidson@apple.com>
1676
1677         Reviewed by John Sullivan.
1678
1679         WebKit Mac API should provide a delegate interface for global history.
1680         <rdar://problem/7042773> and https://webkit.org/b/29904
1681
1682         Adding the dumping of global history delegate callbacks.
1683
1684         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1685
1686         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1687         * DumpRenderTree/mac/DumpRenderTree.mm:
1688         (createWebViewAndOffscreenWindow):
1689         (allocateGlobalControllers):
1690         (shouldLogFrameLoadDelegates):
1691         (shouldLogHistoryDelegates):
1692         (runTest):
1693
1694         Dump history delegate callbacks:
1695         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1696         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1697         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1698         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1699         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1700
1701 2009-09-29  Daniel Bates  <dbates@webkit.org>
1702
1703         Reviewed by Adam Roben.
1704
1705         https://bugs.webkit.org/show_bug.cgi?id=28902
1706         
1707         Fixes an issue where the drop effect returned by Window Dump Render Tree 
1708         was always DROPEFFECT_NONE (since it was hard coded to do so).
1709         
1710         This patch corrects this issue by determining the actual drop effect 
1711         performed by the corresponding drag-and-drop operation so that we can 
1712         return it.
1713
1714         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1715         (DraggingInfo::DraggingInfo):
1716         (DraggingInfo::performedDropEffect): Added method.
1717         (DraggingInfo::setPerformedDropEffect): Added method.
1718         * DumpRenderTree/win/EventSender.cpp:
1719         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1720         Moved delete draggingInfo to UIDelegate::doDragDrop.
1721         * DumpRenderTree/win/UIDelegate.cpp:
1722         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1723
1724 2009-09-29  Dan Bernstein  <mitz@apple.com>
1725
1726         Reviewed by Adam Roben.
1727
1728         Remove copying of unnecessary or nonexistent files from the ImageDiff
1729         post-build event.
1730
1731         * DumpRenderTree/win/ImageDiff.vcproj:
1732
1733 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1734
1735         Reviewed by David Kilzer.
1736
1737         [Qt] Make build-webkit script work on Windows
1738         https://bugs.webkit.org/show_bug.cgi?id=29802
1739
1740         * Scripts/run-webkit-tests:
1741         * Scripts/webkitdirs.pm:
1742          - Removed unnecessary -p switch for mkdir on Windows.
1743          - Use canonical path, which uses slashes or backslashes depends on platform.
1744          - isWindows() only test for Windows and not for Cyqwin.
1745
1746 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1747
1748         Reviewed by Simon Hausmann.
1749
1750         Fix time measurement in build-webkit after refactoring done in r48853.
1751
1752         * Scripts/build-webkit:
1753
1754 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1755
1756         Reviewed by Tor Arne Vestbø.
1757
1758         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1759         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1760
1761         * DumpRenderTree/qt/DumpRenderTree.cpp:
1762         (WebCore::WebPage::WebPage):
1763
1764 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1765
1766         Reviewed by Simon Hausmann.
1767
1768         [Qt] Implement eventSender.contextClick().
1769         https://bugs.webkit.org/show_bug.cgi?id=29821
1770
1771         * DumpRenderTree/qt/jsobjects.cpp:
1772         (EventSender::contextClick):
1773         * DumpRenderTree/qt/jsobjects.h:
1774
1775 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1776
1777         Reviewed by Eric Seidel.
1778
1779         Add experimentalWebSocketsEnabled in WebPreferences.
1780         https://bugs.webkit.org/show_bug.cgi?id=28941
1781
1782         * DumpRenderTree/mac/DumpRenderTree.mm:
1783         (resetDefaultsToConsistentValues):
1784         * DumpRenderTree/win/DumpRenderTree.cpp:
1785         (resetDefaultsToConsistentValues):
1786
1787 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1788
1789         Reviewed by David Kilzer.
1790
1791         Integrated chromium port building into webkit tools update-webkit and
1792         build-webkit.
1793
1794         https://bugs.webkit.org/show_bug.cgi?id=29749
1795
1796         * Scripts/build-webkit: When --chromium is specified, will build
1797           the chromium port (currently only Mac is supported).
1798         * Scripts/update-webkit: When --chromium is specified, delegates to
1799           update-webkit-chromium.
1800         * Scripts/webkitdirs.pm: Added chromium specific defs.
1801         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1802           chromium port's dependencies and update its project files.
1803
1804 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1805
1806         Unreviewed.
1807
1808         Add myself to list of committers.
1809
1810         * Scripts/modules/committers.py:
1811
1812 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1813
1814         Reviewed by Darin Adler.
1815
1816         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1817         https://bugs.webkit.org/show_bug.cgi?id=29771
1818
1819         * Scripts/run-webkit-tests:
1820
1821 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1822
1823         Reviewed by Simon Hausmann.
1824
1825         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1826         https://bugs.webkit.org/show_bug.cgi?id=25037
1827
1828         * DumpRenderTree/qt/DumpRenderTree.cpp:
1829         (WebCore::WebPage::acceptNavigationRequest):
1830         * DumpRenderTree/qt/DumpRenderTree.pro:
1831         * DumpRenderTree/qt/jsobjects.cpp:
1832         (LayoutTestController::reset):
1833         (LayoutTestController::notifyDone):
1834         (LayoutTestController::waitForPolicyDelegate):
1835         * DumpRenderTree/qt/jsobjects.h:
1836         (LayoutTestController::waitForPolicy):
1837
1838 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1839
1840         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1841
1842         Reviewed by Eric Seidel.
1843
1844         The -o|--open switch uses the open(1) command on Mac OS X to
1845         open the bug URL in the default web browser.  If there are
1846         similar mechanisms on other platforms, they may be added later.
1847
1848         * Scripts/mark-bug-fixed:
1849         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1850         options.
1851         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1852         code into main() and extracted prompting code into
1853         _prompt_user_for_correctness().
1854         (MarkBugFixed._open_bug_in_web_browser): Added.
1855         (MarkBugFixed._prompt_user_for_correctness): Added.
1856         (MarkBugFixed.main): Added logging code from
1857         _determine_bug_id_and_svn_revision().  Added code to call
1858         _open_bug_in_web_browser() if the switch is set.  Added code to
1859         call _prompt_user_for_correctness() when needed.
1860         * Scripts/modules/bugzilla.py:
1861         (Bugzilla.short_bug_url_for_bug_id): Added.
1862
1863 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1864
1865         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1866
1867         <http://webkit.org/b/29744>
1868         <rdar://problem/7252905>
1869
1870         Reviewed by Eric Seidel.
1871
1872         Some users have a workflow where svn-create-patch, svn-apply and
1873         svn-unapply are used outside of multiple svn working
1874         directories.  Instead of aborting the scripts in these cases,
1875         print a warning and assume that Subversion is being used.
1876
1877         * Scripts/VCSUtils.pm:
1878         (determineVCSRoot): Call warn() instead of die() if both isGit()
1879         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1880         to enforce the assumption about Subversion, then return
1881         determineSVNRoot().
1882         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1883         VCSUtils.pm.  They both already cache their values and checking
1884         here is redundant since determineVCSRoot() is called later.
1885
1886 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1887
1888         Reviewed by Gustavo Noronha.
1889
1890         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1891         https://bugs.webkit.org/show_bug.cgi?id=29689
1892
1893         Load test fonts through FontConfig before each test.
1894         This ensures a more proper rendering of the tests.
1895
1896         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1897         (initializeFonts):
1898         (runTest):
1899         (main):
1900         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1901         * GNUmakefile.am:
1902
1903 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1904
1905         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1906
1907         Reviewed by Eric Seidel.
1908
1909         * Scripts/mark-bug-fixed:
1910         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1911         of parse options.
1912         (MarkBugFixed.main): When -u|--update-only is specified, add a
1913         comment to the bug without marking it Resolved/Fixed.
1914
1915 2009-09-25  Darin Adler  <darin@apple.com>
1916
1917         Reviewed by Geoffrey Garen.
1918
1919         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1920         out, just as we do for the resources directory.
1921
1922 2009-09-25  Adam Barth  <abarth@webkit.org>
1923
1924         Unreviewed.  Added Tony to committers.py because he's a
1925         committer now.
1926
1927         * Scripts/modules/committers.py:
1928
1929 2009-09-25  Eric Seidel  <eric@webkit.org>
1930
1931         Reviewed by Simon Fraser.
1932
1933         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1934         https://bugs.webkit.org/show_bug.cgi?id=28624
1935
1936         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1937
1938         * DumpRenderTree/mac/DumpRenderTree.mm:
1939         (resetDefaultsToConsistentValues):
1940
1941 2009-09-25  Eric Seidel  <eric@webkit.org>
1942
1943         Reviewed by Adam Barth.
1944
1945         commit-queue should auto-retry patches which fail to commit due to out of date files
1946         https://bugs.webkit.org/show_bug.cgi?id=28316
1947
1948         * Scripts/bugzilla-tool:
1949          - Handle new CheckoutNeedsUpdate exception.
1950         * Scripts/modules/logging_unittest.py:
1951          - Call the ScriptError constructor correctly (this test had regressed).
1952         * Scripts/modules/scm.py:
1953          - Added the ability to define custom error handlers for run_command
1954            and added a commit_error_handler which throws CheckoutNeedsUpdate
1955            instead of ScriptError.
1956          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1957         * Scripts/modules/scm_unittest.py:
1958          - Added tests of new error handlers.
1959
1960 2009-09-25  Eric Seidel  <eric@webkit.org>
1961
1962         Reviewed by Adam Barth.
1963
1964         commit-queue should give better feedback when failing a patch
1965         https://bugs.webkit.org/show_bug.cgi?id=29316
1966
1967         * Scripts/bugzilla-tool:
1968          - Update ScriptError uses to the new constructor format.
1969          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1970            so that we can print to both stdout as well as an output buffer for error reporting.
1971          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1972          - Use e.message_with_output() when failing a patch (this is the real fix here).
1973            I also removed use of "This patch will require manual commit." as that's not always true.
1974          - Add missing word "bug" from log message.
1975         * Scripts/modules/scm.py:
1976          - Make ScriptError save a bunch more data so that error messages can be nicer.
1977          - Update ScriptError callers.
1978
1979 2009-09-24  John Gregg  <johnnyg@google.com>
1980
1981         Reviewed by Eric Seidel.
1982
1983         Enable switch for notifications (experimental) in Page Settings
1984         https://bugs.webkit.org/show_bug.cgi?id=28930
1985
1986         Now that desktop notifications are controlled by run-time switch,
1987         set that switch to true for DumpRenderTree.
1988
1989         * DumpRenderTree/mac/DumpRenderTree.mm:
1990         (resetDefaultsToConsistentValues):
1991         * DumpRenderTree/win/DumpRenderTree.cpp:
1992         (resetDefaultsToConsistentValues):
1993         * DumpRenderTree/win/UIDelegate.cpp:
1994         (UIDelegate::QueryInterface):
1995
1996 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1997
1998         wx build fix. SnowLeopard fixes for Mac dependencies.
1999
2000         * wx/build/build_utils.py:
2001         * wx/build/settings.py:
2002         * wx/install-unix-extras:
2003
2004 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2005
2006         Reviewed by Oliver Hunt.
2007
2008         Add support for DRT to send mouse wheel events.
2009
2010         https://bugs.webkit.org/show_bug.cgi?id=29348
2011         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2012
2013         * DumpRenderTree/gtk/EventSender.cpp:
2014         (mouseWheelToCallback):
2015
2016 2009-09-17  Eric Seidel  <eric@webkit.org>
2017
2018         Reviewed by David Levin.
2019
2020         commit-queue needs web-based status reporting
2021         https://bugs.webkit.org/show_bug.cgi?id=29307
2022
2023         Add a first-pass web-based status for the commit-queue.
2024         The bot is currently reachable at:
2025         http://webkit-commit-queue.appspot.com/
2026
2027         * CommitQueueStatus/app.yaml: Added.
2028          - Application description file required by App Engine.
2029         * CommitQueueStatus/filters/__init__.py: Added.
2030          - Required by python to treat 'filters' as a module.
2031         * CommitQueueStatus/filters/webkit_extras.py: Added.
2032          - Support for turning 'bug 123' and 'patch 123' into links.
2033            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2034         * CommitQueueStatus/index.html: Added.
2035         * CommitQueueStatus/index.yaml: Added.
2036          - Some auto-generated file from app engine.
2037         * CommitQueueStatus/queue_status.py: Added.
2038          - The core logic of this bot.  We could eventually split this file out into pieces.
2039         * CommitQueueStatus/stylesheets/main.css: Added.
2040          - Some basic lame-o CSS to make the page look less awful.
2041         * CommitQueueStatus/update_status.html: Added.
2042          - The form that the commit-queue (or a human) can use to update the status.
2043         * Scripts/bugzilla-tool:
2044          - Add some very basic update_status calls.
2045         * Scripts/modules/statusbot.py: Added.
2046          - Knows how to post to the CommitQueueStatus web application.
2047
2048 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2049
2050         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2051
2052         Reviewed by Adam Roben.
2053
2054         * Scripts/mark-bug-fixed:
2055         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2056         parse options.
2057         (MarkBugFixed.main): When specified, prepend comment from
2058         -m|--comment command-line switch to the bug comment.
2059
2060 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2061
2062         Reviewed by Jan Alonzo.
2063
2064         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2065         https://bugs.webkit.org/show_bug.cgi?id=29693
2066
2067         Show the window, to be able to synthesize events correctly.
2068
2069         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2070         (runTest):
2071         (main):
2072
2073 2009-09-24  Oliver Hunt  <oliver@apple.com>
2074
2075         Reviewed by NOBODY(rollout)
2076
2077         Roll out r48712 as it is incorrect.
2078
2079         * DumpRenderTree/mac/ObjCController.m:
2080         (+[ObjCController isSelectorExcludedFromWebScript:]):
2081         (+[ObjCController webScriptNameForSelector:]):
2082
2083 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2084
2085         Reviewed by Eric Seidel.
2086
2087         https://bugs.webkit.org/show_bug.cgi?id=29005
2088         The indices of RuntimeArray should be enumerated like for a regular array.
2089
2090         * DumpRenderTree/mac/ObjCController.m:
2091         (+[ObjCController isSelectorExcludedFromWebScript:]):
2092         (+[ObjCController webScriptNameForSelector:]):
2093         (-[ObjCController arrayOfString]):
2094
2095 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2096
2097         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2098
2099         Reviewed by Darin Adler.
2100
2101         Also fixed a bug where specifying a revision on the command-line
2102         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2103
2104         * Scripts/bugzilla-tool: Updated module import statements.
2105         (parse_bug_id): Removed.  Moved to bugzilla.py.
2106         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2107         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2108         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2109         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2110         * Scripts/mark-bug-fixed: Added.
2111         * Scripts/modules/bugzilla.py:
2112         (parse_bug_id): Added.  Moved from bugzilla-tool.
2113         * Scripts/modules/comments.py: Added.
2114         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2115         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2116
2117 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2118
2119         Reviewed by Eric Seidel.
2120         
2121          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2122          "false" in non-implemented stub for setAlwaysAcceptCookies.
2123          https://bugs.webkit.org/show_bug.cgi?id=29661
2124
2125         * DumpRenderTree/win/DumpRenderTree.vcproj:
2126         * DumpRenderTree/win/DumpRenderTree.cpp:
2127
2128 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2129
2130         Reviewed by Xan Lopez.
2131
2132         [GTK] need to dump number of pending unload handlers
2133         https://bugs.webkit.org/show_bug.cgi?id=29685
2134
2135         Implement dumping of the number of pending unload handlers.
2136
2137         The following tests will pass:
2138
2139           fast/loader/unload-form-about-blank.html
2140           fast/loader/unload-form-post-about-blank.html
2141           fast/loader/unload-form-post.html
2142           fast/loader/unload-form.html
2143           fast/loader/unload-hyperlink.html
2144           fast/loader/unload-javascript-url.html
2145           fast/loader/unload-reload.html
2146           fast/loader/unload-window-location.html
2147
2148         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2149         (getFrameNameSuitableForTestResult):
2150         (webViewLoadFinished):
2151
2152 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
2153
2154         Reviewed by Eric Seidel.
2155
2156         js tests should move into jstests subdirectory instead of resources/
2157         https://bugs.webkit.org/show_bug.cgi?id=25880
2158
2159         Remove support of resources directory.
2160
2161         * Scripts/make-script-test-wrappers:
2162
2163 2009-09-22  Eric Seidel  <eric@webkit.org>
2164
2165         No review, only fixing typo (missing space character).
2166
2167         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
2168
2169         * Scripts/run-webkit-tests:
2170
2171 2009-09-22  Eric Seidel  <eric@webkit.org>
2172
2173         Reviewed by Darin Adler.
2174
2175         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
2176         https://bugs.webkit.org/show_bug.cgi?id=29220
2177
2178         * Scripts/run-webkit-tests:
2179
2180 2009-09-22  Eric Seidel  <eric@webkit.org>
2181
2182         Reviewed by David Kilzer.
2183
2184         svn-apply can't handle single-line binary file additions
2185         https://bugs.webkit.org/show_bug.cgi?id=29100
2186
2187         Fixed the regexp and added a unit test.
2188
2189         * Scripts/modules/scm_unittest.py:
2190         * Scripts/svn-apply:
2191
2192 2009-09-11  Eric Seidel  <eric@webkit.org>
2193
2194         Reviewed by David Kilzer.
2195
2196         post-diff and post-commits should be able to find bug urls in ChangeLogs.
2197         https://bugs.webkit.org/show_bug.cgi?id=29206
2198
2199         * Scripts/bugzilla-tool:
2200          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
2201          - Rename --no-comment to --add-log-as-comment and reverse behavior.
2202            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
2203          - Split out code into helper functions to try and make execute() more legible.
2204          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
2205          - Fallback to bug urls in commit diffs, instead of just in commit messages,
2206            meaning post-commits will now find bug urls in ChangeLogs.
2207
2208 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2209
2210         Reviewed by Maciej Stachowiak.
2211
2212         --parse-only parameter wasn't passed to SunSpider/sunspider script.
2213         https://bugs.webkit.org/show_bug.cgi?id=29611
2214
2215         * Scripts/run-sunspider: Missing parameter passing added.
2216
2217 2009-09-20  David Kilzer  <ddkilzer@apple.com>
2218
2219         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
2220
2221         Reviewed by Mark Rowe.
2222
2223         The require statement is like the use statement, except that it
2224         is run during script execution instead of during the 'BEGIN'
2225         phase.  This makes it possible to change @INC before the require
2226         statement is run.  See 'require' and 'use' in the perlfunc(1)
2227         manpage and 'BEGIN' in perlmod(1) manpage.
2228
2229         * Scripts/run-webkit-tests: Replace eval statement with require
2230         statement.
2231
2232 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
2233
2234         wx build fixes. Fix the config name under git and allow users to specify
2235         their own waf install for experimenting with new versions.
2236
2237         * Scripts/webkitdirs.pm:
2238         * wx/build/settings.py:
2239
2240 2009-09-18  Alex Milowski  <alex@milowski.com>
2241
2242         Reviewed by Maciej Stachowiak.
2243
2244         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
2245         checking for whether MathML tests should be run
2246
2247         * Scripts/run-webkit-tests:
2248         * Scripts/webkitdirs.pm:
2249
2250 2009-08-28  Darin Adler  <darin@apple.com>
2251
2252         Reviewed by Mark Rowe.
2253
2254         Break more of run-webkit-tests into separate functions
2255         https://bugs.webkit.org/show_bug.cgi?id=29497
2256
2257         Some small steps toward improving run-webkit-tests. My goal is to
2258         refactor much more of the script into functions. Later we can add
2259         parallel test running to the tool. But better structure may help
2260         even if someone decides to translate this into another scripting
2261         language instead.
2262
2263         * Scripts/run-webkit-tests: Break more pieces of the script into
2264         seprate functions. Added readSkippedFiles, findTestsToRun, and
2265         printResults functions. Removed custom code to skip results.html
2266         and instead just put it into the ignoredFiles hash. Fixed some
2267         indentation. Sorted function declarations, global variables,
2268         and options at the top of the file alphabetically so they're not
2269         in a semi-random order.
2270
2271 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
2272
2273         wx build fix, add missing dependency.
2274
2275         * wx/browser/wscript:
2276
2277 2009-09-16  Mark Rowe  <mrowe@apple.com>
2278
2279         Split the SnowLeopard build across a few machines.
2280
2281         * BuildSlaveSupport/build.webkit.org-config/config.json:
2282
2283 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2284
2285         wx build fix to support monolithic builds on Windows.
2286
2287         * wx/build/wxpresets.py:
2288
2289 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2290
2291         wx build fix, improve debug support and 2.9 support on MSW.
2292
2293         * wx/build/settings.py:
2294         * wx/build/wxpresets.py:
2295
2296 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2297
2298         Blind try at fixing new test failure on Windows.
2299
2300         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2301         (FrameLoadDelegate::didReceiveTitle):
2302
2303 2009-09-15  Alex Milowski  <alex@milowski.com>
2304
2305         Reviewed by Tor Arne Vestbø.
2306
2307         Added mathml toggle
2308
2309         * Scripts/build-webkit:
2310
2311 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
2312
2313         wx build fix. Allow waf build to support Python < 2.6.
2314
2315         * wx/build/waf_extensions.py:
2316
2317 2009-09-14  Chris Marrin  <cmarrin@apple.com>
2318
2319         Reviewed by Oliver Hunt.
2320
2321         Add LayoutTests infrastructure to enable and disable webgl tests.
2322         https://bugs.webkit.org/show_bug.cgi?id=29254
2323
2324         * Scripts/run-webkit-tests:
2325         * Scripts/webkitdirs.pm:
2326
2327 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
2328
2329         Reviewed by Darin Adler.
2330         
2331         Add --iterations option to run-webkit-tests to repeat the tests N times
2332         https://bugs.webkit.org/show_bug.cgi?id=29263
2333
2334         When run with --iterations N, run-webkit-tests will repeat the tests N times.
2335
2336         * Scripts/run-webkit-tests:
2337
2338 2009-09-14  Brady Eidson  <beidson@apple.com>
2339
2340         Not reviewed, maybe should've been:
2341
2342         Cleaning up more Windows-specific fallout from the fix for:
2343         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2344
2345         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2346         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
2347           and call the correct method to get the Sender.
2348
2349 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
2350
2351         GTK build fix.
2352
2353         Unreviewed.
2354
2355         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2356         (AccessibilityController::setLogScrollingStartEvents):
2357
2358 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
2359
2360         DRT/test part of
2361         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
2362         jumping to a named anchor
2363
2364         https://bugs.webkit.org/show_bug.cgi?id=28899
2365
2366         Reviewed by Adam Roben.
2367
2368         * DumpRenderTree/AccessibilityController.cpp:
2369         (logScrollingStartEventsCallback):
2370         Turn on logging of scrolling start events.
2371         (AccessibilityController::getJSClass):
2372         Add a "logScrollingStartEvents" to the AccessibilityController's JS
2373         class definition.
2374         (AccessibilityController::resetToConsistentState):
2375         Turn off logging of scrolling start events.
2376
2377         * DumpRenderTree/AccessibilityController.h:
2378         Declare setLogScrollingStartEvents(). Add a member for the scrolling
2379         start event hook.
2380
2381         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
2382         (AccessibilityController::setLogScrollingStartEvents):
2383         Stubbed.
2384
2385         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2386         (AccessibilityController::AccessibilityController):
2387         Initialize the handle to 0.
2388         (logEventProc):
2389         Renamed from logFocusEventProc; now logs scrolling start events, too.
2390         Removed the assertion that the event is a focus event. Added a switch
2391         to print a message for focus, scrolling start, and other, unknown
2392         events.
2393         (AccessibilityController::setLogFocusEvents):
2394         Changed to use logEventProc.
2395         (AccessibilityController::setLogScrollingStartEvents):
2396         If turning logging off, unhook the scrolling start event hook, and clear
2397         the member holding the handle. If turning on, query for the root
2398         accessible, so that accessibility is enabled for the WebView, and call
2399         SetWinEventHook to setup an event hook using logEventProc as the
2400         callback function.
2401
2402 2009-09-14  Brady Eidson  <beidson@apple.com>
2403
2404         Windows build fix.
2405
2406         * DumpRenderTree/LayoutTestController.cpp:
2407         (setAuthenticationPasswordCallback):
2408         (setAuthenticationUsernameCallback):
2409         
2410         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2411         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2412
2413 2009-09-14  Brady Eidson  <beidson@apple.com>
2414
2415         Reviewed by Alexey Proskuryakov.
2416
2417         Safari 4 cannot be used to update firmware on Linksys routers.
2418         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2419
2420         Add the ability for DRT to handle authentication challenges.
2421
2422         * DumpRenderTree/LayoutTestController.cpp:
2423         (setAuthenticationPasswordCallback):
2424         (setAuthenticationUsernameCallback):
2425         (setHandlesAuthenticationChallengesCallback):
2426         (LayoutTestController::staticFunctions):
2427
2428         * DumpRenderTree/LayoutTestController.h:
2429         (LayoutTestController::handlesAuthenticationChallenges):
2430         (LayoutTestController::setHandlesAuthenticationChallenges):
2431         (LayoutTestController::authenticationUsername):
2432         (LayoutTestController::setAuthenticationUsername):
2433         (LayoutTestController::authenticationPassword):
2434         (LayoutTestController::setAuthenticationPassword):
2435
2436         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2437         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2438
2439         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2440         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2441         * DumpRenderTree/win/ResourceLoadDelegate.h:
2442
2443 2009-09-12  Mark Rowe  <mrowe@apple.com>
2444
2445         Reviewed by Dan Bernstein.
2446
2447         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
2448
2449         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
2450         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
2451
2452         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2453         (NPP_New):
2454
2455 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2456
2457         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
2458
2459         * wx/build/build_utils.py:
2460         * wx/build/settings.py:
2461
2462 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2463
2464         Reviewed by Tor Arne Vestbø.
2465
2466         [Qt] Build fix for windows build.
2467
2468         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
2469
2470 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2471
2472         Fix typo accidently landed in last commit.
2473
2474         * wx/build/settings.py:
2475
2476 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2477
2478         wx build fix, error out if using the wrong Python.
2479
2480         * wx/build/settings.py:
2481
2482 2009-09-13  Xan Lopez  <xlopez@igalia.com>
2483
2484         Build fix for GTK+ < 2.14.
2485
2486         Do not use gtk_widget_get_window, access the window directly
2487         through the struct.
2488
2489         * DumpRenderTree/gtk/EventSender.cpp:
2490         (contextClickCallback):
2491         (mouseDownCallback):
2492         (mouseUpCallback):
2493         (mouseMoveToCallback):
2494         (keyDownCallback):
2495
2496 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
2497
2498         Reviewed by Xan Lopez and Jan Alonzo.
2499
2500         [GTK] EventSender does not set 'window' property on synthesized GDK events
2501         https://bugs.webkit.org/show_bug.cgi?id=29169
2502
2503         Set the window property on synthesized GDK events in the GTK+ EventSender.
2504
2505         * DumpRenderTree/gtk/EventSender.cpp:
2506         (contextClickCallback):
2507         (mouseDownCallback):
2508         (mouseUpCallback):
2509         (mouseMoveToCallback):
2510         (keyDownCallback):
2511
2512 2009-09-12  Drew Wilson  <atwilson@google.com>
2513
2514         Reviewed by Mark Rowe.
2515
2516         run-webkit-tests has a timeout value that is too low
2517         https://bugs.webkit.org/show_bug.cgi?id=29223
2518
2519         * Scripts/run-webkit-tests:
2520         Changed timeout value to 20 seconds to avoid timing out too early.
2521
2522 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
2523
2524         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
2525         architectures are supported for building wxWebKit.
2526
2527         * wx/build/settings.py:
2528
2529 2009-09-11  Eric Seidel  <eric@webkit.org>
2530
2531         Reviewed by David Levin.
2532
2533         bugzilla-tool rollout threw exception under svn
2534         https://bugs.webkit.org/show_bug.cgi?id=29211
2535
2536         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
2537         * Scripts/modules/scm_unittest.py: add testing for this fix.
2538
2539 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
2540
2541         Add myself to the committers list.
2542
2543         * Scripts/modules/committers.py:
2544
2545 2009-09-11  Eric Seidel  <eric@webkit.org>
2546
2547         Reviewed by Adam Barth.
2548
2549         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
2550         https://bugs.webkit.org/show_bug.cgi?id=29201
2551
2552         * Scripts/bugzilla-tool:
2553
2554 2009-09-11  Adam Roben  <aroben@apple.com>
2555
2556         Make commit-log-editor move common prefixes to the top of the log
2557
2558         Fies <http://webkit.org/b/29190> commit-log-editor should move common
2559         prefixes to the top of the commit log
2560
2561         Reviewed by Darin Adler.
2562
2563         * Scripts/commit-log-editor: Find and remove the longest common prefix
2564         ending in a double newline from each ChangeLog entry, then put that
2565         common prefix at the top of the commit log.
2566         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
2567         removes, and returns the longest common prefix ending in a double
2568         newline from a hash of strings
2569
2570 2009-09-11  Eric Seidel  <eric@webkit.org>
2571
2572         Fix obvious typo in previous commit, no review.
2573
2574         bugzilla-tool should automate rollouts
2575         https://bugs.webkit.org/show_bug.cgi?id=26715
2576
2577         * Scripts/bugzilla-tool: add back missing "scm" argument.
2578
2579 2009-09-11  Eric Seidel  <eric@webkit.org>
2580
2581         Reviewed by Adam Barth.
2582
2583         bugzilla-tool should automate rollouts
2584         https://bugs.webkit.org/show_bug.cgi?id=26715
2585
2586         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
2587         The --complete-rollout option will automatically land and update the bug.
2588         Eventually --complete-rollout will be default, but that will require more testing.
2589
2590         This first pass is good enough for others to try and file bugs about.
2591
2592         * Scripts/bugzilla-tool:
2593          - Move modified_changelogs into scm.py.
2594          - Move svn_revision_from_commit_text logic into scm.py.
2595          - Add RolloutCommit command.
2596         * Scripts/modules/bugzilla.py:
2597          - Add reopen_bug command used by RolloutCommit.
2598         * Scripts/modules/scm.py:
2599          - Add functions to support RolloutCommit.
2600          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
2601          - Add a str() call so that svn_commit_log can take a numeric argument.
2602          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
2603          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
2604         * Scripts/modules/scm_unittest.py:
2605          - Add read_from_path for easy file reading.
2606          - Put test4 on a new line to make reverts work w/o conflict.
2607          - Add an "svn update" call so that the checkout revision matches the server revision.
2608          - Add tests for svn_revision_from_commit_text.
2609          - Add a simple test for apply_reverse_diff.
2610          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
2611          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
2612
2613 2009-09-11  Adam Roben  <aroben@apple.com>
2614
2615         Get user script/stylesheet tests running on Windows
2616
2617         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
2618         skipped on Windows
2619
2620         Reviewed by John Sullivan.
2621
2622         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
2623         against comsuppw.lib so we can use _bstr_t.
2624
2625         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
2626         order, added #include of comutil.h for _bstr_t.
2627
2628         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
2629         (LayoutTestController::addUserScript):
2630         (LayoutTestController::addUserStyleSheet):
2631         Implemented. Implementations were based on those in
2632         LayoutTestControllerMac.mm.
2633
2634 2009-09-10  David Kilzer  <ddkilzer@apple.com>
2635
2636         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
2637
2638         Reviewed by Mark Rowe.
2639
2640         * Scripts/run-webkit-tests: Updated to make -h switch show help.
2641
2642 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
2643
2644         Reviewed by Alexey Proskuryakov.
2645
2646         Add WebCore/websockets directory in wx build system.
2647         https://bugs.webkit.org/show_bug.cgi?id=28038
2648
2649         * wx/build/settings.py:
2650
2651 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2652
2653         [GTK] EventSender does not properly convert some keyDown strings
2654         https://bugs.webkit.org/show_bug.cgi?id=29119
2655
2656         Add more keyDown string to character code conversions for GTK+ EventSender.
2657
2658         * DumpRenderTree/gtk/EventSender.cpp:
2659         (keyDownCallback):
2660
2661 2009-09-09  Steve Block  <steveblock@google.com>
2662
2663         Reviewed by Maciej Stachowiak.
2664
2665         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2666         https://bugs.webkit.org/show_bug.cgi?id=29080
2667
2668         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2669
2670 2009-09-09  Eric Seidel  <eric@webkit.org>
2671
2672         Reviewed by Eric Carlson.
2673
2674         reviewer/committer lookups are backwards
2675         https://bugs.webkit.org/show_bug.cgi?id=29113
2676
2677         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2678
2679         * Scripts/modules/bugzilla.py:
2680         * Scripts/modules/committers.py:
2681
2682 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2683
2684         Reviewed by Eric Seidel.
2685
2686         svn-unapply doesn't revert directories correctly
2687         https://bugs.webkit.org/show_bug.cgi?id=29065
2688
2689         * Scripts/svn-unapply: Make svnStatus consistently return status
2690         lines including a newline.
2691         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2692         svn-unapply, in lieu of moving it to a common file.
2693
2694 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2695
2696         Reviewed by Eric Seidel.
2697
2698         svn-apply doesn't handle changes to files copied to new directories properly
2699         https://bugs.webkit.org/show_bug.cgi?id=29059
2700
2701         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2702         additions if we know that we've just copied a file to this name.
2703
2704 2009-09-09  Eric Seidel  <eric@webkit.org>
2705
2706         Reviewed by David Levin.
2707
2708         commit-queue hangs if a builder has never built
2709         https://bugs.webkit.org/show_bug.cgi?id=29091
2710
2711         * Scripts/modules/buildbot.py:
2712         * Scripts/modules/buildbot_unittest.py:
2713
2714 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2715
2716         Reviewed by Gustavo Noronha.
2717
2718         [GTK] DumpRenderTree needs eventSender object and implementation
2719         https://bugs.webkit.org/show_bug.cgi?id=25990
2720
2721         Implements most of the EventSender object's functionality for
2722         the DumpRenderTree tool. Implementation still lacks support
2723         for drag and drop tests and forward leaps.
2724
2725         Based on work by Holger Hans Peter Freyther.
2726
2727         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2728         (runTest): Focus on the view before loading a new test.
2729         (webViewWindowObjectCleared):
2730         * DumpRenderTree/gtk/EventSender.cpp: Added.
2731         (getDragModeCallback):
2732         (setDragModeCallback):
2733         (leapForwardCallback):
2734         (contextClickCallback):
2735         (updateClickCount):
2736         (mouseDownCallback):
2737         (mouseUpCallback):
2738         (mouseMoveToCallback):
2739         (beginDragWithFilesCallback):
2740         (replaySavedEvents):
2741         (keyDownCallback):
2742         (textZoomInCallback):
2743         (textZoomOutCallback):
2744         (zoomPageInCallback):
2745         (zoomPageOutCallback):
2746         (getClass):
2747         (makeEventSender):
2748         * DumpRenderTree/gtk/EventSender.h: Added.
2749         * GNUmakefile.am: Add build rules for EventSender.
2750
2751 2009-09-09  Daniel Bates  <dbates@webkit.org>
2752
2753         Reviewed by Adam Roben.
2754         
2755         https://bugs.webkit.org/show_bug.cgi?id=28953
2756
2757         Added pre- and post- build events so that on build failure, the file 
2758         buildfailed is written to the directory $(WebKitOutputDir).
2759
2760         * WinLauncher/WinLauncher.vcproj:
2761
2762 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2763
2764         Unreviewed.
2765
2766         Add myself to list of committers.
2767
2768         * Scripts/modules/committers.py:
2769
2770 2009-09-08  Eric Seidel  <eric@webkit.org>
2771
2772         Reviewed by David Levin.
2773
2774         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2775         https://bugs.webkit.org/show_bug.cgi?id=28605
2776         https://bugs.webkit.org/show_bug.cgi?id=28916
2777
2778         * Scripts/bugzilla-tool:
2779          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2780            comment now that it's used for rejecting patches for invalid committers too.
2781          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2782          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2783         * Scripts/modules/bugzilla.py:
2784          - Make _parse_attachment_element not validate reviewer/committer.
2785          - Share flag parsing code in _parse_attachment_flag.
2786          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2787          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2788          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2789         * Scripts/modules/bugzilla_unittest.py:
2790          - Update this test to no longer expect committer/reviewer validation.
2791         * Scripts/modules/committers.py:
2792          - Return None on failed lookups instead of raising Exceptions.
2793         * Scripts/modules/committers_unittest.py:
2794          - Update tests to expect None returns instead of exceptions.
2795
2796 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2797
2798         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2799
2800         Reviewed by Mark Rowe.
2801
2802         No change to layout test results.
2803
2804         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2805         (AccessibilityUIElement::clickPointY): Changed to return y value
2806         instead of x value.
2807
2808 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2809
2810         Reviewed by Mark Rowe.
2811
2812         Reduce dglazkov's boboiness by properly concatenating revision value.
2813
2814         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2815             rather than "+".
2816
2817 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2818
2819         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2820
2821         * wx/build/build_utils.py:
2822
2823 2009-09-08  Mark Rowe  <mrowe@apple.com>
2824
2825         Fix an incorrect variable name in UpdateChromiumSource.
2826
2827         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2828
2829 2009-09-08  Mark Rowe  <mrowe@apple.com>
2830
2831         Don't check for leaks on the release SnowLeopard builder.
2832
2833         * BuildSlaveSupport/build.webkit.org-config/config.json:
2834
2835 2009-09-08  Mark Rowe  <mrowe@apple.com>
2836
2837         Add a SnowLeopard release builder.
2838
2839         * BuildSlaveSupport/build.webkit.org-config/config.json:
2840
2841 2009-09-08  David Levin  <levin@chromium.org>
2842
2843         Reviewed by Darin Adler.
2844
2845         Remove end of line whitespace check from check-webkit-style.
2846         https://bugs.webkit.org/show_bug.cgi?id=29053
2847
2848         * Scripts/modules/cpp_style.py:
2849
2850 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2851
2852         Reviewed by Darin Adler.
2853
2854         Fix DumpRenderTree build from clean tree on Tiger
2855         https://bugs.webkit.org/show_bug.cgi?id=28927
2856
2857         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2858         DerivedSources/DumpRenderTree directory exists when
2859         building on Tiger.
2860
2861 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2862
2863         wx build fix after introduction of platform/mock directory.
2864
2865         * wx/build/settings.py:
2866
2867 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2868
2869         Unreviewed.
2870
2871         Add myself to list of committers.
2872
2873         * Scripts/modules/committers.py:
2874
2875 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2876
2877         Unreviewed.
2878
2879         Add myself to list of committers.
2880
2881         * Scripts/modules/committers.py:
2882
2883 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2884
2885         Reviewed by Darin Adler.
2886
2887         prepare-ChangeLog too chatty on file additions
2888         https://bugs.webkit.org/show_bug.cgi?id=29019
2889
2890         * Scripts/prepare-ChangeLog: Omit description of added properties
2891         on newly added files.
2892
2893 2009-09-08  Steve Block  <steveblock@google.com>
2894
2895         Reviewed by Adam Barth.
2896
2897         Adds a LayoutTestController method to set the permission state for Geolocation.
2898         This is required to use the mock Geolocation service for testing.
2899         https://bugs.webkit.org/show_bug.cgi?id=29027
2900
2901         * DumpRenderTree/LayoutTestController.cpp: Modified.
2902         (setDatabaseQuotaCallback): Modified. Style fix.
2903         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2904         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2905         * DumpRenderTree/LayoutTestController.h: Modified.
2906         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2907         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2908         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2909         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2910         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2911
2912 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2913
2914         Reviewed by Simon Hausmann.
2915
2916         [Qt] QtWebKit single API to enable persistency
2917         https://bugs.webkit.org/show_bug.cgi?id=28682
2918
2919         Use the new enablePersistentStorage API instead 
2920         of enabling all persistent features one-by-one.
2921
2922         * DumpRenderTree/qt/DumpRenderTree.cpp:
2923         (WebCore::WebPage::WebPage):
2924         (WebCore::DumpRenderTree::DumpRenderTree):
2925
2926 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2927
2928         Reviewed by Tor Arne Vestbø.
2929
2930         Refactor --strict switch to --ignore-metrics and correct the
2931         implementation to make the feature usable on all platforms.
2932         https://bugs.webkit.org/show_bug.cgi?id=28907
2933
2934         run-webkit-tests --ignore-metrics strips the font related metrics from
2935         the actual and expected data before comparing them.
2936         In this way the render trees can be checked for obvious differences but
2937         a successful test implies by no means that the layout is actually correct.
2938
2939         * Scripts/run-webkit-tests:
2940
2941 2009-09-07  Steve Block  <steveblock@google.com>
2942
2943         Reviewed by Adam Barth.
2944
2945         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2946         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2947         Geolocation service with DumpRenderTree.
2948         https://bugs.webkit.org/show_bug.cgi?id=28264
2949
2950         * DumpRenderTree/LayoutTestController.cpp: Modified.
2951         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2952         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2953         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2954         * DumpRenderTree/LayoutTestController.h: Modified.
2955         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2956         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2957         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2958
2959 2009-09-07  Drew Wilson  <atwilson@google.com>
2960
2961         Reviewed by David Levin.
2962
2963         Enable SHARED_WORKERS by default
2964         https://bugs.webkit.org/show_bug.cgi?id=28959
2965
2966         * Scripts/build-webkit:
2967
2968 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2969
2970         wx build fixes for wx SVN trunk.
2971
2972         * wx/build/settings.py:
2973
2974 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2975
2976         wx build fix. Switch USE_ defines over to the compiler so that they can be
2977         checked by files not including config.h (like WebCorePrefix.h).
2978
2979         * wx/build/settings.py:
2980
2981 2009-09-04  Adam Barth  <abarth@webkit.org>
2982
2983         Unreviewed build fix.
2984
2985         Update declaration of FrameLoadDelegate to reflect that
2986         IWebFrameLoadDelegatePrivate2 inherits from
2987         IWebFrameLoadDelegatePrivate.
2988
2989         * DumpRenderTree/win/FrameLoadDelegate.h:
2990
2991 2009-09-04  Adam Barth  <abarth@webkit.org>
2992
2993         Reviewed by Eric Seidel.
2994
2995         https://bugs.webkit.org/show_bug.cgi?id=24696
2996
2997         Add testing instrumentation for mixed content.
2998
2999         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3000         (-[FrameLoadDelegate webView:]):
3001         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
3002         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3003         (descriptionSuitableForTestResult):
3004         (FrameLoadDelegate::QueryInterface):
3005         (FrameLoadDelegate::didDisplayInsecureContent):
3006         (FrameLoadDelegate::didRunInsecureContent):
3007         * DumpRenderTree/win/FrameLoadDelegate.h:
3008
3009 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
3010
3011         Reviewed by Kevin Ollivier.
3012
3013         [wx] Frames support
3014         https://bugs.webkit.org/show_bug.cgi?id=19041
3015
3016         * wx/build-wxwebkit:
3017
3018 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3019
3020         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3021
3022         Reviewed by Eric Seidel.
3023
3024         This fixes "svn-apply --force" and adds unit tests for the
3025         scm.apply_patch() method which uses this script.
3026
3027         * Scripts/svn-apply: Created $globalExitCode variable that
3028         defaults to 0.  Exit with a value of $globalExitCode when the
3029         script is finished.
3030         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
3031         set $globalExitCode to $exitCode so that svn-apply exits with a
3032         non-zero status if any patches did not apply cleanly.  Also
3033         print out the actual patch command if $force was not true.
3034
3035         * Scripts/modules/scm.py:
3036         (scripts_directory): Added.  Extracted from script_path().
3037         (script_path): Extracted scripts_directory().
3038         * Scripts/modules/scm_unittest.py: Import urllib.
3039         (SVNTestRepository.setup): Save the original working directory
3040         in test_object since this represents the WebKit repository from
3041         where the unit tests are run.
3042         (SCMTest): Created new super class to hold utility methods.
3043         (SCMTest._create_patch): Creates a patch file on disk and a
3044         dictionary for use with scm.svn_apply().
3045         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
3046         back to WebKitTools/Scripts in the test repository so that
3047         scm.apply_patch() is able to find the svn-apply script.
3048         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
3049         (SVNTest.tearDown): Make sure to change directories back to the
3050         original_path before the next test.
3051         (SVNTest.test_apply_svn_patch): New test case for applying an
3052         svn patch with scm.apply_patch().
3053         (SVNTest.test_apply_svn_patch_force): New test case for applying
3054         an svn patch with scm.apply_patch() that conflicts.
3055         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
3056         (GitTest.tearDown): Make sure to change directories back to the
3057         original_path before the next test.
3058         (GitTest.test_apply_git_patch): New test case for applying a git
3059         patch with scm.apply_patch().
3060         (GitTest.test_apply_git_patch_force): New test case for applying
3061         a git patch with scm.apply_patch() that conflicts.
3062
3063 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3064
3065         Reviewed by Mark Rowe.
3066
3067         [Qt] Add support for platform-spesific layout-test results
3068
3069         For the Qt port we use the qt-[mac|linux|win] directories and then fall
3070         back to the generic qt directory for both test results and skipped list.
3071
3072         * Scripts/run-webkit-tests:
3073         * Scripts/webkitdirs.pm:
3074
3075 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
3076
3077         Reviewed by David Kilzer.
3078
3079         <http://webkit.org/b/25517> build-webkit script should print build time at end
3080
3081         * Scripts/build-webkit:
3082         Added startTime and endTime variable so that the build time is computed and printed as
3083         part of the build message; display formatting has been separated in a dedicated subroutine.
3084
3085 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3086
3087         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
3088
3089         Reviewed by Eric Seidel.
3090
3091         * Scripts/VCSUtils.pm:
3092         (determineSvnRoot): Added back check for repository root that
3093         was removed in r46134 when this code lived in svn-create-patch.
3094         It's necessary to check both the repository root and the
3095         repository UUID in case two different working directories are
3096         checked out from the same repository.
3097
3098 2009-09-02  Timothy Hatcher  <timothy@apple.com>
3099
3100         Use new 512x512 icons for nightly builds.
3101
3102         Rubber-stamped by Mark Rowe.
3103
3104         * WebKitLauncher/webkit.icns:
3105
3106 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3107
3108         waf build fix. Remove local variable shadowing global.
3109
3110         * wx/build/settings.py:
3111
3112 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
3113
3114         Reviewed by David Kilzer.
3115
3116         Calls exitStatus function from the main package where it is also defined.
3117
3118         * Scripts/VCSUtils.pm:
3119
3120 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3121
3122         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
3123
3124         * wx/browser/wscript:
3125         * wx/build/build_utils.py:
3126         * wx/build/settings.py:
3127
3128 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
3129
3130         Reviewed by Eric Seidel.
3131
3132         Changes needed for build-webkit to support the waf build system for the wx port.
3133         
3134         https://bugs.webkit.org/show_bug.cgi?id=27619
3135
3136         * Scripts/build-webkit:
3137         * Scripts/run-launcher:
3138         * Scripts/webkitdirs.pm:
3139
3140 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3141
3142         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
3143
3144         Reviewed by Eric Seidel.
3145
3146         * Scripts/update-webkit: Added "--accept postpone" to
3147         @svnOptions when running with svn-1.6 or newer.
3148
3149 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3150
3151         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
3152
3153         Reviewed by Eric Seidel.
3154
3155         * Scripts/VCSUtils.pm:
3156         (@EXPORT): Added &isSVNVersion16OrNewer.
3157         (svnVersion): Added.  Internal method that gets the SVN version
3158         and caches it.
3159         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
3160         version check.
3161         * Scripts/prepare-ChangeLog: Switched to use new
3162         isSVNVersion16OrNewer() method.
3163         * Scripts/resolve-ChangeLogs: Ditto.
3164         * Scripts/svn-create-patch: Ditto.
3165
3166 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3167
3168         Clean up VCSUtils.pm
3169
3170         Reviewed by Eric Seidel.
3171
3172         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
3173         indentation of BEGIN block.  Listed each exported method on a
3174         line by itself.  Added methods to the export list after adding
3175         the package statement.  Sorted module variables.  Moved
3176         definiton of $gitRoot next to other module variables.
3177
3178 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3179
3180         Rubber-stamped by Simon Hausmann.
3181
3182         [Qt] Fix layout-test plugins/plugin-javascript-access.html
3183
3184         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3185
3186 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
3187
3188         Reviewed by Eric Seidel.
3189
3190         js tests should move into jstests subdirectory instead of resources/
3191         https://bugs.webkit.org/show_bug.cgi?id=25880
3192
3193         make-script-wrappers supports both resources and script-tests directories.
3194         run-webkit-tests ignores files in script-tests.
3195         Move script tests of animations to check the new script is working.
3196
3197         * Scripts/make-script-test-wrappers:
3198         * Scripts/run-webkit-tests:
3199
3200 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
3201
3202         Reviewed by David Levin.
3203
3204         check-webkit-style uses python from /usr/bin instead of the PATH
3205         https://bugs.webkit.org/show_bug.cgi?id=28225
3206
3207         * Scripts/bugzilla-tool:
3208         * Scripts/check-webkit-style:
3209         * Scripts/run-webkit-unittests:
3210         * Scripts/update-sources-list.py:
3211           Changed the first line from
3212           #!/usr/bin/python
3213           to
3214           #!/usr/bin/env python
3215           which causes python to be invoked from the path location returned
3216           by "which python" when any of these scripts are launched.
3217           these are currently all the python scripts in WebKitTools/Scripts.
3218
3219 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3220
3221         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
3222
3223         Reviewed by Adam Barth.
3224
3225         * Scripts/modules/scm.py:
3226         (Git.commit_ids_from_commitish_arguments): Reverse the list of
3227         commits returned from git-rev-list since we always want to post
3228         the oldest patches first to bugs.webkit.org.
3229         * Scripts/modules/scm_unittest.py:
3230         (run): Added return statement to return the output now that we
3231         want it sometimes.
3232         (SVNTestRepository._setup_test_commits): Added a fourth commit
3233         so the GitTest.test_commitish_order() test has more commits to
3234         work with.
3235         (GitTest.test_commitish_order): Added unit test for change to
3236         Git.commit_ids_from_commitish_arguments() in scm.py.
3237
3238 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3239
3240         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
3241
3242         Reviewed by David Levin.
3243
3244         The mark-fixed subcommand is for those times when you don't use
3245         bugzilla-tool to commit a patch, but you want to use it to close
3246         the bug with a committed-revision message.
3247
3248         * Scripts/bugzilla-tool:
3249         (bug_comment_from_svn_revision): Added.  Extracted from
3250         bug_comment_from_commit_text().
3251         (bug_comment_from_commit_text): Extracted
3252         bug_comment_from_svn_revision() from this method.
3253         (MarkBugFixed.__init__): Added.
3254         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
3255         log from the last commit if no svn revision is specified, else
3256         the commit log for the specified svn revision.
3257         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
3258         Attempts to determine the bug id and svn revision if one or both
3259         were not defined on the command line.
3260         (MarkBugFixed.execute): Added.  Adds a comment about the
3261         revision that fixed the bug and closes the bug.
3262         (BugzillaTool.__init__): Added mark-fixed subcommand.
3263         * Scripts/modules/bugzilla.py:
3264         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
3265         bug given a bug id.
3266         * Scripts/modules/scm.py:
3267         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
3268         the leading 'r' from an svn revision.
3269         (SCM.svn_commit_log): Added.  Subclasses must override.
3270         (SCM.last_svn_commit_log): Added.  Subclasses must override.
3271         (SVN.svn_commit_log): Added.  Returns svn log for a given
3272         revision.
3273         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
3274         last commit in an svn working directory and then runs svn log.
3275         (Git.svn_commit_log): Added.  Returns svn log for a given
3276         revision.
3277         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
3278         of one log message.
3279
3280 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3281
3282         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3283
3284         Reviewed by Brady Eidson.
3285
3286         * Scripts/svn-apply:
3287         (applyPatch): Add "--force" to $options arrayref if $force is
3288         set.
3289
3290 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3291
3292         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
3293
3294         Reviewed by Adam Roben.
3295
3296         When git-filter-branch has been invoked to rewrite ChangeLog
3297         files on series of git commits, it changes directories into
3298         .git-rewrite/t before re-running resolve-ChangeLogs.  This
3299         causes determineVCSRoot() in VCSUtils.pm to return
3300         ".git-rewrite/t", which causes that path to be prepended to all
3301         ChangeLog paths, which results in an error like this:
3302
3303             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
3304             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
3305
3306         The correct way to fix this is not to try to find the repository
3307         root when invoked by git-filter-branch.
3308
3309         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
3310         set $relativePath to '.' instead of calling
3311         chdirReturningRelativePath(determineVCSRoot()).
3312         (isInGitFilterBranch): Added.  Checks for the existence of the
3313         MAPPED_PREVIOUS_COMMIT environment variable.
3314
3315 2009-09-01  Xan Lopez  <xlopez@igalia.com>
3316
3317         Reviewed by Gustavo Noronha.
3318
3319         Add support for Fedora distros in the http tests
3320         https://bugs.webkit.org/show_bug.cgi?id=28263
3321
3322         Add detection code for Fedora distribution, and use the proper
3323         httpd conf file when needed.
3324
3325         * Scripts/run-webkit-httpd:
3326         * Scripts/run-webkit-tests:
3327         * Scripts/webkitdirs.pm:
3328
3329 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
3330
3331         Reviewed by Eric Seidel.
3332
3333         [Gtk] DRT needs implementation of overridePreference
3334         https://bugs.webkit.org/show_bug.cgi?id=28830
3335
3336         Implement overridePreference.
3337
3338         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3339         (resetDefaultsToConsistentValues):
3340         (setDefaultsToConsistentStateValuesForTesting):
3341         (runTest):
3342         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3343         (toWebSettingKey):
3344         (LayoutTestController::overridePreference):
3345
3346 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
3347
3348         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
3349
3350         Reviewed by Eric Seidel.
3351
3352         Jump back and forth between the repository root directory (to apply) and the
3353         directory the script was run from (to find the patch).
3354
3355         * Scripts/svn-apply:
3356         * Scripts/svn-unapply:
3357
3358 2009-08-31  Adam Roben  <aroben@apple.com>
3359
3360         Fall back to a Release version of Safari if a Debug one doesn't exist
3361
3362         <http://webkit.org/b/28849>
3363
3364         Reviewed by Sam Weinig.
3365
3366         * Scripts/webkitdirs.pm:
3367         (safariPath): If the user is working with a Debug build, but there's
3368         no Debug version of Safari present, fall back to using a Release
3369         version of Safari.
3370
3371 2009-08-31  Adam Roben  <aroben@apple.com>
3372
3373         Make safariPath() work for Debug builds of Safari on Windows
3374
3375         <http://webkit.org/b/28849>
3376
3377         Reviewed by Sam Weinig.
3378
3379         * Scripts/webkitdirs.pm:
3380         (safariPath): If the user is working with a Debug build, add the
3381         _debug suffix to Safari.exe.
3382
3383 2009-08-28  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by Adam Barth.
3386
3387         commit-queue needs a master process
3388         https://bugs.webkit.org/show_bug.cgi?id=28040
3389
3390         Add a bugzilla-tool commit-queue command
3391         Keeps per-bug logs, but doesn't yet upload them anywhere.
3392
3393         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
3394         * Scripts/modules/buildbot.py: remove noisy log message
3395         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
3396
3397 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
3398
3399         Reviewed by Gustavo Noronha.
3400
3401         [GTK] Geolocation needs permission API before being enabled by default
3402
3403         Build the Gtk port with geolocation enabled. This option is only
3404         enabled for the buildbot. The autotools option will be enabled by
3405         default once the permissions API is implemented.
3406
3407         * Scripts/build-webkit:
3408
3409 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
3410
3411         Reviewed by David Kilzer.
3412
3413         Make prepare-ChangeLog notice property changes
3414         https://bugs.webkit.org/show_bug.cgi?id=28675
3415
3416         Make the generated ChangeLog entry include a short description of
3417         property changes if there were such changes.  Also make
3418         prepare-ChangeLog not bail if the only changes are property changes.
3419
3420         * Scripts/prepare-ChangeLog:
3421
3422 2009-08-26  Adam Barth  <abarth@webkit.org>
3423
3424         Reviewed by Oliver Hunt.
3425
3426         Don't let local files access web URLs
3427         https://bugs.webkit.org/show_bug.cgi?id=28480
3428
3429         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3430         grant local files universal access during testing.  Mainly, these tests
3431         involve making XMLHttpRequests for data URLs.
3432
3433         * DumpRenderTree/mac/DumpRenderTree.mm:
3434         (resetDefaultsToConsistentValues):
3435         * DumpRenderTree/qt/DumpRenderTree.cpp:
3436         (WebCore::WebPage::WebPage):
3437         * DumpRenderTree/win/DumpRenderTree.cpp:
3438         (resetDefaultsToConsistentValues):
3439
3440 2009-08-26  John Gregg  <johnnyg@google.com>
3441
3442         Reviewed by David Levin.
3443
3444         Minor style correction and include fix for notifications
3445         https://bugs.webkit.org/show_bug.cgi?id=28745
3446
3447         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3448           change to correct EnumStyle
3449         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3450
3451 2009-08-26  David Levin  <levin@chromium.org>
3452
3453         Reviewed by Alexey Proskuryakov.
3454
3455         XMLHttpRequest.withCredentials=false shouldn't save cookies.
3456         https://bugs.webkit.org/show_bug.cgi?id=28743
3457
3458         Added the support to the layout test controller on OSX and
3459         Windows (for CFNETWORK) to allow for changing the accept cookie
3460         policy.
3461
3462         * DumpRenderTree/LayoutTestController.cpp:
3463         (LayoutTestController::LayoutTestController): Added a bool
3464         to track the state of accepting cookies.
3465         (setAlwaysAcceptCookiesCallback): Standard wrapper method
3466         to go from js to a C++ method.
3467         (LayoutTestController::staticFunctions): Added the
3468         setAlwaysAcceptCookies method to the js layoutTestController.
3469         * DumpRenderTree/LayoutTestController.h:
3470         (LayoutTestController::alwaysAcceptCookies): Returns the value.
3471         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3472         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3473         * DumpRenderTree/mac/DumpRenderTree.mm:
3474         (resetDefaultsToConsistentValues): Reset the accept cookie to
3475         its default.
3476         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3477         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
3478         OSX to change the cookie accept policy.
3479         * DumpRenderTree/win/DumpRenderTree.cpp:
3480         (setAlwaysAcceptCookies): Method to handle all the calls necessary
3481         to change the accept cookie policy on Windows.
3482         (resetDefaultsToConsistentValues): Reset the accept cookie to
3483         its default.
3484         * DumpRenderTree/win/DumpRenderTreeWin.h:
3485         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3486         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3487         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3488         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3489
3490 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3491
3492         Unreviewed.
3493
3494         Remove accidentally left in clobber option.
3495         https://bugs.webkit.org/show_bug.cgi?id=28400
3496
3497         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
3498
3499 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3500
3501         Reviewed by Mark Rowe.
3502
3503         Add canary-style Chromium WebKit build slave to the waterfall.
3504         https://bugs.webkit.org/show_bug.cgi?id=28400
3505
3506         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
3507         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
3508
3509 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
3510
3511         Reviewed by Darin Adler.
3512
3513         make-script-test-wrappers should be executable
3514         https://bugs.webkit.org/show_bug.cgi?id=28669
3515
3516         Make make-script-test-wrappers and update-sources-list.py both be
3517         executable.
3518
3519         * Scripts/update-sources-list.py:
3520         * Scripts/make-script-test-wrappers:
3521
3522 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
3523
3524         Build fix
3525
3526         Revise Debug_Cairo targets to point inherit from the 
3527         debug_wincairo.vsprops property sheet so that they link
3528         against the proper libraries in Debug build.
3529
3530         * DumpRenderTree/win/DumpRenderTree.vcproj:
3531         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3532         * WinLauncher/WinLauncher.vcproj:
3533
3534 2009-08-25  David Levin  <levin@chromium.org>
3535
3536         Reviewed by Adam Roben.
3537
3538         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
3539         https://bugs.webkit.org/show_bug.cgi?id=28713
3540
3541         * DumpRenderTree/win/DumpRenderTree.cpp:
3542         (main):
3543
3544 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3545
3546         Reviewed by Ariya Hidayat.
3547
3548         [Qt/Mac] Use CONFIG+=build_all only when building libraries
3549
3550         If no configuration is specified when building WebKit we pass the
3551         debug_and_release option to QMake which results in Makefiles for
3552         both configurations being generated.
3553
3554         Previously we built both of these configurations by default, for
3555         all targets (both the QtWebKit framework/dyldlib and the various
3556         executables such as QtLauncher and tests). This makes sense for
3557         the libraries, which get the _debug suffix and can be loaded on
3558         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
3559         ended up building the same executable twice.
3560
3561         We now only build one instance of each executable, and since this
3562         is a developer build we build the debug-version. Passing either
3563         --debug or --release to build-webkit will override this, and
3564         even in the default case the release version can still be built
3565         by running 'make release' in the the build directory of each
3566         target.
3567
3568         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3569         * Scripts/webkitdirs.pm:
3570
3571 2009-08-24  Hironori Bono  <hbono@chromium.org>
3572
3573         Reviewed by Adam Barth.
3574
3575         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
3576         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
3577
3578         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
3579         Chromium cannot send valid key-codes to JavaScript when a user types
3580         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
3581
3582         To write layout tests for this issue, added mappings from function-key
3583         names to platform-specific key-codes to EventSendingController objects
3584         so that eventSender.keyDown() can send function-key events without using
3585         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
3586         is only for Mac. So this change adds this new test to Skipped tests for other
3587         platforms to prevent this change from crashing the build trees.)
3588
3589         * DumpRenderTree/mac/EventSendingController.mm:
3590         (-[EventSendingController keyDown:withModifiers:]):
3591
3592 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
3593
3594         Reviewed by Xan Lopez.
3595
3596         [Gtk] API for disabling local file access to web URLs
3597         https://bugs.webkit.org/show_bug.cgi?id=28663
3598
3599         Enable this setting for DRT.
3600
3601         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3602         (resetWebViewToConsistentStateBeforeTesting):
3603
3604 2009-08-22  Adam Barth  <abarth@webkit.org>
3605
3606         Revert 47684.  We're going to do this later once clients have had a
3607         chance to opt into the setting they like.
3608
3609         * DumpRenderTree/mac/DumpRenderTree.mm:
3610         (resetDefaultsToConsistentValues):
3611         * DumpRenderTree/qt/DumpRenderTree.cpp:
3612         (WebCore::WebPage::WebPage):
3613         * DumpRenderTree/win/DumpRenderTree.cpp:
3614         (resetDefaultsToConsistentValues):
3615
3616 2009-08-22  Adam Barth  <abarth@webkit.org>
3617
3618         Reviewed by Eric Seidel.
3619
3620         Don't let local files access web URLs
3621         https://bugs.webkit.org/show_bug.cgi?id=28480
3622
3623         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3624         grant local files universal access during testing.  Mainly, these tests
3625         involve making XMLHttpRequests for data URLs.
3626
3627         * DumpRenderTree/mac/DumpRenderTree.mm:
3628         (resetDefaultsToConsistentValues):
3629         * DumpRenderTree/qt/DumpRenderTree.cpp:
3630         (WebCore::WebPage::WebPage):
3631         * DumpRenderTree/win/DumpRenderTree.cpp:
3632         (resetDefaultsToConsistentValues):
3633
3634 2009-08-22  Mark Rowe  <mrowe@apple.com>
3635
3636         Rubber-stamped by Anders Carlsson.
3637
3638         Bring signed updates to the Mac nightly builds.
3639
3640         * WebKitLauncher/Info.plist:
3641         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3642         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3643         (initializeSparkle):
3644         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
3645
3646 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
3647
3648         Rubberstamped by&nbs