2010-12-06 Philippe Normand <pnormand@igalia.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-06  Philippe Normand  <pnormand@igalia.com>
2
3         Reviewed by Martin Robinson.
4
5         [GTK] Support the Mozilla-style Fullscreen Javascript API
6         https://bugs.webkit.org/show_bug.cgi?id=50572
7
8         Enable the Javascript Fullscreen support in the GtkLauncher. Also
9         make DRT update the Chrome when the WebView settings have been
10         reset to consistent values.
11
12         * DumpRenderTree/gtk/DumpRenderTree.cpp:
13         (resetDefaultsToConsistentValues):
14         * GtkLauncher/main.c:
15         (create_window):
16         * Scripts/build-webkit:
17
18 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
19
20         Reviewed by Tor Arne Vestbø
21
22         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
23         https://bugs.webkit.org/show_bug.cgi?id=50742
24
25         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
26
27         * Scripts/webkitdirs.pm:
28
29 2010-12-09  Joone Hur  <joone@kldp.org>
30
31          Reviewed by Martin Robinson.
32
33          [GTK] Support for viewport meta tag
34          https://bugs.webkit.org/show_bug.cgi?id=45443
35
36          Add support for testing the viewport properties for WebKitGtk.
37
38          * DumpRenderTree/LayoutTestController.cpp:
39          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
40          (LayoutTestController::staticFunctions):
41          * DumpRenderTree/LayoutTestController.h:
42          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
43          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
44          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
45          (LayoutTestController::dumpConfigurationForViewport): Ditto.
46          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
47          (LayoutTestController::dumpConfigurationForViewport): Ditto.
48          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
49          (LayoutTestController::dumpConfigurationForViewport): Ditto.
50          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
51          (LayoutTestController::dumpConfigurationForViewport): Ditto.
52
53 2010-12-08  William Siegrist <wsiegrist@apple.com>
54
55         Reviewed by Eric Seidel.
56
57         Migrate buildbot.py from xmlrpc to json.
58         https://bugs.webkit.org/show_bug.cgi?id=50647
59
60         * Scripts/webkitpy/common/net/buildbot.py:
61
62 2010-12-08  Tony Chang  <tony@chromium.org>
63
64         Reviewed by Eric Seidel.
65
66         make starting the websocket server more reliable on windows
67         https://bugs.webkit.org/show_bug.cgi?id=50712
68
69         * Scripts/webkitpy/common/system/filesystem.py:
70         (remove): Substitute method for os.remove to retry on error on Windows
71         * Scripts/webkitpy/common/system/filesystem_unittest.py:
72         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
73
74 2010-12-08  Jessie Berlin  <jberlin@apple.com>
75
76         Reviewed by Adam Roben.
77
78         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
79         https://bugs.webkit.org/show_bug.cgi?id=50656
80
81         * MiniBrowser/mac/BrowserWindowController.m:
82         (-[BrowserWindowController awakeFromNib]):
83         Indicate that exceededDatabaseQuota is not implemented.
84         * MiniBrowser/win/BrowserView.cpp:
85         (BrowserView::create):
86         Ditto.
87         * WebKitTestRunner/TestController.cpp:
88         (WTR::createOtherPage):
89         Ditto.
90         (WTR::TestController::initialize):
91         Ditto.
92
93 2010-12-08  Antonio Gomes  <agomes@rim.com>
94
95         Reviewed by Martin Robinson.
96
97         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
98         https://bugs.webkit.org/show_bug.cgi?id=48429
99
100         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
101         * webkit_gc_collect_javascript_objects;
102         * webkit_gc_collect_javascript_objects_on_alternate_thread;
103         * webkit_gc_count_javascript_objects;
104         * webkit_web_frame_layout.
105
106         These were all only used by GTK+ DRT.
107
108         * DumpRenderTree/gtk/EventSender.cpp:
109         (dispatchEvent):
110         * DumpRenderTree/gtk/GCControllerGtk.cpp:
111         (GCController::collect):
112         (GCController::collectOnAlternateThread):
113         (GCController::getJSObjectCount):
114
115 2010-12-07  Tony Chang  <tony@chromium.org>
116
117         Reviewed by Ojan Vafai.
118
119         [chromium] force NRWT to use DRT
120         https://bugs.webkit.org/show_bug.cgi?id=50359
121
122         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
123
124 2010-12-06  Sam Weinig  <sam@webkit.org>
125
126         Reviewed by Anders Carlsson.
127
128         Generalize didChangeLocationWithinPageForFrame for all same document navigations
129         https://bugs.webkit.org/show_bug.cgi?id=50584
130
131         * MiniBrowser/mac/BrowserWindowController.m:
132         (didSameDocumentNavigationForFrame):
133         (-[BrowserWindowController awakeFromNib]):
134         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
135         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
136         (TestWebKitAPI::didSameDocumentNavigationForFrame):
137         (TestWebKitAPI::TEST):
138         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
139         (WTR::InjectedBundlePage::InjectedBundlePage):
140         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
142         * WebKitTestRunner/TestController.cpp:
143         (WTR::TestController::initialize):
144
145 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
146
147         Reviewed by Ojan Vafai.
148
149         Make TestResultsServer return 404 for non-existing results files.
150         https://bugs.webkit.org/show_bug.cgi?id=50581
151
152         * TestResultServer/handlers/testfilehandler.py:
153
154 2010-12-06  Tony Chang  <tony@chromium.org>
155
156         Reviewed by Ojan Vafai.
157
158         [chromium] fix an assert hit in DRT
159         https://bugs.webkit.org/show_bug.cgi?id=50575
160
161         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
162         semantics.
163
164         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
165         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
166         WTF::RefCountedBase::ref()).
167
168         * DumpRenderTree/chromium/TestWebWorker.h:
169         (TestWebWorker::TestWebWorker):
170
171 2010-12-02  Ojan Vafai  <ojan@chromium.org>
172
173         Reviewed by Eric Seidel.
174
175         make webkit-patch command work when the git branch is not synced to the remote svn branch
176         https://bugs.webkit.org/show_bug.cgi?id=50424
177
178         * Scripts/webkitpy/common/checkout/scm.py:
179         * Scripts/webkitpy/common/checkout/scm_unittest.py:
180
181 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
182
183         Reviewed by Andreas Kling.
184
185         [WINCE] Add build system
186         https://bugs.webkit.org/show_bug.cgi?id=50522
187
188         * CMakeListsWinCE.txt: Added.
189
190 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
191
192         Reviewed by Tony Chang.
193
194         Allow the Chromium port to have Leopard-specific baselines
195         https://bugs.webkit.org/show_bug.cgi?id=50506
196
197         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
198
199 2010-12-03  Tony Chang  <tony@chromium.org>
200
201         Reviewed by Kent Tamura.
202
203         [chromium] fix 2 bugs with inspector tests in DRT
204         https://bugs.webkit.org/show_bug.cgi?id=50492
205
206         Tasks can outlive the tasklist (even when canceled) so this was
207         causing a crash when ~WebTask() ran.  Avoid this by unregistering
208         when a task is canceled.
209
210         Also fix an assert when closing devtool windows by copying some
211         logic from test_shell.
212
213         * DumpRenderTree/chromium/Task.cpp:
214         (WebTask::~WebTask):
215         (TaskList::revokeAll):
216         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
217             the tasklist (since the task can outlive the tasklist).
218         * DumpRenderTree/chromium/TestShell.h:
219         (TestShell::devToolsWebView):
220         * DumpRenderTree/chromium/WebViewHost.cpp:
221         (WebViewHost::~WebViewHost): Don't load about:blank when closing
222             a window if the window has devtools loaded.  This avoids an
223             ASSERT and matches test_shell.
224
225 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
226
227         Reviewed by Martin Robinson.
228
229         [GTK] Fix GtkLauncher.c style, use webkit style
230         https://bugs.webkit.org/show_bug.cgi?id=50542
231
232         * GtkLauncher/main.c:
233         (activateUriEntryCb):
234         (updateTitle):
235         (linkHoverCb):
236         (notifyTitleCb):
237         (notifyLoadStatusCb):
238         (notifyProgressCb):
239         (destroyCb):
240         (goBackCb):
241         (goForwardCb):
242         (create_webViewCb):
243         (webViewReadyCb):
244         (closeWebViewCb):
245         (createBrowser):
246         (createStatusbar):
247         (createToolbar):
248         (createWindow):
249         (main):
250
251 2010-12-04  Antonio Gomes  <agomes@rim.com>
252
253         Reviewed by Martin Robinson.
254
255         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
256         https://bugs.webkit.org/show_bug.cgi?id=48429
257
258         Moved more private method declared with WEBKIT_API to
259         DumpRenderTreeSupportGtk, since they were only being used by DRT.
260
261         * DumpRenderTree/gtk/DumpRenderTree.cpp:
262         (resetDefaultsToConsistentValues):
263         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
264         (LayoutTestController::addOriginAccessWhitelistEntry):
265         (LayoutTestController::execCommand):
266         (LayoutTestController::isCommandEnabled):
267
268 2010-12-04  Antonio Gomes  <agomes@rim.com>
269
270         Reviewed by Andreas Kling.
271
272         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
273
274         Method was removed by http://trac.webkit.org/changeset/71604
275
276         * DumpRenderTree/gtk/DumpRenderTree.cpp:
277
278 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
279
280         Reviewed by Xan Lopez.
281
282         [GTK] Fix compilation warnings reported by clang
283         https://bugs.webkit.org/show_bug.cgi?id=50252
284
285         * GtkLauncher/main.c:
286         (create_window): The create_statusbar function does not have
287         parameters.
288
289 2010-12-05  Robert Hogan  <robert@webkit.org>
290
291         Reviewed by Andreas Kling.
292
293         [Qt] Zero-sized font does not yet work
294
295         Fix fast/text/font-size-zero.html
296
297         Copy other ports by setting minimumFontSize to 0 for DRT runs.
298
299         https://bugs.webkit.org/show_bug.cgi?id=49759
300
301         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
302         (WebCore::WebPage::WebPage):
303
304 2010-12-04  Sam Weinig  <sam@webkit.org>
305
306         Reviewed by Jon Honeycutt.
307
308         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
309         https://bugs.webkit.org/show_bug.cgi?id=50511
310
311         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
312         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
313
314         * MiniBrowser/mac/BrowserWindowController.m:
315         (didChangeLocationWithinPageForFrame):
316         (-[BrowserWindowController awakeFromNib]):
317         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
318         * TestWebKitAPI/PlatformUtilities.cpp:
319         (TestWebKitAPI::Util::toWK):
320         * TestWebKitAPI/PlatformUtilities.h:
321         (TestWebKitAPI::Util::adoptWK):
322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
323         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
324         (TestWebKitAPI::nullJavaScriptCallback):
325         (TestWebKitAPI::didFinishLoadForFrame):
326         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
327         (TestWebKitAPI::TEST):
328         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
329         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
330         * TestWebKitAPI/win/copy-resources.cmd:
331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
332         (WTR::InjectedBundlePage::InjectedBundlePage):
333         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
334         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
335         * WebKitTestRunner/TestController.cpp:
336         (WTR::TestController::initialize):
337
338 2010-11-08  Antonio Gomes  <agomes@rim.com>
339
340         Reviewed by Martin Robinson.
341
342         [Gtk] Populate DumpRenderTreeSupportGtk
343         https://bugs.webkit.org/show_bug.cgi?id=48429
344
345         Made the previous calls to webkit_web_frame* functions defined as private
346         APIs in webkitprivate.h go through DRTSupportGtk.
347
348         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
349         (AccessibilityController::focusedElement):
350         * DumpRenderTree/gtk/DumpRenderTree.cpp:
351         (dumpFramesAsText):
352         (resetDefaultsToConsistentValues):
353         (dump):
354         (webViewDocumentLoadFinished):
355         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
356         (LayoutTestController::counterValueForElementById):
357         (LayoutTestController::pageNumberForElementById):
358         (LayoutTestController::numberOfPages):
359         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
360         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
361         (LayoutTestController::sampleSVGAnimationForElementAtTime):
362         (LayoutTestController::numberOfActiveAnimations):
363         (LayoutTestController::suspendAnimations):
364         (LayoutTestController::resumeAnimations):
365         (LayoutTestController::markerTextForListItem):
366
367 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
368
369         Reviewed by Tony Chang.
370
371         Rebaseline server: use pretty text diff output
372         https://bugs.webkit.org/show_bug.cgi?id=50484
373         
374         Serve *-pretty-diff.html for text diff output.
375
376         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
377         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
378         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
379         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
380
381 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
382
383         Unreviewed, rolling out r73302.
384         http://trac.webkit.org/changeset/73302
385         https://bugs.webkit.org/show_bug.cgi?id=50499
386
387         Causes crashes in debug LayoutTests (Requested by xan_ on
388         #webkit).
389
390         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
391         (AccessibilityUIElement::AccessibilityUIElement):
392         (AccessibilityUIElement::parentElementCallback):
393         * DumpRenderTree/chromium/AccessibilityUIElement.h:
394         * DumpRenderTree/chromium/CppBoundClass.cpp:
395         * DumpRenderTree/chromium/CppBoundClass.h:
396
397 2010-12-03  Sam Weinig  <sam@webkit.org>
398
399         Reviewed by Maciej Stachowiak.
400
401         Enable <a ping> for Mac/Windows/WebKit2 builds
402         <rdar://problem/8504473>
403         https://bugs.webkit.org/show_bug.cgi?id=50488
404
405         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
406         (TestWebKitAPI::TEST): Test that the default value of
407         WKPreferencesGetHyperlinkAuditingEnabled is true.
408
409 2010-12-03  Chris Guillory  <chris.guillory@google.com>
410
411         Reviewed by Chris Fleizach.
412
413         Include the FrameView widget of a RenderWidget in the accessibility tree.
414         https://bugs.webkit.org/show_bug.cgi?id=49106
415
416         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
417         (AccessibilityUIElement::AccessibilityUIElement):
418         (AccessibilityUIElement::parentElementCallback):
419         (AccessibilityUIElement::isEqualCallback):
420         * DumpRenderTree/chromium/AccessibilityUIElement.h:
421         * DumpRenderTree/chromium/CppBoundClass.cpp:
422         (CppBoundClass::getFromCppVariant):
423         * DumpRenderTree/chromium/CppBoundClass.h:
424
425 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
426
427         Reviewed by Tony Chang.
428
429         Rebaseline server: organize tests by state, add dry run mode
430         https://bugs.webkit.org/show_bug.cgi?id=50473
431         
432         Group tests in the menu by state, so that it's easier to see after
433         processing the queue which failed.
434         
435         Add support for the --dry-run flag so that it's easier to test changes
436         such as this (stubs out filesystem and SCM operations).
437
438         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
439         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
440         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
441
442 2010-12-03  Brady Eidson  <beidson@apple.com>
443
444         Reviewed by Anders Carlsson.
445
446         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
447         WebKit2 Authentication Support
448
449         Keep these builds working:
450         * MiniBrowser/mac/BrowserWindowController.m:
451         (-[BrowserWindowController awakeFromNib]):
452
453         * WebKitTestRunner/TestController.cpp:
454         (WTR::TestController::initialize):
455
456 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
457
458         Reviewed by Tony Chang.
459
460         Rebaseline server: move existing baselines
461         https://bugs.webkit.org/show_bug.cgi?id=50421
462         
463         Implement moving of existing baselines: move all files that are about
464         to be overwriten by update baselines.
465         
466         Also fix a typo in the UI JS.
467
468         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
469         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
470         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
471
472 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
473
474         Unreviewed, rolling out r73211.
475         http://trac.webkit.org/changeset/73211
476         https://bugs.webkit.org/show_bug.cgi?id=50450
477
478         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
479         yutak on #webkit).
480
481         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
482
483 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
484
485         Unreviewed, rolling out r73222.
486         http://trac.webkit.org/changeset/73222
487         https://bugs.webkit.org/show_bug.cgi?id=50449
488
489         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
490         (Requested by yutak on #webkit).
491
492         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
493         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
494         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
495         * Scripts/webkitpy/layout_tests/port/base.py:
496         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
497         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
498
499 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
500
501         Unreviewed, rolling out r73228.
502         http://trac.webkit.org/changeset/73228
503         https://bugs.webkit.org/show_bug.cgi?id=50448
504
505         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
506         (Requested by yutak on #webkit).
507
508         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
509         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
510         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
511         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
512         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
513
514 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
515
516         Unreviewed, rolling out r73231.
517         http://trac.webkit.org/changeset/73231
518         https://bugs.webkit.org/show_bug.cgi?id=50443
519
520         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
521         (Requested by yutak on #webkit).
522
523         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
524         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
525         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
526         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
527
528 2010-12-03  David Levin  <levin@chromium.org>
529
530         Reviewed by Shinichiro Hamaji.
531
532         check-webkit-style: false positive reported for #if macro
533         https://bugs.webkit.org/show_bug.cgi?id=48242
534
535         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
536           all preprocessor commands.
537         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
538
539 2010-12-02  Eric Seidel  <eric@webkit.org>
540
541         Reviewed by Adam Barth.
542
543         Update the EWSTools scripts to use modern-style git repos
544         https://bugs.webkit.org/show_bug.cgi?id=50402
545
546         * EWSTools/create-webkit-git:
547         * EWSTools/start-commit-queue.sh:
548         * EWSTools/start-queue.sh:
549
550 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
551
552         Fix Chromium Linux plugin tests by not logging
553         unconditionally from the event handling code.
554
555         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
556         (handleEventX11):
557
558 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
559
560         Reviewed by Tony Chang.
561
562         nrwt multiprocessing - move logic back into run_webkit_tests
563
564         This change moves a bunch of logic that I had put into
565         message_broker back into run_webkit_tests, in a slightly
566         different format. WorkerMessageBroker needed to become less aware of
567         the logic the TestRunner class uses, and more generic.
568         Eventually the MessageBroker will only do generic messaging and
569         thread/process-pooling, and (almost) all of the
570         run-webkit-tests-specific logic will be moved to
571         run_webkit_tests.py and dump_render_tree_thread.py.
572         
573         The biggest changes are that the Broker can now start a single
574         worker, but the responsibility for starting all of them is pushed
575         back to the TestRunner (Manager), and the logic for checking if
576         the threads are done or wedged is moved back to TestRunner. We
577         also remove WorkerMessageBroker.cleanup (not needed) and
578         cancel_workers (they have to be cancelled individually).
579         
580         The  message_broker is now encapsulated inside
581         TestRunner._run_tests(); it only needs to exist while actually
582         running the tests.
583
584         Also, delete a bunch of tests in message_broker_unittest that no
585         longer make much sense.
586
587         This patch depends on bug 50372.
588
589         https://bugs.webkit.org/show_bug.cgi?id=50374
590
591         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
592         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
593         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
594         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
595         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
596
597 2010-12-02  Hayato Ito  <hayato@chromium.org>
598
599         Reviewed by Eric Seidel.
600
601         Refactor test_types's compare_output() method so that it takes a
602         TestInput object.
603
604         compare_output() will need additional information included in a TestInput
605         object to support reftests. This change is a pre-requirement of that.
606
607         https://bugs.webkit.org/show_bug.cgi?id=50362
608
609         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
610         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
611         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
612         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
613         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
614
615 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
616
617         Reviewed by Anders Carlsson.
618
619         Add the ability to run script on 'new' and 'paint' in the test plugin
620         https://bugs.webkit.org/show_bug.cgi?id=50425
621         
622         Add "onnew" and "onpaintevent" attributes to the test plugin,
623         so that tests can run JS at these times.
624
625         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
626         (pluginAllocate):
627         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
628         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
629         (NPP_New):
630         (NPP_Destroy):
631         (handleEventCarbon):
632         (handleEventCocoa):
633         (NPP_HandleEvent):
634
635 2010-12-02  Sam Weinig  <sam@webkit.org>
636
637         Fix Qt build.
638
639         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
640         (WTR::PlatformWebView::PlatformWebView):
641
642 2010-12-02  Sam Weinig  <sam@webkit.org>
643
644         Reviewed by Anders Carlsson.
645
646         WebKit2 Preferences should be held off the PageGroup, not the Context
647         https://bugs.webkit.org/show_bug.cgi?id=50414
648
649         Update for API changes.
650
651         * WebKitTestRunner/PlatformWebView.h:
652         * WebKitTestRunner/TestController.cpp:
653         (WTR::createOtherPage):
654         (WTR::TestController::initialize):
655         (WTR::TestController::resetStateToConsistentValues):
656         * WebKitTestRunner/TestController.h:
657         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
658         (WTR::PlatformWebView::PlatformWebView):
659         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
660         (WTR::PlatformWebView::PlatformWebView):
661
662 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
663
664         Reviewed by Tony Chang.
665
666         new-run-webkit-tests: minor cleanup for multiprocessing work
667
668         This change:
669         * moves worker naming into TestShellThread, eliminating a
670           parameter to the constructor and putting the responsibility in
671           the correct place.
672         * eliminates the _WorkerState() class in message_broker, because
673           it turns out that state really needs to be in run_webkit_tests
674         * renames the Broker classes to be module-private.
675         * fixes a bunch of minor commenting and whitespace issues to
676           make subsequent patches a bit clearer.
677         * Adds a Port hook for default_worker_model() so that we can
678           accomodate the potential for different worker models on
679           different ports.
680         * merge in the fix from 50420 for the brokenness introduced in
681           bug 50367.
682
683         This patch depends on bug 50367.
684
685         https://bugs.webkit.org/show_bug.cgi?id=50372
686
687         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
688         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
689         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
690         * Scripts/webkitpy/layout_tests/port/base.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
692         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
693
694 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
695
696         Reviewed by Tony Chang.
697
698         This change is a bunch of cleanup / refactoring of the file
699         below. It moves a bunch of free functions to methods on the
700         TestShellThread class, and restructures other methods to be
701         closer to the structure we'll need for the multiprocessing
702         rewrite.
703
704         It also makes the logic of --run-singly a *lot* easier to follow
705         by nestling all of the separate-thread logic into a single
706         routine.
707
708         There should be no semantic changes in this patch, just cleanup.
709
710         https://bugs.webkit.org/show_bug.cgi?id=50367
711
712         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
713
714 2010-12-02  Tony Chang  <tony@chromium.org>
715
716         Unreviewed, rolling out r73164.
717         http://trac.webkit.org/changeset/73164
718         https://bugs.webkit.org/show_bug.cgi?id=50359
719
720         broke debugger tests on win
721
722         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
723
724 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
725
726         Reviewed by Tony Chang.
727
728         Rebaseline server: add updating of baselines
729         https://bugs.webkit.org/show_bug.cgi?id=50305
730         
731         Implements updating of baselines, where we copy -actual.* files over
732         the current -expected.* files. To do this, we need a
733         _get_actual_result_files method to get test results files and a
734         _rebaseline_test method to actually do the file copy and SCM operation.
735         _rebaseline_test logs output into a buffer, this is useful for both
736         showing result in the UI and for unit tests.
737         
738         To make passing around of the various test environment properties
739         (results directory, filesystem, SCM, etc) easier, add a TestConfig
740         class for them.
741         
742         Moving of existing baselines is not implemented yet, this patch is big
743         enough as it is.
744
745         * Scripts/webkitpy/common/system/filesystem.py:
746         * Scripts/webkitpy/common/system/filesystem_mock.py:
747         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
748         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
749         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
750         * Scripts/webkitpy/tool/mocktool.py:
751
752 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
753
754         Unreviewed build fix after vcproj updates.
755
756         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
757         that WIN_CAIRO is defined for this build.
758         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
759         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
760         (these were previously 'Debug_Cairo' and 'Release_Cairo'
761
762 2010-12-02  Sam Weinig  <sam@webkit.org>
763
764         Reviewed by Anders Carlsson.
765
766         WebKit2 needs API to turn on popup blocking
767         https://bugs.webkit.org/show_bug.cgi?id=50407
768
769         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
770         (TestWebKitAPI::TEST):
771         * WebKitTestRunner/TestController.cpp:
772         (WTR::TestController::resetStateToConsistentValues):
773
774 2010-12-01  Tony Chang  <tony@chromium.org>
775
776         Reviewed by Ojan Vafai.
777
778         [chromium] force NRWT to use DRT
779         https://bugs.webkit.org/show_bug.cgi?id=50359
780
781         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
782
783 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
784
785         Reviewed by Xan Lopez.
786
787         [GTK] DumpRenderTree has two copies of JavaScriptCore
788         https://bugs.webkit.org/show_bug.cgi?id=49877
789
790         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
791         LDADD list for DumpRenderTree.
792
793 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
794
795         Unreviewed: Added myself to list of Committers.
796
797         * Scripts/webkitpy/common/config/committers.py:
798
799 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
800
801         Reviewed by Adam Barth.
802
803         build-webkit --chromium always updates DEPS and re-generates project files
804         https://bugs.webkit.org/show_bug.cgi?id=50340
805         
806         Make build-webkit --chromium invoke update-webkit-chromium only when
807         --update-chromium is passed in, so that we don't add 20 seconds to all
808         builds.
809         
810         Making all invocations update was added with r61883, with the goal of
811         making EWS bots always update. The bots will switch to using this flag
812         (as will all other webkit-patch build steps) so nothing should change
813         for them.
814
815         * Scripts/webkitdirs.pm:
816         * Scripts/webkitpy/common/config/ports.py:
817         * Scripts/webkitpy/common/config/ports_unittest.py:
818
819 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
820
821         Reviewed by Tony Chang.
822
823         new-run-webkit-tests: add a --dry-run / -n flag
824         https://bugs.webkit.org/show_bug.cgi?id=50045
825
826         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
827         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
828
829 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
830
831         Reviewed by Adam Roben.
832
833         WinCairo build should not use link-time code generation (LTCG)
834         https://bugs.webkit.org/show_bug.cgi?id=50353
835
836         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
837         * DumpRenderTree/win/DumpRenderTree.vcproj:
838         * DumpRenderTree/win/ImageDiff.vcproj:
839         * FindSafari/FindSafari.vcproj:
840         * MiniBrowser/MiniBrowser.vcproj:
841         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
842         * WebKitAPITest/WebKitAPITest.vcproj:
843         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
844         * WebKitTestRunner/win/InjectedBundle.vcproj:
845         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
846         * WinLauncher/WinLauncher.vcproj:
847         * record-memory-win/record-memory-win.vcproj:
848
849 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
850
851         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
852         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
853         adding the file to the sources list was not enough to force the rebuild.
854
855         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
856         Remove an empty line at the end of this file to force a rebuild.
857
858 2010-12-01  Sam Weinig  <sam@webkit.org>
859
860         Fix windows build.
861
862         * MiniBrowser/win/BrowserView.cpp:
863         (BrowserView::create):
864
865 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
866
867         Add missing file to the TestNetscapePlugin sources list after r73057.
868
869         * GNUmakefile.am: Add missing file.
870
871 2010-12-01  Sam Weinig  <sam@webkit.org>
872
873         Reviewed by Anders Carlsson.
874
875         Add PageGrouping to WebKit2 API
876         https://bugs.webkit.org/show_bug.cgi?id=50332
877
878         - Update testing harnesses to deal with new PageGroup API.
879
880         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
881         (WKBundleInitialize):
882         * TestWebKitAPI/InjectedBundleController.cpp:
883         (TestWebKitAPI::InjectedBundleController::initialize):
884         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
885         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
886         * TestWebKitAPI/InjectedBundleController.h:
887         * TestWebKitAPI/InjectedBundleTest.h:
888         (TestWebKitAPI::InjectedBundleTest::initialize):
889         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
890         * TestWebKitAPI/PlatformUtilities.cpp:
891         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
892         * TestWebKitAPI/PlatformUtilities.h:
893         * TestWebKitAPI/PlatformWebView.h:
894         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
895         (TestWebKitAPI::TEST):
896         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
897         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
898         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
899         (TestWebKitAPI::PlatformWebView::PlatformWebView):
900         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
901         (TestWebKitAPI::PlatformWebView::PlatformWebView):
902         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
903         (WTR::InjectedBundle::didInitializePageGroup):
904         (WTR::InjectedBundle::initialize):
905         (WTR::InjectedBundle::beginTesting):
906         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
907         (WTR::InjectedBundle::pageGroup):
908         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
909         (WTR::LayoutTestController::addUserScript):
910         (WTR::LayoutTestController::addUserStyleSheet):
911         (WTR::LayoutTestController::setXSSAuditorEnabled):
912         * WebKitTestRunner/TestController.cpp:
913         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
914         (WTR::PlatformWebView::PlatformWebView):
915
916 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
917
918         Reviewed by Adam Roben.
919
920         vcproj changes can't be applied cleanly by the Windows EWS bot
921         https://bugs.webkit.org/show_bug.cgi?id=50328
922
923         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
924         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
925         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
926         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
927         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
928         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
929         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
930         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
931         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
932         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
933         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
934         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
935         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
936         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
937         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
938         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
939         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
940         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
941         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
942         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
943         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
944         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
945         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
946         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
947         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
948         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
949         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
950         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
951         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
952         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
953         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
954         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
955         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
956         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
957         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
958         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
959         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
960         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
961         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
962         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
963         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
964         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
965         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
966         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
967         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
968
969 2010-12-01  Anders Carlsson  <andersca@apple.com>
970
971         Reviewed by Darin Adler.
972
973         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
974         https://bugs.webkit.org/show_bug.cgi?id=50336
975
976         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
977         Add new test.
978
979         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
980         (PluginTest::NPP_New):
981         Add default implementation/
982
983         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
984         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
985         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
986         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
987         Get the user agent.
988
989         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
990         (NPP_New):
991         Call PluginTest::NPP_New.
992
993         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
994         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
995         Add new files.
996
997         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
998         (webkit_test_plugin_new_instance):
999         Call PluginTest::NPP_New.
1000
1001 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
1002
1003         [wx] Build fixes after recent trunk changes.
1004
1005         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1006         (LayoutTestController::findString):
1007         * wx/build/settings.py:
1008
1009 2010-12-01  Dan Bernstein  <mitz@apple.com>
1010
1011         Reviewed by Darin Adler.
1012
1013         WebKitTestRunner needs layoutTestController.findString
1014         https://bugs.webkit.org/show_bug.cgi?id=50238
1015
1016         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
1017         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1018         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
1019         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
1020
1021 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
1022
1023         Try using svn:eol-style native on a vcproj file.
1024
1025         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
1026
1027 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
1028
1029         Reviewed by Adam Roben.
1030
1031         [WINCE] Add WinCELauncher
1032         https://bugs.webkit.org/show_bug.cgi?id=50217
1033
1034         * WinCELauncher/main.cpp: Added.
1035
1036 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
1037
1038         Reviewed by Kenneth Rohde Christiansen.
1039
1040         [Qt] Implement layoutTestController.findString
1041         https://bugs.webkit.org/show_bug.cgi?id=50236
1042
1043         Add the missing function to the LayoutTestController.
1044
1045         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1046         (LayoutTestController::findString):
1047         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1048
1049 2010-11-30  Tony Chang  <tony@chromium.org>
1050
1051         Reviewed by Adam Barth.
1052
1053         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
1054         https://bugs.webkit.org/show_bug.cgi?id=49036
1055
1056         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
1057             for CppVariants.
1058         (LayoutTestController::cppVariantToBool):
1059         (LayoutTestController::cppVariantToInt32):
1060         (LayoutTestController::setDatabaseQuota):
1061         (LayoutTestController::evaluateInWebInspector):
1062         (LayoutTestController::setMockGeolocationError):
1063
1064 2010-11-30  Eric Seidel  <eric@webkit.org>
1065
1066         Reviewed by Tony Chang.
1067
1068         update-webkit should call git fetch before git svn rebase
1069         https://bugs.webkit.org/show_bug.cgi?id=50273
1070
1071         After discussion on webkit-dev, we've decided to move the "default"
1072         git setup to pulling updates from git.webkit.org in preference
1073         to rebuilding the local svn index using git svn fetch every time.
1074
1075         This change should have no effect on people using the "old" git setup
1076         and should dramatically increase the speed of updates for those using
1077         the "new" git setup along with update-webkit.  I'm about to move the
1078         EWS and other queues over to this setup once this lands.
1079
1080         * Scripts/update-webkit:
1081
1082 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
1083
1084         Reviewed by Xan Lopez.
1085
1086         GTK: AX: implement press in DRT
1087         https://bugs.webkit.org/show_bug.cgi?id=36146
1088
1089         Implement AccessibilityUIElement::press() for GTK.
1090
1091         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1092         (AccessibilityUIElement::press): Implemented.
1093
1094 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
1095
1096         Reviewed by Tony Chang.
1097
1098         config.webkit_base_dir returns a path with a trailing slash
1099         https://bugs.webkit.org/show_bug.cgi?id=50197
1100         
1101         config.webkit_base_dir() should return a path without a trailing slash,
1102         like all the other methods that return paths.
1103         
1104         Undoes MockFileSytem changes by r72640, since they're no longer
1105         necessary for GetBaselinesTest to pass.
1106
1107         * Scripts/webkitpy/common/system/filesystem_mock.py:
1108         * Scripts/webkitpy/layout_tests/port/base.py:
1109         * Scripts/webkitpy/layout_tests/port/config.py:
1110         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1111
1112 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
1113
1114         Reviewed by Tony Chang.
1115
1116         Rebaseline server: baseline display tweaks
1117         https://bugs.webkit.org/show_bug.cgi?id=50207
1118         
1119         Determine which baselines were used when running the tests and highlight
1120         them in the UI. Sort platform names alphabetically.
1121         
1122         Also makes the server URL be launched in the user's browser
1123         automatically.
1124
1125         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1126         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1127         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1128         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1129         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1130
1131 2010-11-30  Dan Bernstein  <mitz@apple.com>
1132
1133         Reviewed by Anders Carlsson.
1134
1135         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
1136         https://bugs.webkit.org/show_bug.cgi?id=50238
1137
1138         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1139         (WTR::LayoutTestController::findString): Added.
1140         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1141
1142 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
1143
1144         Reviewed by Adam Roben.
1145
1146         All projects on Windows should use cmd files for build events
1147         https://bugs.webkit.org/show_bug.cgi?id=50213
1148
1149         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1150         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
1151         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
1152         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1153         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
1154         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
1155         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1156         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
1157         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
1158         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
1159         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1160         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
1161         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
1162         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
1163         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1164         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
1165         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
1166         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1167         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
1168         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
1169         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1170         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1171         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
1172         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
1173         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
1174         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
1175         * WinLauncher/WinLauncherCommon.vsprops:
1176         * WinLauncher/WinLauncherPostBuild.cmd: Added.
1177         * WinLauncher/WinLauncherPreBuild.cmd: Added.
1178
1179 2010-11-29  Dan Bernstein  <mitz@apple.com>
1180
1181         GTK DumpRenderTree build fix after r72887.
1182
1183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1184         (LayoutTestController::findString):
1185
1186 2010-11-29  Dan Bernstein  <mitz@apple.com>
1187
1188         Windows DumpRenderTree build fix after r72887.
1189
1190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1191         (LayoutTestController::findString): Added empty implementation.
1192
1193 2010-11-29  Dan Bernstein  <mitz@apple.com>
1194
1195         Reviewed by Darin Adler.
1196
1197         DumpRenderTree changes for testing the text search API.
1198         https://bugs.webkit.org/show_bug.cgi?id=50038
1199
1200         * DumpRenderTree/LayoutTestController.cpp:
1201         (findStringCallback):
1202         (LayoutTestController::staticFunctions):
1203         * DumpRenderTree/LayoutTestController.h:
1204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1205         (LayoutTestController::findString):
1206         * MiniBrowser/mac/BrowserWindowController.m:
1207         (-[BrowserWindowController find:]):
1208
1209 2010-11-29  Johnny Ding  <jnd@chromium.org>
1210
1211         Unreviewed: Add myself to the list of Committers.
1212
1213         * Scripts/webkitpy/common/config/committers.py:
1214
1215 2010-11-29  Mark Rowe  <mrowe@apple.com>
1216
1217         Reviewed by Adele Peterson.
1218
1219         <rdar://problem/8694997> DumpRenderTree fails to build.
1220
1221         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
1222
1223 2010-11-29  Mark Rowe  <mrowe@apple.com>
1224
1225         Reviewed by Adele Peterson.
1226
1227         <rdar://problem/8694997> DumpRenderTree fails to build.
1228
1229         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
1230         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
1231         * DumpRenderTree/mac/PerlSupport/Makefile:
1232
1233 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
1234
1235         Reviewed by Martin Robinson.
1236
1237         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
1238         https://bugs.webkit.org/show_bug.cgi?id=50154
1239
1240         Added missing checks to allAttributes().
1241
1242         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1243         (AccessibilityUIElement::allAttributes): Added missing checks.
1244
1245 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1246
1247         Reviewed by Kenneth Rohde Christiansen.
1248
1249         [Qt] Allow pre-generation for package builds for WebKit2
1250         https://bugs.webkit.org/show_bug.cgi?id=50139
1251
1252         Use a build variable for the generated directory path and set the
1253         value based on CONFIG just like for WebKit1.
1254
1255         For non-package builds use a relative base path for the
1256         genrated directory just like for WebKit1.
1257
1258         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1259         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1260
1261 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1262
1263         Reviewed by Kenneth Rohde Christiansen.
1264
1265         [Qt] Move some build logic from Qt to platform independent code
1266         https://bugs.webkit.org/show_bug.cgi?id=50134
1267
1268         Create target directories inside generate-forwarding-headers.pl.
1269
1270         * Scripts/generate-forwarding-headers.pl:
1271
1272 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
1273
1274         Reviewed by Martin Robinson.
1275
1276         [GTK] Windowless plugins gets broken key input
1277         https://bugs.webkit.org/show_bug.cgi?id=49927
1278
1279         Convert the XEvent::keycode to ASCII before printing it. Not
1280         doing this was causing false positive in 
1281         plugins/keyboard-events.html.
1282
1283         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1284         (keycode_to_char):
1285         (webkit_test_plugin_handle_event):
1286
1287 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
1288
1289         Reviewed by Antonio Gomes.
1290
1291         [Qt] Html autofocus not working with QGraphicsWebView
1292         https://bugs.webkit.org/show_bug.cgi?id=43169
1293
1294         Tell the scene to set the webview item as the currently
1295         focused item. This makes the input field with autofocus get
1296         focus as it should.
1297
1298         * QtTestBrowser/webview.cpp:
1299         (WebViewGraphicsBased::WebViewGraphicsBased):
1300
1301 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1302
1303         Reviewed by Tony Chang.
1304
1305         nrwt - clean up create_driver interface and print out the
1306         command line used for DumpRenderTree/TestShell.
1307
1308         This patch adds a driver_cmd_line() call to the Port class in
1309         order to retrive the command line to print it out (as part of
1310         --print config).
1311
1312         In addition, this patch cleans up the Port.create_driver()
1313         signature and the Driver constructor interface to take a worker
1314         number and no longer require the image_path argument (Chromium's
1315         drivers now synthesize the image_path from the worker number
1316         internally).
1317
1318         https://bugs.webkit.org/show_bug.cgi?id=49934
1319
1320         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1321         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1322         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1323         * Scripts/webkitpy/layout_tests/port/base.py:
1324         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1325         * Scripts/webkitpy/layout_tests/port/chromium.py:
1326         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1327         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1328         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1329         * Scripts/webkitpy/layout_tests/port/test.py:
1330         * Scripts/webkitpy/layout_tests/port/webkit.py:
1331         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1332         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1333
1334 2010-11-24  Ojan Vafai  <ojan@chromium.org>
1335
1336         Reviewed by Tony Chang.
1337
1338         [chromium] improve memory usage for test results server and store fewer runs
1339         https://bugs.webkit.org/show_bug.cgi?id=50035
1340
1341         Store fewer runs and don't pass full files around when we only need bools.
1342         Greatly improves error rates on test-results.appspot.com.
1343
1344         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1345         * TestResultServer/handlers/testfilehandler.py:
1346         * TestResultServer/model/dashboardfile.py:
1347         * TestResultServer/model/jsonresults.py:
1348
1349 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
1350
1351         Reviewed by Tony Chang.
1352
1353         This patch implements the first part of the manager side of the
1354         Broker objects - it handles creating threads, waiting for them
1355         to complete, and running a single-threaded loop as well.
1356
1357         https://bugs.webkit.org/show_bug.cgi?id=49779
1358
1359         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1360         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1361         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1362         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1363
1364 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
1365
1366         Reviewed by David Levin.
1367
1368         DRT should not generate pixel output for text/plain tests
1369         https://bugs.webkit.org/show_bug.cgi?id=50002
1370         
1371         Modify Mac, Windows and GTK DRT implementations to disable pixel output
1372         when encountering a text/plain response (the Chromium one already does
1373         this, and none of the other ports special-case text/plain output in
1374         the first place).
1375
1376         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1377         (dump):
1378         * DumpRenderTree/mac/DumpRenderTree.mm:
1379         (dump):
1380         * DumpRenderTree/win/DumpRenderTree.cpp:
1381         (dump):
1382
1383 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1384
1385         Unreviewed.
1386
1387         Add my other email address to committers.py.
1388
1389         * Scripts/webkitpy/common/config/committers.py:
1390
1391 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
1392
1393         Reviewed by Csaba Osztrogonác.
1394
1395         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
1396         https://bugs.webkit.org/show_bug.cgi?id=49975
1397
1398         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
1399         to enable the script to define it 0 in case of a minimal build.
1400
1401 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
1402
1403         Reviewed by Xan Lopez.
1404
1405         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
1406         https://bugs.webkit.org/show_bug.cgi?id=49143
1407
1408         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1409         (createWebView): Call the new connectEditingCallbacks function.
1410         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
1411         (dumpNodePath):
1412         (dumpRange):
1413         (insertActionString):
1414         (selectionAffinityString):
1415         (shouldBeginEditing):
1416         (shouldEndEditing):
1417         (shouldInsertNode):
1418         (shouldInsertText):
1419         (shouldDeleteRange):
1420         (shouldShowDeleteInterfaceForElement):
1421         (shouldChangeSelectedRange):
1422         (shouldApplyStyle):
1423         (editingBegan):
1424         (userChangedContents):
1425         (editingEnded):
1426         (selectionChanged):
1427         (connectEditingCallbacks):
1428         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
1429         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
1430
1431 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
1432
1433         Reviewed by Andreas Kling.
1434
1435         [Qt] Make QtTestBrowser remember the selected user agent
1436         https://bugs.webkit.org/show_bug.cgi?id=50021
1437
1438         Set user agent for a new page by using the old page's
1439
1440         * QtTestBrowser/mainwindow.cpp:
1441         (MainWindow::setPage):
1442
1443 2010-11-24 Patrick Gansterer <paroga@webkit.org>
1444
1445         Reviewed by Csaba Osztrogonác.
1446
1447         Remove Bakefile build system files
1448         https://bugs.webkit.org/show_bug.cgi?id=49983
1449
1450         r53757 only removed the content, but not the files.
1451         This patch removes that empty files.
1452
1453         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1454         * wx/browser/browser.bkl: Removed.
1455         * wx/build-wxwebkit: Removed.
1456
1457 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
1458
1459         Reviewed by Tony Chang.
1460
1461         This patch cleans up the logic used to shard tests into groups a
1462         bit and adds the --worker-model flag to NRWT. The flag is only
1463         used at the moment to control whether to run single-threaded or
1464         not, but eventually will also allow toggling between threads and
1465         processes.
1466
1467         Also add a minor cleanup with _test_is_slow(), which just
1468         eliminates some repetition and gives slightly better encapsulation.
1469
1470         https://bugs.webkit.org/show_bug.cgi?id=49773
1471
1472         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1473         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1474
1475 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
1476
1477         Reviewed by Tony Chang.
1478
1479         Rebaseline server: list current baselines and platforms
1480         https://bugs.webkit.org/show_bug.cgi?id=49991
1481         
1482         List existing baselines (with Trac links) for tests.
1483         
1484         Add dropdowns for choosing with platform baselines to target (and what
1485         to do with existing ones).
1486
1487         Also fix MockFileSystem.join to behave more like os.path.join (unit
1488         test was ending up with two consecutive slashes in a layout test
1489         path).        
1490
1491         * Scripts/webkitpy/common/system/filesystem_mock.py:
1492         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1493         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1494         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1495         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1496         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1497         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1498         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
1499
1500 2010-11-23  Ojan Vafai  <ojan@chromium.org>
1501
1502         Reviewed by Tony Chang.
1503
1504         remove timeout argument to urlopen
1505         https://bugs.webkit.org/show_bug.cgi?id=49995
1506
1507         Apparently the version of python we have on the bots doesn't accept a timeout argument.
1508
1509         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1510
1511 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1512
1513         Unreviewed, rolling out r72628.
1514         http://trac.webkit.org/changeset/72628
1515         https://bugs.webkit.org/show_bug.cgi?id=49994
1516
1517         This patch is causing layout-test failtures on GTK Linux
1518         64-bit Debug (Requested by ctguil on #webkit).
1519
1520         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1521         (AccessibilityUIElement::AccessibilityUIElement):
1522         (AccessibilityUIElement::parentElementCallback):
1523         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1524         * DumpRenderTree/chromium/CppBoundClass.cpp:
1525         * DumpRenderTree/chromium/CppBoundClass.h:
1526
1527 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1528
1529         Reviewed by Tony Chang.
1530
1531         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
1532         https://bugs.webkit.org/show_bug.cgi?id=49944
1533
1534         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
1535
1536 2010-11-23  Chris Guillory  <chris.guillory@google.com>
1537
1538         Reviewed by Dimitri Glazkov.
1539
1540         Include the FrameView widget of a RenderWidget in the accessibility tree.
1541         https://bugs.webkit.org/show_bug.cgi?id=49106
1542
1543         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1544         (AccessibilityUIElement::AccessibilityUIElement):
1545         (AccessibilityUIElement::parentElementCallback):
1546         (AccessibilityUIElement::isEqualCallback):
1547         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1548         * DumpRenderTree/chromium/CppBoundClass.cpp:
1549         (CppBoundClass::getFromCppVariant):
1550         * DumpRenderTree/chromium/CppBoundClass.h:
1551
1552 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
1553
1554         Reviewed by Kenneth Rohde Christiansen.
1555
1556         [EFL] Add tiled backing store to EWebLauncher
1557         https://bugs.webkit.org/show_bug.cgi?id=45777
1558
1559         Allow EWebLauncher to choose between single and tiled backing store
1560
1561         * EWebLauncher/main.c:
1562         (on_key_down):
1563         (browserCreate):
1564         (main):
1565
1566 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1567
1568         Reviewed by Tor Arne Vestbø.
1569
1570         [Qt] Review the setUserPermission & friends API
1571         https://bugs.webkit.org/show_bug.cgi?id=46810
1572
1573         Renamed requestPermissionFromUser to featurePermissionRequested
1574         and cancelRequestsForPermission to featurePermissionRequestCanceled.
1575
1576         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1577         (WebCore::WebPage::WebPage):
1578         * QtTestBrowser/webpage.cpp:
1579         (WebPage::WebPage):
1580         (WebPage::featurePermissionRequestCanceled):
1581         * QtTestBrowser/webpage.h:
1582
1583 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1584
1585         Reviewed by Tor Arne Vestbø.
1586
1587         [Qt] Review the setUserPermission & friends API
1588         https://bugs.webkit.org/show_bug.cgi?id=46810
1589
1590         Rename setUserPermission to setFeaturePermission
1591
1592         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1593         (WebCore::WebPage::requestPermission):
1594         (WebCore::WebPage::permissionSet):
1595         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1596         (LayoutTestController::grantDesktopNotificationPermission):
1597         * QtTestBrowser/webpage.cpp:
1598         (WebPage::requestPermission):
1599
1600 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1601
1602         Reviewed by Tor Arne Vestbø.
1603
1604         [Qt] Review the setUserPermission & friends API
1605         https://bugs.webkit.org/show_bug.cgi?id=46810
1606
1607         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
1608         and GeolocationPermissionDomain to Geolocation.
1609
1610         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1611         (WebCore::WebPage::WebPage):
1612         (WebCore::WebPage::requestPermission):
1613         (WebCore::WebPage::cancelPermission):
1614         (WebCore::WebPage::permissionSet):
1615         (WebCore::DumpRenderTree::geolocationPermissionSet):
1616         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1617         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1618         (LayoutTestController::grantDesktopNotificationPermission):
1619         * QtTestBrowser/webpage.cpp:
1620         (WebPage::WebPage):
1621         (WebPage::requestPermission):
1622         (WebPage::cancelRequestsForPermission):
1623         * QtTestBrowser/webpage.h:
1624
1625 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1626
1627         Reviewed by Tor Arne Vestbø.
1628
1629         [Qt] Review the setUserPermission & friends API
1630         https://bugs.webkit.org/show_bug.cgi?id=46810
1631
1632         Add a ByUser suffix to PermissionGranted/Denied. In the future
1633         we can add PermissionGrantedByDefault.
1634
1635
1636         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1637         (WebCore::WebPage::requestPermission):
1638         (WebCore::WebPage::permissionSet):
1639         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1640         (LayoutTestController::grantDesktopNotificationPermission):
1641         * QtTestBrowser/webpage.cpp:
1642         (WebPage::requestPermission):
1643
1644 2010-11-18  Satish Sampath  <satish@chromium.org>
1645
1646         Reviewed by Jeremy Orlow.
1647
1648         For speech input event, send an event object containing all the recognition results and metadata.
1649         https://bugs.webkit.org/show_bug.cgi?id=49736
1650
1651         Updated DRT by renaming the mock result method on all platforms to the new signature.
1652
1653         * DumpRenderTree/LayoutTestController.cpp:
1654         (addMockSpeechInputResultCallback):
1655         (LayoutTestController::staticFunctions):
1656         * DumpRenderTree/LayoutTestController.h:
1657         * DumpRenderTree/chromium/LayoutTestController.cpp:
1658         (LayoutTestController::LayoutTestController):
1659         (LayoutTestController::addMockSpeechInputResult):
1660         * DumpRenderTree/chromium/LayoutTestController.h:
1661         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1662         (LayoutTestController::addMockSpeechInputResult):
1663         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1664         (LayoutTestController::addMockSpeechInputResult):
1665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1666         (LayoutTestController::addMockSpeechInputResult):
1667         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1668         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1669         (LayoutTestController::addMockSpeechInputResult):
1670         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1671         (LayoutTestController::addMockSpeechInputResult):
1672
1673 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1674
1675         Reviewed by Tony Chang.
1676
1677         Fix some spacing issues with log messages with
1678         new-run-webkit-tests --verbose.
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=49936
1681
1682         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1683
1684 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1685
1686         Reviewed by Adam Barth.
1687
1688         update scm to work with different remote branches
1689         https://bugs.webkit.org/show_bug.cgi?id=49949
1690
1691         This works if there are multiple svn tracking branches
1692         and/or if the tracking branch is refs/remots/origin/master
1693         instead of refs/remotes/trunk which is the direction we're trying
1694         to head since that makes fetches faster.
1695
1696         * Scripts/webkitpy/common/checkout/scm.py:
1697         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1698
1699 2010-11-22  Hayato Ito  <hayato@chromium.org>
1700
1701         Reviewed by Shinichiro Hamaji.
1702
1703         Ignore reference files which will be used by reftests when collecting
1704         test cases.
1705         https://bugs.webkit.org/show_bug.cgi?id=49835
1706
1707         * Scripts/webkitpy/layout_tests/port/test_files.py:
1708         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1709
1710 2010-11-22  Adam Roben  <aroben@apple.com>
1711
1712         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1713
1714         Apple's Windows build allows placing header files and import libraries for WebKit's
1715         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1716         $WebKitLibrariesDir environment variable. This is both required for production builds and
1717         convenient for Apple-internal developer builds. Apple's production builds also require that
1718         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1719         builds, the files are copied into that directory tree by the
1720         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1721         copying is done by
1722         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1723
1724         This .vsprops copying is problematic in one very important case: when a developer updates
1725         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1726         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1727         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1728         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1729         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1730         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1731
1732         To fix this, we now use normal relative paths to access the .vsprops files in the source
1733         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1734         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1735         unset, so the normal relative paths are used to read the .vsprops files out of the source
1736         tree directly. In production builds, this environment variable is set to a fake directory
1737         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1738         is resolved.
1739         
1740         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1741
1742         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1743
1744         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1745         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1746         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1747         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1748         FeatureDefines.vsprops becomes:
1749
1750         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1751
1752         which resolves to:
1753
1754         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1755
1756         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1757         actually exist since they are matched by an equal number of ".." path components.)
1758
1759         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1760         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1761
1762         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1763         updated
1764
1765         Reviewed by Dave Hyatt.
1766
1767         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1768         * DumpRenderTree/win/DumpRenderTree.vcproj:
1769         * DumpRenderTree/win/ImageDiff.vcproj:
1770         * FindSafari/FindSafari.vcproj:
1771         * MiniBrowser/MiniBrowser.vcproj:
1772         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1773         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1774         * WebKitAPITest/WebKitAPITest.vcproj:
1775         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1776         * WebKitTestRunner/win/InjectedBundle.vcproj:
1777         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1778         * WinLauncher/WinLauncher.vcproj:
1779         * record-memory-win/record-memory-win.vcproj:
1780         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1781         files.
1782
1783 2010-11-22  Adam Roben  <aroben@apple.com>
1784
1785         Make it possible to run tests on Windows without Visual Studio or VC++
1786         Express installed
1787
1788         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1789         are not installed. But this function doesn't need to be called when we
1790         already have a build available and are just trying to run the tests.
1791
1792         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1793         because Visual Studio/VC++ Express aren't installed
1794
1795         Reviewed by Dave Hyatt.
1796
1797         * Scripts/webkitdirs.pm:
1798         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1799         it is not needed by this function. Also added a FIXME.
1800
1801         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1802         relying on determineConfigurationForVisualStudio doing it.
1803
1804 2010-11-19  Hayato Ito  <hayato@chromium.org>
1805
1806         Reviewed by Shinichiro Hamaji.
1807
1808         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1809
1810         https://bugs.webkit.org/show_bug.cgi?id=49812
1811
1812         * Scripts/webkitpy/layout_tests/driver_test.py:
1813         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1814         * Scripts/webkitpy/layout_tests/port/base.py:
1815         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1816         * Scripts/webkitpy/layout_tests/port/chromium.py:
1817         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1818         * Scripts/webkitpy/layout_tests/port/test.py:
1819         * Scripts/webkitpy/layout_tests/port/webkit.py:
1820         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1821         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1822
1823 2010-11-22  Hayato Ito  <hayato@chromium.org>
1824
1825         Reviewed by Tony Chang.
1826
1827         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=49924
1830
1831         * Scripts/webkitpy/layout_tests/port/chromium.py:
1832
1833 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1834
1835         Reviewed by Kenneth Rohde Christiansen.
1836
1837         Fix EWebLauncher zoom discretization
1838         https://bugs.webkit.org/show_bug.cgi?id=49810
1839
1840         * EWebLauncher/main.c:
1841         (nearest_zoom_level_get):
1842         (zoom_level_set):
1843         (on_load_finished):
1844         (on_key_down):
1845
1846 2010-11-21  Sam Weinig  <sam@webkit.org>
1847
1848         Rubber-stamped by Dan Bernstein.
1849
1850         Fix ~300 WebKit2 tests by enabling developer extras preference.
1851
1852         * WebKitTestRunner/TestController.cpp:
1853         (WTR::TestController::resetStateToConsistentValues):
1854
1855 2010-11-21  Sam Weinig  <sam@webkit.org>
1856
1857         Reviewed by Dan Bernstein.
1858
1859         Textareas should be resizable by default
1860         https://bugs.webkit.org/show_bug.cgi?id=49892
1861
1862         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1863         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1864         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1865         Add preferences test.
1866
1867 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1868
1869         Reviewed by Tony Chang.
1870
1871         Rebaseline server: checksum-only differences and prefetching
1872         https://bugs.webkit.org/show_bug.cgi?id=49841
1873         
1874         Add support for image test results where the only difference is in the
1875         checksum.
1876         
1877         Add prefetching of the image results from the next test.
1878         
1879         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1880         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1881         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1882
1883 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1884
1885         Reviewed by Tony Chang.
1886
1887         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1888
1889         Add the 'worker number' and 'worker name' concepts to the 
1890         TestShellThread objects, and move test_types and test_args from
1891         the TestRunner to the TestShellThread.
1892
1893         https://bugs.webkit.org/show_bug.cgi?id=49768
1894
1895         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1896         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1897
1898 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1899
1900         Reviewed by Ojan Vafai.
1901
1902         Do some minor cleanup and bug fixing.
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=49777
1905
1906         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1907         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1908
1909 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1910
1911         Reviewed by Ojan Vafai.
1912
1913         nrwt - config.build_directory() is busted
1914
1915         Fixes a typo that was causing us to usually return the top level
1916         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1917         bug was hidden by test stubs that were too simplistic :(.
1918
1919         https://bugs.webkit.org/show_bug.cgi?id=49815
1920
1921         * Scripts/webkitpy/common/system/executive_mock.py:
1922         * Scripts/webkitpy/layout_tests/port/config.py:
1923         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1924
1925 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1926
1927         Reviewed by Adam Roben.
1928
1929         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1930         https://bugs.webkit.org/show_bug.cgi?id=49819
1931
1932         * DumpRenderTree/DumpRenderTree.sln:
1933         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1934         * DumpRenderTree/win/DumpRenderTree.vcproj:
1935         * DumpRenderTree/win/ImageDiff.vcproj:
1936         * FindSafari/FindSafari.vcproj:
1937         * MiniBrowser/MiniBrowser.vcproj:
1938         * TestWebKitAPI/win/TestWebKitAPI.sln:
1939         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1940         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1941         * WebKitAPITest/WebKitAPITest.vcproj:
1942         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1943         * WebKitTestRunner/win/InjectedBundle.vcproj:
1944         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1945         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1946         * WinLauncher/WinLauncher.vcproj:
1947         * record-memory-win/record-memory-win.vcproj:
1948
1949 2010-11-19  Adam Roben  <aroben@apple.com>
1950
1951         Add some more Windows slaves
1952
1953         This is probably more than we will be using in the immediate future,
1954         but having some extra slave names makes experimenting with different
1955         configurations easier.
1956
1957         Reviewed by Jon Honeycutt.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1960         Windows slaves and distributed them among the three different Test
1961         builders.
1962
1963 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1964
1965         Reviewed by Ojan Vafai.
1966
1967         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1968         https://bugs.webkit.org/show_bug.cgi?id=49702
1969
1970         Re-landing r72357 with a test fix.
1971
1972         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1973         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1974         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1975
1976 2010-11-19  Avi Drissman  <avi@google.com>
1977
1978         Reviewed by Antonio Gomes.
1979
1980         Complete support for Unix editing mode
1981         https://bugs.webkit.org/show_bug.cgi?id=49757
1982
1983         * DumpRenderTree/LayoutTestController.cpp:
1984         (setEditingBehaviorCallback):
1985         * DumpRenderTree/chromium/LayoutTestController.cpp:
1986         (LayoutTestController::setEditingBehavior):
1987
1988 2010-11-19  Adam Roben  <aroben@apple.com>
1989
1990         Fix run-javascriptcore-tests when there's a space in the path to
1991         testapi
1992
1993         Reviewed by Sam Weinig.
1994
1995         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1996         system() to force it to interpret spaces in the path correctly.
1997
1998 2010-11-19  Adam Roben  <aroben@apple.com>
1999
2000         Update scripts for .exe name changes after r72327
2001
2002         As of r72327, the "_debug" suffix is only used in Debug_All builds.
2003
2004         Reviewed by Sam Weinig.
2005
2006         * Scripts/run-javascriptcore-tests:
2007         (testapiPath):
2008
2009         * Scripts/sunspider-compare-results:
2010         (pathToBuiltJSC):
2011
2012         * Scripts/webkitdirs.pm:
2013         (jscPath):
2014         (safariPath):
2015
2016 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
2017
2018         Reviewed by Darin Adler.
2019
2020         Normalize Cairo/CFLite project/solution configuration names
2021         https://bugs.webkit.org/show_bug.cgi?id=49818
2022
2023         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2024         * DumpRenderTree/win/DumpRenderTree.vcproj:
2025         * DumpRenderTree/win/ImageDiff.vcproj:
2026         * MiniBrowser/MiniBrowser.vcproj:
2027         * TestWebKitAPI/win/TestWebKitAPI.sln:
2028         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2029         * WebKitAPITest/WebKitAPITest.vcproj:
2030         * WebKitTestRunner/win/InjectedBundle.vcproj:
2031         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2032         * WinLauncher/WinLauncher.vcproj:
2033         * Scripts/webkitdirs.pm: Updated cairo build configs.
2034
2035 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2036
2037         Reviewed by Adam Roben.
2038
2039         Windows vcproj configuration names should be normalized across projects
2040         https://bugs.webkit.org/show_bug.cgi?id=49776
2041
2042         * DumpRenderTree/DumpRenderTree.sln:
2043         * FindSafari/FindSafari.vcproj:
2044         * TestWebKitAPI/win/TestWebKitAPI.sln:
2045         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
2046         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
2047         * WebKitAPITest/WebKitAPITest.vcproj:
2048         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2049         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2050         * WebKitTestRunner/WebKitTestRunner.sln:
2051         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
2052         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
2053         * record-memory-win/record-memory-win.vcproj:
2054
2055 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2056
2057         Build fix - as per DRT-mac, always enabled developer extras,
2058         in win/qt/gtk DRT.
2059
2060         This is necessary to enable rich exception messages to be generated
2061         following https://bugs.webkit.org/show_bug.cgi?id=49708.
2062
2063         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2064         (shouldEnableDeveloperExtras):
2065         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2066         (WebCore::shouldEnableDeveloperExtras):
2067         * DumpRenderTree/win/DumpRenderTree.cpp:
2068         (shouldEnableDeveloperExtras):
2069
2070 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2071
2072         Unreviewed, rolling out r72357.
2073         http://trac.webkit.org/changeset/72357
2074         https://bugs.webkit.org/show_bug.cgi?id=49784
2075
2076         It broke test-webkitpy tests since the patch didn't have the
2077         corresponding test update (Requested by kinuko on #webkit).
2078
2079         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2080         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2081
2082 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
2083
2084         Reviewed by Tony Chang.
2085
2086         Rebaseline server: add rebaseline queue
2087         https://bugs.webkit.org/show_bug.cgi?id=49763
2088         
2089         Add a UI queue (a multi-item <select>) where tests to be baselined
2090         can be enqueued (also supports basic removal). A queue is used instead
2091         of immediately doing rebaselines since SCM operations can take a while.
2092         It's better to go through lots of tests quickly to mark them as
2093         needing rebaselining and then batch the SCM operations.
2094         
2095         Also adds a simple log where results can be displayed.
2096
2097         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2098         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2099         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2100         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
2101         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2102         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2103
2104 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
2105
2106         Reviewed by Oliver Hunt.
2107
2108         Bug 49708 - Stop recompiling functions to regenerate exception info.
2109
2110         Instead only hold info as necessary – keep divot info is the inspector
2111         is enabled, line number info is debugging or profiling, and handler
2112         info for functions with try/catch.
2113
2114         * DumpRenderTree/mac/DumpRenderTree.mm:
2115         (shouldEnableDeveloperExtras):
2116             - always enable the developer tools from DRT, to ensure we
2117               produce rich error messages on JavaScript exceptions.
2118
2119 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
2120
2121         Reviewed by Ojan Vafai.
2122
2123         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
2124         https://bugs.webkit.org/show_bug.cgi?id=49702
2125
2126         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2127         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2128
2129 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
2130
2131         Reviewed by Tony Chang.
2132
2133         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
2134
2135         Create the first version of the 'message_broker' package. This
2136         class will encapsulate all of the threading/multiprocessing and
2137         message-sending details for the communication between the
2138         'manager' object and the 'worker' objects. For the moment, it
2139         just holds some routines and tests for logging thread stacks.
2140
2141         There should be no functional changes in this patch, just moving stuff
2142         around.
2143
2144         https://bugs.webkit.org/show_bug.cgi?id=49707
2145
2146         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2147         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
2148         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
2149         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
2150         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2151         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2152
2153 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2154
2155         Reviewed by Adam Roben.
2156
2157         Remove leftover Windows Debug_Internal configurations
2158         https://bugs.webkit.org/show_bug.cgi?id=49758
2159
2160         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2161         * DumpRenderTree/win/DumpRenderTree.vcproj:
2162         * DumpRenderTree/win/ImageDiff.vcproj:
2163         * MiniBrowser/MiniBrowser.vcproj:
2164         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2165         * WebKitAPITest/WebKitAPITest.vcproj:
2166         * WebKitTestRunner/win/InjectedBundle.vcproj:
2167         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2168         * WinLauncher/WinLauncher.vcproj:
2169
2170 2010-11-18  Adam Roben  <aroben@apple.com>
2171
2172         Add three new Windows XP build slaves
2173
2174         Reviewed by Steve Falkenburg.
2175
2176         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
2177         new slaves, and added them to the Windows XP Debug (Tests) builder.
2178
2179 2010-11-18  Daniel Bates  <dbates@rim.com>
2180
2181         Reviewed by Adam Roben.
2182
2183         update-webkit-support-libs should fall back to existing
2184         WebKitSupportLibrary version if there is no internet connectivity
2185         https://bugs.webkit.org/show_bug.cgi?id=49503
2186
2187         Fall back to existing support libraries (if present) when there is
2188         no internet connection.
2189
2190         Currently, update-webkit-support-libs dies with an "out-of-date"
2191         error when there is no internet connection because it cannot
2192         retrieve versioning information from developer.apple.com. Because
2193         update-webkit-support-libs fails, build-webkit fails. Instead,
2194         if there is no internet connection and the support libraries are
2195         present then we should warn the user and exit() with success so
2196         that build-webkit can work without an internet connection.
2197
2198         * Scripts/update-webkit-support-libs:
2199
2200 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2201
2202         Reviewed by Adam Roben.
2203
2204         Debug_Internal Windows configuration is unnecessary, should be removed
2205         https://bugs.webkit.org/show_bug.cgi?id=49753
2206
2207         * DumpRenderTree/win/DumpRenderTree.cpp:
2208         * MiniBrowser/win/stdafx.h:
2209         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2210         * WebKitTestRunner/win/TestControllerWin.cpp:
2211
2212 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
2213
2214         Reviewed by Adam Roben.
2215
2216         Clean up vcproj errors
2217         https://bugs.webkit.org/show_bug.cgi?id=49741
2218
2219         * MiniBrowser/MiniBrowser.vcproj:
2220         * WebKitAPITest/WebKitAPITest.vcproj:
2221         * WebKitTestRunner/win/InjectedBundle.vcproj:
2222         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2223
2224 2010-11-18  Hayato Ito  <hayato@chromium.org>
2225
2226         Reviewed by Shinichiro Hamaji.
2227
2228         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
2229         which is caused by r72249.
2230
2231         https://bugs.webkit.org/show_bug.cgi?id=49751
2232
2233         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2234
2235 2010-11-18  Adam Roben  <aroben@apple.com>
2236
2237         Implement layoutTestController.waitForPolicyDelegate on Windows
2238
2239         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
2240
2241         Reviewed by Simon Fraser.
2242
2243         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2244         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
2245         code from LayoutTestControllerMac.mm.
2246
2247 2010-11-18  Hayato Ito  <hayato@chromium.org>
2248
2249         Reviewed by Shinichiro Hamaji.
2250
2251         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
2252
2253         https://bugs.webkit.org/show_bug.cgi?id=49740
2254
2255         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2256
2257 2010-11-18  Tony Chang  <tony@chromium.org>
2258
2259         Reviewed by Adam Barth.
2260
2261         run platform/chromium/plugins/refcount-leaks.html on all platforms
2262         https://bugs.webkit.org/show_bug.cgi?id=49485
2263
2264         Add PluginObject.testObjectCount which returns the number of allocated
2265         TestObjects. Add PluginObject.testCreateTestObject which allocates
2266         and returns a TestObject.
2267
2268         Add TestObject.refCount which returns the number of refs on the
2269         TestObject.
2270
2271         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2272         (pluginGetProperty):
2273         (pluginInvoke):
2274         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2275         (getTestObjectCount):
2276         (testAllocate):
2277         (testDeallocate):
2278         (testGetProperty):
2279         (testScriptObjectInvoke): Release a ref to a plugin object that was
2280             previously leaked.
2281         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
2282
2283 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2284
2285         Reviewed by Adam Roben.
2286
2287         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
2288         https://bugs.webkit.org/show_bug.cgi?id=49711
2289
2290         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
2291         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
2292         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
2293         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2294         * record-memory-win/record-memory-win-common.vsprops: Added.
2295         * record-memory-win/record-memory-win.vcproj:
2296
2297 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
2298
2299         Reviewed by Csaba Osztrogonác.
2300
2301         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
2302
2303         * MiniBrowser/qt/BrowserWindow.cpp:
2304         (BrowserWindow::updateUserAgentList):
2305
2306 2010-11-17  Adam Roben  <aroben@apple.com>
2307
2308         Don't trigger Windows builds when chromium-win test results change
2309
2310         Reviewed by Mark Rowe.
2311
2312         * Scripts/webkitpy/common/config/build.py:
2313         (_should_file_trigger_build): Changed the regular expression used to
2314         search for directory names to only consider full directory names,
2315         rather than matching directory names where the string we care about is
2316         a suffix of the name.
2317
2318         * Scripts/webkitpy/common/config/build_unittest.py:
2319         (ShouldBuildTest): Added a test.
2320
2321 2010-11-17  Hayato Ito  <hayato@chromium.org>
2322
2323         Reviewed by Shinichiro Hamaji.
2324
2325         Remove a uri member from TestInput class.
2326
2327         https://bugs.webkit.org/show_bug.cgi?id=49691
2328
2329         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2331
2332 2010-11-17  Adam Roben  <aroben@apple.com>
2333
2334         Move FindSafari's settings into a vsprops file
2335
2336         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
2337
2338         Reviewed by Steve Falkenburg.
2339
2340         * FindSafari/FindSafari.vcproj:
2341         * FindSafari/FindSafariCommon.vsprops: Added.
2342
2343 2010-11-17  Adam Roben  <aroben@apple.com>
2344
2345         Use a minimum font size of 0 in DRT on Windows
2346
2347         This is the Windows equivalent of r72164.
2348
2349         Rubber-stamped by Dave Hyatt.
2350
2351         * DumpRenderTree/win/DumpRenderTree.cpp:
2352         (resetDefaultsToConsistentValues):
2353
2354 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
2355
2356         Reviewed by Andreas Kling.
2357
2358         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
2359         https://bugs.webkit.org/show_bug.cgi?id=49639
2360
2361         * Scripts/webkitpy/common/checkout/scm.py:
2362
2363 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
2364
2365         Reviewed by Tony Chang.
2366
2367         Rebaseline server: add loupe for image diffs
2368         https://bugs.webkit.org/show_bug.cgi?id=49692
2369         
2370         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
2371         enlarged area of the expected, actual and diff images side by side.
2372
2373         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2374         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
2375         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2376         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2377
2378 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2379
2380         Reviewed by Adam Roben.
2381
2382         WebKitLauncherWin should use vsprops for shared build settings
2383         https://bugs.webkit.org/show_bug.cgi?id=49696
2384
2385         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2386         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
2387
2388 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2389
2390         Reviewed by Adam Roben.
2391
2392         WinLauncher should use vsprops for shared build settings
2393         https://bugs.webkit.org/show_bug.cgi?id=49695
2394
2395         * WinLauncher/WinLauncher.cpp:
2396         (_tWinMain):
2397         (PrintView):
2398         (WndProc):
2399         (MyEditProc):
2400         * WinLauncher/WinLauncher.vcproj:
2401         * WinLauncher/WinLauncherCommon.vsprops: Added.
2402
2403 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2404
2405         Delete unused file unintentionally added in last change.
2406
2407         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
2408
2409 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
2410
2411         Reviewed by Adam Roben.
2412
2413         DumpRenderTree on Windows should use a vsprops file for shared project settings
2414         https://bugs.webkit.org/show_bug.cgi?id=49690
2415
2416         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2417         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
2418         * DumpRenderTree/win/DumpRenderTree.vcproj:
2419         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
2420         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
2421         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
2422         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
2423         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
2424         * DumpRenderTree/win/ImageDiff.vcproj:
2425         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
2426
2427 2010-11-17  Hayato Ito  <hayato@chromium.org>
2428
2429         Refactor TestTypeBase.compare_output().
2430
2431         Introduce a TestOutput class and update compare_output() of each test
2432         types so that they can take both actual and expected TestOutput objects.
2433
2434         https://bugs.webkit.org/show_bug.cgi?id=49431
2435
2436         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2437         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
2438         * Scripts/webkitpy/layout_tests/port/base.py:
2439         * Scripts/webkitpy/layout_tests/port/chromium.py:
2440         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2441         * Scripts/webkitpy/layout_tests/port/test.py:
2442         * Scripts/webkitpy/layout_tests/port/webkit.py:
2443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2444         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2445         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2446         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2447
2448 2010-11-17  Adam Roben  <aroben@apple.com>
2449
2450         Make each Windows Test builder use the same OS for all its slaves
2451
2452         Currently each WebKit1 Windows Test builder has one Windows XP slave
2453         and one Windows 7 slave. Having different OSes in a single builder
2454         meant that the builders would alternate between red and green when
2455         there were OS-specific failures.
2456
2457         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
2458         between red and green because of multiple OS versions
2459
2460         Reviewed by Mark Rowe.
2461
2462         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
2463         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
2464         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
2465         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
2466         builders for the two WebKit1 builders so that they would all use the
2467         appropriate OS.
2468
2469 2010-11-17  James Robinson  <jamesr@chromium.org>
2470
2471         Reviewed by Dan Bernstein.
2472
2473         [chromium] Set minimum font size to 0 for DRT
2474         https://bugs.webkit.org/show_bug.cgi?id=49677
2475
2476         Followup for http://trac.webkit.org/changeset/72141.
2477
2478         Test: http/tests/misc/acid3.html
2479
2480         * DumpRenderTree/chromium/WebPreferences.cpp:
2481         (WebPreferences::reset):
2482
2483 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2484
2485         Unreviewed build fix.
2486
2487         [Qt] Add missing file I forgot in r72220.
2488
2489         * MiniBrowser/MiniBrowser.qrc: Added.
2490
2491 2010-11-17  Andras Becsi  <abecsi@webkit.org>
2492
2493         Reviewed by Andreas Kling.
2494
2495         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
2496         https://bugs.webkit.org/show_bug.cgi?id=49627
2497
2498         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
2499
2500         * MiniBrowser/MiniBrowser.qrc: Added.
2501         Add it here to prevent qmake from detecting it
2502         since it needs to be copied to the build directory.
2503         * MiniBrowser/qt/BrowserWindow.cpp:
2504         (BrowserWindow::BrowserWindow):
2505         (BrowserWindow::updateUserAgentList):
2506         (BrowserWindow::showUserAgentDialog):
2507         * MiniBrowser/qt/BrowserWindow.h:
2508         * MiniBrowser/qt/MiniBrowser.pro:
2509
2510 2010-11-17  Adam Roben  <aroben@apple.com>
2511
2512         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
2513
2514         We use that file on Windows!
2515
2516         Fixes <http://webkit.org/b/49643> Changes to
2517         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
2518
2519         Reviewed by Steve Falkenburg.
2520
2521         * Scripts/webkitpy/common/config/build.py:
2522         (_should_file_trigger_build): Added the mac-wk2 directory and make it
2523         trigger builds on SnowLeopard and Windows.
2524
2525         * Scripts/webkitpy/common/config/build_unittest.py:
2526         (ShouldBuildTest.test_should_build): Added a test.
2527
2528 2010-11-17  Satish Sampath  <satish@chromium.org>
2529
2530         Reviewed by Jeremy Orlow.
2531
2532         Clear the speech input mock explicitly before each test.
2533         https://bugs.webkit.org/show_bug.cgi?id=49660
2534
2535         * DumpRenderTree/chromium/LayoutTestController.cpp:
2536         (LayoutTestController::setMockSpeechInputResult):
2537         * DumpRenderTree/chromium/LayoutTestController.h:
2538         * DumpRenderTree/chromium/WebViewHost.cpp:
2539         (WebViewHost::speechInputController):
2540         (WebViewHost::reset): Invoke speech input mock's clearResults method.
2541         * DumpRenderTree/chromium/WebViewHost.h:
2542         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
2543
2544 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
2545
2546         Unreviewed, specify IRC nickname in committers.py.
2547
2548         * Scripts/webkitpy/common/config/committers.py:
2549
2550 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2551
2552         Reviewed by Tony Chang.
2553
2554         [NRWT] Make http locking similar to perl implementation
2555         https://bugs.webkit.org/show_bug.cgi?id=49187
2556
2557         * Scripts/webkitpy/common/system/file_lock.py: Added.
2558         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2559         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2560
2561 2010-11-17  MORITA Hajime  <morrita@google.com>
2562
2563         Reviewed by Kent Tamura.
2564
2565         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
2566         https://bugs.webkit.org/show_bug.cgi?id=49366
2567
2568         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
2569           according to the spellchecker suggestion
2570         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
2571
2572         test_expectations.txt will be changed after this change is ported to test_shell.
2573         
2574         * DumpRenderTree/chromium/EventSender.cpp:
2575         (makeMenuItemStringsFor):
2576         (EventSender::contextClick):
2577         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2578         (MockSpellCheck::fillSuggestionList):
2579         (MockSpellCheck::initializeIfNeeded):
2580         * DumpRenderTree/chromium/MockSpellCheck.h:
2581         * DumpRenderTree/chromium/WebViewHost.cpp:
2582         (WebViewHost::mockSpellCheck):
2583         * DumpRenderTree/chromium/WebViewHost.h:
2584
2585 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2586
2587         Reviewed by Sam Weinig.
2588
2589         Make sure the pref for minimum font size is just explicitly set to 0 every time,
2590         since the bots have 1 stuck in their plist otherwise.
2591
2592         * DumpRenderTree/mac/DumpRenderTree.mm:
2593         (resetDefaultsToConsistentValues):
2594
2595 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2596
2597         Reviewed by Tony Chang.
2598
2599         Rebaseline server: compute diffs client-side
2600         https://bugs.webkit.org/show_bug.cgi?id=49640
2601         
2602         The image diff output from the DRT is pretty bad on some ports (at
2603         least the Mac one), so it's better to compute diffs on the client by
2604         using <canvas>.
2605
2606         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2607         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2608         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2609
2610 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
2611
2612         Reviewed by Tony Chang.
2613
2614         Rebaseline server: display test results
2615         https://bugs.webkit.org/show_bug.cgi?id=49626
2616         
2617         Adds basic result display to the rebaseline server. On the Python side
2618         this involves:
2619         - Parsing the unexpected_results.json into a dictionary.
2620         - Serving it as JSON under /results.json.
2621         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2622         but I'll need to have access to the parsed results on the Python side
2623         for follow-up changes).
2624         
2625         On the web UI side this adds:
2626         - Markup for display image and text results (expected, actual, diff),
2627           and JS for populating it.
2628         - Markup for breaking down test results by failure type and directory,
2629           and JS for populating it.
2630
2631         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2632         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2633         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2634         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2635         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2636
2637 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2638
2639         Reviewed by Ojan Vafai.
2640
2641         See Chromium issue http://codereview.chromium.org/5133001/ - we
2642         are modifying the build bots to pass in the builder name with
2643         the "GPU" string appended instead of appending it in the code.
2644
2645         https://bugs.webkit.org/show_bug.cgi?id=49636
2646
2647         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2648
2649 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2650
2651         Reviewed by Adam Roben.
2652
2653         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2654         https://bugs.webkit.org/show_bug.cgi?id=49632
2655
2656         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2657         * DumpRenderTree/win/DumpRenderTree.vcproj:
2658         * DumpRenderTree/win/ImageDiff.vcproj:
2659         * MiniBrowser/MiniBrowser.vcproj:
2660         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2661         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2662         * WebKitTestRunner/win/InjectedBundle.vcproj:
2663         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2664         * WinLauncher/WinLauncher.vcproj:
2665         * record-memory-win/record-memory-win.vcproj:
2666
2667 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2668
2669         Reviewed by Ojan Vafai.
2670
2671         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2672
2673         Rename the TestInfo class to TestInput to be clearer about its
2674         function, and move the checksum-reading code into dump_render_tree_thread
2675         to avoid cross-thread access.
2676
2677         https://bugs.webkit.org/show_bug.cgi?id=49573
2678
2679         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2680         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2681         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2682
2683 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2684
2685         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2686
2687         * DumpRenderTree/mac/DumpRenderTree.mm:
2688         (resetDefaultsToConsistentValues):
2689
2690 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2691
2692         Reviewed by Geoff Garen.
2693
2694         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2695
2696         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2697         for every WebView, and the WebKit API doesn't support that ownership model.
2698
2699         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2700
2701         * DumpRenderTree/mac/DumpRenderTree.mm:
2702         (createWebViewAndOffscreenWindow):
2703         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2704         (LayoutTestController::setMockDeviceOrientation):
2705
2706 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2707
2708         Reviewed by Ojan Vafai.
2709
2710         new-run-webkit-tests: log the process id in --verbose mode
2711
2712         As part of the switch to multi-process mode, we should log the
2713         process id when running w/ --verbose.
2714
2715         https://bugs.webkit.org/show_bug.cgi?id=49571
2716
2717         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2718
2719 2010-11-16  Adam Roben  <aroben@apple.com>
2720
2721         Only trigger Windows builds when files that we actually use on Windows
2722         are changed
2723
2724         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2725         It uses the new webkitpy.common.config.build module to determine
2726         whether a particular change should trigger a build on a particular
2727         platform. The Windows builders have been switched to use a
2728         PlatformSpecificScheduler.
2729
2730         The logic to determine whether or not a particular change should
2731         trigger a build on a given platform has only been implemented/tested
2732         for Windows. I tried to make it easy to add more platforms in the
2733         future, but I don't have enough familiarity with all platforms to be
2734         able to implement it for them.
2735
2736         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2737         lots irrelevant changes (e.g., rebaselining Chromium test results)
2738
2739         Reviewed by Eric Seidel.
2740
2741         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2742         PlatformSpecificScheduler for the Windows builders.
2743
2744         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2745         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2746         up a ChangeFilter that filters to our branch and will call through to
2747         our filter method, and calls up to our base class.
2748         (PlatformSpecificScheduler.filter): Calls through to
2749         build.should_build to find out whether we should trigger a build for
2750         this change.
2751
2752         * Scripts/webkitpy/common/net/build.py: Added.
2753         (_should_file_trigger_build): Uses a set of directories and regexp
2754         patterns to determine whether the given file should trigger a build on
2755         the given platform. As mentioned earlier, this has only been
2756         implemented for Windows, though I did try to make some guesses about
2757         other platforms.
2758         (should_build): Returns true if any of the files should trigger a
2759         build on the given platform.
2760
2761         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2762         (ShouldBuildTest.test_should_build): Does some basic testing to make
2763         sure we're triggering builds for the right files. It only tests
2764         Windows for now, though I tried to make some guesses about other
2765         platforms.
2766
2767 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2768
2769         Reviewed by Andreas Kling.
2770
2771         [Qt] Remove synchronous QWebPage::checkPermissions signal
2772         https://bugs.webkit.org/show_bug.cgi?id=46810
2773
2774         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2775         (WebCore::WebPage::WebPage):
2776         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2777         (LayoutTestController::grantDesktopNotificationPermission): When granting
2778         permission, grant it directly on the QWebPage/Frame, that will remember it.
2779         * QtTestBrowser/webpage.cpp:
2780         (WebPage::WebPage):
2781         * QtTestBrowser/webpage.h:
2782
2783
2784 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2785
2786         Reviewed by Csaba Osztrogonác.
2787
2788         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2789
2790         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2791         (LayoutTestController::reset):
2792         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2793         (LayoutTestController::isPrinting):
2794         (LayoutTestController::setPrinting):
2795
2796 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2797
2798         Reviewed by Andreas Kling.
2799
2800         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2801         https://bugs.webkit.org/show_bug.cgi?id=49587
2802
2803         * MiniBrowser/qt/BrowserView.cpp:
2804         (BrowserView::BrowserView): Added BackingStoreType
2805         argument to ctor. Propagating it to the QGraphicsWKView.
2806         * MiniBrowser/qt/BrowserView.h:
2807         * MiniBrowser/qt/BrowserWindow.cpp:
2808         (BrowserWindow::BrowserWindow):
2809         (BrowserWindow::newWindow): Create the new BrowserWindow
2810         with the same BackingStoreType that this instance has.
2811         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2812         * MiniBrowser/qt/main.cpp:
2813         (main): Use tiled backing store if got -tiled command line argument.
2814         Avoid redundant copy of command line args.
2815
2816 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2817
2818         Reviewed by Jeremy Orlow.
2819
2820         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2821         https://bugs.webkit.org/show_bug.cgi?id=48506
2822
2823         This ensures that there is one mock per page WebView / WebViewHost. This is a
2824         design constraint of the DeviceOrientationClientMock because the m_controller
2825         field can only store a pointer to a single instance of the corresponding
2826         DeviceOrientationController.
2827
2828         Test: fast/dom/DeviceOrientation/no-page-cache.html
2829
2830         * DumpRenderTree/chromium/LayoutTestController.cpp:
2831         (LayoutTestController::setMockDeviceOrientation):
2832         (LayoutTestController::deviceOrientationClientMock):
2833         * DumpRenderTree/chromium/LayoutTestController.h:
2834         * DumpRenderTree/chromium/WebViewHost.cpp:
2835         (WebViewHost::deviceOrientationClientMock):
2836         (WebViewHost::deviceOrientationClient):
2837         (WebViewHost::reset):
2838         * DumpRenderTree/chromium/WebViewHost.h:
2839
2840 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2841
2842         Reviewed by Andreas Kling.
2843
2844         [Qt][WK2] Avoid polling in WebKitTestRunner.
2845         https://bugs.webkit.org/show_bug.cgi?id=49542
2846
2847         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2848         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2849
2850         * WebKitTestRunner/TestController.cpp:
2851         (WTR::TestController::didFinishLoadForFrame):
2852         * WebKitTestRunner/TestController.h:
2853         * WebKitTestRunner/TestInvocation.cpp:
2854         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2855         * WebKitTestRunner/mac/TestControllerMac.mm:
2856         (WTR::TestController::notifyDone): Add method stub.
2857         * WebKitTestRunner/qt/TestControllerQt.cpp:
2858         (WTR::TestControllerRunLoop::instance):
2859         (WTR::TestControllerRunLoop::start):
2860         (WTR::TestControllerRunLoop::stop):
2861         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2862         (WTR::TestControllerRunLoop::timerEvent):
2863         (WTR::TestController::notifyDone):
2864         (WTR::TestController::platformRunUntil):
2865         * WebKitTestRunner/win/TestControllerWin.cpp:
2866         (WTR::TestController::notifyDone): Add method stub.
2867
2868 2010-11-15  Darin Adler  <darin@apple.com>
2869
2870         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2871
2872 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2873
2874         Reviewed by Andreas Kling.
2875
2876         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2877         https://bugs.webkit.org/show_bug.cgi?id=49544
2878
2879         Add the shortcut to BrowserWindow.
2880
2881         * MiniBrowser/qt/BrowserWindow.cpp:
2882         (BrowserWindow::BrowserWindow):
2883         (BrowserWindow::openLocation):
2884         * MiniBrowser/qt/BrowserWindow.h:
2885
2886 2010-11-14  David Levin  <levin@chromium.org>
2887
2888         Reviewed by Daniel Bates.
2889
2890         check-webkit-style should detect PassRefPtr usage in functions.
2891         https://bugs.webkit.org/show_bug.cgi?id=49513
2892
2893         * Scripts/webkitpy/style/checkers/cpp.py:
2894         (check_for_function_lengths): Revert a comment change that I
2895          accidentally made in r71986.
2896         (check_pass_ptr_usage): Added the code to do the check.
2897         (process_line): Added the call to check_pass_ptr_usage.
2898         (CppChecker): Added the new error category.
2899         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2900         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2901          testing purposes.
2902         (PassPtrTest::*): The class/functions to unit test the new
2903          functionality.
2904
2905 2010-11-14  David Levin  <levin@chromium.org>
2906
2907         Reviewed by Shinichiro Hamaji.
2908
2909         check-webkit-style function detection and the line count style checks should be separate.
2910         https://bugs.webkit.org/show_bug.cgi?id=49512
2911
2912         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2913         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2914           call the detection function and fix line counts in two places now that
2915           the code really only counts the lines in the body of the function.
2916
2917 2010-11-14  Andreas Kling  <kling@webkit.org>
2918
2919         Reviewed by Antonio Gomes.
2920
2921         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2922         https://bugs.webkit.org/show_bug.cgi?id=33438
2923
2924         Stifle "Unhandled variable" warning to match what the other
2925         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2926         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2927
2928         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2929         (webkit_test_plugin_get_value):
2930
2931 2010-11-13  David Levin  <levin@chromium.org>
2932
2933         Reviewed by Eric Seidel.
2934
2935         check-webkit-style function detection crashes on functions in templates.
2936         https://bugs.webkit.org/show_bug.cgi?id=49504
2937
2938         For example "template <bool shouldClose(const Element*)>".
2939
2940         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2941         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2942           function detection test to expose this issue.
2943
2944 2010-11-12  David Levin  <levin@chromium.org>
2945
2946         Reviewed by Shinichiro Hamaji.
2947
2948         check-webkit-style function detection doesn't detect indented functions declaractions.
2949         https://bugs.webkit.org/show_bug.cgi?id=49446
2950
2951         Indented function declarations occur inside class definitions, so
2952         they are a pretty common (and worth detecting).
2953
2954         * Scripts/webkitpy/style/checkers/cpp.py:
2955           Changed regex to allow indentation.
2956           Changed the function start detection to only happen when not in a
2957           function.
2958           Changed function end detection to work based on matching braces
2959           instead of finding a close brace at the beginning of the line.
2960           Fixed close_expression to do what it says when it doesn't find
2961           the close.
2962         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2963
2964 2010-11-12  Daniel Bates  <dbates@rim.com>
2965
2966         Rubber-stamped by Nikolas Zimmermann.
2967
2968         Make do-file-rename rename files in the directory WebKit2.
2969
2970         This also makes the list of searched directories in do-file-rename
2971         consistent with the list of searched directories in the script do-webcore-rename.
2972
2973         * Scripts/do-file-rename:
2974
2975 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2976
2977         Reviewed by James Robinson.
2978
2979         Attempt yet again to land the fix for bug 49360 (respecting
2980         set-webkit-configuration). We need to handle the cases where
2981         trying to run webkit-build-directory to find out where the
2982         default configuration might be fails (that shows up on some
2983         Chromium bots that apparently don't have perl installed).
2984
2985         https://bugs.webkit.org/show_bug.cgi?id=49360
2986
2987         * Scripts/webkitpy/layout_tests/port/config.py:
2988         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2989         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2990
2991 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2992
2993         Reviewed by Adam Barth.
2994
2995         webkit-patch land logs commit message twice
2996         https://bugs.webkit.org/show_bug.cgi?id=49482
2997         
2998         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2999         that's just the commit message, which we now output following the
3000         actual commit.
3001
3002         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3003
3004 2010-11-12  Tony Chang  <tony@chromium.org>
3005
3006         Reviewed by Adam Barth.
3007
3008         run platform/chromium/plugins/script-object-invoke.html on all platforms
3009         https://bugs.webkit.org/show_bug.cgi?id=49280
3010
3011         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3012         (testScriptObjectInvoke):
3013         (pluginInvoke):
3014
3015 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3016
3017         Reviewed by Adam Barth.
3018
3019         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
3020         https://bugs.webkit.org/show_bug.cgi?id=49471
3021
3022         Right now there's no indication of a successful commit.
3023         
3024         * Scripts/webkitpy/tool/commands/download_unittest.py:
3025         * Scripts/webkitpy/tool/steps/commit.py:
3026
3027 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
3028
3029         Reviewed by Ojan Vafai.
3030
3031         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
3032         https://bugs.webkit.org/show_bug.cgi?id=49354
3033
3034         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
3035
3036         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3037         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3038         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3039         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3040
3041 2010-11-12  Tony Chang  <tony@chromium.org>
3042
3043         Reviewed by Kent Tamura.
3044
3045         [chromium] Load a blank page when closing DRT WebViewHosts
3046         https://bugs.webkit.org/show_bug.cgi?id=49417
3047
3048         In test_shell, when we close a window, we first load about:blank
3049         and run GC to fire the destruction logic of the page.  In test_shell,
3050         this happens in ~TestShell.  In DRT, we manage virtual windows as
3051         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
3052
3053         Managing focus is a bit trickier, since normally you would get window
3054         events to reset the focus to the right window.  We do it manually
3055         instead.
3056
3057         This fixes 2 plugin tests on DRT.
3058
3059         * DumpRenderTree/chromium/TestShell.cpp:
3060         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
3061         (TestShell::closeWindow): Move widget close() to WVH destructor and
3062             manage focus manually.
3063         (TestShell::closeRemainingWindows): Comment typo.
3064         * DumpRenderTree/chromium/WebViewHost.cpp:
3065         (WebViewHost::closeWidget):
3066         (invokeCloseWidget):
3067         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
3068             test_shell).
3069         (WebViewHost::~WebViewHost):
3070         * DumpRenderTree/chromium/WebViewHost.h:
3071
3072 2010-11-12  David Levin  <levin@chromium.org>
3073
3074         Reviewed by Adam Barth.
3075
3076         cpp.py needs some tidying.
3077         https://bugs.webkit.org/show_bug.cgi?id=49443
3078
3079         * Scripts/webkitpy/style/checkers/cpp.py:
3080           Fix parameter ordering for iteratively_replace_matches_with_char
3081           to mirror other similar functions (and improved comments, etc.)
3082           Also, use a python-ism (for/else) to get rid of a variable that
3083           was there to determine if something had been found in the loop.
3084
3085 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
3086
3087         Reviewed by James Robinson.
3088
3089         [Chromium/DRT] Make EventSendingController send complete touch events.
3090         https://bugs.webkit.org/show_bug.cgi?id=49285
3091
3092         * DumpRenderTree/chromium/EventSender.cpp:
3093         (EventSender::addTouchPoint):
3094         (EventSender::updateTouchPoint):
3095         (EventSender::sendCurrentTouchEvent):
3096
3097 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
3098
3099         Unreviewed rollout of r71858.
3100
3101         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
3102         NaCl tests.
3103
3104         * Scripts/webkitpy/layout_tests/port/config.py:
3105         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
3106         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3107
3108 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
3109
3110         Reviewed by Kenneth Rohde Christiansen.
3111
3112         [Qt] TestController::runUntil doesn't honor the timeout parameter
3113         https://bugs.webkit.org/show_bug.cgi?id=48941
3114
3115         Implement the missing timeout of WebKitTestRunner for Qt.
3116
3117         A QElapsedTimer has been added to RunUntilConditionLoop in order
3118         to measure how long the loop has been running. When the timer
3119         is bigger or equal than the timeout, the loop ends even if the
3120         condition is not met.
3121
3122         * WebKitTestRunner/qt/TestControllerQt.cpp:
3123         (WTR::RunUntilConditionLoop::start):
3124         (WTR::RunUntilConditionLoop::run):
3125         (WTR::RunUntilConditionLoop::timerEvent):
3126         (WTR::TestController::platformRunUntil):
3127
3128 2010-11-11  David Levin  <levin@chromium.org>
3129
3130         Reviewed by Shinichiro Hamaji.
3131
3132         check-webkit-style function detection doesn't handle templates with spaces.
3133         https://bugs.webkit.org/show_bug.cgi?id=49427
3134
3135         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
3136           finding the function name.
3137         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
3138           template with a space.
3139
3140 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3141
3142         Reviewed by Shinichiro Hamaji.
3143
3144         Enable check-webkit-style on Qt files
3145         https://bugs.webkit.org/show_bug.cgi?id=48322
3146
3147         Adding exception for _q_... private slots and
3148         ..._data() methods in tests
3149
3150         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
3151         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
3152
3153 2010-11-11  David Levin  <levin@chromium.org>
3154
3155         Reviewed by Shinichiro Hamaji.
3156
3157         check-webkit-style function detection doesn't work for templates and destructors.
3158         https://bugs.webkit.org/show_bug.cgi?id=49425
3159
3160         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
3161         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
3162
3163 2010-11-11  Joone Hur  <joone@kldp.org>
3164
3165         Reviewed by Antonio Gomes.
3166
3167         [GTK][DRT] Implement LayoutTestController::nodesFromRect
3168         https://bugs.webkit.org/show_bug.cgi?id=46598
3169
3170         Support nodesFromRect in DRT
3171
3172         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3173         (LayoutTestController::nodesFromRect):
3174
3175 2010-11-11  MORITA Hajime  <morrita@google.com>
3176
3177         Reviewed by Kent Tamura.
3178
3179         editing/selection/context-menu-on-text.html fails on chromium
3180         https://bugs.webkit.org/show_bug.cgi?id=45898
3181
3182         Enhance Chromium's EventSender::contextClick() to return
3183         array of menu strings. The implementation incomplete because
3184         Although actual context menu is implemented by the browser,
3185         it reflects editability of underlying context thus makes
3186         context-menu-on-text.html passed.
3187         
3188         * DumpRenderTree/chromium/EventSender.cpp:
3189         (makeMenuItemStringsFor): Added.
3190         (EventSender::contextClick): Now returns array of menu strings.
3191         * DumpRenderTree/chromium/WebViewHost.cpp:
3192         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
3193         (WebViewHost::clearContextMenuData): Added.
3194         (WebViewHost::lastContextMenuData): Added.
3195         * DumpRenderTree/chromium/WebViewHost.h:
3196
3197 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3198
3199         Unreviewed, build fix.
3200
3201         fix build breakage caused by fix for bug 49380 (r71858).
3202
3203         config_standalone needs to ensure that the packages it needs are
3204         in sys.path.
3205
3206         https://bugs.webkit.org/show_bug.cgi?id=49419
3207
3208         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3209
3210 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3211
3212         Reviewed by Adam Roben.
3213
3214         Fix NRWT to respect set-webkit-configuration again :(
3215
3216         This change fixes a typo in config.py that was causing the wrong
3217         value to be read initially and us never actually looking into
3218         the filesystem to get the default configuration.
3219         
3220         * Scripts/webkitpy/layout_tests/port/config.py:
3221         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3222         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3223
3224 2010-11-11  Eric Seidel  <eric@webkit.org>
3225
3226         Reviewed by Adam Barth.
3227
3228         Split out Bug, Attachment and CommitterValidator from bugzilla.py
3229         https://bugs.webkit.org/show_bug.cgi?id=49403
3230
3231         CommitterValidator really had nothing to do with bugzilla.py.
3232         I've put it next to committers.py for now since its rather tied to that file.
3233
3234         * Scripts/webkitpy/common/config/committervalidator.py: Added.
3235         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
3236         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
3237         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
3238         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
3239         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
3240         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3241         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3242         * Scripts/webkitpy/tool/bot/feeders.py:
3243         * Scripts/webkitpy/tool/commands/queues.py:
3244
3245 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
3246
3247         Reviewed by Eric Seidel.
3248
3249         fix missing 'pid' argument for http lockfile checking on win32
3250         https://bugs.webkit.org/show_bug.cgi?id=49363
3251
3252         * Scripts/webkitpy/common/system/executive.py:
3253
3254 2010-11-11  Eric Seidel  <eric@webkit.org>
3255
3256         Rubber-stamped by Adam Barth.
3257
3258         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
3259         https://bugs.webkit.org/show_bug.cgi?id=49402
3260
3261         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
3262         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
3263         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
3264
3265 2010-11-10  Chris Guillory  <chris.guillory@google.com>
3266
3267         Reviewed by Chris Fleizach.
3268
3269         Use IAccessibleComparable to compare accessibility objects.
3270         https://bugs.webkit.org/show_bug.cgi?id=49118
3271
3272         * DumpRenderTree/AccessibilityUIElement.cpp:
3273         (AccessibilityUIElement::isEqual):
3274         * DumpRenderTree/AccessibilityUIElement.h:
3275         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3276         (comparableObject):
3277         (AccessibilityUIElement::isEqual):
3278
3279 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
3280
3281         Reviewed by David Hyatt.
3282
3283         HTML5 Ruby support should be mandatory feature
3284         https://bugs.webkit.org/show_bug.cgi?id=49272
3285
3286         Remove Ruby as optional feature.
3287
3288         * Scripts/build-webkit:
3289
3290 2010-11-10  Adam Roben  <aroben@apple.com>
3291
3292         Print VC++ Express build logs in the same order that the projects are
3293         built
3294
3295         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
3296         in an unhelpful order
3297
3298         Reviewed by Eric Seidel.
3299
3300         * Scripts/print-vse-failure-logs:
3301         (PrintVisualStudioExpressLogs._build_order): Added. Uses
3302         print-msvc-project-dependencies to figure out the order in which
3303         projects are built.
3304         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
3305         based on their build order and project name.
3306         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
3307         scripts directory from here...
3308         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
3309         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
3310         them.
3311
3312 2010-11-10  Adam Roben  <aroben@apple.com>
3313
3314         Only print the interesting text from VC++ Express build logs
3315
3316         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
3317         output from print-vse-failure-logs
3318
3319         Reviewed by Eric Seidel.
3320
3321         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
3322         added newly-required imports. Removed a comment that was essentially a
3323         FIXME, and is now fixed.
3324         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
3325         BeautifulSoup to extract the relevant text from the build log.
3326         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
3327
3328 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
3329
3330         Reviewed by Tony Chang.
3331
3332         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
3333         https://bugs.webkit.org/show_bug.cgi?id=49286
3334         
3335         The tests in http/tests/security/XFrameOptions started to fail after
3336         r71297, since it changed the WebViewHost::assignIdentifierToRequest
3337         logic to always assign identifiers to requests, even if we're not going
3338         to be dumping resource load callbacks at that point. These tests
3339         only call LayoutTestController.dumpResourceLoadCallbacks after the
3340         request is started, thus their expectations have "<unknown>" as the
3341         identifier. Change WebViewHost to the previous behavior, which also
3342         match the other ports'.
3343
3344         * DumpRenderTree/chromium/WebViewHost.cpp:
3345         (WebViewHost::assignIdentifierToRequest):
3346         (WebViewHost::removeIdentifierForRequest):
3347
3348 2010-11-08  Tony Chang  <tony@chromium.org>
3349
3350         Reviewed by Adam Barth.
3351
3352         run platform/chromium/plugins/return-npobject.html on all platforms
3353         https://bugs.webkit.org/show_bug.cgi?id=49103
3354
3355         This tests that we can get an NPObject returned through a method on
3356         an NPAPI Object.
3357
3358         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3359         (testCallbackReturn):
3360         (pluginInvoke):
3361
3362 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3363
3364         Unreviewed, rolling out r71672.
3365         http://trac.webkit.org/changeset/71672
3366         https://bugs.webkit.org/show_bug.cgi?id=49276
3367
3368         It doesn't work on Chromium Windows bot (Requested by Ossy on
3369         #webkit).
3370
3371         * Scripts/webkitpy/common/system/file_lock.py: Removed.
3372         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
3373         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3374
3375 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3376
3377         Reviewed by Tony Chang.
3378
3379         [NRWT] Make http locking similar to perl implementation
3380         https://bugs.webkit.org/show_bug.cgi?id=49187
3381
3382         * Scripts/webkitpy/common/system/file_lock.py: Added.
3383         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
3384         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3385
3386 2010-11-09  James Kozianski  <koz@chromium.org>
3387
3388         Reviewed by Eric Seidel.
3389
3390         Clean up imports for webkit-patch.
3391         https://bugs.webkit.org/show_bug.cgi?id=49083
3392
3393         Move some imports from commands into main.py where they are used.
3394         Move command imports into the __init__ of the commands module.
3395
3396         * Scripts/webkitpy/tool/commands/__init__.py:
3397         * Scripts/webkitpy/tool/commands/download.py:
3398         * Scripts/webkitpy/tool/commands/queues.py:
3399         * Scripts/webkitpy/tool/main.py:
3400
3401 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
3402
3403         Reviewed by Andreas Kling.
3404
3405         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
3406         https://bugs.webkit.org/show_bug.cgi?id=49047
3407
3408         * QtTestBrowser/mainwindow.cpp:
3409         (MainWindow::setAddressUrl):
3410
3411 2010-11-09  Andras Becsi  <abecsi@webkit.org>
3412
3413         Reviewed by Csaba Osztrogonác.
3414
3415         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
3416         https://bugs.webkit.org/show_bug.cgi?id=49252
3417
3418         * Scripts/old-run-webkit-tests:
3419
3420 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
3421
3422         Reviewed by Tor Arne Vestbø.
3423
3424         Output of old-run-webkit-tests is buggy in verbose mode
3425         https://bugs.webkit.org/show_bug.cgi?id=49249
3426
3427         * Scripts/old-run-webkit-tests: Redundant outputs removed.
3428
3429 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3430
3431         Reviewed by Martin Robinson.
3432
3433         [GTK] Link with target name set does not work
3434         https://bugs.webkit.org/show_bug.cgi?id=48865
3435
3436         When a new page is created with a name (target=myFrame), the new
3437         mainFrame could not be found because they where not stored in the
3438         same PageGroup. As PageGroup are not exposed externally so the
3439         simpliest solution is to use a global page group name. This also fixes
3440         issue with visited link coloration across pages. After this change the
3441         private function webkit_web_view_set_group_name() was no longer used
3442         so it was removed completly.
3443
3444         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3445         (createWebView):
3446
3447 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
3448
3449         Reviewed by Kent Tamura.
3450
3451         WebViewHost::reset() uses placement new.
3452         https://bugs.webkit.org/show_bug.cgi?id=49069
3453
3454         WebViewHost is using placement destruction / new to simulate a fresh
3455         WebViewHost object at the same address. This is because the WebView remains
3456         open across tests and maintains a pointer to the WebViewHost.
3457         This change resets member variables explictly instead of the placement new dance.
3458
3459         * DumpRenderTree/chromium/WebViewHost.cpp:
3460         (WebViewHost::WebViewHost):
3461         (WebViewHost::reset):
3462
3463 2010-11-08  Dirk Pranke <dpranke@chromium.org>
3464
3465         Reviewed by Eric Seidel.
3466
3467         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
3468         It turns out that NRWT can't use the code in scm.find_checkout_root()
3469         because the Chromium bots don't do full checkouts of the WebKit
3470         tree; they only check out subdirectories like WebKitTools/Scripts.
3471         Until we can figure out a better approach for this, I've
3472         restored the base_dir-detecting code from NRWT, which works in
3473         any directory tree, scm or no.
3474
3475         This also restores the files modified in r71475 and r71474.
3476
3477         https://bugs.webkit.org/show_bug.cgi?id=49151
3478
3479         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
3480         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
3481
3482 2010-11-08  Eric Seidel  <eric@webkit.org>
3483
3484         Reviewed by Adam Barth.
3485
3486         webkit-patch failure-reason explodes if a build is missing
3487         https://bugs.webkit.org/show_bug.cgi?id=49195
3488
3489         This is likely a recent regression.  Adding a unit test for this case.
3490
3491         * Scripts/webkitpy/common/net/buildbot.py:
3492         * Scripts/webkitpy/common/net/buildbot_unittest.py:
3493
3494 2010-11-08  Dan Bernstein  <mitz@apple.com>
3495
3496         Reviewed by Darin Adler.
3497
3498         Ignore the system scrollbar setting.
3499
3500         * DumpRenderTree/mac/DumpRenderTree.mm:
3501         (resetDefaultsToConsistentValues): Set the scrollbar default.
3502
3503 2010-11-05  Adam Roben  <aroben@apple.com>
3504
3505         Make webkitpy.common.system.executive_unittest pass when running under
3506         Win32 Python
3507
3508         Fixes <http://webkit.org/b/49033>.
3509
3510         Reviewed by Dave Levin and Eric Seidel.
3511
3512         * Scripts/webkitpy/common/system/executive.py:
3513         (Executive._run_command_with_teed_output): Pass the arguments through
3514         encode_argument_if_needed rather than using Cygwin-specific code here.
3515         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
3516         the output.
3517         (Executive.run_command): Use encode_argument_if_needed to encode the
3518         arguments and child_process_encoding to decode the output.
3519         (Executive._child_process_encoding): Returns the encoding that should be
3520         used when communicating with child processes. On Windows we use mbcs,
3521         which maps to the current code page. On all other platforms we use
3522         UTF-8.
3523         (Executive._should_encode_child_process_arguments): Returns True if
3524         arguments to child processes need to be encoded. This is currently
3525         only needed on Cygwin and Win32 Python 2.x.
3526         (Executive._encode_argument_if_needed): Encode the argument using
3527         child_process_encoding if we need to encode arguments to child
3528         processes on this platform.
3529
3530         * Scripts/webkitpy/common/system/executive_unittest.py:
3531         (never_ending_command): Added. Returns arguments to run a command that
3532         will not quit until we kill it. On Windows we use wmic, on other
3533         platforms we use yes.
3534         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
3535         mbcs encoding to be used and for output from the child processes to
3536         have been roundtripped through encode/decode on Win32 Python. When
3537         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
3538         it's possible that some characters will not be able to be converted
3539         and will be replaced by question marks; the round-tripping allows us
3540         to expect this result.
3541
3542         (ExecutiveTest.test_kill_process):
3543         (ExecutiveTest.test_kill_all):
3544         Use never_ending_command instead of invoking "yes" directly. Expect an
3545         exit code of 1 when using Win32 Python, as that's what seems to happen.
3546
3547 2010-11-08  Adam Roben  <aroben@apple.com>
3548
3549         Roll out r71532
3550
3551         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
3552         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
3553
3554         * Scripts/webkitdirs.pm:
3555
3556 2010-11-08  Tony Chang  <tony@chromium.org>
3557
3558         Reviewed by Adam Barth.
3559
3560         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
3561         https://bugs.webkit.org/show_bug.cgi?id=49094
3562
3563         This tests that objects created by plugins are proplery cleaned up.
3564
3565         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3566         (testPassTestObject):
3567         (pluginInvoke):
3568         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3569         (testAllocate):
3570         (testDeallocate):
3571         (testGetProperty):
3572         (testConstruct):
3573
3574 2010-11-08  Adam Roben  <aroben@apple.com>
3575
3576         Mark Windows builds triggered from Perl as being non-interactive
3577
3578         This affects whether some of our scripts will show alerts vs. printing
3579         to the build log.
3580
3581         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
3582         .vsprops files are updated
3583
3584         Reviewed by Steve Falkenburg.
3585
3586         * Scripts/webkitdirs.pm:
3587         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
3588
3589 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3590
3591         Reviewed by Ojan Vafai.
3592
3593         Make http locking default in NRWT.
3594         https://bugs.webkit.org/show_bug.cgi?id=48053
3595