2010-08-10 Victor Wang <victorw@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-08-10  Victor Wang  <victorw@chromium.org>
2
3         Reviewed by Ojan Vafai.
4
5         Update test results server merge logic so the aggregated
6         results and times are updated for tests that are
7         in aggragated json but not in incremental json.
8
9         Also update unittest to test this case.
10
11         https://bugs.webkit.org/show_bug.cgi?id=43769
12
13         * TestResultServer/model/jsonresults.py:
14         * TestResultServer/model/jsonresults_unittest.py:
15
16 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
17
18         Reviewed by Ariya Hidayat.
19
20         [Qt] QtTestBrowser: proper set scene rect
21
22         When resizesToContents is ON scene's rect is set to the boundary of
23         the mainFrame. However, navigating to other web page should keep resizing
24         scene's rect according to the new document loaded. Patch addresses this issue.
25
26         Now resizesToContents and scrolling properly work on QtTestBrowser.
27
28         * QtTestBrowser/webview.cpp:
29         (WebViewGraphicsBased::setPage):
30         (WebViewGraphicsBased::contentsSizeChanged):
31         (WebViewGraphicsBased::setResizesToContents):
32         (WebViewGraphicsBased::resizeEvent):
33         * QtTestBrowser/webview.h:
34
35 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
36
37         Reviewed by Ariya Hidayat.
38
39         [Qt] QtTestBrowser: Clean up LauncherWindow code.
40
41         * QtTestBrowser/launcherwindow.cpp:
42         (LauncherWindow::LauncherWindow): Moves applyPrefs methods call from the constructor to init().
43         (LauncherWindow::init): Fixed comments.
44         (LauncherWindow::applyPrefs): Move the method around.
45         (LauncherWindow::createChrome): Move more code of this method around, for grouping, and fixing up comments.
46
47 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
48
49         Reviewed by Ariya Hidayat.
50
51         [Qt] QtTestBrowser: make reset-zooming to animate when tiled backing store is on.
52
53         It gets control+0 the same visual effect as control++ or control-.
54
55         * QtTestBrowser/launcherwindow.cpp:
56         (LauncherWindow::toggleZoomTextOnly):
57
58 2010-08-09  Antonio Gomes  <tonikitoo@webkit.org>
59
60         Reviewed by Ariya Hidayat.
61
62         [Qt] QtTestBrowser:: make m_zoomLevels a static member.
63
64         Not all instances of LauncherWindow need its own m_zoomLevel.
65
66         * QtTestBrowser/launcherwindow.cpp:
67         * QtTestBrowser/launcherwindow.h:
68
69 2010-08-09  Sam Weinig  <sam@webkit.org>
70
71         Reviewed by Geoffrey Garen.
72
73         Add zoom support for injected bundle
74         https://bugs.webkit.org/show_bug.cgi?id=43759
75
76         Use zoom factor SPI to implement zoom related eventSender functions.
77
78         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
79         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
80         (WTR::EventSendingController::textZoomIn):
81         (WTR::EventSendingController::textZoomOut):
82         (WTR::EventSendingController::zoomPageIn):
83         (WTR::EventSendingController::zoomPageOut):
84         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
85         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
86         (WTR::InjectedBundlePage::reset): Reset zoom mode and level for each test.
87
88 2010-08-09  Gavin Barraclough  <barraclough@apple.com>
89
90         Speculative chromium build fix III.
91
92         * DumpRenderTree/chromium/MockSpellCheck.h:
93         * DumpRenderTree/chromium/NotificationPresenter.h:
94         * DumpRenderTree/chromium/WebViewHost.h:
95         (WebViewHost::addClearHeader):
96         (WebViewHost::clearHeaders):
97
98 2010-08-09  Ojan Vafai  <ojan@chromium.org>
99
100         Reviewed by Tony Chang.
101
102         increase the number of test results that we save
103         https://bugs.webkit.org/show_bug.cgi?id=43763
104
105         Now that we do incremental uploads, we can increase the number of
106         results that we save for http://test-results.appspot.com/dashboards/flakiness_dashboard.html.
107
108         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
109
110 2010-08-09  Evan Martin  <evan@chromium.org>
111
112         Reviewed by Tony Chang.
113
114         [chromium] DRT error print statement incorrectly tries to print a FILE*
115         https://bugs.webkit.org/show_bug.cgi?id=43747
116
117         * DumpRenderTree/chromium/ImageDiff.cpp:
118         (writeFile): pass the correct pointer.
119
120 2010-08-09  Victor Wang  <victorw@chromium.org>
121
122         Reviewed by Ojan Vafai.
123
124         Upload incremental test results json to server by default.
125
126         https://bugs.webkit.org/show_bug.cgi?id=43743
127
128         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
129
130 2010-08-09  Eric Seidel  <eric@webkit.org>
131
132         Reviewed by Adam Barth.
133
134         EWS bots wait 2 minutes between patches
135         https://bugs.webkit.org/show_bug.cgi?id=43731
136
137         * Scripts/webkitpy/tool/bot/queueengine.py:
138          - Don't sleep after failures.  This was a hold-over from
139            an earlier design.
140         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
141          - EWS bots were not properly reporting true/false from process_work_item.
142            They were always returning None, thus false, thus always logging
143            as a failure and sleeping 2 minutes after each patch.
144
145 2010-08-09  Sam Weinig  <sam@webkit.org>
146
147         Reviewed by Anders Carlsson.
148
149         Stub out EventSender for WebKitTestRunner
150         https://bugs.webkit.org/show_bug.cgi?id=43703
151
152         * WebKitTestRunner/DerivedSources.make:
153         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
154         Add ability to pass javascript arguments to the wrapped object.
155
156         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added.
157         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Added.
158         (WTR::EventSendingController::create):
159         (WTR::EventSendingController::EventSendingController):
160         (WTR::EventSendingController::~EventSendingController):
161         (WTR::EventSendingController::wrapperClass):
162         (WTR::setExceptionForString):
163         (WTR::EventSendingController::mouseDown):
164         (WTR::EventSendingController::mouseUp):
165         (WTR::EventSendingController::mouseMoveTo):
166         (WTR::EventSendingController::keyDown):
167         (WTR::EventSendingController::contextClick):
168         (WTR::EventSendingController::leapForward):
169         (WTR::EventSendingController::textZoomIn):
170         (WTR::EventSendingController::textZoomOut):
171         (WTR::EventSendingController::zoomPageIn):
172         (WTR::EventSendingController::zoomPageOut):
173         (WTR::EventSendingController::makeWindowObject):
174         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Added.
175         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
176         (WTR::InjectedBundle::reset):
177         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
178         (WTR::InjectedBundle::eventSendingController):
179         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
180         (WTR::InjectedBundlePage::didClearWindowForFrame):
181         Add stubbed out EventSenderController.
182
183         * WebKitTestRunner/InjectedBundle/GCController.h:
184         Remove incorrect comment.
185
186         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
187         * WebKitTestRunner/win/InjectedBundle.vcproj:
188         Add new files.
189
190 2010-08-08  Kent Tamura  <tkent@chromium.org>
191
192         Unreviewed, trivial fix.
193
194         Fix "WindowsError: [Error 32] The process cannot access the file
195         because it is being used by another process" introduced by r64959.
196
197         * BuildSlaveSupport/test-result-archive:
198
199 2010-08-08  Kent Tamura  <tkent@chromium.org>
200
201         Reviewed by Tony Chang.
202
203         Chromium buildbot: Avoid "zip" command dependency
204         https://bugs.webkit.org/show_bug.cgi?id=43470
205
206         * BuildSlaveSupport/test-result-archive:
207          For Chromium port, creates a zip archive with zipfile package of Python
208          instead of external "zip" command. We'd like to avoid additional
209          command installation.
210
211 2010-08-08  Jon Honeycutt  <jhoneycutt@apple.com>
212
213         WebKitTestRunner should add the QuickTime dir to the PATH environment
214         variable
215         https://bugs.webkit.org/show_bug.cgi?id=43686
216
217         Reviewed by Dan Bernstein.
218
219         * WebKitTestRunner/win/TestControllerWin.cpp:
220         (WTR::addQTDirToPATH):
221         Copied from DRT.
222         (WTR::TestController::platformInitialize):
223         Call addQTDirToPath().
224         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
225         Link to shlwapi.lib for SHGetValue.
226
227 2010-08-07  Sam Weinig  <sam@webkit.org>
228
229         Reviewed by Maciej Stachowiak.
230
231         WebKitTestRunner needs layoutTestController.dumpTitleChanges
232         <rdar://problem/8213861>
233         https://bugs.webkit.org/show_bug.cgi?id=42683
234
235         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
236         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
237         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
238         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
239         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
240         (WTR::LayoutTestController::LayoutTestController):
241         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
242         (WTR::LayoutTestController::dumpTitleChanges):
243         (WTR::LayoutTestController::shouldDumpTitleChanges):
244
245 2010-08-07  Sam Weinig  <sam@webkit.org>
246
247         Reviewed by Anders Carlsson.
248
249         WebKitTestRunner needs to print onunload handler information
250         <rdar://problem/8213831>
251         https://bugs.webkit.org/show_bug.cgi?id=42703
252
253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
254         (WTR::operator<<):
255         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
256
257 2010-08-07  Sam Weinig  <sam@webkit.org>
258
259         Reviewed by Anders Carlsson.
260
261         Add additional loader client functions need to complete WebKitTestRunner
262         https://bugs.webkit.org/show_bug.cgi?id=43684
263
264         Remove unnecessary and jarring underscores as well.
265
266         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
267         (didClearWindowObjectForFrame):
268         (didCreatePage):
269         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
270         (WTR::InjectedBundlePage::InjectedBundlePage):
271         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
272         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
273         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
274         (WTR::InjectedBundlePage::didCommitLoadForFrame):
275         (WTR::InjectedBundlePage::didFinishLoadForFrame):
276         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
277         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
278         (WTR::InjectedBundlePage::didClearWindowForFrame):
279         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
280         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
281         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
282         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
283         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
284         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
285         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
286         (WTR::InjectedBundlePage::willAddMessageToConsole):
287         (WTR::InjectedBundlePage::willSetStatusbarText):
288         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
289         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
290         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
291         (WTR::InjectedBundlePage::shouldBeginEditing):
292         (WTR::InjectedBundlePage::shouldEndEditing):
293         (WTR::InjectedBundlePage::shouldInsertNode):
294         (WTR::InjectedBundlePage::shouldInsertText):
295         (WTR::InjectedBundlePage::shouldDeleteRange):
296         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
297         (WTR::InjectedBundlePage::shouldApplyStyle):
298         (WTR::InjectedBundlePage::didBeginEditing):
299         (WTR::InjectedBundlePage::didEndEditing):
300         (WTR::InjectedBundlePage::didChange):
301         (WTR::InjectedBundlePage::didChangeSelection):
302         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
303
304 2010-08-07  Dan Bernstein  <mitz@apple.com>
305
306         Build fix.
307
308         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
309         to JSGCController.{cpp,h} relative to the build root.
310
311 2010-08-07  Sam Weinig  <sam@webkit.org>
312
313         Reviewed by Anders Carlsson.
314
315         WebKitTestRunner needs GCController
316         <rdar://problem/8213834>
317         https://bugs.webkit.org/show_bug.cgi?id=42701
318
319         * WebKitTestRunner/DerivedSources.make:
320         * WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
321         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
322         (WTR::setProperty):
323         * WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
324         (WTR::GCController::create):
325         (WTR::GCController::GCController):
326         (WTR::GCController::~GCController):
327         (WTR::GCController::wrapperClass):
328         (WTR::GCController::collect):
329         (WTR::GCController::collectOnAlternateThread):
330         (WTR::GCController::getJSObjectCount):
331         (WTR::GCController::makeWindowObject):
332         * WebKitTestRunner/InjectedBundle/GCController.h: Added.
333         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
334         (WTR::InjectedBundle::reset):
335         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
336         (WTR::InjectedBundle::bundle):
337         (WTR::InjectedBundle::gcController):
338         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
339         (WTR::InjectedBundlePage::didClearWindowForFrame):
340         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
341         (WTR::LayoutTestController::keepWebHistory):
342         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
343         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
344         * WebKitTestRunner/win/InjectedBundle.vcproj:
345
346 2010-08-05  Jon Honeycutt  <jhoneycutt@apple.com>
347
348         WebKitTestRunner needs to be able to set the font smoothing type
349         https://bugs.webkit.org/show_bug.cgi?id=43406
350
351         Reviewed by Adam Roben.
352
353         * WebKitTestRunner/TestInvocation.cpp:
354         (WTR::TestInvocation::resetPreferencesToConsistentValues):
355         Set the font smoothing level to
356         kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
357
358 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
359
360         Fix a missed variable rename.
361
362         Unreviewed.
363
364         * Scripts/old-run-webkit-tests:
365
366 2010-08-06  Jon Honeycutt  <jhoneycutt@apple.com>
367
368         mac-wk2/Skipped should be used on Windows when running regression tests
369         https://bugs.webkit.org/show_bug.cgi?id=43494
370
371         Reviewed by Adam Roben.
372
373         * Scripts/old-run-webkit-tests:
374         If the platform is win-wk2, also read the mac-wk2 skipped list.
375
376 2010-08-06  Kent Tamura  <tkent@chromium.org>
377
378         Reviewed by Dimitri Glazkov.
379
380         [DRT/Chromium] Should revoke scheduled tasks
381         https://bugs.webkit.org/show_bug.cgi?id=43560
382
383         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
384         (DRTDevToolsAgent::reset): Calls RevokeAll().
385         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
386         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
387         (DRTDevToolsClient::reset): Calls RevokeAll().
388         * DumpRenderTree/chromium/DRTDevToolsClient.h:
389         * DumpRenderTree/chromium/EventSender.cpp:
390         (EventSender::reset): Calls RevokeAll().
391         * DumpRenderTree/chromium/LayoutTestController.cpp:
392         (LayoutTestController::reset): Calls RevokeAll().
393         * DumpRenderTree/chromium/TestShell.cpp:
394         (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
395
396 2010-08-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
397
398         Reviewed by Antonio Gomes.
399
400         [Qt] Fix the DRT build on Mac OS X
401
402         * DumpRenderTree/qt/DumpRenderTree.pro:
403
404 2010-08-06  Jochen Eisinger  <jochen@chromium.org>
405
406         Reviewed by Pavel Feldman.
407
408         Rietvield's upload.py moved to a different location.
409         https://bugs.webkit.org/show_bug.cgi?id=43613
410
411         * Scripts/webkitpy/thirdparty/__init__.py:
412
413 2010-05-23  Eric Seidel  <eric@webkit.org>
414
415         Reviewed by Adam Barth.
416
417         QueueStatusServer needs better queue-status pages
418         https://bugs.webkit.org/show_bug.cgi?id=39562
419
420         The primary goal of this patch is to display queue
421         positions somewhere on the site so that it's easier
422         for commit-queue users to know when their pach will
423         be landed.  I also tried to improve the root page
424         to be more useful than the previous wall of status text.
425
426         * QueueStatusServer/handlers/recentstatus.py:
427         * QueueStatusServer/main.py:
428         * QueueStatusServer/model/queues.py:
429         * QueueStatusServer/templates/recentstatus.html:
430
431 2010-08-05  Victor Wang  <victorw@chromium.org>
432
433         Reviewed by Ojan Vafai.
434
435         Add option to generate/upload incremental json results to test result server.
436         Also refactor the json results generator unittest code to test
437         incremental and aggregated json results.
438
439         https://bugs.webkit.org/show_bug.cgi?id=43519
440
441         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
442         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
443         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
444         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
445
446 2010-08-05  Jian Li  <jianli@chromium.org>
447
448         Reviewed by David Levin.
449
450         Unify blob related feature defines to ENABLE(BLOB).
451         https://bugs.webkit.org/show_bug.cgi?id=43081
452
453         * Scripts/build-webkit:
454
455 2010-08-05  Satish Sampath  <satish@chromium.org>
456
457         Reviewed by Jeremy Orlow.
458
459         Add speech input controller mock in WebKit and a layout test.
460         https://bugs.webkit.org/show_bug.cgi?id=43477
461
462         Added LayoutTestController::setMockSpeechInputResultCallback method.
463
464         * DumpRenderTree/LayoutTestController.cpp:
465         (setMockSpeechInputResultCallback): Wrapper invoking the member function.
466         (LayoutTestController::staticFunctions):
467         * DumpRenderTree/LayoutTestController.h:
468         * DumpRenderTree/chromium/LayoutTestController.cpp:
469         (LayoutTestController::LayoutTestController):
470         (LayoutTestController::setMockSpeechInputResult): Sets the mock result.
471         (LayoutTestController::speechInputController): Creates the mock controller.
472         * DumpRenderTree/chromium/LayoutTestController.h:
473         * DumpRenderTree/chromium/WebViewHost.cpp:
474         (WebViewHost::speechInputController): Creates the mock controller.
475         * DumpRenderTree/chromium/WebViewHost.h:
476         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
477         (LayoutTestController::setMockSpeechInputResult): dummy method.
478         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
479         (LayoutTestController::setMockSpeechInputResult): dummy method.
480         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
481         (LayoutTestController::setMockSpeechInputResult): dummy method.
482         * DumpRenderTree/qt/LayoutTestControllerQt.h:
483         * DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method.
484         (LayoutTestController::setMockSpeechInputResult):
485         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method.
486         (LayoutTestController::setMockSpeechInputResult):
487
488 2010-08-04  Adam Roben  <aroben@apple.com>
489
490         Fix the path to TestNetscapePlugin's directory on Windows
491
492         Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
493         load TestNetscapePlugin
494
495         Reviewed by Jon Honeycutt.
496
497         * WebKitTestRunner/win/TestControllerWin.cpp:
498         (WTR::TestController::initializeTestPluginDirectory):
499         TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
500         next to WebKitTestRunner.exe. Previously we were passing the directory
501         that contains WebKitTestRunner.exe. Also fixed some leaks.
502
503 2010-08-05  Kenichi Ishibashi  <bashi@google.com>
504
505         Reviewed by Shinichiro Hamaji.
506
507         check-webkit-style returns non-zero when patch is entirely minus lines.
508         https://bugs.webkit.org/show_bug.cgi?id=38169
509
510         * Scripts/check-webkit-style:
511         Check whether a patch contains modified files that are entirely minus lines.
512         * Scripts/webkitpy/style/filereader.py:
513         Add a variable that holds number of files that contain only deleted lines.
514         * Scripts/webkitpy/style/patchreader.py:
515         Count up modified files that contain only deleted lines.
516
517 2010-08-05  Pavel Feldman  <pfeldman@chromium.org>
518
519         Reviewed by Yury Semikhatsky.
520
521         DevTools: get rid of delayed command dispatching on front-end side.
522
523         https://bugs.webkit.org/show_bug.cgi?id=43479
524
525         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
526         (DRTDevToolsAgent::detach):
527         (DRTDevToolsAgent::frontendLoaded):
528         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
529         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
530         (DRTDevToolsClient::~DRTDevToolsClient):
531         (DRTDevToolsClient::sendFrontendLoaded):
532         * DumpRenderTree/chromium/DRTDevToolsClient.h:
533
534 2010-08-04  Kenichi Ishibashi  <bashi@google.com>
535
536         Reviewed by Shinichiro Hamaji.
537
538         Fixes check-webkit-style false positive on "new uint32_t."
539         https://bugs.webkit.org/show_bug.cgi?id=43077
540
541         * Scripts/webkitpy/style/checkers/cpp.py:
542         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
543
544 2010-08-04  Kent Tamura  <tkent@chromium.org>
545
546         Reviewed by Dimitri Glazkov.
547
548         [DRT/Chromium] Remove base/linked_ptr.h dependency
549         https://bugs.webkit.org/show_bug.cgi?id=43472
550
551         Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
552         We need to use RefPtr<> because m_pendingEntry points an object in
553         m_entries or not in m_entries.
554
555         * DumpRenderTree/chromium/TestNavigationController.cpp:
556         (TestNavigationEntry::create): Added.
557         (TestNavigationController::activeEntry):
558         (TestNavigationController::didNavigateToEntry):
559         (TestNavigationController::discardPendingEntry):
560         (TestNavigationController::insertEntry):
561         (TestNavigationController::navigateToPendingEntry):
562         * DumpRenderTree/chromium/TestNavigationController.h:
563         * DumpRenderTree/chromium/WebViewHost.cpp:
564         (WebViewHost::loadURLForFrame):
565          Use TestNavigationEntry::create().
566         (WebViewHost::updateURL):
567          Use RefPtr<>.
568         (WebViewHost::updateSessionHistory):
569          Remove unnecessary static_cast<>.
570
571 2010-08-04  Kent Tamura  <tkent@chromium.org>
572
573         Reviewed by Dimitri Glazkov.
574
575         Fix a problem that "archived test results" step doesn't work on Chromium buildbots
576         https://bugs.webkit.org/show_bug.cgi?id=43333
577
578         * BuildSlaveSupport/test-result-archive:
579           - Make layoutTestResultsDir local and pass it to archiveTestResults()
580           - Adjust layoutTestResultsDir for Chromium
581
582 2010-08-04  Kent Tamura  <tkent@chromium.org>
583
584         Reviewed by Dimitri Glazkov.
585
586         NRWT: websocket_server startup detection failure
587         https://bugs.webkit.org/show_bug.cgi?id=43466
588
589         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
590          Increase timeout value: 5 second -> 10 second
591
592 2010-08-04  Victor Wang  <victorw@chromium.org>
593
594         Reviewed by Ojan Vafai.
595
596         -. Add result.json incremental merging functionality to test results app engine.
597         -. blobstore is not suitable for AE data merging and there is no API to
598            programatically edit existing blob or write a new one yet, so replace blobstore
599            with datastore. If file is oversize (>1000*1000 bytes), store file data in
600            multiple datastore entries.
601         -. Fix styles.
602
603         Test: jsonresults_unittest to test merging logics.
604
605         https://bugs.webkit.org/show_bug.cgi?id=38599
606
607         * TestResultServer/handlers/dashboardhandler.py:
608         * TestResultServer/handlers/menu.py:
609         * TestResultServer/handlers/testfilehandler.py:
610         * TestResultServer/main.py:
611         * TestResultServer/model/dashboardfile.py:
612         * TestResultServer/model/datastorefile.py: Added.
613         * TestResultServer/model/jsonresults.py: Added.
614         * TestResultServer/model/jsonresults_unittest.py: Added.
615         * TestResultServer/model/testfile.py:
616         * TestResultServer/templates/uploadform.html:
617
618 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
619
620         Reviewed by Kenneth Christiansen.
621
622         [Qt] [QtTestBrowser] Remove unneeded QAction class members
623         https://bugs.webkit.org/show_bug.cgi?id=43518
624
625         LauncherWindow class has two totally unneeded class members: m_flopAnimated and
626         m_flipYAnimated. Also, in initializeView method there are some dead code block
627         trying to connect them at the wrong time, when they have not been instanciated.
628
629         This patch:
630
631         - removes the two cited class members in favor of local variables in createChrome method;
632         - removes the dead code block.
633
634         * QtTestBrowser/launcherwindow.cpp:
635         (LauncherWindow::LauncherWindow):
636         (LauncherWindow::initializeView):
637         (LauncherWindow::createChrome):
638         * QtTestBrowser/launcherwindow.h:
639
640 2010-08-04  Antonio Gomes  <tonikitoo@webkit.org>
641
642         Reviewed by Simon Hausmann and Kenneth Christiansen.
643
644         [Qt] [QtTestBrowser] Clean up static and global menu state controls
645         https://bugs.webkit.org/show_bug.cgi?id=43448
646
647         After LauncherWindow class was refactored out of from main.cpp, all global variables that
648         were hanging in main.cpp became temporarily public static class members of newly added
649         LauncherWindow class. This design was not properly handling the initial purpose of the
650         global variables: newly created launcher windows should inherit the settings of the originating
651         one.
652
653         In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
654         comprises all data needed to handling the goal described above.
655
656         * QtTestBrowser/launcherwindow.cpp:
657         (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
658                                           holding all user settings configured in the menus and command line.
659                                           It also receices an optional QGraphicsScene points in case we are doing
660                                           a "Clone Window".
661         (LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
662                                 value.
663         (LauncherWindow::initializeView): Ditto.
664         (LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
665         (LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
666                                       apply the preferences is provided by m_userData.
667         (LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
668         (LauncherWindow::toggleResizesToContents): Ditto.
669         (LauncherWindow::toggleWebGL): Ditto.
670         (LauncherWindow::toggleFrameFlattening): Ditto.
671         (LauncherWindow::toggleQGLWidgetViewport): Ditto.
672         (LauncherWindow::changeViewportUpdateMode): Ditto.
673         (LauncherWindow::showFPS): Ditto.
674         (LauncherWindow::newWindow): Changed to pass the userData.
675         (LauncherWindow::cloneWindow): Ditto.
676         * QtTestBrowser/launcherwindow.h:
677         (WindowOptions::WindowOptions):
678         * QtTestBrowser/main.cpp:
679         (requiresGraphicsView):
680         (LauncherApplication::handleUserOptions):
681         (main):
682
683 2010-08-04  Kevin Ollivier  <kevino@theolliviers.com>
684
685         [wx] Build fix for gcc not importing all symbols from convenience libraries.
686         Works on 10.6 only for Mac until the build system is reworked. 
687
688         * wx/build/settings.py:
689
690 2010-08-04  Markus Goetz  <Markus.Goetz@nokia.com>
691
692         Reviewed by Simon Hausmann.
693
694         [Qt] Change wording in QtTestBrowser
695         https://bugs.webkit.org/show_bug.cgi?id=43241
696
697         * QtTestBrowser/launcherwindow.cpp:
698         (LauncherWindow::createChrome):
699
700 2010-08-04  Aaron Boodman  <aa@chromium.org>
701
702         Reviewed by Eric Seidel.
703
704         prepare-ChangeLog fails mysteriously if curl doesn't support ssl
705         https://bugs.webkit.org/show_bug.cgi?id=43460
706
707         * Scripts/prepare-ChangeLog:
708
709 2010-08-03  MORITA Hajime  <morrita@google.com>
710
711         Reviewed by Tony Chang.
712
713         [DRT] Assertion failed when drag and move a draggable element.
714         https://bugs.webkit.org/show_bug.cgi?id=41695
715
716         mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
717         But Cocoa doesn't call mouseDragged() until dragging is done.
718         Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
719         on UIDelegate failed when mouseDragged() is called during dragging.
720         This change eliminated the mouseDragged() call when dragging begins,
721         which is implicated by draggingInfo instance.
722         
723         * DumpRenderTree/mac/EventSendingController.mm:
724         (-[EventSendingController mouseMoveToX:Y:]):
725
726         Test: fast/events/dragging-mouse-moves.html
727         
728 2010-08-02  Steve Block  <steveblock@google.com>
729
730         Reviewed by Alexey Proskuryakov.
731
732         Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
733         https://bugs.webkit.org/show_bug.cgi?id=40002
734
735         The code in LayoutTestController::setGeolocationPermission() was moved to
736         setGeolocationPermissionCommon() to allow each port to provide its own
737         implementation of setGeolocationPermission().
738
739         For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
740         new permission, so it can call back to WebCore if permission requests are in
741         progress and are waiting for a response. A minor fix to the Mac
742         MockGeolocationProvider was also required to make sure that the mock provider
743         calls back to WebCore when it is first started.
744
745         For other ports, LayoutTestController::setGeolocationPermission() is not
746         implemented.
747
748         * DumpRenderTree/LayoutTestController.cpp:
749         (LayoutTestController::setGeolocationPermissionCommon):
750         * DumpRenderTree/LayoutTestController.h:
751         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
752         (LayoutTestController::setGeolocationPermission):
753         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
754         (LayoutTestController::setGeolocationPermission):
755         * DumpRenderTree/mac/MockGeolocationProvider.mm:
756         (-[MockGeolocationProvider registerWebView:]):
757         * DumpRenderTree/mac/UIDelegate.h:
758         * DumpRenderTree/mac/UIDelegate.mm:
759         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
760         (-[UIDelegate setGeolocationPermission:]):
761         (-[UIDelegate dealloc]):
762         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
763         (LayoutTestController::setGeolocationPermission):
764         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
765         (LayoutTestController::setGeolocationPermission):
766
767 2010-08-03  Kent Tamura  <tkent@chromium.org>
768
769         Reviewed by Dimitri Glazkov.
770
771         [DRT/Chromium] Implement --testshell-startup-dialog
772         https://bugs.webkit.org/show_bug.cgi?id=40616
773
774         * DumpRenderTree/chromium/DumpRenderTree.cpp:
775         (main): Check --testshell-startup-dialog, and call openStartUpDialog()
776         if it is specfied.
777         * DumpRenderTree/chromium/TestShell.h:
778           Declare openStartUpDialog().
779         * DumpRenderTree/chromium/TestShellGtk.cpp:
780         (openStartupDialog):
781         * DumpRenderTree/chromium/TestShellMac.mm:
782         (openStartupDialog):
783         * DumpRenderTree/chromium/TestShellWin.cpp:
784         (openStartupDialog):
785
786 2010-08-03  Kent Tamura  <tkent@chromium.org>
787
788         Reviewed by Dimitri Glazkov.
789
790         [DRT/Chromium] Remove dependency of base/md5.h
791         https://bugs.webkit.org/show_bug.cgi?id=43403
792
793         * DumpRenderTree/chromium/TestShell.cpp:
794         (TestShell::dumpImage): Use wtf/MD5.h
795
796 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
797
798         Reviewed by David Kilzer.
799
800         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
801         https://bugs.webkit.org/show_bug.cgi?id=40627
802
803         Part 6 - LayoutTest and Cleanup
804
805           Allow tests to delete application caches and set application cache
806           origin quotas, so they can be tested.
807
808         * DumpRenderTree/LayoutTestController.cpp:
809         (LayoutTestController::LayoutTestController):
810         (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller.
811         (clearAllApplicationCachesCallback): should delete all application caches.
812         (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests.
813         (LayoutTestController::staticFunctions):
814         * DumpRenderTree/LayoutTestController.h:
815         (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output.
816         (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
817
818           Mac implementation.
819
820         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
821         (LayoutTestController::clearAllApplicationCaches): delete application caches.
822         (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
823         * DumpRenderTree/mac/UIDelegate.mm:
824         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix.
825         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
826
827           Stub implementations for other platforms.
828
829         * DumpRenderTree/chromium/LayoutTestController.cpp:
830         (LayoutTestController::LayoutTestController):
831         (LayoutTestController::clearAllApplicationCaches):
832         (LayoutTestController::setApplicationCacheOriginQuota):
833         * DumpRenderTree/chromium/LayoutTestController.h:
834         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
835         (LayoutTestController::clearAllApplicationCaches):
836         (LayoutTestController::setApplicationCacheOriginQuota):
837         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
838         (LayoutTestController::clearAllApplicationCaches):
839         (LayoutTestController::setApplicationCacheOriginQuota):
840         * DumpRenderTree/qt/LayoutTestControllerQt.h:
841         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
842         (LayoutTestController::clearAllApplicationCaches):
843         (LayoutTestController::setApplicationCacheOriginQuota):
844         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
845         (LayoutTestController::clearAllApplicationCaches):
846         (LayoutTestController::setApplicationCacheOriginQuota):
847
848 2010-08-03  Joseph Pecoraro  <joepeck@webkit.org>
849
850         Reviewed by David Kilzer.
851
852         Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
853         https://bugs.webkit.org/show_bug.cgi?id=40627
854
855         Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
856
857           Change old style calls to make use of the managers.
858
859         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
860         (LayoutTestController::setDatabaseQuota):
861         * DumpRenderTree/mac/UIDelegate.mm:
862         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
863
864 2010-08-03  Mark Rowe  <mrowe@apple.com>
865
866         Add a new Leopard build slave to run the release tests.
867
868         * BuildSlaveSupport/build.webkit.org-config/config.json:
869
870 2010-08-03  Jon Honeycutt  <jhoneycutt@apple.com>
871
872         WebKitTestRunner needs to activate the Mac font ascent hack
873         https://bugs.webkit.org/show_bug.cgi?id=43404
874
875         Reviewed by Darin Adler.
876
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::initialize):
879         Call WKBundleActivateMacFontAscentHack().
880
881 2010-08-03  Alex Milowski  <alex@milowski.com>
882
883         Reviewed by Beth Dakin.
884
885         Changed the default for MathML support so that is is enabled by default.
886
887         * Scripts/build-webkit:
888
889 2010-08-03  Sam Weinig  <sam@webkit.org>
890
891         Roll r64566 back in this time with all the overloads in place..
892
893         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
894         (WTR::InjectedBundlePage::shouldInsertNode):
895         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
896         * WebKitTestRunner/StringFunctions.h:
897         * WebKitTestRunner/TestInvocation.cpp:
898         (WTR::TestInvocation::resetPreferencesToConsistentValues):
899         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
900         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
901
902 2010-08-03  Sam Weinig  <sam@webkit.org>
903
904         Rollout r64566. It broke all the WebKit2 tests.
905
906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
907         (WTR::operator<<):
908         (WTR::InjectedBundlePage::shouldInsertNode):
909         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
910         * WebKitTestRunner/StringFunctions.h: Removed.
911         * WebKitTestRunner/TestInvocation.cpp:
912         (WTR::createWKURL):
913         (WTR::WKStringToUTF8):
914         (WTR::TestInvocation::resetPreferencesToConsistentValues):
915         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
916         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
917
918 2010-08-03  Sam Weinig  <sam@webkit.org>
919
920         Reviewed by Anders Carlsson.
921
922         WTR: Move all the utility functions for working with strings to a shared header.
923         https://bugs.webkit.org/show_bug.cgi?id=43386
924
925         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
926         (WTR::InjectedBundlePage::shouldInsertNode):
927         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
928         * WebKitTestRunner/StringFunctions.h: Added.
929         * WebKitTestRunner/TestInvocation.cpp:
930         (WTR::TestInvocation::resetPreferencesToConsistentValues):
931         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
932         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
933
934 2010-08-02  Antonio Gomes  <tonikitoo@webkit.org>
935
936         Reviewed by Kenneth Christiansen.
937
938         [Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
939         https://bugs.webkit.org/show_bug.cgi?id=43168
940
941         QGraphicsWebView resizesToContents property has to work together with QWebPage's
942         setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
943
944         * QtTestBrowser/launcherwindow.cpp:
945         (LauncherWindow::applyPrefs):
946         * QtTestBrowser/webview.cpp:
947         (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
948                                                       needed when toggle resizesToContents on/off.
949         (WebViewGraphicsBased::resizeEvent):
950         * QtTestBrowser/webview.h:
951         (WebViewGraphicsBased::setCustomLayoutSize): Setter helper.
952         (WebViewGraphicsBased::customLayoutSize): Getter helper.
953
954 2010-08-03  Jochen Eisinger  <jochen@chromium.org>
955
956         Unreviewed. Adding myself as committer.
957
958         * Scripts/webkitpy/common/config/committers.py:
959
960 2010-08-02  Pavel Feldman  <pfeldman@chromium.org>
961
962         Reviewed by Yury Semikhatsky.
963
964         Chromium DevTools: Get rid of DevTools RPC.
965
966         https://bugs.webkit.org/show_bug.cgi?id=43335
967
968         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
969         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
970         (DRTDevToolsAgent::call):
971         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
972         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h:
973         (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
974         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
975         (DRTDevToolsClient::sendMessageToBackend):
976         (DRTDevToolsClient::call):
977         * DumpRenderTree/chromium/DRTDevToolsClient.h:
978
979 2010-08-02  Kent Tamura  <tkent@chromium.org>
980
981         Reviewed by Dimitri Glazkov.
982
983         [DRT/Chromium] Remove dependencies to some Chromium headers
984         https://bugs.webkit.org/show_bug.cgi?id=43396
985
986         * DumpRenderTree/chromium/CppVariant.h:
987          Remove base/basictypes.h because webkit_support.h contains it.
988         * DumpRenderTree/chromium/EventSender.cpp:
989         (getCurrentEventTimeSec): Use new wrapper function.
990         * DumpRenderTree/chromium/TestNavigationController.h:
991          Remove base/basictypes.h because webkit_support.h contains it.
992         * DumpRenderTree/chromium/TestShell.cpp:
993         (dumpHistoryItem): Use new wrapper function.
994         * DumpRenderTree/chromium/WebViewHost.cpp:
995         (WebViewHost::cancelledError): Use new wrapper function.
996         (WebViewHost::didFailResourceLoad): Use new wrapper function.
997
998 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
999
1000         Reviewed by Xan Lopez.
1001
1002         [GTK] DRT implement execCommand()
1003         https://bugs.webkit.org/show_bug.cgi?id=35351
1004
1005         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1006         (LayoutTestController::execCommand): Implement using webkit_web_view_execute_core_command_by_name.
1007         (LayoutTestController::isCommandEnabled): Implement using webkit_web_view_is_command_enabled.
1008         (LayoutTestController::setCacheModel): Move below LayoutTestController::isCommandEnabled.
1009
1010 2010-08-02  Sam Weinig  <sam@webkit.org>
1011
1012         Reviewed by Anders Carlsson.
1013
1014         Add alias for run-webkit-tests --webkit-test-runner (run-webkit-tests -2).
1015
1016         * Scripts/old-run-webkit-tests:
1017
1018 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1019
1020         WebKitTestRunner needs to support loading custom fonts (via the
1021         WEBKIT_TESTFONTS environment variable)
1022         https://bugs.webkit.org/show_bug.cgi?id=42782
1023
1024         Reviewed by Adam Roben.
1025
1026         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1027         (WTR::fontsPath):
1028         Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
1029         as this directory doesn't appear to be created anymore.
1030         (WTR::activateFonts):
1031         Loop through the fonts, and call AddFontResourceExW() for each.
1032
1033 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1034
1035         Restore the WebKitTestRunner.sln that was removed, and remove the
1036         correct one.
1037
1038         Rubber-stamped by Sam Weinig.
1039
1040         * WebKitTestRunner/WebKitTestRunner.sln: Added.
1041         * WebKitTestRunner/win/WebKitTestRunner.sln: Removed.
1042
1043 2010-08-02  Jon Honeycutt  <jhoneycutt@apple.com>
1044
1045         Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
1046
1047         Remove the unused WebKitTestRunner.sln.
1048
1049         Reviewed by Sam Weinig.
1050
1051         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1052         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Removed.
1053         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
1054         * WebKitTestRunner/win/InjectedBundle.vcproj: Added.
1055         * WebKitTestRunner/win/WebKitTestRunner.sln:
1056
1057 2010-08-02  Sam Weinig  <sam@webkit.org>
1058
1059         Fix the windows build.
1060
1061         * WebKitTestRunner/win/main.cpp:
1062
1063 2010-07-29  Jon Honeycutt  <jhoneycutt@apple.com>
1064
1065         Add a Skipped list on Windows, and have run-webkit-tests respect it.
1066
1067         Part of <rdar://problem/8233237> Fill WebKit2 Windows skipped list so
1068         there are zero tests failing
1069         https://bugs.webkit.org/show_bug.cgi?id=43374
1070
1071         Reviewed by Adam Roben.
1072
1073         * Scripts/old-run-webkit-tests:
1074         If using WebKitTestRunner and Apple Windows WebKit, set the platform to
1075         win-wk2. When building the result hierarchy, if the platform is win-wk2,
1076         add it first to the list of platforms.
1077
1078 2010-08-02  Darin Adler  <darin@apple.com>
1079
1080         Reviewed by Sam Weinig.
1081
1082         WebKitTestRunner needs layoutTestController.setCanOpenWindows
1083         https://bugs.webkit.org/show_bug.cgi?id=42321
1084
1085         WebKitTestRunner needs layoutTestController.setCloseRemainingWindowsWhenComplete
1086         https://bugs.webkit.org/show_bug.cgi?id=42779
1087
1088         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added
1089         setCanOpenWindows, setCloseRemainingWindowsWhenComplete, and windowCount
1090
1091         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1092         (WTR::InjectedBundle::InjectedBundle): Initialize m_mainPage to 0 instead of
1093         waiting for the first call to didCreatePage.
1094         (WTR::InjectedBundle::didCreatePage): Set m_mainPage only when the first page
1095         is created. Put other pages into a map.
1096         (WTR::InjectedBundle::willDestroyPage): Added code to handle the destruction
1097         of the main page.
1098         (WTR::InjectedBundle::closeOtherPages): Added. Closes all the pages other than
1099         the main page.
1100         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Added pageCount and
1101         closeOtherPages functions.
1102
1103         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1104         (WTR::InjectedBundlePage::didFinishLoadForFrame): Don't let pages other than
1105         the main page affect dumping.
1106         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
1107
1108         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1109         (WTR::LayoutTestController::LayoutTestController): Initialize the new
1110         m_shouldCloseExtraWindows member.
1111         (WTR::LayoutTestController::setCanOpenWindows): Added. Empty for now.
1112         (WTR::LayoutTestController::windowCount): Added.
1113
1114         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1115         Added setCanOpenWindows, setCloseRemainingWindowsWhenComplete,
1116         windowCount, shouldCloseExtraWindowsAfterRunningTest, and
1117         m_shouldCloseExtraWindows.
1118
1119         * WebKitTestRunner/TestController.cpp:
1120         (WTR::TestController::shared): Return a pointer to the shared copy, but
1121         don't allocate and leak it. This seemed cleaner than adding an explicit
1122         finalize call to go along with the explicit initialize call.
1123         (WTR::TestController::TestController): Added calls to the initialize and
1124         run function, which are now done automatically.
1125         (WTR::TestController::~TestController): Added, since it's called now.
1126         (WTR::closeOtherPage): Added. Used to close pages other than the main page.
1127         (WTR::createOtherPage): Added. Used to create pages other than the main page.
1128         (WTR::TestController::initialize): Added code to set up createOtherPage.
1129         (WTR::TestController::run): Removed unused return value.
1130         * WebKitTestRunner/TestController.h: Made constructor and destructor public,
1131         and initialize and run private. Changed m_mainWebView to be an OwnPtr.
1132
1133         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1134         (WTR::PlatformWebView::PlatformWebView): Added a call to setReleasedWhenClosed
1135         to avoid releasing the window twice. Another way to handle it would be to
1136         remove the release, but this approach is slightly more robust because it works
1137         even if some other code calls the close method an extra time.
1138
1139         * WebKitTestRunner/mac/main.mm:
1140         (main): Use a stack-allocated TestController object instead of calling
1141         initalize and run on a globally allocated one.
1142
1143 2010-08-02  Tony Chang  <tony@chromium.org>
1144
1145         Reviewed by David Levin.
1146
1147         add myself to the reviewers list
1148         https://bugs.webkit.org/show_bug.cgi?id=43366
1149
1150         * Scripts/webkitpy/common/config/committers.py:
1151
1152 2010-08-02  Anders Carlsson  <andersca@apple.com>
1153
1154         Reviewed by Sam Weinig.
1155
1156         Cache JSNPObjects and fix bugs in the object map
1157         https://bugs.webkit.org/show_bug.cgi?id=43368
1158
1159         Test that we correctly throw exceptions when trying to do things to a JSObject that used to
1160         wrap an NPObject that came from a plug-in that is now destroyed.
1161
1162         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1163         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1164         (PluginTest::Object::getProperty):
1165         (PluginTest::Object::NP_GetProperty):
1166         (PluginTest::Object::npClass):
1167         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp: Added.
1168         (NPRuntimeObjectFromDestroyedPlugin::NPRuntimeObjectFromDestroyedPlugin):
1169         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
1170         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::getProperty):
1171         (NPRuntimeObjectFromDestroyedPlugin::NPP_GetValue):
1172         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1173         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1174         * GNUmakefile.am:
1175
1176 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1177
1178         Reviewed by Xan Lopez.
1179
1180         [Gtk] DOM listeners get wrong keycodes for some keys
1181         https://bugs.webkit.org/show_bug.cgi?id=35170
1182
1183         Add support to all event senders for simulating keypad insert
1184         and print screen keys.
1185
1186         * DumpRenderTree/chromium/EventSender.cpp:
1187         (EventSender::keyDown): Add support for generating keypad insert and print screen.
1188         * DumpRenderTree/gtk/EventSender.cpp:
1189         (keyDownCallback): Ditto.
1190         * DumpRenderTree/mac/EventSendingController.mm:
1191         (-[EventSendingController keyDown:withModifiers:withLocation:]): Ditto.
1192         * DumpRenderTree/qt/EventSenderQt.cpp:
1193         (EventSender::keyDown): Ditto.
1194         * DumpRenderTree/win/EventSender.cpp:
1195         (keyDownCallback): Ditto.
1196
1197 2010-08-02  Martin Robinson  <mrobinson@igalia.com>
1198
1199         Build fix for building against development versions of GTK+. GTK 2.22
1200         has not yet been released, so these function definitions must be conditionalized
1201         on the development version.
1202
1203         * DumpRenderTree/gtk/EventSender.cpp: Fix GTK+ 2.21 build.
1204
1205 2010-08-02  Tony Chang  <tony@chromium.org>
1206
1207         Reviewed by Kent Tamura.
1208
1209         [chromium] use ChromiumDriver on Linux when running webkit tests
1210         https://bugs.webkit.org/show_bug.cgi?id=43273
1211
1212         * Scripts/webkitpy/layout_tests/port/chromium.py:
1213
1214 2010-08-02  Kent Tamura  <tkent@chromium.org>
1215
1216         Reviewed by Dimitri Glazkov.
1217
1218         [DRT/Chromium] Always initialize GTK
1219         https://bugs.webkit.org/show_bug.cgi?id=43327
1220
1221         Call gtk_init() in order to fix plugin test crash.
1222
1223         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1224         (main): Pass argc/argv to platformInit().
1225         * DumpRenderTree/chromium/TestShell.h:
1226         * DumpRenderTree/chromium/TestShellGtk.cpp:
1227         (platformInit): Update parameters, call gtk_init().
1228         * DumpRenderTree/chromium/TestShellMac.mm:
1229         (platformInit): Update parameters.
1230         * DumpRenderTree/chromium/TestShellWin.cpp:
1231         (platformInit): Update parameters.
1232
1233 2010-08-02  Balazs Kelemen  <kb@inf.u-szeged.hu>
1234
1235         Reviewed by Simon Hausmann.
1236
1237         [Qt] Generate forwarding headers for WebKit2
1238
1239         https://bugs.webkit.org/show_bug.cgi?id=43336
1240
1241         * Scripts/webkitdirs.pm: Call make on WebKit2/Makefile.DerivedSources.
1242
1243 2010-08-02  Fumitoshi Ukai  <ukai@chromium.org>
1244
1245         Reviewed by Kent Tamura.
1246
1247         WebSocket server should start with SO_REUSEADDR
1248         https://bugs.webkit.org/show_bug.cgi?id=43329
1249
1250         Pulls in pywebsocket-0.5.2.
1251         pywebsocket-0.5.2 includes a small fix to start server with SO_REUSE_ADDR.
1252         http://code.google.com/p/pywebsocket/source/detail?r=273
1253
1254         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version
1255
1256 2010-08-01  Kent Tamura  <tkent@chromium.org>
1257
1258         Reviewed by Dimitri Glazkov.
1259
1260         [DRT/Chromium] Remove string_util.h dependency
1261         https://bugs.webkit.org/show_bug.cgi?id=43312
1262
1263         * DumpRenderTree/chromium/LayoutTestController.cpp:
1264         (LayoutTestController::pathToLocalResource):
1265          Use string::find() instead of StartsWithASCII().
1266         (LayoutTestController::cppVariantToInt32):
1267          Use strtol() instead of StringToNumber().
1268
1269 2010-08-01  Sam Weinig  <sam@webkit.org>
1270
1271         Reviewed by Anders Carlsson.
1272
1273         Add ability to reset frame names for WebKitTestRunner
1274         https://bugs.webkit.org/show_bug.cgi?id=43316
1275
1276         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1277         (WTR::InjectedBundle::reset):
1278         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1279         (WTR::InjectedBundlePage::reset):
1280         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1281
1282 2010-08-01  Anders Carlsson  <andersca@apple.com>
1283
1284         Reviewed by Sam Weinig.
1285
1286         Implement NPN_RemoveProperty
1287         https://bugs.webkit.org/show_bug.cgi?id=43315
1288
1289         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1290         Add NPRuntimeRemoveProperty.cpp
1291         
1292         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1293         (PluginTest::NPN_GetStringIdentifier):
1294         (PluginTest::NPN_GetIntIdentifier):
1295         (PluginTest::NPN_RemoveProperty):
1296         Add NPN_ helpers.
1297
1298         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1299         Support more NPClass functions.
1300
1301         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: Added.
1302         (NPRuntimeRemoveProperty::NPRuntimeRemoveProperty):
1303         Test for NPN_RemoveProperty.
1304
1305         (NPRuntimeRemoveProperty::TestObject::hasMethod):        
1306         (NPRuntimeRemoveProperty::TestObject::invoke):
1307         Add a testRemoveProperty method.
1308
1309         (NPRuntimeRemoveProperty::NPP_GetValue):
1310         Return the test object.
1311
1312         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1313         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1314         * GNUmakefile.am:
1315         Add NPRuntimeRemoveProperty.cpp
1316
1317 2010-07-30  Anders Carlsson  <andersca@apple.com>
1318
1319         Reviewed by Sam Weinig.
1320
1321         Add an NPObject class template helper to TestNetscapePlugin
1322         https://bugs.webkit.org/show_bug.cgi?id=43288
1323
1324         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1325         Add some template magic to be able to figure out if a class has a member function of a given type.
1326
1327         (PluginTest::Object::create):
1328         Create an object.
1329
1330         (PluginTest::Object::invokeDefault):
1331         Add dummy function, this should never be called.
1332
1333         (PluginTest::Object::Object):
1334         Initialize m_pluginTest to 0.
1335
1336         (PluginTest::Object::~Object):
1337         Add virtual destructor.
1338
1339         (PluginTest::Object::NP_Allocate):
1340         Create a new object.
1341
1342         (PluginTest::Object::NP_Deallocate):
1343         Delete the object.
1344
1345         (PluginTest::Object::NP_InvokeDefault):
1346         Call invokeDefault.
1347
1348         (PluginTest::Object::npClass):
1349         Initialize the NPClass struct.
1350
1351         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1352         (DocumentOpenInDestroyStream::NPP_DestroyStream):
1353         Move this inline.
1354
1355         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
1356         (PluginScriptableNPObjectInvokeDefault::NPObjectWithInvokeDefault::invokeDefault):
1357         (PluginScriptableNPObjectInvokeDefault::NPP_GetValue):
1358         Use the PluginTest::Object class template.
1359
1360 2010-07-31  Sam Weinig  <sam@webkit.org>
1361
1362         Reviewed by Dan Bernstein.
1363
1364         Patch for https://bugs.webkit.org/show_bug.cgi?id=43305
1365         Add back WKBundleFrameCopyInnerText to fix ~50 test failures
1366         due to SVGElements not having the innerText function.
1367
1368         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1369         (WTR::dumpFrameText):
1370
1371 2010-07-30  Sam Weinig  <sam@webkit.org>
1372
1373         Reviewed by Maciej Stachowiak.
1374
1375         Patch for https://bugs.webkit.org/show_bug.cgi?id=43290
1376         Add structured message passing from the injected bundle to UIProcess
1377
1378         * MiniBrowser/mac/AppDelegate.m:
1379         (didRecieveMessageFromInjectedBundle):
1380         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1381         (didClearWindowForFrame):
1382         (didRecieveMessage):
1383         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1384         (WTR::InjectedBundle::done):
1385         (WTR::InjectedBundle::didReceiveMessage):
1386         * WebKitTestRunner/TestController.cpp:
1387         (WTR::TestController::initialize):
1388         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1389         * WebKitTestRunner/TestController.h:
1390         * WebKitTestRunner/TestInvocation.cpp:
1391         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1392         * WebKitTestRunner/TestInvocation.h:
1393         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1394
1395 2010-07-30  Sam Weinig  <sam@webkit.org>
1396
1397         Reviewed by Anders Carlsson.
1398
1399         Patch for https://bugs.webkit.org/show_bug.cgi?id=43275
1400         Make WKArrayRef more usable.
1401
1402         Remove now unnecessary const_casts.
1403
1404         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1405         (WTR::dumpDescendantFrameScrollPositions):
1406         (WTR::dumpDescendantFramesText):
1407
1408 2010-07-30  Sam Weinig  <sam@webkit.org>
1409
1410         Reviewed by Anders Carlsson.
1411
1412         Patch for https://bugs.webkit.org/show_bug.cgi?id=43274
1413         Add first pass of structured message passing.
1414
1415         Update Minibrowser and WebKitTestRunner to work with the new post message
1416         function.
1417
1418         * MiniBrowser/mac/AppDelegate.m:
1419         (didRecieveMessageFromInjectedBundle):
1420         (-[BrowserAppDelegate init]):
1421         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1422         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1423         (didStartProvisionalLoadForFrame):
1424         (didReceiveServerRedirectForProvisionalLoadForFrame):
1425         (didFailProvisionalLoadWithErrorForFrame):
1426         (didCommitLoadForFrame):
1427         (didFinishLoadForFrame):
1428         (didFailLoadWithErrorForFrame):
1429         (didReceiveTitleForFrame):
1430         (didClearWindowForFrame):
1431         (didCreatePage):
1432         (willDestroyPage):
1433         (didRecieveMessage):
1434         (WKBundleInitialize):
1435         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1436         (WTR::InjectedBundle::_didReceiveMessage):
1437         (WTR::InjectedBundle::didReceiveMessage):
1438         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1439         * WebKitTestRunner/TestInvocation.cpp:
1440         (WTR::TestInvocation::invoke):
1441         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1442
1443 2010-07-30  Anders Carlsson  <andersca@apple.com>
1444
1445         Try to fix the layout test failures.
1446
1447         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1448         (webkit_test_plugin_get_value):
1449
1450 2010-07-29  Anders Carlsson  <andersca@apple.com>
1451
1452         Reviewed by Adam Roben.
1453
1454         Replace plugins/npruntime/bindings-test.html with a more sophisticated test
1455         https://bugs.webkit.org/show_bug.cgi?id=43232
1456
1457         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1458         Add PluginScriptableNPObjectInvokeDefault.cpp.
1459
1460         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1461         Remove invokeDefault callback function.
1462
1463         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1464         (PluginTest::create):
1465         Move this to the top of the file.
1466
1467         (PluginTest::NPP_GetValue):
1468         Add default implementation.
1469
1470         (PluginTest::NPN_CreateObject):
1471         Add NPN_ wrapper.
1472
1473         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1474         (PluginTest::identifier):
1475         Add identifier getter.
1476
1477         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
1478         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
1479         Add "using namespace std".
1480
1481         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1482         (NPP_GetValue):
1483         Give PluginTest a chance to return a value.
1484
1485         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1486         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1487         * GNUmakefile.am:
1488         Add PluginScriptableNPObjectInvokeDefault.cpp.
1489         
1490         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1491         (webkit_test_plugin_get_value):
1492         Give PluginTest a chance to return a value.
1493
1494 2010-07-30  Steve Block  <steveblock@google.com>
1495
1496         Reviewed by Steve Block.
1497
1498         Add LayoutTestController methods to test DeviceOrientation
1499         https://bugs.webkit.org/show_bug.cgi?id=39589
1500
1501         * DumpRenderTree/LayoutTestController.cpp:
1502         (setMockDeviceOrientationCallback):
1503         (LayoutTestController::staticFunctions):
1504         * DumpRenderTree/LayoutTestController.h:
1505         * DumpRenderTree/chromium/LayoutTestController.cpp:
1506         (LayoutTestController::LayoutTestController):
1507         (LayoutTestController::setMockDeviceOrientation):
1508         * DumpRenderTree/chromium/LayoutTestController.h:
1509         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1510         (LayoutTestController::setMockDeviceOrientation):
1511         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1512         (LayoutTestController::setMockDeviceOrientation):
1513         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1514         (LayoutTestController::setMockDeviceOrientation):
1515         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1516         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1517         (LayoutTestController::setMockDeviceOrientation):
1518         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1519         (LayoutTestController::setMockDeviceOrientation):
1520         * Scripts/build-webkit:
1521
1522 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1523
1524         Reviewed by Kenneth Christiansen.
1525
1526         [Qt] QtTestBrowser: -resizes-to-contents command line parameter is broken
1527         https://bugs.webkit.org/show_bug.cgi?id=43209
1528
1529         When -resizes-to-content was being passed as a command line parameter it was simply
1530         not being set (although the corresponding menu item was marked as ON).
1531         User had to toggle the menu OFF and then ON again for it to take place.
1532
1533         Reason: LauncherWindow::applyPrefs method sets many user options passed in from
1534         the command line, but not resizesToContents. Patch addresses that.
1535
1536         * QtTestBrowser/launcherwindow.cpp:
1537         (LauncherWindow::createChrome):
1538         (LauncherWindow::applyPrefs):
1539         (LauncherWindow::toggleResizesToContents):
1540         * QtTestBrowser/webview.h:
1541         (WebViewGraphicsBased::resizesToContents):
1542
1543 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1544
1545         Rubber-stamped by Simon Fraser.
1546
1547         [Qt] QtTestBrowser: more method grouping and clean ups.
1548
1549         Moving blocks of code around. Basically grouping related methods close to each.
1550
1551         * QtTestBrowser/launcherwindow.cpp:
1552         (LauncherWindow::initializeView):
1553         (LauncherWindow::createChrome):
1554         (LauncherWindow::changeViewportUpdateMode):
1555         (LauncherWindow::showFPS):
1556         (LauncherWindow::newWindow):
1557         (LauncherWindow::cloneWindow):
1558         * QtTestBrowser/launcherwindow.h:
1559
1560 2010-07-30  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
1561
1562         Reviewed by Tor Arne Vestbø.
1563
1564         [QT][Symbian] QtTestBrowser missing location capabilities
1565         https://bugs.webkit.org/show_bug.cgi?id=43235
1566
1567         QtTestBrowser missing capabilities to use QtMobility::QLocation. 
1568
1569         * QtTestBrowser/QtTestBrowser.pro:
1570
1571 2010-07-29  Anders Carlsson  <andersca@apple.com>
1572
1573         Add PluginTest.cpp
1574
1575         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1576
1577 2010-07-29  Dirk Pranke  <dpranke@chromium.org>
1578
1579         Reviewed by Eric Seidel.
1580
1581         Update download URLs for python irclib package; the old URLs 
1582         pointed at a specific mirror host and not the general sourceforge
1583         URLs.
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=43228
1586
1587         * Scripts/webkitpy/thirdparty/__init__.py:
1588
1589 2010-07-29  Anders Carlsson  <andersca@apple.com>
1590
1591         Fix typo.
1592
1593         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1594
1595 2010-07-29  Anders Carlsson  <andersca@apple.com>
1596
1597         Another attempt at fixing the Qt and GTK+ build.
1598
1599         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1600         (webkit_test_plugin_new_instance):
1601         (webkit_test_plugin_destroy_stream):
1602
1603 2010-07-29  Anders Carlsson  <andersca@apple.com>
1604
1605         Another build fix attempt.
1606
1607         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1608         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1609         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1610         (webkit_test_plugin_new_instance):
1611         * GNUmakefile.am:
1612
1613 2010-07-29  Anders Carlsson  <andersca@apple.com>
1614
1615         Try to fix Windows and Unix builds.
1616
1617         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1618         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1619         (webkit_test_plugin_new_instance):
1620         (webkit_test_plugin_destroy_stream):
1621
1622 2010-07-29  Anders Carlsson  <andersca@apple.com>
1623
1624         Reviewed by Sam Weinig.
1625
1626         Refactor TestNetscapePlugin so tests can be split in separate files
1627         https://bugs.webkit.org/show_bug.cgi?id=43220
1628
1629         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1630         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
1631
1632         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1633         (pluginAllocate):
1634         Initialize pluginTest to 0. Remove testDocumentOpenInDestroyStream.
1635
1636         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1637         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Added.
1638         (PluginTest::PluginTest):
1639         Initialize m_npp and the test identifier.
1640         
1641         (PluginTest::createTestFunctions):
1642         Return the map from identifiers to createTest functions.
1643
1644         (PluginTest::registerCreateTestFunction):
1645         Insert the identifier and create function pair in the map.
1646
1647         (PluginTest::create):
1648         Look for a createTest function. If one is found, call it. Otherwise create a vanilla PluginTest object.
1649
1650         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added.
1651         (PluginTest::Register::Register):
1652         Helper class template for registering plug-in tests.
1653         
1654         (PluginTest::Register::create):
1655         Create a new test of the given type.
1656
1657         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp: Added.
1658         (DocumentOpenInDestroyStream::DocumentOpenInDestroyStream):
1659         Add a test that calls testDocumentOpen from its NPP_DestroyStream callback.
1660
1661         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1662         (NPP_New):
1663         Create a PluginTest given the identifier. Remove the check for "testdocumentopenindestroystream".
1664
1665         (NPP_DestroyStream):
1666         Call the plug-in test NPP_DestroyStream member function.
1667
1668         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1669         Add PluginTest.cpp, PluginTest.h and Tests/DocumentOpenInDestroyStream.cpp.
1670
1671 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
1672
1673         Unreviewed build fix.
1674
1675         Add missing second argument to assert_lint in new style checker tests.
1676
1677         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1678
1679 2010-07-29  Anders Carlsson  <andersca@apple.com>
1680
1681         Reviewed by Adam Roben.
1682
1683         check-webkit-style shouldn't complain about NPAPI functions
1684         https://bugs.webkit.org/show_bug.cgi?id=43211
1685
1686         Allow underscores in functions that start with NPN_, NPP_ or NP_.
1687
1688         * Scripts/webkitpy/style/checkers/cpp.py:
1689         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1690
1691 2010-07-29  Victor Wang  <victorw@chromium.org>
1692
1693         Unreviewed, rolling out r64270.
1694         http://trac.webkit.org/changeset/64270
1695         https://bugs.webkit.org/show_bug.cgi?id=39589
1696
1697         The patch breaks chromium webkit unittest
1698
1699         * DumpRenderTree/LayoutTestController.cpp:
1700         (LayoutTestController::staticFunctions):
1701         * DumpRenderTree/LayoutTestController.h:
1702         * DumpRenderTree/chromium/LayoutTestController.cpp:
1703         (LayoutTestController::LayoutTestController):
1704         * DumpRenderTree/chromium/LayoutTestController.h:
1705         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1706         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1707         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1708         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1709         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1710         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1711         * Scripts/build-webkit:
1712
1713 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1714
1715         Reviewed by Kenneth Christiansen.
1716
1717         [Qt] QtTestBrowser: Move WebPage class methods definitions from main.cpp to webpage.cpp
1718         https://bugs.webkit.org/show_bug.cgi?id=43199
1719
1720         There is no sense in keeping WebPage method definitions in main.cpp once
1721         webpage.cpp already exists.
1722
1723         No behavior change.
1724
1725         * QtTestBrowser/main.cpp:
1726         * QtTestBrowser/webpage.cpp:
1727         (WebPage::createWindow):
1728         (WebPage::createPlugin):
1729
1730 2010-07-29  Antonio Gomes  <tonikitoo@webkit.org>
1731
1732         Reviewed by Kenneth Christiansen.
1733
1734         [Qt] Factor out LauncherWindow class out of main.cpp (QtTestBrowser)
1735         https://bugs.webkit.org/show_bug.cgi?id=43170
1736
1737         Moving LauncherWindow class out of main.cpp to its own .cpp and .h files:
1738         launcherwindow.{cpp|h}
1739
1740         No behavior change.
1741
1742         Also changed all global static variables (named "gXXX") from main.cpp to
1743         static public variables of the LauncherWindow class.
1744
1745         * QtTestBrowser/QtTestBrowser.pro:
1746         * QtTestBrowser/launcherwindow.cpp: Added.
1747         * QtTestBrowser/launcherwindow.h: Added.
1748         * QtTestBrowser/main.cpp:
1749         (LauncherApplication::handleUserOptions):
1750         (main):
1751
1752 2010-07-29  Martin Robinson  <mrobinson@igalia.com>
1753
1754         Reviewed by Xan Lopez.
1755
1756         Build fix for building against GTK+ 3.x. GSEAL requires that we
1757         access internals of the GdkDragContext via methods. For older versions
1758         of GTK+, define those methods.
1759
1760         * DumpRenderTree/gtk/EventSender.cpp:
1761         (gdk_drag_context_get_selected_action): Added.
1762         (gdk_drag_context_get_actions): Added.
1763         (dispatchEvent): Use the two new accessor methods.
1764
1765 2010-07-29  Adam Roben  <aroben@apple.com>
1766
1767         Always say "plugins directory" when referring to a directory
1768         containing one or more plugins
1769
1770         Fixes <http://webkit.org/b/43197> WebKit2 often says "plugin
1771         directory" when it means "plugins directory"
1772
1773         Reviewed by John Sullivan.
1774
1775         * WebKitTestRunner/TestController.cpp:
1776         (WTR::TestController::initialize): Updated for rename.
1777
1778 2010-07-29  Adam Roben  <aroben@apple.com>
1779
1780         Always say "directory" when referring to a plugin directory
1781
1782         Fixes <http://webkit.org/b/43195> WebKit2 often says "plugin path"
1783         when it means "plugin directory"
1784
1785         Reviewed by John Sullivan.
1786
1787         * WebKitTestRunner/TestController.cpp:
1788         (WTR::TestController::initialize): Updated for renames.
1789
1790         * WebKitTestRunner/TestController.h: Renamed m_testPluginPath to
1791         m_testPluginDirectory.
1792         (WTR::TestController::testPluginDirectory): Renamed from
1793         testPluginPath.
1794
1795         * WebKitTestRunner/mac/TestControllerMac.mm:
1796         (WTR::TestController::initializeTestPluginDirectory):
1797         * WebKitTestRunner/win/TestControllerWin.cpp:
1798         (WTR::TestController::initializeTestPluginDirectory):
1799         Renamed from initializeTestPluginPath and updated for rename.
1800
1801 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
1802
1803          Reviewed by Antonio Gomes.
1804
1805          Initialize all members of NPClass struct.
1806          https://bugs.webkit.org/show_bug.cgi?id=43193
1807
1808          * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1809
1810 2010-07-29  Csaba Osztrogonác  <ossy@webkit.org>
1811
1812         Reviewed by Antonio Gomes.
1813
1814         Warning fix on platforms where XP_MACOSX is undefined.
1815         https://bugs.webkit.org/show_bug.cgi?id=43192
1816
1817         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1818         Use #if defined(XP_MACOSX) instead of #if XP_MACOSX .
1819
1820 2010-07-29  Adam Roben  <aroben@apple.com>
1821
1822         Give find-included-framework-headers our standard license
1823
1824         * Scripts/find-included-framework-headers: Used the license from
1825         WebCore/LICENSE-APPLE.
1826
1827 2010-07-29  Adam Roben  <aroben@apple.com>
1828
1829         Speed up find-included-framework-headers
1830
1831         We only do one invocation of find now, no longer pipe to grep, and
1832         replace uniq with sort -u.
1833
1834         Also added a license header.
1835
1836         * Scripts/find-included-framework-headers:
1837
1838 2010-07-29  Steve Block  <steveblock@google.com>
1839
1840         Reviewed by Jeremy Orlow.
1841
1842         Add LayoutTestController methods to test DeviceOrientation
1843         https://bugs.webkit.org/show_bug.cgi?id=39589
1844
1845         * DumpRenderTree/LayoutTestController.cpp:
1846         (setMockDeviceOrientationCallback):
1847         (LayoutTestController::staticFunctions):
1848         * DumpRenderTree/LayoutTestController.h:
1849         * DumpRenderTree/chromium/LayoutTestController.cpp:
1850         * DumpRenderTree/chromium/LayoutTestController.h:
1851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1852         (LayoutTestController::setMockDeviceOrientation):
1853         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1854         (LayoutTestController::setMockDeviceOrientation):
1855         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1856         (LayoutTestController::setMockDeviceOrientation):
1857         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1858         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1859         (LayoutTestController::setMockDeviceOrientation):
1860         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1861         (LayoutTestController::setMockDeviceOrientation):
1862         * Scripts/build-webkit:
1863
1864 2010-07-28  Kenichi Ishibashi  <bashi@google.com>
1865
1866         Reviewed by Shinichiro Hamaji.
1867
1868         Fixed <https://bugs.webkit.org/show_bug.cgi?id=33814>
1869         check-webkit-style gives false positives in single-line functions.
1870
1871         * Scripts/webkitpy/style/checkers/cpp.py:
1872         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1873
1874 2010-07-28  Darin Adler  <darin@apple.com>
1875
1876         Reviewed by Sam Weinig.
1877
1878         WebKitTestRunner needs to support layoutTestController.execCommand
1879         <https://bugs.webkit.org/show_bug.cgi?id=42538>
1880
1881         WebKitTestRunner needs layoutTestController.isCommandEnabled
1882         <https://bugs.webkit.org/show_bug.cgi?id=42671>
1883
1884         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1885         Added execCommand and isCommandEnabled.
1886         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1887         (WTR::LayoutTestController::execCommand): Added.
1888         (WTR::LayoutTestController::isCommandEnabled): Added.
1889         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
1890
1891 2010-07-28  Kent Tamura  <tkent@chromium.org>
1892
1893         Reviewed by Dimitri Glazkov.
1894
1895         [DRT/Chromium] Introduce drt_expectations.txt for NRWT
1896         https://bugs.webkit.org/show_bug.cgi?id=43123
1897
1898         Introduce LayoutTests/platform/chromium/drt_expectations.txt,
1899         which overrides test expectations only for DumpRenderTree, in
1900         order to manage what problems are investigated.
1901         This change will be reverted when we switch to DRT completely.
1902
1903         * Scripts/webkitpy/layout_tests/port/chromium.py:
1904          Add drt_expectations.txt content to the result of
1905          test_expectations_overrides() if --use-drt is specified.
1906
1907 2010-07-28  Brady Eidson  <beidson@apple.com>
1908
1909         Reviewed by Darin Adler.
1910
1911         First pass at visited link support for WK2
1912         https://bugs.webkit.org/show_bug.cgi?id=43157
1913
1914         * MiniBrowser/mac/AppDelegate.m:
1915         (didNavigateWithNavigationData):
1916         (didPerformClientRedirect):
1917         (didPerformServerRedirect):
1918         (didUpdateHistoryTitle):
1919         (populateVisitedLinks): Added for the new version of the HistoryClient.
1920         (-[BrowserAppDelegate init]): Set the HistoryClient right after creating the context(s)
1921         
1922         * MiniBrowser/mac/BrowserWindowController.m:
1923         (-[BrowserWindowController awakeFromNib]):
1924
1925 2010-07-28  Robin Dunn  <robin@alldunn.com>
1926
1927         Reviewed by Kevin Ollivier.
1928
1929         Add DOM bindings support for wx port.
1930
1931         * DumpRenderTree/wscript:
1932         * wx/browser/wscript:
1933         * wx/build/settings.py:
1934
1935 2010-07-28  Tony Chang  <tony@chromium.org>
1936
1937         Reviewed by Kent Tamura.
1938
1939         [chromium] cleanup temp files left by Linux DRT
1940         https://bugs.webkit.org/show_bug.cgi?id=43062
1941
1942         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename the chromium bots to include the OS
1943         * BuildSlaveSupport/build.webkit.org-config/master.cfg: add a step on chromium-linux to delete temp files left
1944             by crashed DRTs
1945
1946 2010-07-28  Antonio Gomes  <tonikitoo@webkit.org>
1947
1948         Rubber-stamped by Kenneth Christiansen.
1949
1950         More Developer menu items reordering.
1951
1952         Grouping related menu items together, visually and logically (in the code).
1953
1954         No behavior change.
1955
1956         * QtTestBrowser/main.cpp:
1957         (LauncherWindow::createChrome):
1958
1959 2010-07-27  Kinuko Yasuda  <kinuko@chromium.org>
1960
1961         Reviewed by Ojan Vafai.
1962
1963         Add FILE_SYSTEM build flag for FileSystem API
1964         https://bugs.webkit.org/show_bug.cgi?id=42915
1965
1966         * Scripts/build-webkit:
1967
1968 2010-07-27  Martin Robinson  <mrobinson@igalia.com>
1969
1970         Reviewed by David Levin.
1971
1972         Stylebot should not complain about NULL usage in calls to gdk_pixbuf_save_to
1973         https://bugs.webkit.org/show_bug.cgi?id=43090
1974
1975         * Scripts/webkitpy/style/checkers/cpp.py: Add exemption for some GdkPixbuf methods.
1976         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for this behavior.
1977
1978 2010-07-27  Kent Tamura  <tkent@chromium.org>
1979
1980         Unreviewed, trivial typo fix.
1981
1982         * Scripts/webkitpy/layout_tests/port/chromium.py:
1983           Fix a wrong method name committed by r64109.
1984
1985 2010-07-27  Sam Weinig  <sam@webkit.org>
1986
1987         Reviewed by Anders Carlsson.
1988
1989         Patch for https://bugs.webkit.org/show_bug.cgi?id=43087
1990         Clean up handling of strings at the WebKit2 API layer.
1991
1992         * MiniBrowser/mac/BrowserWindowController.m:
1993         (runJavaScriptAlert):
1994         (runJavaScriptConfirm):
1995         (runJavaScriptPrompt):
1996         (didNavigateWithNavigationData):
1997         (-[BrowserWindowController updateProvisionalURLForFrame:]):
1998         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1999         (_didClearWindowForFrame):
2000
2001 2010-07-27  Ojan Vafai  <ojan@chromium.org>
2002
2003         Reviewed by Eric Seidel.
2004
2005         webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'
2006         https://bugs.webkit.org/show_bug.cgi?id=42984
2007
2008         squash and no_squash have been intentionally erroring for a couple weeks now.
2009         But post-commits was just broken. Just remove squash/no_squash.
2010
2011         * Scripts/webkitpy/tool/steps/abstractstep.py:
2012         * Scripts/webkitpy/tool/steps/options.py:
2013
2014 2010-07-27  Kevin Ollivier  <kevino@theolliviers.com>
2015
2016         [wx] Build fix after introduction of EXECUTABLE_ALLOCATOR_DEMAND.
2017
2018         * wx/build/settings.py:
2019
2020 2010-07-27  Adam Roben  <aroben@apple.com>
2021
2022         Mac build fix
2023
2024         * MiniBrowser/mac/BrowserWindowController.m:
2025         (processDidExit):
2026         (-[BrowserWindowController awakeFromNib]):
2027         Added processDidExit support.
2028
2029 2010-07-26  Antonio Gomes  <tonikitoo@webkit.org>
2030
2031         Rubber-stamped by Simon Hausmann.
2032
2033         [Qt] Reorder some items in Developers' menu so QGraphicsView one is easier accessible.
2034
2035         Move some less useful menu items on Developers menu from the top to the bottom, so
2036         QGraphicsView menu goes to the top, and becomes more quickly accessible.
2037
2038         * QtTestBrowser/main.cpp:
2039         (LauncherWindow::createChrome):
2040
2041 2010-07-26  Adam Roben  <aroben@apple.com>
2042
2043         Fix the path to InjectedBundle.dll in Debug_Internal builds
2044
2045         Fixes <http://webkit.org/b/42994> WebKitTestRunner fails to load
2046         InjectedBundle.dll in the Debug_Internal configuration
2047
2048         Reviewed by Anders Carlsson.
2049
2050         * WebKitTestRunner/win/TestControllerWin.cpp:
2051         (WTR::TestController::initializeInjectedBundlePath): Add the _debug
2052         suffix only in Debug_All builds.
2053
2054 2010-07-25  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2055
2056         Reviewed by Darin Adler.
2057
2058         https://bugs.webkit.org/show_bug.cgi?id=42947
2059         Check for WEBKIT_TESTFONTS for qt, gtk and windows port and throw 
2060         error. Without which dumpRenderTree crashes.
2061
2062         * Scripts/old-run-webkit-tests:
2063
2064 2010-07-27  Kent Tamura  <tkent@chromium.org>
2065
2066         Reviewed by Dimitri Glazkov.
2067
2068         https://bugs.webkit.org/show_bug.cgi?id=42956
2069         [DRT/Chromium] Fix "out of sync" assertion error
2070
2071         Fix an assertion error on Windows like the following:
2072         100721 20:16:46 chromium.py:386  CRITICAL Test got out of sync:
2073         |file:///c:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2074         |file:///C:/WebKitBuildSlave2/chromium-win-release-tests/build/LayoutTests/http/tests/local/blob/send-data-blob.html|
2075
2076         * Scripts/webkitpy/layout_tests/port/chromium.py:
2077         If the url matches with "file:///[a-z]:", does case-ignore comparison.
2078         GURL capitalize the driver letter of a file: URL.
2079
2080 2010-07-26  Darin Adler  <darin@apple.com>
2081
2082         Reviewed by Sam Weinig.
2083
2084         WebKitTestRunner needs to support layoutTestController.counterValueForElementById
2085         https://bugs.webkit.org/show_bug.cgi?id=42537
2086
2087         WebKitTestRunner needs layoutTestController.markerTextForListItem
2088         https://bugs.webkit.org/show_bug.cgi?id=42549
2089
2090         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2091         Fixed _paramterExpression typo. Improved support for string type as a
2092         return value, so we don't try to include DOMString.h and we can convert
2093         the string to a JSValue by calling JSValueMakeStringOrNull.
2094
2095         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
2096         Added JSValueMakeStringOrNull, used by the code generator.
2097
2098         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2099         Added counterValueForElementById and markerTextForListItem.
2100
2101         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2102         Moved constant to the top of the file.
2103         (WTR::toCF): Added. Converts strings to CFStringRef.
2104         (WTR::toWK): Added. Converts strings to WKStringRef.
2105         (WTR::toJS): Added. Converts strings to JSStringRef.
2106         (WTR::setProperty): Moved this function to the top of the file
2107         rather than having it down where it's used inside the class. Also
2108         renamed it so it's a separate function rather than an overload of
2109         JSObjectSetProperty.
2110         (WTR::propertyValue): Copied this here from InjectedBundlePage.cpp.
2111         Should move it somewhere we can share it.
2112         (WTR::propertyObject): Ditto.
2113         (WTR::getElementById): Added. Calls getElementById through the magic
2114         of JavaScript.
2115         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2116         Chagned to use toWK instead of four local variables.
2117         (WTR::LayoutTestController::counterValueForElementById): Added.
2118         Calls WKBundleFrameCopyCounterValue.
2119         (WTR::LayoutTestController::markerTextForListItem): Added.
2120         Calls WKBundleFrameCopyMarkerText.
2121
2122         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2123         Added counterValueForElementById and markerTextForListItem.
2124
2125 2010-07-26  Martin Robinson  <mrobinson@igalia.com>
2126
2127         Reviewed by Gustavo Noronha Silva.
2128
2129         [GTK] The EventSender should support simulating drop events
2130         https://bugs.webkit.org/show_bug.cgi?id=39844
2131
2132         Add initial dropping support to the GTK+ EventSender.
2133
2134         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2135         (createWebView): Listen for some new drag-and-drop signals.
2136         * DumpRenderTree/gtk/EventSender.cpp: Add currentDragSourceContext.
2137         (dispatchEvent):
2138         Detect situations where a drag is either starting or ending and massage
2139         GTK+ into sending the appropriate signals to the WebView.
2140         (replaySavedEvents): Remove comment.
2141         (makeEventSender): Clear the currentDragSourceContext when creating a new EventSender.
2142         (dragBeginCallback): Capture the new currentDragSourceContext when a drag begins.
2143         (dragEndCallback): Clear the currentDragSourceContext when a drag ends.
2144         (dragFailedCallback): Disable the GTK+ drag failed animation.
2145         * DumpRenderTree/gtk/EventSender.h: Add declarations for new signal callbacks.
2146
2147 2010-07-26  Daniel Bates  <dbates@rim.com>
2148
2149         Reviewed by Darin Adler.
2150
2151         svn-unapply warns of uninitialized variable when unapplying
2152         a patch that describes an svn move operation
2153         https://bugs.webkit.org/show_bug.cgi?id=42036
2154
2155         Fixes Perl uninitialized variable warnings when un-applying
2156         a patch that moves a file.
2157
2158         * Scripts/svn-unapply:
2159           - Modified patch() so that it initializes $patch to the empty
2160             string when we don't have svnConvertedText (such as when
2161             reversing a diff that represents a svn copy/move operation).
2162
2163 2010-07-26  Sam Weinig  <sam@webkit.org>
2164
2165         Reviewed by Anders Carlsson.
2166
2167         Move some non-APIish functions into private headers.
2168
2169         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2170         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2171
2172 2010-07-26  Sam Weinig  <sam@webkit.org>
2173
2174         Reviewed by Anders Carlsson.
2175
2176         Fix for https://bugs.webkit.org/show_bug.cgi?id=42986
2177         Add prompt and confirm client functions to WebKit2
2178
2179         * MiniBrowser/mac/BrowserWindowController.m:
2180         (-[BrowserWindowController awakeFromNib]):
2181
2182 2010-07-26  Adam Roben  <aroben@apple.com>
2183
2184         Windows build fix
2185
2186         * MiniBrowser/MiniBrowser.vcproj:
2187         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2188         Removed empty attributes so the values will be picked up from the
2189         vsprops files. (Also removed a couple of attributes that accidentally
2190         duplicated values from the vsprops files.)
2191
2192 2010-07-26  Brian Weinstein  <bweinstein@apple.com>
2193
2194         Rubber-stamped by Adam Roben.
2195         
2196         Touch MiniBrowser's stdafx to fix the build.
2197
2198         * MiniBrowser/win/stdafx.h:
2199
2200 2010-07-26  Hayato Ito  <hayato@chromium.org>
2201
2202         Reviewed by Shinichiro Hamaji.
2203
2204         Add pretty printer of WTF::Vector for GDB 7.
2205
2206         https://bugs.webkit.org/show_bug.cgi?id=40909
2207
2208         * gdb/wtf.py: Added.
2209
2210 2010-07-26  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2211
2212         Reviewed by Simon Hausmann.
2213
2214         [Qt] Fix feature detection regexp
2215
2216         We were missing the last feature
2217
2218         * Scripts/webkitdirs.pm:
2219
2220 2010-07-25  Darin Adler  <darin@apple.com>
2221
2222         Reviewed by Dan Bernstein.
2223
2224         WebKitTestRunner needs to support layoutTestController.dumpSelectionRect
2225         https://bugs.webkit.org/show_bug.cgi?id=42326
2226
2227         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2228         Added dumpSelectionRect.
2229
2230         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2231         (WTR::LayoutTestController::dumpSelectionRect): Added. For now, this
2232         does nothing because its purpose is to change pixel test output and
2233         we do not have pixel tests implemented yet.
2234
2235 2010-07-25  Darin Adler  <darin@apple.com>
2236
2237         Reviewed by Maciej Stachowiak.
2238
2239         WebKitTestRunner needs to support layoutTestController.keepWebHistory
2240         https://bugs.webkit.org/show_bug.cgi?id=42323
2241
2242         Added keepWebHistory and computedStyleIncludingVisitedInfo.
2243
2244         Also fixed misspellings of the word "receive".
2245
2246         Also tweaked the names of some of the LayoutTestController members.
2247
2248         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2249         Added support for a type named "object" that is passed and returns as
2250         a JSValueRef.
2251
2252         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2253         Added keepWebHistory and computedStyleIncludingVisitedInfo. Also
2254         put setAcceptsEditing up nearer the top.
2255
2256         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2257         (WTR::InjectedBundle::_didReceiveMessage): Fixed mispellings of receive.
2258         (WTR::InjectedBundle::initialize): Ditto.
2259         (WTR::InjectedBundle::didReceiveMessage): Ditto.
2260         (WTR::InjectedBundle::reset): Reset the state of visited links between
2261         tests. Also eliminated the unused argument to the LayoutTestController
2262         create function.
2263         (WTR::InjectedBundle::setShouldTrackVisitedLinks): Added.
2264         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2265
2266         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2267         (WTR::InjectedBundlePage::shouldBeginEditing): Call shouldAllowEditing
2268         instead of acceptsEditing.
2269         (WTR::InjectedBundlePage::shouldEndEditing): Ditto.
2270         (WTR::InjectedBundlePage::shouldInsertNode): Ditto.
2271         (WTR::InjectedBundlePage::shouldInsertText): Ditto.
2272         (WTR::InjectedBundlePage::shouldDeleteRange): Ditto.
2273         (WTR::InjectedBundlePage::shouldChangeSelectedRange): Ditto.
2274         (WTR::InjectedBundlePage::shouldApplyStyle): Ditto.
2275
2276         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2277         (WTR::LayoutTestController::create): Removed uneeded argument.
2278         (WTR::LayoutTestController::LayoutTestController): Removed unneeded
2279         argument. Updated for rename of m_acceptsEditing to m_shouldAllowEditing.
2280         (WTR::LayoutTestController::numberOfActiveAnimations): Added some FIXMEs
2281         about the fact that this works on the main frame.
2282         (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
2283         (WTR::LayoutTestController::keepWebHistory): Added.
2284         (WTR::LayoutTestController::computedStyleIncludingVisitedInfo): Added.
2285         (WTR::JSObjectSetProperty): Added. Helper to make the function below
2286         cleaner.
2287         (WTR::LayoutTestController::makeWindowObject): Changed to use the
2288         overload of JSObjectSetProperty above.
2289
2290         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Changes to
2291         match above.
2292
2293         * WebKitTestRunner/TestController.cpp:
2294         (WTR::TestController::initialize): Fixed mispellings of receive.
2295         (WTR::TestController::_didReceiveMessageFromInjectedBundle): Ditto.
2296         (WTR::TestController::didReceiveMessageFromInjectedBundle): Ditto.
2297         * WebKitTestRunner/TestController.h: Ditto.
2298         * WebKitTestRunner/TestInvocation.cpp:
2299         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Ditto.
2300         * WebKitTestRunner/TestInvocation.h: Ditto.
2301
2302 2010-07-25  Alexey Proskuryakov  <ap@apple.com>
2303
2304         Reviewed by Sam Weinig.
2305
2306         https://bugs.webkit.org/show_bug.cgi?id=42193
2307         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2308
2309         Step 2 - add the rest of editing delegates.
2310
2311         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2312         (WTR::operator<<): Fixed to not crash when range is null.
2313         (WTR::InjectedBundlePage::InjectedBundlePage):
2314         (WTR::InjectedBundlePage::_shouldEndEditing):
2315         (WTR::InjectedBundlePage::_shouldInsertNode):
2316         (WTR::InjectedBundlePage::_shouldInsertText):
2317         (WTR::InjectedBundlePage::_shouldDeleteRange):
2318         (WTR::InjectedBundlePage::_shouldChangeSelectedRange):
2319         (WTR::InjectedBundlePage::_shouldApplyStyle):
2320         (WTR::InjectedBundlePage::_didBeginEditing):
2321         (WTR::InjectedBundlePage::_didEndEditing):
2322         (WTR::InjectedBundlePage::_didChange):
2323         (WTR::InjectedBundlePage::_didChangeSelection):
2324         (WTR::InjectedBundlePage::shouldEndEditing):
2325         (WTR::InjectedBundlePage::shouldInsertNode):
2326         (WTR::InjectedBundlePage::shouldInsertText):
2327         (WTR::InjectedBundlePage::shouldDeleteRange):
2328         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2329         (WTR::InjectedBundlePage::shouldApplyStyle):
2330         (WTR::InjectedBundlePage::didBeginEditing):
2331         (WTR::InjectedBundlePage::didEndEditing):
2332         (WTR::InjectedBundlePage::didChange):
2333         (WTR::InjectedBundlePage::didChangeSelection):
2334         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2335
2336 2010-07-24  Chris Fleizach  <cfleizach@apple.com>
2337
2338         Reviewed by David Kilzer.
2339
2340         AX: need a layout test testing misspelled words in attributed strings
2341         https://bugs.webkit.org/show_bug.cgi?id=42899
2342
2343         * DumpRenderTree/AccessibilityUIElement.cpp:
2344         (attributedStringForRangeCallback):
2345         (attributedStringRangeIsMisspelledCallback):
2346         (AccessibilityUIElement::getJSClass):
2347         * DumpRenderTree/AccessibilityUIElement.h:
2348         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2349         (AccessibilityUIElement::attributedStringForRange):
2350         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2351         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2352         (AccessibilityUIElement::attributedStringForRange):
2353         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2354         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2355         (AccessibilityUIElement::attributedStringForRange):
2356         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2357
2358 2010-07-23  David Kilzer  <ddkilzer@apple.com>
2359
2360         <http://webkit.org/b/42911> Update ruby tools to work with shallow framework bundles
2361
2362         Reviewed by Mark Rowe.
2363
2364         * Scripts/check-for-inappropriate-files-in-framework: Added
2365         check for the SHALLOW_BUNDLE environment variable so that the
2366         script will work with iOS WebKit builds.
2367         * Scripts/check-for-webkit-framework-include-consistency: Ditto.
2368
2369 2010-07-22  Darin Adler  <darin@apple.com>
2370
2371         Reviewed by Sam Weinig.
2372
2373         Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
2374         https://bugs.webkit.org/show_bug.cgi?id=42847
2375
2376         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2377         (WTR::operator<<): Replaced the WKStringToUTF8 function with
2378         a set of overloaded stream operators.
2379         (WTR::dumpPath): Changed to use ostringstream and return a string.
2380         (WTR::propertyValue): Added.
2381         (WTR::propertyObject): Added.
2382         (WTR::propertyString): Added.
2383         (WTR::numericWindowPropertyValue): Changed to call propertyValue.
2384         (WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
2385         since we now have suitable streaming functions.
2386         (WTR::dumpFrameText): Use propertyObject and propertyString instead of
2387         WKBundleFrameCopyInnerText.
2388         (WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
2389         since we now have suitable streaming functions.
2390         (WTR::InjectedBundlePage::dump): Ditto.
2391         (WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
2392         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
2393         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
2394         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
2395         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2396
2397 2010-07-22  Alexey Proskuryakov  <ap@apple.com>
2398
2399         Reviewed by Sam Weinig and Darin Adler.
2400
2401         https://bugs.webkit.org/show_bug.cgi?id=42193
2402         Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
2403
2404         Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
2405         fixed, but this makes difference one line smaller on many editing tests.
2406
2407         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2408         Added dumpEditingCallbacks() and setAcceptsEditing().
2409
2410         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2411         (WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
2412         (WTR::operator<<): Print a range.
2413         (WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
2414         clients.
2415         (WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
2416         (WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
2417         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
2418         calls.
2419
2420         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2421         (WTR::LayoutTestController::LayoutTestController):
2422         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2423         (WTR::LayoutTestController::dumpEditingCallbacks):
2424         (WTR::LayoutTestController::setAcceptsEditing):
2425         (WTR::LayoutTestController::acceptsEditing):
2426         (WTR::LayoutTestController::shouldDumpEditingCallbacks):
2427         Store m_acceptsEditing and m_dumpEditingCallbacks.
2428
2429 2010-07-22  Yael Aharon  <yael.aharon@nokia.com>
2430
2431         Reviewed by Laszlo Gombos.
2432
2433         [Qt] QtWebKit needs public API for Notifications.
2434         https://bugs.webkit.org/show_bug.cgi?id=41413
2435
2436         Update DumpRenderTree and QtTestBrowser to use the new API.
2437         Add new DRT API to flag that notifications permission requests should be ignored.
2438
2439         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2440         (WebCore::WebPage::WebPage):
2441         (WebCore::WebPage::requestPermission):
2442         (WebCore::WebPage::checkPermission):
2443         (WebCore::WebPage::cancelRequestsForPermission):
2444         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2445         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2446         (LayoutTestController::reset):
2447         (LayoutTestController::ignoreDesktopNotificationPermissionRequests):
2448         (LayoutTestController::checkDesktopNotificationPermission):
2449         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2450         (LayoutTestController::ignoreReqestForPermission):
2451         * QtTestBrowser/main.cpp:
2452         (LauncherWindow::LauncherWindow):
2453         * QtTestBrowser/webpage.cpp:
2454         (WebPage::WebPage):
2455         (WebPage::requestPermission):
2456         (WebPage::checkPermission):
2457         (WebPage::cancelRequestsForPermission):
2458         * QtTestBrowser/webpage.h:
2459
2460 2010-07-22  Darin Adler  <darin@apple.com>
2461
2462         Reviewed by Sam Weinig.
2463
2464         WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
2465         https://bugs.webkit.org/show_bug.cgi?id=42325
2466
2467         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2468         Added dumpChildFramesAsText.
2469
2470         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2471         (WTR::dumpFrameText): Added.
2472         (WTR::dumpDescendantFramesText): Added.
2473         (WTR::InjectedBundlePage::dumpAllFramesText): Added.
2474         (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
2475         instead of the shouldDumpAsText function, and added a case for AllFramesText.
2476
2477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
2478
2479         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2480         (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
2481         m_whatToDump.
2482
2483         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
2484         dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
2485         and shouldDumpSourceAsWebArchive. Added whatToDump.
2486
2487 2010-07-22  Adam Roben  <aroben@apple.com>
2488
2489         Windows build fix
2490
2491         Inspired by r63881.
2492
2493         * MiniBrowser/MiniBrowser.vcproj:
2494         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2495         Removed pre- and post-build events so they will be inherited from the
2496         vsprops files.
2497
2498 2010-07-21  Darin Adler  <darin@apple.com>
2499
2500         Reviewed by Sam Weinig.
2501
2502         WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
2503         https://bugs.webkit.org/show_bug.cgi?id=42548
2504
2505         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2506         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2507         (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
2508         (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
2509         Changed to a file-internal function instead of a member function.
2510         (WTR::dumpDescendantFrameScrollPositions): Added.
2511         (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
2512         (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
2513         appropriate. Also streamlined all the WKStringToUTF8 call sites.
2514         (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
2515         (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
2516         (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
2517         (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
2518         (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
2519
2520         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
2521
2522         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2523         (WTR::LayoutTestController::LayoutTestController): Initialize
2524         m_shouldDumpAllFrameScrollPositions.
2525         (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
2526         shouldDumpFrameScrollPositions.
2527
2528         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
2529         bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
2530         and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2531
2532 2010-07-21  Darin Adler  <darin@apple.com>
2533
2534         Reviewed by Sam Weinig.
2535
2536         WebKitTestRunner needs to support dumping of scroll position
2537         https://bugs.webkit.org/show_bug.cgi?id=42514
2538
2539         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2540         (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.
2541
2542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2543         (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
2544         instead of JSContextRef.
2545         (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
2546         (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
2547         (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
2548         (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
2549         instead of JSContextRef.
2550
2551         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
2552         arguments that simply repeat the argument type. Added dumpFrameScrollPosition.
2553
2554         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2555         (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
2556         returns false.
2557         (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
2558         returns false.
2559         (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
2560         the logic in DumpRenderTree.
2561
2562         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.
2563
2564         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
2565
2566 2010-07-21  Kevin Ollivier  <kevino@theolliviers.com>
2567
2568         [wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
2569
2570         * wx/build/settings.py:
2571
2572 2010-07-21  Sam Weinig  <sam@webkit.org>
2573
2574         Reviewed by Anders Carlsson.
2575
2576         Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
2577         WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages
2578
2579         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2580         (WTR::InjectedBundlePage::InjectedBundlePage):
2581         (WTR::InjectedBundlePage::_willAddMessageToConsole):
2582         (WTR::InjectedBundlePage::_willSetStatusbarText):
2583         (WTR::InjectedBundlePage::_willRunJavaScriptAlert):
2584         (WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
2585         (WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
2586         (WTR::InjectedBundlePage::willAddMessageToConsole):
2587         (WTR::InjectedBundlePage::willSetStatusbarText):
2588         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
2589         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
2590         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
2591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2592
2593 2010-07-21  Adam Roben  <aroben@apple.com>
2594
2595         Give InjectedBundle our standard set of configurations (minus the
2596         *_Cairo variants)
2597
2598         InjectedBundle's Debug_All configuration was the same as is Debug
2599         configuration, and it was missing a Debug_Internal configuration.
2600
2601         Fixes <http://webkit.org/b/42749> InjectedBundle's build
2602         configurations are screwy
2603
2604         Reviewed by Darin Adler.
2605
2606         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
2607         debug_internal.vsprops and debug_all.vsprops to the Debug_All
2608         configuration. Added a Debug_Internal configuration.
2609
2610         * WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
2611         variant of InjectedBundle when we're using the Debug_Internal solution
2612         configuration.
2613
2614 2010-07-21  Adam Roben  <aroben@apple.com>
2615
2616         Move InjectedBundle's settings to a vsprops file
2617
2618         This will make it easier to change settings for all configurations,
2619         and to add new configurations.
2620
2621         Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
2622         files
2623
2624         Reviewed by Darin Adler.
2625
2626         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
2627         Moved settings here...
2628         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
2629         here.
2630
2631 2010-07-21  Adam Roben  <aroben@apple.com>
2632
2633         Give MiniBrowser our standard set of configurations (minus the *_Cairo
2634         variants)
2635
2636         MiniBrowser already had a configuration called "Release", but it was
2637         using mostly the same settings as Debug. And its Debug configuration
2638         was using the settings that Debug_Internal should be using.
2639
2640         Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
2641         are screwy
2642
2643         Reviewed by Darin Adler.
2644
2645         * MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
2646         the Debug configuration. Remove debug.vsprops and
2647         debug_internal.vsprops from the Release configuration and replace them
2648         with release.vsprops. Added Debug_Internal and Debug_All
2649         configurations.
2650
2651 2010-07-21  Adam Roben  <aroben@apple.com>
2652
2653         Move MiniBrowser's settings to a vsprops file
2654
2655         This will make it easier to change settings for all configurations,
2656         and to add new configurations.
2657
2658         MiniBrowser should use vsprops files
2659         https://bugs.webkit.org/show_bug.cgi?id=42745
2660
2661         Reviewed by Darin Adler.
2662
2663         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
2664         settings here...
2665         * MiniBrowser/MiniBrowser.vcproj: ...from here.
2666
2667 2010-07-21  Adam Roben  <aroben@apple.com>
2668
2669         Fix compiler warnings when building MiniBrowser
2670
2671         Also cleaned up the .vcproj a bit.
2672
2673         Fixes <http://webkit.org/b/42743>.
2674
2675         Reviewed by Darin Adler.
2676
2677         * MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
2678         already defined in .vsprops files. This also fixes a warning about
2679         /EDITANDCONTINUE being incompatible with /SAFESEH.
2680
2681         * MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
2682         that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
2683         being redefined. (I think this will also get us closer to building
2684         with VC++ Express.)
2685
2686 2010-07-20  Sam Weinig  <sam@webkit.org>
2687
2688         Reviewed by Jon Honeycutt.
2689
2690         Fix obvious typo.
2691
2692         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2693         (WTR::InjectedBundlePage::setStatusbarText): Need to call ->data() to actually get the string value.
2694
2695 2010-07-20  Tony Chang  <tony@chromium.org>
2696
2697         Reviewed by Kent Tamura.
2698
2699         [chromium] by default, dumpAsText should disable pixel results
2700         https://bugs.webkit.org/show_bug.cgi?id=42715
2701
2702         * DumpRenderTree/chromium/LayoutTestController.cpp:
2703         (LayoutTestController::dumpAsText): disable pixel results, but allow JS to override
2704
2705 2010-07-20  Adam Roben  <aroben@apple.com>
2706
2707         Windows build fix
2708
2709         * MiniBrowser/MiniBrowser.vcproj: Link against the new, shiny
2710         WebKit.lib instead of the old, dusty WebKit2.lib.
2711
2712 2010-07-20  Adam Roben  <aroben@apple.com>
2713
2714         Stop linking WebKitTestRunner against getopt
2715
2716         Use of getopt was removed in r63700.
2717
2718         Fixes <http://webkit.org/b/42714> WebKitTestRunner links against
2719         getopt, but doesn't need to
2720
2721         Reviewed by Sam Weinig.
2722
2723         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Removed getopt.lib
2724         from all configurations.
2725
2726 2010-07-20  Adam Roben  <aroben@apple.com>
2727
2728         Make run-webkit-tests --webkit-test-runner "work" on Windows
2729
2730         WebKitTestRunner crashes on launch, but at least the scripts build and
2731         launch it!
2732
2733         Fixes <http://webkit.org/b/42709> run-webkit-tests
2734         --webkit-test-runner bails with an error on Windows
2735
2736         Reviewed by Anders Carlsson.
2737
2738         * Scripts/build-webkittestrunner: Build WebKitTestRunner.sln on
2739         Windows.
2740         * WebKitTestRunner/WebKitTestRunner.sln: Added. Contains the following
2741         projects (from first-built to last-built): FindSafari, ImageDiff,
2742         InjectedBundleGenerated, InjectedBundle, WebKitTestRunner.
2743
2744 2010-07-20  Adam Roben  <aroben@apple.com>
2745
2746         Change build-webkit back to building WebKit.sln on Windows
2747
2748         WebKit.sln builds all the same projects as WebKit2.sln, and the latter
2749         is being removed.
2750
2751         Rubber-stamped in advance by Steve Falkenburg.
2752
2753         * Scripts/build-webkit:
2754
2755 2010-07-20  Adam Roben  <aroben@apple.com>
2756
2757         Windows build fix
2758
2759         * MiniBrowser/win/BrowserWindow.cpp: Added missing #include.
2760
2761 2010-07-20  Joseph Pecoraro  <joepeck@webkit.org>
2762
2763         Reviewed by Geoffrey Garen.
2764
2765         WebScriptObject Should Allow Safely Checking For Key Existence
2766         https://bugs.webkit.org/show_bug.cgi?id=42613
2767
2768         Normal ObjCController workflow for a WebScriptObject test.
2769
2770         * DumpRenderTree/mac/ObjCController.m:
2771         (+[ObjCController isSelectorExcludedFromWebScript:]):
2772         (+[ObjCController webScriptNameForSelector:]):
2773         (-[ObjCController testHasWebScriptKey:]):
2774
2775 2010-07-20  Chris Marrin  <cmarrin@apple.com>
2776
2777         Reviewed by Simon Fraser.
2778
2779         https://bugs.webkit.org/show_bug.cgi?id=42118
2780         Disable compositing/webgl tests if WebGL is not enabled
2781
2782         * Scripts/old-run-webkit-tests:
2783
2784 2010-07-20  Anton Muhin  <antonm@chromium.org>
2785
2786         Reviewed by Darin Adler.
2787
2788         Print additional information about exception if failed to connect to apache (in verbose mode).
2789         https://bugs.webkit.org/show_bug.cgi?id=42627
2790
2791         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2792
2793 2010-07-20  Tony Chang  <tony@chromium.org>
2794
2795         Reviewed by David Levin.
2796
2797         [chromium] only pass --force to gclient sync if explicitly stated
2798         https://bugs.webkit.org/show_bug.cgi?id=42581
2799
2800         * BuildSlaveSupport/build.webkit.org-config/master.cfg: bots should
2801               always pass --force since it's hard to do manual cleanups
2802         * Scripts/update-webkit-chromium: only pass --force if --force is
2803               passed in
2804
2805 2010-07-19  Anders Carlsson  <andersca@apple.com>
2806
2807         Fix build.
2808
2809         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2810         Paths of generated files should be relative to the build product.
2811
2812 2010-07-19  Daniel Bates  <dbates@rim.com>
2813
2814         Reviewed by Adam Roben.
2815
2816         [Win] Implement LayoutTestController::markerTextForListItem()
2817         https://bugs.webkit.org/show_bug.cgi?id=37930
2818
2819         Implements DRT support for markerTextForListItem in the Windows port.
2820
2821         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2822         (LayoutTestController::markerTextForListItem): Implemented.
2823
2824 2010-07-19  Jessie Berlin  <jberlin@apple.com>
2825
2826         Windows build fix. Unreviewed.
2827
2828         * WebKitTestRunner/win/TestControllerWin.cpp:
2829         (WTR::TestController::initializeTestPluginPath):
2830
2831 2010-07-19  Sam Weinig  <sam@webkit.org>
2832
2833         Reviewed by Jon Honeycutt.
2834
2835         Remove dependency on getopt from WebKitTestRunner.
2836
2837         - Simplify options parsing and eliminate unused options.
2838
2839         * WebKitTestRunner/TestController.cpp:
2840         (WTR::TestController::TestController):
2841         (WTR::TestController::initialize):
2842         * WebKitTestRunner/TestController.h:
2843         (WTR::TestController::testPluginPath):
2844         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2845         * WebKitTestRunner/mac/TestControllerMac.mm:
2846         (WTR::TestController::platformInitialize):
2847         (WTR::TestController::initializeTestPluginPath):
2848         * WebKitTestRunner/win/TestControllerWin.cpp:
2849         (WTR::TestController::platformInitialize):
2850         (WTR::TestController::initializeTestPluginPath):
2851
2852 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
2853
2854         Reviewed by Antonio Gomes.
2855
2856         [Qt] MiniBrowser: Progress indication at address bar
2857         https://bugs.webkit.org/show_bug.cgi?id=42565
2858
2859         Make possible to see load progress at address bar based on
2860         QtTestBrowser solution
2861
2862         * MiniBrowser/qt/BrowserWindow.cpp:
2863         (BrowserWindow::BrowserWindow):
2864         (BrowserWindow::loadProgress):
2865         * MiniBrowser/qt/BrowserWindow.h:
2866
2867 2010-07-19  Diego Gonzalez  <diegohcg@webkit.org>
2868
2869         Reviewed by Antonio Gomes.
2870
2871         [Qt] Add MiniBrowser features: urlChanged, titleChanged and from user input load
2872         https://bugs.webkit.org/show_bug.cgi?id=42564
2873
2874         * MiniBrowser/qt/BrowserWindow.cpp:
2875         (BrowserView::load):
2876         (BrowserWindow::BrowserWindow):
2877         (BrowserWindow::titleChanged):
2878         (BrowserWindow::urlChanged):
2879         * MiniBrowser/qt/BrowserWindow.h:
2880
2881 2010-07-19  Sam Weinig  <weinig@apple.com>
2882
2883         Reviewed by Adam Roben.
2884
2885         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
2886         Auto-generate the JS bindings for WebKitTestRunner's script objects.
2887
2888         * WebKitTestRunner/Configurations/Base.xcconfig:
2889         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2890         * WebKitTestRunner/DerivedSources.make: Added.
2891         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
2892         * WebKitTestRunner/InjectedBundle/Bindings: Added.
2893         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
2894         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
2895         (WTR::JSWrappable::~JSWrappable):
2896         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
2897         (WTR::JSWrapper::wrap):
2898         (WTR::JSWrapper::unwrap):
2899         (WTR::unwrapObject):
2900         (WTR::JSWrapper::initialize):
2901         (WTR::JSWrapper::finalize):
2902         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
2903         (WTR::toJS):
2904         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
2905         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2906         (WTR::InjectedBundlePage::dump):
2907         (WTR::InjectedBundlePage::setStatusbarText):
2908         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2909         (WTR::LayoutTestController::wrapperClass):
2910         (WTR::LayoutTestController::waitUntilDone):
2911         (WTR::LayoutTestController::makeWindowObject):
2912         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2913         (WTR::LayoutTestController::shouldDumpAsText):
2914         (WTR::LayoutTestController::dumpAsText):
2915         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
2916         (WTR::LayoutTestController::dumpStatusCallbacks):
2917         (WTR::LayoutTestController::waitToDump):
2918         (WTR::LayoutTestController::testRepaint):
2919         (WTR::LayoutTestController::repaintSweepHorizontally):
2920         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
2921         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2922         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added.
2923         * WebKitTestRunner/win/build-generated-files.sh: Added.
2924
2925 2010-07-19  Mark Rowe  <mrowe@apple.com>
2926
2927         Clean up the buildbot configuration a little.
2928
2929         * BuildSlaveSupport/build.webkit.org-config/config.json:
2930
2931 2010-07-19  Chris Marrin  <cmarrin@apple.com>
2932
2933         Reviewed by Darin Adler.
2934
2935         https://bugs.webkit.org/show_bug.cgi?id=42118
2936         Disable WebGL on Leopard for now. 
2937
2938         LayoutTests fail on some graphics hardware on Leopard because one of the features we use,
2939         GL_ARB_framebuffer_object, is not universally available in Leopard like it is in
2940         SnowLeopard. This will allow LayoutTests to pass on Leopard until we add logic to use a
2941         software OpenGL driver on machines without this support.
2942
2943         * Scripts/build-webkit:
2944
2945 2010-07-19  Simon Fraser  <simon.fraser@apple.com>
2946
2947         Reviewed by Brady Eidson.
2948
2949         Fix MiniBrowser to update URL as you browse
2950         https://bugs.webkit.org/show_bug.cgi?id=42591
2951         
2952         Hook up various loading notifications to update the URL bar in MiniBrowser.
2953
2954         * MiniBrowser/mac/BrowserWindowController.m:
2955         (_didStartProvisionalLoadForFrame):
2956         (_didReceiveServerRedirectForProvisionalLoadForFrame):
2957         (_didFailProvisionalLoadWithErrorForFrame):
2958         (_didCommitLoadForFrame):
2959         (_didFailLoadWithErrorForFrame):
2960         (-[BrowserWindowController updateProvisionalURLForFrame:]):
2961         (-[BrowserWindowController didStartProvisionalLoadForFrame:]):
2962         (-[BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
2963         (-[BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
2964         (-[BrowserWindowController didFailLoadWithErrorForFrame:]):
2965         (-[BrowserWindowController didCommitLoadForFrame:]):
2966
2967 2010-07-19  Alexey Proskuryakov  <ap@apple.com>
2968
2969         Reviewed by Darin Adler.
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=42586
2972         Log all canceled authentication attempts in DumpRenderTree
2973
2974         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2975         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2976         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2977         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2978         It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
2979         case.
2980
2981 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2982
2983         Unreviewed, rolling out r63671.
2984         http://trac.webkit.org/changeset/63671
2985         https://bugs.webkit.org/show_bug.cgi?id=42575
2986
2987         broke windows (Requested by weinig on #webkit).
2988
2989         * WebKitTestRunner/Configurations/Base.xcconfig:
2990         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2991         * WebKitTestRunner/DerivedSources.make: Removed.
2992         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Removed.
2993         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Removed.
2994         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Removed.
2995         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Removed.
2996         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Removed.
2997         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
2998         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2999         (WTR::InjectedBundlePage::dump):
3000         (WTR::InjectedBundlePage::setStatusbarText):
3001         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3002         (WTR::LayoutTestController::setWaitToDump):
3003         (WTR::displayCallback):
3004         (WTR::dumpAsTextCallback):
3005         (WTR::dumpStatusCallbacksCallback):
3006         (WTR::waitUntilDoneCallback):
3007         (WTR::notifyDoneCallback):
3008         (WTR::numberOfActiveAnimationsCallback):
3009         (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
3010         (WTR::repaintSweepHorizontallyCallback):
3011         (WTR::testRepaintCallback):
3012         (WTR::layoutTestControllerObjectFinalize):
3013         (WTR::LayoutTestController::makeWindowObject):
3014         (WTR::LayoutTestController::getJSClass):
3015         (WTR::LayoutTestController::staticFunctions):
3016         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3017         (WTR::LayoutTestController::dumpAsText):
3018         (WTR::LayoutTestController::setDumpAsText):
3019         (WTR::LayoutTestController::dumpStatusCallbacks):
3020         (WTR::LayoutTestController::setDumpStatusCallbacks):
3021         (WTR::LayoutTestController::setTestRepaint):
3022         (WTR::LayoutTestController::setTestRepaintSweepHorizontally):
3023         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3024
3025 2010-07-19  Sam Weinig  <sam@webkit.org>
3026
3027         Reviewed by Adam Roben.
3028
3029         Patch for https://bugs.webkit.org/show_bug.cgi?id=42532
3030         Auto-generate the JS bindings for WebKitTestRunner's script objects.
3031
3032         * WebKitTestRunner/Configurations/Base.xcconfig:
3033         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3034         * WebKitTestRunner/DerivedSources.make: Added.
3035         * WebKitTestRunner/ForwardingHeaders/wtf/GetPtr.h: Added.
3036         * WebKitTestRunner/InjectedBundle/Bindings: Added.
3037         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Added.
3038         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h: Added.
3039         (WTR::JSWrappable::~JSWrappable):
3040         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp: Added.
3041         (WTR::JSWrapper::wrap):
3042         (WTR::JSWrapper::unwrap):
3043         (WTR::unwrapObject):
3044         (WTR::JSWrapper::initialize):
3045         (WTR::JSWrapper::finalize):
3046         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h: Added.
3047         (WTR::toJS):
3048         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added.
3049         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3050         (WTR::InjectedBundlePage::dump):
3051         (WTR::InjectedBundlePage::setStatusbarText):
3052         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3053         (WTR::LayoutTestController::wrapperClass):
3054         (WTR::LayoutTestController::waitUntilDone):
3055         (WTR::LayoutTestController::makeWindowObject):
3056         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3057         (WTR::LayoutTestController::shouldDumpAsText):
3058         (WTR::LayoutTestController::dumpAsText):
3059         (WTR::LayoutTestController::shouldDumpStatusCallbacks):
3060         (WTR::LayoutTestController::dumpStatusCallbacks):
3061         (WTR::LayoutTestController::waitToDump):
3062         (WTR::LayoutTestController::testRepaint):
3063         (WTR::LayoutTestController::repaintSweepHorizontally):
3064         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3065
3066 2010-07-19  Tony Chang  <tony@chromium.org>
3067
3068         Reviewed by David Levin.
3069
3070         fix chromium linux compile on ubuntu maverick
3071         https://bugs.webkit.org/show_bug.cgi?id=42528
3072
3073         * Scripts/webkitdirs.pm: add a chomp to eat a newline that breaks the make command line
3074
3075 2010-07-19  Adam Roben  <aroben@apple.com>
3076
3077         When dumping a response's MIME type, print its URL's last path
3078         component rather than its suitable-for-test-result form
3079
3080         This matches the Mac behavior.
3081
3082         Fixes <http://webkit.org/b/42276>
3083         http/tests/loading/preload-slow-loading.php and
3084         http/tests/mime/uppercase-mime-type.html fail on Windows
3085
3086         Reviewed by Anders Carlsson.
3087
3088         * DumpRenderTree/win/DumpRenderTree.cpp:
3089         (urlSuitableForTestResult): Moved code to actually extract the last
3090         path component from here...
3091         (lastPathComponent): ...to here.
3092
3093         * DumpRenderTree/win/DumpRenderTreeWin.h: Added lastPathComponent.
3094
3095         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3096         (ResourceLoadDelegate::didReceiveResponse): Use the URL's last path
3097         component, rather than its suitable-for-test-result form, to match
3098         Mac.
3099
3100 2010-07-19  Anders carlsson  <andersca@apple.com>
3101
3102         Reviewed by Adam Roben.
3103
3104         WebKit2 does not have application cache
3105         https://bugs.webkit.org/show_bug.cgi?id=42552
3106
3107         * WebKitTestRunner/TestInvocation.cpp:
3108         (WTR::TestInvocation::resetPreferencesToConsistentValues):
3109         Set up default preferences. Right now just enables the web application cache.
3110
3111         (WTR::TestInvocation::invoke):
3112         Call resetPreferencesToConsistentValues.
3113
3114         * WebKitTestRunner/TestInvocation.h:
3115
3116 2010-07-19  Kent Tamura  <tkent@chromium.org>
3117
3118         Reviewed by Adam Roben.
3119
3120         Fix NewRunWebKitTests to work on Windows.
3121         https://bugs.webkit.org/show_bug.cgi?id=41180
3122
3123         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3124           Specifying python explicitly.
3125
3126 2010-07-18  Anders Carlsson  <andersca@apple.com>
3127
3128         Reviewed by Dan Bernstein.
3129
3130         Add dumping of statusbar text to WebKitTestRunner
3131         https://bugs.webkit.org/show_bug.cgi?id=42516
3132
3133         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3134         (WTR::InjectedBundlePage::InjectedBundlePage):
3135         (WTR::InjectedBundlePage::_setStatusbarText):
3136         (WTR::InjectedBundlePage::setStatusbarText):
3137         Dump the statusbar text.
3138
3139         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3140         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3141         (WTR::LayoutTestController::LayoutTestController):
3142         Initialize m_dumpStatusCallbacks to false.
3143
3144         (WTR::dumpStatusCallbacksCallback):
3145         Implement JSC callback.
3146
3147         (WTR::LayoutTestController::staticFunctions):
3148         Add dumpStatusCallbacks.
3149
3150         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3151         (WTR::LayoutTestController::dumpStatusCallbacks):
3152         (WTR::LayoutTestController::setDumpStatusCallbacks):
3153         Add setter and getter for m_dumpStatusCallbacks.
3154
3155 2010-07-17  Anders Carlsson  <andersca@apple.com>
3156
3157         Reviewed by Maciej Stachowiak.
3158
3159         * WebKitTestRunner/TestController.cpp:
3160         (WTR::TestController::initialize):
3161         Get the test plug-in path and set it on the context.
3162
3163         * WebKitTestRunner/TestController.h:
3164         * WebKitTestRunner/mac/TestControllerMac.mm:
3165         (WTR::TestController::initializeInjectedBundlePath):
3166         Simplify this code by using NSBundle.
3167
3168         (WTR::TestController::testPluginPath):
3169         Return the test plug-in path.
3170
3171         * WebKitTestRunner/win/TestControllerWin.cpp:
3172         (WTR::TestController::testPluginPath):
3173         Ditto.
3174
3175 2010-07-16  Adam Barth  <abarth@webkit.org>
3176
3177         Reviewed by Eric Seidel.
3178
3179         Teach webkitpy about queues.webkit.org
3180         https://bugs.webkit.org/show_bug.cgi?id=42492
3181
3182         * Scripts/webkitpy/common/net/statusserver.py:
3183
3184 2010-07-16  Ada Chan  <adachan@apple.com>
3185
3186         Reviewed by Alice Liu.
3187
3188         Fix Windows build.
3189
3190         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
3191
3192 2010-07-16  Sam Weinig  <sam@webkit.org>
3193
3194         Reviewed by Anders Carlsson.
3195
3196         Fix for https://bugs.webkit.org/show_bug.cgi?id=42482
3197         <rdar://problem/8197701>
3198         Add notification of when the BackForwardList changes
3199         to aid invalidation of Back/Forward related UI elements.
3200
3201         * MiniBrowser/mac/BrowserWindowController.m:
3202         (_didStartProvisionalLoadForFrame):
3203         (_didCommitLoadForFrame):
3204         (_didFailLoadWithErrorForFrame):
3205         (_didChangeBackForwardList):
3206         (-[BrowserWindowController awakeFromNib]):
3207         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3208
3209 2010-07-16  Kent Tamura  <tkent@chromium.org>
3210
3211         Reviewed by Darin Fisher.
3212
3213         [Chromium] <input type=number> UI implementation for Windows
3214         https://bugs.webkit.org/show_bug.cgi?id=42259
3215
3216         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp:
3217         (WebThemeEngineDRT::paintSpinButton):
3218          Added. Check state consistency and use existing arrow painting code.
3219         * DumpRenderTree/chromium/WebThemeEngineDRT.h:
3220
3221 2010-07-16  Alice Liu  <alice.liu@apple.com>
3222
3223         Reviewed by Sam Weinig.
3224
3225         https://bugs.webkit.org/show_bug.cgi?id=42430
3226         Make WebKitTestRunner on Windows actually load and run a test
3227
3228         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp: Export WKBundleInitialize.
3229         (WKBundleInitialize):
3230         * WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added.  Output is a dll.
3231         * WebKitTestRunner/TestInvocation.cpp: Create a Windows-style path on Windows
3232         (WTR::createWKURL):
3233         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Change check for Windows platform to match
3234         other existing checks, and avoid including Platform.h
3235         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3236         (WTR::registerWindowClass): Added.
3237         (WTR::PlatformWebView::PlatformWebView): Implemented.
3238         (WTR::PlatformWebView::~PlatformWebView): Implemented.
3239         (WTR::PlatformWebView::page): Implemented.
3240         * WebKitTestRunner/win/TestControllerWin.cpp:
3241         (WTR::TestController::initializeInjectedBundlePath): Implemented. Provide build 
3242         configuration specific path to InjectedBundle.dll.
3243         * WebKitTestRunner/win/TestInvocationWin.cpp:
3244         (WTR::TestInvocation::runUntil): Implemented.
3245         * WebKitTestRunner/win/WebKitTestRunner.sln: Added InjectedBundle project.
3246         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Cleaned up unnecessary dependencies.
3247
3248 2010-07-16  Brady Eidson  <beidson@apple.com>
3249
3250         Reviewed by Sam Weinig.
3251
3252         Make revalidation of back/forward work a little better with page loads
3253         https://bugs.webkit.org/show_bug.cgi?id=42470
3254
3255         * MiniBrowser/mac/BrowserWindow.xib:
3256         * MiniBrowser/mac/BrowserWindowController.h:
3257         * MiniBrowser/mac/BrowserWindowController.m:
3258         (-[BrowserWindowController validateToolbar]):
3259         (_didStartProvisionalLoadForFrame):
3260         (_didCommitLoadForFrame):
3261         (_didFailLoadWithErrorForFrame):
3262
3263 2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
3264
3265         Reviewed by Dirk Schulze.
3266
3267         Add possibility to dumpAsText and generate a pixel test result
3268         https://bugs.webkit.org/show_bug.cgi?id=42374
3269
3270         Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
3271         setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
3272
3273         This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
3274         At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
3275
3276         Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
3277         (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
3278
3279         * DumpRenderTree/LayoutTestController.cpp:
3280         (LayoutTestController::LayoutTestController):
3281         (dumpAsTextAndPixelsCallback):
3282         (LayoutTestController::staticFunctions):
3283         * DumpRenderTree/LayoutTestController.h:
3284         (LayoutTestController::dumpAsTextAndPixels):
3285         (LayoutTestController::setDumpAsTextAndPixels):
3286         * DumpRenderTree/chromium/LayoutTestController.cpp:
3287         (LayoutTestController::LayoutTestController):
3288         (LayoutTestController::dumpAsTextAndPixels):
3289         (LayoutTestController::reset):
3290         * DumpRenderTree/chromium/LayoutTestController.h:
3291         (LayoutTestController::shouldDumpAsTextAndPixels):
3292         * DumpRenderTree/chromium/TestShell.cpp:
3293         (TestShell::dump):
3294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3295         (dump):
3296         * DumpRenderTree/mac/DumpRenderTree.mm:
3297         (dump):
3298         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3299         (WebCore::DumpRenderTree::dump):
3300         * DumpRenderTree/win/DumpRenderTree.cpp:
3301         (dump):
3302         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3303         (dump):
3304
3305 2010-07-16  Kent Hansen  <kent.hansen@nokia.com>
3306
3307         Unreviewed. Adding myself as committer.
3308
3309         * Scripts/webkitpy/common/config/committers.py:
3310
3311 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
3312
3313         Another uneviewed attempt to fix build.
3314
3315         Printing test results differ between machines, we should use ImageDiff instead
3316         https://bugs.webkit.org/show_bug.cgi?id=20011
3317
3318         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3319         (createPagedBitmapContext):
3320
3321 2010-07-16  Shinichiro Hamaji  <hamaji@chromium.org>
3322
3323         Unreviewed tiger build fix.
3324
3325         Printing test results differ between machines, we should use ImageDiff instead
3326         https://bugs.webkit.org/show_bug.cgi?id=20011
3327
3328         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3329         (createBitmapContext):
3330         (createBitmapContextFromWebView):
3331
3332 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
3333
3334         Unreviewed build fix.
3335
3336         Printing test results differ between machines, we should use ImageDiff instead
3337         https://bugs.webkit.org/show_bug.cgi?id=20011
3338
3339         * DumpRenderTree/PixelDumpSupport.cpp:
3340         (dumpWebViewAsPixelsAndCompareWithExpected):
3341
3342 2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
3343
3344         Reviewed by Darin Adler.
3345
3346         Printing test results differ between machines, we should use ImageDiff instead
3347         https://bugs.webkit.org/show_bug.cgi?id=20011
3348
3349         * DumpRenderTree/PixelDumpSupport.cpp:
3350         (dumpWebViewAsPixelsAndCompareWithExpected):
3351         * DumpRenderTree/PixelDumpSupport.h:
3352         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3353         (createBitmapContext): This function was added to share bitmap context creation code.
3354         (createBitmapContextFromWebView):
3355         (createPagedBitmapContext):
3356
3357 2010-07-15  Yuta Kitamura  <yutak@chromium.org>
3358
3359         Reviewed by Kent Tamura.
3360
3361         Pull in pywebsocket-0.5.1
3362         https://bugs.webkit.org/show_bug.cgi?id=42353
3363
3364         pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
3365         in Chromium. There is no other functional change.
3366
3367         (*) http://code.google.com/p/pywebsocket/source/detail?r=265
3368
3369         * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
3370
3371 2010-07-15  Brady Eidson  <beidson@apple.com>
3372
3373         Reviewed by Sam Weinig.
3374
3375         Add toolbar and toolbar item validation for MiniBrowser
3376         https://bugs.webkit.org/show_bug.cgi?id=42422
3377
3378         * MiniBrowser/MBToolbarItem.h: Added.
3379         * MiniBrowser/MBToolbarItem.m: Added.
3380         (-[MBToolbarItem validate]):
3381
3382         * MiniBrowser/mac/BrowserWindowController.m:
3383         (-[BrowserWindowController validateUserInterfaceItem:]):
3384
3385         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3386         * MiniBrowser/mac/BrowserWindow.xib:
3387
3388 2010-07-15  Victor Wang  <victorw@chromium.org>
3389
3390         Unreviewed, add victorw irc nickname to committer list.
3391
3392         * Scripts/webkitpy/common/config/committers.py:
3393
3394 2010-07-15  Adam Roben  <aroben@apple.com>
3395
3396         Make killing Apache more reliable (on both Mac and Windows)
3397
3398         We previously had two ways of determining whether we had succeeded in
3399         killing Apache:
3400           1) checking the return value of kill(0, $apachePID)
3401           2) checking whether Apache's PID file still exists
3402
3403         On Cygwin, Apache doesn't always delete its PID file when it exits,
3404         making (2) unreliable. We unfortunately misdiagnosed this as an
3405         impotency of Perl's kill function, which led to r63177 and r63355.
3406
3407         Now that we know that the real problem is that Apache doesn't always
3408         delete its PID file on Windows, we can make a much better fix: always
3409         use method (1) to determine whether we've killed Apache.
3410
3411         Fixes <http://webkit.org/b/42415> Killing Apache is unreliable,
3412         leading to regression test failures (and general annoyance).
3413
3414         Reviewed by Anders Carlsson.
3415
3416         * Scripts/webkitperl/httpd.pm:
3417         (openHTTPD): Moved killing code from here to killHTTPD. Added a call
3418         to delete the PID file in case Apache doesn't do this itself when
3419         killed. Our later logic relies on the PID file being deleted after
3420         this point.
3421         (closeHTTPD): Removed killing logic and changed to just call killHTTPD
3422         instead. killHTTPD's logic is a bit different from the logic we had
3423         here, for the reasons stated above.
3424         (killHTTPD): Added. Code came from openHTTPD.
3425         (handleInterrupt): Bonus fix for Mac: don't hang when pressing Ctrl-C!
3426         On Mac, don't try to kill Apache when we receive a signal, as Apache
3427         will already have been killed by this point (though for some reason
3428         this isn't detected by our killing logic in killHTTPD). On Cygwin, we
3429         still need to kill Apache manually.
3430
3431 2010-07-15  Sam Weinig  <sam@webkit.org>
3432
3433         Reviewed by Anders Carlsson.
3434
3435         Patch for https://bugs.webkit.org/show_bug.cgi?id=42399
3436         Update MiniBrowser for WKFrameNavigationType 
3437
3438         * MiniBrowser/mac/BrowserWindowController.m:
3439         (_decidePolicyForNavigationAction):
3440         (_decidePolicyForNewWindowAction):
3441
3442 2010-07-15  Stephanie Lewis  <slewis@apple.com>
3443
3444         Reviewed by Geoff Garen.
3445
3446         http://bugs.webkit.org/show_bug.cgi?id=42406
3447         Make SunSpider work better with roots.
3448
3449         * Scripts/sunspider-compare-results: fix argument bug
3450         * Scripts/webkitdirs.pm: look inside JavaScriptCore if jsc isn't top-level.
3451
3452 2010-07-15  Brady Eidson  <beidson@apple.com>
3453
3454         Reviewed by Sam Weinig.
3455
3456         Hook up back/forward in MiniBrowser
3457         https://bugs.webkit.org/show_bug.cgi?id=42397
3458
3459         * MiniBrowser/mac/BrowserWindow.xib:
3460         * MiniBrowser/mac/BrowserWindowController.h:
3461         * MiniBrowser/mac/BrowserWindowController.m:
3462         (-[BrowserWindowController goBack:]):
3463         (-[BrowserWindowController goForward:]):
3464
3465 2010-07-15  Daniel Bates  <dbates@rim.com>
3466
3467         Reviewed by Darin Adler.
3468
3469         [Mac] Implement LayoutTestController::markerTextForListItem()
3470         https://bugs.webkit.org/show_bug.cgi?id=37929
3471
3472         Implements DRT support for markerTextForListItem in the Mac port.
3473
3474         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3475         (LayoutTestController::markerTextForListItem): Implemented.
3476
3477 2010-07-15  Adam Barth  <abarth@webkit.org>
3478
3479         Unreviewed.
3480
3481         Update the port names to be more specific.  Before this patch,
3482         port-specific results for Mac would end up in the wrong place.
3483
3484         * Scripts/webkitpy/tool/commands/rebaseline.py:
3485         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3486
3487 2010-07-14  Eric Seidel  <eric@webkit.org>
3488
3489         Reviewed by Adam Barth.
3490
3491         WebKit needs a rebaselining tool (finally)
3492         https://bugs.webkit.org/show_bug.cgi?id=42339
3493
3494         This is a very basic rebaselining tool.  It's not
3495         quite as fancy as chromium's as it will only handle
3496         updating failing results.  It cannot yet handle adding new
3497         results, or updating results where the results should not
3498         replace existing results.
3499
3500         * Scripts/webkitpy/layout_tests/port/base.py:
3501         * Scripts/webkitpy/tool/commands/__init__.py:
3502         * Scripts/webkitpy/tool/commands/queries.py:
3503         * Scripts/webkitpy/tool/commands/rebaseline.py: Added.
3504         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added.
3505
3506 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3507
3508         Unreviewed, rolling out r63352.
3509         http://trac.webkit.org/changeset/63352
3510         https://bugs.webkit.org/show_bug.cgi?id=42341
3511
3512         Broke plugin-initiate-popup-window.html and plugin-javascript-
3513         access.html on snow leopard (Requested by abarth on #webkit).
3514
3515         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3516         (pluginAllocate):
3517         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3518         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3519         (NPP_New):
3520         (handleEventCarbon):
3521         (handleEventCocoa):
3522
3523 2010-07-14  Maciej Stachowiak  <mjs@apple.com>
3524
3525         Reviewed by Mark Rowe.
3526
3527         Lower WebKitTestRunner notifyDone timeout to 6.0 for now, to make it easier to grind through the failures.
3528
3529         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3530
3531 2010-07-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3532
3533         Unreviewed, rolling out r63346.
3534         http://trac.webkit.org/changeset/63346
3535         https://bugs.webkit.org/show_bug.cgi?id=42295
3536
3537         Broke lots of tests, some of which probably just need new
3538         results (Requested by aroben on #webkit).
3539
3540         * DumpRenderTree/win/DumpRenderTree.cpp:
3541         (urlSuitableForTestResult):
3542
3543 2010-07-14  Adam Roben  <aroben@apple.com>
3544
3545         Speed up killing of Apache on Windows
3546
3547         Fixes <http://webkit.org/b/42289> Killing Apache (and thus quitting
3548         run-webkit-tests) takes a long time on Windows
3549
3550         Reviewed by Darin Adler and Jon Honeycutt.
3551
3552         * Scripts/webkitperl/httpd.pm:
3553         (closeHTTPD): Use taskkill to kill Apache and its child processes.
3554         Perl's kill seems ineffectual. We were already using taskkill, but
3555         only after trying kill 20 times. Since kill never works, let's just
3556         skip it entirely.
3557
3558 2010-07-14  Johnny Ding  <jnd@chromium.org>
3559
3560         Reviewed by Adam Barth.
3561
3562         https://bugs.webkit.org/show_bug.cgi?id=41292
3563         Add a new parameter to the test plugin to allow to specify a script and a
3564         mouse/keyboard event. The specified script will be evaluated in the browser
3565         when the specified event is received by the plugin.
3566
3567         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3568         (pluginAllocate):
3569         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3570         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3571         (NPP_New):
3572         (handleEventCarbon):
3573         (handleEventCocoa):
3574
3575 2010-07-14  Adam Roben  <aroben@apple.com>
3576
3577         Make urlSuitableForTestResult work for http: URLs, too
3578
3579         Fixes <http://webkit.org/b/42276>
3580         http/tests/loading/preload-slow-loading.php and
3581         http/tests/mime/uppercase-mime-type.html fail on Windows.
3582
3583         Reviewed by Darin Adler.
3584
3585         * DumpRenderTree/win/DumpRenderTree.cpp:
3586         (urlSuitableForTestResult): Don't bail if the URL starts with http://.
3587         We want this function to work for those URLs, too!
3588
3589 2010-07-13  Maciej Stachowiak  <mjs@apple.com>
3590
3591         Reviewed by Oliver Hunt.
3592
3593         Add placebo versions of some repaint test functions to WebKitTestRunner - good enough for non-pixel tests
3594         https://bugs.webkit.org/show_bug.cgi?id=42227
3595
3596         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3597         (WTR::LayoutTestController::LayoutTestController): Initialize new bool
3598         m