Adding myself as a reviewer.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
2
3         Reviewed by Beth Dakin.
4
5         Adding myself as a reviewer.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
10
11         Build fix. No review.
12
13         AX: need to catch NSAccessibilityExceptions in DRT
14         https://bugs.webkit.org/show_bug.cgi?id=39881
15
16         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
17
18         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
19         (AccessibilityUIElement::rowIndexRange):
20         (AccessibilityUIElement::columnIndexRange):
21         (AccessibilityUIElement::selectedTextRange):
22
23 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
24
25         Reviewed by Darin Adler.
26
27         AX: need to catch NSAccessibilityExceptions in DRT
28         https://bugs.webkit.org/show_bug.cgi?id=39881
29
30         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
31         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
32   
33         So DRT should wrap exception handlers around its AX related calls.
34
35         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
36         (attributesOfElement):
37         (AccessibilityUIElement::getLinkedUIElements):
38         (AccessibilityUIElement::getDocumentLinks):
39         (AccessibilityUIElement::getChildren):
40         (AccessibilityUIElement::getChildrenWithRange):
41         (AccessibilityUIElement::ariaOwnsElementAtIndex):
42         (AccessibilityUIElement::ariaFlowToElementAtIndex):
43         (AccessibilityUIElement::disclosedRowAtIndex):
44         (AccessibilityUIElement::selectedRowAtIndex):
45         (AccessibilityUIElement::titleUIElement):
46         (AccessibilityUIElement::parentElement):
47         (AccessibilityUIElement::disclosedByRow):
48         (AccessibilityUIElement::stringAttributeValue):
49         (AccessibilityUIElement::boolAttributeValue):
50         (AccessibilityUIElement::isAttributeSettable):
51         (AccessibilityUIElement::isAttributeSupported):
52         (AccessibilityUIElement::role):
53         (AccessibilityUIElement::subrole):
54         (AccessibilityUIElement::roleDescription):
55         (AccessibilityUIElement::title):
56         (AccessibilityUIElement::description):
57         (AccessibilityUIElement::orientation):
58         (AccessibilityUIElement::stringValue):
59         (AccessibilityUIElement::language):
60         (AccessibilityUIElement::helpText):
61         (AccessibilityUIElement::x):
62         (AccessibilityUIElement::y):
63         (AccessibilityUIElement::width):
64         (AccessibilityUIElement::height):
65         (AccessibilityUIElement::clickPointX):
66         (AccessibilityUIElement::clickPointY):
67         (AccessibilityUIElement::intValue):
68         (AccessibilityUIElement::minValue):
69         (AccessibilityUIElement::maxValue):
70         (AccessibilityUIElement::valueDescription):
71         (AccessibilityUIElement::insertionPointLineNumber):
72         (AccessibilityUIElement::isActionSupported):
73         (AccessibilityUIElement::isEnabled):
74         (AccessibilityUIElement::isRequired):
75         (AccessibilityUIElement::isSelected):
76         (AccessibilityUIElement::isExpanded):
77         (AccessibilityUIElement::hierarchicalLevel):
78         (AccessibilityUIElement::ariaIsGrabbed):
79         (AccessibilityUIElement::ariaDropEffects):
80         (AccessibilityUIElement::lineForIndex):
81         (AccessibilityUIElement::boundsForRange):
82         (AccessibilityUIElement::stringForRange):
83         (AccessibilityUIElement::attributesOfColumnHeaders):
84         (AccessibilityUIElement::attributesOfRowHeaders):
85         (AccessibilityUIElement::attributesOfColumns):
86         (AccessibilityUIElement::attributesOfRows):
87         (AccessibilityUIElement::attributesOfVisibleCells):
88         (AccessibilityUIElement::attributesOfHeader):
89         (AccessibilityUIElement::rowCount):
90         (AccessibilityUIElement::columnCount):
91         (AccessibilityUIElement::indexInTable):
92         (AccessibilityUIElement::rowIndexRange):
93         (AccessibilityUIElement::columnIndexRange):
94         (AccessibilityUIElement::cellForColumnAndRow):
95         (AccessibilityUIElement::selectedTextRange):
96         (AccessibilityUIElement::setSelectedTextRange):
97         (AccessibilityUIElement::increment):
98         (AccessibilityUIElement::decrement):
99         (AccessibilityUIElement::showMenu):
100         (AccessibilityUIElement::press):
101         (AccessibilityUIElement::url):
102         (AccessibilityUIElement::hasPopup):
103
104 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
105
106         Reviewed by Laszlo Gombos.
107
108         [Qt] Pass all web notification layout tests
109         https://bugs.webkit.org/show_bug.cgi?id=39146
110
111         Mimic Chromium's test_shell security model in Qt's DRT.
112         It makes a list of origins which were granted permission to display
113         notifications, and only those origins can display notifications.
114
115         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
116         (WebCore::checkPermissionCallback):
117         (WebCore::requestPermissionCallback):
118         (WebCore::WebPage::WebPage):
119         (WebCore::DumpRenderTree::checkPermission):
120         (WebCore::DumpRenderTree::requestPermission):
121         * DumpRenderTree/qt/DumpRenderTreeQt.h:
122         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
123         (LayoutTestController::reset):
124         (LayoutTestController::grantDesktopNotificationPermission):
125         (LayoutTestController::checkDesktopNotificationPermission):
126         * DumpRenderTree/qt/LayoutTestControllerQt.h:
127
128 2010-05-27  Philippe Normand  <pnormand@igalia.com>
129
130         Reviewed by Shinichiro Hamaji.
131
132         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
133         https://bugs.webkit.org/show_bug.cgi?id=39372
134
135         Don't warn about NULL in g_*() calls. Zero can't be used instead
136         for calls like g_build_filename and g_object_get/set.
137
138         * Scripts/webkitpy/style/checkers/cpp.py:
139         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
140
141 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
142
143         Reviewed by Kenneth Rohde Christiansen.
144
145         [Qt] Platform plugin example
146         https://bugs.webkit.org/show_bug.cgi?id=39489
147
148         Exempting directory WebKit/qt/examples/ from style guide.
149
150         * Scripts/webkitpy/style/checker.py:
151
152 2010-05-26  Philippe Normand  <pnormand@igalia.com>
153
154         Reviewed by David Levin.
155
156         [style] Allow usage of NULL in gst_*_many()
157         https://bugs.webkit.org/show_bug.cgi?id=39740
158
159         Don't warn if NULL is used by gst_*_many() functions. Zero can't
160         be used for the reason explained in Bug 32858.
161
162         * Scripts/webkitpy/style/checkers/cpp.py:
163         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
164
165 2010-05-27  Adam Barth  <abarth@webkit.org>
166
167         Reviewed by Eric Seidel.
168
169         Update script to run the normal version of the parser tests.
170
171         * Scripts/test-html5-parser:
172
173 2010-05-27  Adam Barth  <abarth@webkit.org>
174
175         Reviewed by Eric Seidel.
176
177         Add HTML5 parser support to run-webkit-tests
178         https://bugs.webkit.org/show_bug.cgi?id=39815
179
180         * Scripts/old-run-webkit-tests:
181
182 2010-05-26  Adam Barth  <abarth@webkit.org>
183
184         Reviewed by Eric Seidel.
185
186         Make HTML5 lexer not ASSERT when resuming partial parses
187         https://bugs.webkit.org/show_bug.cgi?id=39755
188
189         Add webkit-resumer.html to the HTML5 parser test suite.
190
191         * Scripts/test-html5-parser:
192
193 2010-05-24  Tony Chang  <tony@chromium.org>
194
195         Reviewed by Kent Tamura.
196
197         [chromium] setup fonts on chromium linux DRT
198         https://bugs.webkit.org/show_bug.cgi?id=39644
199
200         * DumpRenderTree/chromium/TestShellGtk.cpp:
201         (setupFontconfig):
202         (platformInit):
203         * DumpRenderTree/chromium/WebViewHost.cpp:
204         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
205         * DumpRenderTree/chromium/fonts.conf: Added.
206
207 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
208
209         Reviewed by Dimitri Glazkov.
210
211         Re-commit r58765 - it had been rolled out to see if it was causing
212         a perf regression (in r59787 and r59789), but that does not seem to
213         have been the case.
214
215         https://bugs.webkit.org/show_bug.cgi?id=39605
216
217         * DumpRenderTree/chromium/NotificationPresenter.cpp:
218         (NotificationPresenter::show):
219
220 2010-05-25  Ojan Vafai  <ojan@chromium.org>
221
222         Reviewed by Chris Jerdonek.
223
224         remove suppression of rietveld logging
225         https://bugs.webkit.org/show_bug.cgi?id=39693
226
227         Now that we only upload to rietveld explicitly, e.g. on the bot
228         or via webkit-patch post-attachment-to-rietveld, we should print
229         all the rietveld logging. It was suppressed before to avoid making
230         webkit-patch upload too noisy.
231
232         * Scripts/webkitpy/common/net/rietveld.py:
233
234 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
235
236         Reviewed by Ojan Vafai.
237
238         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
239         https://bugs.webkit.org/show_bug.cgi?id=39680
240
241         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
242
243         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
244         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
245         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
246         (LayoutTestController::setEditingBehavior):
247
248 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
249
250         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
251
252         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
253         (LayoutTestController::setEditingBehavior):
254         * wx/build/settings.py:
255
256 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
257
258         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
259
260         editingBehavior settings needs to be set back to a reasonable default between tests
261         https://bugs.webkit.org/show_bug.cgi?id=39433
262
263         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
264         so that the serialized version of the setting stays in sync with expectations.
265
266         * DumpRenderTree/chromium/TestShell.cpp:
267         (TestShell::resetWebSettings):
268         * DumpRenderTree/gtk/DumpRenderTree.cpp:
269         (resetDefaultsToConsistentValues):
270
271 2010-05-24  Eric Seidel  <eric@webkit.org>
272
273         Reviewed by Adam Barth.
274
275         webkit-patch land calls scm.changed_files 4 times!
276         https://bugs.webkit.org/show_bug.cgi?id=39584
277
278         * Scripts/webkitpy/tool/commands/download_unittest.py:
279          - Assert that we don't call modified_changelogs too often.
280         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
281          - Use cached changelogs list instead of calling modified_changelogs directly.
282         * Scripts/webkitpy/tool/steps/validatereviewer.py:
283          - ditto.
284
285 2010-05-24  Kent Tamura  <tkent@chromium.org>
286
287         Reviewed by Dimitri Glazkov.
288
289         [DRT/Chromium] Import layout_test_helper for Windows
290         https://bugs.webkit.org/show_bug.cgi?id=39581
291
292         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
293         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
294
295         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
296
297 2010-05-24  Kent Tamura  <tkent@chromium.org>
298
299         Reviewed by Dimitri Glazkov.
300
301         [DRT/Chromium] Reset frame name
302         https://bugs.webkit.org/show_bug.cgi?id=39586
303
304         This change fixes about 70 unexpected results.
305
306         * DumpRenderTree/chromium/WebViewHost.cpp:
307         (WebViewHost::reset):
308
309 2010-05-24  Marcus Bulach  <bulach@chromium.org>
310
311         Reviewed by Kent Tamura.
312
313         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
314         https://bugs.webkit.org/show_bug.cgi?id=39587
315
316         * DumpRenderTree/chromium/WebViewHost.cpp:
317         (WebViewHost::geolocationService):
318
319 2010-05-24  Robert Hogan  <robert@webkit.org>
320
321         Reviewed by Laszlo Gombos.
322
323         [Qt] DRT Support for removeOriginAccessWhitelistEntry
324
325         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
326
327         [Qt] DRT Support for removeOriginAccessWhitelistEntry
328         https://bugs.webkit.org/show_bug.cgi?id=39565
329
330         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
331         (LayoutTestController::removeOriginAccessWhitelistEntry):
332
333 2010-05-24  Marcus Bulach  <bulach@google.com>
334
335         Reviewed by Ojan Vafai.
336
337         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
338         https://bugs.webkit.org/show_bug.cgi?id=39603
339
340         * Scripts/webkitpy/common/checkout/scm.py:
341
342 == Rolled over to ChangeLog-2010-05-24 ==