WebKitTools:
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
2
3         Reviewed by Adam.
4
5         - Layout tests fix.  We need a way to remove machine-dependent
6         information from paths in layout test results. The UIDelegate now does
7         this.
8
9         * DumpRenderTree/DumpRenderTree.h:
10         * DumpRenderTree/win/DumpRenderTree.cpp:
11         (urlSuitableForTestResult):
12         * DumpRenderTree/win/DumpRenderTreeWin.h:
13         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
14         * DumpRenderTree/win/UIDelegate.cpp:
15         (UIDelegate::webViewAddMessageToConsole):
16
17 2007-12-13  Alp Toker  <alp@atoker.com>
18
19         Build fix for DRT breakage introduced in r28690.
20
21         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
22         (LayoutTestController::pathToLocalResource):
23
24 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
25
26         Reviewed by Alice and Sam.
27
28         - <rdar://5621435> Need a way to specify local resources (being loaded
29         from HTTP tests) on Windows.
30         - Implemented pathToLocalResource which exposes the functionality of
31         converting a given unix path to the correct location on Windows.
32
33         * DumpRenderTree/LayoutTestController.cpp:
34         (pathToLocalResourceCallback):
35         (LayoutTestController::staticFunctions):
36         * DumpRenderTree/LayoutTestController.h:
37         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
38         (LayoutTestController::pathToLocalResource):
39         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
40         (LayoutTestController::pathToLocalResource):
41
42 2007-12-11  Anders Carlsson  <andersca@apple.com>
43
44         Reviewed by Sam.
45
46         <rdar://problem/5132003>
47         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
48
49         * DumpRenderTree/win/DumpRenderTree.cpp:
50         (main):
51         Set the resource load delegate.
52         
53         * DumpRenderTree/win/DumpRenderTree.vcproj:
54         
55         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
56         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
57
58 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
59
60         Reviewed by Adam Roben.
61
62         Fix conversion from double to LPARAM in dispatchMessage().
63
64         * DumpRenderTree/win/EventSender.cpp:
65         (dispatchMessageCallback):
66
67 2007-12-11  Dan Bernstein  <mitz@apple.com>
68
69         Reviewed by Mark Rowe and Sam Weinig too!
70
71         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
72           fonts DumpRenderTree registers.
73
74         * DumpRenderTree/win/DumpRenderTree.cpp:
75         (initialize):
76
77 2007-12-11  Brady Eidson  <beidson@apple.com>
78
79         Reviewed by Anders
80
81         Make DumpRenderTree on mac use its own path for Databases testing
82
83         * DumpRenderTree/mac/DumpRenderTree.mm:
84         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
85           for future DRT-only use, then use it to construct the Databases path and set that default
86
87 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
88
89         Reviewed by Darin.
90
91         <rdar://problem/5535636>
92         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
93
94         http://bugs.webkit.org/show_bug.cgi?id=13916
95         JavaScript detects Tab as a character input on a textfield validation
96
97         * DumpRenderTree/mac/EventSendingController.mm:
98         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
99         Dispatch a keyup to better match what happens when a key is physically pressed.
100
101         * DumpRenderTree/win/EventSender.cpp:
102         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
103         returning from keyDown().
104         (getConstantCallback): Fixed a couple copy/paste mistakes.
105
106 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
107
108         Reviewed by Oliver.
109
110         - <rdar://5599845> Drosera: Does not show loal files in the file list
111         on the left side.
112
113         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
114         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
115         so the open source community can build.
116
117 2007-12-10  Brady Eidson  <beidson@apple.com>
118
119         Rubberstamped by Sam Weinig
120
121         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
122
123         * DumpRenderTree/mac/UIDelegate.mm:
124         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
125         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
126
127 2007-12-08  Oliver Hunt  <oliver@apple.com>
128
129         Reviewed by Sam W.
130
131         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
132         
133         Fixes <rdar://problem/5620249> Must disable SVG animation
134         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
135         
136         In order to allow finer grained control over the set of SVG features
137         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
138         distinct flags:
139         ENABLE_SVG_ANIMATION
140         ENABLE_SVG_FILTERS
141         ENABLE_SVG_FONTS
142         ENABLE_SVG_AS_IMAGE
143         ENABLE_SVG_USE
144         
145         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
146         
147         Script handles all the new build flags, and allows --svg-experimental
148         to automatically enable all features.
149
150         * Scripts/build-webkit:
151
152 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
153
154         Fix version parsing.
155
156         Rubber-stamped by Oliver.
157
158         * Drosera/win/Drosera.vcproj/auto-version.sh:
159
160 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
161
162         Build modifications for Drosera.
163
164         Reviewed by Adam.
165
166         * Drosera/DroseraWin.make: Added.
167         * Drosera/win/Drosera.vcproj/Drosera.rc:
168         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
169         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
170         * Drosera/win/Drosera.vcproj/VERSION: Added.
171         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
172
173 2007-12-06  Adam Roben  <aroben@apple.com>
174
175         Explicitly turn on the Mac font ascent hack on Windows
176
177         This keeps our font metrics matching those from Mac.
178
179         Reviewed by Hyatt.
180
181         * DumpRenderTree/win/DumpRenderTree.cpp:
182         (main):
183
184 2007-12-06  Anders Carlsson  <andersca@apple.com>
185
186         Rename main.c to main.cpp here too.
187         
188         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
189
190 2007-12-06  Sam Weinig  <sam@webkit.org>
191
192         Rubber stamped by Geoff.
193
194         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
195
196 2007-12-06  Darin Adler  <darin@apple.com>
197
198         * Scripts/do-webcore-rename: Some more renaming plans.
199
200 2007-12-06  Anders Carlsson  <andersca@apple.com>
201
202         Restore implementation of testGetIntIdentifier that was accidentally
203         removed somehow (possibly when I made PluginObject be a cpp file).
204         
205         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
206         (pluginInvoke):
207
208 2007-12-05  Anders Carlsson  <andersca@apple.com>
209
210         Make the entry points extern "C".
211         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
212         
213 2007-12-05  Anders Carlsson  <andersca@apple.com>
214
215         C++ warning fixes.
216         
217         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
218         (NPP_New):
219         (NPP_Destroy):
220         (NPP_SetWindow):
221         (NPP_NewStream):
222         (NPP_HandleEvent):
223         (NPP_URLNotify):
224         (NPP_GetValue):
225
226 2007-12-05  Anders Carlsson  <andersca@apple.com>
227
228         Add the .cpp files to the TestNetscapePlugIn target.
229
230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
231
232 2007-12-05  Anders Carlsson  <andersca@apple.com>
233
234         Reviewed by Geoff.
235         
236         Rename the TestNetscapePlugIn .c files to be .cpp.
237
238         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
239         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
240         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
241         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
242         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
243         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
244         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
245         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
246
247 2007-12-05  Adam Roben  <aroben@apple.com>
248
249         Fix case of keypresses from the Windows implementation of eventSender.keyDown
250
251         This fixes several regression tests.
252
253         Reviewed by Alice.
254
255         * DumpRenderTree/win/EventSender.cpp:
256         (keyDownCallback): Virtual keycodes for ASCII characters are always
257         uppercase, so we need to check the case of the original character
258         passed in to eventSender.keyDown.
259
260 2007-12-05  Adam Roben  <aroben@apple.com>
261
262         Learn from Tim's mistakes
263
264         * DumpRenderTree/win/DumpRenderTree.cpp:
265         (runTest): Reset the authorAndUserStylesEnabled preference for each
266         test.
267
268 2007-12-05  Alp Toker  <alp@atoker.com>
269
270         Reviewed by Mark Rowe.
271
272         Initialize GTK+ and WebKit so the tests can run.
273
274         Reorganize the headers a little.
275
276         * DumpRenderTree/gtk/DumpRenderTree.cpp:
277         (main):
278
279 2007-12-04  Anders Carlsson  <andersca@apple.com>
280
281         Remove IWebScriptScope include.
282         
283         * Drosera/win/DebuggerDocumentPlatform.cpp:
284
285 2007-12-04  Sam Weinig  <sam@webkit.org>
286
287         Rubber stamped by Mark Rowe.
288
289         Define CF as platform for mac and revert r28409
290
291         * DumpRenderTree/DumpRenderTree.h:
292         * DumpRenderTree/mac/DumpRenderTreeMac.h:
293
294 2007-12-04  Sam Weinig  <sam@webkit.org>
295
296         Define CF as platform for windows.
297
298         Reviewed by Adam Roben.
299
300         * DumpRenderTree/win/DumpRenderTreeWin.h:
301
302 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
303
304         Reviewed by Adam and Darin.
305
306         - Removed a needless BSTR cleanup.
307
308         * Drosera/win/DebuggerDocumentPlatform.cpp:
309         (DebuggerDocument::getPlatformCurrentFunctionStack):
310
311 2007-11-27  Adam Roben  <aroben@apple.com>
312
313         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
314
315         Reviewed by Maciej.
316
317         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
318         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
319
320 2007-12-04  Alp Toker  <alp@atoker.com>
321
322         Prospective Win DRT build fix.
323
324         * DumpRenderTree/DumpRenderTree.h:
325
326 2007-12-04  Alp Toker  <alp@atoker.com>
327
328         Fix a clobbered copyright header.
329
330         * DumpRenderTree/gtk/DumpRenderTree.cpp:
331
332 2007-12-04  Xan Lopez  <xan@gnome.org>
333
334         Reviewed by Alp Toker.
335
336         http://bugs.webkit.org/show_bug.cgi?id=15561
337         GTK port needs DumpRenderTree implementation
338
339         Start work on the GTK+ DRT.
340
341         This does not work yet, and there are a few lingering style issues
342         (nothing major) but this patch has been stuck in the bug tracker for
343         too long already.
344
345         * DumpRenderTree/DumpRenderTree.h:
346         * DumpRenderTree/gtk: Added.
347         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
348         (autocorrectURL):
349         (shouldLogFrameLoadDelegates):
350         (dumpFrameScrollPosition):
351         (displayWebView):
352         (appendString):
353         (dumpFramesAsText):
354         (dumpRenderTreeAsText):
355         (dump):
356         (runTest):
357         (main):
358         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
359         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
360         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
361         (GCController::collect):
362         (GCController::collectOnAlternateThread):
363         (GCController::getJSObjectCount):
364         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
365         (LayoutTestController::~LayoutTestController):
366         (LayoutTestController::addDisallowedURL):
367         (LayoutTestController::clearBackForwardList):
368         (LayoutTestController::copyDecodedHostName):
369         (LayoutTestController::copyEncodedHostName):
370         (LayoutTestController::display):
371         (LayoutTestController::keepWebHistory):
372         (LayoutTestController::notifyDone):
373         (LayoutTestController::queueBackNavigation):
374         (LayoutTestController::queueForwardNavigation):
375         (LayoutTestController::queueLoad):
376         (LayoutTestController::queueReload):
377         (LayoutTestController::queueScript):
378         (LayoutTestController::setAcceptsEditing):
379         (LayoutTestController::setCustomPolicyDelegate):
380         (LayoutTestController::setMainFrameIsFirstResponder):
381         (LayoutTestController::setTabKeyCyclesThroughElements):
382         (LayoutTestController::setUseDashboardCompatibilityMode):
383         (LayoutTestController::setUserStyleSheetEnabled):
384         (LayoutTestController::setUserStyleSheetLocation):
385         (LayoutTestController::setWindowIsKey):
386         (LayoutTestController::setWaitToDump):
387         (LayoutTestController::windowCount):
388         (LayoutTestController::setPrivateBrowsingEnabled):
389         (LayoutTestController::setAuthorAndUserStylesEnabled):
390         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
391         (JSStringCopyUTF8CString):
392         (LoadItem::invoke):
393         (ReloadItem::invoke):
394         (ScriptItem::invoke):
395         (BackForwardItem::invoke):
396
397 2007-12-03  Sam Weinig  <sam@webkit.org>
398
399         Move JavaScriptCore thread testing code to pthread specific directory
400         and remove the dependance on CoreFoundation by using WTF::HashSet.
401
402         Reviewed by Geoff and Oliver.
403
404         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
405         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
406         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
407         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
408         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
409         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
410         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
411         * DumpRenderTree/pthreads: Added.
412         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
413         (javaScriptThreads):
414         (runJavaScriptThread):
415         (startJavaScriptThreads):
416         (stopJavaScriptThreads):
417
418 2007-12-03  Andrew Bonventre  <andybons@google.com>
419
420         Reviewed by Darin Adler.
421
422         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
423         Symbol lookup menu broken in debugger view
424
425         * Drosera/debugger.js: Fixed javascript error where document property
426         should have been used instead of contentDocument in switchFunction that
427         was breaking the select symbol dropdown menu.  This is because
428         window.frames will return a Window object and not a frame object like
429         the author was originally expecting.
430
431 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
432
433         Reviewed by Adam.
434
435         - <rdar://5618942> Drosera: Console window does not process everything
436         correctly.
437         - <rdar://5619005> Drosera: could be sped up by moving the 
438         WebScriptScope stuff into the WebScriptCallFrame.
439         - Now the console can correctly process objects and does not receive
440         notifications from JavaScriptCore about the JavaScript in Drosera's
441         own process.
442
443         * Drosera/win/DebuggerDocumentPlatform.cpp:
444         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
445         (DebuggerDocument::platformValueForScopeVariableNamed):
446
447 2007-12-03  Stephanie  <slewis@apple.com>
448
449         Reviewed by Darin.
450
451         Check to see if we are building a debug root
452
453         * Scripts/check-for-global-initializers: 
454
455 2007-12-03  Dan Bernstein  <mitz@apple.com>
456
457         Reviewed by Darin Adler.
458
459         - added a testGetIntIdentifier() method to TestNetscapePlugIn
460
461         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
462         (pluginInvoke):
463
464 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
465
466         Reviewed by Oliver.
467
468         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
469         in a more fine-grained manner than eventSender.keyDown().
470
471         * DumpRenderTree/win/EventSender.cpp:
472         (getConstantCallback):
473         (dispatchMessageCallback):
474
475 2007-12-02  Darin Adler  <darin@apple.com>
476
477         * Scripts/do-webcore-rename: More planned renaming.
478
479 2007-12-02  Sam Weinig  <sam@webkit.org>
480
481         Rubber stamped by Anders.
482
483         Use [NSURL absoluteString] instead of [NSURL description] in order to get
484         more uniform results cross platform.
485
486         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
487         (-[NSURL _drt_descriptionSuitableForTestResult]):
488
489 2007-12-02  Sam Weinig  <sam@webkit.org>
490
491         Rubber stamped by Niko.
492
493         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
494
495         * DumpRenderTree/win/DumpRenderTree.cpp:
496         * DumpRenderTree/win/DumpRenderTree.vcproj:
497         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
498         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
499         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
500         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
501
502 2007-12-01  Alp Toker  <alp@atoker.com>
503
504         Reviewed by Adam Roben.
505
506         Make use of the newly introduced webkit.h convenience header.
507
508         * GtkLauncher/main.c:
509
510 2007-12-01  Adam Treat  <treat@kde.org>
511
512         Reviewed by Simon.
513
514         * Check to see if the directory exists and exit if not.
515
516         * DumpRenderTree/qt/main.cpp:
517         (main):
518
519 2007-12-01  Adam Treat  <treat@kde.org>
520
521         Reviewed by Simon.
522
523         * Don't hide symbols when in Debug mode
524         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
525
526
527         * DumpRenderTree/qt/main.cpp:
528         (messageHandler):
529
530 2007-11-30  Alp Toker  <alp@atoker.com>
531
532         Reviewed by Adam Roben.
533
534         http://bugs.webkit.org/show_bug.cgi?id=15691
535         [GTK] Public API does not follow GTK+ conventions
536
537         Refactor the WebKit/GTK+ public API. Changes:
538           WebKitPage -> WebKitWebView
539           WebKitFrame -> WebKitWebFrame
540
541         Public API source and header names have been updated to mirror the API
542         changes.
543
544         The API is now kept in WebKit/gtk/WebView to match other ports in the
545         same class such as Mac and Win.
546
547         * GtkLauncher/main.c:
548         (activate_uri_entry_cb):
549         (link_hover_cb):
550         (title_change_cb):
551         (progress_change_cb):
552         (go_back_cb):
553         (go_forward_cb):
554         (create_browser):
555         (main):
556
557 2007-11-30  Adam Roben  <aroben@apple.com>
558
559         Hopefully the final build fix
560
561         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
562         pull in WTF's assertion/logging functions.
563
564 2007-11-30  Adam Roben  <aroben@apple.com>
565
566         Another build fix
567
568         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
569         WebKit.lib.
570
571 2007-11-30  Adam Roben  <aroben@apple.com>
572
573         Debug build fix
574
575         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
576         configuration.
577         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
578         projects.
579         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
580         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
581         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
582
583 2007-11-30  Sam Weinig  <sam@webkit.org>
584
585         Reviewed by Adam Roben.
586
587         Fix drawSelectionRect to actually draw the selection rect.
588
589         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
590         (drawSelectionRect):
591
592 2007-11-30  Darin Adler  <darin@apple.com>
593
594         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
595
596 2007-11-30  Darin Adler  <darin@apple.com>
597
598         * Scripts/do-webcore-rename: Get ready for some future renaming.
599
600 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
601
602         Reviewed by Adam.
603
604         - Removed some unnecessary functions and changed an unused return type. 
605
606         * Drosera/win/DebuggerClient.cpp:
607         (registerConsoleClass):
608         * Drosera/win/DebuggerClient.h:
609         * Drosera/win/Drosera.cpp:
610         (registerDroseraClass):
611
612 2007-11-28  Alp Toker  <alp@atoker.com>
613
614         Reviewed by Timothy Hatcher.
615
616         http://bugs.webkit.org/show_bug.cgi?id=16174
617         [GTK] Use "URI" not "URL" in public API
618
619         Replace use of the term "URL" with "URI" in public headers,
620         documentation and some internal code to match GLib/GTK+ convention.
621
622         This is now mentioned in the API guidelines:
623           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
624
625         * GtkLauncher/main.c:
626         (activate_uri_entry_cb):
627         (title_change_cb):
628         (create_toolbar):
629         (main):
630
631 2007-11-29  Anders Carlsson  <andersca@apple.com>
632
633         Reviewed by Sam.
634
635         <rdar://problem/5230478>
636         FrameLoadDelegate callbacks are not dumped in DRT.
637         
638         * DumpRenderTree/win/DumpRenderTree.cpp:
639         (shouldLogFrameLoadDelegates):
640         (runTest):
641         (main):
642         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
643         (BSTRtoString):
644         (descriptionSuitableForTestResult):
645         (FrameLoadDelegate::QueryInterface):
646         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
647         (FrameLoadDelegate::didFailProvisionalLoadWithError):
648         (FrameLoadDelegate::didCommitLoadForFrame):
649         (FrameLoadDelegate::didFinishLoadForFrame):
650         (FrameLoadDelegate::willCloseFrame):
651         (FrameLoadDelegate::didClearWindowObject):
652         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
653         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
654         * DumpRenderTree/win/FrameLoaderDelegate.h:
655         (FrameLoadDelegate::windowScriptObjectAvailable):
656         (FrameLoadDelegate::didFirstLayoutInFrame):
657
658 2007-11-29  Sam Weinig  <sam@webkit.org>
659
660         Reviewed by Anders.
661
662         Add database quota UIDelegates methods to DRT UIDelegate.
663
664         * DumpRenderTree/mac/UIDelegate.mm:
665         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
666         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
667
668 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
669
670         Reviewed by Sam.
671
672         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
673         dying and vice versa.
674         - This fix will allow Drosera and Safari to reconnect if either of them
675         closes correctly, but does not fix the case where one of them dies
676         silently.
677
678         * Drosera/win/ServerConnection.cpp:
679         (ServerConnection::attemptToCreateServerConnection): Added a safety
680         check, because it's possilbe to try to connect to a server that's dying.
681         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
682         the server has died.
683         * Drosera/win/ServerConnection.h: Added the new function and removed
684         an unnecessary member.
685
686 2007-11-29  Anders Carlsson  <andersca@apple.com>
687
688         * DumpRenderTree/win/DumpRenderTree.vcproj:
689         Add shlwapi.lib to all configurations.
690
691 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
692
693         - Build fix.  Added additional includes for VS Express to the Release
694         project.
695
696         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
697
698 2007-11-29  Anders Carlsson  <andersca@apple.com>
699
700         Reviewed by Adam.
701
702         <rdar://problem/5132005>
703         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
704         
705         * DumpRenderTree/win/DumpRenderTree.vcproj:
706         Add shlwapi.lib
707         
708         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
709         (LayoutTestController::setUserStyleSheetEnabled):
710         Implement this.
711         
712         (appendComponentToPath):
713         New method which wraps the Win32 API PathAppend.
714         
715         (followShortcuts):
716         New method which checks if a file points to a shortcut and
717         follows the shortcut.
718         
719         (resolveCygwinPath):
720         New method that takes a cygwin unix-style path and returns the Win32 path.
721         
722         (cfStringRefToWString):
723         
724         (LayoutTestController::setUserStyleSheetLocation):
725         Implement this.
726
727 2007-11-29  Alice Liu  <alice.liu@apple.com>
728
729         Reviewed by Adam.
730
731         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
732
733         * DumpRenderTree/win/EventSender.cpp:
734         (keyDownCallback):
735         uppercase letters were being sent as lowercase letters without the shift key down.
736
737 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
738
739         - Windows build fix. VS express needs some love.
740
741         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
742
743 2007-11-28  Darin Adler  <darin@apple.com>
744
745         Reviewed by Adam Roben.
746
747         * DumpRenderTree/mac/EventSendingController.mm:
748         (-[EventSendingController keyDown:withModifiers:]):
749         Send capital letters through as lowercase letters with the shift key down
750         rather than sending them as if they were highly unusual "capital letter keys".
751
752         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
753         where you need to update results and more tests are failing than before.
754
755 2007-11-28  Anders Carlsson  <andersca@apple.com>
756
757         Reviewed by Darin.
758
759         <rdar://problem/5132001>
760         contextClick is not implemented in DRT on Windows.
761         
762         * DumpRenderTree/win/EventSender.cpp:
763         (contextClickCallback):
764         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
765         by a WM_RBUTTONUP message.
766         
767         * DumpRenderTree/win/UIDelegate.cpp:
768         (UIDelegate::hasCustomMenuImplementation):
769         (UIDelegate::trackCustomPopupMenu):
770         * DumpRenderTree/win/UIDelegate.h:
771         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
772         menu from being shown (and causing the DRT to hang).
773
774 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
775
776         Reviewed by Darin.
777
778         Fix DumpRenderTree ObjC bug comparing strings.
779
780         * DumpRenderTree/mac/ObjCController.m:
781         (-[ObjCController identityIsEqual::]): Compare strings with string
782         equality instead of identiy equality.
783
784 2007-11-27  Timothy Hatcher  <timothy@apple.com>
785
786         Reviewed by Sam.
787
788         Reset the authorAndUserStylesEnabled preference
789         back to YES for each test. Fixes the broken tests.
790
791         * DumpRenderTree/mac/DumpRenderTree.mm:
792         (resetWebViewToConsistentStateBeforeTesting):
793
794 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
795
796         Reviewed by Adam.
797
798         - Drosera now displays the console window, although it cannot currently
799         process JavaScript.
800
801         * Drosera/win/DebuggerClient.cpp: Shows the console window.
802         (registerConsoleClass): Implemented.
803         (consoleWndProc): Implemented.
804         (DebuggerClient::onSize): Implemented.
805         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
806         new window.
807         * Drosera/win/DebuggerClient.h: Added needed method and members for 
808         creating and maintaining a new window.
809         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
810         lines of code to more appropriate places.
811         (Drosera::handleCommand):
812         (Drosera::initUI):
813         (Drosera::onSize):
814         (Drosera::attach):
815
816 2007-11-27  Timothy Hatcher  <timothy@apple.com>
817
818         Reviewed by Dave Hyatt.
819
820         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
821         
822         Add support for disabling author and user styles for testing.
823
824         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
825         * DumpRenderTree/LayoutTestController.cpp:
826         (setAuthorAndUserStylesEnabledCallback):
827         (LayoutTestController::staticFunctions):
828         * DumpRenderTree/LayoutTestController.h:
829         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
830         (LayoutTestController::setAuthorAndUserStylesEnabled):
831         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
832         (LayoutTestController::setAuthorAndUserStylesEnabled):
833
834 2007-11-26  Dan Bernstein  <mitz@apple.com>
835
836         - Tiger build fix.
837
838         * DumpRenderTree/mac/Configurations/Base.xcconfig:
839
840 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
841
842         Reviewed by Maciej.
843
844         - Implemented displaying variables for Drosera on Win.
845
846         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
847         that retrieve variables to not hold onto the return value since it's
848         not returned.  Also changed to use the new signatures of the retrieval
849         functions.
850         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
851         (DebuggerDocument::platformValueForScopeVariableNamed):
852         * Drosera/win/Drosera.cpp: Removed a needless TODO.
853         (droseraWndProc):
854
855 2007-11-26  Sam Weinig  <sam@webkit.org>
856
857         Cleanup names of painting and repainting functions.
858
859         Reviewed by Adam Roben.
860
861         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
862         (drawSelectionRect): was drawSelectionRectIntoContext.
863         (dumpWebViewAsPixelsAndCompareWithExpected):
864         * DumpRenderTree/cg/PixelDumpSupportCG.h:
865         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
866         (paintWebView): was drawWebViewIntoContext.
867         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
868
869 2007-11-26  Sam Weinig  <sam@webkit.org>
870
871         Reviewed by Dan Bernstein.
872
873         - Leopard build fix
874
875         * DumpRenderTree/mac/Configurations/Base.xcconfig:
876
877 2007-11-26  Sam Weinig  <sam@webkit.org>
878
879         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
880         Use shared PixelDumpSupport for Mac DRT
881
882         Reviewed by Adam Roben.
883
884         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
885         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
886         * DumpRenderTree/cg/ImageDiffCG.cpp:
887         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
888         (drawSelectionRectIntoContext):
889         (dumpWebViewAsPixelsAndCompareWithExpected):
890         * DumpRenderTree/cg/PixelDumpSupportCG.h:
891         * DumpRenderTree/mac/Configurations/Base.xcconfig:
892         * DumpRenderTree/mac/DumpRenderTree.mm:
893         (dump):
894         * DumpRenderTree/mac/ImageDiff.m: Removed.
895         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
896         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
897         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
898         (setDefaultColorProfileToRGB):
899         (getBitmapContextFromWebView):
900         (drawWebViewIntoContext):
901         (repaintWithVerticalSweep):
902         (repaintWithHorizontalSweep):
903         (getSelectionRect):
904         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
905
906 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
907
908         Bug 16052: prepare-ChangeLog doesn't report deleted files
909         <http://bugs.webkit.org/show_bug.cgi?id=16052>
910
911         Reviewed by Sam.
912
913         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
914
915 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
916
917         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
918         <http://bugs.webkit.org/show_bug.cgi?id=15864>
919
920         Reviewed by Adam.
921
922         Roll functionality of merge-changelog into resolve-ChangeLogs
923         script.  The script now checks for ChangeLog.rej and
924         ChangeLog.orig files first.  If it finds them, it uses the
925         ChangeLog.rej file as a patch (in old contextual diff format) to
926         apply with --fuzz=3.
927
928         * Scripts/merge-changelog: Removed.
929         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
930
931 2007-11-25  Sam Weinig  <sam@webkit.org>
932
933         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
934
935         Reviewed by Mark Rowe.
936
937         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
938         * DumpRenderTree/mac/Configurations/Base.xcconfig:
939         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
940         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
941         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
942
943 2007-11-25  Sam Weinig  <sam@webkit.org>
944
945         Convert DumpRenderTree to ues .xcconfig files.
946
947         Reviewed by Mark Rowe.
948
949         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
950         * DumpRenderTree/mac/Configurations: Added.
951         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
952         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
953         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
954
955 2007-11-25  Sam Weinig  <sam@webkit.org>
956
957         Add ForwardingHeaders to wtf for DumpRenderTree.
958
959         Reviewed by Mark Rowe.
960
961         * DumpRenderTree/DumpRenderTree.h:
962         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
963         * DumpRenderTree/ForwardingHeaders: Added.
964         * DumpRenderTree/ForwardingHeaders/wtf: Added.
965         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
966         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
967         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
968         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
969         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
970         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
971         * DumpRenderTree/LayoutTestController.cpp:
972         * DumpRenderTree/WorkQueue.cpp:
973         * DumpRenderTree/mac/DumpRenderTree.mm:
974         * DumpRenderTree/mac/FrameLoadDelegate.mm:
975         * DumpRenderTree/mac/JavaScriptThreading.cpp:
976         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
977         * DumpRenderTree/mac/ObjCController.m:
978         * DumpRenderTree/mac/UIDelegate.mm:
979         * DumpRenderTree/mac/WorkQueueItemMac.mm:
980
981 2007-11-25  Adam Roben  <aroben@apple.com>
982
983         Fix some test failures caused by r28019
984
985         Now that stdout is in binary mode, we need to always use printf
986         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
987         the output.
988
989         Reviewed by Sam.
990
991         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
992         printf.
993         (UIDelegate::runJavaScriptAlertPanelWithMessage):
994         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
995         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
996         (UIDelegate::webViewAddMessageToConsole):
997
998 2007-11-25  Adam Roben  <aroben@apple.com>
999
1000         Set the font smoothing preference in DRT
1001
1002         This makes the pixel results on Windows closer to the Mac results.
1003
1004         Reviewed by Mitz.
1005
1006         * DumpRenderTree/win/DumpRenderTree.cpp:
1007         (initializePreferences):
1008
1009 2007-11-25  Adam Roben  <aroben@apple.com>
1010
1011         Port ImageDiff to CG and C++
1012
1013         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1014         <rdar://5071708>
1015
1016         Reviewed by Sam.
1017
1018         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1019         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1020         (main):
1021         (createImageFromStdin):
1022         (compareImages):
1023         (getDifferenceBitmap):
1024         (computePercentageDifferent):
1025         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1026
1027 2007-11-25  Adam Roben  <aroben@apple.com>
1028
1029         Fix image diff link generation on Windows
1030
1031         Reviewed by Sam.
1032
1033         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1034         to toURL.
1035
1036 2007-11-25  Adam Roben  <aroben@apple.com>
1037
1038         Implement pixel dumping in Windows DRT
1039
1040         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1041         <rdar://5071708>
1042
1043         Reviewed by Sam.
1044
1045         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1046         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1047         Content-Length header.
1048         (getMD5HashStringForBitmap):
1049         (dumpWebViewAsPixelsAndCompareWithExpected):
1050         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1051         * DumpRenderTree/win/DumpRenderTree.cpp:
1052         (dump): Do a pixel dump if requested.
1053         (main): Parse pixel test options.
1054         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1055         the cg/ subdirectory to the include path.
1056         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1057         available in a header or import library, so we have to go through this
1058         LoadLibrary/GetProcAddress dance to use them.
1059         (cryptDLL):
1060         (init):
1061         (update):
1062         (final):
1063         (MD5_Init):
1064         (MD5_Update):
1065         (MD5_Final):
1066         * DumpRenderTree/win/MD5.h: Added.
1067         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1068         moved up to the top level to share it with Mac eventually.
1069         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1070         (getBitmapContextFromWebView): Forces the WebView to paint using a
1071         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1072
1073 2007-11-25  Adam Roben  <aroben@apple.com>
1074
1075         Clean up Windows DRT's option parsing a little bit
1076
1077         Reviewed by Sam.
1078
1079         * DumpRenderTree/win/DumpRenderTree.cpp:
1080         (main): Put non-option arguments into a Vector.
1081
1082 2007-11-25  Adam Roben  <aroben@apple.com>
1083
1084         Make Windows DRT stop changing LF into CRLF
1085
1086         Reviewed by Sam.
1087
1088         * DumpRenderTree/win/DumpRenderTree.cpp:
1089         (main): Put stdout in binary mode.
1090         * Scripts/run-webkit-tests: Remove the CRLF hack.
1091
1092 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1093
1094         Removed empty directory.
1095
1096         * Scripts/resources: Removed.
1097
1098 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1099
1100         Fix bisect-builds to work with recent WebKit nightly builds.
1101
1102         Reviewed by Dan.
1103
1104         * Scripts/bisect-builds: Check for the 
1105         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1106         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1107         to WebKit.app/Contents/Resources.
1108
1109 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1110
1111         Reviewed by Maciej.
1112
1113         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1114         not closed (affects digg.com)
1115
1116         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1117         one after finishing with a test to avoid having its delayed onload handler firing when
1118         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1119         but it helps somewhat.
1120
1121 2007-11-22  Mark Rowe  <mrowe@apple.com>
1122
1123         Reviewed by Alp Toker.
1124
1125         Fix build-webkit to propagate make's exit status if it fails.
1126
1127         * Scripts/webkitdirs.pm:
1128
1129 2007-11-22  Dan Bernstein  <mitz@apple.com>
1130
1131         Reviewed by Mark Rowe.
1132
1133         - fix crash when running pixel tests
1134
1135         * DumpRenderTree/mac/DumpRenderTree.mm:
1136         (dumpRenderTree): Parse the command line options before setting up the
1137         environment so that we know if we need to set up the pixel dump
1138         machinery.
1139
1140 2007-11-21  Eric Seidel  <eric@webkit.org>
1141
1142         Speculative build fix for Tiger.
1143
1144         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1145
1146 2007-11-21  Eric Seidel  <eric@webkit.org>
1147
1148         Reviewed by Tim Hatcher.
1149
1150         Break out more of DumpRenderTree.mm into individual files
1151
1152         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1153         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1154         (checkedMalloc):
1155         (checkedRealloc):
1156         (makeLargeMallocFailSilently):
1157         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1158         * DumpRenderTree/mac/DumpRenderTree.mm:
1159         (crashHandler):
1160         (dump):
1161         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1162         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1163         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1164         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1165         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1166         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1167         (javaScriptThreads):
1168         (runJavaScriptThread):
1169         (startJavaScriptThreads):
1170         (stopJavaScriptThreads):
1171         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1172         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1173         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1174         (restoreColorSpace):
1175         (setDefaultColorProfileToRGB):
1176         (initializeColorSpaceAndScreeBufferForPixelTests):
1177         (md5HashStringForBitmap):
1178         (dumpWebViewAsPixelsAndCompareWithExpected):
1179
1180 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1181
1182         Move install-unix-extras to wx directory as it seems only to be used by that 
1183         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1184         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1185         have install-unix-extras install into WebKitLibraries as per
1186         convention.
1187         
1188         Reviewed by Mark Rowe.
1189
1190         * Scripts/install-unix-extras: Removed.
1191         * wx/build-wxwebkit:
1192         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1193
1194 2007-11-21  Eric Seidel  <eric@webkit.org>
1195
1196         Reviewed by Adam.
1197
1198         More refactoring for greater code readability
1199
1200         * DumpRenderTree/mac/DumpRenderTree.mm:
1201         (initializeGlobalsFromCommandLineOptions):
1202         (initializeColorSpaceAndScreeBufferForPixelTests):
1203         (addTestPluginsToPluginSearchPath):
1204         (useLongRunningServerMode):
1205         (runTestingServerLoop):
1206         (prepareConsistentTestingEnvironment):
1207         (dumpRenderTree):
1208         (main):
1209         (dumpFramesAsText):
1210         (dumpBackForwardListForWebView):
1211         (sizeWebViewForCurrentTest):
1212         (methodNameStringForFailedTest):
1213         (dumpBackForwardListForAllWindows):
1214         (dumpWebViewAsPixelsAndCompareWithExpected):
1215         (invalidateAnyPreviousWaitToDumpWatchdog):
1216         (dump):
1217         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1218         * DumpRenderTree/mac/UIDelegate.mm:
1219         (-[UIDelegate webView:createWebViewWithRequest:]):
1220
1221 2007-11-21  Eric Seidel  <eric@webkit.org>
1222
1223         Reviewed by Tim Hatcher.
1224
1225         Abstract more of DRT into static methods
1226
1227         * DumpRenderTree/mac/DumpRenderTree.mm:
1228         (setDefaultsToConsistentValuesForTesting):
1229         (setupSignalHandlers):
1230         (allocateGlobalControllers):
1231         (releaseAndZero):
1232         (releaseGlobalControllers):
1233         (dumpRenderTree):
1234         (shouldLogFrameLoadDelegates):
1235         (createCFURLFromPathOrURL):
1236         (resetWebViewToConsistentStateBeforeTesting):
1237         (runTest):
1238
1239 2007-11-21  Eric Seidel  <eric@webkit.org>
1240
1241         Reviewed by Tim Hatcher.
1242
1243         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1244
1245         * DumpRenderTree/DumpRenderTree.h:
1246         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1247         * DumpRenderTree/mac/DumpRenderTree.mm:
1248         (dumpRenderTree):
1249         (dump):
1250         (runTest):
1251         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1252         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1253         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1254         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1255         (-[DumpRenderTreePasteboard declareType:owner:]):
1256         (+[LocalPasteboard alloc]):
1257         (-[LocalPasteboard init]):
1258         (-[LocalPasteboard dealloc]):
1259         (-[LocalPasteboard name]):
1260         (-[LocalPasteboard releaseGlobally]):
1261         (-[LocalPasteboard declareTypes:owner:]):
1262         (-[LocalPasteboard addTypes:owner:]):
1263         (-[LocalPasteboard changeCount]):
1264         (-[LocalPasteboard types]):
1265         (-[LocalPasteboard availableTypeFromArray:]):
1266         (-[LocalPasteboard setData:forType:]):
1267         (-[LocalPasteboard dataForType:]):
1268         (-[LocalPasteboard setPropertyList:forType:]):
1269         (-[LocalPasteboard setString:forType:]):
1270         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1271         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1272         (+[DumpRenderTreeWindow allWindows]):
1273         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1274         (-[DumpRenderTreeWindow dealloc]):
1275         (-[DumpRenderTreeWindow isKeyWindow]):
1276         (-[DumpRenderTreeWindow keyDown:]):
1277
1278 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1279
1280         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1281         it indiscriminately copies any headers inside JavaScriptCore,
1282         which includes Tiger ICU headers. 
1283
1284         * wx/build-wxwebkit:
1285         Don't run WebCore/move-js-headers.sh any longer.
1286
1287 2007-11-20  Adam Treat  <treat@kde.org>
1288
1289         Reviewed by David Kilzer.
1290
1291         * Prepend git branch name to $baseProductDir
1292
1293         * Scripts/VCSUtils.pm:
1294         * Scripts/webkitdirs.pm:
1295
1296 2007-11-20  Mark Rowe  <mrowe@apple.com>
1297
1298         Reviewed by Simon Hausmann.
1299
1300         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1301         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1302         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1303         built product and generated Makefile's are removed.
1304
1305 2007-11-19  Alp Toker  <alp@atoker.com>
1306
1307         Reviewed by Mark Rowe.
1308
1309         http://bugs.webkit.org/show_bug.cgi?id=16040
1310         [GTK] GtkLauncher should be written in C
1311
1312         Port GtkLauncher to plain C.
1313
1314         Use a more conventional GTK+ coding style.
1315
1316         Use a toolbar instead of menus.
1317
1318         Various signature fixes and cleanups.
1319
1320         Add a license header. Assume all previous modifications were copyright
1321         assigned to Apple Inc. by default.
1322
1323         * GtkLauncher/GtkLauncher.pro:
1324         * GtkLauncher/main.c: Added.
1325         (activate_url_entry_cb):
1326         (update_title):
1327         (link_hover_cb):
1328         (title_change_cb):
1329         (progress_change_cb):
1330         (destroy_cb):
1331         (go_back_cb):
1332         (go_forward_cb):
1333         (create_browser):
1334         (create_statusbar):
1335         (create_toolbar):
1336         (create_window):
1337         (main):
1338         * GtkLauncher/main.cpp: Removed.
1339
1340 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1341
1342         Build script fixes to ensure they do the right thing for the 
1343         wx port, and update build-wxwebkit to reflect the way the
1344         build scripts now work.
1345
1346         Reviewed by Adam.
1347
1348         * Scripts/build-testkjs:
1349         * Scripts/build-webkit:
1350         * Scripts/run-javascriptcore-tests:
1351         * Scripts/webkitdirs.pm:
1352         * wx/build-wxwebkit:
1353
1354 2007-11-18  Eric Seidel  <eric@webkit.org>
1355
1356         Reviewed by Anders.
1357
1358         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1359
1360         * Scripts/run-javascriptcore-tests:
1361
1362 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1363
1364         Reviewed by Adam Roben.
1365
1366         Make run-webkit-tests work with Windows debug build.
1367
1368         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1369         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1370         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1371         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1372         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1373
1374 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1375
1376         Add wxWebKit sample and build script, and integrate it with 
1377         build-webkit. Also make build-webkit --clean work for all
1378         ports.
1379
1380         Reviewed by Darin Adler.
1381
1382         * Scripts/build-webkit:
1383         * Scripts/webkitdirs.pm:
1384         * wx: Added.
1385         * wx/browser: Added.
1386         * wx/browser/browser.bkl: Added.
1387         * wx/browser/browser.cpp: Added.
1388         * wx/build-wxwebkit: Added.
1389
1390 2007-11-17  Adam Roben  <aroben@apple.com>
1391
1392         Make it easy to run Safari in the debugger on Windows
1393
1394         I've added a new script, debug-safari, which launches Safari in the
1395         debugger. On OS X it just calls gdb-safari.
1396
1397         Reviewed by Mark Rowe.
1398
1399         * FindSafari/FindSafari.cpp:
1400         (_tmain): Added a /debugger flag, which in combination with
1401         /printSafariLauncher will print a script that launches Safari in the
1402         debugger.
1403         * Scripts/debug-safari: Added.
1404         * Scripts/run-safari: Changed to call runSafari().
1405         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1406         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1407         first argument along to FindSafari.
1408         * Scripts/webkitdirs.pm:
1409         (sub runSafari): Added.
1410
1411 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1412
1413         Reviewed by Adam Roben.
1414
1415         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1416
1417 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1418
1419         Reviewed by David Kilzer.
1420
1421         The git config command was renamed to repo-config at some point. This
1422         change tries git config and then git repo-config if the first fails.
1423
1424         * Scripts/prepare-ChangeLog:
1425         (gitConfig):
1426
1427 2007-11-16  Dan Bernstein  <mitz@apple.com>
1428
1429         Reviewed by Darin Adler and Sam Weinig.
1430
1431         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1432
1433         * DumpRenderTree/win/EventSender.cpp:
1434         (keyDownCallback): For characters that cannot be entered on the active
1435         keyboard layout, send a WM_CHAR message with the character along with
1436         a WM_KEYDOWN message with a virtual key code of 255.
1437
1438 2007-11-16  Mark Rowe  <mrowe@apple.com>
1439
1440         Reviewed by Tim Hatcher.
1441
1442         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1443
1444         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1445         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1446
1447 2007-11-15  Adam Roben  <aroben@apple.com>
1448
1449         Make run-safari actually work on Windows
1450
1451         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1452         chdir call.
1453
1454 2007-11-14  Adam Roben  <aroben@apple.com>
1455
1456         Updates to Safari launching now that 3.0.4 is released
1457
1458         Reviewed by Sam.
1459
1460         * FindSafari/FindSafari.cpp:
1461         (getWebViewCLSID): Use version-independent ProgID.
1462         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1463
1464 2007-11-14  Anders Carlsson  <andersca@apple.com>
1465
1466         Reviewed by Adam.
1467
1468         <rdar://problem/5309081>
1469         In DRT, "plugin.logDestroy = true" not working on Windows.
1470         
1471         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1472         (NPP_Destroy):
1473
1474 2007-11-14  Eric Seidel  <eric@webkit.org>
1475
1476         Reviewed by Sam.
1477
1478         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1479
1480 2007-11-14  Anders Carlsson  <andersca@apple.com>
1481
1482         Reviewed by Adam.
1483
1484         <rdar://problem/5141186>
1485         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1486         
1487         Implement setWindowIsKey.
1488         
1489         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1490         (LayoutTestController::setWindowIsKey):
1491
1492 2007-11-13  Sam Weinig  <sam@webkit.org>
1493
1494         Reviewed by Adam Roben.
1495
1496         Fix for <rdar://problem/5382579>
1497         http/tests/security/cross-frame-access-put.html reports large 
1498         negative numbers for screenLeft and screenTop (Mac reports "0")
1499
1500         * DumpRenderTree/win/UIDelegate.cpp:
1501         (UIDelegate::UIDelegate): Initialize the RECT.
1502         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1503         (UIDelegate::webViewFrame): ditto.
1504         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1505
1506 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1507
1508         Reviewed by Adam.
1509
1510         - Make Drosera show source, source URLs, and function stack on Windows,
1511         and some minor fixes.
1512
1513         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1514         (DebuggerDocument::updateFileSource):
1515         * Drosera/debugger.js: Force source to always update display.
1516         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1517         menu controls.
1518         (DebuggerClient::resume):
1519         (DebuggerClient::pause):
1520         (DebuggerClient::stepInto):
1521         (DebuggerClient::stepOver):
1522         (DebuggerClient::stepOut):
1523         (DebuggerClient::showConsole):
1524         (DebuggerClient::closeCurrentFile):
1525         * Drosera/win/DebuggerClient.h: Ditto.
1526         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1527         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1528         removed two bugs.  1) caller could be in a bad state when asked to
1529         assign into it. 2) BSTRs were not created correctly.
1530         (DebuggerDocument::getPlatformCurrentFunctionStack):
1531         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1532         (droseraWndProc):
1533         (handleCommand):
1534         (Drosera::resume):
1535         (Drosera::pause):
1536         (Drosera::stepInto):
1537         (Drosera::stepOver):
1538         (Drosera::stepOut):
1539         (Drosera::showConsole):
1540         (Drosera::closeCurrentFile):
1541         * Drosera/win/Drosera.h: Hook up the menu controls.
1542         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1543         functions, added a null check, and fixed another bug where caller could
1544         be in a bad state when asked to assign into it.
1545         (ServerConnection::didLoadMainResourceForDataSource):
1546         (ServerConnection::getCallerFrame):
1547         * Drosera/win/ServerConnection.h: Safety first.
1548
1549 2007-11-13  Dan Bernstein  <mitz@apple.com>
1550
1551         Reviewed by Darin Adler.
1552
1553         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1554           DumpRenderTree --pixel-tests renders each test twice
1555
1556         * DumpRenderTree/mac/DumpRenderTree.mm:
1557         (dumpRenderTree): Removed the --paint option because the painting code
1558         is always exercised as a result of
1559         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1560         calling -displayIfNeeded.
1561         (dump): Changed to always grab the image from the window since the view
1562         is always displayed.
1563         (runTest):
1564         (displayWebView):
1565         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1566         because it always paints.
1567
1568 2007-11-12  Antti Koivisto  <antti@apple.com>
1569
1570         Reviewed by Adele.
1571         
1572         Add support for http media tests
1573
1574         * Scripts/run-webkit-tests:
1575
1576 2007-11-12  Sam Weinig  <sam@webkit.org>
1577
1578         Reviewed by Adam Roben.
1579
1580         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1581
1582         * DumpRenderTree/win/DumpRenderTree.cpp:
1583         (runTest):
1584         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1585         (LayoutTestController::setPrivateBrowsingEnabled):
1586
1587 2007-11-12  Adam Roben  <aroben@apple.com>
1588
1589         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1590         mac and win subdirectories.
1591
1592 2007-11-11  Adam Roben  <aroben@apple.com>
1593
1594         Fix <rdar://5133816> keepWebHistory is not implemented
1595
1596         Fixes fast/history/clicked-link-is-visited.html.
1597
1598         Reviewed by Darin.
1599
1600         * DumpRenderTree/win/DumpRenderTree.cpp:
1601         (runTest): Clear the optionalSharedHistory.
1602         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1603         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1604
1605 2007-11-10  Sam Weinig  <sam@webkit.org>
1606
1607         Reviewed by Tim Hatcher.
1608
1609         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1610         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1611         is turned on)
1612
1613         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1614
1615         Added test: http/tests/security/cross-frame-access-private-browsing.html
1616
1617         * DumpRenderTree/LayoutTestController.cpp:
1618         (setPrivateBrowsingEnabledCallback):
1619         (LayoutTestController::staticFunctions):
1620         * DumpRenderTree/LayoutTestController.h:
1621         * DumpRenderTree/mac/DumpRenderTree.mm:
1622         (runTest): Default to private browsing disabled.
1623         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1624         (LayoutTestController::setPrivateBrowsingEnabled):
1625         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1626         (LayoutTestController::setPrivateBrowsingEnabled):
1627
1628 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1629
1630         Reviewed by Adam.
1631
1632         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1633         WebCore's!
1634
1635         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1636         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1637         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1638         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1639         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1640         * Drosera/win/Drosera.cpp:
1641         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1642
1643 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1644
1645         Reviewed by Sam.
1646
1647         - Use the new IWebFrame [local] function signature and get the shared
1648         server correctly.
1649
1650         * Drosera/win/DebuggerClient.cpp:
1651         (DebuggerClient::didFinishLoadForFrame):
1652         * Drosera/win/ServerConnection.cpp:
1653         (ServerConnection::attemptToCreateServerConnection):
1654
1655 2007-11-07  Dan Bernstein  <mitz@apple.com>
1656
1657         Reviewed by Darin Adler.
1658
1659         - add an option to run-webkit-tests to ignore pixel test failures where
1660           all pixels differ by no more than a specified threshold
1661
1662         * DumpRenderTree/mac/ImageDiff.m:
1663         (main):
1664         (compareImages):
1665         (computePercentageDifferent):
1666         * Scripts/run-webkit-tests:
1667
1668 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1669
1670         Reviewed by Lars.
1671
1672         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1673
1674         * DumpRenderTree/qt/DumpRenderTree.cpp:
1675
1676 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1677
1678         Reviewed by Lars.
1679
1680         Reworked the QWebSettings API.
1681         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1682
1683         * DumpRenderTree/qt/DumpRenderTree.cpp:
1684
1685 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1686
1687         Reviewed by Lars.
1688
1689         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1690
1691         * DumpRenderTree/qt/jsobjects.cpp:
1692
1693 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1694
1695         Reviewed by Lars Knoll <lars@trolltech.com>.
1696
1697         Add a QWebPage::frameCreated() signal and fix DRT
1698         
1699         The removal of createFrame in QWebPage broke the re-implementation
1700         in DumpRenderTree. Instead emit a frameCreated() signal and
1701         connect to it in DumpRenderTree.
1702         
1703
1704         * DumpRenderTree/qt/DumpRenderTree.cpp:
1705         (WebCore::WebPage::WebPage):
1706         (WebCore::DumpRenderTree::dump):
1707         (WebCore::DumpRenderTree::connectFrame):
1708         * DumpRenderTree/qt/DumpRenderTree.h:
1709
1710 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1711
1712         Reviewed by Lars Knoll <lars@trolltech.com>.
1713
1714         Moved all the event handlers from QWebFrame into QWebPage.
1715         
1716         This cleans up the public API and allows us to remove the
1717         HackWebFrame hack in DumpRenderTree.
1718         
1719
1720         * DumpRenderTree/qt/jsobjects.cpp:
1721         (EventSender::mouseDown):
1722         (EventSender::mouseUp):
1723         (EventSender::mouseMoveTo):
1724
1725 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1726
1727         Reviewed by Mark.
1728
1729         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1730         to prevent the default implementation from popping up messageboxes.
1731
1732         * DumpRenderTree/qt/DumpRenderTree.cpp:
1733         (WebCore::WebPage::javaScriptConfirm):
1734         (WebCore::WebPage::javaScriptPrompt):
1735
1736 2007-11-06  Eric Seidel  <eric@webkit.org>
1737
1738         * Scripts/build-testkjs: build fix... too many $$
1739
1740 2007-11-06  Eric Seidel  <eric@webkit.org>
1741
1742         Reviewed by Mark Rowe.
1743
1744         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1745
1746 2007-11-05  Adam Roben  <aroben@apple.com>
1747
1748         Add support on Windows for WEBKIT_TESTFONTS
1749
1750         This environment variable lets you specify where the fonts to be used
1751         by DumpRenderTree reside. The Qt port is already using this, so I'm
1752         just following their lead.
1753
1754         Reviewed by Darin.
1755
1756         * DumpRenderTree/win/DumpRenderTree.cpp:
1757         (exePath): Refactored code out of initialize().
1758         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1759         DumpRenderTree.resources.
1760         (initialize): Use the new fontsPath function.
1761         (main): Use the new exePath function.
1762         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1763         variable to DRT, like Qt does.
1764
1765 2007-11-05  Mark Rowe  <mrowe@apple.com>
1766
1767         Rubber-stamped by Alp Toker.
1768
1769         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1770
1771         * GtkLauncher/main.cpp:
1772         (goToURLBarText):
1773         (main):
1774
1775 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1776
1777         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1778         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1779
1780         Reviewed by Timothy.
1781
1782         Restrict the range of nightly builds used by the bisect-builds script
1783         based on the version of Safari and the version of Mac OS X being used.
1784
1785         Mac OS X 10.4: Safari 2.0: r11976 or newer
1786         Mac OS X 10.4: Safari 3.0: r19992 or newer
1787
1788         Mac OS X 10.5: Safari 2.0: r19594 or newer
1789         Mac OS X 10.5: Safari 3.0: r25124 or newer
1790
1791         * Scripts/bisect-builds:
1792         (findMacOSXVersion): Added.
1793         (makeNightlyList): Added argument to provide version of Mac OS X.
1794         Restrict range of nightly builds based on Safari and Mac OS X versions.
1795
1796 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1797
1798         Reviewed by Maciej.
1799
1800         - This patch involves several changes, all of them were noticed that
1801         they were needed by the work being done in WebKit to get Drosera and
1802         WebKit working together on Windows.
1803         - The changes are:
1804         1) Added a debugger console for output messages.
1805         2) Drosera now listens for the WebKit server (before, the server would
1806         have to be running before Drosera was started.)
1807         3) Fixed a bug where the WebView started out as 0x0 pixels.
1808         4) Fixed a bug when there is no scope.
1809         5) Added the HTML, JS, and CSS to the project file to make them easy to
1810         find.
1811         6) Made the ServerConnection functions virtual.
1812
1813         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1814         for the WebKit server.
1815         (DebuggerClient::DebuggerClient):
1816         (DebuggerClient::~DebuggerClient):
1817         (DebuggerClient::didFinishLoadForFrame):
1818         (DebuggerClient::serverConnected):
1819         (DebuggerClient::attemptToCreateServerConnection):
1820         * Drosera/win/DebuggerClient.h: Ditto.
1821         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1822         scope.
1823         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1824         (DebuggerDocument::platformValueForScopeVariableNamed):
1825         * Drosera/win/Drosera.cpp:
1826         (_tWinMain): Added a console in debug for output messages.
1827         (Drosera::Drosera): Listen for server.
1828         (Drosera::initUI): The server now Initializes COM.
1829         (Drosera::serverConnected): Part of the listening for the server.
1830         (Drosera::attemptToCreateServerConnection): Ditto.
1831         * Drosera/win/Drosera.h: New interface for listening for the server.
1832         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1833         files to the VS project.
1834         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1835         connection.
1836         (ServerConnection::ServerConnection):
1837         (ServerConnection::attemptToCreateServerConnection):
1838         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1839         methods.
1840         (ServerConnection::serverConnected):
1841
1842 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1843
1844         Reviewed by Maciej.
1845
1846         http://bugs.webkit.org/show_bug.cgi?id=15832
1847         fast/dom/gc-10.html crashes when run alone
1848
1849         Check for !done before using objects that can be already deallocated.
1850
1851         * DumpRenderTree/mac/EditingDelegate.mm:
1852         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1853         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1854         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1855         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1856         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1857         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1858         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1859         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1860         (-[EditingDelegate webViewDidBeginEditing:]):
1861         (-[EditingDelegate webViewDidChange:]):
1862         (-[EditingDelegate webViewDidEndEditing:]):
1863         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1864         (-[EditingDelegate webViewDidChangeSelection:]):
1865         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1866         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1867         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1868         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1869         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1870         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1871         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1872         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1873         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1874         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1875         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1876         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1877         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1878         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1879         (-[FrameLoadDelegate webView:willCloseFrame:]):
1880         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1881         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1882         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1883         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1884         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1885         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1886         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1887         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1888         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1889
1890 2007-11-04  Mark Rowe  <mrowe@apple.com>
1891
1892         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1893         warnings that would otherwise be suppressed due to it being a system header.
1894
1895         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1896
1897 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1898
1899         Rubber stamped by Adam.
1900         
1901         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1902
1903         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1904
1905 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1906
1907         Sort files(...); sections of Xcode project files.
1908
1909         Rubber-stamped by Darin.
1910
1911         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1912         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1913         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1914         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1915
1916 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1917
1918         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1919
1920         Reviewed by Darin.
1921
1922         * Scripts/sort-Xcode-project-file: Added.
1923
1924 2007-11-02  Darin Adler  <darin@apple.com>
1925
1926         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1927
1928 2007-11-02  Darin Adler  <darin@apple.com>
1929
1930         Reviewed by Maciej.
1931
1932         * Scripts/run-sunspider: Pass the "--base" option through.
1933
1934         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1935         the real script do that. Default configuration to Release to match run-sunspider
1936         so we don't end up building Debug just to compare results.
1937
1938 2007-11-01  Adam Roben  <aroben@apple.com>
1939
1940         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1941
1942         Reviewed by Sam.
1943
1944         * Scripts/commit-log-editor: Show all the directories beneath the
1945         source root, instead of just the last one.
1946
1947 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1948
1949         Reviewed by Adam Roben.
1950
1951         Print out an error message when the Windows build fails
1952         and provide guidance on how to find out what went wrong.
1953
1954         * Scripts/build-webkit:
1955         * Scripts/webkitdirs.pm:
1956
1957 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1958
1959         Rubber-stamped by Adam Roben.
1960
1961         Rolled out r27326 - debug CRT seems to cause no problems after all.
1962
1963         * DumpRenderTree/win/DumpRenderTree.vcproj:
1964
1965 2007-10-31  Adam Roben  <aroben@apple.com>
1966
1967         Switch the Debug configuration to using the non-debug CRT
1968
1969         This matches WebKit.
1970
1971         Reviewed by Steve.
1972
1973         * DumpRenderTree/win/DumpRenderTree.vcproj:
1974
1975 2007-10-31  Antti Koivisto  <antti@apple.com>
1976
1977         Reviewed by bdash.
1978         
1979         Disable media tests when doing leak checking on Tiger.
1980         They crash in QuickTime (rdar://problem/5537157).
1981
1982         * Scripts/run-webkit-tests:
1983
1984 2007-10-29  Antti Koivisto  <antti@apple.com>
1985
1986         Reviewed by Maciej.
1987         
1988         Build media support by default on OSX only.
1989
1990         * Scripts/build-webkit:
1991
1992 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1993
1994         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1995         get caught by the pre-commit hooks.
1996
1997 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1998
1999         Reviewed by Adam.
2000
2001         - This is a collection of relatively unrelated changes and cleanups
2002         to Drosera to prepare it for interacting with WebKit.  A lot of these
2003         changes are just correcting mistakes, for example removing included
2004         headers that are no longer needed.
2005
2006         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2007         this will be needed by the DebuggerClient.
2008         (DebuggerDocument::server):
2009         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2010         * Drosera/win/DebuggerClient.cpp: 
2011         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2012         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2013         (DebuggerClient::createWebViewWithRequest): Added comment about its
2014         purpose. 
2015         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2016         declarations.
2017         (DebuggerClient::webViewLoaded): Moved.
2018         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2019         file, since this was the only place it was used.
2020         (cfStringToBSTR):
2021         * Drosera/win/Drosera.h: Cleaned up the includes.
2022         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2023         * Drosera/win/HelperFunctions.h: Removed.
2024
2025 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2026
2027         Reviewed by Adam.
2028
2029         - Small cleanup in the ServerConnection class.
2030
2031         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2032         and added an include.
2033         (ServerConnection::currentFrame):
2034         (ServerConnection::getCallerFrame):
2035         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2036         made a pointer into a COMPtr, and cleaned up the includes.
2037
2038 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2039
2040         Reviewed by John Sullivan.
2041         
2042         - Place the Localizable.strings file in mac or win directories
2043           if that location exists.
2044         - Also look for UI_STRING in .c files.
2045
2046         * Scripts/extract-localizable-strings:
2047
2048 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2049
2050         Reviewed by Adam.
2051
2052         - Set the eol-style to native and made all the line endings the same
2053         so that I avoid messy diffs that show eol changes.
2054
2055         * Drosera/win/ServerConnection.cpp:
2056         (ServerConnection::didParseSource):
2057         (ServerConnection::didEnterCallFrame):
2058         (ServerConnection::willExecuteStatement):
2059         (ServerConnection::willLeaveCallFrame):
2060         (ServerConnection::exceptionWasRaised):
2061
2062 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2063
2064         Reviewed by Adam.
2065
2066         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2067         functionality that could not have existed previously without the new
2068         interfaces.
2069         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2070         from a BSTR to a JSValueRef.
2071         (DebuggerDocument::platformEvaluateScript): Implemented.
2072         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2073         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2074         Implemented.
2075         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2076         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2077         * Drosera/win/ServerConnection.cpp: Added a helper function.
2078         (ServerConnection::getCallerFrame):
2079         * Drosera/win/ServerConnection.h: Added a helper function.
2080
2081 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2082
2083         updated reviewers for my previous changelog.
2084
2085 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2086         Reviewed by Maciej and Adam and Geoff.
2087
2088         - Minor mac-side improvements including moving a function to a more
2089         appropriate location, fixing a warning, and correctly checking
2090         exceptions.
2091
2092         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2093         (DebuggerDocument::willExecuteStatement):
2094         (DebuggerDocument::didEnterCallFrame):
2095         (DebuggerDocument::willLeaveCallFrame):
2096         (DebuggerDocument::windowScriptObjectAvailable):
2097         (DebuggerDocument::callFunctionOnObject):
2098         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2099         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2100         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2101         because it doesn't require the ServerConnection at all.
2102         (NSStringCreateWithJSStringRef): Made an argument const.
2103         (JSValueRefCreateWithNSString): Made an argument const.
2104         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2105         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2106         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2107         * Drosera/mac/ServerConnection.mm: Ditto.
2108         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2109
2110 2007-10-29  Sam Weinig  <sam@webkit.org>
2111
2112         Reviewed by Adam Roben.
2113
2114         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2115
2116         * DumpRenderTree/LayoutTestController.cpp:
2117         (LayoutTestController::LayoutTestController):
2118         (getGlobalFlagCallback):
2119         (setGlobalFlagCallback):
2120         (LayoutTestController::getJSClass):
2121         (LayoutTestController::staticValues):
2122         * DumpRenderTree/LayoutTestController.h:
2123         (LayoutTestController::globalFlag):
2124         (LayoutTestController::setGlobalFlag):
2125
2126 2007-10-29  Darin Adler  <darin@apple.com>
2127
2128         Reviewed by Maciej.
2129
2130         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2131         resolution instead of its default.
2132
2133 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2134
2135         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2136
2137         Reviewed by Mark Rowe.
2138
2139         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2140         was successfully resolved, but this would not show any status because the change had
2141         already been cached in the index using "git add".  The solution is to add an optional
2142         second argument to showStatus() which adds the "--cached" switch to the command.
2143
2144         * Scripts/resolve-ChangeLogs:
2145         (showStatus):
2146
2147 2007-10-28  Eric Seidel  <eric@webkit.org>
2148
2149         Reviewed by Maciej and Geoff, in unison.
2150
2151         * Scripts/run-webkit-tests: remove broken --svg option
2152
2153 2007-10-28  Darin Adler  <darin@apple.com>
2154
2155         Reviewed by Adam.
2156
2157         * Scripts/run-sunspider: Default to "Release" configuration rather than
2158         defaulting to the last configuration used as other scripts do. This can
2159         still be overriden on the command line with "--debug" if there's some
2160         reason to do so. Also fix a typo.
2161
2162         * Scripts/sunspider-compare-results: Fix a typo.
2163
2164 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2165
2166         Reviewed by Adam.
2167
2168         - Implemented the WebScriptDebugListener functions now that the
2169         WebScriptDebugServer exists
2170
2171         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2172         functions.
2173         (ServerConnection::currentFrame):
2174         (ServerConnection::didLoadMainResourceForDataSource):
2175         (ServerConnection::didParseSource):
2176         (ServerConnection::failedToParseSource):
2177         (ServerConnection::didEnterCallFrame):
2178         (ServerConnection::willExecuteStatement):
2179         (ServerConnection::willLeaveCallFrame):
2180         (ServerConnection::exceptionWasRaised):
2181         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2182         members arguments list.
2183
2184 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2185
2186         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2187         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2188
2189         Reviewed by Darin.
2190
2191         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2192         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2193         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2194         file.  Note that it may also be used as a stand-alone script.
2195
2196         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2197         * Scripts/resolve-ChangeLogs: Added.
2198         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2199
2200 2007-10-26  Mark Rowe  <mrowe@apple.com>
2201
2202         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2203         to the Qt port on the assumption that it was an implementation of the cross-platform
2204         LayoutTestController class.  It is not, so it did not need to be changed.
2205
2206         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2207
2208 2007-10-25  Mark Rowe  <mrowe@apple.com>
2209
2210         Reviewed by Maciej.
2211
2212         Fix builds with code coverage enabled.
2213
2214         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2215
2216 2007-10-25  Darin Adler  <darin@apple.com>
2217
2218         Reviewed by Mark Rowe.
2219
2220         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2221         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2222
2223 2007-10-25  Stephanie  <slewis@apple.com>
2224
2225         build Fix
2226
2227         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2228
2229 2007-10-25  Stephanie  <slewis@apple.com>
2230
2231         Reviewed by Mark Rowe, Adam Roben.
2232
2233         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2234
2235         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2236
2237 2007-10-25  Alice Liu  <alice.liu@apple.com>
2238
2239         Reviewed by Adam.
2240
2241         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2242
2243         Moving destructor into platform-specific files
2244         * DumpRenderTree/LayoutTestController.cpp:
2245         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2246         (LayoutTestController::~LayoutTestController):
2247         * DumpRenderTree/qt/jsobjects.cpp:
2248         (LayoutTestController::~LayoutTestController):
2249
2250         LayoutTestController wasn't being destroyed
2251         * DumpRenderTree/win/DumpRenderTree.cpp:
2252         (runTest):
2253
2254         Added declspec
2255         * DumpRenderTree/win/EditingDelegate.h:
2256
2257         Reset certain values on the webview (or related delegate) that might 
2258         have changed while running a test
2259         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2260         (LayoutTestController::~LayoutTestController):
2261
2262 2007-10-25  Adam Roben  <aroben@apple.com>
2263
2264         Make sunspider-compare-results work with relative paths
2265
2266         Reviewed by Sam.
2267
2268         * Scripts/sunspider-compare-results: Convert arguments to absolute
2269         paths before we chdir.
2270
2271 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2272
2273         Reviewed by Sam.
2274
2275         - Implemented server calls now the WebScriptDebugServer exists.
2276         - Also removed no longer needed call to initialize CG.
2277
2278         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2279         automatically now.
2280         (_tWinMain):
2281         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2282         (ServerConnection::ServerConnection):
2283         (ServerConnection::~ServerConnection):
2284         (ServerConnection::pause):
2285         (ServerConnection::resume):
2286         (ServerConnection::stepInto):
2287         (ServerConnection::applicationTerminating):
2288         (ServerConnection::serverConnectionDidDie):
2289         * Drosera/win/ServerConnection.h: Now uses the COM class.
2290
2291 2007-10-24  George Staikos  <staikos@kde.org>
2292
2293         Unbreak Qt build.
2294
2295         * Scripts/build-webkit:
2296
2297 2007-10-24  Adam Roben  <aroben@apple.com>
2298
2299         Remove now-unnecessary call to InitializeCoreGraphics
2300
2301         WebKit takes care of this now.
2302
2303         Reviewed by Ada.
2304
2305         * DumpRenderTree/win/DumpRenderTree.cpp:
2306         (initialize):
2307
2308 2007-10-24  Adam Roben  <aroben@apple.com>
2309
2310         Use WebTextRenderer in DRT
2311
2312         Reviewed by Ada.
2313
2314         * DumpRenderTree/win/DumpRenderTree.cpp:
2315         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2316
2317 2007-10-24  Sven Herzberg  <sven@imendio.com>
2318
2319         Reviewed by Mark Rowe.
2320
2321         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2322         Bug 15614: [GTK] qmake based backends don't build on OS X
2323
2324         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2325         GTK backend on a Mac
2326         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2327         isDarwin() to make it reusable in other places (like the workaround-
2328         for-prebuilt-qmake in build-webkit)
2329
2330 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2331
2332         Refurbish update-webkit script.
2333
2334         Reviewed by Adam.
2335
2336         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2337         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2338         multi-argument version of system() for flexibility and security.  Check for existence
2339         of Internal directory using -d test instead of -x.
2340
2341 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2342
2343         Minor clean-up of prepare-ChangeLog script.
2344
2345         Reviewed by Adam.
2346
2347         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2348         of a string.  Use multi-argument versions of open() and system() for flexibility and
2349         security.
2350
2351 2007-10-24  Alice Liu  <alice.liu@apple.com>
2352
2353         Reviewed by Oliver.
2354
2355         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2356
2357         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2358         replay the saved events when we're still processing the mousedown that starts the drag
2359         * DumpRenderTree/win/EventSender.cpp:
2360         (doMouseMove):
2361         * DumpRenderTree/win/UIDelegate.cpp:
2362         (UIDelegate::doDragDrop):
2363
2364 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2365
2366         Reviewed by Sam, Steve and Darin.
2367
2368         - Stubbed out the WebScriptDebugListener functionality in the Server
2369         Connection class to prepare it for receiving those callbacks.
2370         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2371         and the ServerConnection to not need to be initialized with a server
2372         name, since that is not the way we connect to the WebKit server. 
2373
2374         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2375         no exception.  Now it only loggs when there is an exception
2376         (DebuggerDocument::willExecuteStatement):
2377         (DebuggerDocument::didEnterCallFrame):
2378         (DebuggerDocument::willLeaveCallFrame):
2379         (DebuggerDocument::windowScriptObjectAvailable):
2380         (DebuggerDocument::callFunctionOnObject):
2381         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2382         to be instantiated with a server's name.
2383         (DebuggerClient::DebuggerClient):
2384         (DebuggerClient::didFinishLoadForFrame):
2385         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2386         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2387         a server name.
2388         (Drosera::init):
2389         (Drosera::initServer):
2390         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2391         instantiated with a server's name.
2392         * Drosera/win/ServerConnection.cpp: 
2393         (ServerConnection::ServerConnection): No longer needs a server name
2394         (ServerConnection::~ServerConnection): Only release the global context
2395         if there is one.
2396         (ServerConnection::serverConnectionDidDie): Stub for
2397         IWebScriptDebugListener
2398         (ServerConnection::QueryInterface): ditto
2399         (ServerConnection::AddRef): ditto
2400         (ServerConnection::Release): ditto
2401         (ServerConnection::didLoadMainResourceForDataSource): ditto
2402         (ServerConnection::didParseSource): ditto
2403         (ServerConnection::failedToParseSource): ditto
2404         (ServerConnection::didEnterCallFrame): ditto
2405         (ServerConnection::willExecuteStatement): ditto
2406         (ServerConnection::willLeaveCallFrame): ditto
2407         (ServerConnection::exceptionWasRaised): ditto
2408         * Drosera/win/ServerConnection.h: Stubbed out the
2409         IWebScriptDebugListener functions, and this class no longer needs to be
2410         instantiated with a server name.
2411
2412 2007-10-24  Lars Knoll  <lars@trolltech.com>
2413
2414         Reviewed by Simon.
2415
2416         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2417
2418         * DumpRenderTree/qt/jsobjects.h:
2419
2420 2007-10-24  Lars Knoll  <lars@trolltech.com>
2421
2422         Reviewed by Simon.
2423
2424         add another command.
2425
2426         * DumpRenderTree/qt/jsobjects.cpp:
2427         (TextInputController::doCommand):
2428
2429 2007-10-24  Lars Knoll  <lars@trolltech.com>
2430
2431         Reviewed by Simon.
2432
2433         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2434
2435         * DumpRenderTree/qt/jsobjects.cpp:
2436         (EventSender::keyDown):
2437         * DumpRenderTree/qt/jsobjects.h:
2438
2439 2007-10-24  Lars Knoll  <lars@trolltech.com>
2440
2441         Reviewed by Simon.
2442
2443         implement eventSender.keyDown().
2444
2445         * DumpRenderTree/qt/jsobjects.cpp:
2446         (EventSender::keyDown):
2447
2448 2007-10-24  Lars Knoll  <lars@trolltech.com>
2449
2450         Reviewed by Simon.
2451
2452         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2453
2454         * DumpRenderTree/qt/DumpRenderTree.cpp:
2455         (WebCore::DumpRenderTree::DumpRenderTree):
2456         (WebCore::DumpRenderTree::initJSObjects):
2457         * DumpRenderTree/qt/jsobjects.cpp:
2458         (TextInputController::doCommand):
2459
2460 2007-10-24  Lars Knoll  <lars@trolltech.com>
2461
2462         Reviewed by Simon.
2463
2464         first bit of implementation for the textinputcontroller.
2465
2466         * DumpRenderTree/qt/DumpRenderTree.cpp:
2467         (WebCore::DumpRenderTree::DumpRenderTree):
2468         * DumpRenderTree/qt/DumpRenderTree.h:
2469         * DumpRenderTree/qt/jsobjects.cpp:
2470         (TextInputController::TextInputController):
2471         (TextInputController::doCommand):
2472         * DumpRenderTree/qt/jsobjects.h:
2473
2474 2007-10-24  Lars Knoll  <lars@trolltech.com>
2475
2476         Reviewed by Simon.
2477
2478         make the man webpage believe it has focus, so the editing tests work correctly.
2479
2480         * DumpRenderTree/qt/DumpRenderTree.cpp:
2481         (WebCore::DumpRenderTree::DumpRenderTree):
2482
2483 2007-10-24  Lars Knoll  <lars@trolltech.com>
2484
2485         Reviewed by Simon.
2486
2487         implement layoutTestController.dumpEditingCallbacks() correctly.
2488
2489         * DumpRenderTree/qt/DumpRenderTree.cpp:
2490         (WebCore::DumpRenderTree::DumpRenderTree):
2491         * DumpRenderTree/qt/jsobjects.cpp:
2492         (LayoutTestController::reset):
2493         (LayoutTestController::dumpEditingCallbacks):
2494
2495 2007-10-24  Lars Knoll  <lars@trolltech.com>
2496
2497         Reviewed by Simon.
2498
2499         Implement support for testing editing.
2500
2501         * DumpRenderTree/qt/DumpRenderTree.cpp:
2502         (WebCore::DumpRenderTree::DumpRenderTree):
2503
2504 2007-10-23  Sam Weinig  <sam@webkit.org>
2505
2506         Check for null BSTR that can be passed to the UIDelegate methods
2507         from javascript null and undefined.  Fixes a failing test case on
2508         Windows (fast/dom/Window/alert-undefined.html)
2509
2510         Reviewed by Eric Seidel.
2511
2512         * DumpRenderTree/win/UIDelegate.cpp:
2513         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2514         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2515         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2516         (UIDelegate::webViewAddMessageToConsole):
2517
2518 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2519
2520         Reviewed by Darin.
2521         
2522         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2523
2524         * Scripts/build-testkjs:
2525
2526 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2527
2528         Reviewed by Darin.
2529
2530         - add wrapper that finds the right copy of testkjs
2531         
2532         * Scripts/sunspider-compare-results: Added.
2533
2534 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2535
2536         Reviewed by Sam.
2537
2538         - After talking with Steve I now see that the WebKit server must be
2539         running for DCOM to create the distributed objects, which makes sense
2540         and currently WebKit only allows one instance to be running at a time
2541         which avoids accidentally connecting to the wrong server
2542         - In light of this I have removed the code for the attach box and
2543         NotificationServer and known server names, since they are all extranious
2544         now.
2545
2546         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2547         names.
2548         (_tWinMain): Uses init instead of initUI.
2549         (droseraWndProc): No longer creats an attach dialog box.
2550         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2551         it's not manditory to call init before doing COM stuff.
2552         (Drosera::init): calls initUI and will call attach when the
2553         functionality exists. 
2554         (Drosera::initUI): Has changed very little.
2555         (Drosera::attach): Changed the signature to reflect that we no longer
2556         need the dictionary of known server names.
2557         * Drosera/win/Drosera.h: Removed notification classes and known server
2558         names.  Also renamed and moved some functions.
2559         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2560         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2561         headers to the resources folder. 
2562         * Drosera/win/resource.h: Removed the Attach box.
2563
2564 2007-10-22  Adam Roben  <aroben@apple.com>
2565
2566         Windows build fix
2567
2568         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2569
2570 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2571
2572         - Removed a leak that was fixed.
2573
2574         * Scripts/run-webkit-tests:
2575
2576 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2577
2578         Reviewed by Darin.
2579
2580         - Changed the Client so that the DebuggerDocument now own the
2581         ServerConnection.  This simplifies ownership and cleanup. 
2582
2583         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2584         ServerConnection.
2585         (DebuggerClient::initWithServerName):
2586         (DebuggerClient::didFinishLoadForFrame):
2587         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2588         ServerConnection.
2589         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2590         until after we have a server which we are attached to.
2591         (Drosera::initUI):
2592         (Drosera::attach):
2593         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2594         out previously.
2595
2596 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2597
2598         Reviewed by Nikolas.
2599
2600         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2601
2602         * Scripts/run-javascriptcore-tests:
2603
2604 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2605
2606         Reviewed by Nikolas.
2607
2608         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2609
2610         * Scripts/build-drosera:
2611         * Scripts/build-dumprendertree:
2612         * Scripts/build-testkjs:
2613         * Scripts/build-webkit:
2614         * Scripts/run-javascriptcore-tests:
2615         * Scripts/run-sunspider:
2616         * Scripts/run-webkit-tests:
2617         * Scripts/webkitdirs.pm:
2618
2619 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2620
2621         Reviewed by Mark Rowe.
2622         
2623         Fix for local database support after r26879
2624         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2625
2626         * Scripts/build-webkit:
2627
2628 2007-10-22  Holger Freyther  <zecke@selfish.org>
2629
2630         Reviewed by Simon Hausmann <hausmann@kde.org>.
2631
2632         - Do not build testkjs as an application bundle. This is
2633         needed for run-javascriptcore-tests on OSX.
2634         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2635         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2636         as we do not have -rpath on OSX.
2637
2638         * DumpRenderTree/qt/DumpRenderTree.pro:
2639         * Scripts/run-webkit-tests:
2640
2641 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2642
2643         Reviewed by aroben.
2644
2645         Fix support for Signed-off-by detection in prepare-ChangeLog
2646         --git-commit. The Signed-off-by tag does not appear in the header
2647         but usually at the end.
2648
2649         * Scripts/prepare-ChangeLog:
2650
2651 2007-10-21  Mark Rowe  <mrowe@apple.com>
2652
2653         Reviewed by Eric.
2654
2655         Fix run-javascriptcore-tests for Gtk.
2656
2657         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2658
2659 2007-10-20  Eric Seidel  <eric@webkit.org>
2660
2661         Reviewed by aroben.
2662
2663         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2664
2665 2007-10-20  Eric Seidel  <eric@webkit.org>
2666
2667         Reviewed by darin.
2668         
2669         Add improved argument handling to run-sunspider, including
2670         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2671         Also re-factor code into subroutines
2672
2673         * Scripts/build-dumprendertree: removed bogus comments
2674         * Scripts/build-testkjs: Added.
2675         * Scripts/run-javascriptcore-tests: use build-testkjs
2676         * Scripts/run-sunspider: improved argument handling, abstraction
2677         * Scripts/run-webkit-tests: improved abstraction
2678
2679 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2680
2681         Not reviewed, Windows build fix.
2682
2683         * DumpRenderTree/win/EventSender.cpp:
2684         (keyDownCallback):
2685
2686 2007-10-20  Darin Adler  <darin@apple.com>
2687
2688         Reviewed by Tim Hatcher.
2689
2690         - http://bugs.webkit.org/show_bug.cgi?id=15544
2691           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2692           not rely on Apple-specific key codes
2693
2694         * DumpRenderTree/mac/EventSendingController.mm:
2695         (-[EventSendingController keyDown:withModifiers:]):
2696         Added named key "rightArrow". Later we could have a whole table of these.
2697         Also tweaked modifiers code a little.
2698
2699         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2700
2701 2007-10-19  Darin Adler  <darin@apple.com>
2702
2703         Reviewed by Eric.
2704
2705         - http://bugs.webkit.org/show_bug.cgi?id=15566
2706           possible fix for leak seen in DumpRenderTree
2707
2708         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2709         Delete the item if it's not put on the queue, since the caller has
2710         no way of knowing that. Would be better to have the parameter type
2711         be auto_ptr to express the fact that we take ownership.
2712
2713         - unrelated change
2714
2715         * Drosera/mac/main.m: Add missing include.
2716
2717 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2718
2719         Reviewed by Adam.
2720
2721         - This change should be identical but for some reason was not working
2722         on my machine.
2723
2724         * Scripts/prepare-ChangeLog:
2725
2726 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2727
2728         Reviewed by Oliver and Tim.
2729
2730         - Made use of RetainPtr to avoid retain and release issues and moved the
2731         log function to DebuggerDocumentPlatform, which seems to be a more
2732         logical place for it to live.
2733         - Also moved knownServers from the ServerConnection to
2734         DebuggerApplication to match the Windows code and because it makes sense
2735         that a connection knows its own server but not all of them.
2736
2737         * Drosera/mac/DebuggerClient.h: Moved the log function to
2738           DebuggerDocumentPlatform.
2739         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2740           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2741           call for the server name up from the ServerConnection class.
2742         (-[DebuggerClient dealloc]):
2743         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2744           for the server name up from the ServerConnection.
2745         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2746         (DebuggerDocument::platformPause):
2747         (DebuggerDocument::platformResume):
2748         (DebuggerDocument::platformStepInto):
2749         (DebuggerDocument::platformEvaluateScript):
2750         (DebuggerDocument::getPlatformCurrentFunctionStack):
2751         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2752         (DebuggerDocument::platformValueForScopeVariableNamed):
2753         (DebuggerDocument::platformLog): Log directly from here. No need to call
2754           DebuggerClient.
2755         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2756           way I see it, a ServerConnection should only know about its connection
2757           and the group of all possible servers should be kept by the
2758           application.
2759         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2760           currentServerName, it makes sense that the connection should know that
2761           name.
2762         (-[ServerConnection currentServerName]):
2763
2764 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2765
2766         Reviewed by Adam.
2767
2768         - Integrated changes from mac drosera.  Recently I've encapsulated
2769         out the server connection object from the rest of Drosera because
2770         it is very platform dependent right now and RPC is not implemented on
2771         windows.  This functionality, of communicating with the WebKit server
2772         is the next area I will be focusing on in Windows.
2773
2774         - Other changes and cleanup were made to organize the code and add notes
2775         on which parts still need work.  Also some mac code is added and
2776         commented out, to act as pseudocode for the logic of those parts.
2777
2778         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2779           pointer.
2780         * Drosera/config.h: Added whitespace.
2781         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2782           these files got moved into Drosera.h/cpp
2783         * Drosera/win/DebuggerApplication.h: Removed.
2784         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2785           happened here to better match the logic flow of the same code on the 
2786           mac side and to use the new ServerConnection class.
2787         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2788         (DebuggerClient::initWithServerName): Initializer that will set up the
2789           class to use a ServerConnection object.  This was necessary so I could
2790           create a DebuggerClient without having to initilaize it at
2791           construction.
2792         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2793           will be the UIDelegate and FrameLoadDelegate.
2794         (DebuggerClient::AddRef): For IUnknown.
2795         (DebuggerClient::Release): For IUnknown.
2796         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2797           this still needs to set the global context of the server, but
2798           IWebFrame does not have an accessor for the global context yet. 
2799         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2800           this is a pass through for the same function in the document.
2801         (DebuggerClient::didReceiveTitle): Unimplemented part of
2802           FrameLoadDelegate this would change the title of the window.
2803         (DebuggerClient::createWebViewWithRequest): Part of the
2804           FrameLoadDelegate.  This is about new windows via Window.open() and
2805           how their delegates are set.
2806         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2807           UIDelegate.  Just a debug function for printing messages.
2808         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2809           because the Client should be the UIDelegate and FrameLoadDelegate
2810           to match the delegates on mac.
2811         (DebuggerClient::webViewLoaded): Added accessor method.
2812         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2813           forgotten to add this file before.  This is where the platform
2814           dependent versions of the Documents functions live. Most of these are
2815           unimplemented because some piece of functionality does not exist on
2816           Windows yet.
2817         (DebuggerDocument::platformPause):
2818         (DebuggerDocument::platformResume):
2819         (DebuggerDocument::platformStepInto):
2820         (DebuggerDocument::platformEvaluateScript):
2821         (DebuggerDocument::getPlatformCurrentFunctionStack):
2822         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2823         (DebuggerDocument::platformValueForScopeVariableNamed):
2824         (DebuggerDocument::platformLog):
2825         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2826           responsibilities becaue they belong in the Client. Also I laid the
2827           groundwork for attaching Drosera to a WebKit process
2828         (attachWndProc): Now if a server is selected the Client becomes it's
2829           delegate.
2830         (Drosera::Drosera): Added the construction of the Client and dictionary
2831           of server names. 
2832         (Drosera::initUI): This is no longer the delegates, the Client is.
2833         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2834           state. 
2835         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2836           notification registration when it's possible to implement.
2837         (Drosera::serverLoaded): Ditto
2838         (Drosera::serverUnloaded): Ditto
2839         (Drosera::attach): Attach Drosera to the WebKit server.
2840         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2841         (Drosera::getInst): 
2842         (Drosera::setInst):
2843         (Drosera::knownServers):
2844         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2845           and added the ServerConnection.
2846         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2847         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2848           Most of the functions are completely unimlemented because they cannot
2849           connect with the WebKit server, because one does not exist on Windows
2850           yet.
2851         (ServerConnection::initWithServerName): 
2852         (ServerConnection::~ServerConnection):
2853         (ServerConnection::setGlobalContext):
2854         (ServerConnection::pause):
2855         (ServerConnection::resume):
2856         (ServerConnection::stepInto):
2857         (ServerConnection::switchToServerNamed):
2858         (ServerConnection::applicationTerminating):
2859         (ServerConnection::serverConnectionDidDie):
2860         (ServerConnection::currentFrame):
2861         * Drosera/win/ServerConnection.h: Added. Ditto.
2862         (ServerConnection::ServerConnection):
2863
2864 2007-10-19  Alice Liu  <alice.liu@apple.com>
2865
2866         Reviewed by Darin.
2867
2868         Fix for these broken layout tests on Windows:
2869         
2870         fast/forms/focus-selection-input.html
2871         fast/forms/focus-selection-textarea.html
2872         fast/forms/select-accesskey.html
2873         
2874         * DumpRenderTree/win/EventSender.cpp:
2875         (keyDownCallback):
2876         correct the VK code for alt key.
2877         
2878 2007-10-19  Eric Seidel  <eric@webkit.org>
2879
2880         Reviewed by Mark Rowe.
2881         
2882         Make the GtkLauncher code slightly more readable.
2883
2884         * GtkLauncher/main.cpp:
2885         (setupMainMenu): Added.
2886         (setupMainWindowUI): Added.
2887         (main):
2888
2889 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2890
2891         Rubber stamped by Adam.
2892         
2893         - don't delay-load WebKit in DumpRenderTree.
2894
2895         * DumpRenderTree/win/DumpRenderTree.vcproj:
2896
2897 2007-10-18  Dan Bernstein  <mitz@apple.com>
2898
2899         Reviewed by Adam Roben.
2900
2901         - fix <rdar://problem/5313523>
2902         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2903
2904         * DumpRenderTree/mac/DumpRenderTree.mm:
2905         (dump): Changed to use _responseMIMEType.
2906
2907 2007-10-17  Adam Roben  <aroben@apple.com>
2908
2909         Make it possible to have Windows-specific tests and results
2910
2911         When searching for tests to run and the Skipped file, we will only
2912         look in platform/win and the cross-platform directory. When looking
2913         for expected results, we will look in platform/win, then
2914         platform/mac-leopard, then platform/mac, then finally the
2915         cross-platform directory.
2916
2917         Reviewed by Sam.
2918
2919         * Scripts/run-webkit-tests:
2920         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2921         searching in the cross-platform directory.
2922         (sub buildPlatformHierarchy): Removed some unneeded calls to
2923         dirname/basename.
2924
2925 2007-10-17  Adam Roben  <aroben@apple.com>
2926
2927         Add back the call to register WebKit that we had before WebKitInitializer existed
2928
2929         This is needed to ensure that the right WebKit is used when
2930         instantiating COM objects.
2931
2932         Reviewed by Oliver.
2933
2934         * DumpRenderTree/win/debug_internal.vsprops: Define
2935         DEBUG_WEBKIT_HAS_SUFFIX.
2936         * DumpRenderTree/win/DumpRenderTree.cpp:
2937         (initialize):
2938
2939 2007-10-17  Adam Roben  <aroben@apple.com>
2940
2941         Import File::Basename in webkitdirs since we use it
2942
2943         * Scripts/webkitdirs.pm:
2944
2945 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2946
2947         - Updated the tiger leaks list to make the internal bots green.
2948
2949         * Scripts/run-webkit-tests:
2950
2951 2007-10-17  Adam Roben  <aroben@apple.com>
2952
2953         Build fix for VC++ Express
2954
2955         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2956         and ole32.lib.
2957
2958 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2959
2960         Reviewed by Sam.
2961
2962         - Minor mac improvements based on observations I made while implementing the
2963         Windows code.
2964
2965         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2966         then hand it to the Client who will retain it, it should just be the client who
2967         creates and owns the server.
2968         (-[DebuggerApplication attach:]):
2969         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2970         * Drosera/mac/DebuggerClient.mm: Creates the server.
2971         (-[DebuggerClient initWithServerName:]):
2972         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2973         can instead forward declare what it needs.
2974
2975 2007-10-16  Darin Adler  <darin@apple.com>
2976
2977         Reviewed by Geoff Garen.
2978
2979         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2980         want to turn failing tests into platform-specific test results. Also did a
2981         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2982         would take the type of results into account only some of the time.
2983
2984 2007-10-16  Adam Roben  <aroben@apple.com>
2985
2986         Add a new nightly launcher script for Windows
2987
2988         This new script is for versions of Safari that don't delay-load
2989         WebKit. I had to make FindSafari be able to print out the nightly
2990         launcher script on stdout because Windows shell scripts can't capture
2991         the output from a command into an environment variable.
2992
2993         Reviewed by Steve.
2994
2995         * FindSafari/FindSafari.cpp:
2996         (_tmain): Added /printSafariLauncher option.
2997         * Scripts/run-webkit-nightly.cmd: Added.
2998
2999 2007-10-16  Adam Roben  <aroben@apple.com>
3000
3001         Replace WebKitInitializer with FindSafari
3002
3003         We now rely on setting the PATH environment variable to tell Windows
3004         where to find WebKit and its dependencies (similar to
3005         DYLD_FRAMEWORK_PATH on Mac).
3006
3007         This change also make DumpRenderTree no longer delay-load WebKit.
3008
3009         Reviewed by Sam.
3010
3011         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3012         FindSafari.
3013         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3014         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3015         WebKitInitializer, don't delay-load WebKit.
3016         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3017         * Scripts/run-webkit-tests: Ditto.
3018         * Scripts/webkitdirs.pm:
3019         (sub setPathForRunningWebKitApp): Added.
3020         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3021         * WebKitInitializer/WebKitInitializer.h: Removed.
3022         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3023         * WebKitInitializer/debug.vsprops: Removed.
3024         * WebKitInitializer/debug_internal.vsprops: Removed.
3025         * WebKitInitializer/release.vsprops: Removed.
3026
3027 2007-10-16  Adam Roben  <aroben@apple.com>
3028
3029         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3030
3031         http://bugs.webkit.org/show_bug.cgi?id=15532
3032
3033         FindSafari simply prints the location of an installed Safari.exe on
3034         stdout.
3035
3036         Reviewed by Darin.
3037
3038         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3039         (getStringValue):
3040         (getWebViewCLSID):
3041         (getInstalledWebKitDirectory):
3042         (_tmain):
3043         * FindSafari/FindSafari.vcproj: Added.
3044         * Scripts/webkitdirs.pm:
3045         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3046
3047 2007-10-16  Adam Roben  <aroben@apple.com>
3048
3049         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3050
3051         Reviewed by Kevin McCullough.
3052
3053         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3054         when referring to WebKit.dll.
3055         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3056         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3057         * DumpRenderTree/win/release.vsprops: Ditto.
3058         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3059         never have a _debug suffix on WebKit.dll.
3060         * WebKitInitializer/WebKitInitializer.cpp:
3061         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3062         specified.
3063         * WebKitInitializer/debug_internal.vsprops: Added
3064         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3065
3066 2007-10-16  Darin Adler  <darin@apple.com>
3067
3068         Reviewed by Adele.
3069
3070         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3071         Remove now-unneeded control/alt key hack; the tests have been updated.
3072
3073 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3074
3075         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3076         one of the leaks was fixed between that revision and the bot's previous version of
3077         leopard.
3078
3079         * Scripts/run-webkit-tests:
3080
3081 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3082
3083         Reviewed by Tim.
3084
3085         - I encapsulated out the server connecton functionality because it is a specific part
3086         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3087         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3088         Windows.  So the majority of this patch is moving preexisting functionality.
3089
3090         - Also I removed the prefix header and changed to use config.h because it is more
3091         standard on how we use config.h in windows and it didn't make much sense to keep
3092         the prefix header and the config.h
3093
3094         * Drosera/DebuggerDocument.cpp:
3095         (DebuggerDocument::DebuggerDocument):
3096         * Drosera/DebuggerDocument.h:
3097         * Drosera/config.h:
3098         * Drosera/mac/DebuggerApplication.mm:
3099         (-[DebuggerApplication attach:]):
3100         * Drosera/mac/DebuggerClient.h:
3101         * Drosera/mac/DebuggerClient.mm:
3102         (-[DebuggerClient initWithServerConnection:]):
3103         (-[DebuggerClient dealloc]):
3104         (-[DebuggerClient windowDidLoad]):
3105         (-[DebuggerClient windowWillClose:]):
3106         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3107         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3108         * Drosera/mac/DebuggerDocumentPlatform.mm:
3109         (DebuggerDocument::platformPause):
3110         (DebuggerDocument::platformResume):
3111         (DebuggerDocument::platformStepInto):
3112         (DebuggerDocument::platformEvaluateScript):
3113         (DebuggerDocument::getPlatformCurrentFunctionStack):
3114         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3115         (DebuggerDocument::platformValueForScopeVariableNamed):
3116         (DebuggerDocument::platformLog):
3117         * Drosera/mac/Drosera.pch: Removed.
3118         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3119         * Drosera/mac/ServerConnection.h: Added.
3120         * Drosera/mac/ServerConnection.mm: Added.
3121         (-[ServerConnection initWithServerName:]):
3122         (-[ServerConnection dealloc]):
3123         (-[ServerConnection setGlobalContext:]):
3124         (-[ServerConnection pause]):
3125         (-[ServerConnection resume]):
3126         (-[ServerConnection stepInto]):
3127         (-[ServerConnection switchToServerNamed:]):
3128         (-[ServerConnection applicationTerminating:]):
3129         (-[ServerConnection serverConnectionDidDie:]):
3130         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3131         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3132         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3133         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3134         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3135         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3136         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3137         (-[ServerConnection currentFrame]):
3138         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3139         (-[ServerConnection knownServers]):
3140
3141 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3142
3143         Reviewed by Eric.
3144
3145         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3146           Script to automatically search nightly builds for regressions (bisect-builds)
3147
3148         * Scripts/bisect-builds: Added.
3149
3150 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3151
3152         Reviewed by Darin.
3153
3154         - New JavaScript benchmark
3155         http://bugs.webkit.org/show_bug.cgi?id=15515
3156
3157         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3158         current development or release build of JavaScriptCore.
3159
3160 2007-10-15  Mark Rowe  <mrowe@apple.com>
3161
3162         Reviewed by Sam.
3163
3164         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3165
3166         * Scripts/webkitdirs.pm:
3167         - Change checkArgv to remove the options from @ARGV to prevent
3168         them from interfering with further option processing.
3169         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3170         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3171         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3172         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3173
3174 2007-10-15  Darin Adler  <darin@apple.com>
3175
3176         Reviewed by Sam.
3177
3178         - added logging of window.prompt and window.confirm
3179
3180         * DumpRenderTree/mac/UIDelegate.mm:
3181         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3182         Implement the recommended delegate rather than the deprecated one.
3183         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3184         Added.
3185         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3186         Added.
3187
3188         * DumpRenderTree/win/UIDelegate.h:
3189         * DumpRenderTree/win/UIDelegate.cpp:
3190         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3191         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3192         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3193         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3194
3195 2007-10-15  Alice Liu  <alice.liu@apple.com>
3196
3197         Reviewed by Sam Weinig.
3198
3199         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3200
3201         * DumpRenderTree/win/DumpRenderTree.cpp:
3202         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3203         (main): allocate the global policy delegate for DRT's custom use
3204         * DumpRenderTree/win/DumpRenderTree.vcproj:
3205         Adding files to project
3206         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3207         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3208         (LayoutTestController::setCustomPolicyDelegate):
3209         set the webview's policy delegate to DRT's custom one if the test requests it.
3210         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3211         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3212         (PolicyDelegate::PolicyDelegate):
3213         (PolicyDelegate::QueryInterface):
3214         (PolicyDelegate::AddRef):
3215         (PolicyDelegate::Release):
3216         (PolicyDelegate::decidePolicyForNavigationAction):
3217         * DumpRenderTree/win/PolicyDelegate.h: Added.
3218         (PolicyDelegate::decidePolicyForNewWindowAction):
3219         (PolicyDelegate::decidePolicyForMIMEType):
3220         (PolicyDelegate::unableToImplementPolicyWithError):
3221
3222 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3223
3224         Reviewed by Mark.
3225
3226         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3227         when querying for QMAKE_MKSPECS.
3228
3229 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3230
3231         Reviewed by Adam Roben.
3232         
3233         Fix run-webkit-tests is too greedy calculating platform hierarchy
3234         http://bugs.webkit.org/show_bug.cgi?id=15465
3235         
3236         Fix run-webkit-tests being too greedy in trying to split the platform name up
3237         causing it to try and find tests in every directory above the first "-" in the
3238         path to the LayoutTests
3239
3240         * Scripts/run-webkit-tests:
3241
3242 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3243
3244         Reviewed by Darin.
3245
3246         http://bugs.webkit.org/show_bug.cgi?id=15006
3247         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3248         to reduce code duplication.
3249
3250         * Scripts/build-webkit:
3251         * Scripts/webkitdirs.pm:
3252         buildQMakeProject() renamed to buildQMakeQtProject().
3253         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3254         unused $colorize has been removed.
3255
3256 === Start merge of feature-branch 2007-10-12 ===
3257
3258 2007-10-08  Eric Seidel  <eric@webkit.org>
3259
3260         Reviewed by Mark Rowe.
3261
3262         * Scripts/build-webkit: add --help, remove unused --color
3263
3264 2007-10-07  Eric Seidel  <eric@webkit.org>
3265
3266         Reviewed by darin.
3267
3268         * Drosera/mac/DebuggerDocumentPlatform.mm:
3269         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3270
3271 2007-10-03  Rob Buis  <buis@kde.org>
3272
3273         Reviewed by Olliej.
3274
3275         Adapt to changed location of Ahem font.
3276
3277         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3278
3279 2007-10-02  Eric Seidel  <eric@webkit.org>
3280
3281         Reviewed by Adam Roben.
3282         
3283         Make pixel tests more useful!
3284         Finally fix the image diff 0.00% mystery problem
3285         Highlight any image differences in the image diff.
3286         Add a link from image diffs back to original test file.
3287
3288         * DumpRenderTree/mac/ImageDiff.m:
3289         (compareImages): highlight any differences
3290         (computePercentageDifferent): round to two decimal places
3291         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3292
3293 2007-10-02  Eric Seidel  <eric@webkit.org>
3294
3295         Reviewed by Alexey Proskuryakov.
3296
3297         * Scripts/run-webkit-tests: print the % image difference on main results page
3298
3299 2007-10-02  Mark Rowe  <mrowe@apple.com>
3300
3301         Reviewed by Oliver.
3302
3303         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3304
3305         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3306         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3307
3308 2007-10-01  Mark Rowe  <mrowe@apple.com>
3309
3310         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3311
3312 2007-09-25  Eric Seidel  <eric@webkit.org>
3313
3314         Reviewed by Mark Rowe.
3315         
3316         DerivedSources.make was finding "ENABLE_SVG" in the string
3317         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3318         quite correctly.
3319
3320         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3321
3322 2007-09-25  Mark Rowe  <mrowe@apple.com>
3323
3324         Rubber-stamped by Eric.
3325
3326         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3327         This makes it possible to automate nightly builds for the feature-branch.
3328
3329 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3330
3331         Rubber stamped by Mark.
3332
3333         Enable svg experimental features as default here in feature-branch.
3334
3335         * Scripts/build-webkit:
3336
3337 2007-06-29  Antti Koivisto  <antti@apple.com>
3338
3339         Reviewed by Weinig.
3340         
3341         Add VIDEO flag for timed media features
3342
3343         * Scripts/build-webkit
3344         
3345 === End merge of feature-branch 2007-10-12 ===
3346
3347 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3348
3349         Reviewed by Darin.
3350
3351         - Updated rational for the leaks list to be more clear.
3352
3353         * Scripts/run-webkit-tests:
3354
3355 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3356
3357         Rubber Stamp by Sam.
3358
3359         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3360         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3361
3362         * Scripts/run-webkit-tests:
3363
3364 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3365
3366         Reviewed by Lars.
3367
3368         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3369         includes are needed for INT_MAX, std::auto_ptr and the like.
3370
3371         * DumpRenderTree/qt/main.cpp:
3372
3373 2007-10-09  Lars Knoll  <lars@trolltech.com>
3374
3375         Reviewed by Simon.
3376
3377         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3378
3379         * DumpRenderTree/qt/jsobjects.cpp:
3380         (LayoutTestController::encodeHostName):
3381         (LayoutTestController::decodeHostName):
3382         * DumpRenderTree/qt/jsobjects.h:
3383
3384 2007-10-09  Lars Knoll  <lars@trolltech.com>
3385
3386         Reviewed by Simon.
3387
3388         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3389
3390         * DumpRenderTree/qt/DumpRenderTree.cpp:
3391         (WebCore::WebPage::createFrame):
3392         (WebCore::DumpRenderTree::DumpRenderTree):
3393         (WebCore::DumpRenderTree::titleChanged):
3394         * DumpRenderTree/qt/DumpRenderTree.h:
3395         * DumpRenderTree/qt/jsobjects.cpp:
3396         (LayoutTestController::reset):
3397         * DumpRenderTree/qt/jsobjects.h:
3398
3399 2007-10-09  Lars Knoll  <lars@trolltech.com>
3400
3401         Reviewed by Simon.
3402
3403         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3404
3405         * DumpRenderTree/qt/DumpRenderTree.h:
3406         * DumpRenderTree/qt/jsobjects.cpp:
3407         (LayoutTestController::clearBackForwardList):
3408         * DumpRenderTree/qt/jsobjects.h:
3409
3410 2007-10-09  Lars Knoll  <lars@trolltech.com>
3411
3412         Reviewed by Simon.
3413
3414         make --git-reviewer work again.
3415
3416         * Scripts/prepare-ChangeLog:
3417
3418 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3419
3420         Rubber stamped by Eric.
3421
3422         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3423         show the current link inside the statusbar.
3424         This shows how to make use of this signal and allows to easily test
3425         http://bugs.webkit.org/show_bug.cgi?id=15299.
3426
3427         * GtkLauncher/main.cpp:
3428         (hoveringOverLink):
3429         (main):
3430
3431 2007-10-05  Lars Knoll  <lars@trolltech.com>
3432
3433         add proper error messages to the FrameLoaderClient.
3434         Implement ChromeClientQt::closeWindowSoon and
3435         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3436         Some fixes in DRT to make it work correctly with multiple windows.
3437
3438         Reviewed by Maciej.
3439
3440         * DumpRenderTree/qt/DumpRenderTree.cpp:
3441         (WebCore::DumpRenderTree::DumpRenderTree):
3442         (WebCore::DumpRenderTree::createWindow):
3443         (WebCore::DumpRenderTree::windowCount):
3444         * DumpRenderTree/qt/DumpRenderTree.h:
3445         * DumpRenderTree/qt/jsobjects.cpp:
3446         (LayoutTestController::maybeDump):
3447         (LayoutTestController::windowCount):
3448         * DumpRenderTree/qt/jsobjects.h:
3449
3450 2007-10-05  Lars Knoll  <lars@trolltech.com>
3451
3452         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3453         Add support for layoutTextController.setCanOpenWindows() to DRT
3454         fixing another 2 test cases in fast/dom/Window.
3455
3456         Reviewed by Maciej.
3457
3458         * DumpRenderTree/qt/DumpRenderTree.cpp:
3459         (WebCore::WebPage::WebPage):
3460         (WebCore::WebPage::createWindow):
3461         (WebCore::DumpRenderTree::resetJSObjects):
3462         (WebCore::DumpRenderTree::createWindow):
3463         * DumpRenderTree/qt/DumpRenderTree.h:
3464         * DumpRenderTree/qt/DumpRenderTree.pro:
3465         * DumpRenderTree/qt/jsobjects.cpp:
3466         (LayoutTestController::LayoutTestController):
3467         (LayoutTestController::reset):
3468         * DumpRenderTree/qt/jsobjects.h:
3469         * DumpRenderTree/qt/main.cpp:
3470         * DumpRenderTree/qt/testplugin.cpp: Added.
3471         * DumpRenderTree/qt/testplugin.h: Added.
3472
3473 2007-10-04  Sam Weinig  <sam@webkit.org>
3474
3475         Rubber stamped by Adam.
3476
3477         Remove empty directories.
3478
3479         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3480         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3481
3482 2007-10-03  Darin Adler  <darin@apple.com>
3483
3484         Reviewed by Adam.
3485
3486         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3487         we find the internal libraries in the libraries directory. This
3488         is helpful for Safari team engineers at Apple.
3489
3490 2007-10-03  Adam Roben  <aroben@apple.com>
3491
3492         Update the location of AHEM___.TTF after r25968
3493
3494         Reviewed by Sam.
3495
3496         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3497
3498 2007-10-03  Alp Toker  <alp@atoker.com>
3499
3500         Reviewed by Adam.
3501
3502         http://bugs.webkit.org/show_bug.cgi?id=14726
3503         [gtk] API design. Mapping the WebView delegates to signals.
3504
3505         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3506
3507         * GtkLauncher/main.cpp:
3508         (goToURLBarText):
3509         (titleChanged):
3510         (progressChanged):
3511         (menuMainBackCallback):
3512         (menuMainForwardCallback):
3513         (main):
3514
3515 2007-10-03  Lars Knoll  <lars@trolltech.com>
3516
3517         Reviewed by Rob.
3518
3519         This fixes --strict mode in run-webkit-tests again after
3520         the platform dependent test results have been moved.
3521
3522         * Scripts/run-webkit-tests:
3523
3524 2007-10-03  Lars Knoll  <lars@trolltech.com>
3525
3526         Reviewed by bdash.
3527
3528         remove the hack in run-webkit-tests that forced text only test
3529         to be taken from the platform independent dir. It was only left
3530         there from early days.
3531         
3532         Remove platform dependent results for tests that are text only nowadays,
3533         and add one platform dependent result for a text only test that requires it.
3534
3535         * Scripts/run-webkit-tests:
3536
3537 2007-10-03  Lars Knoll  <lars@trolltech.com>
3538
3539         Reviewed by olliej.
3540
3541         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3542
3543         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3544         (WebCore::WebFrame::WebFrame):
3545         (WebCore::WebPage::WebPage):
3546         (WebCore::WebPage::createFrame):
3547         (WebCore::WebPage::javaScriptAlert):
3548         (WebCore::WebPage::javaScriptConsoleMessage):
3549         (WebCore::DumpRenderTree::DumpRenderTree):
3550         (WebCore::DumpRenderTree::~DumpRenderTree):
3551         (WebCore::DumpRenderTree::open):
3552         (WebCore::DumpRenderTree::readStdin):
3553         (WebCore::DumpRenderTree::resetJSObjects):
3554         (WebCore::DumpRenderTree::initJSObjects):
3555         (WebCore::DumpRenderTree::dumpFramesAsText):
3556         (WebCore::DumpRenderTree::dump):
3557         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3558         (WebCore::DumpRenderTree::layoutTestController):
3559         (WebCore::DumpRenderTree::eventSender):
3560         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3561         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3562         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3563         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3564         (HackWebFrame::mousePressEvent):
3565         (HackWebFrame::mouseReleaseEvent):
3566         (HackWebFrame::mouseMoveEvent):
3567         (HackWebFrame::HackWebFrame):
3568         (HackWebFrame::~HackWebFrame):
3569         (LayoutTestController::LayoutTestController):
3570         (LayoutTestController::reset):
3571         (LayoutTestController::maybeDump):
3572         (LayoutTestController::waitUntilDone):
3573         (LayoutTestController::notifyDone):
3574         (LayoutTestController::dumpEditingCallbacks):
3575         (LayoutTestController::queueReload):
3576         (LayoutTestController::provisionalLoad):
3577         (LayoutTestController::timerEvent):
3578         (EventSender::EventSender):
3579         (EventSender::mouseDown):
3580         (EventSender::mouseUp):
3581         (EventSender::mouseMoveTo):
3582         (EventSender::leapForward):
3583         (EventSender::keyDown):
3584         (EventSender::frameUnderMouse):
3585         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3586         (LayoutTestController::isLoading):
3587         (LayoutTestController::setLoading):
3588         (LayoutTestController::shouldDumpAsText):
3589         (LayoutTestController::shouldDumpChildrenAsText):
3590         (LayoutTestController::shouldWaitUntilDone):
3591         (LayoutTestController::dumpAsText):
3592         (LayoutTestController::dumpChildFramesAsText):
3593         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3594         (messageHandler):
3595         (crashHandler):
3596         (main):
3597         * Scripts/run-webkit-tests:
3598
3599 2007-10-03  Mark Rowe  <mrowe@apple.com>
3600
3601         Reviewed by Alp Toker.
3602
3603         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3604         should take precedence over QTDIR when determining which port we are working with.
3605
3606         * Scripts/webkitdirs.pm: 
3607
3608 2007-10-02  Adam Roben  <aroben@apple.com>
3609
3610         Add keychain to the list of default packages to install
3611