WebKit/win/ChangeLog

   1 2008-05-06  Brady Eidson  <beidson@apple.com>
   2
   3         Reviewed by Darin Adler
   4
   5         Preparation for upcoming work making LocalStorage persistent.
   6
   7         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
   8
   9         * WebKitDLL.cpp:
  10         (shutDownWebKit): Close all LocalStorage areas before quitting.
  11
  12 2008-05-05  Anders Carlsson  <andersca@apple.com>
  13
  14         Reviewed by John.
  15
  16         Add preference for enabling the offline web application cache.
  17
  18         * Interfaces/IWebPreferencesPrivate.idl:
  19         * WebPreferenceKeysPrivate.h:
  20         * WebPreferences.cpp:
  21         (WebPreferences::initializeDefaultSettings):
  22         (WebPreferences::setOfflineWebApplicationCacheEnabled):
  23         (WebPreferences::offlineWebApplicationCacheEnabled):
  24         * WebPreferences.h:
  25         * WebView.cpp:
  26         (WebView::notifyPreferencesChanged):
  27
  28 2008-05-05  Sam Weinig  <sam@webkit.org>
  29
  30         Reviewed by Tim Hatcher.
  31
  32         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
  33
  34         * WebCoreSupport/WebInspectorClient.cpp:
  35         (WebInspectorClient::localizedStringsURL):
  36
  37 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
  38
  39         Add WebPreference for application chrome mode.
  40
  41         Reviewed by Dave Hyatt.
  42
  43         * Interfaces/IWebPreferencesPrivate.idl:
  44         * WebPreferenceKeysPrivate.h:
  45         * WebPreferences.cpp:
  46         (WebPreferences::initializeDefaultSettings):
  47         (WebPreferences::inApplicationChromeMode):
  48         (WebPreferences::setApplicationChromeMode):
  49         * WebPreferences.h:
  50         * WebView.cpp:
  51         (WebView::notifyPreferencesChanged):
  52
  53 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
  54
  55         Reviewed by Geoffrey Garen.
  56
  57         https://bugs.webkit.org/show_bug.cgi?id=18826
  58         Make JavaScript heap per-thread
  59
  60         * WebCoreStatistics.cpp:
  61         (WebCoreStatistics::javaScriptObjectsCount):
  62         (WebCoreStatistics::javaScriptGlobalObjectsCount):
  63         (WebCoreStatistics::javaScriptProtectedObjectsCount):
  64         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
  65         * WebJavaScriptCollector.cpp:
  66         (WebJavaScriptCollector::objectCount):
  67         * WebScriptCallFrame.cpp:
  68         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
  69         Replaced static Collector calls with calls to a current thread's instance. Pass ExecState to jsString().
  70
  71 2008-04-29  Ada Chan  <adachan@apple.com>
  72
  73         Support text shadow in WebDrawText().
  74         Remove DrawTextAtPoint() since it is only called by WebDrawText().
  75
  76         Reviewed by Adam.
  77
  78         * WebKit.vcproj/WebKit.def:
  79         * WebKit.vcproj/WebKit_debug.def:
  80         * WebKitGraphics.cpp:
  81         (WebDrawText):
  82         * WebKitGraphics.h:
  83
  84 2008-04-29  Adam Roben  <aroben@apple.com>
  85
  86         Restore the beloved COMPtr::operator&
  87
  88 2008-04-29  Adam Roben  <aroben@apple.com>
  89
  90         Windows build fix
  91
  92         Replaced uses of COMPtr::operator& with COMPtr::adoptionPointer.
  93
  94 2008-04-29  Adam Roben  <aroben@apple.com>
  95
  96         Fix a Windows build error
  97
  98         * WebScriptCallFrame.cpp:
  99         (WebScriptCallFrame::variableNames): Don't use ::adopt now that
 100         PropertyNameArray has no swap function.
 101
 102 2008-04-28  Adam Roben  <aroben@apple.com>
 103
 104         Fix some Windows build errors in WebKit
 105
 106         * Interfaces/WebKit.idl: Touched to force Interfaces to rebuild.
 107         * WebKitPrefix.cpp: Touched to force WebKit to rebuild.
 108
 109 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
 110
 111         Reviewed by Darin.
 112
 113         Fix run-webkit-tests --threading
 114         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
 115         Proxy server issue in Sunday's Nightly
 116
 117         * WebView.cpp: (WebView::WebView): Initialize threading. Previously, this was only done from
 118         icon database code, which is not robust enough.
 119
 120 2008-04-26  Adam Barth <hk9565@gmail.com>
 121
 122         Reviewed by Adam Roben and Sam Weinig.
 123
 124         Renamed "domain" method to "host" to match SecurityOrigin.
 125
 126         * Interfaces/IWebSecurityOrigin.idl:
 127         * WebSecurityOrigin.cpp:
 128         (WebSecurityOrigin::host):
 129         * WebSecurityOrigin.h:
 130
 131 2008-04-25  Anders Carlsson  <andersca@apple.com>
 132
 133         Reviewed by Adam.
 134
 135         Fix internal debug build.
 136
 137         * WebKit.vcproj/WebKit.vcproj:
 138
 139 2008-04-24  Dan Bernstein  <mitz@apple.com>
 140
 141         - build fix
 142
 143         * WebView.cpp:
 144         (WebView::handleContextMenuEvent):
 145
 146 2008-04-24  Brady Eidson  <beidson@apple.com>
 147
 148         Reviewed by Darin
 149
 150         Revert my previous change to WebKit/Win until I can make it act more like the new Mac code
 151
 152         * WebView.cpp:
 153         (WebView::initWithFrame):
 154
 155 2008-04-24  Anders Carlsson  <andersca@apple.com>
 156
 157         Reviewed by Sam.
 158
 159         Change some String arguments to be const references instead.
 160
 161         * WebCoreSupport/WebEditorClient.cpp:
 162         (WebEditorClient::shouldInsertText):
 163         * WebCoreSupport/WebEditorClient.h:
 164
 165 2008-04-23  Brady Eidson  <beidson@apple.com>
 166
 167         Reviewed by Sam Weinig
 168
 169         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
 170         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
 171         thereby populating the Settings object, immediately after the Page is created.
 172
 173         * WebView.cpp:
 174         (WebView::initWithFrame): Post the notification right after the Page is created
 175
 176 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
 177
 178         Reviewed by Brady.
 179
 180         Implement accDoDefaultAction().
 181
 182         * AccessibleBase.cpp:
 183         (AccessibleBase::accDoDefaultAction): Call the object's
 184         performDefaultAction() method. Return S_FALSE if the call returns false,
 185         indicating that the object has no default action associated with it.
 186
 187 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
 188
 189         Reviewed by Adam.
 190
 191         Implement accHitTest().
 192
 193         * AccessibleBase.cpp:
 194         (AccessibleBase::accHitTest): Perform a hit test for a child object. If
 195         none is found, report whether the point was within our own bounding box.
 196
 197 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
 198
 199         Reviewed by Adam and Darin.
 200
 201         Implement accNavigate().
 202
 203         * AccessibleBase.cpp:
 204         (AccessibleBase::accNavigate): This method navigates between elements,
 205         given a start point and a direction. The directions UP, DOWN, LEFT,
 206         RIGHT are not are not implemented, matching Mozilla and IE. The
 207         directions FIRSTCHILD and LASTCHILD are only allowed from self. NEXT and
 208         PREVIOUS are allowed from self or any of our children.
 209
 210 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
 211
 212         Reviewed by Adam.
 213
 214         Implement accLocation().
 215
 216         * AccessibleBase.cpp:
 217         (AccessibleBase::accLocation): Report the screen coordinates for the
 218         object's bounding box.
 219
 220 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
 221
 222         Reviewed by Adam, Darin, Oliver.
 223
 224         Implement get_accDefaultAction().
 225
 226         * AccessibleBase.cpp:
 227         (AccessibleBase::get_accDefaultAction): Report the result of calling the
 228         object's actionVerb method.
 229         * English.lproj/Localizable.strings: Updated with new strings.
 230         * WebCoreLocalizedStrings.cpp:
 231         (WebCore::AXButtonActionVerb): Return a localized string representing
 232         the object's default action.
 233         (WebCore::AXRadioButtonActionVerb): Same.
 234         (WebCore::AXTextFieldActionVerb): Same.
 235         (WebCore::AXCheckedCheckBoxActionVerb): Same
 236         (WebCore::AXUncheckedCheckBoxActionVerb): Same.
 237         (WebCore::AXLinkActionVerb): Same.
 238
 239 2008-04-23  Daniel Zucker  <zucker@wake3.com>
 240
 241         Reviewed by Adam Roben.
 242
 243         <https://bugs.webkit.org/show_bug.cgi?id=18468>
 244
 245         * WebError.h:  include RetainPtr.h to fix build errors in Cairo build
 246
 247 2008-04-23  Daniel Zucker  <zucker@wake3.com>
 248
 249         Reviewed by Adam Roben.
 250
 251         Move the location of #if USE(CFNETWORK) to fix a cairo/curl build error.
 252         <https://bugs.webkit.org/show_bug.cgi?id=18470>
 253
 254         * WebError.cpp:
 255         (WebError::sslPeerCertificate):
 256
 257 2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>
 258
 259         Reviewed by Adam.
 260
 261         Implement get_accFocus().
 262
 263         * AccessibleBase.cpp:
 264         (AccessibleBase::get_accRole): Remove redundant initialization;
 265         VariantInit does this.
 266         (AccessibleBase::get_accState): Same.
 267         (AccessibleBase::get_accSelection): Relocated next to accSelect().
 268         (AccessibleBase::get_accFocus): If the focused object is this object or
 269         a child of this object, report it. Otherwise, report VT_EMPTY.
 270
 271 2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>
 272
 273         Reviewed by Sam.
 274
 275         Implement get_accKeyboardShortcut().
 276
 277         * AccessibleBase.cpp:
 278         (AccessibleBase::get_accKeyboardShortcut): Report the key combination
 279         that will perform the object's access key action, represented as a
 280         string.
 281
 282 2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>
 283
 284         Reviewed by Darin.
 285
 286         Implement get_accHelp().
 287
 288         * AccessibleBase.cpp:
 289         (AccessibleBase::get_accHelp): Report the result of calling the object's
 290         helpText() method.
 291
 292 2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>
 293
 294         Reviewed by Darin.
 295
 296         Implement get_accState().
 297
 298         * AccessibleBase.cpp:
 299         (AccessibleBase::get_accState):
 300
 301 2008-04-21  Alexey Proskuryakov  <ap@webkit.org>
 302
 303         Reviewed by Darin.
 304
 305         Move collector main thread initialization from WebKit/win to KJS::initializeThreading.
 306
 307         * WebView.cpp:
 308         (WebView::WebView):
 309
 310 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 311
 312         Reviewed by Darin.
 313
 314         Implement get_accRole().
 315
 316         * AccessibleBase.cpp:
 317         (AccessibleBase::get_accRole): Report the result of role().
 318         (MSAARole): Added; returns the MSAA role for a WebCore role.
 319         (AccessibleBase::role): Return the MSAA role for the object's roleValue.
 320         * AccessibleBase.h: Add declaration for role().
 321
 322 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 323
 324         Reviewed by Darin.
 325
 326         Implement get_accName(), get_accValue(), get_accDescription(). Added
 327         virtual methods that accessible objects can override to customize the
 328         result.
 329
 330         * AccessibleBase.cpp:
 331         (AccessibleBase::get_accName): Report result of name().
 332         (AccessibleBase::get_accValue): Report result of value().
 333         (AccessibleBase::get_accDescription): Report result of description().
 334         (AccessibleBase::name): Added; returns AccessibilityObject::title().
 335         (AccessibleBase::value): Added; returns
 336         AccessibilityObject::stringValue().
 337         (AccessibleBase::description): Added; returns
 338         AccessibilityObject::accessibilityDescription().
 339         * AccessibleBase.h: Added declarations for name(), value(), and
 340         description().
 341         * ChangeLog: Fix my misuse of "definition."
 342
 343 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 344
 345         Fix build after r32231.
 346
 347         * WebFrame.cpp:
 348         (WebFrame::renderTreeAsExternalRepresentation): renderer() ->
 349         contentRenderer()
 350
 351 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 352
 353         Fix build after r32231.
 354
 355         * WebView.cpp:
 356         (WebView::paintIntoBackingStore): renderer() -> contentRenderer()
 357         (WebView::elementAtPoint): Same.
 358
 359 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 360
 361         * AccessibleBase.cpp: Build fix for copy/paste error.
 362
 363 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 364
 365         Reviewed by Darin.
 366
 367         Implement IAccessible::get_accChild().
 368
 369         * AccessibleBase.cpp:
 370         (AccessibleBase::get_accChild): Call getAccessibilityObjectForChild
 371         to find the AccessibilityObject for the VARIANT vChild. Get the
 372         AccessibilityObjectWrapper for the child, add a ref, and pass it back.
 373         (AccessibleBase::getAccessibilityObjectForChild): Added; finds the
 374         AccessibilityObject referred to by a VARIANT, or returns a COM error on
 375         failure.
 376         (AccessibleBase::wrapper): Added; returns the wrapper for the
 377         AccessibilityObject. Creates one if necessary.
 378         * AccessibleBase.h: Added declarations for wrapper() and
 379         getAccessibilityObjectForChild().
 380
 381 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
 382
 383         Reviewed by Darin, Ollie.
 384
 385         * AccessibleBase.cpp:
 386         (AccessibleBase::get_accChildCount): Implement get_accChildCount.
 387
 388 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 389
 390         Reviewed by Darin.
 391
 392         Implement IAccessible::get_accParent().
 393
 394         * AccessibleBase.cpp:
 395         (AccessibleBase::get_accParent): Call AccessibleObjectFromWindow with
 396         OBJID_WINDOW. This will be handled by Windows to return the default
 397         accessible object for the WebView, because we only handle OBJID_CLIENT.
 398         * WebView.cpp:
 399         (WebView::AccessibleObjectFromWindow): Added; calls through to the
 400         AccessibleObjectFromWindow in the MSAA DLL.
 401         * WebView.h: Added declaration for AccessibleObjectFromWindow.
 402
 403 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 404
 405         Reviewed by Darin.
 406
 407         Return an AccessibleDocument when our root accessible object is queried
 408         for.
 409
 410         * AccessibleDocument.cpp: Added; represents an AccessibilityObject that
 411         itself represents a Document.
 412         (AccessibleDocument::AccessibleDocument): Initialize AccessibleBase with
 413         the AccessibilityObject for this Document.
 414         * AccessibleDocument.h: Added.
 415         * WebFrame.cpp:
 416         (WebFrame::accessible): If m_accessible is 0, or if Document in this
 417         frame does not match the Document in the cached m_accessible object,
 418         create a new AccessibleDocument for this frame's Document.
 419         * WebFrame.h: Swap AccessibleBase.h for AccessibleDocument.h
 420         * WebKit.vcproj/WebKit.vcproj: Add AccessibleDocument.{h,cpp}
 421
 422 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 423
 424         Reviewed by Darin.
 425
 426         Respond to WM_GETOBJECT messages. Currently returns NULL.
 427
 428         * WebFrame.cpp:
 429         (WebFrame::accessible): Added; will return the root accessible object
 430         for this frame.
 431         * WebFrame.h: Added declaration for accessible().
 432         * WebView.cpp:
 433         (WebViewWndProc): Handle WM_GETOBJECT messages by calling onGetObject().
 434         (WebView::onGetObject): Added; enables the AXObjectCache in WebCore,
 435         queries the top-level frame for its root accessible object, and loads
 436         the MSAA DLL and locates its LresultFromObject function. If calling
 437         LresultFromObject succeeds, it returns a reference to the accessible
 438         object to pass back to Windows. If not, we return false and let Windows
 439         handle the request through DefWindowProc.
 440         * WebView.h: Added declaration for onGetObject().
 441
 442 2008-04-18  Brady Eidson  <beidson@apple.com>
 443
 444         Reviewed by Sam Weinig
 445
 446         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
 447         No reason to do the work twice...
 448
 449         * WebView.cpp:
 450         (WebView::close):
 451
 452 2008-04-18  Adam Roben  <aroben@apple.com>
 453
 454         Update WebScriptDebugServer for JavaScriptDebugListener changes
 455
 456         Reviewed by Tim Hatcher.
 457
 458         * WebScriptDebugServer.cpp: Changed to use KJS::UString instead of
 459         WebCore::String.
 460         * WebScriptDebugServer.h: Ditto.
 461
 462 2008-04-16  Jon Honeycutt  <jhoneycutt@apple.com>
 463
 464         Reviewed by Darin.
 465
 466         Add a base AccessibilityObject wrapper class. Currently just stubs all
 467         of the IAccessible methods.
 468
 469         * AccessibleBase.cpp: Added. Implements IAccessible, and inherits from
 470         WebCore::AccessibilityObjectWrapper.
 471         (AccessibleBase::AccessibleBase): Set the object's wrapper to this
 472         instance.
 473         (AccessibleBase::~AccessibleBase):
 474         (AccessibleBase::createInstance): Create an instance of a wrapper for
 475         this AccessibilityObject.
 476         (AccessibleBase::QueryInterface):
 477         (AccessibleBase::Release):
 478         (AccessibleBase::get_accParent):
 479         (AccessibleBase::get_accChildCount):
 480         (AccessibleBase::get_accChild):
 481         (AccessibleBase::get_accName):
 482         (AccessibleBase::get_accValue):
 483         (AccessibleBase::get_accDescription):
 484         (AccessibleBase::get_accRole):
 485         (AccessibleBase::get_accState):
 486         (AccessibleBase::get_accHelp):
 487         (AccessibleBase::get_accKeyboardShortcut):
 488         (AccessibleBase::accSelect):
 489         (AccessibleBase::get_accFocus):
 490         (AccessibleBase::get_accSelection):
 491         (AccessibleBase::get_accDefaultAction):
 492         (AccessibleBase::accLocation):
 493         (AccessibleBase::accNavigate):
 494         (AccessibleBase::accHitTest):
 495         * AccessibleBase.h: Added.
 496         (AccessibleBase::AddRef):
 497         (AccessibleBase::put_accName):
 498         (AccessibleBase::put_accValue):
 499         (AccessibleBase::get_accHelpTopic):
 500         (AccessibleBase::GetTypeInfoCount):
 501         (AccessibleBase::GetTypeInfo):
 502         (AccessibleBase::GetIDsOfNames):
 503         (AccessibleBase::Invoke):
 504         (AccessibleBase::detach): Detach this wrapper from its object.
 505         * WebKit.vcproj/WebKit.vcproj:
 506
 507 2008-04-15  Anders Carlsson  <andersca@apple.com>
 508
 509         Reviewed by Adam.
 510
 511         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
 512
 513         * WebKit.vcproj/WebKit.vcproj:
 514
 515 2008-04-12  Matt Lilek  <webkit@mattlilek.com>
 516
 517         Not reviewed, build fix.
 518
 519         * WebView.cpp:
 520         (WebView::paintDocumentRectToContext):
 521
 522 2008-04-11  Steve Falkenburg  <sfalken@apple.com>
 523
 524         Fix caching typo.
 525
 526         Made this code match the Mac.
 527
 528         Reviewed by Mark Rowe.
 529
 530         * WebView.cpp:
 531         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
 532
 533 2008-04-11  Adam Roben  <aroben@apple.com>
 534
 535         * ForEachCoClass.h: Added a deprecation notice.
 536
 537 2008-04-11  Adam Roben  <aroben@apple.com>
 538
 539         Fix Bug 18376: r31733 and 27 don't work w/Safari 3.1
 540
 541         <https://bugs.webkit.org/show_bug.cgi?id=18376>
 542
 543         Rubberstamped by Steve.
 544
 545         * ForEachCoClass.h: Move post-3.1 classes to the end of the
 546         FOR_EACH_COCLASS macro so that pre-3.1 classes will be in the place
 547         Safari expects them to be. We will soon be deprecating
 548         setUseOpenSourceWebKit/progIDForClass because it is clearly very
 549         fragile.
 550
 551 2008-04-10  Ada Chan  <adachan@apple.com>
 552
 553         Added WebCoreStatistics that provides stats on Javascript objects
 554         and IconDatabase.
 555
 556         Changed WebCache::statistics() to additionally return xsl stylesheets data
 557         and data on live sizes and decoded sizes.
 558
 559         Reviewed by Steve.
 560
 561         * ForEachCoClass.h:
 562         * Interfaces/IWebCoreStatistics.idl: Added.
 563         * Interfaces/WebKit.idl:
 564         * WebCache.cpp:
 565         (WebCache::statistics):
 566         * WebCoreStatistics.cpp: Added.
 567         (WebCoreStatistics::WebCoreStatistics):
 568         (WebCoreStatistics::~WebCoreStatistics):
 569         (WebCoreStatistics::createInstance):
 570         (WebCoreStatistics::QueryInterface):
 571         (WebCoreStatistics::AddRef):
 572         (WebCoreStatistics::Release):
 573         (WebCoreStatistics::javaScriptObjectsCount):
 574         (WebCoreStatistics::javaScriptGlobalObjectsCount):
 575         (WebCoreStatistics::javaScriptProtectedObjectsCount):
 576         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
 577         (WebCoreStatistics::iconPageURLMappingCount):
 578         (WebCoreStatistics::iconRetainedPageURLCount):
 579         (WebCoreStatistics::iconRecordCount):
 580         (WebCoreStatistics::iconsWithDataCount):
 581         * WebCoreStatistics.h: Added.
 582         * WebKit.vcproj/WebKit.vcproj:
 583         * WebKitClassFactory.cpp:
 584
 585 2008-04-09  Steve Falkenburg  <sfalken@apple.com>
 586
 587         Delete backing store (after a delay) when a WebView's top-level parent becomes inactive.
 588
 589         Reviewed by Brady Eidson.
 590
 591         * WebView.cpp:
 592         (WebView::windowReceivedMessage):
 593
 594 2008-04-08  Adam Roben  <aroben@apple.com>
 595
 596         Export callOnMainThread from WebKit.dll
 597
 598         Rubberstamped by Anders.
 599
 600         * WebKit.vcproj/WebKit.def:
 601         * WebKit.vcproj/WebKit_debug.def:
 602
 603 2008-04-08  Adam Roben  <aroben@apple.com>
 604
 605         Move callOnMainThread to WTF
 606
 607         Reviewed by Alexey Proskuryakov.
 608
 609         * WebIconDatabase.cpp: Updated #include
 610
 611 2008-04-08  Steve Falkenburg  <sfalken@apple.com>
 612
 613         Add missing increment/decrement COM class counts to detect leaks.
 614
 615         Reviewed by Adam Roben.
 616
 617         * CFDictionaryPropertyBag.cpp:
 618         (CFDictionaryPropertyBag::CFDictionaryPropertyBag):
 619         (CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
 620         * CFDictionaryPropertyBag.h:
 621         * HTTPHeaderPropertyBag.cpp:
 622         (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):
 623         (HTTPHeaderPropertyBag::~HTTPHeaderPropertyBag):
 624         * HTTPHeaderPropertyBag.h:
 625         * WebActionPropertyBag.cpp:
 626         (WebActionPropertyBag::WebActionPropertyBag):
 627         (WebActionPropertyBag::~WebActionPropertyBag):
 628         * WebDocumentLoader.cpp:
 629         (WebDocumentLoader::WebDocumentLoader):
 630         (WebDocumentLoader::~WebDocumentLoader):
 631         * WebDropSource.cpp:
 632         (WebDropSource::WebDropSource):
 633         (WebDropSource::~WebDropSource):
 634         * WebDropSource.h:
 635         * WebElementPropertyBag.cpp:
 636         (WebElementPropertyBag::WebElementPropertyBag):
 637         (WebElementPropertyBag::~WebElementPropertyBag):
 638         * WebTextRenderer.cpp:
 639         (WebTextRenderer::WebTextRenderer):
 640         (WebTextRenderer::~WebTextRenderer):
 641
 642 2008-04-07  Brady Eidson  <beidson@apple.com>
 643
 644         Reviewed by John Honeycutt
 645
 646         ENABLE_DOM_STORAGE for Windows
 647
 648         * WebKit.vcproj/WebKit.vcproj:
 649
 650 2008-04-04  Adam Roben  <aroben@apple.com>
 651
 652         Export some more WTF functions from WebKit.dll
 653
 654         Reviewed by Alexey Proskuryakov.
 655
 656         * WebKit.vcproj/WebKit.def:
 657         * WebKit.vcproj/WebKit_debug.def:
 658
 659 2008-04-04  Steve Falkenburg  <sfalken@apple.com>
 660
 661         Only delete the backing store of background windows.
 662
 663         Reviewed by Ada Chan.
 664
 665         * WebView.cpp:
 666         (WebView::WebView):
 667         (WebView::deleteBackingStore):
 668         (WebView::paint): Added active check.
 669         (WebView::deleteBackingStoreSoon):
 670         (WebView::cancelDeleteBackingStoreSoon): Added.
 671         (WebView::active): Added.
 672         (WebView::updateActiveState): Moved active check code from here to active().
 673         * WebView.h:
 674
 675 2008-04-04  Steve Falkenburg  <sfalken@apple.com>
 676
 677         Fix tooltip window leak.
 678
 679         Explicitly call DestroyWindow on the tooltip.
 680         Destroying its parent won't destroy the tooltip, since it not a WS_CHILD style window.
 681
 682         Reviewed by Ada Chan.
 683
 684         * WebView.cpp:
 685         (WebView::~WebView):
 686
 687 2008-04-04  Steve Falkenburg  <sfalken@apple.com>
 688
 689         Delete backing store after we go 5 seconds without a paint.
 690
 691         Timer will be reset if a paint occurs, so this won't negatively impact performance.
 692
 693         Reviewed by Ada Chan.
 694
 695         * WebView.cpp:
 696         (WebView::paint): Call deleteBackingStoreSoon after paint.
 697         (WebViewWndProc): Add DeleteBackingStoreTimer.
 698         (WebView::deleteBackingStoreSoon): Added.
 699         * WebView.h: Add deleteBackingStoreSoon.
 700
 701 2008-04-04  Ada Chan  <adachan@apple.com>
 702
 703         <rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
 704         Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
 705         Changed the format string to take in integers.
 706
 707         Reviewed by Dan.
 708
 709         * English.lproj/Localizable.strings: Updated.
 710         * WebCoreLocalizedStrings.cpp:
 711         (WebCore::imageTitle):
 712
 713 2008-04-03  Dan Bernstein  <mitz@apple.com>
 714
 715         Reviewed by Dave Hyatt.
 716
 717         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
 718           font-weight does not properly support graded weights
 719
 720         * DOMCoreClasses.cpp:
 721         (DOMElement::font): Updated for the change to FontDescription.
 722         * WebCoreSupport/WebDragClient.cpp:
 723         (dragLabelFont): Ditto.
 724         * WebKitGraphics.cpp:
 725         (makeFont): Ditto.
 726         * WebKitGraphics.h: Added a FIXME.
 727
 728 2008-04-03  Steve Falkenburg  <sfalken@apple.com>
 729
 730         <rdar://problem/5835382> Calling window.open immediately after window.close can sometimes result in no window being created
 731
 732         Group name tracking needs to happen using code in WebCore::Page, since it is more involved than
 733         just setting a string.
 734
 735         Reviewed by Adam Roben.
 736
 737         * WebView.cpp:
 738         (WebView::close): Add null check (found via code inspection).
 739         (WebView::initWithFrame): Store the group name directly in Page.
 740         (WebView::setGroupName): Store the group name directly in Page.
 741         (WebView::groupName): Retrieve the group name directly from Page.
 742         * WebView.h: Removed m_groupName
 743
 744 2008-04-03  Simon Hausmann  <hausmann@webkit.org>
 745
 746         Reviewed by Mark Rowe.
 747
 748         Roll out r31599 and r31605 again after discussion with Mark Rowe.
 749
 750         * WebIconDatabase.cpp:
 751         (WebIconDatabase::iconForURL):
 752
 753 2008-04-03  Simon Hausmann  <hausmann@webkit.org>
 754
 755         Attempted build fix
 756
 757         * WebIconDatabase.cpp:
 758         (WebIconDatabase::iconForURL): Adjust to changed iconForPageURL
 759         signature
 760
 761 2008-04-03  Ada Chan  <adachan@apple.com>
 762
 763         Allow WebArchive to be created via COM.
 764         Replaced IID_DOMNode with __uuidof(DOMNode).
 765
 766         Reviewed by Adam and Steve.
 767
 768         * DOMCoreClasses.cpp:
 769         (DOMNode::QueryInterface):
 770         (DOMNode::isSameNode):
 771         * DOMCoreClasses.h:
 772         * ForEachCoClass.h:
 773         * Interfaces/WebKit.idl:
 774         * WebArchive.cpp:
 775         (WebArchive::createInstance):
 776         * WebArchive.h:
 777         * WebKitClassFactory.cpp:
 778
 779 2008-04-01  Brady Eidson  <beidson@apple.com>
 780
 781         Reviewed by Jon Honeycutt and Cake
 782
 783         Hookup WebArchive API enough to be able to save the archive of a DOMNode
 784
 785         * DOMCoreClasses.h: Add a GUID for DOMNode
 786
 787         * Interfaces/IWebArchive.idl: Add initWithNode()
 788
 789         * WebArchive.cpp:
 790         (WebArchive::initWithNode):
 791         (WebArchive::data): Actually return LegacyWebArchive-style data
 792         * WebArchive.h:
 793
 794 2008-04-01  Brady Eidson  <beidson@apple.com>
 795
 796         Reviewed by Adam Roben
 797
 798         Add empty implementations of WebArchive for future work
 799
 800         * WebArchive.cpp: Added.
 801         (WebArchive::createInstance):
 802         (WebArchive::WebArchive):
 803         (WebArchive::~WebArchive):
 804         (WebArchive::QueryInterface):
 805         (WebArchive::AddRef):
 806         (WebArchive::Release):
 807         (WebArchive::initWithMainResource):
 808         (WebArchive::initWithData):
 809         (WebArchive::mainResource):
 810         (WebArchive::subResources):
 811         (WebArchive::subframeArchives):
 812         (WebArchive::data):
 813         * WebArchive.h: Added.
 814
 815         * WebKit.vcproj/WebKit.vcproj:
 816
 817 2008-03-29  Adam Roben  <aroben@apple.com>
 818
 819         Rename IWebViewPrivate::addAdditionalPluginPath to
 820         addAdditionalPluginDirectory
 821
 822         Reviewed by Mitz Pettel.
 823
 824         * Interfaces/IWebViewPrivate.idl:
 825         * Interfaces/WebKit.idl: Touched to make sure the Interfaces project
 826         rebuilds.
 827         * WebView.cpp:
 828         (WebView::addAdditionalPluginDirectory):
 829         * WebView.h:
 830
 831 2008-03-26  Brent Fulgham  <bfulgham@gmail.com>
 832
 833         Reviewed by Adam Roben.
 834
 835         Add necessary files and build commands to vcproj files to
 836         build a Curl-based Windows WebKit.  For details, see
 837         http://bugs.webkit.org/show_bug.cgi?id=17985
 838
 839         * WebKit.vcproj/WebKit.vcproj:
 840
 841 2008-03-25  Adam Roben  <aroben@apple.com>
 842
 843         Attempted build fix
 844
 845         * WebKit.vcproj/WebKit.sln: Make testapi build after most other
 846         projects.
 847
 848 2008-03-25  Adam Roben  <aroben@apple.com>
 849
 850         Fix Bug 18077: Integrate testapi.c into the Windows build
 851
 852         <http://bugs.webkit.org/show_bug.cgi?id=18077>
 853
 854         Reviewed by Steve Falkenburg.
 855
 856         * WebKit.vcproj/WebKit.sln: Added testapi.vcproj to the solution.
 857
 858 2008-03-25  Brady Eidson  <beidson@apple.com>
 859
 860         Reviewed by Darin
 861
 862         Remove newly obsolete FrameLoaderClient methods
 863
 864         * WebFrame.cpp:
 865         * WebFrame.h:
 866
 867 2008-03-25  Darin Adler  <darin@apple.com>
 868
 869         Suggested by Adam.
 870
 871         * Interfaces/WebKit.idl: Touch this file to make the Interface project rebuild.
 872
 873 2008-03-21  Ada Chan  <adachan@apple.com>
 874
 875         <rdar://problem/5810324> visitCount not updated in History.plist
 876         Call WebCore::HistoryItem::mergeAutoCompleteHints() in WebHistoryItem::mergeAutoCompleteHints().
 877
 878         Reviewed by Steve.
 879
 880         * WebHistoryItem.cpp:
 881         (WebHistoryItem::mergeAutoCompleteHints):
 882         (WebHistoryItem::QueryInterface):
 883
 884 2008-03-20  Dan Bernstein  <mitz@apple.com>
 885
 886         Reviewed by Adam Roben.
 887
 888         - make makeTextLarger() and zoomPageIn() do what they are supposed to do
 889
 890         * WebView.cpp:
 891         (WebView::makeTextLarger): Changed call to canZoomIn() to zoomIn().
 892         (WebView::zoomPageIn): Ditto.
 893
 894 2008-03-20  Dave Hyatt  <hyatt@apple.com>
 895
 896         Add full page zoom API for Windows WebKit.
 897
 898         Reviewed by aroben
 899
 900         * Interfaces/IWebView.idl:
 901         * WebView.cpp:
 902         (WebView::WebView):
 903         (WebView::setTextSizeMultiplier):
 904         (WebView::setPageSizeMultiplier):
 905         (WebView::setZoomMultiplier):
 906         (WebView::textSizeMultiplier):
 907         (WebView::pageSizeMultiplier):
 908         (WebView::zoomMultiplier):
 909         (WebView::canMakeTextLarger):
 910         (WebView::canZoomPageIn):
 911         (WebView::canZoomIn):
 912         (WebView::makeTextLarger):
 913         (WebView::zoomPageIn):
 914         (WebView::zoomIn):
 915         (WebView::canMakeTextSmaller):
 916         (WebView::canZoomPageOut):
 917         (WebView::canZoomOut):
 918         (WebView::makeTextSmaller):
 919         (WebView::zoomPageOut):
 920         (WebView::zoomOut):
 921         (WebView::canMakeTextStandardSize):
 922         (WebView::canResetPageZoom):
 923         (WebView::canResetZoom):
 924         (WebView::makeTextStandardSize):
 925         (WebView::resetPageZoom):
 926         (WebView::resetZoom):
 927         * WebView.h:
 928
 929 2008-03-20  John Sullivan  <sullivan@apple.com>
 930
 931         * English.lproj/Localizable.strings:
 932         Brought this file up to date
 933
 934 2008-03-19  Dan Bernstein  <mitz@apple.com>
 935
 936         - build fix
 937
 938         * Interfaces/WebKit.idl: Touched.
 939
 940 2008-03-19  Adam Roben  <aroben@apple.com>
 941
 942         Fix a couple of bugs where the node highlight would appear when it shouldn't
 943
 944         There were at least two ways you could get the highlight to appear
 945         when it shouldn't:
 946           1) Selecting a node in the Inspector while the inspected WebView was
 947              in a background tab.
 948           2) Selecting a node in the Inspector, switching to another tab,
 949              closing the Inspector, then switching back to the inspected
 950              WebView's tab.
 951
 952         This patch fixes the above two issues, and possibly others.
 953
 954         show() and hide() are now private methods of WebNodeHighlight. They
 955         are replaced by a single public method,
 956         setShowsWhileWebViewIsVisible(bool). WebInspectorClient uses this to
 957         tell the highlight whether it should be showing when the inspected
 958         WebView is visible.
 959
 960         Reviewed by John Sullivan.
 961
 962         * WebCoreSupport/WebInspectorClient.cpp:
 963         (WebInspectorClient::highlight): If the highlight is already showing,
 964         it just needs to update since the highlighted node has changed. If the
 965         highlight is not showing, call setShowsWhileWebViewIsVisible(true) so
 966         that the highlight will show when the WebView is shown.
 967         (WebInspectorClient::hideHighlight): Changed to call
 968         setShowsWhileWebViewIsVisible(false) instead of hide().
 969         * WebNodeHighlight.cpp:
 970         (WebNodeHighlight::WebNodeHighlight): Initialize new member, and
 971         initialize m_inspectedWebViewWindow to its final value here instead of
 972         in show().
 973         (WebNodeHighlight::setShowsWhileWebViewIsVisible): Added. If we're not
 974         supposed to show ourselves when the WebView is visible, we hide
 975         ourselves and return. Otherwise, we make our visibility match the
 976         WebView's.
 977         (WebNodeHighlight::isWebViewVisible): Added.
 978         (WebNodeHighlight::show): Removed initialization of
 979         m_inspectedWebViewWindow (this is now done by our constructor). Added
 980         an assertion that we're supposed to show ourselves when the WebView is
 981         visible.
 982         (WebNodeHighlight::onWebViewShowWindow): If we shouldn't show
 983         ourselves when the WebView is visible, then we don't need to do
 984         anything at all when the WebView's visibility changes.
 985         * WebNodeHighlight.h:
 986
 987 2008-03-19  Adam Roben  <aroben@apple.com>
 988
 989         Small WebNodeHighlight cleanup
 990
 991         Renamed the following methods:
 992           visible() -> isShowing()
 993           updateWindow() -> update()
 994
 995         Removed the window() method.
 996
 997         Added a new method, placeBehindWindow(HWND), that moves the highlight
 998         overlay in the window z-order to be just behind the passed-in window.
 999         WebInspectorClient calls this instead of doing the move directly using
1000         the old window() method.
1001
1002         Reviewed by John Sullivan.
1003
1004         * WebCoreSupport/WebInspectorClient.cpp:
1005         (WebInspectorClient::attachWindow):
1006         (WebInspectorClient::detachWindow):
1007         (WebInspectorClient::highlight): Call placeBehindWindow instead of
1008         calling SetWindowPos directly.
1009         * WebNodeHighlight.cpp:
1010         (WebNodeHighlight::show):
1011         (WebNodeHighlight::isShowing):
1012         (WebNodeHighlight::placeBehindWindow): Added. Code came from
1013         WebInspectorClient::highlight.
1014         (WebNodeHighlight::onWebViewWindowPosChanged):
1015         (WebNodeHighlight::onRootWindowPosChanged):
1016         * WebNodeHighlight.h:
1017
1018 2008-03-19  Ada Chan  <adachan@apple.com>
1019
1020         Added a method to paint WebView content specified by
1021         the document rect into a device context.
1022
1023         Reviewed by Darin.
1024
1025         * Interfaces/IWebViewPrivate.idl:
1026         * WebView.cpp:
1027         (WebView::paintDocumentRectToContext):
1028         * WebView.h:
1029
1030 2008-03-18  Brent Fulgham  <bfulgham@gmail.com>
1031
1032         Reviewed by Adam Roben.
1033
1034         Provide some stub implementations for things that WebKit
1035         uses for performing authentication/challenge activities.  This
1036         is in support of http://bugs.webkit.org/show_bug.cgi?id=17837
1037
1038         * WebDataSource.cpp:
1039         * WebError.cpp:  Conditionalize CFNetwork-specific logic
1040         * WebURLAuthenticationChallenge.cpp:  Conditionalize constructor
1041           for authentication/challenge member.
1042         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
1043         * WebURLResponse.cpp:  Remove CFNetwork-specific logic.
1044         * WebURLResponse.h: Conditionalize CFNetwork-specific member.
1045         * WebView.cpp:  Conditionalize CFNetwork-specific network protocol test.
1046         (WebView::canHandleRequest):
1047
1048 2008-03-18  Adam Roben  <aroben@apple.com>
1049
1050         Focus the Inspector's WebView whenever the Inspector window is focused
1051
1052         Reviewed by Mitz.
1053
1054         * WebCoreSupport/WebInspectorClient.cpp:
1055         (WebInspectorClient::onSetFocus): Send focus to the WebView.
1056         (WebInspectorWndProc): Added a handler for WM_SETFOCUS.
1057         * WebCoreSupport/WebInspectorClient.h:
1058
1059 2008-03-18  Adam Roben  <aroben@apple.com>
1060
1061         Fix Bug 14276: Element highlight also covers Web inspector
1062
1063         <http://bugs.webkit.org/show_bug.cgi?id=14276>
1064         <rdar://5712796>
1065
1066         Also fixes <rdar://5622837> Browser window comes to front when node
1067         highlight appears, potentially blocking Inspector
1068
1069         Reviewed by Mitz.
1070
1071         * WebCoreSupport/WebInspectorClient.cpp:
1072         (WebInspectorClient::highlight): After showing the highlight,
1073         reposition it just behind the Inspector's window.
1074         * WebNodeHighlight.cpp:
1075         (WebNodeHighlight::show):
1076           - Changed flags passed to CreateWindowEx to not specify WS_VISIBLE.
1077             This is not needed because we'll show the window later in this
1078             function.
1079           - Removed call to SetWindowPos that tried to position the overlay
1080             just in front of the WebView. This is now handled by
1081             WebInspectorClient.
1082           - Changed call to ShowWindow to use SetWindowPos so that we can pass
1083             SWP_NOACTIVATE. This prevents the highlight from jumping in front
1084             of the Inspector every time it's shown.
1085         * WebNodeHighlight.h: Added a method to get the highlight's HWND.
1086
1087 2008-03-14  Steve Falkenburg  <sfalken@apple.com>
1088
1089         PGO build fixes.
1090
1091         * WebKit.vcproj/WebKit.vcproj:
1092
1093 2008-03-13  Adam Roben  <aroben@apple.com>
1094
1095         Another Windows build fix after r31034
1096
1097         * WebKitDLL.cpp:
1098         (loadResourceIntoBuffer): Use SharedBuffer::create.
1099
1100 2008-03-13  Adam Roben  <aroben@apple.com>
1101
1102         Windows build fix after r31034
1103
1104         * WebFrame.cpp:
1105         (WebFrame::loadData): Use SharedBuffer::create.
1106         (WebFrame::loadHTMLString): Ditto.
1107
1108 2008-03-13  Steve Falkenburg  <sfalken@apple.com>
1109
1110         More PGO build fixes.
1111
1112         * WebKit.vcproj/WebKit.pgd: Removed.
1113         * WebKit.vcproj/WebKit.vcproj:
1114         * WebKitPrefix.cpp:
1115
1116 2008-03-13  Anders Carlsson  <andersca@apple.com>
1117
1118         Reviewed by Adam.
1119
1120         Call originalRequest instead of initialRequest.
1121
1122         * WebDataSource.cpp:
1123         (WebDataSource::initialRequest):
1124
1125 2008-03-13  Steve Falkenburg  <sfalken@apple.com>
1126
1127         PGO build fixes.
1128
1129         Disable PGO for normal release builds.
1130         Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.
1131
1132         * WebKit.vcproj/WebKit.vcproj:
1133
1134 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1135
1136         Fix build.
1137
1138         * WebKit.vcproj/WebKit.vcproj:
1139
1140 2008-03-12  Ada Chan  <adachan@apple.com>
1141
1142         <rdar://problem/5795843>
1143         CFURLDownload needs to be cancelled if we don't have a destination path
1144         to save resume information.
1145
1146         Reviewed by Brady.
1147
1148         * WebDownload.cpp:
1149         (WebDownload::cancelForResume):
1150
1151 2008-03-12  David Hyatt  <hyatt@apple.com>
1152
1153         Make the zoom factor a float and not a percent.
1154
1155         Reviewed by antti
1156
1157         * WebFrame.cpp:
1158         (WebFrame::setTextSizeMultiplier):
1159
1160 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1161
1162         Build fix.
1163
1164         * WebKit.vcproj/WebKit.pgd:
1165         * WebKit.vcproj/WebKit.vcproj:
1166
1167 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1168
1169         Re-enabled PGO.
1170
1171         Rubber stamped by Mark Rowe.
1172
1173         * WebKit.vcproj/WebKit.pgd:
1174         * WebKit.vcproj/WebKit.vcproj:
1175         * WebKitPrefix.cpp: touched this file to force a re-build.
1176
1177 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1178
1179         Fix build.
1180
1181         * WebKit.vcproj/WebKit.vcproj:
1182
1183 2008-03-11  Steve Falkenburg  <sfalken@apple.com>
1184
1185         Use PGO to build WebKit.dll.
1186
1187         Reviewed by Oliver.
1188
1189         * WebKit.vcproj/WebKit.pgd: Added.
1190         * WebKit.vcproj/WebKit.vcproj:
1191
1192 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
1193
1194         Reviewed by Adam Roben.
1195
1196         Enabled WinLauncher as part of normal Windows build.
1197         http://bugs.webkit.org/show_bug.cgi?id=17715.
1198
1199         * WebKit.vcproj/WebKit.sln:  Add WinLauncher to the set of things
1200           build during a Windows build.
1201
1202 2008-03-11  Adam Roben  <aroben@apple.com>
1203
1204         Roll out r30961 since it broke the default site icon on Windows
1205
1206         * WebKit.vcproj/WebKit.rc:
1207         * WebKit.vcproj/urlIcon.png: Renamed from WebCore/Resources/urlIcon.png.
1208         * WebKitDLL.cpp:
1209         (loadResourceIntoBuffer):
1210
1211 2008-03-11  Holger Hans Peter Freyther  <zecke@selfish.org>
1212
1213         Reviewed by Darin.
1214
1215         r25512 inlined the urlIcon to improve the startup time of Safari on Mac. Inlining is
1216         not suitable for platforms where this icon is themable. E.g. the Qt platform is allowing
1217         to theme this icon and the Gtk+ platform will probably end up with themable icons
1218         as well.
1219
1220         Remove dead code from the windows port and move the urlIcon from the windows
1221         directory to the Resource directory to be used by Qt and other ports.
1222
1223         Ifdef the usage of the built-in icon in IconDatabase.cpp and for Qt do not use
1224         it. Gtk+ currently has no proper implementation of Image::loadPlatformResource but
1225         once it does it wants to use this for getting the urlIcon as well.
1226
1227         * WebKit.vcproj/WebKit.rc:
1228         * WebKitDLL.cpp:
1229         (loadResourceIntoBuffer):
1230
1231 2008-03-10  Eric Seidel  <eric@webkit.org>
1232
1233         No review, build fix only.
1234
1235         Speculative fix for Windows build, use ::UChar instead of KJS::UChar
1236
1237         * WebScriptCallFrame.cpp:
1238         (WebScriptCallFrame::valueForVariable):
1239         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
1240
1241 2008-03-10  Steve Falkenburg  <sfalken@apple.com>
1242
1243         Fix build break caused by r30920.
1244
1245         Serialize remaining dependent builds by adding dependencies.
1246         Visual Studio per-vcproj parallelization doesn't add a lot of value
1247         since so many of our builds are dependent - this just enforces that.
1248         We do our parallelization via pdevenv, which works much better.
1249
1250         * WebKit.vcproj/WebKit.sln:
1251         * WebKit.vcproj/WebKit.submit.sln:
1252
1253 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
1254
1255         Stop Windows build if an error occurs in a prior project.
1256
1257         Rubber stamped by Darin.
1258
1259         * WebKit.vcproj/Interfaces.vcproj:
1260         * WebKit.vcproj/InterfacesGenerated.vcproj:
1261         * WebKit.vcproj/WebKit.vcproj:
1262         * WebKit.vcproj/WebKitGUID.vcproj:
1263
1264 2008-03-09  Adam Roben  <aroben@apple.com>
1265
1266         Make WebInspectorClient use WindowMessageBroadcaster instead of manual subclassing
1267
1268         Reviewed by Darin.
1269
1270         * WebCoreSupport/WebInspectorClient.cpp:
1271         (WebInspectorClient::WebInspectorClient): Removed
1272         m_orignalWebViewWndProc member.
1273         (WebInspectorClient::attachWindow): Register as a listener with
1274         WindowMessageBroadcaster instead of subclassing.
1275         (WebInspectorClient::detachWindow): Deregister as a listener with
1276         WindowMessageBroadcaster instead of unsubclassing.
1277         (WebInspectorClient::windowReceivedMessage): Renamed from
1278         SubclassedWebViewWndProc. Also added a missing break statement after
1279         the call to onWebViewWindowPosChanging.
1280         * WebCoreSupport/WebInspectorClient.h:
1281
1282 2008-03-09  Adam Roben  <aroben@apple.com>
1283
1284         Make the node highlight not obscure the tab bar when it first appears
1285
1286         Reviewed by Darin.
1287
1288         * WebNodeHighlight.cpp:
1289         (WebNodeHighlight::onWebViewWindowPosChanged): Added. Listens for
1290         changes to the WebView's size and resizes the highlight window to
1291         match.
1292         (WebNodeHighlight::onRootWindowPosChanged): Added. Listens for changes
1293         to the WebView's root window's position and moves the highlight window
1294         to match.
1295         (WebNodeHighlight::windowReceivedMessage): Call
1296         onWebViewWindowPosChanged/onRootWindowPosChanged as appropriate.
1297         * WebNodeHighlight.h:
1298
1299 2008-03-09  Adam Roben  <aroben@apple.com>
1300
1301         Fix Bug 14254: Inspector node highlight applied to all tabs
1302
1303         <http://bugs.webkit.org/show_bug.cgi?id=14254>
1304         <rdar://problem/5322306>
1305
1306         WebNodeHighlight now listens for the WM_SHOWWINDOW message being sent
1307         to the inspected WebView so that it can hide/show itself as the
1308         WebView is hidden/shown.
1309
1310         Reviewed by Anders.
1311
1312         * WebNodeHighlight.cpp:
1313         (WebNodeHighlight::~WebNodeHighlight): Remove ourselves as a listener
1314         for our inspected WebView's window's messages.
1315         (WebNodeHighlight::show): Add ourselves as a listener for our
1316         inspected WebView's window's messages.
1317         (WebNodeHighlight::onWebViewShowWindow): Added. Hide ourselves when
1318         the WebView hides, show ourselves when the WebView is shown.
1319         (WebNodeHighlight::windowReceivedMessage): Added a separate switch
1320         statement to handle the inspected WebView's window's messages.
1321         * WebNodeHighlight.h:
1322
1323 2008-03-07  Brent Fulgham  <bfulgham@gmail.com>
1324
1325         Reviewed by Mark Rowe.
1326
1327         Correct build intermediary output
1328         (http://bugs.webkit.org/show_bug.cgi?id=17713)
1329
1330         * WebKit/win/WebKit.vcproj/WebKit.vcproj:  Correct output and intermediary paths
1331
1332 2008-03-07  Brent Fulgham  <bfulgham@gmail.com>
1333
1334         Reviewed by Adam Roben.
1335
1336         Do not link (or attempt to initialize) the SafariTheme.dll
1337         when not building with USE(SAFARI_THEME) enabled.
1338         (http://bugs.webkit.org/show_bug.cgi?id=17707)
1339
1340         * WebKit/win/WebKitClassFactory.cpp:  Conditionalize use of SafariTheme.dll
1341
1342 2008-03-07  Brent Fulgham  <bfulgham@gmail.com>
1343
1344         Reviewed by Steve Falkenburg.
1345
1346         Update solution to understand Cairo build target.  Add
1347         library dependencies for Cairo build target.
1348         (http://bugs.webkit.org/show_bug.cgi?id=17300)
1349
1350         * WebKit.vcproj/WebKit.sln:
1351         * WebKit.vcproj/WebKit.vcproj:
1352
1353 2008-03-06  Adam Roben  <aroben@apple.com>
1354
1355         Change WebScriptDebugServer to use WebCore::JavaScriptDebugServer
1356
1357         WebScriptDebugServer is now a JavaScriptDebugListener.
1358
1359         Reviewed by Darin.
1360
1361         * WebScriptDebugServer.cpp:
1362         (WebScriptDebugServer::WebScriptDebugServer): Removed initialization
1363         of m_callingListeners member.
1364         (WebScriptDebugServer::addListener): Register as a listener with
1365         JavaScriptDebugServer if we've just added our first listener.
1366         (WebScriptDebugServer::removeListener): Deregister as a listener with
1367         JavaScriptDebugServer if we've just removed our last listener.
1368         (WebScriptDebugServer::didParseSource): Added. Code came from the old
1369         sourceParsed method. Removed m_callingListeners code because
1370         JavaScriptDebugServer guards against re-entry for us.
1371         (WebScriptDebugServer::failedToParseSource): Ditto.
1372         (WebScriptDebugServer::didEnterCallFrame): Ditto for callEvent.
1373         (WebScriptDebugServer::willExecuteStatement): Ditto for atStatement.
1374         (WebScriptDebugServer::willLeaveCallFrame): Ditto for
1375         willLeaveCallFrame.
1376         (WebScriptDebugServer::exceptionWasRaised): Ditto for exception.
1377         * WebScriptDebugServer.h: Changed to inherit from
1378         WebCore::JavaScriptDebugListener.
1379         * WebView.cpp:
1380         (WebView::initWithFrame): Removed call to
1381         WebScriptDebugServer::pageCreated. This is now handled by WebCore.
1382
1383 2008-03-06  Darin Adler  <darin@apple.com>
1384
1385         Reviewed by Mitz.
1386
1387         - fix regression test failures and crashes from the visited-link change
1388
1389         * WebCoreSupport/WebChromeClient.cpp:
1390         (WebChromeClient::populateVisitedLinks): Check for null before calling
1391         addVisitedLinksToPageGroup.
1392         * WebCoreSupport/WebFrameLoaderClient.cpp:
1393         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
1394         * WebHistory.cpp:
1395         (WebHistory::setOptionalSharedHistory): Call PageGroup::setShouldTrackVisitedLinks
1396         to turn off visited links if there is no history object. Also call
1397         removeAllVisitedLinks so we can start over from scratch with the new history.
1398
1399 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
1400
1401         Reviewed by Adam Roben.
1402
1403         Bug 17691: REGRESSION: FindSafari doesn't work
1404         http://bugs.webkit.org/show_bug.cgi?id=17691
1405
1406         Swap my change from r30394 to use the Release libraries instead of Debug
1407         since some machines don't have the Debug version.
1408
1409         * WebKit.vcproj/WebKit.sln:
1410
1411 2008-03-06  Darin Adler  <darin@apple.com>
1412
1413         Reviewed by Mitz.
1414
1415         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
1416           REGRESSION: iframes are added to Safari's History menu
1417           by separating the visited link machinery from global history
1418
1419         * WebCoreSupport/WebChromeClient.cpp:
1420         (WebChromeClient::populateVisitedLinks): Added a call to the new
1421         WebHistory::addVisitedLinksToPageGroup function.
1422         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
1423         Also fixed the webView function to be non-virtual.
1424
1425         * WebCoreSupport/WebFrameLoaderClient.cpp:
1426         (WebFrameLoaderClient::updateGlobalHistory): Changed to use the
1427         new WebHistory::addItem function.
1428         (WebFrameLoaderClient::webHistory): Changed to return a WebHistory*,
1429         there's no reason to AddRef the result from this function.
1430         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
1431
1432         * WebHistory.cpp: Removed IWebHistoryPrivate and _WebCoreHistoryProvider.
1433         (WebHistory::QueryInterface): Removed IWebHistoryPrivate.
1434         (sharedHistoryStorage): Added.
1435         (WebHistory::sharedHistory): Added.
1436         (WebHistory::optionalSharedHistory): Changed to use sharedHistory().
1437         (WebHistory::setOptionalSharedHistory): Changed to require a WebHistory
1438         object, not just an IWebHistory.
1439         (WebHistory::removeAllItems): Call PageGroup::removeAllVisitedLinks.
1440         (WebHistory::addItem): Changed parameter types since this is called with
1441         arguments from WebCore -- at some point this could allow better efficiency.
1442         (WebHistory::removeItemForURLString):  Call PageGroup::removeAllVisitedLinks
1443         if the last URL is being removed.
1444         (addVisitedLinkToPageGroup): Added. Helper. Adds a single link to a group's
1445         visited link set.
1446         (WebHistory::addVisitedLinksToPageGroup): Added. Adds all links to a group's
1447         visited link.
1448         * WebHistory.h: Removed IWebHistoryPrivate. Removed optionalSharedHistoryInternal
1449         and added sharedHistory. Replaced addItemForURL and containsItemForURLString with
1450         non-virtual addItem and addVisitedLinksToPageGroup functions.
1451
1452 2008-03-05  Anders Carlsson  <andersca@apple.com>
1453
1454         Build fix.
1455
1456         * WebKit.vcproj/WebKit.vcproj:
1457
1458 2008-03-04  Sam Weinig  <sam@webkit.org>
1459
1460         Reviewed by Mark Rowe.
1461
1462         - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
1463           JSDOMWindow.h
1464
1465         * WebFrame.cpp:
1466
1467 2008-03-04  Adam Roben  <aroben@apple.com>
1468
1469         WebScriptDebugServer cleanup
1470
1471         Reviewed by Anders.
1472
1473         * WebScriptDebugServer.cpp: Renamed m_callingServer to
1474         m_callingListeners.
1475         (WebScriptDebugServer::WebScriptDebugServer):
1476         (WebScriptDebugServer::sharedWebScriptDebugServer): Changed to keep
1477         the shared instance as a function-level static.
1478         (WebScriptDebugServer::didLoadMainResourceForDataSource): Made return
1479         void.
1480         (WebScriptDebugServer::sourceParsed):
1481         (WebScriptDebugServer::callEvent):
1482         (WebScriptDebugServer::atStatement):
1483         (WebScriptDebugServer::returnEvent):
1484         (WebScriptDebugServer::exception):
1485         (WebScriptDebugServer::serverDidDie): Made return void.
1486         * WebScriptDebugServer.h:
1487           - Removed unnecessary #includes
1488           - Made inheritance from KJS::Debugger private
1489           - Made some methods private
1490
1491 2008-03-04  Adam Roben  <aroben@apple.com>
1492
1493         Remove WebScriptDebugger
1494
1495         Reviewed by Anders.
1496
1497         * WebKit.vcproj/WebKit.vcproj: Removed files from project.
1498         * WebScriptDebugServer.cpp:
1499         (frame): Moved here from WebScriptDebugger.cpp.
1500         (webFrame): Ditto.
1501         (webView): Ditto.
1502         (WebScriptDebugServer::WebScriptDebugServer): Initialize new member.
1503         * WebScriptDebugServer.h: Changed to inherit directly from
1504         KJS::Debugger instead of from WebScriptDebugger, and added
1505         m_callingServer member that WebScriptDebugger used to own.
1506         * WebScriptDebugger.cpp: Removed.
1507         * WebScriptDebugger.h: Removed.
1508
1509 2008-03-04  Adam Roben  <aroben@apple.com>
1510
1511         Move sourceParsed to WebScriptDebugServer
1512
1513         Reviewed by Anders.
1514
1515         * WebScriptDebugServer.cpp:
1516         (WebScriptDebugServer::sourceParsed): Moved here from
1517         WebScriptDebugger and merged with didParseSource/failedToParseSource.
1518         * WebScriptDebugServer.h: Removed didParseSource/failedToParseSource.
1519         * WebScriptDebugger.cpp: Removed sourceParsed.
1520         * WebScriptDebugger.h: Ditto.
1521
1522 2008-03-04  Adam Roben  <aroben@apple.com>
1523
1524         Move callEvent, returnEvent, and exception to WebScriptDebugServer
1525
1526         Reviewed by Anders.
1527
1528         * WebScriptDebugServer.cpp:
1529         (WebScriptDebugServer::callEvent): Moved here from WebScriptDebugger
1530         and merged with didEnterCallFrame.
1531         (WebScriptDebugServer::returnEvent): Ditto for willLeaveCallFrame.
1532         (WebScriptDebugServer::exception): Ditto for exceptionWasRaised.
1533         * WebScriptDebugServer.h: Removed didEnterCallFrame,
1534         willLeaveCallFrame, and exceptionWasRaised.
1535         * WebScriptDebugger.cpp: Removed callEvent, returnEvent, and
1536         exception.
1537         * WebScriptDebugger.h: Ditto.
1538
1539 2008-03-04  Adam Roben  <aroben@apple.com>
1540
1541         Move atStatement to WebScriptDebugServer
1542
1543         Reviewed by Anders.
1544
1545         * WebScriptDebugServer.cpp:
1546         (WebScriptDebugServer::atStatement): Moved here and merged with the
1547         old willExecuteStatement method.
1548         * WebScriptDebugServer.h: Removed inheritance from
1549         IWebScriptDebugListener, which no one was relying on.
1550         * WebScriptDebugger.cpp:
1551         (webFrame): Made non-static.
1552         (webView): Ditto.
1553         * WebScriptDebugger.h: Added declarations of webFrame and webView
1554         methods for WebScriptDebugServer's benefit. Removed unused m_webView
1555         and m_frame members.
1556
1557 2008-03-04  Adam Roben  <aroben@apple.com>
1558
1559         Start to merge WebScriptDebugger and WebScriptDebugServer
1560
1561         WebScriptDebugServer now inherits from WebScriptDebugger.
1562
1563         Reviewed by Anders.
1564
1565         * WebScriptDebugServer.cpp:
1566         (WebScriptDebugServer::pageCreated): Use sharedWebScriptDebugServer
1567         instead of WebScriptDebugger::shared.
1568         (WebScriptDebugServer::addListener): Ditto.
1569         (WebScriptDebugServer::removeListener): Ditto.
1570         * WebScriptDebugServer.h: Changed to inherit from WebScriptDebugger.
1571         * WebScriptDebugger.cpp: Removed shared method.
1572         * WebScriptDebugger.h: Made constructor/destructor protected, and
1573         removed shared method.
1574
1575 2008-03-04  Adam Roben  <aroben@apple.com>
1576
1577         Use WebCore's new debugger-attaching code
1578
1579         Reviewed by Kevin M.
1580
1581         * WebCoreSupport/WebFrameLoaderClient.cpp: Moved a kit() function to
1582         WebView.{cpp,h} so that other files can call it.
1583         * WebFrame.cpp:
1584         (WebFrame::WebFrame): Removed m_scriptDebugger member.
1585         (WebFrame::windowObjectCleared): Removed attach/detach calls. This is
1586         no longer needed because WebScriptDebugger no longer stores any
1587         per-WebFrame state.
1588         * WebFrame.h:
1589         * WebScriptDebugServer.cpp:
1590         (WebScriptDebugServer::pageCreated): Added. Attaches our shared
1591         debugger to the Page if we have any listeners.
1592         (WebScriptDebugServer::addListener): Sets our shared debugger for all
1593         Pages when we get our first listener.
1594         (WebScriptDebugServer::removeListener): Removes our shared debugger
1595         from all Pages when we lose our last listener.
1596         * WebScriptDebugServer.h:
1597         * WebScriptDebugger.cpp:
1598         (WebScriptDebugger::shared): Added.
1599         (WebScriptDebugger::WebScriptDebugger): Removed m_frame member.
1600         (WebScriptDebugger::~WebScriptDebugger): Added.
1601         (frame): Gets a Frame from an ExecState.
1602         (webFrame): Gets a WebFrame from an ExecState.
1603         (webView): Gets a WebView from an ExecState.
1604         (WebScriptDebugger::sourceParsed): Changed to call webFrame() and
1605         webView() instead of using m_frame and m_webView members.
1606         (WebScriptDebugger::callEvent): Ditto.
1607         (WebScriptDebugger::atStatement): Ditto.
1608         (WebScriptDebugger::returnEvent): Ditto.
1609         (WebScriptDebugger::exception): Ditto.
1610         * WebScriptDebugger.h:
1611         * WebView.cpp:
1612         (kit): Moved here from WebFrameLoaderClient.cpp.
1613         (WebView::initWithFrame): Tell the WebScriptDebugServer about the new
1614         Page so it can attach a debugger if needed.
1615         * WebView.h:
1616
1617 2008-03-04  Adam Roben  <aroben@apple.com>
1618
1619         Change WebView's string-finding methods to call through to Page
1620
1621         These methods were added to Page back in r28878 (and the
1622         implementation was copied from WebView!) but we never switched over to
1623         using them.
1624
1625         Reviewed by Sam.
1626
1627         * WebView.cpp:
1628         (WebView::searchFor): Call through to Page::findString.
1629         (WebView::markAllMatchesForText): Call through to Page.
1630         (WebView::unmarkAllTextMatches): Ditto.
1631
1632 2008-03-04  Adam Roben  <aroben@apple.com>
1633
1634         Actually pause the process while Drosera is at a breakpoint
1635
1636         WebScriptDebugServer::suspendProcessIfPaused is supposed to pause the
1637         process while Drosera is at a breakpoint. Previously we were just
1638         starting a message pump that would deliver messages to all windows in
1639         the process, allowing mouse events, JS timers, etc. to execute.
1640
1641         Now we only deliver messages to COM's message window, which is all we
1642         need to allow RPC to function.
1643
1644         Reviewed by Anders.
1645
1646         * WebScriptDebugServer.cpp:
1647         (comMessageWindow): Added. Finds COM's message window.
1648         (WebScriptDebugServer::suspendProcessIfPaused): Only deliver messages
1649         to COM's message window so that mouse events, JS timers, etc., won't
1650         execute.
1651
1652 2008-03-03  Adam Roben  <aroben@apple.com>
1653
1654         Generate WebScriptCallFrame instances dynamically
1655
1656         WebScriptDebugger no longer holds a reference to the topmost call
1657         frame, and WebScriptCallFrame no longer holds a reference to its
1658         caller. We now generate WebScriptCallFrame instances as needed by
1659         walking the callingExecState chain.
1660
1661         By making WebKit no longer responsible for keeping track of the call
1662         stack, we get one step closer to moving most JS debugging code out of
1663         WebKit entirely.
1664
1665         This incidentally fixes a bug in Drosera where we'd never show the
1666         global scope in the call stack.
1667
1668         Reviewed by Sam and Kevin M.
1669
1670         * WebScriptCallFrame.cpp:
1671         (callingFunctionOrGlobalExecState): Finds the nearest calling
1672         ExecState that is a FunctionExecState or GlobalExecState, if any, and
1673         returns it.
1674         (WebScriptCallFrame::WebScriptCallFrame):
1675           - No longer takes a caller parameter.
1676           - Sets m_state to the callingFunctionOrGlobalExecState of the
1677             ExecState passed in.
1678         (WebScriptCallFrame::createInstance): Removed the caller parameter.
1679         (WebScriptCallFrame::caller): Generate a new WebScriptCallFrame on the
1680         fly from our ExecState.
1681         * WebScriptCallFrame.h: No longer holds a reference to the caller.
1682         * WebScriptDebugger.cpp:
1683         (WebScriptDebugger::WebScriptDebugger): Removed the call to callEvent
1684         that was supposed to set up the global scope call frame, but never
1685         worked because m_callingServer was set to true, which would cause
1686         callEvent to return early without doing anything. Also removed the
1687         m_callingServer guards since we're not calling callEvent anymore.
1688         (WebScriptDebugger::callEvent): Create a WebScriptCallFrame on the
1689         fly from the passed-in ExecState.
1690         (WebScriptDebugger::atStatement): Ditto.
1691         (WebScriptDebugger::returnEvent): Ditto, but use the callingExecState.
1692         This is equivalent to what calling leaveFrame() did before.
1693         (WebScriptDebugger::exception): Ditto, using the passed-in ExecState.
1694         * WebScriptDebugger.h: Removed m_topStackFrame member and
1695         enterFrame/leaveFrame methods.
1696
1697 2008-03-03  Sam Weinig  <sam@webkit.org>
1698
1699         Windows build fix.
1700
1701         * WebFrame.cpp:
1702         (WebFrame::windowObjectCleared):
1703
1704 2008-03-03  David Hyatt  <hyatt@apple.com>
1705
1706         Full page zoom work.  Make setting of a zoom factor take a boolean saying whether it is a text only
1707         or full page zoom.
1708
1709         Reviewed by Tim H.
1710
1711         * WebFrame.cpp:
1712         (WebFrame::setTextSizeMultiplier):
1713
1714 2008-02-29  Adam Roben  <aroben@apple.com>
1715
1716         Delete an unused file
1717
1718         Rubberstamped by Brady.
1719
1720         * Interfaces/IWebScriptScope.idl: Removed.
1721
1722 2008-02-28  Adam Roben  <aroben@apple.com>
1723
1724         Change WebPreferences to be backed by CFPreferences
1725
1726         Reviewed by Ada, Geoff, Steve, and Darin.
1727
1728         * WebPreferenceKeysPrivate.h:
1729         * WebPreferences.cpp:
1730         (WebPreferences::sharedStandardPreferences): Changed to call
1731         setAutoSaves(TRUE) before calling load(). This ensures that the
1732         preferences being migrated to CFPreferences are saved to disk.
1733         (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure
1734         that the refcount is managed properly. Now attempts to retrieve a
1735         value from CFPreferences before falling back to the default settings.
1736         (WebPreferences::setValueForKey): Now saves the value in
1737         CFPreferences if m_autoSaves is true.
1738         (WebPreferences::stringValueForKey): Updated for valueForKey changes.
1739         (WebPreferences::integerValueForKey): DItto.
1740         (WebPreferences::boolValueForKey): Ditto.
1741         (WebPreferences::floatValueForKey): Ditto.
1742         (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize.
1743         (WebPreferences::load): Always initializes m_privatePrefs to an empty
1744         CFMutableDictionary.
1745         (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates
1746         preferences from our old custom plist to CFPreferences and then
1747         deletes our custom plist, if the migration has never occurred before.
1748         (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies
1749         preferences to CFPreferences. If we've never migrated the default
1750         settings from Safari 3 Beta before, we omit them from this copying
1751         procedure.
1752         * WebPreferences.h:
1753
1754 2008-02-28  Adam Roben  <aroben@apple.com>
1755
1756         Refactor value <-> CFNumber conversions into some helper functions
1757
1758         Reviewed by Jon.
1759
1760         * WebPreferences.cpp:
1761         (preferencesPath): Changed to return a const String&.
1762         (numberValueForPreferencesValue): Converts a value from preferences to
1763         a native numeric type.
1764         (cfNumber): Converts a native numeric value to a CFNumberRef.
1765         (booleanValueForPreferencesValue): Converts a value from preferences
1766         to a native boolean.
1767         (WebPreferences::integerValueForKey): Changed to call
1768         numberValueForPreferencesValue.
1769         (WebPreferences::floatValueForKey): Ditto.
1770         (WebPreferences::boolValueForKey): Changed to call
1771         booleanValueForPreferencesValue.
1772         (WebPreferences::setIntegerValue): Changed to call cfNumber.
1773         (WebPreferences::setLongLongValue): Ditto.
1774
1775 2008-02-27  Adam Roben  <aroben@apple.com>
1776
1777         Add WebPreferences::setValueForKey
1778
1779         This is just a small refactoring of some duplicated logic into a
1780         shared method.
1781
1782         Reviewed by Sam.
1783
1784         * WebPreferences.cpp:
1785         (WebPreferences::setValueForKey): Added.
1786         (WebPreferences::setStringValue): Call setValueForKey.
1787         (WebPreferences::setIntegerValue): Ditto.
1788         (WebPreferences::setBoolValue): Ditto.
1789         (WebPreferences::setLongLongValue): Ditto.
1790         * WebPreferences.h:
1791
1792 2008-02-27  Adam Roben  <aroben@apple.com>
1793
1794         Remove WebPreferences' static members
1795
1796         s_defaultSettings is now a file-level static, and
1797         s_standardPreferences has been removed completely (it wasn't being
1798         used).
1799
1800         Reviewed by Sam.
1801
1802         * WebPreferences.cpp:
1803         (WebPreferences::initializeDefaultSettings):
1804         (WebPreferences::valueForKey):
1805         (WebPreferences::migrateDefaultSettingsFromSafari3Beta):
1806         (WebPreferences::removeValuesMatchingDefaultSettings):
1807         * WebPreferences.h:
1808
1809 2008-02-29  Steve Falkenburg  <sfalken@apple.com>
1810
1811         Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
1812         Found via code inspection.
1813
1814         Reviewed by Adam.
1815
1816         * WebActionPropertyBag.cpp:
1817         (WebActionPropertyBag::Write):
1818         * WebElementPropertyBag.cpp:
1819         (WebElementPropertyBag::Write):
1820
1821 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
1822
1823         Reviewed by Adam Roben.
1824
1825         Bug 14348: Messing up the inspector by dragging an URL into it
1826         http://bugs.webkit.org/show_bug.cgi?id=14348
1827         <rdar://problem/5283620> and <rdar://problem/5712808>
1828
1829         Add a new class to handle the Inspector's delegate calls.
1830
1831         * WebCoreSupport/WebInspectorClient.cpp:
1832         (WebInspectorClient::createPage):
1833         * WebCoreSupport/WebInspectorDelegate.cpp: Added.
1834         (:m_refCount):
1835         (WebInspectorDelegate::createInstance):
1836         (WebInspectorDelegate::AddRef):
1837         (WebInspectorDelegate::Release):
1838         (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
1839         * WebCoreSupport/WebInspectorDelegate.h: Added.
1840         (WebInspectorDelegate::QueryInterface):
1841         (WebInspectorDelegate::createWebViewWithRequest):
1842         (WebInspectorDelegate::webViewShow):
1843         (WebInspectorDelegate::webViewClose):
1844         (WebInspectorDelegate::webViewFocus):
1845         (WebInspectorDelegate::webViewUnfocus):
1846         (WebInspectorDelegate::webViewFirstResponder):
1847         (WebInspectorDelegate::makeFirstResponder):
1848         (WebInspectorDelegate::setStatusText):
1849         (WebInspectorDelegate::webViewStatusText):
1850         (WebInspectorDelegate::webViewAreToolbarsVisible):
1851         (WebInspectorDelegate::setToolbarsVisible):
1852         (WebInspectorDelegate::webViewIsStatusBarVisible):
1853         (WebInspectorDelegate::setStatusBarVisible):
1854         (WebInspectorDelegate::webViewIsResizable):
1855         (WebInspectorDelegate::setResizable):
1856         (WebInspectorDelegate::setFrame):
1857         (WebInspectorDelegate::webViewFrame):
1858         (WebInspectorDelegate::setContentRect):
1859         (WebInspectorDelegate::webViewContentRect):
1860         (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage):
1861         (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage):
1862         (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt):
1863         (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage):
1864         (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener):
1865         (WebInspectorDelegate::mouseDidMoveOverElement):
1866         (WebInspectorDelegate::contextMenuItemsForElement):
1867         (WebInspectorDelegate::validateUserInterfaceItem):
1868         (WebInspectorDelegate::shouldPerformAction):
1869         (WebInspectorDelegate::willPerformDragDestinationAction):
1870         (WebInspectorDelegate::dragSourceActionMaskForPoint):
1871         (WebInspectorDelegate::willPerformDragSourceAction):
1872         (WebInspectorDelegate::contextMenuItemSelected):
1873         (WebInspectorDelegate::hasCustomMenuImplementation):
1874         (WebInspectorDelegate::trackCustomPopupMenu):
1875         (WebInspectorDelegate::measureCustomMenuItem):
1876         (WebInspectorDelegate::drawCustomMenuItem):
1877         (WebInspectorDelegate::addCustomMenuDrawingData):
1878         (WebInspectorDelegate::cleanUpCustomMenuDrawingData):
1879         (WebInspectorDelegate::canTakeFocus):
1880         (WebInspectorDelegate::takeFocus):
1881         (WebInspectorDelegate::registerUndoWithTarget):
1882         (WebInspectorDelegate::removeAllActionsWithTarget):
1883         (WebInspectorDelegate::setActionTitle):
1884         (WebInspectorDelegate::undo):
1885         (WebInspectorDelegate::redo):
1886         (WebInspectorDelegate::canUndo):
1887         (WebInspectorDelegate::canRedo):
1888         * WebKit.vcproj/WebKit.vcproj:
1889
1890 2008-02-26  Adam Roben  <aroben@apple.com>
1891
1892         Move ResourceLoadDelegate methods to WebFrameLoaderClient
1893
1894         Changed all methods to use early returns where possible and COMPtr's
1895         AdoptCOM/Query constructors.
1896
1897         Reviewed by Anders.
1898
1899         * WebCoreSupport/WebFrameLoaderClient.cpp:
1900         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1901         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1902         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1903         (WebFrameLoaderClient::dispatchWillSendRequest):
1904         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1905         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1906         (WebFrameLoaderClient::dispatchDidFinishLoading):
1907         (WebFrameLoaderClient::dispatchDidFailLoading):
1908         * WebCoreSupport/WebFrameLoaderClient.h:
1909         * WebFrame.cpp:
1910         * WebFrame.h:
1911
1912 2008-02-26  Adam Roben  <aroben@apple.com>
1913
1914         Move two more methods to WebFrameLoaderClient
1915
1916         Reviewed by Anders.
1917
1918         * WebCoreSupport/WebFrameLoaderClient.cpp:
1919         (kit):
1920         (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to
1921         early returns, and changed to use the COMPtr Query constructor.
1922         (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early
1923         return, and changed to use getWebDataSource.
1924         * WebCoreSupport/WebFrameLoaderClient.h:
1925         * WebFrame.cpp:
1926         * WebFrame.h:
1927
1928 2008-02-26  Adam Roben  <aroben@apple.com>
1929
1930         Get rid of IID_WebFrame
1931
1932         Reviewed by Anders.
1933
1934         * WebFrame.cpp: Removed IID_WebFrame definition.
1935         (WebFrame::QueryInterface): Use __uuidof(WebFrame) instead of
1936         IID_WebFrame.
1937         (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor
1938         instead of a manual QueryInterface.
1939         * WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a
1940         DECLSPEC_UUID.
1941
1942 2008-02-26  Adam Roben  <aroben@apple.com>
1943
1944         Move WebHistory-related methods to WebFrameLoaderClient
1945
1946         Reviewed by Anders.
1947
1948         * WebCoreSupport/WebFrameLoaderClient.cpp:
1949         (WebFrameLoaderClient::updateGlobalHistory):
1950         (WebFrameLoaderClient::shouldGoToHistoryItem):
1951         (WebFrameLoaderClient::setTitle): Changed some nested ifs into early
1952         returns.
1953         (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to
1954         make the reference management foolproof.
1955         * WebCoreSupport/WebFrameLoaderClient.h:
1956         * WebFrame.cpp:
1957         * WebFrame.h:
1958
1959 2008-02-26  Adam Roben  <aroben@apple.com>
1960
1961         Move cache-related methods to WebFrameLoaderClient
1962
1963         Reviewed by Anders.
1964
1965         * WebCoreSupport/WebFrameLoaderClient.cpp:
1966         (getWebDataSource): Moved to the top of the file.
1967         (WebFrameLoaderClient::savePlatformDataToCachedPage):
1968         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1969         (WebFrameLoaderClient::canCachePage):
1970         * WebCoreSupport/WebFrameLoaderClient.h:
1971         * WebFrame.cpp:
1972         * WebFrame.h:
1973
1974 2008-02-25  Adam Roben  <aroben@apple.com>
1975
1976         Move plugin-related methods to WebFrameLoaderClient
1977
1978         Reviewed by Anders.
1979
1980         * WebCoreSupport/WebFrameLoaderClient.cpp:
1981         (WebFrameLoaderClient::WebFrameLoaderClient):
1982         (WebFrameLoaderClient::setMainDocumentError):
1983         (WebFrameLoaderClient::committedLoad): Added some early returns.
1984         (WebFrameLoaderClient::receivedData):
1985         (WebFrameLoaderClient::finishedLoading): Ditto.
1986         (getWebDataSource):
1987         (WebFrameLoaderClient::createPlugin):
1988         * WebCoreSupport/WebFrameLoaderClient.h:
1989         * WebFrame.cpp:
1990         (WebFrame::WebFramePrivate::WebFramePrivate):
1991         * WebFrame.h:
1992
1993 2008-02-25  Adam Roben  <aroben@apple.com>
1994
1995         Move createFrame to WebFrameLoaderClient
1996
1997         Reviewed by Anders.
1998
1999         * WebCoreSupport/WebFrameLoaderClient.cpp:
2000         (WebFrameLoaderClient::createFrame):
2001         (WebFrameLoaderClient::loadURLIntoChild):
2002         * WebCoreSupport/WebFrameLoaderClient.h:
2003         * WebFrame.cpp:
2004         * WebFrame.h:
2005
2006 2008-02-25  Adam Roben  <aroben@apple.com>
2007
2008         Move progress-related methods to WebFrameLoaderClient
2009
2010         Reviewed by Anders.
2011
2012         * WebCoreSupport/WebFrameLoaderClient.cpp:
2013         (WebFrameLoaderClient::postProgressStartedNotification):
2014         (WebFrameLoaderClient::postProgressEstimateChangedNotification):
2015         (WebFrameLoaderClient::postProgressFinishedNotification):
2016         * WebCoreSupport/WebFrameLoaderClient.h:
2017         * WebFrame.cpp:
2018         * WebFrame.h:
2019
2020 2008-02-25  Adam Roben  <aroben@apple.com>
2021
2022         Remove WebFrame::detachedFromParent1
2023
2024         This method was removed from FrameLoaderClient in r19042, but was
2025         never removed from WebFrame.
2026
2027         Reviewed by Anders.
2028
2029         * WebFrame.cpp:
2030         * WebFrame.h:
2031
2032 2008-02-23  Adam Roben  <aroben@apple.com>
2033
2034         Move many dispatch methods to WebFrameLoaderClient
2035
2036         Reviewed by Sam.
2037
2038         * WebCoreSupport/WebFrameLoaderClient.cpp:
2039         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2040         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2041         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2042         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2043         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2044         (WebFrameLoaderClient::dispatchWillClose):
2045         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2046         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2047         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2048         (WebFrameLoaderClient::dispatchDidCommitLoad):
2049         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2050         (WebFrameLoaderClient::dispatchDidFinishLoad):
2051         (WebFrameLoaderClient::dispatchDidFirstLayout):
2052         (WebFrameLoaderClient::dispatchShow):
2053         * WebCoreSupport/WebFrameLoaderClient.h:
2054         * WebFrame.cpp:
2055         * WebFrame.h:
2056
2057 2008-02-23  Adam Roben  <aroben@apple.com>
2058
2059         Move two more methods to WebFrameLoaderClient
2060
2061         Reviewed by Sam.
2062
2063         * WebCoreSupport/WebFrameLoaderClient.cpp:
2064         (WebFrameLoaderClient::hasFrameView):
2065         (WebFrame::forceLayout):
2066         * WebCoreSupport/WebFrameLoaderClient.h:
2067         * WebFrame.cpp:
2068         * WebFrame.h:
2069
2070 2008-02-24  Darin Adler  <darin@apple.com>
2071
2072         Reviewed by Sam.
2073
2074         - remove separate client calls for "standard" and "reload' history
2075
2076         * WebFrame.cpp:
2077         (WebFrame::updateGlobalHistory):
2078         * WebFrame.h:
2079
2080 2008-02-23  Brent Fulgham  <bfulgham@gmail.com>
2081
2082         Not reviewed, build fix.
2083
2084         * WebIconDatabase.cpp:
2085         * WebIconDatabase.h:
2086
2087 2008-02-22  Adam Roben  <aroben@apple.com>
2088
2089         Move hasWebView to WebFrameLoaderClient
2090
2091         I added an m_webFrame member to WebFrameLoaderClient. This is slightly
2092         strange because WebFrame inherits from WebFrameLoaderClient, but this
2093         member will be needed once we remove the inheritance, so we might as
2094         well prepare for that now.
2095
2096         Reviewed by Anders.
2097
2098         * WebCoreSupport/WebFrameLoaderClient.cpp:
2099         (WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a
2100         WebFrame* parameter.
2101         (WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
2102         * WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame
2103         parameter.
2104         * WebFrame.cpp: Removed hasWebView.
2105         (WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor
2106         change.
2107         * WebFrame.h:
2108
2109 2008-02-22  Adam Roben  <aroben@apple.com>
2110
2111         Start to move FrameLoaderClient methods off WebFrame onto a separate class
2112
2113         WebFrame now inherits from a new WebFrameLoaderClient class, which
2114         will gradually assume all FrameLoaderClient responsibilities. Once
2115         that process is complete, WebFrame will no longer inherit from
2116         WebFrameLoaderClient.
2117
2118         In this first patch, I've only moved createDocumentLoader up to the
2119         WebFrameLoaderClient class.
2120
2121         Reviewed by Anders.
2122
2123         * WebCoreSupport/WebFrameLoaderClient.cpp: Added.
2124         (WebFrameLoaderClient::WebFrameLoaderClient):
2125         (WebFrameLoaderClient::~WebFrameLoaderClient):
2126         (WebFrameLoaderClient::createDocumentLoader): Moved here from
2127         WebFrame.cpp.
2128         * WebCoreSupport/WebFrameLoaderClient.h: Added.
2129         * WebFrame.cpp: Removed createDocumentLoader implementation.
2130         * WebFrame.h: Changed to inherit from WebFrameLoaderClient.
2131         * WebKit.vcproj/WebKit.vcproj: Added new files to the project.
2132
2133 2008-02-22  Adam Roben  <aroben@apple.com>
2134
2135         Move FormValuesPropertyBag into its own files
2136
2137         Reviewed by Sam.
2138
2139         * WebCoreSupport/FormValuesPropertyBag.cpp: Added.
2140         (FormValuesPropertyBag::QueryInterface):
2141         (FormValuesPropertyBag::AddRef):
2142         (FormValuesPropertyBag::Release):
2143         (FormValuesPropertyBag::Read):
2144         (FormValuesPropertyBag::Write):
2145         (FormValuesPropertyBag::CountProperties):
2146         (FormValuesPropertyBag::GetPropertyInfo):
2147         (FormValuesPropertyBag::LoadObject):
2148         * WebCoreSupport/FormValuesPropertyBag.h: Added.
2149         (FormValuesPropertyBag::FormValuesPropertyBag):
2150         * WebFrame.cpp: Deleted FormValuesPropertyBag code.
2151         * WebKit.vcproj/WebKit.vcproj: Added new files to the project.
2152
2153 2008-02-22  Adam Roben  <aroben@apple.com>
2154
2155         Remove some unused WebFrame methods
2156
2157         FrameWinClient was deleted back in r22965, but these methods were
2158         never deleted.
2159
2160         Reviewed by Sam.
2161
2162         * WebFrame.cpp:
2163         * WebFrame.h: Made one createFrame overload protected, since it's only
2164         called internally by WebFrame.
2165
2166 2008-02-21  Adam Roben  <aroben@apple.com>
2167
2168         Move Client implementations into a WebCoreSupport directory
2169
2170         Reviewed by Anders.
2171
2172         * WebKit.vcproj/WebKit.vcproj: Updated file paths, and added
2173         WebCoreSupport directory to the include path.
2174         * WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
2175         * WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
2176         * WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
2177         * WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
2178         * WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
2179         * WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
2180         * WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
2181         * WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
2182         * WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
2183         * WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
2184
2185 2008-02-20  Sam Weinig  <sam@webkit.org>
2186
2187         Reviewed by Darin and Geoff.
2188
2189         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
2190
2191         * WebView.cpp:
2192         (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks.
2193         (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where
2194         after you disable the site-specific hacks they persist until you open a new window or tweak
2195         some other preference.
2196
2197 2008-02-19  Darin Adler  <darin@apple.com>
2198
2199         Reviewed by Sam.
2200
2201         * WebFrame.cpp:
2202         (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead
2203         of DeprecatedString.
2204
2205 2008-02-18  Steve Falkenburg  <sfalken@apple.com>
2206
2207         Make Drosera work on Vista.
2208
2209         Runtime type library registration on Vista requires use of two new call:
2210         RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
2211         HKCU.  LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.
2212
2213         Reviewed by Adam.
2214
2215         * WebKitDLL.cpp:
2216         (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number.
2217         (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
2218
2219 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
2220
2221         Reviewed by Adam.
2222
2223         Remove FindSafari's Release configuration.
2224
2225         * WebKit.vcproj/WebKit.sln:
2226
2227 2008-02-16  Alexey Proskuryakov  <ap@webkit.org>
2228
2229         Reviewed by Darin.
2230
2231         http://bugs.webkit.org/show_bug.cgi?id=17397
2232         <rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows
2233
2234         * WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.
2235
2236 2008-02-15  Darin Adler  <darin@apple.com>
2237
2238         Reviewed by Adam.
2239
2240         - quick fix for a problem causing an assertion on launch
2241
2242         * WebFrame.cpp:
2243         (WebFrame::loadData): Make an empty KURL even if the BSTR is null.
2244         Later we might want to rethink this.
2245
2246 2008-02-14  Darin Adler  <darin@apple.com>
2247
2248         - updated for WebCore KURL changes
2249
2250         * MarshallingHelpers.cpp:
2251         (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call.
2252         (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
2253         * WebContextMenuClient.cpp:
2254         (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
2255         * WebDataSource.cpp:
2256         (WebDataSource::unreachableURL): Ditto.
2257         * WebDownload.cpp:
2258         (WebDownload::init): Ditto.
2259         (WebDownload::initWithRequest): Ditto.
2260         * WebFrame.cpp:
2261         (WebFrame::loadData): Ditto.
2262         (WebFrame::loadURLIntoChild): Ditto.
2263         (WebFrame::objectContentType): Ditto.
2264         * WebResource.cpp:
2265         (WebResource::initWithData): Ditto.
2266         * WebURLResponse.cpp:
2267         (WebURLResponse::createInstance): Ditto.
2268         (WebURLResponse::initWithURL): Ditto.
2269         * WebView.cpp:
2270         (WebView::userAgentForURL): Ditto.
2271         (WebView::copyURL): Ditto.
2272         (WebView::notifyPreferencesChanged): Ditto.
2273
2274 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
2275
2276         * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to
2277         the previous check-in, fixing.
2278
2279 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
2280
2281         Reviewed by Adam Roben.
2282
2283         http://bugs.webkit.org/show_bug.cgi?id=17207
2284         Database example doesn't work (requires not-yet-released Safari)
2285
2286         * WebChromeClient.cpp:
2287         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
2288         if it's too old.
2289
2290 2008-02-13  Ada Chan  <adachan@apple.com>
2291
2292         <rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase
2293
2294         Reviewed by Darin.
2295
2296         * WebIconDatabase.cpp:
2297         (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag,
2298         which already has a ref count of 1.
2299
2300 2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>
2301
2302         Fix Bug 17220: Illogical dependency between PluginView and
2303         PluginDatabase
2304
2305         <http://bugs.webkit.org/show_bug.cgi?id=17220>
2306
2307         Reviewed by Adam and Darin.
2308
2309         Update for the rename of PluginDatabase::createPluginView
2310         to PluginView::create
2311
2312         * WebFrame.cpp:
2313
2314 2008-02-13  Adam Roben  <aroben@apple.com>
2315
2316         Windows build fix
2317
2318         * Interfaces/WebKit.idl: Create the typelib version symbol ourselves.
2319
2320 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
2321
2322         Use a precompiled header to build WebKit.
2323
2324         Reviewed by Adam.
2325
2326         * WebKit.vcproj/WebKit.vcproj:
2327         * WebKitPrefix.cpp: Added.
2328         * WebKitPrefix.h: Added.
2329
2330 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
2331
2332         Changes to support merged MIDL output.
2333
2334         All COM interfaces are now generated to WebKit.h.
2335
2336         Reviewed by Sam, Ada.
2337
2338         * DOMCSSClasses.h:
2339         * DOMCoreClasses.h:
2340         * DOMEventsClasses.h:
2341         * DOMHTMLClasses.h:
2342         * DefaultDownloadDelegate.h:
2343         * DefaultPolicyDelegate.cpp:
2344         * DefaultPolicyDelegate.h:
2345         * GEN_DOMObject.h:
2346         * Interfaces/DOMCSS.idl:
2347         * Interfaces/DOMCore.idl:
2348         * Interfaces/DOMEvents.idl:
2349         * Interfaces/DOMExtensions.idl:
2350         * Interfaces/DOMHTML.idl:
2351         * Interfaces/DOMPrivate.idl:
2352         * Interfaces/DOMRange.idl:
2353         * Interfaces/DOMWindow.idl:
2354         * Interfaces/IGEN_DOMObject.idl:
2355         * Interfaces/IWebArchive.idl:
2356         * Interfaces/IWebBackForwardList.idl:
2357         * Interfaces/IWebBackForwardListPrivate.idl:
2358         * Interfaces/IWebCache.idl:
2359         * Interfaces/IWebDataSource.idl:
2360         * Interfaces/IWebDatabaseManager.idl:
2361         * Interfaces/IWebDocument.idl:
2362         * Interfaces/IWebDownload.idl:
2363         * Interfaces/IWebEditingDelegate.idl:
2364         * Interfaces/IWebError.idl:
2365         * Interfaces/IWebErrorPrivate.idl:
2366         * Interfaces/IWebFormDelegate.idl:
2367         * Interfaces/IWebFrame.idl:
2368         * Interfaces/IWebFrameLoadDelegate.idl:
2369         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
2370         * Interfaces/IWebFramePrivate.idl:
2371         * Interfaces/IWebFrameView.idl:
2372         * Interfaces/IWebHTMLRepresentation.idl:
2373         * Interfaces/IWebHTTPURLResponse.idl:
2374         * Interfaces/IWebHistory.idl:
2375         * Interfaces/IWebHistoryItem.idl:
2376         * Interfaces/IWebHistoryItemPrivate.idl:
2377         * Interfaces/IWebIconDatabase.idl:
2378         * Interfaces/IWebInspector.idl:
2379         * Interfaces/IWebJavaScriptCollector.idl:
2380         * Interfaces/IWebKitStatistics.idl:
2381         * Interfaces/IWebMutableURLRequest.idl:
2382         * Interfaces/IWebMutableURLRequestPrivate.idl:
2383         * Interfaces/IWebNotification.idl:
2384         * Interfaces/IWebNotificationCenter.idl:
2385         * Interfaces/IWebNotificationObserver.idl:
2386         * Interfaces/IWebPolicyDelegate.idl:
2387         * Interfaces/IWebPreferences.idl:
2388         * Interfaces/IWebPreferencesPrivate.idl:
2389         * Interfaces/IWebResource.idl:
2390         * Interfaces/IWebResourceLoadDelegate.idl:
2391         * Interfaces/IWebResourceLoadDelegatePrivate.idl:
2392         * Interfaces/IWebScriptCallFrame.idl:
2393         * Interfaces/IWebScriptDebugListener.idl:
2394         * Interfaces/IWebScriptDebugServer.idl:
2395         * Interfaces/IWebScriptObject.idl:
2396         * Interfaces/IWebScriptScope.idl:
2397         * Interfaces/IWebScrollBarDelegatePrivate.idl:
2398         * Interfaces/IWebScrollBarPrivate.idl:
2399         * Interfaces/IWebSecurityOrigin.idl:
2400         * Interfaces/IWebTextRenderer.idl:
2401         * Interfaces/IWebUIDelegate.idl:
2402         * Interfaces/IWebUIDelegatePrivate.idl:
2403         * Interfaces/IWebURLAuthenticationChallenge.idl:
2404         * Interfaces/IWebURLRequest.idl:
2405         * Interfaces/IWebURLResponse.idl:
2406         * Interfaces/IWebURLResponsePrivate.idl:
2407         * Interfaces/IWebUndoManager.idl:
2408         * Interfaces/IWebUndoTarget.idl:
2409         * Interfaces/IWebView.idl:
2410         * Interfaces/IWebViewPrivate.idl:
2411         * Interfaces/WebKit.idl:
2412         * WebActionPropertyBag.cpp:
2413         * WebBackForwardList.h:
2414         * WebCache.h:
2415         * WebDataSource.cpp:
2416         * WebDataSource.h:
2417         * WebDatabaseManager.h:
2418         * WebDownload.h:
2419         * WebEditorClient.cpp:
2420         * WebEditorClient.h:
2421         * WebError.h:
2422         * WebFrame.cpp:
2423         * WebFrame.h:
2424         * WebFramePolicyListener.h:
2425         * WebHTMLRepresentation.cpp:
2426         * WebHTMLRepresentation.h:
2427         * WebHistory.cpp:
2428         * WebHistory.h:
2429         * WebHistoryItem.h:
2430         * WebIconDatabase.h:
2431         * WebInspector.h:
2432         * WebJavaScriptCollector.h:
2433         * WebKit.vcproj/Interfaces.vcproj:
2434         * WebKit.vcproj/WebKitGUID.vcproj:
2435         * WebKitDLL.cpp:
2436         * WebKitStatistics.h:
2437         * WebMutableURLRequest.cpp:
2438         * WebMutableURLRequest.h:
2439         * WebNotification.h:
2440         * WebNotificationCenter.h:
2441         * WebPreferences.h:
2442         * WebResource.h:
2443         * WebScriptCallFrame.h:
2444         * WebScriptDebugServer.cpp:
2445         * WebScriptDebugServer.h:
2446         * WebScriptDebugger.cpp:
2447         * WebScriptDebugger.h:
2448         * WebScriptObject.h:
2449         * WebScrollBar.h:
2450         * WebSecurityOrigin.h:
2451         * WebTextRenderer.h:
2452         * WebURLAuthenticationChallenge.h:
2453         * WebURLAuthenticationChallengeSender.h:
2454         * WebURLCredential.h:
2455         * WebURLProtectionSpace.h:
2456         * WebURLResponse.h:
2457         * WebView.cpp:
2458         * WebView.h:
2459
2460 2008-02-12  Anders Carlsson  <andersca@apple.com>
2461
2462         Reviewed by Adam.
2463
2464         Implement imageTitle.
2465
2466         * WebCoreLocalizedStrings.cpp:
2467         (WebCore::imageTitle):
2468
2469 2008-02-12  Anders Carlsson  <andersca@apple.com>
2470
2471         Reviewed by Mitz.
2472
2473         * WebCoreLocalizedStrings.cpp:
2474         (WebCore::imageTitle):
2475         Add stub.
2476
2477
2478 2008-02-07  Ada Chan  <adachan@apple.com>
2479
2480         <rdar://problem/5292433> certificate authentication support broken in Safari 3.0
2481         Added mechanism to communicate client certificate info back to CFNetwork.
2482
2483         Reviewed by Adam.
2484
2485         * Interfaces/IWebError.idl: Added new WebURLErrorClientCertificateRequired error.
2486         * Interfaces/IWebMutableURLRequestPrivate.idl: Added. Added method to set client
2487         certificate info on the request.
2488         * WebKit.vcproj/Interfaces.vcproj: Added new idl.
2489         * WebKit.vcproj/WebKit.vcproj: Link crypt32.lib
2490         * WebKit.vcproj/WebKitGUID.vcproj:
2491         * WebMutableURLRequest.cpp:
2492         (WebMutableURLRequest::QueryInterface): Implements IWebMutableURLRequestPrivate.
2493         (deallocCertContext): Free certificate context.
2494         (copyCert): Duplicate the certificate context and returns it in a CFDataRef.
2495         (WebMutableURLRequest::setClientCertificate):
2496         * WebMutableURLRequest.h:
2497
2498 2008-02-05  Rodney Dawes  <dobey@wayofthemonkey.com>
2499
2500         Reviewed by Anders Carlsson.
2501
2502         Part one of http://bugs.webkit.org/show_bug.cgi?id=16924.
2503         Shared PluginDatabase, PluginInfoStore and PluginPackage implementations.
2504
2505         Track WebCore renames.
2506
2507         * WebFrame.cpp:
2508         (WebFrame::createPlugin):
2509         (WebFrame::redirectDataToPlugin):
2510         (WebFrame::createJavaAppletWidget):
2511         (WebFrame::objectContentType):
2512         * WebView.cpp:
2513         (WebViewWndProc):
2514         (WebView::canShowMIMEType):
2515         (WebView::addAdditionalPluginPath):
2516
2517 2008-02-05  Alexey Proskuryakov  <ap@webkit.org>
2518
2519         Reviewed by Darin.
2520
2521         http://bugs.webkit.org/show_bug.cgi?id=15248
2522         <rdar://problem/5497032> Can not enter accented characters using alt-numeric keypad (take two)
2523
2524         * WebView.cpp: (WebViewWndProc): KeyUp messages need to be translated, too.
2525
2526 2008-02-01  Darin Adler  <darin@apple.com>
2527
2528         - fix <rdar://problem/5680469> Each database worker thread takes a JSLock,
2529           which slows down all JavaScript execution until the thread terminates
2530
2531         * WebIconDatabase.cpp:
2532         (WebIconDatabase::scheduleNotificationDelivery): Updated for new callOnMainThread.
2533         (WebIconDatabase::deliverNotifications): Ditto.
2534         * WebIconDatabase.h: Ditto.
2535
2536 2008-01-31  Adam Roben  <aroben@apple.com>
2537
2538         Fix <rdar://5713172> Focus lost from Gmail message body after toggling
2539         tabs
2540
2541         This regressed in r29583. Prior to r29583, the code path that resulted
2542         in calling focusController->setFocusedFrame(0) was never getting hit.
2543         r29583 changed the code to adhere to the comment above the code and
2544         actually call setFocusedFrame(0) when losing focus to another part of
2545         the window. It turns out this is wrong behavior (and not what
2546         WebKit/mac does). The only time we should clear the focused frame is
2547         when we tab out of the WebView, and that's already taken care of by
2548         FocusController::advanceFocus. The code to clear the focused frame in
2549         WebView was written before FocusController::advanceFocus, so it was
2550         correct at one point but no longer is.
2551
2552         We now never call setFocusedFrame(0) when the WebView receives a
2553         WM_KILLFOCUS message. Instead we just call setFocused(false) on the
2554         focused frame so that blur events will be sent. This matches what
2555         WebKit/mac does.
2556
2557         Reviewed by Darin and Adele.
2558
2559         * WebView.cpp:
2560         (WebViewWndProc): Also reworded a couple of comments to make them
2561         clearer.
2562
2563 2008-01-31  Adam Roben  <aroben@apple.com>
2564
2565         Let WebCore take care of the highlight drawing entirely
2566
2567         Reviewed by Darin.
2568
2569         * WebInspectorClient.cpp:
2570         (WebInspectorClient::highlight): We now just show our highlight
2571         window and let WebCore figure out what/where to paint. Once all ports
2572         follow suit the Node* parameter to this method should be removed
2573         entirely, and the name should probably change to
2574         updateAndShowHighlight or something similar.
2575         * WebNodeHighlight.cpp: Renamed m_webView to m_inspectedWebViewWindow.
2576         (WebNodeHighlight::WebNodeHighlight): Now takes a WebView* parameter.
2577         (WebNodeHighlight::show): Renamed from highlight(). Now gets the
2578         WebView's HWND. Updated for member rename/removal.
2579         (WebNodeHighlight::updateWindow): Updated for member rename and for
2580         InspectorController changes.
2581         * WebNodeHighlight.h: Added m_inspectedWebView member, removed m_rect
2582         member, renamed highlight(Node*) -> show().
2583
2584 2008-01-31  Adam Roben  <aroben@apple.com>
2585
2586         Move node highlight drawing code to WebCore
2587
2588         Reviewed by Darin.
2589
2590         * WebNodeHighlight.cpp:
2591         (WebNodeHighlight::updateWindow): Call into WebCore to do the node
2592         highlight drawing.
2593
2594 2008-01-29  Adam Roben  <aroben@apple.com>
2595
2596         Fix a crash when opening the Inspector
2597
2598         Reviewed by Anders.
2599
2600         * WebInspectorClient.cpp:
2601         (WebInspectorClient::createPage): Call
2602         WebPreferences::initWithIdentifier so our custom WebPreferences will
2603         have all its members initialized.
2604
2605 2008-01-29  Adam Roben  <aroben@apple.com>
2606
2607         Fix Bug 16786: "Display images when page opens" preference affects
2608         Inspector
2609
2610         <http://bugs.webkit.org/show_bug.cgi?id=16786>
2611         <rdar://5712914>
2612
2613         Reviewed by Anders and Darin.
2614
2615         * WebInspectorClient.cpp:
2616         (WebInspectorClient::createPage): Create our own custom WebPreferences
2617         so that we won't be affected by global preference changes. This
2618         matches what Mac does.
2619
2620 2008-01-29  Adam Roben  <aroben@apple.com>
2621
2622         Fix <rdar://5713302> Web Inspector on Windows is not using the
2623         localized strings
2624
2625         Reviewed by Steve.
2626
2627         * WebInspectorClient.cpp:
2628         (getWebKitBundle): Added.
2629         (WebInspectorClient::createPage): Call getWebKitBundle.
2630         (WebInspectorClient::localizedStringsURL): Implemented.
2631
2632 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
2633
2634         Reviewed by Darin.
2635
2636         <rdar://problem/5710692> All storage tests fail/crash
2637
2638         * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Clients that do not implement
2639         database quota callbacks should have no database support - but not crash.
2640
2641 2008-01-26  Steve Falkenburg  <sfalken@apple.com>
2642
2643         <rdar://problem/5707607> REGRESSION: I hear a beep when selecting Alt-enter in address or search fields
2644
2645         Reviewed by Oliver.
2646
2647         * WebView.cpp:
2648         (WebView::keyDown): Allow alt-return to be marked as handled by WebKit.
2649
2650 2008-01-24  Steve Falkenburg  <sfalken@apple.com>
2651
2652         Build fix
2653
2654         * WebKit.vcproj/WebKit.sln:
2655         * WebKit.vcproj/WebKit.submit.sln:
2656
2657 2008-01-24  Adam Roben  <aroben@apple.com>
2658
2659         Build fix
2660
2661         * WebView.cpp: Added a comma.
2662
2663 2008-01-24  Alexey Proskuryakov  <ap@webkit.org>
2664
2665         Reviewed by Adam Roben.
2666
2667         <rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari
2668
2669         * WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).
2670
2671 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
2672
2673         <rdar://problem/5698732> Copyright strings should include 2008
2674
2675         Reviewed by Sam.
2676
2677         * WebKit.vcproj/WebKit.rc:
2678
2679 2008-01-23  Adam Roben  <aroben@apple.com>
2680
2681         Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly
2682
2683         Reviewed by Hyatt.
2684
2685         * WebInspectorClient.cpp:
2686         (defaultWindowRect): Added.
2687         (WebInspectorClient::createPage):
2688             - Use defaultWindowRect() to set the initial size/position of the
2689               Inspector window.
2690             - Pass the Inspector window's client rect to
2691               IWebView::initWithFrame so that the WebView will be initially
2692               sized to fill the window.
2693         (WebInspectorClient::showWindow): Don't move/resize the window back to
2694         the defaults every time this method is called.
2695
2696 2008-01-23  Adam Roben  <aroben@apple.com>
2697
2698         Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com
2699
2700         Test: fast/events/contextmenu-scrolled-page-with-frame.html
2701
2702         Reviewed by Dan.
2703
2704         * WebView.cpp:
2705         (WebView::handleContextMenuEvent): Translate the mouse coordinates
2706         into document coordinates before performing the hit-test. This is what
2707         EventHandler does internally.
2708
2709 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
2710
2711         <rdar://problem/5699509> Allow file upload dialog to be localized.
2712
2713         Reviewed by Darin.
2714
2715         * English.lproj/Localizable.strings: Updated.
2716         * WebCoreLocalizedStrings.cpp:
2717         (WebCore::uploadFileText): Added.
2718         (WebCore::allFilesText): Added.
2719
2720 2008-01-22  Adam Roben  <aroben@apple.com>
2721
2722         Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com
2723
2724         Now that we have multiple FrameViews per Frame on Windows, we need to
2725         make sure each FrameView gets its scrolling mode set correctly. On Mac
2726         this works because WebFrameView holds the scrolling mode and a single
2727         WebFrameView is shared by many FrameViews. On Windows, we have no such
2728         shared object, so we just ask the Frame's owner element for the
2729         scrolling mode.
2730
2731         Tests: fast/frames/frame-scrolling-attribute.html
2732                fast/frames/iframe-scrolling-attribute.html
2733
2734         Reviewed by Hyatt.
2735
2736         * WebFrame.cpp:
2737         (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode
2738         on the FrameView based on the scrolling mode of the Frame's owner
2739         element.
2740
2741 2008-01-21  Darin Adler  <darin@apple.com>
2742
2743         Reviewed by John Sullivan.
2744
2745         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
2746         - fix incorrect value for WebDatabaseDisplayNameKey in header
2747
2748         * Interfaces/IWebDatabaseManager.idl: Renamed detailsForDatabaseWithOrigin to
2749         detailsForDatabase. Replaced deleteDatabasesWithOrigin with deleteOrigin.
2750         Renamed deleteDatabaseWithOrigin to deleteDatabase. Fixed incorrect value for
2751         WebDatabaseDisplayNameKey.
2752         * Interfaces/IWebPreferencesPrivate.idl: Removed defaultDatabaseQuota and
2753         setDefaultDatabaseQuota.
2754         * Interfaces/IWebUIDelegatePrivate.idl: Replaced the two database quota functions
2755         with a single one.
2756
2757         * WebChromeClient.cpp:
2758         (WebChromeClient::exceededDatabaseQuota): Replaced the two database quota functions
2759         with a single one.
2760         * WebChromeClient.h: Ditto.
2761
2762         * WebDatabaseManager.cpp:
2763         (WebDatabaseManager::detailsForDatabase): Changed to check for a name of null to
2764         detect a nonexistent database rather than using isValid.
2765         (WebDatabaseManager::deleteOrigin): Updated for name change (actually a semantic
2766         change too, but both have the same name).
2767         (WebDatabaseManager::deleteDatabase): Updated for name change.
2768         (WebKitSetWebDatabasesPathIfNecessary): Ditto.
2769
2770         * WebDatabaseManager.h: Updated for name changes.
2771
2772         * WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
2773         * WebPreferences.cpp:
2774         (WebPreferences::initializeDefaultSettings): Removed the default for
2775         WebKitDefaultDatabaseQuotaKey.
2776         * WebPreferences.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
2777         * WebView.cpp:
2778         (WebView::notifyPreferencesChanged): Removed the code to set the
2779         default database origin quota in WebCore::Settings based on IWebPreferencesPrivate.
2780
2781 2008-01-19  Mark Rowe  <mrowe@apple.com>
2782
2783         Fix inconsistent line endings and set svn:eol-style=native
2784         on IDL files that did not have it set.
2785
2786         * Interfaces/IGEN_DOMObject.idl:
2787
2788 2008-01-18  Adam Roben  <aroben@apple.com>
2789
2790         Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
2791
2792         Restored the previous behavior of IWebViewPrivate::updateActiveState,
2793         which DRT depends on, and renamed it to
2794         IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
2795         side-effects.
2796
2797         Reviewed by Adele.
2798
2799         * Interfaces/IWebViewPrivate.idl:
2800         * WebView.cpp:
2801         (WebViewWndProc): Removed some FIXMEs that we no longer want to fix
2802         because the current design is better.
2803         (WebView::updateActiveState): This is now just a method of WebView,
2804         not any of its public interfaces.
2805         (WebView::updateFocusedAndActiveState): Performs the tasks that the
2806         old IWebViewPrivate::updateActiveState performed.
2807         * WebView.h:
2808
2809 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
2810
2811         Reviewed by Adam Roben.
2812
2813         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
2814         between DRT and TestNetscapePlugin.
2815
2816         * WebKit.vcproj/WebKit.sln: Use newly added TestNetscapePlugin Debug_Internal configuration.
2817
2818 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
2819
2820         Build fix.
2821
2822         * WebKit.vcproj/WebKit.make:
2823
2824 2008-01-16  Adam Roben  <aroben@apple.com>
2825
2826         Trigger activation changes at the right time by listening for WM_NCACTIVATE
2827
2828         This is the final part of <rdar://5006915> Inactive look for Aqua
2829         controls
2830
2831         WebView now listens to messages sent to its top-level parent window.
2832         When the top-level parent receives a WM_NCACTIVATE message, WebView
2833         recalculates whether it is contained within the current active window.
2834
2835         Reviewed by Darin.
2836
2837         * Interfaces/IWebViewPrivate.idl:
2838         (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients
2839         should call this when they change the parent window chain of a
2840         WebView.
2841         * WebView.cpp:
2842         (WebView::WebView): Initialize new member.
2843         (findTopLevelParent): Added.
2844         (WebViewWndProc):
2845             - Separated activation handling from focus handling, now that
2846               activation handling is taken care of by updateActiveState
2847               exclusively.
2848             - Compare top-level parents in our WM_KILLFOCUS handler so that we
2849               really know if focus is staying inside our top-level window.
2850             - Update our active state on WM_WINDOWPOSCHANGED.
2851             - Added a WM_TIMER handler.
2852         (WebView::initWithFrame): Call windowAncestryDidChange after setting
2853         up our HWND as a child of the host window.
2854         (WebView::windowReceivedMessage): Added. Update our active state when
2855         our top-level parent receives a WM_NCACTIVATE message.
2856         (WebView::updateActiveStateSoon): Added.
2857         (WebView::setHostWindow): Call windowAncestryDidChange after changing
2858         the host window.
2859         (WebView::updateActiveState): We are active if our top-level parent is
2860         the same as the top-level parent of the active window.
2861         (WebView::windowAncestryDidChange): Added. Recalculates our top-level
2862         parent and registers as a listener for the new top-level parent's
2863         messages.
2864         * WebView.h: Made WebView and WindowMessageListener so that it can
2865         utilize WindowMessageBroadcaster to listen to its top-level parent's
2866         messages.
2867
2868 2008-01-16  Adam Roben  <aroben@apple.com>
2869
2870         Updated for ScrollBarClient changes
2871
2872         Reviewed by Darin.
2873
2874         * WebScrollBar.h:
2875         (WebScrollBar::isActive): Added.
2876
2877 2008-01-16  Adam Roben  <aroben@apple.com>
2878
2879         Updated for changes to WebCore methods
2880
2881         Focus and active state are now handled (somewhat) separately. Future
2882         patches will further separate these concepts.
2883
2884         Reviewed by Darin.
2885
2886         * WebView.cpp:
2887         (WebViewWndProc): Updated for method renames.
2888         (WebView::updateActiveState): Only change the active state here. Focus
2889         is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.
2890
2891 2008-01-16  Steve Falkenburg  <sfalken@apple.com>
2892
2893         <rdar://problem/5097419> Cursor flickers when over window resizer
2894
2895         Reviewed by Sam.
2896
2897         * WebView.cpp:
2898         (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.
2899
2900 2008-01-15  Steve Falkenburg  <sfalken@apple.com>
2901
2902         <rdar://problem/5663888> Cannot type into a JavaScript prompt created from a timer
2903
2904         Allow nested timers from javascript prompts to allow for WebView-based edit fields.
2905
2906         Reviewed by Darin.
2907
2908         * WebChromeClient.cpp:
2909         (WebChromeClient::runJavaScriptPrompt):
2910
2911 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
2912
2913         Use shared vsprops for most vcproj properties.
2914
2915         Reviewed by Darin.
2916
2917         * WebKit.vcproj/Interfaces.vcproj:
2918         * WebKit.vcproj/WebKit.vcproj:
2919         * WebKit.vcproj/WebKitGUID.vcproj: Add missing Debug_Internal config.
2920
2921 2008-01-11  Steve Falkenburg  <sfalken@apple.com>
2922
2923         Share common files across projects.
2924
2925         Unify vsprops files
2926         Debug:          common.vsprops, debug.vsprops
2927         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
2928         Release:        common.vsprops, release.vsprops
2929
2930         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
2931         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
2932
2933         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
2934
2935         Reviewed by Adam Roben.
2936
2937         * WebKit.vcproj/Interfaces.vcproj:
2938         * WebKit.vcproj/PRODUCTVERSION: Removed.
2939         * WebKit.vcproj/VERSION: Removed.
2940         * WebKit.vcproj/WebKit.vcproj:
2941         * WebKit.vcproj/WebKitGUID.vcproj:
2942         * WebKit.vcproj/auto-version.sh: Removed.
2943         * WebKit.vcproj/debug.vsprops: Removed.
2944         * WebKit.vcproj/debug_internal.vsprops: Removed.
2945         * WebKit.vcproj/release.vsprops: Removed.
2946
2947 2008-01-11  Adam Roben  <aroben@apple.com>
2948
2949         Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout
2950
2951         <http://bugs.webkit.org/show_bug.cgi?id=16828>
2952         <rdar://5682402>
2953
2954         Now that we have 1) a real loader and 2) multiple FrameViews per
2955         Frame, we no longer need the hackery we had in our WM_PAINT handler
2956         that decided whether or not to paint. We now always want to paint,
2957         letting the swapping of FrameViews that happens in
2958         transitionToCommittedForNewPage handle which document gets painted.
2959
2960         Reviewed by Hyatt.
2961
2962         * WebView.cpp:
2963         (WebViewWndProc): Removed hackery that decided sometimes not to paint.
2964
2965 2008-01-11  Mark Rowe  <mrowe@apple.com>
2966
2967         Windows build fix.  Update to match method name in WebCore.
2968
2969         * WebJavaScriptCollector.cpp:
2970         (WebJavaScriptCollector::collectOnAlternateThread):
2971
2972 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
2973
2974         Reviewed by John Sullivan.
2975
2976         Updated for transition away from JavaScriptStatistics, which is gone now.
2977
2978         * WebJavaScriptCollector.cpp:
2979         (WebJavaScriptCollector::collect):
2980         (WebJavaScriptCollector::collectOnAlternateThread):
2981         (WebJavaScriptCollector::objectCount):
2982
2983 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
2984
2985         Not reviewed, build fix.
2986
2987         - more build fixing
2988
2989         * WebDatabaseManager.cpp:
2990         * WebSecurityOrigin.h:
2991
2992 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
2993
2994         Not reviewed, build fix.
2995
2996         - try to fix build
2997
2998         * WebDatabaseManager.cpp:
2999         (WebDatabaseManager::databasesWithOrigin):
3000         * WebSecurityOrigin.h:
3001
3002 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
3003
3004         Reviewed by Sam.
3005
3006         - remove SecurityOriginData and fold its functionality into SecurityOrigin
3007
3008         * WebChromeClient.cpp:
3009         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
3010         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
3011         * WebChromeClient.h:
3012         * WebDatabaseManager.cpp:
3013         (WebDatabaseManager::origins):
3014         (WebDatabaseManager::databasesWithOrigin):
3015         (WebDatabaseManager::detailsForDatabaseWithOrigin):
3016         (WebDatabaseManager::deleteDatabasesWithOrigin):
3017         (WebDatabaseManager::deleteDatabaseWithOrigin):
3018         (WebDatabaseManager::dispatchDidModifyOrigin):
3019         (WebDatabaseManager::dispatchDidModifyDatabase):
3020         * WebDatabaseManager.h:
3021         * WebSecurityOrigin.cpp:
3022         (WebSecurityOrigin::createInstance):
3023         (WebSecurityOrigin::WebSecurityOrigin):
3024         (WebSecurityOrigin::protocol):
3025         (WebSecurityOrigin::domain):
3026         (WebSecurityOrigin::port):
3027         (WebSecurityOrigin::usage):
3028         (WebSecurityOrigin::quota):
3029         (WebSecurityOrigin::setQuota):
3030         * WebSecurityOrigin.h:
3031
3032 2008-01-10  David Kilzer  <ddkilzer@apple.com>
3033
3034         dftables should be rewritten as a script
3035
3036         <http://bugs.webkit.org/show_bug.cgi?id=16818>
3037         <rdar://problem/5681463>
3038
3039         Reviewed by Darin.
3040
3041         * WebKit.vcproj/WebKit.sln: Removed reference to dftables project.
3042
3043 2008-01-10  Adam Roben  <aroben@apple.com>
3044
3045         Fix many bugs by giving Windows one FrameView per page load
3046
3047         Bugs include:
3048             <rdar://5659200>
3049                 Windows back/forward cache causes crashes in the layout tests
3050             <rdar://5659355>
3051             <http://bugs.webkit.org/show_bug.cgi?id=16808>
3052                 REGRESSION: PLT broken on Windows due to back/forward cache
3053             <rdar://5663654>
3054             <http://bugs.webkit.org/show_bug.cgi?id=16607>
3055                 Random crashes in FrameView::scheduleRelayout while surfing
3056                 Thinkgeek
3057
3058         On Windows until now we've only had one FrameView per Frame. Once the
3059         back/forward cache was turned on this started causing assertions to
3060         fail and crashes to occur due to a single FrameView being both in the
3061         back/forward cache (possibly multiple times!) and used by a live
3062         document. We now create a new FrameView for each page load, just as
3063         Mac does.
3064
3065         This has the side-effect of plugging some of the world leaks seen at
3066         the end of the PLT.
3067
3068         Reviewed by Hyatt.
3069
3070         * WebFrame.cpp:
3071         (WebFrame::initWithWebFrameView): Don't create the FrameView right
3072         away -- it'll be created when the load is committed.
3073         (WebFrame::transitionToCommittedFromCachedPage): Match the Mac by no
3074         longer calling resetMultipleFormSubmissionProtection here.
3075         (WebFrame::transitionToCommittedForNewPage): Ported code from
3076         -[WebCoreFrameBridge
3077         createFrameViewWithNSView:marginWidth:marginHeight:],
3078         -[WebCoreFrameBridge installInFrame:], and moved code here from
3079         WebFrame::initWithWebFrameView and WebView::initWithFrame. WebCore
3080         takes care of resetMultipleFormSubmissionProtection, just like it does
3081         on the Mac.
3082         * WebView.cpp:
3083         (WebView::initWithFrame): Moved FrameView initialization code to
3084         WebFrame::transitionToCommittedForNewPage.
3085
3086 2008-01-09  Ada Chan  <adachan@apple.com>
3087
3088         Fix crash that could happen if the key we are passing to the HashMap is 0 in WebView::interpretKeyEvent().
3089
3090         Reviewed by Darin.
3091
3092         * WebView.cpp:
3093         (WebView::interpretKeyEvent):
3094
3095 2008-01-08  Steve Falkenburg  <sfalken@apple.com>
3096
3097         Fix build.
3098
3099         * DOMCoreClasses.cpp:
3100
3101 2008-01-07  Antti Koivisto  <antti@apple.com>
3102
3103         Try to fix the Windows build.
3104
3105         * WebKit.vcproj/WebKit.sln:
3106
3107 2008-01-07  Antti Koivisto  <antti@apple.com>
3108
3109         Reviewed by Steve.
3110
3111         Re-enable media support in Windows build.
3112
3113         * WebKit.vcproj/WebKit.vcproj:
3114
3115 2008-01-07  Steve Falkenburg  <sfalken@apple.com>
3116
3117         Build fix.
3118
3119         * WebKit.vcproj/InterfacesGenerated.vcproj:
3120
3121 2008-01-07  Dan Bernstein  <mitz@apple.com>
3122
3123         Reviewed by Dave Hyatt.
3124
3125         - <rdar://problem/5665216> Support the unicode-range property in @font-face rules
3126
3127         * WebView.cpp:
3128         (WebView::setShouldApplyMacFontAscentHack):
3129
3130 2008-01-07  Holger Freyther  <zecke@selfish.org>
3131
3132         Reviewed by Alp Toker.
3133
3134         * Qt and Gtk must know if a ContextMenuItem is checkable. Add a new ContextMenuItemType for checkable
3135         actions.
3136         * Use this information in the Gtk platform to create a GtkCheckMenuItem when needed.
3137         * Update the ContextMenuController to accept CheckableActionTypes as well.
3138         * Change ContextMenu.cpp to use the CheckableActionType. The information if a item is checkable
3139         was extracted from ContextMenu::checkOrEnableIfNeeded.
3140         * Update the Qt and Windows port.
3141
3142         * WebContextMenuClient.cpp:
3143
3144 2008-01-04  Alexey Proskuryakov  <ap@webkit.org>
3145
3146         Reviewed by Adam Roben.
3147
3148         http://bugs.webkit.org/show_bug.cgi?id=16733
3149         REGRESSION: Crash on Safari Start
3150
3151         * Interfaces/IWebViewPrivate.idl: Should have added a new method at the end.
3152
3153 2008-01-04  Alexey Proskuryakov  <ap@webkit.org>
3154
3155         Reviewed by Darin.
3156
3157         <rdar://problem/5611712> xsl:sort does not use a case folding sort, and the 'case-order' attribute is ignored (16077)
3158
3159         * WebKit.vcproj/WebKit.vcproj: Link to icuin{_debug}.lib
3160
3161 2008-01-04  Adam Roben  <aroben@apple.com>
3162
3163         Fix <rdar://4968855> Shift-PageUp/Shift-PageDown only select one line of text
3164
3165         Test: platform/win/editing/selection/shift-page-down-up.html
3166
3167         Reviewed by Oliver.
3168
3169         * WebView.cpp: Correct the commands associated with
3170         Shift-PageUp/Shift-PageDown.
3171
3172 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
3173
3174         Reviewed by Darin.
3175
3176         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
3177
3178         * Interfaces/IWebViewPrivate.idl:
3179         * WebView.cpp:
3180         (WebView::executeCoreCommandByName):
3181         * WebView.h:
3182         Added an SPI to implement layoutTestController.execCommand.
3183
3184 2008-01-03  Ada Chan  <adachan@apple.com>
3185
3186         Replaced the use of editor command "ForwardDelete" with "DeleteForward" to be consistent
3187         with our use of "DeleteBackward".
3188
3189         Rubber-stamped by Jon.
3190
3191         * WebView.cpp:
3192
3193 2008-01-03  Ada Chan  <adachan@apple.com>
3194
3195         Regression: backspace stopped working on text inputs
3196         - Replaced the use of editor command "BackwardDelete" with "DeleteBackward" since it's no longer supported.
3197
3198         Reviewed by Adam.
3199
3200         * WebEditorClient.cpp:
3201         (WebEditorClient::textWillBeDeletedInTextField):
3202         * WebView.cpp:
3203
3204 2008-01-02  Alice Liu  <alice.liu@apple.com>
3205
3206         Reviewed by Maciej.
3207
3208         Fixed <rdar://5283861> (problems scrolling in gmail message content area)
3209
3210         * WebView.cpp:
3211         (WebView::keyDown):
3212         bubble scrolling from a key event
3213
3214 2008-01-01  Matt Lilek  <webkit@mattlilek.com>
3215
3216         Attempt to fix the Windows bots until the bots
3217         can get the Quicktime SDK installed.
3218
3219         * WebKit.vcproj/WebKit.sln:
3220         * WebKit.vcproj/WebKit.vcproj:
3221
3222 2007-12-30  Matt Lilek  <webkit@mattlilek.com>
3223
3224         Reviewed by Darin.
3225
3226         Bug 16578: Windows Web Inspector window needs minimum size
3227         http://bugs.webkit.org/show_bug.cgi?id=16578
3228
3229         * WebInspectorClient.cpp:
3230         (WebInspectorClient::onGetMinMaxInfo):
3231         (WebInspectorWndProc):
3232         * WebInspectorClient.h:
3233
3234 2007-12-21  Antti Koivisto  <antti@apple.com>
3235
3236         Reviewed by Steve.
3237
3238         Build media support on Windows.
3239
3240         * WebKit.vcproj/WebKit.sln:
3241         * WebKit.vcproj/WebKit.vcproj:
3242
3243 2007-12-21  Ada Chan  <adachan@apple.com>
3244
3245         Implemented DOMDocument::getElementById().
3246
3247         Reviewed by Darin.
3248
3249         * DOMCoreClasses.cpp:
3250         (DOMDocument::getElementById):
3251
3252 2007-12-21  Alexey Proskuryakov  <ap@webkit.org>
3253
3254         Reviewed by Steve and Darin.
3255
3256         <rdar://problem/5497037> Win32: Accelerator keys (ctrl-x,c,v,w,q,etc) only fire keyUp,
3257         keyDown/Press consumed by accelerator table (14104)
3258
3259         <rdar://problem/5346299> preventing default behavior for key down does not block accelerators like Ctrl+N
3260
3261         This is WebKit part of a fix, most of which will be in Safari.
3262
3263         * WebView.cpp:
3264         (WebViewWndProc): Return our result for WM_(SYS)KEYDOWN to let the client know whether
3265         further procesing is desired.
3266
3267 2007-12-21  Alexey Proskuryakov  <ap@webkit.org>
3268
3269         Build fix: cannot use framework-style include for ProgIDMacros.h,
3270         because the file is only created on a later step.
3271
3272         * ForEachCoClass.h:
3273
3274 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
3275
3276         Reviewed by Steve.
3277
3278         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
3279         WebKit.
3280
3281         - Drosera and Safari need to use the same ProgIDs in order for
3282         CoCreateInstance to work properly.  The most robust way to do this is
3283         for WebKit to dynamically publish those ProgIDs.
3284
3285         * ForEachCoClass.cpp: Added.
3286         (setUseOpenSourceWebKit):
3287         (progIDForClass):
3288         * ForEachCoClass.h: Added functionality to publish ProgIDs.
3289         * WebKit.vcproj/WebKit.def: Exposed added functions for applications.
3290         * WebKit.vcproj/WebKit.vcproj: Added ForEachCoClass.cpp
3291         * WebKit.vcproj/WebKit_debug.def: Exposed added functions fori
3292         applications.
3293
3294 2007-12-19  Dave Hyatt <hyatt@apple.com>
3295
3296         Add a fourth preference value for GDI text in the font smoothing prefs.
3297
3298         Reviewed by mitz
3299
3300         * Interfaces/IWebPreferences.idl:
3301         * WebPreferenceKeysPrivate.h:
3302         * WebPreferences.cpp:
3303         (WebPreferences::initializeDefaultSettings):
3304         (WebPreferences::fontSmoothing):
3305         (WebPreferences::setFontSmoothing):
3306         * WebView.cpp:
3307         (WebView::notifyPreferencesChanged):
3308
3309 2007-12-17  Darin Adler  <darin@apple.com>
3310
3311         Reviewed by Sam.
3312
3313         - <rdar://4516170> Back/Forward Cache on Windows
3314
3315         * WebFrame.cpp:
3316         (WebFrame::forceLayout): Implemented this. Just calling through to
3317         Frame::forceLayout matches the Mac pretty well and should be enough
3318         for now. Without this we won't repaint the new page when we go back
3319         and forward.
3320         (WebFrame::dispatchWillSubmitForm): Use COMPtr's AdoptCOM constructor
3321         instead of the adoptRef function.
3322         (WebFrame::restoreViewState): Removed unneeded notImplemented() call.
3323         This is implemented as much as it needs to be.
3324         (WebFrame::shouldGoToHistoryItem): Ditto.
3325         (WebFrame::saveViewStateToItem): Ditto.
3326         (WebFrame::canCachePage): Ditto, also changed it to return true. This
3327         is what was preventing the back/forward cache from running, and there's
3328         no need for any additional checks in the Windows version.
3329
3330         * WebView.cpp:
3331         (PreferencesChangedOrRemovedObserver::onNotify): Fix backwards null check
3332         that was preventing this notification from ever being sent, which in turn
3333         meant that page cache had a capacity of 0.
3334         (WebView::initWithFrame): Removed unneeded setUsesPageCache(false) code.
3335         This actually was ineffective and ended up doing no harm, but we don't
3336         need it.
3337
3338 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
3339
3340         Reviewed by Darin.
3341
3342         http://bugs.webkit.org/show_bug.cgi?id=16462
3343         REGRESSION: access keys broken on Windows
3344
3345         * WebView.cpp: (WebView::keyPress): Handle system key presses as access keys.
3346
3347 2007-12-15  Alexey Proskuryakov  <ap@webkit.org>
3348
3349         Reviewed by Maciej.
3350
3351         http://bugs.webkit.org/show_bug.cgi?id=16436
3352         Alt+Space works incorrectly
3353
3354         Test: platform/win/fast/events/alt-space-scroll.html
3355
3356         * WebView.cpp:
3357         (WebView::keyDown):
3358         (WebView::keyPress):
3359         We do not handle WM_SYSCHAR events.
3360
3361 2007-12-14  Dan Bernstein  <mitz@apple.com>
3362
3363         - yet another build fix
3364
3365         * DOMHTMLClasses.cpp:
3366         (DOMHTMLDocument::URL):
3367
3368 2007-12-14  Dan Bernstein  <mitz@apple.com>
3369
3370         - build fix
3371
3372         * WebIconDatabase.h:
3373
3374 2007-12-14  Darin Adler  <darin@apple.com>
3375
3376         Reviewed by Adele.
3377
3378         - http://bugs.webkit.org/show_bug.cgi?id=16443
3379           implement some missing Windows WebKit functions
3380
3381         * DOMHTMLClasses.cpp:
3382         (DOMHTMLDocument::URL): Implemented.
3383
3384         * WebActionPropertyBag.cpp:
3385         (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.
3386
3387 2007-12-14  Darin Adler  <darin@apple.com>
3388
3389         Reviewed by Alexey.
3390
3391         * WebView.cpp:
3392         (WebView::execCommand): Switched from Editor::execCommand to Editor:command.
3393         Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from
3394         MoveDownByPageAndModifyCaret to MovePageDown.
3395         (WebView::copy): Switched from Editor::execCommand to Editor:command.
3396         (WebView::cut): Ditto.
3397         (WebView::paste): Ditto.
3398         (WebView::delete_): Ditto.
3399
3400 2007-12-13  Steve Falkenburg  <sfalken@apple.com>
3401
3402         Move source file generation into its own vcproj to fix build dependencies.
3403
3404         Reviewed by Adam.
3405
3406         * WebKit.vcproj/Interfaces.vcproj:
3407         * WebKit.vcproj/InterfacesGenerated.vcproj: Added.
3408         * WebKit.vcproj/WebKit.sln:
3409         * WebKit.vcproj/WebKit.submit.sln:
3410         * WebKit.vcproj/build-generated-files.sh:
3411
3412 2007-12-13  Adam Roben  <aroben@apple.com>
3413
3414         Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
3415
3416         Reviewed by Anders.
3417
3418         * WebView.cpp:
3419         (WebViewWndProc): Repost paint messages and ignore all other messages
3420         when we're calling a plugin.
3421
3422 2007-12-13  Steve Falkenburg  <sfalken@apple.com>
3423
3424         Fix project dependencies based on JavaScriptCore change.
3425
3426         * WebKit.vcproj/WebKit.sln:
3427
3428 2007-12-13  Alexey Proskuryakov  <ap@webkit.org>
3429
3430         Reviewed by Adele.
3431
3432         http://bugs.webkit.org/show_bug.cgi?id=16421
3433         REGRESSION(r28669): Page scrolls down when you hit space key in text area
3434
3435         Test: fast/events/space-scroll-event.html
3436
3437         * WebView.cpp:
3438         (WebView::keyDown):
3439         (WebView::keyPress):
3440         Moved space handling to keyPress() to fix this bug and to match IE. Scrolling via arrow keys is correctly handled
3441         in keyDown().
3442
3443 2007-12-12  Brady Eidson  <beidson@apple.com>
3444
3445         Reviewed by Sam Weinig
3446
3447         Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
3448
3449         Even though this new code isn't exercised yet because the page cache is still turned off for Windows, local testing
3450         has indicated it works well.
3451
3452         * WebCachedPagePlatformData.h: Added.
3453         (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes an IWebDataSource and the object retains it
3454         (WebCachedPagePlatformData::clear):
3455         (WebCachedPagePlatformData::webDataSource):
3456
3457         * WebFrame.cpp:
3458         (WebFrame::savePlatformDataToCachedPage):
3459         (WebFrame::transitionToCommittedFromCachedPage):
3460         (WebFrame::transitionToCommittedForNewPage):
3461         * WebFrame.h:
3462
3463         * WebKit.vcproj/WebKit.vcproj:
3464
3465 2007-12-12  Steve Falkenburg  <sfalken@apple.com>
3466
3467         Build fix.
3468
3469         * WebKit.vcproj/WebKit.make: Copy only what we need out of obj/bin.
3470
3471 2007-12-12  Dan Bernstein  <mitz@apple.com>
3472
3473         Reviewed by Darin Adler.
3474
3475         - revert my earlier crash fix after making WebCore return the empty
3476           editor command for the empty command name.
3477
3478         * WebView.cpp:
3479         (WebView::handleEditingKeyboardEvent):
3480
3481 2007-12-12  Oliver Hunt  <oliver@apple.com>
3482
3483         Reviewed by Maciej.
3484
3485         <rdar://problem/5071781> window.mouseout events are not
3486         sent to window when mouse moves out of window
3487
3488         Hook up the windows mouse tracking logic to allow us to
3489         detect the mouse leaving the window.
3490
3491         * WebView.cpp:
3492         (WebView::close):
3493         (WebView::handleMouseEvent):
3494         (WebViewWndProc):
3495         * WebView.h:
3496
3497 2007-12-12  Dan Bernstein  <mitz@apple.com>
3498
3499         Reviewed by Alexey Proskuryakov.
3500
3501         - fix a crash when pressing a key that is not associated with a command
3502
3503         * WebView.cpp:
3504         (WebView::handleEditingKeyboardEvent): Check if the result of
3505         interpretKeyEvent() is empty.
3506
3507 2007-12-11  Sam Weinig  <sam@webkit.org>
3508
3509         Reviewed by Darin Adler.
3510
3511         Scrub URL out of the tree in preparation for renaming KURL to URL.
3512
3513         * WebFrame.cpp:
3514         (WebFrame::url):
3515         (WebFrame::dispatchWillPerformClientRedirect):
3516         (WebFrame::setTitle):
3517         (WebFrame::updateGlobalHistoryForStandardLoad):
3518         (WebFrame::updateGlobalHistoryForReload):
3519         (WebFrame::cancelledError):
3520         (WebFrame::blockedError):
3521         (WebFrame::interruptForPolicyChangeError):
3522         (WebFrame::createPlugin):
3523         * WebView.cpp:
3524         (WebView::notifyDidAddIcon):
3525
3526 2007-12-10  Anders Carlsson  <andersca@apple.com>
3527
3528         Reviewed by Darin.
3529
3530         <rdar://problem/5636865>
3531         WebKit needs API to allow registering a protocol as local (RSS feeds appear unstyled)
3532
3533         * Interfaces/IWebView.idl:
3534         * WebView.cpp:
3535         (WebView::registerURLSchemeAsLocal):
3536         * WebView.h:
3537
3538 2007-12-11  Ada Chan  <adachan@apple.com>
3539
3540         Updated the database SPI to take in IWebFrame.
3541
3542         Reviewed by Adam.
3543
3544         * Interfaces/IWebUIDelegatePrivate.idl:
3545         * WebChromeClient.cpp:
3546         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
3547         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
3548
3549 2007-12-11  Alexey Proskuryakov  <ap@webkit.org>
3550
3551         Windows build fix.
3552
3553         * WebView.cpp:
3554         (WebView::interpretKeyEvent):
3555
3556 2007-12-11  Darin Adler  <darin@apple.com>
3557
3558         * WebView.cpp:
3559         (WebView::handleEditingKeyboardEvent): Update for change to Editor API.
3560
3561 2007-12-11  Alexey Proskuryakov  <ap@webkit.org>
3562
3563         Reviewed by Darin.
3564
3565         <rdar://problem/5535636>
3566         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
3567
3568         http://bugs.webkit.org/show_bug.cgi?id=13916
3569         JavaScript detects Tab as a character input on a textfield validation
3570
3571         Listen to WM_CHAR messages, and actually pass the type of message received down to WebCore.
3572         Since WM_KEYDOWN == keydown and WM_CHAR == keypress, this allows for much better IE compatibility
3573         than layering Windows keyboard event handling on top of Mac one.
3574
3575         * WebView.cpp:
3576         (WebView::keyUp): Do not special case Alt+F4 and Alt+Space - we don't get keyups for those anyway!
3577         (WebView::interpretKeyEvent): Renamed WindowsKeyCode() to windowsVirtualKeyCode().
3578         (WebView::handleEditingKeyboardEvent): Use the additional information about event type that
3579         we now pass with PlatformKeyboardEvent.
3580         (WebView::keyDown): (WebView::keyPress): Split WM_KEYDOWN and WM_CHAR handling in separate
3581         functions, pass them down as is, without trying to guess what WM_CHAR Windows would have sent
3582         for a given WM_KEYDOWN.
3583
3584         (WebViewWndProc): Handle WM_CHAR and WM_SYSCHAR.
3585
3586         * WebView.h: Removed inIMEKeyDown() - it doesn't look like we need it at all. At least, I didn't
3587         notice any regressions after removing the only call to it in WebEditorClient.
3588
3589         * WebEditorClient.cpp:
3590         (WebEditorClient::handleKeyboardEvent):
3591         (WebEditorClient::handleInputMethodKeydown):
3592         * WebEditorClient.h:
3593         Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
3594         Renamed handleInputMethodKeypress() to handleInputMethodKeydown() and removed
3595         inIMEKeyDown()-related code.
3596
3597 2007-12-10  Geoffrey Garen  <ggaren@apple.com>
3598
3599         Reviewed by Sam Weinig.
3600
3601         Updated for rename in JavaScriptCore.
3602
3603         * WebScriptCallFrame.cpp:
3604         (WebScriptCallFrame::functionName):
3605         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
3606
3607 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3608
3609         Fix version parsing.
3610
3611         Rubber-stamped by Oliver.
3612
3613         * WebKit.vcproj/auto-version.sh:
3614
3615 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3616
3617         Fix build.
3618
3619         * WebKit.vcproj/WebKit.vcproj:
3620         * WebScriptCallFrame.cpp:
3621
3622 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3623
3624         Fix build.
3625
3626         * WebHistory.cpp:
3627         (_WebCoreHistoryProvider::containsURL):
3628
3629 2007-12-07  Geoffrey Garen  <ggaren@apple.com>
3630
3631         Tried to fix build by suppressing warning.
3632
3633         * WebScriptCallFrame.cpp:
3634
3635 2007-12-07  Darin Adler  <darin@apple.com>
3636
3637         Reviewed by Mitz.
3638
3639         - http://bugs.webkit.org/show_bug.cgi?id=15981
3640           speed up visited-link code a bit
3641
3642         * WebHistory.cpp: Removed unused Latin-1 code path.
3643         (_WebCoreHistoryProvider::containsItem): Updated for function name change.
3644
3645 2007-12-07  Steve Falkenburg  <sfalken@apple.com>