Turn on static code analysis.
[WebKit-https.git] / WebKit / win / ChangeLog
1 2007-06-27  Steve Falkenburg  <set EMAIL_ADDRESS environment variable>
2
3         Turn on static code analysis.
4
5         Reviewed by Oliver.
6         
7         Effects only folks that have Visual Studio Team Suite installed,
8         or who have replaced their compiler with the version shipping in the
9         Vista SDK.
10
11         * CodeAnalysisConfig.h: Added.
12         * WebKit.vcproj/WebKit.vcproj:
13         * WebLocalizableStrings.cpp:
14         (createWebKitBundle):
15
16 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
17
18         Prefast: Remove variable redefinitions in inner scopes.
19         
20         Reviewed by Ada.
21
22         * WebDownload.cpp:
23         (WebDownload::didFinish):
24         * WebNotificationCenter.cpp:
25         (WebNotificationCenter::postNotificationInternal):
26         (WebNotificationCenter::removeObserver):
27
28 2007-06-27  Steve Falkenburg  <sfaken@apple.com>
29
30         Remove SEH block from around history plist read, since the underlying bug has been fixed.
31         
32         Reviewed by Darin.
33
34         * WebHistory.cpp:
35         (createHistoryListFromStream):
36
37 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
38
39         Prefast: Fix misplaced parenthesis.
40         
41         Reviewed by Darin.
42
43         * WebView.cpp:
44         (core):
45
46 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
47
48         Prefast: Add null check prior to writing into allocated BSTR.
49         
50         Reviewed by Darin.
51
52         * MarshallingHelpers.cpp:
53         (MarshallingHelpers::CFStringRefToBSTR):
54
55 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
56
57         Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
58
59         Reviewed by Sam, Darin.
60                 
61         Allocation failure will result in a null dereference in this case,
62         so it isn't exploitable.
63
64         * DefaultDownloadDelegate.cpp:
65         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
66
67 2007-06-20  Adam Roben  <aroben@apple.com>
68
69         Land the new Inspector.
70
71         Co-written with Tim Hatcher.
72
73         Reviewed by Anders, Adele, Hyatt, and Sam.
74
75         Implement the InspectorClient interface.
76
77         * WebInspectorClient.cpp: Added.
78         (WebInspectorClient::WebInspectorClient):
79         (WebInspectorClient::~WebInspectorClient):
80         (WebInspectorClient::inspectorDestroyed):
81         (WebInspectorClient::createPage):
82         (WebInspectorClient::showWindow):
83         (WebInspectorClient::closeWindow):
84         (WebInspectorClient::windowVisible):
85         (WebInspectorClient::attachWindow):
86         (WebInspectorClient::detachWindow):
87         (WebInspectorClient::highlight):
88         (WebInspectorClient::hideHighlight):
89         (WebInspectorClient::inspectedURLChanged):
90         (WebInspectorClient::updateWindowTitle):
91         (WebInspectorClient::onSize):
92         (WebInspectorClient::onClose):
93         (WebInspectorClient::onWebViewWindowPosChanging):
94         (WebInspectorWndProc):
95         (SubclassedWebViewWndProc):
96         (registerWindowClass):
97         * WebInspectorClient.h: Added.
98
99         Add an easier-to-see highlight.
100
101         * WebNodeHighlight.cpp: Added.
102         (WebNodeHighlight::WebNodeHighlight):
103         (WebNodeHighlight::~WebNodeHighlight):
104         (WebNodeHighlight::highlight):
105         (WebNodeHighlight::hide):
106         (WebNodeHighlight::visible):
107         (WebNodeHighlight::updateWindow):
108         (WebNodeHighlight::removeSubclass):
109         (registerOverlayClass):
110         (OverlayWndProc):
111         (SubclassedWndProc):
112         * WebNodeHighlight.h: Added.
113
114         WebView changes needed for the new Inspector.
115
116         * WebView.cpp: Removed old inspectElement method now that this is
117         handled by WebCore.
118         (WebView::WebView):
119         (WebView::close):
120         (WebView::performContextMenuAction): Removed handling of the Inspect
121         Element context menu item.
122         (WebView::initWithFrame): Give each Page an InspectorClient to enable
123         the Inspector.
124         (WebView::setProhibitsMainFrameScrolling): Added.
125         * WebView.h:
126
127         Updates needed for WebCore changes.
128
129         * Interfaces/IWebUIDelegate.idl:
130         * WebContextMenuClient.cpp:
131         (WebContextMenuClient::getCustomMenuFromDefaultItems):
132         * WebContextMenuClient.h:
133         * WebCoreLocalizedStrings.cpp:
134
135         Remove old Inspector code.
136
137         * WebFrame.cpp:
138         * WebFrame.h:
139         * WebInspector/WebInspector.cpp: Removed.
140         * WebInspector/WebInspector.h: Removed.
141         * WebInspector/webInspector/Images/button.png: Removed.
142         * WebInspector/webInspector/Images/buttonDivider.png: Removed.
143         * WebInspector/webInspector/Images/buttonPressed.png: Removed.
144         * WebInspector/webInspector/Images/close.png: Removed.
145         * WebInspector/webInspector/Images/closePressed.png: Removed.
146         * WebInspector/webInspector/Images/downTriangle.png: Removed.
147         * WebInspector/webInspector/Images/menu.png: Removed.
148         * WebInspector/webInspector/Images/menuPressed.png: Removed.
149         * WebInspector/webInspector/Images/popup.png: Removed.
150         * WebInspector/webInspector/Images/popupPressed.png: Removed.
151         * WebInspector/webInspector/Images/resize.png: Removed.
152         * WebInspector/webInspector/Images/rightTriangle.png: Removed.
153         * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
154         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
155         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
156         * WebInspector/webInspector/Images/upTriangle.png: Removed.
157         * WebInspector/webInspector/inspector.css: Removed.
158         * WebInspector/webInspector/inspector.html: Removed.
159         * WebInspector/webInspector/inspector.js: Removed.
160         * WebInspector/webInspector/scrollarea.js: Removed.
161         * WebInspector/webInspector/scrollbar.js: Removed.
162         * WebInspector/webInspector/treeoutline.js: Removed.
163         * WebInspector/webInspector/utilities.js: Removed.
164
165         Build-fu:
166
167         * WebKit.vcproj/WebKit.vcproj:
168
169 2007-06-19  Dave Hyatt  <hyatt@apple.com>
170
171         Fix for <rdar://problem/5022197>, backspace and ctrl+left arrow should go back.  Shift+backspace
172         and ctrl+right arrow should go forward.  Add support for these keybindings to Windows.
173        
174         Reviewed by ada
175
176         * WebView.cpp:
177         (WebView::keyDown):
178
179 2007-06-18  Dave Hyatt  <hyatt@apple.com>
180
181         Let through more newline+modifier key combos in order to support Alt+Enter and Ctrl+Enter in the
182         SafariWin URL bar.
183        
184         Reviewed by mccullough
185
186         * WebView.cpp:
187
188 2007-06-18  Dave Hyatt  <hyatt@apple.com>
189
190         Add support for horizontal mouse wheeling to Windows.  Shift+wheel is supported for horizontal
191         wheeling just like on OS X.  In addition, the WM_MOUSEHWHEEL event is now processed correctly so that
192         input devices like tilt wheels will now work.
193        
194         Reviewed by aroben
195
196         * WebView.cpp:
197         (WebView::mouseWheel):
198         (WebViewWndProc):
199         * WebView.h:
200
201 2007-06-17  Dave Hyatt  <hyatt@apple.com>
202
203         Add support for Ctrl+Mouse Wheel to increase/decrease text zoom (Win32 only).
204        
205         Reviewed by aroben
206
207         * WebView.cpp:
208         (WebView::mouseWheel):
209
210 2007-06-09  Steve Falkenburg  <sfalken@apple.com>
211
212         Reviewed by Adam.
213         
214         Workaround: <rdar://problem/5213266> schwab.com menu is ridiculously big.
215         
216         * WebView.cpp:
217         (WebView::userAgentForKURL): Add schwab to spoof list to fix gigantic menus.
218
219 2007-06-08  Ada Chan  <adachan@apple.com>
220
221         Reviewed by Hyatt, Adam, and Steve.
222
223         Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.
224
225         * WebView.cpp:
226         (WebView::selectedText):
227
228 2007-06-08  Adam Roben  <aroben@apple.com>
229
230         Get rid of the Safari part of the query string used for Google searches.
231
232         Reviewed by Steve and Ada.
233
234         * WebContextMenuClient.cpp:
235         (WebContextMenuClient::searchWithGoogle):
236
237 2007-06-08  Kevin McCullough  <kmccullough@apple.com>
238
239         Reviewed by Kevin Decker, and Sam.
240
241         - Added and updated licenses.
242
243         * CFDictionaryPropertyBag.cpp:
244         * CFDictionaryPropertyBag.h:
245         * DOMCSSClasses.cpp:
246         * DOMCSSClasses.h:
247         * DOMEventsClasses.cpp:
248         * DOMEventsClasses.h:
249         * DOMHTMLClasses.cpp:
250         * DOMHTMLClasses.h:
251         * MarshallingHelpers.cpp:
252         * MarshallingHelpers.h:
253         * MemoryStream.cpp:
254         * MemoryStream.h:
255         * WebBackForwardList.cpp:
256         * WebBackForwardList.h:
257         * WebCache.cpp:
258         * WebCache.h:
259         * WebChromeClient.cpp:
260         * WebChromeClient.h:
261         * WebContextMenuClient.h:
262         * WebDataSource.h:
263         * WebEditorClient.cpp:
264         * WebEditorClient.h:
265         * WebElementPropertyBag.cpp:
266         * WebElementPropertyBag.h:
267         * WebHTMLRepresentation.h:
268         * WebHistory.cpp:
269         * WebHistory.h:
270         * WebIconDatabase.cpp:
271         * WebIconDatabase.h:
272         * WebKit.vcproj/auto-version.sh:
273         * WebKitClassFactory.h:
274         * WebKitDLL.h:
275         * WebLocalizableStrings.cpp:
276         * WebLocalizableStrings.h:
277         * WebMutableURLRequest.cpp:
278         * WebMutableURLRequest.h:
279         * WebNotification.cpp:
280         * WebNotification.h:
281         * WebNotificationCenter.cpp:
282         * WebNotificationCenter.h:
283         * WebPreferenceKeysPrivate.h:
284         * WebPreferences.cpp:
285         * WebPreferences.h:
286         * WebScriptObject.cpp:
287         * WebScriptObject.h:
288         * WebURLResponse.cpp:
289         * WebURLResponse.h:
290
291 2007-06-07  Sam Weinig  <sam@webkit.org>
292
293         Reviewed by Adam Roben.
294
295         Make the inspector compile again.
296
297         * WebInspector/WebInspector.cpp:
298         (setFocusedDOMNodeCallback):
299         (focusedDOMNodeCallback):
300         (setRootDOMNodeCallback):
301         (rootDOMNodeCallback):
302
303 2007-06-06  Steve Falkenburg  <sfalken@apple.com>
304
305         Reviewed by Adam.
306         
307         <rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
308         <rdar://problem/5243655> Flash download page doesn't recognize Boomer
309         
310         Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
311         This fixes the Acrobat Reader download.
312
313         * WebView.cpp:
314         (WebView::userAgentForKURL):
315
316 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
317
318         Reviewed by Adam.
319         
320         <rdar://problem/5246665> Drop down lists are not drawn on volvocars.us
321
322         * WebView.cpp:
323         (WebView::userAgentForKURL):
324
325 2007-06-01  Kevin McCullough  <kmccullough@apple.com>
326
327         Reviewed by Oliver.
328
329         - Uncommenting some functions that should not be commented out.  I needed them for the Drosera port.
330
331         * WebKit.vcproj/WebKit_debug.def:
332
333 2007-06-01  Steve Falkenburg  <sfalken@apple.com>
334
335         Reviewed by Kevin Decker.
336         
337         Remove unnecessary user agent spoofs, now that we have the final UA in place.
338         Added spoof to allow Flash downloads from adobe.com
339
340         * WebView.cpp:
341         (WebView::userAgentForKURL):
342
343 2007-05-30  Ada Chan  <adachan@apple.com>
344
345         Reviewed by Steve.
346
347         Implemented the mechanism to associate a WebPreferences instance with an identifier.
348
349         * WebIconDatabase.cpp:
350         (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
351         * WebPreferences.cpp:
352         (WebPreferences::getInstanceForIdentifier): implemented
353         (WebPreferences::setInstance): implemented
354         (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be
355         released has only one ref left, remove it from the s_webPreferencesInstances dictionary.
356         (WebPreferences::load): don't need to reread in the default preferences if we have done so.
357         (WebPreferences::initWithIdentifier): update the m_identifier data member with the
358         passed in identifier string, and store the identifier to WebPreferences instance mapping in
359         s_webPreferencesInstances dictionary.
360         (WebPreferences::identifier): implemented
361         * WebPreferences.h:
362         * WebView.cpp:
363         (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification
364         since it's already done in close().
365         (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object -
366         this way the WebView is only notified when that particular WebPreferences instance changes.
367         (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object -
368         this way the WebView is only notified when that particular WebPreferences instance changes.
369         (WebView::setPreferences): implemented
370         (WebView::onNotify): used COMPtr to fix a missing release
371
372 2007-05-29  Steve Falkenburg  <sfalken@apple.com>
373
374         Reviewed by Darin.
375         
376         Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.
377
378         * Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
379         * WebBackForwardList.cpp: Removed unnecessary methods.
380         * WebBackForwardList.h: Removed unnecessary methods.
381
382 2007-05-29  Sam Weinig  <sam@webkit.org>
383
384         Reviewed by Adam Roben.
385
386         - Removes platform/win/NotImplemented.h because we have consolidated
387           the notImplemented() for all platforms in platform/NotImplemented.h
388         - Fixes remaining uses of old macro to use the new notImplemented() one.
389
390         * WebChromeClient.cpp:
391         (WebChromeClient::createModalDialog):
392         (WebChromeClient::canRunModal):
393         (WebChromeClient::runModal):
394         (WebChromeClient::setScrollbarsVisible):
395         (WebChromeClient::scrollbarsVisible):
396         (WebChromeClient::setMenubarVisible):
397         (WebChromeClient::menubarVisible):
398         * WebContextMenuClient.cpp:
399         (WebContextMenuClient::lookUpInDictionary):
400         (WebContextMenuClient::speak):
401         (WebContextMenuClient::stopSpeaking):
402         * WebDownload.cpp:
403         (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType):
404         (WebDownload::cancelAuthenticationChallenge):
405         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
406         (WebDownload::useCredential):
407         (WebDownload::didReceiveAuthenticationChallenge):
408         * WebEditorClient.cpp:
409         (WebEditorClient::spellCheckerDocumentTag):
410         (WebEditorClient::shouldBeginEditing):
411         (WebEditorClient::shouldEndEditing):
412         (WebEditorClient::didBeginEditing):
413         (WebEditorClient::respondToChangedContents):
414         (WebEditorClient::respondToChangedSelection):
415         (WebEditorClient::didEndEditing):
416         (WebEditorClient::didWriteSelectionToPasteboard):
417         (WebEditorClient::didSetSelectionTypesForPasteboard):
418         (WebEditorClient::shouldDeleteRange):
419         (WebEditorClient::shouldInsertNode):
420         (WebEditorClient::shouldInsertText):
421         (WebEditorClient::shouldApplyStyle):
422         (WebEditorClient::shouldChangeTypingStyle):
423         (WebEditorClient::webViewDidChangeTypingStyle):
424         (WebEditorClient::webViewDidChangeSelection):
425         (WebEditorClient::shouldShowDeleteInterface):
426         (WebEditorClient::shouldChangeSelectedRange):
427         * WebFrame.cpp:
428         (WebFrame::makeRepresentation):
429         (WebFrame::forceLayout):
430         (WebFrame::forceLayoutForNonHTML):
431         (WebFrame::setCopiesOnScroll):
432         (WebFrame::detachedFromParent1):
433         (WebFrame::detachedFromParent2):
434         (WebFrame::detachedFromParent3):
435         (WebFrame::detachedFromParent4):
436         (WebFrame::loadedFromCachedPage):
437         (WebFrame::dispatchDidLoadMainResource):
438         (WebFrame::revertToProvisionalState):
439         (WebFrame::clearUnarchivingState):
440         (WebFrame::setMainFrameDocumentReady):
441         (WebFrame::willChangeTitle):
442         (WebFrame::didChangeTitle):
443         (WebFrame::finalSetupForReplace):
444         (WebFrame::setDefersLoading):
445         (WebFrame::isArchiveLoadPending):
446         (WebFrame::cancelPendingArchiveLoad):
447         (WebFrame::clearArchivedResources):
448         (WebFrame::canShowMIMEType):
449         (WebFrame::representationExistsForURLScheme):
450         (WebFrame::generatedMIMETypeForURLScheme):
451         (WebFrame::restoreViewState):
452         (WebFrame::provisionalLoadStarted):
453         (WebFrame::shouldTreatURLAsSameAsCurrent):
454         (WebFrame::addHistoryItemForFragmentScroll):
455         (WebFrame::didFinishLoad):
456         (WebFrame::prepareForDataSourceReplacement):
457         (WebFrame::setDocumentViewFromCachedPage):
458         (WebFrame::shouldGoToHistoryItem):
459         (WebFrame::saveViewStateToItem):
460         (WebFrame::saveDocumentViewToCachedPage):
461         (WebFrame::canCachePage):
462         (WebFrame::setMainDocumentError):
463         (WebFrame::cannotShowURLError):
464         (WebFrame::cannotShowMIMETypeError):
465         (WebFrame::fileDoesNotExistError):
466         (WebFrame::willUseArchive):
467         (WebFrame::dispatchDidLoadResourceFromMemoryCache):
468         (WebFrame::startDownload):
469         (WebFrame::overrideMediaType):
470         (WebFrame::addInspector):
471         (WebFrame::removeInspector):
472
473 2007-05-25  Oliver Hunt  <oliver@apple.com>
474
475         Reviewed by Hyatt.
476         
477         Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)
478
479         * WebFrame.cpp:
480         (WebFrame::objectContentType):
481
482 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
483
484         Build fix -- forgot to commit a little bit in my last patch.
485
486 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
487
488         Reviewed by Darin Adler, Adam Roben.
489
490         Fixed <rdar://problem/5055182> The page cache has no global cap.
491         
492         The main WebKit changes are:
493             1. Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: 
494             pageCacheSize because they're deprecated on Mac now. I didn't remove
495             them, though, because doing so can cause COM badness.
496             
497             2. Added IWebPreferences::setUsesPageCache IWebPreferences:: 
498             usesPageCache because that's the new Mac API. I added them to the end
499             of IWebPreferences to avoid COM badness.
500             
501             3. Centralized calculation of object cache and page cache sizes inside
502             WebPreferences. 
503             
504             Changed our old behavior of reading a preference and applying a fudge 
505             factor with a new behavior of just using the preference directly. The 
506             old behavior was confusing and often inappropriate. (For example, if 
507             you set a page cache size of 100, a 256MB machine would somewhat 
508             arbitrarily reduce that number to 98.)
509             
510 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
511
512         Reviewed by Darin Adler.
513
514         Fixed a bug with Settings where a number of different objects held bare 
515         Settings* data members, even though the Page owns the Settings object and 
516         deletes it upon destruction.
517         
518         Added NULL checks since the Page can be deleted before the frame/document.
519
520 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
521
522         Added IWebFramePrivate::isDescendantOfFrame.
523
524         * Interfaces/IWebFramePrivate.idl:
525         * WebFrame.cpp:
526         (WebFrame::isDescendantOfFrame):
527         * WebFrame.h:
528
529 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
530
531         Build fix.  Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.
532
533         * WebKit.vcproj/Interfaces.vcproj:
534
535 2007-05-22  Alice Liu  <alice.liu@apple.com>
536
537         Reviewed by Oliver.
538         
539         Enabling smartInsertDelete to resolve 
540         <rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail
541         
542         * Interfaces/IWebView.idl:
543         * WebEditorClient.cpp:
544         (WebEditorClient::smartInsertDeleteEnabled):
545         * WebView.cpp:
546         (WebView::WebView):
547         (WebView::initWithFrame):
548         (WebView::toggleSmartInsertDelete):
549         (WebView::setSmartInsertDeleteEnabled):
550         (WebView::smartInsertDeleteEnabled):
551         * WebView.h:
552
553 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
554
555         Reviewed by oliver
556         
557         Build fix.
558
559         * WebView.cpp:
560         (WebView::clearFocusNode):
561
562 2007-05-22  Steve Falkenburg  <sfalken@apple.com>
563
564         Reviewed by Ada.
565         
566         Added 3 view-related methods to IWebFramePrivate.
567
568         * Interfaces/IWebFramePrivate.idl: Added 3 new methods
569         * WebFrame.cpp:
570         (WebFrame::hasScrollBars): Added.
571         (WebFrame::contentBounds): Added.
572         (WebFrame::frameBounds): Added.
573         * WebFrame.h:
574
575 2007-05-21  Steve Falkenburg  <sfalken@apple.com>
576
577         Reviewed by Adam, Ada.
578         
579         Added IWebFramePrivate::size().
580
581         * Interfaces/IWebFramePrivate.idl: Added size.
582         * WebFrame.cpp:
583         (WebFrame::size): Added.
584         * WebFrame.h: Added size.
585
586 2007-05-21  Ada Chan  <adachan@apple.com>
587
588         Reviewed by Steve.
589
590         Added IWebViewPrivate::loadBackForwardListFromOtherView().  It replicates the backforward
591         list from another webview and loads that in the current webview.
592
593         * Interfaces/IWebViewPrivate.idl:
594         * WebView.cpp:
595         (WebView::loadBackForwardListFromOtherView):
596         * WebView.h:
597
598 2007-05-18  Steve Falkenburg  <sfalken@apple.com>
599
600         Build-related fix: stamp version resource properly.
601
602         * WebKit.vcproj/WebKit.rc: Fix version resource
603
604 2007-05-18  Adam Roben  <aroben@apple.com>
605
606         Build fix after r21555.
607
608         * WebView.cpp:
609
610 2007-05-17  Ada Chan  <adachan@apple.com>
611
612         Reviewed by Steve.
613         
614         Implemented IWebHTTPURLResponse::localizedStringForStatusCode().
615
616         * English.lproj/Localizable.strings: new http status strings
617         * Interfaces/WebKit.idl: added code to create WebURLResponse instances
618         * WebKitClassFactory.cpp:
619         (WebKitClassFactory::CreateInstance): ditto
620         * WebKitDLL.cpp: ditto
621         * WebURLResponse.cpp:
622         (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): return the description
623         text for the given status code
624         (WebURLResponse::createInstance): create a general instance of web url response.
625         (WebURLResponse::localizedStringForStatusCode):
626         * WebURLResponse.h:
627
628 2007-05-17  Ada Chan  <adachan@apple.com>
629
630         Reviewed by Steve.
631         
632         Changed the context menu title "Search in Google" to "Search with Google".
633
634         * English.lproj/Localizable.strings:
635         * WebCoreLocalizedStrings.cpp:
636         (WebCore::contextMenuItemTagSearchWeb):
637
638 2007-05-17  Anders Carlsson  <andersca@apple.com>
639
640         Fix build.
641         
642         * WebFrame.cpp:
643         (WebFrame::loadURLIntoChild):
644
645 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
646
647         Reviewed by Darin, Oliver.
648         
649         <rdar://problem/4967360> Need to detect damaged installs, alert the user to reinstall, and exit
650
651         * WebLocalizableStrings.cpp:
652         (WebLocalizedString): Make failure to load a localized string slightly less fatal
653
654 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
655
656         Reviewed by Darin.
657         
658         <rdar://problem/4956541> Need to implement preference for how much History is maintained
659
660         * WebHistory.cpp:
661         (WebHistory::ageLimitDate): Remove extra +30 from history age in days.
662
663 2007-05-14  Anders Carlsson  <andersca@apple.com>
664
665         Reviewed by Darin.
666
667         Pass an empty property bag when constructing the WebError, the code in Safari relies on having a user info bag.
668         
669         * WebFrame.cpp:
670         (WebFrame::createJavaAppletWidget):
671
672 2007-05-14  Anders Carlsson  <andersca@apple.com>
673
674         Reviewed by Antti.
675
676         Report an error to the resource load delegate if the Java plugin can't be loaded.
677         
678         * WebFrame.cpp:
679         (WebFrame::createJavaAppletWidget):
680
681 2007-05-11  Steve Falkenburg  <sfalken@apple.com>
682
683         Reviewed by Darin, Ada.
684
685         WebKit DCOM compatibility.
686         When a WebKit hosting app calls RunAsLocalServer, the class object for CLSID_WebDebugProgram
687         is registered to allow creation across processes.  This is for future compatibility with
688         Drosera.
689
690         Added new exported function: RunAsLocalServer.
691         This exposes WebKit inside the running exe as a LocalServer32 (COM server), which
692         will allow Drosera to connect to it via DCOM.
693
694         We use the DCOM Universal Marshaller from oleaut32.dll, which performs marshalling
695         based on type libraries, so as part of this change, I've done some work on making our
696         interfaces compatible with this marshaller.
697         
698         Updated for compatibility w/ COM automation, and fixed up our type library.        
699         Added type library registration/unregistration code.
700         Marked methods not compatible w/ automation/marshalling as [local].
701         
702         As a side-effect, with these changes, the .NET tlbimp tool can create a .NET interop
703         assembly to theoretically allow WebKit to be invoked from .NET apps.  I haven't
704         tried this.  It could end up being useful to drive API testing.
705         
706         To test, I wrote a small app that calls:
707         ::CoCreateInstance(CLSID_IWebDebugProgram, 0, CLSCTX_LOCAL_SERVER, IID_IUnknown, (void**)&viewUnknown);
708         Using this instantiated class, I'm able to iterate the exisitng webviews and retrieve their
709         source, title, URL, etc.
710         
711         * DOMCoreClasses.cpp:
712         (DOMElement::isEqual):
713         * DOMCoreClasses.h:
714         * DefaultDownloadDelegate.cpp:
715         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
716         * DefaultDownloadDelegate.h:
717         * Interfaces/DOMCSS.idl:
718         * Interfaces/DOMCore.idl:
719         * Interfaces/DOMEvents.idl:
720         * Interfaces/DOMExtensions.idl:
721         * Interfaces/DOMHTML.idl:
722         * Interfaces/DOMPrivate.idl:
723         * Interfaces/DOMRange.idl:
724         * Interfaces/DOMWindow.idl:
725         * Interfaces/IWebArchive.idl:
726         * Interfaces/IWebAttributedString.idl: Removed.
727         * Interfaces/IWebBackForwardList.idl:
728         * Interfaces/IWebBackForwardListPrivate.idl:
729         * Interfaces/IWebCache.idl:
730         * Interfaces/IWebDataSource.idl:
731         * Interfaces/IWebDebugProgram.idl: Added.
732         * Interfaces/IWebDocument.idl:
733         * Interfaces/IWebDownload.idl:
734         * Interfaces/IWebEditingDelegate.idl:
735         * Interfaces/IWebError.idl:
736         * Interfaces/IWebFormDelegate.idl:
737         * Interfaces/IWebFrame.idl:
738         * Interfaces/IWebFrameLoadDelegate.idl:
739         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
740         * Interfaces/IWebFramePrivate.idl:
741         * Interfaces/IWebFrameView.idl:
742         * Interfaces/IWebHTMLRepresentation.idl:
743         * Interfaces/IWebHTTPURLResponse.idl:
744         * Interfaces/IWebHistory.idl:
745         * Interfaces/IWebHistoryItem.idl:
746         * Interfaces/IWebHistoryItemPrivate.idl:
747         * Interfaces/IWebIconDatabase.idl:
748         * Interfaces/IWebJavaScriptCollector.idl:
749         * Interfaces/IWebKitStatistics.idl:
750         * Interfaces/IWebMutableURLRequest.idl:
751         * Interfaces/IWebNotification.idl:
752         * Interfaces/IWebNotificationCenter.idl:
753         * Interfaces/IWebNotificationObserver.idl:
754         * Interfaces/IWebPolicyDelegate.idl:
755         * Interfaces/IWebPreferences.idl:
756         * Interfaces/IWebResource.idl:
757         * Interfaces/IWebResourceLoadDelegate.idl:
758         * Interfaces/IWebResourceLoadDelegatePrivate.idl:
759         * Interfaces/IWebScriptObject.idl:
760         * Interfaces/IWebScrollBarDelegatePrivate.idl:
761         * Interfaces/IWebScrollBarPrivate.idl:
762         * Interfaces/IWebUIDelegate.idl:
763         * Interfaces/IWebUIDelegatePrivate.idl:
764         * Interfaces/IWebURLAuthenticationChallenge.idl:
765         * Interfaces/IWebURLRequest.idl:
766         * Interfaces/IWebURLResponse.idl:
767         * Interfaces/IWebUndoManager.idl:
768         * Interfaces/IWebUndoTarget.idl:
769         * Interfaces/IWebView.idl:
770         * Interfaces/IWebViewPrivate.idl:
771         * Interfaces/WebKit.idl:
772         * WebContextMenuClient.cpp:
773         (WebContextMenuClient::getCustomMenuFromDefaultItems):
774         * WebDataSource.cpp:
775         (WebDataSource::subresources):
776         * WebDataSource.h:
777         * WebDebugProgram.cpp: Added.
778         (EnumViews::EnumViews):
779         (EnumViews::QueryInterface):
780         (EnumViews::AddRef):
781         (EnumViews::Release):
782         (EnumViews::Next):
783         (EnumViews::Skip):
784         (EnumViews::Reset):
785         (EnumViews::Clone):
786         (WebDebugProgram::WebDebugProgram):
787         (WebDebugProgram::~WebDebugProgram):
788         (WebDebugProgram::createInstance):
789         (WebDebugProgram::QueryInterface):
790         (WebDebugProgram::AddRef):
791         (WebDebugProgram::Release):
792         (WebDebugProgram::viewAdded):
793         (WebDebugProgram::viewRemoved):
794         (WebDebugProgram::attach):
795         (WebDebugProgram::detach):
796         (WebDebugProgram::statistics):
797         (WebDebugProgram::webViews):
798         * WebDebugProgram.h: Added.
799         * WebDropSource.cpp:
800         (generateMouseEvent):
801         * WebError.cpp:
802         (WebError::localizedRecoveryOptions):
803         * WebError.h:
804         * WebFrame.cpp:
805         (EnumChildFrames::EnumChildFrames):
806         (EnumChildFrames::QueryInterface):
807         (EnumChildFrames::AddRef):
808         (EnumChildFrames::Release):
809         (EnumChildFrames::Next):
810         (EnumChildFrames::Skip):
811         (EnumChildFrames::Reset):
812         (EnumChildFrames::Clone):
813         (WebFrame::childFrames):
814         (WebFrame::initWithWebFrameView):
815         * WebFrame.h:
816         * WebHistoryItem.cpp:
817         (WebHistoryItem::icon):
818         * WebHistoryItem.h:
819         * WebIconDatabase.cpp:
820         (WebIconDatabase::iconForURL):
821         (WebIconDatabase::defaultIconWithSize):
822         * WebIconDatabase.h:
823         * WebInspector/WebInspector.cpp:
824         (WebInspector::WebInspector):
825         (WebInspector::show):
826         (WebInspector::onDestroy):
827         (WebInspector::onSize):
828         * WebInspector/WebInspector.h:
829         (WebInspector::didReceiveIcon):
830         (WebInspector::webViewFirstResponder):
831         (WebInspector::makeFirstResponder):
832         (WebInspector::contextMenuItemsForElement):
833         (WebInspector::trackCustomPopupMenu):
834         (WebInspector::addCustomMenuDrawingData):
835         (WebInspector::cleanUpCustomMenuDrawingData):
836         * WebKit.vcproj/Interfaces.vcproj:
837         * WebKit.vcproj/WebKit.def:
838         * WebKit.vcproj/WebKit.vcproj:
839         * WebKit.vcproj/WebKitGUID.vcproj:
840         * WebKit.vcproj/WebKit_debug.def:
841         * WebKitClassFactory.cpp:
842         (WebKitClassFactory::CreateInstance):
843         * WebKitDLL.cpp:
844         (DllGetClassObject):
845         (DllUnregisterServer):
846         (DllRegisterServer):
847         (RunAsLocalServer):
848         * WebKitStatistics.cpp:
849         * WebScrollBar.cpp:
850         (WebScrollBar::init):
851         (WebScrollBar::handleMouseEvent):
852         * WebScrollBar.h:
853         * WebView.cpp:
854         (WebView::WebView):
855         (WebView::~WebView):
856         (WebView::handleContextMenuEvent):
857         (WebView::onInitMenuPopup):
858         (WebView::onUninitMenuPopup):
859         (WebViewWndProc):
860         (WebView::QueryInterface):
861         (WebView::MIMETypesShownAsHTML):
862         (WebView::setHostWindow):
863         (WebView::hostWindow):
864         (WebView::generateSelectionImage):
865         (WebView::pasteboardTypesForSelection):
866         (WebView::pasteboardTypesForElement):
867         (WebView::mainFrameIcon):
868         (WebView::canMakeTextStandardSize):
869         (WebView::viewWindow):
870         * WebView.h:
871
872 2007-05-11  Adele Peterson  <adele@apple.com>
873
874         Build fix.
875
876         * WebView.cpp: (WebView::selectionImageRect):
877
878 2007-05-10  Geoffrey Garen  <ggaren@apple.com>
879
880         Reviewed by Darin Adler.
881         
882         "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.
883
884 2007-05-10  Maciej Stachowiak  <mjs@apple.com>
885
886         Reviewed by Oliver.
887
888         - WebKitWin part of fix for:
889         <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
890         <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
891
892         The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
893         so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
894         
895         However, this caused many regressions so I had to fix the fallout.
896
897         * WebFrame.cpp:
898         (WebFrame::createFrame): init frame
899         * WebView.cpp:
900         (WebView::initWithFrame): init frame
901         (WebView::stringByEvaluatingJavaScriptFromString): don't create empty document
902
903 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
904
905         Reviewed by Darin, Oliver.
906         
907         Added UI_STRING versions of localized WebCore strings.
908
909         * English.lproj/Localizable.strings: Updated.
910         * English.lproj/StringsNotToBeLocalized.txt: Updated.
911         * WebCoreLocalizedStrings.cpp: Added.
912         (WebCore::searchableIndexIntroduction):
913         (WebCore::submitButtonDefaultLabel):
914         (WebCore::inputElementAltText):
915         (WebCore::resetButtonDefaultLabel):
916         (WebCore::fileButtonChooseFileLabel):
917         (WebCore::fileButtonNoFileSelectedLabel):
918         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
919         (WebCore::contextMenuItemTagDownloadLinkToDisk):
920         (WebCore::contextMenuItemTagCopyLinkToClipboard):
921         (WebCore::contextMenuItemTagOpenImageInNewWindow):
922         (WebCore::contextMenuItemTagDownloadImageToDisk):
923         (WebCore::contextMenuItemTagCopyImageToClipboard):
924         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
925         (WebCore::contextMenuItemTagCopy):
926         (WebCore::contextMenuItemTagGoBack):
927         (WebCore::contextMenuItemTagGoForward):
928         (WebCore::contextMenuItemTagStop):
929         (WebCore::contextMenuItemTagReload):
930         (WebCore::contextMenuItemTagCut):
931         (WebCore::contextMenuItemTagPaste):
932         (WebCore::contextMenuItemTagNoGuessesFound):
933         (WebCore::contextMenuItemTagIgnoreSpelling):
934         (WebCore::contextMenuItemTagLearnSpelling):
935         (WebCore::contextMenuItemTagSearchWeb):
936         (WebCore::contextMenuItemTagLookUpInDictionary):
937         (WebCore::contextMenuItemTagOpenLink):
938         (WebCore::contextMenuItemTagIgnoreGrammar):
939         (WebCore::contextMenuItemTagSpellingMenu):
940         (WebCore::contextMenuItemTagCheckSpelling):
941         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
942         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
943         (WebCore::contextMenuItemTagFontMenu):
944         (WebCore::contextMenuItemTagBold):
945         (WebCore::contextMenuItemTagItalic):
946         (WebCore::contextMenuItemTagUnderline):
947         (WebCore::contextMenuItemTagOutline):
948         (WebCore::contextMenuItemTagWritingDirectionMenu):
949         (WebCore::contextMenuItemTagDefaultDirection):
950         (WebCore::contextMenuItemTagLeftToRight):
951         (WebCore::contextMenuItemTagRightToLeft):
952         (WebCore::contextMenuItemTagShowSpellingPanel):
953         (WebCore::searchMenuNoRecentSearchesText):
954         (WebCore::searchMenuRecentSearchesText):
955         (WebCore::searchMenuClearRecentSearchesText):
956         (WebCore::AXWebAreaText):
957         (WebCore::AXLinkText):
958         (WebCore::AXListMarkerText):
959         (WebCore::AXImageMapText):
960         (WebCore::AXHeadingText):
961         * WebKit.vcproj/WebKit.vcproj: Added WebCoreLocalizedStrings.cpp, reorganized other files a bit.
962
963 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
964
965         Reviewed by Ada.
966         
967         Update editing delegate
968
969         * Interfaces/IWebEditingDelegate.idl:
970         * WebEditorClient.cpp:
971         (WebEditorClient::updateSpellingUIWithGrammarString):
972         * WebEditorClient.h:
973
974 2007-05-07  Steve Falkenburg  <sfalken@apple.com>
975
976         Reviewed by Darin.
977
978         Fix typo in prefs code.       
979
980         * WebPreferences.cpp:
981         (WebPreferences::preferencesPath): Fix typo in error handling.
982
983 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
984
985         Reviewed by Darin.
986         
987         Fix crash when using "check spelling while typing".
988
989         * WebView.cpp:
990         (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.
991
992 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
993
994         Reviewed by Ada, Oliver.
995         
996         Checkpoint:
997         <rdar://problem/4602372> Spelling
998         <rdar://problem/4769763> Spell checking engine support        
999
1000         * Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
1001         * WebEditorClient.cpp:
1002         (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
1003         * WebEditorClient.h:
1004         * WebView.cpp:
1005         (WebView::replaceSelectionWithText): Implemented.
1006
1007 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
1008
1009         Reviewed by Oliver.
1010         
1011         Fix usage errors in COM enumeration.
1012
1013         * WebEditorClient.cpp:
1014         (WebEditorClient::checkGrammarOfString): Call Next correctly.
1015         (WebEditorClient::getGuessesForWord): Call Next correctly.
1016
1017 2007-04-30  Alice Liu  <alice.liu@apple.com>
1018
1019         Reviewed by Adam.
1020
1021         Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
1022         Basically this fix involved one thing, which lead to another thing.  First, the crash
1023         was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
1024         WebViewWndProc when WM_DESTROY message is processed.  We now want only WebKit handling
1025         the closure of a WebView, so all calls to WebView::close have been removed, save for
1026         the one call in WebViewWndProc.
1027
1028         * Interfaces/IWebView.idl:
1029         removed close() from public interface
1030         * WebInspector/WebInspector.cpp:
1031         (WebInspector::onDestroy):
1032         removed call to close()
1033         * WebView.cpp:
1034         (WebView::~WebView):
1035         move the deleting of m_page down a bit to avoid a crash 
1036         (WebView::close):
1037         changed from public API to just a public function
1038         (WebViewWndProc):
1039         webView->close() was moved here from SearchableWebView::onDestroy
1040         * WebView.h:
1041         changed close() to a public function not exposed in the WebKit interface
1042
1043 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
1044
1045         Reviewed by Darin, Oliver.
1046         
1047         Checkpoint:
1048         <rdar://problem/4602372> Spelling
1049         <rdar://problem/4769763> Spell checking engine support
1050
1051         * WebEditorClient.cpp:
1052         (WebEditorClient::isContinuousSpellCheckingEnabled):
1053         (WebEditorClient::toggleContinuousSpellChecking):
1054         (WebEditorClient::isGrammarCheckingEnabled):
1055         (WebEditorClient::toggleGrammarChecking):
1056         (initViewSpecificSpelling):
1057         (WebEditorClient::spellCheckerDocumentTag):
1058         (WebEditorClient::ignoreWordInSpellDocument):
1059         (WebEditorClient::learnWord):
1060         (WebEditorClient::checkSpellingOfString):
1061         (WebEditorClient::checkGrammarOfString):
1062         (WebEditorClient::udpateSpellingUIWithGrammarString):
1063         (WebEditorClient::updateSpellingUIWithMisspelledWord):
1064         (WebEditorClient::showSpellingUI):
1065         (WebEditorClient::spellingUIIsShowing):
1066         (WebEditorClient::getGuessesForWord):
1067         * WebPreferences.h:
1068
1069 2007-04-20  Ada Chan  <adachan@apple.com>
1070
1071         Reviewed by Steve and Oliver.
1072         
1073         Implemented some DOM methods I need to support password input and textarea in 
1074         WebView-based edit fields in the app.
1075
1076         * DOMCSSClasses.cpp:
1077         (DOMCSSStyleDeclaration::setCssText): added implementation
1078         * DOMCoreClasses.cpp:
1079         (DOMDocument::createElement): ditto
1080         * DOMHTMLClasses.cpp:
1081         (DOMHTMLInputElement::setType): ditto
1082         (DOMHTMLTextAreaElement::value): ditto
1083         (DOMHTMLTextAreaElement::setValue): ditto
1084         (DOMHTMLTextAreaElement::select): ditto
1085         * Interfaces/IWebUIDelegatePrivate.idl: added a new method webViewGetDlgCode() that client
1086         can implement if it wants to handle keypresses themselves rather than letting the system 
1087         interpret certain keys as dialog box navigation keys.
1088         * WebKitGraphics.cpp:
1089         (DrawTextAtPoint): handle drawing text as password
1090         * WebKitGraphics.h:
1091         * WebView.cpp:
1092         Added Copy, Cut, and Paste to the keyEntries.
1093         (WebViewWndProc): added code to handle WM_GETDLGCODE.  Calls IWebUIDelegatePrivate::webViewGetDlgCode()
1094         if available to see if the client wants to handle it.
1095
1096 2007-04-18  Adam Roben  <aroben@apple.com>
1097
1098         Reviewed by Steve.
1099
1100         Make development builds use the same CLSIDs as archive builds, and get
1101         rid of the now-unused set of CLSIDs.
1102
1103         * Interfaces/WebKit.idl: Use the archive build CLSIDs if we're not
1104         doing a production build.
1105         * WebKit.vcproj/Interfaces.vcproj: Don't define __ARCHIVE_BUILD__
1106         because it's not used anymore.
1107
1108 2007-04-18  Adam Roben  <aroben@apple.com>
1109
1110         Reviewed by Steve.
1111
1112         Use different ProgIDs for production builds.
1113
1114         * ProgIDMacros.h: Added.
1115         * WebKit.vcproj/WebKit.vcproj: Defined the __BUILDBOT__ macro and added
1116         a new header which is copied in the post-build step.
1117         * WebKitDLL.cpp: Macro-ized the declaration of the registry keys to
1118         install.
1119
1120 2007-04-16  Adam Roben  <aroben@apple.com>
1121
1122         Rubberstamped by Steve.
1123
1124         * WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.
1125
1126 2007-04-16  Adam Roben  <aroben@apple.com>
1127
1128         Reviewed by Steve.
1129
1130         Removed the pre-link build step, and removed registration of WebKit.dll
1131         from the post-build step.
1132
1133         * WebKit.vcproj/WebKit.vcproj:
1134
1135 2007-04-16  Adam Roben  <aroben@apple.com>
1136
1137         * WebKit.vcproj/WebKit.sln: Added WTF to the solution.
1138
1139 2007-04-16  Steve Falkenburg  <sfalken@apple.com>
1140
1141         Reviewed by Adam.
1142         
1143         Visual Studio Express compatibility for WebKit build (except for DRT)
1144
1145         * WebDragClient.cpp: Removed unused header (atlsafe.h)
1146         * WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
1147         * WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
1148         * WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
1149         * WebView.cpp: Removed unused header (atldef.h)
1150
1151 2007-04-16  Adam Roben  <aroben@apple.com>
1152
1153         Merge in r20872.
1154
1155         * WebInspector/webInspector/inspector.js:
1156         * WebInspector/webInspector/treeoutline.js:
1157
1158 2007-04-16  Adam Roben  <aroben@apple.com>
1159
1160         Merge in r20861.
1161
1162         * WebInspector/webInspector/inspector.js:
1163         * WebInspector/webInspector/treeoutline.js:
1164
1165 2007-04-16  Adam Roben  <aroben@apple.com>
1166
1167         Merge in r20845.
1168
1169         * WebInspector/webInspector/inspector.js:
1170
1171 2007-04-16  Adam Roben  <aroben@apple.com>
1172
1173         Merge in r20844.
1174
1175         * WebInspector/webInspector/inspector.js:
1176
1177 2007-04-16  Adam Roben  <aroben@apple.com>
1178
1179         Merge in r20843.
1180
1181         * WebInspector/webInspector/inspector.js:
1182         * WebInspector/webInspector/scrollarea.js:
1183         * WebInspector/webInspector/scrollbar.js:
1184         * WebInspector/webInspector/utilities.js:
1185
1186 2007-04-16  Adam Roben  <aroben@apple.com>
1187
1188         Merge in r20842.
1189
1190         * WebInspector/webInspector/inspector.html:
1191         * WebInspector/webInspector/inspector.js:
1192         * WebInspector/webInspector/utilities.js: Added.
1193
1194 2007-04-16  Adam Roben  <aroben@apple.com>
1195
1196         Merge in r20840.
1197
1198         * WebInspector/webInspector/inspector.html:
1199         * WebInspector/webInspector/inspector.js:
1200         * WebInspector/webInspector/treeoutline.js: Added.
1201
1202 2007-04-14  Adam Roben  <aroben@apple.com>
1203
1204         * WebKit.vcproj/WebKitGUID.vcproj: Need to use WebKitConfigSuffix
1205         instead of ConfigSuffix now.
1206
1207 2007-04-14  Adam Roben  <aroben@apple.com>
1208
1209         * WebKit.vcproj/WebKit.submit.sln: Use the Debug_Internal configuration
1210         when B&I builds Debug.
1211
1212 2007-04-12  Steve Falkenburg  <sfalken@apple.com>
1213
1214         Reviewed by Geoff, Adam.
1215         
1216         Changes required for search history content.
1217
1218         * Interfaces/IWebFramePrivate.idl:
1219         * WebFrame.cpp:
1220         (WebFrame::isFrameSet): Added
1221         (WebFrame::string): Added
1222         * WebFrame.h:
1223
1224 2007-04-12  Adam Roben  <aroben@apple.com>
1225
1226         Rubberstamped by Steve.
1227
1228         Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
1229         WebKit.sln so that opensource contributors can use it to build a
1230         working WebKit.
1231
1232         * WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
1233         * WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore,
1234         DumpRenderTree projects.
1235         * WebKit.vcproj/WebKit.submit.sln: Added.
1236
1237 2007-04-12  Adam Roben  <aroben@apple.com>
1238
1239         Reviewed by Steve.
1240
1241         <rdar://problem/5131565> Need to be able to use debug WebKit with
1242         release Safari.
1243
1244         Added a new configuration to WebKit.vcproj called Debug_Internal to be
1245         used by Apple internal builds. The Debug configuration is now meant to
1246         be used by opensource builds, and will always link against release
1247         versions of CF, CFNet, CG, etc. Debug_Internal is identical to Debug
1248         except for the property sheet it uses, and the Debug configuration
1249         doesn't register WebKit_debug.dll when finished.
1250
1251         We now have two macros, $(WebKitConfigSuffix) and
1252         $(LibraryConfigSuffix). WebKitConfigSuffix is used for WebKit projects,
1253         and is "_debug" for both Debug and Debug_Internal. LibraryConfigSuffix
1254         is used for external projects, and is "" for Debug and "_debug" for
1255         Debug_Internal.
1256
1257         * WebKit.vcproj/WebKit.vcproj:
1258         * WebKit.vcproj/debug.vsprops:
1259         * WebKit.vcproj/debug_internal.vsprops: Added.
1260         * WebKit.vcproj/release.vsprops:
1261
1262 2007-04-12  John Sullivan  <sullivan@apple.com>
1263
1264         Reviewed by Anders
1265
1266         * Interfaces/IWebUIDelegate.idl:
1267         added new PDF-related context menu items to enum to keep it in sync with WebCore
1268
1269 2007-04-12  Mark Rowe  <mrowe@apple.com>
1270
1271         Not reviewed.  Internal counterpart to open-source r20856.
1272
1273         * WebChromeClient.cpp:
1274         (WebChromeClient::createWindow):
1275         (WebChromeClient::createModalDialog):
1276         * WebChromeClient.h:
1277
1278 2007-04-11  Ada Chan  <adachan@apple.com>
1279
1280         Reviewed by Steve.
1281         
1282         Implemented WebHistoryItem::originalURLString().  Added parameter checks to other methods.
1283
1284         * WebHistoryItem.cpp:
1285         (WebHistoryItem::originalURLString):
1286         (WebHistoryItem::URLString):
1287         (WebHistoryItem::title):
1288         (WebHistoryItem::lastVisitedTimeInterval):
1289
1290 2007-04-10  Brady Eidson  <beidson@apple.com>
1291
1292         Reviewed by Darin
1293
1294         <rdar://problem/4887095> - PageCache and PageState should be combined
1295
1296         Basically updated client methods for the new names and signatures 
1297
1298         * WebFrame.cpp:
1299         (WebFrame::loadedFromCachedPage):
1300         (WebFrame::setDocumentViewFromCachedPage):
1301         (WebFrame::saveDocumentViewToCachedPage):
1302         * WebFrame.h:
1303
1304 2007-04-10  Adam Roben  <aroben@apple.com>
1305
1306         Reviewed by Anders.
1307
1308         Fix <rdar://problem/5119803> Web Inspector has no options menu
1309
1310         * WebInspector/WebInspector.cpp:
1311         (interpreterForFrame): Added.
1312         (WebInspector::showOptionsMenu): Implemented.
1313         (WebInspector::onCommand): Added.
1314         (WebInspector::toggleIgnoreWhitespace): Implemented.
1315         (WebInspector::toggleShowUserAgentStyles): Implemented.
1316         (WebInspectorWndProc): Added case for WM_COMMAND.
1317         * WebInspector/WebInspector.h:
1318
1319 2007-04-09  Anders Carlsson  <andersca@apple.com>
1320
1321         Reviewed by Adam.
1322
1323         <rdar://problem/5062624>
1324         No prompt to install QT for pages with uninstalled QT plug-in.
1325         
1326         * CFDictionaryPropertyBag.cpp:
1327         (CFDictionaryPropertyBag::Read):
1328         (CFDictionaryPropertyBag::Write):
1329         Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.
1330         
1331         * Interfaces/IWebError.idl:
1332         Add user info keys.
1333         
1334         * MarshallingHelpers.cpp:
1335         (MarshallingHelpers::LPCOLESTRToCFStringRef):
1336         * MarshallingHelpers.h:
1337         New function.
1338         
1339         * WebError.cpp:
1340         (WebError::WebError):
1341         (WebError::createInstance):
1342         Take a property bag.
1343         
1344         (WebError::userInfo):
1345         Return the property bag.
1346         
1347         * WebFrame.cpp:
1348         (WebFrame::createPlugin):
1349         If the plug-in wasn't found or failed to load, create a WebError with the right user info and
1350         call IWebResourceLoadDelegate::plugInFailedWithError.
1351
1352 2007-04-09  Brady Eidson  <beidson@apple.com>
1353
1354         Build Fix
1355
1356         * WebContextMenuClient.cpp:
1357         (WebContextMenuClient::searchWithGoogle): userGesture is true
1358
1359 2007-04-09  Timothy Hatcher  <timothy@apple.com>
1360
1361         Merge in r20810.
1362
1363         <rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down
1364
1365         Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
1366         Also makes selecting rows in the style pane happen on mousedown for consistency.
1367
1368         * WebInspector/webInspector/inspector.js:
1369
1370 2007-04-09  Adam Roben  <aroben@apple.com>
1371
1372         Fixed copyrights.
1373
1374         * WebInspector/WebInspector.cpp:
1375         * WebInspector/WebInspector.h:
1376
1377 2007-04-09  Adam Roben  <aroben@apple.com>
1378
1379         Reviewed by Oliver.
1380
1381         Fix two Web Inspector bugs:
1382         - The WebView wasn't focused when the inspector first appeared.
1383         - Resizing the upper pane did not resize the whole window.
1384
1385         * WebInspector/WebInspector.cpp:
1386         (WebInspector::show): Focus the WebView.
1387         (WebInspector::setFrame): Implemented.
1388         (WebInspector::webViewFrame): Implemented.
1389         * WebInspector/WebInspector.h:
1390
1391 2007-04-09  Adam Roben  <aroben@apple.com>
1392
1393         * WebInspector/WebInspector.cpp:
1394         (WebInspector::WebInspector): Removed two fixed FIXMEs and some
1395         commented-out code.
1396
1397 2007-04-08  Adam Roben  <aroben@apple.com>
1398
1399         When does "merge" != "merge"? When you make the change yourself
1400         pre-emptively and make a typo.
1401
1402         * WebInspector/webInspector/inspector.js:
1403
1404 2007-04-08  Adam Roben  <aroben@apple.com>
1405
1406         Merge in r20800.
1407
1408         * WebInspector/webInspector/inspector.js:
1409
1410 2007-04-08  Adam Roben  <aroben@apple.com>
1411
1412         Merge in r20797.
1413
1414         * WebInspector/webInspector/inspector.js:
1415
1416 2007-04-08  Adam Roben  <aroben@apple.com>
1417
1418         Merge in r20796.
1419
1420         * WebInspector/webInspector/inspector.js:
1421
1422 2007-04-08  Adam Roben  <aroben@apple.com>
1423
1424         Reviewed by Anders.
1425
1426         <rdar://problem/5119804> Web Inspector isn't resizable
1427         <rdar://problem/5119805> Can't move Web Inspector
1428
1429         * WebInspector/WebInspector.cpp:
1430         (WebInspectorPrivate::WebInspectorPrivate):
1431         (WebInspector::WebInspector): Subclass the WebView so we can intercept
1432         its messages.
1433         (WebInspector::onDestroy): Undo the subclassing.
1434         (WebInspector::handleMessageSentToWebView): Added.
1435         (WebInspector::onLButtonDown): Added.
1436         (WebInspector::onLButtonUp): Added.
1437         (WebInspector::onMouseMove): Added.
1438         (WebInspectorWndProc): Added cases for mouse messages.
1439         (SubclassedWebViewWndProc): Added.
1440         * WebInspector/WebInspector.h:
1441
1442 2007-04-08  Adam Roben  <aroben@apple.com>
1443
1444         Merge in r20793.
1445
1446         * WebInspector/webInspector/AppleScrollArea.js: Removed.
1447         * WebInspector/webInspector/AppleScrollbar.js: Removed.
1448         * WebInspector/webInspector/Images/resize.png: Added.
1449         * WebInspector/webInspector/inspector.css:
1450         * WebInspector/webInspector/inspector.html:
1451         * WebInspector/webInspector/inspector.js:
1452         * WebInspector/webInspector/scrollarea.js: Added.
1453         * WebInspector/webInspector/scrollbar.js: Added.
1454
1455 2007-04-08  Adam Roben  <aroben@apple.com>
1456
1457         Merge in r20792.
1458
1459         * WebInspector/webInspector/inspector.js:
1460
1461 2007-04-08  Adam Roben  <aroben@apple.com>
1462
1463         Merge in r20791.
1464
1465         * WebInspector/webInspector/inspector.js:
1466
1467 2007-04-08  Adam Roben  <aroben@apple.com>
1468
1469         Merge in r20789.
1470
1471         * WebInspector/webInspector/inspector.js:
1472
1473 2007-04-08  Adam Roben  <aroben@apple.com>
1474
1475         Build fix.
1476
1477         * WebInspector/WebInspector.cpp:
1478
1479 2007-04-07  Adam Roben  <aroben@apple.com>
1480
1481         Reviewed by Oliver.
1482
1483         <rdar://problem/4769828> Web Inspector
1484
1485         * WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported
1486         Mac code. Some parts are left commented out to aid later
1487         implementation.
1488         * WebInspector/WebInspector.h: Ditto.
1489
1490         * DOMCoreClasses.cpp: Added IID_DOMNode.
1491         (DOMNode::QueryInterface): Added case for IID_DOMNode.
1492         (DOMNode::isSameNode): Implemented.
1493         * DOMCoreClasses.h: Added IID_DOMNode.
1494         (DOMNode::node): Added.
1495         * English.lproj/Localizable.strings: Updated for "Inspect Element".
1496         * WebContextMenuClient.cpp:
1497         (WebContextMenuClient::getCustomMenuFromDefaultItems): Add the "Inspect
1498         Element" item.
1499         * WebFrame.cpp:
1500         (WebFrame::addInspector): Stubbed out.
1501         (WebFrame::removeInspector): Ditto.
1502         * WebFrame.h: Added declarations.
1503         * WebKit.resources/Info.plist: Added. This was needed so that the
1504         WebKit bundle would have a bundle identifier.
1505         * WebKit.vcproj/WebKit.vcproj: Added new files to project, and modified
1506         the post-build step to copy Info.plist and everything in
1507         WebInspector/webInspector to WebKit.resources.
1508         * WebView.cpp:
1509         (WebView::performContextMenuAction): Added case for the Inspect Element item.
1510         (WebView::inspectElement): Added.
1511         * WebView.h: Added declaration.
1512
1513 2007-04-07  Adam Roben  <aroben@apple.com>
1514
1515         Forked most of the WebInspector directory from
1516         r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.
1517
1518         * WebInspector/WebInspector.h: Added.
1519         * WebInspector/WebInspector.m: Added.
1520         (+[WebInspector sharedWebInspector]):
1521         (-[WebInspector init]):
1522         (-[WebInspector initWithWebFrame:]):
1523         (-[WebInspector dealloc]):
1524         (-[WebInspector window]):
1525         (-[WebInspector windowWillClose:]):
1526         (-[WebInspector showWindow:]):
1527         (-[WebInspector setWebFrame:]):
1528         (-[WebInspector webFrame]):
1529         (-[WebInspector setRootDOMNode:]):
1530         (-[WebInspector rootDOMNode]):
1531         (-[WebInspector setFocusedDOMNode:]):
1532         (-[WebInspector focusedDOMNode]):
1533         (-[WebInspector setSearchQuery:]):
1534         (-[WebInspector searchQuery]):
1535         (-[WebInspector showOptionsMenu]):
1536         (-[WebInspector _toggleIgnoreWhitespace:]):
1537         (-[WebInspector _toggleShowUserAgentStyles:]):
1538         (-[WebInspector _highlightNode:]):
1539         (-[WebInspector _nodeHighlightExpired:]):
1540         (-[WebInspector _update]):
1541         (-[WebInspector _updateRoot]):
1542         (-[WebInspector _updateSystemColors]):
1543         (-[WebInspector _applicationWillResignActive]):
1544         (-[WebInspector _applicationDidBecomeActive]):
1545         (-[WebInspector _webFrameDetached:]):
1546         (+[WebInspector isSelectorExcludedFromWebScript:]):
1547         (+[WebInspector webScriptNameForSelector:]):
1548         (+[WebInspector isKeyExcludedFromWebScript:]):
1549         (-[WebInspector inspectedWebViewProgressFinished:]):
1550         (-[WebInspector webView:didFinishLoadForFrame:]):
1551         (-[WebInspector webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1552         (-[WebInspector webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1553         (-[WebInspector webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1554         (-[WebInspectorPrivate dealloc]):
1555         (-[DOMNode _isAncestorOfNode:]):
1556         * WebInspector/webInspector/AppleScrollArea.js: Added.
1557         * WebInspector/webInspector/AppleScrollbar.js: Added.
1558         * WebInspector/webInspector/Images/button.png: Added.
1559         * WebInspector/webInspector/Images/buttonDivider.png: Added.
1560         * WebInspector/webInspector/Images/buttonPressed.png: Added.
1561         * WebInspector/webInspector/Images/close.png: Added.
1562         * WebInspector/webInspector/Images/closePressed.png: Added.
1563         * WebInspector/webInspector/Images/downTriangle.png: Added.
1564         * WebInspector/webInspector/Images/menu.png: Added.
1565         * WebInspector/webInspector/Images/menuPressed.png: Added.
1566         * WebInspector/webInspector/Images/popup.png: Added.
1567         * WebInspector/webInspector/Images/popupPressed.png: Added.
1568         * WebInspector/webInspector/Images/rightTriangle.png: Added.
1569         * WebInspector/webInspector/Images/scrollThumbBottom.png: Added.
1570         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Added.
1571         * WebInspector/webInspector/Images/scrollThumbTop.png: Added.
1572         * WebInspector/webInspector/Images/scrollTrackBottom.png: Added.
1573         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Added.
1574         * WebInspector/webInspector/Images/scrollTrackTop.png: Added.
1575         * WebInspector/webInspector/Images/upTriangle.png: Added.
1576         * WebInspector/webInspector/inspector.css: Added.
1577         * WebInspector/webInspector/inspector.html: Added.
1578         * WebInspector/webInspector/inspector.js: Added.
1579
1580 2007-04-06  Dave Hyatt  <hyatt@apple.com>
1581
1582         Internal side of fix for bug 13274.
1583
1584         Reviewed by olliej
1585
1586         * Interfaces/IWebScrollBarPrivate.idl:
1587         * WebScrollBar.cpp:
1588         * WebScrollBar.h:
1589         * WebView.cpp:
1590         (WebView::handleMouseEvent):
1591
1592 2007-04-04  Oliver Hunt  <oliver@apple.com>
1593
1594         Reviewed by Ada.
1595         
1596         Fix <rdar://problem/5111027> Dragging a link on page
1597         shows URL thumbnail as nearly-transparent instead 
1598         semi-transparent
1599
1600         Error in createDragImageForLink led me to get wrong 
1601         maximum drag image size, now logic and maximum drag 
1602         image size corrected.
1603
1604         * WebDragClient.cpp:
1605         (WebDragClient::createDragImageForLink):
1606
1607 2007-04-04  Adam Roben  <aroben@apple.com>
1608
1609         Release build fix for TestNetscapePlugin.
1610
1611         * WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the
1612         same as the Debug one so that the npapi headers get copied.
1613
1614 2007-04-03  Adam Roben  <aroben@apple.com>
1615
1616         Reviewed by Anders.
1617
1618         WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
1619         failing due to extra/missing newlines
1620
1621         * DOMCoreClasses.cpp:
1622         (DOMElement::innerText): Added.
1623         * DOMCoreClasses.h: Added declaration.
1624         * Interfaces/DOMPrivate.idl: Ditto.
1625
1626 2007-04-02  Steve Falkenburg  <sfalken@apple.com>
1627
1628         Reviewed by Darin.
1629         
1630         Expose COM class counter
1631
1632         * Interfaces/IWebKitStatistics.idl: Added comClassCount
1633         * WebKitStatistics.cpp:
1634         (WebKitStatistics::comClassCount): Added
1635         * WebKitStatistics.h:
1636
1637 2007-03-31  Steve Falkenburg  <sfalken@apple.com>
1638
1639         Reviewed by Hyatt.
1640
1641         <rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
1642         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
1643
1644         * WebIconDatabase.cpp:
1645         (userIconDatabasePath): Prefer to store Icon.db file keyed off of bundle executable name
1646         * WebPreferences.cpp:
1647         (WebPreferences::preferencesPath): Prefer to store WebKit Preferences keyed off of bundle executable name
1648
1649 2007-03-30  Adele Peterson  <adele@apple.com>
1650
1651         Reviewed by Beth.
1652
1653         Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing
1654
1655         * WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
1656
1657 2007-03-30  Anders Carlsson  <andersca@apple.com>
1658
1659         Reviewed by Adele.
1660
1661         <rdar://problem/5101970> 
1662         Crash when submitting form, running under App Verifier
1663         
1664         * WebActionPropertyBag.cpp:
1665         (findMouseEvent):
1666         Return the right event.
1667
1668 2007-03-30  Anders Carlsson  <andersca@apple.com>
1669
1670         Reviewed by Geoff.
1671
1672         * Interfaces/IWebViewPrivate.idl:
1673         Add addAdditionalPluginPath method.
1674         
1675         * WebKit.vcproj/WebKit.vcproj:
1676         Copy NP includes so they can be included by the test plugin.
1677         
1678         * WebView.cpp:
1679         (WebView::stringByEvaluatingJavaScriptFromString):
1680         Hold JSLock while we call JSValue::getString().
1681         
1682         (WebView::addAdditionalPluginPath):
1683         * WebView.h:
1684         Implement addAdditionalPluginPath.
1685
1686 2007-03-27  Dave Hyatt  <hyatt@apple.com>
1687
1688         Enable complex text.  Selection and small-caps support are now enabled with this patch.
1689         
1690         Reviewed by aroben
1691
1692         * WebPreferences.cpp:
1693         (WebPreferences::initialize):
1694
1695 2007-03-26  Brady Eidson  <beidson@apple.com>
1696
1697         Reviewed by Ada
1698
1699         This one didn't actually have any leaks, but I just felt like doing the
1700         same style cleanup as the others :)
1701         
1702         * WebPreferences.cpp:
1703         (WebPreferences::stringValueForKey):
1704         (WebPreferences::integerValueForKey):
1705         (WebPreferences::floatValueForKey):
1706         (WebPreferences::setStringValue):
1707         (WebPreferences::setIntegerValue):
1708         (WebPreferences::save):
1709         (WebPreferences::load):
1710
1711 2007-03-26  Brady Eidson  <beidson@apple.com>
1712
1713         Reviewed by Ada
1714
1715         <rdar://5090412> - Plug CFNumberRef leaks in WebCache
1716         
1717         * WebCache.cpp:
1718         (WebCache::statistics):
1719
1720 2007-03-26  Beth Dakin  <bdakin@apple.com>
1721
1722         Reviewed by Geoff.
1723
1724         Fix build without breaking anything.
1725
1726         * WebHistory.cpp:
1727         (releaseUserInfo): Added silly void statement for now.
1728
1729 2007-03-26  Beth Dakin  <bdakin@apple.com>
1730
1731         Rubber-stamped by Brady.
1732
1733         Build fix for release build.
1734
1735         * WebHistory.cpp:
1736         (releaseUserInfo): Do not store userInfo->Release() in a local 
1737         variable since it is only used for an ASSERT.
1738
1739 2007-03-26  Steve Falkenburg  <sfalken@apple.com>
1740
1741         Reviewed by Lou.
1742         
1743         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
1744
1745         * WebIconDatabase.cpp:
1746         (userIconDatabasePath): Move icon database to non-roaming location
1747
1748 2007-03-25  Brady Eidson  <beidson@apple.com>
1749
1750         Reviewed by Oliver
1751         
1752         <rdar://problem/5086888> - WebHistory(Item) Leak
1753         
1754         This is a pretty thourough touchup up style and correctness that
1755         plugs at least 1 definite leak and many potential leaks with
1756         extensive use of RetainPtr and COMPtr.
1757         
1758         This should result in no change in behavior
1759
1760         * MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
1761         * MarshallingHelpers.h: Ditto
1762         
1763         * WebHistory.cpp:
1764         (createUserInfoFromArray):
1765         (createUserInfoFromHistoryItem):
1766         (releaseUserInfo):
1767         (WebHistory::WebHistory):
1768         (WebHistory::~WebHistory):
1769         (WebHistory::loadFromURL):
1770         (createHistoryListFromStream): Split of the Structured Exception
1771           Handling to a seperate function to cooperate with C++
1772         (WebHistory::loadHistoryGutsFromURL):
1773         (WebHistory::saveToURL):
1774         (WebHistory::saveHistoryGuts):
1775         (WebHistory::datesArray):
1776         (WebHistory::addItems):
1777         (WebHistory::removeItems):
1778         (WebHistory::removeAllItems):
1779         (WebHistory::orderedLastVisitedDays):
1780         (WebHistory::orderedItemsLastVisitedOnDay):
1781         (WebHistory::removeItem):
1782         (WebHistory::addItem):
1783         (WebHistory::addItemForURL):
1784         (WebHistory::itemForURLString):
1785         (WebHistory::itemForURL):
1786         (WebHistory::containsItemForURLString):
1787         (WebHistory::removeItemForURLString):
1788         (WebHistory::addItemToDateCaches):
1789         (WebHistory::removeItemFromDateCaches):
1790         (WebHistory::findIndex):
1791         (WebHistory::insertItem):
1792         (WebHistory::ageLimitDate):
1793         * WebHistory.h:
1794         
1795         * WebHistoryItem.cpp:
1796         (WebHistoryItem::dictionaryRepresentation):
1797         (WebHistoryItem::mergeAutoCompleteHints):
1798
1799 2007-03-25  Adam Roben  <aroben@apple.com>
1800
1801         Reviewed by Oliver.
1802
1803         WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
1804         layoutTestController.queueLoad
1805
1806         * WebFrame.cpp:
1807         (WebFrame::findFrameNamed): Implemented.
1808         * WebHistoryItem.cpp:
1809         (WebHistoryItem::children): Don't increment i twice per loop!
1810
1811 2007-03-25  Adam Roben  <aroben@apple.com>
1812
1813         Build fix.
1814
1815         * WebDownload.h: Include RetainPtr from WTF.
1816
1817 2007-03-24  Steve Falkenburg  <sfalken@apple.com>
1818
1819         Build fix.
1820
1821         * WebDownload.h: Remove WebCore namespace
1822
1823 2007-03-24  Adam Roben  <aroben@apple.com>
1824
1825         Reviewed by Oliver.
1826
1827         WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
1828         layoutTestController.dumpBackForwardList
1829
1830         * Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
1831         * WebFrame.cpp:
1832         (WebFrame::childFrames): Removed unused variable.
1833         * WebHistoryItem.cpp:
1834         (WebHistoryItem::target): Implemented.
1835         (WebHistoryItem::isTargetItem): Implemented.
1836         (WebHistoryItem::children): Implemented.
1837         * WebHistoryItem.h: Added declarations.
1838
1839 2007-03-23  Brady Eidson  <beidson@apple.com>
1840
1841         Reviewed by Adam
1842         
1843         <rdar://5086194> - WebHistory overreleases a CFNumber
1844         
1845         * WebHistory.cpp:
1846         (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't 
1847           legitimately get a ref for!
1848
1849 2007-03-23  Adam Roben  <aroben@apple.com>
1850
1851         Reviewed by Darin.
1852
1853         WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
1854         hacks" menu item to the Debug menu
1855
1856         Added new IWebPrivate::setAllowSiteSpecificHacks SPI.
1857
1858         * Interfaces/IWebViewPrivate.idl: Added declaration.
1859         * WebView.cpp:
1860         (WebView::userAgentForKURL): Only give a site-specific UA if
1861         site-specific hacks are turned on.
1862         (WebView::setAllowSiteSpecificHacks): Added.
1863         * WebView.h:
1864         (WebView::allowSiteSpecificHacks): Added.
1865
1866 2007-03-23  Beth Dakin  <bdakin@apple.com>
1867
1868         Reviewed by Hyatt.
1869
1870         Fix for <rdar://problem/5083914> Cursor is wrong for all context 
1871         menus
1872
1873         * WebView.cpp:
1874         (WebView::handleContextMenuEvent): Set the cursor to the pointer 
1875         cursor.
1876
1877 2007-03-23  Alice Liu  <alice.liu@apple.com>
1878
1879         Reviewed by Adam.
1880
1881         Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit
1882
1883         * WebView.cpp:
1884         (WebView::userAgentForKURL):
1885         added flickr spoof
1886
1887 2007-03-23  Adam Roben  <aroben@apple.com>
1888
1889         Reviewed by Oliver.
1890
1891         WebKit part of <rdar://problem/5085170> DumpRenderTree doesn't print
1892         frame scroll offsets
1893
1894         Implemented some WebFrame methods to support dumping frame scroll
1895         offsets in DRT.
1896
1897         * Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
1898         * Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
1899         * WebFrame.cpp:
1900         (WebFrame::name): Implemented.
1901         (WebFrame::childFrames): Implemented.
1902         (WebFrame::scrollOffset): Implemented.
1903         * WebFrame.h: Updated/added declarations.
1904
1905 2007-03-23  Adam Roben  <aroben@apple.com>
1906
1907         Reviewed by Oliver.
1908
1909         WebKit part of fix for <rdar://problem/4990740>.
1910
1911         Added IWebDataSourcePrivate::mainDocumentError.
1912
1913         * Interfaces/IWebDataSource.idl: Added method declaration and updated
1914         copyrights.
1915         * WebDataSource.cpp:
1916         (WebDataSource::mainDocumentError): Implemented.
1917         * WebDataSource.h: Added declaration.
1918
1919 2007-03-23  Steve Falkenburg  <sfalken@apple.com>
1920
1921         Reviewed by Adam.
1922         
1923         <rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed
1924
1925         * WebView.cpp:
1926         (WebView::userAgentForKURL): Remove gmail spoof
1927
1928 2007-03-22  Dave Hyatt  <hyatt@apple.com>
1929
1930         Fix for <rdar://problem/5083072>.
1931
1932         Reviewed by aroben
1933   
1934         * ChangeLog:
1935         * WebFrame.cpp:
1936         (WebFrame::setPrinting):
1937         (WebFrame::spoolPages):
1938         * WebFrame.h:
1939
1940 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
1941
1942         Reviewed by Maciej.
1943
1944         <rdar://problem/5082270>
1945         Crash in windows media player at MTV.COM
1946         
1947         Ignore any WM_PAINT events we get while painting.
1948         
1949         * WebView.cpp:
1950         (WebView::WebView):
1951         (WebView::updateBackingStore):
1952         (WebView::paint):
1953         (WebViewWndProc):
1954         * WebView.h:
1955         (WebView::isPainting):
1956
1957 2007-03-22  Adele Peterson  <adele@apple.com>
1958
1959         Reviewed by Anders.
1960
1961         Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)
1962
1963         * Interfaces/IWebURLRequest.idl:
1964         * WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty.  On the mac,
1965           NSURLRequests created from empty ResourceRequests are nil.  We may want to consider that in the future, but there were too
1966           many places in the app that expected the IWebURLRequest to be non-null.
1967         * WebMutableURLRequest.h:
1968
1969 2007-03-22  Dave Hyatt  <hyatt@apple.com>
1970
1971         Fix for crasher in layout caused by paints that happen without layout being current.  Change to be
1972         more like the Mac and crawl the frame tree up front ensuring everyone is up to date before painting.
1973
1974         Reviewed by olliej
1975
1976         * WebFrame.cpp:
1977         (WebFrame::WebFramePrivate::m_policyFunction):
1978         (WebFrame::layoutIfNeededRecursive):
1979         * WebFrame.h:
1980         * WebView.cpp:
1981         (WebView::updateBackingStore):
1982         (WebView::paint):
1983         (WebViewWndProc):
1984
1985 2007-03-22  Ada Chan  <adachan@apple.com>
1986
1987         Reviewed by Hyatt and Alice.
1988         
1989         Changed the mouse event processing in the WebView wndproc so we actually
1990         allow a mouse event with click count > 3, which matches the mac safari behavior.
1991         
1992         Set globalPrevButton and globalPrevPoint also in mouse down.
1993
1994         * WebView.cpp:
1995         (WebView::handleMouseEvent):
1996
1997 2007-03-21  Anders Carlsson  <acarlsson@apple.com>
1998
1999         Reviewed by Adam.
2000
2001         * WebView.cpp:
2002         (WebView::initWithFrame):
2003         Remove #ifdef now that DRT no longer crashes.
2004
2005 2007-03-21  Beth Dakin  <bdakin@apple.com>
2006
2007         Reviewed by Adam.
2008
2009         <rdar://problem/5074274> right-clicking in certain iframes ends up 
2010         left-clicking, and context menu appears far away
2011
2012         * WebView.cpp:
2013         (WebView::handleContextMenuEvent): We were always calling 
2014         sendContextMenuEvent() on the main frame!! Instead, call it on the 
2015         focused or main frame.
2016
2017 2007-03-21  Adele Peterson  <adele@apple.com>
2018
2019         Reviewed by Adam.
2020         
2021         Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails
2022         
2023         Added updateActiveState SPI for DumpRenderTree.
2024
2025         * Interfaces/IWebViewPrivate.idl:
2026         * WebView.cpp:
2027         (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus.  We should merge this logic into updateActiveState eventually.
2028         (WebView::updateActiveState):
2029         * WebView.h:
2030
2031 2007-03-19  Maciej Stachowiak  <mjs@apple.com>
2032
2033         Reviewed by Geoff and Adam.
2034
2035         - <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
2036
2037         * WebView.cpp:
2038         (WebView::WebView): Tell JavaScriptCore what the main thread is.
2039
2040 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2041
2042         Reviewed by Adam.
2043
2044         <rdar://problem/5050512>
2045         Need invalid/expired certificate alerts
2046         
2047         Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it 
2048         call down to WebCore.
2049         
2050         * Interfaces/IWebMutableURLRequest.idl:
2051         * WebMutableURLRequest.cpp:
2052         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2053         * WebMutableURLRequest.h:
2054
2055 2007-03-20  Adam Roben  <aroben@apple.com>
2056
2057         Rubberstamped by Anders.
2058
2059         Workaround a CFNetwork crash that affects DRT.
2060
2061         * WebView.cpp:
2062         (WebView::initWithFrame): Commented out cookie storage initialization.
2063
2064 2007-03-20  Adam Roben  <aroben@apple.com>
2065
2066         Build fix.
2067
2068         * WebView.cpp: Added missing #include.
2069
2070 2007-03-20  Adam Roben  <aroben@apple.com>
2071
2072         Reviewed by Oliver.
2073
2074         Implemented [set]TabKeyCyclesThroughElements.
2075
2076         * Interfaces/IWebViewPrivate.idl: Added new declarations.
2077         * WebView.cpp:
2078         (WebView::setTabKeyCyclesThroughElements): Implemented.
2079         (WebView::tabKeyCyclesThroughElements): Implemented.
2080         * WebView.h: Updated.
2081
2082 2007-03-20  Dave Hyatt  <hyatt@apple.com>
2083
2084         Land advanced text code path (turned off).
2085        
2086         Reviewed by aroben
2087
2088         * WebKit.vcproj/WebKit.vcproj:
2089
2090 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2091
2092         Reviewed by Adam.
2093
2094         <rdar://problem/4921198>
2095         Cookie acceptance policy not settable
2096         
2097         * WebView.cpp:
2098         (WebView::updateWebCoreSettingsFromPreferences):
2099         Update the cookie storage accept policy.
2100         
2101         (WebView::initWithFrame):
2102         Initialize the cookie storage.
2103
2104 2007-03-19  Adam Roben  <aroben@apple.com>
2105
2106         Build fix.
2107
2108         * WebKit.vcproj/WebKitGUID.vcproj:
2109
2110 2007-03-19  Adam Roben  <aroben@apple.com>
2111
2112         Reviewed by Anders and Darin.
2113
2114         Added WebJavaScriptCollector for <rdar://problems/5071653>.
2115
2116         * Interfaces/IWebJavaScriptCollector.idl: Added.
2117         * Interfaces/WebKit.idl:
2118         * WebJavaScriptCollector.cpp: Added.
2119         (WebJavaScriptCollector::WebJavaScriptCollector):
2120         (WebJavaScriptCollector::~WebJavaScriptCollector):
2121         (WebJavaScriptCollector::createInstance):
2122         (WebJavaScriptCollector::QueryInterface):
2123         (WebJavaScriptCollector::AddRef):
2124         (WebJavaScriptCollector::Release):
2125         (WebJavaScriptCollector::collect):
2126         (WebJavaScriptCollector::collectOnAlternateThread):
2127         (WebJavaScriptCollector::objectCount):
2128         * WebJavaScriptCollector.h: Added.
2129         * WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
2130         * WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
2131         * WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
2132         * WebKitClassFactory.cpp:
2133         (WebKitClassFactory::CreateInstance): Added cases for
2134         WebJavaScriptCollector.
2135         * WebKitDLL.cpp:
2136         (DllGetClassObject): Ditto.
2137
2138 2007-03-19  Adam Roben  <aroben@apple.com>
2139
2140         Build fix.
2141
2142         * Interfaces/IWebView.idl:
2143
2144 2007-03-18  Adam Roben  <aroben@apple.com>
2145
2146         Reviewed by Hyatt.
2147
2148         Implemented getting/setting of the editing delegate (we don't actually
2149         use it for anything yet, though. See <rdar://problem/5071598>).
2150
2151         * Interfaces/IWebEditingDelegate.idl: Renamed IWebViewEditingDelegate
2152         to IWebEditingDelegate to match our other delegates.
2153         * Interfaces/IWebView.idl: Updated for rename.
2154         * WebView.cpp:
2155         (WebView::setEditingDelegate): Implemented.
2156         (WebView::editingDelegate): Ditto.
2157         * WebView.h: Updated for rename.
2158
2159 2007-03-18  Adam Roben  <aroben@apple.com>
2160
2161         Reviewed by Geoff.
2162
2163         Added IWebFramePrivate::layout to support eventSender in DRT.
2164
2165         Made IWebView inherit from IDropTarget to match Mac, and added
2166         IWebUIDelegatePrivate::doDragDrop to support drag-and-drop in DRT.
2167
2168         * Interfaces/IWebFramePrivate.idl: Added layout().
2169         * Interfaces/IWebUIDelegatePrivate.idl: Added doDragDrop().
2170         * Interfaces/IWebView.idl: Added inheritance from IDropTarget.
2171         * WebDragClient.cpp:
2172         (WebDragClient::startDrag): Call the UI delegate if possible,
2173         otherwise fallback to OLE's DoDragDrop.
2174         * WebFrame.cpp:
2175         (WebFrame::layout): Implemented.
2176         * WebFrame.h:
2177         * WebView.h:
2178
2179 2007-03-17  Adam Roben  <aroben@apple.com>
2180
2181         Reviewed by Brady.
2182
2183         Fix repro ASSERT when logging in to facebook.com.
2184
2185         * WebMutableURLRequest.cpp:
2186         (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.
2187
2188 2007-03-16  Brady Eidson  <beidson@apple.com>
2189
2190         Reviewed by Oliver
2191
2192         Make the WebDownload fix a little more correct.
2193         
2194         * WebDownload.cpp:
2195         (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created
2196
2197 2007-03-16  Geoffrey Garen  <ggaren@apple.com>
2198
2199         Reviewed by Dave Hyatt.
2200         
2201         Fixed "called Frame::paint with nil renderer" console messages.
2202         You can now launch and exit the app without seeing any
2203         error messages!
2204
2205         * WebView.cpp:
2206         (WebView::paintIntoBackingStore): Only tell the FrameView to
2207         paint if it has a renderer. This isn't an issue on the Mac
2208         because we don't create a FrameView until you load a page.
2209
2210 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2211
2212         Reviewed by Adam.
2213
2214         Add setters and getters for cookie storage accept policy.
2215         
2216         * Interfaces/IWebPreferences.idl:
2217         * WebPreferenceKeysPrivate.h:
2218         * WebPreferences.cpp:
2219         (WebPreferences::initialize):
2220         (WebPreferences::cookieStorageAcceptPolicy):
2221         (WebPreferences::setCookieStorageAcceptPolicy):
2222         * WebPreferences.h:
2223
2224 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2225
2226         Reviewed by Adam and Dave Hyatt.
2227
2228         <rdar://problem/5069226>
2229         Boomer fails Acid2.
2230         
2231         Fix acid2 test.
2232         
2233         * WebFrame.cpp:
2234         (WebFrame::shouldFallBack):
2235         Implement this function.
2236
2237 2007-03-16  Ada Chan  <adachan@apple.com>
2238
2239         Reviewed by Steve.
2240         
2241         Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.
2242
2243         * DOMCSSClasses.cpp:
2244         (DOMCSSStyleDeclaration::setProperty):
2245         * DOMCoreClasses.cpp:
2246         (DOMElement::style):
2247
2248 2007-03-15  Alice Liu  <alice.liu@apple.com>
2249
2250         Reviewed by Ada.
2251
2252         Fixing some leaks
2253
2254         * WebFrame.cpp:
2255         (WebFrame::dispatchDidReceiveAuthenticationChallenge):
2256         (WebFrame::dispatchDidCancelAuthenticationChallenge):
2257
2258 2007-03-15  Brady Eidson  <beidson@apple.com>
2259
2260         Reviewed by Oliver
2261
2262         CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
2263         This might fix some of the random crashers we see on stress testing if they end up 
2264         downloading links.
2265
2266         * WebDownload.cpp:
2267         (WebDownload::init): Release the connection from the handle so it no longer refers to it
2268         
2269 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
2270
2271         Reviewed by Geoff and Steve.
2272         
2273         - fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
2274         - fixes to use FastMalloc on Windows
2275
2276         * WebKit.vcproj/WebKit.def: Add exports of WTF symbols.
2277         * WebKit.vcproj/WebKit_debug.def: ditto
2278         * WebKit.vcproj/WebKit.vcproj: Link pthreads, now needed by WTF.
2279
2280 2007-03-15  Brady Eidson  <beidson@apple.com>
2281
2282         Reviewed by Alice
2283         
2284         Due to OpenSource r20178, all of the sudden we were trying to handle page caching on Windows
2285         even though it is not hooked up yet.  The resulted in very particular cases ending up calling 
2286         clear() in FrameLoader::provisionalLoadStarted().  One such particular case was if a page *would*
2287         be "cachable" (no frames, no passwords, etc etc), and you start a download from that page.
2288         
2289         The fix for now is to manually set the pageCacheSize to 0 whenever we create new pages on Windows.
2290         This prevents the "Should I cache this page?" checking from getting far enough to clear the document.
2291         It so happens this involves exactly one line.
2292         
2293         * WebView.cpp:
2294         (WebView::initWithFrame): Set page cache size to zero on new pages, and add a fixme to remove later
2295
2296 2007-03-15  Brady Eidson  <beidson@apple.com>
2297
2298         Reviewed by Maciej
2299
2300         <rdar://problem/4429701>
2301         Implements a port blocking black list that matches Firefox's
2302         
2303         * Interfaces/IWebError.idl: Add the custom error code for blocked error
2304
2305         * WebFrame.cpp:
2306         (WebFrame::blockedError): FrameLoaderClient fill-in + a Fixme
2307         (WebFrame::interruptForPolicyChangeError): Add a Fixme for localization
2308         * WebFrame.h:
2309
2310 2007-03-15  Adam Roben  <aroben@apple.com>
2311
2312         Rubberstamped by Brady.
2313
2314         * WebKitLogging.cpp: Turn of Download logging by default.
2315
2316 2007-03-14  Ada Chan  <adachan@apple.com>
2317
2318         Reviewed by Lou.
2319
2320         Added a method in IWebViewPrivate to clear the current focus node.  This is called in the app
2321         when focus has been transferred to the address field or search field.
2322
2323         * Interfaces/IWebViewPrivate.idl:
2324         * WebView.cpp:
2325         (WebView::clearFocusNode):
2326         * WebView.h:
2327
2328 2007-03-14  Adele Peterson  <adele@apple.com>
2329
2330         Reviewed by Ada.
2331
2332         Allow empty commands to be sent by doTextFieldCommandFromEvent.  Our autocomplete code relies on this.
2333
2334         * WebEditorClient.cpp: (WebEditorClient::doTextFieldCommandFromEvent):
2335
2336 2007-03-14  Steve Falkenburg  <sfalken@apple.com>
2337
2338         <rdar://problem/5050470> Reproducible crash doing find on page at cnn.com
2339         
2340         Add frame->document() null checks in cases where frame could be a
2341         sub-frame that hasn't started loading yet.
2342
2343         * WebView.cpp:
2344         (WebView::rectsForTextMatches): Add null check
2345
2346 2007-03-14  Adele Peterson  <adele@apple.com>
2347
2348         Reviewed by Darin.
2349
2350         WebKit part of fix for <rdar://problem/5057371> REGRESSION: Shift-selection stopped working in text fields
2351
2352         This fixes doCommandBySelector to take a command string instead of a key code.
2353
2354         * Interfaces/IWebEditingDelegate.idl: Changed parameter to BSTR.
2355         * Interfaces/IWebFormDelegate.idl: ditto.
2356         * WebEditorClient.cpp:
2357         (WebEditorClient::doTextFieldCommandFromEvent): Calls doCommandBySelector with a BString that it gets from interpretKeyEvent instead of a key code.
2358         (WebEditorClient::textWillBeDeletedInTextField): Calls doCommandBySelector with a BString to represent the BackwardDelete command.
2359         (WebEditorClient::handleKeypress): Calls handleEditingKeyboardEvent with just the KeyboardEvent.
2360         * WebView.cpp: Added commands that will be used by doCommandBySelector to the table (Cancel, InsertTab, InsertBacktab, InsertNewline).
2361         (WebView::interpretKeyEvent): Added. Returns a command string for a KeyboardEvent. Removed static editCommandForKey.
2362         (WebView::handleEditingKeyboardEvent): Call Editor methods instead of calling handleTextInputEvent directly.
2363         * WebView.h:
2364
2365 2007-03-14  Administrator  <acarlsson@apple.com>
2366
2367         Build fixes.
2368         
2369         * WebDataSource.cpp:
2370         (WebDataSource::subresourceForURL):
2371         * WebKitDLL.cpp:
2372         (loadResourceIntoBuffer):
2373
2374 2007-03-12  Adele Peterson  <adele@apple.com>
2375
2376         Reviewed by Oliver.
2377
2378         WebKit part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)
2379
2380         Removed special handling of the WM_CHAR message.  All this work is now done by WM_KEYDOWN, which will dispatch the keydown event, 
2381         which causes the keypress event to be dispatched, which calls WebEditorClient::handleKeyPress to do all the hard work.
2382         
2383         * WebEditorClient.cpp: (WebEditorClient::handleKeypress): Removed special call to doTextFieldCommandFromEvent since this will now 
2384         happen during normal key event processing. Call handleEditingKeyboardEvent.  Now editing actions can be prevented from the keypress event handler.
2385         * WebView.cpp:
2386         (WebView::WebView): Added m_currentCharacterCode, so we can reuse the computed code from keyDown for keyUp events.
2387         (WebView::keyUp): Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Use m_currentCharacterCode when constructing the PlatformKeyboardEvent.
2388         (WebView::handleEditingKeyboardEvent): Now takes a KeyboardEvent instead of a PlatformKeyboardEvent.  If no editCommand is created
2389          from the event, then call handleTextInputEvent.
2390         (WebView::keyDown): Peek at the next message in the message loop.  If its a WM_CHAR, then get the character code and remove that message from the queue.
2391          Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Set m_currentCharacterCode and use it when constructing the PlatformKeyboardEvent.
2392         (WebViewWndProc):  Removed handling of WM_CHAR, since this is now done from WM_KEYDOWN by dispatching the keydown event, which will eventually call handleKeyPress.
2393         * WebView.h: Made handleEditingKeyboardEvent public so it can be accessed from WebEditorClient.
2394
2395 2007-03-11  Oliver Hunt  <oliver@apple.com>
2396
2397         Reviewed by Adele.
2398
2399         Stubbed WebEditorClient::respondToChangedSelection
2400
2401         * WebEditorClient.cpp:
2402         (WebEditorClient::respondToChangedSelection):
2403         * WebEditorClient.h:
2404
2405 2007-03-10  Anders Carlsson <acarlsson@apple.com>
2406
2407         Reviewed by Adam.
2408
2409         * DOMCoreClasses.cpp:
2410         (DOMNode::textContent):
2411         Implement this.
2412
2413 2007-03-09  Anders Carlsson <acarlsson@apple.com>
2414
2415         Reviewed by Adam.
2416
2417         * WebURLResponse.cpp:
2418         (WebURLResponse::suggestedFilename):
2419         Get the suggested filename from the ResourceResponse object.
2420
2421 2007-03-09  Adam Roben  <aroben@apple.com>
2422
2423         Rubberstamped by Steve.
2424
2425         B&I build fix.
2426
2427         * WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
2428
2429 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2430
2431         Build fix.
2432         
2433         * WebView.cpp:
2434         (WebView::isLoading):
2435
2436 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2437
2438         Reviewed by Adam.
2439
2440         Implement WebView::isLoading.
2441         
2442         * WebView.cpp:
2443         (WebView::isLoading):
2444
2445 2007-03-07  Adam Roben  <aroben@apple.com>
2446
2447         Rubberstamped by Anders.
2448
2449         Return E_POINTER for null parameters.
2450
2451         * WebScrollBar.cpp:
2452         (WebScrollBar::value):
2453         (WebScrollBar::capturingMouse):
2454         (WebScrollBar::frameGeometry):
2455         (WebScrollBar::width):
2456         (WebScrollBar::height):
2457         (WebScrollBar::requestedWidth):
2458         (WebScrollBar::requestedHeight):
2459         (WebScrollBar::windowClipRect):
2460
2461 2007-03-07  Adam Roben  <aroben@apple.com>
2462
2463         Reviewed by Oliver.
2464
2465         Added requestedWidth and requestedHeight methods to WebScrollBar.
2466
2467         * Interfaces/IWebScrollBarPrivate.idl: Added new declarations.
2468         * WebScrollBar.cpp:
2469         (WebScrollBar::requestedWidth): Implemented.
2470         (WebScrollBar::requestedHeight): Implemented.
2471         * WebScrollBar.h: Added method declarations.
2472
2473 2007-03-07  Adam Roben  <aroben@apple.com>
2474
2475         Rubberstamped by Anders.
2476
2477         * WebFrame.cpp:
2478         (WebFrame::cancelledError): Use the WebURLErrorDomain constant.
2479         (WebFrame::interruptForPolicyChangeError): Use the WebKitErrorDomain constant.
2480
2481 2007-03-07  Adam Roben  <aroben@apple.com>
2482
2483         Rubberstamped by Anders.
2484
2485         Switch the definition of WebURLErrorDomain to "CFURLErrorDomain" so
2486         that we will send the right errors once <rdar://problem/5034136> is
2487         fixed.
2488
2489         * Interfaces/IWebError.idl: Changed definition.
2490
2491 2007-03-07  Adele Peterson  <adele@apple.com>
2492
2493         Build fix.
2494
2495         * WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
2496
2497 2007-03-07  Adele Peterson  <adele@apple.com>
2498
2499         Reviewed by Darin.
2500
2501         WebKitWin part of fix for:
2502         http://bugs.webkit.org/show_bug.cgi?id=10871
2503         http://bugs.webkit.org/show_bug.cgi?id=12677
2504         <rdar://problem/4823129> REGRESSION: IME key events different in nightly
2505         <rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri
2506
2507         * WebEditorClient.cpp:
2508         (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress.
2509         (WebEditorClient::handleInputMethodKeypress): Added.
2510         * WebEditorClient.h:
2511
2512 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
2513
2514         Reviewed by Adam.
2515
2516         * WebFrame.cpp:
2517         (WebFrame::makeDocumentView):
2518         Assert that frame is not null.
2519
2520 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
2521
2522         Reviewed by Adam.
2523
2524         * WebFrame.cpp:
2525         (WebFrame::makeDocumentView):
2526         Call resetMultipleFormSubmissionProtection() so that submitting the same form from separate loads works.
2527
2528 2007-03-06  Brady Eidson  <beidson@apple.com>
2529
2530         Reviewed by Adam
2531
2532         Adapt to an API change in CFURLDownload
2533         
2534         * WebDownload.cpp:
2535         (WebDownload::init):
2536
2537 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
2538
2539         Rubber-stamped by Adam.
2540         
2541         Fix disney.com more.  Disney redirects to disney.go.com.
2542
2543         * WebView.cpp:
2544         (WebView::userAgentForKURL): Added disney.go.com
2545
2546 2007-03-06  Adam Roben  <aroben@apple.com>
2547
2548         Reviewed by Anders.
2549
2550         Always keep rounding hacks on to be consistent.
2551
2552         * WebDragClient.cpp:
2553         (createDragImageForLink): Tell StringTruncator to keep rounding hacks on.
2554         * WebKitGraphics.cpp:
2555         (CenterTruncateStringToWidth): Ditto.
2556         (RightTruncateStringToWidth): Ditto.
2557
2558 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
2559
2560         Reviewed by Adam.
2561         
2562         Allow custom user agents per site.
2563         
2564         This fixes:
2565         
2566         http://www.disney.com
2567         http://www.yahoo.com
2568         http://mail.google.com
2569         iTunes store links (w/ latest unsubmitted CFNetwork from our root share)
2570
2571         * WebView.cpp:
2572         (WebView::userAgentForKURL): Check URL host against a list of known offenders, return them what they're looking for.
2573
2574 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
2575
2576         Reviewed by Adam.
2577         
2578         Pass the user agent on.
2579         
2580         * WebFrame.cpp:
2581         (WebFrame::userAgent):
2582         * WebFrame.h:
2583
2584 2007-03-04  Adam Roben  <aroben@apple.com>
2585
2586         Reviewed by Steve.
2587
2588         Added line spacing querying to FontMetrics to support line wrapping.
2589
2590         * WebKitGraphics.cpp:
2591         (FontMetrics): Return the line spacing.
2592         * WebKitGraphics.h: Added lineSpacing parameter.
2593
2594 2007-03-02  Adam Roben  <aroben@apple.com>
2595
2596         Reviewed by Beth.
2597
2598         Make submenus draw using the UIDelegate.
2599
2600         * Interfaces/IWebUIDelegate.idl: Added new delegate method to add
2601         custom drawing data for menus.
2602         * WebView.cpp:
2603         (WebView::onInitMenuPopup): Added. Calls new delegate method.
2604         (WebViewWndProc): Added handler for WM_INITMENUPOPUP, which is called
2605         for all submenus.
2606         * WebView.h: Added declaration.
2607
2608 2007-03-02  Adam Roben  <aroben@apple.com>
2609
2610         Reviewed by Anders.
2611
2612         Added optional underlining of a single character to WebKitGraphics.
2613
2614         * WebKitGraphics.cpp:
2615         (DrawTextAtPoint): Passed optional underlinedIndex parameter to
2616         WebCoreTextRenderer.
2617         * WebKitGraphics.h: Added optional underlinedIndex parameter.
2618
2619 2007-03-01  Adam Roben  <aroben@apple.com>
2620
2621         Reviewed by Kevin M.
2622
2623         Add support for right-truncation to WebKitGraphics.
2624
2625         * WebKit.vcproj/WebKit.def: Added new export.
2626         * WebKit.vcproj/WebKit_debug.def: Ditto.
2627         * WebKitGraphics.cpp:
2628         (RightTruncateStringToWidth): Added.
2629         * WebKitGraphics.h: Added declaration.
2630
2631 2007-02-28  Adam Roben  <aroben@apple.com>
2632
2633         Reviewed by Anders.
2634
2635         Made WebKitGraphics more flexible.
2636
2637         * WebDragClient.cpp:
2638         (WebDragClient::createDragImageForLink): Updated for changes to
2639         WebKitGraphics/WebCoreTextRenderer.
2640         * WebKit.vcproj/WebKit.def: Added new exported methods.
2641         * WebKit.vcproj/WebKit_debug.def: Ditto.
2642         * WebKitGraphics.cpp:
2643         (makeFont): Added.
2644         (DrawTextAtPoint): Simplified arguments, changed to take a
2645         CGContextRef, and updated for WebCoreTextRenderer changes.
2646         (TextFloatWidth): Added.
2647         (FontMetrics): Added.
2648         (CenterTruncateStringToWidth): Added.
2649         * WebKitGraphics.h: Updated declarations.
2650
2651 2007-02-28  Steve Falkenburg  <sfalken@apple.com>
2652
2653         Fix build (for new SDK) / Break build (for old SDK)
2654
2655         * WebDownload.cpp:
2656         (WebDownload::initToResumeWithBundle):
2657
2658 2007-02-27  Ada Chan  <adachan@apple.com>
2659
2660         Reviewed by Steve and Adam.
2661         
2662         WebKitWin changes to get the aqua scrollbar into the app.
2663
2664         * Interfaces/IWebScrollBarDelegatePrivate.idl: Added.
2665         COM interface for the WebKit scrollbar
2666         * Interfaces/IWebScrollBarPrivate.idl: Added.
2667         COM interface that allows the WebKit scrollbar to update the client.
2668         * Interfaces/WebKit.idl:
2669         * WebKit.vcproj/Interfaces.vcproj:
2670         * WebKit.vcproj/WebKit.vcproj:
2671         * WebKit.vcproj/WebKitGUID.vcproj:
2672         * WebKitClassFactory.cpp:
2673         (WebKitClassFactory::CreateInstance):
2674         Added changes needed to create the WebKitScrollBar through COM
2675         * WebKitDLL.cpp:
2676         (DllGetClassObject):
2677         * WebScrollBar.cpp: Added.
2678         WebKitScrollBar wraps the WebCore's PlatformScrollbar.  This allows the app to
2679         make its own scroll bar that's the same aqua scrollbar in the engine.
2680         (WebScrollBar::WebScrollBar):
2681         (WebScrollBar::~WebScrollBar):
2682         (WebScrollBar::createInstance):
2683         (WebScrollBar::QueryInterface):
2684         (WebScrollBar::AddRef):
2685         (WebScrollBar::Release):
2686         (WebScrollBar::init): instantiate PlatformScrollbar.
2687         (WebScrollBar::setEnabled): call through to PlatformScrollbar
2688         (WebScrollBar::setSteps): ditto
2689         (WebScrollBar::setProportion): ditto
2690         (WebScrollBar::setRect): ditto
2691         (WebScrollBar::setValue): ditto
2692         (WebScrollBar::value): ditto
2693         (WebScrollBar::capturingMouse): ditto
2694         (WebScrollBar::paint): ditto
2695         (WebScrollBar::frameGeometry): ditto
2696         (WebScrollBar::width): ditto
2697         (WebScrollBar::height): ditto
2698         (WebScrollBar::handleMouseEvent): ditto
2699         (WebScrollBar::scroll): ditto
2700         (WebScrollBar::valueChanged): call valueChanged on the delegate
2701         (WebScrollBar::windowClipRect): get the rect from the scrollbar's containing window
2702         * WebScrollBar.h: Added.
2703
2704 2007-02-27  Alice Liu  <alice.liu@apple.com>
2705
2706         Reviewed by Steve, Adam, Maciej, and their mothers.
2707
2708         This is a general leaks fix but helps the effort towards fixing
2709         <rdar://4974495> Boomer leaks while running HTML iBench
2710         However, this fix doens't close that bug. 
2711
2712         * WebFrame.cpp:
2713         (WebFrame::setTitle):
2714             fix a leak of WebHistory
2715         * WebHistory.cpp:
2716         (_WebCoreHistoryProvider::containsItemForURLUnicode):
2717             fix a leak of WebHistory
2718
2719 2007-02-27  Adam Roben  <aroben@apple.com>
2720
2721         Reviewed by Anders.
2722
2723         Fix <rdar://problem/5004615> View source menu option is always disabled
2724         when Netscape 8 is installed
2725
2726         The bug was caused by Netscape's npTrident.dll plugin, which registers
2727         itself as a handler for text/html and text/xml.
2728
2729         * WebFrame.cpp:
2730         (WebFrame::canProvideDocumentSource): Explicitly allow viewing the
2731         source of HTML and XML documents, rather than disallowing text, image,
2732         and plugin documents. Plugins can register themselves as handlers for
2733         HTML and XML MIME types, but we still want to display source in those
2734         cases.
2735
2736 2007-02-27  Beth Dakin  <bdakin@apple.com>
2737
2738         Reviewed by Adam.
2739
2740         Make msimg32.lib available to the engine so that we can use 
2741         AlphaBlend.
2742
2743         * WebKit.vcproj/WebKit.vcproj:
2744
2745 2007-02-27  Ada Chan  <adachan@apple.com>
2746
2747         Fixed build.
2748
2749         * WebFrame.cpp:
2750
2751 2007-02-27  Oliver Hunt  <oliver@apple.com>
2752
2753         Reviewed by Lou and Steve.
2754         
2755         Handle the WM_CURSOR message to stop cursor flickering
2756         to fix <rdar://problem/4788352>
2757
2758         * WebView.cpp:
2759         (WebViewWndProc):
2760
2761 2007-02-27  Ada Chan  <adachan@apple.com>
2762
2763         Reviewed by Steve and Anders.
2764
2765         <rdar://4983106> Stop/reload button never changes back to
2766         reload when a click on a link spawns a download
2767
2768         * WebError.cpp:
2769         (WebError::isPolicyChangeError): fixed string comparison
2770         * WebFrame.cpp:
2771         (WebFrame::interruptForPolicyChangeError): implemented the method
2772
2773 2007-02-26  Adam Roben  <aroben@apple.com>
2774
2775         Reviewed by Adele.
2776
2777         Stop bizarre crashes from happening on startup.
2778
2779         * WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.
2780
2781 2007-02-24  Steve Falkenburg  <sfalken@apple.com>
2782
2783         Pre-emptive build fix.
2784         Removed CGPThreads DLL copy
2785
2786         * WebKit.vcproj/WebKit.vcproj:
2787
2788 2007-02-22  Adele Peterson  <adele@apple.com>
2789
2790         Updating this file to match WebCore.
2791
2792         * WebKit.vcproj/textAreaResizeCorner.png:
2793
2794 2007-02-22  Beth Dakin  <bdakin@apple.com>
2795
2796         Reviewed by Adam.
2797
2798         Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION: 
2799         Unable to prevent default context menu from appearing. <rdar://
2800         problem/5017416>
2801
2802         * WebView.cpp:
2803         (WebView::handleContextMenuEvent): Clear the controller's context 
2804         menu before propagating a new context menu event through the DOM.
2805
2806 2007-02-22  Oliver Hunt  <oliver@apple.com>
2807
2808         Reviewed by Ada, Lou, and Steve.
2809
2810         Last of the major changes for drag and drop
2811         - Move COMPtr.h to WebCore
2812         - Added WebDragSource, a modified version of SDataSource from the App
2813           that can notify a WebView's eventhandler of drag events
2814         - Implement the last bits of the DragClient
2815         - As part of drag client added code to draw the "doubled" text used by
2816           drag links.  May be useful for other parts of WebKit/App
2817         
2818         * COMPtr.h: Removed.
2819           Moving to WebCore
2820         * WebDragClient.cpp:
2821         (WebDragClient::actionMaskForDrag):
2822         (WebDragClient::willPerformDragDestinationAction):
2823         (WebDragClient::dragSourceActionMaskForPoint):
2824         (WebDragClient::willPerformDragSourceAction):
2825           Removing WebCore:: as i'm now using the WebCore namespace
2826         (WebDragClient::startDrag):
2827           Implemented client method
2828         (allocImage):
2829         (dragLabelFont):
2830           Helper functions for generating the link dragging image
2831         (WebDragClient::createDragImageForLink):
2832           Implemented client method
2833           
2834         * WebDropSource.cpp: Added.
2835         (WebDropSource::createInstance):
2836         (WebDropSource::WebDropSource):
2837         (WebDropSource::QueryInterface):
2838         (WebDropSource::AddRef):
2839         (WebDropSource::Release):
2840         (generateMouseEvent):
2841           Generates a mouse event for the EventHandler
2842         (WebDropSource::QueryContinueDrag):
2843         (WebDropSource::GiveFeedback):
2844           Copied from SDataObject in the App.  Minor changes per suggestions
2845           from Ada and Steve (error codes, potential leaks)
2846           Also includes logic to notify the source WebView of drag events (moving 
2847           and drag end)
2848           
2849         * WebDropSource.h: Added.
2850           Header for the above
2851           
2852         * WebKit.vcproj/WebKit.vcproj:
2853           Removing COMPtr.h, and adding WebDropSource.{h,cpp}
2854           
2855         * WebKitGraphics.cpp:
2856         (DrawDoubledTextAtPoint):
2857           Utility function for drawing double text, as used by link dragging image
2858           
2859         * WebKitGraphics.h:
2860           Defining the above function
2861
2862 2007-02-21  Brady Eidson  <beidson@apple.com>
2863
2864         Reviewed by the build-fix fairies
2865
2866         * WebDownload.cpp:
2867         (WebDownload::initToResumeWithBundle): Conditionally use CFURLDownload API for the resume case.
2868          I totally made up the flag
2869
2870 2007-02-21  Brady Eidson  <beidson@apple.com>
2871
2872         Reviewed by Anders' rubberstamp
2873         
2874         * WebDownload.cpp:
2875         (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate
2876          so it doesn't affect the original
2877
2878 2007-02-21  Brady Eidson  <beidson@apple.com>
2879
2880         Reviewed by Adam
2881
2882         <rdar://problem/4964763> - Hookup resume downloads on the engine side
2883         
2884         NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires 
2885         a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later
2886         
2887         * WebDownload.cpp:
2888         (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks
2889         (WebDownload::initToResumeWithBundle): Added a real implementation - this now works!
2890         (WebDownload::didFinish): Added some logging and fixed up some lifetime issues
2891         (extractResumeDataFromBundle): Renamed to imply the modification of the file.  Truncate
2892           the resume data from the file once it is extracted
2893
2894 2007-02-20  Beth Dakin  <bdakin@apple.com>
2895
2896         Reviewed by Maciej.
2897
2898         Move copyImage functionality from the ContextMenuClient to the 
2899         Pasteboard.
2900
2901         * WebContextMenuClient.cpp:
2902         * WebContextMenuClient.h:
2903
2904 2007-02-20  Adam Roben  <aroben@apple.com>
2905
2906         Reviewed by Darin and Anders.
2907
2908         Fix <rdar://problem/5003318> App: Status bar text is more difficult to
2909         read than Mac OS X Safari
2910
2911         * WebKitGraphics.cpp:
2912         (DrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
2913         * WebKitGraphics.h: Ditto.
2914
2915 2007-02-20  Darin Adler  <darin@apple.com>
2916
2917         Reviewed by Anders.
2918
2919         * WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to
2920         FrameLoader and DocumentLoader.
2921
2922 2007-02-19  Adam Roben  <aroben@apple.com>
2923
2924         Reviewed by Darin.
2925
2926         Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru
2927
2928         The fix for the bug was to zero out WebFrame's Frame pointer in
2929         WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
2930         non-null as appropriate. All IWebFrame methods that depend on the Frame
2931         pointer will return E_FAIL if it is null, and everywhere within
2932         WebFrame that wasn't null-checking before will now explicitly ASSERT.
2933
2934         I also changed all uses of d->frame and WebFrame::impl() to use the
2935         core() function for consistency, and so that there is only one code
2936         path for getting from a WebFrame to a Frame.
2937
2938         Additional more specific comments below.
2939
2940         * WebChromeClient.cpp:
2941         (WebChromeClient::scrollBackingStore):
2942         (WebChromeClient::updateBackingStore):
2943         * WebFrame.cpp:
2944         (kit): Null-check the frame parameter.
2945         (core): Added two overloads of this.
2946         (WebFrame::DOMDocument): Added argument checking.
2947         (WebFrame::currentForm):
2948         (WebFrame::loadRequest):
2949         (WebFrame::loadData):
2950         (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null.
2951         (WebFrame::provisionalDataSource): Ditto.
2952         (WebFrame::stopLoading):
2953         (WebFrame::reload):
2954         (WebFrame::parentFrame):
2955         (WebFrame::renderTreeAsExternalRepresentation): Added argument checking.
2956         (WebFrame::firstLayoutDone): Ditto.
2957         (WebFrame::loadType): Ditto.
2958         (WebFrame::invalidate):
2959         (WebFrame::setTextSizeMultiplier):
2960         (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT.
2961         (WebFrame::setInViewSourceMode): Changed to return an HRESULT.
2962         (WebFrame::searchForLabelsBeforeElement): Added argument checking.
2963         (WebFrame::matchLabelsAgainstElement): Ditto.
2964         (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed.
2965         (WebFrame::createFrame):
2966         (WebFrame::loadURLIntoChild): Added some assertions.
2967         (WebFrame::dispatchWillSubmitForm):
2968         (WebFrame::frameLoadCompleted):
2969         (WebFrame::receivedData):
2970         (WebFrame::setUpPolicyListener):
2971         (WebFrame::receivedPolicyDecision):
2972         (WebFrame::dispatchDecidePolicyForMIMEType):
2973         (WebFrame::dispatchDecidePolicyForNewWindowAction):
2974         (WebFrame::dispatchDecidePolicyForNavigationAction):
2975         (WebFrame::dispatchCreatePage):
2976         (WebFrame::createPlugin):
2977         (WebFrame::redirectDataToPlugin):
2978         (WebFrame::createJavaAppletWidget):
2979         (WebFrame::windowObjectCleared):
2980         (WebFrame::setPrinting):
2981         (WebFrame::setInPrintingMode):
2982         (WebFrame::computePageRects):
2983         (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding.
2984         (WebFrame::spoolPages):
2985         (WebFrame::forceLayoutWithPageWidthRange):
2986         * WebFrame.h:
2987         * WebView.cpp:
2988         (WebView::paint): Silently fail on a null Frame, because this method could be called at any time.
2989         (WebView::mouseWheel): Ditto.
2990         (WebViewWndProc): Ditto.
2991         (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns.
2992         (WebView::setInViewSourceMode): Ditto.
2993         (WebView::setCustomTextEncodingName): Replaced check for a null
2994         FrameLoader with a check for a null Frame, which is equivalent but, as
2995         a bonus, won't crash.
2996         (WebView::stringByEvaluatingJavaScriptFromString):
2997         (WebView::elementAtPoint): Added argument checking.
2998         (WebView::selectedText): Ditto.
2999         (WebView::centerSelectionInVisibleArea):
3000
3001 2007-02-19  Adam Roben  <aroben@apple.com>
3002
3003         Build fix.
3004
3005         * WebFrame.cpp:
3006         (WebFrame::computePageRects):
3007
3008 2007-02-18  Maciej Stachowiak  <mjs@apple.com>
3009
3010         Reviewed by Oliver.
3011
3012         - Adapt for Lars's patch to clean up Frame
3013
3014         * WebChromeClient.cpp:
3015         (WebChromeClient::tabsToLinks):
3016         (WebChromeClient::windowResizerRect):
3017         (WebChromeClient::addToDirtyRegion):
3018         (WebChromeClient::scrollBackingStore):
3019         (WebChromeClient::updateBackingStore):
3020         * WebChromeClient.h:
3021         * WebEditorClient.cpp:
3022         (WebEditorClient::shouldChangeSelectedRange):
3023         (WebEditorClient::textFieldDidBeginEditing):
3024         (WebEditorClient::textFieldDidEndEditing):
3025         (WebEditorClient::textDidChangeInTextField):
3026         (WebEditorClient::doTextFieldCommandFromEvent):
3027         (WebEditorClient::textWillBeDeletedInTextField):
3028         (WebEditorClient::textDidChangeInTextArea):
3029         * WebEditorClient.h:
3030         * WebElementPropertyBag.cpp:
3031         (WebElementPropertyBag::Read):
3032         * WebFrame.cpp:
3033         (kit):
3034         (WebFrame::initWithWebFrameView):
3035         (WebFrame::searchForLabelsBeforeElement):
3036         (WebFrame::matchLabelsAgainstElement):
3037         (WebFrame::createPlugin):
3038         (WebFrame::createJavaAppletWidget):
3039         (WebFrame::computePageRects):
3040         (WebFrame::getPrintedPageCount):
3041         (WebFrame::spoolPages):
3042         * WebFrame.h:
3043         * WebView.cpp:
3044         (WebView::handleEditingKeyboardEvent):
3045         (WebView::keyDown):
3046         (WebView::generateSelectionImage):
3047         * WebView.h:
3048
3049 2007-02-18  Ada Chan  <adachan@apple.com>
3050
3051         Reviewed by Adam.
3052         
3053         Move app text controls to use webview
3054
3055         * DOMCoreClasses.cpp:
3056         (DOMNode::parentNode): implemented
3057         (DOMElement::blur): implemented
3058         * Interfaces/IWebUIDelegatePrivate.idl: added API for focus/blur notifications
3059         * WebKit.vcproj/WebKit.def: added DrawTextAtPoint
3060         * WebKit.vcproj/WebKit.vcproj: added WebKitGraphics.h/cpp
3061         * WebKit.vcproj/WebKit_debug.def: added DrawTextAtPoint
3062         * WebKitGraphics.cpp: Added.
3063         (DrawTextAtPoint): calls WebCoreDrawTextAtPoint to render text
3064         * WebKitGraphics.h: Added.
3065         * WebView.cpp:
3066         (WebViewWndProc): notify setfocus and killfocus through IWebUIDelegatePrivate delegate.
3067         (WebView::unmarkAllTextMatches): added null check
3068
3069 2007-02-18  Oliver Hunt  <oliver@apple.com>
3070
3071         Reviewed by Adam.
3072
3073         Stubs to keep the build going
3074
3075         * WebDragClient.cpp:
3076         (WebDragClient::willPerformDragSourceAction):
3077         (WebDragClient::startDrag):
3078         (WebDragClient::createDragImageForLink):
3079         * WebDragClient.h:
3080
3081 2007-02-17  Steve Falkenburg  <sfalken@apple.com>
3082
3083         Reviewed by Adam.
3084
3085         <rdar://problem/4918821> Find: clicking on the webview does not hide findoverlay
3086         <rdar://problem/4956428> Find: Showing/hiding the Find banner should not push the page contents down when possible
3087
3088         * Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
3089         * WebView.cpp:
3090         (WebView::scrollOffset): Add null check
3091         (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here)
3092         (WebView::visibleContentRect):  Added so we can size find overlay appropriately (not including scroll bars)
3093         * WebView.h: Added scrollBy, visibleContentRect
3094
3095 2007-02-17  Adele Peterson  <adele@apple.com>
3096
3097         Reviewed by Hyatt.
3098
3099         Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea
3100
3101         * WebView.cpp: (WebView::handleEditingKeyboardEvent):
3102         Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text).
3103         This will also reveal the selection properly.
3104
3105 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
3106
3107         Build fixes.
3108         
3109         * WebDownload.cpp:
3110         (WebDownload::init):
3111         (WebDownload::initWithRequest):
3112
3113 2007-02-15  Steve Falkenburg  <sfalken@apple.com>
3114
3115         Reviewed by Adam.
3116         
3117         <rdar://problem/5001181> Crash: autofilling empty page
3118         
3119         Return an error from WebFrame::DOMDocument if there's no document
3120
3121         * WebFrame.cpp:
3122         (WebFrame::DOMDocument): null document now maps to E_FAIL
3123
3124 2007-02-15  Brady Eidson  <beidson@apple.com>
3125
3126         Reviewed by Adam
3127
3128         <rdar://4778394> - Save scroll position in the back/forward list
3129         
3130         * WebFrame.cpp:
3131         (WebFrame::restoreViewState):  Renamed, as scroll position was pushed to WebCore
3132         (WebFrame::saveViewStateToItem):  Ditto
3133         * WebFrame.h:
3134
3135 2007-02-15  Adam Roben  <aroben@apple.com>
3136
3137         Reviewed by Anders.
3138
3139         Fix <rdar://problem/4968731> Printing scales frames to page width
3140         instead of doing a layout at that width
3141
3142         * Interfaces/IWebFramePrivate.idl: Added setInPrintingMode method.
3143         * WebFrame.cpp:
3144         (WebFrame::WebFrame): Initialize new member.
3145         (printerRect): New helper function.
3146         (WebFrame::setPrinting): Ported from WebHTMLView.
3147         (WebFrame::setInPrintingMode): Implemented.
3148         (WebFrame::computePageRects): Changed to store the page rects.
3149         (WebFrame::getPrintedPageCount): Added an ASSERT and updated for change to computePageRects.
3150         (WebFrame::spoolPages): Use the stored page rects, and set mediaBox's
3151         size using the print rect instead of the page rect so we will scale the
3152         pages to the full width of the print DC.
3153         (WebFrame::forceLayoutWithPageWidthRange): Ported from WebFrameBridge.
3154         * WebFrame.h: Updated declarations.
3155
3156 2007-02-15  Lou Amadio  <lamadio@apple.com>
3157
3158         Reviewed by Steve.
3159
3160         <rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style
3161         
3162         * WebKit.vcproj/WebKit.vcproj:
3163         * WebPreferences.cpp:
3164         (WebPreferences::setFontSmoothing):
3165         * WebView.cpp:
3166         (WebViewWndProc):
3167
3168 2007-02-13  Steve Falkenburg  <sfalken@apple.com>
3169
3170         Reviewed by Adam.
3171         
3172         <rdar://problem/4950378> AddressBook autofill doesn't fill rest of form when tabbing out of a completed field
3173         
3174         Send tab keypresses to IWebFormDelegate::doCommandBySelector.
3175
3176         * WebEditorClient.cpp:
3177         (WebEditorClient::handleKeyPress): Call doTextFieldCommandFromEvent if we get a tab keypress
3178
3179 2007-02-12  Ada Chan  <adachan@apple.com>
3180
3181         Reviewed by Steve.
3182         
3183         Also, checked in a fix in WebContextMenuClient that Adam made on my machine, reviewed by me.
3184
3185         <rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
3186         Inform form delegate about delete key press.
3187         
3188         DOM event fixes:
3189         - Removed DOMEventTarget class.
3190         - IDOMEventTarget no longer extends IDOMObject
3191         - DOMNode now implements IDOMEventTarget
3192         - DOMEvent::CoCreateInstance creates the correct subclasses
3193         of DOMEvents based on the type of event
3194         - Added IDOMDocumentEvent interface, which DOMDocument implements.
3195         - Fixed the out parameter in IDOMUIEvent::view to be IDOMWindow**
3196         
3197         Implemented DOMHTMLDocument::body and DOMHTMLElement::setInnerText.
3198
3199         * DOMCoreClasses.cpp:
3200         (DOMNode::addEventListener): added as DOMNode now needs to implement IDOMEventTarget
3201         (DOMNode::removeEventListener): ditto above
3202         (DOMNode::dispatchEvent): ditto above
3203         (DOMDocument::QueryInterface): DOMDocument now also implements IDOMDocumentEvent
3204         (DOMDocument::createEvent): added as DOMDocument implements IDOMDocumentEvent
3205         (DOMElement::focus): implemented
3206         * DOMCoreClasses.h:
3207         * DOMEventsClasses.cpp:
3208         (DOMEvent::DOMEvent): The data member m_event is now a RefPtr, and the WebCore::Event is now
3209         passed into the constructor via a PassRefPtr.
3210         (DOMEvent::~DOMEvent): No longer need to deref m_event since we are using a RefPtr.
3211         (DOMEvent::createInstance): instantiate the correct DOMEvent subclass based on event type.
3212         (DOMEvent::QueryInterface): be able to QI IID_DOMEvent, which returns back the DOMEvent type.
3213         (DOMUIEvent::view): fixed the API
3214         (DOMKeyboardEvent::ctrlKey): call .get() on RefPtr
3215         (DOMKeyboardEvent::shiftKey): ditto above
3216         (DOMKeyboardEvent::altKey): ditto above
3217         (DOMKeyboardEvent::metaKey): ditto above
3218         (DOMKeyboardEvent::altGraphKey): ditto above
3219         (DOMMouseEvent::ctrlKey): ditto above
3220         (DOMMouseEvent::shiftKey): ditto above
3221         (DOMMouseEvent::altKey): ditto above
3222         (DOMMouseEvent::metaKey): ditto above
3223         * DOMEventsClasses.h:
3224         (DOMEvent::coreEvent): Added an API to get the WebCore::Event out of a DOMEvent.  Used in DOMNode::dispatchEvent.
3225         (DOMUIEvent::DOMUIEvent): made public so it can be called in DOMEvent::createInstance
3226         (DOMKeyboardEvent::DOMKeyboardEvent): ditto above
3227         (DOMKeyboardEvent::view): fixed API
3228         (DOMMouseEvent::DOMMouseEvent): made public so it can be called in DOMEvent::createInstance
3229         (DOMMouseEvent::view): fixed API
3230         (DOMMutationEvent::DOMMutationEvent): made public so it can be called in DOMEvent::createInstance
3231         (DOMOverflowEvent::DOMOverflowEvent): made public so it can be called in DOMEvent::createInstance
3232         (DOMWheelEvent::DOMWheelEvent): made public so it can be called in DOMEvent::createInstance
3233         (DOMWheelEvent::view): fixed API
3234         * DOMHTMLClasses.cpp:
3235         (DOMHTMLDocument::body):
3236         (DOMHTMLElement::setInnerText):
3237         * Interfaces/DOMEvents.idl: IDOMEventTarget no longer extends IDOMObject.  Added IDOMDocumentEvent.
3238         * WebContextMenuClient.cpp:
3239         (WebContextMenuClient::getCustomMenuFromDefaultItems): check for error from calling contextMenuItemsForElement.
3240         * WebFrame.cpp:
3241         (WebFrame::textWillBeDeletedInTextField): call form delegate callback doCommandBySelector with VK_BACK 
3242         when deleting text.
3243
3244 2007-02-11  Adam Roben  <aroben@apple.com>
3245
3246         Fixing line endings.
3247
3248         * WebResource.cpp:
3249         * WebResource.h:
3250
3251 2007-02-10  Adam Roben  <aroben@apple.com>
3252
3253         Reviewed by Steve.
3254
3255         Fix <rdar://problem/4989705> Loading eBay puts many items into back list
3256
3257         The bug was that WebFrame::createFrame was calling loadRequest on the
3258         new child frame, which would initiate a load of FrameLoadTypeStandard,
3259         when in fact we wanted to do a FrameLoadTypeInternal load. I ported
3260         -[WebFrame _loadURL:referrer:intoChild:] to WebFrame, which contains
3261         the logic we need.
3262
3263         * WebFrame.cpp:
3264         (WebFrame::createFrame): Use a COMPtr to manage the new WebFrame, and
3265         call loadURLIntoChild instead of just calling loadRequest.
3266         (WebFrame::loadURLIntoChild): Ported from Mac WebFrame.
3267         * WebFrame.h: Added declaration.
3268
3269 2007-02-09  Maciej Stachowiak  <mjs@apple.com>
3270
3271         Reviewed by Adam, Steve.
3272         
3273         - fixed <rdar://problem/4976975> Need WEbKit API to revtrieve current or first frame and form from a WebView
3274
3275         * Interfaces/IWebFrame.idl: added currentForm
3276         * Interfaces/IWebView.idl: added focusedFrame
3277         * WebFrame.cpp:
3278         (WebFrame::currentForm): Get the "current" form for a frame,
3279         as determined by WebCore::Frame
3280         * WebFrame.h:
3281         * WebView.cpp:
3282         (WebView::focusedFrame): Get the currently focused frame
3283         (via FocusController).
3284         * WebView.h:
3285
3286 2007-02-09  Alice Liu  <alice.liu@apple.com>
3287
3288         Reviewed by Brady and Adam.
3289
3290         Fixed <rdar://4986194> Typing in content editable body does not automatically scroll to reveal cursor
3291         fix depends on corresponding fix in WebCoreWin
3292
3293         * WebView.cpp:
3294         (WebViewWndProc):
3295         call the editor to handle inserting text and scrolling/focus changes
3296
3297 2007-02-09  John Sullivan  <sullivan@apple.com>
3298
3299         Reviewed by Beth
3300
3301         - WebKitWin part of fix for radar 4939636, problems with context menu items and binaries linked
3302           against WebKit 2.0.
3303
3304         * Interfaces/IWebUIDelegate.idl:
3305         bumped enum value for new SPI tags to match change in WebCore/WebKit
3306
3307 2007-02-08  Alice Liu  <alice.liu@apple.com>
3308
3309         Reviewed by Adam.
3310
3311         Fixed <rdar://4920436> Find: Regression: Find banner does not select in orange on pages with frame
3312
3313         * WebView.cpp:
3314         (WebView::searchFor):
3315         Ever since 11396, the widget no longer handles frame focus changes.
3316         This is now the page's focus controller responsibility
3317
3318 2007-02-07  Brady Eidson  <beidson@apple.com>
3319
3320         Reviewed by Steve, Ada, Darin, and Adam
3321         
3322         <rdar://problem/4964763> - Download resume support
3323         
3324         Note I did my work with a ToT CFNetwork.  
3325         This will compile on stock CFNetwork, but will not function until they submit resume support.
3326         
3327         * Interfaces/IWebDownload.idl:  Reworked the API a bit
3328         
3329         * MarshallingHelpers.cpp:
3330         (MarshallingHelpers::PathStringToFileCFURLRef):
3331         (MarshallingHelpers::FileCFURLRefToPathString):
3332         * MarshallingHelpers.h:
3333
3334         * WebDownload.cpp:
3335         (WebDownload::initToResumeWithBundle): The app needs simply to pass in a bundle path to resume it
3336         (WebDownload::cancelForResume): Cancel the download, writing out the resume data
3337         (WebDownload::bundlePathForTargetPath): Helper for the app
3338         (WebDownload::setDestination): Cache the destination inside the WebDownload
3339         (WebDownload::didCreateDestination): Hide the bundle distinction from the app
3340         (WebDownload::didFinish): Hide the bundle distinction from the app
3341         (createResumeDataFromBundle): Extract the resume data from the bundle
3342         (appendResumeDataToBundle): Add the resume data to the bundle
3343         * WebDownload.h:
3344
3345 2007-02-08  Anders Carlsson  <acarlsson@apple.com>
3346
3347         Reviewed by Adam.
3348
3349         <rdar://problem/4972772>
3350         Implement IWebResource::Data.
3351         
3352         <rdar://problem/4972777>
3353         Implement IWebDataSource::subresourceForURL.
3354         
3355         * MemoryStream.cpp:
3356         (MemoryStream::MemoryStream):
3357         (MemoryStream::createInstance):
3358         (MemoryStream::Clone):
3359         * MemoryStream.h:
3360         Remove notion of buffer owner, it's not needed now that the buffer itself is reference counted.
3361         
3362         * WebDataSource.cpp:
3363         (WebDataSource::subresourceForURL):
3364         Implement this.
3365                 
3366         * WebKit.vcproj/WebKit.vcproj:
3367         Add WebResource.cpp and WebResource.h
3368         
3369         * WebResource.cpp: Added.
3370         (WebResource::WebResource):
3371         (WebResource::~WebResource):
3372         (WebResource::createInstance):
3373         (WebResource::QueryInterface):
3374         (WebResource::AddRef):
3375         (WebResource::Release):
3376         (WebResource::initWithData):
3377         (WebResource::data):
3378         (WebResource::URL):
3379         (WebResource::MIMEType):
3380         (WebResource::textEncodingName):
3381         (WebResource::frameName):
3382         * WebResource.h: Added.
3383         
3384         * WebView.cpp:
3385         (WebView::formDelegate):
3386         Return E_FAIL if there's no form delegate.
3387
3388 2007-02-08  Anders Carlsson  <acarlsson@apple.com>
3389
3390         Reviewed by Adam.
3391
3392         Add shouldInterruptJavaScript to the API.
3393         
3394         * Interfaces/IWebUIDelegatePrivate.idl:
3395         * WebChromeClient.cpp:
3396         (WebChromeClient::addMessageToConsole):
3397         (WebChromeClient::shouldInterruptJavaScript):
3398
3399 2007-02-07  Anders Carlsson  <acarlsson@apple.com>
3400
3401         * WebChromeClient.cpp:
3402         * WebChromeClient.h:
3403         Build fix.
3404         
3405 2007-02-06  Alice Liu  <alice.liu@apple.com>
3406
3407         Reviewed by Maciej.
3408
3409         Fix for <rdar://4973323> PageUp/PageDown don't move the caret in textareas
3410
3411         * WebView.cpp:
3412         (WebView::keyDown):
3413         added key entry for function to scroll by page and move 
3414         caret in scrolling editable regions
3415
3416 2007-02-06  Adam Roben  <aroben@apple.com>
3417
3418         Reviewed by Ada and Oliver.
3419         
3420         Add some GDI object logging to help catch leaks.
3421
3422         * WebFrame.cpp:
3423         (WebFrame::layoutIfNeeded):
3424         * WebView.cpp:
3425         (WebView::addToDirtyRegion):
3426         (WebView::scrollBackingStore):
3427         (WebView::updateBackingStore):
3428         (WebView::paint):
3429         (WebView::paintIntoBackingStore):
3430         (WebView::paintIntoWindow):
3431
3432 2007-02-05  Brady Eidson  <beidson@apple.com>
3433
3434         Rubberstamped by Adam
3435         
3436         Added #include "config.h" to 3 files that didn't have it before
3437         I was tipped off when some work I was doing resulted in these 3 files
3438         trying to use the wrong MAX() - YET AGAIN...
3439
3440         * CFDictionaryPropertyBag.cpp:
3441         * MarshallingHelpers.cpp:
3442         * WebHistory.cpp:
3443
3444 2007-02-05  Ada Chan  <adachan@apple.com>
3445
3446         Reviewed by Anders.
3447         
3448         <rdar://4945519> Crash when back/forward buttons are clicked several times
3449         Clear loader's previous history item when frame load is completed (got that code from the mac side).
3450
3451         * WebFrame.cpp:
3452         (WebFrame::frameLoadCompleted):
3453
3454 2007-02-04  Ada Chan  <adachan@apple.com>
3455
3456         Reviewed by Steve.
3457         
3458         <rdar://4946475> Private browsing is not working correctly
3459         Implemented FrameLoaderClient::privateBrowsingEnabled().
3460
3461         * WebFrame.cpp:
3462         (WebFrame::privateBrowsingEnabled):
3463
3464 2007-02-04  Alice Liu  <alice.liu@apple.com>
3465
3466         Reviewed by Steve.
3467
3468         Fix some memory leaks.  This fixes WebFrame leak as well. 
3469         Can be considered a partial fix for <rdar://4974495> Boomer leaks while running HTML iBench
3470
3471         * WebActionPropertyBag.cpp:
3472         (WebActionPropertyBag::WebActionPropertyBag):
3473         * WebDataSource.cpp:
3474         (WebDataSource::representation):
3475         * WebURLResponse.cpp:
3476         (:m_refCount):
3477
3478 2007-02-04  Adam Roben  <aroben@apple.com>
3479
3480         Reviewed by Steve.
3481
3482         Fix <rdar://problem/4972498> REGRESSION: Crash while closing View Source window
3483
3484         * WebView.cpp:
3485         (WebView::WebView): Initialize new member.
3486         (WebViewWndProc): Set flag when we receive WM_DESTROY, and don't handle
3487         WM_SIZE if that flag is true.
3488         (WebView::mainFrame): Added argument check.
3489         * WebView.h:
3490         (WebView::setIsBeingDestroyed): Added.
3491         (WebView::isBeingDestroyed): Added.
3492
3493 2007-02-04  Adam Roben  <aroben@apple.com>
3494
3495         Reviewed by Hyatt.
3496
3497         Fix <rdar://problem/4968183> Cross-window frame targeting doesn't work
3498
3499         * Interfaces/IWebView.idl: Pass RECT by value.
3500         * WebView.cpp:
3501         (WebView::initWithFrame): Uses the passed-in RECT for the frame, and
3502         sets the frame/group names.
3503         * WebView.h: Updated declaration.
3504
3505 2007-02-03  Steve Falkenburg  <sfalken@apple.com>
3506
3507         Reviewed by Adam.
3508         
3509         <rdar://problem/4930947> Regression: History is not saved when boomer window is closed.
3510         
3511         Fix boolean test causing lost history regression.
3512
3513         * WebHistoryItem.cpp:
3514         (WebHistoryItem::hasURLString): isEmpty returns true if there is NO url, not if there is one.
3515
3516 2007-02-02  Alice Liu  <alice.liu@apple.com>
3517
3518         Reviewed by Maciej.
3519
3520         Fixed <rdar://4956286> Find: Deleting all text in the Find banner search field should clear the page's selection
3521
3522         * Interfaces/IWebView.idl:
3523         * WebView.cpp:
3524         (WebView::clearSelection):
3525         * WebView.h:
3526             Added a clearSelection function to webview so the findbanner can call it. 
3527
3528 2007-02-02  Adam Roben  <aroben@apple.com>
3529
3530         Reviewed by Anders.
3531
3532         Fix a crash when running the PLT.
3533
3534         * WebView.cpp:
3535         (WebView::initWithFrame):
3536             Added assertions to make catching this easier.
3537
3538 2007-02-01  Ada Chan  <adachan@apple.com>
3539
3540         Reviewed by Anders.
3541         
3542         Forgot to assign document to 0 in case of failure in WebView::mainFrameDocument().
3543
3544         * WebView.cpp:
3545         (WebView::mainFrameDocument):
3546
3547 2007-02-01  Ada Chan  <adachan@apple.com>
3548
3549         Reviewed by Steve, Geoff.
3550         
3551         <rdar://4969341> Regression: crash: when Resetting Safari
3552         <rdar://4953390> Closing my two open boomer windows produced a crash
3553         Fixed crash when closing second window and doing the close 
3554         all safari window option in Reset Safari.
3555
3556         * WebFrame.cpp:
3557         WebFramePrivate has a pointer to frameView but does not hold a reference
3558         to it.  The frame holds a ref to the frameView anyway, so it's safest to get
3559         the frameView through the frame.  The crash happened because frame already has
3560         cleared out its frameView but WebFrame was still accessing the old stale frameView
3561         through that data member in WebFramePrivate.
3562         (WebFrame::WebFramePrivate::m_policyFunction):
3563         (WebFrame::WebFramePrivate::frameView):
3564         (WebFrame::initWithWebFrameView):
3565         (WebFrame::layoutIfNeeded):
3566         (WebFrame::hasFrameView):
3567         * WebView.cpp:
3568         (WebView::paintIntoBackingStore): bail if frameView is null.
3569         (WebView::setHostWindow): don't set the view window's parent to 0.
3570         It'll end up creating a standalone window.
3571
3572 2007-02-01  Anders Carlsson  <acarlsson@apple.com>
3573
3574         Reviewed by Adam.
3575
3576         <rdar://problem/4969348>
3577         REGRESSION: Crash loading pdf
3578         
3579         * WebView.cpp:
3580         (WebView::canShowMIMEType):
3581         Return true if the MIME type can be handled by a plug-in.
3582
3583 2007-02-01  Adam Roben  <aroben@apple.com>
3584
3585         Reviewed by Steve.
3586
3587         Fix <rdar://problem/4849601> Implement printing of individual subframes
3588
3589         This just moves some functions from IWebViewPrivate to IWebFramePrivate.
3590
3591         * Interfaces/IWebFramePrivate.idl: Added declarations.
3592         * Interfaces/IWebViewPrivate.idl: Removed declarations.
3593         * WebFrame.cpp: Added functions from WebView.cpp.
3594         (WebFrame::computePageRects):
3595         (WebFrame::getPrintedPageCount):
3596         (WebFrame::spoolPages):
3597         * WebFrame.h: Added declarations.
3598         * WebView.cpp: Moved functions to WebFrame.cpp.
3599         * WebView.h: Removed declarations.
3600
3601 2007-01-31  Ada Chan  <adachan@apple.com>
3602
3603         Reviewed by Adam.
3604         
3605         Adam and I found a missing retain on WebFrame::setUpPolicyListener().  The mac
3606         code returns a RefPtr which retains it, but we are returning the raw pointer.
3607         Changed the code to return a COMPtr.  Without this change, loading bogus urls
3608         will crash.
3609
3610         * WebFrame.cpp:
3611         (WebFrame::dispatchWillSubmitForm):
3612         (WebFrame::setUpPolicyListener):
3613         (WebFrame::dispatchDecidePolicyForMIMEType):
3614         (WebFrame::dispatchDecidePolicyForNewWindowAction):
3615         (WebFrame::dispatchDecidePolicyForNavigationAction):
3616         * WebFrame.h:
3617
3618 2007-01-31  Ada Chan  <adachan@apple.com>
3619
3620         Reviewed by Anders.
3621         
3622         Implement WebView::mainFrameDocument.
3623
3624         * WebView.cpp:
3625         (WebView::mainFrameDocument):
3626
3627 2007-01-31  Steve Falkenburg  <sfalken@apple.com>
3628
3629         Reviewed by Ada.
3630