Windows build fixes
[WebKit-https.git] / WebKit / win / ChangeLog
1 2008-07-14  Adam Roben  <aroben@apple.com>
2
3         Windows build fix
4
5         * WebJavaScriptCollector.cpp:
6         (WebJavaScriptCollector::objectCount): Updated to match
7         -[WebCoreStatistics javaScriptsObjectCount].
8
9 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
10
11         Reviewed by Geoff Garen.
12
13         Eliminate per-thread JavaScript global data instance support and make arbitrary
14         global data/global object combinations possible.
15
16         * WebCoreStatistics.cpp:
17         (WebCoreStatistics::javaScriptObjectsCount):
18         (WebCoreStatistics::javaScriptGlobalObjectsCount):
19         (WebCoreStatistics::javaScriptProtectedObjectsCount):
20         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
21         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
22
23 2008-07-11  Steve Falkenburg  <sfalken@apple.com>
24
25         Build fix.
26
27         * WebKit.vcproj/WebKit.vcproj:
28
29 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
30
31         Build fix.
32
33         * WebKit.vcproj/Interfaces.vcproj:
34
35 2008-07-10  Adam Roben  <aroben@apple.com>
36
37         Windows build fix
38
39         * WebKit.vcproj/resource.h: Revert some changes that VS made to this
40         file in r35083.
41
42 2008-07-09  Maxime Britto  <britto@apple.com>
43
44         Reviewed by Adele.
45        
46         Added the panning icon in the ressources.
47         Its name is compass.png to make a difference with moveCursor.png (from the WebCore ressources)
48
49         * ChangeLog:
50         * WebKit.vcproj/WebKit.rc:
51         * WebKit.vcproj/panIcon.png: Added.
52         * WebKit.vcproj/resource.h:
53         * WebKitDLL.cpp: Declared the new ressource with the name "panIcon"
54         (loadResourceIntoBuffer):
55
56 2008-07-02  Dan Bernstein  <mitz@apple.com>
57
58         - try to fix the Windows build
59
60         * WebScriptCallFrame.cpp:
61
62 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
63
64         Reviewed by Darin.
65
66         Disable JSLock for per-thread contexts.
67
68         * WebCoreStatistics.cpp:
69         (WebCoreStatistics::javaScriptObjectsCount):
70         (WebCoreStatistics::javaScriptGlobalObjectsCount):
71         (WebCoreStatistics::javaScriptProtectedObjectsCount):
72         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
73         * WebScriptCallFrame.cpp:
74         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
75         * WebView.cpp:
76         (WebView::stringByEvaluatingJavaScriptFromString):
77         Pass a parameter (false) to JSLock to indicate that WebKit doesn't need locking.
78         Include JSLock.h, as it is no longer brought in implicitly.
79
80 2008-06-27  Adam Roben  <aroben@apple.com>
81
82         Change WebKitGraphics truncation functions to return the length of the
83         truncated string
84
85         Reviewed by Darin Adler.
86
87         * WebKitGraphics.cpp:
88         (CenterTruncateStringToWidth):
89         (RightTruncateStringToWidth):
90         Return the length.
91         * WebKitGraphics.h:
92         The truncation functions now return an unsigned int that is the length
93         of the truncated string. The whole file has been marked extern "C" to
94         keep the symbols for these functions from changing (which would break
95         nightly builds).
96
97 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
98
99         Windows build fix.
100
101         * WebJavaScriptCollector.cpp: Added a missing include.
102
103 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
104
105         Reviewed by Darin.
106
107         Prepare JavaScript heap for being per-thread.
108
109         * WebCoreStatistics.cpp:
110         (WebCoreStatistics::javaScriptObjectsCount):
111         (WebCoreStatistics::javaScriptGlobalObjectsCount):
112         (WebCoreStatistics::javaScriptProtectedObjectsCount):
113         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
114         * WebJavaScriptCollector.cpp:
115         (WebJavaScriptCollector::objectCount):
116         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
117
118         * WebScriptCallFrame.cpp:
119         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Pass ExecState* where
120         now required.
121
122 2008-06-16  Alexey Proskuryakov  <ap@webkit.org>
123
124         Trying to fix Windows build.
125
126         * WebScriptCallFrame.cpp:
127         (WebScriptCallFrame::variableNames):
128         (WebScriptCallFrame::valueForVariable):
129         Give ExecState to functions that now take it.
130
131 2008-06-16  Adam Roben  <aroben@apple.com>
132
133         Windows build fix
134
135         * WebScriptCallFrame.cpp: Fixed a header name.
136
137 2008-06-15  Darin Adler  <darin@apple.com>
138
139         - give Frame object functions shorter names: scriptProxy() -> script(),
140           selectionController() -> selection(), animationController() -> animation()
141
142         * WebFrame.cpp:
143         (WebFrame::globalContext):
144         (WebFrame::windowObjectCleared):
145         * WebView.cpp:
146         (WebView::handleContextMenuEvent):
147         (WebViewWndProc):
148         (WebView::updateFocusedAndActiveState):
149         (WebView::hasSelectedRange):
150         (WebView::replaceSelectionWithText):
151         (WebView::clearSelection):
152         (WebView::prepareCandidateWindow):
153         (WebView::onIMERequestCharPosition):
154         (WebView::onIMERequestReconvertString):
155
156 2008-06-15  Darin Adler  <darin@apple.com>
157
158         - rename KJS::List to KJS::ArgList
159
160         * WebScriptCallFrame.cpp:
161         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
162
163 2008-06-15  Darin Adler  <darin@apple.com>
164
165         - new names for a few key JavaScriptCore files
166
167         * WebView.cpp:
168
169 2008-06-15  Darin Adler  <darin@apple.com>
170
171         Rubber stamped by Sam.
172
173         - use JS prefix and simpler names for basic JavaScriptCore types,
174           to complement JSValue and JSObject
175
176         * WebScriptCallFrame.cpp:
177         (WebScriptCallFrame::functionName):
178
179 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
180
181         Rubber stamped by Oliver.
182         
183         - fix WebKit solution for testkjs --> jsc rename
184
185         * WebKit.vcproj/WebKit.sln:
186
187 2008-06-14  Darin Adler  <darin@apple.com>
188
189         Rubber stamped by Sam.
190
191         - new names for kjs_binding.h and kjs_proxy.h
192
193         * WebFrame.cpp:
194
195 2008-06-14  Darin Adler  <darin@apple.com>
196
197         Rubber stamped by Sam.
198
199         - renamed HTMLGenericFormElement to HTMLFormControlElement
200
201         * WebFrame.cpp:
202         (WebFrame::elementWithName):
203         (WebFrame::controlsInForm):
204
205 2008-06-14  Darin Adler  <darin@apple.com>
206
207         - try to fix Windows build, again
208
209         * WebFrame.cpp:
210         (WebFrame::dispatchDecidePolicyForNewWindowAction): Fix arguments. Pass form.
211         (WebFrame::dispatchDecidePolicyForNavigationAction): Ditto.
212         * WebFrame.h: Fix arguments.
213
214 2008-06-14  Darin Adler  <darin@apple.com>
215
216         - try to fix Windows build
217
218         * WebActionPropertyBag.cpp:
219         (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
220         * WebFrame.h: Added missing FormState arguments.
221         * WebScrollBar.cpp:
222         (WebScrollBar::init): Use create instead of new.
223
224 2008-06-14  Darin Adler  <darin@apple.com>
225
226         Reviewed by Sam.
227
228         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
229           start ref counts at 1 instead of 0 for speed
230
231         * WebCoreSupport/WebFrameLoaderClient.cpp:
232         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
233         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
234         conventional ones without a special case.
235
236         * WebFrame.cpp:
237         (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused
238         IWebFrameView argument (every caller was passing 0). Also changed this to return the
239         WebCore Frame object, which is needed to straighten out the lifetime and ownership
240         issues.
241         * WebFrame.h: Ditto.
242
243         * WebView.cpp:
244         (WebView::initWithFrame): Changed to call new init function and use the return value.
245
246 2008-06-13  Darin Adler  <darin@apple.com>
247
248         Reviewed by John Sullivan.
249
250         - updated for addition of FormState argument to action policy functions
251         - added WebActionFormKey
252
253         * Interfaces/IWebPolicyDelegate.idl:
254         * WebActionPropertyBag.cpp:
255         (WebActionPropertyBag::WebActionPropertyBag):
256         (WebActionPropertyBag::createInstance):
257         (WebActionPropertyBag::AddRef):
258         (WebActionPropertyBag::Release):
259         (WebActionPropertyBag::Read):
260         * WebActionPropertyBag.h:
261         * WebFrame.cpp:
262         (WebFrame::dispatchDecidePolicyForNewWindowAction):
263         (WebFrame::dispatchDecidePolicyForNavigationAction):
264
265 2008-06-07  Darin Adler  <darin@apple.com>
266
267         Reviewed by Mitz.
268
269         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
270           start ref counts at 1 instead of 0 for speed
271
272         * WebHistoryItem.cpp:
273         (WebHistoryItem::createInstance):
274         (WebHistoryItem::initFromDictionaryRepresentation):
275         (WebHistoryItem::initWithURLString):
276
277 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
278
279         Registry-free COM.        
280         
281         WebKit no longer requires COM registration.
282         Registry-free COM information is read from the application manifest.
283
284         Only 1 set of CLSIDs are now used, since we don't need to worry about registry collisions.
285         The second set remains, but only temporarily so nightlies continue to work.
286
287         This is supported for XPSP2 and later.  Earlier systems require an installer
288         to write the required registry keys.  Nightlies and developer builds require
289         XPSP2, Server 2003, or later.
290
291         Reviewed by Adam.
292
293         * ForEachCoClass.cpp: Moved COM registration code here from WebKitDLL.cpp. This is ONLY used in the nightly case.
294         (substituteGUID): Moved here from WebKitDLL.cpp.
295         (registerWebKit): Moved here from WebKitDLL.cpp.
296         (setUseOpenSourceWebKit): Call registerWebKit instead of swapping progids. There is only 1 set of progids now - for the nightly.
297         * ForEachCoClass.h: Removed production progids. 
298         * Interfaces/WebKit.idl: Added prototype for shutDownWebKit.
299         * WebKit.vcproj/Interfaces.vcproj: Changed path to type library to move it out of project directory.
300         * WebKit.vcproj/WebKit.vcproj: Changed path to type library to move it out of project directory.
301         * WebKitDLL.cpp:
302         (DllUnregisterServer): Does nothing. Entry point is still present for backward compatibility.
303         (DllRegisterServer): Does nothing. Entry point is still present for backward compatibility.
304         (RunAsLocalServer): Does nothing. Entry point is still present for backward compatibility.
305         (shutDownWebKit): Moved from ForEachCoClass.
306         * WebKitDLL.h:
307
308 2008-05-29  Anders Carlsson  <andersca@apple.com>
309
310         Reviewed by Brady.
311
312         <rdar://problem/5970312> 
313         icon file specified for stand alone web app causes crash if the icon can't be found
314         
315         Handle the case where iconData is null.
316
317         * WebIconFetcher.cpp:
318         (WebIconFetcherClient::finishedFetchingIcon):
319
320 2008-05-22  Anders Carlsson  <andersca@apple.com>
321
322         Reviewed by Adam.
323
324         Add IWebIconFetcher interface and implementation.
325         
326         * Interfaces/IWebFramePrivate.idl:
327         * Interfaces/IWebIconFetcher.idl: Added.
328         * Interfaces/WebKit.idl:
329         * WebFrame.cpp:
330         * WebFrame.h:
331         * WebIconFetcher.cpp: Added.
332         * WebIconFetcher.h: Added.
333         * WebKit.vcproj/WebKit.vcproj:
334
335 2008-05-22  Adam Roben  <aroben@apple.com>
336
337         Add functions to IWebInspector to start/stop profiling/debugging
338
339         <rdar://5956403>
340
341         Reviewed by Jon Honeycutt.
342
343         * Interfaces/IWebInspector.idl:
344         * WebInspector.cpp:
345         (WebInspector::isDebuggingJavaScript):
346         (WebInspector::toggleDebuggingJavaScript):
347         (WebInspector::isProfilingJavaScript):
348         (WebInspector::toggleProfilingJavaScript):
349         * WebInspector.h:
350
351 2008-05-22  Steve Falkenburg  <sfalken@apple.com>
352
353         Build fix.
354
355         * Interfaces/IWebInspector.idl:
356         * Interfaces/WebKit.idl:
357         * WebInspector.cpp:
358         (WebInspector::unused1):
359         * WebInspector.h:
360
361 2008-05-22  Timothy Hatcher  <timothy@apple.com>
362
363         Changes to keep Windows building.
364
365         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
366
367         Reviewed by Adam Roben.
368
369         * English.lproj/Localizable.strings: Added new strings.
370         * WebInspector.cpp:
371         (WebInspector::showConsole): Call showPanel.
372         * WebInspector.h:
373
374 2008-05-21  Adele Peterson  <adele@apple.com>
375
376         Reviewed by Adam.
377
378         WebKit part of for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
379         
380         * WebCoreSupport/WebChromeClient.cpp:
381         (WebChromeClient::focus): Call updateActiveState directly.
382          Normally this would happen on a timer, but JS might need to know this earlier, so we'll update here.        
383         (WebChromeClient::unfocus): ditto.
384         * WebView.cpp: (WebView::updateActiveStateSoon): Added comment about why we use a timer for this.
385
386 === End merge of squirrelfish ===
387
388 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
389
390         Reviewed by Oliver Hunt.
391         
392         Updated for new JS debugging APIs.
393
394         * WebScriptDebugServer.cpp:
395         (WebScriptDebugServer::didParseSource):
396         (WebScriptDebugServer::failedToParseSource):
397         * WebScriptDebugServer.h:
398
399 2008-05-09  Oliver Hunt  <oliver@apple.com>
400
401         Reviewed by Geoff.
402
403         Build fixes for SquirrelFish on windows.
404
405         * WebScriptCallFrame.cpp:
406         (callingFunctionOrGlobalExecState):
407         (WebScriptCallFrame::caller):
408         (WebScriptCallFrame::functionName):
409         (WebScriptCallFrame::variableNames):
410         (WebScriptCallFrame::valueForVariable):
411         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
412         * WebScriptDebugServer.cpp:
413         (WebScriptDebugServer::willLeaveCallFrame):
414
415 2008-05-19  Adam Roben  <aroben@apple.com>
416
417         Make WebKit.idl rebuild whenever any of its included interfaces are
418         changed
419
420         Reviewed by Tim Hatcher.
421
422         * WebKit.vcproj/DerivedSources.make: Touch WebKit.idl whenever any
423         other IDL file is changed. This will force VS to rebuild WebKit.idl.
424
425 2008-05-19  Anders Carlsson  <andersca@apple.com>
426
427         Reviewed by Adam.
428
429         <rdar://problem/5946454>
430         Support navigator.onLine from HTML5.
431         
432         Link with iphlpapi.lib, and make iphlpapi.dll a delay loaded library.
433         
434         * WebKit.vcproj/WebKit.vcproj:
435
436 === Start merge of squirrelfish ===
437
438 2008-05-19  Anders Carlsson  <andersca@apple.com>
439
440         Reviewed by Darin, Alexey, Jess and Brady.
441
442         Set the application cache path.
443         
444         * WebView.cpp:
445         (WebKitSetApplicationCachePathIfNecessary):
446         New function that sets the cache path.
447         
448         (WebView::initWithFrame):
449         Set the application cache path.
450         
451 2008-05-19  Ada Chan  <adachan@apple.com>
452
453         Added IWebCookieManager interface which allows client to set the
454         CFHTTPCookieStorageRef that WebCore should use.
455         
456         Implement IWebCookieManager interface in WebCookieManager.
457         
458         Update the cookie accept policy in the current cookie storage.
459
460         Reviewed by Steve Falkenburg.
461
462         * ForEachCoClass.h:
463         * Interfaces/IWebCookieManager.idl: Added.
464         * Interfaces/WebKit.idl:
465         * WebCookieManager.cpp: Added.
466         (WebCookieManager::createInstance):
467         (WebCookieManager::WebCookieManager):
468         (WebCookieManager::~WebCookieManager):
469         (WebCookieManager::QueryInterface):
470         (WebCookieManager::AddRef):
471         (WebCookieManager::Release):
472         (WebCookieManager::cookieStorage):
473         (WebCookieManager::setCookieStorage):
474         * WebCookieManager.h: Added.
475         * WebKit.vcproj/WebKit.vcproj:
476         * WebKitClassFactory.cpp:
477         * WebView.cpp:
478         (updateSharedSettingsFromPreferencesIfNeeded):
479
480 2008-05-16  Stephanie Lewis  <slewis@apple.com>
481
482         Reviewed by Steve.
483
484         Get pending unload event count from WebCore.
485
486         * Interfaces/IWebFramePrivate.idl:
487         * WebFrame.cpp:
488         (WebFrame::pendingFrameUnloadEventCount):
489         * WebFrame.h:
490
491 2008-05-16  Matt Lilek  <webkit@mattlilek.com>
492
493         Rubber stamped by Oliver.
494
495         Remove the Drosera sub-project.
496
497         * WebKit.vcproj/WebKit.sln:
498
499 2008-05-16  Brady Eidson  <beidson@apple.com>
500
501         Reviewed by Steve Falkenburg
502         
503         <rdar://problem/5942624> - Get LocalStorage persistence working on Windows
504         
505         * WebPreferenceKeysPrivate.h: Add the LocalStorageDirectory defaults key
506         
507         * WebPreferences.cpp:
508         (WebPreferences::initializeDefaultSettings):
509         (WebPreferences::localStorageDatabasePath):
510         (WebPreferences::setLocalStorageDatabasePath):
511         * WebPreferences.h:
512         * Interfaces/IWebPreferencesPrivate.idl:
513
514         * WebView.cpp:
515         (WebView::initWithFrame): Set the path in the WebCore::Settings after new Page creation
516
517 2008-05-06  Brady Eidson  <beidson@apple.com>
518
519         Reviewed by Tim Hatcher
520
521         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
522         before setting the page group of the new page.
523
524         Since I still need to add the local storage path to WebPreferences on Windows, mark this with a FIXME for now.
525
526         * WebView.cpp:
527         (WebView::initWithFrame): Mark an important FIXME for setting the LocalStorage path as
528           appropriate.  Until this FIXME is handled, Windows will have no persistent LocalStorage
529
530 2008-05-14  Adam Roben  <aroben@apple.com>
531
532         Fix Bug 18767: Inspector is currently pretty much useless on Windows
533
534         <https://bugs.webkit.org/show_bug.cgi?id=18767>
535
536         Reviewed by Tim Hatcher.
537
538         * WebCoreSupport/WebInspectorClient.cpp:
539         (WebInspectorClient::highlight): Only move the highlight behind the
540         Inspector window when first creating the highlight, not every time we
541         update it.
542
543 2008-05-13  Adam Roben  <aroben@apple.com>
544
545         Neuter WebScriptDebugServer
546
547         Some upcoming changes to JavaScriptDebugServer and
548         JavaScriptDebugListener will break WebScriptDebugServer. Since Drosera
549         is being replaced by the Inspector's debugger, and Drosera is the only
550         client of WebScriptDebugServer, it makes more sense to get rid of
551         WebScriptDebugServer than to update it to keep it working.
552
553         We can't actually remove WebScriptDebugServer entirely yet, so I've
554         just made it non-functional. This will completely break Drosera, but
555         as stated above, Drosera's days are numbered anyway.
556
557         Reviewed by Tim Hatcher and Kevin McCullough.
558
559         * WebCoreSupport/WebFrameLoaderClient.cpp:
560         (WebFrameLoaderClient::dispatchDidLoadMainResource): Removed all code
561         in this function.
562         * WebKitDLL.cpp:
563         (LocalServerDidDie): Ditto.
564         * WebScriptDebugServer.cpp: Made all IWebScriptDebugServer functions
565         return E_NOTIMPL.
566         * WebScriptDebugServer.h: Removed everything but the
567         IWebScriptDebugServer functions.
568
569 2008-05-12  Dan Bernstein  <mitz@apple.com>
570
571         - build fix
572
573         * Interfaces/WebKit.idl: Touched.
574
575 2008-05-12  Dan Bernstein  <mitz@apple.com>
576
577         Reviewed by Ada Chan.
578
579         - WebKit/win changes for https://bugs.webkit.org/show_bug.cgi?id=17097
580           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
581
582         Added font cache statistics and a function to purge inactive font data.
583
584         * Interfaces/IWebCoreStatistics.idl:
585         * WebCoreStatistics.cpp:
586         (WebCoreStatistics::cachedFontDataCount):
587         (WebCoreStatistics::cachedFontDataInactiveCount):
588         (WebCoreStatistics::purgeInactiveFontData):
589         (WebCoreStatistics::glyphPageCount):
590         * WebCoreStatistics.h:
591
592 2008-05-12  Adam Roben  <aroben@apple.com>
593
594         Build fix
595
596         * WebKitPrefix.cpp: Touch this so that it will rebuild after
597         ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
598
599 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
600
601         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
602         SquirrelFish merging.
603
604         * WebCoreStatistics.cpp:
605         (WebCoreStatistics::javaScriptObjectsCount):
606         (WebCoreStatistics::javaScriptGlobalObjectsCount):
607         (WebCoreStatistics::javaScriptProtectedObjectsCount):
608         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
609         * WebJavaScriptCollector.cpp:
610         (WebJavaScriptCollector::objectCount):
611         * WebScriptCallFrame.cpp:
612         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
613
614 2008-05-09  Brady Eidson  <beidson@apple.com>
615
616         Reviewed by Adam Roben
617
618         Fix a hang-on-quit bug where in the DLL_PROCESS_DETACH DllMain callback, we assummed that
619         we could cleanly shutdown WebKit but we couldn't because any background threads have already
620         been uncleanly aborted at that point.
621         
622         * ForEachCoClass.cpp:
623         (shutDownWebKit): Moved from WebKitDLL to here, to be exposed via WebKit.def
624         * ForEachCoClass.h:
625         
626         * WebKit.vcproj/WebKit.def:
627         * WebKit.vcproj/WebKit_debug.def:
628         
629         * WebKitDLL.cpp:
630         (DllMain): Don't call shutDownWebKit here
631
632 2008-05-09  Sam Weinig  <sam@webkit.org>
633
634         Rubber-stamped by Mark Rowe.
635
636         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
637
638         * WebKit.vcproj/WebKit.vcproj:
639
640 2008-05-09  Adam Roben  <aroben@apple.com>
641
642         Build fix
643
644         * Interfaces/WebKit.idl: Touched.
645
646 2008-05-06  Alice Liu  <alice.liu@apple.com>
647
648         Reviewed by Adele Peterson and John Sullivan.
649
650         changes needed to build on Windows after r32911 and r32927
651
652         * AccessibleBase.cpp:
653         (AccessibleBase::get_accParent):
654         * AccessibleDocument.cpp:
655         (AccessibleDocument::document):
656
657 2008-05-06  Brady Eidson  <beidson@apple.com>
658
659         Reviewed by Darin Adler
660
661         Preparation for upcoming work making LocalStorage persistent.
662
663         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
664
665         * WebKitDLL.cpp:
666         (shutDownWebKit): Close all LocalStorage areas before quitting.
667
668 2008-05-05  Anders Carlsson  <andersca@apple.com>
669
670         Reviewed by John.
671
672         Add preference for enabling the offline web application cache.
673         
674         * Interfaces/IWebPreferencesPrivate.idl:
675         * WebPreferenceKeysPrivate.h:
676         * WebPreferences.cpp:
677         (WebPreferences::initializeDefaultSettings):
678         (WebPreferences::setOfflineWebApplicationCacheEnabled):
679         (WebPreferences::offlineWebApplicationCacheEnabled):
680         * WebPreferences.h:
681         * WebView.cpp:
682         (WebView::notifyPreferencesChanged):
683
684 2008-05-05  Sam Weinig  <sam@webkit.org>
685
686         Reviewed by Tim Hatcher.
687
688         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
689
690         * WebCoreSupport/WebInspectorClient.cpp:
691         (WebInspectorClient::localizedStringsURL):
692
693 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
694
695         Add WebPreference for application chrome mode.
696         
697         Reviewed by Dave Hyatt.
698
699         * Interfaces/IWebPreferencesPrivate.idl:
700         * WebPreferenceKeysPrivate.h:
701         * WebPreferences.cpp:
702         (WebPreferences::initializeDefaultSettings):
703         (WebPreferences::inApplicationChromeMode):
704         (WebPreferences::setApplicationChromeMode):
705         * WebPreferences.h:
706         * WebView.cpp:
707         (WebView::notifyPreferencesChanged):
708
709 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
710
711         Reviewed by Geoffrey Garen.
712
713         https://bugs.webkit.org/show_bug.cgi?id=18826
714         Make JavaScript heap per-thread
715
716         * WebCoreStatistics.cpp:
717         (WebCoreStatistics::javaScriptObjectsCount):
718         (WebCoreStatistics::javaScriptGlobalObjectsCount):
719         (WebCoreStatistics::javaScriptProtectedObjectsCount):
720         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
721         * WebJavaScriptCollector.cpp:
722         (WebJavaScriptCollector::objectCount):
723         * WebScriptCallFrame.cpp:
724         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
725         Replaced static Collector calls with calls to a current thread's instance. Pass ExecState to jsString().
726
727 2008-04-29  Ada Chan  <adachan@apple.com>
728
729         Support text shadow in WebDrawText().
730         Remove DrawTextAtPoint() since it is only called by WebDrawText().
731
732         Reviewed by Adam.
733
734         * WebKit.vcproj/WebKit.def:
735         * WebKit.vcproj/WebKit_debug.def:
736         * WebKitGraphics.cpp:
737         (WebDrawText):
738         * WebKitGraphics.h:
739
740 2008-04-29  Adam Roben  <aroben@apple.com>
741
742         Restore the beloved COMPtr::operator&
743
744 2008-04-29  Adam Roben  <aroben@apple.com>
745
746         Windows build fix
747
748         Replaced uses of COMPtr::operator& with COMPtr::adoptionPointer.
749
750 2008-04-29  Adam Roben  <aroben@apple.com>
751
752         Fix a Windows build error
753
754         * WebScriptCallFrame.cpp:
755         (WebScriptCallFrame::variableNames): Don't use ::adopt now that
756         PropertyNameArray has no swap function.
757
758 2008-04-28  Adam Roben  <aroben@apple.com>
759
760         Fix some Windows build errors in WebKit
761
762         * Interfaces/WebKit.idl: Touched to force Interfaces to rebuild.
763         * WebKitPrefix.cpp: Touched to force WebKit to rebuild.
764
765 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
766
767         Reviewed by Darin.
768
769         Fix run-webkit-tests --threading
770         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
771         Proxy server issue in Sunday's Nightly
772
773         * WebView.cpp: (WebView::WebView): Initialize threading. Previously, this was only done from
774         icon database code, which is not robust enough.
775
776 2008-04-26  Adam Barth <hk9565@gmail.com>
777
778         Reviewed by Adam Roben and Sam Weinig.
779
780         Renamed "domain" method to "host" to match SecurityOrigin.
781
782         * Interfaces/IWebSecurityOrigin.idl:
783         * WebSecurityOrigin.cpp:
784         (WebSecurityOrigin::host):
785         * WebSecurityOrigin.h:
786
787 2008-04-25  Anders Carlsson  <andersca@apple.com>
788
789         Reviewed by Adam.
790
791         Fix internal debug build.
792         
793         * WebKit.vcproj/WebKit.vcproj:
794
795 2008-04-24  Dan Bernstein  <mitz@apple.com>
796
797         - build fix
798
799         * WebView.cpp:
800         (WebView::handleContextMenuEvent):
801
802 2008-04-24  Brady Eidson  <beidson@apple.com>
803
804         Reviewed by Darin
805
806         Revert my previous change to WebKit/Win until I can make it act more like the new Mac code
807
808         * WebView.cpp:
809         (WebView::initWithFrame):
810
811 2008-04-24  Anders Carlsson  <andersca@apple.com>
812
813         Reviewed by Sam.
814
815         Change some String arguments to be const references instead.
816
817         * WebCoreSupport/WebEditorClient.cpp:
818         (WebEditorClient::shouldInsertText):
819         * WebCoreSupport/WebEditorClient.h:
820
821 2008-04-23  Brady Eidson  <beidson@apple.com>
822
823         Reviewed by Sam Weinig
824
825         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
826         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
827         thereby populating the Settings object, immediately after the Page is created.
828
829         * WebView.cpp:
830         (WebView::initWithFrame): Post the notification right after the Page is created
831
832 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
833
834         Reviewed by Brady.
835
836         Implement accDoDefaultAction().
837
838         * AccessibleBase.cpp:
839         (AccessibleBase::accDoDefaultAction): Call the object's
840         performDefaultAction() method. Return S_FALSE if the call returns false,
841         indicating that the object has no default action associated with it.
842
843 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
844
845         Reviewed by Adam.
846
847         Implement accHitTest().
848
849         * AccessibleBase.cpp:
850         (AccessibleBase::accHitTest): Perform a hit test for a child object. If
851         none is found, report whether the point was within our own bounding box.
852
853 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
854
855         Reviewed by Adam and Darin.
856
857         Implement accNavigate().
858
859         * AccessibleBase.cpp:
860         (AccessibleBase::accNavigate): This method navigates between elements,
861         given a start point and a direction. The directions UP, DOWN, LEFT,
862         RIGHT are not are not implemented, matching Mozilla and IE. The
863         directions FIRSTCHILD and LASTCHILD are only allowed from self. NEXT and
864         PREVIOUS are allowed from self or any of our children.
865
866 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
867
868         Reviewed by Adam.
869
870         Implement accLocation().
871
872         * AccessibleBase.cpp:
873         (AccessibleBase::accLocation): Report the screen coordinates for the
874         object's bounding box.
875
876 2008-04-23  Jon Honeycutt  <jhoneycutt@apple.com>
877
878         Reviewed by Adam, Darin, Oliver.
879
880         Implement get_accDefaultAction().
881
882         * AccessibleBase.cpp:
883         (AccessibleBase::get_accDefaultAction): Report the result of calling the
884         object's actionVerb method.
885         * English.lproj/Localizable.strings: Updated with new strings.
886         * WebCoreLocalizedStrings.cpp: 
887         (WebCore::AXButtonActionVerb): Return a localized string representing
888         the object's default action.
889         (WebCore::AXRadioButtonActionVerb): Same.
890         (WebCore::AXTextFieldActionVerb): Same.
891         (WebCore::AXCheckedCheckBoxActionVerb): Same
892         (WebCore::AXUncheckedCheckBoxActionVerb): Same.
893         (WebCore::AXLinkActionVerb): Same.
894
895 2008-04-23  Daniel Zucker  <zucker@wake3.com>
896
897         Reviewed by Adam Roben.
898
899         <https://bugs.webkit.org/show_bug.cgi?id=18468>
900
901         * WebError.h:  include RetainPtr.h to fix build errors in Cairo build
902
903 2008-04-23  Daniel Zucker  <zucker@wake3.com>
904
905         Reviewed by Adam Roben.
906
907         Move the location of #if USE(CFNETWORK) to fix a cairo/curl build error.
908         <https://bugs.webkit.org/show_bug.cgi?id=18470>
909
910         * WebError.cpp:
911         (WebError::sslPeerCertificate):
912
913 2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>
914
915         Reviewed by Adam.
916
917         Implement get_accFocus().
918
919         * AccessibleBase.cpp:
920         (AccessibleBase::get_accRole): Remove redundant initialization;
921         VariantInit does this.
922         (AccessibleBase::get_accState): Same.
923         (AccessibleBase::get_accSelection): Relocated next to accSelect().
924         (AccessibleBase::get_accFocus): If the focused object is this object or
925         a child of this object, report it. Otherwise, report VT_EMPTY.
926
927 2008-04-22  Jon Honeycutt  <jhoneycutt@apple.com>
928
929         Reviewed by Sam.
930
931         Implement get_accKeyboardShortcut().
932
933         * AccessibleBase.cpp:
934         (AccessibleBase::get_accKeyboardShortcut): Report the key combination
935         that will perform the object's access key action, represented as a
936         string.
937
938 2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>
939
940         Reviewed by Darin.
941
942         Implement get_accHelp().
943
944         * AccessibleBase.cpp:
945         (AccessibleBase::get_accHelp): Report the result of calling the object's
946         helpText() method.
947
948 2008-04-19  Jon Honeycutt  <jhoneycutt@apple.com>
949
950         Reviewed by Darin.
951
952         Implement get_accState().
953
954         * AccessibleBase.cpp:
955         (AccessibleBase::get_accState):
956
957 2008-04-21  Alexey Proskuryakov  <ap@webkit.org>
958
959         Reviewed by Darin.
960
961         Move collector main thread initialization from WebKit/win to KJS::initializeThreading.
962
963         * WebView.cpp:
964         (WebView::WebView):
965
966 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
967
968         Reviewed by Darin.
969
970         Implement get_accRole().
971
972         * AccessibleBase.cpp:
973         (AccessibleBase::get_accRole): Report the result of role().
974         (MSAARole): Added; returns the MSAA role for a WebCore role.
975         (AccessibleBase::role): Return the MSAA role for the object's roleValue.
976         * AccessibleBase.h: Add declaration for role().
977
978 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
979
980         Reviewed by Darin.
981
982         Implement get_accName(), get_accValue(), get_accDescription(). Added
983         virtual methods that accessible objects can override to customize the
984         result.
985
986         * AccessibleBase.cpp:
987         (AccessibleBase::get_accName): Report result of name().
988         (AccessibleBase::get_accValue): Report result of value().
989         (AccessibleBase::get_accDescription): Report result of description().
990         (AccessibleBase::name): Added; returns AccessibilityObject::title().
991         (AccessibleBase::value): Added; returns
992         AccessibilityObject::stringValue().
993         (AccessibleBase::description): Added; returns
994         AccessibilityObject::accessibilityDescription().
995         * AccessibleBase.h: Added declarations for name(), value(), and
996         description().
997         * ChangeLog: Fix my misuse of "definition."
998
999 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
1000
1001         Fix build after r32231.
1002
1003         * WebFrame.cpp:
1004         (WebFrame::renderTreeAsExternalRepresentation): renderer() ->
1005         contentRenderer()
1006
1007 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
1008
1009         Fix build after r32231.
1010
1011         * WebView.cpp:
1012         (WebView::paintIntoBackingStore): renderer() -> contentRenderer()
1013         (WebView::elementAtPoint): Same.
1014
1015 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
1016
1017         * AccessibleBase.cpp: Build fix for copy/paste error.
1018
1019 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
1020
1021         Reviewed by Darin.
1022
1023         Implement IAccessible::get_accChild().
1024
1025         * AccessibleBase.cpp:
1026         (AccessibleBase::get_accChild): Call getAccessibilityObjectForChild
1027         to find the AccessibilityObject for the VARIANT vChild. Get the
1028         AccessibilityObjectWrapper for the child, add a ref, and pass it back.
1029         (AccessibleBase::getAccessibilityObjectForChild): Added; finds the
1030         AccessibilityObject referred to by a VARIANT, or returns a COM error on
1031         failure.
1032         (AccessibleBase::wrapper): Added; returns the wrapper for the
1033         AccessibilityObject. Creates one if necessary.
1034         * AccessibleBase.h: Added declarations for wrapper() and
1035         getAccessibilityObjectForChild().
1036
1037 2008-04-18  Jon Honeycutt  <jhoneycutt@apple.com>
1038
1039         Reviewed by Darin, Ollie. 
1040
1041         * AccessibleBase.cpp:
1042         (AccessibleBase::get_accChildCount): Implement get_accChildCount.
1043
1044 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
1045
1046         Reviewed by Darin.
1047
1048         Implement IAccessible::get_accParent(). 
1049
1050         * AccessibleBase.cpp:
1051         (AccessibleBase::get_accParent): Call AccessibleObjectFromWindow with
1052         OBJID_WINDOW. This will be handled by Windows to return the default
1053         accessible object for the WebView, because we only handle OBJID_CLIENT.
1054         * WebView.cpp:
1055         (WebView::AccessibleObjectFromWindow): Added; calls through to the
1056         AccessibleObjectFromWindow in the MSAA DLL.
1057         * WebView.h: Added declaration for AccessibleObjectFromWindow.
1058
1059 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
1060
1061         Reviewed by Darin.
1062
1063         Return an AccessibleDocument when our root accessible object is queried
1064         for.
1065
1066         * AccessibleDocument.cpp: Added; represents an AccessibilityObject that
1067         itself represents a Document.
1068         (AccessibleDocument::AccessibleDocument): Initialize AccessibleBase with
1069         the AccessibilityObject for this Document.
1070         * AccessibleDocument.h: Added.
1071         * WebFrame.cpp:
1072         (WebFrame::accessible): If m_accessible is 0, or if Document in this
1073         frame does not match the Document in the cached m_accessible object,
1074         create a new AccessibleDocument for this frame's Document.
1075         * WebFrame.h: Swap AccessibleBase.h for AccessibleDocument.h
1076         * WebKit.vcproj/WebKit.vcproj: Add AccessibleDocument.{h,cpp}
1077
1078 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
1079
1080         Reviewed by Darin.
1081
1082         Respond to WM_GETOBJECT messages. Currently returns NULL.
1083
1084         * WebFrame.cpp:
1085         (WebFrame::accessible): Added; will return the root accessible object
1086         for this frame.
1087         * WebFrame.h: Added declaration for accessible().
1088         * WebView.cpp:
1089         (WebViewWndProc): Handle WM_GETOBJECT messages by calling onGetObject().
1090         (WebView::onGetObject): Added; enables the AXObjectCache in WebCore,
1091         queries the top-level frame for its root accessible object, and loads
1092         the MSAA DLL and locates its LresultFromObject function. If calling
1093         LresultFromObject succeeds, it returns a reference to the accessible
1094         object to pass back to Windows. If not, we return false and let Windows
1095         handle the request through DefWindowProc.
1096         * WebView.h: Added declaration for onGetObject().
1097
1098 2008-04-18  Brady Eidson  <beidson@apple.com>
1099
1100         Reviewed by Sam Weinig
1101
1102         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
1103         No reason to do the work twice...
1104
1105         * WebView.cpp:
1106         (WebView::close):
1107
1108 2008-04-18  Adam Roben  <aroben@apple.com>
1109
1110         Update WebScriptDebugServer for JavaScriptDebugListener changes
1111
1112         Reviewed by Tim Hatcher.
1113
1114         * WebScriptDebugServer.cpp: Changed to use KJS::UString instead of
1115         WebCore::String.
1116         * WebScriptDebugServer.h: Ditto.
1117
1118 2008-04-16  Jon Honeycutt  <jhoneycutt@apple.com>
1119
1120         Reviewed by Darin.
1121
1122         Add a base AccessibilityObject wrapper class. Currently just stubs all
1123         of the IAccessible methods.
1124
1125         * AccessibleBase.cpp: Added. Implements IAccessible, and inherits from
1126         WebCore::AccessibilityObjectWrapper.
1127         (AccessibleBase::AccessibleBase): Set the object's wrapper to this
1128         instance. 
1129         (AccessibleBase::~AccessibleBase):
1130         (AccessibleBase::createInstance): Create an instance of a wrapper for
1131         this AccessibilityObject.
1132         (AccessibleBase::QueryInterface):
1133         (AccessibleBase::Release):
1134         (AccessibleBase::get_accParent):
1135         (AccessibleBase::get_accChildCount):
1136         (AccessibleBase::get_accChild):
1137         (AccessibleBase::get_accName):
1138         (AccessibleBase::get_accValue):
1139         (AccessibleBase::get_accDescription):
1140         (AccessibleBase::get_accRole):
1141         (AccessibleBase::get_accState):
1142         (AccessibleBase::get_accHelp):
1143         (AccessibleBase::get_accKeyboardShortcut):
1144         (AccessibleBase::accSelect):
1145         (AccessibleBase::get_accFocus):
1146         (AccessibleBase::get_accSelection):
1147         (AccessibleBase::get_accDefaultAction):
1148         (AccessibleBase::accLocation):
1149         (AccessibleBase::accNavigate):
1150         (AccessibleBase::accHitTest):
1151         * AccessibleBase.h: Added.
1152         (AccessibleBase::AddRef):
1153         (AccessibleBase::put_accName):
1154         (AccessibleBase::put_accValue):
1155         (AccessibleBase::get_accHelpTopic):
1156         (AccessibleBase::GetTypeInfoCount):
1157         (AccessibleBase::GetTypeInfo):
1158         (AccessibleBase::GetIDsOfNames):
1159         (AccessibleBase::Invoke):
1160         (AccessibleBase::detach): Detach this wrapper from its object.
1161         * WebKit.vcproj/WebKit.vcproj:
1162
1163 2008-04-15  Anders Carlsson  <andersca@apple.com>
1164
1165         Reviewed by Adam.
1166
1167         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
1168
1169         * WebKit.vcproj/WebKit.vcproj:
1170
1171 2008-04-12  Matt Lilek  <webkit@mattlilek.com>
1172
1173         Not reviewed, build fix.
1174
1175         * WebView.cpp:
1176         (WebView::paintDocumentRectToContext):
1177
1178 2008-04-11  Steve Falkenburg  <sfalken@apple.com>
1179
1180         Fix caching typo.
1181         
1182         Made this code match the Mac.
1183         
1184         Reviewed by Mark Rowe.
1185
1186         * WebView.cpp:
1187         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
1188
1189 2008-04-11  Adam Roben  <aroben@apple.com>
1190
1191         * ForEachCoClass.h: Added a deprecation notice.
1192
1193 2008-04-11  Adam Roben  <aroben@apple.com>
1194
1195         Fix Bug 18376: r31733 and 27 don't work w/Safari 3.1
1196         
1197         <https://bugs.webkit.org/show_bug.cgi?id=18376>
1198
1199         Rubberstamped by Steve.
1200
1201         * ForEachCoClass.h: Move post-3.1 classes to the end of the
1202         FOR_EACH_COCLASS macro so that pre-3.1 classes will be in the place
1203         Safari expects them to be. We will soon be deprecating
1204         setUseOpenSourceWebKit/progIDForClass because it is clearly very
1205         fragile.
1206
1207 2008-04-10  Ada Chan  <adachan@apple.com>
1208
1209         Added WebCoreStatistics that provides stats on Javascript objects
1210         and IconDatabase.
1211         
1212         Changed WebCache::statistics() to additionally return xsl stylesheets data
1213         and data on live sizes and decoded sizes.
1214
1215         Reviewed by Steve.
1216
1217         * ForEachCoClass.h:
1218         * Interfaces/IWebCoreStatistics.idl: Added.
1219         * Interfaces/WebKit.idl:
1220         * WebCache.cpp:
1221         (WebCache::statistics):
1222         * WebCoreStatistics.cpp: Added.
1223         (WebCoreStatistics::WebCoreStatistics):
1224         (WebCoreStatistics::~WebCoreStatistics):
1225         (WebCoreStatistics::createInstance):
1226         (WebCoreStatistics::QueryInterface):
1227         (WebCoreStatistics::AddRef):
1228         (WebCoreStatistics::Release):
1229         (WebCoreStatistics::javaScriptObjectsCount):
1230         (WebCoreStatistics::javaScriptGlobalObjectsCount):
1231         (WebCoreStatistics::javaScriptProtectedObjectsCount):
1232         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
1233         (WebCoreStatistics::iconPageURLMappingCount):
1234         (WebCoreStatistics::iconRetainedPageURLCount):
1235         (WebCoreStatistics::iconRecordCount):
1236         (WebCoreStatistics::iconsWithDataCount):
1237         * WebCoreStatistics.h: Added.
1238         * WebKit.vcproj/WebKit.vcproj:
1239         * WebKitClassFactory.cpp:
1240
1241 2008-04-09  Steve Falkenburg  <sfalken@apple.com>
1242
1243         Delete backing store (after a delay) when a WebView's top-level parent becomes inactive.
1244
1245         Reviewed by Brady Eidson.
1246
1247         * WebView.cpp:
1248         (WebView::windowReceivedMessage):
1249
1250 2008-04-08  Adam Roben  <aroben@apple.com>
1251
1252         Export callOnMainThread from WebKit.dll
1253
1254         Rubberstamped by Anders.
1255
1256         * WebKit.vcproj/WebKit.def:
1257         * WebKit.vcproj/WebKit_debug.def:
1258
1259 2008-04-08  Adam Roben  <aroben@apple.com>
1260
1261         Move callOnMainThread to WTF
1262
1263         Reviewed by Alexey Proskuryakov.
1264
1265         * WebIconDatabase.cpp: Updated #include
1266
1267 2008-04-08  Steve Falkenburg  <sfalken@apple.com>
1268
1269         Add missing increment/decrement COM class counts to detect leaks.
1270         
1271         Reviewed by Adam Roben.
1272
1273         * CFDictionaryPropertyBag.cpp:
1274         (CFDictionaryPropertyBag::CFDictionaryPropertyBag):
1275         (CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
1276         * CFDictionaryPropertyBag.h:
1277         * HTTPHeaderPropertyBag.cpp:
1278         (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):
1279         (HTTPHeaderPropertyBag::~HTTPHeaderPropertyBag):
1280         * HTTPHeaderPropertyBag.h:
1281         * WebActionPropertyBag.cpp:
1282         (WebActionPropertyBag::WebActionPropertyBag):
1283         (WebActionPropertyBag::~WebActionPropertyBag):
1284         * WebDocumentLoader.cpp:
1285         (WebDocumentLoader::WebDocumentLoader):
1286         (WebDocumentLoader::~WebDocumentLoader):
1287         * WebDropSource.cpp:
1288         (WebDropSource::WebDropSource):
1289         (WebDropSource::~WebDropSource):
1290         * WebDropSource.h:
1291         * WebElementPropertyBag.cpp:
1292         (WebElementPropertyBag::WebElementPropertyBag):
1293         (WebElementPropertyBag::~WebElementPropertyBag):
1294         * WebTextRenderer.cpp:
1295         (WebTextRenderer::WebTextRenderer):
1296         (WebTextRenderer::~WebTextRenderer):
1297
1298 2008-04-07  Brady Eidson  <beidson@apple.com>
1299
1300         Reviewed by John Honeycutt
1301
1302         ENABLE_DOM_STORAGE for Windows
1303
1304         * WebKit.vcproj/WebKit.vcproj:
1305
1306 2008-04-04  Adam Roben  <aroben@apple.com>
1307
1308         Export some more WTF functions from WebKit.dll
1309
1310         Reviewed by Alexey Proskuryakov.
1311
1312         * WebKit.vcproj/WebKit.def:
1313         * WebKit.vcproj/WebKit_debug.def:
1314
1315 2008-04-04  Steve Falkenburg  <sfalken@apple.com>
1316
1317         Only delete the backing store of background windows.
1318
1319         Reviewed by Ada Chan.
1320
1321         * WebView.cpp:
1322         (WebView::WebView):
1323         (WebView::deleteBackingStore):
1324         (WebView::paint): Added active check.
1325         (WebView::deleteBackingStoreSoon):
1326         (WebView::cancelDeleteBackingStoreSoon): Added.
1327         (WebView::active): Added.
1328         (WebView::updateActiveState): Moved active check code from here to active().
1329         * WebView.h:
1330
1331 2008-04-04  Steve Falkenburg  <sfalken@apple.com>
1332
1333         Fix tooltip window leak.
1334         
1335         Explicitly call DestroyWindow on the tooltip.
1336         Destroying its parent won't destroy the tooltip, since it not a WS_CHILD style window.
1337
1338         Reviewed by Ada Chan.
1339
1340         * WebView.cpp:
1341         (WebView::~WebView):
1342
1343 2008-04-04  Steve Falkenburg  <sfalken@apple.com>
1344
1345         Delete backing store after we go 5 seconds without a paint.
1346                 
1347         Timer will be reset if a paint occurs, so this won't negatively impact performance.
1348         
1349         Reviewed by Ada Chan.
1350
1351         * WebView.cpp:
1352         (WebView::paint): Call deleteBackingStoreSoon after paint.
1353         (WebViewWndProc): Add DeleteBackingStoreTimer.
1354         (WebView::deleteBackingStoreSoon): Added.
1355         * WebView.h: Add deleteBackingStoreSoon.
1356
1357 2008-04-04  Ada Chan  <adachan@apple.com>
1358
1359         <rdar://problem/5830598> Image file opened in the browser window shows "Localized String Not Found' in window's title bar instead file name
1360         Save WebCoreLocalizedStrings.cpp with UTF8 encoding.
1361         Changed the format string to take in integers.
1362
1363         Reviewed by Dan.
1364
1365         * English.lproj/Localizable.strings: Updated.
1366         * WebCoreLocalizedStrings.cpp:
1367         (WebCore::imageTitle):
1368
1369 2008-04-03  Dan Bernstein  <mitz@apple.com>
1370
1371         Reviewed by Dave Hyatt.
1372
1373         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
1374           font-weight does not properly support graded weights
1375
1376         * DOMCoreClasses.cpp:
1377         (DOMElement::font): Updated for the change to FontDescription.
1378         * WebCoreSupport/WebDragClient.cpp:
1379         (dragLabelFont): Ditto.
1380         * WebKitGraphics.cpp:
1381         (makeFont): Ditto.
1382         * WebKitGraphics.h: Added a FIXME.
1383
1384 2008-04-03  Steve Falkenburg  <sfalken@apple.com>
1385
1386         <rdar://problem/5835382> Calling window.open immediately after window.close can sometimes result in no window being created
1387         
1388         Group name tracking needs to happen using code in WebCore::Page, since it is more involved than
1389         just setting a string.
1390         
1391         Reviewed by Adam Roben.
1392
1393         * WebView.cpp:
1394         (WebView::close): Add null check (found via code inspection).
1395         (WebView::initWithFrame): Store the group name directly in Page.
1396         (WebView::setGroupName): Store the group name directly in Page.
1397         (WebView::groupName): Retrieve the group name directly from Page.
1398         * WebView.h: Removed m_groupName
1399
1400 2008-04-03  Simon Hausmann  <hausmann@webkit.org>
1401
1402         Reviewed by Mark Rowe.
1403
1404         Roll out r31599 and r31605 again after discussion with Mark Rowe.
1405
1406         * WebIconDatabase.cpp:
1407         (WebIconDatabase::iconForURL):
1408
1409 2008-04-03  Simon Hausmann  <hausmann@webkit.org>
1410
1411         Attempted build fix
1412
1413         * WebIconDatabase.cpp:
1414         (WebIconDatabase::iconForURL): Adjust to changed iconForPageURL
1415         signature
1416
1417 2008-04-03  Ada Chan  <adachan@apple.com>
1418
1419         Allow WebArchive to be created via COM.
1420         Replaced IID_DOMNode with __uuidof(DOMNode).
1421
1422         Reviewed by Adam and Steve.
1423
1424         * DOMCoreClasses.cpp:
1425         (DOMNode::QueryInterface):
1426         (DOMNode::isSameNode):
1427         * DOMCoreClasses.h:
1428         * ForEachCoClass.h:
1429         * Interfaces/WebKit.idl:
1430         * WebArchive.cpp:
1431         (WebArchive::createInstance):
1432         * WebArchive.h:
1433         * WebKitClassFactory.cpp:
1434
1435 2008-04-01  Brady Eidson  <beidson@apple.com>
1436
1437         Reviewed by Jon Honeycutt and Cake
1438
1439         Hookup WebArchive API enough to be able to save the archive of a DOMNode
1440         
1441         * DOMCoreClasses.h: Add a GUID for DOMNode
1442
1443         * Interfaces/IWebArchive.idl: Add initWithNode()
1444
1445         * WebArchive.cpp:
1446         (WebArchive::initWithNode):
1447         (WebArchive::data): Actually return LegacyWebArchive-style data
1448         * WebArchive.h:
1449
1450 2008-04-01  Brady Eidson  <beidson@apple.com>
1451
1452         Reviewed by Adam Roben
1453
1454         Add empty implementations of WebArchive for future work
1455         
1456         * WebArchive.cpp: Added.
1457         (WebArchive::createInstance):
1458         (WebArchive::WebArchive):
1459         (WebArchive::~WebArchive):
1460         (WebArchive::QueryInterface):
1461         (WebArchive::AddRef):
1462         (WebArchive::Release):
1463         (WebArchive::initWithMainResource):
1464         (WebArchive::initWithData):
1465         (WebArchive::mainResource):
1466         (WebArchive::subResources):
1467         (WebArchive::subframeArchives):
1468         (WebArchive::data):
1469         * WebArchive.h: Added.
1470         
1471         * WebKit.vcproj/WebKit.vcproj:
1472
1473 2008-03-29  Adam Roben  <aroben@apple.com>
1474
1475         Rename IWebViewPrivate::addAdditionalPluginPath to
1476         addAdditionalPluginDirectory
1477
1478         Reviewed by Mitz Pettel.
1479
1480         * Interfaces/IWebViewPrivate.idl:
1481         * Interfaces/WebKit.idl: Touched to make sure the Interfaces project
1482         rebuilds.
1483         * WebView.cpp:
1484         (WebView::addAdditionalPluginDirectory):
1485         * WebView.h:
1486
1487 2008-03-26  Brent Fulgham  <bfulgham@gmail.com>
1488
1489         Reviewed by Adam Roben.
1490
1491         Add necessary files and build commands to vcproj files to
1492         build a Curl-based Windows WebKit.  For details, see
1493         http://bugs.webkit.org/show_bug.cgi?id=17985
1494
1495         * WebKit.vcproj/WebKit.vcproj:
1496
1497 2008-03-25  Adam Roben  <aroben@apple.com>
1498
1499         Attempted build fix
1500
1501         * WebKit.vcproj/WebKit.sln: Make testapi build after most other
1502         projects.
1503
1504 2008-03-25  Adam Roben  <aroben@apple.com>
1505
1506         Fix Bug 18077: Integrate testapi.c into the Windows build
1507
1508         <http://bugs.webkit.org/show_bug.cgi?id=18077>
1509
1510         Reviewed by Steve Falkenburg.
1511
1512         * WebKit.vcproj/WebKit.sln: Added testapi.vcproj to the solution.
1513
1514 2008-03-25  Brady Eidson  <beidson@apple.com>
1515
1516         Reviewed by Darin
1517
1518         Remove newly obsolete FrameLoaderClient methods
1519
1520         * WebFrame.cpp:
1521         * WebFrame.h:
1522
1523 2008-03-25  Darin Adler  <darin@apple.com>
1524
1525         Suggested by Adam.
1526
1527         * Interfaces/WebKit.idl: Touch this file to make the Interface project rebuild.
1528
1529 2008-03-21  Ada Chan  <adachan@apple.com>
1530
1531         <rdar://problem/5810324> visitCount not updated in History.plist
1532         Call WebCore::HistoryItem::mergeAutoCompleteHints() in WebHistoryItem::mergeAutoCompleteHints().
1533
1534         Reviewed by Steve.
1535
1536         * WebHistoryItem.cpp:
1537         (WebHistoryItem::mergeAutoCompleteHints):
1538         (WebHistoryItem::QueryInterface):
1539
1540 2008-03-20  Dan Bernstein  <mitz@apple.com>
1541
1542         Reviewed by Adam Roben.
1543
1544         - make makeTextLarger() and zoomPageIn() do what they are supposed to do
1545
1546         * WebView.cpp:
1547         (WebView::makeTextLarger): Changed call to canZoomIn() to zoomIn().
1548         (WebView::zoomPageIn): Ditto.
1549
1550 2008-03-20  Dave Hyatt  <hyatt@apple.com>
1551
1552         Add full page zoom API for Windows WebKit.
1553
1554         Reviewed by aroben
1555
1556         * Interfaces/IWebView.idl:
1557         * WebView.cpp:
1558         (WebView::WebView):
1559         (WebView::setTextSizeMultiplier):
1560         (WebView::setPageSizeMultiplier):
1561         (WebView::setZoomMultiplier):
1562         (WebView::textSizeMultiplier):
1563         (WebView::pageSizeMultiplier):
1564         (WebView::zoomMultiplier):
1565         (WebView::canMakeTextLarger):
1566         (WebView::canZoomPageIn):
1567         (WebView::canZoomIn):
1568         (WebView::makeTextLarger):
1569         (WebView::zoomPageIn):
1570         (WebView::zoomIn):
1571         (WebView::canMakeTextSmaller):
1572         (WebView::canZoomPageOut):
1573         (WebView::canZoomOut):
1574         (WebView::makeTextSmaller):
1575         (WebView::zoomPageOut):
1576         (WebView::zoomOut):
1577         (WebView::canMakeTextStandardSize):
1578         (WebView::canResetPageZoom):
1579         (WebView::canResetZoom):
1580         (WebView::makeTextStandardSize):
1581         (WebView::resetPageZoom):
1582         (WebView::resetZoom):
1583         * WebView.h:
1584
1585 2008-03-20  John Sullivan  <sullivan@apple.com>
1586
1587         * English.lproj/Localizable.strings:
1588         Brought this file up to date
1589
1590 2008-03-19  Dan Bernstein  <mitz@apple.com>
1591
1592         - build fix
1593
1594         * Interfaces/WebKit.idl: Touched.
1595
1596 2008-03-19  Adam Roben  <aroben@apple.com>
1597
1598         Fix a couple of bugs where the node highlight would appear when it shouldn't
1599
1600         There were at least two ways you could get the highlight to appear
1601         when it shouldn't:
1602           1) Selecting a node in the Inspector while the inspected WebView was
1603              in a background tab.
1604           2) Selecting a node in the Inspector, switching to another tab,
1605              closing the Inspector, then switching back to the inspected
1606              WebView's tab.
1607
1608         This patch fixes the above two issues, and possibly others.
1609
1610         show() and hide() are now private methods of WebNodeHighlight. They
1611         are replaced by a single public method,
1612         setShowsWhileWebViewIsVisible(bool). WebInspectorClient uses this to
1613         tell the highlight whether it should be showing when the inspected
1614         WebView is visible.
1615
1616         Reviewed by John Sullivan.
1617
1618         * WebCoreSupport/WebInspectorClient.cpp:
1619         (WebInspectorClient::highlight): If the highlight is already showing,
1620         it just needs to update since the highlighted node has changed. If the
1621         highlight is not showing, call setShowsWhileWebViewIsVisible(true) so
1622         that the highlight will show when the WebView is shown.
1623         (WebInspectorClient::hideHighlight): Changed to call
1624         setShowsWhileWebViewIsVisible(false) instead of hide().
1625         * WebNodeHighlight.cpp:
1626         (WebNodeHighlight::WebNodeHighlight): Initialize new member, and
1627         initialize m_inspectedWebViewWindow to its final value here instead of
1628         in show().
1629         (WebNodeHighlight::setShowsWhileWebViewIsVisible): Added. If we're not
1630         supposed to show ourselves when the WebView is visible, we hide
1631         ourselves and return. Otherwise, we make our visibility match the
1632         WebView's.
1633         (WebNodeHighlight::isWebViewVisible): Added.
1634         (WebNodeHighlight::show): Removed initialization of
1635         m_inspectedWebViewWindow (this is now done by our constructor). Added
1636         an assertion that we're supposed to show ourselves when the WebView is
1637         visible.
1638         (WebNodeHighlight::onWebViewShowWindow): If we shouldn't show
1639         ourselves when the WebView is visible, then we don't need to do
1640         anything at all when the WebView's visibility changes.
1641         * WebNodeHighlight.h:
1642
1643 2008-03-19  Adam Roben  <aroben@apple.com>
1644
1645         Small WebNodeHighlight cleanup
1646
1647         Renamed the following methods:
1648           visible() -> isShowing()
1649           updateWindow() -> update()
1650
1651         Removed the window() method.
1652
1653         Added a new method, placeBehindWindow(HWND), that moves the highlight
1654         overlay in the window z-order to be just behind the passed-in window.
1655         WebInspectorClient calls this instead of doing the move directly using
1656         the old window() method.
1657
1658         Reviewed by John Sullivan.
1659
1660         * WebCoreSupport/WebInspectorClient.cpp:
1661         (WebInspectorClient::attachWindow):
1662         (WebInspectorClient::detachWindow):
1663         (WebInspectorClient::highlight): Call placeBehindWindow instead of
1664         calling SetWindowPos directly.
1665         * WebNodeHighlight.cpp:
1666         (WebNodeHighlight::show):
1667         (WebNodeHighlight::isShowing):
1668         (WebNodeHighlight::placeBehindWindow): Added. Code came from
1669         WebInspectorClient::highlight.
1670         (WebNodeHighlight::onWebViewWindowPosChanged):
1671         (WebNodeHighlight::onRootWindowPosChanged):
1672         * WebNodeHighlight.h:
1673
1674 2008-03-19  Ada Chan  <adachan@apple.com>
1675
1676         Added a method to paint WebView content specified by 
1677         the document rect into a device context.
1678
1679         Reviewed by Darin.
1680
1681         * Interfaces/IWebViewPrivate.idl:
1682         * WebView.cpp:
1683         (WebView::paintDocumentRectToContext):
1684         * WebView.h:
1685
1686 2008-03-18  Brent Fulgham  <bfulgham@gmail.com>
1687
1688         Reviewed by Adam Roben.
1689
1690         Provide some stub implementations for things that WebKit
1691         uses for performing authentication/challenge activities.  This
1692         is in support of http://bugs.webkit.org/show_bug.cgi?id=17837
1693
1694         * WebDataSource.cpp:
1695         * WebError.cpp:  Conditionalize CFNetwork-specific logic
1696         * WebURLAuthenticationChallenge.cpp:  Conditionalize constructor
1697           for authentication/challenge member.
1698         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
1699         * WebURLResponse.cpp:  Remove CFNetwork-specific logic.
1700         * WebURLResponse.h: Conditionalize CFNetwork-specific member.
1701         * WebView.cpp:  Conditionalize CFNetwork-specific network protocol test.
1702         (WebView::canHandleRequest):
1703
1704 2008-03-18  Adam Roben  <aroben@apple.com>
1705
1706         Focus the Inspector's WebView whenever the Inspector window is focused
1707
1708         Reviewed by Mitz.
1709
1710         * WebCoreSupport/WebInspectorClient.cpp:
1711         (WebInspectorClient::onSetFocus): Send focus to the WebView.
1712         (WebInspectorWndProc): Added a handler for WM_SETFOCUS.
1713         * WebCoreSupport/WebInspectorClient.h:
1714
1715 2008-03-18  Adam Roben  <aroben@apple.com>
1716
1717         Fix Bug 14276: Element highlight also covers Web inspector
1718
1719         <http://bugs.webkit.org/show_bug.cgi?id=14276>
1720         <rdar://5712796>
1721
1722         Also fixes <rdar://5622837> Browser window comes to front when node
1723         highlight appears, potentially blocking Inspector
1724
1725         Reviewed by Mitz.
1726
1727         * WebCoreSupport/WebInspectorClient.cpp:
1728         (WebInspectorClient::highlight): After showing the highlight,
1729         reposition it just behind the Inspector's window.
1730         * WebNodeHighlight.cpp:
1731         (WebNodeHighlight::show):
1732           - Changed flags passed to CreateWindowEx to not specify WS_VISIBLE.
1733             This is not needed because we'll show the window later in this
1734             function.
1735           - Removed call to SetWindowPos that tried to position the overlay
1736             just in front of the WebView. This is now handled by
1737             WebInspectorClient.
1738           - Changed call to ShowWindow to use SetWindowPos so that we can pass
1739             SWP_NOACTIVATE. This prevents the highlight from jumping in front
1740             of the Inspector every time it's shown.
1741         * WebNodeHighlight.h: Added a method to get the highlight's HWND.
1742
1743 2008-03-14  Steve Falkenburg  <sfalken@apple.com>
1744
1745         PGO build fixes.
1746
1747         * WebKit.vcproj/WebKit.vcproj:
1748
1749 2008-03-13  Adam Roben  <aroben@apple.com>
1750
1751         Another Windows build fix after r31034
1752
1753         * WebKitDLL.cpp:
1754         (loadResourceIntoBuffer): Use SharedBuffer::create.
1755
1756 2008-03-13  Adam Roben  <aroben@apple.com>
1757
1758         Windows build fix after r31034
1759
1760         * WebFrame.cpp:
1761         (WebFrame::loadData): Use SharedBuffer::create.
1762         (WebFrame::loadHTMLString): Ditto.
1763
1764 2008-03-13  Steve Falkenburg  <sfalken@apple.com>
1765
1766         More PGO build fixes.
1767
1768         * WebKit.vcproj/WebKit.pgd: Removed.
1769         * WebKit.vcproj/WebKit.vcproj:
1770         * WebKitPrefix.cpp:
1771
1772 2008-03-13  Anders Carlsson  <andersca@apple.com>
1773
1774         Reviewed by Adam.
1775
1776         Call originalRequest instead of initialRequest.
1777         
1778         * WebDataSource.cpp:
1779         (WebDataSource::initialRequest):
1780
1781 2008-03-13  Steve Falkenburg  <sfalken@apple.com>
1782
1783         PGO build fixes.
1784         
1785         Disable PGO for normal release builds.
1786         Added work-in-progress Release_PGOInstrument/Release_PGOOptimize targets.
1787
1788         * WebKit.vcproj/WebKit.vcproj:
1789
1790 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1791
1792         Fix build.
1793
1794         * WebKit.vcproj/WebKit.vcproj:
1795
1796 2008-03-12  Ada Chan  <adachan@apple.com>
1797
1798         <rdar://problem/5795843> 
1799         CFURLDownload needs to be cancelled if we don't have a destination path
1800         to save resume information.
1801
1802         Reviewed by Brady.
1803
1804         * WebDownload.cpp:
1805         (WebDownload::cancelForResume):
1806
1807 2008-03-12  David Hyatt  <hyatt@apple.com>
1808
1809         Make the zoom factor a float and not a percent.
1810
1811         Reviewed by antti
1812
1813         * WebFrame.cpp:
1814         (WebFrame::setTextSizeMultiplier):
1815
1816 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1817
1818         Build fix.
1819
1820         * WebKit.vcproj/WebKit.pgd:
1821         * WebKit.vcproj/WebKit.vcproj:
1822
1823 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1824
1825         Re-enabled PGO.
1826         
1827         Rubber stamped by Mark Rowe.
1828
1829         * WebKit.vcproj/WebKit.pgd:
1830         * WebKit.vcproj/WebKit.vcproj:
1831         * WebKitPrefix.cpp: touched this file to force a re-build.
1832
1833 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
1834
1835         Fix build.
1836
1837         * WebKit.vcproj/WebKit.vcproj:
1838
1839 2008-03-11  Steve Falkenburg  <sfalken@apple.com>
1840
1841         Use PGO to build WebKit.dll.
1842         
1843         Reviewed by Oliver.
1844
1845         * WebKit.vcproj/WebKit.pgd: Added.
1846         * WebKit.vcproj/WebKit.vcproj:
1847
1848 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
1849
1850         Reviewed by Adam Roben.
1851
1852         Enabled WinLauncher as part of normal Windows build.
1853         http://bugs.webkit.org/show_bug.cgi?id=17715.
1854
1855         * WebKit.vcproj/WebKit.sln:  Add WinLauncher to the set of things
1856           build during a Windows build.
1857
1858 2008-03-11  Adam Roben  <aroben@apple.com>
1859
1860         Roll out r30961 since it broke the default site icon on Windows
1861
1862         * WebKit.vcproj/WebKit.rc:
1863         * WebKit.vcproj/urlIcon.png: Renamed from WebCore/Resources/urlIcon.png.
1864         * WebKitDLL.cpp:
1865         (loadResourceIntoBuffer):
1866
1867 2008-03-11  Holger Hans Peter Freyther  <zecke@selfish.org>
1868
1869         Reviewed by Darin.
1870
1871         r25512 inlined the urlIcon to improve the startup time of Safari on Mac. Inlining is
1872         not suitable for platforms where this icon is themable. E.g. the Qt platform is allowing
1873         to theme this icon and the Gtk+ platform will probably end up with themable icons
1874         as well.
1875         
1876         Remove dead code from the windows port and move the urlIcon from the windows
1877         directory to the Resource directory to be used by Qt and other ports.
1878         
1879         Ifdef the usage of the built-in icon in IconDatabase.cpp and for Qt do not use
1880         it. Gtk+ currently has no proper implementation of Image::loadPlatformResource but
1881         once it does it wants to use this for getting the urlIcon as well.
1882
1883         * WebKit.vcproj/WebKit.rc:
1884         * WebKitDLL.cpp:
1885         (loadResourceIntoBuffer):
1886
1887 2008-03-10  Eric Seidel  <eric@webkit.org>
1888
1889         No review, build fix only.
1890         
1891         Speculative fix for Windows build, use ::UChar instead of KJS::UChar
1892
1893         * WebScriptCallFrame.cpp:
1894         (WebScriptCallFrame::valueForVariable):
1895         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
1896
1897 2008-03-10  Steve Falkenburg  <sfalken@apple.com>
1898
1899         Fix build break caused by r30920.
1900         
1901         Serialize remaining dependent builds by adding dependencies.
1902         Visual Studio per-vcproj parallelization doesn't add a lot of value
1903         since so many of our builds are dependent - this just enforces that.
1904         We do our parallelization via pdevenv, which works much better.
1905
1906         * WebKit.vcproj/WebKit.sln:
1907         * WebKit.vcproj/WebKit.submit.sln:
1908
1909 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
1910
1911         Stop Windows build if an error occurs in a prior project.
1912
1913         Rubber stamped by Darin.
1914
1915         * WebKit.vcproj/Interfaces.vcproj:
1916         * WebKit.vcproj/InterfacesGenerated.vcproj:
1917         * WebKit.vcproj/WebKit.vcproj:
1918         * WebKit.vcproj/WebKitGUID.vcproj:
1919
1920 2008-03-09  Adam Roben  <aroben@apple.com>
1921
1922         Make WebInspectorClient use WindowMessageBroadcaster instead of manual subclassing
1923
1924         Reviewed by Darin.
1925
1926         * WebCoreSupport/WebInspectorClient.cpp:
1927         (WebInspectorClient::WebInspectorClient): Removed
1928         m_orignalWebViewWndProc member.
1929         (WebInspectorClient::attachWindow): Register as a listener with
1930         WindowMessageBroadcaster instead of subclassing.
1931         (WebInspectorClient::detachWindow): Deregister as a listener with
1932         WindowMessageBroadcaster instead of unsubclassing.
1933         (WebInspectorClient::windowReceivedMessage): Renamed from
1934         SubclassedWebViewWndProc. Also added a missing break statement after
1935         the call to onWebViewWindowPosChanging.
1936         * WebCoreSupport/WebInspectorClient.h:
1937
1938 2008-03-09  Adam Roben  <aroben@apple.com>
1939
1940         Make the node highlight not obscure the tab bar when it first appears
1941
1942         Reviewed by Darin.
1943
1944         * WebNodeHighlight.cpp:
1945         (WebNodeHighlight::onWebViewWindowPosChanged): Added. Listens for
1946         changes to the WebView's size and resizes the highlight window to
1947         match.
1948         (WebNodeHighlight::onRootWindowPosChanged): Added. Listens for changes
1949         to the WebView's root window's position and moves the highlight window
1950         to match.
1951         (WebNodeHighlight::windowReceivedMessage): Call
1952         onWebViewWindowPosChanged/onRootWindowPosChanged as appropriate.
1953         * WebNodeHighlight.h:
1954
1955 2008-03-09  Adam Roben  <aroben@apple.com>
1956
1957         Fix Bug 14254: Inspector node highlight applied to all tabs
1958
1959         <http://bugs.webkit.org/show_bug.cgi?id=14254>
1960         <rdar://problem/5322306>
1961
1962         WebNodeHighlight now listens for the WM_SHOWWINDOW message being sent
1963         to the inspected WebView so that it can hide/show itself as the
1964         WebView is hidden/shown.
1965
1966         Reviewed by Anders.
1967
1968         * WebNodeHighlight.cpp:
1969         (WebNodeHighlight::~WebNodeHighlight): Remove ourselves as a listener
1970         for our inspected WebView's window's messages.
1971         (WebNodeHighlight::show): Add ourselves as a listener for our
1972         inspected WebView's window's messages.
1973         (WebNodeHighlight::onWebViewShowWindow): Added. Hide ourselves when
1974         the WebView hides, show ourselves when the WebView is shown.
1975         (WebNodeHighlight::windowReceivedMessage): Added a separate switch
1976         statement to handle the inspected WebView's window's messages.
1977         * WebNodeHighlight.h:
1978
1979 2008-03-07  Brent Fulgham  <bfulgham@gmail.com>
1980
1981         Reviewed by Mark Rowe.
1982
1983         Correct build intermediary output
1984         (http://bugs.webkit.org/show_bug.cgi?id=17713)
1985
1986         * WebKit/win/WebKit.vcproj/WebKit.vcproj:  Correct output and intermediary paths
1987
1988 2008-03-07  Brent Fulgham  <bfulgham@gmail.com>
1989
1990         Reviewed by Adam Roben.
1991
1992         Do not link (or attempt to initialize) the SafariTheme.dll
1993         when not building with USE(SAFARI_THEME) enabled.
1994         (http://bugs.webkit.org/show_bug.cgi?id=17707)
1995
1996         * WebKit/win/WebKitClassFactory.cpp:  Conditionalize use of SafariTheme.dll
1997
1998 2008-03-07  Brent Fulgham  <bfulgham@gmail.com>
1999
2000         Reviewed by Steve Falkenburg.
2001
2002         Update solution to understand Cairo build target.  Add
2003         library dependencies for Cairo build target.
2004         (http://bugs.webkit.org/show_bug.cgi?id=17300)
2005
2006         * WebKit.vcproj/WebKit.sln:
2007         * WebKit.vcproj/WebKit.vcproj:
2008
2009 2008-03-06  Adam Roben  <aroben@apple.com>
2010
2011         Change WebScriptDebugServer to use WebCore::JavaScriptDebugServer
2012
2013         WebScriptDebugServer is now a JavaScriptDebugListener.
2014
2015         Reviewed by Darin.
2016
2017         * WebScriptDebugServer.cpp:
2018         (WebScriptDebugServer::WebScriptDebugServer): Removed initialization
2019         of m_callingListeners member.
2020         (WebScriptDebugServer::addListener): Register as a listener with
2021         JavaScriptDebugServer if we've just added our first listener.
2022         (WebScriptDebugServer::removeListener): Deregister as a listener with
2023         JavaScriptDebugServer if we've just removed our last listener.
2024         (WebScriptDebugServer::didParseSource): Added. Code came from the old
2025         sourceParsed method. Removed m_callingListeners code because
2026         JavaScriptDebugServer guards against re-entry for us.
2027         (WebScriptDebugServer::failedToParseSource): Ditto.
2028         (WebScriptDebugServer::didEnterCallFrame): Ditto for callEvent.
2029         (WebScriptDebugServer::willExecuteStatement): Ditto for atStatement.
2030         (WebScriptDebugServer::willLeaveCallFrame): Ditto for
2031         willLeaveCallFrame.
2032         (WebScriptDebugServer::exceptionWasRaised): Ditto for exception.
2033         * WebScriptDebugServer.h: Changed to inherit from
2034         WebCore::JavaScriptDebugListener.
2035         * WebView.cpp:
2036         (WebView::initWithFrame): Removed call to
2037         WebScriptDebugServer::pageCreated. This is now handled by WebCore.
2038
2039 2008-03-06  Darin Adler  <darin@apple.com>
2040
2041         Reviewed by Mitz.
2042
2043         - fix regression test failures and crashes from the visited-link change
2044
2045         * WebCoreSupport/WebChromeClient.cpp:
2046         (WebChromeClient::populateVisitedLinks): Check for null before calling
2047         addVisitedLinksToPageGroup.
2048         * WebCoreSupport/WebFrameLoaderClient.cpp:
2049         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
2050         * WebHistory.cpp:
2051         (WebHistory::setOptionalSharedHistory): Call PageGroup::setShouldTrackVisitedLinks
2052         to turn off visited links if there is no history object. Also call
2053         removeAllVisitedLinks so we can start over from scratch with the new history.
2054
2055 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
2056
2057         Reviewed by Adam Roben.
2058
2059         Bug 17691: REGRESSION: FindSafari doesn't work
2060         http://bugs.webkit.org/show_bug.cgi?id=17691
2061
2062         Swap my change from r30394 to use the Release libraries instead of Debug
2063         since some machines don't have the Debug version.
2064
2065         * WebKit.vcproj/WebKit.sln:
2066
2067 2008-03-06  Darin Adler  <darin@apple.com>
2068
2069         Reviewed by Mitz.
2070
2071         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
2072           REGRESSION: iframes are added to Safari's History menu
2073           by separating the visited link machinery from global history
2074
2075         * WebCoreSupport/WebChromeClient.cpp:
2076         (WebChromeClient::populateVisitedLinks): Added a call to the new
2077         WebHistory::addVisitedLinksToPageGroup function.
2078         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
2079         Also fixed the webView function to be non-virtual.
2080
2081         * WebCoreSupport/WebFrameLoaderClient.cpp:
2082         (WebFrameLoaderClient::updateGlobalHistory): Changed to use the
2083         new WebHistory::addItem function.
2084         (WebFrameLoaderClient::webHistory): Changed to return a WebHistory*,
2085         there's no reason to AddRef the result from this function.
2086         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
2087
2088         * WebHistory.cpp: Removed IWebHistoryPrivate and _WebCoreHistoryProvider.
2089         (WebHistory::QueryInterface): Removed IWebHistoryPrivate.
2090         (sharedHistoryStorage): Added.
2091         (WebHistory::sharedHistory): Added.
2092         (WebHistory::optionalSharedHistory): Changed to use sharedHistory().
2093         (WebHistory::setOptionalSharedHistory): Changed to require a WebHistory
2094         object, not just an IWebHistory.
2095         (WebHistory::removeAllItems): Call PageGroup::removeAllVisitedLinks.
2096         (WebHistory::addItem): Changed parameter types since this is called with
2097         arguments from WebCore -- at some point this could allow better efficiency.
2098         (WebHistory::removeItemForURLString):  Call PageGroup::removeAllVisitedLinks
2099         if the last URL is being removed.
2100         (addVisitedLinkToPageGroup): Added. Helper. Adds a single link to a group's
2101         visited link set.
2102         (WebHistory::addVisitedLinksToPageGroup): Added. Adds all links to a group's
2103         visited link.
2104         * WebHistory.h: Removed IWebHistoryPrivate. Removed optionalSharedHistoryInternal
2105         and added sharedHistory. Replaced addItemForURL and containsItemForURLString with
2106         non-virtual addItem and addVisitedLinksToPageGroup functions.
2107
2108 2008-03-05  Anders Carlsson  <andersca@apple.com>
2109
2110         Build fix.
2111
2112         * WebKit.vcproj/WebKit.vcproj:
2113
2114 2008-03-04  Sam Weinig  <sam@webkit.org>
2115
2116         Reviewed by Mark Rowe.
2117
2118         - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
2119           JSDOMWindow.h
2120
2121         * WebFrame.cpp:
2122
2123 2008-03-04  Adam Roben  <aroben@apple.com>
2124
2125         WebScriptDebugServer cleanup
2126
2127         Reviewed by Anders.
2128
2129         * WebScriptDebugServer.cpp: Renamed m_callingServer to
2130         m_callingListeners.
2131         (WebScriptDebugServer::WebScriptDebugServer):
2132         (WebScriptDebugServer::sharedWebScriptDebugServer): Changed to keep
2133         the shared instance as a function-level static.
2134         (WebScriptDebugServer::didLoadMainResourceForDataSource): Made return
2135         void.
2136         (WebScriptDebugServer::sourceParsed):
2137         (WebScriptDebugServer::callEvent):
2138         (WebScriptDebugServer::atStatement):
2139         (WebScriptDebugServer::returnEvent):
2140         (WebScriptDebugServer::exception):
2141         (WebScriptDebugServer::serverDidDie): Made return void.
2142         * WebScriptDebugServer.h:
2143           - Removed unnecessary #includes
2144           - Made inheritance from KJS::Debugger private
2145           - Made some methods private
2146
2147 2008-03-04  Adam Roben  <aroben@apple.com>
2148
2149         Remove WebScriptDebugger
2150
2151         Reviewed by Anders.
2152
2153         * WebKit.vcproj/WebKit.vcproj: Removed files from project.
2154         * WebScriptDebugServer.cpp:
2155         (frame): Moved here from WebScriptDebugger.cpp.
2156         (webFrame): Ditto.
2157         (webView): Ditto.
2158         (WebScriptDebugServer::WebScriptDebugServer): Initialize new member.
2159         * WebScriptDebugServer.h: Changed to inherit directly from
2160         KJS::Debugger instead of from WebScriptDebugger, and added
2161         m_callingServer member that WebScriptDebugger used to own.
2162         * WebScriptDebugger.cpp: Removed.
2163         * WebScriptDebugger.h: Removed.
2164
2165 2008-03-04  Adam Roben  <aroben@apple.com>
2166
2167         Move sourceParsed to WebScriptDebugServer
2168
2169         Reviewed by Anders.
2170
2171         * WebScriptDebugServer.cpp:
2172         (WebScriptDebugServer::sourceParsed): Moved here from
2173         WebScriptDebugger and merged with didParseSource/failedToParseSource.
2174         * WebScriptDebugServer.h: Removed didParseSource/failedToParseSource.
2175         * WebScriptDebugger.cpp: Removed sourceParsed.
2176         * WebScriptDebugger.h: Ditto.
2177
2178 2008-03-04  Adam Roben  <aroben@apple.com>
2179
2180         Move callEvent, returnEvent, and exception to WebScriptDebugServer
2181
2182         Reviewed by Anders.
2183
2184         * WebScriptDebugServer.cpp:
2185         (WebScriptDebugServer::callEvent): Moved here from WebScriptDebugger
2186         and merged with didEnterCallFrame.
2187         (WebScriptDebugServer::returnEvent): Ditto for willLeaveCallFrame.
2188         (WebScriptDebugServer::exception): Ditto for exceptionWasRaised.
2189         * WebScriptDebugServer.h: Removed didEnterCallFrame,
2190         willLeaveCallFrame, and exceptionWasRaised.
2191         * WebScriptDebugger.cpp: Removed callEvent, returnEvent, and
2192         exception.
2193         * WebScriptDebugger.h: Ditto.
2194
2195 2008-03-04  Adam Roben  <aroben@apple.com>
2196
2197         Move atStatement to WebScriptDebugServer
2198
2199         Reviewed by Anders.
2200
2201         * WebScriptDebugServer.cpp:
2202         (WebScriptDebugServer::atStatement): Moved here and merged with the
2203         old willExecuteStatement method.
2204         * WebScriptDebugServer.h: Removed inheritance from
2205         IWebScriptDebugListener, which no one was relying on.
2206         * WebScriptDebugger.cpp:
2207         (webFrame): Made non-static.
2208         (webView): Ditto.
2209         * WebScriptDebugger.h: Added declarations of webFrame and webView
2210         methods for WebScriptDebugServer's benefit. Removed unused m_webView
2211         and m_frame members.
2212
2213 2008-03-04  Adam Roben  <aroben@apple.com>
2214
2215         Start to merge WebScriptDebugger and WebScriptDebugServer
2216
2217         WebScriptDebugServer now inherits from WebScriptDebugger.
2218
2219         Reviewed by Anders.
2220
2221         * WebScriptDebugServer.cpp:
2222         (WebScriptDebugServer::pageCreated): Use sharedWebScriptDebugServer
2223         instead of WebScriptDebugger::shared.
2224         (WebScriptDebugServer::addListener): Ditto.
2225         (WebScriptDebugServer::removeListener): Ditto.
2226         * WebScriptDebugServer.h: Changed to inherit from WebScriptDebugger.
2227         * WebScriptDebugger.cpp: Removed shared method.
2228         * WebScriptDebugger.h: Made constructor/destructor protected, and
2229         removed shared method.
2230
2231 2008-03-04  Adam Roben  <aroben@apple.com>
2232
2233         Use WebCore's new debugger-attaching code
2234
2235         Reviewed by Kevin M.
2236
2237         * WebCoreSupport/WebFrameLoaderClient.cpp: Moved a kit() function to
2238         WebView.{cpp,h} so that other files can call it.
2239         * WebFrame.cpp:
2240         (WebFrame::WebFrame): Removed m_scriptDebugger member.
2241         (WebFrame::windowObjectCleared): Removed attach/detach calls. This is
2242         no longer needed because WebScriptDebugger no longer stores any
2243         per-WebFrame state.
2244         * WebFrame.h:
2245         * WebScriptDebugServer.cpp:
2246         (WebScriptDebugServer::pageCreated): Added. Attaches our shared
2247         debugger to the Page if we have any listeners.
2248         (WebScriptDebugServer::addListener): Sets our shared debugger for all
2249         Pages when we get our first listener.
2250         (WebScriptDebugServer::removeListener): Removes our shared debugger
2251         from all Pages when we lose our last listener.
2252         * WebScriptDebugServer.h:
2253         * WebScriptDebugger.cpp:
2254         (WebScriptDebugger::shared): Added.
2255         (WebScriptDebugger::WebScriptDebugger): Removed m_frame member.
2256         (WebScriptDebugger::~WebScriptDebugger): Added.
2257         (frame): Gets a Frame from an ExecState.
2258         (webFrame): Gets a WebFrame from an ExecState.
2259         (webView): Gets a WebView from an ExecState.
2260         (WebScriptDebugger::sourceParsed): Changed to call webFrame() and
2261         webView() instead of using m_frame and m_webView members.
2262         (WebScriptDebugger::callEvent): Ditto.
2263         (WebScriptDebugger::atStatement): Ditto.
2264         (WebScriptDebugger::returnEvent): Ditto.
2265         (WebScriptDebugger::exception): Ditto.
2266         * WebScriptDebugger.h:
2267         * WebView.cpp:
2268         (kit): Moved here from WebFrameLoaderClient.cpp.
2269         (WebView::initWithFrame): Tell the WebScriptDebugServer about the new
2270         Page so it can attach a debugger if needed.
2271         * WebView.h:
2272
2273 2008-03-04  Adam Roben  <aroben@apple.com>
2274
2275         Change WebView's string-finding methods to call through to Page
2276
2277         These methods were added to Page back in r28878 (and the
2278         implementation was copied from WebView!) but we never switched over to
2279         using them.
2280
2281         Reviewed by Sam.
2282
2283         * WebView.cpp:
2284         (WebView::searchFor): Call through to Page::findString.
2285         (WebView::markAllMatchesForText): Call through to Page.
2286         (WebView::unmarkAllTextMatches): Ditto.
2287
2288 2008-03-04  Adam Roben  <aroben@apple.com>
2289
2290         Actually pause the process while Drosera is at a breakpoint
2291
2292         WebScriptDebugServer::suspendProcessIfPaused is supposed to pause the
2293         process while Drosera is at a breakpoint. Previously we were just
2294         starting a message pump that would deliver messages to all windows in
2295         the process, allowing mouse events, JS timers, etc. to execute.
2296
2297         Now we only deliver messages to COM's message window, which is all we
2298         need to allow RPC to function.
2299
2300         Reviewed by Anders.
2301
2302         * WebScriptDebugServer.cpp:
2303         (comMessageWindow): Added. Finds COM's message window.
2304         (WebScriptDebugServer::suspendProcessIfPaused): Only deliver messages
2305         to COM's message window so that mouse events, JS timers, etc., won't
2306         execute.
2307
2308 2008-03-03  Adam Roben  <aroben@apple.com>
2309
2310         Generate WebScriptCallFrame instances dynamically
2311
2312         WebScriptDebugger no longer holds a reference to the topmost call
2313         frame, and WebScriptCallFrame no longer holds a reference to its
2314         caller. We now generate WebScriptCallFrame instances as needed by
2315         walking the callingExecState chain.
2316
2317         By making WebKit no longer responsible for keeping track of the call
2318         stack, we get one step closer to moving most JS debugging code out of
2319         WebKit entirely.
2320
2321         This incidentally fixes a bug in Drosera where we'd never show the
2322         global scope in the call stack.
2323
2324         Reviewed by Sam and Kevin M.
2325
2326         * WebScriptCallFrame.cpp:
2327         (callingFunctionOrGlobalExecState): Finds the nearest calling
2328         ExecState that is a FunctionExecState or GlobalExecState, if any, and
2329         returns it.
2330         (WebScriptCallFrame::WebScriptCallFrame):
2331           - No longer takes a caller parameter.
2332           - Sets m_state to the callingFunctionOrGlobalExecState of the
2333             ExecState passed in.
2334         (WebScriptCallFrame::createInstance): Removed the caller parameter.
2335         (WebScriptCallFrame::caller): Generate a new WebScriptCallFrame on the
2336         fly from our ExecState.
2337         * WebScriptCallFrame.h: No longer holds a reference to the caller.
2338         * WebScriptDebugger.cpp:
2339         (WebScriptDebugger::WebScriptDebugger): Removed the call to callEvent
2340         that was supposed to set up the global scope call frame, but never
2341         worked because m_callingServer was set to true, which would cause
2342         callEvent to return early without doing anything. Also removed the
2343         m_callingServer guards since we're not calling callEvent anymore.
2344         (WebScriptDebugger::callEvent): Create a WebScriptCallFrame on the
2345         fly from the passed-in ExecState.
2346         (WebScriptDebugger::atStatement): Ditto.
2347         (WebScriptDebugger::returnEvent): Ditto, but use the callingExecState.
2348         This is equivalent to what calling leaveFrame() did before.
2349         (WebScriptDebugger::exception): Ditto, using the passed-in ExecState.
2350         * WebScriptDebugger.h: Removed m_topStackFrame member and
2351         enterFrame/leaveFrame methods.
2352
2353 2008-03-03  Sam Weinig  <sam@webkit.org>
2354
2355         Windows build fix.
2356
2357         * WebFrame.cpp:
2358         (WebFrame::windowObjectCleared):
2359
2360 2008-03-03  David Hyatt  <hyatt@apple.com>
2361
2362         Full page zoom work.  Make setting of a zoom factor take a boolean saying whether it is a text only
2363         or full page zoom.
2364
2365         Reviewed by Tim H.
2366
2367         * WebFrame.cpp:
2368         (WebFrame::setTextSizeMultiplier):
2369
2370 2008-02-29  Adam Roben  <aroben@apple.com>
2371
2372         Delete an unused file
2373
2374         Rubberstamped by Brady.
2375
2376         * Interfaces/IWebScriptScope.idl: Removed.
2377
2378 2008-02-28  Adam Roben  <aroben@apple.com>
2379
2380         Change WebPreferences to be backed by CFPreferences
2381
2382         Reviewed by Ada, Geoff, Steve, and Darin.
2383
2384         * WebPreferenceKeysPrivate.h:
2385         * WebPreferences.cpp:
2386         (WebPreferences::sharedStandardPreferences): Changed to call
2387         setAutoSaves(TRUE) before calling load(). This ensures that the
2388         preferences being migrated to CFPreferences are saved to disk.
2389         (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure
2390         that the refcount is managed properly. Now attempts to retrieve a
2391         value from CFPreferences before falling back to the default settings.
2392         (WebPreferences::setValueForKey): Now saves the value in
2393         CFPreferences if m_autoSaves is true.
2394         (WebPreferences::stringValueForKey): Updated for valueForKey changes.
2395         (WebPreferences::integerValueForKey): DItto.
2396         (WebPreferences::boolValueForKey): Ditto.
2397         (WebPreferences::floatValueForKey): Ditto.
2398         (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize.
2399         (WebPreferences::load): Always initializes m_privatePrefs to an empty
2400         CFMutableDictionary.
2401         (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates
2402         preferences from our old custom plist to CFPreferences and then
2403         deletes our custom plist, if the migration has never occurred before.
2404         (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies
2405         preferences to CFPreferences. If we've never migrated the default
2406         settings from Safari 3 Beta before, we omit them from this copying
2407         procedure.
2408         * WebPreferences.h:
2409
2410 2008-02-28  Adam Roben  <aroben@apple.com>
2411
2412         Refactor value <-> CFNumber conversions into some helper functions
2413
2414         Reviewed by Jon.
2415
2416         * WebPreferences.cpp:
2417         (preferencesPath): Changed to return a const String&.
2418         (numberValueForPreferencesValue): Converts a value from preferences to
2419         a native numeric type.
2420         (cfNumber): Converts a native numeric value to a CFNumberRef.
2421         (booleanValueForPreferencesValue): Converts a value from preferences
2422         to a native boolean.
2423         (WebPreferences::integerValueForKey): Changed to call
2424         numberValueForPreferencesValue.
2425         (WebPreferences::floatValueForKey): Ditto.
2426         (WebPreferences::boolValueForKey): Changed to call
2427         booleanValueForPreferencesValue.
2428         (WebPreferences::setIntegerValue): Changed to call cfNumber.
2429         (WebPreferences::setLongLongValue): Ditto.
2430
2431 2008-02-27  Adam Roben  <aroben@apple.com>
2432
2433         Add WebPreferences::setValueForKey
2434
2435         This is just a small refactoring of some duplicated logic into a
2436         shared method.
2437
2438         Reviewed by Sam.
2439
2440         * WebPreferences.cpp:
2441         (WebPreferences::setValueForKey): Added.
2442         (WebPreferences::setStringValue): Call setValueForKey.
2443         (WebPreferences::setIntegerValue): Ditto.
2444         (WebPreferences::setBoolValue): Ditto.
2445         (WebPreferences::setLongLongValue): Ditto.
2446         * WebPreferences.h:
2447
2448 2008-02-27  Adam Roben  <aroben@apple.com>
2449
2450         Remove WebPreferences' static members
2451
2452         s_defaultSettings is now a file-level static, and
2453         s_standardPreferences has been removed completely (it wasn't being
2454         used).
2455
2456         Reviewed by Sam.
2457
2458         * WebPreferences.cpp:
2459         (WebPreferences::initializeDefaultSettings):
2460         (WebPreferences::valueForKey):
2461         (WebPreferences::migrateDefaultSettingsFromSafari3Beta):
2462         (WebPreferences::removeValuesMatchingDefaultSettings):
2463         * WebPreferences.h:
2464
2465 2008-02-29  Steve Falkenburg  <sfalken@apple.com>
2466
2467         Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
2468         Found via code inspection.
2469         
2470         Reviewed by Adam.
2471
2472         * WebActionPropertyBag.cpp:
2473         (WebActionPropertyBag::Write):
2474         * WebElementPropertyBag.cpp:
2475         (WebElementPropertyBag::Write):
2476
2477 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
2478
2479         Reviewed by Adam Roben.
2480
2481         Bug 14348: Messing up the inspector by dragging an URL into it
2482         http://bugs.webkit.org/show_bug.cgi?id=14348
2483         <rdar://problem/5283620> and <rdar://problem/5712808>
2484
2485         Add a new class to handle the Inspector's delegate calls.
2486
2487         * WebCoreSupport/WebInspectorClient.cpp:
2488         (WebInspectorClient::createPage):
2489         * WebCoreSupport/WebInspectorDelegate.cpp: Added.
2490         (:m_refCount):
2491         (WebInspectorDelegate::createInstance):
2492         (WebInspectorDelegate::AddRef):
2493         (WebInspectorDelegate::Release):
2494         (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
2495         * WebCoreSupport/WebInspectorDelegate.h: Added.
2496         (WebInspectorDelegate::QueryInterface):
2497         (WebInspectorDelegate::createWebViewWithRequest):
2498         (WebInspectorDelegate::webViewShow):
2499         (WebInspectorDelegate::webViewClose):
2500         (WebInspectorDelegate::webViewFocus):
2501         (WebInspectorDelegate::webViewUnfocus):
2502         (WebInspectorDelegate::webViewFirstResponder):
2503         (WebInspectorDelegate::makeFirstResponder):
2504         (WebInspectorDelegate::setStatusText):
2505         (WebInspectorDelegate::webViewStatusText):
2506         (WebInspectorDelegate::webViewAreToolbarsVisible):
2507         (WebInspectorDelegate::setToolbarsVisible):
2508         (WebInspectorDelegate::webViewIsStatusBarVisible):
2509         (WebInspectorDelegate::setStatusBarVisible):
2510         (WebInspectorDelegate::webViewIsResizable):
2511         (WebInspectorDelegate::setResizable):
2512         (WebInspectorDelegate::setFrame):
2513         (WebInspectorDelegate::webViewFrame):
2514         (WebInspectorDelegate::setContentRect):
2515         (WebInspectorDelegate::webViewContentRect):
2516         (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage):
2517         (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage):
2518         (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt):
2519         (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage):
2520         (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener):
2521         (WebInspectorDelegate::mouseDidMoveOverElement):
2522         (WebInspectorDelegate::contextMenuItemsForElement):
2523         (WebInspectorDelegate::validateUserInterfaceItem):
2524         (WebInspectorDelegate::shouldPerformAction):
2525         (WebInspectorDelegate::willPerformDragDestinationAction):
2526         (WebInspectorDelegate::dragSourceActionMaskForPoint):
2527         (WebInspectorDelegate::willPerformDragSourceAction):
2528         (WebInspectorDelegate::contextMenuItemSelected):
2529         (WebInspectorDelegate::hasCustomMenuImplementation):
2530         (WebInspectorDelegate::trackCustomPopupMenu):
2531         (WebInspectorDelegate::measureCustomMenuItem):
2532         (WebInspectorDelegate::drawCustomMenuItem):
2533         (WebInspectorDelegate::addCustomMenuDrawingData):
2534         (WebInspectorDelegate::cleanUpCustomMenuDrawingData):
2535         (WebInspectorDelegate::canTakeFocus):
2536         (WebInspectorDelegate::takeFocus):
2537         (WebInspectorDelegate::registerUndoWithTarget):
2538         (WebInspectorDelegate::removeAllActionsWithTarget):
2539         (WebInspectorDelegate::setActionTitle):
2540         (WebInspectorDelegate::undo):
2541         (WebInspectorDelegate::redo):
2542         (WebInspectorDelegate::canUndo):
2543         (WebInspectorDelegate::canRedo):
2544         * WebKit.vcproj/WebKit.vcproj:
2545
2546 2008-02-26  Adam Roben  <aroben@apple.com>
2547
2548         Move ResourceLoadDelegate methods to WebFrameLoaderClient
2549
2550         Changed all methods to use early returns where possible and COMPtr's
2551         AdoptCOM/Query constructors.
2552
2553         Reviewed by Anders.
2554
2555         * WebCoreSupport/WebFrameLoaderClient.cpp:
2556         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2557         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2558         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2559         (WebFrameLoaderClient::dispatchWillSendRequest):
2560         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2561         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2562         (WebFrameLoaderClient::dispatchDidFinishLoading):
2563         (WebFrameLoaderClient::dispatchDidFailLoading):
2564         * WebCoreSupport/WebFrameLoaderClient.h:
2565         * WebFrame.cpp:
2566         * WebFrame.h:
2567
2568 2008-02-26  Adam Roben  <aroben@apple.com>
2569
2570         Move two more methods to WebFrameLoaderClient
2571
2572         Reviewed by Anders.
2573
2574         * WebCoreSupport/WebFrameLoaderClient.cpp:
2575         (kit):
2576         (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to
2577         early returns, and changed to use the COMPtr Query constructor.
2578         (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early
2579         return, and changed to use getWebDataSource.
2580         * WebCoreSupport/WebFrameLoaderClient.h:
2581         * WebFrame.cpp:
2582         * WebFrame.h:
2583
2584 2008-02-26  Adam Roben  <aroben@apple.com>
2585
2586         Get rid of IID_WebFrame
2587
2588         Reviewed by Anders.
2589
2590         * WebFrame.cpp: Removed IID_WebFrame definition.
2591         (WebFrame::QueryInterface): Use __uuidof(WebFrame) instead of
2592         IID_WebFrame.
2593         (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor
2594         instead of a manual QueryInterface.
2595         * WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a
2596         DECLSPEC_UUID.
2597
2598 2008-02-26  Adam Roben  <aroben@apple.com>
2599
2600         Move WebHistory-related methods to WebFrameLoaderClient
2601
2602         Reviewed by Anders.
2603
2604         * WebCoreSupport/WebFrameLoaderClient.cpp:
2605         (WebFrameLoaderClient::updateGlobalHistory):
2606         (WebFrameLoaderClient::shouldGoToHistoryItem):
2607         (WebFrameLoaderClient::setTitle): Changed some nested ifs into early
2608         returns.
2609         (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to
2610         make the reference management foolproof.
2611         * WebCoreSupport/WebFrameLoaderClient.h:
2612         * WebFrame.cpp:
2613         * WebFrame.h:
2614
2615 2008-02-26  Adam Roben  <aroben@apple.com>
2616
2617         Move cache-related methods to WebFrameLoaderClient
2618
2619         Reviewed by Anders.
2620
2621         * WebCoreSupport/WebFrameLoaderClient.cpp:
2622         (getWebDataSource): Moved to the top of the file.
2623         (WebFrameLoaderClient::savePlatformDataToCachedPage):
2624         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2625         (WebFrameLoaderClient::canCachePage):
2626         * WebCoreSupport/WebFrameLoaderClient.h:
2627         * WebFrame.cpp:
2628         * WebFrame.h:
2629
2630 2008-02-25  Adam Roben  <aroben@apple.com>
2631
2632         Move plugin-related methods to WebFrameLoaderClient
2633
2634         Reviewed by Anders.
2635
2636         * WebCoreSupport/WebFrameLoaderClient.cpp:
2637         (WebFrameLoaderClient::WebFrameLoaderClient):
2638         (WebFrameLoaderClient::setMainDocumentError):
2639         (WebFrameLoaderClient::committedLoad): Added some early returns.
2640         (WebFrameLoaderClient::receivedData):
2641         (WebFrameLoaderClient::finishedLoading): Ditto.
2642         (getWebDataSource):
2643         (WebFrameLoaderClient::createPlugin):
2644         * WebCoreSupport/WebFrameLoaderClient.h:
2645         * WebFrame.cpp:
2646         (WebFrame::WebFramePrivate::WebFramePrivate):
2647         * WebFrame.h:
2648
2649 2008-02-25  Adam Roben  <aroben@apple.com>
2650
2651         Move createFrame to WebFrameLoaderClient
2652
2653         Reviewed by Anders.
2654
2655         * WebCoreSupport/WebFrameLoaderClient.cpp:
2656         (WebFrameLoaderClient::createFrame):
2657         (WebFrameLoaderClient::loadURLIntoChild):
2658         * WebCoreSupport/WebFrameLoaderClient.h:
2659         * WebFrame.cpp:
2660         * WebFrame.h:
2661
2662 2008-02-25  Adam Roben  <aroben@apple.com>
2663
2664         Move progress-related methods to WebFrameLoaderClient
2665
2666         Reviewed by Anders.
2667
2668         * WebCoreSupport/WebFrameLoaderClient.cpp:
2669         (WebFrameLoaderClient::postProgressStartedNotification):
2670         (WebFrameLoaderClient::postProgressEstimateChangedNotification):
2671         (WebFrameLoaderClient::postProgressFinishedNotification):
2672         * WebCoreSupport/WebFrameLoaderClient.h:
2673         * WebFrame.cpp:
2674         * WebFrame.h:
2675
2676 2008-02-25  Adam Roben  <aroben@apple.com>
2677
2678         Remove WebFrame::detachedFromParent1
2679
2680         This method was removed from FrameLoaderClient in r19042, but was
2681         never removed from WebFrame.
2682
2683         Reviewed by Anders.
2684
2685         * WebFrame.cpp:
2686         * WebFrame.h:
2687
2688 2008-02-23  Adam Roben  <aroben@apple.com>
2689
2690         Move many dispatch methods to WebFrameLoaderClient
2691
2692         Reviewed by Sam.
2693
2694         * WebCoreSupport/WebFrameLoaderClient.cpp:
2695         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2696         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2697         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2698         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2699         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2700         (WebFrameLoaderClient::dispatchWillClose):
2701         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2702         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2703         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2704         (WebFrameLoaderClient::dispatchDidCommitLoad):
2705         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2706         (WebFrameLoaderClient::dispatchDidFinishLoad):
2707         (WebFrameLoaderClient::dispatchDidFirstLayout):
2708         (WebFrameLoaderClient::dispatchShow):
2709         * WebCoreSupport/WebFrameLoaderClient.h:
2710         * WebFrame.cpp:
2711         * WebFrame.h:
2712
2713 2008-02-23  Adam Roben  <aroben@apple.com>
2714
2715         Move two more methods to WebFrameLoaderClient
2716
2717         Reviewed by Sam.
2718
2719         * WebCoreSupport/WebFrameLoaderClient.cpp:
2720         (WebFrameLoaderClient::hasFrameView):
2721         (WebFrame::forceLayout):
2722         * WebCoreSupport/WebFrameLoaderClient.h:
2723         * WebFrame.cpp:
2724         * WebFrame.h:
2725
2726 2008-02-24  Darin Adler  <darin@apple.com>
2727
2728         Reviewed by Sam.
2729
2730         - remove separate client calls for "standard" and "reload' history
2731
2732         * WebFrame.cpp:
2733         (WebFrame::updateGlobalHistory):
2734         * WebFrame.h:
2735
2736 2008-02-23  Brent Fulgham  <bfulgham@gmail.com>
2737
2738         Not reviewed, build fix.
2739
2740         * WebIconDatabase.cpp:
2741         * WebIconDatabase.h:
2742
2743 2008-02-22  Adam Roben  <aroben@apple.com>
2744
2745         Move hasWebView to WebFrameLoaderClient
2746
2747         I added an m_webFrame member to WebFrameLoaderClient. This is slightly
2748         strange because WebFrame inherits from WebFrameLoaderClient, but this
2749         member will be needed once we remove the inheritance, so we might as
2750         well prepare for that now.
2751
2752         Reviewed by Anders.
2753
2754         * WebCoreSupport/WebFrameLoaderClient.cpp:
2755         (WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a
2756         WebFrame* parameter.
2757         (WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
2758         * WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame
2759         parameter.
2760         * WebFrame.cpp: Removed hasWebView.
2761         (WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor
2762         change.
2763         * WebFrame.h:
2764
2765 2008-02-22  Adam Roben  <aroben@apple.com>
2766
2767         Start to move FrameLoaderClient methods off WebFrame onto a separate class
2768
2769         WebFrame now inherits from a new WebFrameLoaderClient class, which
2770         will gradually assume all FrameLoaderClient responsibilities. Once
2771         that process is complete, WebFrame will no longer inherit from
2772         WebFrameLoaderClient.
2773
2774         In this first patch, I've only moved createDocumentLoader up to the
2775         WebFrameLoaderClient class.
2776
2777         Reviewed by Anders.
2778
2779         * WebCoreSupport/WebFrameLoaderClient.cpp: Added.
2780         (WebFrameLoaderClient::WebFrameLoaderClient):
2781         (WebFrameLoaderClient::~WebFrameLoaderClient):
2782         (WebFrameLoaderClient::createDocumentLoader): Moved here from
2783         WebFrame.cpp.
2784         * WebCoreSupport/WebFrameLoaderClient.h: Added.
2785         * WebFrame.cpp: Removed createDocumentLoader implementation.
2786         * WebFrame.h: Changed to inherit from WebFrameLoaderClient.
2787         * WebKit.vcproj/WebKit.vcproj: Added new files to the project.
2788
2789 2008-02-22  Adam Roben  <aroben@apple.com>
2790
2791         Move FormValuesPropertyBag into its own files
2792
2793         Reviewed by Sam.
2794
2795         * WebCoreSupport/FormValuesPropertyBag.cpp: Added.
2796         (FormValuesPropertyBag::QueryInterface):
2797         (FormValuesPropertyBag::AddRef):
2798         (FormValuesPropertyBag::Release):
2799         (FormValuesPropertyBag::Read):
2800         (FormValuesPropertyBag::Write):
2801         (FormValuesPropertyBag::CountProperties):
2802         (FormValuesPropertyBag::GetPropertyInfo):
2803         (FormValuesPropertyBag::LoadObject):
2804         * WebCoreSupport/FormValuesPropertyBag.h: Added.
2805         (FormValuesPropertyBag::FormValuesPropertyBag):
2806         * WebFrame.cpp: Deleted FormValuesPropertyBag code.
2807         * WebKit.vcproj/WebKit.vcproj: Added new files to the project.
2808
2809 2008-02-22  Adam Roben  <aroben@apple.com>
2810
2811         Remove some unused WebFrame methods
2812
2813         FrameWinClient was deleted back in r22965, but these methods were
2814         never deleted.
2815
2816         Reviewed by Sam.
2817
2818         * WebFrame.cpp:
2819         * WebFrame.h: Made one createFrame overload protected, since it's only
2820         called internally by WebFrame.
2821
2822 2008-02-21  Adam Roben  <aroben@apple.com>
2823
2824         Move Client implementations into a WebCoreSupport directory
2825
2826         Reviewed by Anders.
2827
2828         * WebKit.vcproj/WebKit.vcproj: Updated file paths, and added
2829         WebCoreSupport directory to the include path.
2830         * WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
2831         * WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
2832         * WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
2833         * WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
2834         * WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
2835         * WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
2836         * WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
2837         * WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
2838         * WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
2839         * WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
2840
2841 2008-02-20  Sam Weinig  <sam@webkit.org>
2842
2843         Reviewed by Darin and Geoff.
2844
2845         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
2846
2847         * WebView.cpp:
2848         (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks.
2849         (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where
2850         after you disable the site-specific hacks they persist until you open a new window or tweak
2851         some other preference.
2852
2853 2008-02-19  Darin Adler  <darin@apple.com>
2854
2855         Reviewed by Sam.
2856
2857         * WebFrame.cpp:
2858         (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead
2859         of DeprecatedString.
2860
2861 2008-02-18  Steve Falkenburg  <sfalken@apple.com>
2862
2863         Make Drosera work on Vista.
2864         
2865         Runtime type library registration on Vista requires use of two new call:
2866         RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
2867         HKCU.  LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.
2868         
2869         Reviewed by Adam.
2870
2871         * WebKitDLL.cpp:
2872         (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number.
2873         (DllRegisterServer): Call RegisterTypeLibraryForUser if available.
2874
2875 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
2876
2877         Reviewed by Adam.
2878
2879         Remove FindSafari's Release configuration.
2880
2881         * WebKit.vcproj/WebKit.sln:
2882
2883 2008-02-16  Alexey Proskuryakov  <ap@webkit.org>
2884
2885         Reviewed by Darin.
2886
2887         http://bugs.webkit.org/show_bug.cgi?id=17397
2888         <rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows
2889
2890         * WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.
2891
2892 2008-02-15  Darin Adler  <darin@apple.com>
2893
2894         Reviewed by Adam.
2895
2896         - quick fix for a problem causing an assertion on launch
2897
2898         * WebFrame.cpp:
2899         (WebFrame::loadData): Make an empty KURL even if the BSTR is null.
2900         Later we might want to rethink this.
2901
2902 2008-02-14  Darin Adler  <darin@apple.com>
2903
2904         - updated for WebCore KURL changes
2905
2906         * MarshallingHelpers.cpp:
2907         (MarshallingHelpers::BSTRToKURL): Removed deprecatedString call.
2908         (MarshallingHelpers::KURLToBSTR): Tweaked for efficiency.
2909         * WebContextMenuClient.cpp:
2910         (WebContextMenuClient::searchWithGoogle): Updated for KURL changes.
2911         * WebDataSource.cpp:
2912         (WebDataSource::unreachableURL): Ditto.
2913         * WebDownload.cpp:
2914         (WebDownload::init): Ditto.
2915         (WebDownload::initWithRequest): Ditto.
2916         * WebFrame.cpp:
2917         (WebFrame::loadData): Ditto.
2918         (WebFrame::loadURLIntoChild): Ditto.
2919         (WebFrame::objectContentType): Ditto.
2920         * WebResource.cpp:
2921         (WebResource::initWithData): Ditto.
2922         * WebURLResponse.cpp:
2923         (WebURLResponse::createInstance): Ditto.
2924         (WebURLResponse::initWithURL): Ditto.
2925         * WebView.cpp:
2926         (WebView::userAgentForURL): Ditto.
2927         (WebView::copyURL): Ditto.
2928         (WebView::notifyPreferencesChanged): Ditto.
2929
2930 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
2931
2932         * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Forgot to re-apply review comments to
2933         the previous check-in, fixing.
2934
2935 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
2936
2937         Reviewed by Adam Roben.
2938
2939         http://bugs.webkit.org/show_bug.cgi?id=17207
2940         Database example doesn't work (requires not-yet-released Safari)
2941
2942         * WebChromeClient.cpp:
2943         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
2944         if it's too old.
2945
2946 2008-02-13  Ada Chan  <adachan@apple.com>
2947
2948         <rdar://problem/5740656> Leak in postDidAddIconNotification in WebIconDatabase
2949
2950         Reviewed by Darin.
2951
2952         * WebIconDatabase.cpp:
2953         (postDidAddIconNotification): Need to adopt the newly created instance of CFDictionaryPropertyBag, 
2954         which already has a ref count of 1.
2955
2956 2008-02-13  Rodney Dawes  <dobey@wayofthemonkey.com>
2957
2958         Fix Bug 17220: Illogical dependency between PluginView and
2959         PluginDatabase
2960         
2961         <http://bugs.webkit.org/show_bug.cgi?id=17220>
2962
2963         Reviewed by Adam and Darin.
2964
2965         Update for the rename of PluginDatabase::createPluginView
2966         to PluginView::create
2967
2968         * WebFrame.cpp:
2969
2970 2008-02-13  Adam Roben  <aroben@apple.com>
2971
2972         Windows build fix
2973
2974         * Interfaces/WebKit.idl: Create the typelib version symbol ourselves.
2975
2976 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
2977
2978         Use a precompiled header to build WebKit.
2979         
2980         Reviewed by Adam.
2981
2982         * WebKit.vcproj/WebKit.vcproj:
2983         * WebKitPrefix.cpp: Added.
2984         * WebKitPrefix.h: Added.
2985
2986 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
2987
2988         Changes to support merged MIDL output.
2989
2990         All COM interfaces are now generated to WebKit.h.
2991
2992         Reviewed by Sam, Ada.
2993
2994         * DOMCSSClasses.h:
2995         * DOMCoreClasses.h:
2996         * DOMEventsClasses.h:
2997         * DOMHTMLClasses.h:
2998         * DefaultDownloadDelegate.h:
2999         * DefaultPolicyDelegate.cpp:
3000         * DefaultPolicyDelegate.h:
3001         * GEN_DOMObject.h:
3002         * Interfaces/DOMCSS.idl:
3003         * Interfaces/DOMCore.idl:
3004         * Interfaces/DOMEvents.idl:
3005         * Interfaces/DOMExtensions.idl:
3006         * Interfaces/DOMHTML.idl:
3007         * Interfaces/DOMPrivate.idl:
3008         * Interfaces/DOMRange.idl:
3009         * Interfaces/DOMWindow.idl:
3010         * Interfaces/IGEN_DOMObject.idl:
3011         * Interfaces/IWebArchive.idl:
3012         * Interfaces/IWebBackForwardList.idl:
3013         * Interfaces/IWebBackForwardListPrivate.idl:
3014         * Interfaces/IWebCache.idl:
3015         * Interfaces/IWebDataSource.idl:
3016         * Interfaces/IWebDatabaseManager.idl:
3017         * Interfaces/IWebDocument.idl:
3018         * Interfaces/IWebDownload.idl:
3019         * Interfaces/IWebEditingDelegate.idl:
3020         * Interfaces/IWebError.idl:
3021         * Interfaces/IWebErrorPrivate.idl:
3022         * Interfaces/IWebFormDelegate.idl:
3023         * Interfaces/IWebFrame.idl:
3024         * Interfaces/IWebFrameLoadDelegate.idl:
3025         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
3026         * Interfaces/IWebFramePrivate.idl:
3027         * Interfaces/IWebFrameView.idl:
3028         * Interfaces/IWebHTMLRepresentation.idl:
3029         * Interfaces/IWebHTTPURLResponse.idl:
3030         * Interfaces/IWebHistory.idl:
3031         * Interfaces/IWebHistoryItem.idl:
3032         * Interfaces/IWebHistoryItemPrivate.idl:
3033         * Interfaces/IWebIconDatabase.idl:
3034         * Interfaces/IWebInspector.idl:
3035         * Interfaces/IWebJavaScriptCollector.idl:
3036         * Interfaces/IWebKitStatistics.idl:
3037         * Interfaces/IWebMutableURLRequest.idl:
3038         * Interfaces/IWebMutableURLRequestPrivate.idl:
3039         * Interfaces/IWebNotification.idl:
3040         * Interfaces/IWebNotificationCenter.idl:
3041         * Interfaces/IWebNotificationObserver.idl:
3042         * Interfaces/IWebPolicyDelegate.idl:
3043         * Interfaces/IWebPreferences.idl:
3044         * Interfaces/IWebPreferencesPrivate.idl:
3045         * Interfaces/IWebResource.idl:
3046         * Interfaces/IWebResourceLoadDelegate.idl:
3047         * Interfaces/IWebResourceLoadDelegatePrivate.idl:
3048         * Interfaces/IWebScriptCallFrame.idl:
3049         * Interfaces/IWebScriptDebugListener.idl:
3050         * Interfaces/IWebScriptDebugServer.idl:
3051         * Interfaces/IWebScriptObject.idl:
3052         * Interfaces/IWebScriptScope.idl:
3053         * Interfaces/IWebScrollBarDelegatePrivate.idl:
3054         * Interfaces/IWebScrollBarPrivate.idl:
3055         * Interfaces/IWebSecurityOrigin.idl:
3056         * Interfaces/IWebTextRenderer.idl:
3057         * Interfaces/IWebUIDelegate.idl:
3058         * Interfaces/IWebUIDelegatePrivate.idl:
3059         * Interfaces/IWebURLAuthenticationChallenge.idl:
3060         * Interfaces/IWebURLRequest.idl:
3061         * Interfaces/IWebURLResponse.idl:
3062         * Interfaces/IWebURLResponsePrivate.idl:
3063         * Interfaces/IWebUndoManager.idl:
3064         * Interfaces/IWebUndoTarget.idl:
3065         * Interfaces/IWebView.idl:
3066         * Interfaces/IWebViewPrivate.idl:
3067         * Interfaces/WebKit.idl:
3068         * WebActionPropertyBag.cpp:
3069         * WebBackForwardList.h:
3070         * WebCache.h:
3071         * WebDataSource.cpp:
3072         * WebDataSource.h:
3073         * WebDatabaseManager.h:
3074         * WebDownload.h:
3075         * WebEditorClient.cpp:
3076         * WebEditorClient.h:
3077         * WebError.h:
3078         * WebFrame.cpp:
3079         * WebFrame.h:
3080         * WebFramePolicyListener.h:
3081         * WebHTMLRepresentation.cpp:
3082         * WebHTMLRepresentation.h:
3083         * WebHistory.cpp:
3084         * WebHistory.h:
3085         * WebHistoryItem.h:
3086         * WebIconDatabase.h:
3087         * WebInspector.h:
3088         * WebJavaScriptCollector.h:
3089         * WebKit.vcproj/Interfaces.vcproj:
3090         * WebKit.vcproj/WebKitGUID.vcproj:
3091         * WebKitDLL.cpp:
3092         * WebKitStatistics.h:
3093         * WebMutableURLRequest.cpp:
3094         * WebMutableURLRequest.h:
3095         * WebNotification.h:
3096         * WebNotificationCenter.h:
3097         * WebPreferences.h:
3098         * WebResource.h:
3099         * WebScriptCallFrame.h:
3100         * WebScriptDebugServer.cpp:
3101         * WebScriptDebugServer.h:
3102         * WebScriptDebugger.cpp:
3103         * WebScriptDebugger.h:
3104         * WebScriptObject.h:
3105         * WebScrollBar.h:
3106         * WebSecurityOrigin.h:
3107         * WebTextRenderer.h:
3108         * WebURLAuthenticationChallenge.h:
3109         * WebURLAuthenticationChallengeSender.h:
3110         * WebURLCredential.h:
3111         * WebURLProtectionSpace.h:
3112         * WebURLResponse.h:
3113         * WebView.cpp:
3114         * WebView.h:
3115
3116 2008-02-12  Anders Carlsson  <andersca@apple.com>
3117
3118         Reviewed by Adam.
3119
3120         Implement imageTitle.
3121         
3122         * WebCoreLocalizedStrings.cpp:
3123         (WebCore::imageTitle):
3124
3125 2008-02-12  Anders Carlsson  <andersca@apple.com>
3126
3127         Reviewed by Mitz.
3128
3129         * WebCoreLocalizedStrings.cpp:
3130         (WebCore::imageTitle):
3131         Add stub.
3132         
3133
3134 2008-02-07  Ada Chan  <adachan@apple.com>
3135
3136         <rdar://problem/5292433> certificate authentication support broken in Safari 3.0
3137         Added mechanism to communicate client certificate info back to CFNetwork.
3138
3139         Reviewed by Adam.
3140
3141         * Interfaces/IWebError.idl: Added new WebURLErrorClientCertificateRequired error.
3142         * Interfaces/IWebMutableURLRequestPrivate.idl: Added. Added method to set client 
3143         certificate info on the request.
3144         * WebKit.vcproj/Interfaces.vcproj: Added new idl.
3145         * WebKit.vcproj/WebKit.vcproj: Link crypt32.lib
3146         * WebKit.vcproj/WebKitGUID.vcproj:
3147         * WebMutableURLRequest.cpp:
3148         (WebMutableURLRequest::QueryInterface): Implements IWebMutableURLRequestPrivate.
3149         (deallocCertContext): Free certificate context.
3150         (copyCert): Duplicate the certificate context and returns it in a CFDataRef.
3151         (WebMutableURLRequest::setClientCertificate):
3152         * WebMutableURLRequest.h:
3153
3154 2008-02-05  Rodney Dawes  <dobey@wayofthemonkey.com>
3155
3156         Reviewed by Anders Carlsson.
3157
3158         Part one of http://bugs.webkit.org/show_bug.cgi?id=16924.
3159         Shared PluginDatabase, PluginInfoStore and PluginPackage implementations.
3160
3161         Track WebCore renames.
3162
3163         * WebFrame.cpp:
3164         (WebFrame::createPlugin):
3165         (WebFrame::redirectDataToPlugin):
3166         (WebFrame::createJavaAppletWidget):
3167         (WebFrame::objectContentType):
3168         * WebView.cpp:
3169         (WebViewWndProc):
3170         (WebView::canShowMIMEType):
3171         (WebView::addAdditionalPluginPath):
3172
3173 2008-02-05  Alexey Proskuryakov  <ap@webkit.org>
3174
3175         Reviewed by Darin.
3176
3177         http://bugs.webkit.org/show_bug.cgi?id=15248
3178         <rdar://problem/5497032> Can not enter accented characters using alt-numeric keypad (take two)
3179
3180         * WebView.cpp: (WebViewWndProc): KeyUp messages need to be translated, too.
3181
3182 2008-02-01  Darin Adler  <darin@apple.com>
3183
3184         - fix <rdar://problem/5680469> Each database worker thread takes a JSLock,
3185           which slows down all JavaScript execution until the thread terminates
3186
3187         * WebIconDatabase.cpp:
3188         (WebIconDatabase::scheduleNotificationDelivery): Updated for new callOnMainThread.
3189         (WebIconDatabase::deliverNotifications): Ditto.
3190         * WebIconDatabase.h: Ditto.
3191
3192 2008-01-31  Adam Roben  <aroben@apple.com>
3193
3194         Fix <rdar://5713172> Focus lost from Gmail message body after toggling
3195         tabs
3196
3197         This regressed in r29583. Prior to r29583, the code path that resulted
3198         in calling focusController->setFocusedFrame(0) was never getting hit.
3199         r29583 changed the code to adhere to the comment above the code and
3200         actually call setFocusedFrame(0) when losing focus to another part of
3201         the window. It turns out this is wrong behavior (and not what
3202         WebKit/mac does). The only time we should clear the focused frame is
3203         when we tab out of the WebView, and that's already taken care of by
3204         FocusController::advanceFocus. The code to clear the focused frame in
3205         WebView was written before FocusController::advanceFocus, so it was
3206         correct at one point but no longer is.
3207
3208         We now never call setFocusedFrame(0) when the WebView receives a
3209         WM_KILLFOCUS message. Instead we just call setFocused(false) on the
3210         focused frame so that blur events will be sent. This matches what
3211         WebKit/mac does.
3212
3213         Reviewed by Darin and Adele.
3214
3215         * WebView.cpp:
3216         (WebViewWndProc): Also reworded a couple of comments to make them
3217         clearer.
3218
3219 2008-01-31  Adam Roben  <aroben@apple.com>
3220
3221         Let WebCore take care of the highlight drawing entirely
3222
3223         Reviewed by Darin.
3224
3225         * WebInspectorClient.cpp:
3226         (WebInspectorClient::highlight): We now just show our highlight
3227         window and let WebCore figure out what/where to paint. Once all ports
3228         follow suit the Node* parameter to this method should be removed
3229         entirely, and the name should probably change to
3230         updateAndShowHighlight or something similar.
3231         * WebNodeHighlight.cpp: Renamed m_webView to m_inspectedWebViewWindow.
3232         (WebNodeHighlight::WebNodeHighlight): Now takes a WebView* parameter.
3233         (WebNodeHighlight::show): Renamed from highlight(). Now gets the
3234         WebView's HWND. Updated for member rename/removal.
3235         (WebNodeHighlight::updateWindow): Updated for member rename and for
3236         InspectorController changes.
3237         * WebNodeHighlight.h: Added m_inspectedWebView member, removed m_rect
3238         member, renamed highlight(Node*) -> show().
3239
3240 2008-01-31  Adam Roben  <aroben@apple.com>
3241
3242         Move node highlight drawing code to WebCore
3243
3244         Reviewed by Darin.
3245
3246         * WebNodeHighlight.cpp:
3247         (WebNodeHighlight::updateWindow): Call into WebCore to do the node
3248         highlight drawing.
3249
3250 2008-01-29  Adam Roben  <aroben@apple.com>
3251
3252         Fix a crash when opening the Inspector
3253
3254         Reviewed by Anders.
3255
3256         * WebInspectorClient.cpp:
3257         (WebInspectorClient::createPage): Call
3258         WebPreferences::initWithIdentifier so our custom WebPreferences will
3259         have all its members initialized.
3260
3261 2008-01-29  Adam Roben  <aroben@apple.com>
3262
3263         Fix Bug 16786: "Display images when page opens" preference affects
3264         Inspector
3265
3266         <http://bugs.webkit.org/show_bug.cgi?id=16786>
3267         <rdar://5712914>
3268
3269         Reviewed by Anders and Darin.
3270
3271         * WebInspectorClient.cpp:
3272         (WebInspectorClient::createPage): Create our own custom WebPreferences
3273         so that we won't be affected by global preference changes. This
3274         matches what Mac does.
3275
3276 2008-01-29  Adam Roben  <aroben@apple.com>
3277
3278         Fix <rdar://5713302> Web Inspector on Windows is not using the
3279         localized strings
3280
3281         Reviewed by Steve.
3282
3283         * WebInspectorClient.cpp:
3284         (getWebKitBundle): Added.
3285         (WebInspectorClient::createPage): Call getWebKitBundle.
3286         (WebInspectorClient::localizedStringsURL): Implemented.
3287
3288 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
3289
3290         Reviewed by Darin.
3291
3292         <rdar://problem/5710692> All storage tests fail/crash
3293
3294         * WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota): Clients that do not implement
3295         database quota callbacks should have no database support - but not crash.
3296
3297 2008-01-26  Steve Falkenburg  <sfalken@apple.com>
3298
3299         <rdar://problem/5707607> REGRESSION: I hear a beep when selecting Alt-enter in address or search fields
3300         
3301         Reviewed by Oliver.
3302
3303         * WebView.cpp:
3304         (WebView::keyDown): Allow alt-return to be marked as handled by WebKit.
3305
3306 2008-01-24  Steve Falkenburg  <sfalken@apple.com>
3307
3308         Build fix
3309
3310         * WebKit.vcproj/WebKit.sln:
3311         * WebKit.vcproj/WebKit.submit.sln:
3312
3313 2008-01-24  Adam Roben  <aroben@apple.com>
3314
3315         Build fix
3316
3317         * WebView.cpp: Added a comma.
3318
3319 2008-01-24  Alexey Proskuryakov  <ap@webkit.org>
3320
3321         Reviewed by Adam Roben.
3322
3323         <rdar://problem/5702734> REGRESSION(r28936/r15890): Shift+del does not work in win Safari
3324
3325         * WebView.cpp: Fixed keyDownEntries to list this shortcut (and related ones, for consistency).
3326
3327 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
3328
3329         <rdar://problem/5698732> Copyright strings should include 2008
3330         
3331         Reviewed by Sam.
3332
3333         * WebKit.vcproj/WebKit.rc:
3334
3335 2008-01-23  Adam Roben  <aroben@apple.com>
3336
3337         Fix <rdar://5698502> Inspector window reverts to default position/size unexpectedly
3338
3339         Reviewed by Hyatt.
3340
3341         * WebInspectorClient.cpp:
3342         (defaultWindowRect): Added.
3343         (WebInspectorClient::createPage):
3344             - Use defaultWindowRect() to set the initial size/position of the
3345               Inspector window.
3346             - Pass the Inspector window's client rect to
3347               IWebView::initWithFrame so that the WebView will be initially
3348               sized to fill the window.
3349         (WebInspectorClient::showWindow): Don't move/resize the window back to
3350         the defaults every time this method is called.
3351
3352 2008-01-23  Adam Roben  <aroben@apple.com>
3353
3354         Fix <rdar://5700620> REGRESSION (r28190): "Open frame in new tab" instead of "Open link in new tab" @ digg.com
3355
3356         Test: fast/events/contextmenu-scrolled-page-with-frame.html
3357
3358         Reviewed by Dan.
3359
3360         * WebView.cpp:
3361         (WebView::handleContextMenuEvent): Translate the mouse coordinates
3362         into document coordinates before performing the hit-test. This is what
3363         EventHandler does internally.
3364
3365 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
3366
3367         <rdar://problem/5699509> Allow file upload dialog to be localized.
3368         
3369         Reviewed by Darin.
3370
3371         * English.lproj/Localizable.strings: Updated.
3372         * WebCoreLocalizedStrings.cpp:
3373         (WebCore::uploadFileText): Added.
3374         (WebCore::allFilesText): Added.
3375
3376 2008-01-22  Adam Roben  <aroben@apple.com>
3377
3378         Fix <rdar://5693599> REGRESSION (r29369): scroll bars are drawing when they shouldn't be on an ad on cnn.com
3379
3380         Now that we have multiple FrameViews per Frame on Windows, we need to
3381         make sure each FrameView gets its scrolling mode set correctly. On Mac
3382         this works because WebFrameView holds the scrolling mode and a single
3383         WebFrameView is shared by many FrameViews. On Windows, we have no such
3384         shared object, so we just ask the Frame's owner element for the
3385         scrolling mode.
3386
3387         Tests: fast/frames/frame-scrolling-attribute.html
3388                fast/frames/iframe-scrolling-attribute.html
3389
3390         Reviewed by Hyatt.
3391
3392         * WebFrame.cpp:
3393         (WebFrame::transitionToCommittedForNewPage): Set the scrolling mode
3394         on the FrameView based on the scrolling mode of the Frame's owner
3395         element.
3396
3397 2008-01-21  Darin Adler  <darin@apple.com>
3398
3399         Reviewed by John Sullivan.
3400
3401         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
3402         - fix incorrect value for WebDatabaseDisplayNameKey in header
3403         
3404         * Interfaces/IWebDatabaseManager.idl: Renamed detailsForDatabaseWithOrigin to
3405         detailsForDatabase. Replaced deleteDatabasesWithOrigin with deleteOrigin.
3406         Renamed deleteDatabaseWithOrigin to deleteDatabase. Fixed incorrect value for
3407         WebDatabaseDisplayNameKey.
3408         * Interfaces/IWebPreferencesPrivate.idl: Removed defaultDatabaseQuota and
3409         setDefaultDatabaseQuota.
3410         * Interfaces/IWebUIDelegatePrivate.idl: Replaced the two database quota functions
3411         with a single one.
3412
3413         * WebChromeClient.cpp:
3414         (WebChromeClient::exceededDatabaseQuota): Replaced the two database quota functions
3415         with a single one.
3416         * WebChromeClient.h: Ditto.
3417
3418         * WebDatabaseManager.cpp:
3419         (WebDatabaseManager::detailsForDatabase): Changed to check for a name of null to
3420         detect a nonexistent database rather than using isValid.
3421         (WebDatabaseManager::deleteOrigin): Updated for name change (actually a semantic
3422         change too, but both have the same name).
3423         (WebDatabaseManager::deleteDatabase): Updated for name change.
3424         (WebKitSetWebDatabasesPathIfNecessary): Ditto.
3425
3426         * WebDatabaseManager.h: Updated for name changes.
3427
3428         * WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
3429         * WebPreferences.cpp:
3430         (WebPreferences::initializeDefaultSettings): Removed the default for
3431         WebKitDefaultDatabaseQuotaKey.
3432         * WebPreferences.h: Removed defaultDatabaseQuota and setDefaultDatabaseQuota.
3433         * WebView.cpp:
3434         (WebView::notifyPreferencesChanged): Removed the code to set the
3435         default database origin quota in WebCore::Settings based on IWebPreferencesPrivate.
3436
3437 2008-01-19  Mark Rowe  <mrowe@apple.com>
3438
3439         Fix inconsistent line endings and set svn:eol-style=native
3440         on IDL files that did not have it set.
3441
3442         * Interfaces/IGEN_DOMObject.idl:
3443
3444 2008-01-18  Adam Roben  <aroben@apple.com>
3445
3446         Fix <rdar://5693854> REGRESSION (r29581): fast/events/frame-click-focus.html failing
3447
3448         Restored the previous behavior of IWebViewPrivate::updateActiveState,
3449         which DRT depends on, and renamed it to
3450         IWebViewPrivate::updateFocusedAndActiveState to be clearer about its
3451         side-effects.
3452
3453         Reviewed by Adele.
3454
3455         * Interfaces/IWebViewPrivate.idl:
3456         * WebView.cpp:
3457         (WebViewWndProc): Removed some FIXMEs that we no longer want to fix
3458         because the current design is better.
3459         (WebView::updateActiveState): This is now just a method of WebView,
3460         not any of its public interfaces.
3461         (WebView::updateFocusedAndActiveState): Performs the tasks that the
3462         old IWebViewPrivate::updateActiveState performed.
3463         * WebView.h:
3464
3465 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
3466
3467         Reviewed by Adam Roben.
3468
3469         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
3470         between DRT and TestNetscapePlugin.
3471
3472         * WebKit.vcproj/WebKit.sln: Use newly added TestNetscapePlugin Debug_Internal configuration.
3473
3474 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
3475
3476         Build fix.
3477
3478         * WebKit.vcproj/WebKit.make:
3479
3480 2008-01-16  Adam Roben  <aroben@apple.com>
3481
3482         Trigger activation changes at the right time by listening for WM_NCACTIVATE
3483
3484         This is the final part of <rdar://5006915> Inactive look for Aqua
3485         controls
3486
3487         WebView now listens to messages sent to its top-level parent window.
3488         When the top-level parent receives a WM_NCACTIVATE message, WebView
3489         recalculates whether it is contained within the current active window.
3490
3491         Reviewed by Darin.
3492
3493         * Interfaces/IWebViewPrivate.idl:
3494         (IWebViewPrivate::windowAncestryDidChange): Added. WebKit clients
3495         should call this when they change the parent window chain of a
3496         WebView.
3497         * WebView.cpp:
3498         (WebView::WebView): Initialize new member.
3499         (findTopLevelParent): Added.
3500         (WebViewWndProc):
3501             - Separated activation handling from focus handling, now that
3502               activation handling is taken care of by updateActiveState
3503               exclusively.
3504             - Compare top-level parents in our WM_KILLFOCUS handler so that we
3505               really know if focus is staying inside our top-level window.
3506             - Update our active state on WM_WINDOWPOSCHANGED.
3507             - Added a WM_TIMER handler.
3508         (WebView::initWithFrame): Call windowAncestryDidChange after setting
3509         up our HWND as a child of the host window.
3510         (WebView::windowReceivedMessage): Added. Update our active state when
3511         our top-level parent receives a WM_NCACTIVATE message.
3512         (WebView::updateActiveStateSoon): Added.
3513         (WebView::setHostWindow): Call windowAncestryDidChange after changing
3514         the host window.
3515         (WebView::updateActiveState): We are active if our top-level parent is
3516         the same as the top-level parent of the active window.
3517         (WebView::windowAncestryDidChange): Added. Recalculates our top-level
3518         parent and registers as a listener for the new top-level parent's
3519         messages.
3520         * WebView.h: Made WebView and WindowMessageListener so that it can
3521         utilize WindowMessageBroadcaster to listen to its top-level parent's
3522         messages.
3523
3524 2008-01-16  Adam Roben  <aroben@apple.com>
3525
3526         Updated for ScrollBarClient changes
3527
3528         Reviewed by Darin.
3529
3530         * WebScrollBar.h:
3531         (WebScrollBar::isActive): Added.
3532
3533 2008-01-16  Adam Roben  <aroben@apple.com>
3534
3535         Updated for changes to WebCore methods
3536
3537         Focus and active state are now handled (somewhat) separately. Future
3538         patches will further separate these concepts.
3539
3540         Reviewed by Darin.
3541
3542         * WebView.cpp:
3543         (WebViewWndProc): Updated for method renames.
3544         (WebView::updateActiveState): Only change the active state here. Focus
3545         is handled inside WM_SETFOCUS and WM_KILLFOCUS message handlers.
3546
3547 2008-01-16  Steve Falkenburg  <sfalken@apple.com>
3548
3549         <rdar://problem/5097419> Cursor flickers when over window resizer
3550         
3551         Reviewed by Sam.
3552
3553         * WebView.cpp:
3554         (WebViewWndProc): Don't set the resize cursor when over the non-border resize area.
3555
3556 2008-01-15  Steve Falkenburg  <sfalken@apple.com>
3557
3558         <rdar://problem/5663888> Cannot type into a JavaScript prompt created from a timer
3559         
3560         Allow nested timers from javascript prompts to allow for WebView-based edit fields.
3561         
3562         Reviewed by Darin.
3563
3564         * WebChromeClient.cpp:
3565         (WebChromeClient::runJavaScriptPrompt):
3566
3567 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
3568
3569         Use shared vsprops for most vcproj properties.
3570         
3571         Reviewed by Darin.
3572
3573         * WebKit.vcproj/Interfaces.vcproj:
3574         * WebKit.vcproj/WebKit.vcproj:
3575         * WebKit.vcproj/WebKitGUID.vcproj: Add missing Debug_Internal config.
3576
3577 2008-01-11  Steve Falkenburg  <sfalken@apple.com>
3578
3579         Share common files across projects.
3580         
3581         Unify vsprops files
3582         Debug:          common.vsprops, debug.vsprops
3583         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
3584         Release:        common.vsprops, release.vsprops
3585         
3586         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
3587         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
3588
3589         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
3590
3591         Reviewed by Adam Roben.
3592
3593         * WebKit.vcproj/Interfaces.vcproj:
3594         * WebKit.vcproj/PRODUCTVERSION: Removed.
3595         * WebKit.vcproj/VERSION: Removed.
3596         * WebKit.vcproj/WebKit.vcproj:
3597         * WebKit.vcproj/WebKitGUID.vcproj:
3598         * WebKit.vcproj/auto-version.sh: Removed.
3599         * WebKit.vcproj/debug.vsprops: Removed.
3600         * WebKit.vcproj/debug_internal.vsprops: Removed.
3601         * WebKit.vcproj/release.vsprops: Removed.
3602
3603 2008-01-11  Adam Roben  <aroben@apple.com>
3604
3605         Fix Bug 16828: WebView never paints if first page load is canceled after being committed but before layout
3606
3607         <http://bugs.webkit.org/show_bug.cgi?id=16828>
3608         <rdar://5682402>
3609
3610         Now that we have 1) a real loader and 2) multiple FrameViews per
3611         Frame, we no longer need the hackery we had in our WM_PAINT handler
3612         that decided whether or not to paint. We now always want to paint,
3613         letting the swapping of FrameViews that happens in
3614         transitionToCommittedForNewPage handle which document gets painted.
3615
3616         Reviewed by Hyatt.
3617
3618         * WebView.cpp:
3619         (WebViewWndProc): Removed hackery that decided sometimes not to paint.
3620
3621 2008-01-11  Mark Rowe  <mrowe@apple.com>
3622
3623         Windows build fix.  Update to match method name in WebCore.
3624
3625         * WebJavaScriptCollector.cpp:
3626         (WebJavaScriptCollector::collectOnAlternateThread):
3627
3628 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
3629
3630         Reviewed by John Sullivan.
3631
3632         Updated for transition away from JavaScriptStatistics, which is gone now.
3633
3634         * WebJavaScriptCollector.cpp:
3635         (WebJavaScriptCollector::collect):
3636         (WebJavaScriptCollector::collectOnAlternateThread):
3637         (WebJavaScriptCollector::objectCount):
3638
3639 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
3640
3641         Not reviewed, build fix.
3642