2009-03-27 Darin Adler <darin@apple.com>
[WebKit-https.git] / WebKit / win / ChangeLog
1 2009-03-26  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Adam Roben.
4
5         - add close() to the WebView API.
6
7         * Interfaces/IWebView.idl:
8         * WebView.cpp:
9         (WebView::close):
10         * WebView.h:
11
12 2009-03-24  Brent Fulgham  <bfulgham@webkit.org>
13
14         Reviewed by Adam Roben.
15
16         https://bugs.webkit.org/show_bug.cgi?id=24779
17         Conditionalize CFNetwork-specific code in WebView to permit
18         support for other network backends.
19
20         * WebView.cpp:
21         (WebView::setCacheModel): Add CFNETWORK check around CFNetwork
22         specific cache implementation.
23         (updateSharedSettingsFromPreferencesIfNeeded): Add CFNETWORK
24         check around use of CFHTTPCookie code.
25
26 2009-03-23  Sam Weinig  <sam@webkit.org>
27
28         Reviewed by Dan Bernstein.
29
30         Fix for <rdar://problem/6140966>
31         Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
32
33         * WebCache.cpp:
34         (WebCache::empty): Also add application cache emptying to match the mac.
35
36 2009-03-18  Steve Falkenburg  <sfalken@apple.com>
37
38         Add webViewClosing to private UI delegate.
39
40         Reviewed by Adam Roben.
41
42         * Interfaces/IWebUIDelegatePrivate.idl:
43         * Interfaces/WebKit.idl:
44         * WebView.cpp:
45         (WebView::close):
46
47 2009-03-17  Dan Bernstein  <mitz@apple.com>
48
49         Reviewed by Adam Roben.
50
51         - WebKit part of adding a mechanism for controlling the caching of
52           responses through WebFrameLoaderClient
53
54         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added the
55         IWebResourceLoadDelegatePrivate3 interface, containing the new
56         delegate method shouldCacheResponse().
57
58         * Interfaces/IWebURLRequest.idl: Added the isEqual() method.
59
60         * WebCoreSupport/WebFrameLoaderClient.cpp:
61         (WebFrameLoaderClient::shouldCacheResponse): Implemented this new
62         FrameLoaderDelegate method by calling through to the resource load
63         delegate, if it implements shouldCacheResponse(), and returning true
64         otherwise.
65
66         * WebCoreSupport/WebFrameLoaderClient.h:
67
68         * WebMutableURLRequest.cpp:
69         (WebMutableURLRequest::isEqual): Added.
70         (WebMutableURLRequest::setValue): Implemented.
71
72         * WebMutableURLRequest.h: Declared isEqual().
73
74 2009-03-16  Darin Adler  <darin@apple.com>
75
76         Reviewed by Dan Bernstein.
77
78         <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”
79
80         For now, change only the localized strings, not the terminology in the code.
81
82         * WebCoreLocalizedStrings.cpp:
83         (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here.
84         (WebCore::contextMenuItemTagTextDirectionMenu): And here.
85
86 2009-03-16  Adam Roben  <aroben@apple.com>
87
88         Add IWebFramePrivate::isDisplayingStandaloneImage
89
90         This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
91         uses.
92
93         Reviewed by Darin Adler.
94
95         * Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.
96
97         * WebFrame.cpp:
98         (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our
99         Document is an image document.
100
101         * WebFrame.h: Added isDisplayingStandaloneImage.
102
103 2009-03-12  Peter Kasting  <pkasting@google.com>
104
105         Reviewed by Darin Fisher.
106
107         https://bugs.webkit.org/show_bug.cgi?id=24502
108         Make horizontal scrolling on Windows always go the correct direction.
109
110         * WebView.cpp:
111         (WebView::mouseWheel):
112         (WebViewWndProc):
113         * WebView.h:
114
115 2009-03-12  Adam Roben  <aroben@apple.com>
116
117         Implement DOMHTMLDocument::title
118
119         Reviewed by Dan Bernstein.
120
121         * DOMHTMLClasses.cpp:
122         (DOMHTMLDocument::title): Call through to WebCore::Document (with
123         obligatory COM error checking/type conversions).
124
125 2009-03-11  Adam Roben  <aroben@apple.com>
126
127         Export functions needed by ThreadSpecific from WebKit
128
129         Reviewed by John Sullivan.
130
131         * WebKit.vcproj/WebKit.def:
132         * WebKit.vcproj/WebKit_debug.def:
133         Export WTF::tlsKeyCount and WTF::tlsKeys.
134
135 2009-03-10  Steve Falkenburg  <sfalken@apple.com>
136
137         <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults
138         
139         Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.
140         
141         This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
142         The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
143         saying there was browsing history for a particular day, and then return no history items when we requested a
144         list of sites visited that day.        
145         
146         Reviewed by Ada Chan.
147
148         * MarshallingHelpers.cpp:
149         (MarshallingHelpers::DATEToCFAbsoluteTime):
150         (MarshallingHelpers::CFAbsoluteTimeToDATE):
151
152 2009-03-08  Mark Rowe  <mrowe@apple.com>
153
154         Reviewed by Oliver Hunt.
155
156         Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
157         Frame.h no longer needs to include it.  This cuts the size of the symbols
158         for a debug build by around 3%.
159
160         * WebView.cpp:
161         (WebView::centerSelectionInVisibleArea):
162
163 2009-03-07  Dan Bernstein  <mitz@apple.com>
164
165         Reviewed by Mark Rowe.
166
167         - WebKit part of removing build-time and run-time support for legacy
168           versions of CFNetwork and Core Graphics
169
170         * WebView.cpp:
171         (WebView::setCacheModel):
172
173 2009-03-04  Adam Barth  <abath@webkit.org>
174
175         Reviewed by Alexey Proskuryakov.
176
177         https://bugs.webkit.org/show_bug.cgi?id=24356
178
179         Fix WebKit style for allowUniversalAccessFromFileURLs.
180
181         * Interfaces/IWebPreferencesPrivate.idl:
182         * WebPreferenceKeysPrivate.h:
183         * WebPreferences.cpp:
184         (WebPreferences::initializeDefaultSettings):
185         (WebPreferences::allowUniversalAccessFromFileURLs):
186         (WebPreferences::setAllowUniversalAccessFromFileURLs):
187         * WebPreferences.h:
188         * WebView.cpp:
189         (WebView::notifyPreferencesChanged):
190
191 2009-02-27  Adam Barth  <abarth@webkit.org>
192
193         Reviewed by Eric Seidel.
194
195         Add a preference to reduce the power of file:// URLs.
196
197         * Interfaces/IWebPreferencesPrivate.idl:
198         * WebPreferenceKeysPrivate.h:
199         * WebPreferences.cpp:
200         (WebPreferences::initializeDefaultSettings):
201         (WebPreferences::allowUniversalAccessFromFileUrls):
202         (WebPreferences::setAllowUniversalAccessFromFileUrls):
203         * WebPreferences.h:
204         * WebView.cpp:
205         (WebView::notifyPreferencesChanged):
206
207 2009-02-19  Alexey Proskuryakov  <ap@webkit.org>
208
209         Reviewed by Darin Adler.
210
211         https://bugs.webkit.org/show_bug.cgi?id=24024
212         REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
213         archiving a submission to about:blank
214
215         I don't know how to make an automated test for this bug.
216
217         * WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be
218         non-empty for non-HTTP requests.
219
220 2009-02-25  Andreia Gaita  <shana@jitted.com>
221
222         Reviewed by Alp Toker.
223
224         Update Win def files with recent JavaScriptCore API additions.
225
226         * WebKit.vcproj/WebKit.def:
227         * WebKit.vcproj/WebKit_Cairo.def:
228         * WebKit.vcproj/WebKit_debug.def:
229
230 2009-02-24  Sam Weinig  <sam@webkit.org>
231
232         Reviewed by Geoffrey Garen.
233
234         Related to <rdar://problem/6590295>
235         Allow disabling javascript: urls.
236
237         * Interfaces/IWebViewPrivate.idl:
238         * WebView.cpp:
239         (WebView::setJavaScriptURLsAreAllowed):
240         * WebView.h:
241
242 2009-02-24  Adam Roben  <aroben@apple.com>
243
244         Windows build fix
245
246         * WebKit.vcproj/WebKit.def:
247         * WebKit.vcproj/WebKit_debug.def:
248         Export WTF::ThreadCondition::timedWait.
249
250 2009-02-12  Brady Eidson  <beidson@apple.com>
251
252         Reviewed by Kevin Decker
253
254         <rdar://problem/6582180> - Wrong HTTP method applied to history item.
255
256         * WebCoreSupport/WebFrameLoaderClient.cpp:
257         (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any
258           redirected request.
259
260 2009-02-11  Brady Eidson  <beidson@apple.com>
261
262         Fix my last checkin for more effect.
263
264         * WebHistoryItem.cpp:
265         (WebHistoryItem::initFromDictionaryRepresentation):
266
267 2009-02-11  Adam Roben  <aroben@apple.com>
268
269         Windows fix for Bug 22239: Implement missing animation & transition
270         APIs on LayoutTestController for non-mac platforms
271
272         <https://bugs.webkit.org/show_bug.cgi?id=22239>
273
274         Reviewed by Simon Fraser.
275
276         * Interfaces/IWebFramePrivate.idl: Added pauseAnimation,
277         pauseTransition, and numberOfActiveAnimations.
278
279         * WebFrame.cpp:
280         (WebFrame::pauseAnimation):
281         (WebFrame::pauseTransition):
282         (WebFrame::numberOfActiveAnimation):
283         Added. These all call through to AnimationController.
284
285         * WebFrame.h: Added pauseAnimation, pauseTransition, and
286         numberOfActiveAnimations.
287
288 2009-02-11  Brady Eidson  <beidson@apple.com>
289
290         Reviewed by Mark Rowe
291
292         <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative
293
294         Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed 
295         and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
296         which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.
297
298         * WebHistory.cpp:
299         (WebHistory::loadHistoryGutsFromURL):
300         (WebHistory::addItems):
301         (WebHistory::addItem): Add a mode that allows the entry being added to be discarded if an entry for the URL already 
302           exists.  Use that mode when reading the History.plist so only the most recent entry for a given URL will be used.
303         (WebHistory::visitedURL): Swap the removeItemFromDateCaches and visitedWithTitle calls.
304         * WebHistory.h:
305
306         * WebHistoryItem.cpp:
307         (WebHistoryItem::initFromDictionaryRepresentation):  Add the negative-visit-count-correction-logic as implemented
308           for Mac in http://trac.webkit.org/changeset/40851.
309
310 2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>
311
312         Stub out WebInspectorClient::hiddenPanels.
313
314         Reviewed by Timothy Hatcher.
315
316         * WebCoreSupport/WebInspectorClient.cpp:
317         (WebInspectorClient::hiddenPanels):
318         * WebCoreSupport/WebInspectorClient.h:
319
320 2009-02-11  Adam Roben  <aroben@apple.com>
321
322         Don't release the shared WebHistory instance on quit
323
324         This matches Mac, and prevents a race condition when the process exits
325         that depends on the order in which global destructors are invoked.
326
327         Reviewed by Alexey Proskuryakov.
328
329         * WebHistory.cpp:
330         (sharedHistoryStorage): Changed to use DEFINE_STATIC_LOCAL so the
331         destructor is never called.
332
333 2009-02-10  Adam Roben  <aroben@apple.com>
334
335         Fix recursive WebView destruction when running DumpRenderTree
336
337         DumpRenderTree would call DestroyWindow on a WebView's host window,
338         which would send a WM_DESTROY message to the WebView's window. Inside
339         the WebView's WndProc, we would hold a ref to the WebView, then call
340         close() and revokeDragDrop(), which would release all remaining
341         references to the WebView other than the ref we held in the WndProc.
342         When the WndProc exited, the final ref to the WebView would be
343         released, invoking WebView's destructor. At this point,
344         IsWindow(m_viewWindow) would return true, since we were still in the
345         process of handling WM_DESTROY, so we would call DestroyWindow on the
346         WebView's window again, re-entering the WndProc and re-reffing the
347         WebView, leading to recursive destruction.
348
349         Reviewed by Alexey Proskuryakov.
350
351         * WebView.cpp:
352         (WebView::~WebView): Don't call DestroyWindow if our window is already
353         being destroyed.
354         (WebViewWndProc): Only hold an extra ref to the WebView when we're not
355         being destroyed.
356
357 2009-02-06  Adam Roben  <aroben@apple.com>
358
359         Build fix
360
361         Reviewed by Sam Weinig.
362
363         * WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include.
364         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed
365         incorrect .get(), and changed to use the new overload of
366         WebHistory::itemForURLString.
367
368         * WebHistory.cpp:
369         (WebHistory::itemForURLString): Made this const.
370         (WebHistory::itemForURLString): Added an overload that takes a
371         WebCore::String and returns the IWebHistoryItem instead of using an
372         out parameter.
373
374         * WebHistory.h: Added public overload of itemForURLString.
375
376         * WebView.cpp:
377         (WebView::prepareCandidateWindow):
378         (WebView::onIMERequestCharPosition):
379         (WebView::onIMERequestReconvertString):
380         Updated for toRange -> toNormalizedRange rename.
381
382 2009-02-06  Geoffrey Garen  <ggaren@apple.com>
383
384         Reviewed by Sam Weinig.
385
386         Part III of <rdar://problem/6552272>.
387         
388         Refactored to use the redirect data WebCore makes available, instead of
389         tracking loading state in WebKit.
390         
391         * WebCoreSupport/WebFrameLoaderClient.cpp:
392         (WebFrameLoaderClient::updateGlobalHistory):
393         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
394         * WebCoreSupport/WebFrameLoaderClient.h:
395         * WebHistory.cpp:
396         (WebHistory::visitedURL):
397         * WebHistory.h:
398
399 2009-02-06  Dan Bernstein  <mitz@apple.com>
400
401         Reviewed by Anders Carlsson.
402
403         - fix an assertion failure in Vector::at() beneath
404           WebHistoryItem::dictionaryRepresentation.
405
406         * WebHistoryItem.cpp:
407         (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial
408         size. Also reduced the inline capacity of the vector used for weekly visit
409         counts to 5, which is the expected maximum size.
410
411 2009-02-06  Brent Fulgham  <bfulgham@webkit.org>
412
413         Build fix.  
414
415         * WebKit.vcproj/WebKit.vcproj: Re-enable missing file in Release
416           target of Cairo.
417
418 2009-02-06  Maciej Stachowiak  <mjs@apple.com>
419
420         Rubber stamped by Dan Bernstein.
421
422         - fix obvious problem in previous commit (|| used instead of &&)
423
424         * WebHistoryItem.cpp:
425         (WebHistoryItem::initFromDictionaryRepresentation):
426
427 2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>
428
429         Reviewed by Dan Bernstein and Geoff Garen..
430
431         - WebKit code to track per-day and per-week visit counts in history
432
433         For now this data is only exposed via SPI for performance reasons.
434
435         * Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
436         * WebHistory.cpp:
437         (WebHistory::visitedURL): Use new recordInitialVisit method.
438         * WebHistoryItem.cpp:
439         (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support
440         for new data.
441         (WebHistoryItem::dictionaryRepresentation): Add saving support for
442         new data.
443         (WebHistoryItem::getDailyVisitCounts): SPI accessor.
444         (WebHistoryItem::getWeeklyVisitCounts): SPI accessor.
445         (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
446         * WebHistoryItem.h:
447
448 2009-02-05  Brent Fulgham  <bfulgham@webkit.org>
449
450         Reviewed by Sam Weinig <sam@webkit.org>
451
452         Build fix.  Update file for recently removed EventTargetNodeCast.
453         * DOMCoreClasses.cpp:
454         (DOMNode::dispatchEvent):
455
456 2009-02-05  Aaron Boodman  <aa@chromium.org>
457
458         Reviewed by Dave Hyatt.
459
460         https://bugs.webkit.org/show_bug.cgi?id=23708
461         Adds documentElementAvailable() callback to FrameLoaderClient.
462
463         * WebFrame.cpp:
464         (WebFrame::documentElementAvailable):
465         Stub out documentElementAvailable()
466         * WebFrame.h:
467         Ditto.
468
469 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
470
471         Build fix.
472
473         * WebHistory.cpp:
474         (WebHistory::visitedURL):
475
476 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
477
478         Reviewed by Mark Rowe.
479         
480         Part I of <rdar://problem/6552272>.
481
482         Clear the redirectURLs entry when first visiting a site, so sites that
483         only redirect you the first time you visit them can later learn that
484         they don't redirect.
485
486         * WebHistory.cpp:
487         (WebHistory::visitedURL):
488
489 2009-02-03  Geoffrey Garen  <ggaren@apple.com>
490
491         Build fix.
492
493         * WebHistory.cpp:
494         (WebHistory::visitedURL):
495
496 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
497
498         Build fix.
499
500         * WebHistory.cpp:
501         (WebHistory::visitedURL):
502
503 2009-02-02  Hiroaki Nakamura <hnakamur@gmail.com>
504
505         Reviewed by Adam Roben.
506
507         Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
508         Modify pre-build step to properly handle the errorlevel
509         shell command.
510
511         * WebKit.vcproj/WebKit.vcproj: Change errorlevel handling
512         for all targets so prefast is only enabled in builds
513         where /analyze is available.
514
515 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
516
517         Reviewed by Sam Weinig.
518
519         Track redirects in global history.
520
521         * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
522
523         * WebCoreSupport/WebFrameLoaderClient.cpp:
524         (WebFrameLoaderClient::updateGlobalHistory):
525         (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
526         Store redirect information in global history.
527
528         (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
529
530         * WebCoreSupport/WebFrameLoaderClient.h: See above.
531
532         * WebFrame.cpp:
533         (WebFrame::loadRequest):
534         (WebFrame::loadData): Updated for extra parameter.
535
536         * WebHistory.cpp:
537         (WebHistory::visitedURL):
538         (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
539         information in global history.
540
541         * WebHistory.h: See above.
542
543 2009-02-02  Brady Eidson  <beidson@apple.com>
544
545         Reviewed by Dan Bernstein
546
547         Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.
548
549         * Interfaces/IWebHistoryItemPrivate.idl:
550         * WebCoreSupport/WebFrameLoaderClient.cpp:
551         (WebFrameLoaderClient::updateGlobalHistory):
552
553         * WebHistory.cpp:
554         (WebHistory::visitedURL):
555         * WebHistory.h:
556
557         * WebHistoryItem.cpp:
558         (WebHistoryItem::visitedWithTitle):
559         * WebHistoryItem.h:
560
561 2009-02-02  Anders Carlsson  <andersca@apple.com>
562
563         Fix build.
564         
565         * WebCoreSupport/WebFrameLoaderClient.cpp:
566         (WebFrameLoaderClient::createPlugin):
567         * WebCoreSupport/WebFrameLoaderClient.h:
568
569 2009-02-02  Anders Carlsson  <andersca@apple.com>
570
571         Reviewed by Dan Bernstein.
572
573         Update for changes to WebCore.
574
575         * WebFrame.cpp:
576         (WebFrame::createJavaAppletWidget):
577         * WebFrame.h:
578
579 2009-02-02  Holger Hans Peter Freyther  <zecke@selfish.org>
580
581         Reviewed by Darin Adler.
582
583         Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
584
585         https://bugs.webkit.org/show_bug.cgi?id=23428
586
587         FrameView::forceLayout could be killed but the comment might
588         contain a value over the the plain FrameView::layout...
589
590         Adjust the WebCore/WebKit consumers of these methods.
591
592         * WebCoreSupport/WebFrameLoaderClient.cpp:
593         (WebFrameLoaderClient::forceLayout):
594
595 2009-01-31  Matt Lilek  <webkit@mattlilek.com>
596
597         Not reviewed, build fixes.
598
599         * WebCoreSupport/WebContextMenuClient.cpp:
600         (WebContextMenuClient::searchWithGoogle):
601         * WebFrame.cpp:
602         (WebFrame::setInPrintingMode):
603         (WebFrame::isFrameSet):
604         * WebView.cpp:
605         (WebView::notifyPreferencesChanged):
606
607 2009-01-30  Adam Barth  <abarth@webkit.org>
608
609         Reviewed by Sam Weinig.
610
611         Add a pref to disable web security.
612
613         * Interfaces/IWebPreferencesPrivate.idl:
614         * WebPreferenceKeysPrivate.h:
615         * WebPreferences.cpp:
616         (WebPreferences::initializeDefaultSettings):
617         (WebPreferences::isWebSecurityEnabled):
618         (WebPreferences::setWebSecurityEnabled):
619         * WebPreferences.h:
620         * WebView.cpp:
621         (WebView::notifyPreferencesChanged):
622
623 2009-01-30  Geoffrey Garen  <ggaren@apple.com>
624
625         Build fix.
626
627         * Interfaces/IWebFramePrivate.idl:
628         * WebCoreSupport/WebFrameLoaderClient.cpp:
629         (WebFrameLoaderClient::loadURLIntoChild):
630
631 2009-01-30  Holger Hans Peter Freyther  <zecke@selfish.org>
632
633         Reviewed by Simon Hausmann.
634
635         Kill FrameLoaderClient.cpp, move the code over to Frame::createView
636
637         FrameLoaderClient is supposed to be an interface, move the
638         to be shared code to Frame which is a controller and is
639         allowed to create a FrameView.
640
641         * WebCoreSupport/WebFrameLoaderClient.cpp:
642         (WebFrameLoaderClient::transitionToCommittedForNewPage):
643
644 2009-01-30  Brady Eidson  <beidson@apple.com>
645
646         Reviewed by Sam Weinig
647
648         Remove FrameLoaderClient code that is now handled by FrameLoader itself
649
650         * WebFrame.cpp:
651         (WebFrame::frameLoadCompleted):
652
653 2009-01-29  Sam Weinig  <sam@webkit.org>
654
655         Fix Windows build
656
657         * WebHistoryItem.cpp:
658         (WebHistoryItem::initFromDictionaryRepresentation):
659
660 2009-01-29  Sam Weinig  <sam@webkit.org>
661
662         Reviewed by Anders Carlsson.
663
664         Second step in tracking the urls a HistoryItem was redirected through
665         Add SPI to access the array of redirect urls associated with a HistoryItem.
666
667         * Interfaces/IWebHistoryItemPrivate.idl:
668         * WebHistoryItem.cpp:
669         (WebHistoryItem::dictionaryRepresentation):
670         (WebHistoryItem::redirectURLs):
671         * WebHistoryItem.h:
672
673 2009-01-29  Sam Weinig  <sam@webkit.org>
674
675         Reviewed by Mark Rowe.
676
677         First step in tracking the urls a HistoryItem was redirected through.
678
679         * WebHistoryItem.cpp:
680         (WebHistoryItem::initFromDictionaryRepresentation):
681         (WebHistoryItem::dictionaryRepresentation):
682
683 2009-01-29  Adam Roben  <aroben@apple.com>
684
685         Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
686         receives a WM_PRINTCLIENT message
687
688         <https://bugs.webkit.org/show_bug.cgi?id=23623>
689         <rdar://problem/6513921>
690         <rdar://problem/6536874>
691
692         Reviewed by Darin Adler.
693
694         * WebFrame.cpp:
695         (WebFrame::paintDocumentRectToContext):
696         (WebFrame::spoolPages):
697         Call GraphicsContext::setShouldIncludeChildWindows so that child
698         windows will be painted into the GraphicsContext rather than painted
699         directly to the screen.
700
701         * WebView.cpp:
702         (WebView::updateBackingStore): Added a windowsToPaint parameter, which
703         we pass along to paintIntoBackingStore.
704
705         (WebView::paint): Tell updateBackingStore to paint child windows if
706         we're not painting to the screen.
707
708         (WebView::paintIntoBackingStore): Added a windowsToPaint paramter,
709         which we use to tell our GraphicsContext whether or not to include
710         child windows.
711
712         * WebView.h: Added windowsToPaint parameters to paintIntoBackingStore
713         and updateBackingStore (which I also made private).
714
715 2009-01-29  Adam Roben  <aroben@apple.com>
716
717         Build fix after r40353
718
719         * WebCoreSupport/WebFrameLoaderClient.cpp:
720         (WebFrameLoaderClient::loadURLIntoChild): Removed the check for
721         FrameLoadTypeReloadAllowingStaleData.
722
723 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
724
725         Reviewed by Sam Weinig.
726
727         Updated for WebCore rename.
728         
729         * WebView.cpp:
730         (WebView::setCustomTextEncodingName):
731
732 2009-01-27  Brady Eidson  <beidson@apple.com>
733
734         Reviewed by Dan Bernstein
735
736         Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
737
738         * WebCoreSupport/WebFrameLoaderClient.cpp:
739         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
740         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
741         * WebCoreSupport/WebFrameLoaderClient.h:
742
743         * WebFrame.cpp:
744         * WebFrame.h:
745
746 2009-01-26  Adam Roben  <aroben@apple.com>
747
748         Fix an assertion failure when Safari loads an error page
749
750         Reviewed by Alexey Proskuryakov.
751
752         * WebFrame.cpp:
753         (WebFrame::loadData): Use the two-argument version of KURL and
754         MarshallingHelpers::BSTRToKURL, for reasons mentioned in r40248.
755
756 2009-01-26  Adam Roben  <aroben@apple.com>
757
758         Fix an assertion on launch in KURL::KURL
759
760         All URL strings passed in to the WebKit API need to be passed to
761         MarshallingHelpers::BSTRToKURL so that they may be properly parsed.
762
763         Reviewed by Alexey Proskuryakov.
764
765         * MarshallingHelpers.cpp:
766         (MarshallingHelpers::BSTRToKURL): Changed to use the two-argument
767         constructor for KURL so that the strings will be parsed rather than
768         assumed to be in the correct encoding/form.
769
770         * WebResource.cpp:
771         (WebResource::initWithData):
772         * WebURLResponse.cpp:
773         (WebURLResponse::initWithURL):
774         * WebView.cpp:
775         (WebView::userAgentForURL):
776         (WebView::copyURL):
777         Changed to use MarshallingHelpers::BSTRToKURL instead of trying to do
778         the work manually.
779
780 2009-01-25  Darin Adler  <darin@apple.com>
781
782         Try to fix Windows build.
783
784         * WebView.cpp: Added FloatQuad.h.
785
786 2009-01-23  Brent Fulgham  <bfulgham@webkit.org>
787
788         Reviewed by Darin Adler
789
790         https://bugs.webkit.org/show_bug.cgi?id=23492
791         Exclude calls to WebKitSystemInterface functions when not
792         using CoreGraphics.
793
794         * WebPreferences.cpp:
795         (WebPreferences::setFontSmoothing): 
796         (WebPreferences::setFontSmoothingContrast):
797         * WebTextRenderer.cpp:
798         (WebTextRenderer::registerPrivateFont):
799
800 2009-01-23  Brady Eidson  <beidson@apple.com>
801
802         Rubberstamped by Darin Adler
803
804         Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
805
806         * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
807         (WebCachedFramePlatformData::WebCachedFramePlatformData):
808         * WebCachedPagePlatformData.h: Removed.
809
810         * WebCoreSupport/WebFrameLoaderClient.cpp:
811         (WebFrameLoaderClient::savePlatformDataToCachedPage):
812
813         * WebKit.vcproj/WebKit.vcproj:
814
815 2009-01-22  Eric Roman  <eroman@chromium.org>
816
817         Reviewed by Eric Seidel.
818
819         https://bugs.webkit.org/show_bug.cgi?id=20806
820         Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
821
822         * WebHistoryItem.cpp:
823         (WebHistoryItem::RSSFeedReferrer):
824         (WebHistoryItem::setRSSFeedReferrer):
825
826 2009-01-19  Sam Weinig  <sam@webkit.org>
827
828         Rubber-stamped by Gavin Barraclough.
829
830         Remove temporary operator-> from JSValuePtr.
831
832         * WebScriptCallFrame.cpp:
833         (WebScriptCallFrame::jsValueToString):
834         * WebView.cpp:
835         (WebView::stringByEvaluatingJavaScriptFromString):
836
837 2009-01-19  Adam Roben  <aroben@apple.com>
838
839         Windows build fix
840
841         * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
842         individual using directives for each type we need from that namespace,
843         to avoid conflicts between DOMObject and WebCore::DOMObject.
844         (DOMElement::font): Added a now-needed WebCore::.
845
846 2009-01-17  Steve Falkenburg  <sfalken@apple.com>
847
848         Build fix.
849
850         * WebCoreSupport/WebDragClient.cpp:
851         (WebDragClient::createDragImageForLink):
852
853 2009-01-17  David Hyatt  <hyatt@apple.com>
854
855         Eliminate dependencies on backslashAsCurrencySymbol from WebKit.
856
857         Reviewed by Oliver Hunt
858
859         * WebFrame.cpp:
860         (WebFrame::selectedString):
861
862 2009-01-16  Steve Falkenburg  <sfalken@apple.com>
863
864         <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
865         
866         This was caused by mismatched ENABLE definitions across WebCore and WebKit.
867         
868         Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
869         In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
870         to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
871         Our Windows ENABLE flags now match Mac.
872         
873         Reviewed by Adele Peterson.
874
875         * WebKit.vcproj/WebKit.vcproj:
876
877 2009-01-15  Adele Peterson  <adele@apple.com>
878
879         Reviewed by Darin Adler.
880         
881         Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
882         <rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html
883         
884         Return S_OK or E_FAIL based on the result from CreateInstance.
885         This was causing DumpRenderTree to not realize it had just gotten a null documentElement.
886         
887         * DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent.
888         (DOMNode::parentNode):
889         (DOMNode::ownerDocument):
890         (DOMNodeList::item):
891         (DOMDocument::documentElement):
892         (DOMDocument::createElement):
893         (DOMDocument::getElementsByTagName):
894         (DOMDocument::getElementsByTagNameNS):
895         (DOMDocument::getElementById):
896         (DOMDocument::getComputedStyle):
897         (DOMDocument::createEvent):
898         (DOMElement::style):
899
900 2009-01-14  Adele Peterson  <adele@apple.com>
901
902         Reviewed by Darin Adler.
903
904         Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
905         <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
906         
907         Added artwork.
908         
909         * WebKit.vcproj/WebKit.rc:
910         * WebKit.vcproj/WebKit.vcproj:
911         * WebKit.vcproj/resource.h:
912         * WebKit.vcproj/searchCancel.png: Added.
913         * WebKit.vcproj/searchCancelPressed.png: Added.
914         * WebKit.vcproj/searchMagnifier.png: Added.
915         * WebKit.vcproj/searchMagnifierResults.png: Added.
916         * WebKitDLL.cpp:(loadResourceIntoBuffer):
917
918 2009-01-14  Dan Bernstein  <mitz@apple.com>
919
920         Reviewed by John Sullivan.
921
922         - update copyright
923
924         * WebKit.resources/Info.plist:
925         * WebKit.vcproj/WebKit.rc:
926
927 2009-01-13  Steve Falkenburg  <sfalken@apple.com>
928
929         Build fix.
930
931         * WebScriptCallFrame.cpp:
932         (WebScriptCallFrame::jsValueToString):
933
934 2009-01-12  Brady Eidson  <beidson@apple.com>
935
936         Reviewed by Dan Bernstein
937         
938         <rdar://problem/6490446> - Crash when going back to a cached page
939
940         * WebCoreSupport/WebFrameLoaderClient.cpp:
941         (WebFrameLoaderClient::savePlatformDataToCachedPage):  ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
942
943 2009-01-12  Brady Eidson  <beidson@apple.com>
944
945         Reviewed by Darin Adler
946
947         <rdar://problem/6468274> - Track Non-get requests in global history
948
949         * WebCoreSupport/WebFrameLoaderClient.cpp:
950         (WebFrameLoaderClient::updateGlobalHistory):
951
952         * WebHistory.cpp:
953         (WebHistory::addItem):
954         * WebHistory.h:
955
956         * Interfaces/IWebHistoryItemPrivate.idl:
957         * WebHistoryItem.cpp:
958         (WebHistoryItem::initFromDictionaryRepresentation):
959         (WebHistoryItem::dictionaryRepresentation):
960         (WebHistoryItem::lastVisitWasHTTPNonGet):
961         (WebHistoryItem::setLastVisitWasHTTPNonGet):
962         * WebHistoryItem.h:
963
964 2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
965
966         Reviewed by Darin Adler.
967
968         Bug 22861: Turn the FontCache into a singleton
969         https://bugs.webkit.org/show_bug.cgi?id=22861
970
971         * WebCoreStatistics.cpp:
972         (WebCoreStatistics::cachedFontDataCount):
973         (WebCoreStatistics::cachedFontDataInactiveCount):
974         (WebCoreStatistics::purgeInactiveFontData):
975         Redirected all the static calls to the global FontCache
976         instance.
977
978 2009-01-11  Dmitry Titov  <dimich@chromium.org>
979
980         Reviewed by Darin Adler.
981
982         https://bugs.webkit.org/show_bug.cgi?id=23207
983         Moved currentTime() to from WebCore to WTF.
984
985         * WebDownload.cpp: a different header file included.
986         * WebDropSource.cpp: a different header file included.
987
988 2009-01-09  Darin Adler  <darin@apple.com>
989
990         Reviewed by Jon Honeycutt.
991
992         Bug 22913: REGRESSION: Space bar doesn't scroll on windows
993         https://bugs.webkit.org/show_bug.cgi?id=22913
994         rdar://problem/6479834
995
996         * WebView.cpp:
997         (WebView::keyPress): Removed code to handle space bar here; put it in
998         WebCore instead.
999
1000 2009-01-09  Brent Fulgham  <bfulgham@gmail.com>
1001
1002         Reviewed by Adam Roben.
1003
1004         Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
1005         Separate CFNetwork-specific code in WebKit.dll into separate
1006         implementation files. Create cURL stub files to be populated
1007         with new implementation in a future bug report. 
1008
1009         * WebCookieManager.cpp: Move CFNetwork-specific routines to
1010           the new WebCookieManagerCFNet.cpp file.
1011         (WebCookieManager::Release):
1012         * WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp.
1013         (WebCookieManager::cookieStorage):
1014         * WebCookieManagerCurl.cpp: Added.
1015         (WebCookieManager::cookieStorage):
1016         (WebCookieManager::setCookieStorage):
1017         * WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two
1018           methods in this file.
1019         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1020         (WebFrameLoaderClient::savePlatformDataToCachedPage):
1021         * WebDownload.cpp: Move CFNetwork-specific logic to the new
1022           WebDownloadCFNet.cpp
1023         (WebDownload::bundleExtension):
1024         (WebDownload::bundleMagicNumber):
1025         (WebDownload::bundlePathForTargetPath):
1026         (WebDownload::extractResumeDataFromBundle): Made static class method
1027           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
1028         (WebDownload::appendResumeDataToBundle): Made static class method
1029           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
1030         * WebDownload.h:
1031         * WebDownloadCFNet.cpp: Copied from WebDownload.cpp.
1032         (WebDownload::initToResumeWithBundle):
1033         (WebDownload::setDestination):
1034         (didFailCallback):
1035         * WebDownloadCurl.cpp: Added.
1036         (WebDownload::init):
1037         (WebDownload::initWithRequest):
1038         (WebDownload::initToResumeWithBundle):
1039         (WebDownload::start):
1040         (WebDownload::cancel):
1041         (WebDownload::cancelForResume):
1042         (WebDownload::deletesFileUponFailure):
1043         (WebDownload::setDeletesFileUponFailure):
1044         (WebDownload::setDestination):
1045         (WebDownload::cancelAuthenticationChallenge):
1046         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
1047         (WebDownload::useCredential):
1048         * WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the
1049           new cURL files. Modify Cairo targets to exclude CFNet files.
1050         * WebMutableURLRequest.cpp: Conditionalize the single method
1051           with a CFNetwork-speicic call.
1052         (WebMutableURLRequest::mutableCopy):
1053         * WebURLAuthenticationChallenge.cpp: Conditionalize one line that
1054           causes build problems for cURL. This will be removed later.
1055         (WebURLAuthenticationChallenge::initWithProtectionSpace):
1056         * WebURLAuthenticationChallengeSender.cpp:
1057         * WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp.
1058         (WebURLAuthenticationChallengeSender::useCredential):
1059         * WebURLAuthenticationChallengeSenderCurl.cpp: Added.
1060         (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
1061         (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
1062         (WebURLAuthenticationChallengeSender::useCredential):
1063         * WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling
1064           for the cURL target.
1065
1066 2009-01-09  Alexey Proskuryakov  <ap@webkit.org>
1067
1068         Reviewed by Darin Adler.
1069
1070         Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
1071
1072         * WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can
1073         raise exceptions, as needed for AppCache tests. I do not know why this error was not
1074         implemented.
1075
1076 2009-01-09  Darin Adler  <darin@apple.com>
1077
1078         Reviewed and landed by Adele Peterson.
1079
1080         Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
1081         https://bugs.webkit.org/show_bug.cgi?id=23160
1082
1083         * Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
1084         * WebView.cpp:
1085         (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
1086         * WebView.h: Ditto.
1087
1088 2009-01-08  Dan Bernstein  <mitz@apple.com>
1089
1090         Reviewed by Adam Roben.
1091
1092         - WebPreferences changes to support Core Graphics native glyph drawing
1093
1094         * Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast
1095         getter and setter.
1096         * WebPreferenceKeysPrivate.h: Added
1097         WebKitFontSmoothingContrastPreferenceKey.
1098         * WebPreferences.cpp:
1099         (WebPreferences::initializeDefaultSettings): Initialized
1100         WebKitFontSmoothingContrastPreferenceKey to 2.
1101         (WebPreferences::setFloatValue): Added.
1102         (WebPreferences::setFontSmoothing): Changed to map
1103         FontSmoothingTypeWindows to FontSmoothingTypeMedium.
1104         (WebPreferences::fontSmoothingContrast): Added.
1105         (WebPreferences::setFontSmoothingContrast): Added. Calls
1106         wkSetFontSmoothingContrast().
1107         * WebPreferences.h:
1108
1109 2009-01-08  Steve Falkenburg  <sfalken@apple.com>
1110
1111         <rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?
1112         
1113         Reviewed by Adam Roben.
1114
1115         * WebView.cpp:
1116         (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.
1117
1118 2009-01-07  Jon Honeycutt  <jhoneycutt@apple.com>
1119
1120         Fix a crash with querying a WebView for its global history item when
1121         its associated Page has no global history item.
1122
1123         Reviewed by Dan Bernstein.
1124
1125         * WebView.cpp:
1126         (WebView::globalHistoryItem): If the Page has no global history item,
1127         report 0.
1128
1129 2009-01-06  Adam Roben  <aroben@apple.com>
1130
1131         Fix Bug 22262: Clicking close ("X") button in docked Web Inspector
1132         clears Web Inspector but doesn't close it
1133
1134         <https://bugs.webkit.org/show_bug.cgi?id=22262>
1135         <rdar://problem/6371873>
1136
1137         Reviewed by Darin Adler.
1138
1139         * WebCoreSupport/WebInspectorClient.cpp:
1140         (WebInspectorClient::WebInspectorClient): Initialize new member.
1141         (WebInspectorClient::showWindow): Moved code from here to
1142         showWindowWithoutNotifications.
1143         (WebInspectorClient::closeWindow): Moved code from here to
1144         closeWindowWithoutNotifications.
1145
1146         (WebInspectorClient::attachWindow):
1147         (WebInspectorClient::detachWindow):
1148         Record whether or not we should be attached, then close and reopen the
1149         window without notifying the InspectorController. Code that was in
1150         these functions moved to showWindowWithoutNotifications and
1151         closeWindowWithoutNotifications, respectively.
1152
1153         (WebInspectorClient::closeWindowWithoutNotifications): Added. Code
1154         came from closeWindow and detachWindow.
1155         (WebInspectorClient::showWindowWithoutNotifications): Added. Code came
1156         from showWindow and attachWindow.
1157
1158         * WebCoreSupport/WebInspectorClient.h: Added
1159         {close,show}WindowWithoutNotifications and m_shouldAttachWhenShown.
1160
1161 2009-01-06  Anders Carlsson  <andersca@apple.com>
1162
1163         Reviewed by Sam Weinig.
1164
1165         Add a way for application to provide custom, full frame, views for certain MIME types.
1166         
1167         * Interfaces/IWebEmbeddedView.idl:
1168         Add loading related methods.
1169         
1170         * Interfaces/IWebViewPrivate.idl:
1171         Add new registerEmbeddedViewMIMEType method.
1172         
1173         * WebCoreSupport/EmbeddedWidget.cpp:
1174         (EmbeddedWidget::didReceiveResponse):
1175         (EmbeddedWidget::didReceiveData):
1176         (EmbeddedWidget::didFinishLoading):
1177         (EmbeddedWidget::didFail):
1178         Implement these and call the IEmbeddedView methods.
1179         
1180         * WebCoreSupport/EmbeddedWidget.h:
1181         Inherit from PluginManualLoader.
1182         
1183         * WebCoreSupport/WebFrameLoaderClient.cpp:
1184         (WebFrameLoaderClient::redirectDataToPlugin):
1185         Handle the case where the widget is an EnbeddedWidget.
1186         
1187         (WebFrameLoaderClient::shouldUsePluginDocument):
1188         Have this call WebView::shouldUseEmbeddedView.
1189         
1190         * WebView.cpp:
1191         (WebView::canShowMIMEType):
1192         Have this call WebView::shouldUseEmbeddedView.
1193         
1194         (WebView::registerEmbeddedViewMIMEType):
1195         Add the MIME type to the set.
1196         
1197         (WebView::shouldUseEmbeddedView):
1198         Given a MIME type, returns whether an embedded view should be used or not.
1199         
1200 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1201
1202         BUILD FIX (r39641): Try to fix WebIconDatabase build errors #4
1203
1204         * WebIconDatabase.cpp:
1205         (WebIconDatabase::isEnabled): Added 'WebIconDatabase::' to method
1206         signature.  (Another copy-paste error.)
1207         (WebIconDatabase::setEnabled): Ditto.
1208         * WebIconDatabase.h:
1209         (WebIconDatabase::startUpIconDatabase): Make private again.
1210         (WebIconDatabase::shutDownIconDatabase): Ditto.
1211
1212 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1213
1214         BUILD FIX (r39641): Try to fix build errors #3
1215
1216         Try to fix the following (more specific) build errors:
1217
1218             WebIconDatabase.cpp
1219             ..\WebIconDatabase.cpp(255) : error C2248: 'WebIconDatabase::shutDownIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1220                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1221                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1222             ..\WebIconDatabase.cpp(255) : error C2352: 'WebIconDatabase::shutDownIconDatabase' : illegal call of non-static member function
1223                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1224             ..\WebIconDatabase.cpp(258) : error C2248: 'WebIconDatabase::startUpIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1225                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1226                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1227             ..\WebIconDatabase.cpp(258) : error C2352: 'WebIconDatabase::startUpIconDatabase' : illegal call of non-static member function
1228                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1229
1230         * WebIconDatabase.cpp:
1231         (setEnabled): Get instance of shared WebIconDatabase, then call
1232         startUp/shutDown methods on it.
1233         * WebIconDatabase.h:
1234         (WebIconDatabase::startUpIconDatabase): Make protected again.
1235         (WebIconDatabase::shutDownIconDatabase): Ditto.
1236
1237 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1238
1239         BUILD FIX (r39641): Try to fix build errors again
1240
1241         Try to fix the following build errors:
1242
1243             WebIconDatabase.cpp
1244             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1245             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1246
1247         * WebIconDatabase.cpp:
1248         (setEnabled): Add class prefix to startUpIconDatabase() and
1249         shutDownIconDatabase().
1250         * WebIconDatabase.h:
1251         (WebIconDatabase::startUpIconDatabase): Make private again.
1252         (WebIconDatabase::shutDownIconDatabase): Ditto.
1253
1254 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1255
1256         BUILD FIX (r39641): Try to fix build error
1257
1258         Try to fix the following build errors:
1259
1260             WebIconDatabase.cpp
1261             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1262             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1263
1264         * WebIconDatabase.h:
1265         (WebIconDatabase::startUpIconDatabase): Make protected.
1266         (WebIconDatabase::shutDownIconDatabase): Ditto.
1267
1268 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1269
1270         BUILD FIX (r39641): Fix more silly errors
1271
1272         Fixes the following compilation errors:
1273
1274             WebIconDatabase.cpp
1275             ..\WebIconDatabase.cpp(85) : error C2065: 'standardPrefs' : undeclared identifier
1276             ..\WebIconDatabase.cpp(85) : error C2227: left of '->iconDatabaseLocation' must point to class/struct/union/generic type
1277                     type is ''unknown-type''
1278             ..\WebIconDatabase.cpp(241) : error C2575: 'isEnabled' : only member functions and bases can be virtual
1279             ..\WebIconDatabase.cpp(248) : error C2575: 'setEnabled' : only member functions and bases can be virtual
1280             ..\WebIconDatabase.cpp(253) : error C3861: 'shutDownIconDatabase': identifier not found
1281             ..\WebIconDatabase.cpp(256) : error C3861: 'startUpIconDatabase': identifier not found
1282
1283         * WebIconDatabase.cpp:
1284         (WebIconDatabase::startUpIconDatabase): Redeclare standardPrefs
1285         since this was in init() but not in this method after it was
1286         extracted from init().
1287         (isEnabled): Don't use "virtual" in method implementation
1288         (silly copy-paste error).
1289         (setEnabled): Ditto.
1290
1291 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1292
1293         BUILD FIX (r39641): Remove STDMETHODCALLTYPE from method declarations in IWebIconDatabase.idl
1294
1295         * Interfaces/IWebIconDatabase.idl: Removed "STDMETHODCALLTYPE"
1296         from silly copy-paste error in two method declarations.
1297
1298 2009-01-05  David Kilzer  <ddkilzer@apple.com>
1299
1300         Add API to enable, disable and check state of WebIconDatabase
1301
1302         Reviewed by Darin Adler & Timothy Hatcher.
1303
1304         Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
1305         API to make it possible to enable, disable and check the state of
1306         the icon database.
1307
1308         * Interfaces/IWebIconDatabase.idl: Declared isEnabled() and
1309         setEnabled() methods.
1310         * WebIconDatabase.cpp:
1311         (WebIconDatabase::init): Extracted code into startUpIconDatabase().
1312         (WebIconDatabase::startUpIconDatabase): Added.  Extracted from
1313         init().
1314         (WebIconDatabase::shutDownIconDatabase): Added.  Method is empty
1315         since there is nothing to do yet on Windows.
1316         (isEnabled): Added.
1317         (setEnabled): Added.
1318         * WebIconDatabase.h: Added method declarations.
1319
1320 2009-01-05  Anders Carlsson  <andersca@apple.com>
1321
1322         Reviewed by Jon Honeycutt.
1323
1324         Pass more information in the property bag passed to embeddedViewWithArguments.
1325         
1326         * Interfaces/IWebUIDelegatePrivate.idl:
1327         Declare new keys.
1328         
1329         * WebCoreSupport/WebFrameLoaderClient.cpp:
1330         (WebFrameLoaderClient::createPlugin):
1331         Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.
1332
1333 2009-01-05  Anders Carlsson  <andersca@apple.com>
1334
1335         Reviewed by Darin Adler, Jon Honeycutt.
1336
1337         Add a templatized COMVariant constructor so we can make COMVariants out of
1338         everything that has a COMVariantSetter specialization.
1339         
1340         Add a COMVariantSetter specialization for COMVariant.
1341         
1342         * COMVariantSetter.h:
1343         (COMVariant::COMVariant):
1344
1345 2009-01-05  Brent Fulgham  <bfulgham@gmail.com>
1346
1347         Reviewed by Oliver Hunt.
1348
1349         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23027
1350
1351         Removes the WebKitGraphics files from the Cairo build, as well
1352         as excluding their link definitions.  These are not used outside
1353         of Safari, and should not be part of the 'Redistributable API.'
1354
1355         * WebKit.vcproj/WebKit.vcproj:  Update *_Cairo targets to exclude
1356           the WebKitGraphics.cpp/.h files.
1357         * WebKit.vcproj/WebKit_Cairo.def: Added.  File without Safari
1358           link definitions.
1359         * WebKit.vcproj/WebKit_Cairo_debug.def: Added.  File without Safari
1360           link definitions.
1361
1362 2009-01-05  Anders Carlsson  <andersca@apple.com>
1363
1364         Reviewed by Jon Honeycutt.
1365
1366         Add a simple, memory managed, wrapper around a VARIANT struuct.
1367         
1368         * COMVariantSetter.h:
1369         (COMVariant::COMVariant):
1370         (COMVariant::~COMVariant):
1371         (COMVariant::operator=):
1372         (COMVariant::copyTo):
1373         (COMVariant::variantType):
1374
1375 2009-01-05  Adele Peterson  <adele@apple.com>
1376
1377         Windows build fix.
1378
1379         * WebCoreSupport/WebChromeClient.cpp:
1380
1381 2009-01-05  Anders Carlsson  <andersca@apple.com>
1382
1383         Reviewed by Adam Roben.
1384
1385         Make it possible to have per value variant types.
1386         
1387         * COMPropertyBag.h:
1388         (::Read):
1389         Call variantType here, passing in the value.
1390         
1391         (::GetPropertyInfo):
1392         Ditto.
1393         
1394         * COMVariantSetter.h:
1395         (COMVariantSetterBase::variantType):
1396         Add COMVariantSetterBase, whose variantType implementation just returns the
1397         VariantType variable. Make all existing classes inherit from COMVariantSetterBase.
1398
1399 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
1400
1401         Fix win build
1402
1403         * WebCoreSupport/WebChromeClient.h:
1404
1405 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
1406
1407         Reviewed by George Staikos.
1408
1409         Build fix for contentsSizeChanged
1410
1411         * WebCoreSupport/WebChromeClient.cpp:
1412         (WebChromeClient::contentsSizeChanged):
1413         * WebCoreSupport/WebChromeClient.h:
1414
1415 2009-01-05  Anders Carlsson  <andersca@apple.com> 
1416
1417         Reviewed by Kevin Decker.
1418
1419         Use the ManualLoader class instead of assuming that the manual loader
1420         is a plug-in view.
1421         
1422         * WebCoreSupport/WebFrameLoaderClient.cpp:
1423         (WebFrameLoaderClient::WebFrameLoaderClient):
1424         (WebFrameLoaderClient::setMainDocumentError):
1425         (WebFrameLoaderClient::committedLoad):
1426         (WebFrameLoaderClient::finishedLoading):
1427         (WebFrameLoaderClient::redirectDataToPlugin):
1428         * WebCoreSupport/WebFrameLoaderClient.h:
1429
1430 2009-01-04  Adam Treat  <adam.treat@torchmobile.com>
1431
1432         Reviewed by George Staikos.
1433
1434         Make the apple windows port build with the new fixedLayoutSize feature
1435
1436         * WebCoreSupport/WebFrameLoaderClient.cpp:
1437         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1438
1439 2008-12-20  Dan Bernstein  <mitz@apple.com>
1440
1441         Reviewed by Ada Chan.
1442
1443         - expose the new allItems() method via a new IWebHistoryPrivate
1444           interface
1445
1446         * Interfaces/IWebHistoryPrivate.idl: Added.
1447         * Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
1448         * WebHistory.cpp:
1449         (WebHistory::QueryInterface): Added IWebHistoryPrivate.
1450         (WebHistory::allItems):
1451         * WebHistory.h:
1452
1453 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
1454
1455         Build fix.
1456
1457         * WebHistory.cpp:
1458         (WebHistory::allItems):
1459
1460 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
1461
1462         Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
1463         
1464         Added SPI for getting an unsorted vector of all items in history.
1465         
1466         * WebHistory.cpp:
1467         (WebHistory::orderedItemsLastVisitedOnDay):
1468         (WebHistory::allItems):
1469         * WebHistory.h:
1470
1471 2008-12-18  Dan Bernstein  <mitz@apple.com>
1472
1473         Reviewed by Sam Weinig.
1474
1475         - implement FrameLoaderClient::shouldUseCredentialStorage() by calling
1476           a new resource load delegae method.
1477
1478         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added
1479         a ne interface, IWebResourceLoadDelegatePrivate2, including a new
1480         method, shouldUseCredentialStorage().
1481         * WebCoreSupport/WebFrameLoaderClient.cpp:
1482         (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the
1483         delegate method. If the method is unimplemented, returns true for
1484         backwards compatibility.
1485         * WebCoreSupport/WebFrameLoaderClient.h:
1486
1487 2008-12-18  Sam Weinig  <sam@webkit.org>
1488
1489         Reviewed by John Sullivan.
1490
1491         Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
1492         a new private frame load delegate method.
1493
1494         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
1495         * WebCoreSupport/WebFrameLoaderClient.cpp:
1496         (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
1497         * WebCoreSupport/WebFrameLoaderClient.h:
1498
1499 2008-12-16  Steve Falkenburg  <sfalken@apple.com>
1500
1501         Windows build fix.
1502         
1503         Reviewed by Stephanie Lewis.
1504
1505         * COMPropertyBag.h:
1506         (::createInstance):
1507         (::adopt):
1508         (::QueryInterface):
1509         (::AddRef):
1510         (::Release):
1511         (::Read):
1512         (::Write):
1513         (::CountProperties):
1514         (::GetPropertyInfo):
1515         (::LoadObject):
1516         * WebURLResponse.cpp:
1517         (WebURLResponse::allHeaderFields):
1518
1519 2008-12-16  Stephanie Lewis  <slewis@apple.com>
1520
1521         Another Windows Build Fix.
1522
1523         * WebURLResponse.cpp:
1524         (WebURLResponse::allHeaderFields):
1525
1526 2008-12-14  Dan Bernstein  <mitz@apple.com>
1527
1528         Reviewed by Darin Adler.
1529
1530         - Windows equivalent of <rdar://problem/3258561>
1531           WebHistoryAllItemsRemovedNotification should add items to userInfo
1532
1533         * WebHistory.cpp:
1534         (WebHistory::removeAllItems): Changed to create an array of all items
1535         and send it in the notification.
1536
1537 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
1538
1539         Reviewed by Oliver Hunt.
1540
1541         Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
1542
1543         Provides implementation of image drag for Windows Cairo back-end.
1544         Switch to generic PlatformGraphicsContext data type, rather than
1545         specific use of CoreGraphics types.
1546
1547         * WebCoreSupport/WebDragClient.cpp:
1548         (WebDragClient::createDragImageForLink): Revise calls to use more
1549         generic PlatformGraphicsContext data types and calls for better
1550         portability.
1551
1552 2008-12-12  Steve Falkenburg  <sfalken@apple.com>
1553
1554         Update Windows cache sizes to match recent Mac change.
1555         
1556         Reviewed by Stephanie Lewis, Sam Weinig.
1557
1558         * WebView.cpp:
1559         (WebView::setCacheModel):
1560
1561 2008-12-12  Tor Arne Vestbø  <tavestbo@trolltech.com>
1562
1563         Rubber-stamped by Oliver Hunt.
1564
1565         Remove mutables from EmbeddedWidget
1566
1567         We can do this now that frameRectsChanged() is no longer const
1568
1569         * WebCoreSupport/EmbeddedWidget.h:
1570
1571 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
1572
1573         Rubber-stamped by Mark Rowe.
1574
1575         Roll out r39212 due to assertion failures during layout tests, multiple
1576         layout test failures, memory leaks, and obvious incorrectness.
1577
1578         * Interfaces/IWebPreferencesPrivate.idl:
1579         * WebPreferenceKeysPrivate.h:
1580         * WebPreferences.cpp:
1581         * WebPreferences.h:
1582
1583 2008-12-10  Glenn Wilson  <gwilson@google.com>
1584
1585         Reviewed by Adam Roben.
1586
1587         Added support for overriding default preferences per-test.
1588         https://bugs.webkit.org/show_bug.cgi?id=20534
1589         Two new methods were added: resetToDefaults and overridePreference.
1590
1591         * Interfaces/IWebPreferencesPrivate.idl: new method signatures
1592         * WebPreferenceKeysPrivate.h: added new key for internal state
1593         * WebPreferences.cpp: added new methods
1594         (WebPreferences::overridePreference): new method
1595         (WebPreferences::resetToDefaults): new method
1596         * WebPreferences.h: new method signatures
1597
1598 2008-12-08  Tor Arne Vestbø  <tavestbo@trolltech.com>
1599
1600         Reviewed by Darin Adler and Holger Freyther.
1601
1602         Make Widget::frameRectsChanged() and overrides non-const
1603
1604         This will hopefully allow us to get rid of some of the mutables in
1605         the classes that react to the callback by changing their own state.
1606
1607         * WebCoreSupport/EmbeddedWidget.cpp:
1608         (EmbeddedWidget::frameRectsChanged):
1609         * WebCoreSupport/EmbeddedWidget.h:
1610
1611 2008-12-09  Brett Wilson  <brettw@chromium.org>
1612
1613         Reviewed by Dave Hyatt.
1614
1615         https://bugs.webkit.org/show_bug.cgi?id=22177
1616
1617         Add a callback on ChromeClient that the state of form elements on
1618         the page has changed. This is to allow clients implementing session
1619         saving to know when the current state is dirty.
1620
1621         * WebCoreSupport/WebChromeClient.h:
1622         (WebChromeClient::formStateDidChange):
1623
1624 ks2008-12-08  Dan Bernstein  <mitz@apple.com>
1625
1626         Reviewed by Adam Roben.
1627
1628         - Fix nightly builds
1629
1630         * Interfaces/IWebViewPrivate.idl: Moved globalHistoryItem() to the end,
1631         so that it comes after all methods used by Safari 3.2.1.
1632
1633 2008-12-08  Dan Bernstein  <mitz@apple.com>
1634
1635         Reviewed by John Sullivan.
1636
1637         - WebKit/win part of tracking the global history item for a WebView
1638
1639         * Interfaces/IWebViewPrivate.idl: Declared globalHistoryItem()
1640         * WebView.cpp:
1641         (WebView::globalHistoryItem): Added. Gets the page's global history
1642         item.
1643         * WebView.h:
1644
1645 2008-12-06  Simon Fraser  <simon.fraser@apple.com>
1646
1647         Reviewed by Dave Hyatt
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=15671
1650
1651         Renderer::caretRect() is now localCaretRect(), which needs
1652         converting to absolute coordinates (taking transforms into account).
1653
1654         * WebView.cpp:
1655         (WebView::handleContextMenuEvent):
1656
1657 2008-12-05  Darin Adler  <darin@apple.com>
1658
1659         Reviewed by Alexey Proskuryakov.
1660
1661         - fix https://bugs.webkit.org/show_bug.cgi?id=22674
1662           Webkit r39005 does not start, an entry point not found
1663
1664         * WebView.cpp:
1665         (findCFNetworkModule): Added.
1666         (findCopySharedURLCacheFunction): Added.
1667         (WebView::setCacheModel): Call CFURLCacheCopySharedURLCache via dynamic loading
1668         instead of compiling based on which version of CFNetwork headers are present.
1669
1670 2008-12-04  Steve Falkenburg  <sfalken@apple.com>
1671
1672         Implement IPropertyBag2::Read.
1673         Fill in dwType for IPropertyBag2::GetPropertyInfo (we always use PROPBAG2_TYPE_DATA).
1674         https://bugs.webkit.org/show_bug.cgi?id=22659
1675         
1676         This fixes <rdar://problem/6419127> REGRESSION: Forms autocomplete is broken for "other forms"
1677         
1678         Reviewed by Ada Chan, Alice Liu.
1679
1680         * COMPropertyBag.h:
1681         (::Read): Implemented.
1682         (::GetPropertyInfo): Set dwType to PROPBAG2_TYPE_DATA.
1683
1684 2008-12-02  Adam Roben  <aroben@apple.com>
1685
1686         Export new-ish JSCore convenience constructor functions
1687
1688         Reviewed by Jon Honeycutt.
1689
1690         * WebKit.vcproj/WebKit.def:
1691         * WebKit.vcproj/WebKit_debug.def:
1692         Export JSObjectMakeArray, JSObjectMakeDate, and JSObjectMakeRegExp.
1693         Remove duplicate export of JSObjectMakeFunction.
1694
1695 2008-12-02  Michael Moss  <mmoss@chromium.org>
1696
1697         Reviewed by Eric Seidel.
1698
1699         - Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
1700         https://bugs.webkit.org/show_bug.cgi?id=20926
1701
1702         Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.
1703
1704         * WebCoreSupport/WebFrameLoaderClient.cpp:
1705         (WebFrameLoaderClient::loadURLIntoChild):
1706
1707 2008-12-01  Steve Falkenburg  <sfalken@apple.com>
1708
1709         Implement renderedImage for Windows.
1710         https://bugs.webkit.org/show_bug.cgi?25648
1711         
1712         Reviewed by Adam Roben.
1713
1714         * DOMCoreClasses.cpp:
1715         (DOMElement::renderedImage):
1716         * DOMCoreClasses.h:
1717         * Interfaces/DOMPrivate.idl:
1718
1719 2008-12-01  Eric Seidel  <eric@webkit.org>
1720
1721         Reviewed by Adam Roben.
1722
1723         NULL-check documentFrameView() and topDocumentFrameView() it's possible
1724         for either of these methods to return NULL, and this was seen to cause
1725         crashes in Chromium.
1726         https://bugs.webkit.org/show_bug.cgi?id=22572
1727
1728         * AccessibleBase.cpp:
1729         (AccessibleBase::get_accParent):
1730         (AccessibleBase::accLocation):
1731         (AccessibleBase::accHitTest):
1732
1733 2008-11-30  Antti Koivisto  <antti@apple.com>
1734
1735         Another Windows build fix.
1736
1737         * WebCoreStatistics.cpp:
1738         (WebCoreStatistics::javaScriptObjectsCount):
1739
1740 2008-11-30  Antti Koivisto  <antti@apple.com>
1741
1742         Windows build fix.
1743
1744         * WebJavaScriptCollector.cpp:
1745         (WebJavaScriptCollector::objectCount):
1746
1747 2008-11-29  Brent Fulgham  <bfulgham@gmail.com>
1748
1749         Reviewed by Alexey Proskuryakov.
1750
1751         Remove Visual Studio project dependencies on non-redistributable
1752         components in the Debug_Cairo and Release_Cairo build targets.
1753         See https://bugs.webkit.org/show_bug.cgi?id=22527
1754
1755         * WebKit.vcproj/WebKit.vcproj:
1756         * WebKit.vcproj/WebKit.sln: Instruct Cairo builds to not bother
1757           building the unused QuickTime support library.
1758
1759 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
1760
1761         Reviewed by Alexey Proskuryakov.
1762
1763         http://bugs.webkit.org/show_bug.cgi?id=15643
1764
1765         Added API support for the "trailing whitespace" work-around.  This includes an APIs
1766         to get and set the state of this configuration variable.
1767
1768         * Interfaces/IWebView.idl:
1769         * WebCoreSupport/WebEditorClient.cpp:
1770         (WebEditorClient::selectTrailingWhitespaceEnabled):
1771         * WebCoreSupport/WebEditorClient.h:
1772         * WebView.cpp:
1773         (WebView::WebView):
1774         (WebView::setSelectTrailingWhitespaceEnabled):
1775         (WebView::selectTrailingWhitespaceEnabled):
1776         * WebView.h:
1777
1778 2008-11-24  Darin Adler  <darin@apple.com>
1779
1780         Reviewed by Dan Bernstein.
1781
1782         - https://bugs.webkit.org/show_bug.cgi?id=22470
1783           remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
1784
1785         * WebCoreSupport/WebFrameLoaderClient.cpp:
1786         (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the
1787         DocumentLoader, just as we do the title and the failure flag.
1788         * WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
1789
1790 2008-11-24  Darin Adler  <darin@apple.com>
1791
1792         Reviewed by Dan Bernstein.
1793
1794         - finish https://bugs.webkit.org/show_bug.cgi?id=22295
1795           track which history items are from page load failures
1796
1797         Last time around I did this only for the back/forward list and missed the
1798         global history list.
1799
1800         * Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
1801
1802         * WebCoreSupport/WebFrameLoaderClient.cpp:
1803         (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure
1804         and pass the argument in to WebHistory.
1805
1806         * WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument.
1807         Set the flag on the newly created history item.
1808         * WebHistory.h: Ditto.
1809
1810         * WebHistoryItem.cpp:
1811         (WebHistoryItem::setLastVisitWasFailure): Added.
1812         * WebHistoryItem.h: Ditto.
1813
1814 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
1815
1816         Fix call to Frame::selectionBounds in Windows build.
1817
1818         * WebView.cpp:
1819         (WebView::selectionRect):
1820
1821 2008-11-21  Dimitri Glazkov  <dglazkov@chromium.org>
1822
1823         Reviewed by Alexey Proskuryakov.
1824
1825         Debug WebKit crashes on launch because of threading not being initialized early enough.
1826
1827         * WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory):
1828         Call JSC::InitializeThreading().
1829
1830 2008-11-19  Darin Fisher  <darin@chromium.org>
1831
1832         Reviewed by Geoff Garen.
1833
1834         https://bugs.webkit.org/show_bug.cgi?id=22345
1835         Define ScriptValue as a thin container for a JSC::Value*.
1836
1837         * WebView.cpp:
1838         (WebView::stringByEvaluatingJavaScriptFromString):
1839
1840 2008-11-19  Adele Peterson  <adele@apple.com>
1841
1842         Reviewed by Darin Adler.
1843
1844         For transparent views, clear the dirty rect instead of painting it white.
1845         
1846         * WebView.cpp: (WebView::paintIntoBackingStore):
1847
1848 2008-11-18  Adele Peterson  <adele@apple.com>
1849
1850         Reverting last change.  I just realized it causes the view to never get cleared out.
1851
1852         * WebView.cpp: (WebView::paintIntoBackingStore):
1853
1854 2008-11-18  Adele Peterson  <adele@apple.com>
1855
1856         Reviewed by John Sullivan.
1857
1858         Don't fill the view with white if its transparent.
1859         
1860         * WebView.cpp: (WebView::paintIntoBackingStore):
1861
1862 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1863
1864         Try to fix the Windows build. It is view and not webView.
1865
1866         * WebCoreSupport/WebFrameLoaderClient.cpp:
1867         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1868
1869 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1870
1871         Reviewed by Simon Hausmann.
1872
1873         Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
1874
1875         After Hyatt's work on Widget and ScrollView there is little difference
1876         between the implementation of Qt, Gtk+ and Win. In fact any kind of
1877         difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
1878         port and the Qt port has at least one of them left.
1879
1880         The only difference between the implementations is in getting the the
1881         IntSize for the new FrameView, the background color to be applied and
1882         eventually some post processing.
1883
1884         Unify the implementations by providing a static helper function that
1885         takes a Frame, IntSize, color and transparency bit and calling it from
1886         the Gtk+, the Qt and the Windows port.
1887
1888         * WebCoreSupport/WebFrameLoaderClient.cpp:
1889         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1890
1891 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1892
1893         Reviewed by Simon Hausmann.
1894
1895         https://bugs.webkit.org/show_bug.cgi?id=22056
1896
1897         Move setting the background color and transparency from WebKit/win
1898         to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
1899         to share this code.
1900
1901         * WebFrame.cpp:
1902         (WebFrame::updateBackground):
1903
1904 2008-11-16  Geoffrey Garen  <ggaren@apple.com>
1905
1906         Not reviewed.
1907         
1908         Try to fix Windows build.
1909
1910         * WebCoreSupport/WebFrameLoaderClient.cpp:
1911
1912 2008-11-16  Darin Adler  <darin@apple.com>
1913
1914         Reviewed by Dan Bernstein.
1915
1916         - https://bugs.webkit.org/show_bug.cgi?id=22295
1917           track which history items are from page load failures
1918
1919         * Interfaces/IWebHistoryItemPrivate.idl: Added lastVisitWasFailure function.
1920
1921         * WebHistoryItem.cpp:
1922         (WebHistoryItem::initFromDictionaryRepresentation): Set the lastVisitWasFailure
1923         flag in the history item if the dictionary had an entry for lastVisitWasFailureKey.
1924         (WebHistoryItem::dictionaryRepresentation): Set the lastVisitWasFailureKey key
1925         in the dictionary if the history item had the lastVisitWasFailure flag.
1926         (WebHistoryItem::lastVisitWasFailure): Added.
1927
1928         * WebHistoryItem.h: Added lastVisitWasFailure function.
1929
1930 2008-11-15  Geoffrey Garen  <ggaren@apple.com>
1931
1932         Reviewed by Sam Weinig.
1933         
1934         Updated for JavaScriptCore renames.
1935
1936         * WebScriptCallFrame.cpp:
1937         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
1938
1939 2008-11-14  Dan Bernstein  <mitz@apple.com>
1940
1941         - try to fix the Windows build
1942
1943         * WebCoreLocalizedStrings.cpp:
1944         (WebCore::contextMenuItemTagTextDirectionMenu): Added.
1945
1946 2008-11-13  Adam Roben  <aroben@apple.com>
1947
1948         Fix Bug 22244: Webkit nightly builds crash with Safari 3.2
1949
1950         <https://bugs.webkit.org/show_bug.cgi?id=22244>
1951
1952         r36652 added IWebViewPrivate::clearMainFrameName into the middle of
1953         the IWebViewPrivate interface, which modifies the part of the
1954         IWebViewPrivate vtable that Safari 3.2 relies on.
1955
1956         Reviewed by Dan Bernstein.
1957
1958         * Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end
1959         of the interface.
1960
1961 2008-11-11  Dan Bernstein  <mitz@apple.com>
1962
1963         Reviewed by Adam Roben.
1964
1965         WebKit/win part of adding a master volume control for media elements in a WebView
1966         * Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and
1967         mediaVolume().
1968         * WebView.cpp:
1969         (WebView::setMediaVolume): Added.
1970         (WebView::mediaVolume): Added.
1971         * WebView.h:
1972
1973 2008-11-10  Adam Roben  <aroben@apple.com>
1974
1975         Fix Bug 22158: Would like to turn on WebCore logging channels via an
1976         environment variable
1977
1978         <https://bugs.webkit.org/show_bug.cgi?id=22158>
1979
1980         Reviewed by Anders Carlsson.
1981
1982         * WebView.cpp:
1983         (WebView::initWithFrame): Call WebCore's
1984         InitializeLoggingChannelsIfNecessary.
1985
1986 2008-11-08  Dan Bernstein  <mitz@apple.com>
1987
1988         Reviewed by Darin Adler.
1989
1990         - WebKit/win part of adding WebPreferences for controlling databases and local storage
1991
1992         * Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled,
1993         databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
1994         * WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey
1995         and WebKitLocalStorageEnabledPreferenceKey.
1996         * WebPreferences.cpp:
1997         (WebPreferences::initializeDefaultSettings): Made databases and local
1998         storage enabled by default.
1999         (WebPreferences::setDatabasesEnabled): Added.
2000         (WebPreferences::databasesEnabled): Added.
2001         (WebPreferences::setLocalStorageEnabled): Added.
2002         (WebPreferences::localStorageEnabled): Added.
2003         * WebPreferences.h:
2004         * WebView.cpp:
2005         (WebView::notifyPreferencesChanged): Transfer the databases and local
2006         storage preferences to WebCore settings.
2007
2008 2008-11-06  John Sullivan  <sullivan@apple.com>
2009     
2010         Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.
2011     
2012         Reviewed by Adam Roben
2013
2014         * WebView.h:
2015         removed m_zoomMultiplierIsTextOnly
2016         
2017         * WebView.cpp:
2018         (WebView::WebView):
2019         removed initialization of m_zoomMultiplierIsTextOnly
2020         (WebView::setZoomMultiplier):
2021         use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly
2022         (WebView::zoomMultiplier):
2023         use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
2024
2025 2008-11-06  Adele Peterson  <adele@apple.com>
2026
2027         Reviewed by Adam Roben.
2028
2029         Add support for a WebKitZoomsTextOnly preference.
2030
2031         * Interfaces/IWebPreferences.idl:
2032         * WebPreferenceKeysPrivate.h:
2033         * WebPreferences.cpp:
2034         (WebPreferences::setZoomsTextOnly):
2035         (WebPreferences::zoomsTextOnly):
2036         * WebPreferences.h:
2037
2038         * WebView.cpp:
2039         (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this.
2040         (WebView::makeTextLarger): ditto.
2041         (WebView::canMakeTextSmaller): ditto.
2042         (WebView::makeTextSmaller): ditto.
2043         (WebView::canMakeTextStandardSize): 
2044         Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting.
2045         (WebView::makeTextStandardSize):
2046         (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
2047
2048 2008-11-05  Dan Bernstein  <mitz@apple.com>
2049
2050         Reviewed by John Sullivan.
2051
2052         - make the {protocol,proxyType} argument of
2053           WebURLProtectionSpace::initWith{Proxy}Host actually work and fix
2054           assertion failures.
2055
2056         * WebURLProtectionSpace.cpp:
2057         (WebURLProtectionSpace::initWithHost): The BString comparisons were
2058         applying the BString==BSTR operator to a right hand side that was
2059         actually a WCHAR string. Fixed by using BStrings on both sides.
2060         (WebURLProtectionSpace::initWithProxyHost): Ditto.
2061
2062 2008-11-01  Alexey Proskuryakov  <ap@webkit.org>
2063
2064         Reviewed by Darin Adler.
2065
2066         https://bugs.webkit.org/show_bug.cgi?id=22030
2067         Make EventNames usable from multiple threads
2068
2069         * WebView.cpp: (WebView::interpretKeyEvent): Access event names via eventNames() function.
2070
2071 2008-11-03  Cameron Zwarich  <zwarich@apple.com>
2072
2073         Rubber-stamped by Maciej Stachowiak.
2074
2075         Move more files into the runtime subdirectory of JavaScriptCore.
2076
2077         * WebJavaScriptCollector.cpp:
2078
2079 2008-11-03  Dan Bernstein  <mitz@apple.com>
2080
2081         Reviewed by Steve Falkenburg.
2082
2083         - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
2084         - add and implement WebMutableURLRequest::mutableCopy()
2085
2086         * Interfaces/IWebURLRequest.idl:
2087         * WebMutableURLRequest.cpp:
2088         (WebMutableURLRequest::setHTTPShouldHandleCookies):
2089         (WebMutableURLRequest::mutableCopy):
2090         * WebMutableURLRequest.h:
2091
2092 2008-10-31  Dan Bernstein  <mitz@apple.com>
2093
2094         Reviewed by John Sullivan.
2095
2096         - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
2097
2098         * Interfaces/IWebViewPrivate.idl:
2099         * WebView.cpp:
2100         (WebView::setCookieEnabled):
2101         (WebView::cookieEnabled):
2102         * WebView.h:
2103
2104 2008-10-31  Adele Peterson  <adele@apple.com>
2105
2106         Reviewed by Darin Adler.
2107
2108         WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
2109         https://bugs.webkit.org/show_bug.cgi?id=22008
2110         
2111         * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): 
2112         Add support for mulitple file selection.
2113
2114 2008-10-31  Darin Adler  <darin@apple.com>
2115
2116         - try to fix build
2117
2118         * WebView.cpp:
2119         (WebView::setCacheModel): Roll out the part of my last change
2120         that involved no longer using wkCopyFoundationCacheDirectory.
2121
2122 2008-10-30  Darin Adler  <darin@apple.com>
2123
2124         Reviewed by Sam Weinig.
2125
2126         - https://bugs.webkit.org/show_bug.cgi?id=21986
2127           <rdar://problem/6294285> adopt CFURLCopySharedURLCache
2128
2129         * WebView.cpp:
2130         (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.
2131
2132 2008-10-30  Dan Bernstein  <mitz@apple.com>
2133
2134         Reviewed by Sam Weinig.
2135
2136         - export WTFReportAssertionFailureWithMessage()
2137
2138         * WebKit.vcproj/WebKit_debug.def:
2139
2140 2008-10-29  Steve Falkenburg  <sfalken@apple.com>
2141
2142         <rdar://problem/6326563> Crash on launch
2143         
2144         For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
2145         
2146         Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
2147         callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
2148         the explicit lock/unlock functions, we can avoid this.
2149         
2150         Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
2151         
2152         Reviewed by Darin Adler.
2153
2154         * WebKit.vcproj/WebKit.def:
2155         * WebKit.vcproj/WebKit_debug.def:
2156
2157 2008-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2158
2159         Export atomicallyInitializedStaticMutex.
2160
2161         Rubber-stamped by Steve Falkenburg.
2162
2163         * WebKit.vcproj/WebKit.def:
2164         * WebKit.vcproj/WebKit_debug.def:
2165
2166 2008-10-28  Cameron Zwarich  <zwarich@apple.com>
2167
2168         Reviewed by Mark Rowe.
2169
2170         Move ForwardingHeaders to their correct location after the creation of
2171         the runtime directory in JavaScriptCore.
2172
2173         * WebScriptCallFrame.h:
2174
2175 2008-10-28  Adele Peterson  <adele@apple.com>
2176
2177         Reviewed by John Sullivan.
2178
2179         Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
2180         "files" string for multifile uploads needs to be localized
2181
2182         * WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
2183
2184 2008-10-28  Adele Peterson  <adele@apple.com>
2185
2186         Reviewed by Sam Weinig. 
2187
2188         * English.lproj: Removed.
2189         * English.lproj/Localizable.strings: Removed.
2190         * WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.
2191
2192 2008-10-28  Timothy Hatcher  <timothy@apple.com>
2193
2194         Add IWebInspector methods to enable the profiler.
2195
2196         https://bugs.webkit.org/show_bug.cgi?id=21927
2197
2198         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
2199         not slow down JavaScript all the time
2200
2201         Reviewed by Darin Adler and Kevin McCullough.
2202
2203         * WebInspector.cpp:
2204         (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
2205         (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
2206         or enableProfiler methods.
2207         * WebInspector.h:
2208
2209 2008-10-27  Timothy Hatcher  <timothy@apple.com>
2210
2211         Rename a few methods related to attaching and detaching the debugger.
2212
2213         * Rename attachDebugger to enableDebugger.
2214         * Rename detachDebugger to disableDebugger.
2215         * Rename the debuggerAttached getter to debuggerEnabled.
2216
2217         Reviewed by Darin Adler.
2218
2219         * WebInspector.cpp:
2220         (WebInspector::isDebuggingJavaScript):
2221         (WebInspector::toggleDebuggingJavaScript):
2222
2223 2008-10-24  Sam Weinig  <sam@webkit.org>
2224
2225         Yet another windows build fix.
2226
2227         * WebCoreSupport/WebChromeClient.cpp:
2228
2229 2008-10-24  Sam Weinig  <sam@webkit.org>
2230
2231         Another windows build fix.
2232
2233         * WebCoreSupport/WebChromeClient.cpp:
2234
2235 2008-10-24  Sam Weinig  <sam@webkit.org>
2236
2237         Reviewed by Dan Bernstein.
2238
2239         Fix https://bugs.webkit.org/show_bug.cgi?id=21759
2240         Layering violation: FileChooser should not depend on Document/Frame/Page
2241
2242         * WebCoreSupport/WebChromeClient.cpp:
2243         (WebChromeClient::runOpenPanel):
2244         * WebCoreSupport/WebChromeClient.h:
2245
2246 2008-10-24  Timothy Hatcher  <timothy@apple.com>
2247
2248         Implement new InspectorClient methods to work with Settings.
2249
2250         https://bugs.webkit.org/show_bug.cgi?id=21856
2251
2252         Reviewed by Adam Roben.
2253
2254         * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
2255         * WebCoreSupport/WebInspectorClient.h: Add the new methods.
2256
2257 2008-10-24  Darin Adler  <darin@apple.com>
2258
2259         - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
2260
2261         * WebScriptCallFrame.cpp:
2262         (WebScriptCallFrame::jsValueToString):
2263         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
2264         (WebScriptCallFrame::valueForVariable):
2265         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
2266         * WebScriptCallFrame.h:
2267         * WebView.cpp:
2268         (WebView::stringByEvaluatingJavaScriptFromString):
2269         Use JSValue* instead of JSValuePtr.
2270
2271 2008-10-22  Brent Fulgham  <bfulgham@gmail.com>
2272
2273         Correct build regressions in Cairo port for Windows.
2274         http://bugs.webkit.org/show_bug.cgi?id=21724
2275
2276         Reviewed by Adam Roben.
2277
2278         * WebView.cpp:
2279         (WebView::notifyPreferencesChanged): Don't try to call
2280         setShouldPaintNativeControls when SafariTheme support is disabled, as
2281         that function doesn't exist in that case.
2282
2283 2008-10-22  Brady Eidson  <beidson@apple.com>
2284
2285         Reviewed by Adam Roben
2286         
2287         Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use
2288
2289         * Interfaces/IWebFramePrivate.idl:
2290         
2291         * WebFrame.cpp:
2292         (WebFrame::elementDoesAutoComplete):
2293         * WebFrame.h:
2294         
2295         * WebHTMLRepresentation.cpp:
2296         (WebHTMLRepresentation::elementDoesAutoComplete):
2297
2298 2008-10-20  Sam Weinig  <sam@webkit.org>
2299
2300         Reviewed by Anders Carlsson.
2301
2302         Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
2303
2304         * WebFrame.cpp:
2305         * WebFrame.h:
2306
2307 2008-10-19  Darin Adler  <darin@apple.com>
2308
2309         Reviewed by Oliver Hunt.
2310
2311         - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
2312           improve performance by eliminating JSValue as a base class for JSCell
2313
2314         Remove most uses of JSValue, which will be removed in a future patch.
2315
2316         * WebScriptCallFrame.cpp:
2317         (WebScriptCallFrame::jsValueToString): Use JSValuePtr.
2318         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Ditto.
2319         (WebScriptCallFrame::valueForVariable): Put more code inside and ifdef.
2320         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Ditto.
2321         * WebScriptCallFrame.h: Use JSValuePtr.
2322
2323         * WebView.cpp:
2324         (WebView::stringByEvaluatingJavaScriptFromString): Use JSValuePtr.
2325
2326 2008-10-18  Dan Bernstein  <mitz@apple.com>
2327
2328         - build fix
2329
2330         * WebScriptCallFrame.cpp:
2331         (WebScriptCallFrame::jsValueToString):
2332
2333 2008-10-18  Dan Bernstein  <mitz@apple.com>
2334
2335         Reviewed by Sam Weinig.
2336
2337         - WebKit/win part of https://bugs.webkit.org/show_bug.cgi?id=21736
2338           Long-dead decoded image data make up for most of the object cache's memory use over time
2339
2340         * WebView.cpp:
2341         (WebView::setCacheModel): In the primary web browser model,
2342         set the cache's dead decoded data deletion interval to 60 seconds.
2343
2344 2008-10-16  Kevin McCullough  <kmccullough@apple.com>
2345
2346         Reviewed by Steve Falkenburg.
2347
2348         <rdar://problem/6292718>
2349         Implement a standard way to get the UA given an application name.
2350
2351         * Interfaces/IWebViewPrivate.idl:
2352         * WebView.cpp:
2353         (WebView::standardUserAgentWithApplicationName):
2354         * WebView.h:
2355
2356 2008-10-17  Dan Bernstein  <mitz@apple.com>
2357
2358         Reviewed by Sam Weinig.
2359
2360         - export WTF::initializeOnMainThread()
2361
2362         * WebKit.vcproj/WebKit.def:
2363         * WebKit.vcproj/WebKit_debug.def:
2364
2365 2008-10-15  Geoffrey Garen  <ggaren@apple.com>
2366
2367         Reviewed by Cameron Zwarich.
2368
2369         Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
2370         Start the debugger without reloading the inspected page
2371
2372         * WebInspector.cpp:
2373         (WebInspector::toggleDebuggingJavaScript): Updated for rename.
2374
2375 2008-10-15  Adam Roben  <aroben@apple.com>
2376
2377         Export WTF::Mutex::tryLock
2378
2379         * WebKit.vcproj/WebKit.def:
2380         * WebKit.vcproj/WebKit_debug.def:
2381
2382 2008-10-14  Jon Honeycutt  <jhoneycutt@apple.com>
2383
2384         Export currentThread.
2385
2386         Rubber-stamped by Dan Bernstein.
2387
2388         * WebKit.vcproj/WebKit.def:
2389         * WebKit.vcproj/WebKit_debug.def:
2390
2391 2008-10-13  Steve Falkenburg  <sfalken@apple.com>
2392
2393         Reorder methods to preserve compatibility.
2394         
2395         Rubber stamped by Oliver Hunt.
2396
2397         * Interfaces/IWebViewPrivate.idl:
2398
2399 2008-10-11  Dan Bernstein  <mitz@apple.com>
2400
2401         Reviewed by Sam Weinig.
2402
2403         - add SPI for forcing the complex text code path to be used for all text
2404
2405         * Interfaces/IWebViewPrivate.idl:
2406         * WebView.cpp:
2407         (WebView::setAlwaysUsesComplexTextCodePath):
2408         (WebView::alwaysUsesComplexTextCodePath):
2409         * WebView.h:
2410
2411 2008-10-10  Ada Chan  <adachan@apple.com>
2412
2413         Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can 
2414         potentially hold onto stale instances of WebPreferences
2415         https://bugs.webkit.org/show_bug.cgi?id=21526
2416         
2417         webPreferencesInstances now keeps a reference to all the instances it holds.
2418         Fix up callers of WebPreferences::removeReferenceForIdentifier() to call 
2419         it after they have released their references to the WebPreferences objects.
2420
2421         Reviewed by Adam Roben.
2422
2423         * WebPreferences.cpp:
2424         (WebPreferences::getInstanceForIdentifier):
2425         (WebPreferences::removeReferenceForIdentifier):
2426         * WebView.cpp:
2427         (WebView::close):
2428         (WebView::setPreferences):
2429
2430 2008-10-06  David Hyatt  <hyatt@apple.com>
2431
2432         Enable viewless Mac WebKit to paint some basic pages.
2433         
2434         Reviewed by Sam Weinig
2435
2436         * WebCoreSupport/WebFrameLoaderClient.cpp:
2437         (WebFrameLoaderClient::createFrame):
2438         * WebCoreSupport/WebFrameLoaderClient.h:
2439
2440 2008-10-03  David Hyatt  <hyatt@apple.com>
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=21340
2443         
2444         Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.
2445         
2446         Reviewed by Dan Bernstein & Darin Adler
2447
2448         * WebCoreSupport/WebFrameLoaderClient.cpp:
2449         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2450         * WebScrollBar.cpp:
2451         (WebScrollBar::WebScrollBar):
2452         (WebScrollBar::init):
2453         (WebScrollBar::invalidateScrollbarRect):
2454         * WebScrollBar.h:
2455
2456 2008-10-03  David Hyatt  <hyatt@apple.com>
2457
2458          Remove addToDirtyRegion.
2459         
2460          Reviewed by Oliver Hunt
2461
2462         * WebCoreSupport/WebChromeClient.cpp:
2463
2464 2008-10-02  David Hyatt  <hyatt@apple.com>
2465
2466         https://bugs.webkit.org/show_bug.cgi?id=21328
2467         
2468         Make widget invalidation more cross-platform.
2469         
2470         (1) Make invalidateRect a pure virtual function on Widget.  All leaf widgets must now implement this function.
2471         
2472         (2) Scrollbars now send invalidations through the ScrollbarClient.  windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
2473         This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
2474         
2475         (3) Plugins now have the native window invalidation code for windowed plugins.  Windowless plugins do a repaintRectangle on the plugin's renderer.
2476         
2477         (4) FrameViews now do a repaintRectangle on their owner element's renderer.
2478
2479         Reviewed by Sam Weinig
2480
2481         * WebCoreSupport/EmbeddedWidget.cpp:
2482         (EmbeddedWidget::invalidateRect):
2483         * WebCoreSupport/EmbeddedWidget.h:
2484         * WebScrollBar.cpp:
2485         (WebScrollBar::invalidateScrollbarRect):
2486         * WebScrollBar.h:
2487
2488 2008-10-02  Darin Adler  <darin@apple.com>
2489
2490         - https://bugs.webkit.org/show_bug.cgi?id=21321
2491           Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
2492
2493         * WebCoreStatistics.cpp:
2494         (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to
2495         work with the heap.
2496         (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto.
2497         (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto.
2498         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto.
2499         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
2500         * WebJavaScriptCollector.cpp:
2501         (WebJavaScriptCollector::objectCount): Ditto.
2502
2503 2008-10-02  Dave Hyatt  <hyatt@apple.com>
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=21316
2506
2507         Reviewed by Adele
2508        
2509         * WebCoreSupport/WebFrameLoaderClient.cpp:
2510         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2511
2512 2008-10-02  David Hyatt  <hyatt@apple.com>
2513
2514         https://bugs.webkit.org/show_bug.cgi?id=21314
2515         
2516         Make scrollBackingStore cross-platform.
2517
2518         Reviewed by Sam Weinig
2519
2520         * WebCoreSupport/WebChromeClient.cpp:
2521         (WebChromeClient::repaint):
2522         (WebChromeClient::scroll):
2523         * WebCoreSupport/WebChromeClient.h:
2524         * WebView.cpp:
2525         (WebView::repaint):
2526         * WebView.h:
2527
2528 2008-10-01  David Hyatt  <hyatt@apple.com>
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=21298
2531         
2532         Make updateScrollbars cross-platform.  For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store.  Next patch
2533         will make that cross-platform.  
2534         
2535         The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
2536         multiple inheritance.  For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
2537         windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
2538
2539         Reviewed by Sam Weinig
2540
2541         * WebScrollBar.cpp:
2542         (WebScrollBar::windowClipRect):
2543         * WebScrollBar.h:
2544
2545 2008-10-01  David Hyatt  <hyatt@apple.com>
2546         
2547         https://bugs.webkit.org/show_bug.cgi?id=21282
2548         
2549         Make contentsToScreen/screenToContents cross-platform.  Only implemented by Mac/Win right now.
2550         
2551         Reviewed by Adam Roben
2552
2553         * WebCoreSupport/WebChromeClient.cpp:
2554         (WebChromeClient::windowToScreen):
2555         (WebChromeClient::screenToWindow):
2556         * WebCoreSupport/WebChromeClient.h:
2557
2558 2008-09-30   Dave Hyatt  <hyatt@apple.com>
2559
2560         https://bugs.webkit.org/show_bug.cgi?id=21269
2561   
2562         This patch makes the ScrollView::paint method cross-platform.  The paint method calls the base class
2563         Widget paint on platforms with native widgets (Mac and wx).  Otherwise it calls a virtual function,
2564         paintContents, to paint the ScrollView's contents, and then it paints each of the two scrollbars and
2565         the scrollbar corner.
2566         
2567         The scrollbar themes are now responsible for painting scrollbar corners.  At the moment ScrollbarThemeWin still
2568         paints white (which is incorrect), so a future patch will actually implement proper native scroll corner painting
2569         for Windows.
2570         
2571         paintContents is implemented by FrameView, and replaces Frame::paint.  All of the FramePrivate member
2572         variables used by Frame::paint have moved to FrameViewPrivate instead.  All callers of Frame::paint have
2573         been patched to use FrameView::paintContents instead.
2574         
2575         Reviewed by Darin Adler
2576
2577         * WebFrame.cpp:
2578         (WebFrame::paintDocumentRectToContext):
2579         (WebFrame::spoolPages):
2580
2581 2008-09-30  Dave Hyatt  <hyatt@apple.com>
2582
2583         http://bugs.webkit.org/show_bug.cgi?id=21250
2584         
2585         Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
2586         repaints up through the ChromeClient.
2587
2588         Reviewed by Darin Adler
2589
2590         * WebCoreSupport/WebChromeClient.cpp:
2591         (WebChromeClient::repaint):
2592         * WebCoreSupport/WebChromeClient.h:
2593         * WebView.cpp:
2594         (WebView::repaint):
2595         * WebView.h:
2596
2597 2008-09-29  Dan Bernstein  <mitz@apple.com>
2598
2599         Reviewed by Adam Roben.
2600
2601         - WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
2602
2603         * WebKitDLL.cpp:
2604         (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit
2605         is being unloaded.
2606
2607 2008-09-27  David Hyatt  <hyatt@apple.com>
2608
2609         Land the frameGeometry->frameRect changes that I forgot to land in WebKit.
2610
2611         * Interfaces/IWebScrollBarPrivate.idl:
2612         * WebCoreSupport/EmbeddedWidget.cpp:
2613         (EmbeddedWidget::setFrameRect):
2614         (EmbeddedWidget::frameRectsChanged):
2615         * WebCoreSupport/EmbeddedWidget.h:
2616         * WebScrollBar.cpp:
2617         (WebScrollBar::setRect):
2618         (WebScrollBar::frameRect):
2619         * WebScrollBar.h:
2620
2621 2008-09-27  Anders Carlsson  <andersca@apple.com>
2622
2623         Fix build.
2624
2625         * WebCoreSupport/EmbeddedWidget.cpp:
2626         (EmbeddedWidget::setFrameRect):
2627         (EmbeddedWidget::frameRectsChanged):
2628         * WebCoreSupport/EmbeddedWidget.h:
2629         * WebScrollBar.cpp:
2630         (WebScrollBar::setRect):
2631         (WebScrollBar::frameGeometry):
2632
2633 2008-09-26  David Kilzer  <ddkilzer@apple.com>
2634
2635         Speculative Windows build fix with XSLT disabled
2636
2637         Reviewed by Alexey.
2638
2639         * WebCache.cpp:
2640         (WebCache::statistics): Populate xslStyleSheet statistics with
2641         zeros if XSLT is disabled.
2642
2643 2008-09-24  Matt Lilek  <webkit@mattlilek.com>
2644
2645         Reviewed by Darin Adler.
2646
2647         Bug 20999: Inspector hover to select does not work properly on Windows
2648         https://bugs.webkit.org/show_bug.cgi?id=20999
2649         <rdar://problem/6236524>
2650
2651         * WebNodeHighlight.cpp:
2652         (WebNodeHighlight::show):
2653
2654 2008-09-24  Darin Adler  <darin@apple.com>
2655
2656         * English.lproj/Localizable.strings: Updated for recent changes.
2657
2658 2008-09-22  Alice Liu  <alice.liu@apple.com>
2659
2660         Added record-memory-win.vcproj tool to the solution
2661
2662         Reviewed by Steve Falkenburg.
2663
2664         * WebKit.vcproj/WebKit.sln:
2665
2666 2008-09-20  Darin Adler  <darin@apple.com>
2667
2668         - fix build
2669
2670         * WebCoreSupport/WebChromeClient.cpp:
2671         (WebChromeClient::paintCustomScrollbar): Tweaked constant names to make this
2672         compile, but it may not be working correctly. Hyatt should do the real fix.
2673
2674 2008-09-19  Alice Liu  <alice.liu@apple.com>
2675
2676         Fix crash when submitting form at bugreport.apple.com rdar://6234126
2677
2678         Reviewed by Mark Rowe.
2679
2680         * COMPropertyBag.h:
2681         (::GetPropertyInfo):
2682         correct mis-use of comma operator
2683
2684 2008-09-18  Mark Rowe  <mrowe@apple.com>
2685
2686         Reviewed by Dan Bernstein.
2687
2688         Add SPI to WebView to allow DRT to clear the main frame's name between tests.
2689
2690         * Interfaces/IWebViewPrivate.idl:
2691         * WebView.cpp:
2692         (WebView::clearMainFrameName):
2693         * WebView.h:
2694
2695 2008-09-16  Alp Toker  <alp@nuanti.com>
2696
2697         Suggested by Dave Hyatt.
2698
2699         Build fix and cleanup. Rename ScrollBar to Scrollbar.
2700
2701         * WebScrollBar.cpp:
2702         * WebScrollBar.h:
2703
2704 2008-09-16  David Hyatt  <hyatt@apple.com>
2705
2706         Eliminate PlatformScrollbar.
2707
2708         Reviewed by Sam Weinig
2709
2710         * WebScrollBar.cpp:
2711         (WebScrollBar::init):
2712         * WebScrollBar.h:
2713
2714 2008-09-15  Chris Fleizach  <cfleizach@apple.com>
2715
2716         Reviewed by Darin Adler, Beth Dakin
2717
2718         Support strings for AXLists
2719
2720         * WebCoreLocalizedStrings.cpp:
2721         (WebCore::AXDefinitionListTermText):
2722         (WebCore::AXDefinitionListDefinitionText):
2723
2724 2008-09-13  Dave Hyatt  <hyatt@apple.com>
2725
2726         Add ScrollbarTheme to the build.
2727         
2728         Reviewed by Sam Weinig
2729
2730         * WebScrollBar.cpp:
2731         (WebScrollBar::requestedWidth):
2732         (WebScrollBar::requestedHeight):
2733
2734 2008-09-13  Dave Hyatt  <hyatt@apple.com>
2735
2736         More scrollbar refactoring.
2737         
2738         Reviewed by Sam Weinig
2739
2740         * WebScrollBar.h:
2741
2742 2008-09-08  Adam Roben  <aroben@apple.com>
2743
2744         Respect the font smoothing preference when drawing via WebKitGraphics
2745
2746         Reviewed by Dave Hyatt.
2747
2748         * WebKitGraphics.cpp:
2749         (makeFont): Check the font smoothing preference and update the
2750         FontDescription's rendering mode based on it.
2751
2752 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
2753
2754         Another Windows nightly build fix.
2755         
2756         Remove non-production versions of CLSIDs since we'll use registry free COM with
2757         an embedded manifest now in all cases to find COM classes.
2758         
2759         Reviewed by Sam Weinig.
2760
2761         * ForEachCoClass.cpp:
2762         (setUseOpenSourceWebKit): Remove COM registration code.
2763         * Interfaces/WebKit.idl: Remove non-production COM classes
2764
2765 2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2766
2767         Reviewed by Maciej Stachowiak.
2768
2769         Bug 20704: Replace the KJS namespace
2770         <https://bugs.webkit.org/show_bug.cgi?id=20704>
2771
2772         Rename the KJS namespace to JSC.
2773
2774         * WebCoreStatistics.cpp:
2775         * WebJavaScriptCollector.cpp:
2776         * WebScriptCallFrame.cpp:
2777         (WebScriptCallFrame::jsValueToString):
2778         * WebScriptCallFrame.h:
2779         (WebScriptCallFrame::state):
2780         * WebView.cpp:
2781         (WebView::WebView):
2782         (WebView::stringByEvaluatingJavaScriptFromString):
2783
2784 2008-09-05  Dave Hyatt  <hyatt@apple.com>
2785
2786         Add support for runtime switchability of the Aqua look and the native look on Windows.
2787         Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
2788
2789         Reviewed by Adam Roben
2790
2791         * Interfaces/IWebPreferencesPrivate.idl:
2792         * WebPreferenceKeysPrivate.h:
2793         * WebPreferences.cpp:
2794         (WebPreferences::initializeDefaultSettings):
2795         (WebPreferences::shouldPaintNativeControls):
2796         (WebPreferences::setShouldPaintNativeControls):
2797         * WebPreferences.h:
2798         * WebView.cpp:
2799         (WebView::notifyPreferencesChanged):
2800
2801 2008-09-04  Adam Roben  <aroben@apple.com>
2802
2803         Make JavaScriptCoreGenerated build first instead of WTF
2804
2805         JavaScriptCoreGenerated does some setup work that we want to happen
2806         before WTF builds.
2807
2808         * WebKit.vcproj/WebKit.sln: Reversed the dependencies of WTF and
2809         JavaScriptCoreGenerated.
2810
2811 2008-08-30  Sam Weinig  <sam@webkit.org>
2812
2813         Reviewed by Dan Bernstein.
2814
2815         Add WebView SPI to defer loading callbacks.
2816
2817         * Interfaces/IWebViewPrivate.idl:
2818         * WebView.cpp:
2819         (WebView::setDefersCallbacks):
2820         (WebView::defersCallbacks):
2821         * WebView.h:
2822
2823 2008-08-28  Adele Peterson  <adele@apple.com>
2824
2825         Build fix.
2826
2827         * WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
2828
2829 2008-08-28  Holger Hans Peter Freyther  <zecke@selfish.org>
2830
2831         Rubber-stamped by Darin Adler.
2832
2833         https://bugs.webkit.org/show_bug.cgi?id=17261
2834
2835         Remove the urlIcon.png from the project and the resource file. Remove
2836         the usage of this icon from WebKitDLL.cpp and change WebIconDatabase
2837         to get the icon from the IconDatabase code which is using a version of
2838         the icon that is compiled into the code.
2839
2840         * WebIconDatabase.cpp:
2841         (WebIconDatabase::getOrCreateDefaultIconBitmap): Use the icon from the
2842         IconDatabase.cpp
2843         * WebKit.vcproj/WebKit.rc: Remove urlIcon.cpp
2844         * WebKit.vcproj/urlIcon.png: Removed.
2845         * WebKitDLL.cpp:
2846         (loadResourceIntoBuffer): Remove "urlIcon"
2847
2848 2008-08-27  Alice Liu  <alice.liu@apple.com>
2849
2850         Add interface for obtaining JS object counts broken down by type
2851
2852         Reviewed by Steve Falkenburg.
2853
2854         * Interfaces/IWebCoreStatistics.idl:
2855         * WebCoreStatistics.cpp:
2856         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2857         * WebCoreStatistics.h:
2858
2859 2008-08-27  Ada Chan  <adachan@apple.com>
2860
2861         Fixed build.
2862
2863         * WebFrame.cpp:
2864         (WebFrame::pluginWillHandleLoadError):
2865
2866 2008-08-27  Brady Eidson  <beidson@apple.com>
2867
2868         Reviewed by Anders
2869
2870         <rdar://problem/6134133> - Crash when loading large movie as a standalone document
2871
2872         * WebFrame.cpp:
2873         (WebFrame::pluginWillHandleLoadError):
2874         * WebFrame.h:
2875
2876 2008-08-26  Alice Liu  <alice.liu@apple.com>
2877
2878         Implement COMPropertyBag::GetPropertyInfo
2879         and a variant setter for type int
2880
2881         Reviewed by Anders Carlsson.
2882
2883         * COMPropertyBag.h:
2884         (::GetPropertyInfo):
2885         * COMVariantSetter.h:
2886
2887 2008-08-25  Adam Roben  <aroben@apple.com>
2888
2889         Fix an assertion when showing the Web Inspector
2890
2891         Reviewed by Kevin McCullough.
2892
2893         * WebCoreSupport/WebInspectorClient.cpp:
2894         (WebInspectorClient::attachWindow):
2895         (WebInspectorClient::detachWindow):
2896         Recent code changes have caused these functions to get called even
2897         when the window is already attached/detached, respectively. Handle
2898         this case gracefully instead of asserting something that is no longer
2899         true.
2900
2901 2008-08-24  Beth Dakin  <bdakin@apple.com>
2902
2903         Reviewed by John Sullivan.
2904
2905         Provide the excludeFromTextSearch SPI on Windows as well.
2906
2907         * Interfaces/IWebFrame.idl:
2908         * WebFrame.cpp:
2909         (WebFrame::setExcludeFromTextSearch):
2910         * WebFrame.h:
2911
2912 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
2913
2914         Cannot get the focused accessible object from the root object.
2915
2916         AccessibleBase::get_AccFocus() checks whether the focused object is a
2917         child of the current object, but 
2918         http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
2919         the result is the object itself, if it has focus, or a child object of
2920         the active window, not a child of the object.
2921
2922         Reviewed by Sam Weinig.
2923
2924         * AccessibleBase.cpp:
2925         (AccessibleBase::get_accFocus): Don't check whether the focused object
2926         is our child.
2927
2928 2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>
2929
2930         Add SPI to make a Windows WebView transparent.
2931
2932         Reviewed by Dan Bernstein.
2933
2934         * Interfaces/IWebViewPrivate.idl:
2935         * WebCoreSupport/WebFrameLoaderClient.cpp:
2936         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2937         updateBackground() when a new frame is attached, matching the Mac.
2938         * WebFrame.cpp:
2939         (WebFrame::updateBackground): Propagate WebView transparency to ourself
2940         and our child frames.
2941         * WebFrame.h:
2942         * WebView.cpp:
2943         (WebView::WebView):
2944         (WebView::paintIntoBackingStore): Pass m_transparent when creating a
2945         GraphicsContext, so the context will be created with an alpha channel.
2946         (WebView::setTransparent):
2947         (WebView::transparent):
2948         * WebView.h:
2949
2950 2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2951
2952         Add SPI to get a handle to the WebView's backing store bitmap.
2953
2954         Reviewed by Dan Bernstein.
2955
2956         * Interfaces/IWebViewPrivate.idl:
2957         * WebView.cpp:
2958         (WebView::backingStore):
2959         * WebView.h:
2960
2961 2008-08-21 Jonas Klink <klinktech@gmail.com>
2962
2963         Reviewed by Jon Honeycutt.
2964
2965         Fix https://bugs.webkit.org/show_bug.cgi?id=20231
2966         Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE
2967
2968         Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
2969         from accNavigate if no screen element is found in the specified direction.
2970
2971         * AccessibleBase.cpp:
2972         (AccessibleBase::accNavigate):
2973
2974 2008-08-21 Jonas Klink <klinktech@gmail.com>
2975
2976         Reviewed by Jon Honeycutt.
2977
2978         Fix http://bugs.webkit.org/show_bug.cgi?id=20230
2979         Bug 20230: get_accState should be testing state on childObj
2980
2981         Also initializes output parameter action to 0 in get_accDefaultAction.
2982
2983         * AccessibleBase.cpp:
2984         (AccessibleBase::get_accState):
2985         (AccessibleBase::get_accDefaultAction):
2986
2987 2008-08-20  Maxime Britto  <britto@apple.com>
2988
2989         Reviewed by Ada Chan.
2990
2991         rdar://5259746
2992         Mouse events are sent to page while resizing window (affects Gmail)
2993         In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
2994
2995         * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
2996         * WebView.cpp:
2997         (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
2998
2999 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3000
3001         Reviewed by Geoff Garen.
3002
3003         Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
3004
3005         * WebCoreStatistics.cpp:
3006         (WebCoreStatistics::javaScriptObjectsCount):
3007         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3008         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3009         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3010         * WebJavaScriptCollector.cpp:
3011         (WebJavaScriptCollector::objectCount):
3012         * WebScriptCallFrame.cpp:
3013         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3014         * WebView.cpp:
3015         (WebView::stringByEvaluatingJavaScriptFromString):
3016
3017 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
3018
3019         Fix build.
3020
3021         * WebScriptCallFrame.cpp:
3022         (WebScriptCallFrame::jsValueToString):
3023
3024 2008-08-14  Steve Falkenburg  <sfalken@apple.com>
3025
3026         Update cache capacities to match values used on Mac.
3027         
3028         Reviewed by Dan Bernstein.
3029
3030         * WebView.cpp:
3031         (WebView::setCacheModel):
3032
3033 2008-08-14  Sam Weinig  <sam@webkit.org>
3034
3035         Reviewed by Jon Honeycutt.
3036
3037         Add WebView SPI to set HTMLTokenizer yielding parameters.
3038
3039         * Interfaces/IWebViewPrivate.idl:
3040         * WebView.cpp:
3041         (WebView::setCustomHTMLTokenizerTimeDelay):
3042         (WebView::setCustomHTMLTokenizerChunkSize):
3043         * WebView.h:
3044
3045 2008-08-13  Eric Seidel  <eric@webkit.org>
3046
3047         Attempt to fix the windows build, not review.
3048
3049         * WebIconDatabase.cpp:
3050         (WebIconDatabase::getOrCreateDefaultIconBitmap):
3051
3052 2008-08-13  Ada Chan  <adachan@apple.com>
3053
3054         Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
3055         Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
3056         content into a device context.  Changed WebView::paintDocumentRectToContext()
3057         to call that WebFrame method.
3058
3059         Reviewed by Adam Roben.
3060
3061         * DOMHTMLClasses.cpp:
3062         (DOMHTMLElement::idName):
3063         * Interfaces/IWebFramePrivate.idl:
3064         * WebFrame.cpp:
3065         (WebFrame::paintDocumentRectToContext):
3066         (WebFrame::frameElement):
3067         * WebFrame.h:
3068         * WebView.cpp:
3069         (WebView::paintDocumentRectToContext):
3070
3071 2008-08-12  Timothy Hatcher  <timothy@apple.com>
3072
3073         Add a stub for InspectorClient::setAttachedWindowHeight.
3074
3075         * WebCoreSupport/WebInspectorClient.cpp:
3076         (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
3077         * WebCoreSupport/WebInspectorClient.h:
3078
3079 2008-08-12  Adam Roben  <aroben@apple.com>
3080
3081         Export WTFLog in Debug builds
3082
3083         Reviewed by John Sullivan.
3084
3085         * WebKit.vcproj/WebKit_debug.def:
3086
3087 2008-08-07  Steve Falkenburg  <sfalken@apple.com>
3088
3089         Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.
3090         
3091         WM_TIMER-based timers can be starved if enough other events are keeping
3092         our message loop busy. This change prevents many backing store deletes from stacking
3093         up in this case.
3094         
3095         Reviewed by Geoff Garen.
3096
3097         * WebView.cpp:
3098         (WebView::deleteBackingStore):
3099         (WebView::deleteBackingStoreSoon):
3100         (WebView::cancelDeleteBackingStoreSoon):
3101
3102 2008-08-05  Ada Chan  <adachan@apple.com>
3103
3104         Add a getter for CFURLRequestRef in WebMutableURLRequest.
3105
3106         Reviewed by Anders Carlsson.
3107
3108         * Interfaces/IWebMutableURLRequestPrivate.idl:
3109         * WebMutableURLRequest.cpp:
3110         (WebMutableURLRequest::cfRequest):
3111         * WebMutableURLRequest.h:
3112
3113 2008-08-05  Steve Falkenburg  <sfalken@apple.com>
3114
3115         Don't invalidate a WebView in the process of being closed when prefs change.
3116         
3117         Reviewed by Ada Chan.
3118
3119         * WebView.cpp:
3120         (WebView::notifyPreferencesChanged):
3121
3122 2008-08-04  Alice Liu  <alice.liu@apple.com>
3123
3124         Reviewed by Steve Falkenburg.
3125
3126         Fix CFDictionary leak
3127
3128         * CFDictionaryPropertyBag.cpp:
3129         (CFDictionaryPropertyBag::Write):
3130         m_dictionary is a RetainPtr and should adopt the CF type created
3131
3132 2008-08-02  Maxime Britto  <britto@apple.com>
3133
3134         Reviewed by Eric Seidel.
3135       
3136         These icons are copies from the resizers in WebCore/Ressources
3137
3138         * ChangeLog:
3139         * WebKit.vcproj/WebKit.rc:
3140         * WebKit.vcproj/panEastCursor.png: Added.
3141         * WebKit.vcproj/panNorthCursor.png: Added.
3142         * WebKit.vcproj/panNorthEastCursor.png: Added.
3143         * WebKit.vcproj/panNorthWestCursor.png: Added.
3144         * WebKit.vcproj/panSouthCursor.png: Added.
3145         * WebKit.vcproj/panSouthEastCursor.png: Added.
3146         * WebKit.vcproj/panSouthWestCursor.png: Added.
3147         * WebKit.vcproj/panWestCursor.png: Added.
3148         * WebKit.vcproj/resource.h:
3149         * WebKitDLL.cpp:
3150         (loadResourceIntoBuffer):
3151
3152 2008-08-01  Beth Dakin  <bdakin@apple.com>
3153
3154         Reviewed by Adam Roben.
3155
3156         Fix for <rdar://problem/6119382> Need to hook up WebFrame's 
3157         disconnected frame API on Windows.
3158
3159         * Interfaces/IWebFrame.idl:
3160         * WebFrame.cpp:
3161         (WebFrame::setIsDisconnected):
3162         * WebFrame.h:
3163
3164 2008-08-01  Adam Roben  <aroben@apple.com>
3165
3166         Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any
3167         form
3168
3169         Reviewed by Darin Adler.
3170
3171         * COMPropertyBag.h:
3172         (COMPropertyBag::QueryInterface): Cast to an appropriate type before
3173         assigning into ppvObject.
3174
3175 2008-07-31  Anders Carlsson  <andersca@apple.com>
3176
3177         Reviewed by Adam.
3178
3179         Get rid of FormValuesPropertyBag and use COMPropertyBag instead.
3180         
3181         * COMPropertyBag.h:
3182         Implement parts of IPropertyBag2. 
3183         Currently just one method (CountProperties) is implemented.
3184         
3185         * WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
3186         * WebCoreSupport/FormValuesPropertyBag.h: Removed.
3187       
3188         * WebFrame.cpp:
3189         (WebFrame::dispatchWillSubmitForm):
3190         Create a COMPropertyBag instead.
3191         
3192         * WebKit.vcproj/WebKit.vcproj:
3193
3194 2008-07-31  Anders Carlsson  <andersca@apple.com>
3195
3196         Reviewed by Jon.
3197         
3198         Tweak the names.
3199
3200         * WebCoreSupport/WebFrameLoaderClient.cpp:
3201         (WebFrameLoaderClient::createPlugin):
3202
3203 2008-07-31  Anders Carlsson  <andersca@apple.com>
3204
3205         Reviewed by Jon.
3206
3207         <rdar://problem/5826110>
3208         
3209         Add a way for WebKit clients to embed custom content in web pages.
3210         
3211         * Interfaces/IWebEmbeddedView.idl: Added.
3212         New interface which an embedded view must implement.
3213         
3214         * Interfaces/IWebUIDelegatePrivate.idl:
3215         Add new UI delegate method for creating an embedded view.
3216         
3217         * Interfaces/WebKit.idl:
3218         Include IWebEmbeddedView.idl.
3219         
3220         * WebCoreSupport/EmbeddedWidget.cpp: Added.
3221         * WebCoreSupport/EmbeddedWidget.h: Added.
3222         Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.
3223         
3224         * WebCoreSupport/WebFrameLoaderClient.cpp:
3225         (WebFrameLoaderClient::createPlugin):
3226         Check if the UI delegate wants to create an embedded view.
3227         
3228         * WebKit.vcproj/WebKit.vcproj:
3229         Add EmbeddedWidget.{cpp|h}
3230
3231 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
3232
3233         Rubber-stamped by Maciej.
3234
3235         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
3236         call sites now).
3237
3238         * WebCoreStatistics.cpp:
3239         (WebCoreStatistics::javaScriptObjectsCount):
3240         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3241         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3242         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3243         * WebJavaScriptCollector.cpp:
3244         (WebJavaScriptCollector::objectCount):
3245         * WebScriptCallFrame.cpp:
3246         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3247         * WebView.cpp:
3248         (WebView::stringByEvaluatingJavaScriptFromString):
3249
3250 2008-07-31  Jon Honeycutt  <jhoneycutt@apple.com>
3251
3252         Windows build fix.
3253
3254         * WebURLResponse.cpp:
3255
3256 2008-07-30  Mark Rowe  <mrowe@apple.com>
3257
3258         Windows build fix.
3259
3260         * WebURLResponse.cpp:  Don't include a header file that we just deleted.
3261
3262 2008-07-30  Anders Carlsson  <andersca@apple.com>
3263
3264         Reviewed by Mitz.
3265
3266         Use a COMPropertyBag instead of the HTTPHeaderPropertyBag.
3267         
3268         * HTTPHeaderPropertyBag.cpp: Removed.
3269         * HTTPHeaderPropertyBag.h: Removed.
3270         * WebURLResponse.cpp:
3271         (WebURLResponse::allHeaderFields):
3272
3273 2008-07-30  Anders Carlsson  <andersca@apple.com>
3274
3275         Fix copyright years.
3276         
3277         * COMPropertyBag.h:
3278         * COMVariantSetter.h:
3279
3280 2008-07-30  Anders Carlsson  <andersca@apple.com>
3281
3282         Reviewed by Sam.
3283
3284         More property bag work.
3285         
3286         * COMPropertyBag.h:
3287         (COMPropertyBag::COMPropertyBag):        
3288         (::adopt):
3289         (::Read):
3290         * COMVariantSetter.h:
3291         (COMIUnknownVariantSetter::setVariant):
3292
3293 2008-07-30  Anders Carlsson  <andersca@apple.com>
3294
3295         Reviewed by Sam.
3296
3297         Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
3298         property bag values must be of the same type.
3299         
3300         The COMVariantSetter helpers are now in COMVariantSetter.h
3301         
3302         * COMEnumVariant.h:
3303         * COMPropertyBag.h: Added.
3304         * COMVariantSetter.h: Added.
3305         * WebKit.vcproj/WebKit.vcproj:
3306         
3307 2008-07-30  Alice Liu  <alice.liu@apple.com>
3308
3309         Reviewed by Adam Roben.
3310
3311         Adding logging of COM class names and counts to facilitate
3312         investigating memory issues.
3313
3314         * Interfaces/IWebKitStatistics.idl:
3315         * WebKitDLL.cpp:
3316         * WebKitDLL.h:
3317         * WebKitStatistics.cpp:
3318         (WebKitStatistics::comClassNameCounts):
3319         * WebKitStatistics.h:
3320
3321 2008-07-29  Alice Liu  <alice.liu@apple.com>
3322
3323         Reviewed by Geoff Garen.
3324
3325         Fix WebDocumentLoader leak on Windows.
3326
3327         * WebCoreSupport/WebFrameLoaderClient.cpp:
3328         (WebFrameLoaderClient::createDocumentLoader):
3329         * WebDocumentLoader.cpp:
3330         (WebDocumentLoader::create):
3331         * WebDocumentLoader.h:
3332
3333 2008-07-29  Adam Roben  <aroben@apple.com>
3334
3335         Export detachThread
3336
3337         Reviewed by Geoff Garen.
3338
3339         * WebKit.vcproj/WebKit.def:
3340         * WebKit.vcproj/WebKit_debug.def:
3341
3342 2008-07-29  Adam Roben  <aroben@apple.com>
3343
3344         Export the new version of createThread
3345
3346         Reviewed by Anders Carlsson.
3347
3348         * WebKit.vcproj/WebKit.def:
3349         * WebKit.vcproj/WebKit_debug.def:
3350         Also moved the old version of createThread into the deprecated
3351         section.
3352
3353 2008-07-26  Matt Lilek  <webkit@mattlilek.com>
3354
3355         Reviewed by Geoff Garen.
3356
3357         Changes to accommodate newly named/signatured loading methods in WebCore.
3358
3359         * WebCoreSupport/WebContextMenuClient.cpp:
3360         (WebContextMenuClient::searchWithGoogle):
3361         * WebCoreSupport/WebFrameLoaderClient.cpp:
3362         (WebFrameLoaderClient::loadURLIntoChild):
3363
3364 2008-07-25  Adam Roben  <aroben@apple.com>
3365
3366         Try to fix the Windows build bot
3367
3368         * WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each
3369         project now depends only on the project that should immediately
3370         precede it in the build. For the frameworks, this order makes sense.
3371         For the applications built on top of the frameworks, the order is
3372         arbitrary (but roughly follows the applications' complexity).
3373
3374 2008-07-17  Adele Peterson  <adele@apple.com>
3375
3376         Reviewed by Adam.
3377
3378         WebKit part of fix for <rdar://problem/5698672>  Add drawing callback for a WebKit app to draw its own scrollbars
3379         
3380         Added a setting so an application can tell WebKit its going to draw custom scrollbars.  Also added delegate methods for the actual painting.
3381         
3382         * Interfaces/IWebPreferences.idl:  Added setShouldPaintCustomScrollbars and shouldPaintCustomScrollbars.
3383         * Interfaces/IWebScrollBarPrivate.idl: Moved types to WebScrollbarTypes.idl
3384         * Interfaces/IWebUIDelegate.idl: Added WebUIDelegate4 with new delegate methods, paintCustomScrollbar and paintCustomScrollCorner
3385         * Interfaces/WebKit.idl: Include new WebScrollbarTypes.idl
3386         * Interfaces/WebScrollbarTypes.idl: Added. Has types that the new delegate methods use.
3387         * WebCoreSupport/WebChromeClient.cpp:
3388         (WebChromeClient::paintCustomScrollbar): Added. Calls new delegate method and converts between WebCore types and types exported in WebScrollbarTypes.idl
3389         (WebChromeClient::paintCustomScrollCorner): Added. Calls new delegate method.
3390         (WebChromeClient::uiDelegate4): Added.
3391         * WebCoreSupport/WebChromeClient.h:
3392         * WebPreferenceKeysPrivate.h: Added WebKitPaintCustomScrollbarsPreferenceKey
3393         * WebPreferences.cpp:
3394         (WebPreferences::): Added.
3395         (WebPreferences::shouldPaintCustomScrollbars): Added.
3396         * WebPreferences.h:
3397         * WebView.cpp: (WebView::notifyPreferencesChanged):
3398
3399 2008-07-15  Adam Roben  <aroben@apple.com>
3400
3401         Add WebKit[Set]ShouldUseFontSmoothing functions
3402
3403         <rdar://6059127>
3404
3405         Reviewed by John Sullivan.
3406
3407         * WebKit.vcproj/WebKit.def:
3408         * WebKit.vcproj/WebKit_debug.def:
3409         Export the new functions.
3410         * WebKitGraphics.cpp:
3411         (WebKitSetShouldUseFontSmoothing):
3412         (WebKitShouldUseFontSmoothing):
3413         Call through to the relevant WebCore functions.
3414         * WebKitGraphics.h:
3415
3416 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
3417
3418         Don't include autoversion.h in WebKitDLL.cpp.
3419         autoversion.h changes for every build, so we don't want to include it unless necessary.        
3420
3421         Rubber stamped by Ada Chan.
3422
3423         * WebKitDLL.cpp:
3424
3425 2008-07-14  Adam Roben  <aroben@apple.com>
3426
3427         Windows build fix
3428
3429         * WebJavaScriptCollector.cpp:
3430         (WebJavaScriptCollector::objectCount): Updated to match
3431         -[WebCoreStatistics javaScriptsObjectCount].
3432
3433 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
3434
3435         Reviewed by Geoff Garen.
3436
3437         Eliminate per-thread JavaScript global data instance support and make arbitrary
3438         global data/global object combinations possible.
3439
3440         * WebCoreStatistics.cpp:
3441         (WebCoreStatistics::javaScriptObjectsCount):
3442         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3443         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3444         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3445         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
3446
3447 2008-07-11  Steve Falkenburg  <sfalken@apple.com>
3448
3449         Build fix.
3450
3451         * WebKit.vcproj/WebKit.vcproj:
3452
3453 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
3454
3455         Build fix.
3456
3457         * WebKit.vcproj/Interfaces.vcproj:
3458
3459 2008-07-10  Adam Roben  <aroben@apple.com>
3460
3461         Windows build fix
3462
3463         * WebKit.vcproj/resource.h: Revert some changes that VS made to this
3464         file in r35083.
3465
3466 2008-07-09  Maxime Britto  <britto@apple.com>
3467
3468         Reviewed by Adele.
3469        
3470         Added the panning icon in the ressources.
3471         Its name is compass.png to make a difference with moveCursor.png (from the WebCore ressources)
3472
3473         * ChangeLog:
3474         * WebKit.vcproj/WebKit.rc:
3475         * WebKit.vcproj/panIcon.png: Added.
3476         * WebKit.vcproj/resource.h:
3477         * WebKitDLL.cpp: Declared the new ressource with the name "panIcon"
3478         (loadResourceIntoBuffer):
3479
3480 2008-07-02  Dan Bernstein  <mitz@apple.com>
3481
3482         - try to fix the Windows build
3483
3484         * WebScriptCallFrame.cpp:
3485
3486 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
3487
3488         Reviewed by Darin Adler.
3489
3490         Disable JSLock for per-thread contexts.
3491
3492         * WebCoreStatistics.cpp:
3493         (WebCoreStatistics::javaScriptObjectsCount):
3494         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3495         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3496         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3497         * WebScriptCallFrame.cpp:
3498         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3499         * WebView.cpp:
3500         (WebView::stringByEvaluatingJavaScriptFromString):
3501         Pass a parameter (false) to JSLock to indicate that WebKit doesn't need locking.
3502         Include JSLock.h, as it is no longer brought in implicitly.
3503
3504 2008-06-27  Adam Roben  <aroben@apple.com>
3505
3506         Change WebKitGraphics truncation functions to return the length of the
3507         truncated string
3508
3509         Reviewed by Darin Adler.
3510
3511         * WebKitGraphics.cpp:
3512         (CenterTruncateStringToWidth):
3513         (RightTruncateStringToWidth):
3514         Return the length.
3515         * WebKitGraphics.h:
3516         The truncation functions now return an unsigned int that is the length
3517         of the truncated string. The whole file has been marked extern "C" to
3518         keep the symbols for these functions from changing (which would break
3519         nightly builds).
3520
3521 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
3522
3523         Windows build fix.
3524
3525         * WebJavaScriptCollector.cpp: Added a missing include.
3526
3527 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
3528
3529         Reviewed by Darin Adler.
3530
3531         Prepare JavaScript heap for being per-thread.
3532
3533         * WebCoreStatistics.cpp:
3534         (WebCoreStatistics::javaScriptObjectsCount):
3535         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3536         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3537         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3538         * WebJavaScriptCollector.cpp:
3539         (WebJavaScriptCollector::objectCount):
3540         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
3541
3542         * WebScriptCallFrame.cpp:
3543         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Pass ExecState* where
3544         now required.
3545
3546 2008-06-16  Alexey Proskuryakov  <ap@webkit.org>
3547
3548         Trying to fix Windows build.
3549
3550         * WebScriptCallFrame.cpp:
3551         (WebScriptCallFrame::variableNames):
3552         (WebScriptCallFrame::valueForVariable):
3553         Give ExecState to functions that now take it.
3554
3555 2008-06-16  Adam Roben  <aroben@apple.com>
3556
3557         Windows build fix
3558
3559         * WebScriptCallFrame.cpp: Fixed a header name.
3560
3561 2008-06-15  Darin Adler  <darin@apple.com>
3562
3563         - give Frame object functions shorter names: scriptProxy() -> script(),
3564           selectionController() -> selection(), animationController() -> animation()
3565
3566         * WebFrame.cpp:
3567         (WebFrame::globalContext):
3568         (WebFrame::windowObjectCleared):
3569         * WebView.cpp:
3570         (WebView::handleContextMenuEvent):
3571         (WebViewWndProc):
3572         (WebView::updateFocusedAndActiveState):
3573         (WebView::hasSelectedRange):
3574         (WebView::replaceSelectionWithText):
3575         (WebView::clearSelection):
3576         (WebView::prepareCandidateWindow):
3577         (WebView::onIMERequestCharPosition):
3578         (WebView::onIMERequestReconvertString):
3579
3580 2008-06-15  Darin Adler  <darin@apple.com>
3581
3582         - rename KJS::List to KJS::ArgList
3583
3584         * WebScriptCallFrame.cpp:
3585         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
3586
3587 2008-06-15  Darin Adler  <darin@apple.com>
3588
3589         - new names for a few key JavaScriptCore files
3590
3591         * WebView.cpp:
3592
3593 2008-06-15  Darin Adler  <darin@apple.com>
3594
3595         Rubber stamped by Sam.
3596
3597         - use JS prefix and simpler names for basic JavaScriptCore types,
3598           to complement JSValue and JSObject
3599
3600         * WebScriptCallFrame.cpp:
3601         (WebScriptCallFrame::functionName):
3602
3603 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
3604
3605         Rubber stamped by Oliver.
3606         
3607         - fix WebKit solution for testkjs --> jsc rename
3608
3609         * WebKit.vcproj/WebKit.sln:
3610
3611 2008-06-14  Darin Adler  <darin@apple.com>
3612
3613         Rubber stamped by Sam.
3614
3615         - new names for kjs_binding.h and kjs_proxy.h
3616
3617         * WebFrame.cpp:
3618
3619 2008-06-14  Darin Adler  <darin@apple.com>
3620
3621         Rubber stamped by Sam.
3622
3623         - renamed HTMLGenericFormElement to HTMLFormControlElement
3624
3625         * WebFrame.cpp:
3626         (WebFrame::elementWithName):
3627         (WebFrame::controlsInForm):
3628
3629 2008-06-14  Darin Adler  <darin@apple.com>
3630
3631         - try to fix Windows build, again
3632
3633         * WebFrame.cpp:
3634         (WebFrame::dispatchDecidePolicyForNewWindowAction): Fix arguments. Pass form.
3635         (WebFrame::dispatchDecidePolicyForNavigationAction): Ditto.
3636         * WebFrame.h: Fix arguments.
3637
3638 2008-06-14  Darin Adler  <darin@apple.com>
3639
3640         - try to fix Windows build
3641
3642         * WebActionPropertyBag.cpp:
3643         (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
3644         * WebFrame.h: Added missing FormState arguments.
3645         * WebScrollBar.cpp:
3646         (WebScrollBar::init): Use create instead of new.
3647
3648 2008-06-14  Darin Adler  <darin@apple.com>
3649
3650         Reviewed by Sam.
3651
3652         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
3653           start ref counts at 1 instead of 0 for speed
3654
3655         * WebCoreSupport/WebFrameLoaderClient.cpp:
3656         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
3657         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
3658         conventional ones without a special case.
3659
3660         * WebFrame.cpp:
3661         (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused
3662         IWebFrameView argument (every caller was passing 0). Also changed this to return the
3663         WebCore Frame object, which is needed to straighten out the lifetime and ownership
3664         issues.
3665         * WebFrame.h: Ditto.
3666
3667         * WebView.cpp:
3668         (WebView::initWithFrame): Changed to call new init function and use the return value.
3669
3670 2008-06-13  Darin Adler  <darin@apple.com>
3671
3672         Reviewed by John Sullivan.
3673
3674         - updated for addition of FormState argument to action policy functions
3675         - added WebActionFormKey
3676
3677         * Interfaces/IWebPolicyDelegate.idl:
3678         * WebActionPropertyBag.cpp:
3679         (WebActionPropertyBag::WebActionPropertyBag):
3680         (WebActionPropertyBag::createInstance):
3681         (WebActionPropertyBag::AddRef):
3682         (WebActionPropertyBag::Release):
3683         (WebActionPropertyBag::Read):
3684         * WebActionPropertyBag.h:
3685         * WebFrame.cpp:
3686         (WebFrame::dispatchDecidePolicyForNewWindowAction):
3687         (WebFrame::dispatchDecidePolicyForNavigationAction):
3688
3689 2008-06-07  Darin Adler  <darin@apple.com>
3690
3691         Reviewed by Mitz.
3692
3693         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
3694           start ref counts at 1 instead of 0 for speed
3695
369