Don't include substitute data URLs in global history redirect chains
[WebKit-https.git] / WebKit / win / ChangeLog
1 2009-03-27  Adam Roben  <aroben@apple.com>
2
3         Don't include substitute data URLs in global history redirect chains
4
5         <rdar://6690169>
6
7         Reviewed by Darin Adler.
8
9         * WebCoreSupport/WebFrameLoaderClient.cpp:
10         (WebFrameLoaderClient::updateGlobalHistory): Don't call
11         updateGlobalHistoryRedirectLinks. FrameLoader calls this for us now.
12         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
13         Added an assertion to help catch cases where we might be adding a
14         substitute data URL into a redirect chain.
15
16 2009-03-26  Dan Bernstein  <mitz@apple.com>
17
18         Reviewed by Adam Roben.
19
20         - add close() to the WebView API.
21
22         * Interfaces/IWebView.idl:
23         * WebView.cpp:
24         (WebView::close):
25         * WebView.h:
26
27 2009-03-24  Brent Fulgham  <bfulgham@webkit.org>
28
29         Reviewed by Adam Roben.
30
31         https://bugs.webkit.org/show_bug.cgi?id=24779
32         Conditionalize CFNetwork-specific code in WebView to permit
33         support for other network backends.
34
35         * WebView.cpp:
36         (WebView::setCacheModel): Add CFNETWORK check around CFNetwork
37         specific cache implementation.
38         (updateSharedSettingsFromPreferencesIfNeeded): Add CFNETWORK
39         check around use of CFHTTPCookie code.
40
41 2009-03-23  Sam Weinig  <sam@webkit.org>
42
43         Reviewed by Dan Bernstein.
44
45         Fix for <rdar://problem/6140966>
46         Empty Caches does not clear the Cross-site XMLHttpRequest preflight cache
47
48         * WebCache.cpp:
49         (WebCache::empty): Also add application cache emptying to match the mac.
50
51 2009-03-18  Steve Falkenburg  <sfalken@apple.com>
52
53         Add webViewClosing to private UI delegate.
54
55         Reviewed by Adam Roben.
56
57         * Interfaces/IWebUIDelegatePrivate.idl:
58         * Interfaces/WebKit.idl:
59         * WebView.cpp:
60         (WebView::close):
61
62 2009-03-17  Dan Bernstein  <mitz@apple.com>
63
64         Reviewed by Adam Roben.
65
66         - WebKit part of adding a mechanism for controlling the caching of
67           responses through WebFrameLoaderClient
68
69         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added the
70         IWebResourceLoadDelegatePrivate3 interface, containing the new
71         delegate method shouldCacheResponse().
72
73         * Interfaces/IWebURLRequest.idl: Added the isEqual() method.
74
75         * WebCoreSupport/WebFrameLoaderClient.cpp:
76         (WebFrameLoaderClient::shouldCacheResponse): Implemented this new
77         FrameLoaderDelegate method by calling through to the resource load
78         delegate, if it implements shouldCacheResponse(), and returning true
79         otherwise.
80
81         * WebCoreSupport/WebFrameLoaderClient.h:
82
83         * WebMutableURLRequest.cpp:
84         (WebMutableURLRequest::isEqual): Added.
85         (WebMutableURLRequest::setValue): Implemented.
86
87         * WebMutableURLRequest.h: Declared isEqual().
88
89 2009-03-16  Darin Adler  <darin@apple.com>
90
91         Reviewed by Dan Bernstein.
92
93         <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”
94
95         For now, change only the localized strings, not the terminology in the code.
96
97         * WebCoreLocalizedStrings.cpp:
98         (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here.
99         (WebCore::contextMenuItemTagTextDirectionMenu): And here.
100
101 2009-03-16  Adam Roben  <aroben@apple.com>
102
103         Add IWebFramePrivate::isDisplayingStandaloneImage
104
105         This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
106         uses.
107
108         Reviewed by Darin Adler.
109
110         * Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.
111
112         * WebFrame.cpp:
113         (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our
114         Document is an image document.
115
116         * WebFrame.h: Added isDisplayingStandaloneImage.
117
118 2009-03-12  Peter Kasting  <pkasting@google.com>
119
120         Reviewed by Darin Fisher.
121
122         https://bugs.webkit.org/show_bug.cgi?id=24502
123         Make horizontal scrolling on Windows always go the correct direction.
124
125         * WebView.cpp:
126         (WebView::mouseWheel):
127         (WebViewWndProc):
128         * WebView.h:
129
130 2009-03-12  Adam Roben  <aroben@apple.com>
131
132         Implement DOMHTMLDocument::title
133
134         Reviewed by Dan Bernstein.
135
136         * DOMHTMLClasses.cpp:
137         (DOMHTMLDocument::title): Call through to WebCore::Document (with
138         obligatory COM error checking/type conversions).
139
140 2009-03-11  Adam Roben  <aroben@apple.com>
141
142         Export functions needed by ThreadSpecific from WebKit
143
144         Reviewed by John Sullivan.
145
146         * WebKit.vcproj/WebKit.def:
147         * WebKit.vcproj/WebKit_debug.def:
148         Export WTF::tlsKeyCount and WTF::tlsKeys.
149
150 2009-03-10  Steve Falkenburg  <sfalken@apple.com>
151
152         <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults
153         
154         Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.
155         
156         This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
157         The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
158         saying there was browsing history for a particular day, and then return no history items when we requested a
159         list of sites visited that day.        
160         
161         Reviewed by Ada Chan.
162
163         * MarshallingHelpers.cpp:
164         (MarshallingHelpers::DATEToCFAbsoluteTime):
165         (MarshallingHelpers::CFAbsoluteTimeToDATE):
166
167 2009-03-08  Mark Rowe  <mrowe@apple.com>
168
169         Reviewed by Oliver Hunt.
170
171         Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
172         Frame.h no longer needs to include it.  This cuts the size of the symbols
173         for a debug build by around 3%.
174
175         * WebView.cpp:
176         (WebView::centerSelectionInVisibleArea):
177
178 2009-03-07  Dan Bernstein  <mitz@apple.com>
179
180         Reviewed by Mark Rowe.
181
182         - WebKit part of removing build-time and run-time support for legacy
183           versions of CFNetwork and Core Graphics
184
185         * WebView.cpp:
186         (WebView::setCacheModel):
187
188 2009-03-04  Adam Barth  <abath@webkit.org>
189
190         Reviewed by Alexey Proskuryakov.
191
192         https://bugs.webkit.org/show_bug.cgi?id=24356
193
194         Fix WebKit style for allowUniversalAccessFromFileURLs.
195
196         * Interfaces/IWebPreferencesPrivate.idl:
197         * WebPreferenceKeysPrivate.h:
198         * WebPreferences.cpp:
199         (WebPreferences::initializeDefaultSettings):
200         (WebPreferences::allowUniversalAccessFromFileURLs):
201         (WebPreferences::setAllowUniversalAccessFromFileURLs):
202         * WebPreferences.h:
203         * WebView.cpp:
204         (WebView::notifyPreferencesChanged):
205
206 2009-02-27  Adam Barth  <abarth@webkit.org>
207
208         Reviewed by Eric Seidel.
209
210         Add a preference to reduce the power of file:// URLs.
211
212         * Interfaces/IWebPreferencesPrivate.idl:
213         * WebPreferenceKeysPrivate.h:
214         * WebPreferences.cpp:
215         (WebPreferences::initializeDefaultSettings):
216         (WebPreferences::allowUniversalAccessFromFileUrls):
217         (WebPreferences::setAllowUniversalAccessFromFileUrls):
218         * WebPreferences.h:
219         * WebView.cpp:
220         (WebView::notifyPreferencesChanged):
221
222 2009-02-19  Alexey Proskuryakov  <ap@webkit.org>
223
224         Reviewed by Darin Adler.
225
226         https://bugs.webkit.org/show_bug.cgi?id=24024
227         REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
228         archiving a submission to about:blank
229
230         I don't know how to make an automated test for this bug.
231
232         * WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be
233         non-empty for non-HTTP requests.
234
235 2009-02-25  Andreia Gaita  <shana@jitted.com>
236
237         Reviewed by Alp Toker.
238
239         Update Win def files with recent JavaScriptCore API additions.
240
241         * WebKit.vcproj/WebKit.def:
242         * WebKit.vcproj/WebKit_Cairo.def:
243         * WebKit.vcproj/WebKit_debug.def:
244
245 2009-02-24  Sam Weinig  <sam@webkit.org>
246
247         Reviewed by Geoffrey Garen.
248
249         Related to <rdar://problem/6590295>
250         Allow disabling javascript: urls.
251
252         * Interfaces/IWebViewPrivate.idl:
253         * WebView.cpp:
254         (WebView::setJavaScriptURLsAreAllowed):
255         * WebView.h:
256
257 2009-02-24  Adam Roben  <aroben@apple.com>
258
259         Windows build fix
260
261         * WebKit.vcproj/WebKit.def:
262         * WebKit.vcproj/WebKit_debug.def:
263         Export WTF::ThreadCondition::timedWait.
264
265 2009-02-12  Brady Eidson  <beidson@apple.com>
266
267         Reviewed by Kevin Decker
268
269         <rdar://problem/6582180> - Wrong HTTP method applied to history item.
270
271         * WebCoreSupport/WebFrameLoaderClient.cpp:
272         (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any
273           redirected request.
274
275 2009-02-11  Brady Eidson  <beidson@apple.com>
276
277         Fix my last checkin for more effect.
278
279         * WebHistoryItem.cpp:
280         (WebHistoryItem::initFromDictionaryRepresentation):
281
282 2009-02-11  Adam Roben  <aroben@apple.com>
283
284         Windows fix for Bug 22239: Implement missing animation & transition
285         APIs on LayoutTestController for non-mac platforms
286
287         <https://bugs.webkit.org/show_bug.cgi?id=22239>
288
289         Reviewed by Simon Fraser.
290
291         * Interfaces/IWebFramePrivate.idl: Added pauseAnimation,
292         pauseTransition, and numberOfActiveAnimations.
293
294         * WebFrame.cpp:
295         (WebFrame::pauseAnimation):
296         (WebFrame::pauseTransition):
297         (WebFrame::numberOfActiveAnimation):
298         Added. These all call through to AnimationController.
299
300         * WebFrame.h: Added pauseAnimation, pauseTransition, and
301         numberOfActiveAnimations.
302
303 2009-02-11  Brady Eidson  <beidson@apple.com>
304
305         Reviewed by Mark Rowe
306
307         <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative
308
309         Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed 
310         and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
311         which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.
312
313         * WebHistory.cpp:
314         (WebHistory::loadHistoryGutsFromURL):
315         (WebHistory::addItems):
316         (WebHistory::addItem): Add a mode that allows the entry being added to be discarded if an entry for the URL already 
317           exists.  Use that mode when reading the History.plist so only the most recent entry for a given URL will be used.
318         (WebHistory::visitedURL): Swap the removeItemFromDateCaches and visitedWithTitle calls.
319         * WebHistory.h:
320
321         * WebHistoryItem.cpp:
322         (WebHistoryItem::initFromDictionaryRepresentation):  Add the negative-visit-count-correction-logic as implemented
323           for Mac in http://trac.webkit.org/changeset/40851.
324
325 2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>
326
327         Stub out WebInspectorClient::hiddenPanels.
328
329         Reviewed by Timothy Hatcher.
330
331         * WebCoreSupport/WebInspectorClient.cpp:
332         (WebInspectorClient::hiddenPanels):
333         * WebCoreSupport/WebInspectorClient.h:
334
335 2009-02-11  Adam Roben  <aroben@apple.com>
336
337         Don't release the shared WebHistory instance on quit
338
339         This matches Mac, and prevents a race condition when the process exits
340         that depends on the order in which global destructors are invoked.
341
342         Reviewed by Alexey Proskuryakov.
343
344         * WebHistory.cpp:
345         (sharedHistoryStorage): Changed to use DEFINE_STATIC_LOCAL so the
346         destructor is never called.
347
348 2009-02-10  Adam Roben  <aroben@apple.com>
349
350         Fix recursive WebView destruction when running DumpRenderTree
351
352         DumpRenderTree would call DestroyWindow on a WebView's host window,
353         which would send a WM_DESTROY message to the WebView's window. Inside
354         the WebView's WndProc, we would hold a ref to the WebView, then call
355         close() and revokeDragDrop(), which would release all remaining
356         references to the WebView other than the ref we held in the WndProc.
357         When the WndProc exited, the final ref to the WebView would be
358         released, invoking WebView's destructor. At this point,
359         IsWindow(m_viewWindow) would return true, since we were still in the
360         process of handling WM_DESTROY, so we would call DestroyWindow on the
361         WebView's window again, re-entering the WndProc and re-reffing the
362         WebView, leading to recursive destruction.
363
364         Reviewed by Alexey Proskuryakov.
365
366         * WebView.cpp:
367         (WebView::~WebView): Don't call DestroyWindow if our window is already
368         being destroyed.
369         (WebViewWndProc): Only hold an extra ref to the WebView when we're not
370         being destroyed.
371
372 2009-02-06  Adam Roben  <aroben@apple.com>
373
374         Build fix
375
376         Reviewed by Sam Weinig.
377
378         * WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include.
379         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed
380         incorrect .get(), and changed to use the new overload of
381         WebHistory::itemForURLString.
382
383         * WebHistory.cpp:
384         (WebHistory::itemForURLString): Made this const.
385         (WebHistory::itemForURLString): Added an overload that takes a
386         WebCore::String and returns the IWebHistoryItem instead of using an
387         out parameter.
388
389         * WebHistory.h: Added public overload of itemForURLString.
390
391         * WebView.cpp:
392         (WebView::prepareCandidateWindow):
393         (WebView::onIMERequestCharPosition):
394         (WebView::onIMERequestReconvertString):
395         Updated for toRange -> toNormalizedRange rename.
396
397 2009-02-06  Geoffrey Garen  <ggaren@apple.com>
398
399         Reviewed by Sam Weinig.
400
401         Part III of <rdar://problem/6552272>.
402         
403         Refactored to use the redirect data WebCore makes available, instead of
404         tracking loading state in WebKit.
405         
406         * WebCoreSupport/WebFrameLoaderClient.cpp:
407         (WebFrameLoaderClient::updateGlobalHistory):
408         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
409         * WebCoreSupport/WebFrameLoaderClient.h:
410         * WebHistory.cpp:
411         (WebHistory::visitedURL):
412         * WebHistory.h:
413
414 2009-02-06  Dan Bernstein  <mitz@apple.com>
415
416         Reviewed by Anders Carlsson.
417
418         - fix an assertion failure in Vector::at() beneath
419           WebHistoryItem::dictionaryRepresentation.
420
421         * WebHistoryItem.cpp:
422         (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial
423         size. Also reduced the inline capacity of the vector used for weekly visit
424         counts to 5, which is the expected maximum size.
425
426 2009-02-06  Brent Fulgham  <bfulgham@webkit.org>
427
428         Build fix.  
429
430         * WebKit.vcproj/WebKit.vcproj: Re-enable missing file in Release
431           target of Cairo.
432
433 2009-02-06  Maciej Stachowiak  <mjs@apple.com>
434
435         Rubber stamped by Dan Bernstein.
436
437         - fix obvious problem in previous commit (|| used instead of &&)
438
439         * WebHistoryItem.cpp:
440         (WebHistoryItem::initFromDictionaryRepresentation):
441
442 2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>
443
444         Reviewed by Dan Bernstein and Geoff Garen..
445
446         - WebKit code to track per-day and per-week visit counts in history
447
448         For now this data is only exposed via SPI for performance reasons.
449
450         * Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
451         * WebHistory.cpp:
452         (WebHistory::visitedURL): Use new recordInitialVisit method.
453         * WebHistoryItem.cpp:
454         (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support
455         for new data.
456         (WebHistoryItem::dictionaryRepresentation): Add saving support for
457         new data.
458         (WebHistoryItem::getDailyVisitCounts): SPI accessor.
459         (WebHistoryItem::getWeeklyVisitCounts): SPI accessor.
460         (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
461         * WebHistoryItem.h:
462
463 2009-02-05  Brent Fulgham  <bfulgham@webkit.org>
464
465         Reviewed by Sam Weinig <sam@webkit.org>
466
467         Build fix.  Update file for recently removed EventTargetNodeCast.
468         * DOMCoreClasses.cpp:
469         (DOMNode::dispatchEvent):
470
471 2009-02-05  Aaron Boodman  <aa@chromium.org>
472
473         Reviewed by Dave Hyatt.
474
475         https://bugs.webkit.org/show_bug.cgi?id=23708
476         Adds documentElementAvailable() callback to FrameLoaderClient.
477
478         * WebFrame.cpp:
479         (WebFrame::documentElementAvailable):
480         Stub out documentElementAvailable()
481         * WebFrame.h:
482         Ditto.
483
484 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
485
486         Build fix.
487
488         * WebHistory.cpp:
489         (WebHistory::visitedURL):
490
491 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
492
493         Reviewed by Mark Rowe.
494         
495         Part I of <rdar://problem/6552272>.
496
497         Clear the redirectURLs entry when first visiting a site, so sites that
498         only redirect you the first time you visit them can later learn that
499         they don't redirect.
500
501         * WebHistory.cpp:
502         (WebHistory::visitedURL):
503
504 2009-02-03  Geoffrey Garen  <ggaren@apple.com>
505
506         Build fix.
507
508         * WebHistory.cpp:
509         (WebHistory::visitedURL):
510
511 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
512
513         Build fix.
514
515         * WebHistory.cpp:
516         (WebHistory::visitedURL):
517
518 2009-02-02  Hiroaki Nakamura <hnakamur@gmail.com>
519
520         Reviewed by Adam Roben.
521
522         Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
523         Modify pre-build step to properly handle the errorlevel
524         shell command.
525
526         * WebKit.vcproj/WebKit.vcproj: Change errorlevel handling
527         for all targets so prefast is only enabled in builds
528         where /analyze is available.
529
530 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
531
532         Reviewed by Sam Weinig.
533
534         Track redirects in global history.
535
536         * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
537
538         * WebCoreSupport/WebFrameLoaderClient.cpp:
539         (WebFrameLoaderClient::updateGlobalHistory):
540         (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
541         Store redirect information in global history.
542
543         (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
544
545         * WebCoreSupport/WebFrameLoaderClient.h: See above.
546
547         * WebFrame.cpp:
548         (WebFrame::loadRequest):
549         (WebFrame::loadData): Updated for extra parameter.
550
551         * WebHistory.cpp:
552         (WebHistory::visitedURL):
553         (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
554         information in global history.
555
556         * WebHistory.h: See above.
557
558 2009-02-02  Brady Eidson  <beidson@apple.com>
559
560         Reviewed by Dan Bernstein
561
562         Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.
563
564         * Interfaces/IWebHistoryItemPrivate.idl:
565         * WebCoreSupport/WebFrameLoaderClient.cpp:
566         (WebFrameLoaderClient::updateGlobalHistory):
567
568         * WebHistory.cpp:
569         (WebHistory::visitedURL):
570         * WebHistory.h:
571
572         * WebHistoryItem.cpp:
573         (WebHistoryItem::visitedWithTitle):
574         * WebHistoryItem.h:
575
576 2009-02-02  Anders Carlsson  <andersca@apple.com>
577
578         Fix build.
579         
580         * WebCoreSupport/WebFrameLoaderClient.cpp:
581         (WebFrameLoaderClient::createPlugin):
582         * WebCoreSupport/WebFrameLoaderClient.h:
583
584 2009-02-02  Anders Carlsson  <andersca@apple.com>
585
586         Reviewed by Dan Bernstein.
587
588         Update for changes to WebCore.
589
590         * WebFrame.cpp:
591         (WebFrame::createJavaAppletWidget):
592         * WebFrame.h:
593
594 2009-02-02  Holger Hans Peter Freyther  <zecke@selfish.org>
595
596         Reviewed by Darin Adler.
597
598         Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
599
600         https://bugs.webkit.org/show_bug.cgi?id=23428
601
602         FrameView::forceLayout could be killed but the comment might
603         contain a value over the the plain FrameView::layout...
604
605         Adjust the WebCore/WebKit consumers of these methods.
606
607         * WebCoreSupport/WebFrameLoaderClient.cpp:
608         (WebFrameLoaderClient::forceLayout):
609
610 2009-01-31  Matt Lilek  <webkit@mattlilek.com>
611
612         Not reviewed, build fixes.
613
614         * WebCoreSupport/WebContextMenuClient.cpp:
615         (WebContextMenuClient::searchWithGoogle):
616         * WebFrame.cpp:
617         (WebFrame::setInPrintingMode):
618         (WebFrame::isFrameSet):
619         * WebView.cpp:
620         (WebView::notifyPreferencesChanged):
621
622 2009-01-30  Adam Barth  <abarth@webkit.org>
623
624         Reviewed by Sam Weinig.
625
626         Add a pref to disable web security.
627
628         * Interfaces/IWebPreferencesPrivate.idl:
629         * WebPreferenceKeysPrivate.h:
630         * WebPreferences.cpp:
631         (WebPreferences::initializeDefaultSettings):
632         (WebPreferences::isWebSecurityEnabled):
633         (WebPreferences::setWebSecurityEnabled):
634         * WebPreferences.h:
635         * WebView.cpp:
636         (WebView::notifyPreferencesChanged):
637
638 2009-01-30  Geoffrey Garen  <ggaren@apple.com>
639
640         Build fix.
641
642         * Interfaces/IWebFramePrivate.idl:
643         * WebCoreSupport/WebFrameLoaderClient.cpp:
644         (WebFrameLoaderClient::loadURLIntoChild):
645
646 2009-01-30  Holger Hans Peter Freyther  <zecke@selfish.org>
647
648         Reviewed by Simon Hausmann.
649
650         Kill FrameLoaderClient.cpp, move the code over to Frame::createView
651
652         FrameLoaderClient is supposed to be an interface, move the
653         to be shared code to Frame which is a controller and is
654         allowed to create a FrameView.
655
656         * WebCoreSupport/WebFrameLoaderClient.cpp:
657         (WebFrameLoaderClient::transitionToCommittedForNewPage):
658
659 2009-01-30  Brady Eidson  <beidson@apple.com>
660
661         Reviewed by Sam Weinig
662
663         Remove FrameLoaderClient code that is now handled by FrameLoader itself
664
665         * WebFrame.cpp:
666         (WebFrame::frameLoadCompleted):
667
668 2009-01-29  Sam Weinig  <sam@webkit.org>
669
670         Fix Windows build
671
672         * WebHistoryItem.cpp:
673         (WebHistoryItem::initFromDictionaryRepresentation):
674
675 2009-01-29  Sam Weinig  <sam@webkit.org>
676
677         Reviewed by Anders Carlsson.
678
679         Second step in tracking the urls a HistoryItem was redirected through
680         Add SPI to access the array of redirect urls associated with a HistoryItem.
681
682         * Interfaces/IWebHistoryItemPrivate.idl:
683         * WebHistoryItem.cpp:
684         (WebHistoryItem::dictionaryRepresentation):
685         (WebHistoryItem::redirectURLs):
686         * WebHistoryItem.h:
687
688 2009-01-29  Sam Weinig  <sam@webkit.org>
689
690         Reviewed by Mark Rowe.
691
692         First step in tracking the urls a HistoryItem was redirected through.
693
694         * WebHistoryItem.cpp:
695         (WebHistoryItem::initFromDictionaryRepresentation):
696         (WebHistoryItem::dictionaryRepresentation):
697
698 2009-01-29  Adam Roben  <aroben@apple.com>
699
700         Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
701         receives a WM_PRINTCLIENT message
702
703         <https://bugs.webkit.org/show_bug.cgi?id=23623>
704         <rdar://problem/6513921>
705         <rdar://problem/6536874>
706
707         Reviewed by Darin Adler.
708
709         * WebFrame.cpp:
710         (WebFrame::paintDocumentRectToContext):
711         (WebFrame::spoolPages):
712         Call GraphicsContext::setShouldIncludeChildWindows so that child
713         windows will be painted into the GraphicsContext rather than painted
714         directly to the screen.
715
716         * WebView.cpp:
717         (WebView::updateBackingStore): Added a windowsToPaint parameter, which
718         we pass along to paintIntoBackingStore.
719
720         (WebView::paint): Tell updateBackingStore to paint child windows if
721         we're not painting to the screen.
722
723         (WebView::paintIntoBackingStore): Added a windowsToPaint paramter,
724         which we use to tell our GraphicsContext whether or not to include
725         child windows.
726
727         * WebView.h: Added windowsToPaint parameters to paintIntoBackingStore
728         and updateBackingStore (which I also made private).
729
730 2009-01-29  Adam Roben  <aroben@apple.com>
731
732         Build fix after r40353
733
734         * WebCoreSupport/WebFrameLoaderClient.cpp:
735         (WebFrameLoaderClient::loadURLIntoChild): Removed the check for
736         FrameLoadTypeReloadAllowingStaleData.
737
738 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
739
740         Reviewed by Sam Weinig.
741
742         Updated for WebCore rename.
743         
744         * WebView.cpp:
745         (WebView::setCustomTextEncodingName):
746
747 2009-01-27  Brady Eidson  <beidson@apple.com>
748
749         Reviewed by Dan Bernstein
750
751         Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
752
753         * WebCoreSupport/WebFrameLoaderClient.cpp:
754         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
755         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
756         * WebCoreSupport/WebFrameLoaderClient.h:
757
758         * WebFrame.cpp:
759         * WebFrame.h:
760
761 2009-01-26  Adam Roben  <aroben@apple.com>
762
763         Fix an assertion failure when Safari loads an error page
764
765         Reviewed by Alexey Proskuryakov.
766
767         * WebFrame.cpp:
768         (WebFrame::loadData): Use the two-argument version of KURL and
769         MarshallingHelpers::BSTRToKURL, for reasons mentioned in r40248.
770
771 2009-01-26  Adam Roben  <aroben@apple.com>
772
773         Fix an assertion on launch in KURL::KURL
774
775         All URL strings passed in to the WebKit API need to be passed to
776         MarshallingHelpers::BSTRToKURL so that they may be properly parsed.
777
778         Reviewed by Alexey Proskuryakov.
779
780         * MarshallingHelpers.cpp:
781         (MarshallingHelpers::BSTRToKURL): Changed to use the two-argument
782         constructor for KURL so that the strings will be parsed rather than
783         assumed to be in the correct encoding/form.
784
785         * WebResource.cpp:
786         (WebResource::initWithData):
787         * WebURLResponse.cpp:
788         (WebURLResponse::initWithURL):
789         * WebView.cpp:
790         (WebView::userAgentForURL):
791         (WebView::copyURL):
792         Changed to use MarshallingHelpers::BSTRToKURL instead of trying to do
793         the work manually.
794
795 2009-01-25  Darin Adler  <darin@apple.com>
796
797         Try to fix Windows build.
798
799         * WebView.cpp: Added FloatQuad.h.
800
801 2009-01-23  Brent Fulgham  <bfulgham@webkit.org>
802
803         Reviewed by Darin Adler
804
805         https://bugs.webkit.org/show_bug.cgi?id=23492
806         Exclude calls to WebKitSystemInterface functions when not
807         using CoreGraphics.
808
809         * WebPreferences.cpp:
810         (WebPreferences::setFontSmoothing): 
811         (WebPreferences::setFontSmoothingContrast):
812         * WebTextRenderer.cpp:
813         (WebTextRenderer::registerPrivateFont):
814
815 2009-01-23  Brady Eidson  <beidson@apple.com>
816
817         Rubberstamped by Darin Adler
818
819         Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
820
821         * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
822         (WebCachedFramePlatformData::WebCachedFramePlatformData):
823         * WebCachedPagePlatformData.h: Removed.
824
825         * WebCoreSupport/WebFrameLoaderClient.cpp:
826         (WebFrameLoaderClient::savePlatformDataToCachedPage):
827
828         * WebKit.vcproj/WebKit.vcproj:
829
830 2009-01-22  Eric Roman  <eroman@chromium.org>
831
832         Reviewed by Eric Seidel.
833
834         https://bugs.webkit.org/show_bug.cgi?id=20806
835         Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
836
837         * WebHistoryItem.cpp:
838         (WebHistoryItem::RSSFeedReferrer):
839         (WebHistoryItem::setRSSFeedReferrer):
840
841 2009-01-19  Sam Weinig  <sam@webkit.org>
842
843         Rubber-stamped by Gavin Barraclough.
844
845         Remove temporary operator-> from JSValuePtr.
846
847         * WebScriptCallFrame.cpp:
848         (WebScriptCallFrame::jsValueToString):
849         * WebView.cpp:
850         (WebView::stringByEvaluatingJavaScriptFromString):
851
852 2009-01-19  Adam Roben  <aroben@apple.com>
853
854         Windows build fix
855
856         * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
857         individual using directives for each type we need from that namespace,
858         to avoid conflicts between DOMObject and WebCore::DOMObject.
859         (DOMElement::font): Added a now-needed WebCore::.
860
861 2009-01-17  Steve Falkenburg  <sfalken@apple.com>
862
863         Build fix.
864
865         * WebCoreSupport/WebDragClient.cpp:
866         (WebDragClient::createDragImageForLink):
867
868 2009-01-17  David Hyatt  <hyatt@apple.com>
869
870         Eliminate dependencies on backslashAsCurrencySymbol from WebKit.
871
872         Reviewed by Oliver Hunt
873
874         * WebFrame.cpp:
875         (WebFrame::selectedString):
876
877 2009-01-16  Steve Falkenburg  <sfalken@apple.com>
878
879         <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
880         
881         This was caused by mismatched ENABLE definitions across WebCore and WebKit.
882         
883         Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
884         In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
885         to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
886         Our Windows ENABLE flags now match Mac.
887         
888         Reviewed by Adele Peterson.
889
890         * WebKit.vcproj/WebKit.vcproj:
891
892 2009-01-15  Adele Peterson  <adele@apple.com>
893
894         Reviewed by Darin Adler.
895         
896         Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
897         <rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html
898         
899         Return S_OK or E_FAIL based on the result from CreateInstance.
900         This was causing DumpRenderTree to not realize it had just gotten a null documentElement.
901         
902         * DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent.
903         (DOMNode::parentNode):
904         (DOMNode::ownerDocument):
905         (DOMNodeList::item):
906         (DOMDocument::documentElement):
907         (DOMDocument::createElement):
908         (DOMDocument::getElementsByTagName):
909         (DOMDocument::getElementsByTagNameNS):
910         (DOMDocument::getElementById):
911         (DOMDocument::getComputedStyle):
912         (DOMDocument::createEvent):
913         (DOMElement::style):
914
915 2009-01-14  Adele Peterson  <adele@apple.com>
916
917         Reviewed by Darin Adler.
918
919         Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
920         <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
921         
922         Added artwork.
923         
924         * WebKit.vcproj/WebKit.rc:
925         * WebKit.vcproj/WebKit.vcproj:
926         * WebKit.vcproj/resource.h:
927         * WebKit.vcproj/searchCancel.png: Added.
928         * WebKit.vcproj/searchCancelPressed.png: Added.
929         * WebKit.vcproj/searchMagnifier.png: Added.
930         * WebKit.vcproj/searchMagnifierResults.png: Added.
931         * WebKitDLL.cpp:(loadResourceIntoBuffer):
932
933 2009-01-14  Dan Bernstein  <mitz@apple.com>
934
935         Reviewed by John Sullivan.
936
937         - update copyright
938
939         * WebKit.resources/Info.plist:
940         * WebKit.vcproj/WebKit.rc:
941
942 2009-01-13  Steve Falkenburg  <sfalken@apple.com>
943
944         Build fix.
945
946         * WebScriptCallFrame.cpp:
947         (WebScriptCallFrame::jsValueToString):
948
949 2009-01-12  Brady Eidson  <beidson@apple.com>
950
951         Reviewed by Dan Bernstein
952         
953         <rdar://problem/6490446> - Crash when going back to a cached page
954
955         * WebCoreSupport/WebFrameLoaderClient.cpp:
956         (WebFrameLoaderClient::savePlatformDataToCachedPage):  ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
957
958 2009-01-12  Brady Eidson  <beidson@apple.com>
959
960         Reviewed by Darin Adler
961
962         <rdar://problem/6468274> - Track Non-get requests in global history
963
964         * WebCoreSupport/WebFrameLoaderClient.cpp:
965         (WebFrameLoaderClient::updateGlobalHistory):
966
967         * WebHistory.cpp:
968         (WebHistory::addItem):
969         * WebHistory.h:
970
971         * Interfaces/IWebHistoryItemPrivate.idl:
972         * WebHistoryItem.cpp:
973         (WebHistoryItem::initFromDictionaryRepresentation):
974         (WebHistoryItem::dictionaryRepresentation):
975         (WebHistoryItem::lastVisitWasHTTPNonGet):
976         (WebHistoryItem::setLastVisitWasHTTPNonGet):
977         * WebHistoryItem.h:
978
979 2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
980
981         Reviewed by Darin Adler.
982
983         Bug 22861: Turn the FontCache into a singleton
984         https://bugs.webkit.org/show_bug.cgi?id=22861
985
986         * WebCoreStatistics.cpp:
987         (WebCoreStatistics::cachedFontDataCount):
988         (WebCoreStatistics::cachedFontDataInactiveCount):
989         (WebCoreStatistics::purgeInactiveFontData):
990         Redirected all the static calls to the global FontCache
991         instance.
992
993 2009-01-11  Dmitry Titov  <dimich@chromium.org>
994
995         Reviewed by Darin Adler.
996
997         https://bugs.webkit.org/show_bug.cgi?id=23207
998         Moved currentTime() to from WebCore to WTF.
999
1000         * WebDownload.cpp: a different header file included.
1001         * WebDropSource.cpp: a different header file included.
1002
1003 2009-01-09  Darin Adler  <darin@apple.com>
1004
1005         Reviewed by Jon Honeycutt.
1006
1007         Bug 22913: REGRESSION: Space bar doesn't scroll on windows
1008         https://bugs.webkit.org/show_bug.cgi?id=22913
1009         rdar://problem/6479834
1010
1011         * WebView.cpp:
1012         (WebView::keyPress): Removed code to handle space bar here; put it in
1013         WebCore instead.
1014
1015 2009-01-09  Brent Fulgham  <bfulgham@gmail.com>
1016
1017         Reviewed by Adam Roben.
1018
1019         Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
1020         Separate CFNetwork-specific code in WebKit.dll into separate
1021         implementation files. Create cURL stub files to be populated
1022         with new implementation in a future bug report. 
1023
1024         * WebCookieManager.cpp: Move CFNetwork-specific routines to
1025           the new WebCookieManagerCFNet.cpp file.
1026         (WebCookieManager::Release):
1027         * WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp.
1028         (WebCookieManager::cookieStorage):
1029         * WebCookieManagerCurl.cpp: Added.
1030         (WebCookieManager::cookieStorage):
1031         (WebCookieManager::setCookieStorage):
1032         * WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two
1033           methods in this file.
1034         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1035         (WebFrameLoaderClient::savePlatformDataToCachedPage):
1036         * WebDownload.cpp: Move CFNetwork-specific logic to the new
1037           WebDownloadCFNet.cpp
1038         (WebDownload::bundleExtension):
1039         (WebDownload::bundleMagicNumber):
1040         (WebDownload::bundlePathForTargetPath):
1041         (WebDownload::extractResumeDataFromBundle): Made static class method
1042           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
1043         (WebDownload::appendResumeDataToBundle): Made static class method
1044           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
1045         * WebDownload.h:
1046         * WebDownloadCFNet.cpp: Copied from WebDownload.cpp.
1047         (WebDownload::initToResumeWithBundle):
1048         (WebDownload::setDestination):
1049         (didFailCallback):
1050         * WebDownloadCurl.cpp: Added.
1051         (WebDownload::init):
1052         (WebDownload::initWithRequest):
1053         (WebDownload::initToResumeWithBundle):
1054         (WebDownload::start):
1055         (WebDownload::cancel):
1056         (WebDownload::cancelForResume):
1057         (WebDownload::deletesFileUponFailure):
1058         (WebDownload::setDeletesFileUponFailure):
1059         (WebDownload::setDestination):
1060         (WebDownload::cancelAuthenticationChallenge):
1061         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
1062         (WebDownload::useCredential):
1063         * WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the
1064           new cURL files. Modify Cairo targets to exclude CFNet files.
1065         * WebMutableURLRequest.cpp: Conditionalize the single method
1066           with a CFNetwork-speicic call.
1067         (WebMutableURLRequest::mutableCopy):
1068         * WebURLAuthenticationChallenge.cpp: Conditionalize one line that
1069           causes build problems for cURL. This will be removed later.
1070         (WebURLAuthenticationChallenge::initWithProtectionSpace):
1071         * WebURLAuthenticationChallengeSender.cpp:
1072         * WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp.
1073         (WebURLAuthenticationChallengeSender::useCredential):
1074         * WebURLAuthenticationChallengeSenderCurl.cpp: Added.
1075         (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
1076         (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
1077         (WebURLAuthenticationChallengeSender::useCredential):
1078         * WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling
1079           for the cURL target.
1080
1081 2009-01-09  Alexey Proskuryakov  <ap@webkit.org>
1082
1083         Reviewed by Darin Adler.
1084
1085         Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
1086
1087         * WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can
1088         raise exceptions, as needed for AppCache tests. I do not know why this error was not
1089         implemented.
1090
1091 2009-01-09  Darin Adler  <darin@apple.com>
1092
1093         Reviewed and landed by Adele Peterson.
1094
1095         Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
1096         https://bugs.webkit.org/show_bug.cgi?id=23160
1097
1098         * Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
1099         * WebView.cpp:
1100         (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
1101         * WebView.h: Ditto.
1102
1103 2009-01-08  Dan Bernstein  <mitz@apple.com>
1104
1105         Reviewed by Adam Roben.
1106
1107         - WebPreferences changes to support Core Graphics native glyph drawing
1108
1109         * Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast
1110         getter and setter.
1111         * WebPreferenceKeysPrivate.h: Added
1112         WebKitFontSmoothingContrastPreferenceKey.
1113         * WebPreferences.cpp:
1114         (WebPreferences::initializeDefaultSettings): Initialized
1115         WebKitFontSmoothingContrastPreferenceKey to 2.
1116         (WebPreferences::setFloatValue): Added.
1117         (WebPreferences::setFontSmoothing): Changed to map
1118         FontSmoothingTypeWindows to FontSmoothingTypeMedium.
1119         (WebPreferences::fontSmoothingContrast): Added.
1120         (WebPreferences::setFontSmoothingContrast): Added. Calls
1121         wkSetFontSmoothingContrast().
1122         * WebPreferences.h:
1123
1124 2009-01-08  Steve Falkenburg  <sfalken@apple.com>
1125
1126         <rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?
1127         
1128         Reviewed by Adam Roben.
1129
1130         * WebView.cpp:
1131         (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.
1132
1133 2009-01-07  Jon Honeycutt  <jhoneycutt@apple.com>
1134
1135         Fix a crash with querying a WebView for its global history item when
1136         its associated Page has no global history item.
1137
1138         Reviewed by Dan Bernstein.
1139
1140         * WebView.cpp:
1141         (WebView::globalHistoryItem): If the Page has no global history item,
1142         report 0.
1143
1144 2009-01-06  Adam Roben  <aroben@apple.com>
1145
1146         Fix Bug 22262: Clicking close ("X") button in docked Web Inspector
1147         clears Web Inspector but doesn't close it
1148
1149         <https://bugs.webkit.org/show_bug.cgi?id=22262>
1150         <rdar://problem/6371873>
1151
1152         Reviewed by Darin Adler.
1153
1154         * WebCoreSupport/WebInspectorClient.cpp:
1155         (WebInspectorClient::WebInspectorClient): Initialize new member.
1156         (WebInspectorClient::showWindow): Moved code from here to
1157         showWindowWithoutNotifications.
1158         (WebInspectorClient::closeWindow): Moved code from here to
1159         closeWindowWithoutNotifications.
1160
1161         (WebInspectorClient::attachWindow):
1162         (WebInspectorClient::detachWindow):
1163         Record whether or not we should be attached, then close and reopen the
1164         window without notifying the InspectorController. Code that was in
1165         these functions moved to showWindowWithoutNotifications and
1166         closeWindowWithoutNotifications, respectively.
1167
1168         (WebInspectorClient::closeWindowWithoutNotifications): Added. Code
1169         came from closeWindow and detachWindow.
1170         (WebInspectorClient::showWindowWithoutNotifications): Added. Code came
1171         from showWindow and attachWindow.
1172
1173         * WebCoreSupport/WebInspectorClient.h: Added
1174         {close,show}WindowWithoutNotifications and m_shouldAttachWhenShown.
1175
1176 2009-01-06  Anders Carlsson  <andersca@apple.com>
1177
1178         Reviewed by Sam Weinig.
1179
1180         Add a way for application to provide custom, full frame, views for certain MIME types.
1181         
1182         * Interfaces/IWebEmbeddedView.idl:
1183         Add loading related methods.
1184         
1185         * Interfaces/IWebViewPrivate.idl:
1186         Add new registerEmbeddedViewMIMEType method.
1187         
1188         * WebCoreSupport/EmbeddedWidget.cpp:
1189         (EmbeddedWidget::didReceiveResponse):
1190         (EmbeddedWidget::didReceiveData):
1191         (EmbeddedWidget::didFinishLoading):
1192         (EmbeddedWidget::didFail):
1193         Implement these and call the IEmbeddedView methods.
1194         
1195         * WebCoreSupport/EmbeddedWidget.h:
1196         Inherit from PluginManualLoader.
1197         
1198         * WebCoreSupport/WebFrameLoaderClient.cpp:
1199         (WebFrameLoaderClient::redirectDataToPlugin):
1200         Handle the case where the widget is an EnbeddedWidget.
1201         
1202         (WebFrameLoaderClient::shouldUsePluginDocument):
1203         Have this call WebView::shouldUseEmbeddedView.
1204         
1205         * WebView.cpp:
1206         (WebView::canShowMIMEType):
1207         Have this call WebView::shouldUseEmbeddedView.
1208         
1209         (WebView::registerEmbeddedViewMIMEType):
1210         Add the MIME type to the set.
1211         
1212         (WebView::shouldUseEmbeddedView):
1213         Given a MIME type, returns whether an embedded view should be used or not.
1214         
1215 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1216
1217         BUILD FIX (r39641): Try to fix WebIconDatabase build errors #4
1218
1219         * WebIconDatabase.cpp:
1220         (WebIconDatabase::isEnabled): Added 'WebIconDatabase::' to method
1221         signature.  (Another copy-paste error.)
1222         (WebIconDatabase::setEnabled): Ditto.
1223         * WebIconDatabase.h:
1224         (WebIconDatabase::startUpIconDatabase): Make private again.
1225         (WebIconDatabase::shutDownIconDatabase): Ditto.
1226
1227 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1228
1229         BUILD FIX (r39641): Try to fix build errors #3
1230
1231         Try to fix the following (more specific) build errors:
1232
1233             WebIconDatabase.cpp
1234             ..\WebIconDatabase.cpp(255) : error C2248: 'WebIconDatabase::shutDownIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1235                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1236                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1237             ..\WebIconDatabase.cpp(255) : error C2352: 'WebIconDatabase::shutDownIconDatabase' : illegal call of non-static member function
1238                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1239             ..\WebIconDatabase.cpp(258) : error C2248: 'WebIconDatabase::startUpIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1240                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1241                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1242             ..\WebIconDatabase.cpp(258) : error C2352: 'WebIconDatabase::startUpIconDatabase' : illegal call of non-static member function
1243                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1244
1245         * WebIconDatabase.cpp:
1246         (setEnabled): Get instance of shared WebIconDatabase, then call
1247         startUp/shutDown methods on it.
1248         * WebIconDatabase.h:
1249         (WebIconDatabase::startUpIconDatabase): Make protected again.
1250         (WebIconDatabase::shutDownIconDatabase): Ditto.
1251
1252 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1253
1254         BUILD FIX (r39641): Try to fix build errors again
1255
1256         Try to fix the following build errors:
1257
1258             WebIconDatabase.cpp
1259             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1260             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1261
1262         * WebIconDatabase.cpp:
1263         (setEnabled): Add class prefix to startUpIconDatabase() and
1264         shutDownIconDatabase().
1265         * WebIconDatabase.h:
1266         (WebIconDatabase::startUpIconDatabase): Make private again.
1267         (WebIconDatabase::shutDownIconDatabase): Ditto.
1268
1269 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1270
1271         BUILD FIX (r39641): Try to fix build error
1272
1273         Try to fix the following build errors:
1274
1275             WebIconDatabase.cpp
1276             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1277             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1278
1279         * WebIconDatabase.h:
1280         (WebIconDatabase::startUpIconDatabase): Make protected.
1281         (WebIconDatabase::shutDownIconDatabase): Ditto.
1282
1283 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1284
1285         BUILD FIX (r39641): Fix more silly errors
1286
1287         Fixes the following compilation errors:
1288
1289             WebIconDatabase.cpp
1290             ..\WebIconDatabase.cpp(85) : error C2065: 'standardPrefs' : undeclared identifier
1291             ..\WebIconDatabase.cpp(85) : error C2227: left of '->iconDatabaseLocation' must point to class/struct/union/generic type
1292                     type is ''unknown-type''
1293             ..\WebIconDatabase.cpp(241) : error C2575: 'isEnabled' : only member functions and bases can be virtual
1294             ..\WebIconDatabase.cpp(248) : error C2575: 'setEnabled' : only member functions and bases can be virtual
1295             ..\WebIconDatabase.cpp(253) : error C3861: 'shutDownIconDatabase': identifier not found
1296             ..\WebIconDatabase.cpp(256) : error C3861: 'startUpIconDatabase': identifier not found
1297
1298         * WebIconDatabase.cpp:
1299         (WebIconDatabase::startUpIconDatabase): Redeclare standardPrefs
1300         since this was in init() but not in this method after it was
1301         extracted from init().
1302         (isEnabled): Don't use "virtual" in method implementation
1303         (silly copy-paste error).
1304         (setEnabled): Ditto.
1305
1306 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1307
1308         BUILD FIX (r39641): Remove STDMETHODCALLTYPE from method declarations in IWebIconDatabase.idl
1309
1310         * Interfaces/IWebIconDatabase.idl: Removed "STDMETHODCALLTYPE"
1311         from silly copy-paste error in two method declarations.
1312
1313 2009-01-05  David Kilzer  <ddkilzer@apple.com>
1314
1315         Add API to enable, disable and check state of WebIconDatabase
1316
1317         Reviewed by Darin Adler & Timothy Hatcher.
1318
1319         Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
1320         API to make it possible to enable, disable and check the state of
1321         the icon database.
1322
1323         * Interfaces/IWebIconDatabase.idl: Declared isEnabled() and
1324         setEnabled() methods.
1325         * WebIconDatabase.cpp:
1326         (WebIconDatabase::init): Extracted code into startUpIconDatabase().
1327         (WebIconDatabase::startUpIconDatabase): Added.  Extracted from
1328         init().
1329         (WebIconDatabase::shutDownIconDatabase): Added.  Method is empty
1330         since there is nothing to do yet on Windows.
1331         (isEnabled): Added.
1332         (setEnabled): Added.
1333         * WebIconDatabase.h: Added method declarations.
1334
1335 2009-01-05  Anders Carlsson  <andersca@apple.com>
1336
1337         Reviewed by Jon Honeycutt.
1338
1339         Pass more information in the property bag passed to embeddedViewWithArguments.
1340         
1341         * Interfaces/IWebUIDelegatePrivate.idl:
1342         Declare new keys.
1343         
1344         * WebCoreSupport/WebFrameLoaderClient.cpp:
1345         (WebFrameLoaderClient::createPlugin):
1346         Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.
1347
1348 2009-01-05  Anders Carlsson  <andersca@apple.com>
1349
1350         Reviewed by Darin Adler, Jon Honeycutt.
1351
1352         Add a templatized COMVariant constructor so we can make COMVariants out of
1353         everything that has a COMVariantSetter specialization.
1354         
1355         Add a COMVariantSetter specialization for COMVariant.
1356         
1357         * COMVariantSetter.h:
1358         (COMVariant::COMVariant):
1359
1360 2009-01-05  Brent Fulgham  <bfulgham@gmail.com>
1361
1362         Reviewed by Oliver Hunt.
1363
1364         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23027
1365
1366         Removes the WebKitGraphics files from the Cairo build, as well
1367         as excluding their link definitions.  These are not used outside
1368         of Safari, and should not be part of the 'Redistributable API.'
1369
1370         * WebKit.vcproj/WebKit.vcproj:  Update *_Cairo targets to exclude
1371           the WebKitGraphics.cpp/.h files.
1372         * WebKit.vcproj/WebKit_Cairo.def: Added.  File without Safari
1373           link definitions.
1374         * WebKit.vcproj/WebKit_Cairo_debug.def: Added.  File without Safari
1375           link definitions.
1376
1377 2009-01-05  Anders Carlsson  <andersca@apple.com>
1378
1379         Reviewed by Jon Honeycutt.
1380
1381         Add a simple, memory managed, wrapper around a VARIANT struuct.
1382         
1383         * COMVariantSetter.h:
1384         (COMVariant::COMVariant):
1385         (COMVariant::~COMVariant):
1386         (COMVariant::operator=):
1387         (COMVariant::copyTo):
1388         (COMVariant::variantType):
1389
1390 2009-01-05  Adele Peterson  <adele@apple.com>
1391
1392         Windows build fix.
1393
1394         * WebCoreSupport/WebChromeClient.cpp:
1395
1396 2009-01-05  Anders Carlsson  <andersca@apple.com>
1397
1398         Reviewed by Adam Roben.
1399
1400         Make it possible to have per value variant types.
1401         
1402         * COMPropertyBag.h:
1403         (::Read):
1404         Call variantType here, passing in the value.
1405         
1406         (::GetPropertyInfo):
1407         Ditto.
1408         
1409         * COMVariantSetter.h:
1410         (COMVariantSetterBase::variantType):
1411         Add COMVariantSetterBase, whose variantType implementation just returns the
1412         VariantType variable. Make all existing classes inherit from COMVariantSetterBase.
1413
1414 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
1415
1416         Fix win build
1417
1418         * WebCoreSupport/WebChromeClient.h:
1419
1420 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
1421
1422         Reviewed by George Staikos.
1423
1424         Build fix for contentsSizeChanged
1425
1426         * WebCoreSupport/WebChromeClient.cpp:
1427         (WebChromeClient::contentsSizeChanged):
1428         * WebCoreSupport/WebChromeClient.h:
1429
1430 2009-01-05  Anders Carlsson  <andersca@apple.com> 
1431
1432         Reviewed by Kevin Decker.
1433
1434         Use the ManualLoader class instead of assuming that the manual loader
1435         is a plug-in view.
1436         
1437         * WebCoreSupport/WebFrameLoaderClient.cpp:
1438         (WebFrameLoaderClient::WebFrameLoaderClient):
1439         (WebFrameLoaderClient::setMainDocumentError):
1440         (WebFrameLoaderClient::committedLoad):
1441         (WebFrameLoaderClient::finishedLoading):
1442         (WebFrameLoaderClient::redirectDataToPlugin):
1443         * WebCoreSupport/WebFrameLoaderClient.h:
1444
1445 2009-01-04  Adam Treat  <adam.treat@torchmobile.com>
1446
1447         Reviewed by George Staikos.
1448
1449         Make the apple windows port build with the new fixedLayoutSize feature
1450
1451         * WebCoreSupport/WebFrameLoaderClient.cpp:
1452         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1453
1454 2008-12-20  Dan Bernstein  <mitz@apple.com>
1455
1456         Reviewed by Ada Chan.
1457
1458         - expose the new allItems() method via a new IWebHistoryPrivate
1459           interface
1460
1461         * Interfaces/IWebHistoryPrivate.idl: Added.
1462         * Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
1463         * WebHistory.cpp:
1464         (WebHistory::QueryInterface): Added IWebHistoryPrivate.
1465         (WebHistory::allItems):
1466         * WebHistory.h:
1467
1468 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
1469
1470         Build fix.
1471
1472         * WebHistory.cpp:
1473         (WebHistory::allItems):
1474
1475 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
1476
1477         Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
1478         
1479         Added SPI for getting an unsorted vector of all items in history.
1480         
1481         * WebHistory.cpp:
1482         (WebHistory::orderedItemsLastVisitedOnDay):
1483         (WebHistory::allItems):
1484         * WebHistory.h:
1485
1486 2008-12-18  Dan Bernstein  <mitz@apple.com>
1487
1488         Reviewed by Sam Weinig.
1489
1490         - implement FrameLoaderClient::shouldUseCredentialStorage() by calling
1491           a new resource load delegae method.
1492
1493         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added
1494         a ne interface, IWebResourceLoadDelegatePrivate2, including a new
1495         method, shouldUseCredentialStorage().
1496         * WebCoreSupport/WebFrameLoaderClient.cpp:
1497         (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the
1498         delegate method. If the method is unimplemented, returns true for
1499         backwards compatibility.
1500         * WebCoreSupport/WebFrameLoaderClient.h:
1501
1502 2008-12-18  Sam Weinig  <sam@webkit.org>
1503
1504         Reviewed by John Sullivan.
1505
1506         Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
1507         a new private frame load delegate method.
1508
1509         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
1510         * WebCoreSupport/WebFrameLoaderClient.cpp:
1511         (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
1512         * WebCoreSupport/WebFrameLoaderClient.h:
1513
1514 2008-12-16  Steve Falkenburg  <sfalken@apple.com>
1515
1516         Windows build fix.
1517         
1518         Reviewed by Stephanie Lewis.
1519
1520         * COMPropertyBag.h:
1521         (::createInstance):
1522         (::adopt):
1523         (::QueryInterface):
1524         (::AddRef):
1525         (::Release):
1526         (::Read):
1527         (::Write):
1528         (::CountProperties):
1529         (::GetPropertyInfo):
1530         (::LoadObject):
1531         * WebURLResponse.cpp:
1532         (WebURLResponse::allHeaderFields):
1533
1534 2008-12-16  Stephanie Lewis  <slewis@apple.com>
1535
1536         Another Windows Build Fix.
1537
1538         * WebURLResponse.cpp:
1539         (WebURLResponse::allHeaderFields):
1540
1541 2008-12-14  Dan Bernstein  <mitz@apple.com>
1542
1543         Reviewed by Darin Adler.
1544
1545         - Windows equivalent of <rdar://problem/3258561>
1546           WebHistoryAllItemsRemovedNotification should add items to userInfo
1547
1548         * WebHistory.cpp:
1549         (WebHistory::removeAllItems): Changed to create an array of all items
1550         and send it in the notification.
1551
1552 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
1553
1554         Reviewed by Oliver Hunt.
1555
1556         Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
1557
1558         Provides implementation of image drag for Windows Cairo back-end.
1559         Switch to generic PlatformGraphicsContext data type, rather than
1560         specific use of CoreGraphics types.
1561
1562         * WebCoreSupport/WebDragClient.cpp:
1563         (WebDragClient::createDragImageForLink): Revise calls to use more
1564         generic PlatformGraphicsContext data types and calls for better
1565         portability.
1566
1567 2008-12-12  Steve Falkenburg  <sfalken@apple.com>
1568
1569         Update Windows cache sizes to match recent Mac change.
1570         
1571         Reviewed by Stephanie Lewis, Sam Weinig.
1572
1573         * WebView.cpp:
1574         (WebView::setCacheModel):
1575
1576 2008-12-12  Tor Arne Vestbø  <tavestbo@trolltech.com>
1577
1578         Rubber-stamped by Oliver Hunt.
1579
1580         Remove mutables from EmbeddedWidget
1581
1582         We can do this now that frameRectsChanged() is no longer const
1583
1584         * WebCoreSupport/EmbeddedWidget.h:
1585
1586 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
1587
1588         Rubber-stamped by Mark Rowe.
1589
1590         Roll out r39212 due to assertion failures during layout tests, multiple
1591         layout test failures, memory leaks, and obvious incorrectness.
1592
1593         * Interfaces/IWebPreferencesPrivate.idl:
1594         * WebPreferenceKeysPrivate.h:
1595         * WebPreferences.cpp:
1596         * WebPreferences.h:
1597
1598 2008-12-10  Glenn Wilson  <gwilson@google.com>
1599
1600         Reviewed by Adam Roben.
1601
1602         Added support for overriding default preferences per-test.
1603         https://bugs.webkit.org/show_bug.cgi?id=20534
1604         Two new methods were added: resetToDefaults and overridePreference.
1605
1606         * Interfaces/IWebPreferencesPrivate.idl: new method signatures
1607         * WebPreferenceKeysPrivate.h: added new key for internal state
1608         * WebPreferences.cpp: added new methods
1609         (WebPreferences::overridePreference): new method
1610         (WebPreferences::resetToDefaults): new method
1611         * WebPreferences.h: new method signatures
1612
1613 2008-12-08  Tor Arne Vestbø  <tavestbo@trolltech.com>
1614
1615         Reviewed by Darin Adler and Holger Freyther.
1616
1617         Make Widget::frameRectsChanged() and overrides non-const
1618
1619         This will hopefully allow us to get rid of some of the mutables in
1620         the classes that react to the callback by changing their own state.
1621
1622         * WebCoreSupport/EmbeddedWidget.cpp:
1623         (EmbeddedWidget::frameRectsChanged):
1624         * WebCoreSupport/EmbeddedWidget.h:
1625
1626 2008-12-09  Brett Wilson  <brettw@chromium.org>
1627
1628         Reviewed by Dave Hyatt.
1629
1630         https://bugs.webkit.org/show_bug.cgi?id=22177
1631
1632         Add a callback on ChromeClient that the state of form elements on
1633         the page has changed. This is to allow clients implementing session
1634         saving to know when the current state is dirty.
1635
1636         * WebCoreSupport/WebChromeClient.h:
1637         (WebChromeClient::formStateDidChange):
1638
1639 ks2008-12-08  Dan Bernstein  <mitz@apple.com>
1640
1641         Reviewed by Adam Roben.
1642
1643         - Fix nightly builds
1644
1645         * Interfaces/IWebViewPrivate.idl: Moved globalHistoryItem() to the end,
1646         so that it comes after all methods used by Safari 3.2.1.
1647
1648 2008-12-08  Dan Bernstein  <mitz@apple.com>
1649
1650         Reviewed by John Sullivan.
1651
1652         - WebKit/win part of tracking the global history item for a WebView
1653
1654         * Interfaces/IWebViewPrivate.idl: Declared globalHistoryItem()
1655         * WebView.cpp:
1656         (WebView::globalHistoryItem): Added. Gets the page's global history
1657         item.
1658         * WebView.h:
1659
1660 2008-12-06  Simon Fraser  <simon.fraser@apple.com>
1661
1662         Reviewed by Dave Hyatt
1663
1664         https://bugs.webkit.org/show_bug.cgi?id=15671
1665
1666         Renderer::caretRect() is now localCaretRect(), which needs
1667         converting to absolute coordinates (taking transforms into account).
1668
1669         * WebView.cpp:
1670         (WebView::handleContextMenuEvent):
1671
1672 2008-12-05  Darin Adler  <darin@apple.com>
1673
1674         Reviewed by Alexey Proskuryakov.
1675
1676         - fix https://bugs.webkit.org/show_bug.cgi?id=22674
1677           Webkit r39005 does not start, an entry point not found
1678
1679         * WebView.cpp:
1680         (findCFNetworkModule): Added.
1681         (findCopySharedURLCacheFunction): Added.
1682         (WebView::setCacheModel): Call CFURLCacheCopySharedURLCache via dynamic loading
1683         instead of compiling based on which version of CFNetwork headers are present.
1684
1685 2008-12-04  Steve Falkenburg  <sfalken@apple.com>
1686
1687         Implement IPropertyBag2::Read.
1688         Fill in dwType for IPropertyBag2::GetPropertyInfo (we always use PROPBAG2_TYPE_DATA).
1689         https://bugs.webkit.org/show_bug.cgi?id=22659
1690         
1691         This fixes <rdar://problem/6419127> REGRESSION: Forms autocomplete is broken for "other forms"
1692         
1693         Reviewed by Ada Chan, Alice Liu.
1694
1695         * COMPropertyBag.h:
1696         (::Read): Implemented.
1697         (::GetPropertyInfo): Set dwType to PROPBAG2_TYPE_DATA.
1698
1699 2008-12-02  Adam Roben  <aroben@apple.com>
1700
1701         Export new-ish JSCore convenience constructor functions
1702
1703         Reviewed by Jon Honeycutt.
1704
1705         * WebKit.vcproj/WebKit.def:
1706         * WebKit.vcproj/WebKit_debug.def:
1707         Export JSObjectMakeArray, JSObjectMakeDate, and JSObjectMakeRegExp.
1708         Remove duplicate export of JSObjectMakeFunction.
1709
1710 2008-12-02  Michael Moss  <mmoss@chromium.org>
1711
1712         Reviewed by Eric Seidel.
1713
1714         - Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
1715         https://bugs.webkit.org/show_bug.cgi?id=20926
1716
1717         Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.
1718
1719         * WebCoreSupport/WebFrameLoaderClient.cpp:
1720         (WebFrameLoaderClient::loadURLIntoChild):
1721
1722 2008-12-01  Steve Falkenburg  <sfalken@apple.com>
1723
1724         Implement renderedImage for Windows.
1725         https://bugs.webkit.org/show_bug.cgi?25648
1726         
1727         Reviewed by Adam Roben.
1728
1729         * DOMCoreClasses.cpp:
1730         (DOMElement::renderedImage):
1731         * DOMCoreClasses.h:
1732         * Interfaces/DOMPrivate.idl:
1733
1734 2008-12-01  Eric Seidel  <eric@webkit.org>
1735
1736         Reviewed by Adam Roben.
1737
1738         NULL-check documentFrameView() and topDocumentFrameView() it's possible
1739         for either of these methods to return NULL, and this was seen to cause
1740         crashes in Chromium.
1741         https://bugs.webkit.org/show_bug.cgi?id=22572
1742
1743         * AccessibleBase.cpp:
1744         (AccessibleBase::get_accParent):
1745         (AccessibleBase::accLocation):
1746         (AccessibleBase::accHitTest):
1747
1748 2008-11-30  Antti Koivisto  <antti@apple.com>
1749
1750         Another Windows build fix.
1751
1752         * WebCoreStatistics.cpp:
1753         (WebCoreStatistics::javaScriptObjectsCount):
1754
1755 2008-11-30  Antti Koivisto  <antti@apple.com>
1756
1757         Windows build fix.
1758
1759         * WebJavaScriptCollector.cpp:
1760         (WebJavaScriptCollector::objectCount):
1761
1762 2008-11-29  Brent Fulgham  <bfulgham@gmail.com>
1763
1764         Reviewed by Alexey Proskuryakov.
1765
1766         Remove Visual Studio project dependencies on non-redistributable
1767         components in the Debug_Cairo and Release_Cairo build targets.
1768         See https://bugs.webkit.org/show_bug.cgi?id=22527
1769
1770         * WebKit.vcproj/WebKit.vcproj:
1771         * WebKit.vcproj/WebKit.sln: Instruct Cairo builds to not bother
1772           building the unused QuickTime support library.
1773
1774 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
1775
1776         Reviewed by Alexey Proskuryakov.
1777
1778         http://bugs.webkit.org/show_bug.cgi?id=15643
1779
1780         Added API support for the "trailing whitespace" work-around.  This includes an APIs
1781         to get and set the state of this configuration variable.
1782
1783         * Interfaces/IWebView.idl:
1784         * WebCoreSupport/WebEditorClient.cpp:
1785         (WebEditorClient::selectTrailingWhitespaceEnabled):
1786         * WebCoreSupport/WebEditorClient.h:
1787         * WebView.cpp:
1788         (WebView::WebView):
1789         (WebView::setSelectTrailingWhitespaceEnabled):
1790         (WebView::selectTrailingWhitespaceEnabled):
1791         * WebView.h:
1792
1793 2008-11-24  Darin Adler  <darin@apple.com>
1794
1795         Reviewed by Dan Bernstein.
1796
1797         - https://bugs.webkit.org/show_bug.cgi?id=22470
1798           remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
1799
1800         * WebCoreSupport/WebFrameLoaderClient.cpp:
1801         (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the
1802         DocumentLoader, just as we do the title and the failure flag.
1803         * WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
1804
1805 2008-11-24  Darin Adler  <darin@apple.com>
1806
1807         Reviewed by Dan Bernstein.
1808
1809         - finish https://bugs.webkit.org/show_bug.cgi?id=22295
1810           track which history items are from page load failures
1811
1812         Last time around I did this only for the back/forward list and missed the
1813         global history list.
1814
1815         * Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
1816
1817         * WebCoreSupport/WebFrameLoaderClient.cpp:
1818         (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure
1819         and pass the argument in to WebHistory.
1820
1821         * WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument.
1822         Set the flag on the newly created history item.
1823         * WebHistory.h: Ditto.
1824
1825         * WebHistoryItem.cpp:
1826         (WebHistoryItem::setLastVisitWasFailure): Added.
1827         * WebHistoryItem.h: Ditto.
1828
1829 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
1830
1831         Fix call to Frame::selectionBounds in Windows build.
1832
1833         * WebView.cpp:
1834         (WebView::selectionRect):
1835
1836 2008-11-21  Dimitri Glazkov  <dglazkov@chromium.org>
1837
1838         Reviewed by Alexey Proskuryakov.
1839
1840         Debug WebKit crashes on launch because of threading not being initialized early enough.
1841
1842         * WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory):
1843         Call JSC::InitializeThreading().
1844
1845 2008-11-19  Darin Fisher  <darin@chromium.org>
1846
1847         Reviewed by Geoff Garen.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=22345
1850         Define ScriptValue as a thin container for a JSC::Value*.
1851
1852         * WebView.cpp:
1853         (WebView::stringByEvaluatingJavaScriptFromString):
1854
1855 2008-11-19  Adele Peterson  <adele@apple.com>
1856
1857         Reviewed by Darin Adler.
1858
1859         For transparent views, clear the dirty rect instead of painting it white.
1860         
1861         * WebView.cpp: (WebView::paintIntoBackingStore):
1862
1863 2008-11-18  Adele Peterson  <adele@apple.com>
1864
1865         Reverting last change.  I just realized it causes the view to never get cleared out.
1866
1867         * WebView.cpp: (WebView::paintIntoBackingStore):
1868
1869 2008-11-18  Adele Peterson  <adele@apple.com>
1870
1871         Reviewed by John Sullivan.
1872
1873         Don't fill the view with white if its transparent.
1874         
1875         * WebView.cpp: (WebView::paintIntoBackingStore):
1876
1877 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1878
1879         Try to fix the Windows build. It is view and not webView.
1880
1881         * WebCoreSupport/WebFrameLoaderClient.cpp:
1882         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1883
1884 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1885
1886         Reviewed by Simon Hausmann.
1887
1888         Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
1889
1890         After Hyatt's work on Widget and ScrollView there is little difference
1891         between the implementation of Qt, Gtk+ and Win. In fact any kind of
1892         difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
1893         port and the Qt port has at least one of them left.
1894
1895         The only difference between the implementations is in getting the the
1896         IntSize for the new FrameView, the background color to be applied and
1897         eventually some post processing.
1898
1899         Unify the implementations by providing a static helper function that
1900         takes a Frame, IntSize, color and transparency bit and calling it from
1901         the Gtk+, the Qt and the Windows port.
1902
1903         * WebCoreSupport/WebFrameLoaderClient.cpp:
1904         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1905
1906 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1907
1908         Reviewed by Simon Hausmann.
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=22056
1911
1912         Move setting the background color and transparency from WebKit/win
1913         to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
1914         to share this code.
1915
1916         * WebFrame.cpp:
1917         (WebFrame::updateBackground):
1918
1919 2008-11-16  Geoffrey Garen  <ggaren@apple.com>
1920
1921         Not reviewed.
1922         
1923         Try to fix Windows build.
1924
1925         * WebCoreSupport/WebFrameLoaderClient.cpp:
1926
1927 2008-11-16  Darin Adler  <darin@apple.com>
1928
1929         Reviewed by Dan Bernstein.
1930
1931         - https://bugs.webkit.org/show_bug.cgi?id=22295
1932           track which history items are from page load failures
1933
1934         * Interfaces/IWebHistoryItemPrivate.idl: Added lastVisitWasFailure function.
1935
1936         * WebHistoryItem.cpp:
1937         (WebHistoryItem::initFromDictionaryRepresentation): Set the lastVisitWasFailure
1938         flag in the history item if the dictionary had an entry for lastVisitWasFailureKey.
1939         (WebHistoryItem::dictionaryRepresentation): Set the lastVisitWasFailureKey key
1940         in the dictionary if the history item had the lastVisitWasFailure flag.
1941         (WebHistoryItem::lastVisitWasFailure): Added.
1942
1943         * WebHistoryItem.h: Added lastVisitWasFailure function.
1944
1945 2008-11-15  Geoffrey Garen  <ggaren@apple.com>
1946
1947         Reviewed by Sam Weinig.
1948         
1949         Updated for JavaScriptCore renames.
1950
1951         * WebScriptCallFrame.cpp:
1952         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
1953
1954 2008-11-14  Dan Bernstein  <mitz@apple.com>
1955
1956         - try to fix the Windows build
1957
1958         * WebCoreLocalizedStrings.cpp:
1959         (WebCore::contextMenuItemTagTextDirectionMenu): Added.
1960
1961 2008-11-13  Adam Roben  <aroben@apple.com>
1962
1963         Fix Bug 22244: Webkit nightly builds crash with Safari 3.2
1964
1965         <https://bugs.webkit.org/show_bug.cgi?id=22244>
1966
1967         r36652 added IWebViewPrivate::clearMainFrameName into the middle of
1968         the IWebViewPrivate interface, which modifies the part of the
1969         IWebViewPrivate vtable that Safari 3.2 relies on.
1970
1971         Reviewed by Dan Bernstein.
1972
1973         * Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end
1974         of the interface.
1975
1976 2008-11-11  Dan Bernstein  <mitz@apple.com>
1977
1978         Reviewed by Adam Roben.
1979
1980         WebKit/win part of adding a master volume control for media elements in a WebView
1981         * Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and
1982         mediaVolume().
1983         * WebView.cpp:
1984         (WebView::setMediaVolume): Added.
1985         (WebView::mediaVolume): Added.
1986         * WebView.h:
1987
1988 2008-11-10  Adam Roben  <aroben@apple.com>
1989
1990         Fix Bug 22158: Would like to turn on WebCore logging channels via an
1991         environment variable
1992
1993         <https://bugs.webkit.org/show_bug.cgi?id=22158>
1994
1995         Reviewed by Anders Carlsson.
1996
1997         * WebView.cpp:
1998         (WebView::initWithFrame): Call WebCore's
1999         InitializeLoggingChannelsIfNecessary.
2000
2001 2008-11-08  Dan Bernstein  <mitz@apple.com>
2002
2003         Reviewed by Darin Adler.
2004
2005         - WebKit/win part of adding WebPreferences for controlling databases and local storage
2006
2007         * Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled,
2008         databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
2009         * WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey
2010         and WebKitLocalStorageEnabledPreferenceKey.
2011         * WebPreferences.cpp:
2012         (WebPreferences::initializeDefaultSettings): Made databases and local
2013         storage enabled by default.
2014         (WebPreferences::setDatabasesEnabled): Added.
2015         (WebPreferences::databasesEnabled): Added.
2016         (WebPreferences::setLocalStorageEnabled): Added.
2017         (WebPreferences::localStorageEnabled): Added.
2018         * WebPreferences.h:
2019         * WebView.cpp:
2020         (WebView::notifyPreferencesChanged): Transfer the databases and local
2021         storage preferences to WebCore settings.
2022
2023 2008-11-06  John Sullivan  <sullivan@apple.com>
2024     
2025         Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.
2026     
2027         Reviewed by Adam Roben
2028
2029         * WebView.h:
2030         removed m_zoomMultiplierIsTextOnly
2031         
2032         * WebView.cpp:
2033         (WebView::WebView):
2034         removed initialization of m_zoomMultiplierIsTextOnly
2035         (WebView::setZoomMultiplier):
2036         use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly
2037         (WebView::zoomMultiplier):
2038         use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
2039
2040 2008-11-06  Adele Peterson  <adele@apple.com>
2041
2042         Reviewed by Adam Roben.
2043
2044         Add support for a WebKitZoomsTextOnly preference.
2045
2046         * Interfaces/IWebPreferences.idl:
2047         * WebPreferenceKeysPrivate.h:
2048         * WebPreferences.cpp:
2049         (WebPreferences::setZoomsTextOnly):
2050         (WebPreferences::zoomsTextOnly):
2051         * WebPreferences.h:
2052
2053         * WebView.cpp:
2054         (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this.
2055         (WebView::makeTextLarger): ditto.
2056         (WebView::canMakeTextSmaller): ditto.
2057         (WebView::makeTextSmaller): ditto.
2058         (WebView::canMakeTextStandardSize): 
2059         Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting.
2060         (WebView::makeTextStandardSize):
2061         (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
2062
2063 2008-11-05  Dan Bernstein  <mitz@apple.com>
2064
2065         Reviewed by John Sullivan.
2066
2067         - make the {protocol,proxyType} argument of
2068           WebURLProtectionSpace::initWith{Proxy}Host actually work and fix
2069           assertion failures.
2070
2071         * WebURLProtectionSpace.cpp:
2072         (WebURLProtectionSpace::initWithHost): The BString comparisons were
2073         applying the BString==BSTR operator to a right hand side that was
2074         actually a WCHAR string. Fixed by using BStrings on both sides.
2075         (WebURLProtectionSpace::initWithProxyHost): Ditto.
2076
2077 2008-11-01  Alexey Proskuryakov  <ap@webkit.org>
2078
2079         Reviewed by Darin Adler.
2080
2081         https://bugs.webkit.org/show_bug.cgi?id=22030
2082         Make EventNames usable from multiple threads
2083
2084         * WebView.cpp: (WebView::interpretKeyEvent): Access event names via eventNames() function.
2085
2086 2008-11-03  Cameron Zwarich  <zwarich@apple.com>
2087
2088         Rubber-stamped by Maciej Stachowiak.
2089
2090         Move more files into the runtime subdirectory of JavaScriptCore.
2091
2092         * WebJavaScriptCollector.cpp:
2093
2094 2008-11-03  Dan Bernstein  <mitz@apple.com>
2095
2096         Reviewed by Steve Falkenburg.
2097
2098         - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
2099         - add and implement WebMutableURLRequest::mutableCopy()
2100
2101         * Interfaces/IWebURLRequest.idl:
2102         * WebMutableURLRequest.cpp:
2103         (WebMutableURLRequest::setHTTPShouldHandleCookies):
2104         (WebMutableURLRequest::mutableCopy):
2105         * WebMutableURLRequest.h:
2106
2107 2008-10-31  Dan Bernstein  <mitz@apple.com>
2108
2109         Reviewed by John Sullivan.
2110
2111         - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
2112
2113         * Interfaces/IWebViewPrivate.idl:
2114         * WebView.cpp:
2115         (WebView::setCookieEnabled):
2116         (WebView::cookieEnabled):
2117         * WebView.h:
2118
2119 2008-10-31  Adele Peterson  <adele@apple.com>
2120
2121         Reviewed by Darin Adler.
2122
2123         WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
2124         https://bugs.webkit.org/show_bug.cgi?id=22008
2125         
2126         * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): 
2127         Add support for mulitple file selection.
2128
2129 2008-10-31  Darin Adler  <darin@apple.com>
2130
2131         - try to fix build
2132
2133         * WebView.cpp:
2134         (WebView::setCacheModel): Roll out the part of my last change
2135         that involved no longer using wkCopyFoundationCacheDirectory.
2136
2137 2008-10-30  Darin Adler  <darin@apple.com>
2138
2139         Reviewed by Sam Weinig.
2140
2141         - https://bugs.webkit.org/show_bug.cgi?id=21986
2142           <rdar://problem/6294285> adopt CFURLCopySharedURLCache
2143
2144         * WebView.cpp:
2145         (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.
2146
2147 2008-10-30  Dan Bernstein  <mitz@apple.com>
2148
2149         Reviewed by Sam Weinig.
2150
2151         - export WTFReportAssertionFailureWithMessage()
2152
2153         * WebKit.vcproj/WebKit_debug.def:
2154
2155 2008-10-29  Steve Falkenburg  <sfalken@apple.com>
2156
2157         <rdar://problem/6326563> Crash on launch
2158         
2159         For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
2160         
2161         Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
2162         callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
2163         the explicit lock/unlock functions, we can avoid this.
2164         
2165         Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
2166         
2167         Reviewed by Darin Adler.
2168
2169         * WebKit.vcproj/WebKit.def:
2170         * WebKit.vcproj/WebKit_debug.def:
2171
2172 2008-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2173
2174         Export atomicallyInitializedStaticMutex.
2175
2176         Rubber-stamped by Steve Falkenburg.
2177
2178         * WebKit.vcproj/WebKit.def:
2179         * WebKit.vcproj/WebKit_debug.def:
2180
2181 2008-10-28  Cameron Zwarich  <zwarich@apple.com>
2182
2183         Reviewed by Mark Rowe.
2184
2185         Move ForwardingHeaders to their correct location after the creation of
2186         the runtime directory in JavaScriptCore.
2187
2188         * WebScriptCallFrame.h:
2189
2190 2008-10-28  Adele Peterson  <adele@apple.com>
2191
2192         Reviewed by John Sullivan.
2193
2194         Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
2195         "files" string for multifile uploads needs to be localized
2196
2197         * WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
2198
2199 2008-10-28  Adele Peterson  <adele@apple.com>
2200
2201         Reviewed by Sam Weinig. 
2202
2203         * English.lproj: Removed.
2204         * English.lproj/Localizable.strings: Removed.
2205         * WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.
2206
2207 2008-10-28  Timothy Hatcher  <timothy@apple.com>
2208
2209         Add IWebInspector methods to enable the profiler.
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=21927
2212
2213         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
2214         not slow down JavaScript all the time
2215
2216         Reviewed by Darin Adler and Kevin McCullough.
2217
2218         * WebInspector.cpp:
2219         (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
2220         (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
2221         or enableProfiler methods.
2222         * WebInspector.h:
2223
2224 2008-10-27  Timothy Hatcher  <timothy@apple.com>
2225
2226         Rename a few methods related to attaching and detaching the debugger.
2227
2228         * Rename attachDebugger to enableDebugger.
2229         * Rename detachDebugger to disableDebugger.
2230         * Rename the debuggerAttached getter to debuggerEnabled.
2231
2232         Reviewed by Darin Adler.
2233
2234         * WebInspector.cpp:
2235         (WebInspector::isDebuggingJavaScript):
2236         (WebInspector::toggleDebuggingJavaScript):
2237
2238 2008-10-24  Sam Weinig  <sam@webkit.org>
2239
2240         Yet another windows build fix.
2241
2242         * WebCoreSupport/WebChromeClient.cpp:
2243
2244 2008-10-24  Sam Weinig  <sam@webkit.org>
2245
2246         Another windows build fix.
2247
2248         * WebCoreSupport/WebChromeClient.cpp:
2249
2250 2008-10-24  Sam Weinig  <sam@webkit.org>
2251
2252         Reviewed by Dan Bernstein.
2253
2254         Fix https://bugs.webkit.org/show_bug.cgi?id=21759
2255         Layering violation: FileChooser should not depend on Document/Frame/Page
2256
2257         * WebCoreSupport/WebChromeClient.cpp:
2258         (WebChromeClient::runOpenPanel):
2259         * WebCoreSupport/WebChromeClient.h:
2260
2261 2008-10-24  Timothy Hatcher  <timothy@apple.com>
2262
2263         Implement new InspectorClient methods to work with Settings.
2264
2265         https://bugs.webkit.org/show_bug.cgi?id=21856
2266
2267         Reviewed by Adam Roben.
2268
2269         * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
2270         * WebCoreSupport/WebInspectorClient.h: Add the new methods.
2271
2272 2008-10-24  Darin Adler  <darin@apple.com>
2273
2274         - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
2275
2276         * WebScriptCallFrame.cpp:
2277         (WebScriptCallFrame::jsValueToString):
2278         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
2279         (WebScriptCallFrame::valueForVariable):
2280         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
2281         * WebScriptCallFrame.h:
2282         * WebView.cpp:
2283         (WebView::stringByEvaluatingJavaScriptFromString):
2284         Use JSValue* instead of JSValuePtr.
2285
2286 2008-10-22  Brent Fulgham  <bfulgham@gmail.com>
2287
2288         Correct build regressions in Cairo port for Windows.
2289         http://bugs.webkit.org/show_bug.cgi?id=21724
2290
2291         Reviewed by Adam Roben.
2292
2293         * WebView.cpp:
2294         (WebView::notifyPreferencesChanged): Don't try to call
2295         setShouldPaintNativeControls when SafariTheme support is disabled, as
2296         that function doesn't exist in that case.
2297
2298 2008-10-22  Brady Eidson  <beidson@apple.com>
2299
2300         Reviewed by Adam Roben
2301         
2302         Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use
2303
2304         * Interfaces/IWebFramePrivate.idl:
2305         
2306         * WebFrame.cpp:
2307         (WebFrame::elementDoesAutoComplete):
2308         * WebFrame.h:
2309         
2310         * WebHTMLRepresentation.cpp:
2311         (WebHTMLRepresentation::elementDoesAutoComplete):
2312
2313 2008-10-20  Sam Weinig  <sam@webkit.org>
2314
2315         Reviewed by Anders Carlsson.
2316
2317         Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
2318
2319         * WebFrame.cpp:
2320         * WebFrame.h:
2321
2322 2008-10-19  Darin Adler  <darin@apple.com>
2323
2324         Reviewed by Oliver Hunt.
2325
2326         - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
2327           improve performance by eliminating JSValue as a base class for JSCell
2328
2329         Remove most uses of JSValue, which will be removed in a future patch.
2330
2331         * WebScriptCallFrame.cpp:
2332         (WebScriptCallFrame::jsValueToString): Use JSValuePtr.
2333         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Ditto.
2334         (WebScriptCallFrame::valueForVariable): Put more code inside and ifdef.
2335         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Ditto.
2336         * WebScriptCallFrame.h: Use JSValuePtr.
2337
2338         * WebView.cpp:
2339         (WebView::stringByEvaluatingJavaScriptFromString): Use JSValuePtr.
2340
2341 2008-10-18  Dan Bernstein  <mitz@apple.com>
2342
2343         - build fix
2344
2345         * WebScriptCallFrame.cpp:
2346         (WebScriptCallFrame::jsValueToString):
2347
2348 2008-10-18  Dan Bernstein  <mitz@apple.com>
2349
2350         Reviewed by Sam Weinig.
2351
2352         - WebKit/win part of https://bugs.webkit.org/show_bug.cgi?id=21736
2353           Long-dead decoded image data make up for most of the object cache's memory use over time
2354
2355         * WebView.cpp:
2356         (WebView::setCacheModel): In the primary web browser model,
2357         set the cache's dead decoded data deletion interval to 60 seconds.
2358
2359 2008-10-16  Kevin McCullough  <kmccullough@apple.com>
2360
2361         Reviewed by Steve Falkenburg.
2362
2363         <rdar://problem/6292718>
2364         Implement a standard way to get the UA given an application name.
2365
2366         * Interfaces/IWebViewPrivate.idl:
2367         * WebView.cpp:
2368         (WebView::standardUserAgentWithApplicationName):
2369         * WebView.h:
2370
2371 2008-10-17  Dan Bernstein  <mitz@apple.com>
2372
2373         Reviewed by Sam Weinig.
2374
2375         - export WTF::initializeOnMainThread()
2376
2377         * WebKit.vcproj/WebKit.def:
2378         * WebKit.vcproj/WebKit_debug.def:
2379
2380 2008-10-15  Geoffrey Garen  <ggaren@apple.com>
2381
2382         Reviewed by Cameron Zwarich.
2383
2384         Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
2385         Start the debugger without reloading the inspected page
2386
2387         * WebInspector.cpp:
2388         (WebInspector::toggleDebuggingJavaScript): Updated for rename.
2389
2390 2008-10-15  Adam Roben  <aroben@apple.com>
2391
2392         Export WTF::Mutex::tryLock
2393
2394         * WebKit.vcproj/WebKit.def:
2395         * WebKit.vcproj/WebKit_debug.def:
2396
2397 2008-10-14  Jon Honeycutt  <jhoneycutt@apple.com>
2398
2399         Export currentThread.
2400
2401         Rubber-stamped by Dan Bernstein.
2402
2403         * WebKit.vcproj/WebKit.def:
2404         * WebKit.vcproj/WebKit_debug.def:
2405
2406 2008-10-13  Steve Falkenburg  <sfalken@apple.com>
2407
2408         Reorder methods to preserve compatibility.
2409         
2410         Rubber stamped by Oliver Hunt.
2411
2412         * Interfaces/IWebViewPrivate.idl:
2413
2414 2008-10-11  Dan Bernstein  <mitz@apple.com>
2415
2416         Reviewed by Sam Weinig.
2417
2418         - add SPI for forcing the complex text code path to be used for all text
2419
2420         * Interfaces/IWebViewPrivate.idl:
2421         * WebView.cpp:
2422         (WebView::setAlwaysUsesComplexTextCodePath):
2423         (WebView::alwaysUsesComplexTextCodePath):
2424         * WebView.h:
2425
2426 2008-10-10  Ada Chan  <adachan@apple.com>
2427
2428         Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can 
2429         potentially hold onto stale instances of WebPreferences
2430         https://bugs.webkit.org/show_bug.cgi?id=21526
2431         
2432         webPreferencesInstances now keeps a reference to all the instances it holds.
2433         Fix up callers of WebPreferences::removeReferenceForIdentifier() to call 
2434         it after they have released their references to the WebPreferences objects.
2435
2436         Reviewed by Adam Roben.
2437
2438         * WebPreferences.cpp:
2439         (WebPreferences::getInstanceForIdentifier):
2440         (WebPreferences::removeReferenceForIdentifier):
2441         * WebView.cpp:
2442         (WebView::close):
2443         (WebView::setPreferences):
2444
2445 2008-10-06  David Hyatt  <hyatt@apple.com>
2446
2447         Enable viewless Mac WebKit to paint some basic pages.
2448         
2449         Reviewed by Sam Weinig
2450
2451         * WebCoreSupport/WebFrameLoaderClient.cpp:
2452         (WebFrameLoaderClient::createFrame):
2453         * WebCoreSupport/WebFrameLoaderClient.h:
2454
2455 2008-10-03  David Hyatt  <hyatt@apple.com>
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=21340
2458         
2459         Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.
2460         
2461         Reviewed by Dan Bernstein & Darin Adler
2462
2463         * WebCoreSupport/WebFrameLoaderClient.cpp:
2464         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2465         * WebScrollBar.cpp:
2466         (WebScrollBar::WebScrollBar):
2467         (WebScrollBar::init):
2468         (WebScrollBar::invalidateScrollbarRect):
2469         * WebScrollBar.h:
2470
2471 2008-10-03  David Hyatt  <hyatt@apple.com>
2472
2473          Remove addToDirtyRegion.
2474         
2475          Reviewed by Oliver Hunt
2476
2477         * WebCoreSupport/WebChromeClient.cpp:
2478
2479 2008-10-02  David Hyatt  <hyatt@apple.com>
2480
2481         https://bugs.webkit.org/show_bug.cgi?id=21328
2482         
2483         Make widget invalidation more cross-platform.
2484         
2485         (1) Make invalidateRect a pure virtual function on Widget.  All leaf widgets must now implement this function.
2486         
2487         (2) Scrollbars now send invalidations through the ScrollbarClient.  windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
2488         This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
2489         
2490         (3) Plugins now have the native window invalidation code for windowed plugins.  Windowless plugins do a repaintRectangle on the plugin's renderer.
2491         
2492         (4) FrameViews now do a repaintRectangle on their owner element's renderer.
2493
2494         Reviewed by Sam Weinig
2495
2496         * WebCoreSupport/EmbeddedWidget.cpp:
2497         (EmbeddedWidget::invalidateRect):
2498         * WebCoreSupport/EmbeddedWidget.h:
2499         * WebScrollBar.cpp:
2500         (WebScrollBar::invalidateScrollbarRect):
2501         * WebScrollBar.h:
2502
2503 2008-10-02  Darin Adler  <darin@apple.com>
2504
2505         - https://bugs.webkit.org/show_bug.cgi?id=21321
2506           Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
2507
2508         * WebCoreStatistics.cpp:
2509         (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to
2510         work with the heap.
2511         (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto.
2512         (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto.
2513         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto.
2514         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
2515         * WebJavaScriptCollector.cpp:
2516         (WebJavaScriptCollector::objectCount): Ditto.
2517
2518 2008-10-02  Dave Hyatt  <hyatt@apple.com>
2519
2520         https://bugs.webkit.org/show_bug.cgi?id=21316
2521
2522         Reviewed by Adele
2523        
2524         * WebCoreSupport/WebFrameLoaderClient.cpp:
2525         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2526
2527 2008-10-02  David Hyatt  <hyatt@apple.com>
2528
2529         https://bugs.webkit.org/show_bug.cgi?id=21314
2530         
2531         Make scrollBackingStore cross-platform.
2532
2533         Reviewed by Sam Weinig
2534
2535         * WebCoreSupport/WebChromeClient.cpp:
2536         (WebChromeClient::repaint):
2537         (WebChromeClient::scroll):
2538         * WebCoreSupport/WebChromeClient.h:
2539         * WebView.cpp:
2540         (WebView::repaint):
2541         * WebView.h:
2542
2543 2008-10-01  David Hyatt  <hyatt@apple.com>
2544
2545         https://bugs.webkit.org/show_bug.cgi?id=21298
2546         
2547         Make updateScrollbars cross-platform.  For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store.  Next patch
2548         will make that cross-platform.  
2549         
2550         The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
2551         multiple inheritance.  For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
2552         windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
2553
2554         Reviewed by Sam Weinig
2555
2556         * WebScrollBar.cpp:
2557         (WebScrollBar::windowClipRect):
2558         * WebScrollBar.h:
2559
2560 2008-10-01  David Hyatt  <hyatt@apple.com>
2561         
2562         https://bugs.webkit.org/show_bug.cgi?id=21282
2563         
2564         Make contentsToScreen/screenToContents cross-platform.  Only implemented by Mac/Win right now.
2565         
2566         Reviewed by Adam Roben
2567
2568         * WebCoreSupport/WebChromeClient.cpp:
2569         (WebChromeClient::windowToScreen):
2570         (WebChromeClient::screenToWindow):
2571         * WebCoreSupport/WebChromeClient.h:
2572
2573 2008-09-30   Dave Hyatt  <hyatt@apple.com>
2574
2575         https://bugs.webkit.org/show_bug.cgi?id=21269
2576   
2577         This patch makes the ScrollView::paint method cross-platform.  The paint method calls the base class
2578         Widget paint on platforms with native widgets (Mac and wx).  Otherwise it calls a virtual function,
2579         paintContents, to paint the ScrollView's contents, and then it paints each of the two scrollbars and
2580         the scrollbar corner.
2581         
2582         The scrollbar themes are now responsible for painting scrollbar corners.  At the moment ScrollbarThemeWin still
2583         paints white (which is incorrect), so a future patch will actually implement proper native scroll corner painting
2584         for Windows.
2585         
2586         paintContents is implemented by FrameView, and replaces Frame::paint.  All of the FramePrivate member
2587         variables used by Frame::paint have moved to FrameViewPrivate instead.  All callers of Frame::paint have
2588         been patched to use FrameView::paintContents instead.
2589         
2590         Reviewed by Darin Adler
2591
2592         * WebFrame.cpp:
2593         (WebFrame::paintDocumentRectToContext):
2594         (WebFrame::spoolPages):
2595
2596 2008-09-30  Dave Hyatt  <hyatt@apple.com>
2597
2598         http://bugs.webkit.org/show_bug.cgi?id=21250
2599         
2600         Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
2601         repaints up through the ChromeClient.
2602
2603         Reviewed by Darin Adler
2604
2605         * WebCoreSupport/WebChromeClient.cpp:
2606         (WebChromeClient::repaint):
2607         * WebCoreSupport/WebChromeClient.h:
2608         * WebView.cpp:
2609         (WebView::repaint):
2610         * WebView.h:
2611
2612 2008-09-29  Dan Bernstein  <mitz@apple.com>
2613
2614         Reviewed by Adam Roben.
2615
2616         - WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
2617
2618         * WebKitDLL.cpp:
2619         (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit
2620         is being unloaded.
2621
2622 2008-09-27  David Hyatt  <hyatt@apple.com>
2623
2624         Land the frameGeometry->frameRect changes that I forgot to land in WebKit.
2625
2626         * Interfaces/IWebScrollBarPrivate.idl:
2627         * WebCoreSupport/EmbeddedWidget.cpp:
2628         (EmbeddedWidget::setFrameRect):
2629         (EmbeddedWidget::frameRectsChanged):
2630         * WebCoreSupport/EmbeddedWidget.h:
2631         * WebScrollBar.cpp:
2632         (WebScrollBar::setRect):
2633         (WebScrollBar::frameRect):
2634         * WebScrollBar.h:
2635
2636 2008-09-27  Anders Carlsson  <andersca@apple.com>
2637
2638         Fix build.
2639
2640         * WebCoreSupport/EmbeddedWidget.cpp:
2641         (EmbeddedWidget::setFrameRect):
2642         (EmbeddedWidget::frameRectsChanged):
2643         * WebCoreSupport/EmbeddedWidget.h:
2644         * WebScrollBar.cpp:
2645         (WebScrollBar::setRect):
2646         (WebScrollBar::frameGeometry):
2647
2648 2008-09-26  David Kilzer  <ddkilzer@apple.com>
2649
2650         Speculative Windows build fix with XSLT disabled
2651
2652         Reviewed by Alexey.
2653
2654         * WebCache.cpp:
2655         (WebCache::statistics): Populate xslStyleSheet statistics with
2656         zeros if XSLT is disabled.
2657
2658 2008-09-24  Matt Lilek  <webkit@mattlilek.com>
2659
2660         Reviewed by Darin Adler.
2661
2662         Bug 20999: Inspector hover to select does not work properly on Windows
2663         https://bugs.webkit.org/show_bug.cgi?id=20999
2664         <rdar://problem/6236524>
2665
2666         * WebNodeHighlight.cpp:
2667         (WebNodeHighlight::show):
2668
2669 2008-09-24  Darin Adler  <darin@apple.com>
2670
2671         * English.lproj/Localizable.strings: Updated for recent changes.
2672
2673 2008-09-22  Alice Liu  <alice.liu@apple.com>
2674
2675         Added record-memory-win.vcproj tool to the solution
2676
2677         Reviewed by Steve Falkenburg.
2678
2679         * WebKit.vcproj/WebKit.sln:
2680
2681 2008-09-20  Darin Adler  <darin@apple.com>
2682
2683         - fix build
2684
2685         * WebCoreSupport/WebChromeClient.cpp:
2686         (WebChromeClient::paintCustomScrollbar): Tweaked constant names to make this
2687         compile, but it may not be working correctly. Hyatt should do the real fix.
2688
2689 2008-09-19  Alice Liu  <alice.liu@apple.com>
2690
2691         Fix crash when submitting form at bugreport.apple.com rdar://6234126
2692
2693         Reviewed by Mark Rowe.
2694
2695         * COMPropertyBag.h:
2696         (::GetPropertyInfo):
2697         correct mis-use of comma operator
2698
2699 2008-09-18  Mark Rowe  <mrowe@apple.com>
2700
2701         Reviewed by Dan Bernstein.
2702
2703         Add SPI to WebView to allow DRT to clear the main frame's name between tests.
2704
2705         * Interfaces/IWebViewPrivate.idl:
2706         * WebView.cpp:
2707         (WebView::clearMainFrameName):
2708         * WebView.h:
2709
2710 2008-09-16  Alp Toker  <alp@nuanti.com>
2711
2712         Suggested by Dave Hyatt.
2713
2714         Build fix and cleanup. Rename ScrollBar to Scrollbar.
2715
2716         * WebScrollBar.cpp:
2717         * WebScrollBar.h:
2718
2719 2008-09-16  David Hyatt  <hyatt@apple.com>
2720
2721         Eliminate PlatformScrollbar.
2722
2723         Reviewed by Sam Weinig
2724
2725         * WebScrollBar.cpp:
2726         (WebScrollBar::init):
2727         * WebScrollBar.h:
2728
2729 2008-09-15  Chris Fleizach  <cfleizach@apple.com>
2730
2731         Reviewed by Darin Adler, Beth Dakin
2732
2733         Support strings for AXLists
2734
2735         * WebCoreLocalizedStrings.cpp:
2736         (WebCore::AXDefinitionListTermText):
2737         (WebCore::AXDefinitionListDefinitionText):
2738
2739 2008-09-13  Dave Hyatt  <hyatt@apple.com>
2740
2741         Add ScrollbarTheme to the build.
2742         
2743         Reviewed by Sam Weinig
2744
2745         * WebScrollBar.cpp:
2746         (WebScrollBar::requestedWidth):
2747         (WebScrollBar::requestedHeight):
2748
2749 2008-09-13  Dave Hyatt  <hyatt@apple.com>
2750
2751         More scrollbar refactoring.
2752         
2753         Reviewed by Sam Weinig
2754
2755         * WebScrollBar.h:
2756
2757 2008-09-08  Adam Roben  <aroben@apple.com>
2758
2759         Respect the font smoothing preference when drawing via WebKitGraphics
2760
2761         Reviewed by Dave Hyatt.
2762
2763         * WebKitGraphics.cpp:
2764         (makeFont): Check the font smoothing preference and update the
2765         FontDescription's rendering mode based on it.
2766
2767 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
2768
2769         Another Windows nightly build fix.
2770         
2771         Remove non-production versions of CLSIDs since we'll use registry free COM with
2772         an embedded manifest now in all cases to find COM classes.
2773         
2774         Reviewed by Sam Weinig.
2775
2776         * ForEachCoClass.cpp:
2777         (setUseOpenSourceWebKit): Remove COM registration code.
2778         * Interfaces/WebKit.idl: Remove non-production COM classes
2779
2780 2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2781
2782         Reviewed by Maciej Stachowiak.
2783
2784         Bug 20704: Replace the KJS namespace
2785         <https://bugs.webkit.org/show_bug.cgi?id=20704>
2786
2787         Rename the KJS namespace to JSC.
2788
2789         * WebCoreStatistics.cpp:
2790         * WebJavaScriptCollector.cpp:
2791         * WebScriptCallFrame.cpp:
2792         (WebScriptCallFrame::jsValueToString):
2793         * WebScriptCallFrame.h:
2794         (WebScriptCallFrame::state):
2795         * WebView.cpp:
2796         (WebView::WebView):
2797         (WebView::stringByEvaluatingJavaScriptFromString):
2798
2799 2008-09-05  Dave Hyatt  <hyatt@apple.com>
2800
2801         Add support for runtime switchability of the Aqua look and the native look on Windows.
2802         Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
2803
2804         Reviewed by Adam Roben
2805
2806         * Interfaces/IWebPreferencesPrivate.idl:
2807         * WebPreferenceKeysPrivate.h:
2808         * WebPreferences.cpp:
2809         (WebPreferences::initializeDefaultSettings):
2810         (WebPreferences::shouldPaintNativeControls):
2811         (WebPreferences::setShouldPaintNativeControls):
2812         * WebPreferences.h:
2813         * WebView.cpp:
2814         (WebView::notifyPreferencesChanged):
2815
2816 2008-09-04  Adam Roben  <aroben@apple.com>
2817
2818         Make JavaScriptCoreGenerated build first instead of WTF
2819
2820         JavaScriptCoreGenerated does some setup work that we want to happen
2821         before WTF builds.
2822
2823         * WebKit.vcproj/WebKit.sln: Reversed the dependencies of WTF and
2824         JavaScriptCoreGenerated.
2825
2826 2008-08-30  Sam Weinig  <sam@webkit.org>
2827
2828         Reviewed by Dan Bernstein.
2829
2830         Add WebView SPI to defer loading callbacks.
2831
2832         * Interfaces/IWebViewPrivate.idl:
2833         * WebView.cpp:
2834         (WebView::setDefersCallbacks):
2835         (WebView::defersCallbacks):
2836         * WebView.h:
2837
2838 2008-08-28  Adele Peterson  <adele@apple.com>
2839
2840         Build fix.
2841
2842         * WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
2843
2844 2008-08-28  Holger Hans Peter Freyther  <zecke@selfish.org>
2845
2846         Rubber-stamped by Darin Adler.
2847
2848         https://bugs.webkit.org/show_bug.cgi?id=17261
2849
2850         Remove the urlIcon.png from the project and the resource file. Remove
2851         the usage of this icon from WebKitDLL.cpp and change WebIconDatabase
2852         to get the icon from the IconDatabase code which is using a version of
2853         the icon that is compiled into the code.
2854
2855         * WebIconDatabase.cpp:
2856         (WebIconDatabase::getOrCreateDefaultIconBitmap): Use the icon from the
2857         IconDatabase.cpp
2858         * WebKit.vcproj/WebKit.rc: Remove urlIcon.cpp
2859         * WebKit.vcproj/urlIcon.png: Removed.
2860         * WebKitDLL.cpp:
2861         (loadResourceIntoBuffer): Remove "urlIcon"
2862
2863 2008-08-27  Alice Liu  <alice.liu@apple.com>
2864
2865         Add interface for obtaining JS object counts broken down by type
2866
2867         Reviewed by Steve Falkenburg.
2868
2869         * Interfaces/IWebCoreStatistics.idl:
2870         * WebCoreStatistics.cpp:
2871         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2872         * WebCoreStatistics.h:
2873
2874 2008-08-27  Ada Chan  <adachan@apple.com>
2875
2876         Fixed build.
2877
2878         * WebFrame.cpp:
2879         (WebFrame::pluginWillHandleLoadError):
2880
2881 2008-08-27  Brady Eidson  <beidson@apple.com>
2882
2883         Reviewed by Anders
2884
2885         <rdar://problem/6134133> - Crash when loading large movie as a standalone document
2886
2887         * WebFrame.cpp:
2888         (WebFrame::pluginWillHandleLoadError):
2889         * WebFrame.h:
2890
2891 2008-08-26  Alice Liu  <alice.liu@apple.com>
2892
2893         Implement COMPropertyBag::GetPropertyInfo
2894         and a variant setter for type int
2895
2896         Reviewed by Anders Carlsson.
2897
2898         * COMPropertyBag.h:
2899         (::GetPropertyInfo):
2900         * COMVariantSetter.h:
2901
2902 2008-08-25  Adam Roben  <aroben@apple.com>
2903
2904         Fix an assertion when showing the Web Inspector
2905
2906         Reviewed by Kevin McCullough.
2907
2908         * WebCoreSupport/WebInspectorClient.cpp:
2909         (WebInspectorClient::attachWindow):
2910         (WebInspectorClient::detachWindow):
2911         Recent code changes have caused these functions to get called even
2912         when the window is already attached/detached, respectively. Handle
2913         this case gracefully instead of asserting something that is no longer
2914         true.
2915
2916 2008-08-24  Beth Dakin  <bdakin@apple.com>
2917
2918         Reviewed by John Sullivan.
2919
2920         Provide the excludeFromTextSearch SPI on Windows as well.
2921
2922         * Interfaces/IWebFrame.idl:
2923         * WebFrame.cpp:
2924         (WebFrame::setExcludeFromTextSearch):
2925         * WebFrame.h:
2926
2927 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
2928
2929         Cannot get the focused accessible object from the root object.
2930
2931         AccessibleBase::get_AccFocus() checks whether the focused object is a
2932         child of the current object, but 
2933         http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
2934         the result is the object itself, if it has focus, or a child object of
2935         the active window, not a child of the object.
2936
2937         Reviewed by Sam Weinig.
2938
2939         * AccessibleBase.cpp:
2940         (AccessibleBase::get_accFocus): Don't check whether the focused object
2941         is our child.
2942
2943 2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>
2944
2945         Add SPI to make a Windows WebView transparent.
2946
2947         Reviewed by Dan Bernstein.
2948
2949         * Interfaces/IWebViewPrivate.idl:
2950         * WebCoreSupport/WebFrameLoaderClient.cpp:
2951         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2952         updateBackground() when a new frame is attached, matching the Mac.
2953         * WebFrame.cpp:
2954         (WebFrame::updateBackground): Propagate WebView transparency to ourself
2955         and our child frames.
2956         * WebFrame.h:
2957         * WebView.cpp:
2958         (WebView::WebView):
2959         (WebView::paintIntoBackingStore): Pass m_transparent when creating a
2960         GraphicsContext, so the context will be created with an alpha channel.
2961         (WebView::setTransparent):
2962         (WebView::transparent):
2963         * WebView.h:
2964
2965 2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2966
2967         Add SPI to get a handle to the WebView's backing store bitmap.
2968
2969         Reviewed by Dan Bernstein.
2970
2971         * Interfaces/IWebViewPrivate.idl:
2972         * WebView.cpp:
2973         (WebView::backingStore):
2974         * WebView.h:
2975
2976 2008-08-21 Jonas Klink <klinktech@gmail.com>
2977
2978         Reviewed by Jon Honeycutt.
2979
2980         Fix https://bugs.webkit.org/show_bug.cgi?id=20231
2981         Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE
2982
2983         Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
2984         from accNavigate if no screen element is found in the specified direction.
2985
2986         * AccessibleBase.cpp:
2987         (AccessibleBase::accNavigate):
2988
2989 2008-08-21 Jonas Klink <klinktech@gmail.com>
2990
2991         Reviewed by Jon Honeycutt.
2992
2993         Fix http://bugs.webkit.org/show_bug.cgi?id=20230
2994         Bug 20230: get_accState should be testing state on childObj
2995
2996         Also initializes output parameter action to 0 in get_accDefaultAction.
2997
2998         * AccessibleBase.cpp:
2999         (AccessibleBase::get_accState):
3000         (AccessibleBase::get_accDefaultAction):
3001
3002 2008-08-20  Maxime Britto  <britto@apple.com>
3003
3004         Reviewed by Ada Chan.
3005
3006         rdar://5259746
3007         Mouse events are sent to page while resizing window (affects Gmail)
3008         In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
3009
3010         * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
3011         * WebView.cpp:
3012         (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
3013
3014 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
3015
3016         Reviewed by Geoff Garen.
3017
3018         Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
3019
3020         * WebCoreStatistics.cpp:
3021         (WebCoreStatistics::javaScriptObjectsCount):
3022         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3023         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3024         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3025         * WebJavaScriptCollector.cpp:
3026         (WebJavaScriptCollector::objectCount):
3027         * WebScriptCallFrame.cpp:
3028         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3029         * WebView.cpp:
3030         (WebView::stringByEvaluatingJavaScriptFromString):
3031
3032 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
3033
3034         Fix build.
3035
3036         * WebScriptCallFrame.cpp:
3037         (WebScriptCallFrame::jsValueToString):
3038
3039 2008-08-14  Steve Falkenburg  <sfalken@apple.com>
3040
3041         Update cache capacities to match values used on Mac.
3042         
3043         Reviewed by Dan Bernstein.
3044
3045         * WebView.cpp:
3046         (WebView::setCacheModel):
3047
3048 2008-08-14  Sam Weinig  <sam@webkit.org>
3049
3050         Reviewed by Jon Honeycutt.
3051
3052         Add WebView SPI to set HTMLTokenizer yielding parameters.
3053
3054         * Interfaces/IWebViewPrivate.idl:
3055         * WebView.cpp:
3056         (WebView::setCustomHTMLTokenizerTimeDelay):
3057         (WebView::setCustomHTMLTokenizerChunkSize):
3058         * WebView.h:
3059
3060 2008-08-13  Eric Seidel  <eric@webkit.org>
3061
3062         Attempt to fix the windows build, not review.
3063
3064         * WebIconDatabase.cpp:
3065         (WebIconDatabase::getOrCreateDefaultIconBitmap):
3066
3067 2008-08-13  Ada Chan  <adachan@apple.com>
3068
3069         Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
3070         Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
3071         content into a device context.  Changed WebView::paintDocumentRectToContext()
3072         to call that WebFrame method.
3073
3074         Reviewed by Adam Roben.
3075
3076         * DOMHTMLClasses.cpp:
3077         (DOMHTMLElement::idName):
3078         * Interfaces/IWebFramePrivate.idl:
3079         * WebFrame.cpp:
3080         (WebFrame::paintDocumentRectToContext):
3081         (WebFrame::frameElement):
3082         * WebFrame.h:
3083         * WebView.cpp:
3084         (WebView::paintDocumentRectToContext):
3085
3086 2008-08-12  Timothy Hatcher  <timothy@apple.com>
3087
3088         Add a stub for InspectorClient::setAttachedWindowHeight.
3089
3090         * WebCoreSupport/WebInspectorClient.cpp:
3091         (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
3092         * WebCoreSupport/WebInspectorClient.h:
3093
3094 2008-08-12  Adam Roben  <aroben@apple.com>
3095
3096         Export WTFLog in Debug builds
3097
3098         Reviewed by John Sullivan.
3099
3100         * WebKit.vcproj/WebKit_debug.def:
3101
3102 2008-08-07  Steve Falkenburg  <sfalken@apple.com>
3103
3104         Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.
3105         
3106         WM_TIMER-based timers can be starved if enough other events are keeping
3107         our message loop busy. This change prevents many backing store deletes from stacking
3108         up in this case.
3109         
3110         Reviewed by Geoff Garen.
3111
3112         * WebView.cpp:
3113         (WebView::deleteBackingStore):
3114         (WebView::deleteBackingStoreSoon):
3115         (WebView::cancelDeleteBackingStoreSoon):
3116
3117 2008-08-05  Ada Chan  <adachan@apple.com>
3118
3119         Add a getter for CFURLRequestRef in WebMutableURLRequest.
3120
3121         Reviewed by Anders Carlsson.
3122
3123         * Interfaces/IWebMutableURLRequestPrivate.idl:
3124         * WebMutableURLRequest.cpp:
3125         (WebMutableURLRequest::cfRequest):
3126         * WebMutableURLRequest.h:
3127
3128 2008-08-05  Steve Falkenburg  <sfalken@apple.com>
3129
3130         Don't invalidate a WebView in the process of being closed when prefs change.
3131         
3132         Reviewed by Ada Chan.
3133
3134         * WebView.cpp:
3135         (WebView::notifyPreferencesChanged):
3136
3137 2008-08-04  Alice Liu  <alice.liu@apple.com>
3138
3139         Reviewed by Steve Falkenburg.
3140
3141         Fix CFDictionary leak
3142
3143         * CFDictionaryPropertyBag.cpp:
3144         (CFDictionaryPropertyBag::Write):
3145         m_dictionary is a RetainPtr and should adopt the CF type created
3146
3147 2008-08-02  Maxime Britto  <britto@apple.com>
3148
3149         Reviewed by Eric Seidel.
3150       
3151         These icons are copies from the resizers in WebCore/Ressources
3152
3153         * ChangeLog:
3154         * WebKit.vcproj/WebKit.rc:
3155         * WebKit.vcproj/panEastCursor.png: Added.
3156         * WebKit.vcproj/panNorthCursor.png: Added.
3157         * WebKit.vcproj/panNorthEastCursor.png: Added.
3158         * WebKit.vcproj/panNorthWestCursor.png: Added.
3159         * WebKit.vcproj/panSouthCursor.png: Added.
3160         * WebKit.vcproj/panSouthEastCursor.png: Added.
3161         * WebKit.vcproj/panSouthWestCursor.png: Added.
3162         * WebKit.vcproj/panWestCursor.png: Added.
3163         * WebKit.vcproj/resource.h:
3164         * WebKitDLL.cpp:
3165         (loadResourceIntoBuffer):
3166
3167 2008-08-01  Beth Dakin  <bdakin@apple.com>
3168
3169         Reviewed by Adam Roben.
3170
3171         Fix for <rdar://problem/6119382> Need to hook up WebFrame's 
3172         disconnected frame API on Windows.
3173
3174         * Interfaces/IWebFrame.idl:
3175         * WebFrame.cpp:
3176         (WebFrame::setIsDisconnected):
3177         * WebFrame.h:
3178
3179 2008-08-01  Adam Roben  <aroben@apple.com>
3180
3181         Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any
3182         form
3183
3184         Reviewed by Darin Adler.
3185
3186         * COMPropertyBag.h:
3187         (COMPropertyBag::QueryInterface): Cast to an appropriate type before
3188         assigning into ppvObject.
3189
3190 2008-07-31  Anders Carlsson  <andersca@apple.com>
3191
3192         Reviewed by Adam.
3193
3194         Get rid of FormValuesPropertyBag and use COMPropertyBag instead.
3195         
3196         * COMPropertyBag.h:
3197         Implement parts of IPropertyBag2. 
3198         Currently just one method (CountProperties) is implemented.
3199         
3200         * WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
3201         * WebCoreSupport/FormValuesPropertyBag.h: Removed.
3202       
3203         * WebFrame.cpp:
3204         (WebFrame::dispatchWillSubmitForm):
3205         Create a COMPropertyBag instead.
3206         
3207         * WebKit.vcproj/WebKit.vcproj:
3208
3209 2008-07-31  Anders Carlsson  <andersca@apple.com>
3210
3211         Reviewed by Jon.
3212         
3213         Tweak the names.
3214
3215         * WebCoreSupport/WebFrameLoaderClient.cpp:
3216         (WebFrameLoaderClient::createPlugin):
3217
3218 2008-07-31  Anders Carlsson  <andersca@apple.com>
3219
3220         Reviewed by Jon.
3221
3222         <rdar://problem/5826110>
3223         
3224         Add a way for WebKit clients to embed custom content in web pages.
3225         
3226         * Interfaces/IWebEmbeddedView.idl: Added.
3227         New interface which an embedded view must implement.
3228         
3229         * Interfaces/IWebUIDelegatePrivate.idl:
3230         Add new UI delegate method for creating an embedded view.
3231         
3232         * Interfaces/WebKit.idl:
3233         Include IWebEmbeddedView.idl.
3234         
3235         * WebCoreSupport/EmbeddedWidget.cpp: Added.
3236         * WebCoreSupport/EmbeddedWidget.h: Added.
3237         Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.
3238         
3239         * WebCoreSupport/WebFrameLoaderClient.cpp:
3240         (WebFrameLoaderClient::createPlugin):
3241         Check if the UI delegate wants to create an embedded view.
3242         
3243         * WebKit.vcproj/WebKit.vcproj:
3244         Add EmbeddedWidget.{cpp|h}
3245
3246 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
3247
3248         Rubber-stamped by Maciej.
3249
3250         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
3251         call sites now).
3252
3253         * WebCoreStatistics.cpp:
3254         (WebCoreStatistics::javaScriptObjectsCount):
3255         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3256         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3257         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3258         * WebJavaScriptCollector.cpp:
3259         (WebJavaScriptCollector::objectCount):
3260         * WebScriptCallFrame.cpp:
3261         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3262         * WebView.cpp:
3263         (WebView::stringByEvaluatingJavaScriptFromString):
3264
3265 2008-07-31  Jon Honeycutt  <jhoneycutt@apple.com>
3266
3267         Windows build fix.
3268
3269         * WebURLResponse.cpp:
3270
3271 2008-07-30  Mark Rowe  <mrowe@apple.com>
3272
3273         Windows build fix.
3274
3275         * WebURLResponse.cpp:  Don't include a header file that we just deleted.
3276
3277 2008-07-30  Anders Carlsson  <andersca@apple.com>
3278
3279         Reviewed by Mitz.
3280
3281         Use a COMPropertyBag instead of the HTTPHeaderPropertyBag.
3282         
3283         * HTTPHeaderPropertyBag.cpp: Removed.
3284         * HTTPHeaderPropertyBag.h: Removed.
3285         * WebURLResponse.cpp:
3286         (WebURLResponse::allHeaderFields):
3287
3288 2008-07-30  Anders Carlsson  <andersca@apple.com>
3289
3290         Fix copyright years.
3291         
3292         * COMPropertyBag.h:
3293         * COMVariantSetter.h:
3294
3295 2008-07-30  Anders Carlsson  <andersca@apple.com>
3296
3297         Reviewed by Sam.
3298
3299         More property bag work.
3300         
3301         * COMPropertyBag.h:
3302         (COMPropertyBag::COMPropertyBag):        
3303         (::adopt):
3304         (::Read):
3305         * COMVariantSetter.h:
3306         (COMIUnknownVariantSetter::setVariant):
3307
3308 2008-07-30  Anders Carlsson  <andersca@apple.com>
3309
3310         Reviewed by Sam.
3311
3312         Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
3313         property bag values must be of the same type.
3314         
3315         The COMVariantSetter helpers are now in COMVariantSetter.h
3316         
3317         * COMEnumVariant.h:
3318         * COMPropertyBag.h: Added.
3319         * COMVariantSetter.h: Added.
3320         * WebKit.vcproj/WebKit.vcproj:
3321         
3322 2008-07-30  Alice Liu  <alice.liu@apple.com>
3323
3324         Reviewed by Adam Roben.
3325
3326         Adding logging of COM class names and counts to facilitate
3327         investigating memory issues.
3328
3329         * Interfaces/IWebKitStatistics.idl:
3330         * WebKitDLL.cpp:
3331         * WebKitDLL.h:
3332         * WebKitStatistics.cpp:
3333         (WebKitStatistics::comClassNameCounts):
3334         * WebKitStatistics.h:
3335
3336 2008-07-29  Alice Liu  <alice.liu@apple.com>
3337
3338         Reviewed by Geoff Garen.
3339
3340         Fix WebDocumentLoader leak on Windows.
3341
3342         * WebCoreSupport/WebFrameLoaderClient.cpp:
3343         (WebFrameLoaderClient::createDocumentLoader):
3344         * WebDocumentLoader.cpp:
3345         (WebDocumentLoader::create):
3346         * WebDocumentLoader.h:
3347
3348 2008-07-29  Adam Roben  <aroben@apple.com>
3349
3350         Export detachThread
3351
3352         Reviewed by Geoff Garen.
3353
3354         * WebKit.vcproj/WebKit.def:
3355         * WebKit.vcproj/WebKit_debug.def:
3356
3357 2008-07-29  Adam Roben  <aroben@apple.com>
3358
3359         Export the new version of createThread
3360
3361         Reviewed by Anders Carlsson.
3362
3363         * WebKit.vcproj/WebKit.def:
3364         * WebKit.vcproj/WebKit_debug.def:
3365         Also moved the old version of createThread into the deprecated
3366         section.
3367
3368 2008-07-26  Matt Lilek  <webkit@mattlilek.com>
3369
3370         Reviewed by Geoff Garen.
3371
3372         Changes to accommodate newly named/signatured loading methods in WebCore.
3373
3374         * WebCoreSupport/WebContextMenuClient.cpp:
3375         (WebContextMenuClient::searchWithGoogle):
3376         * WebCoreSupport/WebFrameLoaderClient.cpp:
3377         (WebFrameLoaderClient::loadURLIntoChild):
3378
3379 2008-07-25  Adam Roben  <aroben@apple.com>
3380
3381         Try to fix the Windows build bot
3382
3383         * WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each
3384         project now depends only on the project that should immediately
3385         precede it in the build. For the frameworks, this order makes sense.
3386         For the applications built on top of the frameworks, the order is
3387         arbitrary (but roughly follows the applications' complexity).
3388
3389 2008-07-17  Adele Peterson  <adele@apple.com>
3390
3391         Reviewed by Adam.
3392
3393         WebKit part of fix for <rdar://problem/5698672>  Add drawing callback for a WebKit app to draw its own scrollbars
3394         
3395         Added a setting so an application can tell WebKit its going to draw custom scrollbars.  Also added delegate methods for the actual painting.
3396         
3397         * Interfaces/IWebPreferences.idl:  Added setShouldPaintCustomScrollbars and shouldPaintCustomScrollbars.
3398         * Interfaces/IWebScrollBarPrivate.idl: Moved types to WebScrollbarTypes.idl
3399         * Interfaces/IWebUIDelegate.idl: Added WebUIDelegate4 with new delegate methods, paintCustomScrollbar and paintCustomScrollCorner
3400         * Interfaces/WebKit.idl: Include new WebScrollbarTypes.idl
3401         * Interfaces/WebScrollbarTypes.idl: Added. Has types that the new delegate methods use.
3402         * WebCoreSupport/WebChromeClient.cpp:
3403         (WebChromeClient::paintCustomScrollbar): Added. Calls new delegate method and converts between WebCore types and types exported in WebScrollbarTypes.idl
3404         (WebChromeClient::paintCustomScrollCorner): Added. Calls new delegate method.
3405         (WebChromeClient::uiDelegate4): Added.
3406         * WebCoreSupport/WebChromeClient.h:
3407         * WebPreferenceKeysPrivate.h: Added WebKitPaintCustomScrollbarsPreferenceKey
3408         * WebPreferences.cpp:
3409         (WebPreferences::): Added.
3410         (WebPreferences::shouldPaintCustomScrollbars): Added.
3411         * WebPreferences.h:
3412         * WebView.cpp: (WebView::notifyPreferencesChanged):
3413
3414 2008-07-15  Adam Roben  <aroben@apple.com>
3415
3416         Add WebKit[Set]ShouldUseFontSmoothing functions
3417
3418         <rdar://6059127>
3419
3420         Reviewed by John Sullivan.
3421
3422         * WebKit.vcproj/WebKit.def:
3423         * WebKit.vcproj/WebKit_debug.def:
3424         Export the new functions.
3425         * WebKitGraphics.cpp:
3426         (WebKitSetShouldUseFontSmoothing):
3427         (WebKitShouldUseFontSmoothing):
3428         Call through to the relevant WebCore functions.
3429         * WebKitGraphics.h:
3430
3431 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
3432
3433         Don't include autoversion.h in WebKitDLL.cpp.
3434         autoversion.h changes for every build, so we don't want to include it unless necessary.        
3435
3436         Rubber stamped by Ada Chan.
3437
3438         * WebKitDLL.cpp:
3439
3440 2008-07-14  Adam Roben  <aroben@apple.com>
3441
3442         Windows build fix
3443
3444         * WebJavaScriptCollector.cpp:
3445         (WebJavaScriptCollector::objectCount): Updated to match
3446         -[WebCoreStatistics javaScriptsObjectCount].
3447
3448 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
3449
3450         Reviewed by Geoff Garen.
3451
3452         Eliminate per-thread JavaScript global data instance support and make arbitrary
3453         global data/global object combinations possible.
3454
3455         * WebCoreStatistics.cpp:
3456         (WebCoreStatistics::javaScriptObjectsCount):
3457         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3458         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3459         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3460         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
3461
3462 2008-07-11  Steve Falkenburg  <sfalken@apple.com>
3463
3464         Build fix.
3465
3466         * WebKit.vcproj/WebKit.vcproj:
3467
3468 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
3469
3470         Build fix.
3471
3472         * WebKit.vcproj/Interfaces.vcproj:
3473
3474 2008-07-10  Adam Roben  <aroben@apple.com>
3475
3476         Windows build fix
3477
3478         * WebKit.vcproj/resource.h: Revert some changes that VS made to this
3479         file in r35083.
3480
3481 2008-07-09  Maxime Britto  <britto@apple.com>
3482
3483         Reviewed by Adele.
3484        
3485         Added the panning icon in the ressources.
3486         Its name is compass.png to make a difference with moveCursor.png (from the WebCore ressources)
3487
3488         * ChangeLog:
3489         * WebKit.vcproj/WebKit.rc:
3490         * WebKit.vcproj/panIcon.png: Added.
3491         * WebKit.vcproj/resource.h:
3492         * WebKitDLL.cpp: Declared the new ressource with the name "panIcon"
3493         (loadResourceIntoBuffer):
3494
3495 2008-07-02  Dan Bernstein  <mitz@apple.com>
3496
3497         - try to fix the Windows build
3498
3499         * WebScriptCallFrame.cpp:
3500
3501 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
3502
3503         Reviewed by Darin Adler.
3504
3505         Disable JSLock for per-thread contexts.
3506
3507         * WebCoreStatistics.cpp:
3508         (WebCoreStatistics::javaScriptObjectsCount):
3509         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3510         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3511         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3512         * WebScriptCallFrame.cpp:
3513         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3514         * WebView.cpp:
3515         (WebView::stringByEvaluatingJavaScriptFromString):
3516         Pass a parameter (false) to JSLock to indicate that WebKit doesn't need locking.
3517         Include JSLock.h, as it is no longer brought in implicitly.
3518
3519 2008-06-27  Adam Roben  <aroben@apple.com>
3520
3521         Change WebKitGraphics truncation functions to return the length of the
3522         truncated string
3523
3524         Reviewed by Darin Adler.
3525
3526         * WebKitGraphics.cpp:
3527         (CenterTruncateStringToWidth):
3528         (RightTruncateStringToWidth):
3529         Return the length.
3530         * WebKitGraphics.h:
3531         The truncation functions now return an unsigned int that is the length
3532         of the truncated string. The whole file has been marked extern "C" to
3533         keep the symbols for these functions from changing (which would break
3534         nightly builds).
3535
3536 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
3537
3538         Windows build fix.
3539
3540         * WebJavaScriptCollector.cpp: Added a missing include.
3541
3542 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
3543
3544         Reviewed by Darin Adler.
3545
3546         Prepare JavaScript heap for being per-thread.
3547
3548         * WebCoreStatistics.cpp:
3549         (WebCoreStatistics::javaScriptObjectsCount):
3550         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3551         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3552         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3553         * WebJavaScriptCollector.cpp:
3554         (WebJavaScriptCollector::objectCount):
3555         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
3556
3557         * WebScriptCallFrame.cpp:
3558         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Pass ExecState* where
3559         now required.
3560
3561 2008-06-16  Alexey Proskuryakov  <ap@webkit.org>
3562
3563         Trying to fix Windows build.
3564
3565         * WebScriptCallFrame.cpp:
3566         (WebScriptCallFrame::variableNames):
3567         (WebScriptCallFrame::valueForVariable):
3568         Give ExecState to functions that now take it.
3569
3570 2008-06-16  Adam Roben  <aroben@apple.com>
3571
3572         Windows build fix
3573
3574         * WebScriptCallFrame.cpp: Fixed a header name.
3575
3576 2008-06-15  Darin Adler  <darin@apple.com>
3577
3578         - give Frame object functions shorter names: scriptProxy() -> script(),
3579           selectionController() -> selection(), animationController() -> animation()
3580
3581         * WebFrame.cpp:
3582         (WebFrame::globalContext):
3583         (WebFrame::windowObjectCleared):
3584         * WebView.cpp:
3585         (WebView::handleContextMenuEvent):
3586         (WebViewWndProc):
3587         (WebView::updateFocusedAndActiveState):
3588         (WebView::hasSelectedRange):
3589         (WebView::replaceSelectionWithText):
3590         (WebView::clearSelection):
3591         (WebView::prepareCandidateWindow):
3592         (WebView::onIMERequestCharPosition):
3593         (WebView::onIMERequestReconvertString):
3594
3595 2008-06-15  Darin Adler  <darin@apple.com>
3596
3597         - rename KJS::List to KJS::ArgList
3598
3599         * WebScriptCallFrame.cpp:
3600         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
3601
3602 2008-06-15  Darin Adler  <darin@apple.com>
3603
3604         - new names for a few key JavaScriptCore files
3605
3606         * WebView.cpp:
3607
3608 2008-06-15  Darin Adler  <darin@apple.com>
3609
3610         Rubber stamped by Sam.
3611
3612         - use JS prefix and simpler names for basic JavaScriptCore types,
3613           to complement JSValue and JSObject
3614
3615         * WebScriptCallFrame.cpp:
3616         (WebScriptCallFrame::functionName):
3617
3618 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
3619
3620         Rubber stamped by Oliver.
3621         
3622         - fix WebKit solution for testkjs --> jsc rename
3623
3624         * WebKit.vcproj/WebKit.sln:
3625
3626 2008-06-14  Darin Adler  <darin@apple.com>
3627
3628         Rubber stamped by Sam.
3629
3630         - new names for kjs_binding.h and kjs_proxy.h
3631
3632         * WebFrame.cpp:
3633
3634 2008-06-14  Darin Adler  <darin@apple.com>
3635
3636         Rubber stamped by Sam.
3637
3638         - renamed HTMLGenericFormElement to HTMLFormControlElement
3639
3640         * WebFrame.cpp:
3641         (WebFrame::elementWithName):
3642         (WebFrame::controlsInForm):
3643
3644 2008-06-14  Darin Adler  <darin@apple.com>
3645
3646         - try to fix Windows build, again
3647
3648         * WebFrame.cpp:
3649         (WebFrame::dispatchDecidePolicyForNewWindowAction): Fix arguments. Pass form.
3650         (WebFrame::dispatchDecidePolicyForNavigationAction): Ditto.
3651         * WebFrame.h: Fix arguments.
3652
3653 2008-06-14  Darin Adler  <darin@apple.com>
3654
3655         - try to fix Windows build
3656
3657         * WebActionPropertyBag.cpp:
3658         (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
3659         * WebFrame.h: Added missing FormState arguments.
3660         * WebScrollBar.cpp:
3661         (WebScrollBar::init): Use create instead of new.
3662
3663 2008-06-14  Darin Adler  <darin@apple.com>
3664
3665         Reviewed by Sam.
3666
3667         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
3668           start ref counts at 1 instead of 0 for speed
3669
3670         * WebCoreSupport/WebFrameLoaderClient.cpp:
3671         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
3672         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
3673         conventional ones without a special case.
3674
3675         * WebFrame.cpp:
3676         (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused
3677         IWebFrameView argument (every caller was passing 0). Also changed this to return the
3678         WebCore Frame object, which is needed to straighten out the lifetime and ownership
3679         issues.
3680         * WebFrame.h: Ditto.
3681
3682         * WebView.cpp:
3683         (WebView::initWithFrame): Changed to call new init function and use the return value.
3684
3685 2008-06-13  Darin Adler  <darin@apple.com>
3686
3687         Reviewed by John Sullivan.
3688
3689         - updated for addition of FormState argument to action policy functions
3690         - added WebActionFormKey
3691
3692         * Interfaces/IWebPolicyDelegate.idl:
3693         * WebActionPropertyBag.cpp:
3694         (WebActionPropertyBag::WebActionPropertyBag):
3695         (WebActionPropertyBag::createInstance):