Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to...
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-07-10  Mark Rowe  <mrowe@apple.com>
2
3         Reviewed by Sam Weinig.
4
5         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
6
7         * Configurations/WebKit.xcconfig:
8
9 2008-07-10  Mark Rowe  <mrowe@apple.com>
10
11         Reviewed by Sam Weinig.
12
13         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
14
15         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
16         * WebView/WebFrameLoadDelegate.h: Ditto.
17         * WebView/WebUIDelegate.h: Ditto.
18
19 2008-07-10  Anders Carlsson  <andersca@apple.com>
20
21         Reviewed by Mark.
22         
23         Add availability macros for the new WebPlugin methods.
24
25         * Plugins/WebPlugin.h:
26         * Plugins/WebPluginViewFactory.h:
27
28 2008-07-09  Mark Rowe  <mrowe@apple.com>
29
30         Reviewed by Geoff Garen.
31
32         Don't warn about deprecated functions in production builds.
33
34         * Configurations/Base.xcconfig:
35         * Configurations/DebugRelease.xcconfig:
36
37 2008-07-09  Brady Eidson  <beidson@apple.com>
38
39         Reviewed by Darin
40
41         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
42         has been installed in a frame tree.
43
44         The root of this problem was that calling init() on a new frame could end up calling arbitrary
45         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
46         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
47         destroying the frame.
48
49         Note that each platforms WebKit API layer needs to make this new guarantee:
50         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
51         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
52         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
53
54         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
55         architectural improvement we can make in the future so the individual platform clients are no longer
56         vulnerable to this problem, which should really have been a WebCore issue.
57
58         * WebCoreSupport/WebFrameLoaderClient.mm:
59         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
60           Don't appendChild() the new frame here.
61           Null-check the new frame's page before loading the URL into it, as it might already have been
62           removed from the page.
63
64         * WebView/WebFrame.mm:
65         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
66           go ahead and install the new frame in the frame tree *before* calling init() on it.
67
68 2008-07-09  Anders Carlsson  <andersca@apple.com>
69
70         Reviewed by Darin.
71
72         Make some WebPlugin and WebPluginFactory SPI public.
73         
74         * Plugins/WebPlugin.h:
75         * Plugins/WebPluginPrivate.h:
76         * Plugins/WebPluginViewFactory.h:
77         * Plugins/WebPluginViewFactoryPrivate.h:
78
79 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
80
81         Reviewed by Anders.
82
83         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
84         unsuccessful.
85
86         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
87         newStreamSuccessful.
88         * Plugins/WebBaseNetscapePluginStream.mm:
89         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
90         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
91         newStreamSuccessful to YES.
92         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
93         NPP_DestroyStream if newStreamSuccessful is true.
94
95 2008-07-08  Dan Bernstein  <mitz@apple.com>
96
97         Reviewed by John Sullivan.
98
99         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
100
101         * WebView/WebHTMLView.mm:
102         (-[WebHTMLView addWindowObservers]): Added code to observe when the
103         window goes onscreen.
104         (-[WebHTMLView removeWindowObservers]): Added.
105         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
106         not update when offscreen, calls -setNeedsDisplay: just before it comes
107         onscreen.
108         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
109         * WebView/WebPreferences.m:
110         (+[WebPreferences initialize]): Made updates when offscreen on by
111         default.
112         (-[WebPreferences updatesWhenOffscreen]): Added.
113         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
114         * WebView/WebPreferencesPrivate.h:
115         * WebView/WebView.mm:
116         (-[WebView _preferencesChangedNotification:]): Added code to update the
117         updatesWhenOffscreen setting in WebCore.
118
119 2008-07-07  Anders Carlsson  <andersca@apple.com>
120
121         Reviewed by Darin.
122
123         Speculative fix for     
124         <rdar://problem/5839800>
125         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
126         
127         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
128         
129         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
130         This is usually protected by _private->closed, but in this case it might still be false.
131
132         * WebView/WebHTMLView.mm:
133         (-[WebHTMLView close]):
134
135 2008-07-05  Mark Rowe  <mrowe@apple.com>
136
137         Reviewed by John Sullivan.
138
139         Remove WebSearchableTextView as it has been unused for some time now.
140
141         * Misc/WebSearchableTextView.h: Removed.
142         * Misc/WebSearchableTextView.m: Removed.
143
144 2008-07-05  Mark Rowe  <mrowe@apple.com>
145
146         Reviewed by John Sullivan.
147
148         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
149
150         * Misc/WebNSUserDefaultsExtras.m:
151         (-[NSString _webkit_HTTPStyleLanguageCode]):
152
153 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
154
155         Inspired and reviewed by Mark Rowe.
156
157         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
158
159         * Carbon/HIViewAdapter.m:
160         * DOM/WebDOMOperations.mm:
161         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
162         * DefaultDelegates/WebDefaultPolicyDelegate.m:
163         * History/WebBackForwardList.mm:
164         * History/WebHistory.mm:
165         * History/WebHistoryItem.mm:
166         * History/WebHistoryItemInternal.h:
167         * Misc/WebCoreStatistics.mm:
168         * Misc/WebDownload.m:
169         * Misc/WebGraphicsExtras.c:
170         * Misc/WebKitLogging.h:
171         * Misc/WebKitSystemBits.m:
172         * Misc/WebLocalizableStrings.m:
173         * Misc/WebNSArrayExtras.m:
174         * Misc/WebNSDataExtras.m:
175         * Misc/WebNSDictionaryExtras.m:
176         * Misc/WebNSFileManagerExtras.m:
177         * Misc/WebNSPasteboardExtras.mm:
178         * Misc/WebNSURLExtras.mm:
179         * Misc/WebNSUserDefaultsExtras.m:
180         * Panels/WebAuthenticationPanel.m:
181         * Panels/WebPanelAuthenticationHandler.m:
182         * Plugins/WebBaseNetscapePluginView.mm:
183         * Plugins/WebBasePluginPackage.m:
184         * Plugins/WebNetscapePluginEmbeddedView.mm:
185         * Plugins/WebPluginContainerCheck.mm:
186         * Plugins/WebPluginController.mm:
187         * Plugins/WebPluginDatabase.mm:
188         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
189         * WebCoreSupport/WebKeyGenerator.m:
190         * WebCoreSupport/WebViewFactory.mm:
191         * WebKitPrefix.h:
192         * WebView/WebHTMLRepresentation.mm:
193         * WebView/WebPDFRepresentation.m:
194         * WebView/WebPDFView.mm:
195         * WebView/WebScriptDebugger.mm:
196
197 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
198
199         Reviewed by Darin.
200
201         Disable JSLock for per-thread contexts.
202
203         * Misc/WebCoreStatistics.mm:
204         (+[WebCoreStatistics javaScriptObjectsCount]):
205         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
206         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
207         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
208         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
209         (+[WebCoreStatistics shouldPrintExceptions]):
210         (+[WebCoreStatistics setShouldPrintExceptions:]):
211         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
212         * Plugins/WebBaseNetscapePluginView.mm:
213         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
214         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
215         (-[WebBaseNetscapePluginView start]):
216         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
217         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
218         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
219         (-[WebBaseNetscapePluginView loadPluginRequest:]):
220         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
221         * Plugins/WebPluginController.mm:
222         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
223         (-[WebPluginController startAllPlugins]):
224         (-[WebPluginController stopAllPlugins]):
225         (-[WebPluginController addPlugin:]):
226         (-[WebPluginController destroyPlugin:]):
227         (-[WebPluginController destroyAllPlugins]):
228         * WebView/WebFrame.mm:
229         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
230         * WebView/WebScriptDebugDelegate.mm:
231         (-[WebScriptCallFrame evaluateWebScript:]):
232         * WebView/WebView.mm:
233         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
234         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
235         doesn't need locking. In the future, it may be possible to remove some of these if we
236         establish that this won't make JSC assertions fail (and that we don't want to add such
237         assertions either).
238         Added includes that are now needed.
239
240 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
241
242         Build fix.
243
244         * WebView/WebView.mm:
245
246 2008-07-01  Anders Carlsson  <andersca@apple.com>
247
248         Reviewed by Darin.
249
250         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
251         
252         * Plugins/WebBaseNetscapePluginView.mm:
253         (-[WebBaseNetscapePluginView _createPlugin]):
254         Register the plug-in instance.
255         
256         (-[WebBaseNetscapePluginView _destroyPlugin]):
257         Unegister the plug-in instance.
258         
259         * Plugins/WebNetscapePluginPackage.m:
260         (-[WebNetscapePluginPackage load]):
261         Set NPN_PluginThreadAsyncCall.
262         
263         * Plugins/npapi.mm:
264         (NPN_PluginThreadAsyncCall):
265         Implement this.
266
267 2008-07-01  Dan Bernstein  <mitz@apple.com>
268
269         Reviewed by Darin Adler.
270
271         - WebKit part of moving the method to set the base writing direction from Frame to Editor
272
273         * WebView/WebHTMLView.mm:
274         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
275         Editor method.
276         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
277         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
278
279 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
280
281         Build fix: forgot to check in this file.
282
283         * WebView/WebScriptDebugger.mm:
284         (WebScriptDebugger::WebScriptDebugger):
285
286 2008-06-30  Dan Bernstein  <mitz@apple.com>
287
288         Reviewed by Adele Peterson.
289
290         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
291
292         * WebView/WebHTMLView.mm:
293         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
294         WebCore::Frame::setSelectionBaseWritingDirection() instead of
295         WebCore::Editor::setBaseWritingDirection().
296         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
297         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
298
299 2008-06-28  Darin Adler  <darin@apple.com>
300
301         - fix build
302
303         * WebView/WebView.mm:
304         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
305
306 2008-06-26  Anders Carlsson  <andersca@apple.com>
307
308         Reviewed by Darin.
309
310         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
311         if necessary. Use this for the WebView class. 
312                 
313         * WebView/MainThreadObjectDeallocator.h: Added.
314         * WebView/MainThreadObjectDeallocator.mm: Added.
315         (deallocCallback):
316         (scheduleDeallocateOnMainThread):
317         * WebView/WebView.mm:
318         (-[WebViewPrivate dealloc]):
319         (+[WebView initialize]):
320
321 2008-06-25  Anders Carlsson  <andersca@apple.com>
322
323         Reviewed by Mark.
324
325         <rdar://problem/5984270> 
326         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
327         
328         * WebView/WebView.mm:
329         (tigerMailReleaseIMP):
330         New method that makes sure that the final release happens on the main thread.
331         
332         (-[WebView release]):
333         New method that just calls [super release];
334         
335         (+[WebView initialize]):
336         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
337
338 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
339
340         Reviewed by Geoff.
341
342         Make Machine per-JSGlobalData.
343
344         * WebView/WebScriptDebugger.mm:
345         (WebScriptDebugger::WebScriptDebugger):
346
347 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
348
349         Reviewed by Darin.
350
351         Prepare JavaScript heap for being per-thread.
352
353         * Misc/WebCoreStatistics.mm:
354         (+[WebCoreStatistics javaScriptObjectsCount]):
355         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
356         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
357         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
358         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
359         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
360         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
361
362 2008-06-17  Darin Adler  <darin@apple.com>
363
364         Reviewed by Sam.
365
366         * WebView/WebHTMLView.mm:
367         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
368         to create a CSSMutableStyleDeclaration.
369
370 2008-06-16  Mark Rowe  <mrowe@apple.com>
371
372         Reviewed by Darin Adler.
373
374         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
375
376         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
377         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
378         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
379         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
380
381         * WebView/WebHTMLView.mm:
382         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
383         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
384         * WebView/WebHTMLViewInternal.h:
385         * WebView/WebHTMLViewPrivate.h:
386
387 2008-06-15  Darin Adler  <darin@apple.com>
388
389         - give Frame object functions shorter names: scriptProxy() -> script(),
390           selectionController() -> selection(), animationController() -> animation()
391
392         * Plugins/WebPluginController.mm:
393         (-[WebPluginController webPlugInContainerSelectionColor]):
394         * WebView/WebFrame.mm:
395         (-[WebFrame _attachScriptDebugger]):
396         (-[WebFrame _hasSelection]):
397         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
398         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
399         (-[WebFrame _convertToNSRange:]):
400         (-[WebFrame _convertToDOMRange:]):
401         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
402         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
403         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
404         (-[WebFrame _selectedNSRange]):
405         (-[WebFrame _selectNSRange:]):
406         (-[WebFrame globalContext]):
407         * WebView/WebHTMLView.mm:
408         (-[WebHTMLView _selectedRange]):
409         (-[WebHTMLView _hasSelection]):
410         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
411         (-[WebHTMLView _hasInsertionPoint]):
412         (-[WebHTMLView _isEditable]):
413         (-[WebHTMLView _updateFocusedAndActiveState]):
414         (-[WebHTMLView readSelectionFromPasteboard:]):
415         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
416         (-[WebHTMLView maintainsInactiveSelection]):
417         (-[WebHTMLView paste:]):
418         (isTextInput):
419         (-[WebHTMLView inputContext]):
420         (-[WebTextCompleteController doCompletion]):
421         (-[WebHTMLView selectAll]):
422         (-[WebHTMLView deselectAll]):
423         (-[WebHTMLView selectedAttributedString]):
424         * WebView/WebView.mm:
425         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
426         (-[WebView setSelectedDOMRange:affinity:]):
427         (-[WebView selectedDOMRange]):
428         (-[WebView selectionAffinity]):
429
430 2008-06-15  Darin Adler  <darin@apple.com>
431
432         - rename KJS::List to KJS::ArgList
433
434         * WebView/WebScriptDebugger.h:
435
436 2008-06-15  Darin Adler  <darin@apple.com>
437
438         - new names for more JavaScriptCore files
439
440         * WebView/WebView.mm:
441
442 2008-06-15  Darin Adler  <darin@apple.com>
443
444         - new names for a few key JavaScriptCore files
445
446         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
447         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
448         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
449         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
450         * ForwardingHeaders/kjs/function.h: Removed.
451         * ForwardingHeaders/kjs/internal.h: Removed.
452         * ForwardingHeaders/kjs/object.h: Removed.
453         * ForwardingHeaders/kjs/value.h: Removed.
454         * WebView/WebScriptDebugDelegate.mm:
455
456 2008-06-15  Darin Adler  <darin@apple.com>
457
458         Rubber stamped by Sam.
459
460         - use JS prefix and simpler names for basic JavaScriptCore types,
461           to complement JSValue and JSObject
462
463         * WebView/WebView.mm:
464         (aeDescFromJSValue):
465
466 2008-06-14  Darin Adler  <darin@apple.com>
467
468         Rubber stamped by Sam.
469
470         - new names for kjs_binding.h and kjs_proxy.h
471
472         * WebView/WebFrame.mm:
473         * WebView/WebScriptDebugDelegate.mm:
474         * WebView/WebView.mm:
475
476 2008-06-14  Darin Adler  <darin@apple.com>
477
478         Rubber stamped by Sam.
479
480         - renamed HTMLGenericFormElement to HTMLFormControlElement
481
482         * WebView/WebHTMLRepresentation.mm:
483         (-[WebHTMLRepresentation elementWithName:inForm:]):
484         (-[WebHTMLRepresentation controlsInForm:]):
485
486 2008-06-14  Darin Adler  <darin@apple.com>
487
488         Reviewed by Sam.
489
490         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
491           start ref counts at 1 instead of 0 for speed
492
493         * WebCoreSupport/WebFrameLoaderClient.mm:
494         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
495         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
496         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
497         conventional ones without a special case.
498
499         * WebView/WebDataSource.mm:
500         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
501         this function takes ownership of the DocumentLoader.
502         (-[WebDataSource initWithRequest:]): Use create instead of new.
503         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
504         PassRefPtr and also cleaned up the header a bit.
505
506         * WebView/WebDocumentLoaderMac.h:
507         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
508         functions private.
509
510         * WebView/WebFrame.mm:
511         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
512         of new.
513
514 2008-06-14  Darin Adler  <darin@apple.com>
515
516         Reviewed by Sam.
517
518         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
519           start ref counts at 1 instead of 0 for speed
520
521         * WebView/WebFrame.mm:
522         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
523         * WebView/WebPDFView.mm:
524         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
525
526 2008-06-13  Darin Adler  <darin@apple.com>
527
528         Reviewed by John Sullivan.
529
530         - updated for addition of FormState argument to action policy functions
531         - added WebActionFormKey
532
533         * WebCoreSupport/WebFrameLoaderClient.h:
534         * WebCoreSupport/WebFrameLoaderClient.mm:
535         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
536         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
537         (WebFrameLoaderClient::actionDictionary):
538         * WebKit.exp:
539         * WebView/WebPolicyDelegate.mm:
540         * WebView/WebPolicyDelegatePrivate.h:
541
542 2008-06-12  John Sullivan  <sullivan@apple.com>
543
544         Reviewed by Dan and Darin
545
546         Clear up the confusion about _close (older private method) vs -close (newer public method).
547
548         * WebView/WebView.mm:
549         (-[WebView _isClosed]):
550         simplified style
551         (-[WebView _close]):
552         added a comment about how clients and subclasses should use -close instead
553         (-[WebView dealloc]):
554         call -close instead of _close, so subclasses that override the public method will have the intended behavior
555         (-[WebView close]):
556         added a comment
557         (-[WebView _windowWillClose:]):
558         call -close instead of _close, so subclasses that override the public method will have the intended behavior
559
560         * WebView/WebViewPrivate.h:
561         added a comment about how clients and subclasses should use -close instead
562
563 2008-06-07  Darin Adler  <darin@apple.com>
564
565         Reviewed by Mitz.
566
567         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
568           start ref counts at 1 instead of 0 for speed
569
570         * History/WebHistoryItem.mm:
571         (-[WebHistoryItem init]):
572         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
573         (-[WebHistoryItem initWithURL:target:parent:title:]):
574         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
575         * WebView/WebView.mm:
576         (+[WebView _decodeData:]):
577
578 2008-06-03  Oliver Hunt  <oliver@apple.com>
579
580         Reviewed by Tim.
581
582         Bug 12983: Web Inspector break on the debugger keyword
583         <https://bugs.webkit.org/show_bug.cgi?id=12983>
584
585         Add stubs to allow old webkit debugger interface to build.
586
587         * WebView/WebScriptDebugger.h:
588         * WebView/WebScriptDebugger.mm:
589
590 2008-06-03  Anders Carlsson  <andersca@apple.com>
591
592         Reviewed by Darin.
593
594         <rdar://problem/5980961>
595         
596         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
597         newBottom to be larger than oldBottom which is illegal.
598         
599         * WebView/WebHTMLView.mm:
600         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
601
602 2008-06-02  Anders Carlsson  <andersca@apple.com>
603
604         Reviewed by Mitz.
605
606         Speculative fix for <rdar://problem/5661112> 
607         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
608         
609         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
610         layouts to be triggered.
611         
612         * Plugins/WebBaseNetscapePluginView.mm:
613         (-[WebBaseNetscapePluginView _createPlugin]):
614
615 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
616
617         Reviewed by Darin.
618         
619         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
620         
621         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
622         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
623         setting and retrieving pasteboard types with UTIs, but we don't know of any
624         applications on Tiger that put only PNG on the pasteboard.
625
626         * WebView/WebHTMLView.mm:
627         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
628         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
629
630 2008-05-29  Anders Carlsson  <andersca@apple.com>
631
632         Reviewed by Brady.
633
634         <rdar://problem/5970312> 
635         icon file specified for stand alone web app causes crash if the icon can't be found
636         
637         Handle the case where iconData is null.
638         
639         * Misc/WebIconFetcher.mm:
640         (WebIconFetcherClient::finishedFetchingIcon):
641
642 2008-05-29  Anders Carlsson  <andersca@apple.com>
643
644         Reviewed by Mitz.
645
646         <rdar://problem/5971845>
647         https://bugs.webkit.org/show_bug.cgi?id=19313
648         Add version member to NPCocoaEvent
649
650         Initialize the version member to 0 for all events.
651         
652         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
653         (initializeEvent):
654         (WebNetscapePluginEventHandlerCocoa::drawRect):
655         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
656         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
657         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
658         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
659         (WebNetscapePluginEventHandlerCocoa::focusChanged):
660
661 2008-05-29  Dan Bernstein  <mitz@apple.com>
662
663         Reviewed by Jessica Kahn.
664
665         - fix <rdar://problem/5965013> Page 2 does not print correctly
666
667         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
668         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
669         -viewWillDraw being sent first, which could lead to painting without
670         valid layout. The fix is to ensure up-to-date layout in those methods
671         when printing.
672
673         * WebView/WebHTMLView.mm:
674         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
675         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
676
677 2008-05-28  Anders Carlsson  <andersca@apple.com>
678
679         Reviewed by Jon.
680
681         Remove workaround, this is no longer a problem.
682         
683         * WebView/WebView.mm:
684         (-[WebView _removeObjectForIdentifier:]):
685
686 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
687
688         Reviewed by Tim Hatcher.
689         
690         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
691         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
692         clicking button in returnEvent-crash.html
693         
694         Added implementations for willExecuteProgram and didExecuteProgram, which
695         take care of making sure we're not hanging on to stale data.
696
697 2008-05-27  Timothy Hatcher  <timothy@apple.com>
698
699         Fixes a bug where unplugging the monitor from a video card and
700         moving it to another video card would no longer show OpenGL plugins
701         until you relaunched Safari.
702
703         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
704         attribute to OpenGL contexts
705
706         Reviewed by Kevin Decker.
707
708         * Plugins/WebBaseNetscapePluginView.mm:
709         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
710         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
711         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
712
713 2008-05-25  Mark Rowe  <mrowe@apple.com>
714
715         Reviewed by Darin Adler.
716
717         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
718
719         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
720         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
721
722         * WebView/WebFrame.mm:
723         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
724         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
725         * WebView/WebFrameInternal.h:
726         * WebView/WebFramePrivate.h:
727
728 2008-05-23  Timothy Hatcher  <timothy@apple.com>
729
730         Fix attaching and detaching the Web Inspector. This change removes
731         the clunky animation that never looked right and was causing issues
732         where the inspected WebView would get into a no useable state.
733
734         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
735         can cause the inspected WebVIew to be unusable
736
737         Reviewed by Adam Roben.
738
739         * WebCoreSupport/WebInspectorClient.mm:
740         (-[WebInspectorWindowController close]): Removes animation code.
741         Sets the frame directly and does a displayIfNeeded to prevent
742         showing the Inspector in the page and in the Inspector window.
743         (-[WebInspectorWindowController showWindow:]): Removes animation code.
744         Sets the frame directly.
745         (-[WebInspectorWindowController attach]): Simplified.
746         (-[WebInspectorWindowController detach]): Ditto.
747
748 2008-05-22  Dan Bernstein  <mitz@apple.com>
749
750         Reviewed by Darin Adler.
751
752         - fix broken documentation of
753           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
754
755         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
756         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
757
758 2008-05-22  Timothy Hatcher  <timothy@apple.com>
759
760         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
761
762         Reviewed by Adam Roben.
763
764         * WebCoreSupport/WebInspectorClient.mm:
765         (-[WebInspectorWindowController showWebInspector:]):
766         (-[WebInspectorWindowController showErrorConsole:]):
767         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
768         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
769         (-[WebInspectorWindowController validateUserInterfaceItem:]):
770         * WebInspector/WebInspector.h:
771         * WebInspector/WebInspector.mm:
772         (-[WebInspector showConsole:]):
773         (-[WebInspector showTimeline:]):
774         (-[WebInspector isDebuggingJavaScript]):
775         (-[WebInspector toggleDebuggingJavaScript:]):
776         (-[WebInspector startDebuggingJavaScript:]):
777         (-[WebInspector stopDebuggingJavaScript:]):
778         (-[WebInspector isProfilingJavaScript]):
779         (-[WebInspector toggleProfilingJavaScript:]):
780         (-[WebInspector startProfilingJavaScript:]):
781         (-[WebInspector stopProfilingJavaScript:]):
782
783 2008-05-22  Josh Aas  <joshmoz@gmail.com>
784
785         Reviewed by Anders.
786
787         <rdar://problem/5956429> 
788         https://bugs.webkit.org/show_bug.cgi?id=19192
789         remove NPNVpluginEventModel, fix example plugin
790         
791         * Plugins/WebBaseNetscapePluginView.mm:
792         (-[WebBaseNetscapePluginView getVariable:value:]):
793
794 2008-05-21  Anders Carlsson  <andersca@apple.com>
795
796         Reviewed by Maciej.
797
798         Add WebIconFetcher.
799         
800         * Misc/WebIconFetcher.h: Added.
801         * Misc/WebIconFetcher.mm: Added.
802         (WebIconFetcherClient::WebIconFetcherClient):
803         (WebIconFetcherClient::finishedFetchingIcon):
804         (WebIconFetcherClient::setFetcher):
805         (-[WebIconFetcher init]):
806         (-[WebIconFetcher dealloc]):
807         (-[WebIconFetcher finalize]):
808         (-[WebIconFetcher cancel]):
809         (-[WebIconFetcher _initWithIconFetcher:client:]):
810         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
811         * Misc/WebIconFetcherInternal.h: Added.
812         * WebView/WebFrame.mm:
813         (-[WebFrame fetchApplicationIcon:selector:]):
814         * WebView/WebFramePrivate.h:
815
816 === End merge of squirrelfish ===
817
818 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
819
820         Reviewed by Tim Hatcher.
821         
822         Updated for API changes from merging with trunk WebCore's new debugger.
823
824         * WebView/WebScriptDebugDelegate.mm:
825         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
826         exception return, since the DebuggerCallFrame no longer automatically
827         substitutes the exception for the return value.
828
829         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
830         lexical global object, since the debugger attaches based on dynamic
831         global object.
832
833 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
834
835         Reviewed by Oliver Hunt.
836         
837         Re-enabled previously disabled debugging functionality.
838         
839         There are two major changes from how the WebKit debugger used to work:
840         
841         (1) All the interesting bits are implemented down in JavaScriptCore. The
842         debugger just calls through to KJS::DebuggerCallFrame for everything.
843         
844         (2) Instead of copyihng a pointer to an ExecState once, the debugger
845         copies the DebuggerCallFrame passed to it in each callback. This is
846         because the VM no longer maintains a fully transparent execution state
847         to which you can hold a pointer, and the DebuggerCallFrames it vends
848         are temporaries.
849         
850         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
851         from its function. This is safer than the old method, which was to
852         hold a stale ExecState* and hope for the best.
853
854 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
855
856         Reviewed by Oliver Hunt.
857
858         Updated for API changes in KJS::Debugger.
859
860         * WebView/WebFrame.mm:
861         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
862         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
863
864 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
865
866         Reviewed by Oliver Hunt.
867         
868         Updated WebScriptDebugger API to accept a SourceProvider instead
869         of a WebCore::String, to avoid copying.
870
871         (WebScriptDebugger::sourceParsed): Updated this function not to return
872         a value.
873
874 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
875
876         Build fix: #ifdef'd out some code that doesn't work anymore.
877
878 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
879
880         Reviewed by Oliver Hunt.
881         
882         #ifdef'd out some debugger code that doesn't work anymore.
883
884         * WebView/WebScriptDebugDelegate.mm:
885         (-[WebScriptCallFrame scopeChain]):
886
887 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
888
889         Build fix.
890
891         * ChangeLog:
892         * WebView/WebScriptDebugDelegate.mm:
893         (-[WebScriptCallFrame scopeChain]):
894
895 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
896
897         Reviewed by Oliver Hunt.
898         
899         Build fix.
900
901 === Start merge of squirrelfish ===
902
903 2008-05-21  Darin Adler  <darin@apple.com>
904
905         - fix build
906
907         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
908         if we want, but if we do, we should probably make some refinements like checking _private->closed
909         and applicationIsTerminating.
910
911 2008-05-21  Darin Adler  <darin@apple.com>
912
913         Reviewed by Anders and Kevin Decker.
914
915         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
916
917         * WebView/WebView.mm:
918         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
919         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
920         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
921         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
922         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
923
924 2008-05-19  Stephanie Lewis  <slewis@apple.com>
925
926         Reviewed by Darin.
927     
928         more fast teardown performance work
929
930         * Misc/WebDownload.m:
931         (-[WebDownloadInternal downloadDidBegin:]):
932         (-[WebDownloadInternal downloadDidFinish:]):
933         (-[WebDownloadInternal download:didFailWithError:]):
934         * WebCoreSupport/WebChromeClient.h:
935         * WebCoreSupport/WebChromeClient.mm:
936         (WebChromeClient::disableSuddenTermination):
937         (WebChromeClient::enableSuddenTermination):
938
939 2008-05-18  Dan Bernstein  <mitz@apple.com>
940
941         Reviewed by Sam Weinig.
942
943         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
944
945         * Panels/WebAuthenticationPanel.m:
946         (-[WebAuthenticationPanel setUpForChallenge:]):
947
948 2008-05-16  Timothy Hatcher  <timothy@apple.com>
949
950         Removes WebScriptDebugServer files and related calls. This removes
951         the hooks that Drosera uses for debugging. Now that the Web Inspector
952         has a better debugger, we don't need these anymore.
953
954         Reviewed by Sam Weinig.
955
956         * DefaultDelegates/WebScriptDebugServer.h: Removed.
957         * DefaultDelegates/WebScriptDebugServer.m: Removed.
958         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
959         * WebCoreSupport/WebFrameLoaderClient.mm:
960         * WebKit.exp:
961         * WebView/WebScriptDebugDelegate.mm:
962         * WebView/WebScriptDebugger.mm:
963         (WebScriptDebugger::sourceParsed):
964         (WebScriptDebugger::callEvent):
965         (WebScriptDebugger::atStatement):
966         (WebScriptDebugger::returnEvent):
967         (WebScriptDebugger::exception):
968         * WebView/WebView.mm:
969         (-[WebView _commonInitializationWithFrameName:groupName:]):
970         * WebView/WebViewPrivate.h:
971
972 2008-05-16  Brady Eidson  <beidson@apple.com>
973
974         Reviewed by Anders
975
976         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
977
978         Took the opportunity to touch up another pref that needs the same standardization.
979         That pref is currently not in use on Mac.
980
981         * WebView/WebPreferences.m:
982         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
983         (-[WebPreferences _localStorageDatabasePath]):
984         (-[WebPreferences _setLocalStorageDatabasePath:]):
985         (-[WebPreferences _ftpDirectoryTemplatePath]):
986
987 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
988
989         Reviewed by Alice Liu
990
991         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
992
993         * WebView/WebFrame.mm:
994         (-[WebFrame _accessibilityTree]):
995
996 2008-05-15  Stephanie Lewis  <slewis@apple.com>
997         
998         fix mac build
999
1000         * WebView/WebView.mm:
1001         (-[WebView closeWithFastTeardown]):
1002
1003 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1004
1005         Reviewed by Anders.
1006
1007         Turn on fast teardown.  I added a preference for using full teardown because 
1008         the LEAKS output will be useless without a full teardown.  
1009
1010         preference for fullteardown
1011         * WebView/WebPreferenceKeysPrivate.h:
1012         * WebView/WebPreferences.m:
1013         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1014         (-[WebPreferences fullDocumentTeardownEnabled]):
1015         * WebView/WebPreferencesPrivate.h:
1016         
1017         on application quit dispatch unload events and destroy plugins then exit
1018         * WebView/WebView.mm:
1019         (-[WebView closeWithFastTeardown]):
1020         (-[WebView _close]):
1021         * WebView/WebViewPrivate.h:
1022
1023 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1024
1025         Reviewed by Anders.
1026
1027         get the pending frame unload count from WebCore
1028
1029         * WebView/WebFrame.mm:
1030         (-[WebFrame _pendingFrameUnloadEventCount]):
1031         * WebView/WebFramePrivate.h:
1032
1033 2008-05-15  John Sullivan  <sullivan@apple.com>
1034
1035         Reviewed by Kevin Decker
1036         
1037         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1038           screen when new tab appears
1039           
1040         The highlight should go away entirely, but this simple patch just makes it not jump away.
1041         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1042
1043         * WebInspector/WebNodeHighlight.m:
1044         (-[WebNodeHighlight _repositionHighlightWindow]):
1045         Bail out if target view isn't in a window
1046
1047 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1048
1049         Reviewed by Anders.
1050
1051         Track views that contain plugin instances so that they can be destroyed at application
1052         quit without walking the entire document tree.
1053
1054         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1055         plugins are created and destroyed
1056         * Plugins/WebBaseNetscapePluginView.mm:
1057         (-[WebBaseNetscapePluginView start]):
1058         (-[WebBaseNetscapePluginView stop]):
1059  
1060         Add/remove WebKit plugin views from instance list
1061         * Plugins/WebPluginController.mm:
1062         (-[WebPluginController addPlugin:]):
1063         (-[WebPluginController destroyPlugin:]):
1064         (-[WebPluginController destroyAllPlugins]):
1065
1066         Add a set of views with plugin instances to the WebPluginDatabase
1067         * Plugins/WebPluginDatabase.h:
1068         * Plugins/WebPluginDatabase.mm:
1069         (-[WebPluginDatabase init]):
1070         (-[WebPluginDatabase dealloc]):
1071         (-[WebPluginDatabase addPluginInstanceView:]):
1072         (-[WebPluginDatabase removePluginInstanceView:]):
1073         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1074         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1075         
1076         Handle cases where plugin views are detached before the plugin is destroyed.
1077         * WebCoreSupport/WebFrameLoaderClient.mm:
1078         (WebFrameLoaderClient::detachedFromParent2):
1079         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1080         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1081
1082         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1083         * WebView/WebHTMLView.mm:
1084         (-[WebHTMLView _destroyAllWebPlugins]):
1085         * WebView/WebHTMLViewInternal.h:
1086         * WebView/WebView.mm:
1087         (-[WebView addPluginInstanceView:]):
1088         (-[WebView removePluginInstanceView:]):
1089         (-[WebView removePluginInstanceViewsFor:]):
1090         * WebView/WebViewInternal.h:
1091
1092 2008-05-15  Brady Eidson  <beidson@apple.com>
1093
1094         Reviewed by Tim Hatcher
1095
1096         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1097         before setting the page group of the new page.
1098         
1099         * WebView/WebView.mm:
1100         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1101           immediately after creating the page so it is in place for initializing the LocalStorageThread
1102
1103 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1104
1105         Fixes the bug where the Web Inspector would flash white while resizing.
1106         This was cause by deferring the window creation.
1107
1108         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1109
1110         Reviewed by Darin Adler.
1111
1112         * WebCoreSupport/WebInspectorClient.mm:
1113         (-[WebInspectorWindowController window]): Don't defer the window creation.
1114
1115 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1116
1117         Tiger build fix.
1118
1119         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1120
1121 2008-05-15  Adele Peterson  <adele@apple.com>
1122
1123         Reviewed and landed by Alexey.
1124
1125         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1126
1127         * Misc/WebNSAttributedStringExtras.mm:
1128         (+[NSAttributedString _web_attributedStringFromRange:]):
1129
1130 2008-05-14  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed by Oliver.
1133
1134         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1135
1136         * WebView/WebResource.mm:
1137         (-[WebResource data]):
1138
1139 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1140
1141         Reviewed by Dan Bernstein.
1142
1143         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1144
1145         * Plugins/nptextinput.h:
1146
1147 2008-05-13  Anders Carlsson  <andersca@apple.com>
1148
1149         Reviewed by Sam.
1150
1151         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1152         Instead, do it in [WebCache empty].
1153         
1154         * Misc/WebCache.mm:
1155         (+[WebCache empty]):
1156         * WebView/WebView.mm:
1157         (+[WebView _setCacheModel:]):
1158
1159 2008-05-13  chris fleizach  <cfleizach@apple.com>
1160
1161         Reviewed by Beth Dakin
1162
1163         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1164
1165         * WebCoreSupport/WebViewFactory.mm:
1166         (-[WebViewFactory AXWebAreaText]):
1167
1168 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1169
1170         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1171         was referencing a nil WebView under validateUserInterfaceItem.
1172         The validateUserInterfaceItem methods was being called at a time
1173         when the WebHTMLView is being torndown.
1174
1175         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1176         while mousing down on menu bar after Xcode News window is opened
1177
1178         Reviewed by Ada Chan.
1179
1180         * WebView/WebHTMLView.mm:
1181         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1182         return NO when it is nil. Adds a comment.
1183         * WebView/WebPDFView.mm:
1184         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1185
1186 2008-05-13  Mark Rowe  <mrowe@apple.com>
1187
1188         Reviewed by John Sullivan.
1189
1190         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1191
1192         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1193         * Carbon/HIWebView.m: Ditto.
1194         (HIWebViewCreate):
1195         (HIWebViewConstructor):
1196
1197 2008-05-12  Dan Bernstein  <mitz@apple.com>
1198
1199         Reviewed by Ada Chan.
1200
1201         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1202           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1203
1204         Added font cache statistics and a function to purge inactive font data.
1205
1206         * Misc/WebCoreStatistics.h:
1207         * Misc/WebCoreStatistics.mm:
1208         (+[WebCoreStatistics cachedFontDataCount]):
1209         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1210         (+[WebCoreStatistics purgeInactiveFontData]):
1211         (+[WebCoreStatistics glyphPageCount]):
1212
1213 2008-05-12  Mark Rowe  <mrowe@apple.com>
1214
1215         Reviewed by Tim Hatcher.
1216
1217         Decorate some deprecated delegate methods with the availability macros.
1218
1219         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1220         macros is good for consistency and documentation.
1221
1222         * WebView/WebFrameLoadDelegate.h:
1223         * WebView/WebUIDelegate.h:
1224
1225 2008-05-12  Mark Rowe  <mrowe@apple.com>
1226
1227         Reviewed by Tim Hatcher.
1228
1229         <rdar://problem/5835604> Deprecate HIWebView
1230
1231         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1232
1233         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1234         * Carbon/HIWebView.h: Ditto.
1235
1236 2008-05-12  Kevin Decker  <kdecker@apple.com>
1237
1238         Reviewed by Anders.
1239
1240         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1241         
1242         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
1243         in changeset <http://trac.webkit.org/changeset/31028>
1244         
1245         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
1246         * WebView/WebFrame.mm:
1247         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
1248         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
1249         * WebView/WebFrameInternal.h: Ditto.
1250         * WebView/WebHTMLView.mm: Ditto.
1251         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
1252         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1253         * WebView/WebHTMLViewInternal.h: Ditto.
1254         * WebView/WebHTMLViewPrivate.h: Ditto.
1255
1256 2008-05-12  Anders Carlsson  <andersca@apple.com>
1257
1258         Reviewed by Alexey.
1259
1260         Empty the application cache when changing the cache model.
1261         
1262         * WebView/WebView.mm:
1263         (+[WebView _setCacheModel:]):
1264
1265 2008-05-12  Anders Carlsson  <andersca@apple.com>
1266
1267         Reviewed by Oliver.
1268
1269         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
1270         
1271         * Plugins/WebBaseNetscapePluginView.h:
1272         * Plugins/WebBaseNetscapePluginView.mm:
1273         (-[WebBaseNetscapePluginView start]):
1274         Get the plug-in text input vtable pointer.
1275         
1276         (-[WebBaseNetscapePluginView stop]):
1277         Set the plug-in text input vtable pointer to 0.
1278         
1279         (-[WebBaseNetscapePluginView inputContext]):
1280         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
1281         
1282         (-[WebBaseNetscapePluginView hasMarkedText]):        
1283         (-[WebBaseNetscapePluginView insertText:]):
1284         (-[WebBaseNetscapePluginView markedRange]):
1285         (-[WebBaseNetscapePluginView selectedRange]):
1286         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
1287         (-[WebBaseNetscapePluginView unmarkText]):
1288         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
1289         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
1290         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
1291         (-[WebBaseNetscapePluginView doCommandBySelector:]):
1292         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
1293         (-[WebBaseNetscapePluginView conversationIdentifier]):
1294         Implement NSTextInput and call into the plug-in text input vtable.
1295         
1296         (browserTextInputFuncs):
1297         New method which returns the browser input vtable.
1298         
1299         (-[WebBaseNetscapePluginView getVariable:value:]):
1300         Support getting the browser input vtable pointer.
1301         
1302         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1303         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1304         (WebNetscapePluginEventHandlerCocoa::keyDown):
1305         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1306         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
1307         it means that the event should be passed on to the input manager.
1308          
1309         * Plugins/npapi.mm:
1310         (NPN_MarkedTextAbandoned):
1311         (NPN_MarkedTextSelectionChanged):
1312         Add implementations of browser input method methods.
1313         
1314         * Plugins/nptextinput.h: Added.
1315         Add file with new text input API.
1316
1317 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
1318
1319         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
1320         SquirrelFish merging.
1321
1322         * Misc/WebCoreStatistics.mm:
1323         (+[WebCoreStatistics javaScriptObjectsCount]):
1324         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1325         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1326         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1327         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1328         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1329         * WebView/WebScriptDebugDelegate.mm:
1330         (-[WebScriptCallFrame evaluateWebScript:]):
1331
1332 2008-05-07  Anders Carlsson  <andersca@apple.com>
1333
1334         Reviewed by Mitz.
1335
1336         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
1337         https://bugs.webkit.org/show_bug.cgi?id=18880
1338         <rdar://problem/5909513>
1339
1340         Stop suspending key up events before calling handleEvent.
1341         
1342         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1343         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1344
1345 2008-05-06  Stephanie Lewis  <slewis@apple.com>
1346
1347         Reviewed by Andersca.
1348
1349         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
1350
1351         * Plugins/WebPluginDatabase.m: Removed.
1352         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
1353         * Plugins/npapi.m: Removed.
1354         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
1355
1356 2008-05-06  Anders Carlsson  <andersca@apple.com>
1357
1358         Reviewed by Darin.
1359
1360         Initialize numArchs to 0.
1361         
1362         * Plugins/WebBasePluginPackage.m:
1363         (-[WebBasePluginPackage isNativeLibraryData:]):
1364
1365 2008-05-06  Anders Carlsson  <andersca@apple.com>
1366
1367         Reviewed by Darin.
1368
1369         Add implementation of NPN_PopUpContextMenu.
1370         
1371         * Plugins/WebBaseNetscapePluginView.mm:
1372         (-[WebBaseNetscapePluginView popUpContextMenu:]):
1373         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1374         * Plugins/WebNetscapePluginPackage.m:
1375         (-[WebNetscapePluginPackage load]):
1376         * Plugins/npapi.m:
1377         (NPN_PopUpContextMenu):
1378
1379 2008-05-06  Anders Carlsson  <andersca@apple.com>
1380
1381         Fix typo (don't read random memory).
1382         
1383         * Plugins/WebBasePluginPackage.m:
1384         (-[WebBasePluginPackage isNativeLibraryData:]):
1385
1386 2008-05-05  Anders Carlsson  <andersca@apple.com>
1387
1388         Reviewed by Darin.
1389
1390         Change the isNativeLibraryData: method to handle universal binaries.
1391         
1392         * Plugins/WebBasePluginPackage.m:
1393         (swapIntsInHeader):
1394         (-[WebBasePluginPackage isNativeLibraryData:]):
1395
1396 2008-05-06  Brady Eidson  <beidson@apple.com>
1397
1398         Reviewed by Darin Adler
1399
1400         Preparation for upcoming work making LocalStorage persistent.
1401
1402         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
1403
1404         * WebView/WebView.mm:
1405         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
1406
1407 2008-05-05  Sam Weinig  <sam@webkit.org>
1408
1409         Reviewed by Darin Adler.
1410
1411         Fix for <rdar://problem/5884383>
1412         Escape look-a-like characters from the the entire url.
1413
1414         * Misc/WebNSURLExtras.mm:
1415         (escapeUnsafeCharacters):
1416         (-[NSURL _web_userVisibleString]):
1417
1418 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
1419
1420         Reviewed by Darin.
1421         
1422         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
1423
1424         * WebView/WebView.mm:
1425         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
1426         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
1427         the two interfere.
1428
1429 2008-05-05  Sam Weinig  <sam@webkit.org>
1430
1431         Reviewed by Tim Hatcher.
1432
1433         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
1434
1435         * WebCoreSupport/WebInspectorClient.mm:
1436         (WebInspectorClient::localizedStringsURL):
1437
1438 2008-05-05  Anders Carlsson  <andersca@apple.com>
1439
1440         Reviewed by Jess.
1441
1442         Apparently preflighting can cause hangs for some reason. Revert this for now.
1443         
1444         * Plugins/WebNetscapePluginPackage.m:
1445         (-[WebNetscapePluginPackage _initWithPath:]):
1446         * Plugins/WebPluginPackage.m:
1447         (-[WebPluginPackage initWithPath:]):
1448
1449 2008-05-05  Darin Adler  <darin@apple.com>
1450
1451         Reviewed by Mitz.
1452
1453         - https://bugs.webkit.org/show_bug.cgi?id=18789
1454           fix some shouldCloseWithWindow edge cases
1455
1456         * WebView/WebView.mm:
1457         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
1458         NSWindowWillCloseNotification if the view was moved out of the window but still
1459         had that window set as the host window. Also make sure this function doesn't do
1460         anything if the WebView is already closed.
1461         (-[WebView setHostWindow:]): Ditto.
1462
1463 2008-05-04  David Kilzer  <ddkilzer@apple.com>
1464
1465         Make parameters match for WebChromeClient::addMessageToConsole()
1466
1467         Reviewed by John.
1468
1469         * WebCoreSupport/WebChromeClient.h:
1470         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
1471         to sourceURL to match implementation in WebChromeClient.mm.
1472
1473 2008-05-02  Anders Carlsson  <andersca@apple.com>
1474
1475         Reviewed by Mark.
1476
1477         Various Cocoa event model and 64-bit plug-in fixes.
1478         
1479         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1480         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1481         Set click count.
1482         
1483         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1484         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1485         Don't try to get the mouse location for keyboard events.
1486         
1487         * Plugins/WebPluginPackage.m:
1488         (-[WebPluginPackage initWithPath:]):
1489         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
1490
1491 2008-05-02  Anders Carlsson  <andersca@apple.com>
1492
1493         Reviewed by Sam.
1494
1495         The event union is now named.
1496         
1497         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1498         (WebNetscapePluginEventHandlerCocoa::drawRect):
1499         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1500         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1501         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1502         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1503         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1504
1505 2008-05-02  Anders Carlsson  <andersca@apple.com>
1506
1507         Reviewed by Mark.
1508
1509         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
1510         
1511         Call preflightAndReturnError on the bundle, which will check if any of the architectures
1512         in the bundle match the current architecture.
1513         
1514         * Plugins/WebNetscapePluginPackage.m:
1515         (-[WebNetscapePluginPackage _initWithPath:]):
1516
1517 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
1518
1519         Reviewed by Geoffrey Garen.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=18826
1522         Make JavaScript heap per-thread
1523
1524         * Misc/WebCoreStatistics.mm:
1525         (+[WebCoreStatistics javaScriptObjectsCount]):
1526         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1527         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1528         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1529         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1530         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1531         Replaced static Collector calls with calls to a current thread's instance.
1532
1533         * WebView/WebScriptDebugDelegate.mm:
1534         (-[WebScriptCallFrame evaluateWebScript:]):
1535         Pass ExecState to jsString().
1536
1537 2008-05-01  Anders Carlsson  <andersca@apple.com>
1538
1539         Reviewed by Mark.
1540
1541         64-bit NPAPI plugin build fixes.
1542         
1543         * Plugins/WebBaseNetscapePluginView.mm:
1544         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1545         (-[WebBaseNetscapePluginView updateAndSetWindow]):
1546         (-[WebBaseNetscapePluginView start]):
1547         (-[WebBaseNetscapePluginView windowBecameKey:]):
1548         * Plugins/WebNetscapeDeprecatedFunctions.c:
1549         * Plugins/WebNetscapeDeprecatedFunctions.h:
1550         * Plugins/WebNetscapePluginEventHandler.mm:
1551         (WebNetscapePluginEventHandler::create):
1552         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1553         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1554         * Plugins/WebPluginDatabase.m:
1555         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
1556
1557 2008-05-01  Anders Carlsson  <andersca@apple.com>
1558
1559         Reviewed by Tim.
1560
1561         Remove duplicate npfunctions.h header from WebKit.
1562
1563         * MigrateHeaders.make:
1564         Migrate npfunctions.h
1565         
1566         * Plugins/npfunctions.h: Removed.
1567
1568 2008-05-01  Anders Carlsson  <andersca@apple.com>
1569
1570         Reviewed by John.
1571         
1572         Add null checks for the event handler.
1573         
1574         * Plugins/WebBaseNetscapePluginView.mm:
1575         (-[WebBaseNetscapePluginView stopTimers]):
1576         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1577
1578 2008-05-01  Anders Carlsson  <andersca@apple.com>
1579
1580         Fix 64-bit build.
1581         
1582         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1583         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1584         * WebCoreSupport/WebFrameLoaderClient.mm:
1585
1586 2008-05-01  Anders Carlsson  <andersca@apple.com>
1587
1588         Fix build.
1589         
1590         * Plugins/npfunctions.h:
1591
1592 2008-05-01  Anders Carlsson  <andersca@apple.com>
1593
1594         Reviewed by Adam.
1595
1596         Forward mouse move events to the Netscape plug-in view.
1597         
1598         * Plugins/WebBaseNetscapePluginView.h:
1599         * Plugins/WebBaseNetscapePluginView.mm:
1600         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1601         New method that just calls the current event handler.
1602         
1603         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1604         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1605         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
1606         don't work on it so don't call them.
1607         
1608         * WebCoreSupport/WebFrameLoaderClient.mm:
1609         (NetscapePluginWidget::NetscapePluginWidget):
1610         New Widget subclass to be used for Netscape plug-ins.
1611         
1612         (NetscapePluginWidget::handleEvent):
1613         Forward NSMouseMoved events to the plug-in.
1614         
1615         (WebFrameLoaderClient::createPlugin):
1616         Wrap the plug-in view in a NetscapePluginWidget.
1617
1618 2008-05-01  Alp Toker  <alp@nuanti.com>
1619
1620         Rubber-stamped by Anders.
1621
1622         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
1623         npapi.h.
1624
1625         Additional fix to use same signedness in npapi.h and Mac for the
1626         interval parameter.
1627
1628         * Plugins/WebBaseNetscapePluginView.h:
1629         * Plugins/WebBaseNetscapePluginView.mm:
1630         (PluginTimer::PluginTimer):
1631         (-[WebBaseNetscapePluginView stopTimers]):
1632         (-[WebBaseNetscapePluginView restartTimers]):
1633         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
1634         (-[WebBaseNetscapePluginView unscheduleTimer:]):
1635         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1636         * Plugins/npapi.m:
1637         (NPN_ScheduleTimer):
1638         (NPN_UnscheduleTimer):
1639         * Plugins/npfunctions.h:
1640
1641 2008-04-30  Anders Carlsson  <andersca@apple.com>
1642
1643         Reviewed by Adam.
1644
1645         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
1646         
1647         * Plugins/WebBaseNetscapePluginView.h:
1648         * Plugins/WebBaseNetscapePluginView.mm:
1649         (PluginTimer::PluginTimer):
1650         (PluginTimer::start):
1651         (PluginTimer::fired):
1652         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1653         (-[WebBaseNetscapePluginView stopTimers]):
1654         (-[WebBaseNetscapePluginView restartTimers]):
1655         (-[WebBaseNetscapePluginView scrollWheel:]):
1656         (-[WebBaseNetscapePluginView flagsChanged:]):
1657         (-[WebBaseNetscapePluginView start]):
1658         (-[WebBaseNetscapePluginView eventModel]):
1659         (-[WebBaseNetscapePluginView fini]):
1660         (-[WebBaseNetscapePluginView getVariable:value:]):
1661         (-[WebBaseNetscapePluginView setVariable:value:]):
1662         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
1663         (-[WebBaseNetscapePluginView unscheduleTimer:]):
1664         * Plugins/WebBaseNetscapePluginViewInternal.h:
1665         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1666         * Plugins/WebNetscapePluginEventHandler.h:
1667         * Plugins/WebNetscapePluginEventHandler.mm:
1668         (WebNetscapePluginEventHandler::create):
1669         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1670         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1671         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
1672         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
1673         (WebNetscapePluginEventHandlerCarbon::platformWindow):
1674         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
1675         (WebNetscapePluginEventHandlerCocoa::startTimers):
1676         (WebNetscapePluginEventHandlerCocoa::stopTimers):
1677         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
1678         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
1679         (WebNetscapePluginEventHandlerCocoa::drawRect):
1680         (WebNetscapePluginEventHandlerCocoa::mouseDown):
1681         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
1682         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
1683         (WebNetscapePluginEventHandlerCocoa::mouseExited):
1684         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
1685         (WebNetscapePluginEventHandlerCocoa::mouseUp):
1686         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
1687         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1688         (WebNetscapePluginEventHandlerCocoa::keyDown):
1689         (WebNetscapePluginEventHandlerCocoa::keyUp):
1690         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1691         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1692         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1693         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1694         (WebNetscapePluginEventHandlerCocoa::platformWindow):
1695         (WebNetscapePluginEventHandlerCocoa::sendEvent):
1696         * Plugins/WebNetscapePluginPackage.m:
1697         (-[WebNetscapePluginPackage load]):
1698         * Plugins/npapi.m:
1699         (NPN_ScheduleTimer):
1700         (NPN_UnscheduleTimer):
1701         * Plugins/npfunctions.h:
1702
1703 2008-04-30  Brady Eidson  <beidson@apple.com>
1704
1705         Fix my WebPreferences revert check-in
1706
1707         * WebView/WebView.mm:
1708         (-[WebView _preferencesChangedNotification:]):
1709
1710 2008-04-30  Brady Eidson  <beidson@apple.com>
1711
1712         Rubberstamped by John Sullivan
1713
1714         Revert the remainder of my original preferences changes from last week.
1715         They caused a massive PLT regression (too many notifications being sent out
1716         or listened to that weren't previously) and it's not in my schedule to refine
1717         the preferences code instead of working on my feature!
1718
1719         * WebView/WebView.mm:
1720         (-[WebView _updateSettingsFromPreferences:]):
1721         (-[WebView _commonInitializationWithFrameName:groupName:]):
1722
1723 2008-04-30  Anders Carlsson  <andersca@apple.com>
1724
1725         Fix the 64-bit build.
1726         
1727         * Plugins/WebNetscapePluginEventHandler.h:
1728         * Plugins/WebNetscapePluginEventHandler.mm:
1729         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1730         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1731
1732 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
1733
1734         BUILD FIX for Release build.
1735
1736         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1737         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
1738         separately so the compiler doesn't complain about an unused variable.
1739         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
1740
1741 2008-04-29  Anders Carlsson  <andersca@apple.com>
1742
1743         Reviewed by Adam.
1744
1745         Refactor the Carbon event handling code out into a separate class in preparation for adding
1746         the Cocoa event handling code.
1747         
1748         * Plugins/WebBaseNetscapePluginView.h:
1749         * Plugins/WebBaseNetscapePluginView.mm:
1750         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
1751         (-[WebBaseNetscapePluginView sendActivateEvent:]):
1752         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
1753         (-[WebBaseNetscapePluginView stopTimers]):
1754         (-[WebBaseNetscapePluginView restartTimers]):
1755         (-[WebBaseNetscapePluginView setHasFocus:]):
1756         (-[WebBaseNetscapePluginView mouseDown:]):
1757         (-[WebBaseNetscapePluginView mouseUp:]):
1758         (-[WebBaseNetscapePluginView mouseEntered:]):
1759         (-[WebBaseNetscapePluginView mouseExited:]):
1760         (-[WebBaseNetscapePluginView mouseDragged:]):
1761         (-[WebBaseNetscapePluginView keyUp:]):
1762         (-[WebBaseNetscapePluginView keyDown:]):
1763         (-[WebBaseNetscapePluginView cut:]):
1764         (-[WebBaseNetscapePluginView copy:]):
1765         (-[WebBaseNetscapePluginView paste:]):
1766         (-[WebBaseNetscapePluginView selectAll:]):
1767         (-[WebBaseNetscapePluginView start]):
1768         (-[WebBaseNetscapePluginView stop]):
1769         (-[WebBaseNetscapePluginView fini]):
1770         (-[WebBaseNetscapePluginView drawRect:]):
1771         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1772         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1773         (-[WebBaseNetscapePluginView windowBecameKey:]):
1774         (-[WebBaseNetscapePluginView windowResignedKey:]):
1775         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
1776         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
1777         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
1778         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
1779         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1780         (-[WebBaseNetscapePluginView _viewHasMoved]):
1781         * Plugins/WebBaseNetscapePluginViewInternal.h:
1782         * Plugins/WebNetscapePluginEmbeddedView.h:
1783         * Plugins/WebNetscapePluginEventHandler.h: Added.
1784         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
1785         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
1786         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
1787         * Plugins/WebNetscapePluginEventHandler.mm: Added.
1788         (WebNetscapePluginEventHandler::create):
1789         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
1790         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
1791         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
1792         (getCarbonEvent):
1793         (modifiersForEvent):
1794         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
1795         (WebNetscapePluginEventHandlerCarbon::drawRect):
1796         (WebNetscapePluginEventHandlerCarbon::mouseDown):
1797         (WebNetscapePluginEventHandlerCarbon::mouseUp):
1798         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
1799         (WebNetscapePluginEventHandlerCarbon::mouseExited):
1800         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
1801         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
1802         (WebNetscapePluginEventHandlerCarbon::keyDown):
1803         (keyMessageForEvent):
1804         (WebNetscapePluginEventHandlerCarbon::keyUp):
1805         (WebNetscapePluginEventHandlerCarbon::focusChanged):
1806         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
1807         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
1808         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
1809         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
1810         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
1811         (WebNetscapePluginEventHandlerCarbon::startTimers):
1812         (WebNetscapePluginEventHandlerCarbon::stopTimers):
1813         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1814
1815 2008-04-29  Mark Rowe  <mrowe@apple.com>
1816
1817         Reviewed by David Harrison.
1818
1819         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
1820
1821         * WebKit.exp:
1822         * WebView/WebDynamicScrollBarsView.h:
1823         * WebView/WebDynamicScrollBarsView.m:
1824
1825 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
1826
1827         Reviewed by Darin.
1828
1829         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
1830
1831         * WebCoreSupport/WebChromeClient.h:
1832         * WebCoreSupport/WebChromeClient.mm:
1833         * WebView/WebClipView.m:
1834         (-[WebClipView scrollWheel:]):
1835         * WebView/WebHTMLView.mm:
1836         (-[WebHTMLView addMouseMovedObserver]):
1837         (-[WebHTMLView removeMouseMovedObserver]):
1838         (-[WebHTMLView acceptsFirstMouse:]):
1839         * WebView/WebUIDelegatePrivate.h:
1840         * WebView/WebView.mm:
1841         (-[WebViewPrivate init]):
1842         * WebView/WebViewPrivate.h:
1843
1844 2008-04-28  Rob Buis  <buis@kde.org>
1845
1846         Reviewed by Maciej.
1847
1848         Build fix for Tiger.
1849
1850         * WebView/WebView.mm:
1851         (WebKitInitializeApplicationCachePathIfNecessary):
1852
1853 2008-04-28  Adele Peterson  <adele@apple.com>
1854
1855         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
1856
1857         WebKit part of fix for <rdar://problem/3709505>
1858         Safari should have a way to upload bundles from the file upload control (as zip)
1859
1860         Added UIDelegate methods to let the application handle generating replacement files for uploads.
1861         In this case, Safari will create archived files for bundles so they can be uploaded properly.
1862
1863         * DefaultDelegates/WebDefaultUIDelegate.m:
1864         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
1865         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
1866         * WebCoreSupport/WebChromeClient.h:
1867         * WebCoreSupport/WebChromeClient.mm:
1868         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
1869         (WebChromeClient::generateReplacementFile):
1870         * WebView/WebUIDelegatePrivate.h:
1871
1872 2008-04-28  Anders Carlsson  <andersca@apple.com>
1873
1874         Reviewed by Sam, Mark, Adele and Darin.
1875
1876         Initialize the application cache path.
1877         
1878         * WebView/WebView.mm:
1879         (WebKitInitializeApplicationCachePathIfNecessary):
1880         (-[WebView _commonInitializationWithFrameName:groupName:]):
1881
1882 2008-04-28  Alice Liu  <alice.liu@apple.com>
1883
1884         Reviewed by Darin.
1885
1886         Fix <rdar://problem/4911289> Add tabindex property to all children 
1887         of HTMLElement (7138)
1888         http://bugs.webkit.org/show_bug.cgi?id=7138
1889
1890         * MigrateHeaders.make:
1891         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
1892         because now that focus() has been moved to DOMHTMLElement.h, these
1893         files are no longer needed.
1894
1895 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
1896
1897         Reviewed by Darin.
1898
1899         Fix run-webkit-tests --threading
1900         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
1901         Proxy server issue in Sunday's Nightly
1902
1903         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
1904         only done from icon database code, which is not robust enough.
1905
1906 2008-04-20 Adam Barth <hk9565@gmail.com>
1907
1908         Reviewed by Adam Roben and Sam Weinig.
1909
1910         Updated WebSecurityOrigin to match new SecurityOrigin API.
1911
1912         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
1913
1914         * Storage/WebSecurityOrigin.mm:
1915         (-[WebSecurityOrigin host]):
1916         (-[WebSecurityOrigin domain]):
1917         * Storage/WebSecurityOriginPrivate.h:
1918
1919 2008-04-25  Mark Rowe  <mrowe@apple.com>
1920
1921         Rubber-stamped by Sam Weinig.
1922
1923         Add some content to an empty ICU header file to prevent verification errors.
1924
1925         * icu/unicode/utf_old.h:
1926
1927 2008-04-25  Anders Carlsson  <andersca@apple.com>
1928
1929         Reviewed by Sam.
1930
1931         Add offlineWebApplicationCacheEnabled preference.
1932         
1933         * WebView/WebPreferenceKeysPrivate.h:
1934         * WebView/WebPreferences.m:
1935         (+[WebPreferences initialize]):
1936         (-[WebPreferences offlineWebApplicationCacheEnabled]):
1937         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
1938         * WebView/WebPreferencesPrivate.h:
1939         * WebView/WebView.mm:
1940         (-[WebView _updateSettingsFromPreferences:]):
1941
1942 2008-04-24  Mark Rowe  <mrowe@apple.com>
1943
1944         Reviewed by Sam Weinig.
1945
1946         Remove code for calculating the glyph cache size.
1947
1948         * WebCoreSupport/WebSystemInterface.m:
1949         (InitWebCoreSystemInterface): Remove unused symbol.
1950
1951 2008-04-24  Mark Rowe  <mrowe@apple.com>
1952
1953         Reviewed by Sam Weinig.
1954
1955         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
1956
1957         * WebKitPrefix.h:
1958
1959 2008-04-24  Brady Eidson  <beidson@apple.com>
1960
1961         Reviewed by Darin
1962
1963         Fix layout test regressions from my earlier preferences/settings tweak.
1964
1965         * WebView/WebView.mm:
1966         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
1967           the notification to update the settings, each WebView still needs to register for the
1968           notification - restore that behavior.
1969
1970 2008-04-24  Dan Bernstein  <mitz@apple.com>
1971
1972         Reviewed by Darin Adler.
1973
1974         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
1975           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
1976
1977         * WebView/WebFrame.mm:
1978         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
1979         VisiblePosition::caretRect() instead of the RenderObject method which
1980         was removed.
1981
1982 2008-04-24  Brady Eidson  <beidson@apple.com>
1983
1984         Reviewed by Darin
1985
1986         Rework the Settings population again.
1987
1988         * WebView/WebView.mm:
1989         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
1990           and directly from WebView's common init function.
1991         (-[WebView _preferencesChangedNotification:]):
1992         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
1993           after creating the new Page
1994
1995 2008-04-24  Darin Adler  <darin@apple.com>
1996
1997         Reviewed by Geoff.
1998
1999         - fix crash in regression test where we'd ask a frame for a user agent string
2000           after the WebView was already closed
2001
2002         * WebCoreSupport/WebFrameLoaderClient.mm:
2003         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2004         added some code to prevent the crash in release builds if this problem happens
2005         again.
2006
2007 2008-04-24  Anders Carlsson  <andersca@apple.com>
2008
2009         Reviewed by Sam.
2010
2011         Change some String arguments to be const references instead.
2012
2013         * WebCoreSupport/WebEditorClient.h:
2014         * WebCoreSupport/WebEditorClient.mm:
2015         (WebEditorClient::shouldInsertText):
2016
2017 2008-04-24  John Sullivan  <sullivan@apple.com>
2018
2019         Mac build fix
2020         
2021         * WebCoreSupport/WebViewFactory.mm:
2022         (-[WebViewFactory AXButtonActionVerb]):
2023         implement this method using the text in WebCoreLocalizedStrings.cpp
2024         (-[WebViewFactory AXRadioButtonActionVerb]):
2025         ditto
2026         (-[WebViewFactory AXTextFieldActionVerb]):
2027         ditto
2028         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2029         ditto
2030         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2031         ditto
2032         (-[WebViewFactory AXLinkActionVerb]):
2033         ditto
2034
2035 2008-04-23  Brady Eidson  <beidson@apple.com>
2036
2037         Reviewed by Sam Weinig
2038
2039         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2040         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2041         thereby populating the Settings object, immediately after the Page is created.
2042
2043         * WebView/WebView.mm:
2044         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2045
2046 2008-04-24  John Sullivan  <sullivan@apple.com>
2047
2048         Reviewed by Jess
2049         
2050         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2051
2052         * Misc/WebNSControlExtras.m:
2053         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2054         deploy userSpaceScaleFactor when using view distances on the window
2055
2056 2008-04-22  Anders Carlsson  <andersca@apple.com>
2057
2058         Reviewed by Darin.
2059
2060         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2061         
2062         * Plugins/npfunctions.h:
2063
2064 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2065
2066         Mysteriously reviewed by mitz|away.
2067
2068         Bug 18111: Closing a tab while dragging crashes Safari
2069         https://bugs.webkit.org/show_bug.cgi?id=18111
2070
2071         Null check the page before handling drag events.
2072
2073         * WebView/WebView.mm:
2074         (-[WebView draggingUpdated:]):
2075         (-[WebView draggingExited:]):
2076
2077 2008-04-19  Brady Eidson  <beidson@apple.com>
2078
2079         Reviewed by Tim Hatcher
2080
2081         Add a WebPreference for the path of the local storage persistent store.
2082
2083         * WebView/WebPreferenceKeysPrivate.h:
2084
2085         * WebView/WebPreferences.m:
2086         (-[WebPreferences _localStorageDatabasePath]):
2087         (-[WebPreferences _setLocalStorageDatabasePath:]):
2088         * WebView/WebPreferencesPrivate.h:
2089
2090         * WebView/WebView.mm:
2091         (-[WebView _preferencesChangedNotification:]):
2092
2093 2008-04-18  Brady Eidson  <beidson@apple.com>
2094
2095         Reviewed by Sam Weinig
2096
2097         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2098         No reason to do the work twice...
2099
2100         * WebView/WebView.mm:
2101         (-[WebView _close]):
2102
2103 2008-04-17  Eric Seidel  <eric@webkit.org>
2104
2105         Reviewed by beth.
2106
2107         Rename Frame::renderer() to contentRenderer() and fix uses.
2108
2109         * Misc/WebCoreStatistics.mm:
2110         * WebView/WebRenderNode.mm:
2111         (-[WebRenderNode initWithWebFrameView:]):
2112
2113 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2114
2115         Reviewed by mrowe.
2116
2117         * WebView/WebFrame.mm: Remove temporary build fix.
2118
2119 2008-04-17  Mark Rowe  <mrowe@apple.com>
2120
2121         Reviewed by Dan Bernstein.
2122
2123         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2124
2125         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2126
2127         * WebCoreSupport/WebFrameLoaderClient.mm:
2128         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2129
2130 2008-04-17  Mark Rowe  <mrowe@apple.com>
2131
2132         Rubber-stamped by Dan Bernstein.
2133
2134         Fix the Mac build.
2135
2136         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2137         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2138         for this to live going forward.
2139
2140 2008-04-15  Kevin Decker  <kdecker@apple.com>
2141
2142         Reviewed by Anders.
2143
2144         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2145         
2146         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2147         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2148         a bundle out from underneath itself.
2149
2150         * Plugins/WebBasePluginPackage.h: Added unload method.
2151         * Plugins/WebBasePluginPackage.m:
2152         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2153         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2154         * Plugins/WebNetscapePluginPackage.m:
2155         (-[WebNetscapePluginPackage unload]): Added.
2156
2157 2008-04-15  Anders Carlsson  <andersca@apple.com>
2158
2159         Reviewed by Adam.
2160
2161         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2162
2163         * Configurations/WebKit.xcconfig:
2164
2165 2008-04-15  Brady Eidson  <beidson@apple.com>
2166
2167         Reviewed by John Sullivan
2168
2169         Do a more complete job adding the "WebArchiveDebugMode" pref
2170
2171         * WebView/WebPreferences.m: Add both getter *and* setter
2172         (-[WebPreferences webArchiveDebugModeEnabled]):
2173         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2174         * WebView/WebPreferencesPrivate.h:
2175
2176         * WebView/WebView.mm:
2177         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2178
2179 2008-04-14  Brady Eidson  <beidson@apple.com>
2180
2181         Reviewed by Anders
2182
2183         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2184         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2185         network and will instead fail the load as "cancelled."
2186
2187         * WebView/WebPreferenceKeysPrivate.h:
2188
2189         * WebView/WebPreferences.m:
2190         (+[WebPreferences initialize]):
2191         (-[WebPreferences _webArchiveDebugModeEnabled]):
2192         * WebView/WebPreferencesPrivate.h:
2193
2194         * WebView/WebView.mm:
2195         (-[WebView _preferencesChangedNotification:]):
2196
2197 2008-04-11  David Hyatt  <hyatt@apple.com>
2198
2199         Rename CachedResource ref/deref methods to addClient/removeClient.
2200
2201         Reviewed by olliej
2202
2203         * WebView/WebHTMLView.mm:
2204         (-[WebHTMLViewPrivate dealloc]):
2205         (-[WebHTMLViewPrivate finalize]):
2206         (-[WebHTMLViewPrivate clear]):
2207         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2208
2209 2008-04-07  Brady Eidson  <beidson@apple.com>
2210
2211         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2212
2213         * Configurations/WebKit.xcconfig:
2214
2215 2008-04-04  Adam Roben  <aroben@apple.com>
2216
2217         Use WebCore's ICU headers instead of our own copy
2218
2219         Rubberstamped by Tim Hatcher.
2220
2221         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2222         PrivateHeaders.
2223
2224 2008-04-04  Adam Roben  <aroben@apple.com>
2225
2226         Fix <rdar://problem/5804776> Would like to use WebCore's
2227         ForwardingHeaders in WebKit without manually creating copies
2228
2229         Patch by Tim Hatcher, typed by me.
2230
2231         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2232         WebCore's PrivateHeaders instead of our own copy.
2233
2234 2008-04-04  Ada Chan  <adachan@apple.com>
2235
2236         Now we pass width and height directly as integers to format
2237         the window title for a standalone image.
2238
2239         Reviewed by Dan.
2240
2241         * WebCoreSupport/WebViewFactory.mm:
2242         (-[WebViewFactory imageTitleForFilename:width:height:]):
2243
2244 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
2245
2246         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
2247
2248         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
2249           font-weight does not properly support graded weights
2250
2251         * WebView/WebHTMLView.mm:
2252         (-[WebHTMLView _styleFromFontAttributes:]):
2253         (-[WebHTMLView _originalFontB]):
2254         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2255
2256 2008-04-02  Mark Rowe  <mrowe@apple.com>
2257
2258         Reviewed by Oliver Hunt.
2259
2260         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
2261
2262         * Configurations/Base.xcconfig:
2263
2264 2008-03-31  Alice Liu  <alice.liu@apple.com>
2265
2266         Reviewed by Darin.
2267
2268         * WebView/WebFrame.mm:
2269         (-[WebFrame _accessibilityTree]):
2270         The syntax for fetching an object from the AXObjectCache changed slightly
2271
2272 2008-03-31  Brady Eidson  <beidson@apple.com>
2273
2274         Reviewed by Jon Honeycutt
2275         
2276         Move a WebArchive loading check into WebCore
2277
2278         * WebView/WebHTMLRepresentation.mm:
2279         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
2280           responsible for checking that state
2281
2282 2008-03-31  Brady Eidson  <beidson@apple.com>
2283
2284         Reviewed by Darin and Mitz's rubber stamp
2285
2286         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2287
2288         * WebCoreSupport/WebEditorClient.mm:
2289         * WebCoreSupport/WebEditorClient.h:
2290
2291 2008-03-28  Brady Eidson  <beidson@apple.com>
2292
2293         Rubberstamped by Darin Adler
2294
2295         Remove WebArchiver.h/mm
2296
2297         * WebView/WebArchiver.h: Removed.
2298         * WebView/WebArchiver.mm: Removed.
2299
2300         * DOM/WebDOMOperations.mm:
2301         * WebCoreSupport/WebDragClient.mm:
2302         * WebCoreSupport/WebEditorClient.mm:
2303         * WebView/WebDataSource.mm:
2304         * WebView/WebHTMLView.mm:
2305
2306 2008-03-28  Brady Eidson  <beidson@apple.com>
2307
2308         Reviewed by Darin Adler
2309
2310         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
2311
2312         * WebCoreSupport/WebEditorClient.mm:
2313         (WebEditorClient::dataForArchivedSelection):
2314
2315         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
2316         * WebView/WebArchiver.mm: Ditto
2317
2318         * WebView/WebHTMLView.mm:
2319         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2320
2321 2008-03-28  Brady Eidson  <beidson@apple.com>
2322
2323         Reviewed by Darin Adler
2324
2325         More Kit->Core WebArchive changes.
2326
2327         Create an archive from the current selection in a frame
2328
2329         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
2330           easily in a followup
2331
2332 2008-03-28  Brady Eidson  <beidson@apple.com>
2333
2334         Reviewed by Sam Weinig
2335
2336         WebArchive saga continues - Can now make archives from ranges in WebCore
2337
2338         * DOM/WebDOMOperations.mm:
2339         (-[DOMRange webArchive]):
2340         (-[DOMRange markupString]):
2341
2342         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
2343         * WebView/WebArchiver.mm:
2344
2345 2008-03-28  Brady Eidson  <beidson@apple.com>
2346
2347         Reviewed by Sam Weinig
2348
2349         More Kit->Core webarchive code movement
2350
2351         * DOM/WebDOMOperations.mm:
2352         (-[DOMNode markupString]): Call createFullMarkup() instead
2353
2354         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
2355         * WebView/WebFrameInternal.h: Ditto
2356
2357 2008-03-28  Brady Eidson  <beidson@apple.com>
2358
2359         Reviewed by Sam Weinig
2360
2361         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
2362
2363         * WebView/WebArchiver.h:
2364         * WebView/WebArchiver.mm:
2365         * WebView/WebDataSource.mm:
2366         (-[WebDataSource webArchive]):
2367
2368 2008-03-28  Brady Eidson  <beidson@apple.com>
2369
2370         Reviewed by Sam Weinig
2371
2372         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
2373
2374         * WebView/WebArchiver.h:
2375         * WebView/WebArchiver.mm:
2376
2377 2008-03-28  Brady Eidson  <beidson@apple.com>
2378
2379         Reviewed by Darin
2380
2381         "Yet another transitional step" to empty out WebKit-based code for archiving.
2382
2383         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2384         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2385
2386         * DOM/WebDOMOperations.mm:
2387         * WebView/WebArchiver.mm:
2388         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2389
2390 2008-03-27  Brady Eidson  <beidson@apple.com>
2391
2392         Reviewed by Adam Roben
2393
2394         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
2395         as the push to core-ify WebArchives continues.
2396
2397         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
2398         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
2399         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
2400         (as in "while archiving a page") are accepting of null or empty data.
2401
2402         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
2403
2404         * WebView/WebDataSource.mm:
2405         (-[WebDataSource mainResource]): Call DocumentLoader implementation
2406         (-[WebDataSource subresources]): Ditto
2407         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
2408         * WebView/WebFrameInternal.h:
2409
2410 2008-03-27  Brady Eidson  <beidson@apple.com>
2411
2412         Reviewed by Adam
2413
2414         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
2415         (more efficient)
2416
2417         * WebView/WebResource.mm:
2418         (-[WebResource _initWithCoreResource:]):
2419         * WebView/WebResourceInternal.h:
2420
2421 2008-03-26  Brady Eidson  <beidson@apple.com>
2422
2423         Build fix - accidentally checked in this change which was work in progress
2424
2425         * DOM/WebDOMOperations.mm:
2426
2427 2008-03-26  Brady Eidson  <beidson@apple.com>
2428
2429         Reviewed by Darin
2430
2431         When we create a WebArchive, we walk every node from some starting point, asking each node
2432         along the way "What are your subresource URLs?"
2433
2434         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
2435         WebCore::Node
2436
2437         * DOM/WebDOMOperations.mm:
2438         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
2439           calling into individual WebCore::Node implementations
2440         * DOM/WebDOMOperationsPrivate.h:
2441
2442 2008-03-26  Brady Eidson  <beidson@apple.com>
2443
2444         Reviewed by Mark Rowe
2445
2446         Part of the continued push to move WebArchive-related code down to WebCore, this
2447         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
2448
2449         * WebView/WebDataSource.mm:
2450         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
2451
2452         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
2453           has now been ported down to WebCore
2454         * WebView/WebFrameInternal.h:
2455
2456 2008-03-26  Mark Rowe  <mrowe@apple.com>
2457
2458         Rubber-stamped by Brady Eidson.
2459
2460         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
2461
2462         * Configurations/WebKit.xcconfig:
2463
2464 2008-03-26  Mark Rowe  <mrowe@apple.com>
2465
2466         Reviewed by David Hyatt.
2467
2468         Make the Ahem font antialias correctly on Acid3 on Tiger.
2469
2470         * WebCoreSupport/WebSystemInterface.m:
2471         (InitWebCoreSystemInterface):
2472
2473 2008-03-26  Mark Rowe  <mrowe@apple.com>
2474
2475         Fix the Mac build.
2476
2477         * MigrateHeaders.make: Copy the newly generated header into the right place.
2478
2479 2008-03-25  Brady Eidson  <beidson@apple.com>
2480
2481         Reviewed by Beth Dakin
2482
2483         Remove entirely unused internal method
2484
2485         * WebView/WebArchiver.h:
2486         * WebView/WebArchiver.mm:
2487
2488 2008-03-25  Brady Eidson  <beidson@apple.com>
2489
2490         Reviewed by Adam Roben
2491
2492         <rdar://problem/5819308> - View Source is empty when view webarchives
2493
2494         * WebCore.base.exp:
2495         * loader/DocumentLoader.cpp:
2496         (WebCore::DocumentLoader::setParsedArchiveData):
2497         (WebCore::DocumentLoader::parsedArchiveData):
2498         * loader/DocumentLoader.h:
2499
2500         * loader/FrameLoader.cpp:
2501         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
2502           in the DocumentLoader
2503
2504 2008-03-25  Dan Bernstein  <mitz@apple.com>
2505
2506         Reviewed by Darin Adler.
2507
2508         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
2509           Reopen All Windows From Last Session causes crash
2510
2511         * WebView/WebHTMLView.mm:
2512         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
2513         check.
2514
2515 2008-03-25  Brady Eidson  <beidson@apple.com>
2516
2517         Reviewed by Jon Honeycutt's rubberstamp
2518
2519         Fix a leak with the new WebArchive setup
2520
2521         * WebView/WebArchive.mm:
2522         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2523
2524 2008-03-25  Brady Eidson  <beidson@apple.com>
2525
2526         Reviewed by Darin
2527
2528         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
2529         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
2530
2531         * WebCoreSupport/WebFrameLoaderClient.h:
2532         * WebCoreSupport/WebFrameLoaderClient.mm:
2533         (WebFrameLoaderClient::WebFrameLoaderClient):
2534
2535 2008-03-25  Brady Eidson  <beidson@apple.com>
2536
2537         Reviewed by Darin
2538
2539         Remove newly obsolete FrameLoaderClient methods
2540
2541         * WebCoreSupport/WebFrameLoaderClient.h:
2542         * WebCoreSupport/WebFrameLoaderClient.mm:
2543
2544 2008-03-25  Brady Eidson  <beidson@apple.com>
2545
2546         Release build fix
2547
2548         * WebView/WebArchive.mm:
2549         (-[WebArchive subresources]):
2550         (-[WebArchive subframeArchives]):
2551
2552 2008-03-25  Brady Eidson  <beidson@apple.com>
2553
2554         Reviewed by Darin
2555
2556         <rdar://problem/4516169> - Support WebArchives on Windows
2557         And paves the way for many future WebArchive bug fixes and enhancements
2558
2559         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
2560         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
2561          * WebArchive <-> LegacyWebArchive
2562          * WebResource <-> ArchiveResource
2563          * WebUnarchivingState <-> ArchiveResourceCollection
2564  
2565         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
2566         and now exist in WebCore
2567
2568         * WebCoreSupport/WebFrameLoaderClient.mm:
2569         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
2570         (WebFrameLoaderClient::finalSetupForReplace):
2571         (WebFrameLoaderClient::setDefersLoading):
2572         (WebFrameLoaderClient::willUseArchive):
2573         (WebFrameLoaderClient::isArchiveLoadPending):
2574         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2575         (WebFrameLoaderClient::clearArchivedResources):
2576         (WebFrameLoaderClient::createFrame):
2577
2578         * WebView/WebArchive.mm:
2579         (+[WebArchivePrivate initialize]):
2580         (-[WebArchivePrivate init]):
2581         (-[WebArchivePrivate initWithCoreArchive:]):
2582         (-[WebArchivePrivate coreArchive]):
2583         (-[WebArchivePrivate setCoreArchive:]):
2584         (-[WebArchivePrivate dealloc]):
2585         (-[WebArchivePrivate finalize]):
2586         (-[WebArchive init]):
2587         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2588         (-[WebArchive initWithData:]):
2589         (-[WebArchive initWithCoder:]):
2590         (-[WebArchive encodeWithCoder:]):
2591         (-[WebArchive mainResource]):
2592         (-[WebArchive subresources]):
2593         (-[WebArchive subframeArchives]):
2594         (-[WebArchive data]):
2595         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
2596         (-[WebArchive WebCore::]):
2597         * WebView/WebArchiveInternal.h: Added.
2598
2599         * WebView/WebDataSource.mm:
2600         (-[WebDataSourcePrivate dealloc]):
2601         (-[WebDataSource _addSubframeArchives:]):
2602         (-[WebDataSource _documentFragmentWithArchive:]):
2603         (-[WebDataSource subresourceForURL:]):
2604         (-[WebDataSource addSubresource:]):
2605         * WebView/WebDataSourceInternal.h:
2606
2607         * WebView/WebFrame.mm:
2608         (-[WebFrame loadArchive:]):
2609         * WebView/WebFrameInternal.h:
2610
2611         * WebView/WebHTMLRepresentation.mm:
2612         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2613
2614         * WebView/WebResource.mm:
2615         (+[WebResourcePrivate initialize]):
2616         (-[WebResourcePrivate init]):
2617         (-[WebResourcePrivate initWithCoreResource:]):
2618         (-[WebResourcePrivate dealloc]):
2619         (-[WebResourcePrivate finalize]):
2620         (-[WebResource initWithCoder:]):
2621         (-[WebResource encodeWithCoder:]):
2622         (-[WebResource data]):
2623         (-[WebResource URL]):
2624         (-[WebResource MIMEType]):
2625         (-[WebResource textEncodingName]):
2626         (-[WebResource frameName]):
2627         (-[WebResource _initWithCoreResource:WebCore::]):
2628         (-[WebResource WebCore::]):
2629         (-[WebResource _ignoreWhenUnarchiving]):
2630         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2631         (-[WebResource _fileWrapperRepresentation]):
2632         (-[WebResource _response]):
2633         (-[WebResource _stringValue]):
2634         * WebView/WebResourceInternal.h: Added.
2635         * WebView/WebResourcePrivate.h:
2636
2637         * WebView/WebUnarchivingState.h: Removed.
2638         * WebView/WebUnarchivingState.m: Removed.
2639
2640 2008-03-24  Oliver Hunt  <oliver@apple.com>
2641
2642         Reviewed by Mark Rowe.
2643
2644         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
2645         <http://bugs.webkit.org/show_bug.cgi?id=18030>
2646
2647         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
2648         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
2649         <http://bugs.webkit.org/show_bug.cgi?id=18057>
2650
2651         * WebView/WebHTMLView.mm:
2652         (-[WebHTMLView keyDown:]):
2653
2654 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2655
2656         Reviewed by Maciej, landed by Brady
2657
2658         Bug 3580: iFrames Appear to be Cached
2659         <http://bugs.webkit.org/show_bug.cgi?id=3580>
2660
2661         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
2662         <http://bugs.webkit.org/show_bug.cgi?id=15486>
2663
2664         Bug 15554: Reload causes <object> to use old data
2665         <http://bugs.webkit.org/show_bug.cgi?id=15554>
2666
2667         If a page is reloaded, a child frame's URL can not be taken from a history item.
2668
2669         * WebView/WebFrame.mm:
2670         (-[WebFrame _loadURL:referrer:intoChild:]):
2671
2672 2008-03-24  Darin Adler  <darin@apple.com>
2673
2674         Reviewed by Beth.
2675
2676         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
2677
2678         * History/WebHistoryItem.mm:
2679         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
2680         * WebView/WebDataSource.mm:
2681         (-[WebDataSource _URL]): Ditto.
2682         (-[WebDataSource unreachableURL]): Ditto.
2683         * WebView/WebHTMLView.mm:
2684         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2685
2686         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2687         * History/WebHistory.mm:
2688         * Misc/WebElementDictionary.mm:
2689         * Misc/WebNSAttributedStringExtras.mm:
2690         Remove unneeded imports of KURL.h.
2691
2692 2008-03-24  Brady Eidson  <beidson@apple.com>
2693
2694         Reviewed by Darin's rubberstamp
2695
2696         Rename this file for upcoming work.
2697
2698         * WebView/WebArchive.m: Removed.
2699         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
2700
2701 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
2702
2703         Build fix.
2704
2705         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
2706
2707 2008-03-23  Oliver Hunt  <oliver@apple.com>
2708
2709         Reviewed by Maciej.
2710
2711         Bug 17670: Key events may improperly propagate from iframe to parent frame
2712         <http://bugs.webkit.org/show_bug.cgi?id=17670>
2713         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
2714         <http://bugs.webkit.org/show_bug.cgi?id=16381>
2715
2716         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
2717         as that results in us dispatching the key events for each frame going up the frame
2718         tree.
2719
2720         * WebView/WebHTMLView.mm:
2721         (-[WebHTMLView keyDown:]):
2722         (-[WebHTMLView keyUp:]):
2723         (-[WebHTMLView flagsChanged:]):
2724
2725 2008-03-21  Timothy Hatcher  <timothy@apple.com>
2726
2727         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
2728         http://bugs.webkit.org/show_bug.cgi?id=17980
2729
2730         Reviewed by Adam.
2731
2732         The new highlight drawing was not honoring the fade value, so it was
2733         always drawing at full opacity. The animation code didn't match Windows
2734         and the new highlight anyway, so it has been removed. The highlight
2735         how just detaches when it is hidden.
2736
2737         * WebCoreSupport/WebInspectorClient.mm:
2738         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
2739         (-[WebInspectorWindowController close]): Ditto.
2740         (-[WebInspectorWindowController highlightNode:]): Call attach.
2741         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
2742         * WebInspector/WebNodeHighlight.h:
2743         * WebInspector/WebNodeHighlight.m:
2744         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2745         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
2746         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
2747         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
2748         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
2749         * WebInspector/WebNodeHighlightView.h:
2750         * WebInspector/WebNodeHighlightView.m:
2751         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
2752
2753 2008-03-20  Mark Rowe  <mrowe@apple.com>
2754
2755         Reviewed by Sam Weinig.
2756
2757         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
2758         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
2759         command-line.
2760
2761         * Configurations/WebKit.xcconfig:
2762
2763 2008-03-20  Adam Roben  <aroben@apple.com>
2764
2765         Make WebNodeHighlightView use InspectorController to do its painting
2766
2767         Reviewed by Tim Hatcher.
2768
2769         * WebCoreSupport/WebInspectorClient.mm:
2770         (-[WebInspectorWindowController highlightNode:]): Pass the
2771         InspectorController to the WebNodeHighlight, and don't call
2772         setHighlightedNode: (which has been removed).
2773         (-[WebInspectorWindowController hideHighlight]): Removed call to
2774         setHighlightedNode:.
2775         * WebInspector/WebNodeHighlight.h:
2776           - Replaced _highlightNode with _inspectorController
2777           - Removed _highlightedNode accessors
2778           - Added -inspectorController method
2779         * WebInspector/WebNodeHighlight.m:
2780         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
2781         takes an InspectorController* and stores it in _inspectorController.
2782         (-[WebNodeHighlight dealloc]): Removed code dealing with
2783         _highlightedNode.
2784         (-[WebNodeHighlight inspectorController]): Added.
2785         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
2786         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
2787         GraphicsContexts to be based on a flipped CGContext, so we have to
2788         specify that this view is flipped.
2789         (-[WebNodeHighlightView drawRect:]): Changed to create a
2790         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
2791
2792 2008-03-18  David Hyatt  <hyatt@apple.com>
2793
2794         Add support for a preference in WebKit that can be used in nightly builds to test full page
2795         zoom.
2796
2797         Reviewed by Antti
2798
2799         * WebView/WebPreferenceKeysPrivate.h:
2800         * WebView/WebView.mm:
2801         (-[WebView setTextSizeMultiplier:]):
2802         (-[WebView canMakeTextSmaller]):
2803         (-[WebView makeTextSmaller:]):
2804         (-[WebView canMakeTextLarger]):
2805         (-[WebView makeTextLarger:]):
2806         (-[WebView canMakeTextStandardSize]):
2807         (-[WebView makeTextStandardSize:]):
2808
2809 2008-03-17  Eric Seidel  <eric@webkit.org>
2810
2811         Reviewed by darin.
2812
2813         Export _NPN_IntFromIdentifier as part of our NPAPI interface
2814
2815         * Plugins/WebNetscapePluginPackage.m:
2816         (-[WebNetscapePluginPackage load]):
2817
2818 2008-03-14  Brady Eidson  <beidson@apple.com>
2819
2820         Reviewed by Brian Dash's rubberstamp
2821
2822         Remove a class declaration for a class that has never existed
2823
2824         * WebView/WebResource.h:
2825
2826 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
2827
2828         Unify concept of enabling the Mac Java bridge.
2829
2830         Reviewed by Darin and Anders.
2831
2832         * Plugins/WebPluginJava.h: Removed unused file.
2833         * WebCoreSupport/WebFrameLoaderClient.h:
2834         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
2835         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
2836         (WebFrameLoaderClient::javaApplet): Ditto.
2837
2838 2008-03-13  Antti Koivisto  <antti@apple.com>
2839
2840         Reviewed by Darin.
2841
2842         * ForwardingHeaders/wtf/Deque.h: Added.
2843
2844 2008-03-13  Anders Carlsson  <andersca@apple.com>
2845
2846         Reviewed by Adam.
2847
2848         Call originalRequest, not initialRequest.
2849         
2850         * WebView/WebDataSource.mm:
2851         (-[WebDataSource initialRequest]):
2852
2853 2008-03-12  Darin Adler  <darin@apple.com>
2854
2855         Reviewed by John Sullivan.
2856
2857         - cleanup after removing the bridge
2858
2859         * DOM/WebDOMOperations.mm:
2860         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
2861
2862         * Misc/WebCoreStatistics.mm:
2863         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
2864
2865         * Plugins/WebBaseNetscapePluginView.mm:
2866         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
2867         _frameLoader method.
2868         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2869         Ditto.
2870         * Plugins/WebPluginController.mm:
2871         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
2872
2873         * WebCoreSupport/WebFrameLoaderClient.mm:
2874         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
2875         method. Without this we could leave a stale frame pointer around.
2876         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
2877         caller of the _isMainFrame method.
2878         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
2879         _frameLoader method.
2880         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
2881
2882         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
2883         turned out to be unused.
2884         (core): Added overload for DocumentFragment.
2885         (kit): Ditto.
2886         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
2887         to FrameLoader with _private->coreFrame->loader().
2888         (-[WebFrame _attachScriptDebugger]): Ditto.
2889         (-[WebFrame _clearCoreFrame]): Added.
2890         (-[WebFrame _updateBackground]): More of the same.
2891         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
2892         (-[WebFrame _unmarkAllMisspellings]): Ditto.
2893         (-[WebFrame _hasSelection]): Ditto.
2894         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
2895         (-[WebFrame _findFrameWithSelection]): Ditto.
2896         (-[WebFrame _dataSource]): Ditto.
2897         (-[WebFrame _addData:]): Streamlined code a bit.
2898         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
2899         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
2900         (-[WebFrame _isDescendantOfFrame:]): Ditto.
2901         (-[WebFrame _bodyBackgroundColor]): Ditto.
2902         (-[WebFrame _isFrameSet]): Ditto.
2903         (-[WebFrame _firstLayoutDone]): Ditto.
2904         (-[WebFrame _loadType]): Ditto.
2905         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
2906         (-[WebFrame name]): Ditto.
2907         (-[WebFrame DOMDocument]): Ditto.
2908         (-[WebFrame frameElement]): Ditto.
2909         (-[WebFrame provisionalDataSource]): Ditto.
2910         (-[WebFrame dataSource]): Ditto.
2911         (-[WebFrame loadRequest:]): Ditto.
2912         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
2913         (-[WebFrame loadArchive:]): Ditto.
2914         (-[WebFrame stopLoading]): Ditto.
2915         (-[WebFrame reload]): Ditto.
2916         (-[WebFrame findFrameNamed:]): Ditto.
2917         (-[WebFrame parentFrame]): Ditto.
2918         (-[WebFrame childFrames]): Ditto.
2919         (-[WebFrame windowObject]): Ditto.
2920         (-[WebFrame globalContext]): Ditto.
2921
2922         * WebView/WebFrameInternal.h: Added overloads of core and kit.
2923         Removed method declarations.
2924
2925         * WebView/WebHTMLRepresentation.mm:
2926         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
2927         (formElementFromDOMElement): Ditto.
2928         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
2929         (inputElementFromDOMElement): Ditto.
2930         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
2931         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
2932         (-[WebHTMLRepresentation formForElement:]): Ditto.
2933         (-[WebHTMLRepresentation currentForm]): Ditto.
2934         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
2935         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
2936         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
2937
2938         * WebView/WebHTMLView.mm:
2939         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
2940         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2941         Call createFragmentFromText directly instead of via WebFrame.
2942         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2943         Moved layout calls here from WebFrame.
2944         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
2945         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
2946         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
2947         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
2948         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
2949         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2950         Moved code here from WebFrame.
2951         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
2952         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
2953         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
2954         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
2955         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
2956         (-[WebHTMLView rectsForTextMatches]): Ditto.
2957
2958         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
2959
2960         * WebView/WebPDFView.mm:
2961         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
2962         _frameLoader method.
2963
2964         * WebView/WebRenderNode.mm:
2965         (copyRenderNode): Moved code here from WebFrame.
2966         (-[WebRenderNode initWithWebFrameView:]): Ditto.
2967
2968         * WebView/WebResource.mm:
2969         (-[WebResource _stringValue]): Moved code here from WebFrame.
2970
2971         * WebView/WebView.mm:
2972         (-[WebView _close]): Use core function intsead of _frameLoader method.
2973         (-[WebView setCustomTextEncodingName:]): Ditto.
2974         (-[WebView setHostWindow:]): Moved code here from WebFrame.
2975         (aeDescFromJSValue): Moved this here from WebFrame.
2976         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
2977
2978 2008-03-12  Darin Adler  <darin@apple.com>
2979
2980         Reviewed by Anders.
2981
2982         - http://bugs.webkit.org/show_bug.cgi?id=17640
2983           eliminate WebCoreFrameBridge
2984
2985         Moved all the code from the bridge into WebFrame. This need not be the final
2986         home of these methods -- they can be moved closer to their callers and improved
2987         further -- but it eliminates the bridge without requiring a rewrite of the code.
2988         It's a fairly mechanical process (just adding underscores to method names really).
2989
2990         There's even a chance that some of the methods are unused. Those we can remove
2991         after checking if that's so.
2992
2993         * DOM/WebDOMOperations.mm:
2994         (-[DOMNode markupString]): Use WebFrame rather than bridge.
2995         (-[DOMDocument webFrame]): Changed to use the core and kit functions
2996         instead of using the bridge.
2997         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
2998         (-[DOMRange markupString]): Ditto.
2999         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3000
3001         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3002         * History/WebHistoryItem.mm: Ditto.
3003
3004         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3005         * Misc/WebCoreStatistics.mm:
3006         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3007
3008         * Misc/WebElementDictionary.mm: Removed unneeded import.
3009
3010         * Misc/WebKitStatistics.m:
3011         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3012         * Misc/WebKitStatisticsPrivate.h: Ditto.
3013
3014         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3015         * Misc/WebNSPasteboardExtras.mm: Ditto.
3016
3017         * Plugins/WebBaseNetscapePluginView.mm:
3018         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3019         rather than bridge.
3020
3021         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3022         * Plugins/WebNetscapePluginStream.mm: Ditto.
3023
3024         * Plugins/WebPluginContainerCheck.mm:
3025         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3026         bridge to get to the WebCore::Frame.
3027
3028         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3029         * Plugins/WebPluginController.mm:
3030         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3031         rather than bridge.
3032
3033         * WebCoreSupport/WebEditorClient.mm:
3034         (selectorForKeyEvent): Tweaked comment.
3035
3036         * WebCoreSupport/WebFrameBridge.h: Removed.
3037         * WebCoreSupport/WebFrameBridge.mm: Removed.
3038
3039         * WebCoreSupport/WebFrameLoaderClient.mm:
3040         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3041         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3042         I could remove this function entirely, but it looks like the Qt port is using it.
3043
3044         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3045
3046         * WebView/WebArchiver.mm:
3047         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3048         (+[WebArchiver archiveNode:]): Ditto.
3049         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3050
3051         * WebView/WebDataSource.mm:
3052         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3053         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3054         (-[WebDataSource subresources]): Ditto.
3055         (-[WebDataSource subresourceForURL:]): Ditto.
3056
3057         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3058
3059         * WebView/WebFrame.mm:
3060         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3061         (core): Go directly to the core frame, not via the bridge.
3062         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3063         Remove the code to deal with the bridge.
3064         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3065         shouldCreateRenderers flag, formerly on the bridge.
3066         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3067         (aeDescFromJSValue): Moved here from bridge.
3068         (-[WebFrame _domain]): Ditto.
3069         (-[WebFrame _addData:]): Ditto.
3070         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3071         (-[WebFrame _nodesFromList:]): Ditto.
3072         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3073         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3074         (-[WebFrame _selectedString]): Ditto.
3075         (-[WebFrame _stringForRange:]): Ditto.
3076         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3077         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3078         (-[WebFrame _sendScrollEvent]): Ditto.
3079         (-[WebFrame _drawRect:]): Ditto.
3080         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3081         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3082         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3083         (-[WebFrame _copyRenderTree:]): Ditto.
3084         (inputElementFromDOMElement): Ditto.
3085         (formElementFromDOMElement): Ditto.
3086         (-[WebFrame _elementWithName:inForm:]): Ditto.
3087         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3088         (-[WebFrame _elementIsPassword:]): Ditto.
3089         (-[WebFrame _formForElement:]): Ditto.
3090         (-[WebFrame _currentForm]): Ditto.
3091         (-[WebFrame _controlsInForm:]): Ditto.
3092         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3093         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3094         (-[WebFrame _URLWithAttributeString:]): Ditto.
3095         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3096         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3097         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3098         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3099         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3100         (-[WebFrame _rectsForTextMatches]): Ditto.
3101         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3102         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3103         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3104         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3105         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3106         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3107         (-[WebFrame _baseURL]): Ditto.
3108         (-[WebFrame _stringWithData:]): Ditto.
3109         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3110         (-[WebFrame _needsLayout]): Ditto.
3111         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3112         (-[WebFrame _accessibilityTree]): Ditto.
3113         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3114         (-[WebFrame _setDrawsBackground:]): Ditto.
3115         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3116         Ditto.
3117         (-[WebFrame _selectionGranularity]): Ditto.
3118         (-[WebFrame _convertToNSRange:]): Ditto.
3119         (-[WebFrame _convertToDOMRange:]): Ditto.
3120         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3121         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3122         (-[WebFrame _markDOMRange]): Ditto.
3123         (-[WebFrame _markedTextNSRange]): Ditto.
3124         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3125         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3126         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3127         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3128         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3129         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3130         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3131         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3132         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3133         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3134         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3135         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3136         (-[WebFrame _typingStyle]): Ditto.
3137         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3138         (-[WebFrame _fontForSelection:]): Ditto.
3139         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3140         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3141         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3142         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3143         (-[WebFrame _canProvideDocumentSource]): Ditto.
3144         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3145         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3146         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3147         function. Couldn't just keep the bridge method because this was already here with the same name.
3148         (-[WebFrame _selectedNSRange]): Ditto.
3149         (-[WebFrame _selectNSRange:]): Ditto.
3150         (-[WebFrame dealloc]): Remove bridge-related code.
3151         (-[WebFrame finalize]): Ditto.
3152
3153         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3154         Removed the bridge parameter from the init method. Removed the #if blocks that
3155         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3156         Removed the _bridge method.
3157
3158         * WebView/WebFrameView.mm: Removed the _bridge method.
3159
3160         * WebView/WebHTMLRepresentation.mm:
3161         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3162         field.
3163         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3164         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3165         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3166         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3167         (-[WebHTMLRepresentation documentSource]): Ditto.
3168         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3169         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3170         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3171         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3172         (-[WebHTMLRepresentation formForElement:]): Ditto.
3173         (-[WebHTMLRepresentation currentForm]): Ditto.
3174         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3175         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3176         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3177
3178         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3179
3180         * WebView/WebHTMLView.mm:
3181         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3182         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3183         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3184         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3185         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3186         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3187         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3188         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3189         (-[WebHTMLView drawSingleRect:]): Ditto.
3190         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3191         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3192         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3193         (-[WebHTMLView knowsPageRange:]): Ditto.
3194         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3195         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3196         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3197         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3198         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3199         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3200         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3201         (-[WebHTMLView startSpeaking:]): Ditto.
3202         (-[WebHTMLView _updateFontPanel]): Ditto.
3203         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3204         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3205         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3206         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3207         (-[WebHTMLView selectedRange]): Ditto.
3208         (-[WebHTMLView markedRange]): Ditto.
3209         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3210         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3211         (-[WebHTMLView insertText:]): Ditto.
3212         (-[WebTextCompleteController _insertMatch:]): Ditto.
3213         (-[WebTextCompleteController doCompletion]): Ditto.
3214         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3215         (-[WebHTMLView string]): Ditto.
3216         (-[WebHTMLView selectedString]): Ditto.
3217         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3218         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3219         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3220         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3221         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3222         (-[WebHTMLView rectsForTextMatches]): Ditto.
3223         * WebView/WebRenderNode.mm:
3224         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3225         * WebView/WebResource.mm:
3226         (-[WebResource _stringValue]): Ditto.
3227
3228         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3229
3230         * WebView/WebView.mm:
3231         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3232         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3233         (-[WebView _setInViewSourceMode:]): Ditto.
3234         (-[WebView _inViewSourceMode]): Ditto.
3235         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3236         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3237         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3238         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3239         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
3240         (-[WebView setEditable:]): Ditto.
3241         (-[WebView setTypingStyle:]): Ditto.
3242         (-[WebView typingStyle]): Ditto.
3243         (-[WebView replaceSelectionWithNode:]): Ditto.
3244         (-[WebView replaceSelectionWithText:]): Ditto.
3245         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
3246         (-[WebView replaceSelectionWithArchive:]): Ditto.
3247         (-[WebView _insertNewlineInQuotedContent]): Ditto.
3248         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
3249
3250 2008-03-12  David Hyatt  <hyatt@apple.com>
3251
3252         Make the zoom factor a float and not a percent.
3253
3254         Reviewed by antti
3255
3256         * WebView/WebView.mm:
3257         (-[WebView _setZoomMultiplier:isTextOnly:]):
3258
3259 2008-03-11  David Hyatt  <hyatt@apple.com>
3260
3261         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
3262         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
3263         can zoom the page in, out or reset it to the standard size.
3264
3265         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
3266         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
3267         win.
3268
3269         Reviewed by Tim H.
3270
3271         * WebCoreSupport/WebFrameBridge.mm:
3272         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
3273         * WebView/WebDocumentInternal.h:
3274         * WebView/WebHTMLView.mm:
3275         (-[WebHTMLView viewDidMoveToSuperview]):
3276         * WebView/WebPDFView.h:
3277         * WebView/WebPDFView.mm:
3278         (-[WebPDFView _zoomOut:]):
3279         (-[WebPDFView _zoomIn:]):
3280         (-[WebPDFView _resetZoom:]):
3281         (-[WebPDFView _canZoomOut]):
3282         (-[WebPDFView _canZoomIn]):
3283         (-[WebPDFView _canResetZoom]):
3284         * WebView/WebView.mm:
3285         (-[WebViewPrivate init]):
3286         (-[WebView setTextSizeMultiplier:]):
3287         (-[WebView textSizeMultiplier]):
3288         (-[WebView _setZoomMultiplier:isTextOnly:]):
3289         (-[WebView _zoomMultiplier:]):
3290         (-[WebView _realZoomMultiplier]):
3291         (-[WebView _realZoomMultiplierIsTextOnly]):
3292         (-[WebView _canZoomOut:]):
3293         (-[WebView _canZoomIn:]):
3294         (-[WebView _zoomOut:isTextOnly:]):
3295         (-[WebView _zoomIn:isTextOnly:]):
3296         (-[WebView _canResetZoom:]):
3297         (-[WebView _resetZoom:isTextOnly:]):
3298         (-[WebView canMakeTextSmaller]):
3299         (-[WebView makeTextSmaller:]):
3300         (-[WebView canMakeTextLarger]):
3301         (-[WebView makeTextLarger:]):
3302         (-[WebView canMakeTextStandardSize]):
3303         (-[WebView makeTextStandardSize:]):
3304         (-[WebView setPageSizeMultiplier:]):
3305         (-[WebView pageSizeMultiplier]):
3306         (-[WebView canZoomPageIn]):
3307         (-[WebView zoomPageIn:]):
3308         (-[WebView canZoomPageOut]):
3309         (-[WebView zoomPageOut:]):
3310         (-[WebView canResetPageZoom]):
3311         (-[WebView resetPageZoom:]):
3312         (-[WebView _searchWithSpotlightFromMenu:]):
3313         * WebView/WebViewInternal.h:
3314         * WebView/WebViewPrivate.h:
3315
3316 2008-03-12  Dan Bernstein  <mitz@apple.com>
3317
3318         Reviewed by Darin Adler and Sam Weinig.
3319
3320         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
3321
3322         * WebCoreSupport/WebSystemInterface.m:
3323         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
3324         WKGetNSFontATSUFontId Tiger-only.
3325
3326 2008-03-12  Darin Adler  <darin@apple.com>
3327
3328         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
3329           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
3330
3331         * WebView/WebFrame.mm:
3332         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
3333         up pointer from the bridge to the frame. (My next check-in removes the bridge
3334         entirely, but we need this until then.)
3335
3336 2008-03-11  Darin Adler  <darin@apple.com>
3337
3338         Reviewed by Sam.
3339
3340         - remove all bridge-related things from WebCore except the bridge itself
3341
3342         * DOM/WebDOMOperations.mm:
3343         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
3344
3345         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
3346
3347         * Plugins/WebPluginController.mm: Ditto.
3348
3349         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
3350         init and close methods. Added a setWebFrame: method.
3351
3352         * WebCoreSupport/WebFrameBridge.mm:
3353         (-[WebFrameBridge setWebFrame:]): Added.
3354
3355         * WebCoreSupport/WebFrameLoaderClient.mm:
3356         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
3357         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
3358         bridge here. Soon we will be able to remove this entirely!
3359         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
3360         into WebFrame from the bridge.
3361
3362         * WebView/WebFrame.mm:
3363         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
3364         now owned by the frame.
3365         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
3366         debugger under GC without this!
3367         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
3368         use WebFrameLoaderClient instead of the bridge.
3369         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
3370         This is code that used to live in the bridge's init function.
3371         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
3372         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
3373         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
3374         the WebView is now the bridge's owner.
3375         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
3376         WebCore::Frame::bridge function directly to use the kit function instead.
3377         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
3378         This code won't last long -- we're eliminating the bridge soon.
3379         (-[WebFrame finalize]): Ditto.
3380
3381         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
3382         for creating frames.
3383
3384         * WebView/WebView.mm:
3385         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
3386         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
3387         where we have to allocate a WebFrameBridge and then immediately release it.
3388
3389 2008-03-11  Darin Adler  <darin@apple.com>
3390
3391         Reviewed by Anders.
3392
3393         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
3394
3395         * WebCoreSupport/WebFrameLoaderClient.mm:
3396         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
3397         to setView. A couple lines later, there is a call to _install, which sets the
3398         view to the scroll view.
3399
3400         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
3401
3402         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
3403         this file, since it's used by Safari.
3404         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
3405         * WebView/WebDynamicScrollBarsView.m:
3406         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
3407         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
3408         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
3409         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
3410         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
3411         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
3412         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
3413         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
3414         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
3415         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
3416         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
3417         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
3418         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
3419         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
3420         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
3421
3422         * WebView/WebFrameView.mm:
3423         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
3424
3425         * WebView/WebView.mm:
3426         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
3427         (-[WebView alwaysShowVerticalScroller]): Ditto.
3428         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
3429         (-[WebView alwaysShowHorizontalScroller]): Ditto.
3430
3431 2008-03-11  Darin Adler  <darin@apple.com>
3432
3433         Reviewed by Sam.
3434
3435         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
3436
3437         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
3438         bridge methods.
3439         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
3440         to recently-created functions.
3441         (WebChromeClient::firstResponder): Moved code here from the bridge.
3442         (WebChromeClient::makeFirstResponder): Ditto.
3443         (WebChromeClient::runOpenPanel): Ditto.
3444         (WebChromeClient::willPopUpMenu): Ditto.
3445
3446         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
3447         is related to creating the bridge and connecting it to WebCore, which will
3448         go next when I eliminate use of the bridge to get to/from the Frame*.
3449         * WebCoreSupport/WebFrameBridge.mm:
3450         (-[WebFrameBridge close]): Moved the code to track the bridge count here
3451         instead of the dealloc and finalize methods.
3452
3453 2008-03-11  Darin Adler  <darin@apple.com>
3454
3455         Reviewed by Mitz.
3456
3457         - update code affected by Range changes
3458
3459         * Misc/WebNSAttributedStringExtras.mm:
3460         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
3461         * WebView/WebHTMLRepresentation.mm:
3462         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3463         Use Range::create.
3464         * WebView/WebHTMLView.mm:
3465         (-[WebHTMLView attributedString]): Ditto.
3466
3467 2008-03-10  Darin Adler  <darin@apple.com>
3468
3469         Reviewed by Sam.
3470
3471         - eliminate keyboard UI mode method from WebCoreFrameBridge
3472
3473         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
3474         * WebCoreSupport/WebChromeClient.mm:
3475         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
3476         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
3477         fields for keyboard UI mode.
3478         * WebCoreSupport/WebFrameBridge.mm:
3479         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
3480         method.
3481         (-[WebFrameBridge finalize]): Ditto.
3482         * WebView/WebView.mm: Moved the keyboard mode code in here.
3483         (-[WebView _close]): Remove observer from the distributed notification
3484         center as well as the normal one.
3485         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
3486         here from the bridge.
3487         (-[WebView _keyboardUIMode]): Ditto.
3488         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
3489
3490 2008-03-10  Darin Adler  <darin@apple.com>
3491
3492         Reviewed by Sam.
3493
3494         - eliminate Java applet methods from WebCoreFrameBridge
3495
3496         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
3497         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
3498         the ones that load Java applets.
3499         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
3500         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3501
3502 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
3503
3504         Reviewed by Darin.
3505
3506         Done with Lars.
3507
3508         Simplified WebViewFactory's refreshPlugins method to only refresh the
3509         plugins and not reload the frames anymore since that's now done in a
3510         platform independent manner by WebCore::Page.
3511
3512         Also removed the now unused pluginNameForMIMEType and
3513         pluginSupportsMIMEType methods.
3514
3515         * WebCoreSupport/WebViewFactory.mm:
3516         * WebView/WebFrame.mm:
3517         * WebView/WebFrameInternal.h:
3518         * WebView/WebView.mm:
3519
3520 2008-03-08  Mark Rowe  <mrowe@apple.com>
3521
3522         Reviewed by Darin Adler.
3523
3524         Fix 64-bit build with GCC 4.2.
3525
3526         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
3527         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
3528         * History/WebHistoryItem.mm: Ditto.
3529         * Misc/WebElementDictionary.mm: Ditto.
3530         * WebCoreSupport/WebFrameLoaderClient.mm:
3531         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
3532         variable being unused in 64-bit.
3533         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
3534         * WebView/WebHTMLView.mm:
3535         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
3536         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
3537
3538 2008-03-08  Darin Adler  <darin@apple.com>
3539
3540         Reviewed by Adele.
3541
3542         - eliminate custom highlight methods from WebCoreFrameBridge
3543
3544         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
3545         * WebCoreSupport/WebChromeClient.mm:
3546         (WebChromeClient::customHighlightRect): Moved code here from bridge.
3547         (WebChromeClient::paintCustomHighlight): Ditto.
3548         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
3549
3550 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
3551
3552         Unify concept of enabling Netscape Plug-in API (NPAPI).
3553
3554         Reviewed by Darin.
3555
3556         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
3557
3558         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
3559         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
3560
3561         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
3562         #if ENABLE(NETSCAPE_PLUGIN_API).
3563         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
3564         * Plugins/WebBaseNetscapePluginView.h: Ditto.
3565         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
3566         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
3567         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
3568         * Plugins/WebBasePluginPackage.h: Ditto.
3569         * Plugins/WebBasePluginPackage.m: Ditto.
3570         (+[WebBasePluginPackage pluginWithPath:]):
3571         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
3572         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3573         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
3574         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
3575         * Plugins/WebNetscapePluginPackage.h: Ditto.
3576         * Plugins/WebNetscapePluginPackage.m: Ditto.
3577         * Plugins/WebNetscapePluginStream.h: Ditto.
3578         * Plugins/WebNetscapePluginStream.mm: Ditto.
3579         * Plugins/WebPluginDatabase.m: Ditto.
3580         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
3581         * Plugins/npapi.m: Ditto.
3582         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3583         (WebFrameLoaderClient::objectContentType):
3584         (WebFrameLoaderClient::createPlugin):
3585         * WebView/WebHTMLView.mm: Ditto.
3586         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3587         * WebView/WebHTMLViewInternal.h: Ditto.
3588
3589         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
3590         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
3591         category to (WebInternal) category so we don't expose the ENABLE() macro
3592         from the private header.
3593         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
3594         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
3595         * WebView/WebFrameInternal.h: Ditto.
3596         * WebView/WebFramePrivate.h: Ditto.
3597
3598 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
3599
3600         Reviewed by Darin.
3601
3602         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
3603         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
3604
3605         * WebView/WebPreferences.m:
3606         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
3607         the one used in Safari.
3608
3609 2008-03-07  Mark Rowe  <mrowe@apple.com>
3610
3611         Reviewed by Oliver Hunt.
3612
3613         Fix WebKit build with GCC 4.2.
3614
3615         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
3616
3617 2008-03-07  Darin Adler  <darin@apple.com>
3618
3619         Reviewed by Adam.
3620
3621         - eliminated WebCoreFrameBridge runOpenPanel
3622
3623         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
3624         * WebCoreSupport/WebChromeClient.mm:
3625         (WebChromeClient::runOpenPanel): Added.
3626         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
3627         FileChooser so it can get a result from the UI delegate.
3628         (-[WebOpenPanelResultListener dealloc]): Added.
3629         (-[WebOpenPanelResultListener finalize]): Added.
3630         (-[WebOpenPanelResultListener cancel]): Added.
3631         (-[WebOpenPanelResultListener chooseFilename:]): Added.
3632
3633 2008-03-06  Darin Adler  <darin@apple.com>
3634
3635         Reviewed by Mitz.
3636
3637         - fix regression test failures from the visited-link change
3638
3639         * History/WebHistory.mm:
3640         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
3641         to turn off visited links if there is no history object. Also call
3642         removeAllVisitedLinks so we can start over from scratch with the new history.
3643
3644 2008-03-06  Dan Bernstein  <mitz@apple.com>
3645
3646         Reviewed by Darin Adler.
3647
3648         - fix a regression from r30741: a crash under
3649           WebFrameLoaderClient::createPlugin() when showing a Mail message with
3650           an attachment
3651
3652         * WebCoreSupport/WebFrameLoaderClient.mm:
3653         (WebFrameLoaderClient::createPlugin):
3654
3655 2008-03-06  Darin Adler  <darin@apple.com>
3656
3657         - fix Tiger build
3658
3659         * History/WebHistory.mm: Added include of WebTypesInternal.h.
3660
3661 2008-03-06  Darin Adler  <darin@apple.com>
3662
3663         - fix Release build
3664
3665         * History/WebHistory.mm:
3666         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
3667         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
3668         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
3669
3670 2008-03-06  Darin Adler  <darin@apple.com>
3671
3672         Reviewed by Mitz.
3673
3674         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
3675           REGRESSION: iframes are added to Safari's History menu
3676           by separating the visited link machinery from global history
3677
3678         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
3679         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
3680         method name, since it's on a private object.
3681         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
3682         PageGroup::removeAllVisitedLinks function if the last URL was removed.
3683         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
3684         method name, since it's on a private object.
3685         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
3686         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
3687         method name, since it's on a private object.
3688         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3689         Ditto.
3690         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
3691         to correctly return the error by using the newer version of writeToURL: and
3692         removed the FIXME about that.
3693         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
3694         for every link in the history.
3695         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
3696         (-[WebHistory addItem:]): Moved into the WebPrivate category.
3697         (-[WebHistory addItemForURL:]): Ditto.
3698         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
3699         create an item and already know its title.
3700         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
3701         (-[WebHistory containsItemForURLString:]): Ditto.
3702         (-[WebHistory removeItem:]): Ditto.
3703         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
3704         (-[WebHistory _itemForURLString:]): Ditto.
3705         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
3706
3707         * History/WebHistoryInternal.h: Added.
3708         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
3709         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
3710         Also reorganized what was left behind.
3711
3712         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
3713         * WebCoreSupport/WebChromeClient.mm:
3714         (WebChromeClient::populateVisitedLinks): Added a call to the new
3715         -[WebHistory _addVisitedLinksToPageGroup:] method.
3716
3717         * WebCoreSupport/WebFrameLoaderClient.mm:
3718         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
3719         -[WebHistory _addItemForURL:title:] method.
3720
3721 2008-03-05  Adam Roben  <aroben@apple.com>
3722
3723         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
3724
3725         Reviewed by Kevin M.
3726
3727         * WebView/WebFrame.mm:
3728         * WebView/WebScriptDebugDelegate.mm:
3729         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
3730         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
3731
3732 2008-03-05  Adam Roben  <aroben@apple.com>
3733
3734         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
3735
3736         Reviewed by Kevin M.
3737
3738         * WebView/WebCoreScriptDebuggerImp.h:
3739         * WebView/WebCoreScriptDebuggerImp.mm:
3740         * WebView/WebFrame.mm:
3741         (-[WebFrame _attachScriptDebugger]):
3742         * WebView/WebFrameInternal.h:
3743
3744 2008-03-05  Adam Roben  <aroben@apple.com>
3745
3746         Remove WebScriptDebugger
3747
3748         Uses of WebScriptDebugger have been replaced with
3749         WebCoreScriptDebuggerImp.
3750
3751         Reviewed by Kevin M.
3752
3753         * WebView/WebFrame.mm:
3754         (-[WebFramePrivate dealloc]): Use delete instead of release since
3755         WebCoreScriptDebuggerImp is a C++ class.
3756         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
3757         WebCoreScriptDebuggerImp.
3758         (-[WebFrame _detachScriptDebugger]): Ditto.
3759         * WebView/WebFrameInternal.h:
3760         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
3761         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
3762         * WebView/WebView.mm:
3763
3764 2008-03-05  Adam Roben  <aroben@apple.com>
3765
3766         Remove -webFrame and -globalObject from WebScriptDebugger
3767
3768         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
3769
3770         Reviewed by Kevin M.
3771
3772         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
3773         parameter to the constructor.
3774         * WebView/WebCoreScriptDebuggerImp.mm:
3775         (toWebFrame): Added.
3776         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
3777         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
3778         WindowScriptObject ourselves instead of asking WebScriptDebugger for
3779         it.
3780         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
3781         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
3782         (WebCoreScriptDebuggerImp::exception): Ditto.
3783         * WebView/WebScriptDebugDelegate.mm:
3784         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
3785         WebScriptDebuggerImp's constructor.
3786         * WebView/WebScriptDebugDelegatePrivate.h: Removed
3787         -webFrame/-globalObject.
3788
3789 2008-03-05  Adam Roben  <aroben@apple.com>
3790
3791         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
3792
3793         Reviewed by Kevin M.
3794
3795         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
3796         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
3797         lifetime.
3798         * WebView/WebCoreScriptDebuggerImp.mm:
3799           - Added declaration of -[WebScriptCallFrame
3800             _initWithGlobalObject:caller:state:].
3801           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
3802         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
3803         now-unnecessary initialization of m_topCallFrame.
3804         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
3805         with its implementation. The one difference between this
3806         implementation and the old enterFrame: method is that we don't hand
3807         our reference to m_topCallFrame to _initWithGlobalObject: -- that
3808         method must now retain the passed-in WebScriptCallFrame manually.
3809         (WebCoreScriptDebuggerImp::atStatement):
3810         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
3811         with its implementation.
3812         (WebCoreScriptDebuggerImp::exception):
3813         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
3814         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
3815         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
3816         to retain the passed-in caller.
3817         * WebView/WebScriptDebugDelegatePrivate.h:
3818           - Removed _current ivar
3819           - Removed enterFrame:/leaveFrame declarations.
3820
3821 2008-03-05  Adam Roben  <aroben@apple.com>
3822
3823         Remove -parsedSource: from WebScriptDebugger
3824
3825         Reviewed by Kevin M.
3826
3827         * WebView/WebCoreScriptDebuggerImp.mm:
3828         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
3829         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
3830         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
3831         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
3832
3833 2008-03-05  Adam Roben  <aroben@apple.com>
3834
3835         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
3836
3837         Reviewed by Kevin M.
3838
3839         * WebView/WebCoreScriptDebuggerImp.mm:
3840         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
3841         trhough to callEvent instead of duplicating its code here.
3842         (WebCoreScriptDebuggerImp::callEvent): Moved code from
3843         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
3844         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
3845         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
3846         (WebCoreScriptDebuggerImp::exception): Moved code from
3847         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
3848         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
3849         -leavingFrame:, and -exceptionRaised:.
3850         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
3851
3852 2008-03-05  Adam Roben  <aroben@apple.com>
3853
3854         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
3855
3856         Reviewed by Kevin M.
3857
3858         * WebView/WebCoreScriptDebuggerImp.mm:
3859         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
3860         -[WebScriptDebugger hitStatement:sourceId:line:].
3861         * WebView/WebScriptDebugDelegate.mm:
3862         (-[WebScriptDebugger webFrame]): Added.
3863         * WebView/WebScriptDebugDelegatePrivate.h:
3864
3865 2008-03-05  Adam Roben  <aroben@apple.com>
3866
3867         Remove WebCoreScriptDebugger
3868
3869         Reviewed by Kevin M.
3870
3871         * WebView/WebCoreScriptDebugger.h: Removed.
3872         * WebView/WebCoreScriptDebugger.mm: Removed.
3873         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
3874         with WebScriptDebugger.
3875         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
3876         delegate] with just m_debugger.
3877         (toNSString): Moved here from WebCoreScriptDebugger.mm.
3878         (toNSURL): Ditto.
3879         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
3880         (WebCoreScriptDebuggerImp::sourceParsed):
3881         (WebCoreScriptDebuggerImp::callEvent):
3882         (WebCoreScriptDebuggerImp::atStatement):
3883         (WebCoreScriptDebuggerImp::returnEvent):
3884         (WebCoreScriptDebuggerImp::exception):
3885         * WebView/WebScriptDebugDelegate.mm:
3886         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
3887         WebCoreScriptDebuggerImp, so initialize it properly.
3888         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
3889         WebCoreScriptDebuggerImp.
3890
3891 2008-03-05  Adam Roben  <aroben@apple.com>
3892
3893         Move WebCoreScriptDebuggerImp to its own source files
3894
3895         Also changed WebCoreScriptDebuggerImp coding style to match our style
3896         guidelines.
3897
3898         Reviewed by Kevin M.
3899
3900         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
3901         function.
3902         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
3903         implementation.
3904         (toNSURL): Made no longer static.
3905         * WebView/WebCoreScriptDebuggerImp.h: Added.
3906         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
3907         WebCoreScriptDebugger.mm and cleaned up.
3908         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
3909         (WebCoreScriptDebuggerImp::sourceParsed):
3910         (WebCoreScriptDebuggerImp::callEvent):
3911         (WebCoreScriptDebuggerImp::atStatement):
3912         (WebCoreScriptDebuggerImp::returnEvent):
3913         (WebCoreScriptDebuggerImp::exception):
3914
3915 2008-03-05  Adam Roben  <aroben@apple.com>
3916
3917         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
3918
3919         Reviewed by Kevin M.
3920
3921         * WebView/WebCoreScriptDebugger.h:
3922           - Removed newFrameWithGlobalObject:caller:state: from
3923             WebScriptDebugger protocol
3924           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
3925           - Removed _current ivar from WebCoreScriptDebugger
3926         * WebView/WebCoreScriptDebugger.mm:
3927         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
3928         the delegate.
3929         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
3930         * WebView/WebScriptDebugDelegate.mm:
3931         (-[WebScriptDebugger dealloc]): Added code to release _current.
3932         (-[WebScriptDebugger enterFrame:]): Added. Code came from
3933         WebCoreScriptDebugger.
3934         (-[WebScriptDebugger leaveFrame]): Ditto.
3935         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
3936
3937 2008-03-05  Adam Roben  <aroben@apple.com>
3938
3939         Remove WebCoreScriptCallFrame
3940
3941         Reviewed by Tim.
3942
3943         * WebView/WebCoreScriptDebugger.h:
3944           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
3945           - Replaced -newWrapperForFrame: with
3946             -newFrameWithGlobalObject:caller:state:
3947           - Removed WebCoreScriptCallFrame interface.
3948         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
3949         with WebScriptCallFrame.
3950         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
3951         -newFrameWithGlobalObject:caller:state.
3952         (-[WebCoreScriptDebugger _leaveFrame]):
3953         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
3954         _private ivar to be of type WebScriptCallFramePrivate*.
3955         * WebView/WebScriptDebugDelegate.mm:
3956           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
3957           - Added WebScriptCallFramePrivate
3958         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
3959         (-[WebScriptDebugger hitStatement:sourceId:line:]):
3960         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
3961         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
3962         (-[WebScriptCallFramePrivate dealloc]): Added.
3963         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
3964         Code came from WebCoreScriptCallFrame.
3965         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
3966         ivar.
3967         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
3968         _private with direct access of _private's ivars.
3969         (-[WebScriptCallFrame caller]): Ditto.
3970         (-[WebScriptCallFrame scopeChain]): Ditto.
3971         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
3972
3973 2008-03-05  Adam Roben  <aroben@apple.com>
3974
3975         Move -_convertValueToObjcValue to WebScriptCallFrame
3976
3977         Reviewed by Darin.
3978
3979         * WebView/WebCoreScriptDebugger.h: Removed declaration of
3980         -_convertValueToObjcValue.
3981         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
3982         * WebView/WebScriptDebugDelegate.mm:
3983         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
3984         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
3985         (-[WebScriptCallFrame scopeChain]): Changed to call
3986         -_convertValueToObjcValue on self instead of _private.
3987         (-[WebScriptCallFrame exception]): Ditto.
3988         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
3989
3990 2008-03-05  Adam Roben  <aroben@apple.com>
3991
3992         Move -exception and -evaluateWebScript: to WebScriptCallFrame
3993
3994         Reviewed by Darin.
3995
3996         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
3997         and -evaluateWebScript:.
3998         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
3999         -evaluateWebScript:.
4000         * WebView/WebScriptDebugDelegate.mm:
4001         (-[WebScriptCallFrame exception]): Added. Code came from
4002         -[WebCoreScriptCallFrame exception].
4003         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
4004         -[WebCoreScriptCallFrame evaluateWebScript:].
4005
4006 2008-03-05  Adam Roben  <aroben@apple.com>
4007
4008         Move -scopeChain to WebScriptCallFrame
4009
4010         Reviewed by Darin.
4011
4012         * WebView/WebCoreScriptDebugger.h:
4013           - Added declarations of -globalObject and -_convertValueToObjcValue:
4014             to WebCoreScriptCallFrame
4015           - Removed declaration of -scopeChain.
4016         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
4017         within the main WebCoreScriptCallFrame implementation.
4018         (-[WebCoreScriptCallFrame globalObject]): Added.
4019         * WebView/WebScriptDebugDelegate.mm:
4020         (-[WebScriptCallFrame scopeChain]): Added. Code came from
4021         -[WebCoreScriptCallFrame scopeChain].
4022
4023 2008-03-05  Adam Roben  <aroben@apple.com>
4024
4025         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
4026
4027         Reviewed by Darin.
4028
4029         * WebView/WebCoreScriptDebugger.h:
4030           - Removed #else case of #ifdef __cplusplus since this file is only
4031             ever used by C++ Objective-C files
4032           - Removed 'using KJS::ExecState' statement since we prefer not to
4033             have using statements in header files
4034           - Consequently prefixed uses of ExecState with KJS::
4035           - Added declaration of toNSString method that takes a const
4036             UString&
4037           - Added declaration of -[WebCoreScriptCallFrame state]
4038           - Removed declaration of -[WebCoreScriptCallFrame functionName]
4039         * WebView/WebCoreScriptDebugger.mm:
4040         (toNSString): Made this no longer static.
4041         (-[WebCoreScriptCallFrame state]): Added.
4042         * WebView/WebScriptDebugDelegate.mm:
4043         (-[WebScriptCallFrame functionName]): Added. Code came from
4044         -[WebCoreScriptCallFrame functionName], though I changed some nested
4045         ifs into early returns.
4046
4047 2008-03-05  Adam Roben  <aroben@apple.com>
4048
4049         Move WebCoreScriptDebugger to WebKit
4050
4051         Reviewed by Darin.
4052
4053         * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
4054         * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
4055         (toNSString):
4056         (toNSURL):
4057         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
4058         (WebCoreScriptDebuggerImp::sourceParsed):
4059         (WebCoreScriptDebuggerImp::callEvent):
4060         (WebCoreScriptDebuggerImp::atStatement):
4061         (WebCoreScriptDebuggerImp::returnEvent):
4062         (WebCoreScriptDebuggerImp::exception):
4063         (+[WebCoreScriptDebugger initialize]):
4064         (-[WebCoreScriptDebugger initWithDelegate:]):
4065         (-[WebCoreScriptDebugger dealloc]):
4066         (-[WebCoreScriptDebugger finalize]):
4067         (-[WebCoreScriptDebugger delegate]):
4068         (-[WebCoreScriptDebugger _enterFrame:]):
4069         (-[WebCoreScriptDebugger _leaveFrame]):
4070         (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
4071         (-[WebCoreScriptCallFrame _setWrapper:]):
4072         (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
4073         (-[WebCoreScriptCallFrame dealloc]):
4074         (-[WebCoreScriptCallFrame wrapper]):
4075         (-[WebCoreScriptCallFrame caller]):
4076         (-[WebCoreScriptCallFrame scopeChain]):
4077         (-[WebCoreScriptCallFrame functionName]):
4078         (-[WebCoreScriptCallFrame exception]):
4079         (-[WebCoreScriptCallFrame evaluateWebScript:]):
4080         * WebView/WebScriptDebugDelegate.mm: Updated header path.
4081         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
4082
4083 2008-03-05  Anders Carlsson  <andersca@apple.com>
4084
4085         Reviewed by Geoff.
4086
4087         Include file changes.
4088         
4089         * Plugins/WebBaseNetscapePluginView.mm:
4090         * Plugins/WebNetscapePluginPackage.m:
4091
4092 2008-03-04  Timothy Hatcher  <timothy@apple.com>
4093
4094         Reviewed by Darin Adler.
4095
4096         <rdar://problem/5720160> Browser windows "do nothing" while modal
4097         dialog or menu is up due to run loop modes (or while scrolling)
4098
4099         Add new API that lets a WebView be scheduled with multiple runloops and modes.
4100         This lets loading continue when in a nested runloop or in a different mode.
4101
4102         * Misc/WebKitVersionChecks.h: Add a new version define:
4103         WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
4104         * WebView/WebView.mm:
4105         (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
4106         the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
4107         (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
4108         (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
4109         * WebView/WebViewPrivate.h: Add the new pending API methods.
4110
4111 2008-03-04  Anders Carlsson  <andersca@apple.com>
4112
4113         Reviewed by Darin.
4114
4115         Fix crash that happens when trying to load a page with a Java applet.
4116         
4117         * WebCoreSupport/WebFrameLoaderClient.mm:
4118         Don't release the names and values array - the kit method returns an autoreleased array.
4119
4120 2008-03-04  Darin Adler  <darin@apple.com>
4121
4122         Reviewed by Adam.
4123
4124         - fix 200+ failing regression tests
4125         - fix http://bugs.webkit.org/show_bug.cgi?id=17668
4126           Vertical scrollbar at slashdot.org is randomly not shown
4127
4128         * WebCoreSupport/WebFrameLoaderClient.mm:
4129         (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
4130         code here to exactly match the way it was before it was moved from WebCore. I had
4131         introduced a storage leak and that was causing problems with scroll bars!
4132
4133 2008-03-04  Darin Adler  <darin@apple.com>
4134
4135         Reviewed by Adam.
4136
4137         - remove WebCoreFrameBridge reapplyStyles method
4138
4139         * WebView/WebHTMLView.mm:
4140         (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
4141
4142 2008-03-04  Darin Adler  <darin@apple.com>
4143
4144         Reviewed by Adam.
4145
4146         - eliminate WebCoreFrameBridge createFrameViewWithNSView
4147
4148         * WebCoreSupport/WebFrameLoaderClient.mm:
4149         (WebFrameLoaderClient::transitionToCommittedForNewPage):
4150         Moved code here from createFrameViewWithNSView.
4151
4152 2008-03-04  Darin Adler  <darin@apple.com>
4153
4154         Reviewed by Adam.
4155
4156         - removed WebCoreFrameBridge scrollOverflowInDirection
4157
4158         * WebView/WebFrameView.mm:
4159         (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
4160         EventHandler directly instead of using the bridge.
4161         (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
4162         of the ones from the bridge.
4163         (-[WebFrameView scrollToEndOfDocument:]): Ditto.
4164         (-[WebFrameView _pageVertically:]): Ditto.
4165         (-[WebFrameView _pageHorizontally:]): Ditto.
4166         (-[WebFrameView _scrollLineVertically:]): Ditto.
4167         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
4168
4169 2008-03-04  Darin Adler  <darin@apple.com>
4170
4171         Reviewed by Adam.
4172
4173         - remove WebCoreFrameBridge installInFrame: method
4174
4175         * WebCoreSupport/WebFrameLoaderClient.mm:
4176         (WebFrameLoaderClient::transitionToCommittedF