Adopt the formal protocols where necessary.
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-08-04  Mark Rowe  <mrowe@apple.com>
2
3         Reviewed by Kevin Decker.
4
5         Adopt the formal protocols where necessary.
6         Final part of fix for <rdar://problem/5853147>.
7
8         * WebCoreSupport/WebInspectorClient.mm:
9         * WebView/WebHTMLView.mm:
10         * WebView/WebView.mm:
11         (-[WebView _openFrameInNewWindowFromMenu:]):
12
13 2008-08-04  Mark Rowe  <mrowe@apple.com>
14
15         Reviewed by Darin Adler.
16
17         Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
18         Part one of fix for <rdar://problem/5853147>.
19
20         * Misc/EmptyProtocolDefinitions.h:
21         * WebKitPrefix.h:
22
23 2008-08-04  Brady Eidson  <beidson@apple.com>
24
25         Reviewed by Mitz Pettel
26
27         Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.
28
29         This broke in r31355 when we stopped returning nil WebResources when there was nil
30         resource data.
31
32         * WebView/WebResource.mm:
33         (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil
34           when the resource data is null.
35
36 2008-08-02  Matt Lilek  <webkit@mattlilek.com>
37
38         Reviewed by Tim Hatcher.
39
40         Update the window gradient offset to match the inspector toolbar's new height.
41
42         * WebCoreSupport/WebInspectorClient.mm:
43         (-[WebInspectorWindowController window]):
44
45 2008-08-01  Anders Carlsson  <andersca@apple.com>
46
47         Reviewed by Jon.
48
49         <rdar://problem/6120206>
50         Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
51         
52         Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.
53
54         * Plugins/WebBaseNetscapePluginStream.mm:
55         (-[WebBaseNetscapePluginStream wantsAllStreams]):
56
57 2008-07-31  Anders Carlsson  <andersca@apple.com>
58
59         Reviewed by Darin.
60
61         <rdar://problem/5949410>
62         Add the ability to transfer a given application cache to a new database.
63
64         * Misc/WebKitNSStringExtras.h:
65         * Misc/WebKitNSStringExtras.m:
66         (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
67         New method which returns the appopriate cache directory for a given bundle identifier.
68         
69         * WebView/WebDataSource.mm:
70         (-[WebDataSource _transferApplicationCache:]):
71         Transfer the application cache.
72         
73         * WebView/WebDataSourcePrivate.h:
74         * WebView/WebView.mm:
75         (WebKitInitializeApplicationCachePathIfNecessary):
76         Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
77
78 2008-07-31  John Sullivan  <sullivan@apple.com>
79
80         WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs
81
82         Reviewed by Hyatt
83
84         * WebView/WebPreferenceKeysPrivate.h:
85         added WebKitZoomsTextOnlyPreferenceKey
86         
87         * WebView/WebPreferences.mm:
88         (+[WebPreferences initialize]):
89         default value of YES for WebKitZoomsTextOnlyPreferenceKey
90         (-[WebPreferences zoomsTextOnly]):
91         getter for WebKitZoomsTextOnlyPreferenceKey
92         (-[WebPreferences setZoomsTextOnly:]):
93         setter for WebKitZoomsTextOnlyPreferenceKey
94         
95         * WebView/WebPreferencesPrivate.h:
96         declare zoomsTextOnly/setZoomsTextOnly:
97         
98         * WebView/WebView.mm:
99         (-[WebView _preferencesChangedNotification:]):
100         update WebCore::Settings value for zoomsTextOnly
101
102 2008-07-31  David D. Kilzer  <ddkilzer@webkit.org>
103
104         Fix layout test results for webarchive/test-xml-stylesheet.xml
105
106         Reviewed by Darin.
107
108         Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
109         for DumpRenderTree.
110
111         * WebView/WebHTMLRepresentationInternal.h: Added.
112
113 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
114
115         Release build fix.
116
117         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
118         Don't define to npErr in release builds, as it is only used for logging.
119
120 2008-07-31  John Sullivan  <sullivan@apple.com>
121
122         Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
123         drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard
124
125         Reviewed by Dan
126
127         * WebView/WebHTMLView.mm:
128         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
129         include Leopard in the #ifdef that forces a layout if needed
130
131 2008-07-30  Brady Eidson  <beidson@apple.com>
132
133         Reviewed by Adam and Hyatt
134
135         Fix for <rdar://problem/6099748>
136
137         * WebView/WebView.mm:
138         (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" 
139           quirk when running under iWeb 2
140
141 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
142
143         Rubber-stamped by Maciej.
144
145         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
146         call sites now).
147
148         * ForwardingHeaders/kjs/JSLock.h: Removed.
149         * Misc/WebCoreStatistics.mm:
150         (+[WebCoreStatistics javaScriptObjectsCount]):
151         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
152         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
153         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
154         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
155         (+[WebCoreStatistics shouldPrintExceptions]):
156         (+[WebCoreStatistics setShouldPrintExceptions:]):
157         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
158         * Plugins/WebBaseNetscapePluginStream.mm:
159         (-[WebBaseNetscapePluginStream wantsAllStreams]):
160         * Plugins/WebBaseNetscapePluginView.mm:
161         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
162         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
163         (-[WebBaseNetscapePluginView start]):
164         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
165         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
166         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
167         (-[WebBaseNetscapePluginView loadPluginRequest:]):
168         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
169         * Plugins/WebPluginController.mm:
170         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
171         (-[WebPluginController startAllPlugins]):
172         (-[WebPluginController stopAllPlugins]):
173         (-[WebPluginController addPlugin:]):
174         (-[WebPluginController destroyPlugin:]):
175         (-[WebPluginController destroyAllPlugins]):
176         * WebView/WebFrame.mm:
177         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
178         * WebView/WebScriptDebugDelegate.mm:
179         (-[WebScriptCallFrame evaluateWebScript:]):
180         * WebView/WebView.mm:
181         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
182
183 2008-07-30  Beth Dakin  <bdakin@apple.com>
184
185         Reviewed by Anders Carlsson.
186
187         Fixes <rdar://problem/6041390>
188
189         Adds the ability to have a frame that is "disconnected" from the 
190         main frame from the perspective of top and parent in 
191         Javascript.
192
193         * WebView/WebFrame.mm:
194         (-[WebFrame _setIsDisconnectedFrame]):
195         * WebView/WebFramePrivate.h:
196
197 2008-07-29  Mark Rowe  <mrowe@apple.com>
198
199         Tweak to the build fix to keep Dan happy.
200
201         * Plugins/WebBaseNetscapePluginView.mm:
202         * WebView/WebHTMLView.mm:
203
204 2008-07-29  Mark Rowe  <mrowe@apple.com>
205
206         Build fix.
207
208         * Plugins/WebBaseNetscapePluginView.mm:
209         (-[WebBaseNetscapePluginView inputContext]):
210         * WebView/WebHTMLView.mm:
211
212 2008-07-28  Anders Carlsson  <andersca@apple.com>
213
214         Reviewed by Kevin Decker.
215
216         Based on a patch by Dimcho Balev.
217         
218         https://bugs.webkit.org/show_bug.cgi?id=18676
219         <rdar://problem/6106578>
220         Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
221
222         * Plugins/WebBaseNetscapePluginStream.h:
223         Add NPP_GetValue pointer.
224         
225         * Plugins/WebBaseNetscapePluginStream.mm:
226         (-[WebBaseNetscapePluginStream setPlugin:]):
227         Initialize NPP_GetValue.
228         
229         (-[WebBaseNetscapePluginStream wantsAllStreams]):
230         Call NPP_GetValue.
231         
232         * Plugins/WebPlugInStreamLoaderDelegate.h:
233         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
234         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
235         (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
236         Implement this and call down to the stream.
237
238 2008-07-28  Anders Carlsson  <andersca@apple.com>
239
240         Reviewed by Adam.
241
242         <rdar://problem/6105529> 
243         https://bugs.webkit.org/show_bug.cgi?id=19659
244         Turning off plugins causes crash
245         
246         When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
247         end up in a state where they don't have an event handler. Because of this, we need to 
248         check that the plug-in has been started before calling the event handler.
249         
250         * Plugins/WebBaseNetscapePluginView.mm:
251         (-[WebBaseNetscapePluginView sendActivateEvent:]):
252         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
253         (-[WebBaseNetscapePluginView setHasFocus:]):
254         (-[WebBaseNetscapePluginView mouseDown:]):
255         (-[WebBaseNetscapePluginView mouseUp:]):
256         (-[WebBaseNetscapePluginView mouseEntered:]):
257         (-[WebBaseNetscapePluginView mouseExited:]):
258         (-[WebBaseNetscapePluginView handleMouseMoved:]):
259         (-[WebBaseNetscapePluginView mouseDragged:]):
260         (-[WebBaseNetscapePluginView scrollWheel:]):
261         (-[WebBaseNetscapePluginView keyUp:]):
262         (-[WebBaseNetscapePluginView keyDown:]):
263         (-[WebBaseNetscapePluginView flagsChanged:]):
264         (-[WebBaseNetscapePluginView cut:]):
265         (-[WebBaseNetscapePluginView copy:]):
266         (-[WebBaseNetscapePluginView paste:]):
267         (-[WebBaseNetscapePluginView selectAll:]):
268         (-[WebBaseNetscapePluginView drawRect:]):
269         (-[WebBaseNetscapePluginView inputContext]):
270
271 2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>
272
273         Reviewed by Geoff Garen.
274
275         Changes to accommodate newly named/signatured loading methods in WebCore.
276
277         * Plugins/WebNetscapePluginStream.mm:
278         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
279         * Plugins/WebPluginContainerCheck.mm:
280         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
281         * WebView/WebPDFView.mm:
282         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
283
284 2008-07-21  Mark Rowe  <mrowe@apple.com>
285
286         Reviewed by Sam Weinig.
287
288         <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
289
290         * Configurations/Version.xcconfig:
291         * Info.plist:
292
293 2008-07-21  Anders Carlsson  <andersca@apple.com>
294
295         Reviewed by Geoff.
296
297         <rdar://problem/5820667> 
298         CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
299         
300         Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
301         
302         * Plugins/WebBaseNetscapePluginView.mm:
303         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
304
305 2008-07-21  Mark Rowe  <mrowe@apple.com>
306
307         Reviewed by Adam Roben.
308
309         <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
310
311         Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
312         This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
313
314         * WebView/WebHTMLView.mm:
315
316 2008-07-21  Mark Rowe  <mrowe@apple.com>
317
318         Reviewed by Adam Roben.
319
320         Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
321         only uses objc_msgSend_fpret for long double return values.  For float return
322         values the standard objc_msgSend is used, as on ppc and ppc64.
323
324         * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
325         objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
326         as that method is defined by the Objective-C runtime for x86_64.
327         (CallDelegateReturningFloat):
328
329 2008-07-14  Dan Bernstein  <mitz@apple.com>
330
331         Reviewed by John Sullivan.
332
333         - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
334
335         * Plugins/WebBaseNetscapePluginView.mm:
336         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
337         to account for the case of being drawn into a bitmap context that is not
338         a window's backing store. In that case, there are no valid "rects being
339         drawn" to clip to.
340         * WebView/WebHTMLView.mm:
341         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
342         Added an override of this NSView method which is used in for
343         -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
344         machinery overrides, it sets subviews aside before invoking the
345         superclass implementation. On Tiger, it also updates the layout.
346
347 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
348
349         Reviewed by Geoff Garen.
350
351         Eliminate per-thread JavaScript global data instance support and make arbitrary
352         global data/global object combinations possible.
353
354         * Misc/WebCoreStatistics.mm:
355         (+[WebCoreStatistics javaScriptObjectsCount]):
356         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
357         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
358         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
359         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
360         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
361         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
362
363 2008-07-11  Stephanie Lewis  <slewis@apple.com>
364
365         Reviewed by Darin Adler.
366
367         Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
368
369         * WebView/WebPreferences.m: Removed.
370         * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
371         (+[WebPreferences initialize]): if running in Default enable full  document teardown
372         (-[WebPreferences editableLinkBehavior]):
373         (-[WebPreferences setFullDocumentTeardownEnabled:]):
374         * WebView/WebView.mm:
375         (-[WebView _close]): disable leak messages if using fast teardown
376
377 2008-07-10  Mark Rowe  <mrowe@apple.com>
378
379         Reviewed by Sam Weinig.
380
381         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
382
383         * Configurations/WebKit.xcconfig:
384
385 2008-07-10  Mark Rowe  <mrowe@apple.com>
386
387         Reviewed by Sam Weinig.
388
389         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
390
391         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
392         * WebView/WebFrameLoadDelegate.h: Ditto.
393         * WebView/WebUIDelegate.h: Ditto.
394
395 2008-07-10  Anders Carlsson  <andersca@apple.com>
396
397         Reviewed by Mark.
398         
399         Add availability macros for the new WebPlugin methods.
400
401         * Plugins/WebPlugin.h:
402         * Plugins/WebPluginViewFactory.h:
403
404 2008-07-09  Mark Rowe  <mrowe@apple.com>
405
406         Reviewed by Geoff Garen.
407
408         Don't warn about deprecated functions in production builds.
409
410         * Configurations/Base.xcconfig:
411         * Configurations/DebugRelease.xcconfig:
412
413 2008-07-09  Brady Eidson  <beidson@apple.com>
414
415         Reviewed by Darin
416
417         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
418         has been installed in a frame tree.
419
420         The root of this problem was that calling init() on a new frame could end up calling arbitrary
421         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
422         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
423         destroying the frame.
424
425         Note that each platforms WebKit API layer needs to make this new guarantee:
426         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
427         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
428         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
429
430         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
431         architectural improvement we can make in the future so the individual platform clients are no longer
432         vulnerable to this problem, which should really have been a WebCore issue.
433
434         * WebCoreSupport/WebFrameLoaderClient.mm:
435         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
436           Don't appendChild() the new frame here.
437           Null-check the new frame's page before loading the URL into it, as it might already have been
438           removed from the page.
439
440         * WebView/WebFrame.mm:
441         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
442           go ahead and install the new frame in the frame tree *before* calling init() on it.
443
444 2008-07-09  Anders Carlsson  <andersca@apple.com>
445
446         Reviewed by Darin.
447
448         Make some WebPlugin and WebPluginFactory SPI public.
449         
450         * Plugins/WebPlugin.h:
451         * Plugins/WebPluginPrivate.h:
452         * Plugins/WebPluginViewFactory.h:
453         * Plugins/WebPluginViewFactoryPrivate.h:
454
455 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
456
457         Reviewed by Anders.
458
459         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
460         unsuccessful.
461
462         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
463         newStreamSuccessful.
464         * Plugins/WebBaseNetscapePluginStream.mm:
465         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
466         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
467         newStreamSuccessful to YES.
468         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
469         NPP_DestroyStream if newStreamSuccessful is true.
470
471 2008-07-08  Dan Bernstein  <mitz@apple.com>
472
473         Reviewed by John Sullivan.
474
475         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
476
477         * WebView/WebHTMLView.mm:
478         (-[WebHTMLView addWindowObservers]): Added code to observe when the
479         window goes onscreen.
480         (-[WebHTMLView removeWindowObservers]): Added.
481         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
482         not update when offscreen, calls -setNeedsDisplay: just before it comes
483         onscreen.
484         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
485         * WebView/WebPreferences.m:
486         (+[WebPreferences initialize]): Made updates when offscreen on by
487         default.
488         (-[WebPreferences updatesWhenOffscreen]): Added.
489         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
490         * WebView/WebPreferencesPrivate.h:
491         * WebView/WebView.mm:
492         (-[WebView _preferencesChangedNotification:]): Added code to update the
493         updatesWhenOffscreen setting in WebCore.
494
495 2008-07-07  Anders Carlsson  <andersca@apple.com>
496
497         Reviewed by Darin.
498
499         Speculative fix for     
500         <rdar://problem/5839800>
501         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
502         
503         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
504         
505         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
506         This is usually protected by _private->closed, but in this case it might still be false.
507
508         * WebView/WebHTMLView.mm:
509         (-[WebHTMLView close]):
510
511 2008-07-05  Mark Rowe  <mrowe@apple.com>
512
513         Reviewed by John Sullivan.
514
515         Remove WebSearchableTextView as it has been unused for some time now.
516
517         * Misc/WebSearchableTextView.h: Removed.
518         * Misc/WebSearchableTextView.m: Removed.
519
520 2008-07-05  Mark Rowe  <mrowe@apple.com>
521
522         Reviewed by John Sullivan.
523
524         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
525
526         * Misc/WebNSUserDefaultsExtras.m:
527         (-[NSString _webkit_HTTPStyleLanguageCode]):
528
529 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
530
531         Inspired and reviewed by Mark Rowe.
532
533         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
534
535         * Carbon/HIViewAdapter.m:
536         * DOM/WebDOMOperations.mm:
537         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
538         * DefaultDelegates/WebDefaultPolicyDelegate.m:
539         * History/WebBackForwardList.mm:
540         * History/WebHistory.mm:
541         * History/WebHistoryItem.mm:
542         * History/WebHistoryItemInternal.h:
543         * Misc/WebCoreStatistics.mm:
544         * Misc/WebDownload.m:
545         * Misc/WebGraphicsExtras.c:
546         * Misc/WebKitLogging.h:
547         * Misc/WebKitSystemBits.m:
548         * Misc/WebLocalizableStrings.m:
549         * Misc/WebNSArrayExtras.m:
550         * Misc/WebNSDataExtras.m:
551         * Misc/WebNSDictionaryExtras.m:
552         * Misc/WebNSFileManagerExtras.m:
553         * Misc/WebNSPasteboardExtras.mm:
554         * Misc/WebNSURLExtras.mm:
555         * Misc/WebNSUserDefaultsExtras.m:
556         * Panels/WebAuthenticationPanel.m:
557         * Panels/WebPanelAuthenticationHandler.m:
558         * Plugins/WebBaseNetscapePluginView.mm:
559         * Plugins/WebBasePluginPackage.m:
560         * Plugins/WebNetscapePluginEmbeddedView.mm:
561         * Plugins/WebPluginContainerCheck.mm:
562         * Plugins/WebPluginController.mm:
563         * Plugins/WebPluginDatabase.mm:
564         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
565         * WebCoreSupport/WebKeyGenerator.m:
566         * WebCoreSupport/WebViewFactory.mm:
567         * WebKitPrefix.h:
568         * WebView/WebHTMLRepresentation.mm:
569         * WebView/WebPDFRepresentation.m:
570         * WebView/WebPDFView.mm:
571         * WebView/WebScriptDebugger.mm:
572
573 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
574
575         Reviewed by Darin.
576
577         Disable JSLock for per-thread contexts.
578
579         * Misc/WebCoreStatistics.mm:
580         (+[WebCoreStatistics javaScriptObjectsCount]):
581         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
582         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
583         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
584         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
585         (+[WebCoreStatistics shouldPrintExceptions]):
586         (+[WebCoreStatistics setShouldPrintExceptions:]):
587         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
588         * Plugins/WebBaseNetscapePluginView.mm:
589         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
590         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
591         (-[WebBaseNetscapePluginView start]):
592         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
593         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
594         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
595         (-[WebBaseNetscapePluginView loadPluginRequest:]):
596         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
597         * Plugins/WebPluginController.mm:
598         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
599         (-[WebPluginController startAllPlugins]):
600         (-[WebPluginController stopAllPlugins]):
601         (-[WebPluginController addPlugin:]):
602         (-[WebPluginController destroyPlugin:]):
603         (-[WebPluginController destroyAllPlugins]):
604         * WebView/WebFrame.mm:
605         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
606         * WebView/WebScriptDebugDelegate.mm:
607         (-[WebScriptCallFrame evaluateWebScript:]):
608         * WebView/WebView.mm:
609         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
610         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
611         doesn't need locking. In the future, it may be possible to remove some of these if we
612         establish that this won't make JSC assertions fail (and that we don't want to add such
613         assertions either).
614         Added includes that are now needed.
615
616 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
617
618         Build fix.
619
620         * WebView/WebView.mm:
621
622 2008-07-01  Anders Carlsson  <andersca@apple.com>
623
624         Reviewed by Darin.
625
626         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
627         
628         * Plugins/WebBaseNetscapePluginView.mm:
629         (-[WebBaseNetscapePluginView _createPlugin]):
630         Register the plug-in instance.
631         
632         (-[WebBaseNetscapePluginView _destroyPlugin]):
633         Unegister the plug-in instance.
634         
635         * Plugins/WebNetscapePluginPackage.m:
636         (-[WebNetscapePluginPackage load]):
637         Set NPN_PluginThreadAsyncCall.
638         
639         * Plugins/npapi.mm:
640         (NPN_PluginThreadAsyncCall):
641         Implement this.
642
643 2008-07-01  Dan Bernstein  <mitz@apple.com>
644
645         Reviewed by Darin Adler.
646
647         - WebKit part of moving the method to set the base writing direction from Frame to Editor
648
649         * WebView/WebHTMLView.mm:
650         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
651         Editor method.
652         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
653         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
654
655 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
656
657         Build fix: forgot to check in this file.
658
659         * WebView/WebScriptDebugger.mm:
660         (WebScriptDebugger::WebScriptDebugger):
661
662 2008-06-30  Dan Bernstein  <mitz@apple.com>
663
664         Reviewed by Adele Peterson.
665
666         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
667
668         * WebView/WebHTMLView.mm:
669         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
670         WebCore::Frame::setSelectionBaseWritingDirection() instead of
671         WebCore::Editor::setBaseWritingDirection().
672         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
673         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
674
675 2008-06-28  Darin Adler  <darin@apple.com>
676
677         - fix build
678
679         * WebView/WebView.mm:
680         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
681
682 2008-06-26  Anders Carlsson  <andersca@apple.com>
683
684         Reviewed by Darin.
685
686         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
687         if necessary. Use this for the WebView class. 
688                 
689         * WebView/MainThreadObjectDeallocator.h: Added.
690         * WebView/MainThreadObjectDeallocator.mm: Added.
691         (deallocCallback):
692         (scheduleDeallocateOnMainThread):
693         * WebView/WebView.mm:
694         (-[WebViewPrivate dealloc]):
695         (+[WebView initialize]):
696
697 2008-06-25  Anders Carlsson  <andersca@apple.com>
698
699         Reviewed by Mark.
700
701         <rdar://problem/5984270> 
702         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
703         
704         * WebView/WebView.mm:
705         (tigerMailReleaseIMP):
706         New method that makes sure that the final release happens on the main thread.
707         
708         (-[WebView release]):
709         New method that just calls [super release];
710         
711         (+[WebView initialize]):
712         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
713
714 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
715
716         Reviewed by Geoff.
717
718         Make Machine per-JSGlobalData.
719
720         * WebView/WebScriptDebugger.mm:
721         (WebScriptDebugger::WebScriptDebugger):
722
723 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
724
725         Reviewed by Darin.
726
727         Prepare JavaScript heap for being per-thread.
728
729         * Misc/WebCoreStatistics.mm:
730         (+[WebCoreStatistics javaScriptObjectsCount]):
731         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
732         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
733         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
734         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
735         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
736         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
737
738 2008-06-17  Darin Adler  <darin@apple.com>
739
740         Reviewed by Sam.
741
742         * WebView/WebHTMLView.mm:
743         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
744         to create a CSSMutableStyleDeclaration.
745
746 2008-06-16  Mark Rowe  <mrowe@apple.com>
747
748         Reviewed by Darin Adler.
749
750         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
751
752         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
753         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
754         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
755         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
756
757         * WebView/WebHTMLView.mm:
758         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
759         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
760         * WebView/WebHTMLViewInternal.h:
761         * WebView/WebHTMLViewPrivate.h:
762
763 2008-06-15  Darin Adler  <darin@apple.com>
764
765         - give Frame object functions shorter names: scriptProxy() -> script(),
766           selectionController() -> selection(), animationController() -> animation()
767
768         * Plugins/WebPluginController.mm:
769         (-[WebPluginController webPlugInContainerSelectionColor]):
770         * WebView/WebFrame.mm:
771         (-[WebFrame _attachScriptDebugger]):
772         (-[WebFrame _hasSelection]):
773         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
774         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
775         (-[WebFrame _convertToNSRange:]):
776         (-[WebFrame _convertToDOMRange:]):
777         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
778         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
779         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
780         (-[WebFrame _selectedNSRange]):
781         (-[WebFrame _selectNSRange:]):
782         (-[WebFrame globalContext]):
783         * WebView/WebHTMLView.mm:
784         (-[WebHTMLView _selectedRange]):
785         (-[WebHTMLView _hasSelection]):
786         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
787         (-[WebHTMLView _hasInsertionPoint]):
788         (-[WebHTMLView _isEditable]):
789         (-[WebHTMLView _updateFocusedAndActiveState]):
790         (-[WebHTMLView readSelectionFromPasteboard:]):
791         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
792         (-[WebHTMLView maintainsInactiveSelection]):
793         (-[WebHTMLView paste:]):
794         (isTextInput):
795         (-[WebHTMLView inputContext]):
796         (-[WebTextCompleteController doCompletion]):
797         (-[WebHTMLView selectAll]):
798         (-[WebHTMLView deselectAll]):
799         (-[WebHTMLView selectedAttributedString]):
800         * WebView/WebView.mm:
801         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
802         (-[WebView setSelectedDOMRange:affinity:]):
803         (-[WebView selectedDOMRange]):
804         (-[WebView selectionAffinity]):
805
806 2008-06-15  Darin Adler  <darin@apple.com>
807
808         - rename KJS::List to KJS::ArgList
809
810         * WebView/WebScriptDebugger.h:
811
812 2008-06-15  Darin Adler  <darin@apple.com>
813
814         - new names for more JavaScriptCore files
815
816         * WebView/WebView.mm:
817
818 2008-06-15  Darin Adler  <darin@apple.com>
819
820         - new names for a few key JavaScriptCore files
821
822         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
823         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
824         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
825         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
826         * ForwardingHeaders/kjs/function.h: Removed.
827         * ForwardingHeaders/kjs/internal.h: Removed.
828         * ForwardingHeaders/kjs/object.h: Removed.
829         * ForwardingHeaders/kjs/value.h: Removed.
830         * WebView/WebScriptDebugDelegate.mm:
831
832 2008-06-15  Darin Adler  <darin@apple.com>
833
834         Rubber stamped by Sam.
835
836         - use JS prefix and simpler names for basic JavaScriptCore types,
837           to complement JSValue and JSObject
838
839         * WebView/WebView.mm:
840         (aeDescFromJSValue):
841
842 2008-06-14  Darin Adler  <darin@apple.com>
843
844         Rubber stamped by Sam.
845
846         - new names for kjs_binding.h and kjs_proxy.h
847
848         * WebView/WebFrame.mm:
849         * WebView/WebScriptDebugDelegate.mm:
850         * WebView/WebView.mm:
851
852 2008-06-14  Darin Adler  <darin@apple.com>
853
854         Rubber stamped by Sam.
855
856         - renamed HTMLGenericFormElement to HTMLFormControlElement
857
858         * WebView/WebHTMLRepresentation.mm:
859         (-[WebHTMLRepresentation elementWithName:inForm:]):
860         (-[WebHTMLRepresentation controlsInForm:]):
861
862 2008-06-14  Darin Adler  <darin@apple.com>
863
864         Reviewed by Sam.
865
866         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
867           start ref counts at 1 instead of 0 for speed
868
869         * WebCoreSupport/WebFrameLoaderClient.mm:
870         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
871         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
872         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
873         conventional ones without a special case.
874
875         * WebView/WebDataSource.mm:
876         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
877         this function takes ownership of the DocumentLoader.
878         (-[WebDataSource initWithRequest:]): Use create instead of new.
879         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
880         PassRefPtr and also cleaned up the header a bit.
881
882         * WebView/WebDocumentLoaderMac.h:
883         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
884         functions private.
885
886         * WebView/WebFrame.mm:
887         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
888         of new.
889
890 2008-06-14  Darin Adler  <darin@apple.com>
891
892         Reviewed by Sam.
893
894         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
895           start ref counts at 1 instead of 0 for speed
896
897         * WebView/WebFrame.mm:
898         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
899         * WebView/WebPDFView.mm:
900         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
901
902 2008-06-13  Darin Adler  <darin@apple.com>
903
904         Reviewed by John Sullivan.
905
906         - updated for addition of FormState argument to action policy functions
907         - added WebActionFormKey
908
909         * WebCoreSupport/WebFrameLoaderClient.h:
910         * WebCoreSupport/WebFrameLoaderClient.mm:
911         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
912         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
913         (WebFrameLoaderClient::actionDictionary):
914         * WebKit.exp:
915         * WebView/WebPolicyDelegate.mm:
916         * WebView/WebPolicyDelegatePrivate.h:
917
918 2008-06-12  John Sullivan  <sullivan@apple.com>
919
920         Reviewed by Dan and Darin
921
922         Clear up the confusion about _close (older private method) vs -close (newer public method).
923
924         * WebView/WebView.mm:
925         (-[WebView _isClosed]):
926         simplified style
927         (-[WebView _close]):
928         added a comment about how clients and subclasses should use -close instead
929         (-[WebView dealloc]):
930         call -close instead of _close, so subclasses that override the public method will have the intended behavior
931         (-[WebView close]):
932         added a comment
933         (-[WebView _windowWillClose:]):
934         call -close instead of _close, so subclasses that override the public method will have the intended behavior
935
936         * WebView/WebViewPrivate.h:
937         added a comment about how clients and subclasses should use -close instead
938
939 2008-06-07  Darin Adler  <darin@apple.com>
940
941         Reviewed by Mitz.
942
943         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
944           start ref counts at 1 instead of 0 for speed
945
946         * History/WebHistoryItem.mm:
947         (-[WebHistoryItem init]):
948         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
949         (-[WebHistoryItem initWithURL:target:parent:title:]):
950         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
951         * WebView/WebView.mm:
952         (+[WebView _decodeData:]):
953
954 2008-06-03  Oliver Hunt  <oliver@apple.com>
955
956         Reviewed by Tim.
957
958         Bug 12983: Web Inspector break on the debugger keyword
959         <https://bugs.webkit.org/show_bug.cgi?id=12983>
960
961         Add stubs to allow old webkit debugger interface to build.
962
963         * WebView/WebScriptDebugger.h:
964         * WebView/WebScriptDebugger.mm:
965
966 2008-06-03  Anders Carlsson  <andersca@apple.com>
967
968         Reviewed by Darin.
969
970         <rdar://problem/5980961>
971         
972         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
973         newBottom to be larger than oldBottom which is illegal.
974         
975         * WebView/WebHTMLView.mm:
976         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
977
978 2008-06-02  Anders Carlsson  <andersca@apple.com>
979
980         Reviewed by Mitz.
981
982         Speculative fix for <rdar://problem/5661112> 
983         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
984         
985         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
986         layouts to be triggered.
987         
988         * Plugins/WebBaseNetscapePluginView.mm:
989         (-[WebBaseNetscapePluginView _createPlugin]):
990
991 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
992
993         Reviewed by Darin.
994         
995         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
996         
997         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
998         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
999         setting and retrieving pasteboard types with UTIs, but we don't know of any
1000         applications on Tiger that put only PNG on the pasteboard.
1001
1002         * WebView/WebHTMLView.mm:
1003         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1004         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1005
1006 2008-05-29  Anders Carlsson  <andersca@apple.com>
1007
1008         Reviewed by Brady.
1009
1010         <rdar://problem/5970312> 
1011         icon file specified for stand alone web app causes crash if the icon can't be found
1012         
1013         Handle the case where iconData is null.
1014         
1015         * Misc/WebIconFetcher.mm:
1016         (WebIconFetcherClient::finishedFetchingIcon):
1017
1018 2008-05-29  Anders Carlsson  <andersca@apple.com>
1019
1020         Reviewed by Mitz.
1021
1022         <rdar://problem/5971845>
1023         https://bugs.webkit.org/show_bug.cgi?id=19313
1024         Add version member to NPCocoaEvent
1025
1026         Initialize the version member to 0 for all events.
1027         
1028         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1029         (initializeEvent):
1030         (WebNetscapePluginEventHandlerCocoa::drawRect):
1031         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1032         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1033         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1034         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1035         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1036
1037 2008-05-29  Dan Bernstein  <mitz@apple.com>
1038
1039         Reviewed by Jessica Kahn.
1040
1041         - fix <rdar://problem/5965013> Page 2 does not print correctly
1042
1043         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
1044         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
1045         -viewWillDraw being sent first, which could lead to painting without
1046         valid layout. The fix is to ensure up-to-date layout in those methods
1047         when printing.
1048
1049         * WebView/WebHTMLView.mm:
1050         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1051         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1052
1053 2008-05-28  Anders Carlsson  <andersca@apple.com>
1054
1055         Reviewed by Jon.
1056
1057         Remove workaround, this is no longer a problem.
1058         
1059         * WebView/WebView.mm:
1060         (-[WebView _removeObjectForIdentifier:]):
1061
1062 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
1063
1064         Reviewed by Tim Hatcher.
1065         
1066         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
1067         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
1068         clicking button in returnEvent-crash.html
1069         
1070         Added implementations for willExecuteProgram and didExecuteProgram, which
1071         take care of making sure we're not hanging on to stale data.
1072
1073 2008-05-27  Timothy Hatcher  <timothy@apple.com>
1074
1075         Fixes a bug where unplugging the monitor from a video card and
1076         moving it to another video card would no longer show OpenGL plugins
1077         until you relaunched Safari.
1078
1079         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
1080         attribute to OpenGL contexts
1081
1082         Reviewed by Kevin Decker.
1083
1084         * Plugins/WebBaseNetscapePluginView.mm:
1085         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
1086         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
1087         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
1088
1089 2008-05-25  Mark Rowe  <mrowe@apple.com>
1090
1091         Reviewed by Darin Adler.
1092
1093         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1094
1095         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
1096         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
1097
1098         * WebView/WebFrame.mm:
1099         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
1100         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
1101         * WebView/WebFrameInternal.h:
1102         * WebView/WebFramePrivate.h:
1103
1104 2008-05-23  Timothy Hatcher  <timothy@apple.com>
1105
1106         Fix attaching and detaching the Web Inspector. This change removes
1107         the clunky animation that never looked right and was causing issues
1108         where the inspected WebView would get into a no useable state.
1109
1110         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
1111         can cause the inspected WebVIew to be unusable
1112
1113         Reviewed by Adam Roben.
1114
1115         * WebCoreSupport/WebInspectorClient.mm:
1116         (-[WebInspectorWindowController close]): Removes animation code.
1117         Sets the frame directly and does a displayIfNeeded to prevent
1118         showing the Inspector in the page and in the Inspector window.
1119         (-[WebInspectorWindowController showWindow:]): Removes animation code.
1120         Sets the frame directly.
1121         (-[WebInspectorWindowController attach]): Simplified.
1122         (-[WebInspectorWindowController detach]): Ditto.
1123
1124 2008-05-22  Dan Bernstein  <mitz@apple.com>
1125
1126         Reviewed by Darin Adler.
1127
1128         - fix broken documentation of
1129           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1130
1131         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
1132         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1133
1134 2008-05-22  Timothy Hatcher  <timothy@apple.com>
1135
1136         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
1137
1138         Reviewed by Adam Roben.
1139
1140         * WebCoreSupport/WebInspectorClient.mm:
1141         (-[WebInspectorWindowController showWebInspector:]):
1142         (-[WebInspectorWindowController showErrorConsole:]):
1143         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
1144         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
1145         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1146         * WebInspector/WebInspector.h:
1147         * WebInspector/WebInspector.mm:
1148         (-[WebInspector showConsole:]):
1149         (-[WebInspector showTimeline:]):
1150         (-[WebInspector isDebuggingJavaScript]):
1151         (-[WebInspector toggleDebuggingJavaScript:]):
1152         (-[WebInspector startDebuggingJavaScript:]):
1153         (-[WebInspector stopDebuggingJavaScript:]):
1154         (-[WebInspector isProfilingJavaScript]):
1155         (-[WebInspector toggleProfilingJavaScript:]):
1156         (-[WebInspector startProfilingJavaScript:]):
1157         (-[WebInspector stopProfilingJavaScript:]):
1158
1159 2008-05-22  Josh Aas  <joshmoz@gmail.com>
1160
1161         Reviewed by Anders.
1162
1163         <rdar://problem/5956429> 
1164         https://bugs.webkit.org/show_bug.cgi?id=19192
1165         remove NPNVpluginEventModel, fix example plugin
1166         
1167         * Plugins/WebBaseNetscapePluginView.mm:
1168         (-[WebBaseNetscapePluginView getVariable:value:]):
1169
1170 2008-05-21  Anders Carlsson  <andersca@apple.com>
1171
1172         Reviewed by Maciej.
1173
1174         Add WebIconFetcher.
1175         
1176         * Misc/WebIconFetcher.h: Added.
1177         * Misc/WebIconFetcher.mm: Added.
1178         (WebIconFetcherClient::WebIconFetcherClient):
1179         (WebIconFetcherClient::finishedFetchingIcon):
1180         (WebIconFetcherClient::setFetcher):
1181         (-[WebIconFetcher init]):
1182         (-[WebIconFetcher dealloc]):
1183         (-[WebIconFetcher finalize]):
1184         (-[WebIconFetcher cancel]):
1185         (-[WebIconFetcher _initWithIconFetcher:client:]):
1186         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
1187         * Misc/WebIconFetcherInternal.h: Added.
1188         * WebView/WebFrame.mm:
1189         (-[WebFrame fetchApplicationIcon:selector:]):
1190         * WebView/WebFramePrivate.h:
1191
1192 === End merge of squirrelfish ===
1193
1194 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
1195
1196         Reviewed by Tim Hatcher.
1197         
1198         Updated for API changes from merging with trunk WebCore's new debugger.
1199
1200         * WebView/WebScriptDebugDelegate.mm:
1201         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
1202         exception return, since the DebuggerCallFrame no longer automatically
1203         substitutes the exception for the return value.
1204
1205         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
1206         lexical global object, since the debugger attaches based on dynamic
1207         global object.
1208
1209 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
1210
1211         Reviewed by Oliver Hunt.
1212         
1213         Re-enabled previously disabled debugging functionality.
1214         
1215         There are two major changes from how the WebKit debugger used to work:
1216         
1217         (1) All the interesting bits are implemented down in JavaScriptCore. The
1218         debugger just calls through to KJS::DebuggerCallFrame for everything.
1219         
1220         (2) Instead of copyihng a pointer to an ExecState once, the debugger
1221         copies the DebuggerCallFrame passed to it in each callback. This is
1222         because the VM no longer maintains a fully transparent execution state
1223         to which you can hold a pointer, and the DebuggerCallFrames it vends
1224         are temporaries.
1225         
1226         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
1227         from its function. This is safer than the old method, which was to
1228         hold a stale ExecState* and hope for the best.
1229
1230 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1231
1232         Reviewed by Oliver Hunt.
1233
1234         Updated for API changes in KJS::Debugger.
1235
1236         * WebView/WebFrame.mm:
1237         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
1238         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
1239
1240 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1241
1242         Reviewed by Oliver Hunt.
1243         
1244         Updated WebScriptDebugger API to accept a SourceProvider instead
1245         of a WebCore::String, to avoid copying.
1246
1247         (WebScriptDebugger::sourceParsed): Updated this function not to return
1248         a value.
1249
1250 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1251
1252         Build fix: #ifdef'd out some code that doesn't work anymore.
1253
1254 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1255
1256         Reviewed by Oliver Hunt.
1257         
1258         #ifdef'd out some debugger code that doesn't work anymore.
1259
1260         * WebView/WebScriptDebugDelegate.mm:
1261         (-[WebScriptCallFrame scopeChain]):
1262
1263 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
1264
1265         Build fix.
1266
1267         * ChangeLog:
1268         * WebView/WebScriptDebugDelegate.mm:
1269         (-[WebScriptCallFrame scopeChain]):
1270
1271 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
1272
1273         Reviewed by Oliver Hunt.
1274         
1275         Build fix.
1276
1277 === Start merge of squirrelfish ===
1278
1279 2008-05-21  Darin Adler  <darin@apple.com>
1280
1281         - fix build
1282
1283         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
1284         if we want, but if we do, we should probably make some refinements like checking _private->closed
1285         and applicationIsTerminating.
1286
1287 2008-05-21  Darin Adler  <darin@apple.com>
1288
1289         Reviewed by Anders and Kevin Decker.
1290
1291         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
1292
1293         * WebView/WebView.mm:
1294         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
1295         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
1296         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
1297         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
1298         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
1299
1300 2008-05-19  Stephanie Lewis  <slewis@apple.com>
1301
1302         Reviewed by Darin.
1303     
1304         more fast teardown performance work
1305
1306         * Misc/WebDownload.m:
1307         (-[WebDownloadInternal downloadDidBegin:]):
1308         (-[WebDownloadInternal downloadDidFinish:]):
1309         (-[WebDownloadInternal download:didFailWithError:]):
1310         * WebCoreSupport/WebChromeClient.h:
1311         * WebCoreSupport/WebChromeClient.mm:
1312         (WebChromeClient::disableSuddenTermination):
1313         (WebChromeClient::enableSuddenTermination):
1314
1315 2008-05-18  Dan Bernstein  <mitz@apple.com>
1316
1317         Reviewed by Sam Weinig.
1318
1319         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
1320
1321         * Panels/WebAuthenticationPanel.m:
1322         (-[WebAuthenticationPanel setUpForChallenge:]):
1323
1324 2008-05-16  Timothy Hatcher  <timothy@apple.com>
1325
1326         Removes WebScriptDebugServer files and related calls. This removes
1327         the hooks that Drosera uses for debugging. Now that the Web Inspector
1328         has a better debugger, we don't need these anymore.
1329
1330         Reviewed by Sam Weinig.
1331
1332         * DefaultDelegates/WebScriptDebugServer.h: Removed.
1333         * DefaultDelegates/WebScriptDebugServer.m: Removed.
1334         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
1335         * WebCoreSupport/WebFrameLoaderClient.mm:
1336         * WebKit.exp:
1337         * WebView/WebScriptDebugDelegate.mm:
1338         * WebView/WebScriptDebugger.mm:
1339         (WebScriptDebugger::sourceParsed):
1340         (WebScriptDebugger::callEvent):
1341         (WebScriptDebugger::atStatement):
1342         (WebScriptDebugger::returnEvent):
1343         (WebScriptDebugger::exception):
1344         * WebView/WebView.mm:
1345         (-[WebView _commonInitializationWithFrameName:groupName:]):
1346         * WebView/WebViewPrivate.h:
1347
1348 2008-05-16  Brady Eidson  <beidson@apple.com>
1349
1350         Reviewed by Anders
1351
1352         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
1353
1354         Took the opportunity to touch up another pref that needs the same standardization.
1355         That pref is currently not in use on Mac.
1356
1357         * WebView/WebPreferences.m:
1358         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
1359         (-[WebPreferences _localStorageDatabasePath]):
1360         (-[WebPreferences _setLocalStorageDatabasePath:]):
1361         (-[WebPreferences _ftpDirectoryTemplatePath]):
1362
1363 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
1364
1365         Reviewed by Alice Liu
1366
1367         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
1368
1369         * WebView/WebFrame.mm:
1370         (-[WebFrame _accessibilityTree]):
1371
1372 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1373         
1374         fix mac build
1375
1376         * WebView/WebView.mm:
1377         (-[WebView closeWithFastTeardown]):
1378
1379 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1380
1381         Reviewed by Anders.
1382
1383         Turn on fast teardown.  I added a preference for using full teardown because 
1384         the LEAKS output will be useless without a full teardown.  
1385
1386         preference for fullteardown
1387         * WebView/WebPreferenceKeysPrivate.h:
1388         * WebView/WebPreferences.m:
1389         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1390         (-[WebPreferences fullDocumentTeardownEnabled]):
1391         * WebView/WebPreferencesPrivate.h:
1392         
1393         on application quit dispatch unload events and destroy plugins then exit
1394         * WebView/WebView.mm:
1395         (-[WebView closeWithFastTeardown]):
1396         (-[WebView _close]):
1397         * WebView/WebViewPrivate.h:
1398
1399 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1400
1401         Reviewed by Anders.
1402
1403         get the pending frame unload count from WebCore
1404
1405         * WebView/WebFrame.mm:
1406         (-[WebFrame _pendingFrameUnloadEventCount]):
1407         * WebView/WebFramePrivate.h:
1408
1409 2008-05-15  John Sullivan  <sullivan@apple.com>
1410
1411         Reviewed by Kevin Decker
1412         
1413         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1414           screen when new tab appears
1415           
1416         The highlight should go away entirely, but this simple patch just makes it not jump away.
1417         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1418
1419         * WebInspector/WebNodeHighlight.m:
1420         (-[WebNodeHighlight _repositionHighlightWindow]):
1421         Bail out if target view isn't in a window
1422
1423 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1424
1425         Reviewed by Anders.
1426
1427         Track views that contain plugin instances so that they can be destroyed at application
1428         quit without walking the entire document tree.
1429
1430         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1431         plugins are created and destroyed
1432         * Plugins/WebBaseNetscapePluginView.mm:
1433         (-[WebBaseNetscapePluginView start]):
1434         (-[WebBaseNetscapePluginView stop]):
1435  
1436         Add/remove WebKit plugin views from instance list
1437         * Plugins/WebPluginController.mm:
1438         (-[WebPluginController addPlugin:]):
1439         (-[WebPluginController destroyPlugin:]):
1440         (-[WebPluginController destroyAllPlugins]):
1441
1442         Add a set of views with plugin instances to the WebPluginDatabase
1443         * Plugins/WebPluginDatabase.h:
1444         * Plugins/WebPluginDatabase.mm:
1445         (-[WebPluginDatabase init]):
1446         (-[WebPluginDatabase dealloc]):
1447         (-[WebPluginDatabase addPluginInstanceView:]):
1448         (-[WebPluginDatabase removePluginInstanceView:]):
1449         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1450         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1451         
1452         Handle cases where plugin views are detached before the plugin is destroyed.
1453         * WebCoreSupport/WebFrameLoaderClient.mm:
1454         (WebFrameLoaderClient::detachedFromParent2):
1455         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1456         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1457
1458         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1459         * WebView/WebHTMLView.mm:
1460         (-[WebHTMLView _destroyAllWebPlugins]):
1461         * WebView/WebHTMLViewInternal.h:
1462         * WebView/WebView.mm:
1463         (-[WebView addPluginInstanceView:]):
1464         (-[WebView removePluginInstanceView:]):
1465         (-[WebView removePluginInstanceViewsFor:]):
1466         * WebView/WebViewInternal.h:
1467
1468 2008-05-15  Brady Eidson  <beidson@apple.com>
1469
1470         Reviewed by Tim Hatcher
1471
1472         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1473         before setting the page group of the new page.
1474         
1475         * WebView/WebView.mm:
1476         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1477           immediately after creating the page so it is in place for initializing the LocalStorageThread
1478
1479 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1480
1481         Fixes the bug where the Web Inspector would flash white while resizing.
1482         This was cause by deferring the window creation.
1483
1484         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1485
1486         Reviewed by Darin Adler.
1487
1488         * WebCoreSupport/WebInspectorClient.mm:
1489         (-[WebInspectorWindowController window]): Don't defer the window creation.
1490
1491 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1492
1493         Tiger build fix.
1494
1495         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1496
1497 2008-05-15  Adele Peterson  <adele@apple.com>
1498
1499         Reviewed and landed by Alexey.
1500
1501         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1502
1503         * Misc/WebNSAttributedStringExtras.mm:
1504         (+[NSAttributedString _web_attributedStringFromRange:]):
1505
1506 2008-05-14  Eric Seidel  <eric@webkit.org>
1507
1508         Reviewed by Oliver.
1509
1510         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1511
1512         * WebView/WebResource.mm:
1513         (-[WebResource data]):
1514
1515 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1516
1517         Reviewed by Dan Bernstein.
1518
1519         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1520
1521         * Plugins/nptextinput.h:
1522
1523 2008-05-13  Anders Carlsson  <andersca@apple.com>
1524
1525         Reviewed by Sam.
1526
1527         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1528         Instead, do it in [WebCache empty].
1529         
1530         * Misc/WebCache.mm:
1531         (+[WebCache empty]):
1532         * WebView/WebView.mm:
1533         (+[WebView _setCacheModel:]):
1534
1535 2008-05-13  chris fleizach  <cfleizach@apple.com>
1536
1537         Reviewed by Beth Dakin
1538
1539         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1540
1541         * WebCoreSupport/WebViewFactory.mm:
1542         (-[WebViewFactory AXWebAreaText]):
1543
1544 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1545
1546         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1547         was referencing a nil WebView under validateUserInterfaceItem.
1548         The validateUserInterfaceItem methods was being called at a time
1549         when the WebHTMLView is being torndown.
1550
1551         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1552         while mousing down on menu bar after Xcode News window is opened
1553
1554         Reviewed by Ada Chan.
1555
1556         * WebView/WebHTMLView.mm:
1557         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1558         return NO when it is nil. Adds a comment.
1559         * WebView/WebPDFView.mm:
1560         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1561
1562 2008-05-13  Mark Rowe  <mrowe@apple.com>
1563
1564         Reviewed by John Sullivan.
1565
1566         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1567
1568         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1569         * Carbon/HIWebView.m: Ditto.
1570         (HIWebViewCreate):
1571         (HIWebViewConstructor):
1572
1573 2008-05-12  Dan Bernstein  <mitz@apple.com>
1574
1575         Reviewed by Ada Chan.
1576
1577         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1578           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1579
1580         Added font cache statistics and a function to purge inactive font data.
1581
1582         * Misc/WebCoreStatistics.h:
1583         * Misc/WebCoreStatistics.mm:
1584         (+[WebCoreStatistics cachedFontDataCount]):
1585         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1586         (+[WebCoreStatistics purgeInactiveFontData]):
1587         (+[WebCoreStatistics glyphPageCount]):
1588
1589 2008-05-12  Mark Rowe  <mrowe@apple.com>
1590
1591         Reviewed by Tim Hatcher.
1592
1593         Decorate some deprecated delegate methods with the availability macros.
1594
1595         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1596         macros is good for consistency and documentation.
1597
1598         * WebView/WebFrameLoadDelegate.h:
1599         * WebView/WebUIDelegate.h:
1600
1601 2008-05-12  Mark Rowe  <mrowe@apple.com>
1602
1603         Reviewed by Tim Hatcher.
1604
1605         <rdar://problem/5835604> Deprecate HIWebView
1606
1607         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1608
1609         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1610         * Carbon/HIWebView.h: Ditto.
1611
1612 2008-05-12  Kevin Decker  <kdecker@apple.com>
1613
1614         Reviewed by Anders.
1615
1616         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1617         
1618         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
1619         in changeset <http://trac.webkit.org/changeset/31028>
1620         
1621         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
1622         * WebView/WebFrame.mm:
1623         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
1624         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
1625         * WebView/WebFrameInternal.h: Ditto.
1626         * WebView/WebHTMLView.mm: Ditto.
1627         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
1628         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1629         * WebView/WebHTMLViewInternal.h: Ditto.
1630         * WebView/WebHTMLViewPrivate.h: Ditto.
1631
1632 2008-05-12  Anders Carlsson  <andersca@apple.com>
1633
1634         Reviewed by Alexey.
1635
1636         Empty the application cache when changing the cache model.
1637         
1638         * WebView/WebView.mm:
1639         (+[WebView _setCacheModel:]):
1640
1641 2008-05-12  Anders Carlsson  <andersca@apple.com>
1642
1643         Reviewed by Oliver.
1644
1645         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
1646         
1647         * Plugins/WebBaseNetscapePluginView.h:
1648         * Plugins/WebBaseNetscapePluginView.mm:
1649         (-[WebBaseNetscapePluginView start]):
1650         Get the plug-in text input vtable pointer.
1651         
1652         (-[WebBaseNetscapePluginView stop]):
1653         Set the plug-in text input vtable pointer to 0.
1654         
1655         (-[WebBaseNetscapePluginView inputContext]):
1656         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
1657         
1658         (-[WebBaseNetscapePluginView hasMarkedText]):        
1659         (-[WebBaseNetscapePluginView insertText:]):
1660         (-[WebBaseNetscapePluginView markedRange]):
1661         (-[WebBaseNetscapePluginView selectedRange]):
1662         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
1663         (-[WebBaseNetscapePluginView unmarkText]):
1664         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
1665         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
1666         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
1667         (-[WebBaseNetscapePluginView doCommandBySelector:]):
1668         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
1669         (-[WebBaseNetscapePluginView conversationIdentifier]):
1670         Implement NSTextInput and call into the plug-in text input vtable.
1671         
1672         (browserTextInputFuncs):
1673         New method which returns the browser input vtable.
1674         
1675         (-[WebBaseNetscapePluginView getVariable:value:]):
1676         Support getting the browser input vtable pointer.
1677         
1678         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1679         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1680         (WebNetscapePluginEventHandlerCocoa::keyDown):
1681         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1682         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
1683         it means that the event should be passed on to the input manager.
1684          
1685         * Plugins/npapi.mm:
1686         (NPN_MarkedTextAbandoned):
1687         (NPN_MarkedTextSelectionChanged):
1688         Add implementations of browser input method methods.
1689         
1690         * Plugins/nptextinput.h: Added.
1691         Add file with new text input API.
1692
1693 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
1694
1695         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
1696         SquirrelFish merging.
1697
1698         * Misc/WebCoreStatistics.mm:
1699         (+[WebCoreStatistics javaScriptObjectsCount]):
1700         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1701         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1702         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1703         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1704         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1705         * WebView/WebScriptDebugDelegate.mm:
1706         (-[WebScriptCallFrame evaluateWebScript:]):
1707
1708 2008-05-07  Anders Carlsson  <andersca@apple.com>
1709
1710         Reviewed by Mitz.
1711
1712         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
1713         https://bugs.webkit.org/show_bug.cgi?id=18880
1714         <rdar://problem/5909513>
1715
1716         Stop suspending key up events before calling handleEvent.
1717         
1718         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1719         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1720
1721 2008-05-06  Stephanie Lewis  <slewis@apple.com>
1722
1723         Reviewed by Andersca.
1724
1725         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
1726
1727         * Plugins/WebPluginDatabase.m: Removed.
1728         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
1729         * Plugins/npapi.m: Removed.
1730         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
1731
1732 2008-05-06  Anders Carlsson  <andersca@apple.com>
1733
1734         Reviewed by Darin.
1735
1736         Initialize numArchs to 0.
1737         
1738         * Plugins/WebBasePluginPackage.m:
1739         (-[WebBasePluginPackage isNativeLibraryData:]):
1740
1741 2008-05-06  Anders Carlsson  <andersca@apple.com>
1742
1743         Reviewed by Darin.
1744
1745         Add implementation of NPN_PopUpContextMenu.
1746         
1747         * Plugins/WebBaseNetscapePluginView.mm:
1748         (-[WebBaseNetscapePluginView popUpContextMenu:]):
1749         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1750         * Plugins/WebNetscapePluginPackage.m:
1751         (-[WebNetscapePluginPackage load]):
1752         * Plugins/npapi.m:
1753         (NPN_PopUpContextMenu):
1754
1755 2008-05-06  Anders Carlsson  <andersca@apple.com>
1756
1757         Fix typo (don't read random memory).
1758         
1759         * Plugins/WebBasePluginPackage.m:
1760         (-[WebBasePluginPackage isNativeLibraryData:]):
1761
1762 2008-05-05  Anders Carlsson  <andersca@apple.com>
1763
1764         Reviewed by Darin.
1765
1766         Change the isNativeLibraryData: method to handle universal binaries.
1767         
1768         * Plugins/WebBasePluginPackage.m:
1769         (swapIntsInHeader):
1770         (-[WebBasePluginPackage isNativeLibraryData:]):
1771
1772 2008-05-06  Brady Eidson  <beidson@apple.com>
1773
1774         Reviewed by Darin Adler
1775
1776         Preparation for upcoming work making LocalStorage persistent.
1777
1778         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
1779
1780         * WebView/WebView.mm:
1781         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
1782
1783 2008-05-05  Sam Weinig  <sam@webkit.org>
1784
1785         Reviewed by Darin Adler.
1786
1787         Fix for <rdar://problem/5884383>
1788         Escape look-a-like characters from the the entire url.
1789
1790         * Misc/WebNSURLExtras.mm:
1791         (escapeUnsafeCharacters):
1792         (-[NSURL _web_userVisibleString]):
1793
1794 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
1795
1796         Reviewed by Darin.
1797         
1798         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
1799
1800         * WebView/WebView.mm:
1801         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
1802         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
1803         the two interfere.
1804
1805 2008-05-05  Sam Weinig  <sam@webkit.org>
1806
1807         Reviewed by Tim Hatcher.
1808
1809         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
1810
1811         * WebCoreSupport/WebInspectorClient.mm:
1812         (WebInspectorClient::localizedStringsURL):
1813
1814 2008-05-05  Anders Carlsson  <andersca@apple.com>
1815
1816         Reviewed by Jess.
1817
1818         Apparently preflighting can cause hangs for some reason. Revert this for now.
1819         
1820         * Plugins/WebNetscapePluginPackage.m:
1821         (-[WebNetscapePluginPackage _initWithPath:]):
1822         * Plugins/WebPluginPackage.m:
1823         (-[WebPluginPackage initWithPath:]):
1824
1825 2008-05-05  Darin Adler  <darin@apple.com>
1826
1827         Reviewed by Mitz.
1828
1829         - https://bugs.webkit.org/show_bug.cgi?id=18789
1830           fix some shouldCloseWithWindow edge cases
1831
1832         * WebView/WebView.mm:
1833         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
1834         NSWindowWillCloseNotification if the view was moved out of the window but still
1835         had that window set as the host window. Also make sure this function doesn't do
1836         anything if the WebView is already closed.
1837         (-[WebView setHostWindow:]): Ditto.
1838
1839 2008-05-04  David Kilzer  <ddkilzer@apple.com>
1840
1841         Make parameters match for WebChromeClient::addMessageToConsole()
1842
1843         Reviewed by John.
1844
1845         * WebCoreSupport/WebChromeClient.h:
1846         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
1847         to sourceURL to match implementation in WebChromeClient.mm.
1848
1849 2008-05-02  Anders Carlsson  <andersca@apple.com>
1850
1851         Reviewed by Mark.
1852
1853         Various Cocoa event model and 64-bit plug-in fixes.
1854         
1855         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1856         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1857         Set click count.
1858         
1859         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1860         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1861         Don't try to get the mouse location for keyboard events.
1862         
1863         * Plugins/WebPluginPackage.m:
1864         (-[WebPluginPackage initWithPath:]):
1865         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
1866
1867 2008-05-02  Anders Carlsson  <andersca@apple.com>
1868
1869         Reviewed by Sam.
1870
1871         The event union is now named.
1872         
1873         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1874         (WebNetscapePluginEventHandlerCocoa::drawRect):
1875         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1876         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1877         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1878         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1879         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1880
1881 2008-05-02  Anders Carlsson  <andersca@apple.com>
1882
1883         Reviewed by Mark.
1884
1885         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
1886         
1887         Call preflightAndReturnError on the bundle, which will check if any of the architectures
1888         in the bundle match the current architecture.
1889         
1890         * Plugins/WebNetscapePluginPackage.m:
1891         (-[WebNetscapePluginPackage _initWithPath:]):
1892
1893 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
1894
1895         Reviewed by Geoffrey Garen.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=18826
1898         Make JavaScript heap per-thread
1899
1900         * Misc/WebCoreStatistics.mm:
1901         (+[WebCoreStatistics javaScriptObjectsCount]):
1902         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1903         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1904         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1905         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1906         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1907         Replaced static Collector calls with calls to a current thread's instance.
1908
1909         * WebView/WebScriptDebugDelegate.mm:
1910         (-[WebScriptCallFrame evaluateWebScript:]):
1911         Pass ExecState to jsString().
1912
1913 2008-05-01  Anders Carlsson  <andersca@apple.com>
1914
1915         Reviewed by Mark.
1916
1917         64-bit NPAPI plugin build fixes.
1918         
1919         * Plugins/WebBaseNetscapePluginView.mm:
1920         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1921         (-[WebBaseNetscapePluginView updateAndSetWindow]):
1922         (-[WebBaseNetscapePluginView start]):
1923         (-[WebBaseNetscapePluginView windowBecameKey:]):
1924         * Plugins/WebNetscapeDeprecatedFunctions.c:
1925         * Plugins/WebNetscapeDeprecatedFunctions.h:
1926         * Plugins/WebNetscapePluginEventHandler.mm:
1927         (WebNetscapePluginEventHandler::create):
1928         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1929         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1930         * Plugins/WebPluginDatabase.m:
1931         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
1932
1933 2008-05-01  Anders Carlsson  <andersca@apple.com>
1934
1935         Reviewed by Tim.
1936
1937         Remove duplicate npfunctions.h header from WebKit.
1938
1939         * MigrateHeaders.make:
1940         Migrate npfunctions.h
1941         
1942         * Plugins/npfunctions.h: Removed.
1943
1944 2008-05-01  Anders Carlsson  <andersca@apple.com>
1945
1946         Reviewed by John.
1947         
1948         Add null checks for the event handler.
1949         
1950         * Plugins/WebBaseNetscapePluginView.mm:
1951         (-[WebBaseNetscapePluginView stopTimers]):
1952         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1953
1954 2008-05-01  Anders Carlsson  <andersca@apple.com>
1955
1956         Fix 64-bit build.
1957         
1958         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1959         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1960         * WebCoreSupport/WebFrameLoaderClient.mm:
1961
1962 2008-05-01  Anders Carlsson  <andersca@apple.com>
1963
1964         Fix build.
1965         
1966         * Plugins/npfunctions.h:
1967
1968 2008-05-01  Anders Carlsson  <andersca@apple.com>
1969
1970         Reviewed by Adam.
1971
1972         Forward mouse move events to the Netscape plug-in view.
1973         
1974         * Plugins/WebBaseNetscapePluginView.h:
1975         * Plugins/WebBaseNetscapePluginView.mm:
1976         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1977         New method that just calls the current event handler.
1978         
1979         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1980         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1981         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
1982         don't work on it so don't call them.
1983         
1984         * WebCoreSupport/WebFrameLoaderClient.mm:
1985         (NetscapePluginWidget::NetscapePluginWidget):
1986         New Widget subclass to be used for Netscape plug-ins.
1987         
1988         (NetscapePluginWidget::handleEvent):
1989         Forward NSMouseMoved events to the plug-in.
1990         
1991         (WebFrameLoaderClient::createPlugin):
1992         Wrap the plug-in view in a NetscapePluginWidget.
1993
1994 2008-05-01  Alp Toker  <alp@nuanti.com>
1995
1996         Rubber-stamped by Anders.
1997
1998         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
1999         npapi.h.
2000
2001         Additional fix to use same signedness in npapi.h and Mac for the
2002         interval parameter.
2003
2004         * Plugins/WebBaseNetscapePluginView.h:
2005         * Plugins/WebBaseNetscapePluginView.mm:
2006         (PluginTimer::PluginTimer):
2007         (-[WebBaseNetscapePluginView stopTimers]):
2008         (-[WebBaseNetscapePluginView restartTimers]):
2009         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2010         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2011         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2012         * Plugins/npapi.m:
2013         (NPN_ScheduleTimer):
2014         (NPN_UnscheduleTimer):
2015         * Plugins/npfunctions.h:
2016
2017 2008-04-30  Anders Carlsson  <andersca@apple.com>
2018
2019         Reviewed by Adam.
2020
2021         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
2022         
2023         * Plugins/WebBaseNetscapePluginView.h:
2024         * Plugins/WebBaseNetscapePluginView.mm:
2025         (PluginTimer::PluginTimer):
2026         (PluginTimer::start):
2027         (PluginTimer::fired):
2028         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2029         (-[WebBaseNetscapePluginView stopTimers]):
2030         (-[WebBaseNetscapePluginView restartTimers]):
2031         (-[WebBaseNetscapePluginView scrollWheel:]):
2032         (-[WebBaseNetscapePluginView flagsChanged:]):
2033         (-[WebBaseNetscapePluginView start]):
2034         (-[WebBaseNetscapePluginView eventModel]):
2035         (-[WebBaseNetscapePluginView fini]):
2036         (-[WebBaseNetscapePluginView getVariable:value:]):
2037         (-[WebBaseNetscapePluginView setVariable:value:]):
2038         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2039         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2040         * Plugins/WebBaseNetscapePluginViewInternal.h:
2041         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2042         * Plugins/WebNetscapePluginEventHandler.h:
2043         * Plugins/WebNetscapePluginEventHandler.mm:
2044         (WebNetscapePluginEventHandler::create):
2045         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2046         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2047         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
2048         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
2049         (WebNetscapePluginEventHandlerCarbon::platformWindow):
2050         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
2051         (WebNetscapePluginEventHandlerCocoa::startTimers):
2052         (WebNetscapePluginEventHandlerCocoa::stopTimers):
2053         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
2054         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
2055         (WebNetscapePluginEventHandlerCocoa::drawRect):
2056         (WebNetscapePluginEventHandlerCocoa::mouseDown):
2057         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
2058         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
2059         (WebNetscapePluginEventHandlerCocoa::mouseExited):
2060         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
2061         (WebNetscapePluginEventHandlerCocoa::mouseUp):
2062         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
2063         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2064         (WebNetscapePluginEventHandlerCocoa::keyDown):
2065         (WebNetscapePluginEventHandlerCocoa::keyUp):
2066         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2067         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2068         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
2069         (WebNetscapePluginEventHandlerCocoa::focusChanged):
2070         (WebNetscapePluginEventHandlerCocoa::platformWindow):
2071         (WebNetscapePluginEventHandlerCocoa::sendEvent):
2072         * Plugins/WebNetscapePluginPackage.m:
2073         (-[WebNetscapePluginPackage load]):
2074         * Plugins/npapi.m:
2075         (NPN_ScheduleTimer):
2076         (NPN_UnscheduleTimer):
2077         * Plugins/npfunctions.h:
2078
2079 2008-04-30  Brady Eidson  <beidson@apple.com>
2080
2081         Fix my WebPreferences revert check-in
2082
2083         * WebView/WebView.mm:
2084         (-[WebView _preferencesChangedNotification:]):
2085
2086 2008-04-30  Brady Eidson  <beidson@apple.com>
2087
2088         Rubberstamped by John Sullivan
2089
2090         Revert the remainder of my original preferences changes from last week.
2091         They caused a massive PLT regression (too many notifications being sent out
2092         or listened to that weren't previously) and it's not in my schedule to refine
2093         the preferences code instead of working on my feature!
2094
2095         * WebView/WebView.mm:
2096         (-[WebView _updateSettingsFromPreferences:]):
2097         (-[WebView _commonInitializationWithFrameName:groupName:]):
2098
2099 2008-04-30  Anders Carlsson  <andersca@apple.com>
2100
2101         Fix the 64-bit build.
2102         
2103         * Plugins/WebNetscapePluginEventHandler.h:
2104         * Plugins/WebNetscapePluginEventHandler.mm:
2105         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2106         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2107
2108 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
2109
2110         BUILD FIX for Release build.
2111
2112         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2113         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
2114         separately so the compiler doesn't complain about an unused variable.
2115         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
2116
2117 2008-04-29  Anders Carlsson  <andersca@apple.com>
2118
2119         Reviewed by Adam.
2120
2121         Refactor the Carbon event handling code out into a separate class in preparation for adding
2122         the Cocoa event handling code.
2123         
2124         * Plugins/WebBaseNetscapePluginView.h:
2125         * Plugins/WebBaseNetscapePluginView.mm:
2126         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
2127         (-[WebBaseNetscapePluginView sendActivateEvent:]):
2128         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
2129         (-[WebBaseNetscapePluginView stopTimers]):
2130         (-[WebBaseNetscapePluginView restartTimers]):
2131         (-[WebBaseNetscapePluginView setHasFocus:]):
2132         (-[WebBaseNetscapePluginView mouseDown:]):
2133         (-[WebBaseNetscapePluginView mouseUp:]):
2134         (-[WebBaseNetscapePluginView mouseEntered:]):
2135         (-[WebBaseNetscapePluginView mouseExited:]):
2136         (-[WebBaseNetscapePluginView mouseDragged:]):
2137         (-[WebBaseNetscapePluginView keyUp:]):
2138         (-[WebBaseNetscapePluginView keyDown:]):
2139         (-[WebBaseNetscapePluginView cut:]):
2140         (-[WebBaseNetscapePluginView copy:]):
2141         (-[WebBaseNetscapePluginView paste:]):
2142         (-[WebBaseNetscapePluginView selectAll:]):
2143         (-[WebBaseNetscapePluginView start]):
2144         (-[WebBaseNetscapePluginView stop]):
2145         (-[WebBaseNetscapePluginView fini]):
2146         (-[WebBaseNetscapePluginView drawRect:]):
2147         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
2148         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
2149         (-[WebBaseNetscapePluginView windowBecameKey:]):
2150         (-[WebBaseNetscapePluginView windowResignedKey:]):
2151         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
2152         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
2153         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
2154         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
2155         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2156         (-[WebBaseNetscapePluginView _viewHasMoved]):
2157         * Plugins/WebBaseNetscapePluginViewInternal.h:
2158         * Plugins/WebNetscapePluginEmbeddedView.h:
2159         * Plugins/WebNetscapePluginEventHandler.h: Added.
2160         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
2161         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
2162         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
2163         * Plugins/WebNetscapePluginEventHandler.mm: Added.
2164         (WebNetscapePluginEventHandler::create):
2165         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
2166         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
2167         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
2168         (getCarbonEvent):
2169         (modifiersForEvent):
2170         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
2171         (WebNetscapePluginEventHandlerCarbon::drawRect):
2172         (WebNetscapePluginEventHandlerCarbon::mouseDown):
2173         (WebNetscapePluginEventHandlerCarbon::mouseUp):
2174         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2175         (WebNetscapePluginEventHandlerCarbon::mouseExited):
2176         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
2177         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2178         (WebNetscapePluginEventHandlerCarbon::keyDown):
2179         (keyMessageForEvent):
2180         (WebNetscapePluginEventHandlerCarbon::keyUp):
2181         (WebNetscapePluginEventHandlerCarbon::focusChanged):
2182         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
2183         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
2184         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
2185         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
2186         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
2187         (WebNetscapePluginEventHandlerCarbon::startTimers):
2188         (WebNetscapePluginEventHandlerCarbon::stopTimers):
2189         (WebNetscapePluginEventHandlerCarbon::sendEvent):
2190
2191 2008-04-29  Mark Rowe  <mrowe@apple.com>
2192
2193         Reviewed by David Harrison.
2194
2195         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
2196
2197         * WebKit.exp:
2198         * WebView/WebDynamicScrollBarsView.h:
2199         * WebView/WebDynamicScrollBarsView.m:
2200
2201 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
2202
2203         Reviewed by Darin.
2204
2205         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
2206
2207         * WebCoreSupport/WebChromeClient.h:
2208         * WebCoreSupport/WebChromeClient.mm:
2209         * WebView/WebClipView.m:
2210         (-[WebClipView scrollWheel:]):
2211         * WebView/WebHTMLView.mm:
2212         (-[WebHTMLView addMouseMovedObserver]):
2213         (-[WebHTMLView removeMouseMovedObserver]):
2214         (-[WebHTMLView acceptsFirstMouse:]):
2215         * WebView/WebUIDelegatePrivate.h:
2216         * WebView/WebView.mm:
2217         (-[WebViewPrivate init]):
2218         * WebView/WebViewPrivate.h:
2219
2220 2008-04-28  Rob Buis  <buis@kde.org>
2221
2222         Reviewed by Maciej.
2223
2224         Build fix for Tiger.
2225
2226         * WebView/WebView.mm:
2227         (WebKitInitializeApplicationCachePathIfNecessary):
2228
2229 2008-04-28  Adele Peterson  <adele@apple.com>
2230
2231         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
2232
2233         WebKit part of fix for <rdar://problem/3709505>
2234         Safari should have a way to upload bundles from the file upload control (as zip)
2235
2236         Added UIDelegate methods to let the application handle generating replacement files for uploads.
2237         In this case, Safari will create archived files for bundles so they can be uploaded properly.
2238
2239         * DefaultDelegates/WebDefaultUIDelegate.m:
2240         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
2241         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
2242         * WebCoreSupport/WebChromeClient.h:
2243         * WebCoreSupport/WebChromeClient.mm:
2244         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
2245         (WebChromeClient::generateReplacementFile):
2246         * WebView/WebUIDelegatePrivate.h:
2247
2248 2008-04-28  Anders Carlsson  <andersca@apple.com>
2249
2250         Reviewed by Sam, Mark, Adele and Darin.
2251
2252         Initialize the application cache path.
2253         
2254         * WebView/WebView.mm:
2255         (WebKitInitializeApplicationCachePathIfNecessary):
2256         (-[WebView _commonInitializationWithFrameName:groupName:]):
2257
2258 2008-04-28  Alice Liu  <alice.liu@apple.com>
2259
2260         Reviewed by Darin.
2261
2262         Fix <rdar://problem/4911289> Add tabindex property to all children 
2263         of HTMLElement (7138)
2264         http://bugs.webkit.org/show_bug.cgi?id=7138
2265
2266         * MigrateHeaders.make:
2267         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
2268         because now that focus() has been moved to DOMHTMLElement.h, these
2269         files are no longer needed.
2270
2271 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2272
2273         Reviewed by Darin.
2274
2275         Fix run-webkit-tests --threading
2276         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
2277         Proxy server issue in Sunday's Nightly
2278
2279         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
2280         only done from icon database code, which is not robust enough.
2281
2282 2008-04-20 Adam Barth <hk9565@gmail.com>
2283
2284         Reviewed by Adam Roben and Sam Weinig.
2285
2286         Updated WebSecurityOrigin to match new SecurityOrigin API.
2287
2288         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
2289
2290         * Storage/WebSecurityOrigin.mm:
2291         (-[WebSecurityOrigin host]):
2292         (-[WebSecurityOrigin domain]):
2293         * Storage/WebSecurityOriginPrivate.h:
2294
2295 2008-04-25  Mark Rowe  <mrowe@apple.com>
2296
2297         Rubber-stamped by Sam Weinig.
2298
2299         Add some content to an empty ICU header file to prevent verification errors.
2300
2301         * icu/unicode/utf_old.h:
2302
2303 2008-04-25  Anders Carlsson  <andersca@apple.com>
2304
2305         Reviewed by Sam.
2306
2307         Add offlineWebApplicationCacheEnabled preference.
2308         
2309         * WebView/WebPreferenceKeysPrivate.h:
2310         * WebView/WebPreferences.m:
2311         (+[WebPreferences initialize]):
2312         (-[WebPreferences offlineWebApplicationCacheEnabled]):
2313         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
2314         * WebView/WebPreferencesPrivate.h:
2315         * WebView/WebView.mm:
2316         (-[WebView _updateSettingsFromPreferences:]):
2317
2318 2008-04-24  Mark Rowe  <mrowe@apple.com>
2319
2320         Reviewed by Sam Weinig.
2321
2322         Remove code for calculating the glyph cache size.
2323
2324         * WebCoreSupport/WebSystemInterface.m:
2325         (InitWebCoreSystemInterface): Remove unused symbol.
2326
2327 2008-04-24  Mark Rowe  <mrowe@apple.com>
2328
2329         Reviewed by Sam Weinig.
2330
2331         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
2332
2333         * WebKitPrefix.h:
2334
2335 2008-04-24  Brady Eidson  <beidson@apple.com>
2336
2337         Reviewed by Darin
2338
2339         Fix layout test regressions from my earlier preferences/settings tweak.
2340
2341         * WebView/WebView.mm:
2342         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
2343           the notification to update the settings, each WebView still needs to register for the
2344           notification - restore that behavior.
2345
2346 2008-04-24  Dan Bernstein  <mitz@apple.com>
2347
2348         Reviewed by Darin Adler.
2349
2350         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
2351           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
2352
2353         * WebView/WebFrame.mm:
2354         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
2355         VisiblePosition::caretRect() instead of the RenderObject method which
2356         was removed.
2357
2358 2008-04-24  Brady Eidson  <beidson@apple.com>
2359
2360         Reviewed by Darin
2361
2362         Rework the Settings population again.
2363
2364         * WebView/WebView.mm:
2365         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
2366           and directly from WebView's common init function.
2367         (-[WebView _preferencesChangedNotification:]):
2368         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
2369           after creating the new Page
2370
2371 2008-04-24  Darin Adler  <darin@apple.com>
2372
2373         Reviewed by Geoff.
2374
2375         - fix crash in regression test where we'd ask a frame for a user agent string
2376           after the WebView was already closed
2377
2378         * WebCoreSupport/WebFrameLoaderClient.mm:
2379         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2380         added some code to prevent the crash in release builds if this problem happens
2381         again.
2382
2383 2008-04-24  Anders Carlsson  <andersca@apple.com>
2384
2385         Reviewed by Sam.
2386
2387         Change some String arguments to be const references instead.
2388
2389         * WebCoreSupport/WebEditorClient.h:
2390         * WebCoreSupport/WebEditorClient.mm:
2391         (WebEditorClient::shouldInsertText):
2392
2393 2008-04-24  John Sullivan  <sullivan@apple.com>
2394
2395         Mac build fix
2396         
2397         * WebCoreSupport/WebViewFactory.mm:
2398         (-[WebViewFactory AXButtonActionVerb]):
2399         implement this method using the text in WebCoreLocalizedStrings.cpp
2400         (-[WebViewFactory AXRadioButtonActionVerb]):
2401         ditto
2402         (-[WebViewFactory AXTextFieldActionVerb]):
2403         ditto
2404         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2405         ditto
2406         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2407         ditto
2408         (-[WebViewFactory AXLinkActionVerb]):
2409         ditto
2410
2411 2008-04-23  Brady Eidson  <beidson@apple.com>
2412
2413         Reviewed by Sam Weinig
2414
2415         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2416         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2417         thereby populating the Settings object, immediately after the Page is created.
2418
2419         * WebView/WebView.mm:
2420         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2421
2422 2008-04-24  John Sullivan  <sullivan@apple.com>
2423
2424         Reviewed by Jess
2425         
2426         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2427
2428         * Misc/WebNSControlExtras.m:
2429         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2430         deploy userSpaceScaleFactor when using view distances on the window
2431
2432 2008-04-22  Anders Carlsson  <andersca@apple.com>
2433
2434         Reviewed by Darin.
2435
2436         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2437         
2438         * Plugins/npfunctions.h:
2439
2440 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2441
2442         Mysteriously reviewed by mitz|away.
2443
2444         Bug 18111: Closing a tab while dragging crashes Safari
2445         https://bugs.webkit.org/show_bug.cgi?id=18111
2446
2447         Null check the page before handling drag events.
2448
2449         * WebView/WebView.mm:
2450         (-[WebView draggingUpdated:]):
2451         (-[WebView draggingExited:]):
2452
2453 2008-04-19  Brady Eidson  <beidson@apple.com>
2454
2455         Reviewed by Tim Hatcher
2456
2457         Add a WebPreference for the path of the local storage persistent store.
2458
2459         * WebView/WebPreferenceKeysPrivate.h:
2460
2461         * WebView/WebPreferences.m:
2462         (-[WebPreferences _localStorageDatabasePath]):
2463         (-[WebPreferences _setLocalStorageDatabasePath:]):
2464         * WebView/WebPreferencesPrivate.h:
2465
2466         * WebView/WebView.mm:
2467         (-[WebView _preferencesChangedNotification:]):
2468
2469 2008-04-18  Brady Eidson  <beidson@apple.com>
2470
2471         Reviewed by Sam Weinig
2472
2473         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2474         No reason to do the work twice...
2475
2476         * WebView/WebView.mm:
2477         (-[WebView _close]):
2478
2479 2008-04-17  Eric Seidel  <eric@webkit.org>
2480
2481         Reviewed by beth.
2482
2483         Rename Frame::renderer() to contentRenderer() and fix uses.
2484
2485         * Misc/WebCoreStatistics.mm:
2486         * WebView/WebRenderNode.mm:
2487         (-[WebRenderNode initWithWebFrameView:]):
2488
2489 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2490
2491         Reviewed by mrowe.
2492
2493         * WebView/WebFrame.mm: Remove temporary build fix.
2494
2495 2008-04-17  Mark Rowe  <mrowe@apple.com>
2496
2497         Reviewed by Dan Bernstein.
2498
2499         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2500
2501         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2502
2503         * WebCoreSupport/WebFrameLoaderClient.mm:
2504         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2505
2506 2008-04-17  Mark Rowe  <mrowe@apple.com>
2507
2508         Rubber-stamped by Dan Bernstein.
2509
2510         Fix the Mac build.
2511
2512         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2513         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2514         for this to live going forward.
2515
2516 2008-04-15  Kevin Decker  <kdecker@apple.com>
2517
2518         Reviewed by Anders.
2519
2520         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2521         
2522         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2523         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2524         a bundle out from underneath itself.
2525
2526         * Plugins/WebBasePluginPackage.h: Added unload method.
2527         * Plugins/WebBasePluginPackage.m:
2528         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2529         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2530         * Plugins/WebNetscapePluginPackage.m:
2531         (-[WebNetscapePluginPackage unload]): Added.
2532
2533 2008-04-15  Anders Carlsson  <andersca@apple.com>
2534
2535         Reviewed by Adam.
2536
2537         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2538
2539         * Configurations/WebKit.xcconfig:
2540
2541 2008-04-15  Brady Eidson  <beidson@apple.com>
2542
2543         Reviewed by John Sullivan
2544
2545         Do a more complete job adding the "WebArchiveDebugMode" pref
2546
2547         * WebView/WebPreferences.m: Add both getter *and* setter
2548         (-[WebPreferences webArchiveDebugModeEnabled]):
2549         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2550         * WebView/WebPreferencesPrivate.h:
2551
2552         * WebView/WebView.mm:
2553         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2554
2555 2008-04-14  Brady Eidson  <beidson@apple.com>
2556
2557         Reviewed by Anders
2558
2559         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2560         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2561         network and will instead fail the load as "cancelled."
2562
2563         * WebView/WebPreferenceKeysPrivate.h:
2564
2565         * WebView/WebPreferences.m:
2566         (+[WebPreferences initialize]):
2567         (-[WebPreferences _webArchiveDebugModeEnabled]):
2568         * WebView/WebPreferencesPrivate.h:
2569
2570         * WebView/WebView.mm:
2571         (-[WebView _preferencesChangedNotification:]):
2572
2573 2008-04-11  David Hyatt  <hyatt@apple.com>
2574
2575         Rename CachedResource ref/deref methods to addClient/removeClient.
2576
2577         Reviewed by olliej
2578
2579         * WebView/WebHTMLView.mm:
2580         (-[WebHTMLViewPrivate dealloc]):
2581         (-[WebHTMLViewPrivate finalize]):
2582         (-[WebHTMLViewPrivate clear]):
2583         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2584
2585 2008-04-07  Brady Eidson  <beidson@apple.com>
2586
2587         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2588
2589         * Configurations/WebKit.xcconfig:
2590
2591 2008-04-04  Adam Roben  <aroben@apple.com>
2592
2593         Use WebCore's ICU headers instead of our own copy
2594
2595         Rubberstamped by Tim Hatcher.
2596
2597         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2598         PrivateHeaders.
2599
2600 2008-04-04  Adam Roben  <aroben@apple.com>
2601
2602         Fix <rdar://problem/5804776> Would like to use WebCore's
2603         ForwardingHeaders in WebKit without manually creating copies
2604
2605         Patch by Tim Hatcher, typed by me.
2606
2607         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2608         WebCore's PrivateHeaders instead of our own copy.
2609
2610 2008-04-04  Ada Chan  <adachan@apple.com>
2611
2612         Now we pass width and height directly as integers to format
2613         the window title for a standalone image.
2614
2615         Reviewed by Dan.
2616
2617         * WebCoreSupport/WebViewFactory.mm:
2618         (-[WebViewFactory imageTitleForFilename:width:height:]):
2619
2620 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
2621
2622         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
2623
2624         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
2625           font-weight does not properly support graded weights
2626
2627         * WebView/WebHTMLView.mm:
2628         (-[WebHTMLView _styleFromFontAttributes:]):
2629         (-[WebHTMLView _originalFontB]):
2630         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2631
2632 2008-04-02  Mark Rowe  <mrowe@apple.com>
2633
2634         Reviewed by Oliver Hunt.
2635
2636         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
2637
2638         * Configurations/Base.xcconfig:
2639
2640 2008-03-31  Alice Liu  <alice.liu@apple.com>
2641
2642         Reviewed by Darin.
2643
2644         * WebView/WebFrame.mm:
2645         (-[WebFrame _accessibilityTree]):
2646         The syntax for fetching an object from the AXObjectCache changed slightly
2647
2648 2008-03-31  Brady Eidson  <beidson@apple.com>
2649
2650         Reviewed by Jon Honeycutt
2651         
2652         Move a WebArchive loading check into WebCore
2653
2654         * WebView/WebHTMLRepresentation.mm:
2655         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
2656           responsible for checking that state
2657
2658 2008-03-31  Brady Eidson  <beidson@apple.com>
2659
2660         Reviewed by Darin and Mitz's rubber stamp
2661
2662         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2663
2664         * WebCoreSupport/WebEditorClient.mm:
2665         * WebCoreSupport/WebEditorClient.h:
2666
2667 2008-03-28  Brady Eidson  <beidson@apple.com>
2668
2669         Rubberstamped by Darin Adler
2670
2671         Remove WebArchiver.h/mm
2672
2673         * WebView/WebArchiver.h: Removed.
2674         * WebView/WebArchiver.mm: Removed.
2675
2676         * DOM/WebDOMOperations.mm:
2677         * WebCoreSupport/WebDragClient.mm:
2678         * WebCoreSupport/WebEditorClient.mm:
2679         * WebView/WebDataSource.mm:
2680         * WebView/WebHTMLView.mm:
2681
2682 2008-03-28  Brady Eidson  <beidson@apple.com>
2683
2684         Reviewed by Darin Adler
2685
2686         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
2687
2688         * WebCoreSupport/WebEditorClient.mm:
2689         (WebEditorClient::dataForArchivedSelection):
2690
2691         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
2692         * WebView/WebArchiver.mm: Ditto
2693
2694         * WebView/WebHTMLView.mm:
2695         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2696
2697 2008-03-28  Brady Eidson  <beidson@apple.com>
2698
2699         Reviewed by Darin Adler
2700
2701         More Kit->Core WebArchive changes.
2702
2703         Create an archive from the current selection in a frame
2704
2705         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
2706           easily in a followup
2707
2708 2008-03-28  Brady Eidson  <beidson@apple.com>
2709
2710         Reviewed by Sam Weinig
2711
2712         WebArchive saga continues - Can now make archives from ranges in WebCore
2713
2714         * DOM/WebDOMOperations.mm:
2715         (-[DOMRange webArchive]):
2716         (-[DOMRange markupString]):
2717
2718         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
2719         * WebView/WebArchiver.mm:
2720
2721 2008-03-28  Brady Eidson  <beidson@apple.com>
2722
2723         Reviewed by Sam Weinig
2724
2725         More Kit->Core webarchive code movement
2726
2727         * DOM/WebDOMOperations.mm:
2728         (-[DOMNode markupString]): Call createFullMarkup() instead
2729
2730         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
2731         * WebView/WebFrameInternal.h: Ditto
2732
2733 2008-03-28  Brady Eidson  <beidson@apple.com>
2734
2735         Reviewed by Sam Weinig
2736
2737         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
2738
2739         * WebView/WebArchiver.h:
2740         * WebView/WebArchiver.mm:
2741         * WebView/WebDataSource.mm:
2742         (-[WebDataSource webArchive]):
2743
2744 2008-03-28  Brady Eidson  <beidson@apple.com>
2745
2746         Reviewed by Sam Weinig
2747
2748         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
2749
2750         * WebView/WebArchiver.h:
2751         * WebView/WebArchiver.mm:
2752
2753 2008-03-28  Brady Eidson  <beidson@apple.com>
2754
2755         Reviewed by Darin
2756
2757         "Yet another transitional step" to empty out WebKit-based code for archiving.
2758
2759         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2760         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2761
2762         * DOM/WebDOMOperations.mm:
2763         * WebView/WebArchiver.mm:
2764         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2765
2766 2008-03-27  Brady Eidson  <beidson@apple.com>
2767
2768         Reviewed by Adam Roben
2769
2770         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
2771         as the push to core-ify WebArchives continues.
2772
2773         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
2774         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
2775         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
2776         (as in "while archiving a page") are accepting of null or empty data.
2777
2778         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
2779
2780         * WebView/WebDataSource.mm:
2781         (-[WebDataSource mainResource]): Call DocumentLoader implementation
2782         (-[WebDataSource subresources]): Ditto
2783         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
2784         * WebView/WebFrameInternal.h:
2785
2786 2008-03-27  Brady Eidson  <beidson@apple.com>
2787
2788         Reviewed by Adam
2789
2790         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
2791         (more efficient)
2792
2793         * WebView/WebResource.mm:
2794         (-[WebResource _initWithCoreResource:]):
2795         * WebView/WebResourceInternal.h:
2796
2797 2008-03-26  Brady Eidson  <beidson@apple.com>
2798
2799         Build fix - accidentally checked in this change which was work in progress
2800
2801         * DOM/WebDOMOperations.mm:
2802
2803 2008-03-26  Brady Eidson  <beidson@apple.com>
2804
2805         Reviewed by Darin
2806
2807         When we create a WebArchive, we walk every node from some starting point, asking each node
2808         along the way "What are your subresource URLs?"
2809
2810         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
2811         WebCore::Node
2812
2813         * DOM/WebDOMOperations.mm:
2814         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
2815           calling into individual WebCore::Node implementations
2816         * DOM/WebDOMOperationsPrivate.h:
2817
2818 2008-03-26  Brady Eidson  <beidson@apple.com>
2819
2820         Reviewed by Mark Rowe
2821
2822         Part of the continued push to move WebArchive-related code down to WebCore, this
2823         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
2824
2825         * WebView/WebDataSource.mm:
2826         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
2827
2828         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
2829           has now been ported down to WebCore
2830         * WebView/WebFrameInternal.h:
2831
2832 2008-03-26  Mark Rowe  <mrowe@apple.com>
2833
2834         Rubber-stamped by Brady Eidson.
2835
2836         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
2837
2838         * Configurations/WebKit.xcconfig:
2839
2840 2008-03-26  Mark Rowe  <mrowe@apple.com>
2841
2842         Reviewed by David Hyatt.
2843
2844         Make the Ahem font antialias correctly on Acid3 on Tiger.
2845
2846         * WebCoreSupport/WebSystemInterface.m:
2847         (InitWebCoreSystemInterface):
2848
2849 2008-03-26  Mark Rowe  <mrowe@apple.com>
2850
2851         Fix the Mac build.
2852
2853         * MigrateHeaders.make: Copy the newly generated header into the right place.
2854
2855 2008-03-25  Brady Eidson  <beidson@apple.com>
2856
2857         Reviewed by Beth Dakin
2858
2859         Remove entirely unused internal method
2860
2861         * WebView/WebArchiver.h:
2862         * WebView/WebArchiver.mm:
2863
2864 2008-03-25  Brady Eidson  <beidson@apple.com>
2865
2866         Reviewed by Adam Roben
2867
2868         <rdar://problem/5819308> - View Source is empty when view webarchives
2869
2870         * WebCore.base.exp:
2871         * loader/DocumentLoader.cpp:
2872         (WebCore::DocumentLoader::setParsedArchiveData):
2873         (WebCore::DocumentLoader::parsedArchiveData):
2874         * loader/DocumentLoader.h:
2875
2876         * loader/FrameLoader.cpp:
2877         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
2878           in the DocumentLoader
2879
2880 2008-03-25  Dan Bernstein  <mitz@apple.com>
2881
2882         Reviewed by Darin Adler.
2883
2884         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
2885           Reopen All Windows From Last Session causes crash
2886
2887         * WebView/WebHTMLView.mm:
2888         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
2889         check.
2890
2891 2008-03-25  Brady Eidson  <beidson@apple.com>
2892
2893         Reviewed by Jon Honeycutt's rubberstamp
2894
2895         Fix a leak with the new WebArchive setup
2896
2897         * WebView/WebArchive.mm:
2898         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2899
2900 2008-03-25  Brady Eidson  <beidson@apple.com>
2901
2902         Reviewed by Darin
2903
2904         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
2905         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
2906
2907         * WebCoreSupport/WebFrameLoaderClient.h:
2908         * WebCoreSupport/WebFrameLoaderClient.mm:
2909         (WebFrameLoaderClient::WebFrameLoaderClient):
2910
2911 2008-03-25  Brady Eidson  <beidson@apple.com>
2912
2913         Reviewed by Darin
2914
2915         Remove newly obsolete FrameLoaderClient methods
2916
2917         * WebCoreSupport/WebFrameLoaderClient.h:
2918         * WebCoreSupport/WebFrameLoaderClient.mm:
2919
2920 2008-03-25  Brady Eidson  <beidson@apple.com>
2921
2922         Release build fix
2923
2924         * WebView/WebArchive.mm:
2925         (-[WebArchive subresources]):
2926         (-[WebArchive subframeArchives]):
2927
2928 2008-03-25  Brady Eidson  <beidson@apple.com>
2929
2930         Reviewed by Darin
2931
2932         <rdar://problem/4516169> - Support WebArchives on Windows
2933         And paves the way for many future WebArchive bug fixes and enhancements
2934
2935         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
2936         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
2937          * WebArchive <-> LegacyWebArchive
2938          * WebResource <-> ArchiveResource
2939          * WebUnarchivingState <-> ArchiveResourceCollection
2940  
2941         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
2942         and now exist in WebCore
2943
2944         * WebCoreSupport/WebFrameLoaderClient.mm:
2945         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
2946         (WebFrameLoaderClient::finalSetupForReplace):
2947         (WebFrameLoaderClient::setDefersLoading):
2948         (WebFrameLoaderClient::willUseArchive):
2949         (WebFrameLoaderClient::isArchiveLoadPending):
2950         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2951         (WebFrameLoaderClient::clearArchivedResources):
2952         (WebFrameLoaderClient::createFrame):
2953
2954         * WebView/WebArchive.mm:
2955         (+[WebArchivePrivate initialize]):
2956         (-[WebArchivePrivate init]):
2957         (-[WebArchivePrivate initWithCoreArchive:]):
2958         (-[WebArchivePrivate coreArchive]):
2959         (-[WebArchivePrivate setCoreArchive:]):
2960         (-[WebArchivePrivate dealloc]):
2961         (-[WebArchivePrivate finalize]):
2962         (-[WebArchive init]):
2963         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2964         (-[WebArchive initWithData:]):
2965         (-[WebArchive initWithCoder:]):
2966         (-[WebArchive encodeWithCoder:]):
2967         (-[WebArchive mainResource]):
2968         (-[WebArchive subresources]):
2969         (-[WebArchive subframeArchives]):
2970         (-[WebArchive data]):
2971         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
2972         (-[WebArchive WebCore::]):
2973         * WebView/WebArchiveInternal.h: Added.
2974
2975         * WebView/WebDataSource.mm:
2976         (-[WebDataSourcePrivate dealloc]):
2977         (-[WebDataSource _addSubframeArchives:]):
2978         (-[WebDataSource _documentFragmentWithArchive:]):
2979         (-[WebDataSource subresourceForURL:]):
2980         (-[WebDataSource addSubresource:]):
2981         * WebView/WebDataSourceInternal.h:
2982
2983         * WebView/WebFrame.mm:
2984         (-[WebFrame loadArchive:]):
2985         * WebView/WebFrameInternal.h:
2986
2987         * WebView/WebHTMLRepresentation.mm:
2988         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2989
2990         * WebView/WebResource.mm:
2991         (+[WebResourcePrivate initialize]):
2992         (-[WebResourcePrivate init]):
2993         (-[WebResourcePrivate initWithCoreResource:]):
2994         (-[WebResourcePrivate dealloc]):
2995         (-[WebResourcePrivate finalize]):
2996         (-[WebResource initWithCoder:]):
2997         (-[WebResource encodeWithCoder:]):
2998         (-[WebResource data]):
2999         (-[WebResource URL]):
3000         (-[WebResource MIMEType]):
3001         (-[WebResource textEncodingName]):
3002         (-[WebResource frameName]):
3003         (-[WebResource _initWithCoreResource:WebCore::]):
3004         (-[WebResource WebCore::]):
3005         (-[WebResource _ignoreWhenUnarchiving]):
3006         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3007         (-[WebResource _fileWrapperRepresentation]):
3008         (-[WebResource _response]):
3009         (-[WebResource _stringValue]):
3010         * WebView/WebResourceInternal.h: Added.
3011         * WebView/WebResourcePrivate.h:
3012
3013         * WebView/WebUnarchivingState.h: Removed.
3014         * WebView/WebUnarchivingState.m: Removed.
3015
3016 2008-03-24  Oliver Hunt  <oliver@apple.com>
3017
3018         Reviewed by Mark Rowe.
3019
3020         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
3021         <http://bugs.webkit.org/show_bug.cgi?id=18030>
3022
3023         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
3024         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
3025         <http://bugs.webkit.org/show_bug.cgi?id=18057>
3026
3027         * WebView/WebHTMLView.mm:
3028         (-[WebHTMLView keyDown:]):
3029
3030 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3031
3032         Reviewed by Maciej, landed by Brady
3033
3034         Bug 3580: iFrames Appear to be Cached
3035         <http://bugs.webkit.org/show_bug.cgi?id=3580>
3036
3037         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
3038         <http://bugs.webkit.org/show_bug.cgi?id=15486>
3039
3040         Bug 15554: Reload causes <object> to use old data
3041         <http://bugs.webkit.org/show_bug.cgi?id=15554>
3042
3043         If a page is reloaded, a child frame's URL can not be taken from a history item.
3044
3045         * WebView/WebFrame.mm:
3046         (-[WebFrame _loadURL:referrer:intoChild:]):
3047
3048 2008-03-24  Darin Adler  <darin@apple.com>
3049
3050         Reviewed by Beth.
3051
3052         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
3053
3054         * History/WebHistoryItem.mm:
3055         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
3056         * WebView/WebDataSource.mm:
3057         (-[WebDataSource _URL]): Ditto.
3058         (-[WebDataSource unreachableURL]): Ditto.
3059         * WebView/WebHTMLView.mm:
3060         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3061
3062         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3063         * History/WebHistory.mm:
3064         * Misc/WebElementDictionary.mm:
3065         * Misc/WebNSAttributedStringExtras.mm:
3066         Remove unneeded imports of KURL.h.
3067
3068 2008-03-24  Brady Eidson  <beidson@apple.com>
3069
3070         Reviewed by Darin's rubberstamp
3071
3072         Rename this file for upcoming work.
3073
3074         * WebView/WebArchive.m: Removed.
3075         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
3076
3077 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
3078
3079         Build fix.
3080
3081         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
3082
3083 2008-03-23  Oliver Hunt  <oliver@apple.com>
3084
3085         Reviewed by Maciej.
3086
3087         Bug 17670: Key events may improperly propagate from iframe to parent frame
3088         <http://bugs.webkit.org/show_bug.cgi?id=17670>
3089         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
3090         <http://bugs.webkit.org/show_bug.cgi?id=16381>
3091
3092         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
3093         as that results in us dispatching the key events for each frame going up the frame
3094         tree.
3095
3096         * WebView/WebHTMLView.mm:
3097         (-[WebHTMLView keyDown:]):
3098         (-[WebHTMLView keyUp:]):
3099         (-[WebHTMLView flagsChanged:]):
3100
3101 2008-03-21  Timothy Hatcher  <timothy@apple.com>
3102
3103         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
3104         http://bugs.webkit.org/show_bug.cgi?id=17980
3105
3106         Reviewed by Adam.
3107
3108         The new highlight drawing was not honoring the fade value, so it was
3109         always drawing at full opacity. The animation code didn't match Windows
3110         and the new highlight anyway, so it has been removed. The highlight
3111         how just detaches when it is hidden.
3112
3113         * WebCoreSupport/WebInspectorClient.mm:
3114         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
3115         (-[WebInspectorWindowController close]): Ditto.
3116         (-[WebInspectorWindowController highlightNode:]): Call attach.
3117         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
3118         * WebInspector/WebNodeHighlight.h:
3119         * WebInspector/WebNodeHighlight.m:
3120         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3121         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
3122         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
3123         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
3124         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
3125         * WebInspector/WebNodeHighlightView.h:
3126         * WebInspector/WebNodeHighlightView.m:
3127         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
3128
3129 2008-03-20  Mark Rowe  <mrowe@apple.com>
3130
3131         Reviewed by Sam Weinig.
3132
3133         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
3134         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
3135         command-line.
3136
3137         * Configurations/WebKit.xcconfig:
3138
3139 2008-03-20  Adam Roben  <aroben@apple.com>
3140
3141         Make WebNodeHighlightView use InspectorController to do its painting
3142
3143         Reviewed by Tim Hatcher.
3144
3145         * WebCoreSupport/WebInspectorClient.mm:
3146         (-[WebInspectorWindowController highlightNode:]): Pass the
3147         InspectorController to the WebNodeHighlight, and don't call
3148         setHighlightedNode: (which has been removed).
3149         (-[WebInspectorWindowController hideHighlight]): Removed call to
3150         setHighlightedNode:.
3151         * WebInspector/WebNodeHighlight.h:
3152           - Replaced _highlightNode with _inspectorController
3153           - Removed _highlightedNode accessors
3154           - Added -inspectorController method
3155         * WebInspector/WebNodeHighlight.m:
3156         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
3157         takes an InspectorController* and stores it in _inspectorController.
3158         (-[WebNodeHighlight dealloc]): Removed code dealing with
3159         _highlightedNode.
3160         (-[WebNodeHighlight inspectorController]): Added.
3161         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
3162         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
3163         GraphicsContexts to be based on a flipped CGContext, so we have to
3164         specify that this view is flipped.
3165         (-[WebNodeHighlightView drawRect:]): Changed to create a
3166         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
3167
3168 2008-03-18  David Hyatt  <hyatt@apple.com>
3169
3170         Add support for a preference in WebKit that can be used in nightly builds to test full page
3171         zoom.
3172
3173         Reviewed by Antti
3174
3175         * WebView/WebPreferenceKeysPrivate.h:
3176         * WebView/WebView.mm:
3177         (-[WebView setTextSizeMultiplier:]):
3178         (-[WebView canMakeTextSmaller]):
3179         (-[WebView makeTextSmaller:]):
3180         (-[WebView canMakeTextLarger]):
3181         (-[WebView makeTextLarger:]):
3182         (-[WebView canMakeTextStandardSize]):
3183         (-[WebView makeTextStandardSize:]):
3184
3185 2008-03-17  Eric Seidel  <eric@webkit.org>
3186
3187         Reviewed by darin.
3188
3189         Export _NPN_IntFromIdentifier as part of our NPAPI interface
3190
3191         * Plugins/WebNetscapePluginPackage.m:
3192         (-[WebNetscapePluginPackage load]):
3193
3194 2008-03-14  Brady Eidson  <beidson@apple.com>
3195
3196         Reviewed by Brian Dash's rubberstamp
3197
3198         Remove a class declaration for a class that has never existed
3199
3200         * WebView/WebResource.h:
3201
3202 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
3203
3204         Unify concept of enabling the Mac Java bridge.
3205
3206         Reviewed by Darin and Anders.
3207
3208         * Plugins/WebPluginJava.h: Removed unused file.
3209         * WebCoreSupport/WebFrameLoaderClient.h:
3210         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
3211         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
3212         (WebFrameLoaderClient::javaApplet): Ditto.
3213
3214 2008-03-13  Antti Koivisto  <antti@apple.com>
3215
3216         Reviewed by Darin.
3217
3218         * ForwardingHeaders/wtf/Deque.h: Added.
3219
3220 2008-03-13  Anders Carlsson  <andersca@apple.com>
3221
3222         Reviewed by Adam.
3223
3224         Call originalRequest, not initialRequest.
3225         
3226         * WebView/WebDataSource.mm:
3227         (-[WebDataSource initialRequest]):
3228
3229 2008-03-12  Darin Adler  <darin@apple.com>
3230
3231         Reviewed by John Sullivan.
3232
3233         - cleanup after removing the bridge
3234
3235         * DOM/WebDOMOperations.mm:
3236         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
3237
3238         * Misc/WebCoreStatistics.mm:
3239         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
3240
3241         * Plugins/WebBaseNetscapePluginView.mm:
3242         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
3243         _frameLoader method.
3244         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3245         Ditto.
3246         * Plugins/WebPluginController.mm:
3247         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
3248
3249         * WebCoreSupport/WebFrameLoaderClient.mm:
3250         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
3251         method. Without this we could leave a stale frame pointer around.
3252         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
3253         caller of the _isMainFrame method.
3254         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
3255         _frameLoader method.
3256         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
3257
3258         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
3259         turned out to be unused.
3260         (core): Added overload for DocumentFragment.
3261         (kit): Ditto.
3262         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
3263         to FrameLoader with _private->coreFrame->loader().
3264         (-[WebFrame _attachScriptDebugger]): Ditto.
3265         (-[WebFrame _clearCoreFrame]): Added.
3266         (-[WebFrame _updateBackground]): More of the same.
3267         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
3268         (-[WebFrame _unmarkAllMisspellings]): Ditto.
3269         (-[WebFrame _hasSelection]): Ditto.
3270         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
3271         (-[WebFrame _findFrameWithSelection]): Ditto.
3272         (-[WebFrame _dataSource]): Ditto.
3273         (-[WebFrame _addData:]): Streamlined code a bit.
3274         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3275         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3276         (-[WebFrame _isDescendantOfFrame:]): Ditto.
3277         (-[WebFrame _bodyBackgroundColor]): Ditto.
3278         (-[WebFrame _isFrameSet]): Ditto.
3279         (-[WebFrame _firstLayoutDone]): Ditto.
3280         (-[WebFrame _loadType]): Ditto.
3281         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
3282         (-[WebFrame name]): Ditto.
3283         (-[WebFrame DOMDocument]): Ditto.
3284         (-[WebFrame frameElement]): Ditto.
3285         (-[WebFrame provisionalDataSource]): Ditto.
3286         (-[WebFrame dataSource]): Ditto.
3287         (-[WebFrame loadRequest:]): Ditto.
3288         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
3289         (-[WebFrame loadArchive:]): Ditto.
3290         (-[WebFrame stopLoading]): Ditto.
3291         (-[WebFrame reload]): Ditto.
3292         (-[WebFrame findFrameNamed:]): Ditto.
3293         (-[WebFrame parentFrame]): Ditto.
3294         (-[WebFrame childFrames]): Ditto.
3295         (-[WebFrame windowObject]): Ditto.
3296         (-[WebFrame globalContext]): Ditto.
3297
3298         * WebView/WebFrameInternal.h: Added overloads of core and kit.
3299         Removed method declarations.
3300
3301         * WebView/WebHTMLRepresentation.mm:
3302         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
3303         (formElementFromDOMElement): Ditto.
3304         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3305         (inputElementFromDOMElement): Ditto.
3306         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3307         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3308         (-[WebHTMLRepresentation formForElement:]): Ditto.
3309         (-[WebHTMLRepresentation currentForm]): Ditto.
3310         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3311         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3312         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3313
3314         * WebView/WebHTMLView.mm:
3315         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
3316         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3317         Call createFragmentFromText directly instead of via WebFrame.
3318         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3319         Moved layout calls here from WebFrame.
3320         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3321         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
3322         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
3323         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
3324         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
3325         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3326         Moved code here from WebFrame.
3327         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
3328         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3329         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3330         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3331         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3332         (-[WebHTMLView rectsForTextMatches]): Ditto.
3333
3334         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
3335
3336         * WebView/WebPDFView.mm:
3337         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
3338         _frameLoader method.
3339
3340         * WebView/WebRenderNode.mm:
3341         (copyRenderNode): Moved code here from WebFrame.
3342         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3343
3344         * WebView/WebResource.mm:
3345         (-[WebResource _stringValue]): Moved code here from WebFrame.
3346
3347         * WebView/WebView.mm:
3348         (-[WebView _close]): Use core function intsead of _frameLoader method.
3349         (-[WebView setCustomTextEncodingName:]): Ditto.
3350         (-[WebView setHostWindow:]): Moved code here from WebFrame.
3351         (aeDescFromJSValue): Moved this here from WebFrame.
3352         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
3353
3354 2008-03-12  Darin Adler  <darin@apple.com>
3355
3356         Reviewed by Anders.
3357
3358         - http://bugs.webkit.org/show_bug.cgi?id=17640
3359           eliminate WebCoreFrameBridge
3360
3361         Moved all the code from the bridge into WebFrame. This need not be the final
3362         home of these methods -- they can be moved closer to their callers and improved
3363         further -- but it eliminates the bridge without requiring a rewrite of the code.
3364         It's a fairly mechanical process (just adding underscores to method names really).
3365
3366         There's even a chance that some of the methods are unused. Those we can remove
3367         after checking if that's so.
3368
3369         * DOM/WebDOMOperations.mm:
3370         (-[DOMNode markupString]): Use WebFrame rather than bridge.
3371         (-[DOMDocument webFrame]): Changed to use the core and kit functions
3372         instead of using the bridge.
3373         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
3374         (-[DOMRange markupString]): Ditto.
3375         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3376
3377         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3378         * History/WebHistoryItem.mm: Ditto.
3379
3380         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3381         * Misc/WebCoreStatistics.mm:
3382         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3383
3384         * Misc/WebElementDictionary.mm: Removed unneeded import.
3385
3386         * Misc/WebKitStatistics.m:
3387         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3388         * Misc/WebKitStatisticsPrivate.h: Ditto.
3389
3390         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3391         * Misc/WebNSPasteboardExtras.mm: Ditto.
3392
3393         * Plugins/WebBaseNetscapePluginView.mm:
3394         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3395         rather than bridge.
3396
3397         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3398         * Plugins/WebNetscapePluginStream.mm: Ditto.
3399
3400         * Plugins/WebPluginContainerCheck.mm:
3401         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3402         bridge to get to the WebCore::Frame.
3403
3404         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3405         * Plugins/WebPluginController.mm:
3406         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3407         rather than bridge.
3408
3409         * WebCoreSupport/WebEditorClient.mm:
3410         (selectorForKeyEvent): Tweaked comment.
3411
3412         * WebCoreSupport/WebFrameBridge.h: Removed.
3413         * WebCoreSupport/WebFrameBridge.mm: Removed.
3414
3415         * WebCoreSupport/WebFrameLoaderClient.mm:
3416         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3417         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3418         I could remove this function entirely, but it looks like the Qt port is using it.
3419
3420         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3421
3422         * WebView/WebArchiver.mm:
3423         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3424         (+[WebArchiver archiveNode:]): Ditto.
3425         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3426
3427         * WebView/WebDataSource.mm:
3428         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3429         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3430         (-[WebDataSource subresources]): Ditto.
3431         (-[WebDataSource subresourceForURL:]): Ditto.
3432
3433         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3434
3435         * WebView/WebFrame.mm:
3436         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3437         (core): Go directly to the core frame, not via the bridge.
3438         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3439         Remove the code to deal with the bridge.
3440         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3441         shouldCreateRenderers flag, formerly on the bridge.
3442         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3443         (aeDescFromJSValue): Moved here from bridge.
3444         (-[WebFrame _domain]): Ditto.
3445         (-[WebFrame _addData:]): Ditto.
3446         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3447         (-[WebFrame _nodesFromList:]): Ditto.
3448         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3449         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3450         (-[WebFrame _selectedString]): Ditto.
3451         (-[WebFrame _stringForRange:]): Ditto.
3452         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3453         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3454         (-[WebFrame _sendScrollEvent]): Ditto.
3455         (-[WebFrame _drawRect:]): Ditto.
3456         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3457         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3458         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3459         (-[WebFrame _copyRenderTree:]): Ditto.
3460         (inputElementFromDOMElement): Ditto.
3461         (formElementFromDOMElement): Ditto.
3462         (-[WebFrame _elementWithName:inForm:]): Ditto.
3463         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3464         (-[WebFrame _elementIsPassword:]): Ditto.
3465         (-[WebFrame _formForElement:]): Ditto.
3466         (-[WebFrame _currentForm]): Ditto.
3467         (-[WebFrame _controlsInForm:]): Ditto.
3468         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3469         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3470         (-[WebFrame _URLWithAttributeString:]): Ditto.
3471         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3472         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3473         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3474         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3475         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3476         (-[WebFrame _rectsForTextMatches]): Ditto.
3477         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3478         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3479         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3480         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3481         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3482         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3483         (-[WebFrame _baseURL]): Ditto.
3484         (-[WebFrame _stringWithData:]): Ditto.
3485         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3486         (-[WebFrame _needsLayout]): Ditto.
3487         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3488         (-[WebFrame _accessibilityTree]): Ditto.
3489         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3490         (-[WebFrame _setDrawsBackground:]): Ditto.
3491         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3492         Ditto.
3493         (-[WebFrame _selectionGranularity]): Ditto.
3494         (-[WebFrame _convertToNSRange:]): Ditto.
3495         (-[WebFrame _convertToDOMRange:]): Ditto.
3496         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3497         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3498         (-[WebFrame _markDOMRange]): Ditto.
3499         (-[WebFrame _markedTextNSRange]): Ditto.
3500         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3501         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3502         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3503         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3504         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3505         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3506         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3507         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3508         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3509         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3510         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3511         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3512         (-[WebFrame _typingStyle]): Ditto.
3513         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3514         (-[WebFrame _fontForSelection:]): Ditto.
3515         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3516         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3517         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3518         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3519         (-[WebFrame _canProvideDocumentSource]): Ditto.
3520         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3521         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3522         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3523         function. Couldn't just keep the bridge method because this was already here with the same name.
3524         (-[WebFrame _selectedNSRange]): Ditto.
3525         (-[WebFrame _selectNSRange:]): Ditto.
3526         (-[WebFrame dealloc]): Remove bridge-related code.
3527         (-[WebFrame finalize]): Ditto.
3528
3529         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3530         Removed the bridge parameter from the init method. Removed the #if blocks that
3531         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3532         Removed the _bridge method.
3533
3534         * WebView/WebFrameView.mm: Removed the _bridge method.
3535
3536         * WebView/WebHTMLRepresentation.mm:
3537         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3538         field.
3539         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3540         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3541         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3542         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3543         (-[WebHTMLRepresentation documentSource]): Ditto.
3544         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3545         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3546         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3547         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3548         (-[WebHTMLRepresentation formForElement:]): Ditto.
3549         (-[WebHTMLRepresentation currentForm]): Ditto.
3550         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3551         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3552         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3553
3554         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3555
3556         * WebView/WebHTMLView.mm:
3557         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3558         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3559         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3560         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3561         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3562         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3563         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3564         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3565         (-[WebHTMLView drawSingleRect:]): Ditto.
3566         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3567         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3568         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3569         (-[WebHTMLView knowsPageRange:]): Ditto.
3570         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3571         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3572         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3573         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3574         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3575         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3576         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3577         (-[WebHTMLView startSpeaking:]): Ditto.
3578         (-[WebHTMLView _updateFontPanel]): Ditto.
3579         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3580         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3581         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3582         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3583         (-[WebHTMLView selectedRange]): Ditto.
3584         (-[WebHTMLView markedRange]): Ditto.
3585         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3586         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3587         (-[WebHTMLView insertText:]): Ditto.
3588         (-[WebTextCompleteController _insertMatch:]): Ditto.
3589         (-[WebTextCompleteController doCompletion]): Ditto.
3590         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3591         (-[WebHTMLView string]): Ditto.
3592         (-[WebHTMLView selectedString]): Ditto.
3593         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3594         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3595         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3596         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3597         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3598         (-[WebHTMLView rectsForTextMatches]): Ditto.
3599         * WebView/WebRenderNode.mm:
3600         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3601         * WebView/WebResource.mm:
3602         (-[WebResource _stringValue]): Ditto.
3603
3604         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3605
3606         * WebView/WebView.mm:
3607         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3608         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3609         (-[WebView _setInViewSourceMode:]): Ditto.
3610         (-[WebView _inViewSourceMode]): Ditto.
3611         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3612         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3613         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3614         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3615         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
3616         (-[WebView setEditable:]): Ditto.
3617         (-[WebView setTypingStyle:]): Ditto.
3618         (-[WebView typingStyle]): Ditto.
3619         (-[WebView replaceSelectionWithNode:]): Ditto.
3620         (-[WebView replaceSelectionWithText:]): Ditto.
3621         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
3622         (-[WebView replaceSelectionWithArchive:]): Ditto.
3623         (-[WebView _insertNewlineInQuotedContent]): Ditto.
3624         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
3625
3626 2008-03-12  David Hyatt  <hyatt@apple.com>
3627
3628         Make the zoom factor a float and not a percent.
3629
3630         Reviewed by antti
3631
3632         * WebView/WebView.mm:
3633         (-[WebView _setZoomMultiplier:isTextOnly:]):
3634
3635 2008-03-11  David Hyatt  <hyatt@apple.com>
3636
3637         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
3638         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
3639         can zoom the page in, out or reset it to the standard size.
3640
3641         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
3642         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
3643         win.
3644
3645         Reviewed by Tim H.
3646
3647         * WebCoreSupport/WebFrameBridge.mm:
3648         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
3649         * WebView/WebDocumentInternal.h:
3650         * WebView/WebHTMLView.mm:
3651         (-[WebHTMLView viewDidMoveToSuperview]):
3652         * WebView/WebPDFView.h:
3653         * WebView/WebPDFView.mm:
3654         (-[WebPDFView _zoomOut:]):
3655         (-[WebPDFView _zoomIn:]):
3656         (-[WebPDFView _resetZoom:]):
3657         (-[WebPDFView _canZoomOut]):
3658         (-[WebPDFView _canZoomIn]):
3659         (-[WebPDFView _canResetZoom]):
3660         * WebView/WebView.mm:
3661         (-[WebViewPrivate init]):
3662         (-[WebView setTextSizeMultiplier:]):
3663         (-[WebView textSizeMultiplier]):
3664         (-[WebView _setZoomMultiplier:isTextOnly:]):
3665         (-[WebView _zoomMultiplier:]):
3666         (-[WebView _realZoomMultiplier]):
3667         (-[WebView _realZoomMultiplierIsTextOnly]):
3668         (-[WebView _canZoomOut:]):
3669         (-[WebView _canZoomIn:]):
3670         (-[WebView _zoomOut:isTextOnly:]):
3671         (-[WebView _zoomIn:isTextOnly:]):
3672         (-[WebView _canResetZoom:]):
3673         (-[WebView _resetZoom:isTextOnly:]):
3674         (-[WebView canMakeTextSmaller]):
3675         (-[WebView makeTextSmaller:]):
3676         (-[WebView canMakeTextLarger]):
3677         (-[WebView makeTextLarger:]):
3678         (-[WebView canMakeTextStandardSize]):
3679         (-[WebView makeTextStandardSize:]):
3680         (-[WebView setPageSizeMultiplier:]):
3681         (-[WebView pageSizeMultiplier]):
3682         (-[WebView canZoomPageIn]):
3683         (-[WebView zoomPageIn:]):
3684         (-[WebView canZoomPageOut]):
3685         (-[WebView zoomPageOut:]):
3686         (-[WebView canResetPageZoom]):
3687         (-[WebView resetPageZoom:]):
3688         (-[WebView _searchWithSpotlightFromMenu:]):
3689         * WebView/WebViewInternal.h:
3690         * WebView/WebViewPrivate.h:
3691
3692 2008-03-12  Dan Bernstein  <mitz@apple.com>
3693
3694         Reviewed by Darin Adler and Sam Weinig.
3695
3696         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
3697
3698         * WebCoreSupport/WebSystemInterface.m:
3699         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
3700         WKGetNSFontATSUFontId Tiger-only.
3701
3702 2008-03-12  Darin Adler  <darin@apple.com>
3703
3704         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
3705           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
3706
3707         * WebView/WebFrame.mm:
3708         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
3709         up pointer from the bridge to the frame. (My next check-in removes the bridge
3710         entirely, but we need this until then.)
3711
3712 2008-03-11  Darin Adler  <darin@apple.com>
3713
3714         Reviewed by Sam.
3715
3716         - remove all bridge-related things from WebCore except the bridge itself
3717
3718         * DOM/WebDOMOperations.mm:
3719         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
3720
3721         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
3722
3723         * Plugins/WebPluginController.mm: Ditto.
3724
3725         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
3726         init and close methods. Added a setWebFrame: method.
3727
3728         * WebCoreSupport/WebFrameBridge.mm:
3729         (-[WebFrameBridge setWebFrame:]): Added.
3730
3731         * WebCoreSupport/WebFrameLoaderClient.mm:
3732         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
3733         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
3734         bridge here. Soon we will be able to remove this entirely!
3735         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
3736         into WebFrame from the bridge.
3737
3738         * WebView/WebFrame.mm:
3739         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
3740         now owned by the frame.
3741         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
3742         debugger under GC without this!
3743         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
3744         use WebFrameLoaderClient instead of the bridge.
3745         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
3746         This is code that used to live in the bridge's init function.
3747         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
3748         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
3749         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
3750         the WebView is now the bridge's owner.
3751         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
3752         WebCore::Frame::bridge function directly to use the kit function instead.
3753         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
3754         This code won't last long -- we're eliminating the bridge soon.
3755         (-[WebFrame finalize]): Ditto.
3756
3757         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
3758         for creating frames.
3759
3760         * WebView/WebView.mm:
3761         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
3762         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
3763         where we have to allocate a WebFrameBridge and then immediately release it.
3764
3765 2008-03-11  Darin Adler  <darin@apple.com>
3766
3767         Reviewed by Anders.
3768
3769         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
3770
3771         * WebCoreSupport/WebFrameLoaderClient.mm:
3772         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
3773         to setView. A couple lines later, there is a call to _install, which sets the
3774         view to the scroll view.
3775
3776         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
3777
3778         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
3779         this file, since it's used by Safari.
3780         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
3781         * WebView/WebDynamicScrollBarsView.m:
3782         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
3783         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
3784         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
3785         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
3786         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
3787         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
3788         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
3789         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
3790         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
3791         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
3792         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
3793         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
3794         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
3795         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
3796         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
3797
3798         * WebView/WebFrameView.mm:
3799         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
3800
3801         * WebView/WebView.mm:
3802         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
3803         (-[WebView alwaysShowVerticalScroller]): Ditto.
3804         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
3805         (-[WebView alwaysShowHorizontalScroller]): Ditto.
3806
3807 2008-03-11  Darin Adler  <darin@apple.com>
3808
3809         Reviewed by Sam.
3810
3811         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
3812
3813         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
3814         bridge methods.
3815         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
3816         to recently-created functions.
3817         (WebChromeClient::firstResponder): Moved code here from the bridge.
3818         (WebChromeClient::makeFirstResponder): Ditto.
3819         (WebChromeClient::runOpenPanel): Ditto.
3820         (WebChromeClient::willPopUpMenu): Ditto.
3821
3822         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
3823         is related to creating the bridge and connecting it to WebCore, which will
3824         go next when I eliminate use of the bridge to get to/from the Frame*.
3825         * WebCoreSupport/WebFrameBridge.mm:
3826         (-[WebFrameBridge close]): Moved the code to track the bridge count here
3827         instead of the dealloc and finalize methods.
3828
3829 2008-03-11  Darin Adler  <darin@apple.com>
3830
3831         Reviewed by Mitz.
3832
3833         - update code affected by Range changes
3834
3835         * Misc/WebNSAttributedStringExtras.mm:
3836         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
3837         * WebView/WebHTMLRepresentation.mm:
3838         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3839         Use Range::create.
3840         * WebView/WebHTMLView.mm:
3841         (-[WebHTMLView attributedString]): Ditto.
3842
3843 2008-03-10  Darin Adler  <darin@apple.com>
3844
3845         Reviewed by Sam.
3846
3847         - eliminate keyboard UI mode method from WebCoreFrameBridge
3848
3849         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
3850         * WebCoreSupport/WebChromeClient.mm:
3851         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
3852         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
3853         fields for keyboard UI mode.
3854         * WebCoreSupport/WebFrameBridge.mm:
3855         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
3856         method.
3857         (-[WebFrameBridge finalize]): Ditto.
3858         * WebView/WebView.mm: Moved the keyboard mode code in here.
3859         (-[WebView _close]): Remove observer from the distributed notification
3860         center as well as the normal one.
3861         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
3862         here from the bridge.
3863         (-[WebView _keyboardUIMode]): Ditto.
3864         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
3865
3866 2008-03-10  Darin Adler  <darin@apple.com>
3867
3868         Reviewed by Sam.
3869
3870         - eliminate Java applet methods from WebCoreFrameBridge
3871
3872         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
3873         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
3874         the ones that load Java applets.
3875         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
3876         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3877
3878 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
3879
3880         Reviewed by Darin.
3881
3882         Done with Lars.
3883
3884         Simplified WebViewFactory's refreshPlugins method to only refresh the
3885         plugins and not reload the frames anymore since that's now done in a
3886         platform independent manner by WebCore::Page.
3887
3888         Also removed the now unused pluginNameForMIMEType and
3889         pluginSupportsMIMEType methods.
3890
3891         * WebCoreSupport/WebViewFactory.mm:
3892         * WebView/WebFrame.mm:
3893         * WebView/WebFrameInternal.h:
3894         * WebView/WebView.mm:
3895
3896 2008-03-08  Mark Rowe  <mrowe@apple.com>
3897
3898         Reviewed by Darin Adler.
3899
3900         Fix 64-bit build with GCC 4.2.
3901
3902         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
3903         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
3904         * History/WebHistoryItem.mm: Ditto.
3905         * Misc/WebElementDictionary.mm: Ditto.
3906         * WebCoreSupport/WebFrameLoaderClient.mm:
3907         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
3908         variable being unused in 64-bit.
3909         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
3910         * WebView/WebHTMLView.mm:
3911         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
3912         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
3913
3914 2008-03-08  Darin Adler  <darin@apple.com>
3915
3916         Reviewed by Adele.
3917
3918         - eliminate custom highlight methods from WebCoreFrameBridge
3919
3920         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
3921         * WebCoreSupport/WebChromeClient.mm:
3922         (WebChromeClient::customHighlightRect): Moved code here from bridge.
3923         (WebChromeClient::paintCustomHighlight): Ditto.
3924         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
3925
3926 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
3927
3928         Unify concept of enabling Netscape Plug-in API (NPAPI).
3929
3930         Reviewed by Darin.
3931
3932         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
3933
3934         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
3935         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
3936
3937         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
3938         #if ENABLE(NETSCAPE_PLUGIN_API).
3939         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
3940         * Plugins/WebBaseNetscapePluginView.h: Ditto.
3941         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
3942         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
3943         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
3944         * Plugins/WebBasePluginPackage.h: Ditto.
3945         * Plugins/WebBasePluginPackage.m: Ditto.
3946         (+[WebBasePluginPackage pluginWithPath:]):
3947         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
3948         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3949         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
3950         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
3951         * Plugins/WebNetscapePluginPackage.h: Ditto.
3952         * Plugins/WebNetscapePluginPackage.m: Ditto.
3953         * Plugins/WebNetscapePluginStream.h: Ditto.
3954         * Plugins/WebNetscapePluginStream.mm: Ditto.
3955         * Plugins/WebPluginDatabase.m: Ditto.
3956         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
3957         * Plugins/npapi.m: Ditto.
3958         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3959         (WebFrameLoaderClient::objectContentType):
3960         (WebFrameLoaderClient::createPlugin):
3961         * WebView/WebHTMLView.mm: Ditto.
3962         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3963         * WebView/WebHTMLViewInternal.h: Ditto.
3964
3965         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
3966         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
3967         category to (WebInternal) category so we don't expose the ENABLE() macro
3968         from the private header.
3969         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
3970         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
3971         * WebView/WebFrameInternal.h: Ditto.
3972         * WebView/WebFramePrivate.h: Ditto.
3973
3974 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
3975
3976         Reviewed by Darin.
3977
3978         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
3979         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
3980
3981         * WebView/WebPreferences.m:
3982         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
3983         the one used in Safari.
3984
3985 2008-03-07  Mark Rowe  <mrowe@apple.com>
3986
3987         Reviewed by Oliver Hunt.
3988
3989         Fix WebKit build with GCC 4.2.
3990
3991         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
3992
3993 2008-03-07  Darin Adler  <darin@apple.com>
3994
3995         Reviewed by Adam.
3996
3997         - eliminated WebCoreFrameBridge runOpenPanel
3998
3999         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
4000         * WebCoreSupport/WebChromeClient.mm:
4001         (WebChromeClient::runOpenPanel): Added.
4002         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
4003         FileChooser so it can get a result from the UI delegate.
4004         (-[WebOpenPanelResultListener dealloc]): Added.
4005         (-[WebOpenPanelResultListener finalize]): Added.
4006         (-[WebOpenPanelResultListener cancel]): Added.
4007         (-[WebOpenPanelResultListener chooseFilename:]): Added.
4008
4009 2008-03-06  Darin Adler  <darin@apple.com>
4010
4011         Reviewed by Mitz.
4012
4013         - fix regression test failures from the visited-link change
4014
4015         * History/WebHistory.mm:
4016         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
4017         to turn off visited links if there is no history object. Also call
4018         removeAllVisitedLinks so we can start over from scratch with the new history.
4019
4020 2008-03-06  Dan Bernstein  <mitz@apple.com>
4021
4022         Reviewed by Darin Adler.
4023
4024         - fix a regression from r30741: a crash under
4025           WebFrameLoaderClient::createPlugin() when showing a Mail message with
4026           an attachment
4027
4028         * WebCoreSupport/WebFrameLoaderClient.mm:
4029         (WebFrameLoaderClient::createPlugin):
4030
4031 2008-03-06  Darin Adler  <darin@apple.com>
4032
4033         - fix Tiger build
4034
4035         * History/WebHistory.mm: Added include of WebTypesInternal.h.
4036
4037 2008-03-06  Darin Adler  <darin@apple.com>
4038
4039         - fix Release build
4040
4041         * History/WebHistory.mm:
4042         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
4043         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
4044         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
4045
4046 2008-03-06  Darin Adler  <darin@apple.com>
4047
4048         Reviewed by Mitz.
4049
4050         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
4051           REGRESSION: iframes are added to Safari's History menu
4052           by separating the visited link machinery from global history
4053
4054         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
4055         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
4056         method name, since it's on a private object.
4057         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
4058         PageGroup::removeAllVisitedLinks function if the last URL was removed.
4059         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
4060         method name, since it's on a private object.
4061         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
4062         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
4063         method name, since it's on a private object.
4064         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
4065         Ditto.
4066         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
4067         to correctly return the error by using the newer version of writeToURL: and
4068         removed the FIXME about that.
4069         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
4070         for every link in the history.
4071         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
4072         (-[WebHistory addItem:]): Moved into the WebPrivate category.
4073         (-[WebHistory addItemForURL:]): Ditto.
4074         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
4075         create an item and already know its title.
4076         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
4077         (-[WebHistory containsItemForURLString:]): Ditto.
4078         (-[WebHistory removeItem:]): Ditto.
4079         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
4080         (-[WebHistory _itemForURLString:]): Ditto.
4081         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
4082
4083         * History/WebHistoryInternal.h: Added.
4084         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
4085         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
4086         Also reorganized what was left behind.
4087
4088         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
4089         * WebCoreSupport/WebChromeClient.mm:
4090         (WebChromeClient::populateVisitedLinks): Added a call to the new
4091         -[WebHistory _addVisitedLinksToPageGroup:] method.
4092
4093         * WebCoreSupport/WebFrameLoaderClient.mm:
4094         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
4095         -[WebHistory _addItemForURL:title:] method.
4096
4097 2008-03-05  Adam Roben  <aroben@apple.com>
4098
4099         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
4100
4101         Reviewed by Kevin M.
4102
4103         * WebView/WebFrame.mm:
4104         * WebView/WebScriptDebugDelegate.mm:
4105         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
4106         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
4107
4108 2008-03-05  Adam Roben  <aroben@apple.com>
4109
4110         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
4111
4112         Reviewed by Kevin M.
4113
4114         * WebView/WebCoreScriptDebuggerImp.h:
4115         * WebView/WebCoreScriptDebuggerImp.mm:
4116         * WebView/WebFrame.mm:
4117         (-[WebFrame _attachScriptDebugger]):
4118         * WebView/WebFrameInternal.h:
4119
4120 2008-03-05  Adam Roben  <aroben@apple.com>
4121
4122         Remove WebScriptDebugger
4123
4124         Uses of WebScriptDebugger have been replaced with
4125         WebCoreScriptDebuggerImp.
4126
4127         Reviewed by Kevin M.
4128
4129         * WebView/WebFrame.mm:
4130         (-[WebFramePrivate dealloc]): Use delete instead of release since
4131         WebCoreScriptDebuggerImp is a C++ class.
4132         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
4133         WebCoreScriptDebuggerImp.
4134         (-[WebFrame _detachScriptDebugger]): Ditto.
4135         * WebView/WebFrameInternal.h:
4136         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
4137         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
4138         * WebView/WebView.mm:
4139
4140 2008-03-05  Adam Roben  <aroben@apple.com>
4141
4142         Remove -webFrame and -globalObject from WebScriptDebugger
4143
4144         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
4145
4146         Reviewed by Kevin M.
4147
4148         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
4149         parameter to the constructor.
4150         * WebView/WebCoreScriptDebuggerImp.mm:
4151         (toWebFrame): Added.
4152         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
4153         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
4154         WindowScriptObject ourselves instead of asking WebScriptDebugger for
4155         it.
4156         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
4157         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
4158         (WebCoreScriptDebuggerImp::exception): Ditto.
4159         * WebView/WebScriptDebugDelegate.mm:
4160         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
4161         WebScriptDebuggerImp's constructor.
4162         * WebView/WebScriptDebugDelegatePrivate.h: Removed
4163         -webFrame/-globalObject.
4164
4165 2008-03-05  Adam Roben  <aroben@apple.com>
4166
4167         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
4168
4169         Reviewed by Kevin M.
4170
4171         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
4172         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
4173         lifetime.
4174         * WebView/WebCoreScriptDebuggerImp.mm:
4175           - Added declaration of -[WebScriptCallFrame
4176             _initWithGlobalObject:caller:state:].
4177           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
4178         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
4179         now-unnecessary initialization of m_topCallFrame.
4180         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
4181         with its implementation. The one difference between this
4182         implementation and the old enterFrame: method is that we don't hand
4183         our reference to m_topCallFrame to _initWithGlobalObject: -- that
4184