Build fix.
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-08-04  Mark Rowe  <mrowe@apple.com>
2
3         Build fix.
4
5         * WebView/WebHTMLView.mm:
6
7 2008-08-04  Mark Rowe  <mrowe@apple.com>
8
9         Reviewed by Kevin Decker.
10
11         Adopt the formal protocols where necessary.
12         Final part of fix for <rdar://problem/5853147>.
13
14         * WebCoreSupport/WebInspectorClient.mm:
15         * WebView/WebHTMLView.mm:
16         * WebView/WebView.mm:
17         (-[WebView _openFrameInNewWindowFromMenu:]):
18
19 2008-08-04  Mark Rowe  <mrowe@apple.com>
20
21         Reviewed by Darin Adler.
22
23         Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
24         Part one of fix for <rdar://problem/5853147>.
25
26         * Misc/EmptyProtocolDefinitions.h:
27         * WebKitPrefix.h:
28
29 2008-08-04  Brady Eidson  <beidson@apple.com>
30
31         Reviewed by Mitz Pettel
32
33         Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.
34
35         This broke in r31355 when we stopped returning nil WebResources when there was nil
36         resource data.
37
38         * WebView/WebResource.mm:
39         (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil
40           when the resource data is null.
41
42 2008-08-02  Matt Lilek  <webkit@mattlilek.com>
43
44         Reviewed by Tim Hatcher.
45
46         Update the window gradient offset to match the inspector toolbar's new height.
47
48         * WebCoreSupport/WebInspectorClient.mm:
49         (-[WebInspectorWindowController window]):
50
51 2008-08-01  Anders Carlsson  <andersca@apple.com>
52
53         Reviewed by Jon.
54
55         <rdar://problem/6120206>
56         Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
57         
58         Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.
59
60         * Plugins/WebBaseNetscapePluginStream.mm:
61         (-[WebBaseNetscapePluginStream wantsAllStreams]):
62
63 2008-07-31  Anders Carlsson  <andersca@apple.com>
64
65         Reviewed by Darin.
66
67         <rdar://problem/5949410>
68         Add the ability to transfer a given application cache to a new database.
69
70         * Misc/WebKitNSStringExtras.h:
71         * Misc/WebKitNSStringExtras.m:
72         (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
73         New method which returns the appopriate cache directory for a given bundle identifier.
74         
75         * WebView/WebDataSource.mm:
76         (-[WebDataSource _transferApplicationCache:]):
77         Transfer the application cache.
78         
79         * WebView/WebDataSourcePrivate.h:
80         * WebView/WebView.mm:
81         (WebKitInitializeApplicationCachePathIfNecessary):
82         Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
83
84 2008-07-31  John Sullivan  <sullivan@apple.com>
85
86         WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs
87
88         Reviewed by Hyatt
89
90         * WebView/WebPreferenceKeysPrivate.h:
91         added WebKitZoomsTextOnlyPreferenceKey
92         
93         * WebView/WebPreferences.mm:
94         (+[WebPreferences initialize]):
95         default value of YES for WebKitZoomsTextOnlyPreferenceKey
96         (-[WebPreferences zoomsTextOnly]):
97         getter for WebKitZoomsTextOnlyPreferenceKey
98         (-[WebPreferences setZoomsTextOnly:]):
99         setter for WebKitZoomsTextOnlyPreferenceKey
100         
101         * WebView/WebPreferencesPrivate.h:
102         declare zoomsTextOnly/setZoomsTextOnly:
103         
104         * WebView/WebView.mm:
105         (-[WebView _preferencesChangedNotification:]):
106         update WebCore::Settings value for zoomsTextOnly
107
108 2008-07-31  David D. Kilzer  <ddkilzer@webkit.org>
109
110         Fix layout test results for webarchive/test-xml-stylesheet.xml
111
112         Reviewed by Darin.
113
114         Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
115         for DumpRenderTree.
116
117         * WebView/WebHTMLRepresentationInternal.h: Added.
118
119 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
120
121         Release build fix.
122
123         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
124         Don't define to npErr in release builds, as it is only used for logging.
125
126 2008-07-31  John Sullivan  <sullivan@apple.com>
127
128         Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
129         drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard
130
131         Reviewed by Dan
132
133         * WebView/WebHTMLView.mm:
134         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
135         include Leopard in the #ifdef that forces a layout if needed
136
137 2008-07-30  Brady Eidson  <beidson@apple.com>
138
139         Reviewed by Adam and Hyatt
140
141         Fix for <rdar://problem/6099748>
142
143         * WebView/WebView.mm:
144         (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" 
145           quirk when running under iWeb 2
146
147 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
148
149         Rubber-stamped by Maciej.
150
151         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
152         call sites now).
153
154         * ForwardingHeaders/kjs/JSLock.h: Removed.
155         * Misc/WebCoreStatistics.mm:
156         (+[WebCoreStatistics javaScriptObjectsCount]):
157         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
158         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
159         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
160         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
161         (+[WebCoreStatistics shouldPrintExceptions]):
162         (+[WebCoreStatistics setShouldPrintExceptions:]):
163         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
164         * Plugins/WebBaseNetscapePluginStream.mm:
165         (-[WebBaseNetscapePluginStream wantsAllStreams]):
166         * Plugins/WebBaseNetscapePluginView.mm:
167         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
168         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
169         (-[WebBaseNetscapePluginView start]):
170         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
171         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
172         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
173         (-[WebBaseNetscapePluginView loadPluginRequest:]):
174         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
175         * Plugins/WebPluginController.mm:
176         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
177         (-[WebPluginController startAllPlugins]):
178         (-[WebPluginController stopAllPlugins]):
179         (-[WebPluginController addPlugin:]):
180         (-[WebPluginController destroyPlugin:]):
181         (-[WebPluginController destroyAllPlugins]):
182         * WebView/WebFrame.mm:
183         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
184         * WebView/WebScriptDebugDelegate.mm:
185         (-[WebScriptCallFrame evaluateWebScript:]):
186         * WebView/WebView.mm:
187         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
188
189 2008-07-30  Beth Dakin  <bdakin@apple.com>
190
191         Reviewed by Anders Carlsson.
192
193         Fixes <rdar://problem/6041390>
194
195         Adds the ability to have a frame that is "disconnected" from the 
196         main frame from the perspective of top and parent in 
197         Javascript.
198
199         * WebView/WebFrame.mm:
200         (-[WebFrame _setIsDisconnectedFrame]):
201         * WebView/WebFramePrivate.h:
202
203 2008-07-29  Mark Rowe  <mrowe@apple.com>
204
205         Tweak to the build fix to keep Dan happy.
206
207         * Plugins/WebBaseNetscapePluginView.mm:
208         * WebView/WebHTMLView.mm:
209
210 2008-07-29  Mark Rowe  <mrowe@apple.com>
211
212         Build fix.
213
214         * Plugins/WebBaseNetscapePluginView.mm:
215         (-[WebBaseNetscapePluginView inputContext]):
216         * WebView/WebHTMLView.mm:
217
218 2008-07-28  Anders Carlsson  <andersca@apple.com>
219
220         Reviewed by Kevin Decker.
221
222         Based on a patch by Dimcho Balev.
223         
224         https://bugs.webkit.org/show_bug.cgi?id=18676
225         <rdar://problem/6106578>
226         Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
227
228         * Plugins/WebBaseNetscapePluginStream.h:
229         Add NPP_GetValue pointer.
230         
231         * Plugins/WebBaseNetscapePluginStream.mm:
232         (-[WebBaseNetscapePluginStream setPlugin:]):
233         Initialize NPP_GetValue.
234         
235         (-[WebBaseNetscapePluginStream wantsAllStreams]):
236         Call NPP_GetValue.
237         
238         * Plugins/WebPlugInStreamLoaderDelegate.h:
239         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
240         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
241         (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
242         Implement this and call down to the stream.
243
244 2008-07-28  Anders Carlsson  <andersca@apple.com>
245
246         Reviewed by Adam.
247
248         <rdar://problem/6105529> 
249         https://bugs.webkit.org/show_bug.cgi?id=19659
250         Turning off plugins causes crash
251         
252         When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
253         end up in a state where they don't have an event handler. Because of this, we need to 
254         check that the plug-in has been started before calling the event handler.
255         
256         * Plugins/WebBaseNetscapePluginView.mm:
257         (-[WebBaseNetscapePluginView sendActivateEvent:]):
258         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
259         (-[WebBaseNetscapePluginView setHasFocus:]):
260         (-[WebBaseNetscapePluginView mouseDown:]):
261         (-[WebBaseNetscapePluginView mouseUp:]):
262         (-[WebBaseNetscapePluginView mouseEntered:]):
263         (-[WebBaseNetscapePluginView mouseExited:]):
264         (-[WebBaseNetscapePluginView handleMouseMoved:]):
265         (-[WebBaseNetscapePluginView mouseDragged:]):
266         (-[WebBaseNetscapePluginView scrollWheel:]):
267         (-[WebBaseNetscapePluginView keyUp:]):
268         (-[WebBaseNetscapePluginView keyDown:]):
269         (-[WebBaseNetscapePluginView flagsChanged:]):
270         (-[WebBaseNetscapePluginView cut:]):
271         (-[WebBaseNetscapePluginView copy:]):
272         (-[WebBaseNetscapePluginView paste:]):
273         (-[WebBaseNetscapePluginView selectAll:]):
274         (-[WebBaseNetscapePluginView drawRect:]):
275         (-[WebBaseNetscapePluginView inputContext]):
276
277 2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>
278
279         Reviewed by Geoff Garen.
280
281         Changes to accommodate newly named/signatured loading methods in WebCore.
282
283         * Plugins/WebNetscapePluginStream.mm:
284         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
285         * Plugins/WebPluginContainerCheck.mm:
286         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
287         * WebView/WebPDFView.mm:
288         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
289
290 2008-07-21  Mark Rowe  <mrowe@apple.com>
291
292         Reviewed by Sam Weinig.
293
294         <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
295
296         * Configurations/Version.xcconfig:
297         * Info.plist:
298
299 2008-07-21  Anders Carlsson  <andersca@apple.com>
300
301         Reviewed by Geoff.
302
303         <rdar://problem/5820667> 
304         CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
305         
306         Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
307         
308         * Plugins/WebBaseNetscapePluginView.mm:
309         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
310
311 2008-07-21  Mark Rowe  <mrowe@apple.com>
312
313         Reviewed by Adam Roben.
314
315         <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
316
317         Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
318         This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
319
320         * WebView/WebHTMLView.mm:
321
322 2008-07-21  Mark Rowe  <mrowe@apple.com>
323
324         Reviewed by Adam Roben.
325
326         Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
327         only uses objc_msgSend_fpret for long double return values.  For float return
328         values the standard objc_msgSend is used, as on ppc and ppc64.
329
330         * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
331         objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
332         as that method is defined by the Objective-C runtime for x86_64.
333         (CallDelegateReturningFloat):
334
335 2008-07-14  Dan Bernstein  <mitz@apple.com>
336
337         Reviewed by John Sullivan.
338
339         - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
340
341         * Plugins/WebBaseNetscapePluginView.mm:
342         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
343         to account for the case of being drawn into a bitmap context that is not
344         a window's backing store. In that case, there are no valid "rects being
345         drawn" to clip to.
346         * WebView/WebHTMLView.mm:
347         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
348         Added an override of this NSView method which is used in for
349         -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
350         machinery overrides, it sets subviews aside before invoking the
351         superclass implementation. On Tiger, it also updates the layout.
352
353 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
354
355         Reviewed by Geoff Garen.
356
357         Eliminate per-thread JavaScript global data instance support and make arbitrary
358         global data/global object combinations possible.
359
360         * Misc/WebCoreStatistics.mm:
361         (+[WebCoreStatistics javaScriptObjectsCount]):
362         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
363         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
364         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
365         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
366         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
367         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
368
369 2008-07-11  Stephanie Lewis  <slewis@apple.com>
370
371         Reviewed by Darin Adler.
372
373         Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
374
375         * WebView/WebPreferences.m: Removed.
376         * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
377         (+[WebPreferences initialize]): if running in Default enable full  document teardown
378         (-[WebPreferences editableLinkBehavior]):
379         (-[WebPreferences setFullDocumentTeardownEnabled:]):
380         * WebView/WebView.mm:
381         (-[WebView _close]): disable leak messages if using fast teardown
382
383 2008-07-10  Mark Rowe  <mrowe@apple.com>
384
385         Reviewed by Sam Weinig.
386
387         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
388
389         * Configurations/WebKit.xcconfig:
390
391 2008-07-10  Mark Rowe  <mrowe@apple.com>
392
393         Reviewed by Sam Weinig.
394
395         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
396
397         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
398         * WebView/WebFrameLoadDelegate.h: Ditto.
399         * WebView/WebUIDelegate.h: Ditto.
400
401 2008-07-10  Anders Carlsson  <andersca@apple.com>
402
403         Reviewed by Mark.
404         
405         Add availability macros for the new WebPlugin methods.
406
407         * Plugins/WebPlugin.h:
408         * Plugins/WebPluginViewFactory.h:
409
410 2008-07-09  Mark Rowe  <mrowe@apple.com>
411
412         Reviewed by Geoff Garen.
413
414         Don't warn about deprecated functions in production builds.
415
416         * Configurations/Base.xcconfig:
417         * Configurations/DebugRelease.xcconfig:
418
419 2008-07-09  Brady Eidson  <beidson@apple.com>
420
421         Reviewed by Darin
422
423         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
424         has been installed in a frame tree.
425
426         The root of this problem was that calling init() on a new frame could end up calling arbitrary
427         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
428         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
429         destroying the frame.
430
431         Note that each platforms WebKit API layer needs to make this new guarantee:
432         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
433         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
434         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
435
436         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
437         architectural improvement we can make in the future so the individual platform clients are no longer
438         vulnerable to this problem, which should really have been a WebCore issue.
439
440         * WebCoreSupport/WebFrameLoaderClient.mm:
441         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
442           Don't appendChild() the new frame here.
443           Null-check the new frame's page before loading the URL into it, as it might already have been
444           removed from the page.
445
446         * WebView/WebFrame.mm:
447         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
448           go ahead and install the new frame in the frame tree *before* calling init() on it.
449
450 2008-07-09  Anders Carlsson  <andersca@apple.com>
451
452         Reviewed by Darin.
453
454         Make some WebPlugin and WebPluginFactory SPI public.
455         
456         * Plugins/WebPlugin.h:
457         * Plugins/WebPluginPrivate.h:
458         * Plugins/WebPluginViewFactory.h:
459         * Plugins/WebPluginViewFactoryPrivate.h:
460
461 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
462
463         Reviewed by Anders.
464
465         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
466         unsuccessful.
467
468         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
469         newStreamSuccessful.
470         * Plugins/WebBaseNetscapePluginStream.mm:
471         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
472         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
473         newStreamSuccessful to YES.
474         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
475         NPP_DestroyStream if newStreamSuccessful is true.
476
477 2008-07-08  Dan Bernstein  <mitz@apple.com>
478
479         Reviewed by John Sullivan.
480
481         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
482
483         * WebView/WebHTMLView.mm:
484         (-[WebHTMLView addWindowObservers]): Added code to observe when the
485         window goes onscreen.
486         (-[WebHTMLView removeWindowObservers]): Added.
487         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
488         not update when offscreen, calls -setNeedsDisplay: just before it comes
489         onscreen.
490         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
491         * WebView/WebPreferences.m:
492         (+[WebPreferences initialize]): Made updates when offscreen on by
493         default.
494         (-[WebPreferences updatesWhenOffscreen]): Added.
495         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
496         * WebView/WebPreferencesPrivate.h:
497         * WebView/WebView.mm:
498         (-[WebView _preferencesChangedNotification:]): Added code to update the
499         updatesWhenOffscreen setting in WebCore.
500
501 2008-07-07  Anders Carlsson  <andersca@apple.com>
502
503         Reviewed by Darin.
504
505         Speculative fix for     
506         <rdar://problem/5839800>
507         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
508         
509         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
510         
511         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
512         This is usually protected by _private->closed, but in this case it might still be false.
513
514         * WebView/WebHTMLView.mm:
515         (-[WebHTMLView close]):
516
517 2008-07-05  Mark Rowe  <mrowe@apple.com>
518
519         Reviewed by John Sullivan.
520
521         Remove WebSearchableTextView as it has been unused for some time now.
522
523         * Misc/WebSearchableTextView.h: Removed.
524         * Misc/WebSearchableTextView.m: Removed.
525
526 2008-07-05  Mark Rowe  <mrowe@apple.com>
527
528         Reviewed by John Sullivan.
529
530         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
531
532         * Misc/WebNSUserDefaultsExtras.m:
533         (-[NSString _webkit_HTTPStyleLanguageCode]):
534
535 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
536
537         Inspired and reviewed by Mark Rowe.
538
539         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
540
541         * Carbon/HIViewAdapter.m:
542         * DOM/WebDOMOperations.mm:
543         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
544         * DefaultDelegates/WebDefaultPolicyDelegate.m:
545         * History/WebBackForwardList.mm:
546         * History/WebHistory.mm:
547         * History/WebHistoryItem.mm:
548         * History/WebHistoryItemInternal.h:
549         * Misc/WebCoreStatistics.mm:
550         * Misc/WebDownload.m:
551         * Misc/WebGraphicsExtras.c:
552         * Misc/WebKitLogging.h:
553         * Misc/WebKitSystemBits.m:
554         * Misc/WebLocalizableStrings.m:
555         * Misc/WebNSArrayExtras.m:
556         * Misc/WebNSDataExtras.m:
557         * Misc/WebNSDictionaryExtras.m:
558         * Misc/WebNSFileManagerExtras.m:
559         * Misc/WebNSPasteboardExtras.mm:
560         * Misc/WebNSURLExtras.mm:
561         * Misc/WebNSUserDefaultsExtras.m:
562         * Panels/WebAuthenticationPanel.m:
563         * Panels/WebPanelAuthenticationHandler.m:
564         * Plugins/WebBaseNetscapePluginView.mm:
565         * Plugins/WebBasePluginPackage.m:
566         * Plugins/WebNetscapePluginEmbeddedView.mm:
567         * Plugins/WebPluginContainerCheck.mm:
568         * Plugins/WebPluginController.mm:
569         * Plugins/WebPluginDatabase.mm:
570         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
571         * WebCoreSupport/WebKeyGenerator.m:
572         * WebCoreSupport/WebViewFactory.mm:
573         * WebKitPrefix.h:
574         * WebView/WebHTMLRepresentation.mm:
575         * WebView/WebPDFRepresentation.m:
576         * WebView/WebPDFView.mm:
577         * WebView/WebScriptDebugger.mm:
578
579 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
580
581         Reviewed by Darin.
582
583         Disable JSLock for per-thread contexts.
584
585         * Misc/WebCoreStatistics.mm:
586         (+[WebCoreStatistics javaScriptObjectsCount]):
587         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
588         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
589         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
590         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
591         (+[WebCoreStatistics shouldPrintExceptions]):
592         (+[WebCoreStatistics setShouldPrintExceptions:]):
593         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
594         * Plugins/WebBaseNetscapePluginView.mm:
595         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
596         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
597         (-[WebBaseNetscapePluginView start]):
598         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
599         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
600         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
601         (-[WebBaseNetscapePluginView loadPluginRequest:]):
602         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
603         * Plugins/WebPluginController.mm:
604         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
605         (-[WebPluginController startAllPlugins]):
606         (-[WebPluginController stopAllPlugins]):
607         (-[WebPluginController addPlugin:]):
608         (-[WebPluginController destroyPlugin:]):
609         (-[WebPluginController destroyAllPlugins]):
610         * WebView/WebFrame.mm:
611         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
612         * WebView/WebScriptDebugDelegate.mm:
613         (-[WebScriptCallFrame evaluateWebScript:]):
614         * WebView/WebView.mm:
615         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
616         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
617         doesn't need locking. In the future, it may be possible to remove some of these if we
618         establish that this won't make JSC assertions fail (and that we don't want to add such
619         assertions either).
620         Added includes that are now needed.
621
622 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
623
624         Build fix.
625
626         * WebView/WebView.mm:
627
628 2008-07-01  Anders Carlsson  <andersca@apple.com>
629
630         Reviewed by Darin.
631
632         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
633         
634         * Plugins/WebBaseNetscapePluginView.mm:
635         (-[WebBaseNetscapePluginView _createPlugin]):
636         Register the plug-in instance.
637         
638         (-[WebBaseNetscapePluginView _destroyPlugin]):
639         Unegister the plug-in instance.
640         
641         * Plugins/WebNetscapePluginPackage.m:
642         (-[WebNetscapePluginPackage load]):
643         Set NPN_PluginThreadAsyncCall.
644         
645         * Plugins/npapi.mm:
646         (NPN_PluginThreadAsyncCall):
647         Implement this.
648
649 2008-07-01  Dan Bernstein  <mitz@apple.com>
650
651         Reviewed by Darin Adler.
652
653         - WebKit part of moving the method to set the base writing direction from Frame to Editor
654
655         * WebView/WebHTMLView.mm:
656         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
657         Editor method.
658         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
659         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
660
661 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
662
663         Build fix: forgot to check in this file.
664
665         * WebView/WebScriptDebugger.mm:
666         (WebScriptDebugger::WebScriptDebugger):
667
668 2008-06-30  Dan Bernstein  <mitz@apple.com>
669
670         Reviewed by Adele Peterson.
671
672         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
673
674         * WebView/WebHTMLView.mm:
675         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
676         WebCore::Frame::setSelectionBaseWritingDirection() instead of
677         WebCore::Editor::setBaseWritingDirection().
678         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
679         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
680
681 2008-06-28  Darin Adler  <darin@apple.com>
682
683         - fix build
684
685         * WebView/WebView.mm:
686         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
687
688 2008-06-26  Anders Carlsson  <andersca@apple.com>
689
690         Reviewed by Darin.
691
692         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
693         if necessary. Use this for the WebView class. 
694                 
695         * WebView/MainThreadObjectDeallocator.h: Added.
696         * WebView/MainThreadObjectDeallocator.mm: Added.
697         (deallocCallback):
698         (scheduleDeallocateOnMainThread):
699         * WebView/WebView.mm:
700         (-[WebViewPrivate dealloc]):
701         (+[WebView initialize]):
702
703 2008-06-25  Anders Carlsson  <andersca@apple.com>
704
705         Reviewed by Mark.
706
707         <rdar://problem/5984270> 
708         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
709         
710         * WebView/WebView.mm:
711         (tigerMailReleaseIMP):
712         New method that makes sure that the final release happens on the main thread.
713         
714         (-[WebView release]):
715         New method that just calls [super release];
716         
717         (+[WebView initialize]):
718         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
719
720 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
721
722         Reviewed by Geoff.
723
724         Make Machine per-JSGlobalData.
725
726         * WebView/WebScriptDebugger.mm:
727         (WebScriptDebugger::WebScriptDebugger):
728
729 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
730
731         Reviewed by Darin.
732
733         Prepare JavaScript heap for being per-thread.
734
735         * Misc/WebCoreStatistics.mm:
736         (+[WebCoreStatistics javaScriptObjectsCount]):
737         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
738         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
739         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
740         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
741         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
742         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
743
744 2008-06-17  Darin Adler  <darin@apple.com>
745
746         Reviewed by Sam.
747
748         * WebView/WebHTMLView.mm:
749         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
750         to create a CSSMutableStyleDeclaration.
751
752 2008-06-16  Mark Rowe  <mrowe@apple.com>
753
754         Reviewed by Darin Adler.
755
756         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
757
758         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
759         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
760         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
761         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
762
763         * WebView/WebHTMLView.mm:
764         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
765         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
766         * WebView/WebHTMLViewInternal.h:
767         * WebView/WebHTMLViewPrivate.h:
768
769 2008-06-15  Darin Adler  <darin@apple.com>
770
771         - give Frame object functions shorter names: scriptProxy() -> script(),
772           selectionController() -> selection(), animationController() -> animation()
773
774         * Plugins/WebPluginController.mm:
775         (-[WebPluginController webPlugInContainerSelectionColor]):
776         * WebView/WebFrame.mm:
777         (-[WebFrame _attachScriptDebugger]):
778         (-[WebFrame _hasSelection]):
779         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
780         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
781         (-[WebFrame _convertToNSRange:]):
782         (-[WebFrame _convertToDOMRange:]):
783         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
784         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
785         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
786         (-[WebFrame _selectedNSRange]):
787         (-[WebFrame _selectNSRange:]):
788         (-[WebFrame globalContext]):
789         * WebView/WebHTMLView.mm:
790         (-[WebHTMLView _selectedRange]):
791         (-[WebHTMLView _hasSelection]):
792         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
793         (-[WebHTMLView _hasInsertionPoint]):
794         (-[WebHTMLView _isEditable]):
795         (-[WebHTMLView _updateFocusedAndActiveState]):
796         (-[WebHTMLView readSelectionFromPasteboard:]):
797         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
798         (-[WebHTMLView maintainsInactiveSelection]):
799         (-[WebHTMLView paste:]):
800         (isTextInput):
801         (-[WebHTMLView inputContext]):
802         (-[WebTextCompleteController doCompletion]):
803         (-[WebHTMLView selectAll]):
804         (-[WebHTMLView deselectAll]):
805         (-[WebHTMLView selectedAttributedString]):
806         * WebView/WebView.mm:
807         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
808         (-[WebView setSelectedDOMRange:affinity:]):
809         (-[WebView selectedDOMRange]):
810         (-[WebView selectionAffinity]):
811
812 2008-06-15  Darin Adler  <darin@apple.com>
813
814         - rename KJS::List to KJS::ArgList
815
816         * WebView/WebScriptDebugger.h:
817
818 2008-06-15  Darin Adler  <darin@apple.com>
819
820         - new names for more JavaScriptCore files
821
822         * WebView/WebView.mm:
823
824 2008-06-15  Darin Adler  <darin@apple.com>
825
826         - new names for a few key JavaScriptCore files
827
828         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
829         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
830         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
831         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
832         * ForwardingHeaders/kjs/function.h: Removed.
833         * ForwardingHeaders/kjs/internal.h: Removed.
834         * ForwardingHeaders/kjs/object.h: Removed.
835         * ForwardingHeaders/kjs/value.h: Removed.
836         * WebView/WebScriptDebugDelegate.mm:
837
838 2008-06-15  Darin Adler  <darin@apple.com>
839
840         Rubber stamped by Sam.
841
842         - use JS prefix and simpler names for basic JavaScriptCore types,
843           to complement JSValue and JSObject
844
845         * WebView/WebView.mm:
846         (aeDescFromJSValue):
847
848 2008-06-14  Darin Adler  <darin@apple.com>
849
850         Rubber stamped by Sam.
851
852         - new names for kjs_binding.h and kjs_proxy.h
853
854         * WebView/WebFrame.mm:
855         * WebView/WebScriptDebugDelegate.mm:
856         * WebView/WebView.mm:
857
858 2008-06-14  Darin Adler  <darin@apple.com>
859
860         Rubber stamped by Sam.
861
862         - renamed HTMLGenericFormElement to HTMLFormControlElement
863
864         * WebView/WebHTMLRepresentation.mm:
865         (-[WebHTMLRepresentation elementWithName:inForm:]):
866         (-[WebHTMLRepresentation controlsInForm:]):
867
868 2008-06-14  Darin Adler  <darin@apple.com>
869
870         Reviewed by Sam.
871
872         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
873           start ref counts at 1 instead of 0 for speed
874
875         * WebCoreSupport/WebFrameLoaderClient.mm:
876         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
877         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
878         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
879         conventional ones without a special case.
880
881         * WebView/WebDataSource.mm:
882         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
883         this function takes ownership of the DocumentLoader.
884         (-[WebDataSource initWithRequest:]): Use create instead of new.
885         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
886         PassRefPtr and also cleaned up the header a bit.
887
888         * WebView/WebDocumentLoaderMac.h:
889         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
890         functions private.
891
892         * WebView/WebFrame.mm:
893         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
894         of new.
895
896 2008-06-14  Darin Adler  <darin@apple.com>
897
898         Reviewed by Sam.
899
900         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
901           start ref counts at 1 instead of 0 for speed
902
903         * WebView/WebFrame.mm:
904         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
905         * WebView/WebPDFView.mm:
906         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
907
908 2008-06-13  Darin Adler  <darin@apple.com>
909
910         Reviewed by John Sullivan.
911
912         - updated for addition of FormState argument to action policy functions
913         - added WebActionFormKey
914
915         * WebCoreSupport/WebFrameLoaderClient.h:
916         * WebCoreSupport/WebFrameLoaderClient.mm:
917         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
918         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
919         (WebFrameLoaderClient::actionDictionary):
920         * WebKit.exp:
921         * WebView/WebPolicyDelegate.mm:
922         * WebView/WebPolicyDelegatePrivate.h:
923
924 2008-06-12  John Sullivan  <sullivan@apple.com>
925
926         Reviewed by Dan and Darin
927
928         Clear up the confusion about _close (older private method) vs -close (newer public method).
929
930         * WebView/WebView.mm:
931         (-[WebView _isClosed]):
932         simplified style
933         (-[WebView _close]):
934         added a comment about how clients and subclasses should use -close instead
935         (-[WebView dealloc]):
936         call -close instead of _close, so subclasses that override the public method will have the intended behavior
937         (-[WebView close]):
938         added a comment
939         (-[WebView _windowWillClose:]):
940         call -close instead of _close, so subclasses that override the public method will have the intended behavior
941
942         * WebView/WebViewPrivate.h:
943         added a comment about how clients and subclasses should use -close instead
944
945 2008-06-07  Darin Adler  <darin@apple.com>
946
947         Reviewed by Mitz.
948
949         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
950           start ref counts at 1 instead of 0 for speed
951
952         * History/WebHistoryItem.mm:
953         (-[WebHistoryItem init]):
954         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
955         (-[WebHistoryItem initWithURL:target:parent:title:]):
956         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
957         * WebView/WebView.mm:
958         (+[WebView _decodeData:]):
959
960 2008-06-03  Oliver Hunt  <oliver@apple.com>
961
962         Reviewed by Tim.
963
964         Bug 12983: Web Inspector break on the debugger keyword
965         <https://bugs.webkit.org/show_bug.cgi?id=12983>
966
967         Add stubs to allow old webkit debugger interface to build.
968
969         * WebView/WebScriptDebugger.h:
970         * WebView/WebScriptDebugger.mm:
971
972 2008-06-03  Anders Carlsson  <andersca@apple.com>
973
974         Reviewed by Darin.
975
976         <rdar://problem/5980961>
977         
978         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
979         newBottom to be larger than oldBottom which is illegal.
980         
981         * WebView/WebHTMLView.mm:
982         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
983
984 2008-06-02  Anders Carlsson  <andersca@apple.com>
985
986         Reviewed by Mitz.
987
988         Speculative fix for <rdar://problem/5661112> 
989         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
990         
991         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
992         layouts to be triggered.
993         
994         * Plugins/WebBaseNetscapePluginView.mm:
995         (-[WebBaseNetscapePluginView _createPlugin]):
996
997 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
998
999         Reviewed by Darin.
1000         
1001         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
1002         
1003         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
1004         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
1005         setting and retrieving pasteboard types with UTIs, but we don't know of any
1006         applications on Tiger that put only PNG on the pasteboard.
1007
1008         * WebView/WebHTMLView.mm:
1009         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1010         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1011
1012 2008-05-29  Anders Carlsson  <andersca@apple.com>
1013
1014         Reviewed by Brady.
1015
1016         <rdar://problem/5970312> 
1017         icon file specified for stand alone web app causes crash if the icon can't be found
1018         
1019         Handle the case where iconData is null.
1020         
1021         * Misc/WebIconFetcher.mm:
1022         (WebIconFetcherClient::finishedFetchingIcon):
1023
1024 2008-05-29  Anders Carlsson  <andersca@apple.com>
1025
1026         Reviewed by Mitz.
1027
1028         <rdar://problem/5971845>
1029         https://bugs.webkit.org/show_bug.cgi?id=19313
1030         Add version member to NPCocoaEvent
1031
1032         Initialize the version member to 0 for all events.
1033         
1034         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1035         (initializeEvent):
1036         (WebNetscapePluginEventHandlerCocoa::drawRect):
1037         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1038         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1039         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1040         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1041         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1042
1043 2008-05-29  Dan Bernstein  <mitz@apple.com>
1044
1045         Reviewed by Jessica Kahn.
1046
1047         - fix <rdar://problem/5965013> Page 2 does not print correctly
1048
1049         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
1050         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
1051         -viewWillDraw being sent first, which could lead to painting without
1052         valid layout. The fix is to ensure up-to-date layout in those methods
1053         when printing.
1054
1055         * WebView/WebHTMLView.mm:
1056         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1057         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1058
1059 2008-05-28  Anders Carlsson  <andersca@apple.com>
1060
1061         Reviewed by Jon.
1062
1063         Remove workaround, this is no longer a problem.
1064         
1065         * WebView/WebView.mm:
1066         (-[WebView _removeObjectForIdentifier:]):
1067
1068 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
1069
1070         Reviewed by Tim Hatcher.
1071         
1072         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
1073         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
1074         clicking button in returnEvent-crash.html
1075         
1076         Added implementations for willExecuteProgram and didExecuteProgram, which
1077         take care of making sure we're not hanging on to stale data.
1078
1079 2008-05-27  Timothy Hatcher  <timothy@apple.com>
1080
1081         Fixes a bug where unplugging the monitor from a video card and
1082         moving it to another video card would no longer show OpenGL plugins
1083         until you relaunched Safari.
1084
1085         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
1086         attribute to OpenGL contexts
1087
1088         Reviewed by Kevin Decker.
1089
1090         * Plugins/WebBaseNetscapePluginView.mm:
1091         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
1092         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
1093         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
1094
1095 2008-05-25  Mark Rowe  <mrowe@apple.com>
1096
1097         Reviewed by Darin Adler.
1098
1099         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1100
1101         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
1102         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
1103
1104         * WebView/WebFrame.mm:
1105         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
1106         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
1107         * WebView/WebFrameInternal.h:
1108         * WebView/WebFramePrivate.h:
1109
1110 2008-05-23  Timothy Hatcher  <timothy@apple.com>
1111
1112         Fix attaching and detaching the Web Inspector. This change removes
1113         the clunky animation that never looked right and was causing issues
1114         where the inspected WebView would get into a no useable state.
1115
1116         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
1117         can cause the inspected WebVIew to be unusable
1118
1119         Reviewed by Adam Roben.
1120
1121         * WebCoreSupport/WebInspectorClient.mm:
1122         (-[WebInspectorWindowController close]): Removes animation code.
1123         Sets the frame directly and does a displayIfNeeded to prevent
1124         showing the Inspector in the page and in the Inspector window.
1125         (-[WebInspectorWindowController showWindow:]): Removes animation code.
1126         Sets the frame directly.
1127         (-[WebInspectorWindowController attach]): Simplified.
1128         (-[WebInspectorWindowController detach]): Ditto.
1129
1130 2008-05-22  Dan Bernstein  <mitz@apple.com>
1131
1132         Reviewed by Darin Adler.
1133
1134         - fix broken documentation of
1135           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1136
1137         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
1138         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1139
1140 2008-05-22  Timothy Hatcher  <timothy@apple.com>
1141
1142         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
1143
1144         Reviewed by Adam Roben.
1145
1146         * WebCoreSupport/WebInspectorClient.mm:
1147         (-[WebInspectorWindowController showWebInspector:]):
1148         (-[WebInspectorWindowController showErrorConsole:]):
1149         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
1150         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
1151         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1152         * WebInspector/WebInspector.h:
1153         * WebInspector/WebInspector.mm:
1154         (-[WebInspector showConsole:]):
1155         (-[WebInspector showTimeline:]):
1156         (-[WebInspector isDebuggingJavaScript]):
1157         (-[WebInspector toggleDebuggingJavaScript:]):
1158         (-[WebInspector startDebuggingJavaScript:]):
1159         (-[WebInspector stopDebuggingJavaScript:]):
1160         (-[WebInspector isProfilingJavaScript]):
1161         (-[WebInspector toggleProfilingJavaScript:]):
1162         (-[WebInspector startProfilingJavaScript:]):
1163         (-[WebInspector stopProfilingJavaScript:]):
1164
1165 2008-05-22  Josh Aas  <joshmoz@gmail.com>
1166
1167         Reviewed by Anders.
1168
1169         <rdar://problem/5956429> 
1170         https://bugs.webkit.org/show_bug.cgi?id=19192
1171         remove NPNVpluginEventModel, fix example plugin
1172         
1173         * Plugins/WebBaseNetscapePluginView.mm:
1174         (-[WebBaseNetscapePluginView getVariable:value:]):
1175
1176 2008-05-21  Anders Carlsson  <andersca@apple.com>
1177
1178         Reviewed by Maciej.
1179
1180         Add WebIconFetcher.
1181         
1182         * Misc/WebIconFetcher.h: Added.
1183         * Misc/WebIconFetcher.mm: Added.
1184         (WebIconFetcherClient::WebIconFetcherClient):
1185         (WebIconFetcherClient::finishedFetchingIcon):
1186         (WebIconFetcherClient::setFetcher):
1187         (-[WebIconFetcher init]):
1188         (-[WebIconFetcher dealloc]):
1189         (-[WebIconFetcher finalize]):
1190         (-[WebIconFetcher cancel]):
1191         (-[WebIconFetcher _initWithIconFetcher:client:]):
1192         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
1193         * Misc/WebIconFetcherInternal.h: Added.
1194         * WebView/WebFrame.mm:
1195         (-[WebFrame fetchApplicationIcon:selector:]):
1196         * WebView/WebFramePrivate.h:
1197
1198 === End merge of squirrelfish ===
1199
1200 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
1201
1202         Reviewed by Tim Hatcher.
1203         
1204         Updated for API changes from merging with trunk WebCore's new debugger.
1205
1206         * WebView/WebScriptDebugDelegate.mm:
1207         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
1208         exception return, since the DebuggerCallFrame no longer automatically
1209         substitutes the exception for the return value.
1210
1211         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
1212         lexical global object, since the debugger attaches based on dynamic
1213         global object.
1214
1215 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
1216
1217         Reviewed by Oliver Hunt.
1218         
1219         Re-enabled previously disabled debugging functionality.
1220         
1221         There are two major changes from how the WebKit debugger used to work:
1222         
1223         (1) All the interesting bits are implemented down in JavaScriptCore. The
1224         debugger just calls through to KJS::DebuggerCallFrame for everything.
1225         
1226         (2) Instead of copyihng a pointer to an ExecState once, the debugger
1227         copies the DebuggerCallFrame passed to it in each callback. This is
1228         because the VM no longer maintains a fully transparent execution state
1229         to which you can hold a pointer, and the DebuggerCallFrames it vends
1230         are temporaries.
1231         
1232         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
1233         from its function. This is safer than the old method, which was to
1234         hold a stale ExecState* and hope for the best.
1235
1236 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1237
1238         Reviewed by Oliver Hunt.
1239
1240         Updated for API changes in KJS::Debugger.
1241
1242         * WebView/WebFrame.mm:
1243         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
1244         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
1245
1246 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1247
1248         Reviewed by Oliver Hunt.
1249         
1250         Updated WebScriptDebugger API to accept a SourceProvider instead
1251         of a WebCore::String, to avoid copying.
1252
1253         (WebScriptDebugger::sourceParsed): Updated this function not to return
1254         a value.
1255
1256 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1257
1258         Build fix: #ifdef'd out some code that doesn't work anymore.
1259
1260 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1261
1262         Reviewed by Oliver Hunt.
1263         
1264         #ifdef'd out some debugger code that doesn't work anymore.
1265
1266         * WebView/WebScriptDebugDelegate.mm:
1267         (-[WebScriptCallFrame scopeChain]):
1268
1269 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
1270
1271         Build fix.
1272
1273         * ChangeLog:
1274         * WebView/WebScriptDebugDelegate.mm:
1275         (-[WebScriptCallFrame scopeChain]):
1276
1277 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
1278
1279         Reviewed by Oliver Hunt.
1280         
1281         Build fix.
1282
1283 === Start merge of squirrelfish ===
1284
1285 2008-05-21  Darin Adler  <darin@apple.com>
1286
1287         - fix build
1288
1289         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
1290         if we want, but if we do, we should probably make some refinements like checking _private->closed
1291         and applicationIsTerminating.
1292
1293 2008-05-21  Darin Adler  <darin@apple.com>
1294
1295         Reviewed by Anders and Kevin Decker.
1296
1297         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
1298
1299         * WebView/WebView.mm:
1300         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
1301         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
1302         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
1303         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
1304         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
1305
1306 2008-05-19  Stephanie Lewis  <slewis@apple.com>
1307
1308         Reviewed by Darin.
1309     
1310         more fast teardown performance work
1311
1312         * Misc/WebDownload.m:
1313         (-[WebDownloadInternal downloadDidBegin:]):
1314         (-[WebDownloadInternal downloadDidFinish:]):
1315         (-[WebDownloadInternal download:didFailWithError:]):
1316         * WebCoreSupport/WebChromeClient.h:
1317         * WebCoreSupport/WebChromeClient.mm:
1318         (WebChromeClient::disableSuddenTermination):
1319         (WebChromeClient::enableSuddenTermination):
1320
1321 2008-05-18  Dan Bernstein  <mitz@apple.com>
1322
1323         Reviewed by Sam Weinig.
1324
1325         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
1326
1327         * Panels/WebAuthenticationPanel.m:
1328         (-[WebAuthenticationPanel setUpForChallenge:]):
1329
1330 2008-05-16  Timothy Hatcher  <timothy@apple.com>
1331
1332         Removes WebScriptDebugServer files and related calls. This removes
1333         the hooks that Drosera uses for debugging. Now that the Web Inspector
1334         has a better debugger, we don't need these anymore.
1335
1336         Reviewed by Sam Weinig.
1337
1338         * DefaultDelegates/WebScriptDebugServer.h: Removed.
1339         * DefaultDelegates/WebScriptDebugServer.m: Removed.
1340         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
1341         * WebCoreSupport/WebFrameLoaderClient.mm:
1342         * WebKit.exp:
1343         * WebView/WebScriptDebugDelegate.mm:
1344         * WebView/WebScriptDebugger.mm:
1345         (WebScriptDebugger::sourceParsed):
1346         (WebScriptDebugger::callEvent):
1347         (WebScriptDebugger::atStatement):
1348         (WebScriptDebugger::returnEvent):
1349         (WebScriptDebugger::exception):
1350         * WebView/WebView.mm:
1351         (-[WebView _commonInitializationWithFrameName:groupName:]):
1352         * WebView/WebViewPrivate.h:
1353
1354 2008-05-16  Brady Eidson  <beidson@apple.com>
1355
1356         Reviewed by Anders
1357
1358         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
1359
1360         Took the opportunity to touch up another pref that needs the same standardization.
1361         That pref is currently not in use on Mac.
1362
1363         * WebView/WebPreferences.m:
1364         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
1365         (-[WebPreferences _localStorageDatabasePath]):
1366         (-[WebPreferences _setLocalStorageDatabasePath:]):
1367         (-[WebPreferences _ftpDirectoryTemplatePath]):
1368
1369 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
1370
1371         Reviewed by Alice Liu
1372
1373         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
1374
1375         * WebView/WebFrame.mm:
1376         (-[WebFrame _accessibilityTree]):
1377
1378 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1379         
1380         fix mac build
1381
1382         * WebView/WebView.mm:
1383         (-[WebView closeWithFastTeardown]):
1384
1385 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1386
1387         Reviewed by Anders.
1388
1389         Turn on fast teardown.  I added a preference for using full teardown because 
1390         the LEAKS output will be useless without a full teardown.  
1391
1392         preference for fullteardown
1393         * WebView/WebPreferenceKeysPrivate.h:
1394         * WebView/WebPreferences.m:
1395         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1396         (-[WebPreferences fullDocumentTeardownEnabled]):
1397         * WebView/WebPreferencesPrivate.h:
1398         
1399         on application quit dispatch unload events and destroy plugins then exit
1400         * WebView/WebView.mm:
1401         (-[WebView closeWithFastTeardown]):
1402         (-[WebView _close]):
1403         * WebView/WebViewPrivate.h:
1404
1405 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1406
1407         Reviewed by Anders.
1408
1409         get the pending frame unload count from WebCore
1410
1411         * WebView/WebFrame.mm:
1412         (-[WebFrame _pendingFrameUnloadEventCount]):
1413         * WebView/WebFramePrivate.h:
1414
1415 2008-05-15  John Sullivan  <sullivan@apple.com>
1416
1417         Reviewed by Kevin Decker
1418         
1419         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1420           screen when new tab appears
1421           
1422         The highlight should go away entirely, but this simple patch just makes it not jump away.
1423         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1424
1425         * WebInspector/WebNodeHighlight.m:
1426         (-[WebNodeHighlight _repositionHighlightWindow]):
1427         Bail out if target view isn't in a window
1428
1429 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1430
1431         Reviewed by Anders.
1432
1433         Track views that contain plugin instances so that they can be destroyed at application
1434         quit without walking the entire document tree.
1435
1436         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1437         plugins are created and destroyed
1438         * Plugins/WebBaseNetscapePluginView.mm:
1439         (-[WebBaseNetscapePluginView start]):
1440         (-[WebBaseNetscapePluginView stop]):
1441  
1442         Add/remove WebKit plugin views from instance list
1443         * Plugins/WebPluginController.mm:
1444         (-[WebPluginController addPlugin:]):
1445         (-[WebPluginController destroyPlugin:]):
1446         (-[WebPluginController destroyAllPlugins]):
1447
1448         Add a set of views with plugin instances to the WebPluginDatabase
1449         * Plugins/WebPluginDatabase.h:
1450         * Plugins/WebPluginDatabase.mm:
1451         (-[WebPluginDatabase init]):
1452         (-[WebPluginDatabase dealloc]):
1453         (-[WebPluginDatabase addPluginInstanceView:]):
1454         (-[WebPluginDatabase removePluginInstanceView:]):
1455         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1456         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1457         
1458         Handle cases where plugin views are detached before the plugin is destroyed.
1459         * WebCoreSupport/WebFrameLoaderClient.mm:
1460         (WebFrameLoaderClient::detachedFromParent2):
1461         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1462         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1463
1464         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1465         * WebView/WebHTMLView.mm:
1466         (-[WebHTMLView _destroyAllWebPlugins]):
1467         * WebView/WebHTMLViewInternal.h:
1468         * WebView/WebView.mm:
1469         (-[WebView addPluginInstanceView:]):
1470         (-[WebView removePluginInstanceView:]):
1471         (-[WebView removePluginInstanceViewsFor:]):
1472         * WebView/WebViewInternal.h:
1473
1474 2008-05-15  Brady Eidson  <beidson@apple.com>
1475
1476         Reviewed by Tim Hatcher
1477
1478         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1479         before setting the page group of the new page.
1480         
1481         * WebView/WebView.mm:
1482         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1483           immediately after creating the page so it is in place for initializing the LocalStorageThread
1484
1485 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1486
1487         Fixes the bug where the Web Inspector would flash white while resizing.
1488         This was cause by deferring the window creation.
1489
1490         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1491
1492         Reviewed by Darin Adler.
1493
1494         * WebCoreSupport/WebInspectorClient.mm:
1495         (-[WebInspectorWindowController window]): Don't defer the window creation.
1496
1497 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1498
1499         Tiger build fix.
1500
1501         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1502
1503 2008-05-15  Adele Peterson  <adele@apple.com>
1504
1505         Reviewed and landed by Alexey.
1506
1507         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1508
1509         * Misc/WebNSAttributedStringExtras.mm:
1510         (+[NSAttributedString _web_attributedStringFromRange:]):
1511
1512 2008-05-14  Eric Seidel  <eric@webkit.org>
1513
1514         Reviewed by Oliver.
1515
1516         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1517
1518         * WebView/WebResource.mm:
1519         (-[WebResource data]):
1520
1521 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1522
1523         Reviewed by Dan Bernstein.
1524
1525         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1526
1527         * Plugins/nptextinput.h:
1528
1529 2008-05-13  Anders Carlsson  <andersca@apple.com>
1530
1531         Reviewed by Sam.
1532
1533         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1534         Instead, do it in [WebCache empty].
1535         
1536         * Misc/WebCache.mm:
1537         (+[WebCache empty]):
1538         * WebView/WebView.mm:
1539         (+[WebView _setCacheModel:]):
1540
1541 2008-05-13  chris fleizach  <cfleizach@apple.com>
1542
1543         Reviewed by Beth Dakin
1544
1545         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1546
1547         * WebCoreSupport/WebViewFactory.mm:
1548         (-[WebViewFactory AXWebAreaText]):
1549
1550 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1551
1552         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1553         was referencing a nil WebView under validateUserInterfaceItem.
1554         The validateUserInterfaceItem methods was being called at a time
1555         when the WebHTMLView is being torndown.
1556
1557         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1558         while mousing down on menu bar after Xcode News window is opened
1559
1560         Reviewed by Ada Chan.
1561
1562         * WebView/WebHTMLView.mm:
1563         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1564         return NO when it is nil. Adds a comment.
1565         * WebView/WebPDFView.mm:
1566         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1567
1568 2008-05-13  Mark Rowe  <mrowe@apple.com>
1569
1570         Reviewed by John Sullivan.
1571
1572         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1573
1574         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1575         * Carbon/HIWebView.m: Ditto.
1576         (HIWebViewCreate):
1577         (HIWebViewConstructor):
1578
1579 2008-05-12  Dan Bernstein  <mitz@apple.com>
1580
1581         Reviewed by Ada Chan.
1582
1583         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1584           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1585
1586         Added font cache statistics and a function to purge inactive font data.
1587
1588         * Misc/WebCoreStatistics.h:
1589         * Misc/WebCoreStatistics.mm:
1590         (+[WebCoreStatistics cachedFontDataCount]):
1591         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1592         (+[WebCoreStatistics purgeInactiveFontData]):
1593         (+[WebCoreStatistics glyphPageCount]):
1594
1595 2008-05-12  Mark Rowe  <mrowe@apple.com>
1596
1597         Reviewed by Tim Hatcher.
1598
1599         Decorate some deprecated delegate methods with the availability macros.
1600
1601         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1602         macros is good for consistency and documentation.
1603
1604         * WebView/WebFrameLoadDelegate.h:
1605         * WebView/WebUIDelegate.h:
1606
1607 2008-05-12  Mark Rowe  <mrowe@apple.com>
1608
1609         Reviewed by Tim Hatcher.
1610
1611         <rdar://problem/5835604> Deprecate HIWebView
1612
1613         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1614
1615         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1616         * Carbon/HIWebView.h: Ditto.
1617
1618 2008-05-12  Kevin Decker  <kdecker@apple.com>
1619
1620         Reviewed by Anders.
1621
1622         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1623         
1624         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
1625         in changeset <http://trac.webkit.org/changeset/31028>
1626         
1627         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
1628         * WebView/WebFrame.mm:
1629         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
1630         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
1631         * WebView/WebFrameInternal.h: Ditto.
1632         * WebView/WebHTMLView.mm: Ditto.
1633         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
1634         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1635         * WebView/WebHTMLViewInternal.h: Ditto.
1636         * WebView/WebHTMLViewPrivate.h: Ditto.
1637
1638 2008-05-12  Anders Carlsson  <andersca@apple.com>
1639
1640         Reviewed by Alexey.
1641
1642         Empty the application cache when changing the cache model.
1643         
1644         * WebView/WebView.mm:
1645         (+[WebView _setCacheModel:]):
1646
1647 2008-05-12  Anders Carlsson  <andersca@apple.com>
1648
1649         Reviewed by Oliver.
1650
1651         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
1652         
1653         * Plugins/WebBaseNetscapePluginView.h:
1654         * Plugins/WebBaseNetscapePluginView.mm:
1655         (-[WebBaseNetscapePluginView start]):
1656         Get the plug-in text input vtable pointer.
1657         
1658         (-[WebBaseNetscapePluginView stop]):
1659         Set the plug-in text input vtable pointer to 0.
1660         
1661         (-[WebBaseNetscapePluginView inputContext]):
1662         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
1663         
1664         (-[WebBaseNetscapePluginView hasMarkedText]):        
1665         (-[WebBaseNetscapePluginView insertText:]):
1666         (-[WebBaseNetscapePluginView markedRange]):
1667         (-[WebBaseNetscapePluginView selectedRange]):
1668         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
1669         (-[WebBaseNetscapePluginView unmarkText]):
1670         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
1671         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
1672         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
1673         (-[WebBaseNetscapePluginView doCommandBySelector:]):
1674         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
1675         (-[WebBaseNetscapePluginView conversationIdentifier]):
1676         Implement NSTextInput and call into the plug-in text input vtable.
1677         
1678         (browserTextInputFuncs):
1679         New method which returns the browser input vtable.
1680         
1681         (-[WebBaseNetscapePluginView getVariable:value:]):
1682         Support getting the browser input vtable pointer.
1683         
1684         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1685         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1686         (WebNetscapePluginEventHandlerCocoa::keyDown):
1687         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1688         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
1689         it means that the event should be passed on to the input manager.
1690          
1691         * Plugins/npapi.mm:
1692         (NPN_MarkedTextAbandoned):
1693         (NPN_MarkedTextSelectionChanged):
1694         Add implementations of browser input method methods.
1695         
1696         * Plugins/nptextinput.h: Added.
1697         Add file with new text input API.
1698
1699 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
1700
1701         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
1702         SquirrelFish merging.
1703
1704         * Misc/WebCoreStatistics.mm:
1705         (+[WebCoreStatistics javaScriptObjectsCount]):
1706         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1707         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1708         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1709         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1710         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1711         * WebView/WebScriptDebugDelegate.mm:
1712         (-[WebScriptCallFrame evaluateWebScript:]):
1713
1714 2008-05-07  Anders Carlsson  <andersca@apple.com>
1715
1716         Reviewed by Mitz.
1717
1718         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
1719         https://bugs.webkit.org/show_bug.cgi?id=18880
1720         <rdar://problem/5909513>
1721
1722         Stop suspending key up events before calling handleEvent.
1723         
1724         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1725         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1726
1727 2008-05-06  Stephanie Lewis  <slewis@apple.com>
1728
1729         Reviewed by Andersca.
1730
1731         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
1732
1733         * Plugins/WebPluginDatabase.m: Removed.
1734         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
1735         * Plugins/npapi.m: Removed.
1736         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
1737
1738 2008-05-06  Anders Carlsson  <andersca@apple.com>
1739
1740         Reviewed by Darin.
1741
1742         Initialize numArchs to 0.
1743         
1744         * Plugins/WebBasePluginPackage.m:
1745         (-[WebBasePluginPackage isNativeLibraryData:]):
1746
1747 2008-05-06  Anders Carlsson  <andersca@apple.com>
1748
1749         Reviewed by Darin.
1750
1751         Add implementation of NPN_PopUpContextMenu.
1752         
1753         * Plugins/WebBaseNetscapePluginView.mm:
1754         (-[WebBaseNetscapePluginView popUpContextMenu:]):
1755         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1756         * Plugins/WebNetscapePluginPackage.m:
1757         (-[WebNetscapePluginPackage load]):
1758         * Plugins/npapi.m:
1759         (NPN_PopUpContextMenu):
1760
1761 2008-05-06  Anders Carlsson  <andersca@apple.com>
1762
1763         Fix typo (don't read random memory).
1764         
1765         * Plugins/WebBasePluginPackage.m:
1766         (-[WebBasePluginPackage isNativeLibraryData:]):
1767
1768 2008-05-05  Anders Carlsson  <andersca@apple.com>
1769
1770         Reviewed by Darin.
1771
1772         Change the isNativeLibraryData: method to handle universal binaries.
1773         
1774         * Plugins/WebBasePluginPackage.m:
1775         (swapIntsInHeader):
1776         (-[WebBasePluginPackage isNativeLibraryData:]):
1777
1778 2008-05-06  Brady Eidson  <beidson@apple.com>
1779
1780         Reviewed by Darin Adler
1781
1782         Preparation for upcoming work making LocalStorage persistent.
1783
1784         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
1785
1786         * WebView/WebView.mm:
1787         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
1788
1789 2008-05-05  Sam Weinig  <sam@webkit.org>
1790
1791         Reviewed by Darin Adler.
1792
1793         Fix for <rdar://problem/5884383>
1794         Escape look-a-like characters from the the entire url.
1795
1796         * Misc/WebNSURLExtras.mm:
1797         (escapeUnsafeCharacters):
1798         (-[NSURL _web_userVisibleString]):
1799
1800 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
1801
1802         Reviewed by Darin.
1803         
1804         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
1805
1806         * WebView/WebView.mm:
1807         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
1808         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
1809         the two interfere.
1810
1811 2008-05-05  Sam Weinig  <sam@webkit.org>
1812
1813         Reviewed by Tim Hatcher.
1814
1815         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
1816
1817         * WebCoreSupport/WebInspectorClient.mm:
1818         (WebInspectorClient::localizedStringsURL):
1819
1820 2008-05-05  Anders Carlsson  <andersca@apple.com>
1821
1822         Reviewed by Jess.
1823
1824         Apparently preflighting can cause hangs for some reason. Revert this for now.
1825         
1826         * Plugins/WebNetscapePluginPackage.m:
1827         (-[WebNetscapePluginPackage _initWithPath:]):
1828         * Plugins/WebPluginPackage.m:
1829         (-[WebPluginPackage initWithPath:]):
1830
1831 2008-05-05  Darin Adler  <darin@apple.com>
1832
1833         Reviewed by Mitz.
1834
1835         - https://bugs.webkit.org/show_bug.cgi?id=18789
1836           fix some shouldCloseWithWindow edge cases
1837
1838         * WebView/WebView.mm:
1839         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
1840         NSWindowWillCloseNotification if the view was moved out of the window but still
1841         had that window set as the host window. Also make sure this function doesn't do
1842         anything if the WebView is already closed.
1843         (-[WebView setHostWindow:]): Ditto.
1844
1845 2008-05-04  David Kilzer  <ddkilzer@apple.com>
1846
1847         Make parameters match for WebChromeClient::addMessageToConsole()
1848
1849         Reviewed by John.
1850
1851         * WebCoreSupport/WebChromeClient.h:
1852         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
1853         to sourceURL to match implementation in WebChromeClient.mm.
1854
1855 2008-05-02  Anders Carlsson  <andersca@apple.com>
1856
1857         Reviewed by Mark.
1858
1859         Various Cocoa event model and 64-bit plug-in fixes.
1860         
1861         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1862         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1863         Set click count.
1864         
1865         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1866         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1867         Don't try to get the mouse location for keyboard events.
1868         
1869         * Plugins/WebPluginPackage.m:
1870         (-[WebPluginPackage initWithPath:]):
1871         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
1872
1873 2008-05-02  Anders Carlsson  <andersca@apple.com>
1874
1875         Reviewed by Sam.
1876
1877         The event union is now named.
1878         
1879         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1880         (WebNetscapePluginEventHandlerCocoa::drawRect):
1881         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1882         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1883         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1884         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1885         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1886
1887 2008-05-02  Anders Carlsson  <andersca@apple.com>
1888
1889         Reviewed by Mark.
1890
1891         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
1892         
1893         Call preflightAndReturnError on the bundle, which will check if any of the architectures
1894         in the bundle match the current architecture.
1895         
1896         * Plugins/WebNetscapePluginPackage.m:
1897         (-[WebNetscapePluginPackage _initWithPath:]):
1898
1899 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
1900
1901         Reviewed by Geoffrey Garen.
1902
1903         https://bugs.webkit.org/show_bug.cgi?id=18826
1904         Make JavaScript heap per-thread
1905
1906         * Misc/WebCoreStatistics.mm:
1907         (+[WebCoreStatistics javaScriptObjectsCount]):
1908         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1909         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1910         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1911         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1912         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1913         Replaced static Collector calls with calls to a current thread's instance.
1914
1915         * WebView/WebScriptDebugDelegate.mm:
1916         (-[WebScriptCallFrame evaluateWebScript:]):
1917         Pass ExecState to jsString().
1918
1919 2008-05-01  Anders Carlsson  <andersca@apple.com>
1920
1921         Reviewed by Mark.
1922
1923         64-bit NPAPI plugin build fixes.
1924         
1925         * Plugins/WebBaseNetscapePluginView.mm:
1926         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1927         (-[WebBaseNetscapePluginView updateAndSetWindow]):
1928         (-[WebBaseNetscapePluginView start]):
1929         (-[WebBaseNetscapePluginView windowBecameKey:]):
1930         * Plugins/WebNetscapeDeprecatedFunctions.c:
1931         * Plugins/WebNetscapeDeprecatedFunctions.h:
1932         * Plugins/WebNetscapePluginEventHandler.mm:
1933         (WebNetscapePluginEventHandler::create):
1934         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1935         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1936         * Plugins/WebPluginDatabase.m:
1937         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
1938
1939 2008-05-01  Anders Carlsson  <andersca@apple.com>
1940
1941         Reviewed by Tim.
1942
1943         Remove duplicate npfunctions.h header from WebKit.
1944
1945         * MigrateHeaders.make:
1946         Migrate npfunctions.h
1947         
1948         * Plugins/npfunctions.h: Removed.
1949
1950 2008-05-01  Anders Carlsson  <andersca@apple.com>
1951
1952         Reviewed by John.
1953         
1954         Add null checks for the event handler.
1955         
1956         * Plugins/WebBaseNetscapePluginView.mm:
1957         (-[WebBaseNetscapePluginView stopTimers]):
1958         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1959
1960 2008-05-01  Anders Carlsson  <andersca@apple.com>
1961
1962         Fix 64-bit build.
1963         
1964         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1965         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1966         * WebCoreSupport/WebFrameLoaderClient.mm:
1967
1968 2008-05-01  Anders Carlsson  <andersca@apple.com>
1969
1970         Fix build.
1971         
1972         * Plugins/npfunctions.h:
1973
1974 2008-05-01  Anders Carlsson  <andersca@apple.com>
1975
1976         Reviewed by Adam.
1977
1978         Forward mouse move events to the Netscape plug-in view.
1979         
1980         * Plugins/WebBaseNetscapePluginView.h:
1981         * Plugins/WebBaseNetscapePluginView.mm:
1982         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1983         New method that just calls the current event handler.
1984         
1985         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1986         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1987         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
1988         don't work on it so don't call them.
1989         
1990         * WebCoreSupport/WebFrameLoaderClient.mm:
1991         (NetscapePluginWidget::NetscapePluginWidget):
1992         New Widget subclass to be used for Netscape plug-ins.
1993         
1994         (NetscapePluginWidget::handleEvent):
1995         Forward NSMouseMoved events to the plug-in.
1996         
1997         (WebFrameLoaderClient::createPlugin):
1998         Wrap the plug-in view in a NetscapePluginWidget.
1999
2000 2008-05-01  Alp Toker  <alp@nuanti.com>
2001
2002         Rubber-stamped by Anders.
2003
2004         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
2005         npapi.h.
2006
2007         Additional fix to use same signedness in npapi.h and Mac for the
2008         interval parameter.
2009
2010         * Plugins/WebBaseNetscapePluginView.h:
2011         * Plugins/WebBaseNetscapePluginView.mm:
2012         (PluginTimer::PluginTimer):
2013         (-[WebBaseNetscapePluginView stopTimers]):
2014         (-[WebBaseNetscapePluginView restartTimers]):
2015         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2016         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2017         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2018         * Plugins/npapi.m:
2019         (NPN_ScheduleTimer):
2020         (NPN_UnscheduleTimer):
2021         * Plugins/npfunctions.h:
2022
2023 2008-04-30  Anders Carlsson  <andersca@apple.com>
2024
2025         Reviewed by Adam.
2026
2027         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
2028         
2029         * Plugins/WebBaseNetscapePluginView.h:
2030         * Plugins/WebBaseNetscapePluginView.mm:
2031         (PluginTimer::PluginTimer):
2032         (PluginTimer::start):
2033         (PluginTimer::fired):
2034         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2035         (-[WebBaseNetscapePluginView stopTimers]):
2036         (-[WebBaseNetscapePluginView restartTimers]):
2037         (-[WebBaseNetscapePluginView scrollWheel:]):
2038         (-[WebBaseNetscapePluginView flagsChanged:]):
2039         (-[WebBaseNetscapePluginView start]):
2040         (-[WebBaseNetscapePluginView eventModel]):
2041         (-[WebBaseNetscapePluginView fini]):
2042         (-[WebBaseNetscapePluginView getVariable:value:]):
2043         (-[WebBaseNetscapePluginView setVariable:value:]):
2044         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2045         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2046         * Plugins/WebBaseNetscapePluginViewInternal.h:
2047         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2048         * Plugins/WebNetscapePluginEventHandler.h:
2049         * Plugins/WebNetscapePluginEventHandler.mm:
2050         (WebNetscapePluginEventHandler::create):
2051         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2052         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2053         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
2054         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
2055         (WebNetscapePluginEventHandlerCarbon::platformWindow):
2056         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
2057         (WebNetscapePluginEventHandlerCocoa::startTimers):
2058         (WebNetscapePluginEventHandlerCocoa::stopTimers):
2059         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
2060         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
2061         (WebNetscapePluginEventHandlerCocoa::drawRect):
2062         (WebNetscapePluginEventHandlerCocoa::mouseDown):
2063         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
2064         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
2065         (WebNetscapePluginEventHandlerCocoa::mouseExited):
2066         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
2067         (WebNetscapePluginEventHandlerCocoa::mouseUp):
2068         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
2069         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2070         (WebNetscapePluginEventHandlerCocoa::keyDown):
2071         (WebNetscapePluginEventHandlerCocoa::keyUp):
2072         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2073         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2074         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
2075         (WebNetscapePluginEventHandlerCocoa::focusChanged):
2076         (WebNetscapePluginEventHandlerCocoa::platformWindow):
2077         (WebNetscapePluginEventHandlerCocoa::sendEvent):
2078         * Plugins/WebNetscapePluginPackage.m:
2079         (-[WebNetscapePluginPackage load]):
2080         * Plugins/npapi.m:
2081         (NPN_ScheduleTimer):
2082         (NPN_UnscheduleTimer):
2083         * Plugins/npfunctions.h:
2084
2085 2008-04-30  Brady Eidson  <beidson@apple.com>
2086
2087         Fix my WebPreferences revert check-in
2088
2089         * WebView/WebView.mm:
2090         (-[WebView _preferencesChangedNotification:]):
2091
2092 2008-04-30  Brady Eidson  <beidson@apple.com>
2093
2094         Rubberstamped by John Sullivan
2095
2096         Revert the remainder of my original preferences changes from last week.
2097         They caused a massive PLT regression (too many notifications being sent out
2098         or listened to that weren't previously) and it's not in my schedule to refine
2099         the preferences code instead of working on my feature!
2100
2101         * WebView/WebView.mm:
2102         (-[WebView _updateSettingsFromPreferences:]):
2103         (-[WebView _commonInitializationWithFrameName:groupName:]):
2104
2105 2008-04-30  Anders Carlsson  <andersca@apple.com>
2106
2107         Fix the 64-bit build.
2108         
2109         * Plugins/WebNetscapePluginEventHandler.h:
2110         * Plugins/WebNetscapePluginEventHandler.mm:
2111         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2112         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2113
2114 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
2115
2116         BUILD FIX for Release build.
2117
2118         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2119         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
2120         separately so the compiler doesn't complain about an unused variable.
2121         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
2122
2123 2008-04-29  Anders Carlsson  <andersca@apple.com>
2124
2125         Reviewed by Adam.
2126
2127         Refactor the Carbon event handling code out into a separate class in preparation for adding
2128         the Cocoa event handling code.
2129         
2130         * Plugins/WebBaseNetscapePluginView.h:
2131         * Plugins/WebBaseNetscapePluginView.mm:
2132         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
2133         (-[WebBaseNetscapePluginView sendActivateEvent:]):
2134         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
2135         (-[WebBaseNetscapePluginView stopTimers]):
2136         (-[WebBaseNetscapePluginView restartTimers]):
2137         (-[WebBaseNetscapePluginView setHasFocus:]):
2138         (-[WebBaseNetscapePluginView mouseDown:]):
2139         (-[WebBaseNetscapePluginView mouseUp:]):
2140         (-[WebBaseNetscapePluginView mouseEntered:]):
2141         (-[WebBaseNetscapePluginView mouseExited:]):
2142         (-[WebBaseNetscapePluginView mouseDragged:]):
2143         (-[WebBaseNetscapePluginView keyUp:]):
2144         (-[WebBaseNetscapePluginView keyDown:]):
2145         (-[WebBaseNetscapePluginView cut:]):
2146         (-[WebBaseNetscapePluginView copy:]):
2147         (-[WebBaseNetscapePluginView paste:]):
2148         (-[WebBaseNetscapePluginView selectAll:]):
2149         (-[WebBaseNetscapePluginView start]):
2150         (-[WebBaseNetscapePluginView stop]):
2151         (-[WebBaseNetscapePluginView fini]):
2152         (-[WebBaseNetscapePluginView drawRect:]):
2153         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
2154         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
2155         (-[WebBaseNetscapePluginView windowBecameKey:]):
2156         (-[WebBaseNetscapePluginView windowResignedKey:]):
2157         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
2158         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
2159         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
2160         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
2161         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2162         (-[WebBaseNetscapePluginView _viewHasMoved]):
2163         * Plugins/WebBaseNetscapePluginViewInternal.h:
2164         * Plugins/WebNetscapePluginEmbeddedView.h:
2165         * Plugins/WebNetscapePluginEventHandler.h: Added.
2166         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
2167         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
2168         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
2169         * Plugins/WebNetscapePluginEventHandler.mm: Added.
2170         (WebNetscapePluginEventHandler::create):
2171         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
2172         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
2173         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
2174         (getCarbonEvent):
2175         (modifiersForEvent):
2176         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
2177         (WebNetscapePluginEventHandlerCarbon::drawRect):
2178         (WebNetscapePluginEventHandlerCarbon::mouseDown):
2179         (WebNetscapePluginEventHandlerCarbon::mouseUp):
2180         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2181         (WebNetscapePluginEventHandlerCarbon::mouseExited):
2182         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
2183         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2184         (WebNetscapePluginEventHandlerCarbon::keyDown):
2185         (keyMessageForEvent):
2186         (WebNetscapePluginEventHandlerCarbon::keyUp):
2187         (WebNetscapePluginEventHandlerCarbon::focusChanged):
2188         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
2189         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
2190         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
2191         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
2192         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
2193         (WebNetscapePluginEventHandlerCarbon::startTimers):
2194         (WebNetscapePluginEventHandlerCarbon::stopTimers):
2195         (WebNetscapePluginEventHandlerCarbon::sendEvent):
2196
2197 2008-04-29  Mark Rowe  <mrowe@apple.com>
2198
2199         Reviewed by David Harrison.
2200
2201         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
2202
2203         * WebKit.exp:
2204         * WebView/WebDynamicScrollBarsView.h:
2205         * WebView/WebDynamicScrollBarsView.m:
2206
2207 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
2208
2209         Reviewed by Darin.
2210
2211         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
2212
2213         * WebCoreSupport/WebChromeClient.h:
2214         * WebCoreSupport/WebChromeClient.mm:
2215         * WebView/WebClipView.m:
2216         (-[WebClipView scrollWheel:]):
2217         * WebView/WebHTMLView.mm:
2218         (-[WebHTMLView addMouseMovedObserver]):
2219         (-[WebHTMLView removeMouseMovedObserver]):
2220         (-[WebHTMLView acceptsFirstMouse:]):
2221         * WebView/WebUIDelegatePrivate.h:
2222         * WebView/WebView.mm:
2223         (-[WebViewPrivate init]):
2224         * WebView/WebViewPrivate.h:
2225
2226 2008-04-28  Rob Buis  <buis@kde.org>
2227
2228         Reviewed by Maciej.
2229
2230         Build fix for Tiger.
2231
2232         * WebView/WebView.mm:
2233         (WebKitInitializeApplicationCachePathIfNecessary):
2234
2235 2008-04-28  Adele Peterson  <adele@apple.com>
2236
2237         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
2238
2239         WebKit part of fix for <rdar://problem/3709505>
2240         Safari should have a way to upload bundles from the file upload control (as zip)
2241
2242         Added UIDelegate methods to let the application handle generating replacement files for uploads.
2243         In this case, Safari will create archived files for bundles so they can be uploaded properly.
2244
2245         * DefaultDelegates/WebDefaultUIDelegate.m:
2246         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
2247         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
2248         * WebCoreSupport/WebChromeClient.h:
2249         * WebCoreSupport/WebChromeClient.mm:
2250         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
2251         (WebChromeClient::generateReplacementFile):
2252         * WebView/WebUIDelegatePrivate.h:
2253
2254 2008-04-28  Anders Carlsson  <andersca@apple.com>
2255
2256         Reviewed by Sam, Mark, Adele and Darin.
2257
2258         Initialize the application cache path.
2259         
2260         * WebView/WebView.mm:
2261         (WebKitInitializeApplicationCachePathIfNecessary):
2262         (-[WebView _commonInitializationWithFrameName:groupName:]):
2263
2264 2008-04-28  Alice Liu  <alice.liu@apple.com>
2265
2266         Reviewed by Darin.
2267
2268         Fix <rdar://problem/4911289> Add tabindex property to all children 
2269         of HTMLElement (7138)
2270         http://bugs.webkit.org/show_bug.cgi?id=7138
2271
2272         * MigrateHeaders.make:
2273         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
2274         because now that focus() has been moved to DOMHTMLElement.h, these
2275         files are no longer needed.
2276
2277 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2278
2279         Reviewed by Darin.
2280
2281         Fix run-webkit-tests --threading
2282         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
2283         Proxy server issue in Sunday's Nightly
2284
2285         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
2286         only done from icon database code, which is not robust enough.
2287
2288 2008-04-20 Adam Barth <hk9565@gmail.com>
2289
2290         Reviewed by Adam Roben and Sam Weinig.
2291
2292         Updated WebSecurityOrigin to match new SecurityOrigin API.
2293
2294         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
2295
2296         * Storage/WebSecurityOrigin.mm:
2297         (-[WebSecurityOrigin host]):
2298         (-[WebSecurityOrigin domain]):
2299         * Storage/WebSecurityOriginPrivate.h:
2300
2301 2008-04-25  Mark Rowe  <mrowe@apple.com>
2302
2303         Rubber-stamped by Sam Weinig.
2304
2305         Add some content to an empty ICU header file to prevent verification errors.
2306
2307         * icu/unicode/utf_old.h:
2308
2309 2008-04-25  Anders Carlsson  <andersca@apple.com>
2310
2311         Reviewed by Sam.
2312
2313         Add offlineWebApplicationCacheEnabled preference.
2314         
2315         * WebView/WebPreferenceKeysPrivate.h:
2316         * WebView/WebPreferences.m:
2317         (+[WebPreferences initialize]):
2318         (-[WebPreferences offlineWebApplicationCacheEnabled]):
2319         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
2320         * WebView/WebPreferencesPrivate.h:
2321         * WebView/WebView.mm:
2322         (-[WebView _updateSettingsFromPreferences:]):
2323
2324 2008-04-24  Mark Rowe  <mrowe@apple.com>
2325
2326         Reviewed by Sam Weinig.
2327
2328         Remove code for calculating the glyph cache size.
2329
2330         * WebCoreSupport/WebSystemInterface.m:
2331         (InitWebCoreSystemInterface): Remove unused symbol.
2332
2333 2008-04-24  Mark Rowe  <mrowe@apple.com>
2334
2335         Reviewed by Sam Weinig.
2336
2337         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
2338
2339         * WebKitPrefix.h:
2340
2341 2008-04-24  Brady Eidson  <beidson@apple.com>
2342
2343         Reviewed by Darin
2344
2345         Fix layout test regressions from my earlier preferences/settings tweak.
2346
2347         * WebView/WebView.mm:
2348         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
2349           the notification to update the settings, each WebView still needs to register for the
2350           notification - restore that behavior.
2351
2352 2008-04-24  Dan Bernstein  <mitz@apple.com>
2353
2354         Reviewed by Darin Adler.
2355
2356         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
2357           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
2358
2359         * WebView/WebFrame.mm:
2360         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
2361         VisiblePosition::caretRect() instead of the RenderObject method which
2362         was removed.
2363
2364 2008-04-24  Brady Eidson  <beidson@apple.com>
2365
2366         Reviewed by Darin
2367
2368         Rework the Settings population again.
2369
2370         * WebView/WebView.mm:
2371         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
2372           and directly from WebView's common init function.
2373         (-[WebView _preferencesChangedNotification:]):
2374         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
2375           after creating the new Page
2376
2377 2008-04-24  Darin Adler  <darin@apple.com>
2378
2379         Reviewed by Geoff.
2380
2381         - fix crash in regression test where we'd ask a frame for a user agent string
2382           after the WebView was already closed
2383
2384         * WebCoreSupport/WebFrameLoaderClient.mm:
2385         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2386         added some code to prevent the crash in release builds if this problem happens
2387         again.
2388
2389 2008-04-24  Anders Carlsson  <andersca@apple.com>
2390
2391         Reviewed by Sam.
2392
2393         Change some String arguments to be const references instead.
2394
2395         * WebCoreSupport/WebEditorClient.h:
2396         * WebCoreSupport/WebEditorClient.mm:
2397         (WebEditorClient::shouldInsertText):
2398
2399 2008-04-24  John Sullivan  <sullivan@apple.com>
2400
2401         Mac build fix
2402         
2403         * WebCoreSupport/WebViewFactory.mm:
2404         (-[WebViewFactory AXButtonActionVerb]):
2405         implement this method using the text in WebCoreLocalizedStrings.cpp
2406         (-[WebViewFactory AXRadioButtonActionVerb]):
2407         ditto
2408         (-[WebViewFactory AXTextFieldActionVerb]):
2409         ditto
2410         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2411         ditto
2412         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2413         ditto
2414         (-[WebViewFactory AXLinkActionVerb]):
2415         ditto
2416
2417 2008-04-23  Brady Eidson  <beidson@apple.com>
2418
2419         Reviewed by Sam Weinig
2420
2421         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2422         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2423         thereby populating the Settings object, immediately after the Page is created.
2424
2425         * WebView/WebView.mm:
2426         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2427
2428 2008-04-24  John Sullivan  <sullivan@apple.com>
2429
2430         Reviewed by Jess
2431         
2432         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2433
2434         * Misc/WebNSControlExtras.m:
2435         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2436         deploy userSpaceScaleFactor when using view distances on the window
2437
2438 2008-04-22  Anders Carlsson  <andersca@apple.com>
2439
2440         Reviewed by Darin.
2441
2442         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2443         
2444         * Plugins/npfunctions.h:
2445
2446 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2447
2448         Mysteriously reviewed by mitz|away.
2449
2450         Bug 18111: Closing a tab while dragging crashes Safari
2451         https://bugs.webkit.org/show_bug.cgi?id=18111
2452
2453         Null check the page before handling drag events.
2454
2455         * WebView/WebView.mm:
2456         (-[WebView draggingUpdated:]):
2457         (-[WebView draggingExited:]):
2458
2459 2008-04-19  Brady Eidson  <beidson@apple.com>
2460
2461         Reviewed by Tim Hatcher
2462
2463         Add a WebPreference for the path of the local storage persistent store.
2464
2465         * WebView/WebPreferenceKeysPrivate.h:
2466
2467         * WebView/WebPreferences.m:
2468         (-[WebPreferences _localStorageDatabasePath]):
2469         (-[WebPreferences _setLocalStorageDatabasePath:]):
2470         * WebView/WebPreferencesPrivate.h:
2471
2472         * WebView/WebView.mm:
2473         (-[WebView _preferencesChangedNotification:]):
2474
2475 2008-04-18  Brady Eidson  <beidson@apple.com>
2476
2477         Reviewed by Sam Weinig
2478
2479         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2480         No reason to do the work twice...
2481
2482         * WebView/WebView.mm:
2483         (-[WebView _close]):
2484
2485 2008-04-17  Eric Seidel  <eric@webkit.org>
2486
2487         Reviewed by beth.
2488
2489         Rename Frame::renderer() to contentRenderer() and fix uses.
2490
2491         * Misc/WebCoreStatistics.mm:
2492         * WebView/WebRenderNode.mm:
2493         (-[WebRenderNode initWithWebFrameView:]):
2494
2495 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2496
2497         Reviewed by mrowe.
2498
2499         * WebView/WebFrame.mm: Remove temporary build fix.
2500
2501 2008-04-17  Mark Rowe  <mrowe@apple.com>
2502
2503         Reviewed by Dan Bernstein.
2504
2505         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2506
2507         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2508
2509         * WebCoreSupport/WebFrameLoaderClient.mm:
2510         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2511
2512 2008-04-17  Mark Rowe  <mrowe@apple.com>
2513
2514         Rubber-stamped by Dan Bernstein.
2515
2516         Fix the Mac build.
2517
2518         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2519         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2520         for this to live going forward.
2521
2522 2008-04-15  Kevin Decker  <kdecker@apple.com>
2523
2524         Reviewed by Anders.
2525
2526         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2527         
2528         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2529         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2530         a bundle out from underneath itself.
2531
2532         * Plugins/WebBasePluginPackage.h: Added unload method.
2533         * Plugins/WebBasePluginPackage.m:
2534         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2535         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2536         * Plugins/WebNetscapePluginPackage.m:
2537         (-[WebNetscapePluginPackage unload]): Added.
2538
2539 2008-04-15  Anders Carlsson  <andersca@apple.com>
2540
2541         Reviewed by Adam.
2542
2543         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2544
2545         * Configurations/WebKit.xcconfig:
2546
2547 2008-04-15  Brady Eidson  <beidson@apple.com>
2548
2549         Reviewed by John Sullivan
2550
2551         Do a more complete job adding the "WebArchiveDebugMode" pref
2552
2553         * WebView/WebPreferences.m: Add both getter *and* setter
2554         (-[WebPreferences webArchiveDebugModeEnabled]):
2555         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2556         * WebView/WebPreferencesPrivate.h:
2557
2558         * WebView/WebView.mm:
2559         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2560
2561 2008-04-14  Brady Eidson  <beidson@apple.com>
2562
2563         Reviewed by Anders
2564
2565         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2566         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2567         network and will instead fail the load as "cancelled."
2568
2569         * WebView/WebPreferenceKeysPrivate.h:
2570
2571         * WebView/WebPreferences.m:
2572         (+[WebPreferences initialize]):
2573         (-[WebPreferences _webArchiveDebugModeEnabled]):
2574         * WebView/WebPreferencesPrivate.h:
2575
2576         * WebView/WebView.mm:
2577         (-[WebView _preferencesChangedNotification:]):
2578
2579 2008-04-11  David Hyatt  <hyatt@apple.com>
2580
2581         Rename CachedResource ref/deref methods to addClient/removeClient.
2582
2583         Reviewed by olliej
2584
2585         * WebView/WebHTMLView.mm:
2586         (-[WebHTMLViewPrivate dealloc]):
2587         (-[WebHTMLViewPrivate finalize]):
2588         (-[WebHTMLViewPrivate clear]):
2589         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2590
2591 2008-04-07  Brady Eidson  <beidson@apple.com>
2592
2593         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2594
2595         * Configurations/WebKit.xcconfig:
2596
2597 2008-04-04  Adam Roben  <aroben@apple.com>
2598
2599         Use WebCore's ICU headers instead of our own copy
2600
2601         Rubberstamped by Tim Hatcher.
2602
2603         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2604         PrivateHeaders.
2605
2606 2008-04-04  Adam Roben  <aroben@apple.com>
2607
2608         Fix <rdar://problem/5804776> Would like to use WebCore's
2609         ForwardingHeaders in WebKit without manually creating copies
2610
2611         Patch by Tim Hatcher, typed by me.
2612
2613         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2614         WebCore's PrivateHeaders instead of our own copy.
2615
2616 2008-04-04  Ada Chan  <adachan@apple.com>
2617
2618         Now we pass width and height directly as integers to format
2619         the window title for a standalone image.
2620
2621         Reviewed by Dan.
2622
2623         * WebCoreSupport/WebViewFactory.mm:
2624         (-[WebViewFactory imageTitleForFilename:width:height:]):
2625
2626 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
2627
2628         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
2629
2630         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
2631           font-weight does not properly support graded weights
2632
2633         * WebView/WebHTMLView.mm:
2634         (-[WebHTMLView _styleFromFontAttributes:]):
2635         (-[WebHTMLView _originalFontB]):
2636         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2637
2638 2008-04-02  Mark Rowe  <mrowe@apple.com>
2639
2640         Reviewed by Oliver Hunt.
2641
2642         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
2643
2644         * Configurations/Base.xcconfig:
2645
2646 2008-03-31  Alice Liu  <alice.liu@apple.com>
2647
2648         Reviewed by Darin.
2649
2650         * WebView/WebFrame.mm:
2651         (-[WebFrame _accessibilityTree]):
2652         The syntax for fetching an object from the AXObjectCache changed slightly
2653
2654 2008-03-31  Brady Eidson  <beidson@apple.com>
2655
2656         Reviewed by Jon Honeycutt
2657         
2658         Move a WebArchive loading check into WebCore
2659
2660         * WebView/WebHTMLRepresentation.mm:
2661         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
2662           responsible for checking that state
2663
2664 2008-03-31  Brady Eidson  <beidson@apple.com>
2665
2666         Reviewed by Darin and Mitz's rubber stamp
2667
2668         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2669
2670         * WebCoreSupport/WebEditorClient.mm:
2671         * WebCoreSupport/WebEditorClient.h:
2672
2673 2008-03-28  Brady Eidson  <beidson@apple.com>
2674
2675         Rubberstamped by Darin Adler
2676
2677         Remove WebArchiver.h/mm
2678
2679         * WebView/WebArchiver.h: Removed.
2680         * WebView/WebArchiver.mm: Removed.
2681
2682         * DOM/WebDOMOperations.mm:
2683         * WebCoreSupport/WebDragClient.mm:
2684         * WebCoreSupport/WebEditorClient.mm:
2685         * WebView/WebDataSource.mm:
2686         * WebView/WebHTMLView.mm:
2687
2688 2008-03-28  Brady Eidson  <beidson@apple.com>
2689
2690         Reviewed by Darin Adler
2691
2692         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
2693
2694         * WebCoreSupport/WebEditorClient.mm:
2695         (WebEditorClient::dataForArchivedSelection):
2696
2697         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
2698         * WebView/WebArchiver.mm: Ditto
2699
2700         * WebView/WebHTMLView.mm:
2701         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2702
2703 2008-03-28  Brady Eidson  <beidson@apple.com>
2704
2705         Reviewed by Darin Adler
2706
2707         More Kit->Core WebArchive changes.
2708
2709         Create an archive from the current selection in a frame
2710
2711         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
2712           easily in a followup
2713
2714 2008-03-28  Brady Eidson  <beidson@apple.com>
2715
2716         Reviewed by Sam Weinig
2717
2718         WebArchive saga continues - Can now make archives from ranges in WebCore
2719
2720         * DOM/WebDOMOperations.mm:
2721         (-[DOMRange webArchive]):
2722         (-[DOMRange markupString]):
2723
2724         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
2725         * WebView/WebArchiver.mm:
2726
2727 2008-03-28  Brady Eidson  <beidson@apple.com>
2728
2729         Reviewed by Sam Weinig
2730
2731         More Kit->Core webarchive code movement
2732
2733         * DOM/WebDOMOperations.mm:
2734         (-[DOMNode markupString]): Call createFullMarkup() instead
2735
2736         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
2737         * WebView/WebFrameInternal.h: Ditto
2738
2739 2008-03-28  Brady Eidson  <beidson@apple.com>
2740
2741         Reviewed by Sam Weinig
2742
2743         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
2744
2745         * WebView/WebArchiver.h:
2746         * WebView/WebArchiver.mm:
2747         * WebView/WebDataSource.mm:
2748         (-[WebDataSource webArchive]):
2749
2750 2008-03-28  Brady Eidson  <beidson@apple.com>
2751
2752         Reviewed by Sam Weinig
2753
2754         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
2755
2756         * WebView/WebArchiver.h:
2757         * WebView/WebArchiver.mm:
2758
2759 2008-03-28  Brady Eidson  <beidson@apple.com>
2760
2761         Reviewed by Darin
2762
2763         "Yet another transitional step" to empty out WebKit-based code for archiving.
2764
2765         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2766         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2767
2768         * DOM/WebDOMOperations.mm:
2769         * WebView/WebArchiver.mm:
2770         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2771
2772 2008-03-27  Brady Eidson  <beidson@apple.com>
2773
2774         Reviewed by Adam Roben
2775
2776         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
2777         as the push to core-ify WebArchives continues.
2778
2779         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
2780         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
2781         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
2782         (as in "while archiving a page") are accepting of null or empty data.
2783
2784         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
2785
2786         * WebView/WebDataSource.mm:
2787         (-[WebDataSource mainResource]): Call DocumentLoader implementation
2788         (-[WebDataSource subresources]): Ditto
2789         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
2790         * WebView/WebFrameInternal.h:
2791
2792 2008-03-27  Brady Eidson  <beidson@apple.com>
2793
2794         Reviewed by Adam
2795
2796         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
2797         (more efficient)
2798
2799         * WebView/WebResource.mm:
2800         (-[WebResource _initWithCoreResource:]):
2801         * WebView/WebResourceInternal.h:
2802
2803 2008-03-26  Brady Eidson  <beidson@apple.com>
2804
2805         Build fix - accidentally checked in this change which was work in progress
2806
2807         * DOM/WebDOMOperations.mm:
2808
2809 2008-03-26  Brady Eidson  <beidson@apple.com>
2810
2811         Reviewed by Darin
2812
2813         When we create a WebArchive, we walk every node from some starting point, asking each node
2814         along the way "What are your subresource URLs?"
2815
2816         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
2817         WebCore::Node
2818
2819         * DOM/WebDOMOperations.mm:
2820         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
2821           calling into individual WebCore::Node implementations
2822         * DOM/WebDOMOperationsPrivate.h:
2823
2824 2008-03-26  Brady Eidson  <beidson@apple.com>
2825
2826         Reviewed by Mark Rowe
2827
2828         Part of the continued push to move WebArchive-related code down to WebCore, this
2829         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
2830
2831         * WebView/WebDataSource.mm:
2832         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
2833
2834         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
2835           has now been ported down to WebCore
2836         * WebView/WebFrameInternal.h:
2837
2838 2008-03-26  Mark Rowe  <mrowe@apple.com>
2839
2840         Rubber-stamped by Brady Eidson.
2841
2842         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
2843
2844         * Configurations/WebKit.xcconfig:
2845
2846 2008-03-26  Mark Rowe  <mrowe@apple.com>
2847
2848         Reviewed by David Hyatt.
2849
2850         Make the Ahem font antialias correctly on Acid3 on Tiger.
2851
2852         * WebCoreSupport/WebSystemInterface.m:
2853         (InitWebCoreSystemInterface):
2854
2855 2008-03-26  Mark Rowe  <mrowe@apple.com>
2856
2857         Fix the Mac build.
2858
2859         * MigrateHeaders.make: Copy the newly generated header into the right place.
2860
2861 2008-03-25  Brady Eidson  <beidson@apple.com>
2862
2863         Reviewed by Beth Dakin
2864
2865         Remove entirely unused internal method
2866
2867         * WebView/WebArchiver.h:
2868         * WebView/WebArchiver.mm:
2869
2870 2008-03-25  Brady Eidson  <beidson@apple.com>
2871
2872         Reviewed by Adam Roben
2873
2874         <rdar://problem/5819308> - View Source is empty when view webarchives
2875
2876         * WebCore.base.exp:
2877         * loader/DocumentLoader.cpp:
2878         (WebCore::DocumentLoader::setParsedArchiveData):
2879         (WebCore::DocumentLoader::parsedArchiveData):
2880         * loader/DocumentLoader.h:
2881
2882         * loader/FrameLoader.cpp:
2883         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
2884           in the DocumentLoader
2885
2886 2008-03-25  Dan Bernstein  <mitz@apple.com>
2887
2888         Reviewed by Darin Adler.
2889
2890         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
2891           Reopen All Windows From Last Session causes crash
2892
2893         * WebView/WebHTMLView.mm:
2894         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
2895         check.
2896
2897 2008-03-25  Brady Eidson  <beidson@apple.com>
2898
2899         Reviewed by Jon Honeycutt's rubberstamp
2900
2901         Fix a leak with the new WebArchive setup
2902
2903         * WebView/WebArchive.mm:
2904         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2905
2906 2008-03-25  Brady Eidson  <beidson@apple.com>
2907
2908         Reviewed by Darin
2909
2910         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
2911         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
2912
2913         * WebCoreSupport/WebFrameLoaderClient.h:
2914         * WebCoreSupport/WebFrameLoaderClient.mm:
2915         (WebFrameLoaderClient::WebFrameLoaderClient):
2916
2917 2008-03-25  Brady Eidson  <beidson@apple.com>
2918
2919         Reviewed by Darin
2920
2921         Remove newly obsolete FrameLoaderClient methods
2922
2923         * WebCoreSupport/WebFrameLoaderClient.h:
2924         * WebCoreSupport/WebFrameLoaderClient.mm:
2925
2926 2008-03-25  Brady Eidson  <beidson@apple.com>
2927
2928         Release build fix
2929
2930         * WebView/WebArchive.mm:
2931         (-[WebArchive subresources]):
2932         (-[WebArchive subframeArchives]):
2933
2934 2008-03-25  Brady Eidson  <beidson@apple.com>
2935
2936         Reviewed by Darin
2937
2938         <rdar://problem/4516169> - Support WebArchives on Windows
2939         And paves the way for many future WebArchive bug fixes and enhancements
2940
2941         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
2942         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
2943          * WebArchive <-> LegacyWebArchive
2944          * WebResource <-> ArchiveResource
2945          * WebUnarchivingState <-> ArchiveResourceCollection
2946  
2947         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
2948         and now exist in WebCore
2949
2950         * WebCoreSupport/WebFrameLoaderClient.mm:
2951         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
2952         (WebFrameLoaderClient::finalSetupForReplace):
2953         (WebFrameLoaderClient::setDefersLoading):
2954         (WebFrameLoaderClient::willUseArchive):
2955         (WebFrameLoaderClient::isArchiveLoadPending):
2956         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2957         (WebFrameLoaderClient::clearArchivedResources):
2958         (WebFrameLoaderClient::createFrame):
2959
2960         * WebView/WebArchive.mm:
2961         (+[WebArchivePrivate initialize]):
2962         (-[WebArchivePrivate init]):
2963         (-[WebArchivePrivate initWithCoreArchive:]):
2964         (-[WebArchivePrivate coreArchive]):
2965         (-[WebArchivePrivate setCoreArchive:]):
2966         (-[WebArchivePrivate dealloc]):
2967         (-[WebArchivePrivate finalize]):
2968         (-[WebArchive init]):
2969         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2970         (-[WebArchive initWithData:]):
2971         (-[WebArchive initWithCoder:]):
2972         (-[WebArchive encodeWithCoder:]):
2973         (-[WebArchive mainResource]):
2974         (-[WebArchive subresources]):
2975         (-[WebArchive subframeArchives]):
2976         (-[WebArchive data]):
2977         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
2978         (-[WebArchive WebCore::]):
2979         * WebView/WebArchiveInternal.h: Added.
2980
2981         * WebView/WebDataSource.mm:
2982         (-[WebDataSourcePrivate dealloc]):
2983         (-[WebDataSource _addSubframeArchives:]):
2984         (-[WebDataSource _documentFragmentWithArchive:]):
2985         (-[WebDataSource subresourceForURL:]):
2986         (-[WebDataSource addSubresource:]):
2987         * WebView/WebDataSourceInternal.h:
2988
2989         * WebView/WebFrame.mm:
2990         (-[WebFrame loadArchive:]):
2991         * WebView/WebFrameInternal.h:
2992
2993         * WebView/WebHTMLRepresentation.mm:
2994         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2995
2996         * WebView/WebResource.mm:
2997         (+[WebResourcePrivate initialize]):
2998         (-[WebResourcePrivate init]):
2999         (-[WebResourcePrivate initWithCoreResource:]):
3000         (-[WebResourcePrivate dealloc]):
3001         (-[WebResourcePrivate finalize]):
3002         (-[WebResource initWithCoder:]):
3003         (-[WebResource encodeWithCoder:]):
3004         (-[WebResource data]):
3005         (-[WebResource URL]):
3006         (-[WebResource MIMEType]):
3007         (-[WebResource textEncodingName]):
3008         (-[WebResource frameName]):
3009         (-[WebResource _initWithCoreResource:WebCore::]):
3010         (-[WebResource WebCore::]):
3011         (-[WebResource _ignoreWhenUnarchiving]):
3012         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3013         (-[WebResource _fileWrapperRepresentation]):
3014         (-[WebResource _response]):
3015         (-[WebResource _stringValue]):
3016         * WebView/WebResourceInternal.h: Added.
3017         * WebView/WebResourcePrivate.h:
3018
3019         * WebView/WebUnarchivingState.h: Removed.
3020         * WebView/WebUnarchivingState.m: Removed.
3021
3022 2008-03-24  Oliver Hunt  <oliver@apple.com>
3023
3024         Reviewed by Mark Rowe.
3025
3026         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
3027         <http://bugs.webkit.org/show_bug.cgi?id=18030>
3028
3029         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
3030         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
3031         <http://bugs.webkit.org/show_bug.cgi?id=18057>
3032
3033         * WebView/WebHTMLView.mm:
3034         (-[WebHTMLView keyDown:]):
3035
3036 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3037
3038         Reviewed by Maciej, landed by Brady
3039
3040         Bug 3580: iFrames Appear to be Cached
3041         <http://bugs.webkit.org/show_bug.cgi?id=3580>
3042
3043         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
3044         <http://bugs.webkit.org/show_bug.cgi?id=15486>
3045
3046         Bug 15554: Reload causes <object> to use old data
3047         <http://bugs.webkit.org/show_bug.cgi?id=15554>
3048
3049         If a page is reloaded, a child frame's URL can not be taken from a history item.
3050
3051         * WebView/WebFrame.mm:
3052         (-[WebFrame _loadURL:referrer:intoChild:]):
3053
3054 2008-03-24  Darin Adler  <darin@apple.com>
3055
3056         Reviewed by Beth.
3057
3058         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
3059
3060         * History/WebHistoryItem.mm:
3061         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
3062         * WebView/WebDataSource.mm:
3063         (-[WebDataSource _URL]): Ditto.
3064         (-[WebDataSource unreachableURL]): Ditto.
3065         * WebView/WebHTMLView.mm:
3066         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3067
3068         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3069         * History/WebHistory.mm:
3070         * Misc/WebElementDictionary.mm:
3071         * Misc/WebNSAttributedStringExtras.mm:
3072         Remove unneeded imports of KURL.h.
3073
3074 2008-03-24  Brady Eidson  <beidson@apple.com>
3075
3076         Reviewed by Darin's rubberstamp
3077
3078         Rename this file for upcoming work.
3079
3080         * WebView/WebArchive.m: Removed.
3081         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
3082
3083 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
3084
3085         Build fix.
3086
3087         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
3088
3089 2008-03-23  Oliver Hunt  <oliver@apple.com>
3090
3091         Reviewed by Maciej.
3092
3093         Bug 17670: Key events may improperly propagate from iframe to parent frame
3094         <http://bugs.webkit.org/show_bug.cgi?id=17670>
3095         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
3096         <http://bugs.webkit.org/show_bug.cgi?id=16381>
3097
3098         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
3099         as that results in us dispatching the key events for each frame going up the frame
3100         tree.
3101
3102         * WebView/WebHTMLView.mm:
3103         (-[WebHTMLView keyDown:]):
3104         (-[WebHTMLView keyUp:]):
3105         (-[WebHTMLView flagsChanged:]):
3106
3107 2008-03-21  Timothy Hatcher  <timothy@apple.com>
3108
3109         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
3110         http://bugs.webkit.org/show_bug.cgi?id=17980
3111
3112         Reviewed by Adam.
3113
3114         The new highlight drawing was not honoring the fade value, so it was
3115         always drawing at full opacity. The animation code didn't match Windows
3116         and the new highlight anyway, so it has been removed. The highlight
3117         how just detaches when it is hidden.
3118
3119         * WebCoreSupport/WebInspectorClient.mm:
3120         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
3121         (-[WebInspectorWindowController close]): Ditto.
3122         (-[WebInspectorWindowController highlightNode:]): Call attach.
3123         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
3124         * WebInspector/WebNodeHighlight.h:
3125         * WebInspector/WebNodeHighlight.m:
3126         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3127         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
3128         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
3129         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
3130         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
3131         * WebInspector/WebNodeHighlightView.h:
3132         * WebInspector/WebNodeHighlightView.m:
3133         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
3134
3135 2008-03-20  Mark Rowe  <mrowe@apple.com>
3136
3137         Reviewed by Sam Weinig.
3138
3139         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
3140         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
3141         command-line.
3142
3143         * Configurations/WebKit.xcconfig:
3144
3145 2008-03-20  Adam Roben  <aroben@apple.com>
3146
3147         Make WebNodeHighlightView use InspectorController to do its painting
3148
3149         Reviewed by Tim Hatcher.
3150
3151         * WebCoreSupport/WebInspectorClient.mm:
3152         (-[WebInspectorWindowController highlightNode:]): Pass the
3153         InspectorController to the WebNodeHighlight, and don't call
3154         setHighlightedNode: (which has been removed).
3155         (-[WebInspectorWindowController hideHighlight]): Removed call to
3156         setHighlightedNode:.
3157         * WebInspector/WebNodeHighlight.h:
3158           - Replaced _highlightNode with _inspectorController
3159           - Removed _highlightedNode accessors
3160           - Added -inspectorController method
3161         * WebInspector/WebNodeHighlight.m:
3162         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
3163         takes an InspectorController* and stores it in _inspectorController.
3164         (-[WebNodeHighlight dealloc]): Removed code dealing with
3165         _highlightedNode.
3166         (-[WebNodeHighlight inspectorController]): Added.
3167         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
3168         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
3169         GraphicsContexts to be based on a flipped CGContext, so we have to
3170         specify that this view is flipped.
3171         (-[WebNodeHighlightView drawRect:]): Changed to create a
3172         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
3173
3174 2008-03-18  David Hyatt  <hyatt@apple.com>
3175
3176         Add support for a preference in WebKit that can be used in nightly builds to test full page
3177         zoom.
3178
3179         Reviewed by Antti
3180
3181         * WebView/WebPreferenceKeysPrivate.h:
3182         * WebView/WebView.mm:
3183         (-[WebView setTextSizeMultiplier:]):
3184         (-[WebView canMakeTextSmaller]):
3185         (-[WebView makeTextSmaller:]):
3186         (-[WebView canMakeTextLarger]):
3187         (-[WebView makeTextLarger:]):
3188         (-[WebView canMakeTextStandardSize]):
3189         (-[WebView makeTextStandardSize:]):
3190
3191 2008-03-17  Eric Seidel  <eric@webkit.org>
3192
3193         Reviewed by darin.
3194
3195         Export _NPN_IntFromIdentifier as part of our NPAPI interface
3196
3197         * Plugins/WebNetscapePluginPackage.m:
3198         (-[WebNetscapePluginPackage load]):
3199
3200 2008-03-14  Brady Eidson  <beidson@apple.com>
3201
3202         Reviewed by Brian Dash's rubberstamp
3203
3204         Remove a class declaration for a class that has never existed
3205
3206         * WebView/WebResource.h:
3207
3208 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
3209
3210         Unify concept of enabling the Mac Java bridge.
3211
3212         Reviewed by Darin and Anders.
3213
3214         * Plugins/WebPluginJava.h: Removed unused file.
3215         * WebCoreSupport/WebFrameLoaderClient.h:
3216         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
3217         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
3218         (WebFrameLoaderClient::javaApplet): Ditto.
3219
3220 2008-03-13  Antti Koivisto  <antti@apple.com>
3221
3222         Reviewed by Darin.
3223
3224         * ForwardingHeaders/wtf/Deque.h: Added.
3225
3226 2008-03-13  Anders Carlsson  <andersca@apple.com>
3227
3228         Reviewed by Adam.
3229
3230         Call originalRequest, not initialRequest.
3231         
3232         * WebView/WebDataSource.mm:
3233         (-[WebDataSource initialRequest]):
3234
3235 2008-03-12  Darin Adler  <darin@apple.com>
3236
3237         Reviewed by John Sullivan.
3238
3239         - cleanup after removing the bridge
3240
3241         * DOM/WebDOMOperations.mm:
3242         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
3243
3244         * Misc/WebCoreStatistics.mm:
3245         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
3246
3247         * Plugins/WebBaseNetscapePluginView.mm:
3248         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
3249         _frameLoader method.
3250         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3251         Ditto.
3252         * Plugins/WebPluginController.mm:
3253         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
3254
3255         * WebCoreSupport/WebFrameLoaderClient.mm:
3256         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
3257         method. Without this we could leave a stale frame pointer around.
3258         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
3259         caller of the _isMainFrame method.
3260         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
3261         _frameLoader method.
3262         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
3263
3264         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
3265         turned out to be unused.
3266         (core): Added overload for DocumentFragment.
3267         (kit): Ditto.
3268         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
3269         to FrameLoader with _private->coreFrame->loader().
3270         (-[WebFrame _attachScriptDebugger]): Ditto.
3271         (-[WebFrame _clearCoreFrame]): Added.
3272         (-[WebFrame _updateBackground]): More of the same.
3273         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
3274         (-[WebFrame _unmarkAllMisspellings]): Ditto.
3275         (-[WebFrame _hasSelection]): Ditto.
3276         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
3277         (-[WebFrame _findFrameWithSelection]): Ditto.
3278         (-[WebFrame _dataSource]): Ditto.
3279         (-[WebFrame _addData:]): Streamlined code a bit.
3280         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3281         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3282         (-[WebFrame _isDescendantOfFrame:]): Ditto.
3283         (-[WebFrame _bodyBackgroundColor]): Ditto.
3284         (-[WebFrame _isFrameSet]): Ditto.
3285         (-[WebFrame _firstLayoutDone]): Ditto.
3286         (-[WebFrame _loadType]): Ditto.
3287         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
3288         (-[WebFrame name]): Ditto.
3289         (-[WebFrame DOMDocument]): Ditto.
3290         (-[WebFrame frameElement]): Ditto.
3291         (-[WebFrame provisionalDataSource]): Ditto.
3292         (-[WebFrame dataSource]): Ditto.
3293         (-[WebFrame loadRequest:]): Ditto.
3294         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
3295         (-[WebFrame loadArchive:]): Ditto.
3296         (-[WebFrame stopLoading]): Ditto.
3297         (-[WebFrame reload]): Ditto.
3298         (-[WebFrame findFrameNamed:]): Ditto.
3299         (-[WebFrame parentFrame]): Ditto.
3300         (-[WebFrame childFrames]): Ditto.
3301         (-[WebFrame windowObject]): Ditto.
3302         (-[WebFrame globalContext]): Ditto.
3303
3304         * WebView/WebFrameInternal.h: Added overloads of core and kit.
3305         Removed method declarations.
3306
3307         * WebView/WebHTMLRepresentation.mm:
3308         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
3309         (formElementFromDOMElement): Ditto.
3310         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3311         (inputElementFromDOMElement): Ditto.
3312         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3313         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3314         (-[WebHTMLRepresentation formForElement:]): Ditto.
3315         (-[WebHTMLRepresentation currentForm]): Ditto.
3316         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3317         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3318         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3319
3320         * WebView/WebHTMLView.mm:
3321         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
3322         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3323         Call createFragmentFromText directly instead of via WebFrame.
3324         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3325         Moved layout calls here from WebFrame.
3326         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3327         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
3328         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
3329         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
3330         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
3331         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3332         Moved code here from WebFrame.
3333         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
3334         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3335         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3336         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3337         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3338         (-[WebHTMLView rectsForTextMatches]): Ditto.
3339
3340         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
3341
3342         * WebView/WebPDFView.mm:
3343         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
3344         _frameLoader method.
3345
3346         * WebView/WebRenderNode.mm:
3347         (copyRenderNode): Moved code here from WebFrame.
3348         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3349
3350         * WebView/WebResource.mm:
3351         (-[WebResource _stringValue]): Moved code here from WebFrame.
3352
3353         * WebView/WebView.mm:
3354         (-[WebView _close]): Use core function intsead of _frameLoader method.
3355         (-[WebView setCustomTextEncodingName:]): Ditto.
3356         (-[WebView setHostWindow:]): Moved code here from WebFrame.
3357         (aeDescFromJSValue): Moved this here from WebFrame.
3358         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
3359
3360 2008-03-12  Darin Adler  <darin@apple.com>
3361
3362         Reviewed by Anders.
3363
3364         - http://bugs.webkit.org/show_bug.cgi?id=17640
3365           eliminate WebCoreFrameBridge
3366
3367         Moved all the code from the bridge into WebFrame. This need not be the final
3368         home of these methods -- they can be moved closer to their callers and improved
3369         further -- but it eliminates the bridge without requiring a rewrite of the code.
3370         It's a fairly mechanical process (just adding underscores to method names really).
3371
3372         There's even a chance that some of the methods are unused. Those we can remove
3373         after checking if that's so.
3374
3375         * DOM/WebDOMOperations.mm:
3376         (-[DOMNode markupString]): Use WebFrame rather than bridge.
3377         (-[DOMDocument webFrame]): Changed to use the core and kit functions
3378         instead of using the bridge.
3379         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
3380         (-[DOMRange markupString]): Ditto.
3381         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3382
3383         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3384         * History/WebHistoryItem.mm: Ditto.
3385
3386         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3387         * Misc/WebCoreStatistics.mm:
3388         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3389
3390         * Misc/WebElementDictionary.mm: Removed unneeded import.
3391
3392         * Misc/WebKitStatistics.m:
3393         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3394         * Misc/WebKitStatisticsPrivate.h: Ditto.
3395
3396         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3397         * Misc/WebNSPasteboardExtras.mm: Ditto.
3398
3399         * Plugins/WebBaseNetscapePluginView.mm:
3400         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3401         rather than bridge.
3402
3403         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3404         * Plugins/WebNetscapePluginStream.mm: Ditto.
3405
3406         * Plugins/WebPluginContainerCheck.mm:
3407         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3408         bridge to get to the WebCore::Frame.
3409
3410         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3411         * Plugins/WebPluginController.mm:
3412         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3413         rather than bridge.
3414
3415         * WebCoreSupport/WebEditorClient.mm:
3416         (selectorForKeyEvent): Tweaked comment.
3417
3418         * WebCoreSupport/WebFrameBridge.h: Removed.
3419         * WebCoreSupport/WebFrameBridge.mm: Removed.
3420
3421         * WebCoreSupport/WebFrameLoaderClient.mm:
3422         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3423         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3424         I could remove this function entirely, but it looks like the Qt port is using it.
3425
3426         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3427
3428         * WebView/WebArchiver.mm:
3429         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3430         (+[WebArchiver archiveNode:]): Ditto.
3431         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3432
3433         * WebView/WebDataSource.mm:
3434         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3435         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3436         (-[WebDataSource subresources]): Ditto.
3437         (-[WebDataSource subresourceForURL:]): Ditto.
3438
3439         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3440
3441         * WebView/WebFrame.mm:
3442         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3443         (core): Go directly to the core frame, not via the bridge.
3444         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3445         Remove the code to deal with the bridge.
3446         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3447         shouldCreateRenderers flag, formerly on the bridge.
3448         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3449         (aeDescFromJSValue): Moved here from bridge.
3450         (-[WebFrame _domain]): Ditto.
3451         (-[WebFrame _addData:]): Ditto.
3452         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3453         (-[WebFrame _nodesFromList:]): Ditto.
3454         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3455         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3456         (-[WebFrame _selectedString]): Ditto.
3457         (-[WebFrame _stringForRange:]): Ditto.
3458         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3459         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3460         (-[WebFrame _sendScrollEvent]): Ditto.
3461         (-[WebFrame _drawRect:]): Ditto.
3462         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3463         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3464         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3465         (-[WebFrame _copyRenderTree:]): Ditto.
3466         (inputElementFromDOMElement): Ditto.
3467         (formElementFromDOMElement): Ditto.
3468         (-[WebFrame _elementWithName:inForm:]): Ditto.
3469         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3470         (-[WebFrame _elementIsPassword:]): Ditto.
3471         (-[WebFrame _formForElement:]): Ditto.
3472         (-[WebFrame _currentForm]): Ditto.
3473         (-[WebFrame _controlsInForm:]): Ditto.
3474         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3475         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3476         (-[WebFrame _URLWithAttributeString:]): Ditto.
3477         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3478         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3479         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3480         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3481         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3482         (-[WebFrame _rectsForTextMatches]): Ditto.
3483         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3484         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3485         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3486         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3487         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3488         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3489         (-[WebFrame _baseURL]): Ditto.
3490         (-[WebFrame _stringWithData:]): Ditto.
3491         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3492         (-[WebFrame _needsLayout]): Ditto.
3493         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3494         (-[WebFrame _accessibilityTree]): Ditto.
3495         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3496         (-[WebFrame _setDrawsBackground:]): Ditto.
3497         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3498         Ditto.
3499         (-[WebFrame _selectionGranularity]): Ditto.
3500         (-[WebFrame _convertToNSRange:]): Ditto.
3501         (-[WebFrame _convertToDOMRange:]): Ditto.
3502         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3503         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3504         (-[WebFrame _markDOMRange]): Ditto.
3505         (-[WebFrame _markedTextNSRange]): Ditto.
3506         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3507         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3508         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3509         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3510         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3511         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3512         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3513         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3514         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3515         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3516         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3517         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3518         (-[WebFrame _typingStyle]): Ditto.
3519         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3520         (-[WebFrame _fontForSelection:]): Ditto.
3521         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3522         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3523         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3524         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3525         (-[WebFrame _canProvideDocumentSource]): Ditto.
3526         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3527         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3528         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3529         function. Couldn't just keep the bridge method because this was already here with the same name.
3530         (-[WebFrame _selectedNSRange]): Ditto.
3531         (-[WebFrame _selectNSRange:]): Ditto.
3532         (-[WebFrame dealloc]): Remove bridge-related code.
3533         (-[WebFrame finalize]): Ditto.
3534
3535         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3536         Removed the bridge parameter from the init method. Removed the #if blocks that
3537         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3538         Removed the _bridge method.
3539
3540         * WebView/WebFrameView.mm: Removed the _bridge method.
3541
3542         * WebView/WebHTMLRepresentation.mm:
3543         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3544         field.
3545         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3546         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3547         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3548         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3549         (-[WebHTMLRepresentation documentSource]): Ditto.
3550         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3551         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3552         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3553         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3554         (-[WebHTMLRepresentation formForElement:]): Ditto.
3555         (-[WebHTMLRepresentation currentForm]): Ditto.
3556         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3557         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3558         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3559
3560         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3561
3562         * WebView/WebHTMLView.mm:
3563         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3564         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3565         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3566         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3567         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3568         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3569         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3570         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3571         (-[WebHTMLView drawSingleRect:]): Ditto.
3572         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3573         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3574         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3575         (-[WebHTMLView knowsPageRange:]): Ditto.
3576         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3577         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3578         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3579         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3580         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3581         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3582         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3583         (-[WebHTMLView startSpeaking:]): Ditto.
3584         (-[WebHTMLView _updateFontPanel]): Ditto.
3585         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3586         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3587         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3588         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3589         (-[WebHTMLView selectedRange]): Ditto.
3590         (-[WebHTMLView markedRange]): Ditto.
3591         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3592         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3593         (-[WebHTMLView insertText:]): Ditto.
3594         (-[WebTextCompleteController _insertMatch:]): Ditto.
3595         (-[WebTextCompleteController doCompletion]): Ditto.
3596         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3597         (-[WebHTMLView string]): Ditto.
3598         (-[WebHTMLView selectedString]): Ditto.
3599         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3600         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3601         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3602         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3603         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3604         (-[WebHTMLView rectsForTextMatches]): Ditto.
3605         * WebView/WebRenderNode.mm:
3606         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3607         * WebView/WebResource.mm:
3608         (-[WebResource _stringValue]): Ditto.
3609
3610         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3611
3612         * WebView/WebView.mm:
3613         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3614         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3615         (-[WebView _setInViewSourceMode:]): Ditto.
3616         (-[WebView _inViewSourceMode]): Ditto.
3617         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3618         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3619         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3620         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3621         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
3622         (-[WebView setEditable:]): Ditto.
3623         (-[WebView setTypingStyle:]): Ditto.
3624         (-[WebView typingStyle]): Ditto.
3625         (-[WebView replaceSelectionWithNode:]): Ditto.
3626         (-[WebView replaceSelectionWithText:]): Ditto.
3627         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
3628         (-[WebView replaceSelectionWithArchive:]): Ditto.
3629         (-[WebView _insertNewlineInQuotedContent]): Ditto.
3630         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
3631
3632 2008-03-12  David Hyatt  <hyatt@apple.com>
3633
3634         Make the zoom factor a float and not a percent.
3635
3636         Reviewed by antti
3637
3638         * WebView/WebView.mm:
3639         (-[WebView _setZoomMultiplier:isTextOnly:]):
3640
3641 2008-03-11  David Hyatt  <hyatt@apple.com>
3642
3643         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
3644         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
3645         can zoom the page in, out or reset it to the standard size.
3646
3647         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
3648         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
3649         win.
3650
3651         Reviewed by Tim H.
3652
3653         * WebCoreSupport/WebFrameBridge.mm:
3654         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
3655         * WebView/WebDocumentInternal.h:
3656         * WebView/WebHTMLView.mm:
3657         (-[WebHTMLView viewDidMoveToSuperview]):
3658         * WebView/WebPDFView.h:
3659         * WebView/WebPDFView.mm:
3660         (-[WebPDFView _zoomOut:]):
3661         (-[WebPDFView _zoomIn:]):
3662         (-[WebPDFView _resetZoom:]):
3663         (-[WebPDFView _canZoomOut]):
3664         (-[WebPDFView _canZoomIn]):
3665         (-[WebPDFView _canResetZoom]):
3666         * WebView/WebView.mm:
3667         (-[WebViewPrivate init]):
3668         (-[WebView setTextSizeMultiplier:]):
3669         (-[WebView textSizeMultiplier]):
3670         (-[WebView _setZoomMultiplier:isTextOnly:]):
3671         (-[WebView _zoomMultiplier:]):
3672         (-[WebView _realZoomMultiplier]):
3673         (-[WebView _realZoomMultiplierIsTextOnly]):
3674         (-[WebView _canZoomOut:]):
3675         (-[WebView _canZoomIn:]):
3676         (-[WebView _zoomOut:isTextOnly:]):
3677         (-[WebView _zoomIn:isTextOnly:]):
3678         (-[WebView _canResetZoom:]):
3679         (-[WebView _resetZoom:isTextOnly:]):
3680         (-[WebView canMakeTextSmaller]):
3681         (-[WebView makeTextSmaller:]):
3682         (-[WebView canMakeTextLarger]):
3683         (-[WebView makeTextLarger:]):
3684         (-[WebView canMakeTextStandardSize]):
3685         (-[WebView makeTextStandardSize:]):
3686         (-[WebView setPageSizeMultiplier:]):
3687         (-[WebView pageSizeMultiplier]):
3688         (-[WebView canZoomPageIn]):
3689         (-[WebView zoomPageIn:]):
3690         (-[WebView canZoomPageOut]):
3691         (-[WebView zoomPageOut:]):
3692         (-[WebView canResetPageZoom]):
3693         (-[WebView resetPageZoom:]):
3694         (-[WebView _searchWithSpotlightFromMenu:]):
3695         * WebView/WebViewInternal.h:
3696         * WebView/WebViewPrivate.h:
3697
3698 2008-03-12  Dan Bernstein  <mitz@apple.com>
3699
3700         Reviewed by Darin Adler and Sam Weinig.
3701
3702         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
3703
3704         * WebCoreSupport/WebSystemInterface.m:
3705         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
3706         WKGetNSFontATSUFontId Tiger-only.
3707
3708 2008-03-12  Darin Adler  <darin@apple.com>
3709
3710         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
3711           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
3712
3713         * WebView/WebFrame.mm:
3714         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
3715         up pointer from the bridge to the frame. (My next check-in removes the bridge
3716         entirely, but we need this until then.)
3717
3718 2008-03-11  Darin Adler  <darin@apple.com>
3719
3720         Reviewed by Sam.
3721
3722         - remove all bridge-related things from WebCore except the bridge itself
3723
3724         * DOM/WebDOMOperations.mm:
3725         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
3726
3727         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
3728
3729         * Plugins/WebPluginController.mm: Ditto.
3730
3731         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
3732         init and close methods. Added a setWebFrame: method.
3733
3734         * WebCoreSupport/WebFrameBridge.mm:
3735         (-[WebFrameBridge setWebFrame:]): Added.
3736
3737         * WebCoreSupport/WebFrameLoaderClient.mm:
3738         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
3739         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
3740         bridge here. Soon we will be able to remove this entirely!
3741         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
3742         into WebFrame from the bridge.
3743
3744         * WebView/WebFrame.mm:
3745         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
3746         now owned by the frame.
3747         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
3748         debugger under GC without this!
3749         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
3750         use WebFrameLoaderClient instead of the bridge.
3751         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
3752         This is code that used to live in the bridge's init function.
3753         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
3754         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
3755         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
3756         the WebView is now the bridge's owner.
3757         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
3758         WebCore::Frame::bridge function directly to use the kit function instead.
3759         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
3760         This code won't last long -- we're eliminating the bridge soon.
3761         (-[WebFrame finalize]): Ditto.
3762
3763         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
3764         for creating frames.
3765
3766         * WebView/WebView.mm:
3767         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
3768         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
3769         where we have to allocate a WebFrameBridge and then immediately release it.
3770
3771 2008-03-11  Darin Adler  <darin@apple.com>
3772
3773         Reviewed by Anders.
3774
3775         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
3776
3777         * WebCoreSupport/WebFrameLoaderClient.mm:
3778         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
3779         to setView. A couple lines later, there is a call to _install, which sets the
3780         view to the scroll view.
3781
3782         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
3783
3784         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
3785         this file, since it's used by Safari.
3786         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
3787         * WebView/WebDynamicScrollBarsView.m:
3788         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
3789         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
3790         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
3791         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
3792         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
3793         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
3794         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
3795         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
3796         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
3797         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
3798         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
3799         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
3800         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
3801         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
3802         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
3803
3804         * WebView/WebFrameView.mm:
3805         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
3806
3807         * WebView/WebView.mm:
3808         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
3809         (-[WebView alwaysShowVerticalScroller]): Ditto.
3810         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
3811         (-[WebView alwaysShowHorizontalScroller]): Ditto.
3812
3813 2008-03-11  Darin Adler  <darin@apple.com>
3814
3815         Reviewed by Sam.
3816
3817         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
3818
3819         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
3820         bridge methods.
3821         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
3822         to recently-created functions.
3823         (WebChromeClient::firstResponder): Moved code here from the bridge.
3824         (WebChromeClient::makeFirstResponder): Ditto.
3825         (WebChromeClient::runOpenPanel): Ditto.
3826         (WebChromeClient::willPopUpMenu): Ditto.
3827
3828         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
3829         is related to creating the bridge and connecting it to WebCore, which will
3830         go next when I eliminate use of the bridge to get to/from the Frame*.
3831         * WebCoreSupport/WebFrameBridge.mm:
3832         (-[WebFrameBridge close]): Moved the code to track the bridge count here
3833         instead of the dealloc and finalize methods.
3834
3835 2008-03-11  Darin Adler  <darin@apple.com>
3836
3837         Reviewed by Mitz.
3838
3839         - update code affected by Range changes
3840
3841         * Misc/WebNSAttributedStringExtras.mm:
3842         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
3843         * WebView/WebHTMLRepresentation.mm:
3844         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3845         Use Range::create.
3846         * WebView/WebHTMLView.mm:
3847         (-[WebHTMLView attributedString]): Ditto.
3848
3849 2008-03-10  Darin Adler  <darin@apple.com>
3850
3851         Reviewed by Sam.
3852
3853         - eliminate keyboard UI mode method from WebCoreFrameBridge
3854
3855         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
3856         * WebCoreSupport/WebChromeClient.mm:
3857         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
3858         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
3859         fields for keyboard UI mode.
3860         * WebCoreSupport/WebFrameBridge.mm:
3861         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
3862         method.
3863         (-[WebFrameBridge finalize]): Ditto.
3864         * WebView/WebView.mm: Moved the keyboard mode code in here.
3865         (-[WebView _close]): Remove observer from the distributed notification
3866         center as well as the normal one.
3867         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
3868         here from the bridge.
3869         (-[WebView _keyboardUIMode]): Ditto.
3870         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
3871
3872 2008-03-10  Darin Adler  <darin@apple.com>
3873
3874         Reviewed by Sam.
3875
3876         - eliminate Java applet methods from WebCoreFrameBridge
3877
3878         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
3879         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
3880         the ones that load Java applets.
3881         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
3882         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3883
3884 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
3885
3886         Reviewed by Darin.
3887
3888         Done with Lars.
3889
3890         Simplified WebViewFactory's refreshPlugins method to only refresh the
3891         plugins and not reload the frames anymore since that's now done in a
3892         platform independent manner by WebCore::Page.
3893
3894         Also removed the now unused pluginNameForMIMEType and
3895         pluginSupportsMIMEType methods.
3896
3897         * WebCoreSupport/WebViewFactory.mm:
3898         * WebView/WebFrame.mm:
3899         * WebView/WebFrameInternal.h:
3900         * WebView/WebView.mm:
3901
3902 2008-03-08  Mark Rowe  <mrowe@apple.com>
3903
3904         Reviewed by Darin Adler.
3905
3906         Fix 64-bit build with GCC 4.2.
3907
3908         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
3909         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
3910         * History/WebHistoryItem.mm: Ditto.
3911         * Misc/WebElementDictionary.mm: Ditto.
3912         * WebCoreSupport/WebFrameLoaderClient.mm:
3913         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
3914         variable being unused in 64-bit.
3915         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
3916         * WebView/WebHTMLView.mm:
3917         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
3918         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
3919
3920 2008-03-08  Darin Adler  <darin@apple.com>
3921
3922         Reviewed by Adele.
3923
3924         - eliminate custom highlight methods from WebCoreFrameBridge
3925
3926         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
3927         * WebCoreSupport/WebChromeClient.mm:
3928         (WebChromeClient::customHighlightRect): Moved code here from bridge.
3929         (WebChromeClient::paintCustomHighlight): Ditto.
3930         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
3931
3932 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
3933
3934         Unify concept of enabling Netscape Plug-in API (NPAPI).
3935
3936         Reviewed by Darin.
3937
3938         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
3939
3940         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
3941         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
3942
3943         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
3944         #if ENABLE(NETSCAPE_PLUGIN_API).
3945         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
3946         * Plugins/WebBaseNetscapePluginView.h: Ditto.
3947         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
3948         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
3949         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
3950         * Plugins/WebBasePluginPackage.h: Ditto.
3951         * Plugins/WebBasePluginPackage.m: Ditto.
3952         (+[WebBasePluginPackage pluginWithPath:]):
3953         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
3954         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3955         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
3956         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
3957         * Plugins/WebNetscapePluginPackage.h: Ditto.
3958         * Plugins/WebNetscapePluginPackage.m: Ditto.
3959         * Plugins/WebNetscapePluginStream.h: Ditto.
3960         * Plugins/WebNetscapePluginStream.mm: Ditto.
3961         * Plugins/WebPluginDatabase.m: Ditto.
3962         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
3963         * Plugins/npapi.m: Ditto.
3964         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3965         (WebFrameLoaderClient::objectContentType):
3966         (WebFrameLoaderClient::createPlugin):
3967         * WebView/WebHTMLView.mm: Ditto.
3968         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3969         * WebView/WebHTMLViewInternal.h: Ditto.
3970
3971         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
3972         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
3973         category to (WebInternal) category so we don't expose the ENABLE() macro
3974         from the private header.
3975         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
3976         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
3977         * WebView/WebFrameInternal.h: Ditto.
3978         * WebView/WebFramePrivate.h: Ditto.
3979
3980 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
3981
3982         Reviewed by Darin.
3983
3984         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
3985         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
3986
3987         * WebView/WebPreferences.m:
3988         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
3989         the one used in Safari.
3990
3991 2008-03-07  Mark Rowe  <mrowe@apple.com>
3992
3993         Reviewed by Oliver Hunt.
3994
3995         Fix WebKit build with GCC 4.2.
3996
3997         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
3998
3999 2008-03-07  Darin Adler  <darin@apple.com>
4000
4001         Reviewed by Adam.
4002
4003         - eliminated WebCoreFrameBridge runOpenPanel
4004
4005         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
4006         * WebCoreSupport/WebChromeClient.mm:
4007         (WebChromeClient::runOpenPanel): Added.
4008         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
4009         FileChooser so it can get a result from the UI delegate.
4010         (-[WebOpenPanelResultListener dealloc]): Added.
4011         (-[WebOpenPanelResultListener finalize]): Added.
4012         (-[WebOpenPanelResultListener cancel]): Added.
4013         (-[WebOpenPanelResultListener chooseFilename:]): Added.
4014
4015 2008-03-06  Darin Adler  <darin@apple.com>
4016
4017         Reviewed by Mitz.
4018
4019         - fix regression test failures from the visited-link change
4020
4021         * History/WebHistory.mm:
4022         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
4023         to turn off visited links if there is no history object. Also call
4024         removeAllVisitedLinks so we can start over from scratch with the new history.
4025
4026 2008-03-06  Dan Bernstein  <mitz@apple.com>
4027
4028         Reviewed by Darin Adler.
4029
4030         - fix a regression from r30741: a crash under
4031           WebFrameLoaderClient::createPlugin() when showing a Mail message with
4032           an attachment
4033
4034         * WebCoreSupport/WebFrameLoaderClient.mm:
4035         (WebFrameLoaderClient::createPlugin):
4036
4037 2008-03-06  Darin Adler  <darin@apple.com>
4038
4039         - fix Tiger build
4040
4041         * History/WebHistory.mm: Added include of WebTypesInternal.h.
4042
4043 2008-03-06  Darin Adler  <darin@apple.com>
4044
4045         - fix Release build
4046
4047         * History/WebHistory.mm:
4048         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
4049         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
4050         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
4051
4052 2008-03-06  Darin Adler  <darin@apple.com>
4053
4054         Reviewed by Mitz.
4055
4056         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
4057           REGRESSION: iframes are added to Safari's History menu
4058           by separating the visited link machinery from global history
4059
4060         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
4061         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
4062         method name, since it's on a private object.
4063         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
4064         PageGroup::removeAllVisitedLinks function if the last URL was removed.
4065         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
4066         method name, since it's on a private object.
4067         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
4068         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
4069         method name, since it's on a private object.
4070         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
4071         Ditto.
4072         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
4073         to correctly return the error by using the newer version of writeToURL: and
4074         removed the FIXME about that.
4075         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
4076         for every link in the history.
4077         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
4078         (-[WebHistory addItem:]): Moved into the WebPrivate category.
4079         (-[WebHistory addItemForURL:]): Ditto.
4080         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
4081         create an item and already know its title.
4082         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
4083         (-[WebHistory containsItemForURLString:]): Ditto.
4084         (-[WebHistory removeItem:]): Ditto.
4085         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
4086         (-[WebHistory _itemForURLString:]): Ditto.
4087         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
4088
4089         * History/WebHistoryInternal.h: Added.
4090         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
4091         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
4092         Also reorganized what was left behind.
4093
4094         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
4095         * WebCoreSupport/WebChromeClient.mm:
4096         (WebChromeClient::populateVisitedLinks): Added a call to the new
4097         -[WebHistory _addVisitedLinksToPageGroup:] method.
4098
4099         * WebCoreSupport/WebFrameLoaderClient.mm:
4100         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
4101         -[WebHistory _addItemForURL:title:] method.
4102
4103 2008-03-05  Adam Roben  <aroben@apple.com>
4104
4105         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
4106
4107         Reviewed by Kevin M.
4108
4109         * WebView/WebFrame.mm:
4110         * WebView/WebScriptDebugDelegate.mm:
4111         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
4112         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
4113
4114 2008-03-05  Adam Roben  <aroben@apple.com>
4115
4116         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
4117
4118         Reviewed by Kevin M.
4119
4120         * WebView/WebCoreScriptDebuggerImp.h:
4121         * WebView/WebCoreScriptDebuggerImp.mm:
4122         * WebView/WebFrame.mm:
4123         (-[WebFrame _attachScriptDebugger]):
4124         * WebView/WebFrameInternal.h:
4125
4126 2008-03-05  Adam Roben  <aroben@apple.com>
4127
4128         Remove WebScriptDebugger
4129
4130         Uses of WebScriptDebugger have been replaced with
4131         WebCoreScriptDebuggerImp.
4132
4133         Reviewed by Kevin M.
4134
4135         * WebView/WebFrame.mm:
4136         (-[WebFramePrivate dealloc]): Use delete instead of release since
4137         WebCoreScriptDebuggerImp is a C++ class.
4138         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
4139         WebCoreScriptDebuggerImp.
4140         (-[WebFrame _detachScriptDebugger]): Ditto.
4141         * WebView/WebFrameInternal.h:
4142         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
4143         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
4144         * WebView/WebView.mm:
4145
4146 2008-03-05  Adam Roben  <aroben@apple.com>
4147
4148         Remove -webFrame and -globalObject from WebScriptDebugger
4149
4150         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
4151
4152         Reviewed by Kevin M.
4153
4154         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
4155         parameter to the constructor.
4156         * WebView/WebCoreScriptDebuggerImp.mm:
4157         (toWebFrame): Added.
4158         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
4159         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
4160         WindowScriptObject ourselves instead of asking WebScriptDebugger for
4161         it.
4162         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
4163         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
4164         (WebCoreScriptDebuggerImp::exception): Ditto.
4165         * WebView/WebScriptDebugDelegate.mm:
4166         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
4167         WebScriptDebuggerImp's constructor.
4168         * WebView/WebScriptDebugDelegatePrivate.h: Removed
4169         -webFrame/-globalObject.
4170
4171 2008-03-05  Adam Roben  <aroben@apple.com>
4172
4173         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
4174
4175         Reviewed by Kevin M.
4176
4177         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
4178         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
4179         lifetime.
4180         * WebView/WebCoreScriptDebuggerImp.mm:
4181           - Added declaration of -[WebScriptCallFrame
4182             _initWithGlobalObject:caller:state:].
4183           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
4184         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
4185         now-unnecessary initialization of m_topCallFrame.
4186         (WebCoreScriptDebuggerImp::callEvent): Replaced call