2008-08-08 Maxime Britto <britto@apple.com>
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-08-08  Maxime Britto  <britto@apple.com>
2
3         Reviewed by Adele.
4
5         * WebView/WebFrame.mm:
6         (-[WebFrame _scrollDOMRangeToVisible:]):
7
8 2008-08-08  Brady Eidson  <beidson@apple.com>
9
10         Reviewed by Sam Weinig
11
12         Fix for <rdar://problem/5865504>
13
14         This bug was actually *largely* fixed by http://trac.webkit.org/changeset/35538.
15         But with that same patch, it became possible for a WebResource to fail to initialize.  
16         Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
17         Lets fix that, shall we?
18
19         * WebView/WebArchive.mm:
20         (-[WebArchive subresources]): 
21
22 2008-08-06  Eric Seidel  <eric@webkit.org>
23
24         Reviewed by Cameron Zwarich.
25
26         Move more methods from Frame into ScriptController
27         https://bugs.webkit.org/show_bug.cgi?id=20294
28
29         The WebKit side of this move.  Calls to frame() are now frame()->script()
30
31         * Plugins/WebBaseNetscapePluginView.mm:
32         (-[WebBaseNetscapePluginView getVariable:value:]):
33         (-[WebBaseNetscapePluginView _destroyPlugin]):
34         * Plugins/WebPluginController.mm:
35         (-[WebPluginController destroyPlugin:]):
36         (-[WebPluginController destroyAllPlugins]):
37         * WebCoreSupport/WebFrameLoaderClient.mm:
38         * WebView/WebFrame.mm:
39         (-[WebFrame windowObject]):
40         * WebView/WebScriptDebugger.mm:
41         (WebScriptDebugger::callEvent):
42         * WebView/WebView.mm:
43         (-[WebView windowScriptObject]):
44
45 2008-08-06  Dan Bernstein  <mitz@apple.com>
46
47         Reviewed by Mark Rowe.
48
49         - fix an assertion failure in Cache::setCapacities()
50
51         * Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize()
52         to uint64_t.
53         * Misc/WebKitSystemBits.m:
54         (WebMemorySize):
55         * WebView/WebView.mm:
56         (+[WebView _setCacheModel:]):
57
58 2008-08-05  Anders Carlsson  <andersca@apple.com>
59
60         Pass in the correct class here.
61         
62         * WebView/WebResource.mm:
63         (-[WebResourcePrivate dealloc]):
64
65 2008-08-05  Anders Carlsson  <andersca@apple.com>
66
67         Reviewed by Darin.
68
69         <rdar://problem/6037398>
70         ER: Deallocate WebKit objects on the main thread, even if released on secondary thread
71         
72         Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.
73
74         * Carbon/CarbonWindowAdapter.m:
75         (-[CarbonWindowAdapter dealloc]):
76         * History/WebBackForwardList.mm:
77         (-[WebBackForwardList dealloc]):
78         * History/WebHistoryItem.mm:
79         (-[WebHistoryItem dealloc]):
80         * Misc/WebElementDictionary.mm:
81         (+[WebElementDictionary initialize]):
82         (-[WebElementDictionary dealloc]):
83         * WebCoreSupport/WebEditorClient.mm:
84         (-[WebEditCommand dealloc]):
85         * WebCoreSupport/WebFrameLoaderClient.mm:
86         * WebView/WebArchive.mm:
87         (-[WebArchivePrivate dealloc]):
88         * WebView/WebDataSource.mm:
89         (-[WebDataSourcePrivate dealloc]):
90         * WebView/WebHTMLView.mm:
91         (-[WebHTMLViewPrivate dealloc]):
92         (-[WebHTMLView dealloc]):
93         * WebView/WebResource.mm:
94         (-[WebResourcePrivate dealloc]):
95
96 2008-08-05  Anders Carlsson  <andersca@apple.com>
97
98         Reviewed by Darin.
99
100         Remove MainThreadObjectDeallocator.{h|mm}.
101
102         * WebView/MainThreadObjectDeallocator.h: Removed.
103         * WebView/MainThreadObjectDeallocator.mm: Removed.
104         
105         * WebView/WebView.mm:
106         (-[WebView dealloc]):
107         Call WebCoreObjCScheduleDeallocateOnMainThread instead.
108
109 2008-08-05  Anders Carlsson  <andersca@apple.com>
110
111         Reviewed by Darin.
112
113         Make the main thread object deallocator work with subclasses.
114         
115         * WebView/MainThreadObjectDeallocator.h:
116         * WebView/MainThreadObjectDeallocator.mm:
117         (deallocCallback):
118         Call the correct dealloc method.
119                 
120         (scheduleDeallocateOnMainThread):
121         Store both the class and the instance, so we know which dealloc method to call.
122         
123         * WebView/WebView.mm:
124         (-[WebViewPrivate dealloc]):
125         Schedule deallocation on the main thread.
126
127 2008-08-05  Dan Bernstein  <mitz@apple.com>
128
129         Reviewed by Mark Rowe and Anders Carlsson.
130
131         - fix WebMemorySize() reporting a value capped at 2GB
132
133         * misc/WebKitSystemBits.m:
134         (WebMemorySize): Changed to return the max_mem field, which, unlike
135         memory_size, is not capped at 2GB.
136         * WebView/WebView.mm:
137         (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the
138         same as for 2GB, so that behavior on machines that have more than 2GB
139         RAM is not affected by the fix to WebMemorySize().
140
141 2008-08-04  Mark Rowe  <mrowe@apple.com>
142
143         Build fix.
144
145         * WebView/WebHTMLView.mm:
146
147 2008-08-04  Mark Rowe  <mrowe@apple.com>
148
149         Reviewed by Kevin Decker.
150
151         Adopt the formal protocols where necessary.
152         Final part of fix for <rdar://problem/5853147>.
153
154         * WebCoreSupport/WebInspectorClient.mm:
155         * WebView/WebHTMLView.mm:
156         * WebView/WebView.mm:
157         (-[WebView _openFrameInNewWindowFromMenu:]):
158
159 2008-08-04  Mark Rowe  <mrowe@apple.com>
160
161         Reviewed by Darin Adler.
162
163         Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
164         Part one of fix for <rdar://problem/5853147>.
165
166         * Misc/EmptyProtocolDefinitions.h:
167         * WebKitPrefix.h:
168
169 2008-08-04  Brady Eidson  <beidson@apple.com>
170
171         Reviewed by Mitz Pettel
172
173         Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.
174
175         This broke in r31355 when we stopped returning nil WebResources when there was nil
176         resource data.
177
178         * WebView/WebResource.mm:
179         (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil
180           when the resource data is null.
181
182 2008-08-02  Matt Lilek  <webkit@mattlilek.com>
183
184         Reviewed by Tim Hatcher.
185
186         Update the window gradient offset to match the inspector toolbar's new height.
187
188         * WebCoreSupport/WebInspectorClient.mm:
189         (-[WebInspectorWindowController window]):
190
191 2008-08-01  Anders Carlsson  <andersca@apple.com>
192
193         Reviewed by Jon.
194
195         <rdar://problem/6120206>
196         Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
197         
198         Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.
199
200         * Plugins/WebBaseNetscapePluginStream.mm:
201         (-[WebBaseNetscapePluginStream wantsAllStreams]):
202
203 2008-07-31  Anders Carlsson  <andersca@apple.com>
204
205         Reviewed by Darin.
206
207         <rdar://problem/5949410>
208         Add the ability to transfer a given application cache to a new database.
209
210         * Misc/WebKitNSStringExtras.h:
211         * Misc/WebKitNSStringExtras.m:
212         (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
213         New method which returns the appopriate cache directory for a given bundle identifier.
214         
215         * WebView/WebDataSource.mm:
216         (-[WebDataSource _transferApplicationCache:]):
217         Transfer the application cache.
218         
219         * WebView/WebDataSourcePrivate.h:
220         * WebView/WebView.mm:
221         (WebKitInitializeApplicationCachePathIfNecessary):
222         Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
223
224 2008-07-31  John Sullivan  <sullivan@apple.com>
225
226         WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs
227
228         Reviewed by Hyatt
229
230         * WebView/WebPreferenceKeysPrivate.h:
231         added WebKitZoomsTextOnlyPreferenceKey
232         
233         * WebView/WebPreferences.mm:
234         (+[WebPreferences initialize]):
235         default value of YES for WebKitZoomsTextOnlyPreferenceKey
236         (-[WebPreferences zoomsTextOnly]):
237         getter for WebKitZoomsTextOnlyPreferenceKey
238         (-[WebPreferences setZoomsTextOnly:]):
239         setter for WebKitZoomsTextOnlyPreferenceKey
240         
241         * WebView/WebPreferencesPrivate.h:
242         declare zoomsTextOnly/setZoomsTextOnly:
243         
244         * WebView/WebView.mm:
245         (-[WebView _preferencesChangedNotification:]):
246         update WebCore::Settings value for zoomsTextOnly
247
248 2008-07-31  David D. Kilzer  <ddkilzer@webkit.org>
249
250         Fix layout test results for webarchive/test-xml-stylesheet.xml
251
252         Reviewed by Darin.
253
254         Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
255         for DumpRenderTree.
256
257         * WebView/WebHTMLRepresentationInternal.h: Added.
258
259 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
260
261         Release build fix.
262
263         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
264         Don't define to npErr in release builds, as it is only used for logging.
265
266 2008-07-31  John Sullivan  <sullivan@apple.com>
267
268         Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
269         drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard
270
271         Reviewed by Dan
272
273         * WebView/WebHTMLView.mm:
274         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
275         include Leopard in the #ifdef that forces a layout if needed
276
277 2008-07-30  Brady Eidson  <beidson@apple.com>
278
279         Reviewed by Adam and Hyatt
280
281         Fix for <rdar://problem/6099748>
282
283         * WebView/WebView.mm:
284         (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" 
285           quirk when running under iWeb 2
286
287 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
288
289         Rubber-stamped by Maciej.
290
291         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
292         call sites now).
293
294         * ForwardingHeaders/kjs/JSLock.h: Removed.
295         * Misc/WebCoreStatistics.mm:
296         (+[WebCoreStatistics javaScriptObjectsCount]):
297         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
298         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
299         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
300         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
301         (+[WebCoreStatistics shouldPrintExceptions]):
302         (+[WebCoreStatistics setShouldPrintExceptions:]):
303         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
304         * Plugins/WebBaseNetscapePluginStream.mm:
305         (-[WebBaseNetscapePluginStream wantsAllStreams]):
306         * Plugins/WebBaseNetscapePluginView.mm:
307         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
308         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
309         (-[WebBaseNetscapePluginView start]):
310         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
311         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
312         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
313         (-[WebBaseNetscapePluginView loadPluginRequest:]):
314         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
315         * Plugins/WebPluginController.mm:
316         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
317         (-[WebPluginController startAllPlugins]):
318         (-[WebPluginController stopAllPlugins]):
319         (-[WebPluginController addPlugin:]):
320         (-[WebPluginController destroyPlugin:]):
321         (-[WebPluginController destroyAllPlugins]):
322         * WebView/WebFrame.mm:
323         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
324         * WebView/WebScriptDebugDelegate.mm:
325         (-[WebScriptCallFrame evaluateWebScript:]):
326         * WebView/WebView.mm:
327         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
328
329 2008-07-30  Beth Dakin  <bdakin@apple.com>
330
331         Reviewed by Anders Carlsson.
332
333         Fixes <rdar://problem/6041390>
334
335         Adds the ability to have a frame that is "disconnected" from the 
336         main frame from the perspective of top and parent in 
337         Javascript.
338
339         * WebView/WebFrame.mm:
340         (-[WebFrame _setIsDisconnectedFrame]):
341         * WebView/WebFramePrivate.h:
342
343 2008-07-29  Mark Rowe  <mrowe@apple.com>
344
345         Tweak to the build fix to keep Dan happy.
346
347         * Plugins/WebBaseNetscapePluginView.mm:
348         * WebView/WebHTMLView.mm:
349
350 2008-07-29  Mark Rowe  <mrowe@apple.com>
351
352         Build fix.
353
354         * Plugins/WebBaseNetscapePluginView.mm:
355         (-[WebBaseNetscapePluginView inputContext]):
356         * WebView/WebHTMLView.mm:
357
358 2008-07-28  Anders Carlsson  <andersca@apple.com>
359
360         Reviewed by Kevin Decker.
361
362         Based on a patch by Dimcho Balev.
363         
364         https://bugs.webkit.org/show_bug.cgi?id=18676
365         <rdar://problem/6106578>
366         Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
367
368         * Plugins/WebBaseNetscapePluginStream.h:
369         Add NPP_GetValue pointer.
370         
371         * Plugins/WebBaseNetscapePluginStream.mm:
372         (-[WebBaseNetscapePluginStream setPlugin:]):
373         Initialize NPP_GetValue.
374         
375         (-[WebBaseNetscapePluginStream wantsAllStreams]):
376         Call NPP_GetValue.
377         
378         * Plugins/WebPlugInStreamLoaderDelegate.h:
379         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
380         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
381         (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
382         Implement this and call down to the stream.
383
384 2008-07-28  Anders Carlsson  <andersca@apple.com>
385
386         Reviewed by Adam.
387
388         <rdar://problem/6105529> 
389         https://bugs.webkit.org/show_bug.cgi?id=19659
390         Turning off plugins causes crash
391         
392         When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
393         end up in a state where they don't have an event handler. Because of this, we need to 
394         check that the plug-in has been started before calling the event handler.
395         
396         * Plugins/WebBaseNetscapePluginView.mm:
397         (-[WebBaseNetscapePluginView sendActivateEvent:]):
398         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
399         (-[WebBaseNetscapePluginView setHasFocus:]):
400         (-[WebBaseNetscapePluginView mouseDown:]):
401         (-[WebBaseNetscapePluginView mouseUp:]):
402         (-[WebBaseNetscapePluginView mouseEntered:]):
403         (-[WebBaseNetscapePluginView mouseExited:]):
404         (-[WebBaseNetscapePluginView handleMouseMoved:]):
405         (-[WebBaseNetscapePluginView mouseDragged:]):
406         (-[WebBaseNetscapePluginView scrollWheel:]):
407         (-[WebBaseNetscapePluginView keyUp:]):
408         (-[WebBaseNetscapePluginView keyDown:]):
409         (-[WebBaseNetscapePluginView flagsChanged:]):
410         (-[WebBaseNetscapePluginView cut:]):
411         (-[WebBaseNetscapePluginView copy:]):
412         (-[WebBaseNetscapePluginView paste:]):
413         (-[WebBaseNetscapePluginView selectAll:]):
414         (-[WebBaseNetscapePluginView drawRect:]):
415         (-[WebBaseNetscapePluginView inputContext]):
416
417 2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>
418
419         Reviewed by Geoff Garen.
420
421         Changes to accommodate newly named/signatured loading methods in WebCore.
422
423         * Plugins/WebNetscapePluginStream.mm:
424         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
425         * Plugins/WebPluginContainerCheck.mm:
426         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
427         * WebView/WebPDFView.mm:
428         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
429
430 2008-07-21  Mark Rowe  <mrowe@apple.com>
431
432         Reviewed by Sam Weinig.
433
434         <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
435
436         * Configurations/Version.xcconfig:
437         * Info.plist:
438
439 2008-07-21  Anders Carlsson  <andersca@apple.com>
440
441         Reviewed by Geoff.
442
443         <rdar://problem/5820667> 
444         CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
445         
446         Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
447         
448         * Plugins/WebBaseNetscapePluginView.mm:
449         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
450
451 2008-07-21  Mark Rowe  <mrowe@apple.com>
452
453         Reviewed by Adam Roben.
454
455         <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
456
457         Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
458         This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
459
460         * WebView/WebHTMLView.mm:
461
462 2008-07-21  Mark Rowe  <mrowe@apple.com>
463
464         Reviewed by Adam Roben.
465
466         Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
467         only uses objc_msgSend_fpret for long double return values.  For float return
468         values the standard objc_msgSend is used, as on ppc and ppc64.
469
470         * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
471         objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
472         as that method is defined by the Objective-C runtime for x86_64.
473         (CallDelegateReturningFloat):
474
475 2008-07-14  Dan Bernstein  <mitz@apple.com>
476
477         Reviewed by John Sullivan.
478
479         - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
480
481         * Plugins/WebBaseNetscapePluginView.mm:
482         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
483         to account for the case of being drawn into a bitmap context that is not
484         a window's backing store. In that case, there are no valid "rects being
485         drawn" to clip to.
486         * WebView/WebHTMLView.mm:
487         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
488         Added an override of this NSView method which is used in for
489         -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
490         machinery overrides, it sets subviews aside before invoking the
491         superclass implementation. On Tiger, it also updates the layout.
492
493 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
494
495         Reviewed by Geoff Garen.
496
497         Eliminate per-thread JavaScript global data instance support and make arbitrary
498         global data/global object combinations possible.
499
500         * Misc/WebCoreStatistics.mm:
501         (+[WebCoreStatistics javaScriptObjectsCount]):
502         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
503         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
504         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
505         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
506         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
507         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
508
509 2008-07-11  Stephanie Lewis  <slewis@apple.com>
510
511         Reviewed by Darin Adler.
512
513         Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
514
515         * WebView/WebPreferences.m: Removed.
516         * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
517         (+[WebPreferences initialize]): if running in Default enable full  document teardown
518         (-[WebPreferences editableLinkBehavior]):
519         (-[WebPreferences setFullDocumentTeardownEnabled:]):
520         * WebView/WebView.mm:
521         (-[WebView _close]): disable leak messages if using fast teardown
522
523 2008-07-10  Mark Rowe  <mrowe@apple.com>
524
525         Reviewed by Sam Weinig.
526
527         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
528
529         * Configurations/WebKit.xcconfig:
530
531 2008-07-10  Mark Rowe  <mrowe@apple.com>
532
533         Reviewed by Sam Weinig.
534
535         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
536
537         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
538         * WebView/WebFrameLoadDelegate.h: Ditto.
539         * WebView/WebUIDelegate.h: Ditto.
540
541 2008-07-10  Anders Carlsson  <andersca@apple.com>
542
543         Reviewed by Mark.
544         
545         Add availability macros for the new WebPlugin methods.
546
547         * Plugins/WebPlugin.h:
548         * Plugins/WebPluginViewFactory.h:
549
550 2008-07-09  Mark Rowe  <mrowe@apple.com>
551
552         Reviewed by Geoff Garen.
553
554         Don't warn about deprecated functions in production builds.
555
556         * Configurations/Base.xcconfig:
557         * Configurations/DebugRelease.xcconfig:
558
559 2008-07-09  Brady Eidson  <beidson@apple.com>
560
561         Reviewed by Darin
562
563         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
564         has been installed in a frame tree.
565
566         The root of this problem was that calling init() on a new frame could end up calling arbitrary
567         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
568         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
569         destroying the frame.
570
571         Note that each platforms WebKit API layer needs to make this new guarantee:
572         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
573         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
574         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
575
576         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
577         architectural improvement we can make in the future so the individual platform clients are no longer
578         vulnerable to this problem, which should really have been a WebCore issue.
579
580         * WebCoreSupport/WebFrameLoaderClient.mm:
581         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
582           Don't appendChild() the new frame here.
583           Null-check the new frame's page before loading the URL into it, as it might already have been
584           removed from the page.
585
586         * WebView/WebFrame.mm:
587         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
588           go ahead and install the new frame in the frame tree *before* calling init() on it.
589
590 2008-07-09  Anders Carlsson  <andersca@apple.com>
591
592         Reviewed by Darin.
593
594         Make some WebPlugin and WebPluginFactory SPI public.
595         
596         * Plugins/WebPlugin.h:
597         * Plugins/WebPluginPrivate.h:
598         * Plugins/WebPluginViewFactory.h:
599         * Plugins/WebPluginViewFactoryPrivate.h:
600
601 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
602
603         Reviewed by Anders.
604
605         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
606         unsuccessful.
607
608         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
609         newStreamSuccessful.
610         * Plugins/WebBaseNetscapePluginStream.mm:
611         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
612         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
613         newStreamSuccessful to YES.
614         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
615         NPP_DestroyStream if newStreamSuccessful is true.
616
617 2008-07-08  Dan Bernstein  <mitz@apple.com>
618
619         Reviewed by John Sullivan.
620
621         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
622
623         * WebView/WebHTMLView.mm:
624         (-[WebHTMLView addWindowObservers]): Added code to observe when the
625         window goes onscreen.
626         (-[WebHTMLView removeWindowObservers]): Added.
627         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
628         not update when offscreen, calls -setNeedsDisplay: just before it comes
629         onscreen.
630         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
631         * WebView/WebPreferences.m:
632         (+[WebPreferences initialize]): Made updates when offscreen on by
633         default.
634         (-[WebPreferences updatesWhenOffscreen]): Added.
635         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
636         * WebView/WebPreferencesPrivate.h:
637         * WebView/WebView.mm:
638         (-[WebView _preferencesChangedNotification:]): Added code to update the
639         updatesWhenOffscreen setting in WebCore.
640
641 2008-07-07  Anders Carlsson  <andersca@apple.com>
642
643         Reviewed by Darin.
644
645         Speculative fix for     
646         <rdar://problem/5839800>
647         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
648         
649         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
650         
651         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
652         This is usually protected by _private->closed, but in this case it might still be false.
653
654         * WebView/WebHTMLView.mm:
655         (-[WebHTMLView close]):
656
657 2008-07-05  Mark Rowe  <mrowe@apple.com>
658
659         Reviewed by John Sullivan.
660
661         Remove WebSearchableTextView as it has been unused for some time now.
662
663         * Misc/WebSearchableTextView.h: Removed.
664         * Misc/WebSearchableTextView.m: Removed.
665
666 2008-07-05  Mark Rowe  <mrowe@apple.com>
667
668         Reviewed by John Sullivan.
669
670         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
671
672         * Misc/WebNSUserDefaultsExtras.m:
673         (-[NSString _webkit_HTTPStyleLanguageCode]):
674
675 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
676
677         Inspired and reviewed by Mark Rowe.
678
679         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
680
681         * Carbon/HIViewAdapter.m:
682         * DOM/WebDOMOperations.mm:
683         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
684         * DefaultDelegates/WebDefaultPolicyDelegate.m:
685         * History/WebBackForwardList.mm:
686         * History/WebHistory.mm:
687         * History/WebHistoryItem.mm:
688         * History/WebHistoryItemInternal.h:
689         * Misc/WebCoreStatistics.mm:
690         * Misc/WebDownload.m:
691         * Misc/WebGraphicsExtras.c:
692         * Misc/WebKitLogging.h:
693         * Misc/WebKitSystemBits.m:
694         * Misc/WebLocalizableStrings.m:
695         * Misc/WebNSArrayExtras.m:
696         * Misc/WebNSDataExtras.m:
697         * Misc/WebNSDictionaryExtras.m:
698         * Misc/WebNSFileManagerExtras.m:
699         * Misc/WebNSPasteboardExtras.mm:
700         * Misc/WebNSURLExtras.mm:
701         * Misc/WebNSUserDefaultsExtras.m:
702         * Panels/WebAuthenticationPanel.m:
703         * Panels/WebPanelAuthenticationHandler.m:
704         * Plugins/WebBaseNetscapePluginView.mm:
705         * Plugins/WebBasePluginPackage.m:
706         * Plugins/WebNetscapePluginEmbeddedView.mm:
707         * Plugins/WebPluginContainerCheck.mm:
708         * Plugins/WebPluginController.mm:
709         * Plugins/WebPluginDatabase.mm:
710         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
711         * WebCoreSupport/WebKeyGenerator.m:
712         * WebCoreSupport/WebViewFactory.mm:
713         * WebKitPrefix.h:
714         * WebView/WebHTMLRepresentation.mm:
715         * WebView/WebPDFRepresentation.m:
716         * WebView/WebPDFView.mm:
717         * WebView/WebScriptDebugger.mm:
718
719 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
720
721         Reviewed by Darin.
722
723         Disable JSLock for per-thread contexts.
724
725         * Misc/WebCoreStatistics.mm:
726         (+[WebCoreStatistics javaScriptObjectsCount]):
727         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
728         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
729         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
730         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
731         (+[WebCoreStatistics shouldPrintExceptions]):
732         (+[WebCoreStatistics setShouldPrintExceptions:]):
733         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
734         * Plugins/WebBaseNetscapePluginView.mm:
735         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
736         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
737         (-[WebBaseNetscapePluginView start]):
738         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
739         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
740         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
741         (-[WebBaseNetscapePluginView loadPluginRequest:]):
742         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
743         * Plugins/WebPluginController.mm:
744         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
745         (-[WebPluginController startAllPlugins]):
746         (-[WebPluginController stopAllPlugins]):
747         (-[WebPluginController addPlugin:]):
748         (-[WebPluginController destroyPlugin:]):
749         (-[WebPluginController destroyAllPlugins]):
750         * WebView/WebFrame.mm:
751         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
752         * WebView/WebScriptDebugDelegate.mm:
753         (-[WebScriptCallFrame evaluateWebScript:]):
754         * WebView/WebView.mm:
755         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
756         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
757         doesn't need locking. In the future, it may be possible to remove some of these if we
758         establish that this won't make JSC assertions fail (and that we don't want to add such
759         assertions either).
760         Added includes that are now needed.
761
762 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
763
764         Build fix.
765
766         * WebView/WebView.mm:
767
768 2008-07-01  Anders Carlsson  <andersca@apple.com>
769
770         Reviewed by Darin.
771
772         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
773         
774         * Plugins/WebBaseNetscapePluginView.mm:
775         (-[WebBaseNetscapePluginView _createPlugin]):
776         Register the plug-in instance.
777         
778         (-[WebBaseNetscapePluginView _destroyPlugin]):
779         Unegister the plug-in instance.
780         
781         * Plugins/WebNetscapePluginPackage.m:
782         (-[WebNetscapePluginPackage load]):
783         Set NPN_PluginThreadAsyncCall.
784         
785         * Plugins/npapi.mm:
786         (NPN_PluginThreadAsyncCall):
787         Implement this.
788
789 2008-07-01  Dan Bernstein  <mitz@apple.com>
790
791         Reviewed by Darin Adler.
792
793         - WebKit part of moving the method to set the base writing direction from Frame to Editor
794
795         * WebView/WebHTMLView.mm:
796         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
797         Editor method.
798         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
799         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
800
801 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
802
803         Build fix: forgot to check in this file.
804
805         * WebView/WebScriptDebugger.mm:
806         (WebScriptDebugger::WebScriptDebugger):
807
808 2008-06-30  Dan Bernstein  <mitz@apple.com>
809
810         Reviewed by Adele Peterson.
811
812         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
813
814         * WebView/WebHTMLView.mm:
815         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
816         WebCore::Frame::setSelectionBaseWritingDirection() instead of
817         WebCore::Editor::setBaseWritingDirection().
818         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
819         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
820
821 2008-06-28  Darin Adler  <darin@apple.com>
822
823         - fix build
824
825         * WebView/WebView.mm:
826         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
827
828 2008-06-26  Anders Carlsson  <andersca@apple.com>
829
830         Reviewed by Darin.
831
832         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
833         if necessary. Use this for the WebView class. 
834                 
835         * WebView/MainThreadObjectDeallocator.h: Added.
836         * WebView/MainThreadObjectDeallocator.mm: Added.
837         (deallocCallback):
838         (scheduleDeallocateOnMainThread):
839         * WebView/WebView.mm:
840         (-[WebViewPrivate dealloc]):
841         (+[WebView initialize]):
842
843 2008-06-25  Anders Carlsson  <andersca@apple.com>
844
845         Reviewed by Mark.
846
847         <rdar://problem/5984270> 
848         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
849         
850         * WebView/WebView.mm:
851         (tigerMailReleaseIMP):
852         New method that makes sure that the final release happens on the main thread.
853         
854         (-[WebView release]):
855         New method that just calls [super release];
856         
857         (+[WebView initialize]):
858         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
859
860 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
861
862         Reviewed by Geoff.
863
864         Make Machine per-JSGlobalData.
865
866         * WebView/WebScriptDebugger.mm:
867         (WebScriptDebugger::WebScriptDebugger):
868
869 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
870
871         Reviewed by Darin.
872
873         Prepare JavaScript heap for being per-thread.
874
875         * Misc/WebCoreStatistics.mm:
876         (+[WebCoreStatistics javaScriptObjectsCount]):
877         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
878         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
879         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
880         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
881         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
882         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
883
884 2008-06-17  Darin Adler  <darin@apple.com>
885
886         Reviewed by Sam.
887
888         * WebView/WebHTMLView.mm:
889         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
890         to create a CSSMutableStyleDeclaration.
891
892 2008-06-16  Mark Rowe  <mrowe@apple.com>
893
894         Reviewed by Darin Adler.
895
896         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
897
898         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
899         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
900         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
901         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
902
903         * WebView/WebHTMLView.mm:
904         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
905         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
906         * WebView/WebHTMLViewInternal.h:
907         * WebView/WebHTMLViewPrivate.h:
908
909 2008-06-15  Darin Adler  <darin@apple.com>
910
911         - give Frame object functions shorter names: scriptProxy() -> script(),
912           selectionController() -> selection(), animationController() -> animation()
913
914         * Plugins/WebPluginController.mm:
915         (-[WebPluginController webPlugInContainerSelectionColor]):
916         * WebView/WebFrame.mm:
917         (-[WebFrame _attachScriptDebugger]):
918         (-[WebFrame _hasSelection]):
919         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
920         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
921         (-[WebFrame _convertToNSRange:]):
922         (-[WebFrame _convertToDOMRange:]):
923         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
924         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
925         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
926         (-[WebFrame _selectedNSRange]):
927         (-[WebFrame _selectNSRange:]):
928         (-[WebFrame globalContext]):
929         * WebView/WebHTMLView.mm:
930         (-[WebHTMLView _selectedRange]):
931         (-[WebHTMLView _hasSelection]):
932         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
933         (-[WebHTMLView _hasInsertionPoint]):
934         (-[WebHTMLView _isEditable]):
935         (-[WebHTMLView _updateFocusedAndActiveState]):
936         (-[WebHTMLView readSelectionFromPasteboard:]):
937         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
938         (-[WebHTMLView maintainsInactiveSelection]):
939         (-[WebHTMLView paste:]):
940         (isTextInput):
941         (-[WebHTMLView inputContext]):
942         (-[WebTextCompleteController doCompletion]):
943         (-[WebHTMLView selectAll]):
944         (-[WebHTMLView deselectAll]):
945         (-[WebHTMLView selectedAttributedString]):
946         * WebView/WebView.mm:
947         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
948         (-[WebView setSelectedDOMRange:affinity:]):
949         (-[WebView selectedDOMRange]):
950         (-[WebView selectionAffinity]):
951
952 2008-06-15  Darin Adler  <darin@apple.com>
953
954         - rename KJS::List to KJS::ArgList
955
956         * WebView/WebScriptDebugger.h:
957
958 2008-06-15  Darin Adler  <darin@apple.com>
959
960         - new names for more JavaScriptCore files
961
962         * WebView/WebView.mm:
963
964 2008-06-15  Darin Adler  <darin@apple.com>
965
966         - new names for a few key JavaScriptCore files
967
968         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
969         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
970         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
971         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
972         * ForwardingHeaders/kjs/function.h: Removed.
973         * ForwardingHeaders/kjs/internal.h: Removed.
974         * ForwardingHeaders/kjs/object.h: Removed.
975         * ForwardingHeaders/kjs/value.h: Removed.
976         * WebView/WebScriptDebugDelegate.mm:
977
978 2008-06-15  Darin Adler  <darin@apple.com>
979
980         Rubber stamped by Sam.
981
982         - use JS prefix and simpler names for basic JavaScriptCore types,
983           to complement JSValue and JSObject
984
985         * WebView/WebView.mm:
986         (aeDescFromJSValue):
987
988 2008-06-14  Darin Adler  <darin@apple.com>
989
990         Rubber stamped by Sam.
991
992         - new names for kjs_binding.h and kjs_proxy.h
993
994         * WebView/WebFrame.mm:
995         * WebView/WebScriptDebugDelegate.mm:
996         * WebView/WebView.mm:
997
998 2008-06-14  Darin Adler  <darin@apple.com>
999
1000         Rubber stamped by Sam.
1001
1002         - renamed HTMLGenericFormElement to HTMLFormControlElement
1003
1004         * WebView/WebHTMLRepresentation.mm:
1005         (-[WebHTMLRepresentation elementWithName:inForm:]):
1006         (-[WebHTMLRepresentation controlsInForm:]):
1007
1008 2008-06-14  Darin Adler  <darin@apple.com>
1009
1010         Reviewed by Sam.
1011
1012         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
1013           start ref counts at 1 instead of 0 for speed
1014
1015         * WebCoreSupport/WebFrameLoaderClient.mm:
1016         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
1017         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
1018         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
1019         conventional ones without a special case.
1020
1021         * WebView/WebDataSource.mm:
1022         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
1023         this function takes ownership of the DocumentLoader.
1024         (-[WebDataSource initWithRequest:]): Use create instead of new.
1025         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
1026         PassRefPtr and also cleaned up the header a bit.
1027
1028         * WebView/WebDocumentLoaderMac.h:
1029         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
1030         functions private.
1031
1032         * WebView/WebFrame.mm:
1033         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
1034         of new.
1035
1036 2008-06-14  Darin Adler  <darin@apple.com>
1037
1038         Reviewed by Sam.
1039
1040         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
1041           start ref counts at 1 instead of 0 for speed
1042
1043         * WebView/WebFrame.mm:
1044         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1045         * WebView/WebPDFView.mm:
1046         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1047
1048 2008-06-13  Darin Adler  <darin@apple.com>
1049
1050         Reviewed by John Sullivan.
1051
1052         - updated for addition of FormState argument to action policy functions
1053         - added WebActionFormKey
1054
1055         * WebCoreSupport/WebFrameLoaderClient.h:
1056         * WebCoreSupport/WebFrameLoaderClient.mm:
1057         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1058         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1059         (WebFrameLoaderClient::actionDictionary):
1060         * WebKit.exp:
1061         * WebView/WebPolicyDelegate.mm:
1062         * WebView/WebPolicyDelegatePrivate.h:
1063
1064 2008-06-12  John Sullivan  <sullivan@apple.com>
1065
1066         Reviewed by Dan and Darin
1067
1068         Clear up the confusion about _close (older private method) vs -close (newer public method).
1069
1070         * WebView/WebView.mm:
1071         (-[WebView _isClosed]):
1072         simplified style
1073         (-[WebView _close]):
1074         added a comment about how clients and subclasses should use -close instead
1075         (-[WebView dealloc]):
1076         call -close instead of _close, so subclasses that override the public method will have the intended behavior
1077         (-[WebView close]):
1078         added a comment
1079         (-[WebView _windowWillClose:]):
1080         call -close instead of _close, so subclasses that override the public method will have the intended behavior
1081
1082         * WebView/WebViewPrivate.h:
1083         added a comment about how clients and subclasses should use -close instead
1084
1085 2008-06-07  Darin Adler  <darin@apple.com>
1086
1087         Reviewed by Mitz.
1088
1089         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
1090           start ref counts at 1 instead of 0 for speed
1091
1092         * History/WebHistoryItem.mm:
1093         (-[WebHistoryItem init]):
1094         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
1095         (-[WebHistoryItem initWithURL:target:parent:title:]):
1096         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
1097         * WebView/WebView.mm:
1098         (+[WebView _decodeData:]):
1099
1100 2008-06-03  Oliver Hunt  <oliver@apple.com>
1101
1102         Reviewed by Tim.
1103
1104         Bug 12983: Web Inspector break on the debugger keyword
1105         <https://bugs.webkit.org/show_bug.cgi?id=12983>
1106
1107         Add stubs to allow old webkit debugger interface to build.
1108
1109         * WebView/WebScriptDebugger.h:
1110         * WebView/WebScriptDebugger.mm:
1111
1112 2008-06-03  Anders Carlsson  <andersca@apple.com>
1113
1114         Reviewed by Darin.
1115
1116         <rdar://problem/5980961>
1117         
1118         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
1119         newBottom to be larger than oldBottom which is illegal.
1120         
1121         * WebView/WebHTMLView.mm:
1122         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
1123
1124 2008-06-02  Anders Carlsson  <andersca@apple.com>
1125
1126         Reviewed by Mitz.
1127
1128         Speculative fix for <rdar://problem/5661112> 
1129         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
1130         
1131         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
1132         layouts to be triggered.
1133         
1134         * Plugins/WebBaseNetscapePluginView.mm:
1135         (-[WebBaseNetscapePluginView _createPlugin]):
1136
1137 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
1138
1139         Reviewed by Darin.
1140         
1141         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
1142         
1143         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
1144         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
1145         setting and retrieving pasteboard types with UTIs, but we don't know of any
1146         applications on Tiger that put only PNG on the pasteboard.
1147
1148         * WebView/WebHTMLView.mm:
1149         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1150         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1151
1152 2008-05-29  Anders Carlsson  <andersca@apple.com>
1153
1154         Reviewed by Brady.
1155
1156         <rdar://problem/5970312> 
1157         icon file specified for stand alone web app causes crash if the icon can't be found
1158         
1159         Handle the case where iconData is null.
1160         
1161         * Misc/WebIconFetcher.mm:
1162         (WebIconFetcherClient::finishedFetchingIcon):
1163
1164 2008-05-29  Anders Carlsson  <andersca@apple.com>
1165
1166         Reviewed by Mitz.
1167
1168         <rdar://problem/5971845>
1169         https://bugs.webkit.org/show_bug.cgi?id=19313
1170         Add version member to NPCocoaEvent
1171
1172         Initialize the version member to 0 for all events.
1173         
1174         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1175         (initializeEvent):
1176         (WebNetscapePluginEventHandlerCocoa::drawRect):
1177         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1178         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1179         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1180         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1181         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1182
1183 2008-05-29  Dan Bernstein  <mitz@apple.com>
1184
1185         Reviewed by Jessica Kahn.
1186
1187         - fix <rdar://problem/5965013> Page 2 does not print correctly
1188
1189         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
1190         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
1191         -viewWillDraw being sent first, which could lead to painting without
1192         valid layout. The fix is to ensure up-to-date layout in those methods
1193         when printing.
1194
1195         * WebView/WebHTMLView.mm:
1196         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1197         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1198
1199 2008-05-28  Anders Carlsson  <andersca@apple.com>
1200
1201         Reviewed by Jon.
1202
1203         Remove workaround, this is no longer a problem.
1204         
1205         * WebView/WebView.mm:
1206         (-[WebView _removeObjectForIdentifier:]):
1207
1208 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
1209
1210         Reviewed by Tim Hatcher.
1211         
1212         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
1213         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
1214         clicking button in returnEvent-crash.html
1215         
1216         Added implementations for willExecuteProgram and didExecuteProgram, which
1217         take care of making sure we're not hanging on to stale data.
1218
1219 2008-05-27  Timothy Hatcher  <timothy@apple.com>
1220
1221         Fixes a bug where unplugging the monitor from a video card and
1222         moving it to another video card would no longer show OpenGL plugins
1223         until you relaunched Safari.
1224
1225         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
1226         attribute to OpenGL contexts
1227
1228         Reviewed by Kevin Decker.
1229
1230         * Plugins/WebBaseNetscapePluginView.mm:
1231         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
1232         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
1233         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
1234
1235 2008-05-25  Mark Rowe  <mrowe@apple.com>
1236
1237         Reviewed by Darin Adler.
1238
1239         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1240
1241         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
1242         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
1243
1244         * WebView/WebFrame.mm:
1245         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
1246         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
1247         * WebView/WebFrameInternal.h:
1248         * WebView/WebFramePrivate.h:
1249
1250 2008-05-23  Timothy Hatcher  <timothy@apple.com>
1251
1252         Fix attaching and detaching the Web Inspector. This change removes
1253         the clunky animation that never looked right and was causing issues
1254         where the inspected WebView would get into a no useable state.
1255
1256         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
1257         can cause the inspected WebVIew to be unusable
1258
1259         Reviewed by Adam Roben.
1260
1261         * WebCoreSupport/WebInspectorClient.mm:
1262         (-[WebInspectorWindowController close]): Removes animation code.
1263         Sets the frame directly and does a displayIfNeeded to prevent
1264         showing the Inspector in the page and in the Inspector window.
1265         (-[WebInspectorWindowController showWindow:]): Removes animation code.
1266         Sets the frame directly.
1267         (-[WebInspectorWindowController attach]): Simplified.
1268         (-[WebInspectorWindowController detach]): Ditto.
1269
1270 2008-05-22  Dan Bernstein  <mitz@apple.com>
1271
1272         Reviewed by Darin Adler.
1273
1274         - fix broken documentation of
1275           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1276
1277         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
1278         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1279
1280 2008-05-22  Timothy Hatcher  <timothy@apple.com>
1281
1282         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
1283
1284         Reviewed by Adam Roben.
1285
1286         * WebCoreSupport/WebInspectorClient.mm:
1287         (-[WebInspectorWindowController showWebInspector:]):
1288         (-[WebInspectorWindowController showErrorConsole:]):
1289         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
1290         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
1291         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1292         * WebInspector/WebInspector.h:
1293         * WebInspector/WebInspector.mm:
1294         (-[WebInspector showConsole:]):
1295         (-[WebInspector showTimeline:]):
1296         (-[WebInspector isDebuggingJavaScript]):
1297         (-[WebInspector toggleDebuggingJavaScript:]):
1298         (-[WebInspector startDebuggingJavaScript:]):
1299         (-[WebInspector stopDebuggingJavaScript:]):
1300         (-[WebInspector isProfilingJavaScript]):
1301         (-[WebInspector toggleProfilingJavaScript:]):
1302         (-[WebInspector startProfilingJavaScript:]):
1303         (-[WebInspector stopProfilingJavaScript:]):
1304
1305 2008-05-22  Josh Aas  <joshmoz@gmail.com>
1306
1307         Reviewed by Anders.
1308
1309         <rdar://problem/5956429> 
1310         https://bugs.webkit.org/show_bug.cgi?id=19192
1311         remove NPNVpluginEventModel, fix example plugin
1312         
1313         * Plugins/WebBaseNetscapePluginView.mm:
1314         (-[WebBaseNetscapePluginView getVariable:value:]):
1315
1316 2008-05-21  Anders Carlsson  <andersca@apple.com>
1317
1318         Reviewed by Maciej.
1319
1320         Add WebIconFetcher.
1321         
1322         * Misc/WebIconFetcher.h: Added.
1323         * Misc/WebIconFetcher.mm: Added.
1324         (WebIconFetcherClient::WebIconFetcherClient):
1325         (WebIconFetcherClient::finishedFetchingIcon):
1326         (WebIconFetcherClient::setFetcher):
1327         (-[WebIconFetcher init]):
1328         (-[WebIconFetcher dealloc]):
1329         (-[WebIconFetcher finalize]):
1330         (-[WebIconFetcher cancel]):
1331         (-[WebIconFetcher _initWithIconFetcher:client:]):
1332         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
1333         * Misc/WebIconFetcherInternal.h: Added.
1334         * WebView/WebFrame.mm:
1335         (-[WebFrame fetchApplicationIcon:selector:]):
1336         * WebView/WebFramePrivate.h:
1337
1338 === End merge of squirrelfish ===
1339
1340 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
1341
1342         Reviewed by Tim Hatcher.
1343         
1344         Updated for API changes from merging with trunk WebCore's new debugger.
1345
1346         * WebView/WebScriptDebugDelegate.mm:
1347         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
1348         exception return, since the DebuggerCallFrame no longer automatically
1349         substitutes the exception for the return value.
1350
1351         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
1352         lexical global object, since the debugger attaches based on dynamic
1353         global object.
1354
1355 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
1356
1357         Reviewed by Oliver Hunt.
1358         
1359         Re-enabled previously disabled debugging functionality.
1360         
1361         There are two major changes from how the WebKit debugger used to work:
1362         
1363         (1) All the interesting bits are implemented down in JavaScriptCore. The
1364         debugger just calls through to KJS::DebuggerCallFrame for everything.
1365         
1366         (2) Instead of copyihng a pointer to an ExecState once, the debugger
1367         copies the DebuggerCallFrame passed to it in each callback. This is
1368         because the VM no longer maintains a fully transparent execution state
1369         to which you can hold a pointer, and the DebuggerCallFrames it vends
1370         are temporaries.
1371         
1372         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
1373         from its function. This is safer than the old method, which was to
1374         hold a stale ExecState* and hope for the best.
1375
1376 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1377
1378         Reviewed by Oliver Hunt.
1379
1380         Updated for API changes in KJS::Debugger.
1381
1382         * WebView/WebFrame.mm:
1383         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
1384         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
1385
1386 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1387
1388         Reviewed by Oliver Hunt.
1389         
1390         Updated WebScriptDebugger API to accept a SourceProvider instead
1391         of a WebCore::String, to avoid copying.
1392
1393         (WebScriptDebugger::sourceParsed): Updated this function not to return
1394         a value.
1395
1396 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1397
1398         Build fix: #ifdef'd out some code that doesn't work anymore.
1399
1400 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1401
1402         Reviewed by Oliver Hunt.
1403         
1404         #ifdef'd out some debugger code that doesn't work anymore.
1405
1406         * WebView/WebScriptDebugDelegate.mm:
1407         (-[WebScriptCallFrame scopeChain]):
1408
1409 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
1410
1411         Build fix.
1412
1413         * ChangeLog:
1414         * WebView/WebScriptDebugDelegate.mm:
1415         (-[WebScriptCallFrame scopeChain]):
1416
1417 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
1418
1419         Reviewed by Oliver Hunt.
1420         
1421         Build fix.
1422
1423 === Start merge of squirrelfish ===
1424
1425 2008-05-21  Darin Adler  <darin@apple.com>
1426
1427         - fix build
1428
1429         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
1430         if we want, but if we do, we should probably make some refinements like checking _private->closed
1431         and applicationIsTerminating.
1432
1433 2008-05-21  Darin Adler  <darin@apple.com>
1434
1435         Reviewed by Anders and Kevin Decker.
1436
1437         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
1438
1439         * WebView/WebView.mm:
1440         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
1441         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
1442         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
1443         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
1444         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
1445
1446 2008-05-19  Stephanie Lewis  <slewis@apple.com>
1447
1448         Reviewed by Darin.
1449     
1450         more fast teardown performance work
1451
1452         * Misc/WebDownload.m:
1453         (-[WebDownloadInternal downloadDidBegin:]):
1454         (-[WebDownloadInternal downloadDidFinish:]):
1455         (-[WebDownloadInternal download:didFailWithError:]):
1456         * WebCoreSupport/WebChromeClient.h:
1457         * WebCoreSupport/WebChromeClient.mm:
1458         (WebChromeClient::disableSuddenTermination):
1459         (WebChromeClient::enableSuddenTermination):
1460
1461 2008-05-18  Dan Bernstein  <mitz@apple.com>
1462
1463         Reviewed by Sam Weinig.
1464
1465         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
1466
1467         * Panels/WebAuthenticationPanel.m:
1468         (-[WebAuthenticationPanel setUpForChallenge:]):
1469
1470 2008-05-16  Timothy Hatcher  <timothy@apple.com>
1471
1472         Removes WebScriptDebugServer files and related calls. This removes
1473         the hooks that Drosera uses for debugging. Now that the Web Inspector
1474         has a better debugger, we don't need these anymore.
1475
1476         Reviewed by Sam Weinig.
1477
1478         * DefaultDelegates/WebScriptDebugServer.h: Removed.
1479         * DefaultDelegates/WebScriptDebugServer.m: Removed.
1480         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
1481         * WebCoreSupport/WebFrameLoaderClient.mm:
1482         * WebKit.exp:
1483         * WebView/WebScriptDebugDelegate.mm:
1484         * WebView/WebScriptDebugger.mm:
1485         (WebScriptDebugger::sourceParsed):
1486         (WebScriptDebugger::callEvent):
1487         (WebScriptDebugger::atStatement):
1488         (WebScriptDebugger::returnEvent):
1489         (WebScriptDebugger::exception):
1490         * WebView/WebView.mm:
1491         (-[WebView _commonInitializationWithFrameName:groupName:]):
1492         * WebView/WebViewPrivate.h:
1493
1494 2008-05-16  Brady Eidson  <beidson@apple.com>
1495
1496         Reviewed by Anders
1497
1498         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
1499
1500         Took the opportunity to touch up another pref that needs the same standardization.
1501         That pref is currently not in use on Mac.
1502
1503         * WebView/WebPreferences.m:
1504         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
1505         (-[WebPreferences _localStorageDatabasePath]):
1506         (-[WebPreferences _setLocalStorageDatabasePath:]):
1507         (-[WebPreferences _ftpDirectoryTemplatePath]):
1508
1509 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
1510
1511         Reviewed by Alice Liu
1512
1513         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
1514
1515         * WebView/WebFrame.mm:
1516         (-[WebFrame _accessibilityTree]):
1517
1518 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1519         
1520         fix mac build
1521
1522         * WebView/WebView.mm:
1523         (-[WebView closeWithFastTeardown]):
1524
1525 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1526
1527         Reviewed by Anders.
1528
1529         Turn on fast teardown.  I added a preference for using full teardown because 
1530         the LEAKS output will be useless without a full teardown.  
1531
1532         preference for fullteardown
1533         * WebView/WebPreferenceKeysPrivate.h:
1534         * WebView/WebPreferences.m:
1535         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1536         (-[WebPreferences fullDocumentTeardownEnabled]):
1537         * WebView/WebPreferencesPrivate.h:
1538         
1539         on application quit dispatch unload events and destroy plugins then exit
1540         * WebView/WebView.mm:
1541         (-[WebView closeWithFastTeardown]):
1542         (-[WebView _close]):
1543         * WebView/WebViewPrivate.h:
1544
1545 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1546
1547         Reviewed by Anders.
1548
1549         get the pending frame unload count from WebCore
1550
1551         * WebView/WebFrame.mm:
1552         (-[WebFrame _pendingFrameUnloadEventCount]):
1553         * WebView/WebFramePrivate.h:
1554
1555 2008-05-15  John Sullivan  <sullivan@apple.com>
1556
1557         Reviewed by Kevin Decker
1558         
1559         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1560           screen when new tab appears
1561           
1562         The highlight should go away entirely, but this simple patch just makes it not jump away.
1563         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1564
1565         * WebInspector/WebNodeHighlight.m:
1566         (-[WebNodeHighlight _repositionHighlightWindow]):
1567         Bail out if target view isn't in a window
1568
1569 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1570
1571         Reviewed by Anders.
1572
1573         Track views that contain plugin instances so that they can be destroyed at application
1574         quit without walking the entire document tree.
1575
1576         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1577         plugins are created and destroyed
1578         * Plugins/WebBaseNetscapePluginView.mm:
1579         (-[WebBaseNetscapePluginView start]):
1580         (-[WebBaseNetscapePluginView stop]):
1581  
1582         Add/remove WebKit plugin views from instance list
1583         * Plugins/WebPluginController.mm:
1584         (-[WebPluginController addPlugin:]):
1585         (-[WebPluginController destroyPlugin:]):
1586         (-[WebPluginController destroyAllPlugins]):
1587
1588         Add a set of views with plugin instances to the WebPluginDatabase
1589         * Plugins/WebPluginDatabase.h:
1590         * Plugins/WebPluginDatabase.mm:
1591         (-[WebPluginDatabase init]):
1592         (-[WebPluginDatabase dealloc]):
1593         (-[WebPluginDatabase addPluginInstanceView:]):
1594         (-[WebPluginDatabase removePluginInstanceView:]):
1595         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1596         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1597         
1598         Handle cases where plugin views are detached before the plugin is destroyed.
1599         * WebCoreSupport/WebFrameLoaderClient.mm:
1600         (WebFrameLoaderClient::detachedFromParent2):
1601         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1602         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1603
1604         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1605         * WebView/WebHTMLView.mm:
1606         (-[WebHTMLView _destroyAllWebPlugins]):
1607         * WebView/WebHTMLViewInternal.h:
1608         * WebView/WebView.mm:
1609         (-[WebView addPluginInstanceView:]):
1610         (-[WebView removePluginInstanceView:]):
1611         (-[WebView removePluginInstanceViewsFor:]):
1612         * WebView/WebViewInternal.h:
1613
1614 2008-05-15  Brady Eidson  <beidson@apple.com>
1615
1616         Reviewed by Tim Hatcher
1617
1618         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1619         before setting the page group of the new page.
1620         
1621         * WebView/WebView.mm:
1622         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1623           immediately after creating the page so it is in place for initializing the LocalStorageThread
1624
1625 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1626
1627         Fixes the bug where the Web Inspector would flash white while resizing.
1628         This was cause by deferring the window creation.
1629
1630         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1631
1632         Reviewed by Darin Adler.
1633
1634         * WebCoreSupport/WebInspectorClient.mm:
1635         (-[WebInspectorWindowController window]): Don't defer the window creation.
1636
1637 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1638
1639         Tiger build fix.
1640
1641         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1642
1643 2008-05-15  Adele Peterson  <adele@apple.com>
1644
1645         Reviewed and landed by Alexey.
1646
1647         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1648
1649         * Misc/WebNSAttributedStringExtras.mm:
1650         (+[NSAttributedString _web_attributedStringFromRange:]):
1651
1652 2008-05-14  Eric Seidel  <eric@webkit.org>
1653
1654         Reviewed by Oliver.
1655
1656         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1657
1658         * WebView/WebResource.mm:
1659         (-[WebResource data]):
1660
1661 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1662
1663         Reviewed by Dan Bernstein.
1664
1665         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1666
1667         * Plugins/nptextinput.h:
1668
1669 2008-05-13  Anders Carlsson  <andersca@apple.com>
1670
1671         Reviewed by Sam.
1672
1673         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1674         Instead, do it in [WebCache empty].
1675         
1676         * Misc/WebCache.mm:
1677         (+[WebCache empty]):
1678         * WebView/WebView.mm:
1679         (+[WebView _setCacheModel:]):
1680
1681 2008-05-13  chris fleizach  <cfleizach@apple.com>
1682
1683         Reviewed by Beth Dakin
1684
1685         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1686
1687         * WebCoreSupport/WebViewFactory.mm:
1688         (-[WebViewFactory AXWebAreaText]):
1689
1690 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1691
1692         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1693         was referencing a nil WebView under validateUserInterfaceItem.
1694         The validateUserInterfaceItem methods was being called at a time
1695         when the WebHTMLView is being torndown.
1696
1697         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1698         while mousing down on menu bar after Xcode News window is opened
1699
1700         Reviewed by Ada Chan.
1701
1702         * WebView/WebHTMLView.mm:
1703         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1704         return NO when it is nil. Adds a comment.
1705         * WebView/WebPDFView.mm:
1706         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1707
1708 2008-05-13  Mark Rowe  <mrowe@apple.com>
1709
1710         Reviewed by John Sullivan.
1711
1712         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1713
1714         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1715         * Carbon/HIWebView.m: Ditto.
1716         (HIWebViewCreate):
1717         (HIWebViewConstructor):
1718
1719 2008-05-12  Dan Bernstein  <mitz@apple.com>
1720
1721         Reviewed by Ada Chan.
1722
1723         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1724           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1725
1726         Added font cache statistics and a function to purge inactive font data.
1727
1728         * Misc/WebCoreStatistics.h:
1729         * Misc/WebCoreStatistics.mm:
1730         (+[WebCoreStatistics cachedFontDataCount]):
1731         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1732         (+[WebCoreStatistics purgeInactiveFontData]):
1733         (+[WebCoreStatistics glyphPageCount]):
1734
1735 2008-05-12  Mark Rowe  <mrowe@apple.com>
1736
1737         Reviewed by Tim Hatcher.
1738
1739         Decorate some deprecated delegate methods with the availability macros.
1740
1741         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1742         macros is good for consistency and documentation.
1743
1744         * WebView/WebFrameLoadDelegate.h:
1745         * WebView/WebUIDelegate.h:
1746
1747 2008-05-12  Mark Rowe  <mrowe@apple.com>
1748
1749         Reviewed by Tim Hatcher.
1750
1751         <rdar://problem/5835604> Deprecate HIWebView
1752
1753         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1754
1755         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1756         * Carbon/HIWebView.h: Ditto.
1757
1758 2008-05-12  Kevin Decker  <kdecker@apple.com>
1759
1760         Reviewed by Anders.
1761
1762         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1763         
1764         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
1765         in changeset <http://trac.webkit.org/changeset/31028>
1766         
1767         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
1768         * WebView/WebFrame.mm:
1769         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
1770         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
1771         * WebView/WebFrameInternal.h: Ditto.
1772         * WebView/WebHTMLView.mm: Ditto.
1773         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
1774         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1775         * WebView/WebHTMLViewInternal.h: Ditto.
1776         * WebView/WebHTMLViewPrivate.h: Ditto.
1777
1778 2008-05-12  Anders Carlsson  <andersca@apple.com>
1779
1780         Reviewed by Alexey.
1781
1782         Empty the application cache when changing the cache model.
1783         
1784         * WebView/WebView.mm:
1785         (+[WebView _setCacheModel:]):
1786
1787 2008-05-12  Anders Carlsson  <andersca@apple.com>
1788
1789         Reviewed by Oliver.
1790
1791         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
1792         
1793         * Plugins/WebBaseNetscapePluginView.h:
1794         * Plugins/WebBaseNetscapePluginView.mm:
1795         (-[WebBaseNetscapePluginView start]):
1796         Get the plug-in text input vtable pointer.
1797         
1798         (-[WebBaseNetscapePluginView stop]):
1799         Set the plug-in text input vtable pointer to 0.
1800         
1801         (-[WebBaseNetscapePluginView inputContext]):
1802         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
1803         
1804         (-[WebBaseNetscapePluginView hasMarkedText]):        
1805         (-[WebBaseNetscapePluginView insertText:]):
1806         (-[WebBaseNetscapePluginView markedRange]):
1807         (-[WebBaseNetscapePluginView selectedRange]):
1808         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
1809         (-[WebBaseNetscapePluginView unmarkText]):
1810         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
1811         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
1812         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
1813         (-[WebBaseNetscapePluginView doCommandBySelector:]):
1814         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
1815         (-[WebBaseNetscapePluginView conversationIdentifier]):
1816         Implement NSTextInput and call into the plug-in text input vtable.
1817         
1818         (browserTextInputFuncs):
1819         New method which returns the browser input vtable.
1820         
1821         (-[WebBaseNetscapePluginView getVariable:value:]):
1822         Support getting the browser input vtable pointer.
1823         
1824         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1825         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1826         (WebNetscapePluginEventHandlerCocoa::keyDown):
1827         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1828         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
1829         it means that the event should be passed on to the input manager.
1830          
1831         * Plugins/npapi.mm:
1832         (NPN_MarkedTextAbandoned):
1833         (NPN_MarkedTextSelectionChanged):
1834         Add implementations of browser input method methods.
1835         
1836         * Plugins/nptextinput.h: Added.
1837         Add file with new text input API.
1838
1839 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
1840
1841         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
1842         SquirrelFish merging.
1843
1844         * Misc/WebCoreStatistics.mm:
1845         (+[WebCoreStatistics javaScriptObjectsCount]):
1846         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1847         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1848         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1849         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1850         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1851         * WebView/WebScriptDebugDelegate.mm:
1852         (-[WebScriptCallFrame evaluateWebScript:]):
1853
1854 2008-05-07  Anders Carlsson  <andersca@apple.com>
1855
1856         Reviewed by Mitz.
1857
1858         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
1859         https://bugs.webkit.org/show_bug.cgi?id=18880
1860         <rdar://problem/5909513>
1861
1862         Stop suspending key up events before calling handleEvent.
1863         
1864         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1865         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1866
1867 2008-05-06  Stephanie Lewis  <slewis@apple.com>
1868
1869         Reviewed by Andersca.
1870
1871         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
1872
1873         * Plugins/WebPluginDatabase.m: Removed.
1874         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
1875         * Plugins/npapi.m: Removed.
1876         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
1877
1878 2008-05-06  Anders Carlsson  <andersca@apple.com>
1879
1880         Reviewed by Darin.
1881
1882         Initialize numArchs to 0.
1883         
1884         * Plugins/WebBasePluginPackage.m:
1885         (-[WebBasePluginPackage isNativeLibraryData:]):
1886
1887 2008-05-06  Anders Carlsson  <andersca@apple.com>
1888
1889         Reviewed by Darin.
1890
1891         Add implementation of NPN_PopUpContextMenu.
1892         
1893         * Plugins/WebBaseNetscapePluginView.mm:
1894         (-[WebBaseNetscapePluginView popUpContextMenu:]):
1895         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1896         * Plugins/WebNetscapePluginPackage.m:
1897         (-[WebNetscapePluginPackage load]):
1898         * Plugins/npapi.m:
1899         (NPN_PopUpContextMenu):
1900
1901 2008-05-06  Anders Carlsson  <andersca@apple.com>
1902
1903         Fix typo (don't read random memory).
1904         
1905         * Plugins/WebBasePluginPackage.m:
1906         (-[WebBasePluginPackage isNativeLibraryData:]):
1907
1908 2008-05-05  Anders Carlsson  <andersca@apple.com>
1909
1910         Reviewed by Darin.
1911
1912         Change the isNativeLibraryData: method to handle universal binaries.
1913         
1914         * Plugins/WebBasePluginPackage.m:
1915         (swapIntsInHeader):
1916         (-[WebBasePluginPackage isNativeLibraryData:]):
1917
1918 2008-05-06  Brady Eidson  <beidson@apple.com>
1919
1920         Reviewed by Darin Adler
1921
1922         Preparation for upcoming work making LocalStorage persistent.
1923
1924         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
1925
1926         * WebView/WebView.mm:
1927         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
1928
1929 2008-05-05  Sam Weinig  <sam@webkit.org>
1930
1931         Reviewed by Darin Adler.
1932
1933         Fix for <rdar://problem/5884383>
1934         Escape look-a-like characters from the the entire url.
1935
1936         * Misc/WebNSURLExtras.mm:
1937         (escapeUnsafeCharacters):
1938         (-[NSURL _web_userVisibleString]):
1939
1940 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
1941
1942         Reviewed by Darin.
1943         
1944         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
1945
1946         * WebView/WebView.mm:
1947         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
1948         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
1949         the two interfere.
1950
1951 2008-05-05  Sam Weinig  <sam@webkit.org>
1952
1953         Reviewed by Tim Hatcher.
1954
1955         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
1956
1957         * WebCoreSupport/WebInspectorClient.mm:
1958         (WebInspectorClient::localizedStringsURL):
1959
1960 2008-05-05  Anders Carlsson  <andersca@apple.com>
1961
1962         Reviewed by Jess.
1963
1964         Apparently preflighting can cause hangs for some reason. Revert this for now.
1965         
1966         * Plugins/WebNetscapePluginPackage.m:
1967         (-[WebNetscapePluginPackage _initWithPath:]):
1968         * Plugins/WebPluginPackage.m:
1969         (-[WebPluginPackage initWithPath:]):
1970
1971 2008-05-05  Darin Adler  <darin@apple.com>
1972
1973         Reviewed by Mitz.
1974
1975         - https://bugs.webkit.org/show_bug.cgi?id=18789
1976           fix some shouldCloseWithWindow edge cases
1977
1978         * WebView/WebView.mm:
1979         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
1980         NSWindowWillCloseNotification if the view was moved out of the window but still
1981         had that window set as the host window. Also make sure this function doesn't do
1982         anything if the WebView is already closed.
1983         (-[WebView setHostWindow:]): Ditto.
1984
1985 2008-05-04  David Kilzer  <ddkilzer@apple.com>
1986
1987         Make parameters match for WebChromeClient::addMessageToConsole()
1988
1989         Reviewed by John.
1990
1991         * WebCoreSupport/WebChromeClient.h:
1992         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
1993         to sourceURL to match implementation in WebChromeClient.mm.
1994
1995 2008-05-02  Anders Carlsson  <andersca@apple.com>
1996
1997         Reviewed by Mark.
1998
1999         Various Cocoa event model and 64-bit plug-in fixes.
2000         
2001         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2002         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2003         Set click count.
2004         
2005         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2006         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2007         Don't try to get the mouse location for keyboard events.
2008         
2009         * Plugins/WebPluginPackage.m:
2010         (-[WebPluginPackage initWithPath:]):
2011         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
2012
2013 2008-05-02  Anders Carlsson  <andersca@apple.com>
2014
2015         Reviewed by Sam.
2016
2017         The event union is now named.
2018         
2019         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2020         (WebNetscapePluginEventHandlerCocoa::drawRect):
2021         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2022         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2023         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2024         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
2025         (WebNetscapePluginEventHandlerCocoa::focusChanged):
2026
2027 2008-05-02  Anders Carlsson  <andersca@apple.com>
2028
2029         Reviewed by Mark.
2030
2031         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
2032         
2033         Call preflightAndReturnError on the bundle, which will check if any of the architectures
2034         in the bundle match the current architecture.
2035         
2036         * Plugins/WebNetscapePluginPackage.m:
2037         (-[WebNetscapePluginPackage _initWithPath:]):
2038
2039 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
2040
2041         Reviewed by Geoffrey Garen.
2042
2043         https://bugs.webkit.org/show_bug.cgi?id=18826
2044         Make JavaScript heap per-thread
2045
2046         * Misc/WebCoreStatistics.mm:
2047         (+[WebCoreStatistics javaScriptObjectsCount]):
2048         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2049         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2050         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2051         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2052         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2053         Replaced static Collector calls with calls to a current thread's instance.
2054
2055         * WebView/WebScriptDebugDelegate.mm:
2056         (-[WebScriptCallFrame evaluateWebScript:]):
2057         Pass ExecState to jsString().
2058
2059 2008-05-01  Anders Carlsson  <andersca@apple.com>
2060
2061         Reviewed by Mark.
2062
2063         64-bit NPAPI plugin build fixes.
2064         
2065         * Plugins/WebBaseNetscapePluginView.mm:
2066         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2067         (-[WebBaseNetscapePluginView updateAndSetWindow]):
2068         (-[WebBaseNetscapePluginView start]):
2069         (-[WebBaseNetscapePluginView windowBecameKey:]):
2070         * Plugins/WebNetscapeDeprecatedFunctions.c:
2071         * Plugins/WebNetscapeDeprecatedFunctions.h:
2072         * Plugins/WebNetscapePluginEventHandler.mm:
2073         (WebNetscapePluginEventHandler::create):
2074         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2075         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2076         * Plugins/WebPluginDatabase.m:
2077         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2078
2079 2008-05-01  Anders Carlsson  <andersca@apple.com>
2080
2081         Reviewed by Tim.
2082
2083         Remove duplicate npfunctions.h header from WebKit.
2084
2085         * MigrateHeaders.make:
2086         Migrate npfunctions.h
2087         
2088         * Plugins/npfunctions.h: Removed.
2089
2090 2008-05-01  Anders Carlsson  <andersca@apple.com>
2091
2092         Reviewed by John.
2093         
2094         Add null checks for the event handler.
2095         
2096         * Plugins/WebBaseNetscapePluginView.mm:
2097         (-[WebBaseNetscapePluginView stopTimers]):
2098         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2099
2100 2008-05-01  Anders Carlsson  <andersca@apple.com>
2101
2102         Fix 64-bit build.
2103         
2104         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
2105         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2106         * WebCoreSupport/WebFrameLoaderClient.mm:
2107
2108 2008-05-01  Anders Carlsson  <andersca@apple.com>
2109
2110         Fix build.
2111         
2112         * Plugins/npfunctions.h:
2113
2114 2008-05-01  Anders Carlsson  <andersca@apple.com>
2115
2116         Reviewed by Adam.
2117
2118         Forward mouse move events to the Netscape plug-in view.
2119         
2120         * Plugins/WebBaseNetscapePluginView.h:
2121         * Plugins/WebBaseNetscapePluginView.mm:
2122         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2123         New method that just calls the current event handler.
2124         
2125         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2126         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2127         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
2128         don't work on it so don't call them.
2129         
2130         * WebCoreSupport/WebFrameLoaderClient.mm:
2131         (NetscapePluginWidget::NetscapePluginWidget):
2132         New Widget subclass to be used for Netscape plug-ins.
2133         
2134         (NetscapePluginWidget::handleEvent):
2135         Forward NSMouseMoved events to the plug-in.
2136         
2137         (WebFrameLoaderClient::createPlugin):
2138         Wrap the plug-in view in a NetscapePluginWidget.
2139
2140 2008-05-01  Alp Toker  <alp@nuanti.com>
2141
2142         Rubber-stamped by Anders.
2143
2144         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
2145         npapi.h.
2146
2147         Additional fix to use same signedness in npapi.h and Mac for the
2148         interval parameter.
2149
2150         * Plugins/WebBaseNetscapePluginView.h:
2151         * Plugins/WebBaseNetscapePluginView.mm:
2152         (PluginTimer::PluginTimer):
2153         (-[WebBaseNetscapePluginView stopTimers]):
2154         (-[WebBaseNetscapePluginView restartTimers]):
2155         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2156         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2157         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2158         * Plugins/npapi.m:
2159         (NPN_ScheduleTimer):
2160         (NPN_UnscheduleTimer):
2161         * Plugins/npfunctions.h:
2162
2163 2008-04-30  Anders Carlsson  <andersca@apple.com>
2164
2165         Reviewed by Adam.
2166
2167         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
2168         
2169         * Plugins/WebBaseNetscapePluginView.h:
2170         * Plugins/WebBaseNetscapePluginView.mm:
2171         (PluginTimer::PluginTimer):
2172         (PluginTimer::start):
2173         (PluginTimer::fired):
2174         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2175         (-[WebBaseNetscapePluginView stopTimers]):
2176         (-[WebBaseNetscapePluginView restartTimers]):
2177         (-[WebBaseNetscapePluginView scrollWheel:]):
2178         (-[WebBaseNetscapePluginView flagsChanged:]):
2179         (-[WebBaseNetscapePluginView start]):
2180         (-[WebBaseNetscapePluginView eventModel]):
2181         (-[WebBaseNetscapePluginView fini]):
2182         (-[WebBaseNetscapePluginView getVariable:value:]):
2183         (-[WebBaseNetscapePluginView setVariable:value:]):
2184         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2185         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2186         * Plugins/WebBaseNetscapePluginViewInternal.h:
2187         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2188         * Plugins/WebNetscapePluginEventHandler.h:
2189         * Plugins/WebNetscapePluginEventHandler.mm:
2190         (WebNetscapePluginEventHandler::create):
2191         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2192         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2193         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
2194         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
2195         (WebNetscapePluginEventHandlerCarbon::platformWindow):
2196         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
2197         (WebNetscapePluginEventHandlerCocoa::startTimers):
2198         (WebNetscapePluginEventHandlerCocoa::stopTimers):
2199         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
2200         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
2201         (WebNetscapePluginEventHandlerCocoa::drawRect):
2202         (WebNetscapePluginEventHandlerCocoa::mouseDown):
2203         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
2204         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
2205         (WebNetscapePluginEventHandlerCocoa::mouseExited):
2206         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
2207         (WebNetscapePluginEventHandlerCocoa::mouseUp):
2208         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
2209         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2210         (WebNetscapePluginEventHandlerCocoa::keyDown):
2211         (WebNetscapePluginEventHandlerCocoa::keyUp):
2212         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2213         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2214         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
2215         (WebNetscapePluginEventHandlerCocoa::focusChanged):
2216         (WebNetscapePluginEventHandlerCocoa::platformWindow):
2217         (WebNetscapePluginEventHandlerCocoa::sendEvent):
2218         * Plugins/WebNetscapePluginPackage.m:
2219         (-[WebNetscapePluginPackage load]):
2220         * Plugins/npapi.m:
2221         (NPN_ScheduleTimer):
2222         (NPN_UnscheduleTimer):
2223         * Plugins/npfunctions.h:
2224
2225 2008-04-30  Brady Eidson  <beidson@apple.com>
2226
2227         Fix my WebPreferences revert check-in
2228
2229         * WebView/WebView.mm:
2230         (-[WebView _preferencesChangedNotification:]):
2231
2232 2008-04-30  Brady Eidson  <beidson@apple.com>
2233
2234         Rubberstamped by John Sullivan
2235
2236         Revert the remainder of my original preferences changes from last week.
2237         They caused a massive PLT regression (too many notifications being sent out
2238         or listened to that weren't previously) and it's not in my schedule to refine
2239         the preferences code instead of working on my feature!
2240
2241         * WebView/WebView.mm:
2242         (-[WebView _updateSettingsFromPreferences:]):
2243         (-[WebView _commonInitializationWithFrameName:groupName:]):
2244
2245 2008-04-30  Anders Carlsson  <andersca@apple.com>
2246
2247         Fix the 64-bit build.
2248         
2249         * Plugins/WebNetscapePluginEventHandler.h:
2250         * Plugins/WebNetscapePluginEventHandler.mm:
2251         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2252         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2253
2254 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
2255
2256         BUILD FIX for Release build.
2257
2258         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2259         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
2260         separately so the compiler doesn't complain about an unused variable.
2261         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
2262
2263 2008-04-29  Anders Carlsson  <andersca@apple.com>
2264
2265         Reviewed by Adam.
2266
2267         Refactor the Carbon event handling code out into a separate class in preparation for adding
2268         the Cocoa event handling code.
2269         
2270         * Plugins/WebBaseNetscapePluginView.h:
2271         * Plugins/WebBaseNetscapePluginView.mm:
2272         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
2273         (-[WebBaseNetscapePluginView sendActivateEvent:]):
2274         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
2275         (-[WebBaseNetscapePluginView stopTimers]):
2276         (-[WebBaseNetscapePluginView restartTimers]):
2277         (-[WebBaseNetscapePluginView setHasFocus:]):
2278         (-[WebBaseNetscapePluginView mouseDown:]):
2279         (-[WebBaseNetscapePluginView mouseUp:]):
2280         (-[WebBaseNetscapePluginView mouseEntered:]):
2281         (-[WebBaseNetscapePluginView mouseExited:]):
2282         (-[WebBaseNetscapePluginView mouseDragged:]):
2283         (-[WebBaseNetscapePluginView keyUp:]):
2284         (-[WebBaseNetscapePluginView keyDown:]):
2285         (-[WebBaseNetscapePluginView cut:]):
2286         (-[WebBaseNetscapePluginView copy:]):
2287         (-[WebBaseNetscapePluginView paste:]):
2288         (-[WebBaseNetscapePluginView selectAll:]):
2289         (-[WebBaseNetscapePluginView start]):
2290         (-[WebBaseNetscapePluginView stop]):
2291         (-[WebBaseNetscapePluginView fini]):
2292         (-[WebBaseNetscapePluginView drawRect:]):
2293         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
2294         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
2295         (-[WebBaseNetscapePluginView windowBecameKey:]):
2296         (-[WebBaseNetscapePluginView windowResignedKey:]):
2297         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
2298         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
2299         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
2300         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
2301         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2302         (-[WebBaseNetscapePluginView _viewHasMoved]):
2303         * Plugins/WebBaseNetscapePluginViewInternal.h:
2304         * Plugins/WebNetscapePluginEmbeddedView.h:
2305         * Plugins/WebNetscapePluginEventHandler.h: Added.
2306         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
2307         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
2308         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
2309         * Plugins/WebNetscapePluginEventHandler.mm: Added.
2310         (WebNetscapePluginEventHandler::create):
2311         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
2312         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
2313         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
2314         (getCarbonEvent):
2315         (modifiersForEvent):
2316         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
2317         (WebNetscapePluginEventHandlerCarbon::drawRect):
2318         (WebNetscapePluginEventHandlerCarbon::mouseDown):
2319         (WebNetscapePluginEventHandlerCarbon::mouseUp):
2320         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2321         (WebNetscapePluginEventHandlerCarbon::mouseExited):
2322         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
2323         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2324         (WebNetscapePluginEventHandlerCarbon::keyDown):
2325         (keyMessageForEvent):
2326         (WebNetscapePluginEventHandlerCarbon::keyUp):
2327         (WebNetscapePluginEventHandlerCarbon::focusChanged):
2328         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
2329         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
2330         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
2331         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
2332         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
2333         (WebNetscapePluginEventHandlerCarbon::startTimers):
2334         (WebNetscapePluginEventHandlerCarbon::stopTimers):
2335         (WebNetscapePluginEventHandlerCarbon::sendEvent):
2336
2337 2008-04-29  Mark Rowe  <mrowe@apple.com>
2338
2339         Reviewed by David Harrison.
2340
2341         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
2342
2343         * WebKit.exp:
2344         * WebView/WebDynamicScrollBarsView.h:
2345         * WebView/WebDynamicScrollBarsView.m:
2346
2347 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
2348
2349         Reviewed by Darin.
2350
2351         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
2352
2353         * WebCoreSupport/WebChromeClient.h:
2354         * WebCoreSupport/WebChromeClient.mm:
2355         * WebView/WebClipView.m:
2356         (-[WebClipView scrollWheel:]):
2357         * WebView/WebHTMLView.mm:
2358         (-[WebHTMLView addMouseMovedObserver]):
2359         (-[WebHTMLView removeMouseMovedObserver]):
2360         (-[WebHTMLView acceptsFirstMouse:]):
2361         * WebView/WebUIDelegatePrivate.h:
2362         * WebView/WebView.mm:
2363         (-[WebViewPrivate init]):
2364         * WebView/WebViewPrivate.h:
2365
2366 2008-04-28  Rob Buis  <buis@kde.org>
2367
2368         Reviewed by Maciej.
2369
2370         Build fix for Tiger.
2371
2372         * WebView/WebView.mm:
2373         (WebKitInitializeApplicationCachePathIfNecessary):
2374
2375 2008-04-28  Adele Peterson  <adele@apple.com>
2376
2377         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
2378
2379         WebKit part of fix for <rdar://problem/3709505>
2380         Safari should have a way to upload bundles from the file upload control (as zip)
2381
2382         Added UIDelegate methods to let the application handle generating replacement files for uploads.
2383         In this case, Safari will create archived files for bundles so they can be uploaded properly.
2384
2385         * DefaultDelegates/WebDefaultUIDelegate.m:
2386         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
2387         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
2388         * WebCoreSupport/WebChromeClient.h:
2389         * WebCoreSupport/WebChromeClient.mm:
2390         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
2391         (WebChromeClient::generateReplacementFile):
2392         * WebView/WebUIDelegatePrivate.h:
2393
2394 2008-04-28  Anders Carlsson  <andersca@apple.com>
2395
2396         Reviewed by Sam, Mark, Adele and Darin.
2397
2398         Initialize the application cache path.
2399         
2400         * WebView/WebView.mm:
2401         (WebKitInitializeApplicationCachePathIfNecessary):
2402         (-[WebView _commonInitializationWithFrameName:groupName:]):
2403
2404 2008-04-28  Alice Liu  <alice.liu@apple.com>
2405
2406         Reviewed by Darin.
2407
2408         Fix <rdar://problem/4911289> Add tabindex property to all children 
2409         of HTMLElement (7138)
2410         http://bugs.webkit.org/show_bug.cgi?id=7138
2411
2412         * MigrateHeaders.make:
2413         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
2414         because now that focus() has been moved to DOMHTMLElement.h, these
2415         files are no longer needed.
2416
2417 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2418
2419         Reviewed by Darin.
2420
2421         Fix run-webkit-tests --threading
2422         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
2423         Proxy server issue in Sunday's Nightly
2424
2425         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
2426         only done from icon database code, which is not robust enough.
2427
2428 2008-04-20 Adam Barth <hk9565@gmail.com>
2429
2430         Reviewed by Adam Roben and Sam Weinig.
2431
2432         Updated WebSecurityOrigin to match new SecurityOrigin API.
2433
2434         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
2435
2436         * Storage/WebSecurityOrigin.mm:
2437         (-[WebSecurityOrigin host]):
2438         (-[WebSecurityOrigin domain]):
2439         * Storage/WebSecurityOriginPrivate.h:
2440
2441 2008-04-25  Mark Rowe  <mrowe@apple.com>
2442
2443         Rubber-stamped by Sam Weinig.
2444
2445         Add some content to an empty ICU header file to prevent verification errors.
2446
2447         * icu/unicode/utf_old.h:
2448
2449 2008-04-25  Anders Carlsson  <andersca@apple.com>
2450
2451         Reviewed by Sam.
2452
2453         Add offlineWebApplicationCacheEnabled preference.
2454         
2455         * WebView/WebPreferenceKeysPrivate.h:
2456         * WebView/WebPreferences.m:
2457         (+[WebPreferences initialize]):
2458         (-[WebPreferences offlineWebApplicationCacheEnabled]):
2459         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
2460         * WebView/WebPreferencesPrivate.h:
2461         * WebView/WebView.mm:
2462         (-[WebView _updateSettingsFromPreferences:]):
2463
2464 2008-04-24  Mark Rowe  <mrowe@apple.com>
2465
2466         Reviewed by Sam Weinig.
2467
2468         Remove code for calculating the glyph cache size.
2469
2470         * WebCoreSupport/WebSystemInterface.m:
2471         (InitWebCoreSystemInterface): Remove unused symbol.
2472
2473 2008-04-24  Mark Rowe  <mrowe@apple.com>
2474
2475         Reviewed by Sam Weinig.
2476
2477         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
2478
2479         * WebKitPrefix.h:
2480
2481 2008-04-24  Brady Eidson  <beidson@apple.com>
2482
2483         Reviewed by Darin
2484
2485         Fix layout test regressions from my earlier preferences/settings tweak.
2486
2487         * WebView/WebView.mm:
2488         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
2489           the notification to update the settings, each WebView still needs to register for the
2490           notification - restore that behavior.
2491
2492 2008-04-24  Dan Bernstein  <mitz@apple.com>
2493
2494         Reviewed by Darin Adler.
2495
2496         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
2497           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
2498
2499         * WebView/WebFrame.mm:
2500         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
2501         VisiblePosition::caretRect() instead of the RenderObject method which
2502         was removed.
2503
2504 2008-04-24  Brady Eidson  <beidson@apple.com>
2505
2506         Reviewed by Darin
2507
2508         Rework the Settings population again.
2509
2510         * WebView/WebView.mm:
2511         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
2512           and directly from WebView's common init function.
2513         (-[WebView _preferencesChangedNotification:]):
2514         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
2515           after creating the new Page
2516
2517 2008-04-24  Darin Adler  <darin@apple.com>
2518
2519         Reviewed by Geoff.
2520
2521         - fix crash in regression test where we'd ask a frame for a user agent string
2522           after the WebView was already closed
2523
2524         * WebCoreSupport/WebFrameLoaderClient.mm:
2525         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2526         added some code to prevent the crash in release builds if this problem happens
2527         again.
2528
2529 2008-04-24  Anders Carlsson  <andersca@apple.com>
2530
2531         Reviewed by Sam.
2532
2533         Change some String arguments to be const references instead.
2534
2535         * WebCoreSupport/WebEditorClient.h:
2536         * WebCoreSupport/WebEditorClient.mm:
2537         (WebEditorClient::shouldInsertText):
2538
2539 2008-04-24  John Sullivan  <sullivan@apple.com>
2540
2541         Mac build fix
2542         
2543         * WebCoreSupport/WebViewFactory.mm:
2544         (-[WebViewFactory AXButtonActionVerb]):
2545         implement this method using the text in WebCoreLocalizedStrings.cpp
2546         (-[WebViewFactory AXRadioButtonActionVerb]):
2547         ditto
2548         (-[WebViewFactory AXTextFieldActionVerb]):
2549         ditto
2550         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2551         ditto
2552         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2553         ditto
2554         (-[WebViewFactory AXLinkActionVerb]):
2555         ditto
2556
2557 2008-04-23  Brady Eidson  <beidson@apple.com>
2558
2559         Reviewed by Sam Weinig
2560
2561         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2562         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2563         thereby populating the Settings object, immediately after the Page is created.
2564
2565         * WebView/WebView.mm:
2566         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2567
2568 2008-04-24  John Sullivan  <sullivan@apple.com>
2569
2570         Reviewed by Jess
2571         
2572         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2573
2574         * Misc/WebNSControlExtras.m:
2575         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2576         deploy userSpaceScaleFactor when using view distances on the window
2577
2578 2008-04-22  Anders Carlsson  <andersca@apple.com>
2579
2580         Reviewed by Darin.
2581
2582         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2583         
2584         * Plugins/npfunctions.h:
2585
2586 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2587
2588         Mysteriously reviewed by mitz|away.
2589
2590         Bug 18111: Closing a tab while dragging crashes Safari
2591         https://bugs.webkit.org/show_bug.cgi?id=18111
2592
2593         Null check the page before handling drag events.
2594
2595         * WebView/WebView.mm:
2596         (-[WebView draggingUpdated:]):
2597         (-[WebView draggingExited:]):
2598
2599 2008-04-19  Brady Eidson  <beidson@apple.com>
2600
2601         Reviewed by Tim Hatcher
2602
2603         Add a WebPreference for the path of the local storage persistent store.
2604
2605         * WebView/WebPreferenceKeysPrivate.h:
2606
2607         * WebView/WebPreferences.m:
2608         (-[WebPreferences _localStorageDatabasePath]):
2609         (-[WebPreferences _setLocalStorageDatabasePath:]):
2610         * WebView/WebPreferencesPrivate.h:
2611
2612         * WebView/WebView.mm:
2613         (-[WebView _preferencesChangedNotification:]):
2614
2615 2008-04-18  Brady Eidson  <beidson@apple.com>
2616
2617         Reviewed by Sam Weinig
2618
2619         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2620         No reason to do the work twice...
2621
2622         * WebView/WebView.mm:
2623         (-[WebView _close]):
2624
2625 2008-04-17  Eric Seidel  <eric@webkit.org>
2626
2627         Reviewed by beth.
2628
2629         Rename Frame::renderer() to contentRenderer() and fix uses.
2630
2631         * Misc/WebCoreStatistics.mm:
2632         * WebView/WebRenderNode.mm:
2633         (-[WebRenderNode initWithWebFrameView:]):
2634
2635 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2636
2637         Reviewed by mrowe.
2638
2639         * WebView/WebFrame.mm: Remove temporary build fix.
2640
2641 2008-04-17  Mark Rowe  <mrowe@apple.com>
2642
2643         Reviewed by Dan Bernstein.
2644
2645         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2646
2647         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2648
2649         * WebCoreSupport/WebFrameLoaderClient.mm:
2650         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2651
2652 2008-04-17  Mark Rowe  <mrowe@apple.com>
2653
2654         Rubber-stamped by Dan Bernstein.
2655
2656         Fix the Mac build.
2657
2658         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2659         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2660         for this to live going forward.
2661
2662 2008-04-15  Kevin Decker  <kdecker@apple.com>
2663
2664         Reviewed by Anders.
2665
2666         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2667         
2668         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2669         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2670         a bundle out from underneath itself.
2671
2672         * Plugins/WebBasePluginPackage.h: Added unload method.
2673         * Plugins/WebBasePluginPackage.m:
2674         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2675         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2676         * Plugins/WebNetscapePluginPackage.m:
2677         (-[WebNetscapePluginPackage unload]): Added.
2678
2679 2008-04-15  Anders Carlsson  <andersca@apple.com>
2680
2681         Reviewed by Adam.
2682
2683         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2684
2685         * Configurations/WebKit.xcconfig:
2686
2687 2008-04-15  Brady Eidson  <beidson@apple.com>
2688
2689         Reviewed by John Sullivan
2690
2691         Do a more complete job adding the "WebArchiveDebugMode" pref
2692
2693         * WebView/WebPreferences.m: Add both getter *and* setter
2694         (-[WebPreferences webArchiveDebugModeEnabled]):
2695         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2696         * WebView/WebPreferencesPrivate.h:
2697
2698         * WebView/WebView.mm:
2699         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2700
2701 2008-04-14  Brady Eidson  <beidson@apple.com>
2702
2703         Reviewed by Anders
2704
2705         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2706         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2707         network and will instead fail the load as "cancelled."
2708
2709         * WebView/WebPreferenceKeysPrivate.h:
2710
2711         * WebView/WebPreferences.m:
2712         (+[WebPreferences initialize]):
2713         (-[WebPreferences _webArchiveDebugModeEnabled]):
2714         * WebView/WebPreferencesPrivate.h:
2715
2716         * WebView/WebView.mm:
2717         (-[WebView _preferencesChangedNotification:]):
2718
2719 2008-04-11  David Hyatt  <hyatt@apple.com>
2720
2721         Rename CachedResource ref/deref methods to addClient/removeClient.
2722
2723         Reviewed by olliej
2724
2725         * WebView/WebHTMLView.mm:
2726         (-[WebHTMLViewPrivate dealloc]):
2727         (-[WebHTMLViewPrivate finalize]):
2728         (-[WebHTMLViewPrivate clear]):
2729         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2730
2731 2008-04-07  Brady Eidson  <beidson@apple.com>
2732
2733         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2734
2735         * Configurations/WebKit.xcconfig:
2736
2737 2008-04-04  Adam Roben  <aroben@apple.com>
2738
2739         Use WebCore's ICU headers instead of our own copy
2740
2741         Rubberstamped by Tim Hatcher.
2742
2743         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2744         PrivateHeaders.
2745
2746 2008-04-04  Adam Roben  <aroben@apple.com>
2747
2748         Fix <rdar://problem/5804776> Would like to use WebCore's
2749         ForwardingHeaders in WebKit without manually creating copies
2750
2751         Patch by Tim Hatcher, typed by me.
2752
2753         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2754         WebCore's PrivateHeaders instead of our own copy.
2755
2756 2008-04-04  Ada Chan  <adachan@apple.com>
2757
2758         Now we pass width and height directly as integers to format
2759         the window title for a standalone image.
2760
2761         Reviewed by Dan.
2762
2763         * WebCoreSupport/WebViewFactory.mm:
2764         (-[WebViewFactory imageTitleForFilename:width:height:]):
2765
2766 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
2767
2768         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
2769
2770         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
2771           font-weight does not properly support graded weights
2772
2773         * WebView/WebHTMLView.mm:
2774         (-[WebHTMLView _styleFromFontAttributes:]):
2775         (-[WebHTMLView _originalFontB]):
2776         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2777
2778 2008-04-02  Mark Rowe  <mrowe@apple.com>
2779
2780         Reviewed by Oliver Hunt.
2781
2782         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
2783
2784         * Configurations/Base.xcconfig:
2785
2786 2008-03-31  Alice Liu  <alice.liu@apple.com>
2787
2788         Reviewed by Darin.
2789
2790         * WebView/WebFrame.mm:
2791         (-[WebFrame _accessibilityTree]):
2792         The syntax for fetching an object from the AXObjectCache changed slightly
2793
2794 2008-03-31  Brady Eidson  <beidson@apple.com>
2795
2796         Reviewed by Jon Honeycutt
2797         
2798         Move a WebArchive loading check into WebCore
2799
2800         * WebView/WebHTMLRepresentation.mm:
2801         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
2802           responsible for checking that state
2803
2804 2008-03-31  Brady Eidson  <beidson@apple.com>
2805
2806         Reviewed by Darin and Mitz's rubber stamp
2807
2808         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2809
2810         * WebCoreSupport/WebEditorClient.mm:
2811         * WebCoreSupport/WebEditorClient.h:
2812
2813 2008-03-28  Brady Eidson  <beidson@apple.com>
2814
2815         Rubberstamped by Darin Adler
2816
2817         Remove WebArchiver.h/mm
2818
2819         * WebView/WebArchiver.h: Removed.
2820         * WebView/WebArchiver.mm: Removed.
2821
2822         * DOM/WebDOMOperations.mm:
2823         * WebCoreSupport/WebDragClient.mm:
2824         * WebCoreSupport/WebEditorClient.mm:
2825         * WebView/WebDataSource.mm:
2826         * WebView/WebHTMLView.mm:
2827
2828 2008-03-28  Brady Eidson  <beidson@apple.com>
2829
2830         Reviewed by Darin Adler
2831
2832         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
2833
2834         * WebCoreSupport/WebEditorClient.mm:
2835         (WebEditorClient::dataForArchivedSelection):
2836
2837         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
2838         * WebView/WebArchiver.mm: Ditto
2839
2840         * WebView/WebHTMLView.mm:
2841         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2842
2843 2008-03-28  Brady Eidson  <beidson@apple.com>
2844
2845         Reviewed by Darin Adler
2846
2847         More Kit->Core WebArchive changes.
2848
2849         Create an archive from the current selection in a frame
2850
2851         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
2852           easily in a followup
2853
2854 2008-03-28  Brady Eidson  <beidson@apple.com>
2855
2856         Reviewed by Sam Weinig
2857
2858         WebArchive saga continues - Can now make archives from ranges in WebCore
2859
2860         * DOM/WebDOMOperations.mm:
2861         (-[DOMRange webArchive]):
2862         (-[DOMRange markupString]):
2863
2864         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
2865         * WebView/WebArchiver.mm:
2866
2867 2008-03-28  Brady Eidson  <beidson@apple.com>
2868
2869         Reviewed by Sam Weinig
2870
2871         More Kit->Core webarchive code movement
2872
2873         * DOM/WebDOMOperations.mm:
2874         (-[DOMNode markupString]): Call createFullMarkup() instead
2875
2876         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
2877         * WebView/WebFrameInternal.h: Ditto
2878
2879 2008-03-28  Brady Eidson  <beidson@apple.com>
2880
2881         Reviewed by Sam Weinig
2882
2883         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
2884
2885         * WebView/WebArchiver.h:
2886         * WebView/WebArchiver.mm:
2887         * WebView/WebDataSource.mm:
2888         (-[WebDataSource webArchive]):
2889
2890 2008-03-28  Brady Eidson  <beidson@apple.com>
2891
2892         Reviewed by Sam Weinig
2893
2894         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
2895
2896         * WebView/WebArchiver.h:
2897         * WebView/WebArchiver.mm:
2898
2899 2008-03-28  Brady Eidson  <beidson@apple.com>
2900
2901         Reviewed by Darin
2902
2903         "Yet another transitional step" to empty out WebKit-based code for archiving.
2904
2905         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2906         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2907
2908         * DOM/WebDOMOperations.mm:
2909         * WebView/WebArchiver.mm:
2910         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2911
2912 2008-03-27  Brady Eidson  <beidson@apple.com>
2913
2914         Reviewed by Adam Roben
2915
2916         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
2917         as the push to core-ify WebArchives continues.
2918
2919         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
2920         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
2921         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
2922         (as in "while archiving a page") are accepting of null or empty data.
2923
2924         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
2925
2926         * WebView/WebDataSource.mm:
2927         (-[WebDataSource mainResource]): Call DocumentLoader implementation
2928         (-[WebDataSource subresources]): Ditto
2929         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
2930         * WebView/WebFrameInternal.h:
2931
2932 2008-03-27  Brady Eidson  <beidson@apple.com>
2933
2934         Reviewed by Adam
2935
2936         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
2937         (more efficient)
2938
2939         * WebView/WebResource.mm:
2940         (-[WebResource _initWithCoreResource:]):
2941         * WebView/WebResourceInternal.h:
2942
2943 2008-03-26  Brady Eidson  <beidson@apple.com>
2944
2945         Build fix - accidentally checked in this change which was work in progress
2946
2947         * DOM/WebDOMOperations.mm:
2948
2949 2008-03-26  Brady Eidson  <beidson@apple.com>
2950
2951         Reviewed by Darin
2952
2953         When we create a WebArchive, we walk every node from some starting point, asking each node
2954         along the way "What are your subresource URLs?"
2955
2956         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
2957         WebCore::Node
2958
2959         * DOM/WebDOMOperations.mm:
2960         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
2961           calling into individual WebCore::Node implementations
2962         * DOM/WebDOMOperationsPrivate.h:
2963
2964 2008-03-26  Brady Eidson  <beidson@apple.com>
2965
2966         Reviewed by Mark Rowe
2967
2968         Part of the continued push to move WebArchive-related code down to WebCore, this
2969         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
2970
2971         * WebView/WebDataSource.mm:
2972         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
2973
2974         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
2975           has now been ported down to WebCore
2976         * WebView/WebFrameInternal.h:
2977
2978 2008-03-26  Mark Rowe  <mrowe@apple.com>
2979
2980         Rubber-stamped by Brady Eidson.
2981
2982         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
2983
2984         * Configurations/WebKit.xcconfig:
2985
2986 2008-03-26  Mark Rowe  <mrowe@apple.com>
2987
2988         Reviewed by David Hyatt.
2989
2990         Make the Ahem font antialias correctly on Acid3 on Tiger.
2991
2992         * WebCoreSupport/WebSystemInterface.m:
2993         (InitWebCoreSystemInterface):
2994
2995 2008-03-26  Mark Rowe  <mrowe@apple.com>
2996
2997         Fix the Mac build.
2998
2999         * MigrateHeaders.make: Copy the newly generated header into the right place.
3000
3001 2008-03-25  Brady Eidson  <beidson@apple.com>
3002
3003         Reviewed by Beth Dakin
3004
3005         Remove entirely unused internal method
3006
3007         * WebView/WebArchiver.h:
3008         * WebView/WebArchiver.mm:
3009
3010 2008-03-25  Brady Eidson  <beidson@apple.com>
3011
3012         Reviewed by Adam Roben
3013
3014         <rdar://problem/5819308> - View Source is empty when view webarchives
3015
3016         * WebCore.base.exp:
3017         * loader/DocumentLoader.cpp:
3018         (WebCore::DocumentLoader::setParsedArchiveData):
3019         (WebCore::DocumentLoader::parsedArchiveData):
3020         * loader/DocumentLoader.h:
3021
3022         * loader/FrameLoader.cpp:
3023         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
3024           in the DocumentLoader
3025
3026 2008-03-25  Dan Bernstein  <mitz@apple.com>
3027
3028         Reviewed by Darin Adler.
3029
3030         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
3031           Reopen All Windows From Last Session causes crash
3032
3033         * WebView/WebHTMLView.mm:
3034         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
3035         check.
3036
3037 2008-03-25  Brady Eidson  <beidson@apple.com>
3038
3039         Reviewed by Jon Honeycutt's rubberstamp
3040
3041         Fix a leak with the new WebArchive setup
3042
3043         * WebView/WebArchive.mm:
3044         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
3045
3046 2008-03-25  Brady Eidson  <beidson@apple.com>
3047
3048         Reviewed by Darin
3049
3050         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
3051         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
3052
3053         * WebCoreSupport/WebFrameLoaderClient.h:
3054         * WebCoreSupport/WebFrameLoaderClient.mm:
3055         (WebFrameLoaderClient::WebFrameLoaderClient):
3056
3057 2008-03-25  Brady Eidson  <beidson@apple.com>
3058
3059         Reviewed by Darin
3060
3061         Remove newly obsolete FrameLoaderClient methods
3062
3063         * WebCoreSupport/WebFrameLoaderClient.h:
3064         * WebCoreSupport/WebFrameLoaderClient.mm:
3065
3066 2008-03-25  Brady Eidson  <beidson@apple.com>
3067
3068         Release build fix
3069
3070         * WebView/WebArchive.mm:
3071         (-[WebArchive subresources]):
3072         (-[WebArchive subframeArchives]):
3073
3074 2008-03-25  Brady Eidson  <beidson@apple.com>
3075
3076         Reviewed by Darin
3077
3078         <rdar://problem/4516169> - Support WebArchives on Windows
3079         And paves the way for many future WebArchive bug fixes and enhancements
3080
3081         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
3082         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
3083          * WebArchive <-> LegacyWebArchive
3084          * WebResource <-> ArchiveResource
3085          * WebUnarchivingState <-> ArchiveResourceCollection
3086  
3087         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
3088         and now exist in WebCore
3089
3090         * WebCoreSupport/WebFrameLoaderClient.mm:
3091         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
3092         (WebFrameLoaderClient::finalSetupForReplace):
3093         (WebFrameLoaderClient::setDefersLoading):
3094         (WebFrameLoaderClient::willUseArchive):
3095         (WebFrameLoaderClient::isArchiveLoadPending):
3096         (WebFrameLoaderClient::cancelPendingArchiveLoad):
3097         (WebFrameLoaderClient::clearArchivedResources):
3098         (WebFrameLoaderClient::createFrame):
3099
3100         * WebView/WebArchive.mm:
3101         (+[WebArchivePrivate initialize]):
3102         (-[WebArchivePrivate init]):
3103         (-[WebArchivePrivate initWithCoreArchive:]):
3104         (-[WebArchivePrivate coreArchive]):
3105         (-[WebArchivePrivate setCoreArchive:]):
3106         (-[WebArchivePrivate dealloc]):
3107         (-[WebArchivePrivate finalize]):
3108         (-[WebArchive init]):
3109         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
3110         (-[WebArchive initWithData:]):
3111         (-[WebArchive initWithCoder:]):
3112         (-[WebArchive encodeWithCoder:]):
3113         (-[WebArchive mainResource]):
3114         (-[WebArchive subresources]):
3115         (-[WebArchive subframeArchives]):
3116         (-[WebArchive data]):
3117         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
3118         (-[WebArchive WebCore::]):
3119         * WebView/WebArchiveInternal.h: Added.
3120
3121         * WebView/WebDataSource.mm:
3122         (-[WebDataSourcePrivate dealloc]):
3123         (-[WebDataSource _addSubframeArchives:]):
3124         (-[WebDataSource _documentFragmentWithArchive:]):
3125         (-[WebDataSource subresourceForURL:]):
3126         (-[WebDataSource addSubresource:]):
3127         * WebView/WebDataSourceInternal.h:
3128
3129         * WebView/WebFrame.mm:
3130         (-[WebFrame loadArchive:]):
3131         * WebView/WebFrameInternal.h:
3132
3133         * WebView/WebHTMLRepresentation.mm:
3134         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3135
3136         * WebView/WebResource.mm:
3137         (+[WebResourcePrivate initialize]):
3138         (-[WebResourcePrivate init]):
3139         (-[WebResourcePrivate initWithCoreResource:]):
3140         (-[WebResourcePrivate dealloc]):
3141         (-[WebResourcePrivate finalize]):
3142         (-[WebResource initWithCoder:]):
3143         (-[WebResource encodeWithCoder:]):
3144         (-[WebResource data]):
3145         (-[WebResource URL]):
3146         (-[WebResource MIMEType]):
3147         (-[WebResource textEncodingName]):
3148         (-[WebResource frameName]):
3149         (-[WebResource _initWithCoreResource:WebCore::]):
3150         (-[WebResource WebCore::]):
3151         (-[WebResource _ignoreWhenUnarchiving]):
3152         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3153         (-[WebResource _fileWrapperRepresentation]):
3154         (-[WebResource _response]):
3155         (-[WebResource _stringValue]):
3156         * WebView/WebResourceInternal.h: Added.
3157         * WebView/WebResourcePrivate.h:
3158
3159         * WebView/WebUnarchivingState.h: Removed.
3160         * WebView/WebUnarchivingState.m: Removed.
3161
3162 2008-03-24  Oliver Hunt  <oliver@apple.com>
3163
3164         Reviewed by Mark Rowe.
3165
3166         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
3167         <http://bugs.webkit.org/show_bug.cgi?id=18030>
3168
3169         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
3170         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
3171         <http://bugs.webkit.org/show_bug.cgi?id=18057>
3172
3173         * WebView/WebHTMLView.mm:
3174         (-[WebHTMLView keyDown:]):
3175
3176 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3177
3178         Reviewed by Maciej, landed by Brady
3179
3180         Bug 3580: iFrames Appear to be Cached
3181         <http://bugs.webkit.org/show_bug.cgi?id=3580>
3182
3183         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
3184         <http://bugs.webkit.org/show_bug.cgi?id=15486>
3185
3186         Bug 15554: Reload causes <object> to use old data
3187         <http://bugs.webkit.org/show_bug.cgi?id=15554>
3188
3189         If a page is reloaded, a child frame's URL can not be taken from a history item.
3190
3191         * WebView/WebFrame.mm:
3192         (-[WebFrame _loadURL:referrer:intoChild:]):
3193
3194 2008-03-24  Darin Adler  <darin@apple.com>
3195
3196         Reviewed by Beth.
3197
3198         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
3199
3200         * History/WebHistoryItem.mm:
3201         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
3202         * WebView/WebDataSource.mm:
3203         (-[WebDataSource _URL]): Ditto.
3204         (-[WebDataSource unreachableURL]): Ditto.
3205         * WebView/WebHTMLView.mm:
3206         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3207
3208         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3209         * History/WebHistory.mm:
3210         * Misc/WebElementDictionary.mm:
3211         * Misc/WebNSAttributedStringExtras.mm:
3212         Remove unneeded imports of KURL.h.
3213
3214 2008-03-24  Brady Eidson  <beidson@apple.com>
3215
3216         Reviewed by Darin's rubberstamp
3217
3218         Rename this file for upcoming work.
3219
3220         * WebView/WebArchive.m: Removed.
3221         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
3222
3223 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
3224
3225         Build fix.
3226
3227         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
3228
3229 2008-03-23  Oliver Hunt  <oliver@apple.com>
3230
3231         Reviewed by Maciej.
3232
3233         Bug 17670: Key events may improperly propagate from iframe to parent frame
3234         <http://bugs.webkit.org/show_bug.cgi?id=17670>
3235         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
3236         <http://bugs.webkit.org/show_bug.cgi?id=16381>
3237
3238         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
3239         as that results in us dispatching the key events for each frame going up the frame
3240         tree.
3241
3242         * WebView/WebHTMLView.mm:
3243         (-[WebHTMLView keyDown:]):
3244         (-[WebHTMLView keyUp:]):
3245         (-[WebHTMLView flagsChanged:]):
3246
3247 2008-03-21  Timothy Hatcher  <timothy@apple.com>
3248
3249         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
3250         http://bugs.webkit.org/show_bug.cgi?id=17980
3251
3252         Reviewed by Adam.
3253
3254         The new highlight drawing was not honoring the fade value, so it was
3255         always drawing at full opacity. The animation code didn't match Windows
3256         and the new highlight anyway, so it has been removed. The highlight
3257         how just detaches when it is hidden.
3258
3259         * WebCoreSupport/WebInspectorClient.mm:
3260         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
3261         (-[WebInspectorWindowController close]): Ditto.
3262         (-[WebInspectorWindowController highlightNode:]): Call attach.
3263         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
3264         * WebInspector/WebNodeHighlight.h:
3265         * WebInspector/WebNodeHighlight.m:
3266         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3267         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
3268         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
3269         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
3270         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
3271         * WebInspector/WebNodeHighlightView.h:
3272         * WebInspector/WebNodeHighlightView.m:
3273         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
3274
3275 2008-03-20  Mark Rowe  <mrowe@apple.com>
3276
3277         Reviewed by Sam Weinig.
3278
3279         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
3280         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
3281         command-line.
3282
3283         * Configurations/WebKit.xcconfig:
3284
3285 2008-03-20  Adam Roben  <aroben@apple.com>
3286
3287         Make WebNodeHighlightView use InspectorController to do its painting
3288
3289         Reviewed by Tim Hatcher.
3290
3291         * WebCoreSupport/WebInspectorClient.mm:
3292         (-[WebInspectorWindowController highlightNode:]): Pass the
3293         InspectorController to the WebNodeHighlight, and don't call
3294         setHighlightedNode: (which has been removed).
3295         (-[WebInspectorWindowController hideHighlight]): Removed call to
3296         setHighlightedNode:.
3297         * WebInspector/WebNodeHighlight.h:
3298           - Replaced _highlightNode with _inspectorController
3299           - Removed _highlightedNode accessors
3300           - Added -inspectorController method
3301         * WebInspector/WebNodeHighlight.m:
3302         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
3303         takes an InspectorController* and stores it in _inspectorController.
3304         (-[WebNodeHighlight dealloc]): Removed code dealing with
3305         _highlightedNode.
3306         (-[WebNodeHighlight inspectorController]): Added.
3307         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
3308         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
3309         GraphicsContexts to be based on a flipped CGContext, so we have to
3310         specify that this view is flipped.
3311         (-[WebNodeHighlightView drawRect:]): Changed to create a
3312         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
3313
3314 2008-03-18  David Hyatt  <hyatt@apple.com>
3315
3316         Add support for a preference in WebKit that can be used in nightly builds to test full page
3317         zoom.
3318
3319         Reviewed by Antti
3320
3321         * WebView/WebPreferenceKeysPrivate.h:
3322         * WebView/WebView.mm:
3323         (-[WebView setTextSizeMultiplier:]):
3324         (-[WebView canMakeTextSmaller]):
3325         (-[WebView makeTextSmaller:]):
3326         (-[WebView canMakeTextLarger]):
3327         (-[WebView makeTextLarger:]):
3328         (-[WebView canMakeTextStandardSize]):
3329         (-[WebView makeTextStandardSize:]):
3330
3331 2008-03-17  Eric Seidel  <eric@webkit.org>
3332
3333         Reviewed by darin.
3334
3335         Export _NPN_IntFromIdentifier as part of our NPAPI interface
3336
3337         * Plugins/WebNetscapePluginPackage.m:
3338         (-[WebNetscapePluginPackage load]):
3339
3340 2008-03-14  Brady Eidson  <beidson@apple.com>
3341
3342         Reviewed by Brian Dash's rubberstamp
3343
3344         Remove a class declaration for a class that has never existed
3345
3346         * WebView/WebResource.h:
3347
3348 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
3349
3350         Unify concept of enabling the Mac Java bridge.
3351
3352         Reviewed by Darin and Anders.
3353
3354         * Plugins/WebPluginJava.h: Removed unused file.
3355         * WebCoreSupport/WebFrameLoaderClient.h:
3356         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
3357         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
3358         (WebFrameLoaderClient::javaApplet): Ditto.
3359
3360 2008-03-13  Antti Koivisto  <antti@apple.com>
3361
3362         Reviewed by Darin.
3363
3364         * ForwardingHeaders/wtf/Deque.h: Added.
3365
3366 2008-03-13  Anders Carlsson  <andersca@apple.com>
3367
3368         Reviewed by Adam.
3369
3370         Call originalRequest, not initialRequest.
3371         
3372         * WebView/WebDataSource.mm:
3373         (-[WebDataSource initialRequest]):
3374
3375 2008-03-12  Darin Adler  <darin@apple.com>
3376
3377         Reviewed by John Sullivan.
3378
3379         - cleanup after removing the bridge
3380
3381         * DOM/WebDOMOperations.mm:
3382         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
3383
3384         * Misc/WebCoreStatistics.mm:
3385         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
3386
3387         * Plugins/WebBaseNetscapePluginView.mm:
3388         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
3389         _frameLoader method.
3390         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3391         Ditto.
3392         * Plugins/WebPluginController.mm:
3393         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
3394
3395         * WebCoreSupport/WebFrameLoaderClient.mm:
3396         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
3397         method. Without this we could leave a stale frame pointer around.
3398         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
3399         caller of the _isMainFrame method.
3400         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
3401         _frameLoader method.
3402         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
3403
3404         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
3405         turned out to be unused.
3406         (core): Added overload for DocumentFragment.
3407         (kit): Ditto.
3408         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
3409         to FrameLoader with _private->coreFrame->loader().
3410         (-[WebFrame _attachScriptDebugger]): Ditto.
3411         (-[WebFrame _clearCoreFrame]): Added.
3412         (-[WebFrame _updateBackground]): More of the same.
3413         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
3414         (-[WebFrame _unmarkAllMisspellings]): Ditto.
3415         (-[WebFrame _hasSelection]): Ditto.
3416         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
3417         (-[WebFrame _findFrameWithSelection]): Ditto.
3418         (-[WebFrame _dataSource]): Ditto.
3419         (-[WebFrame _addData:]): Streamlined code a bit.
3420         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3421         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3422         (-[WebFrame _isDescendantOfFrame:]): Ditto.
3423         (-[WebFrame _bodyBackgroundColor]): Ditto.
3424         (-[WebFrame _isFrameSet]): Ditto.
3425         (-[WebFrame _firstLayoutDone]): Ditto.
3426         (-[WebFrame _loadType]): Ditto.
3427         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
3428         (-[WebFrame name]): Ditto.
3429         (-[WebFrame DOMDocument]): Ditto.
3430         (-[WebFrame frameElement]): Ditto.
3431         (-[WebFrame provisionalDataSource]): Ditto.
3432         (-[WebFrame dataSource]): Ditto.
3433         (-[WebFrame loadRequest:]): Ditto.
3434         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
3435         (-[WebFrame loadArchive:]): Ditto.
3436         (-[WebFrame stopLoading]): Ditto.
3437         (-[WebFrame reload]): Ditto.
3438         (-[WebFrame findFrameNamed:]): Ditto.
3439         (-[WebFrame parentFrame]): Ditto.
3440         (-[WebFrame childFrames]): Ditto.
3441         (-[WebFrame windowObject]): Ditto.
3442         (-[WebFrame globalContext]): Ditto.
3443
3444         * WebView/WebFrameInternal.h: Added overloads of core and kit.
3445         Removed method declarations.
3446
3447         * WebView/WebHTMLRepresentation.mm:
3448         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
3449         (formElementFromDOMElement): Ditto.
3450         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3451         (inputElementFromDOMElement): Ditto.
3452         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3453         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3454         (-[WebHTMLRepresentation formForElement:]): Ditto.
3455         (-[WebHTMLRepresentation currentForm]): Ditto.
3456         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3457         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3458         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3459
3460         * WebView/WebHTMLView.mm:
3461         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
3462         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3463         Call createFragmentFromText directly instead of via WebFrame.
3464         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3465         Moved layout calls here from WebFrame.
3466         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3467         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
3468         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
3469         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
3470         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
3471         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3472         Moved code here from WebFrame.
3473         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
3474         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3475         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3476         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3477         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3478         (-[WebHTMLView rectsForTextMatches]): Ditto.
3479
3480         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
3481
3482         * WebView/WebPDFView.mm:
3483         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
3484         _frameLoader method.
3485
3486         * WebView/WebRenderNode.mm:
3487         (copyRenderNode): Moved code here from WebFrame.
3488         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3489
3490         * WebView/WebResource.mm:
3491         (-[WebResource _stringValue]): Moved code here from WebFrame.
3492
3493         * WebView/WebView.mm:
3494         (-[WebView _close]): Use core function intsead of _frameLoader method.
3495         (-[WebView setCustomTextEncodingName:]): Ditto.
3496         (-[WebView setHostWindow:]): Moved code here from WebFrame.
3497         (aeDescFromJSValue): Moved this here from WebFrame.
3498         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
3499
3500 2008-03-12  Darin Adler  <darin@apple.com>
3501
3502         Reviewed by Anders.
3503
3504         - http://bugs.webkit.org/show_bug.cgi?id=17640
3505           eliminate WebCoreFrameBridge
3506
3507         Moved all the code from the bridge into WebFrame. This need not be the final
3508         home of these methods -- they can be moved closer to their callers and improved
3509         further -- but it eliminates the bridge without requiring a rewrite of the code.
3510         It's a fairly mechanical process (just adding underscores to method names really).
3511
3512         There's even a chance that some of the methods are unused. Those we can remove
3513         after checking if that's so.
3514
3515         * DOM/WebDOMOperations.mm:
3516         (-[DOMNode markupString]): Use WebFrame rather than bridge.
3517         (-[DOMDocument webFrame]): Changed to use the core and kit functions
3518         instead of using the bridge.
3519         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
3520         (-[DOMRange markupString]): Ditto.
3521         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3522
3523         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3524         * History/WebHistoryItem.mm: Ditto.
3525
3526         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3527         * Misc/WebCoreStatistics.mm:
3528         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3529
3530         * Misc/WebElementDictionary.mm: Removed unneeded import.
3531
3532         * Misc/WebKitStatistics.m:
3533         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3534         * Misc/WebKitStatisticsPrivate.h: Ditto.
3535
3536         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3537         * Misc/WebNSPasteboardExtras.mm: Ditto.
3538
3539         * Plugins/WebBaseNetscapePluginView.mm:
3540         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3541         rather than bridge.
3542
3543         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3544         * Plugins/WebNetscapePluginStream.mm: Ditto.
3545
3546         * Plugins/WebPluginContainerCheck.mm:
3547         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3548         bridge to get to the WebCore::Frame.
3549
3550         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3551         * Plugins/WebPluginController.mm:
3552         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3553         rather than bridge.
3554
3555         * WebCoreSupport/WebEditorClient.mm:
3556         (selectorForKeyEvent): Tweaked comment.
3557
3558         * WebCoreSupport/WebFrameBridge.h: Removed.
3559         * WebCoreSupport/WebFrameBridge.mm: Removed.
3560
3561         * WebCoreSupport/WebFrameLoaderClient.mm:
3562         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3563         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3564         I could remove this function entirely, but it looks like the Qt port is using it.
3565
3566         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3567
3568         * WebView/WebArchiver.mm:
3569         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3570         (+[WebArchiver archiveNode:]): Ditto.
3571         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3572
3573         * WebView/WebDataSource.mm:
3574         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3575         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3576         (-[WebDataSource subresources]): Ditto.
3577         (-[WebDataSource subresourceForURL:]): Ditto.
3578
3579         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3580
3581         * WebView/WebFrame.mm:
3582         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3583         (core): Go directly to the core frame, not via the bridge.
3584         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3585         Remove the code to deal with the bridge.
3586         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3587         shouldCreateRenderers flag, formerly on the bridge.
3588         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3589         (aeDescFromJSValue): Moved here from bridge.
3590         (-[WebFrame _domain]): Ditto.
3591         (-[WebFrame _addData:]): Ditto.
3592         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3593         (-[WebFrame _nodesFromList:]): Ditto.
3594         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3595         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3596         (-[WebFrame _selectedString]): Ditto.
3597         (-[WebFrame _stringForRange:]): Ditto.
3598         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3599         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3600         (-[WebFrame _sendScrollEvent]): Ditto.
3601         (-[WebFrame _drawRect:]): Ditto.
3602         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3603         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3604         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3605         (-[WebFrame _copyRenderTree:]): Ditto.
3606         (inputElementFromDOMElement): Ditto.
3607         (formElementFromDOMElement): Ditto.
3608         (-[WebFrame _elementWithName:inForm:]): Ditto.
3609         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3610         (-[WebFrame _elementIsPassword:]): Ditto.
3611         (-[WebFrame _formForElement:]): Ditto.
3612         (-[WebFrame _currentForm]): Ditto.
3613         (-[WebFrame _controlsInForm:]): Ditto.
3614         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3615         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3616         (-[WebFrame _URLWithAttributeString:]): Ditto.
3617         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3618         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3619         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3620         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3621         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3622         (-[WebFrame _rectsForTextMatches]): Ditto.
3623         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3624         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3625         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3626         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3627         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3628         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3629         (-[WebFrame _baseURL]): Ditto.
3630         (-[WebFrame _stringWithData:]): Ditto.
3631         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3632         (-[WebFrame _needsLayout]): Ditto.
3633         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3634         (-[WebFrame _accessibilityTree]): Ditto.
3635         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3636         (-[WebFrame _setDrawsBackground:]): Ditto.
3637         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3638         Ditto.
3639         (-[WebFrame _selectionGranularity]): Ditto.
3640         (-[WebFrame _convertToNSRange:]): Ditto.
3641         (-[WebFrame _convertToDOMRange:]): Ditto.
3642         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3643         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3644         (-[WebFrame _markDOMRange]): Ditto.
3645         (-[WebFrame _markedTextNSRange]): Ditto.
3646         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3647         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3648         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3649         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3650         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3651         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3652         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3653         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3654         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3655         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3656         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3657         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3658         (-[WebFrame _typingStyle]): Ditto.
3659         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3660         (-[WebFrame _fontForSelection:]): Ditto.
3661         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3662         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3663         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3664         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3665         (-[WebFrame _canProvideDocumentSource]): Ditto.
3666         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3667         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3668         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3669         function. Couldn't just keep the bridge method because this was already here with the same name.
3670         (-[WebFrame _selectedNSRange]): Ditto.
3671         (-[WebFrame _selectNSRange:]): Ditto.
3672         (-[WebFrame dealloc]): Remove bridge-related code.
3673         (-[WebFrame finalize]): Ditto.
3674
3675         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3676         Removed the bridge parameter from the init method. Removed the #if blocks that
3677         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3678         Removed the _bridge method.
3679
3680         * WebView/WebFrameView.mm: Removed the _bridge method.
3681
3682         * WebView/WebHTMLRepresentation.mm:
3683         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3684         field.
3685         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3686         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3687         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3688         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3689         (-[WebHTMLRepresentation documentSource]): Ditto.
3690         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3691         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3692         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3693         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3694         (-[WebHTMLRepresentation formForElement:]): Ditto.
3695         (-[WebHTMLRepresentation currentForm]): Ditto.
3696         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3697         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3698         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3699
3700         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3701
3702         * WebView/WebHTMLView.mm:
3703         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3704         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3705         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3706         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3707         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3708         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3709         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3710         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3711         (-[WebHTMLView drawSingleRect:]): Ditto.
3712         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3713         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3714         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3715         (-[WebHTMLView knowsPageRange:]): Ditto.
3716         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3717         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3718         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3719         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3720         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3721         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3722         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3723         (-[WebHTMLView startSpeaking:]): Ditto.
3724         (-[WebHTMLView _updateFontPanel]): Ditto.
3725         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3726         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3727         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3728         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3729         (-[WebHTMLView selectedRange]): Ditto.
3730         (-[WebHTMLView markedRange]): Ditto.
3731         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3732         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3733         (-[WebHTMLView insertText:]): Ditto.
3734         (-[WebTextCompleteController _insertMatch:]): Ditto.
3735         (-[WebTextCompleteController doCompletion]): Ditto.
3736         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3737         (-[WebHTMLView string]): Ditto.
3738         (-[WebHTMLView selectedString]): Ditto.
3739         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3740         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3741         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3742         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3743         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3744         (-[WebHTMLView rectsForTextMatches]): Ditto.
3745         * WebView/WebRenderNode.mm:
3746         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3747         * WebView/WebResource.mm:
3748         (-[WebResource _stringValue]): Ditto.
3749
3750         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3751
3752         * WebView/WebView.mm:
3753         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3754         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3755         (-[WebView _setInViewSourceMode:]): Ditto.
3756         (-[WebView _inViewSourceMode]): Ditto.
3757         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3758         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3759         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3760         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3761         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
3762         (-[WebView setEditable:]): Ditto.
3763         (-[WebView setTypingStyle:]): Ditto.
3764         (-[WebView typingStyle]): Ditto.
3765         (-[WebView replaceSelectionWithNode:]): Ditto.
3766         (-[WebView replaceSelectionWithText:]): Ditto.
3767         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
3768         (-[WebView replaceSelectionWithArchive:]): Ditto.
3769         (-[WebView _insertNewlineInQuotedContent]): Ditto.
3770         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
3771
3772 2008-03-12  David Hyatt  <hyatt@apple.com>
3773
3774         Make the zoom factor a float and not a percent.
3775
3776         Reviewed by antti
3777
3778         * WebView/WebView.mm:
3779         (-[WebView _setZoomMultiplier:isTextOnly:]):
3780
3781 2008-03-11  David Hyatt  <hyatt@apple.com>
3782
3783         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
3784         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
3785         can zoom the page in, out or reset it to the standard size.
3786
3787         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
3788         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
3789         win.
3790
3791         Reviewed by Tim H.
3792
3793         * WebCoreSupport/WebFrameBridge.mm:
3794         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
3795         * WebView/WebDocumentInternal.h:
3796         * WebView/WebHTMLView.mm:
3797         (-[WebHTMLView viewDidMoveToSuperview]):
3798         * WebView/WebPDFView.h:
3799         * WebView/WebPDFView.mm:
3800         (-[WebPDFView _zoomOut:]):
3801         (-[WebPDFView _zoomIn:]):
3802         (-[WebPDFView _resetZoom:]):
3803         (-[WebPDFView _canZoomOut]):
3804         (-[WebPDFView _canZoomIn]):
3805         (-[WebPDFView _canResetZoom]):
3806         * WebView/WebView.mm:
3807         (-[WebViewPrivate init]):
3808         (-[WebView setTextSizeMultiplier:]):
3809         (-[WebView textSizeMultiplier]):
3810         (-[WebView _setZoomMultiplier:isTextOnly:]):
3811         (-[WebView _zoomMultiplier:]):
3812         (-[WebView _realZoomMultiplier]):
3813         (-[WebView _realZoomMultiplierIsTextOnly]):
3814         (-[WebView _canZoomOut:]):
3815         (-[WebView _canZoomIn:]):
3816         (-[WebView _zoomOut:isTextOnly:]):
3817         (-[WebView _zoomIn:isTextOnly:]):
3818         (-[WebView _canResetZoom:]):
3819         (-[WebView _resetZoom:isTextOnly:]):
3820         (-[WebView canMakeTextSmaller]):
3821         (-[WebView makeTextSmaller:]):
3822         (-[WebView canMakeTextLarger]):
3823         (-[WebView makeTextLarger:]):
3824         (-[WebView canMakeTextStandardSize]):
3825         (-[WebView makeTextStandardSize:]):
3826         (-[WebView setPageSizeMultiplier:]):
3827         (-[WebView pageSizeMultiplier]):
3828         (-[WebView canZoomPageIn]):
3829         (-[WebView zoomPageIn:]):
3830         (-[WebView canZoomPageOut]):
3831         (-[WebView zoomPageOut:]):
3832         (-[WebView canResetPageZoom]):
3833         (-[WebView resetPageZoom:]):
3834         (-[WebView _searchWithSpotlightFromMenu:]):
3835         * WebView/WebViewInternal.h:
3836         * WebView/WebViewPrivate.h:
3837
3838 2008-03-12  Dan Bernstein  <mitz@apple.com>
3839
3840         Reviewed by Darin Adler and Sam Weinig.
3841
3842         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
3843
3844         * WebCoreSupport/WebSystemInterface.m:
3845         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
3846         WKGetNSFontATSUFontId Tiger-only.
3847
3848 2008-03-12  Darin Adler  <darin@apple.com>
3849
3850         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
3851           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
3852
3853         * WebView/WebFrame.mm:
3854         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
3855         up pointer from the bridge to the frame. (My next check-in removes the bridge
3856         entirely, but we need this until then.)
3857
3858 2008-03-11  Darin Adler  <darin@apple.com>
3859
3860         Reviewed by Sam.
3861
3862         - remove all bridge-related things from WebCore except the bridge itself
3863
3864         * DOM/WebDOMOperations.mm:
3865         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
3866
3867         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
3868
3869         * Plugins/WebPluginController.mm: Ditto.
3870
3871         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
3872         init and close methods. Added a setWebFrame: method.
3873
3874         * WebCoreSupport/WebFrameBridge.mm:
3875         (-[WebFrameBridge setWebFrame:]): Added.
3876
3877         * WebCoreSupport/WebFrameLoaderClient.mm:
3878         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
3879         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
3880         bridge here. Soon we will be able to remove this entirely!
3881         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
3882         into WebFrame from the bridge.
3883
3884         * WebView/WebFrame.mm:
3885         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
3886         now owned by the frame.
3887         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
3888         debugger under GC without this!
3889         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
3890         use WebFrameLoaderClient instead of the bridge.
3891         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
3892         This is code that used to live in the bridge's init function.
3893         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
3894         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
3895         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
3896         the WebView is now the bridge's owner.
3897         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
3898         WebCore::Frame::bridge function directly to use the kit function instead.
3899         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
3900         This code won't last long -- we're eliminating the bridge soon.
3901         (-[WebFrame finalize]): Ditto.
3902
3903         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
3904         for creating frames.
3905
3906         * WebView/WebView.mm:
3907         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
3908         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
3909         where we have to allocate a WebFrameBridge and then immediately release it.
3910
3911 2008-03-11  Darin Adler  <darin@apple.com>
3912
3913         Reviewed by Anders.
3914
3915         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
3916
3917         * WebCoreSupport/WebFrameLoaderClient.mm:
3918         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
3919         to setView. A couple lines later, there is a call to _install, which sets the
3920         view to the scroll view.
3921
3922         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
3923
3924         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
3925         this file, since it's used by Safari.
3926         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
3927         * WebView/WebDynamicScrollBarsView.m:
3928         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
3929         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
3930         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
3931         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
3932         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
3933         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
3934         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
3935         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
3936         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
3937         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
3938         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
3939         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
3940         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
3941         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
3942         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
3943
3944         * WebView/WebFrameView.mm:
3945         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
3946
3947         * WebView/WebView.mm:
3948         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
3949         (-[WebView alwaysShowVerticalScroller]): Ditto.
3950         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
3951         (-[WebView alwaysShowHorizontalScroller]): Ditto.
3952
3953 2008-03-11  Darin Adler  <darin@apple.com>
3954
3955         Reviewed by Sam.
3956
3957         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
3958
3959         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
3960         bridge methods.
3961         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
3962         to recently-created functions.
3963         (WebChromeClient::firstResponder): Moved code here from the bridge.
3964         (WebChromeClient::makeFirstResponder): Ditto.
3965         (WebChromeClient::runOpenPanel): Ditto.
3966         (WebChromeClient::willPopUpMenu): Ditto.
3967
3968         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
3969         is related to creating the bridge and connecting it to WebCore, which will
3970         go next when I eliminate use of the bridge to get to/from the Frame*.
3971         * WebCoreSupport/WebFrameBridge.mm:
3972         (-[WebFrameBridge close]): Moved the code to track the bridge count here
3973         instead of the dealloc and finalize methods.
3974
3975 2008-03-11  Darin Adler  <darin@apple.com>
3976
3977         Reviewed by Mitz.
3978
3979         - update code affected by Range changes
3980
3981         * Misc/WebNSAttributedStringExtras.mm:
3982         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
3983         * WebView/WebHTMLRepresentation.mm:
3984         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3985         Use Range::create.
3986         * WebView/WebHTMLView.mm:
3987         (-[WebHTMLView attributedString]): Ditto.
3988
3989 2008-03-10  Darin Adler  <darin@apple.com>
3990
3991         Reviewed by Sam.
3992
3993         - eliminate keyboard UI mode method from WebCoreFrameBridge
3994
3995         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
3996         * WebCoreSupport/WebChromeClient.mm:
3997         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
3998         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
3999         fields for keyboard UI mode.
4000         * WebCoreSupport/WebFrameBridge.mm:
4001         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
4002         method.
4003         (-[WebFrameBridge finalize]): Ditto.
4004         * WebView/WebView.mm: Moved the keyboard mode code in here.
4005         (-[WebView _close]): Remove observer from the distributed notification
4006         center as well as the normal one.
4007         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
4008         here from the bridge.
4009         (-[WebView _keyboardUIMode]): Ditto.
4010         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
4011
4012 2008-03-10  Darin Adler  <darin@apple.com>
4013
4014         Reviewed by Sam.
4015
4016         - eliminate Java applet methods from WebCoreFrameBridge
4017
4018         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
4019         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
4020         the ones that load Java applets.
4021         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
4022         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
4023
4024 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
4025
4026         Reviewed by Darin.
4027
4028         Done with Lars.
4029
4030         Simplified WebViewFactory's refreshPlugins method to only refresh the
4031         plugins and not reload the frames anymore since that's now done in a
4032         platform independent manner by WebCore::Page.
4033
4034         Also removed the now unused pluginNameForMIMEType and
4035         pluginSupportsMIMEType methods.
4036
4037         * WebCoreSupport/WebViewFactory.mm:
4038         * WebView/WebFrame.mm:
4039         * WebView/WebFrameInternal.h:
4040         * WebView/WebView.mm:
4041
4042 2008-03-08  Mark Rowe  <mrowe@apple.com>
4043
4044         Reviewed by Darin Adler.
4045
4046         Fix 64-bit build with GCC 4.2.
4047
4048         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
4049         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
4050         * History/WebHistoryItem.mm: Ditto.
4051         * Misc/WebElementDictionary.mm: Ditto.
4052         * WebCoreSupport/WebFrameLoaderClient.mm:
4053         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
4054         variable being unused in 64-bit.
4055         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
4056         * WebView/WebHTMLView.mm:
4057         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
4058         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
4059
4060 2008-03-08  Darin Adler  <darin@apple.com>
4061
4062         Reviewed by Adele.
4063
4064         - eliminate custom highlight methods from WebCoreFrameBridge
4065
4066         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
4067         * WebCoreSupport/WebChromeClient.mm:
4068         (WebChromeClient::customHighlightRect): Moved code here from bridge.
4069         (WebChromeClient::paintCustomHighlight): Ditto.
4070         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
4071
4072 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
4073
4074         Unify concept of enabling Netscape Plug-in API (NPAPI).
4075
4076         Reviewed by Darin.
4077
4078         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
4079
4080         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
4081         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
4082
4083         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
4084         #if ENABLE(NETSCAPE_PLUGIN_API).
4085         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
4086         * Plugins/WebBaseNetscapePluginView.h: Ditto.
4087         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
4088         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
4089         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
4090         * Plugins/WebBasePluginPackage.h: Ditto.
4091         * Plugins/WebBasePluginPackage.m: Ditto.
4092         (+[WebBasePluginPackage pluginWithPath:]):
4093         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
4094         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
4095         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
4096         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
4097         * Plugins/WebNetscapePluginPackage.h: Ditto.
4098         * Plugins/WebNetscapePluginPackage.m: Ditto.
4099         * Plugins/WebNetscapePluginStream.h: Ditto.
4100         * Plugins/WebNetscapePluginStream.mm: Ditto.
4101         * Plugins/WebPluginDatabase.m: Ditto.
4102         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
4103         * Plugins/npapi.m: Ditto.
4104         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
4105         (WebFrameLoaderClient::objectContentType):
4106         (WebFrameLoaderClient::createPlugin):
4107         * WebView/WebHTMLView.mm: Ditto.
4108         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
4109         * WebView/WebHTMLViewInternal.h: Ditto.
4110
4111         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
4112         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
4113         category to (WebInternal) category so we don't expose the ENABLE() macro
4114         from the private header.
4115         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
4116         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
4117         * WebView/WebFrameInternal.h: Ditto.
4118         * WebView/WebFramePrivate.h: Ditto.
4119
4120 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
4121
4122         Reviewed by Darin.
4123
4124         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
4125         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
4126
4127         * WebView/WebPreferences.m:
4128         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
4129         the one used in Safari.
4130
4131 2008-03-07  Mark Rowe  <mrowe@apple.com>
4132
4133         Reviewed by Oliver Hunt.
4134
4135         Fix WebKit build with GCC 4.2.
4136
4137         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
4138
4139 2008-03-07  Darin Adler  <darin@apple.com>
4140
4141         Reviewed by Adam.
4142
4143         - eliminated WebCoreFrameBridge runOpenPanel
4144
4145         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
4146         * WebCoreSupport/WebChromeClient.mm:
4147         (WebChromeClient::runOpenPanel): Added.
4148         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
4149         FileChooser so it can get a result from the UI delegate.
4150         (-[WebOpenPanelResultListener dealloc]): Added.
4151         (-[WebOpenPanelResultListener finalize]): Added.
4152         (-[WebOpenPanelResultListener cancel]): Added.
4153         (-[WebOpenPanelResultListener chooseFilename:]): Added.
4154
4155 2008-03-06  Darin Adler  <darin@apple.com>
4156
4157         Reviewed by Mitz.
4158
4159         - fix regression test failures from the visited-link change
4160
4161         * History/WebHistory.mm:
4162         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
4163         to turn off visited links if there is no history object. Also call
4164         removeAllVisitedLinks so we can start over from scratch with the new history.
4165
4166 2008-03-06  Dan Bernstein  <mitz@apple.com>
4167
4168         Reviewed by Darin Adler.
4169
4170         - fix a regression from r30741: a crash under
4171           WebFrameLoaderClient::createPlugin() when showing a Mail message with
4172           an attachment
4173
4174         * WebCoreSupport/WebFrameLoaderClient.mm:
4175         (WebFrameLoaderClient::createPlugin):
4176
4177 2008-03-06  Darin Adler  <darin@apple.com>
4178
4179         - fix Tiger build
4180
4181         * History/WebHistory.mm: Added include of WebTypesInternal.h.
4182
4183 2008-03-06  Darin Adler  <darin@apple.com>
4184
4185         - fix Release build
4186
4187         * History/WebHistory.mm:
4188         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
4189         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
4190         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
4191
4192 2008-03-06  Darin Adler  <darin@apple.com>
4193
4194         Reviewed by Mitz.
4195
4196         - fix