2008-07-28 Anders Carlsson <andersca@apple.com>
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-07-28  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Adam.
4
5         <rdar://problem/6105529> 
6         https://bugs.webkit.org/show_bug.cgi?id=19659
7         Turning off plugins causes crash
8         
9         When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
10         end up in a state where they don't have an event handler. Because of this, we need to 
11         check that the plug-in has been started before calling the event handler.
12         
13         * Plugins/WebBaseNetscapePluginView.mm:
14         (-[WebBaseNetscapePluginView sendActivateEvent:]):
15         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
16         (-[WebBaseNetscapePluginView setHasFocus:]):
17         (-[WebBaseNetscapePluginView mouseDown:]):
18         (-[WebBaseNetscapePluginView mouseUp:]):
19         (-[WebBaseNetscapePluginView mouseEntered:]):
20         (-[WebBaseNetscapePluginView mouseExited:]):
21         (-[WebBaseNetscapePluginView handleMouseMoved:]):
22         (-[WebBaseNetscapePluginView mouseDragged:]):
23         (-[WebBaseNetscapePluginView scrollWheel:]):
24         (-[WebBaseNetscapePluginView keyUp:]):
25         (-[WebBaseNetscapePluginView keyDown:]):
26         (-[WebBaseNetscapePluginView flagsChanged:]):
27         (-[WebBaseNetscapePluginView cut:]):
28         (-[WebBaseNetscapePluginView copy:]):
29         (-[WebBaseNetscapePluginView paste:]):
30         (-[WebBaseNetscapePluginView selectAll:]):
31         (-[WebBaseNetscapePluginView drawRect:]):
32         (-[WebBaseNetscapePluginView inputContext]):
33
34 2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>
35
36         Reviewed by Geoff Garen.
37
38         Changes to accommodate newly named/signatured loading methods in WebCore.
39
40         * Plugins/WebNetscapePluginStream.mm:
41         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
42         * Plugins/WebPluginContainerCheck.mm:
43         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
44         * WebView/WebPDFView.mm:
45         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
46
47 2008-07-21  Mark Rowe  <mrowe@apple.com>
48
49         Reviewed by Sam Weinig.
50
51         <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
52
53         * Configurations/Version.xcconfig:
54         * Info.plist:
55
56 2008-07-21  Anders Carlsson  <andersca@apple.com>
57
58         Reviewed by Geoff.
59
60         <rdar://problem/5820667> 
61         CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
62         
63         Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
64         
65         * Plugins/WebBaseNetscapePluginView.mm:
66         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
67
68 2008-07-21  Mark Rowe  <mrowe@apple.com>
69
70         Reviewed by Adam Roben.
71
72         <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
73
74         Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
75         This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
76
77         * WebView/WebHTMLView.mm:
78
79 2008-07-21  Mark Rowe  <mrowe@apple.com>
80
81         Reviewed by Adam Roben.
82
83         Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
84         only uses objc_msgSend_fpret for long double return values.  For float return
85         values the standard objc_msgSend is used, as on ppc and ppc64.
86
87         * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
88         objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
89         as that method is defined by the Objective-C runtime for x86_64.
90         (CallDelegateReturningFloat):
91
92 2008-07-14  Dan Bernstein  <mitz@apple.com>
93
94         Reviewed by John Sullivan.
95
96         - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
97
98         * Plugins/WebBaseNetscapePluginView.mm:
99         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
100         to account for the case of being drawn into a bitmap context that is not
101         a window's backing store. In that case, there are no valid "rects being
102         drawn" to clip to.
103         * WebView/WebHTMLView.mm:
104         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
105         Added an override of this NSView method which is used in for
106         -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
107         machinery overrides, it sets subviews aside before invoking the
108         superclass implementation. On Tiger, it also updates the layout.
109
110 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
111
112         Reviewed by Geoff Garen.
113
114         Eliminate per-thread JavaScript global data instance support and make arbitrary
115         global data/global object combinations possible.
116
117         * Misc/WebCoreStatistics.mm:
118         (+[WebCoreStatistics javaScriptObjectsCount]):
119         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
120         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
121         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
122         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
123         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
124         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
125
126 2008-07-11  Stephanie Lewis  <slewis@apple.com>
127
128         Reviewed by Darin Adler.
129
130         Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
131
132         * WebView/WebPreferences.m: Removed.
133         * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
134         (+[WebPreferences initialize]): if running in Default enable full  document teardown
135         (-[WebPreferences editableLinkBehavior]):
136         (-[WebPreferences setFullDocumentTeardownEnabled:]):
137         * WebView/WebView.mm:
138         (-[WebView _close]): disable leak messages if using fast teardown
139
140 2008-07-10  Mark Rowe  <mrowe@apple.com>
141
142         Reviewed by Sam Weinig.
143
144         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
145
146         * Configurations/WebKit.xcconfig:
147
148 2008-07-10  Mark Rowe  <mrowe@apple.com>
149
150         Reviewed by Sam Weinig.
151
152         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
153
154         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
155         * WebView/WebFrameLoadDelegate.h: Ditto.
156         * WebView/WebUIDelegate.h: Ditto.
157
158 2008-07-10  Anders Carlsson  <andersca@apple.com>
159
160         Reviewed by Mark.
161         
162         Add availability macros for the new WebPlugin methods.
163
164         * Plugins/WebPlugin.h:
165         * Plugins/WebPluginViewFactory.h:
166
167 2008-07-09  Mark Rowe  <mrowe@apple.com>
168
169         Reviewed by Geoff Garen.
170
171         Don't warn about deprecated functions in production builds.
172
173         * Configurations/Base.xcconfig:
174         * Configurations/DebugRelease.xcconfig:
175
176 2008-07-09  Brady Eidson  <beidson@apple.com>
177
178         Reviewed by Darin
179
180         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
181         has been installed in a frame tree.
182
183         The root of this problem was that calling init() on a new frame could end up calling arbitrary
184         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
185         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
186         destroying the frame.
187
188         Note that each platforms WebKit API layer needs to make this new guarantee:
189         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
190         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
191         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
192
193         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
194         architectural improvement we can make in the future so the individual platform clients are no longer
195         vulnerable to this problem, which should really have been a WebCore issue.
196
197         * WebCoreSupport/WebFrameLoaderClient.mm:
198         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
199           Don't appendChild() the new frame here.
200           Null-check the new frame's page before loading the URL into it, as it might already have been
201           removed from the page.
202
203         * WebView/WebFrame.mm:
204         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
205           go ahead and install the new frame in the frame tree *before* calling init() on it.
206
207 2008-07-09  Anders Carlsson  <andersca@apple.com>
208
209         Reviewed by Darin.
210
211         Make some WebPlugin and WebPluginFactory SPI public.
212         
213         * Plugins/WebPlugin.h:
214         * Plugins/WebPluginPrivate.h:
215         * Plugins/WebPluginViewFactory.h:
216         * Plugins/WebPluginViewFactoryPrivate.h:
217
218 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
219
220         Reviewed by Anders.
221
222         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
223         unsuccessful.
224
225         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
226         newStreamSuccessful.
227         * Plugins/WebBaseNetscapePluginStream.mm:
228         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
229         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
230         newStreamSuccessful to YES.
231         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
232         NPP_DestroyStream if newStreamSuccessful is true.
233
234 2008-07-08  Dan Bernstein  <mitz@apple.com>
235
236         Reviewed by John Sullivan.
237
238         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
239
240         * WebView/WebHTMLView.mm:
241         (-[WebHTMLView addWindowObservers]): Added code to observe when the
242         window goes onscreen.
243         (-[WebHTMLView removeWindowObservers]): Added.
244         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
245         not update when offscreen, calls -setNeedsDisplay: just before it comes
246         onscreen.
247         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
248         * WebView/WebPreferences.m:
249         (+[WebPreferences initialize]): Made updates when offscreen on by
250         default.
251         (-[WebPreferences updatesWhenOffscreen]): Added.
252         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
253         * WebView/WebPreferencesPrivate.h:
254         * WebView/WebView.mm:
255         (-[WebView _preferencesChangedNotification:]): Added code to update the
256         updatesWhenOffscreen setting in WebCore.
257
258 2008-07-07  Anders Carlsson  <andersca@apple.com>
259
260         Reviewed by Darin.
261
262         Speculative fix for     
263         <rdar://problem/5839800>
264         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
265         
266         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
267         
268         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
269         This is usually protected by _private->closed, but in this case it might still be false.
270
271         * WebView/WebHTMLView.mm:
272         (-[WebHTMLView close]):
273
274 2008-07-05  Mark Rowe  <mrowe@apple.com>
275
276         Reviewed by John Sullivan.
277
278         Remove WebSearchableTextView as it has been unused for some time now.
279
280         * Misc/WebSearchableTextView.h: Removed.
281         * Misc/WebSearchableTextView.m: Removed.
282
283 2008-07-05  Mark Rowe  <mrowe@apple.com>
284
285         Reviewed by John Sullivan.
286
287         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
288
289         * Misc/WebNSUserDefaultsExtras.m:
290         (-[NSString _webkit_HTTPStyleLanguageCode]):
291
292 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
293
294         Inspired and reviewed by Mark Rowe.
295
296         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
297
298         * Carbon/HIViewAdapter.m:
299         * DOM/WebDOMOperations.mm:
300         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
301         * DefaultDelegates/WebDefaultPolicyDelegate.m:
302         * History/WebBackForwardList.mm:
303         * History/WebHistory.mm:
304         * History/WebHistoryItem.mm:
305         * History/WebHistoryItemInternal.h:
306         * Misc/WebCoreStatistics.mm:
307         * Misc/WebDownload.m:
308         * Misc/WebGraphicsExtras.c:
309         * Misc/WebKitLogging.h:
310         * Misc/WebKitSystemBits.m:
311         * Misc/WebLocalizableStrings.m:
312         * Misc/WebNSArrayExtras.m:
313         * Misc/WebNSDataExtras.m:
314         * Misc/WebNSDictionaryExtras.m:
315         * Misc/WebNSFileManagerExtras.m:
316         * Misc/WebNSPasteboardExtras.mm:
317         * Misc/WebNSURLExtras.mm:
318         * Misc/WebNSUserDefaultsExtras.m:
319         * Panels/WebAuthenticationPanel.m:
320         * Panels/WebPanelAuthenticationHandler.m:
321         * Plugins/WebBaseNetscapePluginView.mm:
322         * Plugins/WebBasePluginPackage.m:
323         * Plugins/WebNetscapePluginEmbeddedView.mm:
324         * Plugins/WebPluginContainerCheck.mm:
325         * Plugins/WebPluginController.mm:
326         * Plugins/WebPluginDatabase.mm:
327         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
328         * WebCoreSupport/WebKeyGenerator.m:
329         * WebCoreSupport/WebViewFactory.mm:
330         * WebKitPrefix.h:
331         * WebView/WebHTMLRepresentation.mm:
332         * WebView/WebPDFRepresentation.m:
333         * WebView/WebPDFView.mm:
334         * WebView/WebScriptDebugger.mm:
335
336 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
337
338         Reviewed by Darin.
339
340         Disable JSLock for per-thread contexts.
341
342         * Misc/WebCoreStatistics.mm:
343         (+[WebCoreStatistics javaScriptObjectsCount]):
344         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
345         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
346         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
347         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
348         (+[WebCoreStatistics shouldPrintExceptions]):
349         (+[WebCoreStatistics setShouldPrintExceptions:]):
350         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
351         * Plugins/WebBaseNetscapePluginView.mm:
352         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
353         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
354         (-[WebBaseNetscapePluginView start]):
355         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
356         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
357         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
358         (-[WebBaseNetscapePluginView loadPluginRequest:]):
359         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
360         * Plugins/WebPluginController.mm:
361         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
362         (-[WebPluginController startAllPlugins]):
363         (-[WebPluginController stopAllPlugins]):
364         (-[WebPluginController addPlugin:]):
365         (-[WebPluginController destroyPlugin:]):
366         (-[WebPluginController destroyAllPlugins]):
367         * WebView/WebFrame.mm:
368         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
369         * WebView/WebScriptDebugDelegate.mm:
370         (-[WebScriptCallFrame evaluateWebScript:]):
371         * WebView/WebView.mm:
372         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
373         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
374         doesn't need locking. In the future, it may be possible to remove some of these if we
375         establish that this won't make JSC assertions fail (and that we don't want to add such
376         assertions either).
377         Added includes that are now needed.
378
379 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
380
381         Build fix.
382
383         * WebView/WebView.mm:
384
385 2008-07-01  Anders Carlsson  <andersca@apple.com>
386
387         Reviewed by Darin.
388
389         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
390         
391         * Plugins/WebBaseNetscapePluginView.mm:
392         (-[WebBaseNetscapePluginView _createPlugin]):
393         Register the plug-in instance.
394         
395         (-[WebBaseNetscapePluginView _destroyPlugin]):
396         Unegister the plug-in instance.
397         
398         * Plugins/WebNetscapePluginPackage.m:
399         (-[WebNetscapePluginPackage load]):
400         Set NPN_PluginThreadAsyncCall.
401         
402         * Plugins/npapi.mm:
403         (NPN_PluginThreadAsyncCall):
404         Implement this.
405
406 2008-07-01  Dan Bernstein  <mitz@apple.com>
407
408         Reviewed by Darin Adler.
409
410         - WebKit part of moving the method to set the base writing direction from Frame to Editor
411
412         * WebView/WebHTMLView.mm:
413         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
414         Editor method.
415         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
416         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
417
418 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
419
420         Build fix: forgot to check in this file.
421
422         * WebView/WebScriptDebugger.mm:
423         (WebScriptDebugger::WebScriptDebugger):
424
425 2008-06-30  Dan Bernstein  <mitz@apple.com>
426
427         Reviewed by Adele Peterson.
428
429         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
430
431         * WebView/WebHTMLView.mm:
432         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
433         WebCore::Frame::setSelectionBaseWritingDirection() instead of
434         WebCore::Editor::setBaseWritingDirection().
435         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
436         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
437
438 2008-06-28  Darin Adler  <darin@apple.com>
439
440         - fix build
441
442         * WebView/WebView.mm:
443         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
444
445 2008-06-26  Anders Carlsson  <andersca@apple.com>
446
447         Reviewed by Darin.
448
449         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
450         if necessary. Use this for the WebView class. 
451                 
452         * WebView/MainThreadObjectDeallocator.h: Added.
453         * WebView/MainThreadObjectDeallocator.mm: Added.
454         (deallocCallback):
455         (scheduleDeallocateOnMainThread):
456         * WebView/WebView.mm:
457         (-[WebViewPrivate dealloc]):
458         (+[WebView initialize]):
459
460 2008-06-25  Anders Carlsson  <andersca@apple.com>
461
462         Reviewed by Mark.
463
464         <rdar://problem/5984270> 
465         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
466         
467         * WebView/WebView.mm:
468         (tigerMailReleaseIMP):
469         New method that makes sure that the final release happens on the main thread.
470         
471         (-[WebView release]):
472         New method that just calls [super release];
473         
474         (+[WebView initialize]):
475         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
476
477 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
478
479         Reviewed by Geoff.
480
481         Make Machine per-JSGlobalData.
482
483         * WebView/WebScriptDebugger.mm:
484         (WebScriptDebugger::WebScriptDebugger):
485
486 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
487
488         Reviewed by Darin.
489
490         Prepare JavaScript heap for being per-thread.
491
492         * Misc/WebCoreStatistics.mm:
493         (+[WebCoreStatistics javaScriptObjectsCount]):
494         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
495         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
496         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
497         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
498         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
499         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
500
501 2008-06-17  Darin Adler  <darin@apple.com>
502
503         Reviewed by Sam.
504
505         * WebView/WebHTMLView.mm:
506         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
507         to create a CSSMutableStyleDeclaration.
508
509 2008-06-16  Mark Rowe  <mrowe@apple.com>
510
511         Reviewed by Darin Adler.
512
513         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
514
515         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
516         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
517         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
518         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
519
520         * WebView/WebHTMLView.mm:
521         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
522         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
523         * WebView/WebHTMLViewInternal.h:
524         * WebView/WebHTMLViewPrivate.h:
525
526 2008-06-15  Darin Adler  <darin@apple.com>
527
528         - give Frame object functions shorter names: scriptProxy() -> script(),
529           selectionController() -> selection(), animationController() -> animation()
530
531         * Plugins/WebPluginController.mm:
532         (-[WebPluginController webPlugInContainerSelectionColor]):
533         * WebView/WebFrame.mm:
534         (-[WebFrame _attachScriptDebugger]):
535         (-[WebFrame _hasSelection]):
536         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
537         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
538         (-[WebFrame _convertToNSRange:]):
539         (-[WebFrame _convertToDOMRange:]):
540         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
541         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
542         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
543         (-[WebFrame _selectedNSRange]):
544         (-[WebFrame _selectNSRange:]):
545         (-[WebFrame globalContext]):
546         * WebView/WebHTMLView.mm:
547         (-[WebHTMLView _selectedRange]):
548         (-[WebHTMLView _hasSelection]):
549         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
550         (-[WebHTMLView _hasInsertionPoint]):
551         (-[WebHTMLView _isEditable]):
552         (-[WebHTMLView _updateFocusedAndActiveState]):
553         (-[WebHTMLView readSelectionFromPasteboard:]):
554         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
555         (-[WebHTMLView maintainsInactiveSelection]):
556         (-[WebHTMLView paste:]):
557         (isTextInput):
558         (-[WebHTMLView inputContext]):
559         (-[WebTextCompleteController doCompletion]):
560         (-[WebHTMLView selectAll]):
561         (-[WebHTMLView deselectAll]):
562         (-[WebHTMLView selectedAttributedString]):
563         * WebView/WebView.mm:
564         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
565         (-[WebView setSelectedDOMRange:affinity:]):
566         (-[WebView selectedDOMRange]):
567         (-[WebView selectionAffinity]):
568
569 2008-06-15  Darin Adler  <darin@apple.com>
570
571         - rename KJS::List to KJS::ArgList
572
573         * WebView/WebScriptDebugger.h:
574
575 2008-06-15  Darin Adler  <darin@apple.com>
576
577         - new names for more JavaScriptCore files
578
579         * WebView/WebView.mm:
580
581 2008-06-15  Darin Adler  <darin@apple.com>
582
583         - new names for a few key JavaScriptCore files
584
585         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
586         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
587         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
588         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
589         * ForwardingHeaders/kjs/function.h: Removed.
590         * ForwardingHeaders/kjs/internal.h: Removed.
591         * ForwardingHeaders/kjs/object.h: Removed.
592         * ForwardingHeaders/kjs/value.h: Removed.
593         * WebView/WebScriptDebugDelegate.mm:
594
595 2008-06-15  Darin Adler  <darin@apple.com>
596
597         Rubber stamped by Sam.
598
599         - use JS prefix and simpler names for basic JavaScriptCore types,
600           to complement JSValue and JSObject
601
602         * WebView/WebView.mm:
603         (aeDescFromJSValue):
604
605 2008-06-14  Darin Adler  <darin@apple.com>
606
607         Rubber stamped by Sam.
608
609         - new names for kjs_binding.h and kjs_proxy.h
610
611         * WebView/WebFrame.mm:
612         * WebView/WebScriptDebugDelegate.mm:
613         * WebView/WebView.mm:
614
615 2008-06-14  Darin Adler  <darin@apple.com>
616
617         Rubber stamped by Sam.
618
619         - renamed HTMLGenericFormElement to HTMLFormControlElement
620
621         * WebView/WebHTMLRepresentation.mm:
622         (-[WebHTMLRepresentation elementWithName:inForm:]):
623         (-[WebHTMLRepresentation controlsInForm:]):
624
625 2008-06-14  Darin Adler  <darin@apple.com>
626
627         Reviewed by Sam.
628
629         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
630           start ref counts at 1 instead of 0 for speed
631
632         * WebCoreSupport/WebFrameLoaderClient.mm:
633         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
634         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
635         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
636         conventional ones without a special case.
637
638         * WebView/WebDataSource.mm:
639         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
640         this function takes ownership of the DocumentLoader.
641         (-[WebDataSource initWithRequest:]): Use create instead of new.
642         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
643         PassRefPtr and also cleaned up the header a bit.
644
645         * WebView/WebDocumentLoaderMac.h:
646         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
647         functions private.
648
649         * WebView/WebFrame.mm:
650         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
651         of new.
652
653 2008-06-14  Darin Adler  <darin@apple.com>
654
655         Reviewed by Sam.
656
657         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
658           start ref counts at 1 instead of 0 for speed
659
660         * WebView/WebFrame.mm:
661         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
662         * WebView/WebPDFView.mm:
663         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
664
665 2008-06-13  Darin Adler  <darin@apple.com>
666
667         Reviewed by John Sullivan.
668
669         - updated for addition of FormState argument to action policy functions
670         - added WebActionFormKey
671
672         * WebCoreSupport/WebFrameLoaderClient.h:
673         * WebCoreSupport/WebFrameLoaderClient.mm:
674         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
675         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
676         (WebFrameLoaderClient::actionDictionary):
677         * WebKit.exp:
678         * WebView/WebPolicyDelegate.mm:
679         * WebView/WebPolicyDelegatePrivate.h:
680
681 2008-06-12  John Sullivan  <sullivan@apple.com>
682
683         Reviewed by Dan and Darin
684
685         Clear up the confusion about _close (older private method) vs -close (newer public method).
686
687         * WebView/WebView.mm:
688         (-[WebView _isClosed]):
689         simplified style
690         (-[WebView _close]):
691         added a comment about how clients and subclasses should use -close instead
692         (-[WebView dealloc]):
693         call -close instead of _close, so subclasses that override the public method will have the intended behavior
694         (-[WebView close]):
695         added a comment
696         (-[WebView _windowWillClose:]):
697         call -close instead of _close, so subclasses that override the public method will have the intended behavior
698
699         * WebView/WebViewPrivate.h:
700         added a comment about how clients and subclasses should use -close instead
701
702 2008-06-07  Darin Adler  <darin@apple.com>
703
704         Reviewed by Mitz.
705
706         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
707           start ref counts at 1 instead of 0 for speed
708
709         * History/WebHistoryItem.mm:
710         (-[WebHistoryItem init]):
711         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
712         (-[WebHistoryItem initWithURL:target:parent:title:]):
713         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
714         * WebView/WebView.mm:
715         (+[WebView _decodeData:]):
716
717 2008-06-03  Oliver Hunt  <oliver@apple.com>
718
719         Reviewed by Tim.
720
721         Bug 12983: Web Inspector break on the debugger keyword
722         <https://bugs.webkit.org/show_bug.cgi?id=12983>
723
724         Add stubs to allow old webkit debugger interface to build.
725
726         * WebView/WebScriptDebugger.h:
727         * WebView/WebScriptDebugger.mm:
728
729 2008-06-03  Anders Carlsson  <andersca@apple.com>
730
731         Reviewed by Darin.
732
733         <rdar://problem/5980961>
734         
735         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
736         newBottom to be larger than oldBottom which is illegal.
737         
738         * WebView/WebHTMLView.mm:
739         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
740
741 2008-06-02  Anders Carlsson  <andersca@apple.com>
742
743         Reviewed by Mitz.
744
745         Speculative fix for <rdar://problem/5661112> 
746         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
747         
748         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
749         layouts to be triggered.
750         
751         * Plugins/WebBaseNetscapePluginView.mm:
752         (-[WebBaseNetscapePluginView _createPlugin]):
753
754 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
755
756         Reviewed by Darin.
757         
758         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
759         
760         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
761         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
762         setting and retrieving pasteboard types with UTIs, but we don't know of any
763         applications on Tiger that put only PNG on the pasteboard.
764
765         * WebView/WebHTMLView.mm:
766         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
767         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
768
769 2008-05-29  Anders Carlsson  <andersca@apple.com>
770
771         Reviewed by Brady.
772
773         <rdar://problem/5970312> 
774         icon file specified for stand alone web app causes crash if the icon can't be found
775         
776         Handle the case where iconData is null.
777         
778         * Misc/WebIconFetcher.mm:
779         (WebIconFetcherClient::finishedFetchingIcon):
780
781 2008-05-29  Anders Carlsson  <andersca@apple.com>
782
783         Reviewed by Mitz.
784
785         <rdar://problem/5971845>
786         https://bugs.webkit.org/show_bug.cgi?id=19313
787         Add version member to NPCocoaEvent
788
789         Initialize the version member to 0 for all events.
790         
791         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
792         (initializeEvent):
793         (WebNetscapePluginEventHandlerCocoa::drawRect):
794         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
795         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
796         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
797         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
798         (WebNetscapePluginEventHandlerCocoa::focusChanged):
799
800 2008-05-29  Dan Bernstein  <mitz@apple.com>
801
802         Reviewed by Jessica Kahn.
803
804         - fix <rdar://problem/5965013> Page 2 does not print correctly
805
806         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
807         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
808         -viewWillDraw being sent first, which could lead to painting without
809         valid layout. The fix is to ensure up-to-date layout in those methods
810         when printing.
811
812         * WebView/WebHTMLView.mm:
813         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
814         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
815
816 2008-05-28  Anders Carlsson  <andersca@apple.com>
817
818         Reviewed by Jon.
819
820         Remove workaround, this is no longer a problem.
821         
822         * WebView/WebView.mm:
823         (-[WebView _removeObjectForIdentifier:]):
824
825 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
826
827         Reviewed by Tim Hatcher.
828         
829         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
830         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
831         clicking button in returnEvent-crash.html
832         
833         Added implementations for willExecuteProgram and didExecuteProgram, which
834         take care of making sure we're not hanging on to stale data.
835
836 2008-05-27  Timothy Hatcher  <timothy@apple.com>
837
838         Fixes a bug where unplugging the monitor from a video card and
839         moving it to another video card would no longer show OpenGL plugins
840         until you relaunched Safari.
841
842         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
843         attribute to OpenGL contexts
844
845         Reviewed by Kevin Decker.
846
847         * Plugins/WebBaseNetscapePluginView.mm:
848         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
849         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
850         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
851
852 2008-05-25  Mark Rowe  <mrowe@apple.com>
853
854         Reviewed by Darin Adler.
855
856         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
857
858         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
859         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
860
861         * WebView/WebFrame.mm:
862         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
863         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
864         * WebView/WebFrameInternal.h:
865         * WebView/WebFramePrivate.h:
866
867 2008-05-23  Timothy Hatcher  <timothy@apple.com>
868
869         Fix attaching and detaching the Web Inspector. This change removes
870         the clunky animation that never looked right and was causing issues
871         where the inspected WebView would get into a no useable state.
872
873         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
874         can cause the inspected WebVIew to be unusable
875
876         Reviewed by Adam Roben.
877
878         * WebCoreSupport/WebInspectorClient.mm:
879         (-[WebInspectorWindowController close]): Removes animation code.
880         Sets the frame directly and does a displayIfNeeded to prevent
881         showing the Inspector in the page and in the Inspector window.
882         (-[WebInspectorWindowController showWindow:]): Removes animation code.
883         Sets the frame directly.
884         (-[WebInspectorWindowController attach]): Simplified.
885         (-[WebInspectorWindowController detach]): Ditto.
886
887 2008-05-22  Dan Bernstein  <mitz@apple.com>
888
889         Reviewed by Darin Adler.
890
891         - fix broken documentation of
892           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
893
894         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
895         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
896
897 2008-05-22  Timothy Hatcher  <timothy@apple.com>
898
899         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
900
901         Reviewed by Adam Roben.
902
903         * WebCoreSupport/WebInspectorClient.mm:
904         (-[WebInspectorWindowController showWebInspector:]):
905         (-[WebInspectorWindowController showErrorConsole:]):
906         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
907         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
908         (-[WebInspectorWindowController validateUserInterfaceItem:]):
909         * WebInspector/WebInspector.h:
910         * WebInspector/WebInspector.mm:
911         (-[WebInspector showConsole:]):
912         (-[WebInspector showTimeline:]):
913         (-[WebInspector isDebuggingJavaScript]):
914         (-[WebInspector toggleDebuggingJavaScript:]):
915         (-[WebInspector startDebuggingJavaScript:]):
916         (-[WebInspector stopDebuggingJavaScript:]):
917         (-[WebInspector isProfilingJavaScript]):
918         (-[WebInspector toggleProfilingJavaScript:]):
919         (-[WebInspector startProfilingJavaScript:]):
920         (-[WebInspector stopProfilingJavaScript:]):
921
922 2008-05-22  Josh Aas  <joshmoz@gmail.com>
923
924         Reviewed by Anders.
925
926         <rdar://problem/5956429> 
927         https://bugs.webkit.org/show_bug.cgi?id=19192
928         remove NPNVpluginEventModel, fix example plugin
929         
930         * Plugins/WebBaseNetscapePluginView.mm:
931         (-[WebBaseNetscapePluginView getVariable:value:]):
932
933 2008-05-21  Anders Carlsson  <andersca@apple.com>
934
935         Reviewed by Maciej.
936
937         Add WebIconFetcher.
938         
939         * Misc/WebIconFetcher.h: Added.
940         * Misc/WebIconFetcher.mm: Added.
941         (WebIconFetcherClient::WebIconFetcherClient):
942         (WebIconFetcherClient::finishedFetchingIcon):
943         (WebIconFetcherClient::setFetcher):
944         (-[WebIconFetcher init]):
945         (-[WebIconFetcher dealloc]):
946         (-[WebIconFetcher finalize]):
947         (-[WebIconFetcher cancel]):
948         (-[WebIconFetcher _initWithIconFetcher:client:]):
949         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
950         * Misc/WebIconFetcherInternal.h: Added.
951         * WebView/WebFrame.mm:
952         (-[WebFrame fetchApplicationIcon:selector:]):
953         * WebView/WebFramePrivate.h:
954
955 === End merge of squirrelfish ===
956
957 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
958
959         Reviewed by Tim Hatcher.
960         
961         Updated for API changes from merging with trunk WebCore's new debugger.
962
963         * WebView/WebScriptDebugDelegate.mm:
964         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
965         exception return, since the DebuggerCallFrame no longer automatically
966         substitutes the exception for the return value.
967
968         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
969         lexical global object, since the debugger attaches based on dynamic
970         global object.
971
972 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
973
974         Reviewed by Oliver Hunt.
975         
976         Re-enabled previously disabled debugging functionality.
977         
978         There are two major changes from how the WebKit debugger used to work:
979         
980         (1) All the interesting bits are implemented down in JavaScriptCore. The
981         debugger just calls through to KJS::DebuggerCallFrame for everything.
982         
983         (2) Instead of copyihng a pointer to an ExecState once, the debugger
984         copies the DebuggerCallFrame passed to it in each callback. This is
985         because the VM no longer maintains a fully transparent execution state
986         to which you can hold a pointer, and the DebuggerCallFrames it vends
987         are temporaries.
988         
989         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
990         from its function. This is safer than the old method, which was to
991         hold a stale ExecState* and hope for the best.
992
993 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
994
995         Reviewed by Oliver Hunt.
996
997         Updated for API changes in KJS::Debugger.
998
999         * WebView/WebFrame.mm:
1000         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
1001         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
1002
1003 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1004
1005         Reviewed by Oliver Hunt.
1006         
1007         Updated WebScriptDebugger API to accept a SourceProvider instead
1008         of a WebCore::String, to avoid copying.
1009
1010         (WebScriptDebugger::sourceParsed): Updated this function not to return
1011         a value.
1012
1013 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1014
1015         Build fix: #ifdef'd out some code that doesn't work anymore.
1016
1017 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1018
1019         Reviewed by Oliver Hunt.
1020         
1021         #ifdef'd out some debugger code that doesn't work anymore.
1022
1023         * WebView/WebScriptDebugDelegate.mm:
1024         (-[WebScriptCallFrame scopeChain]):
1025
1026 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
1027
1028         Build fix.
1029
1030         * ChangeLog:
1031         * WebView/WebScriptDebugDelegate.mm:
1032         (-[WebScriptCallFrame scopeChain]):
1033
1034 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
1035
1036         Reviewed by Oliver Hunt.
1037         
1038         Build fix.
1039
1040 === Start merge of squirrelfish ===
1041
1042 2008-05-21  Darin Adler  <darin@apple.com>
1043
1044         - fix build
1045
1046         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
1047         if we want, but if we do, we should probably make some refinements like checking _private->closed
1048         and applicationIsTerminating.
1049
1050 2008-05-21  Darin Adler  <darin@apple.com>
1051
1052         Reviewed by Anders and Kevin Decker.
1053
1054         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
1055
1056         * WebView/WebView.mm:
1057         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
1058         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
1059         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
1060         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
1061         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
1062
1063 2008-05-19  Stephanie Lewis  <slewis@apple.com>
1064
1065         Reviewed by Darin.
1066     
1067         more fast teardown performance work
1068
1069         * Misc/WebDownload.m:
1070         (-[WebDownloadInternal downloadDidBegin:]):
1071         (-[WebDownloadInternal downloadDidFinish:]):
1072         (-[WebDownloadInternal download:didFailWithError:]):
1073         * WebCoreSupport/WebChromeClient.h:
1074         * WebCoreSupport/WebChromeClient.mm:
1075         (WebChromeClient::disableSuddenTermination):
1076         (WebChromeClient::enableSuddenTermination):
1077
1078 2008-05-18  Dan Bernstein  <mitz@apple.com>
1079
1080         Reviewed by Sam Weinig.
1081
1082         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
1083
1084         * Panels/WebAuthenticationPanel.m:
1085         (-[WebAuthenticationPanel setUpForChallenge:]):
1086
1087 2008-05-16  Timothy Hatcher  <timothy@apple.com>
1088
1089         Removes WebScriptDebugServer files and related calls. This removes
1090         the hooks that Drosera uses for debugging. Now that the Web Inspector
1091         has a better debugger, we don't need these anymore.
1092
1093         Reviewed by Sam Weinig.
1094
1095         * DefaultDelegates/WebScriptDebugServer.h: Removed.
1096         * DefaultDelegates/WebScriptDebugServer.m: Removed.
1097         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
1098         * WebCoreSupport/WebFrameLoaderClient.mm:
1099         * WebKit.exp:
1100         * WebView/WebScriptDebugDelegate.mm:
1101         * WebView/WebScriptDebugger.mm:
1102         (WebScriptDebugger::sourceParsed):
1103         (WebScriptDebugger::callEvent):
1104         (WebScriptDebugger::atStatement):
1105         (WebScriptDebugger::returnEvent):
1106         (WebScriptDebugger::exception):
1107         * WebView/WebView.mm:
1108         (-[WebView _commonInitializationWithFrameName:groupName:]):
1109         * WebView/WebViewPrivate.h:
1110
1111 2008-05-16  Brady Eidson  <beidson@apple.com>
1112
1113         Reviewed by Anders
1114
1115         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
1116
1117         Took the opportunity to touch up another pref that needs the same standardization.
1118         That pref is currently not in use on Mac.
1119
1120         * WebView/WebPreferences.m:
1121         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
1122         (-[WebPreferences _localStorageDatabasePath]):
1123         (-[WebPreferences _setLocalStorageDatabasePath:]):
1124         (-[WebPreferences _ftpDirectoryTemplatePath]):
1125
1126 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
1127
1128         Reviewed by Alice Liu
1129
1130         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
1131
1132         * WebView/WebFrame.mm:
1133         (-[WebFrame _accessibilityTree]):
1134
1135 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1136         
1137         fix mac build
1138
1139         * WebView/WebView.mm:
1140         (-[WebView closeWithFastTeardown]):
1141
1142 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1143
1144         Reviewed by Anders.
1145
1146         Turn on fast teardown.  I added a preference for using full teardown because 
1147         the LEAKS output will be useless without a full teardown.  
1148
1149         preference for fullteardown
1150         * WebView/WebPreferenceKeysPrivate.h:
1151         * WebView/WebPreferences.m:
1152         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1153         (-[WebPreferences fullDocumentTeardownEnabled]):
1154         * WebView/WebPreferencesPrivate.h:
1155         
1156         on application quit dispatch unload events and destroy plugins then exit
1157         * WebView/WebView.mm:
1158         (-[WebView closeWithFastTeardown]):
1159         (-[WebView _close]):
1160         * WebView/WebViewPrivate.h:
1161
1162 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1163
1164         Reviewed by Anders.
1165
1166         get the pending frame unload count from WebCore
1167
1168         * WebView/WebFrame.mm:
1169         (-[WebFrame _pendingFrameUnloadEventCount]):
1170         * WebView/WebFramePrivate.h:
1171
1172 2008-05-15  John Sullivan  <sullivan@apple.com>
1173
1174         Reviewed by Kevin Decker
1175         
1176         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1177           screen when new tab appears
1178           
1179         The highlight should go away entirely, but this simple patch just makes it not jump away.
1180         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1181
1182         * WebInspector/WebNodeHighlight.m:
1183         (-[WebNodeHighlight _repositionHighlightWindow]):
1184         Bail out if target view isn't in a window
1185
1186 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1187
1188         Reviewed by Anders.
1189
1190         Track views that contain plugin instances so that they can be destroyed at application
1191         quit without walking the entire document tree.
1192
1193         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1194         plugins are created and destroyed
1195         * Plugins/WebBaseNetscapePluginView.mm:
1196         (-[WebBaseNetscapePluginView start]):
1197         (-[WebBaseNetscapePluginView stop]):
1198  
1199         Add/remove WebKit plugin views from instance list
1200         * Plugins/WebPluginController.mm:
1201         (-[WebPluginController addPlugin:]):
1202         (-[WebPluginController destroyPlugin:]):
1203         (-[WebPluginController destroyAllPlugins]):
1204
1205         Add a set of views with plugin instances to the WebPluginDatabase
1206         * Plugins/WebPluginDatabase.h:
1207         * Plugins/WebPluginDatabase.mm:
1208         (-[WebPluginDatabase init]):
1209         (-[WebPluginDatabase dealloc]):
1210         (-[WebPluginDatabase addPluginInstanceView:]):
1211         (-[WebPluginDatabase removePluginInstanceView:]):
1212         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1213         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1214         
1215         Handle cases where plugin views are detached before the plugin is destroyed.
1216         * WebCoreSupport/WebFrameLoaderClient.mm:
1217         (WebFrameLoaderClient::detachedFromParent2):
1218         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1219         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1220
1221         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1222         * WebView/WebHTMLView.mm:
1223         (-[WebHTMLView _destroyAllWebPlugins]):
1224         * WebView/WebHTMLViewInternal.h:
1225         * WebView/WebView.mm:
1226         (-[WebView addPluginInstanceView:]):
1227         (-[WebView removePluginInstanceView:]):
1228         (-[WebView removePluginInstanceViewsFor:]):
1229         * WebView/WebViewInternal.h:
1230
1231 2008-05-15  Brady Eidson  <beidson@apple.com>
1232
1233         Reviewed by Tim Hatcher
1234
1235         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1236         before setting the page group of the new page.
1237         
1238         * WebView/WebView.mm:
1239         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1240           immediately after creating the page so it is in place for initializing the LocalStorageThread
1241
1242 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1243
1244         Fixes the bug where the Web Inspector would flash white while resizing.
1245         This was cause by deferring the window creation.
1246
1247         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1248
1249         Reviewed by Darin Adler.
1250
1251         * WebCoreSupport/WebInspectorClient.mm:
1252         (-[WebInspectorWindowController window]): Don't defer the window creation.
1253
1254 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1255
1256         Tiger build fix.
1257
1258         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1259
1260 2008-05-15  Adele Peterson  <adele@apple.com>
1261
1262         Reviewed and landed by Alexey.
1263
1264         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1265
1266         * Misc/WebNSAttributedStringExtras.mm:
1267         (+[NSAttributedString _web_attributedStringFromRange:]):
1268
1269 2008-05-14  Eric Seidel  <eric@webkit.org>
1270
1271         Reviewed by Oliver.
1272
1273         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1274
1275         * WebView/WebResource.mm:
1276         (-[WebResource data]):
1277
1278 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1279
1280         Reviewed by Dan Bernstein.
1281
1282         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1283
1284         * Plugins/nptextinput.h:
1285
1286 2008-05-13  Anders Carlsson  <andersca@apple.com>
1287
1288         Reviewed by Sam.
1289
1290         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1291         Instead, do it in [WebCache empty].
1292         
1293         * Misc/WebCache.mm:
1294         (+[WebCache empty]):
1295         * WebView/WebView.mm:
1296         (+[WebView _setCacheModel:]):
1297
1298 2008-05-13  chris fleizach  <cfleizach@apple.com>
1299
1300         Reviewed by Beth Dakin
1301
1302         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1303
1304         * WebCoreSupport/WebViewFactory.mm:
1305         (-[WebViewFactory AXWebAreaText]):
1306
1307 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1308
1309         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1310         was referencing a nil WebView under validateUserInterfaceItem.
1311         The validateUserInterfaceItem methods was being called at a time
1312         when the WebHTMLView is being torndown.
1313
1314         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1315         while mousing down on menu bar after Xcode News window is opened
1316
1317         Reviewed by Ada Chan.
1318
1319         * WebView/WebHTMLView.mm:
1320         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1321         return NO when it is nil. Adds a comment.
1322         * WebView/WebPDFView.mm:
1323         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1324
1325 2008-05-13  Mark Rowe  <mrowe@apple.com>
1326
1327         Reviewed by John Sullivan.
1328
1329         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1330
1331         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1332         * Carbon/HIWebView.m: Ditto.
1333         (HIWebViewCreate):
1334         (HIWebViewConstructor):
1335
1336 2008-05-12  Dan Bernstein  <mitz@apple.com>
1337
1338         Reviewed by Ada Chan.
1339
1340         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1341           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1342
1343         Added font cache statistics and a function to purge inactive font data.
1344
1345         * Misc/WebCoreStatistics.h:
1346         * Misc/WebCoreStatistics.mm:
1347         (+[WebCoreStatistics cachedFontDataCount]):
1348         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1349         (+[WebCoreStatistics purgeInactiveFontData]):
1350         (+[WebCoreStatistics glyphPageCount]):
1351
1352 2008-05-12  Mark Rowe  <mrowe@apple.com>
1353
1354         Reviewed by Tim Hatcher.
1355
1356         Decorate some deprecated delegate methods with the availability macros.
1357
1358         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1359         macros is good for consistency and documentation.
1360
1361         * WebView/WebFrameLoadDelegate.h:
1362         * WebView/WebUIDelegate.h:
1363
1364 2008-05-12  Mark Rowe  <mrowe@apple.com>
1365
1366         Reviewed by Tim Hatcher.
1367
1368         <rdar://problem/5835604> Deprecate HIWebView
1369
1370         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1371
1372         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1373         * Carbon/HIWebView.h: Ditto.
1374
1375 2008-05-12  Kevin Decker  <kdecker@apple.com>
1376
1377         Reviewed by Anders.
1378
1379         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1380         
1381         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
1382         in changeset <http://trac.webkit.org/changeset/31028>
1383         
1384         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
1385         * WebView/WebFrame.mm:
1386         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
1387         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
1388         * WebView/WebFrameInternal.h: Ditto.
1389         * WebView/WebHTMLView.mm: Ditto.
1390         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
1391         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1392         * WebView/WebHTMLViewInternal.h: Ditto.
1393         * WebView/WebHTMLViewPrivate.h: Ditto.
1394
1395 2008-05-12  Anders Carlsson  <andersca@apple.com>
1396
1397         Reviewed by Alexey.
1398
1399         Empty the application cache when changing the cache model.
1400         
1401         * WebView/WebView.mm:
1402         (+[WebView _setCacheModel:]):
1403
1404 2008-05-12  Anders Carlsson  <andersca@apple.com>
1405
1406         Reviewed by Oliver.
1407
1408         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
1409         
1410         * Plugins/WebBaseNetscapePluginView.h:
1411         * Plugins/WebBaseNetscapePluginView.mm:
1412         (-[WebBaseNetscapePluginView start]):
1413         Get the plug-in text input vtable pointer.
1414         
1415         (-[WebBaseNetscapePluginView stop]):
1416         Set the plug-in text input vtable pointer to 0.
1417         
1418         (-[WebBaseNetscapePluginView inputContext]):
1419         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
1420         
1421         (-[WebBaseNetscapePluginView hasMarkedText]):        
1422         (-[WebBaseNetscapePluginView insertText:]):
1423         (-[WebBaseNetscapePluginView markedRange]):
1424         (-[WebBaseNetscapePluginView selectedRange]):
1425         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
1426         (-[WebBaseNetscapePluginView unmarkText]):
1427         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
1428         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
1429         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
1430         (-[WebBaseNetscapePluginView doCommandBySelector:]):
1431         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
1432         (-[WebBaseNetscapePluginView conversationIdentifier]):
1433         Implement NSTextInput and call into the plug-in text input vtable.
1434         
1435         (browserTextInputFuncs):
1436         New method which returns the browser input vtable.
1437         
1438         (-[WebBaseNetscapePluginView getVariable:value:]):
1439         Support getting the browser input vtable pointer.
1440         
1441         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1442         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1443         (WebNetscapePluginEventHandlerCocoa::keyDown):
1444         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1445         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
1446         it means that the event should be passed on to the input manager.
1447          
1448         * Plugins/npapi.mm:
1449         (NPN_MarkedTextAbandoned):
1450         (NPN_MarkedTextSelectionChanged):
1451         Add implementations of browser input method methods.
1452         
1453         * Plugins/nptextinput.h: Added.
1454         Add file with new text input API.
1455
1456 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
1457
1458         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
1459         SquirrelFish merging.
1460
1461         * Misc/WebCoreStatistics.mm:
1462         (+[WebCoreStatistics javaScriptObjectsCount]):
1463         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1464         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1465         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1466         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1467         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1468         * WebView/WebScriptDebugDelegate.mm:
1469         (-[WebScriptCallFrame evaluateWebScript:]):
1470
1471 2008-05-07  Anders Carlsson  <andersca@apple.com>
1472
1473         Reviewed by Mitz.
1474
1475         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
1476         https://bugs.webkit.org/show_bug.cgi?id=18880
1477         <rdar://problem/5909513>
1478
1479         Stop suspending key up events before calling handleEvent.
1480         
1481         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1482         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1483
1484 2008-05-06  Stephanie Lewis  <slewis@apple.com>
1485
1486         Reviewed by Andersca.
1487
1488         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
1489
1490         * Plugins/WebPluginDatabase.m: Removed.
1491         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
1492         * Plugins/npapi.m: Removed.
1493         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
1494
1495 2008-05-06  Anders Carlsson  <andersca@apple.com>
1496
1497         Reviewed by Darin.
1498
1499         Initialize numArchs to 0.
1500         
1501         * Plugins/WebBasePluginPackage.m:
1502         (-[WebBasePluginPackage isNativeLibraryData:]):
1503
1504 2008-05-06  Anders Carlsson  <andersca@apple.com>
1505
1506         Reviewed by Darin.
1507
1508         Add implementation of NPN_PopUpContextMenu.
1509         
1510         * Plugins/WebBaseNetscapePluginView.mm:
1511         (-[WebBaseNetscapePluginView popUpContextMenu:]):
1512         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1513         * Plugins/WebNetscapePluginPackage.m:
1514         (-[WebNetscapePluginPackage load]):
1515         * Plugins/npapi.m:
1516         (NPN_PopUpContextMenu):
1517
1518 2008-05-06  Anders Carlsson  <andersca@apple.com>
1519
1520         Fix typo (don't read random memory).
1521         
1522         * Plugins/WebBasePluginPackage.m:
1523         (-[WebBasePluginPackage isNativeLibraryData:]):
1524
1525 2008-05-05  Anders Carlsson  <andersca@apple.com>
1526
1527         Reviewed by Darin.
1528
1529         Change the isNativeLibraryData: method to handle universal binaries.
1530         
1531         * Plugins/WebBasePluginPackage.m:
1532         (swapIntsInHeader):
1533         (-[WebBasePluginPackage isNativeLibraryData:]):
1534
1535 2008-05-06  Brady Eidson  <beidson@apple.com>
1536
1537         Reviewed by Darin Adler
1538
1539         Preparation for upcoming work making LocalStorage persistent.
1540
1541         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
1542
1543         * WebView/WebView.mm:
1544         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
1545
1546 2008-05-05  Sam Weinig  <sam@webkit.org>
1547
1548         Reviewed by Darin Adler.
1549
1550         Fix for <rdar://problem/5884383>
1551         Escape look-a-like characters from the the entire url.
1552
1553         * Misc/WebNSURLExtras.mm:
1554         (escapeUnsafeCharacters):
1555         (-[NSURL _web_userVisibleString]):
1556
1557 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
1558
1559         Reviewed by Darin.
1560         
1561         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
1562
1563         * WebView/WebView.mm:
1564         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
1565         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
1566         the two interfere.
1567
1568 2008-05-05  Sam Weinig  <sam@webkit.org>
1569
1570         Reviewed by Tim Hatcher.
1571
1572         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
1573
1574         * WebCoreSupport/WebInspectorClient.mm:
1575         (WebInspectorClient::localizedStringsURL):
1576
1577 2008-05-05  Anders Carlsson  <andersca@apple.com>
1578
1579         Reviewed by Jess.
1580
1581         Apparently preflighting can cause hangs for some reason. Revert this for now.
1582         
1583         * Plugins/WebNetscapePluginPackage.m:
1584         (-[WebNetscapePluginPackage _initWithPath:]):
1585         * Plugins/WebPluginPackage.m:
1586         (-[WebPluginPackage initWithPath:]):
1587
1588 2008-05-05  Darin Adler  <darin@apple.com>
1589
1590         Reviewed by Mitz.
1591
1592         - https://bugs.webkit.org/show_bug.cgi?id=18789
1593           fix some shouldCloseWithWindow edge cases
1594
1595         * WebView/WebView.mm:
1596         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
1597         NSWindowWillCloseNotification if the view was moved out of the window but still
1598         had that window set as the host window. Also make sure this function doesn't do
1599         anything if the WebView is already closed.
1600         (-[WebView setHostWindow:]): Ditto.
1601
1602 2008-05-04  David Kilzer  <ddkilzer@apple.com>
1603
1604         Make parameters match for WebChromeClient::addMessageToConsole()
1605
1606         Reviewed by John.
1607
1608         * WebCoreSupport/WebChromeClient.h:
1609         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
1610         to sourceURL to match implementation in WebChromeClient.mm.
1611
1612 2008-05-02  Anders Carlsson  <andersca@apple.com>
1613
1614         Reviewed by Mark.
1615
1616         Various Cocoa event model and 64-bit plug-in fixes.
1617         
1618         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1619         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1620         Set click count.
1621         
1622         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1623         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1624         Don't try to get the mouse location for keyboard events.
1625         
1626         * Plugins/WebPluginPackage.m:
1627         (-[WebPluginPackage initWithPath:]):
1628         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
1629
1630 2008-05-02  Anders Carlsson  <andersca@apple.com>
1631
1632         Reviewed by Sam.
1633
1634         The event union is now named.
1635         
1636         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1637         (WebNetscapePluginEventHandlerCocoa::drawRect):
1638         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1639         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1640         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1641         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1642         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1643
1644 2008-05-02  Anders Carlsson  <andersca@apple.com>
1645
1646         Reviewed by Mark.
1647
1648         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
1649         
1650         Call preflightAndReturnError on the bundle, which will check if any of the architectures
1651         in the bundle match the current architecture.
1652         
1653         * Plugins/WebNetscapePluginPackage.m:
1654         (-[WebNetscapePluginPackage _initWithPath:]):
1655
1656 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
1657
1658         Reviewed by Geoffrey Garen.
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=18826
1661         Make JavaScript heap per-thread
1662
1663         * Misc/WebCoreStatistics.mm:
1664         (+[WebCoreStatistics javaScriptObjectsCount]):
1665         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1666         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1667         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1668         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1669         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1670         Replaced static Collector calls with calls to a current thread's instance.
1671
1672         * WebView/WebScriptDebugDelegate.mm:
1673         (-[WebScriptCallFrame evaluateWebScript:]):
1674         Pass ExecState to jsString().
1675
1676 2008-05-01  Anders Carlsson  <andersca@apple.com>
1677
1678         Reviewed by Mark.
1679
1680         64-bit NPAPI plugin build fixes.
1681         
1682         * Plugins/WebBaseNetscapePluginView.mm:
1683         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1684         (-[WebBaseNetscapePluginView updateAndSetWindow]):
1685         (-[WebBaseNetscapePluginView start]):
1686         (-[WebBaseNetscapePluginView windowBecameKey:]):
1687         * Plugins/WebNetscapeDeprecatedFunctions.c:
1688         * Plugins/WebNetscapeDeprecatedFunctions.h:
1689         * Plugins/WebNetscapePluginEventHandler.mm:
1690         (WebNetscapePluginEventHandler::create):
1691         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1692         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1693         * Plugins/WebPluginDatabase.m:
1694         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
1695
1696 2008-05-01  Anders Carlsson  <andersca@apple.com>
1697
1698         Reviewed by Tim.
1699
1700         Remove duplicate npfunctions.h header from WebKit.
1701
1702         * MigrateHeaders.make:
1703         Migrate npfunctions.h
1704         
1705         * Plugins/npfunctions.h: Removed.
1706
1707 2008-05-01  Anders Carlsson  <andersca@apple.com>
1708
1709         Reviewed by John.
1710         
1711         Add null checks for the event handler.
1712         
1713         * Plugins/WebBaseNetscapePluginView.mm:
1714         (-[WebBaseNetscapePluginView stopTimers]):
1715         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1716
1717 2008-05-01  Anders Carlsson  <andersca@apple.com>
1718
1719         Fix 64-bit build.
1720         
1721         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1722         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1723         * WebCoreSupport/WebFrameLoaderClient.mm:
1724
1725 2008-05-01  Anders Carlsson  <andersca@apple.com>
1726
1727         Fix build.
1728         
1729         * Plugins/npfunctions.h:
1730
1731 2008-05-01  Anders Carlsson  <andersca@apple.com>
1732
1733         Reviewed by Adam.
1734
1735         Forward mouse move events to the Netscape plug-in view.
1736         
1737         * Plugins/WebBaseNetscapePluginView.h:
1738         * Plugins/WebBaseNetscapePluginView.mm:
1739         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1740         New method that just calls the current event handler.
1741         
1742         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1743         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1744         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
1745         don't work on it so don't call them.
1746         
1747         * WebCoreSupport/WebFrameLoaderClient.mm:
1748         (NetscapePluginWidget::NetscapePluginWidget):
1749         New Widget subclass to be used for Netscape plug-ins.
1750         
1751         (NetscapePluginWidget::handleEvent):
1752         Forward NSMouseMoved events to the plug-in.
1753         
1754         (WebFrameLoaderClient::createPlugin):
1755         Wrap the plug-in view in a NetscapePluginWidget.
1756
1757 2008-05-01  Alp Toker  <alp@nuanti.com>
1758
1759         Rubber-stamped by Anders.
1760
1761         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
1762         npapi.h.
1763
1764         Additional fix to use same signedness in npapi.h and Mac for the
1765         interval parameter.
1766
1767         * Plugins/WebBaseNetscapePluginView.h:
1768         * Plugins/WebBaseNetscapePluginView.mm:
1769         (PluginTimer::PluginTimer):
1770         (-[WebBaseNetscapePluginView stopTimers]):
1771         (-[WebBaseNetscapePluginView restartTimers]):
1772         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
1773         (-[WebBaseNetscapePluginView unscheduleTimer:]):
1774         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1775         * Plugins/npapi.m:
1776         (NPN_ScheduleTimer):
1777         (NPN_UnscheduleTimer):
1778         * Plugins/npfunctions.h:
1779
1780 2008-04-30  Anders Carlsson  <andersca@apple.com>
1781
1782         Reviewed by Adam.
1783
1784         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
1785         
1786         * Plugins/WebBaseNetscapePluginView.h:
1787         * Plugins/WebBaseNetscapePluginView.mm:
1788         (PluginTimer::PluginTimer):
1789         (PluginTimer::start):
1790         (PluginTimer::fired):
1791         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1792         (-[WebBaseNetscapePluginView stopTimers]):
1793         (-[WebBaseNetscapePluginView restartTimers]):
1794         (-[WebBaseNetscapePluginView scrollWheel:]):
1795         (-[WebBaseNetscapePluginView flagsChanged:]):
1796         (-[WebBaseNetscapePluginView start]):
1797         (-[WebBaseNetscapePluginView eventModel]):
1798         (-[WebBaseNetscapePluginView fini]):
1799         (-[WebBaseNetscapePluginView getVariable:value:]):
1800         (-[WebBaseNetscapePluginView setVariable:value:]):
1801         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
1802         (-[WebBaseNetscapePluginView unscheduleTimer:]):
1803         * Plugins/WebBaseNetscapePluginViewInternal.h:
1804         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1805         * Plugins/WebNetscapePluginEventHandler.h:
1806         * Plugins/WebNetscapePluginEventHandler.mm:
1807         (WebNetscapePluginEventHandler::create):
1808         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1809         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1810         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
1811         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
1812         (WebNetscapePluginEventHandlerCarbon::platformWindow):
1813         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
1814         (WebNetscapePluginEventHandlerCocoa::startTimers):
1815         (WebNetscapePluginEventHandlerCocoa::stopTimers):
1816         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
1817         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
1818         (WebNetscapePluginEventHandlerCocoa::drawRect):
1819         (WebNetscapePluginEventHandlerCocoa::mouseDown):
1820         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
1821         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
1822         (WebNetscapePluginEventHandlerCocoa::mouseExited):
1823         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
1824         (WebNetscapePluginEventHandlerCocoa::mouseUp):
1825         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
1826         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1827         (WebNetscapePluginEventHandlerCocoa::keyDown):
1828         (WebNetscapePluginEventHandlerCocoa::keyUp):
1829         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1830         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1831         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1832         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1833         (WebNetscapePluginEventHandlerCocoa::platformWindow):
1834         (WebNetscapePluginEventHandlerCocoa::sendEvent):
1835         * Plugins/WebNetscapePluginPackage.m:
1836         (-[WebNetscapePluginPackage load]):
1837         * Plugins/npapi.m:
1838         (NPN_ScheduleTimer):
1839         (NPN_UnscheduleTimer):
1840         * Plugins/npfunctions.h:
1841
1842 2008-04-30  Brady Eidson  <beidson@apple.com>
1843
1844         Fix my WebPreferences revert check-in
1845
1846         * WebView/WebView.mm:
1847         (-[WebView _preferencesChangedNotification:]):
1848
1849 2008-04-30  Brady Eidson  <beidson@apple.com>
1850
1851         Rubberstamped by John Sullivan
1852
1853         Revert the remainder of my original preferences changes from last week.
1854         They caused a massive PLT regression (too many notifications being sent out
1855         or listened to that weren't previously) and it's not in my schedule to refine
1856         the preferences code instead of working on my feature!
1857
1858         * WebView/WebView.mm:
1859         (-[WebView _updateSettingsFromPreferences:]):
1860         (-[WebView _commonInitializationWithFrameName:groupName:]):
1861
1862 2008-04-30  Anders Carlsson  <andersca@apple.com>
1863
1864         Fix the 64-bit build.
1865         
1866         * Plugins/WebNetscapePluginEventHandler.h:
1867         * Plugins/WebNetscapePluginEventHandler.mm:
1868         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1869         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1870
1871 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
1872
1873         BUILD FIX for Release build.
1874
1875         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1876         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
1877         separately so the compiler doesn't complain about an unused variable.
1878         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
1879
1880 2008-04-29  Anders Carlsson  <andersca@apple.com>
1881
1882         Reviewed by Adam.
1883
1884         Refactor the Carbon event handling code out into a separate class in preparation for adding
1885         the Cocoa event handling code.
1886         
1887         * Plugins/WebBaseNetscapePluginView.h:
1888         * Plugins/WebBaseNetscapePluginView.mm:
1889         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
1890         (-[WebBaseNetscapePluginView sendActivateEvent:]):
1891         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
1892         (-[WebBaseNetscapePluginView stopTimers]):
1893         (-[WebBaseNetscapePluginView restartTimers]):
1894         (-[WebBaseNetscapePluginView setHasFocus:]):
1895         (-[WebBaseNetscapePluginView mouseDown:]):
1896         (-[WebBaseNetscapePluginView mouseUp:]):
1897         (-[WebBaseNetscapePluginView mouseEntered:]):
1898         (-[WebBaseNetscapePluginView mouseExited:]):
1899         (-[WebBaseNetscapePluginView mouseDragged:]):
1900         (-[WebBaseNetscapePluginView keyUp:]):
1901         (-[WebBaseNetscapePluginView keyDown:]):
1902         (-[WebBaseNetscapePluginView cut:]):
1903         (-[WebBaseNetscapePluginView copy:]):
1904         (-[WebBaseNetscapePluginView paste:]):
1905         (-[WebBaseNetscapePluginView selectAll:]):
1906         (-[WebBaseNetscapePluginView start]):
1907         (-[WebBaseNetscapePluginView stop]):
1908         (-[WebBaseNetscapePluginView fini]):
1909         (-[WebBaseNetscapePluginView drawRect:]):
1910         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1911         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1912         (-[WebBaseNetscapePluginView windowBecameKey:]):
1913         (-[WebBaseNetscapePluginView windowResignedKey:]):
1914         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
1915         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
1916         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
1917         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
1918         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1919         (-[WebBaseNetscapePluginView _viewHasMoved]):
1920         * Plugins/WebBaseNetscapePluginViewInternal.h:
1921         * Plugins/WebNetscapePluginEmbeddedView.h:
1922         * Plugins/WebNetscapePluginEventHandler.h: Added.
1923         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
1924         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
1925         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
1926         * Plugins/WebNetscapePluginEventHandler.mm: Added.
1927         (WebNetscapePluginEventHandler::create):
1928         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
1929         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
1930         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
1931         (getCarbonEvent):
1932         (modifiersForEvent):
1933         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
1934         (WebNetscapePluginEventHandlerCarbon::drawRect):
1935         (WebNetscapePluginEventHandlerCarbon::mouseDown):
1936         (WebNetscapePluginEventHandlerCarbon::mouseUp):
1937         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
1938         (WebNetscapePluginEventHandlerCarbon::mouseExited):
1939         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
1940         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
1941         (WebNetscapePluginEventHandlerCarbon::keyDown):
1942         (keyMessageForEvent):
1943         (WebNetscapePluginEventHandlerCarbon::keyUp):
1944         (WebNetscapePluginEventHandlerCarbon::focusChanged):
1945         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
1946         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
1947         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
1948         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
1949         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
1950         (WebNetscapePluginEventHandlerCarbon::startTimers):
1951         (WebNetscapePluginEventHandlerCarbon::stopTimers):
1952         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1953
1954 2008-04-29  Mark Rowe  <mrowe@apple.com>
1955
1956         Reviewed by David Harrison.
1957
1958         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
1959
1960         * WebKit.exp:
1961         * WebView/WebDynamicScrollBarsView.h:
1962         * WebView/WebDynamicScrollBarsView.m:
1963
1964 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
1965
1966         Reviewed by Darin.
1967
1968         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
1969
1970         * WebCoreSupport/WebChromeClient.h:
1971         * WebCoreSupport/WebChromeClient.mm:
1972         * WebView/WebClipView.m:
1973         (-[WebClipView scrollWheel:]):
1974         * WebView/WebHTMLView.mm:
1975         (-[WebHTMLView addMouseMovedObserver]):
1976         (-[WebHTMLView removeMouseMovedObserver]):
1977         (-[WebHTMLView acceptsFirstMouse:]):
1978         * WebView/WebUIDelegatePrivate.h:
1979         * WebView/WebView.mm:
1980         (-[WebViewPrivate init]):
1981         * WebView/WebViewPrivate.h:
1982
1983 2008-04-28  Rob Buis  <buis@kde.org>
1984
1985         Reviewed by Maciej.
1986
1987         Build fix for Tiger.
1988
1989         * WebView/WebView.mm:
1990         (WebKitInitializeApplicationCachePathIfNecessary):
1991
1992 2008-04-28  Adele Peterson  <adele@apple.com>
1993
1994         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
1995
1996         WebKit part of fix for <rdar://problem/3709505>
1997         Safari should have a way to upload bundles from the file upload control (as zip)
1998
1999         Added UIDelegate methods to let the application handle generating replacement files for uploads.
2000         In this case, Safari will create archived files for bundles so they can be uploaded properly.
2001
2002         * DefaultDelegates/WebDefaultUIDelegate.m:
2003         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
2004         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
2005         * WebCoreSupport/WebChromeClient.h:
2006         * WebCoreSupport/WebChromeClient.mm:
2007         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
2008         (WebChromeClient::generateReplacementFile):
2009         * WebView/WebUIDelegatePrivate.h:
2010
2011 2008-04-28  Anders Carlsson  <andersca@apple.com>
2012
2013         Reviewed by Sam, Mark, Adele and Darin.
2014
2015         Initialize the application cache path.
2016         
2017         * WebView/WebView.mm:
2018         (WebKitInitializeApplicationCachePathIfNecessary):
2019         (-[WebView _commonInitializationWithFrameName:groupName:]):
2020
2021 2008-04-28  Alice Liu  <alice.liu@apple.com>
2022
2023         Reviewed by Darin.
2024
2025         Fix <rdar://problem/4911289> Add tabindex property to all children 
2026         of HTMLElement (7138)
2027         http://bugs.webkit.org/show_bug.cgi?id=7138
2028
2029         * MigrateHeaders.make:
2030         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
2031         because now that focus() has been moved to DOMHTMLElement.h, these
2032         files are no longer needed.
2033
2034 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2035
2036         Reviewed by Darin.
2037
2038         Fix run-webkit-tests --threading
2039         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
2040         Proxy server issue in Sunday's Nightly
2041
2042         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
2043         only done from icon database code, which is not robust enough.
2044
2045 2008-04-20 Adam Barth <hk9565@gmail.com>
2046
2047         Reviewed by Adam Roben and Sam Weinig.
2048
2049         Updated WebSecurityOrigin to match new SecurityOrigin API.
2050
2051         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
2052
2053         * Storage/WebSecurityOrigin.mm:
2054         (-[WebSecurityOrigin host]):
2055         (-[WebSecurityOrigin domain]):
2056         * Storage/WebSecurityOriginPrivate.h:
2057
2058 2008-04-25  Mark Rowe  <mrowe@apple.com>
2059
2060         Rubber-stamped by Sam Weinig.
2061
2062         Add some content to an empty ICU header file to prevent verification errors.
2063
2064         * icu/unicode/utf_old.h:
2065
2066 2008-04-25  Anders Carlsson  <andersca@apple.com>
2067
2068         Reviewed by Sam.
2069
2070         Add offlineWebApplicationCacheEnabled preference.
2071         
2072         * WebView/WebPreferenceKeysPrivate.h:
2073         * WebView/WebPreferences.m:
2074         (+[WebPreferences initialize]):
2075         (-[WebPreferences offlineWebApplicationCacheEnabled]):
2076         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
2077         * WebView/WebPreferencesPrivate.h:
2078         * WebView/WebView.mm:
2079         (-[WebView _updateSettingsFromPreferences:]):
2080
2081 2008-04-24  Mark Rowe  <mrowe@apple.com>
2082
2083         Reviewed by Sam Weinig.
2084
2085         Remove code for calculating the glyph cache size.
2086
2087         * WebCoreSupport/WebSystemInterface.m:
2088         (InitWebCoreSystemInterface): Remove unused symbol.
2089
2090 2008-04-24  Mark Rowe  <mrowe@apple.com>
2091
2092         Reviewed by Sam Weinig.
2093
2094         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
2095
2096         * WebKitPrefix.h:
2097
2098 2008-04-24  Brady Eidson  <beidson@apple.com>
2099
2100         Reviewed by Darin
2101
2102         Fix layout test regressions from my earlier preferences/settings tweak.
2103
2104         * WebView/WebView.mm:
2105         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
2106           the notification to update the settings, each WebView still needs to register for the
2107           notification - restore that behavior.
2108
2109 2008-04-24  Dan Bernstein  <mitz@apple.com>
2110
2111         Reviewed by Darin Adler.
2112
2113         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
2114           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
2115
2116         * WebView/WebFrame.mm:
2117         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
2118         VisiblePosition::caretRect() instead of the RenderObject method which
2119         was removed.
2120
2121 2008-04-24  Brady Eidson  <beidson@apple.com>
2122
2123         Reviewed by Darin
2124
2125         Rework the Settings population again.
2126
2127         * WebView/WebView.mm:
2128         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
2129           and directly from WebView's common init function.
2130         (-[WebView _preferencesChangedNotification:]):
2131         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
2132           after creating the new Page
2133
2134 2008-04-24  Darin Adler  <darin@apple.com>
2135
2136         Reviewed by Geoff.
2137
2138         - fix crash in regression test where we'd ask a frame for a user agent string
2139           after the WebView was already closed
2140
2141         * WebCoreSupport/WebFrameLoaderClient.mm:
2142         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2143         added some code to prevent the crash in release builds if this problem happens
2144         again.
2145
2146 2008-04-24  Anders Carlsson  <andersca@apple.com>
2147
2148         Reviewed by Sam.
2149
2150         Change some String arguments to be const references instead.
2151
2152         * WebCoreSupport/WebEditorClient.h:
2153         * WebCoreSupport/WebEditorClient.mm:
2154         (WebEditorClient::shouldInsertText):
2155
2156 2008-04-24  John Sullivan  <sullivan@apple.com>
2157
2158         Mac build fix
2159         
2160         * WebCoreSupport/WebViewFactory.mm:
2161         (-[WebViewFactory AXButtonActionVerb]):
2162         implement this method using the text in WebCoreLocalizedStrings.cpp
2163         (-[WebViewFactory AXRadioButtonActionVerb]):
2164         ditto
2165         (-[WebViewFactory AXTextFieldActionVerb]):
2166         ditto
2167         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2168         ditto
2169         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2170         ditto
2171         (-[WebViewFactory AXLinkActionVerb]):
2172         ditto
2173
2174 2008-04-23  Brady Eidson  <beidson@apple.com>
2175
2176         Reviewed by Sam Weinig
2177
2178         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2179         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2180         thereby populating the Settings object, immediately after the Page is created.
2181
2182         * WebView/WebView.mm:
2183         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2184
2185 2008-04-24  John Sullivan  <sullivan@apple.com>
2186
2187         Reviewed by Jess
2188         
2189         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2190
2191         * Misc/WebNSControlExtras.m:
2192         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2193         deploy userSpaceScaleFactor when using view distances on the window
2194
2195 2008-04-22  Anders Carlsson  <andersca@apple.com>
2196
2197         Reviewed by Darin.
2198
2199         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2200         
2201         * Plugins/npfunctions.h:
2202
2203 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2204
2205         Mysteriously reviewed by mitz|away.
2206
2207         Bug 18111: Closing a tab while dragging crashes Safari
2208         https://bugs.webkit.org/show_bug.cgi?id=18111
2209
2210         Null check the page before handling drag events.
2211
2212         * WebView/WebView.mm:
2213         (-[WebView draggingUpdated:]):
2214         (-[WebView draggingExited:]):
2215
2216 2008-04-19  Brady Eidson  <beidson@apple.com>
2217
2218         Reviewed by Tim Hatcher
2219
2220         Add a WebPreference for the path of the local storage persistent store.
2221
2222         * WebView/WebPreferenceKeysPrivate.h:
2223
2224         * WebView/WebPreferences.m:
2225         (-[WebPreferences _localStorageDatabasePath]):
2226         (-[WebPreferences _setLocalStorageDatabasePath:]):
2227         * WebView/WebPreferencesPrivate.h:
2228
2229         * WebView/WebView.mm:
2230         (-[WebView _preferencesChangedNotification:]):
2231
2232 2008-04-18  Brady Eidson  <beidson@apple.com>
2233
2234         Reviewed by Sam Weinig
2235
2236         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2237         No reason to do the work twice...
2238
2239         * WebView/WebView.mm:
2240         (-[WebView _close]):
2241
2242 2008-04-17  Eric Seidel  <eric@webkit.org>
2243
2244         Reviewed by beth.
2245
2246         Rename Frame::renderer() to contentRenderer() and fix uses.
2247
2248         * Misc/WebCoreStatistics.mm:
2249         * WebView/WebRenderNode.mm:
2250         (-[WebRenderNode initWithWebFrameView:]):
2251
2252 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2253
2254         Reviewed by mrowe.
2255
2256         * WebView/WebFrame.mm: Remove temporary build fix.
2257
2258 2008-04-17  Mark Rowe  <mrowe@apple.com>
2259
2260         Reviewed by Dan Bernstein.
2261
2262         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2263
2264         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2265
2266         * WebCoreSupport/WebFrameLoaderClient.mm:
2267         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2268
2269 2008-04-17  Mark Rowe  <mrowe@apple.com>
2270
2271         Rubber-stamped by Dan Bernstein.
2272
2273         Fix the Mac build.
2274
2275         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2276         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2277         for this to live going forward.
2278
2279 2008-04-15  Kevin Decker  <kdecker@apple.com>
2280
2281         Reviewed by Anders.
2282
2283         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2284         
2285         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2286         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2287         a bundle out from underneath itself.
2288
2289         * Plugins/WebBasePluginPackage.h: Added unload method.
2290         * Plugins/WebBasePluginPackage.m:
2291         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2292         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2293         * Plugins/WebNetscapePluginPackage.m:
2294         (-[WebNetscapePluginPackage unload]): Added.
2295
2296 2008-04-15  Anders Carlsson  <andersca@apple.com>
2297
2298         Reviewed by Adam.
2299
2300         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2301
2302         * Configurations/WebKit.xcconfig:
2303
2304 2008-04-15  Brady Eidson  <beidson@apple.com>
2305
2306         Reviewed by John Sullivan
2307
2308         Do a more complete job adding the "WebArchiveDebugMode" pref
2309
2310         * WebView/WebPreferences.m: Add both getter *and* setter
2311         (-[WebPreferences webArchiveDebugModeEnabled]):
2312         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2313         * WebView/WebPreferencesPrivate.h:
2314
2315         * WebView/WebView.mm:
2316         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2317
2318 2008-04-14  Brady Eidson  <beidson@apple.com>
2319
2320         Reviewed by Anders
2321
2322         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2323         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2324         network and will instead fail the load as "cancelled."
2325
2326         * WebView/WebPreferenceKeysPrivate.h:
2327
2328         * WebView/WebPreferences.m:
2329         (+[WebPreferences initialize]):
2330         (-[WebPreferences _webArchiveDebugModeEnabled]):
2331         * WebView/WebPreferencesPrivate.h:
2332
2333         * WebView/WebView.mm:
2334         (-[WebView _preferencesChangedNotification:]):
2335
2336 2008-04-11  David Hyatt  <hyatt@apple.com>
2337
2338         Rename CachedResource ref/deref methods to addClient/removeClient.
2339
2340         Reviewed by olliej
2341
2342         * WebView/WebHTMLView.mm:
2343         (-[WebHTMLViewPrivate dealloc]):
2344         (-[WebHTMLViewPrivate finalize]):
2345         (-[WebHTMLViewPrivate clear]):
2346         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2347
2348 2008-04-07  Brady Eidson  <beidson@apple.com>
2349
2350         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2351
2352         * Configurations/WebKit.xcconfig:
2353
2354 2008-04-04  Adam Roben  <aroben@apple.com>
2355
2356         Use WebCore's ICU headers instead of our own copy
2357
2358         Rubberstamped by Tim Hatcher.
2359
2360         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2361         PrivateHeaders.
2362
2363 2008-04-04  Adam Roben  <aroben@apple.com>
2364
2365         Fix <rdar://problem/5804776> Would like to use WebCore's
2366         ForwardingHeaders in WebKit without manually creating copies
2367
2368         Patch by Tim Hatcher, typed by me.
2369
2370         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2371         WebCore's PrivateHeaders instead of our own copy.
2372
2373 2008-04-04  Ada Chan  <adachan@apple.com>
2374
2375         Now we pass width and height directly as integers to format
2376         the window title for a standalone image.
2377
2378         Reviewed by Dan.
2379
2380         * WebCoreSupport/WebViewFactory.mm:
2381         (-[WebViewFactory imageTitleForFilename:width:height:]):
2382
2383 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
2384
2385         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
2386
2387         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
2388           font-weight does not properly support graded weights
2389
2390         * WebView/WebHTMLView.mm:
2391         (-[WebHTMLView _styleFromFontAttributes:]):
2392         (-[WebHTMLView _originalFontB]):
2393         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2394
2395 2008-04-02  Mark Rowe  <mrowe@apple.com>
2396
2397         Reviewed by Oliver Hunt.
2398
2399         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
2400
2401         * Configurations/Base.xcconfig:
2402
2403 2008-03-31  Alice Liu  <alice.liu@apple.com>
2404
2405         Reviewed by Darin.
2406
2407         * WebView/WebFrame.mm:
2408         (-[WebFrame _accessibilityTree]):
2409         The syntax for fetching an object from the AXObjectCache changed slightly
2410
2411 2008-03-31  Brady Eidson  <beidson@apple.com>
2412
2413         Reviewed by Jon Honeycutt
2414         
2415         Move a WebArchive loading check into WebCore
2416
2417         * WebView/WebHTMLRepresentation.mm:
2418         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
2419           responsible for checking that state
2420
2421 2008-03-31  Brady Eidson  <beidson@apple.com>
2422
2423         Reviewed by Darin and Mitz's rubber stamp
2424
2425         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2426
2427         * WebCoreSupport/WebEditorClient.mm:
2428         * WebCoreSupport/WebEditorClient.h:
2429
2430 2008-03-28  Brady Eidson  <beidson@apple.com>
2431
2432         Rubberstamped by Darin Adler
2433
2434         Remove WebArchiver.h/mm
2435
2436         * WebView/WebArchiver.h: Removed.
2437         * WebView/WebArchiver.mm: Removed.
2438
2439         * DOM/WebDOMOperations.mm:
2440         * WebCoreSupport/WebDragClient.mm:
2441         * WebCoreSupport/WebEditorClient.mm:
2442         * WebView/WebDataSource.mm:
2443         * WebView/WebHTMLView.mm:
2444
2445 2008-03-28  Brady Eidson  <beidson@apple.com>
2446
2447         Reviewed by Darin Adler
2448
2449         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
2450
2451         * WebCoreSupport/WebEditorClient.mm:
2452         (WebEditorClient::dataForArchivedSelection):
2453
2454         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
2455         * WebView/WebArchiver.mm: Ditto
2456
2457         * WebView/WebHTMLView.mm:
2458         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2459
2460 2008-03-28  Brady Eidson  <beidson@apple.com>
2461
2462         Reviewed by Darin Adler
2463
2464         More Kit->Core WebArchive changes.
2465
2466         Create an archive from the current selection in a frame
2467
2468         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
2469           easily in a followup
2470
2471 2008-03-28  Brady Eidson  <beidson@apple.com>
2472
2473         Reviewed by Sam Weinig
2474
2475         WebArchive saga continues - Can now make archives from ranges in WebCore
2476
2477         * DOM/WebDOMOperations.mm:
2478         (-[DOMRange webArchive]):
2479         (-[DOMRange markupString]):
2480
2481         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
2482         * WebView/WebArchiver.mm:
2483
2484 2008-03-28  Brady Eidson  <beidson@apple.com>
2485
2486         Reviewed by Sam Weinig
2487
2488         More Kit->Core webarchive code movement
2489
2490         * DOM/WebDOMOperations.mm:
2491         (-[DOMNode markupString]): Call createFullMarkup() instead
2492
2493         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
2494         * WebView/WebFrameInternal.h: Ditto
2495
2496 2008-03-28  Brady Eidson  <beidson@apple.com>
2497
2498         Reviewed by Sam Weinig
2499
2500         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
2501
2502         * WebView/WebArchiver.h:
2503         * WebView/WebArchiver.mm:
2504         * WebView/WebDataSource.mm:
2505         (-[WebDataSource webArchive]):
2506
2507 2008-03-28  Brady Eidson  <beidson@apple.com>
2508
2509         Reviewed by Sam Weinig
2510
2511         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
2512
2513         * WebView/WebArchiver.h:
2514         * WebView/WebArchiver.mm:
2515
2516 2008-03-28  Brady Eidson  <beidson@apple.com>
2517
2518         Reviewed by Darin
2519
2520         "Yet another transitional step" to empty out WebKit-based code for archiving.
2521
2522         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2523         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2524
2525         * DOM/WebDOMOperations.mm:
2526         * WebView/WebArchiver.mm:
2527         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2528
2529 2008-03-27  Brady Eidson  <beidson@apple.com>
2530
2531         Reviewed by Adam Roben
2532
2533         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
2534         as the push to core-ify WebArchives continues.
2535
2536         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
2537         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
2538         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
2539         (as in "while archiving a page") are accepting of null or empty data.
2540
2541         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
2542
2543         * WebView/WebDataSource.mm:
2544         (-[WebDataSource mainResource]): Call DocumentLoader implementation
2545         (-[WebDataSource subresources]): Ditto
2546         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
2547         * WebView/WebFrameInternal.h:
2548
2549 2008-03-27  Brady Eidson  <beidson@apple.com>
2550
2551         Reviewed by Adam
2552
2553         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
2554         (more efficient)
2555
2556         * WebView/WebResource.mm:
2557         (-[WebResource _initWithCoreResource:]):
2558         * WebView/WebResourceInternal.h:
2559
2560 2008-03-26  Brady Eidson  <beidson@apple.com>
2561
2562         Build fix - accidentally checked in this change which was work in progress
2563
2564         * DOM/WebDOMOperations.mm:
2565
2566 2008-03-26  Brady Eidson  <beidson@apple.com>
2567
2568         Reviewed by Darin
2569
2570         When we create a WebArchive, we walk every node from some starting point, asking each node
2571         along the way "What are your subresource URLs?"
2572
2573         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
2574         WebCore::Node
2575
2576         * DOM/WebDOMOperations.mm:
2577         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
2578           calling into individual WebCore::Node implementations
2579         * DOM/WebDOMOperationsPrivate.h:
2580
2581 2008-03-26  Brady Eidson  <beidson@apple.com>
2582
2583         Reviewed by Mark Rowe
2584
2585         Part of the continued push to move WebArchive-related code down to WebCore, this
2586         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
2587
2588         * WebView/WebDataSource.mm:
2589         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
2590
2591         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
2592           has now been ported down to WebCore
2593         * WebView/WebFrameInternal.h:
2594
2595 2008-03-26  Mark Rowe  <mrowe@apple.com>
2596
2597         Rubber-stamped by Brady Eidson.
2598
2599         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
2600
2601         * Configurations/WebKit.xcconfig:
2602
2603 2008-03-26  Mark Rowe  <mrowe@apple.com>
2604
2605         Reviewed by David Hyatt.
2606
2607         Make the Ahem font antialias correctly on Acid3 on Tiger.
2608
2609         * WebCoreSupport/WebSystemInterface.m:
2610         (InitWebCoreSystemInterface):
2611
2612 2008-03-26  Mark Rowe  <mrowe@apple.com>
2613
2614         Fix the Mac build.
2615
2616         * MigrateHeaders.make: Copy the newly generated header into the right place.
2617
2618 2008-03-25  Brady Eidson  <beidson@apple.com>
2619
2620         Reviewed by Beth Dakin
2621
2622         Remove entirely unused internal method
2623
2624         * WebView/WebArchiver.h:
2625         * WebView/WebArchiver.mm:
2626
2627 2008-03-25  Brady Eidson  <beidson@apple.com>
2628
2629         Reviewed by Adam Roben
2630
2631         <rdar://problem/5819308> - View Source is empty when view webarchives
2632
2633         * WebCore.base.exp:
2634         * loader/DocumentLoader.cpp:
2635         (WebCore::DocumentLoader::setParsedArchiveData):
2636         (WebCore::DocumentLoader::parsedArchiveData):
2637         * loader/DocumentLoader.h:
2638
2639         * loader/FrameLoader.cpp:
2640         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
2641           in the DocumentLoader
2642
2643 2008-03-25  Dan Bernstein  <mitz@apple.com>
2644
2645         Reviewed by Darin Adler.
2646
2647         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
2648           Reopen All Windows From Last Session causes crash
2649
2650         * WebView/WebHTMLView.mm:
2651         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
2652         check.
2653
2654 2008-03-25  Brady Eidson  <beidson@apple.com>
2655
2656         Reviewed by Jon Honeycutt's rubberstamp
2657
2658         Fix a leak with the new WebArchive setup
2659
2660         * WebView/WebArchive.mm:
2661         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2662
2663 2008-03-25  Brady Eidson  <beidson@apple.com>
2664
2665         Reviewed by Darin
2666
2667         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
2668         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
2669
2670         * WebCoreSupport/WebFrameLoaderClient.h:
2671         * WebCoreSupport/WebFrameLoaderClient.mm:
2672         (WebFrameLoaderClient::WebFrameLoaderClient):
2673
2674 2008-03-25  Brady Eidson  <beidson@apple.com>
2675
2676         Reviewed by Darin
2677
2678         Remove newly obsolete FrameLoaderClient methods
2679
2680         * WebCoreSupport/WebFrameLoaderClient.h:
2681         * WebCoreSupport/WebFrameLoaderClient.mm:
2682
2683 2008-03-25  Brady Eidson  <beidson@apple.com>
2684
2685         Release build fix
2686
2687         * WebView/WebArchive.mm:
2688         (-[WebArchive subresources]):
2689         (-[WebArchive subframeArchives]):
2690
2691 2008-03-25  Brady Eidson  <beidson@apple.com>
2692
2693         Reviewed by Darin
2694
2695         <rdar://problem/4516169> - Support WebArchives on Windows
2696         And paves the way for many future WebArchive bug fixes and enhancements
2697
2698         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
2699         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
2700          * WebArchive <-> LegacyWebArchive
2701          * WebResource <-> ArchiveResource
2702          * WebUnarchivingState <-> ArchiveResourceCollection
2703  
2704         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
2705         and now exist in WebCore
2706
2707         * WebCoreSupport/WebFrameLoaderClient.mm:
2708         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
2709         (WebFrameLoaderClient::finalSetupForReplace):
2710         (WebFrameLoaderClient::setDefersLoading):
2711         (WebFrameLoaderClient::willUseArchive):
2712         (WebFrameLoaderClient::isArchiveLoadPending):
2713         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2714         (WebFrameLoaderClient::clearArchivedResources):
2715         (WebFrameLoaderClient::createFrame):
2716
2717         * WebView/WebArchive.mm:
2718         (+[WebArchivePrivate initialize]):
2719         (-[WebArchivePrivate init]):
2720         (-[WebArchivePrivate initWithCoreArchive:]):
2721         (-[WebArchivePrivate coreArchive]):
2722         (-[WebArchivePrivate setCoreArchive:]):
2723         (-[WebArchivePrivate dealloc]):
2724         (-[WebArchivePrivate finalize]):
2725         (-[WebArchive init]):
2726         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2727         (-[WebArchive initWithData:]):
2728         (-[WebArchive initWithCoder:]):
2729         (-[WebArchive encodeWithCoder:]):
2730         (-[WebArchive mainResource]):
2731         (-[WebArchive subresources]):
2732         (-[WebArchive subframeArchives]):
2733         (-[WebArchive data]):
2734         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
2735         (-[WebArchive WebCore::]):
2736         * WebView/WebArchiveInternal.h: Added.
2737
2738         * WebView/WebDataSource.mm:
2739         (-[WebDataSourcePrivate dealloc]):
2740         (-[WebDataSource _addSubframeArchives:]):
2741         (-[WebDataSource _documentFragmentWithArchive:]):
2742         (-[WebDataSource subresourceForURL:]):
2743         (-[WebDataSource addSubresource:]):
2744         * WebView/WebDataSourceInternal.h:
2745
2746         * WebView/WebFrame.mm:
2747         (-[WebFrame loadArchive:]):
2748         * WebView/WebFrameInternal.h:
2749
2750         * WebView/WebHTMLRepresentation.mm:
2751         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2752
2753         * WebView/WebResource.mm:
2754         (+[WebResourcePrivate initialize]):
2755         (-[WebResourcePrivate init]):
2756         (-[WebResourcePrivate initWithCoreResource:]):
2757         (-[WebResourcePrivate dealloc]):
2758         (-[WebResourcePrivate finalize]):
2759         (-[WebResource initWithCoder:]):
2760         (-[WebResource encodeWithCoder:]):
2761         (-[WebResource data]):
2762         (-[WebResource URL]):
2763         (-[WebResource MIMEType]):
2764         (-[WebResource textEncodingName]):
2765         (-[WebResource frameName]):
2766         (-[WebResource _initWithCoreResource:WebCore::]):
2767         (-[WebResource WebCore::]):
2768         (-[WebResource _ignoreWhenUnarchiving]):
2769         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2770         (-[WebResource _fileWrapperRepresentation]):
2771         (-[WebResource _response]):
2772         (-[WebResource _stringValue]):
2773         * WebView/WebResourceInternal.h: Added.
2774         * WebView/WebResourcePrivate.h:
2775
2776         * WebView/WebUnarchivingState.h: Removed.
2777         * WebView/WebUnarchivingState.m: Removed.
2778
2779 2008-03-24  Oliver Hunt  <oliver@apple.com>
2780
2781         Reviewed by Mark Rowe.
2782
2783         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
2784         <http://bugs.webkit.org/show_bug.cgi?id=18030>
2785
2786         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
2787         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
2788         <http://bugs.webkit.org/show_bug.cgi?id=18057>
2789
2790         * WebView/WebHTMLView.mm:
2791         (-[WebHTMLView keyDown:]):
2792
2793 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2794
2795         Reviewed by Maciej, landed by Brady
2796
2797         Bug 3580: iFrames Appear to be Cached
2798         <http://bugs.webkit.org/show_bug.cgi?id=3580>
2799
2800         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
2801         <http://bugs.webkit.org/show_bug.cgi?id=15486>
2802
2803         Bug 15554: Reload causes <object> to use old data
2804         <http://bugs.webkit.org/show_bug.cgi?id=15554>
2805
2806         If a page is reloaded, a child frame's URL can not be taken from a history item.
2807
2808         * WebView/WebFrame.mm:
2809         (-[WebFrame _loadURL:referrer:intoChild:]):
2810
2811 2008-03-24  Darin Adler  <darin@apple.com>
2812
2813         Reviewed by Beth.
2814
2815         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
2816
2817         * History/WebHistoryItem.mm:
2818         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
2819         * WebView/WebDataSource.mm:
2820         (-[WebDataSource _URL]): Ditto.
2821         (-[WebDataSource unreachableURL]): Ditto.
2822         * WebView/WebHTMLView.mm:
2823         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2824
2825         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2826         * History/WebHistory.mm:
2827         * Misc/WebElementDictionary.mm:
2828         * Misc/WebNSAttributedStringExtras.mm:
2829         Remove unneeded imports of KURL.h.
2830
2831 2008-03-24  Brady Eidson  <beidson@apple.com>
2832
2833         Reviewed by Darin's rubberstamp
2834
2835         Rename this file for upcoming work.
2836
2837         * WebView/WebArchive.m: Removed.
2838         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
2839
2840 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
2841
2842         Build fix.
2843
2844         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
2845
2846 2008-03-23  Oliver Hunt  <oliver@apple.com>
2847
2848         Reviewed by Maciej.
2849
2850         Bug 17670: Key events may improperly propagate from iframe to parent frame
2851         <http://bugs.webkit.org/show_bug.cgi?id=17670>
2852         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
2853         <http://bugs.webkit.org/show_bug.cgi?id=16381>
2854
2855         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
2856         as that results in us dispatching the key events for each frame going up the frame
2857         tree.
2858
2859         * WebView/WebHTMLView.mm:
2860         (-[WebHTMLView keyDown:]):
2861         (-[WebHTMLView keyUp:]):
2862         (-[WebHTMLView flagsChanged:]):
2863
2864 2008-03-21  Timothy Hatcher  <timothy@apple.com>
2865
2866         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
2867         http://bugs.webkit.org/show_bug.cgi?id=17980
2868
2869         Reviewed by Adam.
2870
2871         The new highlight drawing was not honoring the fade value, so it was
2872         always drawing at full opacity. The animation code didn't match Windows
2873         and the new highlight anyway, so it has been removed. The highlight
2874         how just detaches when it is hidden.
2875
2876         * WebCoreSupport/WebInspectorClient.mm:
2877         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
2878         (-[WebInspectorWindowController close]): Ditto.
2879         (-[WebInspectorWindowController highlightNode:]): Call attach.
2880         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
2881         * WebInspector/WebNodeHighlight.h:
2882         * WebInspector/WebNodeHighlight.m:
2883         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2884         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
2885         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
2886         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
2887         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
2888         * WebInspector/WebNodeHighlightView.h:
2889         * WebInspector/WebNodeHighlightView.m:
2890         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
2891
2892 2008-03-20  Mark Rowe  <mrowe@apple.com>
2893
2894         Reviewed by Sam Weinig.
2895
2896         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
2897         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
2898         command-line.
2899
2900         * Configurations/WebKit.xcconfig:
2901
2902 2008-03-20  Adam Roben  <aroben@apple.com>
2903
2904         Make WebNodeHighlightView use InspectorController to do its painting
2905
2906         Reviewed by Tim Hatcher.
2907
2908         * WebCoreSupport/WebInspectorClient.mm:
2909         (-[WebInspectorWindowController highlightNode:]): Pass the
2910         InspectorController to the WebNodeHighlight, and don't call
2911         setHighlightedNode: (which has been removed).
2912         (-[WebInspectorWindowController hideHighlight]): Removed call to
2913         setHighlightedNode:.
2914         * WebInspector/WebNodeHighlight.h:
2915           - Replaced _highlightNode with _inspectorController
2916           - Removed _highlightedNode accessors
2917           - Added -inspectorController method
2918         * WebInspector/WebNodeHighlight.m:
2919         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
2920         takes an InspectorController* and stores it in _inspectorController.
2921         (-[WebNodeHighlight dealloc]): Removed code dealing with
2922         _highlightedNode.
2923         (-[WebNodeHighlight inspectorController]): Added.
2924         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
2925         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
2926         GraphicsContexts to be based on a flipped CGContext, so we have to
2927         specify that this view is flipped.
2928         (-[WebNodeHighlightView drawRect:]): Changed to create a
2929         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
2930
2931 2008-03-18  David Hyatt  <hyatt@apple.com>
2932
2933         Add support for a preference in WebKit that can be used in nightly builds to test full page
2934         zoom.
2935
2936         Reviewed by Antti
2937
2938         * WebView/WebPreferenceKeysPrivate.h:
2939         * WebView/WebView.mm:
2940         (-[WebView setTextSizeMultiplier:]):
2941         (-[WebView canMakeTextSmaller]):
2942         (-[WebView makeTextSmaller:]):
2943         (-[WebView canMakeTextLarger]):
2944         (-[WebView makeTextLarger:]):
2945         (-[WebView canMakeTextStandardSize]):
2946         (-[WebView makeTextStandardSize:]):
2947
2948 2008-03-17  Eric Seidel  <eric@webkit.org>
2949
2950         Reviewed by darin.
2951
2952         Export _NPN_IntFromIdentifier as part of our NPAPI interface
2953
2954         * Plugins/WebNetscapePluginPackage.m:
2955         (-[WebNetscapePluginPackage load]):
2956
2957 2008-03-14  Brady Eidson  <beidson@apple.com>
2958
2959         Reviewed by Brian Dash's rubberstamp
2960
2961         Remove a class declaration for a class that has never existed
2962
2963         * WebView/WebResource.h:
2964
2965 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
2966
2967         Unify concept of enabling the Mac Java bridge.
2968
2969         Reviewed by Darin and Anders.
2970
2971         * Plugins/WebPluginJava.h: Removed unused file.
2972         * WebCoreSupport/WebFrameLoaderClient.h:
2973         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
2974         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
2975         (WebFrameLoaderClient::javaApplet): Ditto.
2976
2977 2008-03-13  Antti Koivisto  <antti@apple.com>
2978
2979         Reviewed by Darin.
2980
2981         * ForwardingHeaders/wtf/Deque.h: Added.
2982
2983 2008-03-13  Anders Carlsson  <andersca@apple.com>
2984
2985         Reviewed by Adam.
2986
2987         Call originalRequest, not initialRequest.
2988         
2989         * WebView/WebDataSource.mm:
2990         (-[WebDataSource initialRequest]):
2991
2992 2008-03-12  Darin Adler  <darin@apple.com>
2993
2994         Reviewed by John Sullivan.
2995
2996         - cleanup after removing the bridge
2997
2998         * DOM/WebDOMOperations.mm:
2999         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
3000
3001         * Misc/WebCoreStatistics.mm:
3002         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
3003
3004         * Plugins/WebBaseNetscapePluginView.mm:
3005         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
3006         _frameLoader method.
3007         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3008         Ditto.
3009         * Plugins/WebPluginController.mm:
3010         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
3011
3012         * WebCoreSupport/WebFrameLoaderClient.mm:
3013         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
3014         method. Without this we could leave a stale frame pointer around.
3015         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
3016         caller of the _isMainFrame method.
3017         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
3018         _frameLoader method.
3019         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
3020
3021         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
3022         turned out to be unused.
3023         (core): Added overload for DocumentFragment.
3024         (kit): Ditto.
3025         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
3026         to FrameLoader with _private->coreFrame->loader().
3027         (-[WebFrame _attachScriptDebugger]): Ditto.
3028         (-[WebFrame _clearCoreFrame]): Added.
3029         (-[WebFrame _updateBackground]): More of the same.
3030         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
3031         (-[WebFrame _unmarkAllMisspellings]): Ditto.
3032         (-[WebFrame _hasSelection]): Ditto.
3033         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
3034         (-[WebFrame _findFrameWithSelection]): Ditto.
3035         (-[WebFrame _dataSource]): Ditto.
3036         (-[WebFrame _addData:]): Streamlined code a bit.
3037         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3038         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3039         (-[WebFrame _isDescendantOfFrame:]): Ditto.
3040         (-[WebFrame _bodyBackgroundColor]): Ditto.
3041         (-[WebFrame _isFrameSet]): Ditto.
3042         (-[WebFrame _firstLayoutDone]): Ditto.
3043         (-[WebFrame _loadType]): Ditto.
3044         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
3045         (-[WebFrame name]): Ditto.
3046         (-[WebFrame DOMDocument]): Ditto.
3047         (-[WebFrame frameElement]): Ditto.
3048         (-[WebFrame provisionalDataSource]): Ditto.
3049         (-[WebFrame dataSource]): Ditto.
3050         (-[WebFrame loadRequest:]): Ditto.
3051         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
3052         (-[WebFrame loadArchive:]): Ditto.
3053         (-[WebFrame stopLoading]): Ditto.
3054         (-[WebFrame reload]): Ditto.
3055         (-[WebFrame findFrameNamed:]): Ditto.
3056         (-[WebFrame parentFrame]): Ditto.
3057         (-[WebFrame childFrames]): Ditto.
3058         (-[WebFrame windowObject]): Ditto.
3059         (-[WebFrame globalContext]): Ditto.
3060
3061         * WebView/WebFrameInternal.h: Added overloads of core and kit.
3062         Removed method declarations.
3063
3064         * WebView/WebHTMLRepresentation.mm:
3065         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
3066         (formElementFromDOMElement): Ditto.
3067         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3068         (inputElementFromDOMElement): Ditto.
3069         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3070         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3071         (-[WebHTMLRepresentation formForElement:]): Ditto.
3072         (-[WebHTMLRepresentation currentForm]): Ditto.
3073         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3074         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3075         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3076
3077         * WebView/WebHTMLView.mm:
3078         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
3079         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3080         Call createFragmentFromText directly instead of via WebFrame.
3081         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3082         Moved layout calls here from WebFrame.
3083         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3084         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
3085         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
3086         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
3087         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
3088         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3089         Moved code here from WebFrame.
3090         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
3091         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3092         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3093         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3094         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3095         (-[WebHTMLView rectsForTextMatches]): Ditto.
3096
3097         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
3098
3099         * WebView/WebPDFView.mm:
3100         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
3101         _frameLoader method.
3102
3103         * WebView/WebRenderNode.mm:
3104         (copyRenderNode): Moved code here from WebFrame.
3105         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3106
3107         * WebView/WebResource.mm:
3108         (-[WebResource _stringValue]): Moved code here from WebFrame.
3109
3110         * WebView/WebView.mm:
3111         (-[WebView _close]): Use core function intsead of _frameLoader method.
3112         (-[WebView setCustomTextEncodingName:]): Ditto.
3113         (-[WebView setHostWindow:]): Moved code here from WebFrame.
3114         (aeDescFromJSValue): Moved this here from WebFrame.
3115         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
3116
3117 2008-03-12  Darin Adler  <darin@apple.com>
3118
3119         Reviewed by Anders.
3120
3121         - http://bugs.webkit.org/show_bug.cgi?id=17640
3122           eliminate WebCoreFrameBridge
3123
3124         Moved all the code from the bridge into WebFrame. This need not be the final
3125         home of these methods -- they can be moved closer to their callers and improved
3126         further -- but it eliminates the bridge without requiring a rewrite of the code.
3127         It's a fairly mechanical process (just adding underscores to method names really).
3128
3129         There's even a chance that some of the methods are unused. Those we can remove
3130         after checking if that's so.
3131
3132         * DOM/WebDOMOperations.mm:
3133         (-[DOMNode markupString]): Use WebFrame rather than bridge.
3134         (-[DOMDocument webFrame]): Changed to use the core and kit functions
3135         instead of using the bridge.
3136         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
3137         (-[DOMRange markupString]): Ditto.
3138         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3139
3140         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3141         * History/WebHistoryItem.mm: Ditto.
3142
3143         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3144         * Misc/WebCoreStatistics.mm:
3145         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3146
3147         * Misc/WebElementDictionary.mm: Removed unneeded import.
3148
3149         * Misc/WebKitStatistics.m:
3150         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3151         * Misc/WebKitStatisticsPrivate.h: Ditto.
3152
3153         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3154         * Misc/WebNSPasteboardExtras.mm: Ditto.
3155
3156         * Plugins/WebBaseNetscapePluginView.mm:
3157         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3158         rather than bridge.
3159
3160         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3161         * Plugins/WebNetscapePluginStream.mm: Ditto.
3162
3163         * Plugins/WebPluginContainerCheck.mm:
3164         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3165         bridge to get to the WebCore::Frame.
3166
3167         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3168         * Plugins/WebPluginController.mm:
3169         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3170         rather than bridge.
3171
3172         * WebCoreSupport/WebEditorClient.mm:
3173         (selectorForKeyEvent): Tweaked comment.
3174
3175         * WebCoreSupport/WebFrameBridge.h: Removed.
3176         * WebCoreSupport/WebFrameBridge.mm: Removed.
3177
3178         * WebCoreSupport/WebFrameLoaderClient.mm:
3179         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3180         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3181         I could remove this function entirely, but it looks like the Qt port is using it.
3182
3183         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3184
3185         * WebView/WebArchiver.mm:
3186         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3187         (+[WebArchiver archiveNode:]): Ditto.
3188         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3189
3190         * WebView/WebDataSource.mm:
3191         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3192         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3193         (-[WebDataSource subresources]): Ditto.
3194         (-[WebDataSource subresourceForURL:]): Ditto.
3195
3196         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3197
3198         * WebView/WebFrame.mm:
3199         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3200         (core): Go directly to the core frame, not via the bridge.
3201         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3202         Remove the code to deal with the bridge.
3203         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3204         shouldCreateRenderers flag, formerly on the bridge.
3205         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3206         (aeDescFromJSValue): Moved here from bridge.
3207         (-[WebFrame _domain]): Ditto.
3208         (-[WebFrame _addData:]): Ditto.
3209         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3210         (-[WebFrame _nodesFromList:]): Ditto.
3211         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3212         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3213         (-[WebFrame _selectedString]): Ditto.
3214         (-[WebFrame _stringForRange:]): Ditto.
3215         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3216         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3217         (-[WebFrame _sendScrollEvent]): Ditto.
3218         (-[WebFrame _drawRect:]): Ditto.
3219         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3220         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3221         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3222         (-[WebFrame _copyRenderTree:]): Ditto.
3223         (inputElementFromDOMElement): Ditto.
3224         (formElementFromDOMElement): Ditto.
3225         (-[WebFrame _elementWithName:inForm:]): Ditto.
3226         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3227         (-[WebFrame _elementIsPassword:]): Ditto.
3228         (-[WebFrame _formForElement:]): Ditto.
3229         (-[WebFrame _currentForm]): Ditto.
3230         (-[WebFrame _controlsInForm:]): Ditto.
3231         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3232         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3233         (-[WebFrame _URLWithAttributeString:]): Ditto.
3234         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3235         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3236         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3237         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3238         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3239         (-[WebFrame _rectsForTextMatches]): Ditto.
3240         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3241         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3242         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3243         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3244         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3245         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3246         (-[WebFrame _baseURL]): Ditto.
3247         (-[WebFrame _stringWithData:]): Ditto.
3248         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3249         (-[WebFrame _needsLayout]): Ditto.
3250         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3251         (-[WebFrame _accessibilityTree]): Ditto.
3252         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3253         (-[WebFrame _setDrawsBackground:]): Ditto.
3254         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3255         Ditto.
3256         (-[WebFrame _selectionGranularity]): Ditto.
3257         (-[WebFrame _convertToNSRange:]): Ditto.
3258         (-[WebFrame _convertToDOMRange:]): Ditto.
3259         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3260         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3261         (-[WebFrame _markDOMRange]): Ditto.
3262         (-[WebFrame _markedTextNSRange]): Ditto.
3263         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3264         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3265         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3266         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3267         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3268         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3269         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3270         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3271         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3272         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3273         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3274         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3275         (-[WebFrame _typingStyle]): Ditto.
3276         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3277         (-[WebFrame _fontForSelection:]): Ditto.
3278         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3279         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3280         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3281         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3282         (-[WebFrame _canProvideDocumentSource]): Ditto.
3283         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3284         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3285         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3286         function. Couldn't just keep the bridge method because this was already here with the same name.
3287         (-[WebFrame _selectedNSRange]): Ditto.
3288         (-[WebFrame _selectNSRange:]): Ditto.
3289         (-[WebFrame dealloc]): Remove bridge-related code.
3290         (-[WebFrame finalize]): Ditto.
3291
3292         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3293         Removed the bridge parameter from the init method. Removed the #if blocks that
3294         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3295         Removed the _bridge method.
3296
3297         * WebView/WebFrameView.mm: Removed the _bridge method.
3298
3299         * WebView/WebHTMLRepresentation.mm:
3300         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3301         field.
3302         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3303         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3304         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3305         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3306         (-[WebHTMLRepresentation documentSource]): Ditto.
3307         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3308         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3309         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3310         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3311         (-[WebHTMLRepresentation formForElement:]): Ditto.
3312         (-[WebHTMLRepresentation currentForm]): Ditto.
3313         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3314         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3315         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3316
3317         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3318
3319         * WebView/WebHTMLView.mm:
3320         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3321         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3322         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3323         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3324         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3325         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3326         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3327         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3328         (-[WebHTMLView drawSingleRect:]): Ditto.
3329         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3330         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3331         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3332         (-[WebHTMLView knowsPageRange:]): Ditto.
3333         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3334         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3335         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3336         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3337         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3338         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3339         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3340         (-[WebHTMLView startSpeaking:]): Ditto.
3341         (-[WebHTMLView _updateFontPanel]): Ditto.
3342         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3343         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3344         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3345         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3346         (-[WebHTMLView selectedRange]): Ditto.
3347         (-[WebHTMLView markedRange]): Ditto.
3348         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3349         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3350         (-[WebHTMLView insertText:]): Ditto.
3351         (-[WebTextCompleteController _insertMatch:]): Ditto.
3352         (-[WebTextCompleteController doCompletion]): Ditto.
3353         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3354         (-[WebHTMLView string]): Ditto.
3355         (-[WebHTMLView selectedString]): Ditto.
3356         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3357         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3358         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3359         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3360         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3361         (-[WebHTMLView rectsForTextMatches]): Ditto.
3362         * WebView/WebRenderNode.mm:
3363         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3364         * WebView/WebResource.mm:
3365         (-[WebResource _stringValue]): Ditto.
3366
3367         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3368
3369         * WebView/WebView.mm:
3370         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3371         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3372         (-[WebView _setInViewSourceMode:]): Ditto.
3373         (-[WebView _inViewSourceMode]): Ditto.
3374         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3375         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3376         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3377         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3378         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
3379         (-[WebView setEditable:]): Ditto.
3380         (-[WebView setTypingStyle:]): Ditto.
3381         (-[WebView typingStyle]): Ditto.
3382         (-[WebView replaceSelectionWithNode:]): Ditto.
3383         (-[WebView replaceSelectionWithText:]): Ditto.
3384         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
3385         (-[WebView replaceSelectionWithArchive:]): Ditto.
3386         (-[WebView _insertNewlineInQuotedContent]): Ditto.
3387         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
3388
3389 2008-03-12  David Hyatt  <hyatt@apple.com>
3390
3391         Make the zoom factor a float and not a percent.
3392
3393         Reviewed by antti
3394
3395         * WebView/WebView.mm:
3396         (-[WebView _setZoomMultiplier:isTextOnly:]):
3397
3398 2008-03-11  David Hyatt  <hyatt@apple.com>
3399
3400         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
3401         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
3402         can zoom the page in, out or reset it to the standard size.
3403
3404         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
3405         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
3406         win.
3407
3408         Reviewed by Tim H.
3409
3410         * WebCoreSupport/WebFrameBridge.mm:
3411         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
3412         * WebView/WebDocumentInternal.h:
3413         * WebView/WebHTMLView.mm:
3414         (-[WebHTMLView viewDidMoveToSuperview]):
3415         * WebView/WebPDFView.h:
3416         * WebView/WebPDFView.mm:
3417         (-[WebPDFView _zoomOut:]):
3418         (-[WebPDFView _zoomIn:]):
3419         (-[WebPDFView _resetZoom:]):
3420         (-[WebPDFView _canZoomOut]):
3421         (-[WebPDFView _canZoomIn]):
3422         (-[WebPDFView _canResetZoom]):
3423         * WebView/WebView.mm:
3424         (-[WebViewPrivate init]):
3425         (-[WebView setTextSizeMultiplier:]):
3426         (-[WebView textSizeMultiplier]):
3427         (-[WebView _setZoomMultiplier:isTextOnly:]):
3428         (-[WebView _zoomMultiplier:]):
3429         (-[WebView _realZoomMultiplier]):
3430         (-[WebView _realZoomMultiplierIsTextOnly]):
3431         (-[WebView _canZoomOut:]):
3432         (-[WebView _canZoomIn:]):
3433         (-[WebView _zoomOut:isTextOnly:]):
3434         (-[WebView _zoomIn:isTextOnly:]):
3435         (-[WebView _canResetZoom:]):
3436         (-[WebView _resetZoom:isTextOnly:]):
3437         (-[WebView canMakeTextSmaller]):
3438         (-[WebView makeTextSmaller:]):
3439         (-[WebView canMakeTextLarger]):
3440         (-[WebView makeTextLarger:]):
3441         (-[WebView canMakeTextStandardSize]):
3442         (-[WebView makeTextStandardSize:]):
3443         (-[WebView setPageSizeMultiplier:]):
3444         (-[WebView pageSizeMultiplier]):
3445         (-[WebView canZoomPageIn]):
3446         (-[WebView zoomPageIn:]):
3447         (-[WebView canZoomPageOut]):
3448         (-[WebView zoomPageOut:]):
3449         (-[WebView canResetPageZoom]):
3450         (-[WebView resetPageZoom:]):
3451         (-[WebView _searchWithSpotlightFromMenu:]):
3452         * WebView/WebViewInternal.h:
3453         * WebView/WebViewPrivate.h:
3454
3455 2008-03-12  Dan Bernstein  <mitz@apple.com>
3456
3457         Reviewed by Darin Adler and Sam Weinig.
3458
3459         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
3460
3461         * WebCoreSupport/WebSystemInterface.m:
3462         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
3463         WKGetNSFontATSUFontId Tiger-only.
3464
3465 2008-03-12  Darin Adler  <darin@apple.com>
3466
3467         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
3468           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
3469
3470         * WebView/WebFrame.mm:
3471         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
3472         up pointer from the bridge to the frame. (My next check-in removes the bridge
3473         entirely, but we need this until then.)
3474
3475 2008-03-11  Darin Adler  <darin@apple.com>
3476
3477         Reviewed by Sam.
3478
3479         - remove all bridge-related things from WebCore except the bridge itself
3480
3481         * DOM/WebDOMOperations.mm:
3482         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
3483
3484         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
3485
3486         * Plugins/WebPluginController.mm: Ditto.
3487
3488         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
3489         init and close methods. Added a setWebFrame: method.
3490
3491         * WebCoreSupport/WebFrameBridge.mm:
3492         (-[WebFrameBridge setWebFrame:]): Added.
3493
3494         * WebCoreSupport/WebFrameLoaderClient.mm:
3495         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
3496         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
3497         bridge here. Soon we will be able to remove this entirely!
3498         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
3499         into WebFrame from the bridge.
3500
3501         * WebView/WebFrame.mm:
3502         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
3503         now owned by the frame.
3504         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
3505         debugger under GC without this!
3506         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
3507         use WebFrameLoaderClient instead of the bridge.
3508         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
3509         This is code that used to live in the bridge's init function.
3510         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
3511         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
3512         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
3513         the WebView is now the bridge's owner.
3514         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
3515         WebCore::Frame::bridge function directly to use the kit function instead.
3516         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
3517         This code won't last long -- we're eliminating the bridge soon.
3518         (-[WebFrame finalize]): Ditto.
3519
3520         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
3521         for creating frames.
3522
3523         * WebView/WebView.mm:
3524         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
3525         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
3526         where we have to allocate a WebFrameBridge and then immediately release it.
3527
3528 2008-03-11  Darin Adler  <darin@apple.com>
3529
3530         Reviewed by Anders.
3531
3532         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
3533
3534         * WebCoreSupport/WebFrameLoaderClient.mm:
3535         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
3536         to setView. A couple lines later, there is a call to _install, which sets the
3537         view to the scroll view.
3538
3539         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
3540
3541         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
3542         this file, since it's used by Safari.
3543         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
3544         * WebView/WebDynamicScrollBarsView.m:
3545         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
3546         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
3547         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
3548         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
3549         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
3550         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
3551         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
3552         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
3553         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
3554         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
3555         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
3556         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
3557         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
3558         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
3559         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
3560
3561         * WebView/WebFrameView.mm:
3562         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
3563
3564         * WebView/WebView.mm:
3565         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
3566         (-[WebView alwaysShowVerticalScroller]): Ditto.
3567         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
3568         (-[WebView alwaysShowHorizontalScroller]): Ditto.
3569
3570 2008-03-11  Darin Adler  <darin@apple.com>
3571
3572         Reviewed by Sam.
3573
3574         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
3575
3576         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
3577         bridge methods.
3578         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
3579         to recently-created functions.
3580         (WebChromeClient::firstResponder): Moved code here from the bridge.
3581         (WebChromeClient::makeFirstResponder): Ditto.
3582         (WebChromeClient::runOpenPanel): Ditto.
3583         (WebChromeClient::willPopUpMenu): Ditto.
3584
3585         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
3586         is related to creating the bridge and connecting it to WebCore, which will
3587         go next when I eliminate use of the bridge to get to/from the Frame*.
3588         * WebCoreSupport/WebFrameBridge.mm:
3589         (-[WebFrameBridge close]): Moved the code to track the bridge count here
3590         instead of the dealloc and finalize methods.
3591
3592 2008-03-11  Darin Adler  <darin@apple.com>
3593
3594         Reviewed by Mitz.
3595
3596         - update code affected by Range changes
3597
3598         * Misc/WebNSAttributedStringExtras.mm:
3599         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
3600         * WebView/WebHTMLRepresentation.mm:
3601         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3602         Use Range::create.
3603         * WebView/WebHTMLView.mm:
3604         (-[WebHTMLView attributedString]): Ditto.
3605
3606 2008-03-10  Darin Adler  <darin@apple.com>
3607
3608         Reviewed by Sam.
3609
3610         - eliminate keyboard UI mode method from WebCoreFrameBridge
3611
3612         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
3613         * WebCoreSupport/WebChromeClient.mm:
3614         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
3615         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
3616         fields for keyboard UI mode.
3617         * WebCoreSupport/WebFrameBridge.mm:
3618         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
3619         method.
3620         (-[WebFrameBridge finalize]): Ditto.
3621         * WebView/WebView.mm: Moved the keyboard mode code in here.
3622         (-[WebView _close]): Remove observer from the distributed notification
3623         center as well as the normal one.
3624         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
3625         here from the bridge.
3626         (-[WebView _keyboardUIMode]): Ditto.
3627         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
3628
3629 2008-03-10  Darin Adler  <darin@apple.com>
3630
3631         Reviewed by Sam.
3632
3633         - eliminate Java applet methods from WebCoreFrameBridge
3634
3635         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
3636         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
3637         the ones that load Java applets.
3638         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
3639         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3640
3641 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
3642
3643         Reviewed by Darin.
3644
3645         Done with Lars.
3646
3647         Simplified WebViewFactory's refreshPlugins method to only refresh the
3648         plugins and not reload the frames anymore since that's now done in a
3649         platform independent manner by WebCore::Page.
3650
3651         Also removed the now unused pluginNameForMIMEType and
3652         pluginSupportsMIMEType methods.
3653
3654         * WebCoreSupport/WebViewFactory.mm:
3655         * WebView/WebFrame.mm:
3656         * WebView/WebFrameInternal.h:
3657         * WebView/WebView.mm:
3658
3659 2008-03-08  Mark Rowe  <mrowe@apple.com>
3660
3661         Reviewed by Darin Adler.
3662
3663         Fix 64-bit build with GCC 4.2.
3664
3665         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
3666         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
3667         * History/WebHistoryItem.mm: Ditto.
3668         * Misc/WebElementDictionary.mm: Ditto.
3669         * WebCoreSupport/WebFrameLoaderClient.mm:
3670         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
3671         variable being unused in 64-bit.
3672         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
3673         * WebView/WebHTMLView.mm:
3674         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
3675         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
3676
3677 2008-03-08  Darin Adler  <darin@apple.com>
3678
3679         Reviewed by Adele.
3680
3681         - eliminate custom highlight methods from WebCoreFrameBridge
3682
3683         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
3684         * WebCoreSupport/WebChromeClient.mm:
3685         (WebChromeClient::customHighlightRect): Moved code here from bridge.
3686         (WebChromeClient::paintCustomHighlight): Ditto.
3687         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
3688
3689 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
3690
3691         Unify concept of enabling Netscape Plug-in API (NPAPI).
3692
3693         Reviewed by Darin.
3694
3695         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
3696
3697         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
3698         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
3699
3700         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
3701         #if ENABLE(NETSCAPE_PLUGIN_API).
3702         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
3703         * Plugins/WebBaseNetscapePluginView.h: Ditto.
3704         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
3705         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
3706         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
3707         * Plugins/WebBasePluginPackage.h: Ditto.
3708         * Plugins/WebBasePluginPackage.m: Ditto.
3709         (+[WebBasePluginPackage pluginWithPath:]):
3710         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
3711         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3712         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
3713         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
3714         * Plugins/WebNetscapePluginPackage.h: Ditto.
3715         * Plugins/WebNetscapePluginPackage.m: Ditto.
3716         * Plugins/WebNetscapePluginStream.h: Ditto.
3717         * Plugins/WebNetscapePluginStream.mm: Ditto.
3718         * Plugins/WebPluginDatabase.m: Ditto.
3719         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
3720         * Plugins/npapi.m: Ditto.
3721         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3722         (WebFrameLoaderClient::objectContentType):
3723         (WebFrameLoaderClient::createPlugin):
3724         * WebView/WebHTMLView.mm: Ditto.
3725         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3726         * WebView/WebHTMLViewInternal.h: Ditto.
3727
3728         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
3729         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
3730         category to (WebInternal) category so we don't expose the ENABLE() macro
3731         from the private header.
3732         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
3733         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
3734         * WebView/WebFrameInternal.h: Ditto.
3735         * WebView/WebFramePrivate.h: Ditto.
3736
3737 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
3738
3739         Reviewed by Darin.
3740
3741         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
3742         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
3743
3744         * WebView/WebPreferences.m:
3745         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
3746         the one used in Safari.
3747
3748 2008-03-07  Mark Rowe  <mrowe@apple.com>
3749
3750         Reviewed by Oliver Hunt.
3751
3752         Fix WebKit build with GCC 4.2.
3753
3754         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
3755
3756 2008-03-07  Darin Adler  <darin@apple.com>
3757
3758         Reviewed by Adam.
3759
3760         - eliminated WebCoreFrameBridge runOpenPanel
3761
3762         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
3763         * WebCoreSupport/WebChromeClient.mm:
3764         (WebChromeClient::runOpenPanel): Added.
3765         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
3766         FileChooser so it can get a result from the UI delegate.
3767         (-[WebOpenPanelResultListener dealloc]): Added.
3768         (-[WebOpenPanelResultListener finalize]): Added.
3769         (-[WebOpenPanelResultListener cancel]): Added.
3770         (-[WebOpenPanelResultListener chooseFilename:]): Added.
3771
3772 2008-03-06  Darin Adler  <darin@apple.com>
3773
3774         Reviewed by Mitz.
3775
3776         - fix regression test failures from the visited-link change
3777
3778         * History/WebHistory.mm:
3779         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
3780         to turn off visited links if there is no history object. Also call
3781         removeAllVisitedLinks so we can start over from scratch with the new history.
3782
3783 2008-03-06  Dan Bernstein  <mitz@apple.com>
3784
3785         Reviewed by Darin Adler.
3786
3787         - fix a regression from r30741: a crash under
3788           WebFrameLoaderClient::createPlugin() when showing a Mail message with
3789           an attachment
3790
3791         * WebCoreSupport/WebFrameLoaderClient.mm:
3792         (WebFrameLoaderClient::createPlugin):
3793
3794 2008-03-06  Darin Adler  <darin@apple.com>
3795
3796         - fix Tiger build
3797
3798         * History/WebHistory.mm: Added include of WebTypesInternal.h.
3799
3800 2008-03-06  Darin Adler  <darin@apple.com>
3801
3802         - fix Release build
3803
3804         * History/WebHistory.mm:
3805         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
3806         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
3807         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
3808
3809 2008-03-06  Darin Adler  <darin@apple.com>
3810
3811         Reviewed by Mitz.
3812
3813         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
3814           REGRESSION: iframes are added to Safari's History menu
3815           by separating the visited link machinery from global history
3816
3817         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
3818         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
3819         method name, since it's on a private object.
3820         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
3821         PageGroup::removeAllVisitedLinks function if the last URL was removed.
3822         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
3823         method name, since it's on a private object.
3824         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
3825         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
3826         method name, since it's on a private object.
3827         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3828         Ditto.
3829         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
3830         to correctly return the error by using the newer version of writeToURL: and
3831         removed the FIXME about that.
3832         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
3833         for every link in the history.
3834         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
3835         (-[WebHistory addItem:]): Moved into the WebPrivate category.
3836         (-[WebHistory addItemForURL:]): Ditto.
3837         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
3838         create an item and already know its title.
3839         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
3840         (-[WebHistory containsItemForURLString:]): Ditto.
3841         (-[WebHistory removeItem:]): Ditto.
3842         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
3843         (-[WebHistory _itemForURLString:]): Ditto.
3844         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
3845
3846         * History/WebHistoryInternal.h: Added.
3847         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
3848         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
3849         Also reorganized what was left behind.
3850
3851         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
3852         * WebCoreSupport/WebChromeClient.mm:
3853         (WebChromeClient::populateVisitedLinks): Added a call to the new
3854         -[WebHistory _addVisitedLinksToPageGroup:] method.
3855
3856         * WebCoreSupport/WebFrameLoaderClient.mm:
3857         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
3858         -[WebHistory _addItemForURL:title:] method.
3859
3860 2008-03-05  Adam Roben  <aroben@apple.com>
3861
3862         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
3863
3864         Reviewed by Kevin M.
3865
3866         * WebView/WebFrame.mm:
3867         * WebView/WebScriptDebugDelegate.mm:
3868         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
3869         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
3870
3871 2008-03-05  Adam Roben  <aroben@apple.com>
3872
3873         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
3874
3875         Reviewed by Kevin M.
3876
3877         * WebView/WebCoreScriptDebuggerImp.h:
3878         * WebView/WebCoreScriptDebuggerImp.mm:
3879         * WebView/WebFrame.mm:
3880         (-[WebFrame _attachScriptDebugger]):
3881         * WebView/WebFrameInternal.h:
3882
3883 2008-03-05  Adam Roben  <aroben@apple.com>
3884
3885         Remove WebScriptDebugger
3886
3887         Uses of WebScriptDebugger have been replaced with
3888         WebCoreScriptDebuggerImp.
3889
3890         Reviewed by Kevin M.
3891
3892         * WebView/WebFrame.mm:
3893         (-[WebFramePrivate dealloc]): Use delete instead of release since
3894         WebCoreScriptDebuggerImp is a C++ class.
3895         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
3896         WebCoreScriptDebuggerImp.
3897         (-[WebFrame _detachScriptDebugger]): Ditto.
3898         * WebView/WebFrameInternal.h:
3899         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
3900         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
3901         * WebView/WebView.mm:
3902
3903 2008-03-05  Adam Roben  <aroben@apple.com>
3904
3905         Remove -webFrame and -globalObject from WebScriptDebugger
3906
3907         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
3908
3909         Reviewed by Kevin M.
3910
3911         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
3912         parameter to the constructor.
3913         * WebView/WebCoreScriptDebuggerImp.mm:
3914         (toWebFrame): Added.
3915         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
3916         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
3917         WindowScriptObject ourselves instead of asking WebScriptDebugger for
3918         it.
3919         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
3920         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
3921         (WebCoreScriptDebuggerImp::exception): Ditto.
3922         * WebView/WebScriptDebugDelegate.mm:
3923         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
3924         WebScriptDebuggerImp's constructor.
3925         * WebView/WebScriptDebugDelegatePrivate.h: Removed
3926         -webFrame/-globalObject.
3927
3928 2008-03-05  Adam Roben  <aroben@apple.com>
3929
3930         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
3931
3932         Reviewed by Kevin M.
3933
3934         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
3935         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
3936         lifetime.
3937         * WebView/WebCoreScriptDebuggerImp.mm:
3938           - Added declaration of -[WebScriptCallFrame
3939             _initWithGlobalObject:caller:state:].
3940           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
3941         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
3942         now-unnecessary initialization of m_topCallFrame.
3943         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
3944         with its implementation. The one difference between this
3945         implementation and the old enterFrame: method is that we don't hand
3946         our reference to m_topCallFrame to _initWithGlobalObject: -- that
3947         method must now retain the passed-in WebScriptCallFrame manually.
3948         (WebCoreScriptDebuggerImp::atStatement):
3949         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
3950         with its implementation.
3951         (WebCoreScriptDebuggerImp::exception):
3952         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
3953         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
3954         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
3955         to retain the passed-in caller.
3956         * WebView/WebScriptDebugDelegatePrivate.h:
3957           - Removed _current ivar
3958           - Removed enterFrame:/leaveFrame declarations.
3959
3960 2008-03-05  Adam Roben  <aroben@apple.com>
3961
3962         Remove -parsedSource: from WebScriptDebugger
3963
3964         Reviewed by Kevin M.
3965
3966         * WebView/WebCoreScriptDebuggerImp.mm:
3967         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
3968         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
3969         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
3970         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
3971
3972 2008-03-05  Adam Roben  <aroben@apple.com>
3973
3974         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
3975
3976         Reviewed by Kevin M.
3977
3978         * WebView/WebCoreScriptDebuggerImp.mm:
3979         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
3980         trhough to callEvent instead of duplicating its code here.
3981         (WebCoreScriptDebuggerImp::callEvent): Moved code from
3982         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
3983         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
3984         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
3985         (WebCoreScriptDebuggerImp::exception): Moved code from
3986         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
3987         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
3988         -leavingFrame:, and -exceptionRaised:.
3989         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
3990
3991 2008-03-05  Adam Roben  <aroben@apple.com>
3992
3993         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
3994
3995         Reviewed by Kevin M.
3996
3997         * WebView/WebCoreScriptDebuggerImp.mm:
3998         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
3999         -[WebScriptDebugger hitStatement:sourceId:line:].
4000         * WebView/WebScriptDebugDelegate.mm:
4001         (-[WebScriptDebugger webFrame]): Added.
4002         * WebView/WebScriptDebugDelegatePrivate.h:
4003
4004 2008-03-05  Adam Roben  <aroben@apple.com>
4005
4006         Remove WebCoreScriptDebugger
4007
4008         Reviewed by Kevin M.
4009
4010         * WebView/WebCoreScriptDebugger.h: Removed.
4011         * WebView/WebCoreScriptDebugger.mm: Removed.
4012         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
4013         with WebScriptDebugger.
4014         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
4015         delegate] with just m_debugger.
4016         (toNSString): Moved here from WebCoreScriptDebugger.mm.
4017         (toNSURL): Ditto.
4018         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
4019         (WebCoreScriptDebuggerImp::sourceParsed):
4020         (WebCoreScriptDebuggerImp::callEvent):
4021         (WebCoreScriptDebuggerImp::atStatement):
4022         (WebCoreScriptDebuggerImp::returnEvent):
4023         (WebCoreScriptDebuggerImp::exception):
4024         * WebView/WebScriptDebugDelegate.mm:
4025         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
4026         WebCoreScriptDebuggerImp, so initialize it properly.
4027         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
4028         WebCoreScriptDebuggerImp.
4029
4030 2008-03-05  Adam Roben  <aroben@apple.com>
4031
4032         Move WebCoreScriptDebuggerImp to its own source files
4033
4034         Also changed WebCoreScriptDebuggerImp coding style to match our style
4035         guidelines.
4036
4037         Reviewed by Kevin M.
4038
4039         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
4040         function.
4041         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
4042         implementation.
4043         (toNSURL): Made no longer static.
4044         * WebView/WebCoreScriptDebuggerImp.h: Added.
4045         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
4046         WebCoreScriptDebugger.mm and cleaned up.
4047         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
4048         (WebCoreScriptDebuggerImp::sourceParsed):
4049         (WebCoreScriptDebuggerImp::callEvent):
4050         (WebCoreScriptDebuggerImp::atStatement):
4051         (WebCoreScriptDebuggerImp::returnEvent):
4052         (WebCoreScriptDebuggerImp::exception):
4053
4054 2008-03-05  Adam Roben  <aroben@apple.com>
4055
4056         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
4057
4058         Reviewed by Kevin M.
4059
4060         * WebView/WebCoreScriptDebugger.h:
4061           - Removed newFrameWithGlobalObject:caller:state: from
4062             WebScriptDebugger protocol
4063           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
4064           - Removed _current ivar from WebCoreScriptDebugger
4065         * WebView/WebCoreScriptDebugger.mm:
4066         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
4067         the delegate.
4068         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
4069         * WebView/WebScriptDebugDelegate.mm:
4070         (-[WebScriptDebugger dealloc]): Added code to release _current.
4071         (-[WebScriptDebugger enterFrame:]): Added. Code came from
4072         WebCoreScriptDebugger.
4073         (-[WebScriptDebugger leaveFrame]): Ditto.
4074         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
4075
4076 2008-03-05  Adam Roben  <aroben@apple.com>
4077
4078         Remove WebCoreScriptCallFrame
4079
4080         Reviewed by Tim.
4081
4082         * WebView/WebCoreScriptDebugger.h:
4083           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
4084           - Replaced -newWrapperForFrame: with
4085             -newFrameWithGlobalObject:caller:state:
4086           - Removed WebCoreScriptCallFrame interface.
4087         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
4088         with WebScriptCallFrame.
4089         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
4090         -newFrameWithGlobalObject:caller:state.
4091         (-[WebCoreScriptDebugger _leaveFrame]):
4092         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
4093         _private ivar to be of type WebScriptCallFramePrivate*.
4094         * WebView/WebScriptDebugDelegate.mm:
4095           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
4096           - Added WebScriptCallFramePrivate
4097         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
4098         (-[WebScriptDebugger hitStatement:sourceId:line:]):
4099         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
4100         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
4101         (-[WebScriptCallFramePrivate dealloc]): Added.
4102         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
4103         Code came from WebCoreScriptCallFrame.
4104         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
4105         ivar.
4106         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
4107         _private with direct access of _private's ivars.
4108         (-[WebScriptCallFrame caller]): Ditto.
4109         (-[WebScriptCallFrame scopeChain]): Ditto.
4110         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
4111
4112 2008-03-05  Adam Roben  <aroben@apple.com>
4113
4114         Move -_convertValueToObjcValue to WebScriptCallFrame
4115
4116         Reviewed by Darin.
4117
4118         * WebView/WebCoreScriptDebugger.h: Removed declaration of
4119         -_convertValueToObjcValue.
4120         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
4121         * WebView/WebScriptDebugDelegate.mm:
4122         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
4123         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
4124         (-[WebScriptCallFrame scopeChain]): Changed to call
4125         -_convertValueToObjcValue on self instead of _private.
4126         (-[WebScriptCallFrame exception]): Ditto.
4127         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
4128
4129 2008-03-05  Adam Roben  <aroben@apple.com>
4130
4131         Move -exception and -evaluateWebScript: to WebScriptCallFrame
4132
4133         Reviewed by Darin.
4134
4135         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
4136         and -evaluateWebScript:.
4137         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
4138         -evaluateWebScript:.
4139         * WebView/WebScriptDebugDelegate.mm:
4140         (-[WebScriptCallFrame exception]): Added. Code came from
4141         -[WebCoreScriptCallFrame exception].
4142         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
4143         -[WebCoreScriptCallFrame evaluateWebScript:].
4144
4145 2008-03-05  Adam Roben  <aroben@apple.com>
4146
4147         Move -scopeChain to WebScriptCallFrame
4148
4149         Reviewed by Darin.
4150
4151         * WebView/WebCoreScriptDebugger.h:
4152           - Added declarations of -globalObject and -_convertValueToObjcValue:
4153             to WebCoreScriptCallFrame
4154           - Removed declaration of -scopeChain.
4155         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
4156         within the main WebCoreScriptCallFrame implementation.
4157         (-[WebCoreScriptCallFrame globalObject]): Added.
4158         * WebView/WebScriptDebugDelegate.mm:
4159         (-[WebScriptCallFrame scopeChain]): Added. Code came from
4160         -[WebCoreScriptCallFrame scopeChain].
4161
4162 2008-03-05  Adam Roben  <aroben@apple.com>
4163
4164         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
4165
4166         Reviewed by Darin.
4167
4168         * WebView/WebCoreScriptDebugger.h:
4169           - Removed #else case of #ifdef __cplusplus since this file is only
4170             ever used by C++ Objective-C files
4171           - Removed 'using KJS::ExecState' statement since we prefer not to
4172             have using statements in header files