Add radar number
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-07-28  Anders Carlsson  <andersca@apple.com>
2
3         Reviewed by Kevin Decker.
4
5         Based on a patch by Dimcho Balev.
6         
7         https://bugs.webkit.org/show_bug.cgi?id=18676
8         <rdar://problem/6106578>
9         Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
10
11         * Plugins/WebBaseNetscapePluginStream.h:
12         Add NPP_GetValue pointer.
13         
14         * Plugins/WebBaseNetscapePluginStream.mm:
15         (-[WebBaseNetscapePluginStream setPlugin:]):
16         Initialize NPP_GetValue.
17         
18         (-[WebBaseNetscapePluginStream wantsAllStreams]):
19         Call NPP_GetValue.
20         
21         * Plugins/WebPlugInStreamLoaderDelegate.h:
22         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
23         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
24         (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
25         Implement this and call down to the stream.
26
27 2008-07-28  Anders Carlsson  <andersca@apple.com>
28
29         Reviewed by Adam.
30
31         <rdar://problem/6105529> 
32         https://bugs.webkit.org/show_bug.cgi?id=19659
33         Turning off plugins causes crash
34         
35         When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
36         end up in a state where they don't have an event handler. Because of this, we need to 
37         check that the plug-in has been started before calling the event handler.
38         
39         * Plugins/WebBaseNetscapePluginView.mm:
40         (-[WebBaseNetscapePluginView sendActivateEvent:]):
41         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
42         (-[WebBaseNetscapePluginView setHasFocus:]):
43         (-[WebBaseNetscapePluginView mouseDown:]):
44         (-[WebBaseNetscapePluginView mouseUp:]):
45         (-[WebBaseNetscapePluginView mouseEntered:]):
46         (-[WebBaseNetscapePluginView mouseExited:]):
47         (-[WebBaseNetscapePluginView handleMouseMoved:]):
48         (-[WebBaseNetscapePluginView mouseDragged:]):
49         (-[WebBaseNetscapePluginView scrollWheel:]):
50         (-[WebBaseNetscapePluginView keyUp:]):
51         (-[WebBaseNetscapePluginView keyDown:]):
52         (-[WebBaseNetscapePluginView flagsChanged:]):
53         (-[WebBaseNetscapePluginView cut:]):
54         (-[WebBaseNetscapePluginView copy:]):
55         (-[WebBaseNetscapePluginView paste:]):
56         (-[WebBaseNetscapePluginView selectAll:]):
57         (-[WebBaseNetscapePluginView drawRect:]):
58         (-[WebBaseNetscapePluginView inputContext]):
59
60 2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>
61
62         Reviewed by Geoff Garen.
63
64         Changes to accommodate newly named/signatured loading methods in WebCore.
65
66         * Plugins/WebNetscapePluginStream.mm:
67         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
68         * Plugins/WebPluginContainerCheck.mm:
69         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
70         * WebView/WebPDFView.mm:
71         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
72
73 2008-07-21  Mark Rowe  <mrowe@apple.com>
74
75         Reviewed by Sam Weinig.
76
77         <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
78
79         * Configurations/Version.xcconfig:
80         * Info.plist:
81
82 2008-07-21  Anders Carlsson  <andersca@apple.com>
83
84         Reviewed by Geoff.
85
86         <rdar://problem/5820667> 
87         CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
88         
89         Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
90         
91         * Plugins/WebBaseNetscapePluginView.mm:
92         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
93
94 2008-07-21  Mark Rowe  <mrowe@apple.com>
95
96         Reviewed by Adam Roben.
97
98         <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
99
100         Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
101         This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
102
103         * WebView/WebHTMLView.mm:
104
105 2008-07-21  Mark Rowe  <mrowe@apple.com>
106
107         Reviewed by Adam Roben.
108
109         Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
110         only uses objc_msgSend_fpret for long double return values.  For float return
111         values the standard objc_msgSend is used, as on ppc and ppc64.
112
113         * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
114         objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
115         as that method is defined by the Objective-C runtime for x86_64.
116         (CallDelegateReturningFloat):
117
118 2008-07-14  Dan Bernstein  <mitz@apple.com>
119
120         Reviewed by John Sullivan.
121
122         - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
123
124         * Plugins/WebBaseNetscapePluginView.mm:
125         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
126         to account for the case of being drawn into a bitmap context that is not
127         a window's backing store. In that case, there are no valid "rects being
128         drawn" to clip to.
129         * WebView/WebHTMLView.mm:
130         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
131         Added an override of this NSView method which is used in for
132         -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
133         machinery overrides, it sets subviews aside before invoking the
134         superclass implementation. On Tiger, it also updates the layout.
135
136 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
137
138         Reviewed by Geoff Garen.
139
140         Eliminate per-thread JavaScript global data instance support and make arbitrary
141         global data/global object combinations possible.
142
143         * Misc/WebCoreStatistics.mm:
144         (+[WebCoreStatistics javaScriptObjectsCount]):
145         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
146         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
147         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
148         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
149         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
150         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
151
152 2008-07-11  Stephanie Lewis  <slewis@apple.com>
153
154         Reviewed by Darin Adler.
155
156         Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
157
158         * WebView/WebPreferences.m: Removed.
159         * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
160         (+[WebPreferences initialize]): if running in Default enable full  document teardown
161         (-[WebPreferences editableLinkBehavior]):
162         (-[WebPreferences setFullDocumentTeardownEnabled:]):
163         * WebView/WebView.mm:
164         (-[WebView _close]): disable leak messages if using fast teardown
165
166 2008-07-10  Mark Rowe  <mrowe@apple.com>
167
168         Reviewed by Sam Weinig.
169
170         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
171
172         * Configurations/WebKit.xcconfig:
173
174 2008-07-10  Mark Rowe  <mrowe@apple.com>
175
176         Reviewed by Sam Weinig.
177
178         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
179
180         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
181         * WebView/WebFrameLoadDelegate.h: Ditto.
182         * WebView/WebUIDelegate.h: Ditto.
183
184 2008-07-10  Anders Carlsson  <andersca@apple.com>
185
186         Reviewed by Mark.
187         
188         Add availability macros for the new WebPlugin methods.
189
190         * Plugins/WebPlugin.h:
191         * Plugins/WebPluginViewFactory.h:
192
193 2008-07-09  Mark Rowe  <mrowe@apple.com>
194
195         Reviewed by Geoff Garen.
196
197         Don't warn about deprecated functions in production builds.
198
199         * Configurations/Base.xcconfig:
200         * Configurations/DebugRelease.xcconfig:
201
202 2008-07-09  Brady Eidson  <beidson@apple.com>
203
204         Reviewed by Darin
205
206         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
207         has been installed in a frame tree.
208
209         The root of this problem was that calling init() on a new frame could end up calling arbitrary
210         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
211         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
212         destroying the frame.
213
214         Note that each platforms WebKit API layer needs to make this new guarantee:
215         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
216         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
217         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
218
219         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
220         architectural improvement we can make in the future so the individual platform clients are no longer
221         vulnerable to this problem, which should really have been a WebCore issue.
222
223         * WebCoreSupport/WebFrameLoaderClient.mm:
224         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
225           Don't appendChild() the new frame here.
226           Null-check the new frame's page before loading the URL into it, as it might already have been
227           removed from the page.
228
229         * WebView/WebFrame.mm:
230         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
231           go ahead and install the new frame in the frame tree *before* calling init() on it.
232
233 2008-07-09  Anders Carlsson  <andersca@apple.com>
234
235         Reviewed by Darin.
236
237         Make some WebPlugin and WebPluginFactory SPI public.
238         
239         * Plugins/WebPlugin.h:
240         * Plugins/WebPluginPrivate.h:
241         * Plugins/WebPluginViewFactory.h:
242         * Plugins/WebPluginViewFactoryPrivate.h:
243
244 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
245
246         Reviewed by Anders.
247
248         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
249         unsuccessful.
250
251         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
252         newStreamSuccessful.
253         * Plugins/WebBaseNetscapePluginStream.mm:
254         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
255         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
256         newStreamSuccessful to YES.
257         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
258         NPP_DestroyStream if newStreamSuccessful is true.
259
260 2008-07-08  Dan Bernstein  <mitz@apple.com>
261
262         Reviewed by John Sullivan.
263
264         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
265
266         * WebView/WebHTMLView.mm:
267         (-[WebHTMLView addWindowObservers]): Added code to observe when the
268         window goes onscreen.
269         (-[WebHTMLView removeWindowObservers]): Added.
270         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
271         not update when offscreen, calls -setNeedsDisplay: just before it comes
272         onscreen.
273         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
274         * WebView/WebPreferences.m:
275         (+[WebPreferences initialize]): Made updates when offscreen on by
276         default.
277         (-[WebPreferences updatesWhenOffscreen]): Added.
278         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
279         * WebView/WebPreferencesPrivate.h:
280         * WebView/WebView.mm:
281         (-[WebView _preferencesChangedNotification:]): Added code to update the
282         updatesWhenOffscreen setting in WebCore.
283
284 2008-07-07  Anders Carlsson  <andersca@apple.com>
285
286         Reviewed by Darin.
287
288         Speculative fix for     
289         <rdar://problem/5839800>
290         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
291         
292         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
293         
294         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
295         This is usually protected by _private->closed, but in this case it might still be false.
296
297         * WebView/WebHTMLView.mm:
298         (-[WebHTMLView close]):
299
300 2008-07-05  Mark Rowe  <mrowe@apple.com>
301
302         Reviewed by John Sullivan.
303
304         Remove WebSearchableTextView as it has been unused for some time now.
305
306         * Misc/WebSearchableTextView.h: Removed.
307         * Misc/WebSearchableTextView.m: Removed.
308
309 2008-07-05  Mark Rowe  <mrowe@apple.com>
310
311         Reviewed by John Sullivan.
312
313         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
314
315         * Misc/WebNSUserDefaultsExtras.m:
316         (-[NSString _webkit_HTTPStyleLanguageCode]):
317
318 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
319
320         Inspired and reviewed by Mark Rowe.
321
322         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
323
324         * Carbon/HIViewAdapter.m:
325         * DOM/WebDOMOperations.mm:
326         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
327         * DefaultDelegates/WebDefaultPolicyDelegate.m:
328         * History/WebBackForwardList.mm:
329         * History/WebHistory.mm:
330         * History/WebHistoryItem.mm:
331         * History/WebHistoryItemInternal.h:
332         * Misc/WebCoreStatistics.mm:
333         * Misc/WebDownload.m:
334         * Misc/WebGraphicsExtras.c:
335         * Misc/WebKitLogging.h:
336         * Misc/WebKitSystemBits.m:
337         * Misc/WebLocalizableStrings.m:
338         * Misc/WebNSArrayExtras.m:
339         * Misc/WebNSDataExtras.m:
340         * Misc/WebNSDictionaryExtras.m:
341         * Misc/WebNSFileManagerExtras.m:
342         * Misc/WebNSPasteboardExtras.mm:
343         * Misc/WebNSURLExtras.mm:
344         * Misc/WebNSUserDefaultsExtras.m:
345         * Panels/WebAuthenticationPanel.m:
346         * Panels/WebPanelAuthenticationHandler.m:
347         * Plugins/WebBaseNetscapePluginView.mm:
348         * Plugins/WebBasePluginPackage.m:
349         * Plugins/WebNetscapePluginEmbeddedView.mm:
350         * Plugins/WebPluginContainerCheck.mm:
351         * Plugins/WebPluginController.mm:
352         * Plugins/WebPluginDatabase.mm:
353         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
354         * WebCoreSupport/WebKeyGenerator.m:
355         * WebCoreSupport/WebViewFactory.mm:
356         * WebKitPrefix.h:
357         * WebView/WebHTMLRepresentation.mm:
358         * WebView/WebPDFRepresentation.m:
359         * WebView/WebPDFView.mm:
360         * WebView/WebScriptDebugger.mm:
361
362 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
363
364         Reviewed by Darin.
365
366         Disable JSLock for per-thread contexts.
367
368         * Misc/WebCoreStatistics.mm:
369         (+[WebCoreStatistics javaScriptObjectsCount]):
370         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
371         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
372         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
373         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
374         (+[WebCoreStatistics shouldPrintExceptions]):
375         (+[WebCoreStatistics setShouldPrintExceptions:]):
376         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
377         * Plugins/WebBaseNetscapePluginView.mm:
378         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
379         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
380         (-[WebBaseNetscapePluginView start]):
381         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
382         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
383         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
384         (-[WebBaseNetscapePluginView loadPluginRequest:]):
385         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
386         * Plugins/WebPluginController.mm:
387         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
388         (-[WebPluginController startAllPlugins]):
389         (-[WebPluginController stopAllPlugins]):
390         (-[WebPluginController addPlugin:]):
391         (-[WebPluginController destroyPlugin:]):
392         (-[WebPluginController destroyAllPlugins]):
393         * WebView/WebFrame.mm:
394         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
395         * WebView/WebScriptDebugDelegate.mm:
396         (-[WebScriptCallFrame evaluateWebScript:]):
397         * WebView/WebView.mm:
398         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
399         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
400         doesn't need locking. In the future, it may be possible to remove some of these if we
401         establish that this won't make JSC assertions fail (and that we don't want to add such
402         assertions either).
403         Added includes that are now needed.
404
405 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
406
407         Build fix.
408
409         * WebView/WebView.mm:
410
411 2008-07-01  Anders Carlsson  <andersca@apple.com>
412
413         Reviewed by Darin.
414
415         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
416         
417         * Plugins/WebBaseNetscapePluginView.mm:
418         (-[WebBaseNetscapePluginView _createPlugin]):
419         Register the plug-in instance.
420         
421         (-[WebBaseNetscapePluginView _destroyPlugin]):
422         Unegister the plug-in instance.
423         
424         * Plugins/WebNetscapePluginPackage.m:
425         (-[WebNetscapePluginPackage load]):
426         Set NPN_PluginThreadAsyncCall.
427         
428         * Plugins/npapi.mm:
429         (NPN_PluginThreadAsyncCall):
430         Implement this.
431
432 2008-07-01  Dan Bernstein  <mitz@apple.com>
433
434         Reviewed by Darin Adler.
435
436         - WebKit part of moving the method to set the base writing direction from Frame to Editor
437
438         * WebView/WebHTMLView.mm:
439         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
440         Editor method.
441         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
442         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
443
444 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
445
446         Build fix: forgot to check in this file.
447
448         * WebView/WebScriptDebugger.mm:
449         (WebScriptDebugger::WebScriptDebugger):
450
451 2008-06-30  Dan Bernstein  <mitz@apple.com>
452
453         Reviewed by Adele Peterson.
454
455         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
456
457         * WebView/WebHTMLView.mm:
458         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
459         WebCore::Frame::setSelectionBaseWritingDirection() instead of
460         WebCore::Editor::setBaseWritingDirection().
461         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
462         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
463
464 2008-06-28  Darin Adler  <darin@apple.com>
465
466         - fix build
467
468         * WebView/WebView.mm:
469         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
470
471 2008-06-26  Anders Carlsson  <andersca@apple.com>
472
473         Reviewed by Darin.
474
475         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
476         if necessary. Use this for the WebView class. 
477                 
478         * WebView/MainThreadObjectDeallocator.h: Added.
479         * WebView/MainThreadObjectDeallocator.mm: Added.
480         (deallocCallback):
481         (scheduleDeallocateOnMainThread):
482         * WebView/WebView.mm:
483         (-[WebViewPrivate dealloc]):
484         (+[WebView initialize]):
485
486 2008-06-25  Anders Carlsson  <andersca@apple.com>
487
488         Reviewed by Mark.
489
490         <rdar://problem/5984270> 
491         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
492         
493         * WebView/WebView.mm:
494         (tigerMailReleaseIMP):
495         New method that makes sure that the final release happens on the main thread.
496         
497         (-[WebView release]):
498         New method that just calls [super release];
499         
500         (+[WebView initialize]):
501         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
502
503 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
504
505         Reviewed by Geoff.
506
507         Make Machine per-JSGlobalData.
508
509         * WebView/WebScriptDebugger.mm:
510         (WebScriptDebugger::WebScriptDebugger):
511
512 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
513
514         Reviewed by Darin.
515
516         Prepare JavaScript heap for being per-thread.
517
518         * Misc/WebCoreStatistics.mm:
519         (+[WebCoreStatistics javaScriptObjectsCount]):
520         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
521         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
522         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
523         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
524         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
525         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
526
527 2008-06-17  Darin Adler  <darin@apple.com>
528
529         Reviewed by Sam.
530
531         * WebView/WebHTMLView.mm:
532         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
533         to create a CSSMutableStyleDeclaration.
534
535 2008-06-16  Mark Rowe  <mrowe@apple.com>
536
537         Reviewed by Darin Adler.
538
539         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
540
541         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
542         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
543         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
544         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
545
546         * WebView/WebHTMLView.mm:
547         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
548         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
549         * WebView/WebHTMLViewInternal.h:
550         * WebView/WebHTMLViewPrivate.h:
551
552 2008-06-15  Darin Adler  <darin@apple.com>
553
554         - give Frame object functions shorter names: scriptProxy() -> script(),
555           selectionController() -> selection(), animationController() -> animation()
556
557         * Plugins/WebPluginController.mm:
558         (-[WebPluginController webPlugInContainerSelectionColor]):
559         * WebView/WebFrame.mm:
560         (-[WebFrame _attachScriptDebugger]):
561         (-[WebFrame _hasSelection]):
562         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
563         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
564         (-[WebFrame _convertToNSRange:]):
565         (-[WebFrame _convertToDOMRange:]):
566         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
567         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
568         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
569         (-[WebFrame _selectedNSRange]):
570         (-[WebFrame _selectNSRange:]):
571         (-[WebFrame globalContext]):
572         * WebView/WebHTMLView.mm:
573         (-[WebHTMLView _selectedRange]):
574         (-[WebHTMLView _hasSelection]):
575         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
576         (-[WebHTMLView _hasInsertionPoint]):
577         (-[WebHTMLView _isEditable]):
578         (-[WebHTMLView _updateFocusedAndActiveState]):
579         (-[WebHTMLView readSelectionFromPasteboard:]):
580         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
581         (-[WebHTMLView maintainsInactiveSelection]):
582         (-[WebHTMLView paste:]):
583         (isTextInput):
584         (-[WebHTMLView inputContext]):
585         (-[WebTextCompleteController doCompletion]):
586         (-[WebHTMLView selectAll]):
587         (-[WebHTMLView deselectAll]):
588         (-[WebHTMLView selectedAttributedString]):
589         * WebView/WebView.mm:
590         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
591         (-[WebView setSelectedDOMRange:affinity:]):
592         (-[WebView selectedDOMRange]):
593         (-[WebView selectionAffinity]):
594
595 2008-06-15  Darin Adler  <darin@apple.com>
596
597         - rename KJS::List to KJS::ArgList
598
599         * WebView/WebScriptDebugger.h:
600
601 2008-06-15  Darin Adler  <darin@apple.com>
602
603         - new names for more JavaScriptCore files
604
605         * WebView/WebView.mm:
606
607 2008-06-15  Darin Adler  <darin@apple.com>
608
609         - new names for a few key JavaScriptCore files
610
611         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
612         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
613         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
614         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
615         * ForwardingHeaders/kjs/function.h: Removed.
616         * ForwardingHeaders/kjs/internal.h: Removed.
617         * ForwardingHeaders/kjs/object.h: Removed.
618         * ForwardingHeaders/kjs/value.h: Removed.
619         * WebView/WebScriptDebugDelegate.mm:
620
621 2008-06-15  Darin Adler  <darin@apple.com>
622
623         Rubber stamped by Sam.
624
625         - use JS prefix and simpler names for basic JavaScriptCore types,
626           to complement JSValue and JSObject
627
628         * WebView/WebView.mm:
629         (aeDescFromJSValue):
630
631 2008-06-14  Darin Adler  <darin@apple.com>
632
633         Rubber stamped by Sam.
634
635         - new names for kjs_binding.h and kjs_proxy.h
636
637         * WebView/WebFrame.mm:
638         * WebView/WebScriptDebugDelegate.mm:
639         * WebView/WebView.mm:
640
641 2008-06-14  Darin Adler  <darin@apple.com>
642
643         Rubber stamped by Sam.
644
645         - renamed HTMLGenericFormElement to HTMLFormControlElement
646
647         * WebView/WebHTMLRepresentation.mm:
648         (-[WebHTMLRepresentation elementWithName:inForm:]):
649         (-[WebHTMLRepresentation controlsInForm:]):
650
651 2008-06-14  Darin Adler  <darin@apple.com>
652
653         Reviewed by Sam.
654
655         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
656           start ref counts at 1 instead of 0 for speed
657
658         * WebCoreSupport/WebFrameLoaderClient.mm:
659         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
660         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
661         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
662         conventional ones without a special case.
663
664         * WebView/WebDataSource.mm:
665         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
666         this function takes ownership of the DocumentLoader.
667         (-[WebDataSource initWithRequest:]): Use create instead of new.
668         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
669         PassRefPtr and also cleaned up the header a bit.
670
671         * WebView/WebDocumentLoaderMac.h:
672         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
673         functions private.
674
675         * WebView/WebFrame.mm:
676         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
677         of new.
678
679 2008-06-14  Darin Adler  <darin@apple.com>
680
681         Reviewed by Sam.
682
683         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
684           start ref counts at 1 instead of 0 for speed
685
686         * WebView/WebFrame.mm:
687         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
688         * WebView/WebPDFView.mm:
689         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
690
691 2008-06-13  Darin Adler  <darin@apple.com>
692
693         Reviewed by John Sullivan.
694
695         - updated for addition of FormState argument to action policy functions
696         - added WebActionFormKey
697
698         * WebCoreSupport/WebFrameLoaderClient.h:
699         * WebCoreSupport/WebFrameLoaderClient.mm:
700         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
701         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
702         (WebFrameLoaderClient::actionDictionary):
703         * WebKit.exp:
704         * WebView/WebPolicyDelegate.mm:
705         * WebView/WebPolicyDelegatePrivate.h:
706
707 2008-06-12  John Sullivan  <sullivan@apple.com>
708
709         Reviewed by Dan and Darin
710
711         Clear up the confusion about _close (older private method) vs -close (newer public method).
712
713         * WebView/WebView.mm:
714         (-[WebView _isClosed]):
715         simplified style
716         (-[WebView _close]):
717         added a comment about how clients and subclasses should use -close instead
718         (-[WebView dealloc]):
719         call -close instead of _close, so subclasses that override the public method will have the intended behavior
720         (-[WebView close]):
721         added a comment
722         (-[WebView _windowWillClose:]):
723         call -close instead of _close, so subclasses that override the public method will have the intended behavior
724
725         * WebView/WebViewPrivate.h:
726         added a comment about how clients and subclasses should use -close instead
727
728 2008-06-07  Darin Adler  <darin@apple.com>
729
730         Reviewed by Mitz.
731
732         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
733           start ref counts at 1 instead of 0 for speed
734
735         * History/WebHistoryItem.mm:
736         (-[WebHistoryItem init]):
737         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
738         (-[WebHistoryItem initWithURL:target:parent:title:]):
739         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
740         * WebView/WebView.mm:
741         (+[WebView _decodeData:]):
742
743 2008-06-03  Oliver Hunt  <oliver@apple.com>
744
745         Reviewed by Tim.
746
747         Bug 12983: Web Inspector break on the debugger keyword
748         <https://bugs.webkit.org/show_bug.cgi?id=12983>
749
750         Add stubs to allow old webkit debugger interface to build.
751
752         * WebView/WebScriptDebugger.h:
753         * WebView/WebScriptDebugger.mm:
754
755 2008-06-03  Anders Carlsson  <andersca@apple.com>
756
757         Reviewed by Darin.
758
759         <rdar://problem/5980961>
760         
761         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
762         newBottom to be larger than oldBottom which is illegal.
763         
764         * WebView/WebHTMLView.mm:
765         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
766
767 2008-06-02  Anders Carlsson  <andersca@apple.com>
768
769         Reviewed by Mitz.
770
771         Speculative fix for <rdar://problem/5661112> 
772         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
773         
774         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
775         layouts to be triggered.
776         
777         * Plugins/WebBaseNetscapePluginView.mm:
778         (-[WebBaseNetscapePluginView _createPlugin]):
779
780 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
781
782         Reviewed by Darin.
783         
784         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
785         
786         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
787         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
788         setting and retrieving pasteboard types with UTIs, but we don't know of any
789         applications on Tiger that put only PNG on the pasteboard.
790
791         * WebView/WebHTMLView.mm:
792         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
793         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
794
795 2008-05-29  Anders Carlsson  <andersca@apple.com>
796
797         Reviewed by Brady.
798
799         <rdar://problem/5970312> 
800         icon file specified for stand alone web app causes crash if the icon can't be found
801         
802         Handle the case where iconData is null.
803         
804         * Misc/WebIconFetcher.mm:
805         (WebIconFetcherClient::finishedFetchingIcon):
806
807 2008-05-29  Anders Carlsson  <andersca@apple.com>
808
809         Reviewed by Mitz.
810
811         <rdar://problem/5971845>
812         https://bugs.webkit.org/show_bug.cgi?id=19313
813         Add version member to NPCocoaEvent
814
815         Initialize the version member to 0 for all events.
816         
817         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
818         (initializeEvent):
819         (WebNetscapePluginEventHandlerCocoa::drawRect):
820         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
821         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
822         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
823         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
824         (WebNetscapePluginEventHandlerCocoa::focusChanged):
825
826 2008-05-29  Dan Bernstein  <mitz@apple.com>
827
828         Reviewed by Jessica Kahn.
829
830         - fix <rdar://problem/5965013> Page 2 does not print correctly
831
832         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
833         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
834         -viewWillDraw being sent first, which could lead to painting without
835         valid layout. The fix is to ensure up-to-date layout in those methods
836         when printing.
837
838         * WebView/WebHTMLView.mm:
839         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
840         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
841
842 2008-05-28  Anders Carlsson  <andersca@apple.com>
843
844         Reviewed by Jon.
845
846         Remove workaround, this is no longer a problem.
847         
848         * WebView/WebView.mm:
849         (-[WebView _removeObjectForIdentifier:]):
850
851 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
852
853         Reviewed by Tim Hatcher.
854         
855         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
856         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
857         clicking button in returnEvent-crash.html
858         
859         Added implementations for willExecuteProgram and didExecuteProgram, which
860         take care of making sure we're not hanging on to stale data.
861
862 2008-05-27  Timothy Hatcher  <timothy@apple.com>
863
864         Fixes a bug where unplugging the monitor from a video card and
865         moving it to another video card would no longer show OpenGL plugins
866         until you relaunched Safari.
867
868         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
869         attribute to OpenGL contexts
870
871         Reviewed by Kevin Decker.
872
873         * Plugins/WebBaseNetscapePluginView.mm:
874         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
875         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
876         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
877
878 2008-05-25  Mark Rowe  <mrowe@apple.com>
879
880         Reviewed by Darin Adler.
881
882         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
883
884         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
885         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
886
887         * WebView/WebFrame.mm:
888         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
889         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
890         * WebView/WebFrameInternal.h:
891         * WebView/WebFramePrivate.h:
892
893 2008-05-23  Timothy Hatcher  <timothy@apple.com>
894
895         Fix attaching and detaching the Web Inspector. This change removes
896         the clunky animation that never looked right and was causing issues
897         where the inspected WebView would get into a no useable state.
898
899         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
900         can cause the inspected WebVIew to be unusable
901
902         Reviewed by Adam Roben.
903
904         * WebCoreSupport/WebInspectorClient.mm:
905         (-[WebInspectorWindowController close]): Removes animation code.
906         Sets the frame directly and does a displayIfNeeded to prevent
907         showing the Inspector in the page and in the Inspector window.
908         (-[WebInspectorWindowController showWindow:]): Removes animation code.
909         Sets the frame directly.
910         (-[WebInspectorWindowController attach]): Simplified.
911         (-[WebInspectorWindowController detach]): Ditto.
912
913 2008-05-22  Dan Bernstein  <mitz@apple.com>
914
915         Reviewed by Darin Adler.
916
917         - fix broken documentation of
918           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
919
920         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
921         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
922
923 2008-05-22  Timothy Hatcher  <timothy@apple.com>
924
925         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
926
927         Reviewed by Adam Roben.
928
929         * WebCoreSupport/WebInspectorClient.mm:
930         (-[WebInspectorWindowController showWebInspector:]):
931         (-[WebInspectorWindowController showErrorConsole:]):
932         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
933         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
934         (-[WebInspectorWindowController validateUserInterfaceItem:]):
935         * WebInspector/WebInspector.h:
936         * WebInspector/WebInspector.mm:
937         (-[WebInspector showConsole:]):
938         (-[WebInspector showTimeline:]):
939         (-[WebInspector isDebuggingJavaScript]):
940         (-[WebInspector toggleDebuggingJavaScript:]):
941         (-[WebInspector startDebuggingJavaScript:]):
942         (-[WebInspector stopDebuggingJavaScript:]):
943         (-[WebInspector isProfilingJavaScript]):
944         (-[WebInspector toggleProfilingJavaScript:]):
945         (-[WebInspector startProfilingJavaScript:]):
946         (-[WebInspector stopProfilingJavaScript:]):
947
948 2008-05-22  Josh Aas  <joshmoz@gmail.com>
949
950         Reviewed by Anders.
951
952         <rdar://problem/5956429> 
953         https://bugs.webkit.org/show_bug.cgi?id=19192
954         remove NPNVpluginEventModel, fix example plugin
955         
956         * Plugins/WebBaseNetscapePluginView.mm:
957         (-[WebBaseNetscapePluginView getVariable:value:]):
958
959 2008-05-21  Anders Carlsson  <andersca@apple.com>
960
961         Reviewed by Maciej.
962
963         Add WebIconFetcher.
964         
965         * Misc/WebIconFetcher.h: Added.
966         * Misc/WebIconFetcher.mm: Added.
967         (WebIconFetcherClient::WebIconFetcherClient):
968         (WebIconFetcherClient::finishedFetchingIcon):
969         (WebIconFetcherClient::setFetcher):
970         (-[WebIconFetcher init]):
971         (-[WebIconFetcher dealloc]):
972         (-[WebIconFetcher finalize]):
973         (-[WebIconFetcher cancel]):
974         (-[WebIconFetcher _initWithIconFetcher:client:]):
975         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
976         * Misc/WebIconFetcherInternal.h: Added.
977         * WebView/WebFrame.mm:
978         (-[WebFrame fetchApplicationIcon:selector:]):
979         * WebView/WebFramePrivate.h:
980
981 === End merge of squirrelfish ===
982
983 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
984
985         Reviewed by Tim Hatcher.
986         
987         Updated for API changes from merging with trunk WebCore's new debugger.
988
989         * WebView/WebScriptDebugDelegate.mm:
990         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
991         exception return, since the DebuggerCallFrame no longer automatically
992         substitutes the exception for the return value.
993
994         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
995         lexical global object, since the debugger attaches based on dynamic
996         global object.
997
998 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
999
1000         Reviewed by Oliver Hunt.
1001         
1002         Re-enabled previously disabled debugging functionality.
1003         
1004         There are two major changes from how the WebKit debugger used to work:
1005         
1006         (1) All the interesting bits are implemented down in JavaScriptCore. The
1007         debugger just calls through to KJS::DebuggerCallFrame for everything.
1008         
1009         (2) Instead of copyihng a pointer to an ExecState once, the debugger
1010         copies the DebuggerCallFrame passed to it in each callback. This is
1011         because the VM no longer maintains a fully transparent execution state
1012         to which you can hold a pointer, and the DebuggerCallFrames it vends
1013         are temporaries.
1014         
1015         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
1016         from its function. This is safer than the old method, which was to
1017         hold a stale ExecState* and hope for the best.
1018
1019 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1020
1021         Reviewed by Oliver Hunt.
1022
1023         Updated for API changes in KJS::Debugger.
1024
1025         * WebView/WebFrame.mm:
1026         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
1027         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
1028
1029 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1030
1031         Reviewed by Oliver Hunt.
1032         
1033         Updated WebScriptDebugger API to accept a SourceProvider instead
1034         of a WebCore::String, to avoid copying.
1035
1036         (WebScriptDebugger::sourceParsed): Updated this function not to return
1037         a value.
1038
1039 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1040
1041         Build fix: #ifdef'd out some code that doesn't work anymore.
1042
1043 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1044
1045         Reviewed by Oliver Hunt.
1046         
1047         #ifdef'd out some debugger code that doesn't work anymore.
1048
1049         * WebView/WebScriptDebugDelegate.mm:
1050         (-[WebScriptCallFrame scopeChain]):
1051
1052 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
1053
1054         Build fix.
1055
1056         * ChangeLog:
1057         * WebView/WebScriptDebugDelegate.mm:
1058         (-[WebScriptCallFrame scopeChain]):
1059
1060 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
1061
1062         Reviewed by Oliver Hunt.
1063         
1064         Build fix.
1065
1066 === Start merge of squirrelfish ===
1067
1068 2008-05-21  Darin Adler  <darin@apple.com>
1069
1070         - fix build
1071
1072         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
1073         if we want, but if we do, we should probably make some refinements like checking _private->closed
1074         and applicationIsTerminating.
1075
1076 2008-05-21  Darin Adler  <darin@apple.com>
1077
1078         Reviewed by Anders and Kevin Decker.
1079
1080         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
1081
1082         * WebView/WebView.mm:
1083         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
1084         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
1085         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
1086         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
1087         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
1088
1089 2008-05-19  Stephanie Lewis  <slewis@apple.com>
1090
1091         Reviewed by Darin.
1092     
1093         more fast teardown performance work
1094
1095         * Misc/WebDownload.m:
1096         (-[WebDownloadInternal downloadDidBegin:]):
1097         (-[WebDownloadInternal downloadDidFinish:]):
1098         (-[WebDownloadInternal download:didFailWithError:]):
1099         * WebCoreSupport/WebChromeClient.h:
1100         * WebCoreSupport/WebChromeClient.mm:
1101         (WebChromeClient::disableSuddenTermination):
1102         (WebChromeClient::enableSuddenTermination):
1103
1104 2008-05-18  Dan Bernstein  <mitz@apple.com>
1105
1106         Reviewed by Sam Weinig.
1107
1108         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
1109
1110         * Panels/WebAuthenticationPanel.m:
1111         (-[WebAuthenticationPanel setUpForChallenge:]):
1112
1113 2008-05-16  Timothy Hatcher  <timothy@apple.com>
1114
1115         Removes WebScriptDebugServer files and related calls. This removes
1116         the hooks that Drosera uses for debugging. Now that the Web Inspector
1117         has a better debugger, we don't need these anymore.
1118
1119         Reviewed by Sam Weinig.
1120
1121         * DefaultDelegates/WebScriptDebugServer.h: Removed.
1122         * DefaultDelegates/WebScriptDebugServer.m: Removed.
1123         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
1124         * WebCoreSupport/WebFrameLoaderClient.mm:
1125         * WebKit.exp:
1126         * WebView/WebScriptDebugDelegate.mm:
1127         * WebView/WebScriptDebugger.mm:
1128         (WebScriptDebugger::sourceParsed):
1129         (WebScriptDebugger::callEvent):
1130         (WebScriptDebugger::atStatement):
1131         (WebScriptDebugger::returnEvent):
1132         (WebScriptDebugger::exception):
1133         * WebView/WebView.mm:
1134         (-[WebView _commonInitializationWithFrameName:groupName:]):
1135         * WebView/WebViewPrivate.h:
1136
1137 2008-05-16  Brady Eidson  <beidson@apple.com>
1138
1139         Reviewed by Anders
1140
1141         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
1142
1143         Took the opportunity to touch up another pref that needs the same standardization.
1144         That pref is currently not in use on Mac.
1145
1146         * WebView/WebPreferences.m:
1147         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
1148         (-[WebPreferences _localStorageDatabasePath]):
1149         (-[WebPreferences _setLocalStorageDatabasePath:]):
1150         (-[WebPreferences _ftpDirectoryTemplatePath]):
1151
1152 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
1153
1154         Reviewed by Alice Liu
1155
1156         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
1157
1158         * WebView/WebFrame.mm:
1159         (-[WebFrame _accessibilityTree]):
1160
1161 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1162         
1163         fix mac build
1164
1165         * WebView/WebView.mm:
1166         (-[WebView closeWithFastTeardown]):
1167
1168 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1169
1170         Reviewed by Anders.
1171
1172         Turn on fast teardown.  I added a preference for using full teardown because 
1173         the LEAKS output will be useless without a full teardown.  
1174
1175         preference for fullteardown
1176         * WebView/WebPreferenceKeysPrivate.h:
1177         * WebView/WebPreferences.m:
1178         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1179         (-[WebPreferences fullDocumentTeardownEnabled]):
1180         * WebView/WebPreferencesPrivate.h:
1181         
1182         on application quit dispatch unload events and destroy plugins then exit
1183         * WebView/WebView.mm:
1184         (-[WebView closeWithFastTeardown]):
1185         (-[WebView _close]):
1186         * WebView/WebViewPrivate.h:
1187
1188 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1189
1190         Reviewed by Anders.
1191
1192         get the pending frame unload count from WebCore
1193
1194         * WebView/WebFrame.mm:
1195         (-[WebFrame _pendingFrameUnloadEventCount]):
1196         * WebView/WebFramePrivate.h:
1197
1198 2008-05-15  John Sullivan  <sullivan@apple.com>
1199
1200         Reviewed by Kevin Decker
1201         
1202         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1203           screen when new tab appears
1204           
1205         The highlight should go away entirely, but this simple patch just makes it not jump away.
1206         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1207
1208         * WebInspector/WebNodeHighlight.m:
1209         (-[WebNodeHighlight _repositionHighlightWindow]):
1210         Bail out if target view isn't in a window
1211
1212 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1213
1214         Reviewed by Anders.
1215
1216         Track views that contain plugin instances so that they can be destroyed at application
1217         quit without walking the entire document tree.
1218
1219         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1220         plugins are created and destroyed
1221         * Plugins/WebBaseNetscapePluginView.mm:
1222         (-[WebBaseNetscapePluginView start]):
1223         (-[WebBaseNetscapePluginView stop]):
1224  
1225         Add/remove WebKit plugin views from instance list
1226         * Plugins/WebPluginController.mm:
1227         (-[WebPluginController addPlugin:]):
1228         (-[WebPluginController destroyPlugin:]):
1229         (-[WebPluginController destroyAllPlugins]):
1230
1231         Add a set of views with plugin instances to the WebPluginDatabase
1232         * Plugins/WebPluginDatabase.h:
1233         * Plugins/WebPluginDatabase.mm:
1234         (-[WebPluginDatabase init]):
1235         (-[WebPluginDatabase dealloc]):
1236         (-[WebPluginDatabase addPluginInstanceView:]):
1237         (-[WebPluginDatabase removePluginInstanceView:]):
1238         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1239         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1240         
1241         Handle cases where plugin views are detached before the plugin is destroyed.
1242         * WebCoreSupport/WebFrameLoaderClient.mm:
1243         (WebFrameLoaderClient::detachedFromParent2):
1244         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1245         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1246
1247         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1248         * WebView/WebHTMLView.mm:
1249         (-[WebHTMLView _destroyAllWebPlugins]):
1250         * WebView/WebHTMLViewInternal.h:
1251         * WebView/WebView.mm:
1252         (-[WebView addPluginInstanceView:]):
1253         (-[WebView removePluginInstanceView:]):
1254         (-[WebView removePluginInstanceViewsFor:]):
1255         * WebView/WebViewInternal.h:
1256
1257 2008-05-15  Brady Eidson  <beidson@apple.com>
1258
1259         Reviewed by Tim Hatcher
1260
1261         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1262         before setting the page group of the new page.
1263         
1264         * WebView/WebView.mm:
1265         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1266           immediately after creating the page so it is in place for initializing the LocalStorageThread
1267
1268 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1269
1270         Fixes the bug where the Web Inspector would flash white while resizing.
1271         This was cause by deferring the window creation.
1272
1273         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1274
1275         Reviewed by Darin Adler.
1276
1277         * WebCoreSupport/WebInspectorClient.mm:
1278         (-[WebInspectorWindowController window]): Don't defer the window creation.
1279
1280 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1281
1282         Tiger build fix.
1283
1284         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1285
1286 2008-05-15  Adele Peterson  <adele@apple.com>
1287
1288         Reviewed and landed by Alexey.
1289
1290         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1291
1292         * Misc/WebNSAttributedStringExtras.mm:
1293         (+[NSAttributedString _web_attributedStringFromRange:]):
1294
1295 2008-05-14  Eric Seidel  <eric@webkit.org>
1296
1297         Reviewed by Oliver.
1298
1299         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1300
1301         * WebView/WebResource.mm:
1302         (-[WebResource data]):
1303
1304 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1305
1306         Reviewed by Dan Bernstein.
1307
1308         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1309
1310         * Plugins/nptextinput.h:
1311
1312 2008-05-13  Anders Carlsson  <andersca@apple.com>
1313
1314         Reviewed by Sam.
1315
1316         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1317         Instead, do it in [WebCache empty].
1318         
1319         * Misc/WebCache.mm:
1320         (+[WebCache empty]):
1321         * WebView/WebView.mm:
1322         (+[WebView _setCacheModel:]):
1323
1324 2008-05-13  chris fleizach  <cfleizach@apple.com>
1325
1326         Reviewed by Beth Dakin
1327
1328         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1329
1330         * WebCoreSupport/WebViewFactory.mm:
1331         (-[WebViewFactory AXWebAreaText]):
1332
1333 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1334
1335         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1336         was referencing a nil WebView under validateUserInterfaceItem.
1337         The validateUserInterfaceItem methods was being called at a time
1338         when the WebHTMLView is being torndown.
1339
1340         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1341         while mousing down on menu bar after Xcode News window is opened
1342
1343         Reviewed by Ada Chan.
1344
1345         * WebView/WebHTMLView.mm:
1346         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1347         return NO when it is nil. Adds a comment.
1348         * WebView/WebPDFView.mm:
1349         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1350
1351 2008-05-13  Mark Rowe  <mrowe@apple.com>
1352
1353         Reviewed by John Sullivan.
1354
1355         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1356
1357         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1358         * Carbon/HIWebView.m: Ditto.
1359         (HIWebViewCreate):
1360         (HIWebViewConstructor):
1361
1362 2008-05-12  Dan Bernstein  <mitz@apple.com>
1363
1364         Reviewed by Ada Chan.
1365
1366         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1367           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1368
1369         Added font cache statistics and a function to purge inactive font data.
1370
1371         * Misc/WebCoreStatistics.h:
1372         * Misc/WebCoreStatistics.mm:
1373         (+[WebCoreStatistics cachedFontDataCount]):
1374         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1375         (+[WebCoreStatistics purgeInactiveFontData]):
1376         (+[WebCoreStatistics glyphPageCount]):
1377
1378 2008-05-12  Mark Rowe  <mrowe@apple.com>
1379
1380         Reviewed by Tim Hatcher.
1381
1382         Decorate some deprecated delegate methods with the availability macros.
1383
1384         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1385         macros is good for consistency and documentation.
1386
1387         * WebView/WebFrameLoadDelegate.h:
1388         * WebView/WebUIDelegate.h:
1389
1390 2008-05-12  Mark Rowe  <mrowe@apple.com>
1391
1392         Reviewed by Tim Hatcher.
1393
1394         <rdar://problem/5835604> Deprecate HIWebView
1395
1396         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1397
1398         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1399         * Carbon/HIWebView.h: Ditto.
1400
1401 2008-05-12  Kevin Decker  <kdecker@apple.com>
1402
1403         Reviewed by Anders.
1404
1405         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1406         
1407         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
1408         in changeset <http://trac.webkit.org/changeset/31028>
1409         
1410         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
1411         * WebView/WebFrame.mm:
1412         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
1413         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
1414         * WebView/WebFrameInternal.h: Ditto.
1415         * WebView/WebHTMLView.mm: Ditto.
1416         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
1417         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1418         * WebView/WebHTMLViewInternal.h: Ditto.
1419         * WebView/WebHTMLViewPrivate.h: Ditto.
1420
1421 2008-05-12  Anders Carlsson  <andersca@apple.com>
1422
1423         Reviewed by Alexey.
1424
1425         Empty the application cache when changing the cache model.
1426         
1427         * WebView/WebView.mm:
1428         (+[WebView _setCacheModel:]):
1429
1430 2008-05-12  Anders Carlsson  <andersca@apple.com>
1431
1432         Reviewed by Oliver.
1433
1434         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
1435         
1436         * Plugins/WebBaseNetscapePluginView.h:
1437         * Plugins/WebBaseNetscapePluginView.mm:
1438         (-[WebBaseNetscapePluginView start]):
1439         Get the plug-in text input vtable pointer.
1440         
1441         (-[WebBaseNetscapePluginView stop]):
1442         Set the plug-in text input vtable pointer to 0.
1443         
1444         (-[WebBaseNetscapePluginView inputContext]):
1445         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
1446         
1447         (-[WebBaseNetscapePluginView hasMarkedText]):        
1448         (-[WebBaseNetscapePluginView insertText:]):
1449         (-[WebBaseNetscapePluginView markedRange]):
1450         (-[WebBaseNetscapePluginView selectedRange]):
1451         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
1452         (-[WebBaseNetscapePluginView unmarkText]):
1453         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
1454         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
1455         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
1456         (-[WebBaseNetscapePluginView doCommandBySelector:]):
1457         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
1458         (-[WebBaseNetscapePluginView conversationIdentifier]):
1459         Implement NSTextInput and call into the plug-in text input vtable.
1460         
1461         (browserTextInputFuncs):
1462         New method which returns the browser input vtable.
1463         
1464         (-[WebBaseNetscapePluginView getVariable:value:]):
1465         Support getting the browser input vtable pointer.
1466         
1467         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1468         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1469         (WebNetscapePluginEventHandlerCocoa::keyDown):
1470         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1471         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
1472         it means that the event should be passed on to the input manager.
1473          
1474         * Plugins/npapi.mm:
1475         (NPN_MarkedTextAbandoned):
1476         (NPN_MarkedTextSelectionChanged):
1477         Add implementations of browser input method methods.
1478         
1479         * Plugins/nptextinput.h: Added.
1480         Add file with new text input API.
1481
1482 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
1483
1484         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
1485         SquirrelFish merging.
1486
1487         * Misc/WebCoreStatistics.mm:
1488         (+[WebCoreStatistics javaScriptObjectsCount]):
1489         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1490         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1491         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1492         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1493         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1494         * WebView/WebScriptDebugDelegate.mm:
1495         (-[WebScriptCallFrame evaluateWebScript:]):
1496
1497 2008-05-07  Anders Carlsson  <andersca@apple.com>
1498
1499         Reviewed by Mitz.
1500
1501         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
1502         https://bugs.webkit.org/show_bug.cgi?id=18880
1503         <rdar://problem/5909513>
1504
1505         Stop suspending key up events before calling handleEvent.
1506         
1507         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1508         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1509
1510 2008-05-06  Stephanie Lewis  <slewis@apple.com>
1511
1512         Reviewed by Andersca.
1513
1514         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
1515
1516         * Plugins/WebPluginDatabase.m: Removed.
1517         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
1518         * Plugins/npapi.m: Removed.
1519         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
1520
1521 2008-05-06  Anders Carlsson  <andersca@apple.com>
1522
1523         Reviewed by Darin.
1524
1525         Initialize numArchs to 0.
1526         
1527         * Plugins/WebBasePluginPackage.m:
1528         (-[WebBasePluginPackage isNativeLibraryData:]):
1529
1530 2008-05-06  Anders Carlsson  <andersca@apple.com>
1531
1532         Reviewed by Darin.
1533
1534         Add implementation of NPN_PopUpContextMenu.
1535         
1536         * Plugins/WebBaseNetscapePluginView.mm:
1537         (-[WebBaseNetscapePluginView popUpContextMenu:]):
1538         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1539         * Plugins/WebNetscapePluginPackage.m:
1540         (-[WebNetscapePluginPackage load]):
1541         * Plugins/npapi.m:
1542         (NPN_PopUpContextMenu):
1543
1544 2008-05-06  Anders Carlsson  <andersca@apple.com>
1545
1546         Fix typo (don't read random memory).
1547         
1548         * Plugins/WebBasePluginPackage.m:
1549         (-[WebBasePluginPackage isNativeLibraryData:]):
1550
1551 2008-05-05  Anders Carlsson  <andersca@apple.com>
1552
1553         Reviewed by Darin.
1554
1555         Change the isNativeLibraryData: method to handle universal binaries.
1556         
1557         * Plugins/WebBasePluginPackage.m:
1558         (swapIntsInHeader):
1559         (-[WebBasePluginPackage isNativeLibraryData:]):
1560
1561 2008-05-06  Brady Eidson  <beidson@apple.com>
1562
1563         Reviewed by Darin Adler
1564
1565         Preparation for upcoming work making LocalStorage persistent.
1566
1567         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
1568
1569         * WebView/WebView.mm:
1570         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
1571
1572 2008-05-05  Sam Weinig  <sam@webkit.org>
1573
1574         Reviewed by Darin Adler.
1575
1576         Fix for <rdar://problem/5884383>
1577         Escape look-a-like characters from the the entire url.
1578
1579         * Misc/WebNSURLExtras.mm:
1580         (escapeUnsafeCharacters):
1581         (-[NSURL _web_userVisibleString]):
1582
1583 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
1584
1585         Reviewed by Darin.
1586         
1587         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
1588
1589         * WebView/WebView.mm:
1590         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
1591         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
1592         the two interfere.
1593
1594 2008-05-05  Sam Weinig  <sam@webkit.org>
1595
1596         Reviewed by Tim Hatcher.
1597
1598         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
1599
1600         * WebCoreSupport/WebInspectorClient.mm:
1601         (WebInspectorClient::localizedStringsURL):
1602
1603 2008-05-05  Anders Carlsson  <andersca@apple.com>
1604
1605         Reviewed by Jess.
1606
1607         Apparently preflighting can cause hangs for some reason. Revert this for now.
1608         
1609         * Plugins/WebNetscapePluginPackage.m:
1610         (-[WebNetscapePluginPackage _initWithPath:]):
1611         * Plugins/WebPluginPackage.m:
1612         (-[WebPluginPackage initWithPath:]):
1613
1614 2008-05-05  Darin Adler  <darin@apple.com>
1615
1616         Reviewed by Mitz.
1617
1618         - https://bugs.webkit.org/show_bug.cgi?id=18789
1619           fix some shouldCloseWithWindow edge cases
1620
1621         * WebView/WebView.mm:
1622         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
1623         NSWindowWillCloseNotification if the view was moved out of the window but still
1624         had that window set as the host window. Also make sure this function doesn't do
1625         anything if the WebView is already closed.
1626         (-[WebView setHostWindow:]): Ditto.
1627
1628 2008-05-04  David Kilzer  <ddkilzer@apple.com>
1629
1630         Make parameters match for WebChromeClient::addMessageToConsole()
1631
1632         Reviewed by John.
1633
1634         * WebCoreSupport/WebChromeClient.h:
1635         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
1636         to sourceURL to match implementation in WebChromeClient.mm.
1637
1638 2008-05-02  Anders Carlsson  <andersca@apple.com>
1639
1640         Reviewed by Mark.
1641
1642         Various Cocoa event model and 64-bit plug-in fixes.
1643         
1644         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1645         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1646         Set click count.
1647         
1648         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1649         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1650         Don't try to get the mouse location for keyboard events.
1651         
1652         * Plugins/WebPluginPackage.m:
1653         (-[WebPluginPackage initWithPath:]):
1654         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
1655
1656 2008-05-02  Anders Carlsson  <andersca@apple.com>
1657
1658         Reviewed by Sam.
1659
1660         The event union is now named.
1661         
1662         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1663         (WebNetscapePluginEventHandlerCocoa::drawRect):
1664         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1665         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1666         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1667         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1668         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1669
1670 2008-05-02  Anders Carlsson  <andersca@apple.com>
1671
1672         Reviewed by Mark.
1673
1674         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
1675         
1676         Call preflightAndReturnError on the bundle, which will check if any of the architectures
1677         in the bundle match the current architecture.
1678         
1679         * Plugins/WebNetscapePluginPackage.m:
1680         (-[WebNetscapePluginPackage _initWithPath:]):
1681
1682 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
1683
1684         Reviewed by Geoffrey Garen.
1685
1686         https://bugs.webkit.org/show_bug.cgi?id=18826
1687         Make JavaScript heap per-thread
1688
1689         * Misc/WebCoreStatistics.mm:
1690         (+[WebCoreStatistics javaScriptObjectsCount]):
1691         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1692         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1693         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1694         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1695         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1696         Replaced static Collector calls with calls to a current thread's instance.
1697
1698         * WebView/WebScriptDebugDelegate.mm:
1699         (-[WebScriptCallFrame evaluateWebScript:]):
1700         Pass ExecState to jsString().
1701
1702 2008-05-01  Anders Carlsson  <andersca@apple.com>
1703
1704         Reviewed by Mark.
1705
1706         64-bit NPAPI plugin build fixes.
1707         
1708         * Plugins/WebBaseNetscapePluginView.mm:
1709         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1710         (-[WebBaseNetscapePluginView updateAndSetWindow]):
1711         (-[WebBaseNetscapePluginView start]):
1712         (-[WebBaseNetscapePluginView windowBecameKey:]):
1713         * Plugins/WebNetscapeDeprecatedFunctions.c:
1714         * Plugins/WebNetscapeDeprecatedFunctions.h:
1715         * Plugins/WebNetscapePluginEventHandler.mm:
1716         (WebNetscapePluginEventHandler::create):
1717         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1718         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1719         * Plugins/WebPluginDatabase.m:
1720         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
1721
1722 2008-05-01  Anders Carlsson  <andersca@apple.com>
1723
1724         Reviewed by Tim.
1725
1726         Remove duplicate npfunctions.h header from WebKit.
1727
1728         * MigrateHeaders.make:
1729         Migrate npfunctions.h
1730         
1731         * Plugins/npfunctions.h: Removed.
1732
1733 2008-05-01  Anders Carlsson  <andersca@apple.com>
1734
1735         Reviewed by John.
1736         
1737         Add null checks for the event handler.
1738         
1739         * Plugins/WebBaseNetscapePluginView.mm:
1740         (-[WebBaseNetscapePluginView stopTimers]):
1741         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1742
1743 2008-05-01  Anders Carlsson  <andersca@apple.com>
1744
1745         Fix 64-bit build.
1746         
1747         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
1748         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1749         * WebCoreSupport/WebFrameLoaderClient.mm:
1750
1751 2008-05-01  Anders Carlsson  <andersca@apple.com>
1752
1753         Fix build.
1754         
1755         * Plugins/npfunctions.h:
1756
1757 2008-05-01  Anders Carlsson  <andersca@apple.com>
1758
1759         Reviewed by Adam.
1760
1761         Forward mouse move events to the Netscape plug-in view.
1762         
1763         * Plugins/WebBaseNetscapePluginView.h:
1764         * Plugins/WebBaseNetscapePluginView.mm:
1765         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1766         New method that just calls the current event handler.
1767         
1768         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1769         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1770         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
1771         don't work on it so don't call them.
1772         
1773         * WebCoreSupport/WebFrameLoaderClient.mm:
1774         (NetscapePluginWidget::NetscapePluginWidget):
1775         New Widget subclass to be used for Netscape plug-ins.
1776         
1777         (NetscapePluginWidget::handleEvent):
1778         Forward NSMouseMoved events to the plug-in.
1779         
1780         (WebFrameLoaderClient::createPlugin):
1781         Wrap the plug-in view in a NetscapePluginWidget.
1782
1783 2008-05-01  Alp Toker  <alp@nuanti.com>
1784
1785         Rubber-stamped by Anders.
1786
1787         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
1788         npapi.h.
1789
1790         Additional fix to use same signedness in npapi.h and Mac for the
1791         interval parameter.
1792
1793         * Plugins/WebBaseNetscapePluginView.h:
1794         * Plugins/WebBaseNetscapePluginView.mm:
1795         (PluginTimer::PluginTimer):
1796         (-[WebBaseNetscapePluginView stopTimers]):
1797         (-[WebBaseNetscapePluginView restartTimers]):
1798         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
1799         (-[WebBaseNetscapePluginView unscheduleTimer:]):
1800         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1801         * Plugins/npapi.m:
1802         (NPN_ScheduleTimer):
1803         (NPN_UnscheduleTimer):
1804         * Plugins/npfunctions.h:
1805
1806 2008-04-30  Anders Carlsson  <andersca@apple.com>
1807
1808         Reviewed by Adam.
1809
1810         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
1811         
1812         * Plugins/WebBaseNetscapePluginView.h:
1813         * Plugins/WebBaseNetscapePluginView.mm:
1814         (PluginTimer::PluginTimer):
1815         (PluginTimer::start):
1816         (PluginTimer::fired):
1817         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1818         (-[WebBaseNetscapePluginView stopTimers]):
1819         (-[WebBaseNetscapePluginView restartTimers]):
1820         (-[WebBaseNetscapePluginView scrollWheel:]):
1821         (-[WebBaseNetscapePluginView flagsChanged:]):
1822         (-[WebBaseNetscapePluginView start]):
1823         (-[WebBaseNetscapePluginView eventModel]):
1824         (-[WebBaseNetscapePluginView fini]):
1825         (-[WebBaseNetscapePluginView getVariable:value:]):
1826         (-[WebBaseNetscapePluginView setVariable:value:]):
1827         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
1828         (-[WebBaseNetscapePluginView unscheduleTimer:]):
1829         * Plugins/WebBaseNetscapePluginViewInternal.h:
1830         * Plugins/WebBaseNetscapePluginViewPrivate.h:
1831         * Plugins/WebNetscapePluginEventHandler.h:
1832         * Plugins/WebNetscapePluginEventHandler.mm:
1833         (WebNetscapePluginEventHandler::create):
1834         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1835         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1836         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
1837         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
1838         (WebNetscapePluginEventHandlerCarbon::platformWindow):
1839         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
1840         (WebNetscapePluginEventHandlerCocoa::startTimers):
1841         (WebNetscapePluginEventHandlerCocoa::stopTimers):
1842         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
1843         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
1844         (WebNetscapePluginEventHandlerCocoa::drawRect):
1845         (WebNetscapePluginEventHandlerCocoa::mouseDown):
1846         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
1847         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
1848         (WebNetscapePluginEventHandlerCocoa::mouseExited):
1849         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
1850         (WebNetscapePluginEventHandlerCocoa::mouseUp):
1851         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
1852         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1853         (WebNetscapePluginEventHandlerCocoa::keyDown):
1854         (WebNetscapePluginEventHandlerCocoa::keyUp):
1855         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1856         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1857         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1858         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1859         (WebNetscapePluginEventHandlerCocoa::platformWindow):
1860         (WebNetscapePluginEventHandlerCocoa::sendEvent):
1861         * Plugins/WebNetscapePluginPackage.m:
1862         (-[WebNetscapePluginPackage load]):
1863         * Plugins/npapi.m:
1864         (NPN_ScheduleTimer):
1865         (NPN_UnscheduleTimer):
1866         * Plugins/npfunctions.h:
1867
1868 2008-04-30  Brady Eidson  <beidson@apple.com>
1869
1870         Fix my WebPreferences revert check-in
1871
1872         * WebView/WebView.mm:
1873         (-[WebView _preferencesChangedNotification:]):
1874
1875 2008-04-30  Brady Eidson  <beidson@apple.com>
1876
1877         Rubberstamped by John Sullivan
1878
1879         Revert the remainder of my original preferences changes from last week.
1880         They caused a massive PLT regression (too many notifications being sent out
1881         or listened to that weren't previously) and it's not in my schedule to refine
1882         the preferences code instead of working on my feature!
1883
1884         * WebView/WebView.mm:
1885         (-[WebView _updateSettingsFromPreferences:]):
1886         (-[WebView _commonInitializationWithFrameName:groupName:]):
1887
1888 2008-04-30  Anders Carlsson  <andersca@apple.com>
1889
1890         Fix the 64-bit build.
1891         
1892         * Plugins/WebNetscapePluginEventHandler.h:
1893         * Plugins/WebNetscapePluginEventHandler.mm:
1894         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
1895         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1896
1897 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
1898
1899         BUILD FIX for Release build.
1900
1901         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1902         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
1903         separately so the compiler doesn't complain about an unused variable.
1904         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
1905
1906 2008-04-29  Anders Carlsson  <andersca@apple.com>
1907
1908         Reviewed by Adam.
1909
1910         Refactor the Carbon event handling code out into a separate class in preparation for adding
1911         the Cocoa event handling code.
1912         
1913         * Plugins/WebBaseNetscapePluginView.h:
1914         * Plugins/WebBaseNetscapePluginView.mm:
1915         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
1916         (-[WebBaseNetscapePluginView sendActivateEvent:]):
1917         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
1918         (-[WebBaseNetscapePluginView stopTimers]):
1919         (-[WebBaseNetscapePluginView restartTimers]):
1920         (-[WebBaseNetscapePluginView setHasFocus:]):
1921         (-[WebBaseNetscapePluginView mouseDown:]):
1922         (-[WebBaseNetscapePluginView mouseUp:]):
1923         (-[WebBaseNetscapePluginView mouseEntered:]):
1924         (-[WebBaseNetscapePluginView mouseExited:]):
1925         (-[WebBaseNetscapePluginView mouseDragged:]):
1926         (-[WebBaseNetscapePluginView keyUp:]):
1927         (-[WebBaseNetscapePluginView keyDown:]):
1928         (-[WebBaseNetscapePluginView cut:]):
1929         (-[WebBaseNetscapePluginView copy:]):
1930         (-[WebBaseNetscapePluginView paste:]):
1931         (-[WebBaseNetscapePluginView selectAll:]):
1932         (-[WebBaseNetscapePluginView start]):
1933         (-[WebBaseNetscapePluginView stop]):
1934         (-[WebBaseNetscapePluginView fini]):
1935         (-[WebBaseNetscapePluginView drawRect:]):
1936         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
1937         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
1938         (-[WebBaseNetscapePluginView windowBecameKey:]):
1939         (-[WebBaseNetscapePluginView windowResignedKey:]):
1940         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
1941         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
1942         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
1943         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
1944         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1945         (-[WebBaseNetscapePluginView _viewHasMoved]):
1946         * Plugins/WebBaseNetscapePluginViewInternal.h:
1947         * Plugins/WebNetscapePluginEmbeddedView.h:
1948         * Plugins/WebNetscapePluginEventHandler.h: Added.
1949         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
1950         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
1951         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
1952         * Plugins/WebNetscapePluginEventHandler.mm: Added.
1953         (WebNetscapePluginEventHandler::create):
1954         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
1955         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
1956         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
1957         (getCarbonEvent):
1958         (modifiersForEvent):
1959         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
1960         (WebNetscapePluginEventHandlerCarbon::drawRect):
1961         (WebNetscapePluginEventHandlerCarbon::mouseDown):
1962         (WebNetscapePluginEventHandlerCarbon::mouseUp):
1963         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
1964         (WebNetscapePluginEventHandlerCarbon::mouseExited):
1965         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
1966         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
1967         (WebNetscapePluginEventHandlerCarbon::keyDown):
1968         (keyMessageForEvent):
1969         (WebNetscapePluginEventHandlerCarbon::keyUp):
1970         (WebNetscapePluginEventHandlerCarbon::focusChanged):
1971         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
1972         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
1973         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
1974         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
1975         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
1976         (WebNetscapePluginEventHandlerCarbon::startTimers):
1977         (WebNetscapePluginEventHandlerCarbon::stopTimers):
1978         (WebNetscapePluginEventHandlerCarbon::sendEvent):
1979
1980 2008-04-29  Mark Rowe  <mrowe@apple.com>
1981
1982         Reviewed by David Harrison.
1983
1984         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
1985
1986         * WebKit.exp:
1987         * WebView/WebDynamicScrollBarsView.h:
1988         * WebView/WebDynamicScrollBarsView.m:
1989
1990 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
1991
1992         Reviewed by Darin.
1993
1994         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
1995
1996         * WebCoreSupport/WebChromeClient.h:
1997         * WebCoreSupport/WebChromeClient.mm:
1998         * WebView/WebClipView.m:
1999         (-[WebClipView scrollWheel:]):
2000         * WebView/WebHTMLView.mm:
2001         (-[WebHTMLView addMouseMovedObserver]):
2002         (-[WebHTMLView removeMouseMovedObserver]):
2003         (-[WebHTMLView acceptsFirstMouse:]):
2004         * WebView/WebUIDelegatePrivate.h:
2005         * WebView/WebView.mm:
2006         (-[WebViewPrivate init]):
2007         * WebView/WebViewPrivate.h:
2008
2009 2008-04-28  Rob Buis  <buis@kde.org>
2010
2011         Reviewed by Maciej.
2012
2013         Build fix for Tiger.
2014
2015         * WebView/WebView.mm:
2016         (WebKitInitializeApplicationCachePathIfNecessary):
2017
2018 2008-04-28  Adele Peterson  <adele@apple.com>
2019
2020         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
2021
2022         WebKit part of fix for <rdar://problem/3709505>
2023         Safari should have a way to upload bundles from the file upload control (as zip)
2024
2025         Added UIDelegate methods to let the application handle generating replacement files for uploads.
2026         In this case, Safari will create archived files for bundles so they can be uploaded properly.
2027
2028         * DefaultDelegates/WebDefaultUIDelegate.m:
2029         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
2030         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
2031         * WebCoreSupport/WebChromeClient.h:
2032         * WebCoreSupport/WebChromeClient.mm:
2033         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
2034         (WebChromeClient::generateReplacementFile):
2035         * WebView/WebUIDelegatePrivate.h:
2036
2037 2008-04-28  Anders Carlsson  <andersca@apple.com>
2038
2039         Reviewed by Sam, Mark, Adele and Darin.
2040
2041         Initialize the application cache path.
2042         
2043         * WebView/WebView.mm:
2044         (WebKitInitializeApplicationCachePathIfNecessary):
2045         (-[WebView _commonInitializationWithFrameName:groupName:]):
2046
2047 2008-04-28  Alice Liu  <alice.liu@apple.com>
2048
2049         Reviewed by Darin.
2050
2051         Fix <rdar://problem/4911289> Add tabindex property to all children 
2052         of HTMLElement (7138)
2053         http://bugs.webkit.org/show_bug.cgi?id=7138
2054
2055         * MigrateHeaders.make:
2056         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
2057         because now that focus() has been moved to DOMHTMLElement.h, these
2058         files are no longer needed.
2059
2060 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2061
2062         Reviewed by Darin.
2063
2064         Fix run-webkit-tests --threading
2065         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
2066         Proxy server issue in Sunday's Nightly
2067
2068         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
2069         only done from icon database code, which is not robust enough.
2070
2071 2008-04-20 Adam Barth <hk9565@gmail.com>
2072
2073         Reviewed by Adam Roben and Sam Weinig.
2074
2075         Updated WebSecurityOrigin to match new SecurityOrigin API.
2076
2077         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
2078
2079         * Storage/WebSecurityOrigin.mm:
2080         (-[WebSecurityOrigin host]):
2081         (-[WebSecurityOrigin domain]):
2082         * Storage/WebSecurityOriginPrivate.h:
2083
2084 2008-04-25  Mark Rowe  <mrowe@apple.com>
2085
2086         Rubber-stamped by Sam Weinig.
2087
2088         Add some content to an empty ICU header file to prevent verification errors.
2089
2090         * icu/unicode/utf_old.h:
2091
2092 2008-04-25  Anders Carlsson  <andersca@apple.com>
2093
2094         Reviewed by Sam.
2095
2096         Add offlineWebApplicationCacheEnabled preference.
2097         
2098         * WebView/WebPreferenceKeysPrivate.h:
2099         * WebView/WebPreferences.m:
2100         (+[WebPreferences initialize]):
2101         (-[WebPreferences offlineWebApplicationCacheEnabled]):
2102         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
2103         * WebView/WebPreferencesPrivate.h:
2104         * WebView/WebView.mm:
2105         (-[WebView _updateSettingsFromPreferences:]):
2106
2107 2008-04-24  Mark Rowe  <mrowe@apple.com>
2108
2109         Reviewed by Sam Weinig.
2110
2111         Remove code for calculating the glyph cache size.
2112
2113         * WebCoreSupport/WebSystemInterface.m:
2114         (InitWebCoreSystemInterface): Remove unused symbol.
2115
2116 2008-04-24  Mark Rowe  <mrowe@apple.com>
2117
2118         Reviewed by Sam Weinig.
2119
2120         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
2121
2122         * WebKitPrefix.h:
2123
2124 2008-04-24  Brady Eidson  <beidson@apple.com>
2125
2126         Reviewed by Darin
2127
2128         Fix layout test regressions from my earlier preferences/settings tweak.
2129
2130         * WebView/WebView.mm:
2131         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
2132           the notification to update the settings, each WebView still needs to register for the
2133           notification - restore that behavior.
2134
2135 2008-04-24  Dan Bernstein  <mitz@apple.com>
2136
2137         Reviewed by Darin Adler.
2138
2139         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
2140           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
2141
2142         * WebView/WebFrame.mm:
2143         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
2144         VisiblePosition::caretRect() instead of the RenderObject method which
2145         was removed.
2146
2147 2008-04-24  Brady Eidson  <beidson@apple.com>
2148
2149         Reviewed by Darin
2150
2151         Rework the Settings population again.
2152
2153         * WebView/WebView.mm:
2154         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
2155           and directly from WebView's common init function.
2156         (-[WebView _preferencesChangedNotification:]):
2157         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
2158           after creating the new Page
2159
2160 2008-04-24  Darin Adler  <darin@apple.com>
2161
2162         Reviewed by Geoff.
2163
2164         - fix crash in regression test where we'd ask a frame for a user agent string
2165           after the WebView was already closed
2166
2167         * WebCoreSupport/WebFrameLoaderClient.mm:
2168         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2169         added some code to prevent the crash in release builds if this problem happens
2170         again.
2171
2172 2008-04-24  Anders Carlsson  <andersca@apple.com>
2173
2174         Reviewed by Sam.
2175
2176         Change some String arguments to be const references instead.
2177
2178         * WebCoreSupport/WebEditorClient.h:
2179         * WebCoreSupport/WebEditorClient.mm:
2180         (WebEditorClient::shouldInsertText):
2181
2182 2008-04-24  John Sullivan  <sullivan@apple.com>
2183
2184         Mac build fix
2185         
2186         * WebCoreSupport/WebViewFactory.mm:
2187         (-[WebViewFactory AXButtonActionVerb]):
2188         implement this method using the text in WebCoreLocalizedStrings.cpp
2189         (-[WebViewFactory AXRadioButtonActionVerb]):
2190         ditto
2191         (-[WebViewFactory AXTextFieldActionVerb]):
2192         ditto
2193         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2194         ditto
2195         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2196         ditto
2197         (-[WebViewFactory AXLinkActionVerb]):
2198         ditto
2199
2200 2008-04-23  Brady Eidson  <beidson@apple.com>
2201
2202         Reviewed by Sam Weinig
2203
2204         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2205         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2206         thereby populating the Settings object, immediately after the Page is created.
2207
2208         * WebView/WebView.mm:
2209         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2210
2211 2008-04-24  John Sullivan  <sullivan@apple.com>
2212
2213         Reviewed by Jess
2214         
2215         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2216
2217         * Misc/WebNSControlExtras.m:
2218         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2219         deploy userSpaceScaleFactor when using view distances on the window
2220
2221 2008-04-22  Anders Carlsson  <andersca@apple.com>
2222
2223         Reviewed by Darin.
2224
2225         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2226         
2227         * Plugins/npfunctions.h:
2228
2229 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2230
2231         Mysteriously reviewed by mitz|away.
2232
2233         Bug 18111: Closing a tab while dragging crashes Safari
2234         https://bugs.webkit.org/show_bug.cgi?id=18111
2235
2236         Null check the page before handling drag events.
2237
2238         * WebView/WebView.mm:
2239         (-[WebView draggingUpdated:]):
2240         (-[WebView draggingExited:]):
2241
2242 2008-04-19  Brady Eidson  <beidson@apple.com>
2243
2244         Reviewed by Tim Hatcher
2245
2246         Add a WebPreference for the path of the local storage persistent store.
2247
2248         * WebView/WebPreferenceKeysPrivate.h:
2249
2250         * WebView/WebPreferences.m:
2251         (-[WebPreferences _localStorageDatabasePath]):
2252         (-[WebPreferences _setLocalStorageDatabasePath:]):
2253         * WebView/WebPreferencesPrivate.h:
2254
2255         * WebView/WebView.mm:
2256         (-[WebView _preferencesChangedNotification:]):
2257
2258 2008-04-18  Brady Eidson  <beidson@apple.com>
2259
2260         Reviewed by Sam Weinig
2261
2262         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2263         No reason to do the work twice...
2264
2265         * WebView/WebView.mm:
2266         (-[WebView _close]):
2267
2268 2008-04-17  Eric Seidel  <eric@webkit.org>
2269
2270         Reviewed by beth.
2271
2272         Rename Frame::renderer() to contentRenderer() and fix uses.
2273
2274         * Misc/WebCoreStatistics.mm:
2275         * WebView/WebRenderNode.mm:
2276         (-[WebRenderNode initWithWebFrameView:]):
2277
2278 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2279
2280         Reviewed by mrowe.
2281
2282         * WebView/WebFrame.mm: Remove temporary build fix.
2283
2284 2008-04-17  Mark Rowe  <mrowe@apple.com>
2285
2286         Reviewed by Dan Bernstein.
2287
2288         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2289
2290         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2291
2292         * WebCoreSupport/WebFrameLoaderClient.mm:
2293         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2294
2295 2008-04-17  Mark Rowe  <mrowe@apple.com>
2296
2297         Rubber-stamped by Dan Bernstein.
2298
2299         Fix the Mac build.
2300
2301         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2302         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2303         for this to live going forward.
2304
2305 2008-04-15  Kevin Decker  <kdecker@apple.com>
2306
2307         Reviewed by Anders.
2308
2309         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2310         
2311         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2312         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2313         a bundle out from underneath itself.
2314
2315         * Plugins/WebBasePluginPackage.h: Added unload method.
2316         * Plugins/WebBasePluginPackage.m:
2317         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2318         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2319         * Plugins/WebNetscapePluginPackage.m:
2320         (-[WebNetscapePluginPackage unload]): Added.
2321
2322 2008-04-15  Anders Carlsson  <andersca@apple.com>
2323
2324         Reviewed by Adam.
2325
2326         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2327
2328         * Configurations/WebKit.xcconfig:
2329
2330 2008-04-15  Brady Eidson  <beidson@apple.com>
2331
2332         Reviewed by John Sullivan
2333
2334         Do a more complete job adding the "WebArchiveDebugMode" pref
2335
2336         * WebView/WebPreferences.m: Add both getter *and* setter
2337         (-[WebPreferences webArchiveDebugModeEnabled]):
2338         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2339         * WebView/WebPreferencesPrivate.h:
2340
2341         * WebView/WebView.mm:
2342         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2343
2344 2008-04-14  Brady Eidson  <beidson@apple.com>
2345
2346         Reviewed by Anders
2347
2348         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2349         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2350         network and will instead fail the load as "cancelled."
2351
2352         * WebView/WebPreferenceKeysPrivate.h:
2353
2354         * WebView/WebPreferences.m:
2355         (+[WebPreferences initialize]):
2356         (-[WebPreferences _webArchiveDebugModeEnabled]):
2357         * WebView/WebPreferencesPrivate.h:
2358
2359         * WebView/WebView.mm:
2360         (-[WebView _preferencesChangedNotification:]):
2361
2362 2008-04-11  David Hyatt  <hyatt@apple.com>
2363
2364         Rename CachedResource ref/deref methods to addClient/removeClient.
2365
2366         Reviewed by olliej
2367
2368         * WebView/WebHTMLView.mm:
2369         (-[WebHTMLViewPrivate dealloc]):
2370         (-[WebHTMLViewPrivate finalize]):
2371         (-[WebHTMLViewPrivate clear]):
2372         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2373
2374 2008-04-07  Brady Eidson  <beidson@apple.com>
2375
2376         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2377
2378         * Configurations/WebKit.xcconfig:
2379
2380 2008-04-04  Adam Roben  <aroben@apple.com>
2381
2382         Use WebCore's ICU headers instead of our own copy
2383
2384         Rubberstamped by Tim Hatcher.
2385
2386         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2387         PrivateHeaders.
2388
2389 2008-04-04  Adam Roben  <aroben@apple.com>
2390
2391         Fix <rdar://problem/5804776> Would like to use WebCore's
2392         ForwardingHeaders in WebKit without manually creating copies
2393
2394         Patch by Tim Hatcher, typed by me.
2395
2396         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2397         WebCore's PrivateHeaders instead of our own copy.
2398
2399 2008-04-04  Ada Chan  <adachan@apple.com>
2400
2401         Now we pass width and height directly as integers to format
2402         the window title for a standalone image.
2403
2404         Reviewed by Dan.
2405
2406         * WebCoreSupport/WebViewFactory.mm:
2407         (-[WebViewFactory imageTitleForFilename:width:height:]):
2408
2409 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
2410
2411         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
2412
2413         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
2414           font-weight does not properly support graded weights
2415
2416         * WebView/WebHTMLView.mm:
2417         (-[WebHTMLView _styleFromFontAttributes:]):
2418         (-[WebHTMLView _originalFontB]):
2419         (-[WebHTMLView _addToStyle:fontA:fontB:]):
2420
2421 2008-04-02  Mark Rowe  <mrowe@apple.com>
2422
2423         Reviewed by Oliver Hunt.
2424
2425         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
2426
2427         * Configurations/Base.xcconfig:
2428
2429 2008-03-31  Alice Liu  <alice.liu@apple.com>
2430
2431         Reviewed by Darin.
2432
2433         * WebView/WebFrame.mm:
2434         (-[WebFrame _accessibilityTree]):
2435         The syntax for fetching an object from the AXObjectCache changed slightly
2436
2437 2008-03-31  Brady Eidson  <beidson@apple.com>
2438
2439         Reviewed by Jon Honeycutt
2440         
2441         Move a WebArchive loading check into WebCore
2442
2443         * WebView/WebHTMLRepresentation.mm:
2444         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
2445           responsible for checking that state
2446
2447 2008-03-31  Brady Eidson  <beidson@apple.com>
2448
2449         Reviewed by Darin and Mitz's rubber stamp
2450
2451         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
2452
2453         * WebCoreSupport/WebEditorClient.mm:
2454         * WebCoreSupport/WebEditorClient.h:
2455
2456 2008-03-28  Brady Eidson  <beidson@apple.com>
2457
2458         Rubberstamped by Darin Adler
2459
2460         Remove WebArchiver.h/mm
2461
2462         * WebView/WebArchiver.h: Removed.
2463         * WebView/WebArchiver.mm: Removed.
2464
2465         * DOM/WebDOMOperations.mm:
2466         * WebCoreSupport/WebDragClient.mm:
2467         * WebCoreSupport/WebEditorClient.mm:
2468         * WebView/WebDataSource.mm:
2469         * WebView/WebHTMLView.mm:
2470
2471 2008-03-28  Brady Eidson  <beidson@apple.com>
2472
2473         Reviewed by Darin Adler
2474
2475         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
2476
2477         * WebCoreSupport/WebEditorClient.mm:
2478         (WebEditorClient::dataForArchivedSelection):
2479
2480         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
2481         * WebView/WebArchiver.mm: Ditto
2482
2483         * WebView/WebHTMLView.mm:
2484         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2485
2486 2008-03-28  Brady Eidson  <beidson@apple.com>
2487
2488         Reviewed by Darin Adler
2489
2490         More Kit->Core WebArchive changes.
2491
2492         Create an archive from the current selection in a frame
2493
2494         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
2495           easily in a followup
2496
2497 2008-03-28  Brady Eidson  <beidson@apple.com>
2498
2499         Reviewed by Sam Weinig
2500
2501         WebArchive saga continues - Can now make archives from ranges in WebCore
2502
2503         * DOM/WebDOMOperations.mm:
2504         (-[DOMRange webArchive]):
2505         (-[DOMRange markupString]):
2506
2507         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
2508         * WebView/WebArchiver.mm:
2509
2510 2008-03-28  Brady Eidson  <beidson@apple.com>
2511
2512         Reviewed by Sam Weinig
2513
2514         More Kit->Core webarchive code movement
2515
2516         * DOM/WebDOMOperations.mm:
2517         (-[DOMNode markupString]): Call createFullMarkup() instead
2518
2519         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
2520         * WebView/WebFrameInternal.h: Ditto
2521
2522 2008-03-28  Brady Eidson  <beidson@apple.com>
2523
2524         Reviewed by Sam Weinig
2525
2526         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
2527
2528         * WebView/WebArchiver.h:
2529         * WebView/WebArchiver.mm:
2530         * WebView/WebDataSource.mm:
2531         (-[WebDataSource webArchive]):
2532
2533 2008-03-28  Brady Eidson  <beidson@apple.com>
2534
2535         Reviewed by Sam Weinig
2536
2537         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
2538
2539         * WebView/WebArchiver.h:
2540         * WebView/WebArchiver.mm:
2541
2542 2008-03-28  Brady Eidson  <beidson@apple.com>
2543
2544         Reviewed by Darin
2545
2546         "Yet another transitional step" to empty out WebKit-based code for archiving.
2547
2548         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
2549         entirely within WebCore, and opens the door to saving WebArchives on Windows.
2550
2551         * DOM/WebDOMOperations.mm:
2552         * WebView/WebArchiver.mm:
2553         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
2554
2555 2008-03-27  Brady Eidson  <beidson@apple.com>
2556
2557         Reviewed by Adam Roben
2558
2559         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
2560         as the push to core-ify WebArchives continues.
2561
2562         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
2563         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
2564         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
2565         (as in "while archiving a page") are accepting of null or empty data.
2566
2567         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
2568
2569         * WebView/WebDataSource.mm:
2570         (-[WebDataSource mainResource]): Call DocumentLoader implementation
2571         (-[WebDataSource subresources]): Ditto
2572         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
2573         * WebView/WebFrameInternal.h:
2574
2575 2008-03-27  Brady Eidson  <beidson@apple.com>
2576
2577         Reviewed by Adam
2578
2579         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
2580         (more efficient)
2581
2582         * WebView/WebResource.mm:
2583         (-[WebResource _initWithCoreResource:]):
2584         * WebView/WebResourceInternal.h:
2585
2586 2008-03-26  Brady Eidson  <beidson@apple.com>
2587
2588         Build fix - accidentally checked in this change which was work in progress
2589
2590         * DOM/WebDOMOperations.mm:
2591
2592 2008-03-26  Brady Eidson  <beidson@apple.com>
2593
2594         Reviewed by Darin
2595
2596         When we create a WebArchive, we walk every node from some starting point, asking each node
2597         along the way "What are your subresource URLs?"
2598
2599         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
2600         WebCore::Node
2601
2602         * DOM/WebDOMOperations.mm:
2603         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
2604           calling into individual WebCore::Node implementations
2605         * DOM/WebDOMOperationsPrivate.h:
2606
2607 2008-03-26  Brady Eidson  <beidson@apple.com>
2608
2609         Reviewed by Mark Rowe
2610
2611         Part of the continued push to move WebArchive-related code down to WebCore, this
2612         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
2613
2614         * WebView/WebDataSource.mm:
2615         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
2616
2617         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
2618           has now been ported down to WebCore
2619         * WebView/WebFrameInternal.h:
2620
2621 2008-03-26  Mark Rowe  <mrowe@apple.com>
2622
2623         Rubber-stamped by Brady Eidson.
2624
2625         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
2626
2627         * Configurations/WebKit.xcconfig:
2628
2629 2008-03-26  Mark Rowe  <mrowe@apple.com>
2630
2631         Reviewed by David Hyatt.
2632
2633         Make the Ahem font antialias correctly on Acid3 on Tiger.
2634
2635         * WebCoreSupport/WebSystemInterface.m:
2636         (InitWebCoreSystemInterface):
2637
2638 2008-03-26  Mark Rowe  <mrowe@apple.com>
2639
2640         Fix the Mac build.
2641
2642         * MigrateHeaders.make: Copy the newly generated header into the right place.
2643
2644 2008-03-25  Brady Eidson  <beidson@apple.com>
2645
2646         Reviewed by Beth Dakin
2647
2648         Remove entirely unused internal method
2649
2650         * WebView/WebArchiver.h:
2651         * WebView/WebArchiver.mm:
2652
2653 2008-03-25  Brady Eidson  <beidson@apple.com>
2654
2655         Reviewed by Adam Roben
2656
2657         <rdar://problem/5819308> - View Source is empty when view webarchives
2658
2659         * WebCore.base.exp:
2660         * loader/DocumentLoader.cpp:
2661         (WebCore::DocumentLoader::setParsedArchiveData):
2662         (WebCore::DocumentLoader::parsedArchiveData):
2663         * loader/DocumentLoader.h:
2664
2665         * loader/FrameLoader.cpp:
2666         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
2667           in the DocumentLoader
2668
2669 2008-03-25  Dan Bernstein  <mitz@apple.com>
2670
2671         Reviewed by Darin Adler.
2672
2673         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
2674           Reopen All Windows From Last Session causes crash
2675
2676         * WebView/WebHTMLView.mm:
2677         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
2678         check.
2679
2680 2008-03-25  Brady Eidson  <beidson@apple.com>
2681
2682         Reviewed by Jon Honeycutt's rubberstamp
2683
2684         Fix a leak with the new WebArchive setup
2685
2686         * WebView/WebArchive.mm:
2687         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2688
2689 2008-03-25  Brady Eidson  <beidson@apple.com>
2690
2691         Reviewed by Darin
2692
2693         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
2694         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
2695
2696         * WebCoreSupport/WebFrameLoaderClient.h:
2697         * WebCoreSupport/WebFrameLoaderClient.mm:
2698         (WebFrameLoaderClient::WebFrameLoaderClient):
2699
2700 2008-03-25  Brady Eidson  <beidson@apple.com>
2701
2702         Reviewed by Darin
2703
2704         Remove newly obsolete FrameLoaderClient methods
2705
2706         * WebCoreSupport/WebFrameLoaderClient.h:
2707         * WebCoreSupport/WebFrameLoaderClient.mm:
2708
2709 2008-03-25  Brady Eidson  <beidson@apple.com>
2710
2711         Release build fix
2712
2713         * WebView/WebArchive.mm:
2714         (-[WebArchive subresources]):
2715         (-[WebArchive subframeArchives]):
2716
2717 2008-03-25  Brady Eidson  <beidson@apple.com>
2718
2719         Reviewed by Darin
2720
2721         <rdar://problem/4516169> - Support WebArchives on Windows
2722         And paves the way for many future WebArchive bug fixes and enhancements
2723
2724         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
2725         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
2726          * WebArchive <-> LegacyWebArchive
2727          * WebResource <-> ArchiveResource
2728          * WebUnarchivingState <-> ArchiveResourceCollection
2729  
2730         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
2731         and now exist in WebCore
2732
2733         * WebCoreSupport/WebFrameLoaderClient.mm:
2734         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
2735         (WebFrameLoaderClient::finalSetupForReplace):
2736         (WebFrameLoaderClient::setDefersLoading):
2737         (WebFrameLoaderClient::willUseArchive):
2738         (WebFrameLoaderClient::isArchiveLoadPending):
2739         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2740         (WebFrameLoaderClient::clearArchivedResources):
2741         (WebFrameLoaderClient::createFrame):
2742
2743         * WebView/WebArchive.mm:
2744         (+[WebArchivePrivate initialize]):
2745         (-[WebArchivePrivate init]):
2746         (-[WebArchivePrivate initWithCoreArchive:]):
2747         (-[WebArchivePrivate coreArchive]):
2748         (-[WebArchivePrivate setCoreArchive:]):
2749         (-[WebArchivePrivate dealloc]):
2750         (-[WebArchivePrivate finalize]):
2751         (-[WebArchive init]):
2752         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
2753         (-[WebArchive initWithData:]):
2754         (-[WebArchive initWithCoder:]):
2755         (-[WebArchive encodeWithCoder:]):
2756         (-[WebArchive mainResource]):
2757         (-[WebArchive subresources]):
2758         (-[WebArchive subframeArchives]):
2759         (-[WebArchive data]):
2760         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
2761         (-[WebArchive WebCore::]):
2762         * WebView/WebArchiveInternal.h: Added.
2763
2764         * WebView/WebDataSource.mm:
2765         (-[WebDataSourcePrivate dealloc]):
2766         (-[WebDataSource _addSubframeArchives:]):
2767         (-[WebDataSource _documentFragmentWithArchive:]):
2768         (-[WebDataSource subresourceForURL:]):
2769         (-[WebDataSource addSubresource:]):
2770         * WebView/WebDataSourceInternal.h:
2771
2772         * WebView/WebFrame.mm:
2773         (-[WebFrame loadArchive:]):
2774         * WebView/WebFrameInternal.h:
2775
2776         * WebView/WebHTMLRepresentation.mm:
2777         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2778
2779         * WebView/WebResource.mm:
2780         (+[WebResourcePrivate initialize]):
2781         (-[WebResourcePrivate init]):
2782         (-[WebResourcePrivate initWithCoreResource:]):
2783         (-[WebResourcePrivate dealloc]):
2784         (-[WebResourcePrivate finalize]):
2785         (-[WebResource initWithCoder:]):
2786         (-[WebResource encodeWithCoder:]):
2787         (-[WebResource data]):
2788         (-[WebResource URL]):
2789         (-[WebResource MIMEType]):
2790         (-[WebResource textEncodingName]):
2791         (-[WebResource frameName]):
2792         (-[WebResource _initWithCoreResource:WebCore::]):
2793         (-[WebResource WebCore::]):
2794         (-[WebResource _ignoreWhenUnarchiving]):
2795         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
2796         (-[WebResource _fileWrapperRepresentation]):
2797         (-[WebResource _response]):
2798         (-[WebResource _stringValue]):
2799         * WebView/WebResourceInternal.h: Added.
2800         * WebView/WebResourcePrivate.h:
2801
2802         * WebView/WebUnarchivingState.h: Removed.
2803         * WebView/WebUnarchivingState.m: Removed.
2804
2805 2008-03-24  Oliver Hunt  <oliver@apple.com>
2806
2807         Reviewed by Mark Rowe.
2808
2809         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
2810         <http://bugs.webkit.org/show_bug.cgi?id=18030>
2811
2812         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
2813         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
2814         <http://bugs.webkit.org/show_bug.cgi?id=18057>
2815
2816         * WebView/WebHTMLView.mm:
2817         (-[WebHTMLView keyDown:]):
2818
2819 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2820
2821         Reviewed by Maciej, landed by Brady
2822
2823         Bug 3580: iFrames Appear to be Cached
2824         <http://bugs.webkit.org/show_bug.cgi?id=3580>
2825
2826         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
2827         <http://bugs.webkit.org/show_bug.cgi?id=15486>
2828
2829         Bug 15554: Reload causes <object> to use old data
2830         <http://bugs.webkit.org/show_bug.cgi?id=15554>
2831
2832         If a page is reloaded, a child frame's URL can not be taken from a history item.
2833
2834         * WebView/WebFrame.mm:
2835         (-[WebFrame _loadURL:referrer:intoChild:]):
2836
2837 2008-03-24  Darin Adler  <darin@apple.com>
2838
2839         Reviewed by Beth.
2840
2841         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
2842
2843         * History/WebHistoryItem.mm:
2844         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
2845         * WebView/WebDataSource.mm:
2846         (-[WebDataSource _URL]): Ditto.
2847         (-[WebDataSource unreachableURL]): Ditto.
2848         * WebView/WebHTMLView.mm:
2849         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2850
2851         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2852         * History/WebHistory.mm:
2853         * Misc/WebElementDictionary.mm:
2854         * Misc/WebNSAttributedStringExtras.mm:
2855         Remove unneeded imports of KURL.h.
2856
2857 2008-03-24  Brady Eidson  <beidson@apple.com>
2858
2859         Reviewed by Darin's rubberstamp
2860
2861         Rename this file for upcoming work.
2862
2863         * WebView/WebArchive.m: Removed.
2864         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
2865
2866 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
2867
2868         Build fix.
2869
2870         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
2871
2872 2008-03-23  Oliver Hunt  <oliver@apple.com>
2873
2874         Reviewed by Maciej.
2875
2876         Bug 17670: Key events may improperly propagate from iframe to parent frame
2877         <http://bugs.webkit.org/show_bug.cgi?id=17670>
2878         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
2879         <http://bugs.webkit.org/show_bug.cgi?id=16381>
2880
2881         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
2882         as that results in us dispatching the key events for each frame going up the frame
2883         tree.
2884
2885         * WebView/WebHTMLView.mm:
2886         (-[WebHTMLView keyDown:]):
2887         (-[WebHTMLView keyUp:]):
2888         (-[WebHTMLView flagsChanged:]):
2889
2890 2008-03-21  Timothy Hatcher  <timothy@apple.com>
2891
2892         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
2893         http://bugs.webkit.org/show_bug.cgi?id=17980
2894
2895         Reviewed by Adam.
2896
2897         The new highlight drawing was not honoring the fade value, so it was
2898         always drawing at full opacity. The animation code didn't match Windows
2899         and the new highlight anyway, so it has been removed. The highlight
2900         how just detaches when it is hidden.
2901
2902         * WebCoreSupport/WebInspectorClient.mm:
2903         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
2904         (-[WebInspectorWindowController close]): Ditto.
2905         (-[WebInspectorWindowController highlightNode:]): Call attach.
2906         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
2907         * WebInspector/WebNodeHighlight.h:
2908         * WebInspector/WebNodeHighlight.m:
2909         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2910         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
2911         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
2912         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
2913         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
2914         * WebInspector/WebNodeHighlightView.h:
2915         * WebInspector/WebNodeHighlightView.m:
2916         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
2917
2918 2008-03-20  Mark Rowe  <mrowe@apple.com>
2919
2920         Reviewed by Sam Weinig.
2921
2922         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
2923         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
2924         command-line.
2925
2926         * Configurations/WebKit.xcconfig:
2927
2928 2008-03-20  Adam Roben  <aroben@apple.com>
2929
2930         Make WebNodeHighlightView use InspectorController to do its painting
2931
2932         Reviewed by Tim Hatcher.
2933
2934         * WebCoreSupport/WebInspectorClient.mm:
2935         (-[WebInspectorWindowController highlightNode:]): Pass the
2936         InspectorController to the WebNodeHighlight, and don't call
2937         setHighlightedNode: (which has been removed).
2938         (-[WebInspectorWindowController hideHighlight]): Removed call to
2939         setHighlightedNode:.
2940         * WebInspector/WebNodeHighlight.h:
2941           - Replaced _highlightNode with _inspectorController
2942           - Removed _highlightedNode accessors
2943           - Added -inspectorController method
2944         * WebInspector/WebNodeHighlight.m:
2945         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
2946         takes an InspectorController* and stores it in _inspectorController.
2947         (-[WebNodeHighlight dealloc]): Removed code dealing with
2948         _highlightedNode.
2949         (-[WebNodeHighlight inspectorController]): Added.
2950         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
2951         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
2952         GraphicsContexts to be based on a flipped CGContext, so we have to
2953         specify that this view is flipped.
2954         (-[WebNodeHighlightView drawRect:]): Changed to create a
2955         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
2956
2957 2008-03-18  David Hyatt  <hyatt@apple.com>
2958
2959         Add support for a preference in WebKit that can be used in nightly builds to test full page
2960         zoom.
2961
2962         Reviewed by Antti
2963
2964         * WebView/WebPreferenceKeysPrivate.h:
2965         * WebView/WebView.mm:
2966         (-[WebView setTextSizeMultiplier:]):
2967         (-[WebView canMakeTextSmaller]):
2968         (-[WebView makeTextSmaller:]):
2969         (-[WebView canMakeTextLarger]):
2970         (-[WebView makeTextLarger:]):
2971         (-[WebView canMakeTextStandardSize]):
2972         (-[WebView makeTextStandardSize:]):
2973
2974 2008-03-17  Eric Seidel  <eric@webkit.org>
2975
2976         Reviewed by darin.
2977
2978         Export _NPN_IntFromIdentifier as part of our NPAPI interface
2979
2980         * Plugins/WebNetscapePluginPackage.m:
2981         (-[WebNetscapePluginPackage load]):
2982
2983 2008-03-14  Brady Eidson  <beidson@apple.com>
2984
2985         Reviewed by Brian Dash's rubberstamp
2986
2987         Remove a class declaration for a class that has never existed
2988
2989         * WebView/WebResource.h:
2990
2991 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
2992
2993         Unify concept of enabling the Mac Java bridge.
2994
2995         Reviewed by Darin and Anders.
2996
2997         * Plugins/WebPluginJava.h: Removed unused file.
2998         * WebCoreSupport/WebFrameLoaderClient.h:
2999         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
3000         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
3001         (WebFrameLoaderClient::javaApplet): Ditto.
3002
3003 2008-03-13  Antti Koivisto  <antti@apple.com>
3004
3005         Reviewed by Darin.
3006
3007         * ForwardingHeaders/wtf/Deque.h: Added.
3008
3009 2008-03-13  Anders Carlsson  <andersca@apple.com>
3010
3011         Reviewed by Adam.
3012
3013         Call originalRequest, not initialRequest.
3014         
3015         * WebView/WebDataSource.mm:
3016         (-[WebDataSource initialRequest]):
3017
3018 2008-03-12  Darin Adler  <darin@apple.com>
3019
3020         Reviewed by John Sullivan.
3021
3022         - cleanup after removing the bridge
3023
3024         * DOM/WebDOMOperations.mm:
3025         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
3026
3027         * Misc/WebCoreStatistics.mm:
3028         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
3029
3030         * Plugins/WebBaseNetscapePluginView.mm:
3031         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
3032         _frameLoader method.
3033         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3034         Ditto.
3035         * Plugins/WebPluginController.mm:
3036         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
3037
3038         * WebCoreSupport/WebFrameLoaderClient.mm:
3039         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
3040         method. Without this we could leave a stale frame pointer around.
3041         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
3042         caller of the _isMainFrame method.
3043         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
3044         _frameLoader method.
3045         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
3046
3047         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
3048         turned out to be unused.
3049         (core): Added overload for DocumentFragment.
3050         (kit): Ditto.
3051         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
3052         to FrameLoader with _private->coreFrame->loader().
3053         (-[WebFrame _attachScriptDebugger]): Ditto.
3054         (-[WebFrame _clearCoreFrame]): Added.
3055         (-[WebFrame _updateBackground]): More of the same.
3056         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
3057         (-[WebFrame _unmarkAllMisspellings]): Ditto.
3058         (-[WebFrame _hasSelection]): Ditto.
3059         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
3060         (-[WebFrame _findFrameWithSelection]): Ditto.
3061         (-[WebFrame _dataSource]): Ditto.
3062         (-[WebFrame _addData:]): Streamlined code a bit.
3063         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3064         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3065         (-[WebFrame _isDescendantOfFrame:]): Ditto.
3066         (-[WebFrame _bodyBackgroundColor]): Ditto.
3067         (-[WebFrame _isFrameSet]): Ditto.
3068         (-[WebFrame _firstLayoutDone]): Ditto.
3069         (-[WebFrame _loadType]): Ditto.
3070         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
3071         (-[WebFrame name]): Ditto.
3072         (-[WebFrame DOMDocument]): Ditto.
3073         (-[WebFrame frameElement]): Ditto.
3074         (-[WebFrame provisionalDataSource]): Ditto.
3075         (-[WebFrame dataSource]): Ditto.
3076         (-[WebFrame loadRequest:]): Ditto.
3077         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
3078         (-[WebFrame loadArchive:]): Ditto.
3079         (-[WebFrame stopLoading]): Ditto.
3080         (-[WebFrame reload]): Ditto.
3081         (-[WebFrame findFrameNamed:]): Ditto.
3082         (-[WebFrame parentFrame]): Ditto.
3083         (-[WebFrame childFrames]): Ditto.
3084         (-[WebFrame windowObject]): Ditto.
3085         (-[WebFrame globalContext]): Ditto.
3086
3087         * WebView/WebFrameInternal.h: Added overloads of core and kit.
3088         Removed method declarations.
3089
3090         * WebView/WebHTMLRepresentation.mm:
3091         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
3092         (formElementFromDOMElement): Ditto.
3093         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3094         (inputElementFromDOMElement): Ditto.
3095         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3096         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3097         (-[WebHTMLRepresentation formForElement:]): Ditto.
3098         (-[WebHTMLRepresentation currentForm]): Ditto.
3099         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3100         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3101         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3102
3103         * WebView/WebHTMLView.mm:
3104         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
3105         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3106         Call createFragmentFromText directly instead of via WebFrame.
3107         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3108         Moved layout calls here from WebFrame.
3109         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3110         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
3111         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
3112         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
3113         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
3114         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3115         Moved code here from WebFrame.
3116         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
3117         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3118         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3119         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3120         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3121         (-[WebHTMLView rectsForTextMatches]): Ditto.
3122
3123         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
3124
3125         * WebView/WebPDFView.mm:
3126         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
3127         _frameLoader method.
3128
3129         * WebView/WebRenderNode.mm:
3130         (copyRenderNode): Moved code here from WebFrame.
3131         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3132
3133         * WebView/WebResource.mm:
3134         (-[WebResource _stringValue]): Moved code here from WebFrame.
3135
3136         * WebView/WebView.mm:
3137         (-[WebView _close]): Use core function intsead of _frameLoader method.
3138         (-[WebView setCustomTextEncodingName:]): Ditto.
3139         (-[WebView setHostWindow:]): Moved code here from WebFrame.
3140         (aeDescFromJSValue): Moved this here from WebFrame.
3141         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
3142
3143 2008-03-12  Darin Adler  <darin@apple.com>
3144
3145         Reviewed by Anders.
3146
3147         - http://bugs.webkit.org/show_bug.cgi?id=17640
3148           eliminate WebCoreFrameBridge
3149
3150         Moved all the code from the bridge into WebFrame. This need not be the final
3151         home of these methods -- they can be moved closer to their callers and improved
3152         further -- but it eliminates the bridge without requiring a rewrite of the code.
3153         It's a fairly mechanical process (just adding underscores to method names really).
3154
3155         There's even a chance that some of the methods are unused. Those we can remove
3156         after checking if that's so.
3157
3158         * DOM/WebDOMOperations.mm:
3159         (-[DOMNode markupString]): Use WebFrame rather than bridge.
3160         (-[DOMDocument webFrame]): Changed to use the core and kit functions
3161         instead of using the bridge.
3162         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
3163         (-[DOMRange markupString]): Ditto.
3164         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3165
3166         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3167         * History/WebHistoryItem.mm: Ditto.
3168
3169         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3170         * Misc/WebCoreStatistics.mm:
3171         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3172
3173         * Misc/WebElementDictionary.mm: Removed unneeded import.
3174
3175         * Misc/WebKitStatistics.m:
3176         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3177         * Misc/WebKitStatisticsPrivate.h: Ditto.
3178
3179         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3180         * Misc/WebNSPasteboardExtras.mm: Ditto.
3181
3182         * Plugins/WebBaseNetscapePluginView.mm:
3183         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3184         rather than bridge.
3185
3186         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3187         * Plugins/WebNetscapePluginStream.mm: Ditto.
3188
3189         * Plugins/WebPluginContainerCheck.mm:
3190         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3191         bridge to get to the WebCore::Frame.
3192
3193         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3194         * Plugins/WebPluginController.mm:
3195         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3196         rather than bridge.
3197
3198         * WebCoreSupport/WebEditorClient.mm:
3199         (selectorForKeyEvent): Tweaked comment.
3200
3201         * WebCoreSupport/WebFrameBridge.h: Removed.
3202         * WebCoreSupport/WebFrameBridge.mm: Removed.
3203
3204         * WebCoreSupport/WebFrameLoaderClient.mm:
3205         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3206         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3207         I could remove this function entirely, but it looks like the Qt port is using it.
3208
3209         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3210
3211         * WebView/WebArchiver.mm:
3212         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3213         (+[WebArchiver archiveNode:]): Ditto.
3214         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3215
3216         * WebView/WebDataSource.mm:
3217         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3218         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3219         (-[WebDataSource subresources]): Ditto.
3220         (-[WebDataSource subresourceForURL:]): Ditto.
3221
3222         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3223
3224         * WebView/WebFrame.mm:
3225         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3226         (core): Go directly to the core frame, not via the bridge.
3227         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3228         Remove the code to deal with the bridge.
3229         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3230         shouldCreateRenderers flag, formerly on the bridge.
3231         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3232         (aeDescFromJSValue): Moved here from bridge.
3233         (-[WebFrame _domain]): Ditto.
3234         (-[WebFrame _addData:]): Ditto.
3235         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3236         (-[WebFrame _nodesFromList:]): Ditto.
3237         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3238         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3239         (-[WebFrame _selectedString]): Ditto.
3240         (-[WebFrame _stringForRange:]): Ditto.
3241         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3242         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3243         (-[WebFrame _sendScrollEvent]): Ditto.
3244         (-[WebFrame _drawRect:]): Ditto.
3245         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3246         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3247         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3248         (-[WebFrame _copyRenderTree:]): Ditto.
3249         (inputElementFromDOMElement): Ditto.
3250         (formElementFromDOMElement): Ditto.
3251         (-[WebFrame _elementWithName:inForm:]): Ditto.
3252         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3253         (-[WebFrame _elementIsPassword:]): Ditto.
3254         (-[WebFrame _formForElement:]): Ditto.
3255         (-[WebFrame _currentForm]): Ditto.
3256         (-[WebFrame _controlsInForm:]): Ditto.
3257         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3258         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3259         (-[WebFrame _URLWithAttributeString:]): Ditto.
3260         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3261         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3262         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3263         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3264         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3265         (-[WebFrame _rectsForTextMatches]): Ditto.
3266         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3267         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3268         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3269         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3270         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3271         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3272         (-[WebFrame _baseURL]): Ditto.
3273         (-[WebFrame _stringWithData:]): Ditto.
3274         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3275         (-[WebFrame _needsLayout]): Ditto.
3276         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3277         (-[WebFrame _accessibilityTree]): Ditto.
3278         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3279         (-[WebFrame _setDrawsBackground:]): Ditto.
3280         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3281         Ditto.
3282         (-[WebFrame _selectionGranularity]): Ditto.
3283         (-[WebFrame _convertToNSRange:]): Ditto.
3284         (-[WebFrame _convertToDOMRange:]): Ditto.
3285         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3286         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3287         (-[WebFrame _markDOMRange]): Ditto.
3288         (-[WebFrame _markedTextNSRange]): Ditto.
3289         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3290         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3291         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3292         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3293         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3294         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3295         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3296         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3297         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3298         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3299         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3300         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3301         (-[WebFrame _typingStyle]): Ditto.
3302         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3303         (-[WebFrame _fontForSelection:]): Ditto.
3304         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3305         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3306         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3307         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3308         (-[WebFrame _canProvideDocumentSource]): Ditto.
3309         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3310         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3311         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3312         function. Couldn't just keep the bridge method because this was already here with the same name.
3313         (-[WebFrame _selectedNSRange]): Ditto.
3314         (-[WebFrame _selectNSRange:]): Ditto.
3315         (-[WebFrame dealloc]): Remove bridge-related code.
3316         (-[WebFrame finalize]): Ditto.
3317
3318         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3319         Removed the bridge parameter from the init method. Removed the #if blocks that
3320         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3321         Removed the _bridge method.
3322
3323         * WebView/WebFrameView.mm: Removed the _bridge method.
3324
3325         * WebView/WebHTMLRepresentation.mm:
3326         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3327         field.
3328         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3329         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3330         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3331         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3332         (-[WebHTMLRepresentation documentSource]): Ditto.
3333         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3334         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3335         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3336         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3337         (-[WebHTMLRepresentation formForElement:]): Ditto.
3338         (-[WebHTMLRepresentation currentForm]): Ditto.
3339         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3340         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3341         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3342
3343         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3344
3345         * WebView/WebHTMLView.mm:
3346         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3347         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3348         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3349         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3350         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3351         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3352         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3353         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3354         (-[WebHTMLView drawSingleRect:]): Ditto.
3355         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3356         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3357         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3358         (-[WebHTMLView knowsPageRange:]): Ditto.
3359         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3360         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3361         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3362         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3363         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3364         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3365         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3366         (-[WebHTMLView startSpeaking:]): Ditto.
3367         (-[WebHTMLView _updateFontPanel]): Ditto.
3368         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3369         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3370         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3371         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3372         (-[WebHTMLView selectedRange]): Ditto.
3373         (-[WebHTMLView markedRange]): Ditto.
3374         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3375         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3376         (-[WebHTMLView insertText:]): Ditto.
3377         (-[WebTextCompleteController _insertMatch:]): Ditto.
3378         (-[WebTextCompleteController doCompletion]): Ditto.
3379         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3380         (-[WebHTMLView string]): Ditto.
3381         (-[WebHTMLView selectedString]): Ditto.
3382         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3383         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3384         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3385         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3386         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3387         (-[WebHTMLView rectsForTextMatches]): Ditto.
3388         * WebView/WebRenderNode.mm:
3389         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3390         * WebView/WebResource.mm:
3391         (-[WebResource _stringValue]): Ditto.
3392
3393         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3394
3395         * WebView/WebView.mm:
3396         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3397         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3398         (-[WebView _setInViewSourceMode:]): Ditto.
3399         (-[WebView _inViewSourceMode]): Ditto.
3400         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3401         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3402         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3403         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3404         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
3405         (-[WebView setEditable:]): Ditto.
3406         (-[WebView setTypingStyle:]): Ditto.
3407         (-[WebView typingStyle]): Ditto.
3408         (-[WebView replaceSelectionWithNode:]): Ditto.
3409         (-[WebView replaceSelectionWithText:]): Ditto.
3410         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
3411         (-[WebView replaceSelectionWithArchive:]): Ditto.
3412         (-[WebView _insertNewlineInQuotedContent]): Ditto.
3413         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
3414
3415 2008-03-12  David Hyatt  <hyatt@apple.com>
3416
3417         Make the zoom factor a float and not a percent.
3418
3419         Reviewed by antti
3420
3421         * WebView/WebView.mm:
3422         (-[WebView _setZoomMultiplier:isTextOnly:]):
3423
3424 2008-03-11  David Hyatt  <hyatt@apple.com>
3425
3426         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
3427         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
3428         can zoom the page in, out or reset it to the standard size.
3429
3430         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
3431         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
3432         win.
3433
3434         Reviewed by Tim H.
3435
3436         * WebCoreSupport/WebFrameBridge.mm:
3437         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
3438         * WebView/WebDocumentInternal.h:
3439         * WebView/WebHTMLView.mm:
3440         (-[WebHTMLView viewDidMoveToSuperview]):
3441         * WebView/WebPDFView.h:
3442         * WebView/WebPDFView.mm:
3443         (-[WebPDFView _zoomOut:]):
3444         (-[WebPDFView _zoomIn:]):
3445         (-[WebPDFView _resetZoom:]):
3446         (-[WebPDFView _canZoomOut]):
3447         (-[WebPDFView _canZoomIn]):
3448         (-[WebPDFView _canResetZoom]):
3449         * WebView/WebView.mm:
3450         (-[WebViewPrivate init]):
3451         (-[WebView setTextSizeMultiplier:]):
3452         (-[WebView textSizeMultiplier]):
3453         (-[WebView _setZoomMultiplier:isTextOnly:]):
3454         (-[WebView _zoomMultiplier:]):
3455         (-[WebView _realZoomMultiplier]):
3456         (-[WebView _realZoomMultiplierIsTextOnly]):
3457         (-[WebView _canZoomOut:]):
3458         (-[WebView _canZoomIn:]):
3459         (-[WebView _zoomOut:isTextOnly:]):
3460         (-[WebView _zoomIn:isTextOnly:]):
3461         (-[WebView _canResetZoom:]):
3462         (-[WebView _resetZoom:isTextOnly:]):
3463         (-[WebView canMakeTextSmaller]):
3464         (-[WebView makeTextSmaller:]):
3465         (-[WebView canMakeTextLarger]):
3466         (-[WebView makeTextLarger:]):
3467         (-[WebView canMakeTextStandardSize]):
3468         (-[WebView makeTextStandardSize:]):
3469         (-[WebView setPageSizeMultiplier:]):
3470         (-[WebView pageSizeMultiplier]):
3471         (-[WebView canZoomPageIn]):
3472         (-[WebView zoomPageIn:]):
3473         (-[WebView canZoomPageOut]):
3474         (-[WebView zoomPageOut:]):
3475         (-[WebView canResetPageZoom]):
3476         (-[WebView resetPageZoom:]):
3477         (-[WebView _searchWithSpotlightFromMenu:]):
3478         * WebView/WebViewInternal.h:
3479         * WebView/WebViewPrivate.h:
3480
3481 2008-03-12  Dan Bernstein  <mitz@apple.com>
3482
3483         Reviewed by Darin Adler and Sam Weinig.
3484
3485         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
3486
3487         * WebCoreSupport/WebSystemInterface.m:
3488         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
3489         WKGetNSFontATSUFontId Tiger-only.
3490
3491 2008-03-12  Darin Adler  <darin@apple.com>
3492
3493         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
3494           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
3495
3496         * WebView/WebFrame.mm:
3497         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
3498         up pointer from the bridge to the frame. (My next check-in removes the bridge
3499         entirely, but we need this until then.)
3500
3501 2008-03-11  Darin Adler  <darin@apple.com>
3502
3503         Reviewed by Sam.
3504
3505         - remove all bridge-related things from WebCore except the bridge itself
3506
3507         * DOM/WebDOMOperations.mm:
3508         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
3509
3510         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
3511
3512         * Plugins/WebPluginController.mm: Ditto.
3513
3514         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
3515         init and close methods. Added a setWebFrame: method.
3516
3517         * WebCoreSupport/WebFrameBridge.mm:
3518         (-[WebFrameBridge setWebFrame:]): Added.
3519
3520         * WebCoreSupport/WebFrameLoaderClient.mm:
3521         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
3522         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
3523         bridge here. Soon we will be able to remove this entirely!
3524         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
3525         into WebFrame from the bridge.
3526
3527         * WebView/WebFrame.mm:
3528         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
3529         now owned by the frame.
3530         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
3531         debugger under GC without this!
3532         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
3533         use WebFrameLoaderClient instead of the bridge.
3534         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
3535         This is code that used to live in the bridge's init function.
3536         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
3537         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
3538         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
3539         the WebView is now the bridge's owner.
3540         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
3541         WebCore::Frame::bridge function directly to use the kit function instead.
3542         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
3543         This code won't last long -- we're eliminating the bridge soon.
3544         (-[WebFrame finalize]): Ditto.
3545
3546         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
3547         for creating frames.
3548
3549         * WebView/WebView.mm:
3550         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
3551         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
3552         where we have to allocate a WebFrameBridge and then immediately release it.
3553
3554 2008-03-11  Darin Adler  <darin@apple.com>
3555
3556         Reviewed by Anders.
3557
3558         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
3559
3560         * WebCoreSupport/WebFrameLoaderClient.mm:
3561         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
3562         to setView. A couple lines later, there is a call to _install, which sets the
3563         view to the scroll view.
3564
3565         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
3566
3567         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
3568         this file, since it's used by Safari.
3569         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
3570         * WebView/WebDynamicScrollBarsView.m:
3571         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
3572         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
3573         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
3574         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
3575         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
3576         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
3577         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
3578         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
3579         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
3580         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
3581         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
3582         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
3583         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
3584         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
3585         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
3586
3587         * WebView/WebFrameView.mm:
3588         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
3589
3590         * WebView/WebView.mm:
3591         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
3592         (-[WebView alwaysShowVerticalScroller]): Ditto.
3593         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
3594         (-[WebView alwaysShowHorizontalScroller]): Ditto.
3595
3596 2008-03-11  Darin Adler  <darin@apple.com>
3597
3598         Reviewed by Sam.
3599
3600         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
3601
3602         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
3603         bridge methods.
3604         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
3605         to recently-created functions.
3606         (WebChromeClient::firstResponder): Moved code here from the bridge.
3607         (WebChromeClient::makeFirstResponder): Ditto.
3608         (WebChromeClient::runOpenPanel): Ditto.
3609         (WebChromeClient::willPopUpMenu): Ditto.
3610
3611         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
3612         is related to creating the bridge and connecting it to WebCore, which will
3613         go next when I eliminate use of the bridge to get to/from the Frame*.
3614         * WebCoreSupport/WebFrameBridge.mm:
3615         (-[WebFrameBridge close]): Moved the code to track the bridge count here
3616         instead of the dealloc and finalize methods.
3617
3618 2008-03-11  Darin Adler  <darin@apple.com>
3619
3620         Reviewed by Mitz.
3621
3622         - update code affected by Range changes
3623
3624         * Misc/WebNSAttributedStringExtras.mm:
3625         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
3626         * WebView/WebHTMLRepresentation.mm:
3627         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
3628         Use Range::create.
3629         * WebView/WebHTMLView.mm:
3630         (-[WebHTMLView attributedString]): Ditto.
3631
3632 2008-03-10  Darin Adler  <darin@apple.com>
3633
3634         Reviewed by Sam.
3635
3636         - eliminate keyboard UI mode method from WebCoreFrameBridge
3637
3638         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
3639         * WebCoreSupport/WebChromeClient.mm:
3640         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
3641         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
3642         fields for keyboard UI mode.
3643         * WebCoreSupport/WebFrameBridge.mm:
3644         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
3645         method.
3646         (-[WebFrameBridge finalize]): Ditto.
3647         * WebView/WebView.mm: Moved the keyboard mode code in here.
3648         (-[WebView _close]): Remove observer from the distributed notification
3649         center as well as the normal one.
3650         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
3651         here from the bridge.
3652         (-[WebView _keyboardUIMode]): Ditto.
3653         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
3654
3655 2008-03-10  Darin Adler  <darin@apple.com>
3656
3657         Reviewed by Sam.
3658
3659         - eliminate Java applet methods from WebCoreFrameBridge
3660
3661         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
3662         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
3663         the ones that load Java applets.
3664         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
3665         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3666
3667 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
3668
3669         Reviewed by Darin.
3670
3671         Done with Lars.
3672
3673         Simplified WebViewFactory's refreshPlugins method to only refresh the
3674         plugins and not reload the frames anymore since that's now done in a
3675         platform independent manner by WebCore::Page.
3676
3677         Also removed the now unused pluginNameForMIMEType and
3678         pluginSupportsMIMEType methods.
3679
3680         * WebCoreSupport/WebViewFactory.mm:
3681         * WebView/WebFrame.mm:
3682         * WebView/WebFrameInternal.h:
3683         * WebView/WebView.mm:
3684
3685 2008-03-08  Mark Rowe  <mrowe@apple.com>
3686
3687         Reviewed by Darin Adler.
3688
3689         Fix 64-bit build with GCC 4.2.
3690
3691         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
3692         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
3693         * History/WebHistoryItem.mm: Ditto.
3694         * Misc/WebElementDictionary.mm: Ditto.
3695         * WebCoreSupport/WebFrameLoaderClient.mm:
3696         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
3697         variable being unused in 64-bit.
3698         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
3699         * WebView/WebHTMLView.mm:
3700         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
3701         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
3702
3703 2008-03-08  Darin Adler  <darin@apple.com>
3704
3705         Reviewed by Adele.
3706
3707         - eliminate custom highlight methods from WebCoreFrameBridge
3708
3709         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
3710         * WebCoreSupport/WebChromeClient.mm:
3711         (WebChromeClient::customHighlightRect): Moved code here from bridge.
3712         (WebChromeClient::paintCustomHighlight): Ditto.
3713         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
3714
3715 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
3716
3717         Unify concept of enabling Netscape Plug-in API (NPAPI).
3718
3719         Reviewed by Darin.
3720
3721         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
3722
3723         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
3724         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
3725
3726         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
3727         #if ENABLE(NETSCAPE_PLUGIN_API).
3728         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
3729         * Plugins/WebBaseNetscapePluginView.h: Ditto.
3730         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
3731         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
3732         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
3733         * Plugins/WebBasePluginPackage.h: Ditto.
3734         * Plugins/WebBasePluginPackage.m: Ditto.
3735         (+[WebBasePluginPackage pluginWithPath:]):
3736         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
3737         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3738         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
3739         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
3740         * Plugins/WebNetscapePluginPackage.h: Ditto.
3741         * Plugins/WebNetscapePluginPackage.m: Ditto.
3742         * Plugins/WebNetscapePluginStream.h: Ditto.
3743         * Plugins/WebNetscapePluginStream.mm: Ditto.
3744         * Plugins/WebPluginDatabase.m: Ditto.
3745         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
3746         * Plugins/npapi.m: Ditto.
3747         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
3748         (WebFrameLoaderClient::objectContentType):
3749         (WebFrameLoaderClient::createPlugin):
3750         * WebView/WebHTMLView.mm: Ditto.
3751         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
3752         * WebView/WebHTMLViewInternal.h: Ditto.
3753
3754         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
3755         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
3756         category to (WebInternal) category so we don't expose the ENABLE() macro
3757         from the private header.
3758         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
3759         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
3760         * WebView/WebFrameInternal.h: Ditto.
3761         * WebView/WebFramePrivate.h: Ditto.
3762
3763 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
3764
3765         Reviewed by Darin.
3766
3767         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
3768         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
3769
3770         * WebView/WebPreferences.m:
3771         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
3772         the one used in Safari.
3773
3774 2008-03-07  Mark Rowe  <mrowe@apple.com>
3775
3776         Reviewed by Oliver Hunt.
3777
3778         Fix WebKit build with GCC 4.2.
3779
3780         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
3781
3782 2008-03-07  Darin Adler  <darin@apple.com>
3783
3784         Reviewed by Adam.
3785
3786         - eliminated WebCoreFrameBridge runOpenPanel
3787
3788         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
3789         * WebCoreSupport/WebChromeClient.mm:
3790         (WebChromeClient::runOpenPanel): Added.
3791         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
3792         FileChooser so it can get a result from the UI delegate.
3793         (-[WebOpenPanelResultListener dealloc]): Added.
3794         (-[WebOpenPanelResultListener finalize]): Added.
3795         (-[WebOpenPanelResultListener cancel]): Added.
3796         (-[WebOpenPanelResultListener chooseFilename:]): Added.
3797
3798 2008-03-06  Darin Adler  <darin@apple.com>
3799
3800         Reviewed by Mitz.
3801
3802         - fix regression test failures from the visited-link change
3803
3804         * History/WebHistory.mm:
3805         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
3806         to turn off visited links if there is no history object. Also call
3807         removeAllVisitedLinks so we can start over from scratch with the new history.
3808
3809 2008-03-06  Dan Bernstein  <mitz@apple.com>
3810
3811         Reviewed by Darin Adler.
3812
3813         - fix a regression from r30741: a crash under
3814           WebFrameLoaderClient::createPlugin() when showing a Mail message with
3815           an attachment
3816
3817         * WebCoreSupport/WebFrameLoaderClient.mm:
3818         (WebFrameLoaderClient::createPlugin):
3819
3820 2008-03-06  Darin Adler  <darin@apple.com>
3821
3822         - fix Tiger build
3823
3824         * History/WebHistory.mm: Added include of WebTypesInternal.h.
3825
3826 2008-03-06  Darin Adler  <darin@apple.com>
3827
3828         - fix Release build
3829
3830         * History/WebHistory.mm:
3831         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
3832         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
3833         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
3834
3835 2008-03-06  Darin Adler  <darin@apple.com>
3836
3837         Reviewed by Mitz.
3838
3839         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
3840           REGRESSION: iframes are added to Safari's History menu
3841           by separating the visited link machinery from global history
3842
3843         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
3844         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
3845         method name, since it's on a private object.
3846         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
3847         PageGroup::removeAllVisitedLinks function if the last URL was removed.
3848         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
3849         method name, since it's on a private object.
3850         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
3851         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
3852         method name, since it's on a private object.
3853         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3854         Ditto.
3855         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
3856         to correctly return the error by using the newer version of writeToURL: and
3857         removed the FIXME about that.
3858         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
3859         for every link in the history.
3860         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
3861         (-[WebHistory addItem:]): Moved into the WebPrivate category.
3862         (-[WebHistory addItemForURL:]): Ditto.
3863         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
3864         create an item and already know its title.
3865         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
3866         (-[WebHistory containsItemForURLString:]): Ditto.
3867         (-[WebHistory removeItem:]): Ditto.
3868         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
3869         (-[WebHistory _itemForURLString:]): Ditto.
3870         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
3871
3872         * History/WebHistoryInternal.h: Added.
3873         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
3874         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
3875         Also reorganized what was left behind.
3876
3877         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
3878         * WebCoreSupport/WebChromeClient.mm:
3879         (WebChromeClient::populateVisitedLinks): Added a call to the new
3880         -[WebHistory _addVisitedLinksToPageGroup:] method.
3881
3882         * WebCoreSupport/WebFrameLoaderClient.mm:
3883         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
3884         -[WebHistory _addItemForURL:title:] method.
3885
3886 2008-03-05  Adam Roben  <aroben@apple.com>
3887
3888         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
3889
3890         Reviewed by Kevin M.
3891
3892         * WebView/WebFrame.mm:
3893         * WebView/WebScriptDebugDelegate.mm:
3894         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
3895         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
3896
3897 2008-03-05  Adam Roben  <aroben@apple.com>
3898
3899         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
3900
3901         Reviewed by Kevin M.
3902
3903         * WebView/WebCoreScriptDebuggerImp.h:
3904         * WebView/WebCoreScriptDebuggerImp.mm:
3905         * WebView/WebFrame.mm:
3906         (-[WebFrame _attachScriptDebugger]):
3907         * WebView/WebFrameInternal.h:
3908
3909 2008-03-05  Adam Roben  <aroben@apple.com>
3910
3911         Remove WebScriptDebugger
3912
3913         Uses of WebScriptDebugger have been replaced with
3914         WebCoreScriptDebuggerImp.
3915
3916         Reviewed by Kevin M.
3917
3918         * WebView/WebFrame.mm:
3919         (-[WebFramePrivate dealloc]): Use delete instead of release since
3920         WebCoreScriptDebuggerImp is a C++ class.
3921         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
3922         WebCoreScriptDebuggerImp.
3923         (-[WebFrame _detachScriptDebugger]): Ditto.
3924         * WebView/WebFrameInternal.h:
3925         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
3926         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
3927         * WebView/WebView.mm:
3928
3929 2008-03-05  Adam Roben  <aroben@apple.com>
3930
3931         Remove -webFrame and -globalObject from WebScriptDebugger
3932
3933         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
3934
3935         Reviewed by Kevin M.
3936
3937         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
3938         parameter to the constructor.
3939         * WebView/WebCoreScriptDebuggerImp.mm:
3940         (toWebFrame): Added.
3941         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
3942         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
3943         WindowScriptObject ourselves instead of asking WebScriptDebugger for
3944         it.
3945         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
3946         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
3947         (WebCoreScriptDebuggerImp::exception): Ditto.
3948         * WebView/WebScriptDebugDelegate.mm:
3949         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
3950         WebScriptDebuggerImp's constructor.
3951         * WebView/WebScriptDebugDelegatePrivate.h: Removed
3952         -webFrame/-globalObject.
3953
3954 2008-03-05  Adam Roben  <aroben@apple.com>
3955
3956         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
3957
3958         Reviewed by Kevin M.
3959
3960         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
3961         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
3962         lifetime.
3963         * WebView/WebCoreScriptDebuggerImp.mm:
3964           - Added declaration of -[WebScriptCallFrame
3965             _initWithGlobalObject:caller:state:].
3966           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
3967         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
3968         now-unnecessary initialization of m_topCallFrame.
3969         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
3970         with its implementation. The one difference between this
3971         implementation and the old enterFrame: method is that we don't hand
3972         our reference to m_topCallFrame to _initWithGlobalObject: -- that
3973         method must now retain the passed-in WebScriptCallFrame manually.
3974         (WebCoreScriptDebuggerImp::atStatement):
3975         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
3976         with its implementation.
3977         (WebCoreScriptDebuggerImp::exception):
3978         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
3979         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
3980         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
3981         to retain the passed-in caller.
3982         * WebView/WebScriptDebugDelegatePrivate.h:
3983           - Removed _current ivar
3984           - Removed enterFrame:/leaveFrame declarations.
3985
3986 2008-03-05  Adam Roben  <aroben@apple.com>
3987
3988         Remove -parsedSource: from WebScriptDebugger
3989
3990         Reviewed by Kevin M.
3991
3992         * WebView/WebCoreScriptDebuggerImp.mm:
3993         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
3994         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
3995         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
3996         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
3997
3998 2008-03-05  Adam Roben  <aroben@apple.com>
3999
4000         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
4001
4002         Reviewed by Kevin M.
4003
4004         * WebView/WebCoreScriptDebuggerImp.mm:
4005         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
4006         trhough to callEvent instead of duplicating its code here.
4007         (WebCoreScriptDebuggerImp::callEvent): Moved code from
4008         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
4009         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
4010         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
4011         (WebCoreScriptDebuggerImp::exception): Moved code from
4012         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
4013         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
4014         -leavingFrame:, and -exceptionRaised:.
4015         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
4016
4017 2008-03-05  Adam Roben  <aroben@apple.com>
4018
4019         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
4020
4021         Reviewed by Kevin M.
4022
4023         * WebView/WebCoreScriptDebuggerImp.mm:
4024         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
4025         -[WebScriptDebugger hitStatement:sourceId:line:].
4026         * WebView/WebScriptDebugDelegate.mm:
4027         (-[WebScriptDebugger webFrame]): Added.
4028         * WebView/WebScriptDebugDelegatePrivate.h:
4029
4030 2008-03-05  Adam Roben  <aroben@apple.com>
4031
4032         Remove WebCoreScriptDebugger
4033
4034         Reviewed by Kevin M.
4035
4036         * WebView/WebCoreScriptDebugger.h: Removed.
4037         * WebView/WebCoreScriptDebugger.mm: Removed.
4038         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
4039         with WebScriptDebugger.
4040         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
4041         delegate] with just m_debugger.
4042         (toNSString): Moved here from WebCoreScriptDebugger.mm.
4043         (toNSURL): Ditto.
4044         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
4045         (WebCoreScriptDebuggerImp::sourceParsed):
4046         (WebCoreScriptDebuggerImp::callEvent):
4047         (WebCoreScriptDebuggerImp::atStatement):
4048         (WebCoreScriptDebuggerImp::returnEvent):
4049         (WebCoreScriptDebuggerImp::exception):
4050         * WebView/WebScriptDebugDelegate.mm:
4051         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
4052         WebCoreScriptDebuggerImp, so initialize it properly.
4053         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
4054         WebCoreScriptDebuggerImp.
4055
4056 2008-03-05  Adam Roben  <aroben@apple.com>
4057
4058         Move WebCoreScriptDebuggerImp to its own source files
4059
4060         Also changed WebCoreScriptDebuggerImp coding style to match our style
4061         guidelines.
4062
4063         Reviewed by Kevin M.
4064
4065         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
4066         function.
4067         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
4068         implementation.
4069         (toNSURL): Made no longer static.
4070         * WebView/WebCoreScriptDebuggerImp.h: Added.
4071         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
4072         WebCoreScriptDebugger.mm and cleaned up.
4073         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
4074         (WebCoreScriptDebuggerImp::sourceParsed):
4075         (WebCoreScriptDebuggerImp::callEvent):
4076         (WebCoreScriptDebuggerImp::atStatement):
4077         (WebCoreScriptDebuggerImp::returnEvent):
4078         (WebCoreScriptDebuggerImp::exception):
4079
4080 2008-03-05  Adam Roben  <aroben@apple.com>
4081
4082         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
4083
4084         Reviewed by Kevin M.
4085
4086         * WebView/WebCoreScriptDebugger.h:
4087           - Removed newFrameWithGlobalObject:caller:state: from
4088             WebScriptDebugger protocol
4089           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
4090           - Removed _current ivar from WebCoreScriptDebugger
4091         * WebView/WebCoreScriptDebugger.mm:
4092         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
4093         the delegate.
4094         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
4095         * WebView/WebScriptDebugDelegate.mm:
4096         (-[WebScriptDebugger dealloc]): Added code to release _current.
4097         (-[WebScriptDebugger enterFrame:]): Added. Code came from
4098         WebCoreScriptDebugger.
4099         (-[WebScriptDebugger leaveFrame]): Ditto.
4100         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
4101
4102 2008-03-05  Adam Roben  <aroben@apple.com>
4103
4104         Remove WebCoreScriptCallFrame
4105
4106         Reviewed by Tim.
4107
4108         * WebView/WebCoreScriptDebugger.h:
4109           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
4110           - Replaced -newWrapperForFrame: with
4111             -newFrameWithGlobalObject:caller:state:
4112           - Removed WebCoreScriptCallFrame interface.
4113         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
4114         with WebScriptCallFrame.
4115         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
4116         -newFrameWithGlobalObject:caller:state.
4117         (-[WebCoreScriptDebugger _leaveFrame]):
4118         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
4119         _private ivar to be of type WebScriptCallFramePrivate*.
4120         * WebView/WebScriptDebugDelegate.mm:
4121           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
4122           - Added WebScriptCallFramePrivate
4123         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
4124         (-[WebScriptDebugger hitStatement:sourceId:line:]):
4125         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
4126         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
4127         (-[WebScriptCallFramePrivate dealloc]): Added.
4128         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
4129         Code came from WebCoreScriptCallFrame.
4130         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
4131         ivar.
4132         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
4133         _private with direct access of _private's ivars.
4134         (-[WebScriptCallFrame caller]): Ditto.
4135         (-[WebScriptCallFrame scopeChain]): Ditto.
4136         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
4137
4138 2008-03-05  Adam Roben  <aroben@apple.com>
4139
4140         Move -_convertValueToObjcValue to WebScriptCallFrame
4141
4142         Reviewed by Darin.
4143
4144         * WebView/WebCoreScriptDebugger.h: Removed declaration of
4145         -_convertValueToObjcValue.
4146         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
4147         * WebView/WebScriptDebugDelegate.mm:
4148         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
4149         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
4150         (-[WebScriptCallFrame scopeChain]): Changed to call
4151         -_convertValueToObjcValue on self instead of _private.
4152         (-[WebScriptCallFrame exception]): Ditto.
4153         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
4154
4155 2008-03-05  Adam Roben  <aroben@apple.com>
4156
4157         Move -exception and -evaluateWebScript: to WebScriptCallFrame
4158
4159         Reviewed by Darin.
4160
4161         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
4162         and -evaluateWebScript:.
4163         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
4164         -evaluateWebScript:.
4165         * WebView/WebScriptDebugDelegate.mm:
4166         (-[WebScriptCallFrame exception]): Added. Code came from
4167         -[WebCoreScriptCallFrame exception].
4168         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
4169         -[WebCoreScriptCallFrame evaluateWebScript:].
4170
4171 2008-03-05  Adam Roben  <aroben@apple.com>
4172
4173         Move -scopeChain to WebScriptCallFrame
4174