Fixes the Web Inspector flashing white while resizing after
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-08-19  Timothy Hatcher  <timothy@apple.com>
2
3         Fixes the Web Inspector flashing white while resizing after
4         highlighting a page element. Calling disableScreenUpdatesUntilFlush
5         when attaching and detaching the Inspector page highlight is bad,
6         since the browser window might not flush again for a while. So screen
7         updates could be disabled for long periods of time, causing backing store
8         flashing while resizing. There is no need to call disableScreenUpdatesUntilFlush
9         when attaching or detaching the child window.
10
11         Reviewed by John Sullivan and Kevin McCullough.
12
13         * WebInspector/WebNodeHighlight.m:
14         (-[WebNodeHighlight attach]): Remove the call to disableScreenUpdatesUntilFlush.
15         (-[WebNodeHighlight detach]): Ditto.
16
17 2008-08-19  Timothy Hatcher  <timothy@apple.com>
18
19         Correctly remembers the attached state of the Web Inspector so
20         it opens in that state for the next window, or next launch.
21
22         Reviewed by Kevin McCullough.
23
24         * WebCoreSupport/WebInspectorClient.mm:
25         (-[WebInspectorWindowController attach]): Set WebKitInspectorAttachedKey
26         to YES in the user defaults.
27         (-[WebInspectorWindowController detach]): Set WebKitInspectorAttachedKey
28         to NO in the user defaults.
29
30 2008-08-18  Alexey Proskuryakov  <ap@webkit.org>
31
32         Reviewed by Dan Bernstein.
33
34         https://bugs.webkit.org/show_bug.cgi?id=19347
35         <rdar://problem/5977562> Input methods do not work after switching to a password field
36         and back.
37
38         Fix <rdar://problem/5522011> (The content of the password field of Safari is displayed by
39         reconversion) in a different way which doesn't conflict with context caching performed
40         by AppKit.
41
42         This original bug does not really occur in ToT or shipping Safari under Mac OS X 10.5.4,
43         because input methods are disabled in password fields. Attempting to reconvert text typed
44         with Romaji only yields a string of bullets. Still, it is probably better to match Cocoa
45         password field behavior and disable reconversion completely.
46
47         * WebView/WebHTMLView.mm:
48         (isInPasswordField): Factored out code to determine that the current selection is in
49         a password field.
50         (inputContext): Removed a hack that was breaking TSMGetActiveDocument().
51         (-[WebHTMLView attributedSubstringFromRange:]): Check for password fields.
52         (-[WebHTMLView textStorage]): Ditto.
53
54 2008-08-12  Darin Adler  <darin@apple.com>
55
56         Reviewed by Geoff.
57
58         - eliminate JSValue::type()
59
60         * WebView/WebView.mm:
61         (aeDescFromJSValue): Rewrite to use the JSValue::is functions instead
62         of a switch on JSValue::type().
63
64 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
65
66         Reviewed by Cameron Zwarich.
67
68         Made room for a free word in JSCell.
69         
70         (Updated for JavaScriptCore changes.)
71
72 2008-08-15  Mark Rowe  <mrowe@apple.com>
73
74         Rubber-stamped by Geoff Garen.
75
76         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
77
78         * Configurations/Base.xcconfig: Factor out the debug-only settings so that they can shared
79         between the Debug configuration and debug Production variant.
80
81 2008-08-14  Sam Weinig  <sam@webkit.org>
82
83         Reviewed by Geoffrey Garen and Timothy Hatcher.
84
85         Add WebView SPI to set HTMLTokenizer yielding parameters.
86
87         * WebView/WebView.mm:
88         (-[WebView _setCustomHTMLTokenizerTimeDelay:]):
89         (-[WebView _setCustomHTMLTokenizerChunkSize:]):
90         * WebView/WebViewPrivate.h:
91
92 2008-08-13  Timothy Hatcher  <timothy@apple.com>
93
94         Fixes a bug where Safari's find banner would be permanently hidden
95         when attaching or closing the Web Inspector while attached.
96
97         https://bugs.webkit.org/show_bug.cgi?id=20376
98
99         Reviewed by Kevin McCullough.
100
101         * WebCoreSupport/WebInspectorClient.mm:
102         (-[WebInspectorWindowController close]):
103         Carefully manipulate the WebFrameView's frame when closing to
104         not assume the WebFrameView's frame fills the inspected WebView.
105         (-[WebInspectorWindowController setAttachedWindowHeight:]):
106         Carefully manipulate the WebFrameView's frame when docking to
107         not assume the WebFrameView plus the Web Inspector WebViews fills
108         the full inspected WebView.
109
110 2008-08-13  Stephanie Lewis  <slewis@apple.com>
111
112         fix 64bit build
113
114         * WebCoreSupport/WebInspectorClient.mm:
115
116 2008-08-13  Timothy Hatcher  <timothy@apple.com>
117
118         Remember the docked state of the Web Inspector, so it can be
119         reopened docked if it was last docked.
120
121         https://bugs.webkit.org/show_bug.cgi?id=14271
122
123         Reviewed by Kevin McCullough.
124
125         * WebCoreSupport/WebInspectorClient.mm:
126         (-[WebInspectorWindowController init]): Initialize _shouldAttach
127         to the value stored in the user defaults. If there has never
128         been a value stored, default to being attached.
129         (-[WebInspectorWindowController showWindow:]): Pass the attached
130         state to InspectorController::setWindowVisible.
131
132 2008-08-12  Timothy Hatcher  <timothy@apple.com>
133
134         Remove the Inspector's WebView for the view hierarchy when closed
135         while attached. This prevents it from showing in the background
136         while the page changes.
137
138         Reviewed by Kevin McCullough.
139
140         * WebCoreSupport/WebInspectorClient.mm:
141         (-[WebInspectorWindowController close:]): Call removeFromSuperview
142         on the Inspector's WebView if it isn't attached, so it will not
143         be visible when navigating pages while closed.
144
145 2008-08-12  Timothy Hatcher  <timothy@apple.com>
146
147         Make the docked Web Inspector resizable.
148
149         https://bugs.webkit.org/show_bug.cgi?id=14282
150
151         Reviewed by Kevin McCullough.
152
153         * WebCoreSupport/WebInspectorClient.h:
154         * WebCoreSupport/WebInspectorClient.mm:
155         (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight:
156         on the WebInspectorWindowController.
157         (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:.
158         (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code
159         from showWindow: and generalized to allow being called multiple times.
160         Remembers the last height passed, which is used by showWindow: the next
161         time the Inspector attaches.
162
163 2008-08-12  Timothy Hatcher  <timothy@apple.com>
164
165         Remove unneeded header imports from some Web Inspector files.
166
167         Reviewed by Adam Roben.
168
169         * WebCoreSupport/WebInspectorClient.mm:
170         * WebInspector/WebInspector.mm:
171         * WebInspector/WebNodeHighlightView.m:
172
173 2008-08-12  Timothy Hatcher  <timothy@apple.com>
174
175         Remove the call to WKNSWindowMakeBottomCornersSquare on the
176         Web Inspector's window. This isn't needed anymore since the
177         window style masks used always have square bottom corners.
178
179         Reviewed by Adam Roben.
180
181         * WebCoreSupport/WebInspectorClient.mm:
182         (-[WebInspectorWindowController window]): Remove the call
183         to WKNSWindowMakeBottomCornersSquare.
184
185 2008-08-12  Timothy Hatcher  <timothy@apple.com>
186
187         Make attaching and detaching the Web Inspector instantaneous.
188         This also preserves the current view, other state, and keeps
189         the script debugger attached.
190
191         https://bugs.webkit.org/show_bug.cgi?id=19301
192
193         Reviewed by Adam Roben.
194
195         * WebCoreSupport/WebInspectorClient.mm:
196         (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
197         when not moving windows.
198
199 2008-08-12  Dan Bernstein  <mitz@apple.com>
200
201         Reviewed by John Sullivan.
202
203         - replace -[WebPreferences updatesWhenOffscreen] with -[WebView shouldUpdateWhileHidden]
204
205         * WebCoreSupport/WebFrameLoaderClient.mm:
206         (WebFrameLoaderClient::transitionToCommittedForNewPage):
207         * WebView/WebFrame.mm:
208         (-[WebFrame _updateBackgroundAndUpdatesWhileHidden]):
209         * WebView/WebFrameInternal.h:
210         * WebView/WebHTMLView.mm:
211         (-[WebHTMLView windowWillOrderOnScreen:]):
212         * WebView/WebPreferenceKeysPrivate.h:
213         * WebView/WebPreferences.mm:
214         (+[WebPreferences initialize]):
215         * WebView/WebPreferencesPrivate.h:
216         * WebView/WebView.mm:
217         (-[WebViewPrivate init]):
218         (-[WebView _preferencesChangedNotification:]):
219         (-[WebView setBackgroundColor:]):
220         (-[WebView setDrawsBackground:]):
221         (-[WebView shouldUpdateWhileHidden]):
222         (-[WebView setShouldUpdateWhileHidden:]):
223         * WebView/WebViewPrivate.h:
224
225 2008-08-08  Dan Bernstein  <mitz@apple.com>
226
227         Reviewed by John Sullivan.
228
229         - fix <rdar://problem/6130216> Exception "windowRegionBeingDrawn != nil" in NSView when caching image of a subframe
230
231         This change reintroduces <https://bugs.webkit.org/show_bug.cgi?id=5195> on Leopard.
232
233         * WebView/WebHTMLView.mm:
234         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Removed an
235         unsuccessful workaround for <rdar://problem/5668489>, because invoking
236         layout may change the view hierarchy during the drawing operation,
237         which is not supported on Leopard.
238
239 2008-08-08  Maxime Britto  <britto@apple.com>
240
241         Reviewed by Adele.
242
243         * WebView/WebFrame.mm:
244         (-[WebFrame _scrollDOMRangeToVisible:]):
245
246 2008-08-08  Brady Eidson  <beidson@apple.com>
247
248         Reviewed by Sam Weinig
249
250         Fix for <rdar://problem/5865504>
251
252         This bug was actually *largely* fixed by http://trac.webkit.org/changeset/35538.
253         But with that same patch, it became possible for a WebResource to fail to initialize.  
254         Therefore we were trying to add nil to an NSCFArray for certain situations, which is bad.
255         Lets fix that, shall we?
256
257         * WebView/WebArchive.mm:
258         (-[WebArchive subresources]): 
259
260 2008-08-06  Eric Seidel  <eric@webkit.org>
261
262         Reviewed by Cameron Zwarich.
263
264         Move more methods from Frame into ScriptController
265         https://bugs.webkit.org/show_bug.cgi?id=20294
266
267         The WebKit side of this move.  Calls to frame() are now frame()->script()
268
269         * Plugins/WebBaseNetscapePluginView.mm:
270         (-[WebBaseNetscapePluginView getVariable:value:]):
271         (-[WebBaseNetscapePluginView _destroyPlugin]):
272         * Plugins/WebPluginController.mm:
273         (-[WebPluginController destroyPlugin:]):
274         (-[WebPluginController destroyAllPlugins]):
275         * WebCoreSupport/WebFrameLoaderClient.mm:
276         * WebView/WebFrame.mm:
277         (-[WebFrame windowObject]):
278         * WebView/WebScriptDebugger.mm:
279         (WebScriptDebugger::callEvent):
280         * WebView/WebView.mm:
281         (-[WebView windowScriptObject]):
282
283 2008-08-06  Dan Bernstein  <mitz@apple.com>
284
285         Reviewed by Mark Rowe.
286
287         - fix an assertion failure in Cache::setCapacities()
288
289         * Misc/WebKitSystemBits.h: Changed the return type of WebMemorySize()
290         to uint64_t.
291         * Misc/WebKitSystemBits.m:
292         (WebMemorySize):
293         * WebView/WebView.mm:
294         (+[WebView _setCacheModel:]):
295
296 2008-08-05  Anders Carlsson  <andersca@apple.com>
297
298         Pass in the correct class here.
299         
300         * WebView/WebResource.mm:
301         (-[WebResourcePrivate dealloc]):
302
303 2008-08-05  Anders Carlsson  <andersca@apple.com>
304
305         Reviewed by Darin.
306
307         <rdar://problem/6037398>
308         ER: Deallocate WebKit objects on the main thread, even if released on secondary thread
309         
310         Add calls to WebCoreObjCScheduleDeallocateOnMainThread in dealloc methods of objects we expose.
311
312         * Carbon/CarbonWindowAdapter.m:
313         (-[CarbonWindowAdapter dealloc]):
314         * History/WebBackForwardList.mm:
315         (-[WebBackForwardList dealloc]):
316         * History/WebHistoryItem.mm:
317         (-[WebHistoryItem dealloc]):
318         * Misc/WebElementDictionary.mm:
319         (+[WebElementDictionary initialize]):
320         (-[WebElementDictionary dealloc]):
321         * WebCoreSupport/WebEditorClient.mm:
322         (-[WebEditCommand dealloc]):
323         * WebCoreSupport/WebFrameLoaderClient.mm:
324         * WebView/WebArchive.mm:
325         (-[WebArchivePrivate dealloc]):
326         * WebView/WebDataSource.mm:
327         (-[WebDataSourcePrivate dealloc]):
328         * WebView/WebHTMLView.mm:
329         (-[WebHTMLViewPrivate dealloc]):
330         (-[WebHTMLView dealloc]):
331         * WebView/WebResource.mm:
332         (-[WebResourcePrivate dealloc]):
333
334 2008-08-05  Anders Carlsson  <andersca@apple.com>
335
336         Reviewed by Darin.
337
338         Remove MainThreadObjectDeallocator.{h|mm}.
339
340         * WebView/MainThreadObjectDeallocator.h: Removed.
341         * WebView/MainThreadObjectDeallocator.mm: Removed.
342         
343         * WebView/WebView.mm:
344         (-[WebView dealloc]):
345         Call WebCoreObjCScheduleDeallocateOnMainThread instead.
346
347 2008-08-05  Anders Carlsson  <andersca@apple.com>
348
349         Reviewed by Darin.
350
351         Make the main thread object deallocator work with subclasses.
352         
353         * WebView/MainThreadObjectDeallocator.h:
354         * WebView/MainThreadObjectDeallocator.mm:
355         (deallocCallback):
356         Call the correct dealloc method.
357                 
358         (scheduleDeallocateOnMainThread):
359         Store both the class and the instance, so we know which dealloc method to call.
360         
361         * WebView/WebView.mm:
362         (-[WebViewPrivate dealloc]):
363         Schedule deallocation on the main thread.
364
365 2008-08-05  Dan Bernstein  <mitz@apple.com>
366
367         Reviewed by Mark Rowe and Anders Carlsson.
368
369         - fix WebMemorySize() reporting a value capped at 2GB
370
371         * misc/WebKitSystemBits.m:
372         (WebMemorySize): Changed to return the max_mem field, which, unlike
373         memory_size, is not capped at 2GB.
374         * WebView/WebView.mm:
375         (+[WebView _setCacheModel:]): Made the cache sizes for over 2GB RAM the
376         same as for 2GB, so that behavior on machines that have more than 2GB
377         RAM is not affected by the fix to WebMemorySize().
378
379 2008-08-04  Mark Rowe  <mrowe@apple.com>
380
381         Build fix.
382
383         * WebView/WebHTMLView.mm:
384
385 2008-08-04  Mark Rowe  <mrowe@apple.com>
386
387         Reviewed by Kevin Decker.
388
389         Adopt the formal protocols where necessary.
390         Final part of fix for <rdar://problem/5853147>.
391
392         * WebCoreSupport/WebInspectorClient.mm:
393         * WebView/WebHTMLView.mm:
394         * WebView/WebView.mm:
395         (-[WebView _openFrameInNewWindowFromMenu:]):
396
397 2008-08-04  Mark Rowe  <mrowe@apple.com>
398
399         Reviewed by Darin Adler.
400
401         Declare empty protocols when using versions of AppKit that do not use formal protocols for delegates and data sources.
402         Part one of fix for <rdar://problem/5853147>.
403
404         * Misc/EmptyProtocolDefinitions.h:
405         * WebKitPrefix.h:
406
407 2008-08-04  Brady Eidson  <beidson@apple.com>
408
409         Reviewed by Mitz Pettel
410
411         Fix <rdar://problem/5820157> - Saving WebArchives of Mail attachments broken.
412
413         This broke in r31355 when we stopped returning nil WebResources when there was nil
414         resource data.
415
416         * WebView/WebResource.mm:
417         (-[WebResource _initWithCoreResource:]): Restore previous behavior of returning nil
418           when the resource data is null.
419
420 2008-08-02  Matt Lilek  <webkit@mattlilek.com>
421
422         Reviewed by Tim Hatcher.
423
424         Update the window gradient offset to match the inspector toolbar's new height.
425
426         * WebCoreSupport/WebInspectorClient.mm:
427         (-[WebInspectorWindowController window]):
428
429 2008-08-01  Anders Carlsson  <andersca@apple.com>
430
431         Reviewed by Jon.
432
433         <rdar://problem/6120206>
434         Crash when plug-in queries for NPPVpluginWantsAllNetworkStreams.
435         
436         Pass in a pointer to a void* to make sure that plug-ins don't overwrite the stack.
437
438         * Plugins/WebBaseNetscapePluginStream.mm:
439         (-[WebBaseNetscapePluginStream wantsAllStreams]):
440
441 2008-07-31  Anders Carlsson  <andersca@apple.com>
442
443         Reviewed by Darin.
444
445         <rdar://problem/5949410>
446         Add the ability to transfer a given application cache to a new database.
447
448         * Misc/WebKitNSStringExtras.h:
449         * Misc/WebKitNSStringExtras.m:
450         (+[NSString _webkit_applicationCacheDirectoryWithBundleIdentifier:]):
451         New method which returns the appopriate cache directory for a given bundle identifier.
452         
453         * WebView/WebDataSource.mm:
454         (-[WebDataSource _transferApplicationCache:]):
455         Transfer the application cache.
456         
457         * WebView/WebDataSourcePrivate.h:
458         * WebView/WebView.mm:
459         (WebKitInitializeApplicationCachePathIfNecessary):
460         Change this to use _webkit_applicationCacheDirectoryWithBundleIdentifier.
461
462 2008-07-31  John Sullivan  <sullivan@apple.com>
463
464         WebKit part of <rdar://problem/6116650> Text-only zoom setting should be stored in WebKit prefs
465
466         Reviewed by Hyatt
467
468         * WebView/WebPreferenceKeysPrivate.h:
469         added WebKitZoomsTextOnlyPreferenceKey
470         
471         * WebView/WebPreferences.mm:
472         (+[WebPreferences initialize]):
473         default value of YES for WebKitZoomsTextOnlyPreferenceKey
474         (-[WebPreferences zoomsTextOnly]):
475         getter for WebKitZoomsTextOnlyPreferenceKey
476         (-[WebPreferences setZoomsTextOnly:]):
477         setter for WebKitZoomsTextOnlyPreferenceKey
478         
479         * WebView/WebPreferencesPrivate.h:
480         declare zoomsTextOnly/setZoomsTextOnly:
481         
482         * WebView/WebView.mm:
483         (-[WebView _preferencesChangedNotification:]):
484         update WebCore::Settings value for zoomsTextOnly
485
486 2008-07-31  David D. Kilzer  <ddkilzer@webkit.org>
487
488         Fix layout test results for webarchive/test-xml-stylesheet.xml
489
490         Reviewed by Darin.
491
492         Needed to expose -[WebHTMLRepresentation supportedNonImageMIMETypes]
493         for DumpRenderTree.
494
495         * WebView/WebHTMLRepresentationInternal.h: Added.
496
497 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
498
499         Release build fix.
500
501         * Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView setWindowIfNecessary]):
502         Don't define to npErr in release builds, as it is only used for logging.
503
504 2008-07-31  John Sullivan  <sullivan@apple.com>
505
506         Fixed <https://bugs.webkit.org/show_bug.cgi?id=5195>
507         drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard
508
509         Reviewed by Dan
510
511         * WebView/WebHTMLView.mm:
512         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
513         include Leopard in the #ifdef that forces a layout if needed
514
515 2008-07-30  Brady Eidson  <beidson@apple.com>
516
517         Reviewed by Adam and Hyatt
518
519         Fix for <rdar://problem/6099748>
520
521         * WebView/WebView.mm:
522         (-[WebView _preferencesChangedNotification:]): Set the "don't enforce CSS mime type in strict mode" 
523           quirk when running under iWeb 2
524
525 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
526
527         Rubber-stamped by Maciej.
528
529         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
530         call sites now).
531
532         * ForwardingHeaders/kjs/JSLock.h: Removed.
533         * Misc/WebCoreStatistics.mm:
534         (+[WebCoreStatistics javaScriptObjectsCount]):
535         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
536         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
537         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
538         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
539         (+[WebCoreStatistics shouldPrintExceptions]):
540         (+[WebCoreStatistics setShouldPrintExceptions:]):
541         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
542         * Plugins/WebBaseNetscapePluginStream.mm:
543         (-[WebBaseNetscapePluginStream wantsAllStreams]):
544         * Plugins/WebBaseNetscapePluginView.mm:
545         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
546         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
547         (-[WebBaseNetscapePluginView start]):
548         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
549         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
550         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
551         (-[WebBaseNetscapePluginView loadPluginRequest:]):
552         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
553         * Plugins/WebPluginController.mm:
554         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
555         (-[WebPluginController startAllPlugins]):
556         (-[WebPluginController stopAllPlugins]):
557         (-[WebPluginController addPlugin:]):
558         (-[WebPluginController destroyPlugin:]):
559         (-[WebPluginController destroyAllPlugins]):
560         * WebView/WebFrame.mm:
561         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
562         * WebView/WebScriptDebugDelegate.mm:
563         (-[WebScriptCallFrame evaluateWebScript:]):
564         * WebView/WebView.mm:
565         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
566
567 2008-07-30  Beth Dakin  <bdakin@apple.com>
568
569         Reviewed by Anders Carlsson.
570
571         Fixes <rdar://problem/6041390>
572
573         Adds the ability to have a frame that is "disconnected" from the 
574         main frame from the perspective of top and parent in 
575         Javascript.
576
577         * WebView/WebFrame.mm:
578         (-[WebFrame _setIsDisconnectedFrame]):
579         * WebView/WebFramePrivate.h:
580
581 2008-07-29  Mark Rowe  <mrowe@apple.com>
582
583         Tweak to the build fix to keep Dan happy.
584
585         * Plugins/WebBaseNetscapePluginView.mm:
586         * WebView/WebHTMLView.mm:
587
588 2008-07-29  Mark Rowe  <mrowe@apple.com>
589
590         Build fix.
591
592         * Plugins/WebBaseNetscapePluginView.mm:
593         (-[WebBaseNetscapePluginView inputContext]):
594         * WebView/WebHTMLView.mm:
595
596 2008-07-28  Anders Carlsson  <andersca@apple.com>
597
598         Reviewed by Kevin Decker.
599
600         Based on a patch by Dimcho Balev.
601         
602         https://bugs.webkit.org/show_bug.cgi?id=18676
603         <rdar://problem/6106578>
604         Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs
605
606         * Plugins/WebBaseNetscapePluginStream.h:
607         Add NPP_GetValue pointer.
608         
609         * Plugins/WebBaseNetscapePluginStream.mm:
610         (-[WebBaseNetscapePluginStream setPlugin:]):
611         Initialize NPP_GetValue.
612         
613         (-[WebBaseNetscapePluginStream wantsAllStreams]):
614         Call NPP_GetValue.
615         
616         * Plugins/WebPlugInStreamLoaderDelegate.h:
617         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
618         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm:
619         (WebNetscapePlugInStreamLoaderClient::wantsAllStreams):
620         Implement this and call down to the stream.
621
622 2008-07-28  Anders Carlsson  <andersca@apple.com>
623
624         Reviewed by Adam.
625
626         <rdar://problem/6105529> 
627         https://bugs.webkit.org/show_bug.cgi?id=19659
628         Turning off plugins causes crash
629         
630         When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
631         end up in a state where they don't have an event handler. Because of this, we need to 
632         check that the plug-in has been started before calling the event handler.
633         
634         * Plugins/WebBaseNetscapePluginView.mm:
635         (-[WebBaseNetscapePluginView sendActivateEvent:]):
636         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
637         (-[WebBaseNetscapePluginView setHasFocus:]):
638         (-[WebBaseNetscapePluginView mouseDown:]):
639         (-[WebBaseNetscapePluginView mouseUp:]):
640         (-[WebBaseNetscapePluginView mouseEntered:]):
641         (-[WebBaseNetscapePluginView mouseExited:]):
642         (-[WebBaseNetscapePluginView handleMouseMoved:]):
643         (-[WebBaseNetscapePluginView mouseDragged:]):
644         (-[WebBaseNetscapePluginView scrollWheel:]):
645         (-[WebBaseNetscapePluginView keyUp:]):
646         (-[WebBaseNetscapePluginView keyDown:]):
647         (-[WebBaseNetscapePluginView flagsChanged:]):
648         (-[WebBaseNetscapePluginView cut:]):
649         (-[WebBaseNetscapePluginView copy:]):
650         (-[WebBaseNetscapePluginView paste:]):
651         (-[WebBaseNetscapePluginView selectAll:]):
652         (-[WebBaseNetscapePluginView drawRect:]):
653         (-[WebBaseNetscapePluginView inputContext]):
654
655 2008-07-26  Daniel Jalkut  <jalkut@red-sweater.com>
656
657         Reviewed by Geoff Garen.
658
659         Changes to accommodate newly named/signatured loading methods in WebCore.
660
661         * Plugins/WebNetscapePluginStream.mm:
662         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
663         * Plugins/WebPluginContainerCheck.mm:
664         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
665         * WebView/WebPDFView.mm:
666         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
667
668 2008-07-21  Mark Rowe  <mrowe@apple.com>
669
670         Reviewed by Sam Weinig.
671
672         <rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
673
674         * Configurations/Version.xcconfig:
675         * Info.plist:
676
677 2008-07-21  Anders Carlsson  <andersca@apple.com>
678
679         Reviewed by Geoff.
680
681         <rdar://problem/5820667> 
682         CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
683         
684         Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
685         
686         * Plugins/WebBaseNetscapePluginView.mm:
687         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
688
689 2008-07-21  Mark Rowe  <mrowe@apple.com>
690
691         Reviewed by Adam Roben.
692
693         <rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
694
695         Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
696         This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
697
698         * WebView/WebHTMLView.mm:
699
700 2008-07-21  Mark Rowe  <mrowe@apple.com>
701
702         Reviewed by Adam Roben.
703
704         Fix CallDelegateReturningFloat for x86_64.  The x86_64 Objective-C runtime
705         only uses objc_msgSend_fpret for long double return values.  For float return
706         values the standard objc_msgSend is used, as on ppc and ppc64.
707
708         * WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
709         objc_msgSend with the correct return type.  We can no longer call it objc_msgSend_fpret
710         as that method is defined by the Objective-C runtime for x86_64.
711         (CallDelegateReturningFloat):
712
713 2008-07-14  Dan Bernstein  <mitz@apple.com>
714
715         Reviewed by John Sullivan.
716
717         - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
718
719         * Plugins/WebBaseNetscapePluginView.mm:
720         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
721         to account for the case of being drawn into a bitmap context that is not
722         a window's backing store. In that case, there are no valid "rects being
723         drawn" to clip to.
724         * WebView/WebHTMLView.mm:
725         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
726         Added an override of this NSView method which is used in for
727         -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
728         machinery overrides, it sets subviews aside before invoking the
729         superclass implementation. On Tiger, it also updates the layout.
730
731 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
732
733         Reviewed by Geoff Garen.
734
735         Eliminate per-thread JavaScript global data instance support and make arbitrary
736         global data/global object combinations possible.
737
738         * Misc/WebCoreStatistics.mm:
739         (+[WebCoreStatistics javaScriptObjectsCount]):
740         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
741         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
742         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
743         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
744         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
745         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
746
747 2008-07-11  Stephanie Lewis  <slewis@apple.com>
748
749         Reviewed by Darin Adler.
750
751         Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.
752
753         * WebView/WebPreferences.m: Removed.
754         * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
755         (+[WebPreferences initialize]): if running in Default enable full  document teardown
756         (-[WebPreferences editableLinkBehavior]):
757         (-[WebPreferences setFullDocumentTeardownEnabled:]):
758         * WebView/WebView.mm:
759         (-[WebView _close]): disable leak messages if using fast teardown
760
761 2008-07-10  Mark Rowe  <mrowe@apple.com>
762
763         Reviewed by Sam Weinig.
764
765         Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.
766
767         * Configurations/WebKit.xcconfig:
768
769 2008-07-10  Mark Rowe  <mrowe@apple.com>
770
771         Reviewed by Sam Weinig.
772
773         Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.
774
775         * Plugins/WebPlugin.h: Wrap annotations on methods declared in categories in the WEBKIT_CATEGORY_METHOD_ANNOTATION macro.
776         * WebView/WebFrameLoadDelegate.h: Ditto.
777         * WebView/WebUIDelegate.h: Ditto.
778
779 2008-07-10  Anders Carlsson  <andersca@apple.com>
780
781         Reviewed by Mark.
782         
783         Add availability macros for the new WebPlugin methods.
784
785         * Plugins/WebPlugin.h:
786         * Plugins/WebPluginViewFactory.h:
787
788 2008-07-09  Mark Rowe  <mrowe@apple.com>
789
790         Reviewed by Geoff Garen.
791
792         Don't warn about deprecated functions in production builds.
793
794         * Configurations/Base.xcconfig:
795         * Configurations/DebugRelease.xcconfig:
796
797 2008-07-09  Brady Eidson  <beidson@apple.com>
798
799         Reviewed by Darin
800
801         <rdar://problem/5823684> - Crash manipulating frame tree of a new frame before the new frame
802         has been installed in a frame tree.
803
804         The root of this problem was that calling init() on a new frame could end up calling arbitrary
805         javascript that might end up removing the frame from the tree.  This opened up a small can of worms
806         such as the frame not having yet been installed in its frame tree, and other assumed behavior while
807         destroying the frame.
808
809         Note that each platforms WebKit API layer needs to make this new guarantee:
810         "The new Frame must be installed in its FrameTree before newCoreFrame->init() is called"
811         I am fixing Mac, and Windows and GTK already have this property.  Wx currently has subframes disabled
812         but will need to add this guarantee when re-enabling, and Qt is currently vulnerable to this same bug.
813
814         Alternately, the way frames are created right now is roundabout and asinine, and this is a key
815         architectural improvement we can make in the future so the individual platform clients are no longer
816         vulnerable to this problem, which should really have been a WebCore issue.
817
818         * WebCoreSupport/WebFrameLoaderClient.mm:
819         (WebFrameLoaderClient::createFrame):  Don't bother null checking the newCoreFrame - can't be NULL.
820           Don't appendChild() the new frame here.
821           Null-check the new frame's page before loading the URL into it, as it might already have been
822           removed from the page.
823
824         * WebView/WebFrame.mm:
825         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):  If there is an ownerElement,
826           go ahead and install the new frame in the frame tree *before* calling init() on it.
827
828 2008-07-09  Anders Carlsson  <andersca@apple.com>
829
830         Reviewed by Darin.
831
832         Make some WebPlugin and WebPluginFactory SPI public.
833         
834         * Plugins/WebPlugin.h:
835         * Plugins/WebPluginPrivate.h:
836         * Plugins/WebPluginViewFactory.h:
837         * Plugins/WebPluginViewFactoryPrivate.h:
838
839 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
840
841         Reviewed by Anders.
842
843         Port r34988 to Mac: don't call NPP_DestroyStream if NPP_NewStream was
844         unsuccessful.
845
846         * Plugins/WebBaseNetscapePluginStream.h: Added new member,
847         newStreamSuccessful.
848         * Plugins/WebBaseNetscapePluginStream.mm:
849         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): Initialize new member.
850         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): If NPP_NewStream is successful, set
851         newStreamSuccessful to YES.
852         (-[WebBaseNetscapePluginStream _destroyStream]): Only call
853         NPP_DestroyStream if newStreamSuccessful is true.
854
855 2008-07-08  Dan Bernstein  <mitz@apple.com>
856
857         Reviewed by John Sullivan.
858
859         - WebKit part of <rdar://problem/6008409> Need a way to disable updates in offscreen views
860
861         * WebView/WebHTMLView.mm:
862         (-[WebHTMLView addWindowObservers]): Added code to observe when the
863         window goes onscreen.
864         (-[WebHTMLView removeWindowObservers]): Added.
865         (-[WebHTMLView windowWillOrderOnScreen:]): Added. If the view is set to
866         not update when offscreen, calls -setNeedsDisplay: just before it comes
867         onscreen.
868         * WebView/WebPreferenceKeysPrivate.h: Added preference key.
869         * WebView/WebPreferences.m:
870         (+[WebPreferences initialize]): Made updates when offscreen on by
871         default.
872         (-[WebPreferences updatesWhenOffscreen]): Added.
873         (-[WebPreferences setUpdatesWhenOffscreen:]): Added.
874         * WebView/WebPreferencesPrivate.h:
875         * WebView/WebView.mm:
876         (-[WebView _preferencesChangedNotification:]): Added code to update the
877         updatesWhenOffscreen setting in WebCore.
878
879 2008-07-07  Anders Carlsson  <andersca@apple.com>
880
881         Reviewed by Darin.
882
883         Speculative fix for     
884         <rdar://problem/5839800>
885         CrashTracer: [USER] 5802 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
886         
887         Set _private->closed to YES before calling -[WebPluginController destroyAllPlugins].
888         
889         My theory is that the plug-in destruction callbacks could end up rescheduling timers or re-adding notifications.
890         This is usually protected by _private->closed, but in this case it might still be false.
891
892         * WebView/WebHTMLView.mm:
893         (-[WebHTMLView close]):
894
895 2008-07-05  Mark Rowe  <mrowe@apple.com>
896
897         Reviewed by John Sullivan.
898
899         Remove WebSearchableTextView as it has been unused for some time now.
900
901         * Misc/WebSearchableTextView.h: Removed.
902         * Misc/WebSearchableTextView.m: Removed.
903
904 2008-07-05  Mark Rowe  <mrowe@apple.com>
905
906         Reviewed by John Sullivan.
907
908         Don't leak the result of WKCopyCFLocalizationPreferredName when running under GC.
909
910         * Misc/WebNSUserDefaultsExtras.m:
911         (-[NSString _webkit_HTTPStyleLanguageCode]):
912
913 2008-07-02  Alexey Proskuryakov  <ap@webkit.org>
914
915         Inspired and reviewed by Mark Rowe.
916
917         Change non-API includes from JavaScriptCore/ to kjs/ and wtf/ to match prevalent style.
918
919         * Carbon/HIViewAdapter.m:
920         * DOM/WebDOMOperations.mm:
921         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
922         * DefaultDelegates/WebDefaultPolicyDelegate.m:
923         * History/WebBackForwardList.mm:
924         * History/WebHistory.mm:
925         * History/WebHistoryItem.mm:
926         * History/WebHistoryItemInternal.h:
927         * Misc/WebCoreStatistics.mm:
928         * Misc/WebDownload.m:
929         * Misc/WebGraphicsExtras.c:
930         * Misc/WebKitLogging.h:
931         * Misc/WebKitSystemBits.m:
932         * Misc/WebLocalizableStrings.m:
933         * Misc/WebNSArrayExtras.m:
934         * Misc/WebNSDataExtras.m:
935         * Misc/WebNSDictionaryExtras.m:
936         * Misc/WebNSFileManagerExtras.m:
937         * Misc/WebNSPasteboardExtras.mm:
938         * Misc/WebNSURLExtras.mm:
939         * Misc/WebNSUserDefaultsExtras.m:
940         * Panels/WebAuthenticationPanel.m:
941         * Panels/WebPanelAuthenticationHandler.m:
942         * Plugins/WebBaseNetscapePluginView.mm:
943         * Plugins/WebBasePluginPackage.m:
944         * Plugins/WebNetscapePluginEmbeddedView.mm:
945         * Plugins/WebPluginContainerCheck.mm:
946         * Plugins/WebPluginController.mm:
947         * Plugins/WebPluginDatabase.mm:
948         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
949         * WebCoreSupport/WebKeyGenerator.m:
950         * WebCoreSupport/WebViewFactory.mm:
951         * WebKitPrefix.h:
952         * WebView/WebHTMLRepresentation.mm:
953         * WebView/WebPDFRepresentation.m:
954         * WebView/WebPDFView.mm:
955         * WebView/WebScriptDebugger.mm:
956
957 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
958
959         Reviewed by Darin.
960
961         Disable JSLock for per-thread contexts.
962
963         * Misc/WebCoreStatistics.mm:
964         (+[WebCoreStatistics javaScriptObjectsCount]):
965         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
966         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
967         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
968         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
969         (+[WebCoreStatistics shouldPrintExceptions]):
970         (+[WebCoreStatistics setShouldPrintExceptions:]):
971         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
972         * Plugins/WebBaseNetscapePluginView.mm:
973         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
974         (-[WebBaseNetscapePluginView setWindowIfNecessary]):
975         (-[WebBaseNetscapePluginView start]):
976         (-[WebBaseNetscapePluginView createPluginScriptableObject]):
977         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
978         (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
979         (-[WebBaseNetscapePluginView loadPluginRequest:]):
980         (-[WebBaseNetscapePluginView _printedPluginBitmap]):
981         * Plugins/WebPluginController.mm:
982         (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
983         (-[WebPluginController startAllPlugins]):
984         (-[WebPluginController stopAllPlugins]):
985         (-[WebPluginController addPlugin:]):
986         (-[WebPluginController destroyPlugin:]):
987         (-[WebPluginController destroyAllPlugins]):
988         * WebView/WebFrame.mm:
989         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
990         * WebView/WebScriptDebugDelegate.mm:
991         (-[WebScriptCallFrame evaluateWebScript:]):
992         * WebView/WebView.mm:
993         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
994         Pass a parameter (always false) to JSLock and JSLock::DropAllLocks to indicate that WebKit
995         doesn't need locking. In the future, it may be possible to remove some of these if we
996         establish that this won't make JSC assertions fail (and that we don't want to add such
997         assertions either).
998         Added includes that are now needed.
999
1000 2008-07-01  Kevin McCullough  <kmccullough@apple.com>
1001
1002         Build fix.
1003
1004         * WebView/WebView.mm:
1005
1006 2008-07-01  Anders Carlsson  <andersca@apple.com>
1007
1008         Reviewed by Darin.
1009
1010         Use the PluginMainThreadScheduler, and implement NPN_PluginThreadAsyncCall.
1011         
1012         * Plugins/WebBaseNetscapePluginView.mm:
1013         (-[WebBaseNetscapePluginView _createPlugin]):
1014         Register the plug-in instance.
1015         
1016         (-[WebBaseNetscapePluginView _destroyPlugin]):
1017         Unegister the plug-in instance.
1018         
1019         * Plugins/WebNetscapePluginPackage.m:
1020         (-[WebNetscapePluginPackage load]):
1021         Set NPN_PluginThreadAsyncCall.
1022         
1023         * Plugins/npapi.mm:
1024         (NPN_PluginThreadAsyncCall):
1025         Implement this.
1026
1027 2008-07-01  Dan Bernstein  <mitz@apple.com>
1028
1029         Reviewed by Darin Adler.
1030
1031         - WebKit part of moving the method to set the base writing direction from Frame to Editor
1032
1033         * WebView/WebHTMLView.mm:
1034         (-[WebHTMLView toggleBaseWritingDirection:]): Changed back to call the
1035         Editor method.
1036         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
1037         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
1038
1039 2008-07-01  Geoffrey Garen  <ggaren@apple.com>
1040
1041         Build fix: forgot to check in this file.
1042
1043         * WebView/WebScriptDebugger.mm:
1044         (WebScriptDebugger::WebScriptDebugger):
1045
1046 2008-06-30  Dan Bernstein  <mitz@apple.com>
1047
1048         Reviewed by Adele Peterson.
1049
1050         - WebKit/mac part of <rdar://problem/3881497> Writing direction context menu item has no effect on text typed in Safari
1051
1052         * WebView/WebHTMLView.mm:
1053         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
1054         WebCore::Frame::setSelectionBaseWritingDirection() instead of
1055         WebCore::Editor::setBaseWritingDirection().
1056         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
1057         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Ditto.
1058
1059 2008-06-28  Darin Adler  <darin@apple.com>
1060
1061         - fix build
1062
1063         * WebView/WebView.mm:
1064         (aeDescFromJSValue): Use get instead of getItem, which no longer exists.
1065
1066 2008-06-26  Anders Carlsson  <andersca@apple.com>
1067
1068         Reviewed by Darin.
1069
1070         Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
1071         if necessary. Use this for the WebView class. 
1072                 
1073         * WebView/MainThreadObjectDeallocator.h: Added.
1074         * WebView/MainThreadObjectDeallocator.mm: Added.
1075         (deallocCallback):
1076         (scheduleDeallocateOnMainThread):
1077         * WebView/WebView.mm:
1078         (-[WebViewPrivate dealloc]):
1079         (+[WebView initialize]):
1080
1081 2008-06-25  Anders Carlsson  <andersca@apple.com>
1082
1083         Reviewed by Mark.
1084
1085         <rdar://problem/5984270> 
1086         REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
1087         
1088         * WebView/WebView.mm:
1089         (tigerMailReleaseIMP):
1090         New method that makes sure that the final release happens on the main thread.
1091         
1092         (-[WebView release]):
1093         New method that just calls [super release];
1094         
1095         (+[WebView initialize]):
1096         When running under Tiger mail, replace the release method with tigerMailReleaseIMP.
1097
1098 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
1099
1100         Reviewed by Geoff.
1101
1102         Make Machine per-JSGlobalData.
1103
1104         * WebView/WebScriptDebugger.mm:
1105         (WebScriptDebugger::WebScriptDebugger):
1106
1107 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
1108
1109         Reviewed by Darin.
1110
1111         Prepare JavaScript heap for being per-thread.
1112
1113         * Misc/WebCoreStatistics.mm:
1114         (+[WebCoreStatistics javaScriptObjectsCount]):
1115         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1116         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
1117         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1118         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
1119         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
1120         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
1121
1122 2008-06-17  Darin Adler  <darin@apple.com>
1123
1124         Reviewed by Sam.
1125
1126         * WebView/WebHTMLView.mm:
1127         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Use create instead of new
1128         to create a CSSMutableStyleDeclaration.
1129
1130 2008-06-16  Mark Rowe  <mrowe@apple.com>
1131
1132         Reviewed by Darin Adler.
1133
1134         <rdar://problem/5951874> WebHTMLHighlighter mistakenly gained two new methods, causing compile warnings
1135
1136         _pauseNullEventsForAllNetscapePlugins and _resumeNullEventsForAllNetscapePlugins ended up being declared both in
1137         WebHTMLViewInternal.h and as members of the WebHTMLHighlighter protocol in WebHTMLViewPrivate.h.  They don't belong
1138         in the protocol, but they do need to be available outside of WebKit so they're being moved to the correct location
1139         in WebHTMLViewPrivate.h and removed from WebHTMLViewInternal.h.
1140
1141         * WebView/WebHTMLView.mm:
1142         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
1143         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]):
1144         * WebView/WebHTMLViewInternal.h:
1145         * WebView/WebHTMLViewPrivate.h:
1146
1147 2008-06-15  Darin Adler  <darin@apple.com>
1148
1149         - give Frame object functions shorter names: scriptProxy() -> script(),
1150           selectionController() -> selection(), animationController() -> animation()
1151
1152         * Plugins/WebPluginController.mm:
1153         (-[WebPluginController webPlugInContainerSelectionColor]):
1154         * WebView/WebFrame.mm:
1155         (-[WebFrame _attachScriptDebugger]):
1156         (-[WebFrame _hasSelection]):
1157         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1158         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1159         (-[WebFrame _convertToNSRange:]):
1160         (-[WebFrame _convertToDOMRange:]):
1161         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1162         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
1163         (-[WebFrame _insertParagraphSeparatorInQuotedContent]):
1164         (-[WebFrame _selectedNSRange]):
1165         (-[WebFrame _selectNSRange:]):
1166         (-[WebFrame globalContext]):
1167         * WebView/WebHTMLView.mm:
1168         (-[WebHTMLView _selectedRange]):
1169         (-[WebHTMLView _hasSelection]):
1170         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
1171         (-[WebHTMLView _hasInsertionPoint]):
1172         (-[WebHTMLView _isEditable]):
1173         (-[WebHTMLView _updateFocusedAndActiveState]):
1174         (-[WebHTMLView readSelectionFromPasteboard:]):
1175         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1176         (-[WebHTMLView maintainsInactiveSelection]):
1177         (-[WebHTMLView paste:]):
1178         (isTextInput):
1179         (-[WebHTMLView inputContext]):
1180         (-[WebTextCompleteController doCompletion]):
1181         (-[WebHTMLView selectAll]):
1182         (-[WebHTMLView deselectAll]):
1183         (-[WebHTMLView selectedAttributedString]):
1184         * WebView/WebView.mm:
1185         (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
1186         (-[WebView setSelectedDOMRange:affinity:]):
1187         (-[WebView selectedDOMRange]):
1188         (-[WebView selectionAffinity]):
1189
1190 2008-06-15  Darin Adler  <darin@apple.com>
1191
1192         - rename KJS::List to KJS::ArgList
1193
1194         * WebView/WebScriptDebugger.h:
1195
1196 2008-06-15  Darin Adler  <darin@apple.com>
1197
1198         - new names for more JavaScriptCore files
1199
1200         * WebView/WebView.mm:
1201
1202 2008-06-15  Darin Adler  <darin@apple.com>
1203
1204         - new names for a few key JavaScriptCore files
1205
1206         * ForwardingHeaders/kjs/JSFunction.h: Copied from WebKit/mac/ForwardingHeaders/kjs/function.h.
1207         * ForwardingHeaders/kjs/JSObject.h: Copied from WebKit/mac/ForwardingHeaders/kjs/object.h.
1208         * ForwardingHeaders/kjs/JSString.h: Copied from WebKit/mac/ForwardingHeaders/kjs/internal.h.
1209         * ForwardingHeaders/kjs/JSValue.h: Copied from WebKit/mac/ForwardingHeaders/kjs/value.h.
1210         * ForwardingHeaders/kjs/function.h: Removed.
1211         * ForwardingHeaders/kjs/internal.h: Removed.
1212         * ForwardingHeaders/kjs/object.h: Removed.
1213         * ForwardingHeaders/kjs/value.h: Removed.
1214         * WebView/WebScriptDebugDelegate.mm:
1215
1216 2008-06-15  Darin Adler  <darin@apple.com>
1217
1218         Rubber stamped by Sam.
1219
1220         - use JS prefix and simpler names for basic JavaScriptCore types,
1221           to complement JSValue and JSObject
1222
1223         * WebView/WebView.mm:
1224         (aeDescFromJSValue):
1225
1226 2008-06-14  Darin Adler  <darin@apple.com>
1227
1228         Rubber stamped by Sam.
1229
1230         - new names for kjs_binding.h and kjs_proxy.h
1231
1232         * WebView/WebFrame.mm:
1233         * WebView/WebScriptDebugDelegate.mm:
1234         * WebView/WebView.mm:
1235
1236 2008-06-14  Darin Adler  <darin@apple.com>
1237
1238         Rubber stamped by Sam.
1239
1240         - renamed HTMLGenericFormElement to HTMLFormControlElement
1241
1242         * WebView/WebHTMLRepresentation.mm:
1243         (-[WebHTMLRepresentation elementWithName:inForm:]):
1244         (-[WebHTMLRepresentation controlsInForm:]):
1245
1246 2008-06-14  Darin Adler  <darin@apple.com>
1247
1248         Reviewed by Sam.
1249
1250         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
1251           start ref counts at 1 instead of 0 for speed
1252
1253         * WebCoreSupport/WebFrameLoaderClient.mm:
1254         (WebFrameLoaderClient::createDocumentLoader): Use create instead of new.
1255         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
1256         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
1257         conventional ones without a special case.
1258
1259         * WebView/WebDataSource.mm:
1260         (-[WebDataSource _initWithDocumentLoader:]): Changed argument to be a PassRefPtr, since
1261         this function takes ownership of the DocumentLoader.
1262         (-[WebDataSource initWithRequest:]): Use create instead of new.
1263         * WebView/WebDataSourceInternal.h: Changed _initWithDocumentLoader argument to be a
1264         PassRefPtr and also cleaned up the header a bit.
1265
1266         * WebView/WebDocumentLoaderMac.h:
1267         (WebDocumentLoaderMac::create): Added. Also made the constructor and a couple of virtual
1268         functions private.
1269
1270         * WebView/WebFrame.mm:
1271         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Use create instead
1272         of new.
1273
1274 2008-06-14  Darin Adler  <darin@apple.com>
1275
1276         Reviewed by Sam.
1277
1278         - more work on https://bugs.webkit.org/show_bug.cgi?id=17257
1279           start ref counts at 1 instead of 0 for speed
1280
1281         * WebView/WebFrame.mm:
1282         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1283         * WebView/WebPDFView.mm:
1284         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1285
1286 2008-06-13  Darin Adler  <darin@apple.com>
1287
1288         Reviewed by John Sullivan.
1289
1290         - updated for addition of FormState argument to action policy functions
1291         - added WebActionFormKey
1292
1293         * WebCoreSupport/WebFrameLoaderClient.h:
1294         * WebCoreSupport/WebFrameLoaderClient.mm:
1295         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1296         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1297         (WebFrameLoaderClient::actionDictionary):
1298         * WebKit.exp:
1299         * WebView/WebPolicyDelegate.mm:
1300         * WebView/WebPolicyDelegatePrivate.h:
1301
1302 2008-06-12  John Sullivan  <sullivan@apple.com>
1303
1304         Reviewed by Dan and Darin
1305
1306         Clear up the confusion about _close (older private method) vs -close (newer public method).
1307
1308         * WebView/WebView.mm:
1309         (-[WebView _isClosed]):
1310         simplified style
1311         (-[WebView _close]):
1312         added a comment about how clients and subclasses should use -close instead
1313         (-[WebView dealloc]):
1314         call -close instead of _close, so subclasses that override the public method will have the intended behavior
1315         (-[WebView close]):
1316         added a comment
1317         (-[WebView _windowWillClose:]):
1318         call -close instead of _close, so subclasses that override the public method will have the intended behavior
1319
1320         * WebView/WebViewPrivate.h:
1321         added a comment about how clients and subclasses should use -close instead
1322
1323 2008-06-07  Darin Adler  <darin@apple.com>
1324
1325         Reviewed by Mitz.
1326
1327         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
1328           start ref counts at 1 instead of 0 for speed
1329
1330         * History/WebHistoryItem.mm:
1331         (-[WebHistoryItem init]):
1332         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
1333         (-[WebHistoryItem initWithURL:target:parent:title:]):
1334         (-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
1335         * WebView/WebView.mm:
1336         (+[WebView _decodeData:]):
1337
1338 2008-06-03  Oliver Hunt  <oliver@apple.com>
1339
1340         Reviewed by Tim.
1341
1342         Bug 12983: Web Inspector break on the debugger keyword
1343         <https://bugs.webkit.org/show_bug.cgi?id=12983>
1344
1345         Add stubs to allow old webkit debugger interface to build.
1346
1347         * WebView/WebScriptDebugger.h:
1348         * WebView/WebScriptDebugger.mm:
1349
1350 2008-06-03  Anders Carlsson  <andersca@apple.com>
1351
1352         Reviewed by Darin.
1353
1354         <rdar://problem/5980961>
1355         
1356         In 64-bit Web Kit, converting between float and double, can cause rounding errors which in turn causes
1357         newBottom to be larger than oldBottom which is illegal.
1358         
1359         * WebView/WebHTMLView.mm:
1360         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
1361
1362 2008-06-02  Anders Carlsson  <andersca@apple.com>
1363
1364         Reviewed by Mitz.
1365
1366         Speculative fix for <rdar://problem/5661112> 
1367         CrashTracer: [USER] 49 crashes in DashboardClient at com.apple.WebCore: WebCore::RenderPart::setWidget + 62
1368         
1369         Defer loads while calling NPP_New. Some plug-ins start a run-loop inside NPP_New and finished loads could cause
1370         layouts to be triggered.
1371         
1372         * Plugins/WebBaseNetscapePluginView.mm:
1373         (-[WebBaseNetscapePluginView _createPlugin]):
1374
1375 2008-05-29  Justin Garcia  <justin.garcia@apple.com>
1376
1377         Reviewed by Darin.
1378         
1379         <rdar://problem/5949462> REGRESSION: Can't paste screen captures into Mail
1380         
1381         AppKit started putting PNG instead of PICT onto the pasteboard for screen 
1382         captures.  Added support for PNG with kUTTypePNG.  Tiger doesn't support
1383         setting and retrieving pasteboard types with UTIs, but we don't know of any
1384         applications on Tiger that put only PNG on the pasteboard.
1385
1386         * WebView/WebHTMLView.mm:
1387         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1388         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1389
1390 2008-05-29  Anders Carlsson  <andersca@apple.com>
1391
1392         Reviewed by Brady.
1393
1394         <rdar://problem/5970312> 
1395         icon file specified for stand alone web app causes crash if the icon can't be found
1396         
1397         Handle the case where iconData is null.
1398         
1399         * Misc/WebIconFetcher.mm:
1400         (WebIconFetcherClient::finishedFetchingIcon):
1401
1402 2008-05-29  Anders Carlsson  <andersca@apple.com>
1403
1404         Reviewed by Mitz.
1405
1406         <rdar://problem/5971845>
1407         https://bugs.webkit.org/show_bug.cgi?id=19313
1408         Add version member to NPCocoaEvent
1409
1410         Initialize the version member to 0 for all events.
1411         
1412         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1413         (initializeEvent):
1414         (WebNetscapePluginEventHandlerCocoa::drawRect):
1415         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
1416         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
1417         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
1418         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
1419         (WebNetscapePluginEventHandlerCocoa::focusChanged):
1420
1421 2008-05-29  Dan Bernstein  <mitz@apple.com>
1422
1423         Reviewed by Jessica Kahn.
1424
1425         - fix <rdar://problem/5965013> Page 2 does not print correctly
1426
1427         When printing, _recursiveDisplayRectIfNeededIgnoringOpacity:... and
1428         _recursiveDisplayAllDirtyWithLockFocus:... can be invoked without
1429         -viewWillDraw being sent first, which could lead to painting without
1430         valid layout. The fix is to ensure up-to-date layout in those methods
1431         when printing.
1432
1433         * WebView/WebHTMLView.mm:
1434         (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1435         (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1436
1437 2008-05-28  Anders Carlsson  <andersca@apple.com>
1438
1439         Reviewed by Jon.
1440
1441         Remove workaround, this is no longer a problem.
1442         
1443         * WebView/WebView.mm:
1444         (-[WebView _removeObjectForIdentifier:]):
1445
1446 2008-05-27  Geoffrey Garen  <ggaren@apple.com>
1447
1448         Reviewed by Tim Hatcher.
1449         
1450         Fixed https://bugs.webkit.org/show_bug.cgi?id=19183
1451         REGRESSION (r33979): Crash in DebuggerCallFrame::functionName when
1452         clicking button in returnEvent-crash.html
1453         
1454         Added implementations for willExecuteProgram and didExecuteProgram, which
1455         take care of making sure we're not hanging on to stale data.
1456
1457 2008-05-27  Timothy Hatcher  <timothy@apple.com>
1458
1459         Fixes a bug where unplugging the monitor from a video card and
1460         moving it to another video card would no longer show OpenGL plugins
1461         until you relaunched Safari.
1462
1463         <rdar://problem/5790983> Add AllowOfflineDisplays pixel format
1464         attribute to OpenGL contexts
1465
1466         Reviewed by Kevin Decker.
1467
1468         * Plugins/WebBaseNetscapePluginView.mm:
1469         (-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
1470         AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
1471         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.
1472
1473 2008-05-25  Mark Rowe  <mrowe@apple.com>
1474
1475         Reviewed by Darin Adler.
1476
1477         <rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
1478
1479         Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
1480         need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.
1481
1482         * WebView/WebFrame.mm:
1483         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
1484         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
1485         * WebView/WebFrameInternal.h:
1486         * WebView/WebFramePrivate.h:
1487
1488 2008-05-23  Timothy Hatcher  <timothy@apple.com>
1489
1490         Fix attaching and detaching the Web Inspector. This change removes
1491         the clunky animation that never looked right and was causing issues
1492         where the inspected WebView would get into a no useable state.
1493
1494         <rdar://problem/5958812> Attaching and Detaching the Web Inspector
1495         can cause the inspected WebVIew to be unusable
1496
1497         Reviewed by Adam Roben.
1498
1499         * WebCoreSupport/WebInspectorClient.mm:
1500         (-[WebInspectorWindowController close]): Removes animation code.
1501         Sets the frame directly and does a displayIfNeeded to prevent
1502         showing the Inspector in the page and in the Inspector window.
1503         (-[WebInspectorWindowController showWindow:]): Removes animation code.
1504         Sets the frame directly.
1505         (-[WebInspectorWindowController attach]): Simplified.
1506         (-[WebInspectorWindowController detach]): Ditto.
1507
1508 2008-05-22  Dan Bernstein  <mitz@apple.com>
1509
1510         Reviewed by Darin Adler.
1511
1512         - fix broken documentation of
1513           webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1514
1515         * WebView/WebUIDelegate.h: Fixed method name in HeaderDoc for
1516         -webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:
1517
1518 2008-05-22  Timothy Hatcher  <timothy@apple.com>
1519
1520         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
1521
1522         Reviewed by Adam Roben.
1523
1524         * WebCoreSupport/WebInspectorClient.mm:
1525         (-[WebInspectorWindowController showWebInspector:]):
1526         (-[WebInspectorWindowController showErrorConsole:]):
1527         (-[WebInspectorWindowController toggleDebuggingJavaScript:]):
1528         (-[WebInspectorWindowController toggleProfilingJavaScript:]):
1529         (-[WebInspectorWindowController validateUserInterfaceItem:]):
1530         * WebInspector/WebInspector.h:
1531         * WebInspector/WebInspector.mm:
1532         (-[WebInspector showConsole:]):
1533         (-[WebInspector showTimeline:]):
1534         (-[WebInspector isDebuggingJavaScript]):
1535         (-[WebInspector toggleDebuggingJavaScript:]):
1536         (-[WebInspector startDebuggingJavaScript:]):
1537         (-[WebInspector stopDebuggingJavaScript:]):
1538         (-[WebInspector isProfilingJavaScript]):
1539         (-[WebInspector toggleProfilingJavaScript:]):
1540         (-[WebInspector startProfilingJavaScript:]):
1541         (-[WebInspector stopProfilingJavaScript:]):
1542
1543 2008-05-22  Josh Aas  <joshmoz@gmail.com>
1544
1545         Reviewed by Anders.
1546
1547         <rdar://problem/5956429> 
1548         https://bugs.webkit.org/show_bug.cgi?id=19192
1549         remove NPNVpluginEventModel, fix example plugin
1550         
1551         * Plugins/WebBaseNetscapePluginView.mm:
1552         (-[WebBaseNetscapePluginView getVariable:value:]):
1553
1554 2008-05-21  Anders Carlsson  <andersca@apple.com>
1555
1556         Reviewed by Maciej.
1557
1558         Add WebIconFetcher.
1559         
1560         * Misc/WebIconFetcher.h: Added.
1561         * Misc/WebIconFetcher.mm: Added.
1562         (WebIconFetcherClient::WebIconFetcherClient):
1563         (WebIconFetcherClient::finishedFetchingIcon):
1564         (WebIconFetcherClient::setFetcher):
1565         (-[WebIconFetcher init]):
1566         (-[WebIconFetcher dealloc]):
1567         (-[WebIconFetcher finalize]):
1568         (-[WebIconFetcher cancel]):
1569         (-[WebIconFetcher _initWithIconFetcher:client:]):
1570         (+[WebIconFetcher _fetchApplicationIconForFrame:target:selector:]):
1571         * Misc/WebIconFetcherInternal.h: Added.
1572         * WebView/WebFrame.mm:
1573         (-[WebFrame fetchApplicationIcon:selector:]):
1574         * WebView/WebFramePrivate.h:
1575
1576 === End merge of squirrelfish ===
1577
1578 2008-05-21  Geoffrey Garen  <ggaren@apple.com>
1579
1580         Reviewed by Tim Hatcher.
1581         
1582         Updated for API changes from merging with trunk WebCore's new debugger.
1583
1584         * WebView/WebScriptDebugDelegate.mm:
1585         (-[WebScriptCallFrame evaluateWebScript:]): Explicitly check for an
1586         exception return, since the DebuggerCallFrame no longer automatically
1587         substitutes the exception for the return value.
1588
1589         * WebView/WebScriptDebugger.mm: Use the dynamic global object, not the
1590         lexical global object, since the debugger attaches based on dynamic
1591         global object.
1592
1593 2008-05-17  Geoffrey Garen  <ggaren@apple.com>
1594
1595         Reviewed by Oliver Hunt.
1596         
1597         Re-enabled previously disabled debugging functionality.
1598         
1599         There are two major changes from how the WebKit debugger used to work:
1600         
1601         (1) All the interesting bits are implemented down in JavaScriptCore. The
1602         debugger just calls through to KJS::DebuggerCallFrame for everything.
1603         
1604         (2) Instead of copyihng a pointer to an ExecState once, the debugger
1605         copies the DebuggerCallFrame passed to it in each callback. This is
1606         because the VM no longer maintains a fully transparent execution state
1607         to which you can hold a pointer, and the DebuggerCallFrames it vends
1608         are temporaries.
1609         
1610         Also, we NULL out a WebScriptCallFrame's DebuggerCallFrame upon return
1611         from its function. This is safer than the old method, which was to
1612         hold a stale ExecState* and hope for the best.
1613
1614 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1615
1616         Reviewed by Oliver Hunt.
1617
1618         Updated for API changes in KJS::Debugger.
1619
1620         * WebView/WebFrame.mm:
1621         (-[WebFrame _attachScriptDebugger]): Changed the order of operations to
1622         fix an ASSERT that can happen when re-entering _attachScriptDebugger.
1623
1624 2008-05-13  Geoffrey Garen  <ggaren@apple.com>
1625
1626         Reviewed by Oliver Hunt.
1627         
1628         Updated WebScriptDebugger API to accept a SourceProvider instead
1629         of a WebCore::String, to avoid copying.
1630
1631         (WebScriptDebugger::sourceParsed): Updated this function not to return
1632         a value.
1633
1634 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1635
1636         Build fix: #ifdef'd out some code that doesn't work anymore.
1637
1638 2008-04-30  Geoffrey Garen  <ggaren@apple.com>
1639
1640         Reviewed by Oliver Hunt.
1641         
1642         #ifdef'd out some debugger code that doesn't work anymore.
1643
1644         * WebView/WebScriptDebugDelegate.mm:
1645         (-[WebScriptCallFrame scopeChain]):
1646
1647 2008-04-21  Geoffrey Garen  <ggaren@apple.com>
1648
1649         Build fix.
1650
1651         * ChangeLog:
1652         * WebView/WebScriptDebugDelegate.mm:
1653         (-[WebScriptCallFrame scopeChain]):
1654
1655 2008-03-30  Geoffrey Garen  <ggaren@apple.com>
1656
1657         Reviewed by Oliver Hunt.
1658         
1659         Build fix.
1660
1661 === Start merge of squirrelfish ===
1662
1663 2008-05-21  Darin Adler  <darin@apple.com>
1664
1665         - fix build
1666
1667         * WebView/WebViewPrivate.h: Remove declaration of closeWithFastTeardown. We can add it back later
1668         if we want, but if we do, we should probably make some refinements like checking _private->closed
1669         and applicationIsTerminating.
1670
1671 2008-05-21  Darin Adler  <darin@apple.com>
1672
1673         Reviewed by Anders and Kevin Decker.
1674
1675         - fix <rdar://problem/5951130> REGRESSION: crash on quit after reopening windows from previous session
1676
1677         * WebView/WebView.mm:
1678         (-[WebViewPrivate dealloc]): Fix assertions to not complain when fast teardown is used.
1679         (-[WebView _closePluginDatabases]): Factored out some common code from both versions of close.
1680         (-[WebView _closeWithFastTeardown]): Added an underscore to this method's name, since it's internal.
1681         Streamlined the code a bit. Added a line of code to set _private->closed (this is the bug fix).
1682         (-[WebView _close]): Changed for new method name and to use _closePluginDatabases.
1683
1684 2008-05-19  Stephanie Lewis  <slewis@apple.com>
1685
1686         Reviewed by Darin.
1687     
1688         more fast teardown performance work
1689
1690         * Misc/WebDownload.m:
1691         (-[WebDownloadInternal downloadDidBegin:]):
1692         (-[WebDownloadInternal downloadDidFinish:]):
1693         (-[WebDownloadInternal download:didFailWithError:]):
1694         * WebCoreSupport/WebChromeClient.h:
1695         * WebCoreSupport/WebChromeClient.mm:
1696         (WebChromeClient::disableSuddenTermination):
1697         (WebChromeClient::enableSuddenTermination):
1698
1699 2008-05-18  Dan Bernstein  <mitz@apple.com>
1700
1701         Reviewed by Sam Weinig.
1702
1703         - fix <rdar://problem/5944596> IDNs are displayed as punycode in the authentication panel
1704
1705         * Panels/WebAuthenticationPanel.m:
1706         (-[WebAuthenticationPanel setUpForChallenge:]):
1707
1708 2008-05-16  Timothy Hatcher  <timothy@apple.com>
1709
1710         Removes WebScriptDebugServer files and related calls. This removes
1711         the hooks that Drosera uses for debugging. Now that the Web Inspector
1712         has a better debugger, we don't need these anymore.
1713
1714         Reviewed by Sam Weinig.
1715
1716         * DefaultDelegates/WebScriptDebugServer.h: Removed.
1717         * DefaultDelegates/WebScriptDebugServer.m: Removed.
1718         * DefaultDelegates/WebScriptDebugServerPrivate.h: Removed.
1719         * WebCoreSupport/WebFrameLoaderClient.mm:
1720         * WebKit.exp:
1721         * WebView/WebScriptDebugDelegate.mm:
1722         * WebView/WebScriptDebugger.mm:
1723         (WebScriptDebugger::sourceParsed):
1724         (WebScriptDebugger::callEvent):
1725         (WebScriptDebugger::atStatement):
1726         (WebScriptDebugger::returnEvent):
1727         (WebScriptDebugger::exception):
1728         * WebView/WebView.mm:
1729         (-[WebView _commonInitializationWithFrameName:groupName:]):
1730         * WebView/WebViewPrivate.h:
1731
1732 2008-05-16  Brady Eidson  <beidson@apple.com>
1733
1734         Reviewed by Anders
1735
1736         <rdar://problem/5942616> - Need to standardize LocalStorage persistence path
1737
1738         Took the opportunity to touch up another pref that needs the same standardization.
1739         That pref is currently not in use on Mac.
1740
1741         * WebView/WebPreferences.m:
1742         (-[WebPreferences _setFTPDirectoryTemplatePath:]):
1743         (-[WebPreferences _localStorageDatabasePath]):
1744         (-[WebPreferences _setLocalStorageDatabasePath:]):
1745         (-[WebPreferences _ftpDirectoryTemplatePath]):
1746
1747 2008-05-16  Chris Fleizach  <cfleizach@apple.com>
1748
1749         Reviewed by Alice Liu
1750
1751         <rdar://problem/5710317> REGRESSION:Selecting ranges of text should be possible using the keyboard (15310)
1752
1753         * WebView/WebFrame.mm:
1754         (-[WebFrame _accessibilityTree]):
1755
1756 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1757         
1758         fix mac build
1759
1760         * WebView/WebView.mm:
1761         (-[WebView closeWithFastTeardown]):
1762
1763 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1764
1765         Reviewed by Anders.
1766
1767         Turn on fast teardown.  I added a preference for using full teardown because 
1768         the LEAKS output will be useless without a full teardown.  
1769
1770         preference for fullteardown
1771         * WebView/WebPreferenceKeysPrivate.h:
1772         * WebView/WebPreferences.m:
1773         (-[WebPreferences setFullDocumentTeardownEnabled:]):
1774         (-[WebPreferences fullDocumentTeardownEnabled]):
1775         * WebView/WebPreferencesPrivate.h:
1776         
1777         on application quit dispatch unload events and destroy plugins then exit
1778         * WebView/WebView.mm:
1779         (-[WebView closeWithFastTeardown]):
1780         (-[WebView _close]):
1781         * WebView/WebViewPrivate.h:
1782
1783 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1784
1785         Reviewed by Anders.
1786
1787         get the pending frame unload count from WebCore
1788
1789         * WebView/WebFrame.mm:
1790         (-[WebFrame _pendingFrameUnloadEventCount]):
1791         * WebView/WebFramePrivate.h:
1792
1793 2008-05-15  John Sullivan  <sullivan@apple.com>
1794
1795         Reviewed by Kevin Decker
1796         
1797         - fixed <rdar://problem/5940275> Inspector highlighting moves to bottom-left corner of 
1798           screen when new tab appears
1799           
1800         The highlight should go away entirely, but this simple patch just makes it not jump away.
1801         The issue with it not going away entirely is harder to fix and covered by <rdar://problem/5322306>
1802
1803         * WebInspector/WebNodeHighlight.m:
1804         (-[WebNodeHighlight _repositionHighlightWindow]):
1805         Bail out if target view isn't in a window
1806
1807 2008-05-15  Stephanie Lewis  <slewis@apple.com>
1808
1809         Reviewed by Anders.
1810
1811         Track views that contain plugin instances so that they can be destroyed at application
1812         quit without walking the entire document tree.
1813
1814         Add/Remove Netscape plugin views from instance list.  Start/stop are when netscape
1815         plugins are created and destroyed
1816         * Plugins/WebBaseNetscapePluginView.mm:
1817         (-[WebBaseNetscapePluginView start]):
1818         (-[WebBaseNetscapePluginView stop]):
1819  
1820         Add/remove WebKit plugin views from instance list
1821         * Plugins/WebPluginController.mm:
1822         (-[WebPluginController addPlugin:]):
1823         (-[WebPluginController destroyPlugin:]):
1824         (-[WebPluginController destroyAllPlugins]):
1825
1826         Add a set of views with plugin instances to the WebPluginDatabase
1827         * Plugins/WebPluginDatabase.h:
1828         * Plugins/WebPluginDatabase.mm:
1829         (-[WebPluginDatabase init]):
1830         (-[WebPluginDatabase dealloc]):
1831         (-[WebPluginDatabase addPluginInstanceView:]):
1832         (-[WebPluginDatabase removePluginInstanceView:]):
1833         (-[WebPluginDatabase removePluginInstanceViewsFor:]):
1834         (-[WebPluginDatabase destroyAllPluginInstanceViews]):
1835         
1836         Handle cases where plugin views are detached before the plugin is destroyed.
1837         * WebCoreSupport/WebFrameLoaderClient.mm:
1838         (WebFrameLoaderClient::detachedFromParent2):
1839         (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
1840         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1841
1842         Add plugin instances to the set in the WebPluginDatabase by way of the WebView
1843         * WebView/WebHTMLView.mm:
1844         (-[WebHTMLView _destroyAllWebPlugins]):
1845         * WebView/WebHTMLViewInternal.h:
1846         * WebView/WebView.mm:
1847         (-[WebView addPluginInstanceView:]):
1848         (-[WebView removePluginInstanceView:]):
1849         (-[WebView removePluginInstanceViewsFor:]):
1850         * WebView/WebViewInternal.h:
1851
1852 2008-05-15  Brady Eidson  <beidson@apple.com>
1853
1854         Reviewed by Tim Hatcher
1855
1856         Until the settings/preferences equation can be reworked, we'll need to manually set the local storage path
1857         before setting the page group of the new page.
1858         
1859         * WebView/WebView.mm:
1860         (-[WebView _commonInitializationWithFrameName:groupName:]): Set the LocalStorage path 
1861           immediately after creating the page so it is in place for initializing the LocalStorageThread
1862
1863 2008-05-15  Timothy Hatcher  <timothy@apple.com>
1864
1865         Fixes the bug where the Web Inspector would flash white while resizing.
1866         This was cause by deferring the window creation.
1867
1868         <rdar://problem/5873549> REGRESSION: Inspector flickers horribly while resizing (17979)
1869
1870         Reviewed by Darin Adler.
1871
1872         * WebCoreSupport/WebInspectorClient.mm:
1873         (-[WebInspectorWindowController window]): Don't defer the window creation.
1874
1875 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
1876
1877         Tiger build fix.
1878
1879         * Misc/WebNSAttributedStringExtras.mm: Import WebTypesInternal.h for NSUInteger.
1880
1881 2008-05-15  Adele Peterson  <adele@apple.com>
1882
1883         Reviewed and landed by Alexey.
1884
1885         Use TextIterator in +[NSAttributedString _web_attributedStringFromRange:].
1886
1887         * Misc/WebNSAttributedStringExtras.mm:
1888         (+[NSAttributedString _web_attributedStringFromRange:]):
1889
1890 2008-05-14  Eric Seidel  <eric@webkit.org>
1891
1892         Reviewed by Oliver.
1893
1894         Add missing NULL check to match rest of file, this was found by the editing fuzzer.
1895
1896         * WebView/WebResource.mm:
1897         (-[WebResource data]):
1898
1899 2008-05-14  Alexey Proskuryakov  <ap@webkit.org>
1900
1901         Reviewed by Dan Bernstein.
1902
1903         NPP_ValidAttributesForMarkedText should return NSArray*, not NSArray.
1904
1905         * Plugins/nptextinput.h:
1906
1907 2008-05-13  Anders Carlsson  <andersca@apple.com>
1908
1909         Reviewed by Sam.
1910
1911         Don't empty the application cache in _setCacheModel, since it will be called during initialization.
1912         Instead, do it in [WebCache empty].
1913         
1914         * Misc/WebCache.mm:
1915         (+[WebCache empty]):
1916         * WebView/WebView.mm:
1917         (+[WebView _setCacheModel:]):
1918
1919 2008-05-13  chris fleizach  <cfleizach@apple.com>
1920
1921         Reviewed by Beth Dakin
1922
1923         <rdar://problem/4780592> WebKit application has its window announced as HTML content
1924
1925         * WebCoreSupport/WebViewFactory.mm:
1926         (-[WebViewFactory AXWebAreaText]):
1927
1928 2008-05-13  Timothy Hatcher  <timothy@apple.com>
1929
1930         Fixes a crash seen in Xcode where CallUIDelegateReturningBoolean
1931         was referencing a nil WebView under validateUserInterfaceItem.
1932         The validateUserInterfaceItem methods was being called at a time
1933         when the WebHTMLView is being torndown.
1934
1935         <rdar://problem/5806229> A crash occurs at CallUIDelegateReturningBoolean()
1936         while mousing down on menu bar after Xcode News window is opened
1937
1938         Reviewed by Ada Chan.
1939
1940         * WebView/WebHTMLView.mm:
1941         (-[WebHTMLView validateUserInterfaceItem:]): NULL check the WebView and
1942         return NO when it is nil. Adds a comment.
1943         * WebView/WebPDFView.mm:
1944         (-[WebPDFView validateUserInterfaceItem:]): Ditto.
1945
1946 2008-05-13  Mark Rowe  <mrowe@apple.com>
1947
1948         Reviewed by John Sullivan.
1949
1950         <rdar://problem/5926425> HIWebViewCreateWithClass declared as API in HIWebView.h but never exported from WebKit.framework
1951
1952         * Carbon/HIWebView.h: Remove HIWebViewCreateWithClass.
1953         * Carbon/HIWebView.m: Ditto.
1954         (HIWebViewCreate):
1955         (HIWebViewConstructor):
1956
1957 2008-05-12  Dan Bernstein  <mitz@apple.com>
1958
1959         Reviewed by Ada Chan.
1960
1961         - WebKit/mac changes for https://bugs.webkit.org/show_bug.cgi?id=17097
1962           <rdar://problem/5715471> CGFontRefs (and HFONTs on Windows) leak because FontCache grows without bound
1963
1964         Added font cache statistics and a function to purge inactive font data.
1965
1966         * Misc/WebCoreStatistics.h:
1967         * Misc/WebCoreStatistics.mm:
1968         (+[WebCoreStatistics cachedFontDataCount]):
1969         (+[WebCoreStatistics cachedFontDataInactiveCount]):
1970         (+[WebCoreStatistics purgeInactiveFontData]):
1971         (+[WebCoreStatistics glyphPageCount]):
1972
1973 2008-05-12  Mark Rowe  <mrowe@apple.com>
1974
1975         Reviewed by Tim Hatcher.
1976
1977         Decorate some deprecated delegate methods with the availability macros.
1978
1979         The compiler doesn't appear to warn if a delegate implements these methods, but using the availability
1980         macros is good for consistency and documentation.
1981
1982         * WebView/WebFrameLoadDelegate.h:
1983         * WebView/WebUIDelegate.h:
1984
1985 2008-05-12  Mark Rowe  <mrowe@apple.com>
1986
1987         Reviewed by Tim Hatcher.
1988
1989         <rdar://problem/5835604> Deprecate HIWebView
1990
1991         Use of HIWebView is deprecated in favor of embedding a WebView in a HICocoaView.
1992
1993         * Carbon/CarbonUtils.h: Include the availability macro header and decorate the functions appropriately.
1994         * Carbon/HIWebView.h: Ditto.
1995
1996 2008-05-12  Kevin Decker  <kdecker@apple.com>
1997
1998         Reviewed by Anders.
1999
2000         Fixed: <rdar://problem/5840884>_recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined
2001         
2002         Re-added these SPI methods because they are needed by some clients. They were accidentally removed
2003         in changeset <http://trac.webkit.org/changeset/31028>
2004         
2005         * Plugins/WebBaseNetscapePluginView.h: Added stopTimers, restartTimers to the header.
2006         * WebView/WebFrame.mm:
2007         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): Re-addd.
2008         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): Ditto.
2009         * WebView/WebFrameInternal.h: Ditto.
2010         * WebView/WebHTMLView.mm: Ditto.
2011         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Ditto.
2012         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2013         * WebView/WebHTMLViewInternal.h: Ditto.
2014         * WebView/WebHTMLViewPrivate.h: Ditto.
2015
2016 2008-05-12  Anders Carlsson  <andersca@apple.com>
2017
2018         Reviewed by Alexey.
2019
2020         Empty the application cache when changing the cache model.
2021         
2022         * WebView/WebView.mm:
2023         (+[WebView _setCacheModel:]):
2024
2025 2008-05-12  Anders Carlsson  <andersca@apple.com>
2026
2027         Reviewed by Oliver.
2028
2029         <rdar://problem/5774495> Make Unicode text input possible in Netscape-style plug-ins
2030         
2031         * Plugins/WebBaseNetscapePluginView.h:
2032         * Plugins/WebBaseNetscapePluginView.mm:
2033         (-[WebBaseNetscapePluginView start]):
2034         Get the plug-in text input vtable pointer.
2035         
2036         (-[WebBaseNetscapePluginView stop]):
2037         Set the plug-in text input vtable pointer to 0.
2038         
2039         (-[WebBaseNetscapePluginView inputContext]):
2040         Return 0 for Carbon plug-ins since we don't want Cocoa to handle text input for them.
2041         
2042         (-[WebBaseNetscapePluginView hasMarkedText]):        
2043         (-[WebBaseNetscapePluginView insertText:]):
2044         (-[WebBaseNetscapePluginView markedRange]):
2045         (-[WebBaseNetscapePluginView selectedRange]):
2046         (-[WebBaseNetscapePluginView setMarkedText:selectedRange:]):
2047         (-[WebBaseNetscapePluginView unmarkText]):
2048         (-[WebBaseNetscapePluginView validAttributesForMarkedText]):
2049         (-[WebBaseNetscapePluginView attributedSubstringFromRange:]):
2050         (-[WebBaseNetscapePluginView characterIndexForPoint:]):
2051         (-[WebBaseNetscapePluginView doCommandBySelector:]):
2052         (-[WebBaseNetscapePluginView firstRectForCharacterRange:]):
2053         (-[WebBaseNetscapePluginView conversationIdentifier]):
2054         Implement NSTextInput and call into the plug-in text input vtable.
2055         
2056         (browserTextInputFuncs):
2057         New method which returns the browser input vtable.
2058         
2059         (-[WebBaseNetscapePluginView getVariable:value:]):
2060         Support getting the browser input vtable pointer.
2061         
2062         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
2063         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2064         (WebNetscapePluginEventHandlerCocoa::keyDown):
2065         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2066         If the plug-in returns 0 when a NPCocoaEventKeyDown is passed to NPP_HandleEvent,
2067         it means that the event should be passed on to the input manager.
2068          
2069         * Plugins/npapi.mm:
2070         (NPN_MarkedTextAbandoned):
2071         (NPN_MarkedTextSelectionChanged):
2072         Add implementations of browser input method methods.
2073         
2074         * Plugins/nptextinput.h: Added.
2075         Add file with new text input API.
2076
2077 2008-05-12  Alexey Proskuryakov  <ap@webkit.org>
2078
2079         Roll out recent  threading changes (r32807, r32810, r32819, r32822) to simplify
2080         SquirrelFish merging.
2081
2082         * Misc/WebCoreStatistics.mm:
2083         (+[WebCoreStatistics javaScriptObjectsCount]):
2084         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2085         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2086         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2087         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2088         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2089         * WebView/WebScriptDebugDelegate.mm:
2090         (-[WebScriptCallFrame evaluateWebScript:]):
2091
2092 2008-05-07  Anders Carlsson  <andersca@apple.com>
2093
2094         Reviewed by Mitz.
2095
2096         REGRESSION (3.1.1-TOT): Arrow keys are sticky in Google Maps street view
2097         https://bugs.webkit.org/show_bug.cgi?id=18880
2098         <rdar://problem/5909513>
2099
2100         Stop suspending key up events before calling handleEvent.
2101         
2102         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2103         (WebNetscapePluginEventHandlerCarbon::sendEvent):
2104
2105 2008-05-06  Stephanie Lewis  <slewis@apple.com>
2106
2107         Reviewed by Andersca.
2108
2109         prepare for plugin fast teardown work - make WebPluginDatabase a objective C++ file.
2110
2111         * Plugins/WebPluginDatabase.m: Removed.
2112         * Plugins/WebPluginDatabase.mm: Copied from WebKit/mac/Plugins/WebPluginDatabase.m.
2113         * Plugins/npapi.m: Removed.
2114         * Plugins/npapi.mm: Copied from WebKit/mac/Plugins/npapi.m.
2115
2116 2008-05-06  Anders Carlsson  <andersca@apple.com>
2117
2118         Reviewed by Darin.
2119
2120         Initialize numArchs to 0.
2121         
2122         * Plugins/WebBasePluginPackage.m:
2123         (-[WebBasePluginPackage isNativeLibraryData:]):
2124
2125 2008-05-06  Anders Carlsson  <andersca@apple.com>
2126
2127         Reviewed by Darin.
2128
2129         Add implementation of NPN_PopUpContextMenu.
2130         
2131         * Plugins/WebBaseNetscapePluginView.mm:
2132         (-[WebBaseNetscapePluginView popUpContextMenu:]):
2133         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2134         * Plugins/WebNetscapePluginPackage.m:
2135         (-[WebNetscapePluginPackage load]):
2136         * Plugins/npapi.m:
2137         (NPN_PopUpContextMenu):
2138
2139 2008-05-06  Anders Carlsson  <andersca@apple.com>
2140
2141         Fix typo (don't read random memory).
2142         
2143         * Plugins/WebBasePluginPackage.m:
2144         (-[WebBasePluginPackage isNativeLibraryData:]):
2145
2146 2008-05-05  Anders Carlsson  <andersca@apple.com>
2147
2148         Reviewed by Darin.
2149
2150         Change the isNativeLibraryData: method to handle universal binaries.
2151         
2152         * Plugins/WebBasePluginPackage.m:
2153         (swapIntsInHeader):
2154         (-[WebBasePluginPackage isNativeLibraryData:]):
2155
2156 2008-05-06  Brady Eidson  <beidson@apple.com>
2157
2158         Reviewed by Darin Adler
2159
2160         Preparation for upcoming work making LocalStorage persistent.
2161
2162         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
2163
2164         * WebView/WebView.mm:
2165         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
2166
2167 2008-05-05  Sam Weinig  <sam@webkit.org>
2168
2169         Reviewed by Darin Adler.
2170
2171         Fix for <rdar://problem/5884383>
2172         Escape look-a-like characters from the the entire url.
2173
2174         * Misc/WebNSURLExtras.mm:
2175         (escapeUnsafeCharacters):
2176         (-[NSURL _web_userVisibleString]):
2177
2178 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
2179
2180         Reviewed by Darin.
2181         
2182         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
2183
2184         * WebView/WebView.mm:
2185         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
2186         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
2187         the two interfere.
2188
2189 2008-05-05  Sam Weinig  <sam@webkit.org>
2190
2191         Reviewed by Tim Hatcher.
2192
2193         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
2194
2195         * WebCoreSupport/WebInspectorClient.mm:
2196         (WebInspectorClient::localizedStringsURL):
2197
2198 2008-05-05  Anders Carlsson  <andersca@apple.com>
2199
2200         Reviewed by Jess.
2201
2202         Apparently preflighting can cause hangs for some reason. Revert this for now.
2203         
2204         * Plugins/WebNetscapePluginPackage.m:
2205         (-[WebNetscapePluginPackage _initWithPath:]):
2206         * Plugins/WebPluginPackage.m:
2207         (-[WebPluginPackage initWithPath:]):
2208
2209 2008-05-05  Darin Adler  <darin@apple.com>
2210
2211         Reviewed by Mitz.
2212
2213         - https://bugs.webkit.org/show_bug.cgi?id=18789
2214           fix some shouldCloseWithWindow edge cases
2215
2216         * WebView/WebView.mm:
2217         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
2218         NSWindowWillCloseNotification if the view was moved out of the window but still
2219         had that window set as the host window. Also make sure this function doesn't do
2220         anything if the WebView is already closed.
2221         (-[WebView setHostWindow:]): Ditto.
2222
2223 2008-05-04  David Kilzer  <ddkilzer@apple.com>
2224
2225         Make parameters match for WebChromeClient::addMessageToConsole()
2226
2227         Reviewed by John.
2228
2229         * WebCoreSupport/WebChromeClient.h:
2230         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
2231         to sourceURL to match implementation in WebChromeClient.mm.
2232
2233 2008-05-02  Anders Carlsson  <andersca@apple.com>
2234
2235         Reviewed by Mark.
2236
2237         Various Cocoa event model and 64-bit plug-in fixes.
2238         
2239         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2240         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2241         Set click count.
2242         
2243         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2244         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2245         Don't try to get the mouse location for keyboard events.
2246         
2247         * Plugins/WebPluginPackage.m:
2248         (-[WebPluginPackage initWithPath:]):
2249         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
2250
2251 2008-05-02  Anders Carlsson  <andersca@apple.com>
2252
2253         Reviewed by Sam.
2254
2255         The event union is now named.
2256         
2257         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2258         (WebNetscapePluginEventHandlerCocoa::drawRect):
2259         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2260         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2261         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2262         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
2263         (WebNetscapePluginEventHandlerCocoa::focusChanged):
2264
2265 2008-05-02  Anders Carlsson  <andersca@apple.com>
2266
2267         Reviewed by Mark.
2268
2269         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
2270         
2271         Call preflightAndReturnError on the bundle, which will check if any of the architectures
2272         in the bundle match the current architecture.
2273         
2274         * Plugins/WebNetscapePluginPackage.m:
2275         (-[WebNetscapePluginPackage _initWithPath:]):
2276
2277 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
2278
2279         Reviewed by Geoffrey Garen.
2280
2281         https://bugs.webkit.org/show_bug.cgi?id=18826
2282         Make JavaScript heap per-thread
2283
2284         * Misc/WebCoreStatistics.mm:
2285         (+[WebCoreStatistics javaScriptObjectsCount]):
2286         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
2287         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
2288         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
2289         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
2290         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
2291         Replaced static Collector calls with calls to a current thread's instance.
2292
2293         * WebView/WebScriptDebugDelegate.mm:
2294         (-[WebScriptCallFrame evaluateWebScript:]):
2295         Pass ExecState to jsString().
2296
2297 2008-05-01  Anders Carlsson  <andersca@apple.com>
2298
2299         Reviewed by Mark.
2300
2301         64-bit NPAPI plugin build fixes.
2302         
2303         * Plugins/WebBaseNetscapePluginView.mm:
2304         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2305         (-[WebBaseNetscapePluginView updateAndSetWindow]):
2306         (-[WebBaseNetscapePluginView start]):
2307         (-[WebBaseNetscapePluginView windowBecameKey:]):
2308         * Plugins/WebNetscapeDeprecatedFunctions.c:
2309         * Plugins/WebNetscapeDeprecatedFunctions.h:
2310         * Plugins/WebNetscapePluginEventHandler.mm:
2311         (WebNetscapePluginEventHandler::create):
2312         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2313         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2314         * Plugins/WebPluginDatabase.m:
2315         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2316
2317 2008-05-01  Anders Carlsson  <andersca@apple.com>
2318
2319         Reviewed by Tim.
2320
2321         Remove duplicate npfunctions.h header from WebKit.
2322
2323         * MigrateHeaders.make:
2324         Migrate npfunctions.h
2325         
2326         * Plugins/npfunctions.h: Removed.
2327
2328 2008-05-01  Anders Carlsson  <andersca@apple.com>
2329
2330         Reviewed by John.
2331         
2332         Add null checks for the event handler.
2333         
2334         * Plugins/WebBaseNetscapePluginView.mm:
2335         (-[WebBaseNetscapePluginView stopTimers]):
2336         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2337
2338 2008-05-01  Anders Carlsson  <andersca@apple.com>
2339
2340         Fix 64-bit build.
2341         
2342         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
2343         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2344         * WebCoreSupport/WebFrameLoaderClient.mm:
2345
2346 2008-05-01  Anders Carlsson  <andersca@apple.com>
2347
2348         Fix build.
2349         
2350         * Plugins/npfunctions.h:
2351
2352 2008-05-01  Anders Carlsson  <andersca@apple.com>
2353
2354         Reviewed by Adam.
2355
2356         Forward mouse move events to the Netscape plug-in view.
2357         
2358         * Plugins/WebBaseNetscapePluginView.h:
2359         * Plugins/WebBaseNetscapePluginView.mm:
2360         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2361         New method that just calls the current event handler.
2362         
2363         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2364         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2365         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
2366         don't work on it so don't call them.
2367         
2368         * WebCoreSupport/WebFrameLoaderClient.mm:
2369         (NetscapePluginWidget::NetscapePluginWidget):
2370         New Widget subclass to be used for Netscape plug-ins.
2371         
2372         (NetscapePluginWidget::handleEvent):
2373         Forward NSMouseMoved events to the plug-in.
2374         
2375         (WebFrameLoaderClient::createPlugin):
2376         Wrap the plug-in view in a NetscapePluginWidget.
2377
2378 2008-05-01  Alp Toker  <alp@nuanti.com>
2379
2380         Rubber-stamped by Anders.
2381
2382         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
2383         npapi.h.
2384
2385         Additional fix to use same signedness in npapi.h and Mac for the
2386         interval parameter.
2387
2388         * Plugins/WebBaseNetscapePluginView.h:
2389         * Plugins/WebBaseNetscapePluginView.mm:
2390         (PluginTimer::PluginTimer):
2391         (-[WebBaseNetscapePluginView stopTimers]):
2392         (-[WebBaseNetscapePluginView restartTimers]):
2393         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2394         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2395         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2396         * Plugins/npapi.m:
2397         (NPN_ScheduleTimer):
2398         (NPN_UnscheduleTimer):
2399         * Plugins/npfunctions.h:
2400
2401 2008-04-30  Anders Carlsson  <andersca@apple.com>
2402
2403         Reviewed by Adam.
2404
2405         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
2406         
2407         * Plugins/WebBaseNetscapePluginView.h:
2408         * Plugins/WebBaseNetscapePluginView.mm:
2409         (PluginTimer::PluginTimer):
2410         (PluginTimer::start):
2411         (PluginTimer::fired):
2412         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2413         (-[WebBaseNetscapePluginView stopTimers]):
2414         (-[WebBaseNetscapePluginView restartTimers]):
2415         (-[WebBaseNetscapePluginView scrollWheel:]):
2416         (-[WebBaseNetscapePluginView flagsChanged:]):
2417         (-[WebBaseNetscapePluginView start]):
2418         (-[WebBaseNetscapePluginView eventModel]):
2419         (-[WebBaseNetscapePluginView fini]):
2420         (-[WebBaseNetscapePluginView getVariable:value:]):
2421         (-[WebBaseNetscapePluginView setVariable:value:]):
2422         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
2423         (-[WebBaseNetscapePluginView unscheduleTimer:]):
2424         * Plugins/WebBaseNetscapePluginViewInternal.h:
2425         * Plugins/WebBaseNetscapePluginViewPrivate.h:
2426         * Plugins/WebNetscapePluginEventHandler.h:
2427         * Plugins/WebNetscapePluginEventHandler.mm:
2428         (WebNetscapePluginEventHandler::create):
2429         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2430         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2431         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
2432         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
2433         (WebNetscapePluginEventHandlerCarbon::platformWindow):
2434         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
2435         (WebNetscapePluginEventHandlerCocoa::startTimers):
2436         (WebNetscapePluginEventHandlerCocoa::stopTimers):
2437         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
2438         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
2439         (WebNetscapePluginEventHandlerCocoa::drawRect):
2440         (WebNetscapePluginEventHandlerCocoa::mouseDown):
2441         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
2442         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
2443         (WebNetscapePluginEventHandlerCocoa::mouseExited):
2444         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
2445         (WebNetscapePluginEventHandlerCocoa::mouseUp):
2446         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
2447         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
2448         (WebNetscapePluginEventHandlerCocoa::keyDown):
2449         (WebNetscapePluginEventHandlerCocoa::keyUp):
2450         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
2451         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
2452         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
2453         (WebNetscapePluginEventHandlerCocoa::focusChanged):
2454         (WebNetscapePluginEventHandlerCocoa::platformWindow):
2455         (WebNetscapePluginEventHandlerCocoa::sendEvent):
2456         * Plugins/WebNetscapePluginPackage.m:
2457         (-[WebNetscapePluginPackage load]):
2458         * Plugins/npapi.m:
2459         (NPN_ScheduleTimer):
2460         (NPN_UnscheduleTimer):
2461         * Plugins/npfunctions.h:
2462
2463 2008-04-30  Brady Eidson  <beidson@apple.com>
2464
2465         Fix my WebPreferences revert check-in
2466
2467         * WebView/WebView.mm:
2468         (-[WebView _preferencesChangedNotification:]):
2469
2470 2008-04-30  Brady Eidson  <beidson@apple.com>
2471
2472         Rubberstamped by John Sullivan
2473
2474         Revert the remainder of my original preferences changes from last week.
2475         They caused a massive PLT regression (too many notifications being sent out
2476         or listened to that weren't previously) and it's not in my schedule to refine
2477         the preferences code instead of working on my feature!
2478
2479         * WebView/WebView.mm:
2480         (-[WebView _updateSettingsFromPreferences:]):
2481         (-[WebView _commonInitializationWithFrameName:groupName:]):
2482
2483 2008-04-30  Anders Carlsson  <andersca@apple.com>
2484
2485         Fix the 64-bit build.
2486         
2487         * Plugins/WebNetscapePluginEventHandler.h:
2488         * Plugins/WebNetscapePluginEventHandler.mm:
2489         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
2490         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2491
2492 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
2493
2494         BUILD FIX for Release build.
2495
2496         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2497         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
2498         separately so the compiler doesn't complain about an unused variable.
2499         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
2500
2501 2008-04-29  Anders Carlsson  <andersca@apple.com>
2502
2503         Reviewed by Adam.
2504
2505         Refactor the Carbon event handling code out into a separate class in preparation for adding
2506         the Cocoa event handling code.
2507         
2508         * Plugins/WebBaseNetscapePluginView.h:
2509         * Plugins/WebBaseNetscapePluginView.mm:
2510         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
2511         (-[WebBaseNetscapePluginView sendActivateEvent:]):
2512         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
2513         (-[WebBaseNetscapePluginView stopTimers]):
2514         (-[WebBaseNetscapePluginView restartTimers]):
2515         (-[WebBaseNetscapePluginView setHasFocus:]):
2516         (-[WebBaseNetscapePluginView mouseDown:]):
2517         (-[WebBaseNetscapePluginView mouseUp:]):
2518         (-[WebBaseNetscapePluginView mouseEntered:]):
2519         (-[WebBaseNetscapePluginView mouseExited:]):
2520         (-[WebBaseNetscapePluginView mouseDragged:]):
2521         (-[WebBaseNetscapePluginView keyUp:]):
2522         (-[WebBaseNetscapePluginView keyDown:]):
2523         (-[WebBaseNetscapePluginView cut:]):
2524         (-[WebBaseNetscapePluginView copy:]):
2525         (-[WebBaseNetscapePluginView paste:]):
2526         (-[WebBaseNetscapePluginView selectAll:]):
2527         (-[WebBaseNetscapePluginView start]):
2528         (-[WebBaseNetscapePluginView stop]):
2529         (-[WebBaseNetscapePluginView fini]):
2530         (-[WebBaseNetscapePluginView drawRect:]):
2531         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
2532         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
2533         (-[WebBaseNetscapePluginView windowBecameKey:]):
2534         (-[WebBaseNetscapePluginView windowResignedKey:]):
2535         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
2536         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
2537         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
2538         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
2539         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2540         (-[WebBaseNetscapePluginView _viewHasMoved]):
2541         * Plugins/WebBaseNetscapePluginViewInternal.h:
2542         * Plugins/WebNetscapePluginEmbeddedView.h:
2543         * Plugins/WebNetscapePluginEventHandler.h: Added.
2544         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
2545         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
2546         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
2547         * Plugins/WebNetscapePluginEventHandler.mm: Added.
2548         (WebNetscapePluginEventHandler::create):
2549         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
2550         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
2551         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
2552         (getCarbonEvent):
2553         (modifiersForEvent):
2554         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
2555         (WebNetscapePluginEventHandlerCarbon::drawRect):
2556         (WebNetscapePluginEventHandlerCarbon::mouseDown):
2557         (WebNetscapePluginEventHandlerCarbon::mouseUp):
2558         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
2559         (WebNetscapePluginEventHandlerCarbon::mouseExited):
2560         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
2561         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
2562         (WebNetscapePluginEventHandlerCarbon::keyDown):
2563         (keyMessageForEvent):
2564         (WebNetscapePluginEventHandlerCarbon::keyUp):
2565         (WebNetscapePluginEventHandlerCarbon::focusChanged):
2566         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
2567         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
2568         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
2569         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
2570         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
2571         (WebNetscapePluginEventHandlerCarbon::startTimers):
2572         (WebNetscapePluginEventHandlerCarbon::stopTimers):
2573         (WebNetscapePluginEventHandlerCarbon::sendEvent):
2574
2575 2008-04-29  Mark Rowe  <mrowe@apple.com>
2576
2577         Reviewed by David Harrison.
2578
2579         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
2580
2581         * WebKit.exp:
2582         * WebView/WebDynamicScrollBarsView.h:
2583         * WebView/WebDynamicScrollBarsView.m:
2584
2585 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
2586
2587         Reviewed by Darin.
2588
2589         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
2590
2591         * WebCoreSupport/WebChromeClient.h:
2592         * WebCoreSupport/WebChromeClient.mm:
2593         * WebView/WebClipView.m:
2594         (-[WebClipView scrollWheel:]):
2595         * WebView/WebHTMLView.mm:
2596         (-[WebHTMLView addMouseMovedObserver]):
2597         (-[WebHTMLView removeMouseMovedObserver]):
2598         (-[WebHTMLView acceptsFirstMouse:]):
2599         * WebView/WebUIDelegatePrivate.h:
2600         * WebView/WebView.mm:
2601         (-[WebViewPrivate init]):
2602         * WebView/WebViewPrivate.h:
2603
2604 2008-04-28  Rob Buis  <buis@kde.org>
2605
2606         Reviewed by Maciej.
2607
2608         Build fix for Tiger.
2609
2610         * WebView/WebView.mm:
2611         (WebKitInitializeApplicationCachePathIfNecessary):
2612
2613 2008-04-28  Adele Peterson  <adele@apple.com>
2614
2615         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
2616
2617         WebKit part of fix for <rdar://problem/3709505>
2618         Safari should have a way to upload bundles from the file upload control (as zip)
2619
2620         Added UIDelegate methods to let the application handle generating replacement files for uploads.
2621         In this case, Safari will create archived files for bundles so they can be uploaded properly.
2622
2623         * DefaultDelegates/WebDefaultUIDelegate.m:
2624         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
2625         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
2626         * WebCoreSupport/WebChromeClient.h:
2627         * WebCoreSupport/WebChromeClient.mm:
2628         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
2629         (WebChromeClient::generateReplacementFile):
2630         * WebView/WebUIDelegatePrivate.h:
2631
2632 2008-04-28  Anders Carlsson  <andersca@apple.com>
2633
2634         Reviewed by Sam, Mark, Adele and Darin.
2635
2636         Initialize the application cache path.
2637         
2638         * WebView/WebView.mm:
2639         (WebKitInitializeApplicationCachePathIfNecessary):
2640         (-[WebView _commonInitializationWithFrameName:groupName:]):
2641
2642 2008-04-28  Alice Liu  <alice.liu@apple.com>
2643
2644         Reviewed by Darin.
2645
2646         Fix <rdar://problem/4911289> Add tabindex property to all children 
2647         of HTMLElement (7138)
2648         http://bugs.webkit.org/show_bug.cgi?id=7138
2649
2650         * MigrateHeaders.make:
2651         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
2652         because now that focus() has been moved to DOMHTMLElement.h, these
2653         files are no longer needed.
2654
2655 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2656
2657         Reviewed by Darin.
2658
2659         Fix run-webkit-tests --threading
2660         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
2661         Proxy server issue in Sunday's Nightly
2662
2663         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
2664         only done from icon database code, which is not robust enough.
2665
2666 2008-04-20 Adam Barth <hk9565@gmail.com>
2667
2668         Reviewed by Adam Roben and Sam Weinig.
2669
2670         Updated WebSecurityOrigin to match new SecurityOrigin API.
2671
2672         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
2673
2674         * Storage/WebSecurityOrigin.mm:
2675         (-[WebSecurityOrigin host]):
2676         (-[WebSecurityOrigin domain]):
2677         * Storage/WebSecurityOriginPrivate.h:
2678
2679 2008-04-25  Mark Rowe  <mrowe@apple.com>
2680
2681         Rubber-stamped by Sam Weinig.
2682
2683         Add some content to an empty ICU header file to prevent verification errors.
2684
2685         * icu/unicode/utf_old.h:
2686
2687 2008-04-25  Anders Carlsson  <andersca@apple.com>
2688
2689         Reviewed by Sam.
2690
2691         Add offlineWebApplicationCacheEnabled preference.
2692         
2693         * WebView/WebPreferenceKeysPrivate.h:
2694         * WebView/WebPreferences.m:
2695         (+[WebPreferences initialize]):
2696         (-[WebPreferences offlineWebApplicationCacheEnabled]):
2697         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
2698         * WebView/WebPreferencesPrivate.h:
2699         * WebView/WebView.mm:
2700         (-[WebView _updateSettingsFromPreferences:]):
2701
2702 2008-04-24  Mark Rowe  <mrowe@apple.com>
2703
2704         Reviewed by Sam Weinig.
2705
2706         Remove code for calculating the glyph cache size.
2707
2708         * WebCoreSupport/WebSystemInterface.m:
2709         (InitWebCoreSystemInterface): Remove unused symbol.
2710
2711 2008-04-24  Mark Rowe  <mrowe@apple.com>
2712
2713         Reviewed by Sam Weinig.
2714
2715         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
2716
2717         * WebKitPrefix.h:
2718
2719 2008-04-24  Brady Eidson  <beidson@apple.com>
2720
2721         Reviewed by Darin
2722
2723         Fix layout test regressions from my earlier preferences/settings tweak.
2724
2725         * WebView/WebView.mm:
2726         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
2727           the notification to update the settings, each WebView still needs to register for the
2728           notification - restore that behavior.
2729
2730 2008-04-24  Dan Bernstein  <mitz@apple.com>
2731
2732         Reviewed by Darin Adler.
2733
2734         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
2735           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
2736
2737         * WebView/WebFrame.mm:
2738         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
2739         VisiblePosition::caretRect() instead of the RenderObject method which
2740         was removed.
2741
2742 2008-04-24  Brady Eidson  <beidson@apple.com>
2743
2744         Reviewed by Darin
2745
2746         Rework the Settings population again.
2747
2748         * WebView/WebView.mm:
2749         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
2750           and directly from WebView's common init function.
2751         (-[WebView _preferencesChangedNotification:]):
2752         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
2753           after creating the new Page
2754
2755 2008-04-24  Darin Adler  <darin@apple.com>
2756
2757         Reviewed by Geoff.
2758
2759         - fix crash in regression test where we'd ask a frame for a user agent string
2760           after the WebView was already closed
2761
2762         * WebCoreSupport/WebFrameLoaderClient.mm:
2763         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
2764         added some code to prevent the crash in release builds if this problem happens
2765         again.
2766
2767 2008-04-24  Anders Carlsson  <andersca@apple.com>
2768
2769         Reviewed by Sam.
2770
2771         Change some String arguments to be const references instead.
2772
2773         * WebCoreSupport/WebEditorClient.h:
2774         * WebCoreSupport/WebEditorClient.mm:
2775         (WebEditorClient::shouldInsertText):
2776
2777 2008-04-24  John Sullivan  <sullivan@apple.com>
2778
2779         Mac build fix
2780         
2781         * WebCoreSupport/WebViewFactory.mm:
2782         (-[WebViewFactory AXButtonActionVerb]):
2783         implement this method using the text in WebCoreLocalizedStrings.cpp
2784         (-[WebViewFactory AXRadioButtonActionVerb]):
2785         ditto
2786         (-[WebViewFactory AXTextFieldActionVerb]):
2787         ditto
2788         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
2789         ditto
2790         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
2791         ditto
2792         (-[WebViewFactory AXLinkActionVerb]):
2793         ditto
2794
2795 2008-04-23  Brady Eidson  <beidson@apple.com>
2796
2797         Reviewed by Sam Weinig
2798
2799         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
2800         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
2801         thereby populating the Settings object, immediately after the Page is created.
2802
2803         * WebView/WebView.mm:
2804         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
2805
2806 2008-04-24  John Sullivan  <sullivan@apple.com>
2807
2808         Reviewed by Jess
2809         
2810         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
2811
2812         * Misc/WebNSControlExtras.m:
2813         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2814         deploy userSpaceScaleFactor when using view distances on the window
2815
2816 2008-04-22  Anders Carlsson  <andersca@apple.com>
2817
2818         Reviewed by Darin.
2819
2820         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
2821         
2822         * Plugins/npfunctions.h:
2823
2824 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
2825
2826         Mysteriously reviewed by mitz|away.
2827
2828         Bug 18111: Closing a tab while dragging crashes Safari
2829         https://bugs.webkit.org/show_bug.cgi?id=18111
2830
2831         Null check the page before handling drag events.
2832
2833         * WebView/WebView.mm:
2834         (-[WebView draggingUpdated:]):
2835         (-[WebView draggingExited:]):
2836
2837 2008-04-19  Brady Eidson  <beidson@apple.com>
2838
2839         Reviewed by Tim Hatcher
2840
2841         Add a WebPreference for the path of the local storage persistent store.
2842
2843         * WebView/WebPreferenceKeysPrivate.h:
2844
2845         * WebView/WebPreferences.m:
2846         (-[WebPreferences _localStorageDatabasePath]):
2847         (-[WebPreferences _setLocalStorageDatabasePath:]):
2848         * WebView/WebPreferencesPrivate.h:
2849
2850         * WebView/WebView.mm:
2851         (-[WebView _preferencesChangedNotification:]):
2852
2853 2008-04-18  Brady Eidson  <beidson@apple.com>
2854
2855         Reviewed by Sam Weinig
2856
2857         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
2858         No reason to do the work twice...
2859
2860         * WebView/WebView.mm:
2861         (-[WebView _close]):
2862
2863 2008-04-17  Eric Seidel  <eric@webkit.org>
2864
2865         Reviewed by beth.
2866
2867         Rename Frame::renderer() to contentRenderer() and fix uses.
2868
2869         * Misc/WebCoreStatistics.mm:
2870         * WebView/WebRenderNode.mm:
2871         (-[WebRenderNode initWithWebFrameView:]):
2872
2873 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
2874
2875         Reviewed by mrowe.
2876
2877         * WebView/WebFrame.mm: Remove temporary build fix.
2878
2879 2008-04-17  Mark Rowe  <mrowe@apple.com>
2880
2881         Reviewed by Dan Bernstein.
2882
2883         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
2884
2885         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
2886
2887         * WebCoreSupport/WebFrameLoaderClient.mm:
2888         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
2889
2890 2008-04-17  Mark Rowe  <mrowe@apple.com>
2891
2892         Rubber-stamped by Dan Bernstein.
2893
2894         Fix the Mac build.
2895
2896         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
2897         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
2898         for this to live going forward.
2899
2900 2008-04-15  Kevin Decker  <kdecker@apple.com>
2901
2902         Reviewed by Anders.
2903
2904         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
2905         
2906         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
2907         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
2908         a bundle out from underneath itself.
2909
2910         * Plugins/WebBasePluginPackage.h: Added unload method.
2911         * Plugins/WebBasePluginPackage.m:
2912         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
2913         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
2914         * Plugins/WebNetscapePluginPackage.m:
2915         (-[WebNetscapePluginPackage unload]): Added.
2916
2917 2008-04-15  Anders Carlsson  <andersca@apple.com>
2918
2919         Reviewed by Adam.
2920
2921         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
2922
2923         * Configurations/WebKit.xcconfig:
2924
2925 2008-04-15  Brady Eidson  <beidson@apple.com>
2926
2927         Reviewed by John Sullivan
2928
2929         Do a more complete job adding the "WebArchiveDebugMode" pref
2930
2931         * WebView/WebPreferences.m: Add both getter *and* setter
2932         (-[WebPreferences webArchiveDebugModeEnabled]):
2933         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
2934         * WebView/WebPreferencesPrivate.h:
2935
2936         * WebView/WebView.mm:
2937         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
2938
2939 2008-04-14  Brady Eidson  <beidson@apple.com>
2940
2941         Reviewed by Anders
2942
2943         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
2944         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
2945         network and will instead fail the load as "cancelled."
2946
2947         * WebView/WebPreferenceKeysPrivate.h:
2948
2949         * WebView/WebPreferences.m:
2950         (+[WebPreferences initialize]):
2951         (-[WebPreferences _webArchiveDebugModeEnabled]):
2952         * WebView/WebPreferencesPrivate.h:
2953
2954         * WebView/WebView.mm:
2955         (-[WebView _preferencesChangedNotification:]):
2956
2957 2008-04-11  David Hyatt  <hyatt@apple.com>
2958
2959         Rename CachedResource ref/deref methods to addClient/removeClient.
2960
2961         Reviewed by olliej
2962
2963         * WebView/WebHTMLView.mm:
2964         (-[WebHTMLViewPrivate dealloc]):
2965         (-[WebHTMLViewPrivate finalize]):
2966         (-[WebHTMLViewPrivate clear]):
2967         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
2968
2969 2008-04-07  Brady Eidson  <beidson@apple.com>
2970
2971         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
2972
2973         * Configurations/WebKit.xcconfig:
2974
2975 2008-04-04  Adam Roben  <aroben@apple.com>
2976
2977         Use WebCore's ICU headers instead of our own copy
2978
2979         Rubberstamped by Tim Hatcher.
2980
2981         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
2982         PrivateHeaders.
2983
2984 2008-04-04  Adam Roben  <aroben@apple.com>
2985
2986         Fix <rdar://problem/5804776> Would like to use WebCore's
2987         ForwardingHeaders in WebKit without manually creating copies
2988
2989         Patch by Tim Hatcher, typed by me.
2990
2991         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
2992         WebCore's PrivateHeaders instead of our own copy.
2993
2994 2008-04-04  Ada Chan  <adachan@apple.com>
2995
2996         Now we pass width and height directly as integers to format
2997         the window title for a standalone image.
2998
2999         Reviewed by Dan.
3000
3001         * WebCoreSupport/WebViewFactory.mm:
3002         (-[WebViewFactory imageTitleForFilename:width:height:]):
3003
3004 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
3005
3006         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
3007
3008         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
3009           font-weight does not properly support graded weights
3010
3011         * WebView/WebHTMLView.mm:
3012         (-[WebHTMLView _styleFromFontAttributes:]):
3013         (-[WebHTMLView _originalFontB]):
3014         (-[WebHTMLView _addToStyle:fontA:fontB:]):
3015
3016 2008-04-02  Mark Rowe  <mrowe@apple.com>
3017
3018         Reviewed by Oliver Hunt.
3019
3020         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
3021
3022         * Configurations/Base.xcconfig:
3023
3024 2008-03-31  Alice Liu  <alice.liu@apple.com>
3025
3026         Reviewed by Darin.
3027
3028         * WebView/WebFrame.mm:
3029         (-[WebFrame _accessibilityTree]):
3030         The syntax for fetching an object from the AXObjectCache changed slightly
3031
3032 2008-03-31  Brady Eidson  <beidson@apple.com>
3033
3034         Reviewed by Jon Honeycutt
3035         
3036         Move a WebArchive loading check into WebCore
3037
3038         * WebView/WebHTMLRepresentation.mm:
3039         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
3040           responsible for checking that state
3041
3042 2008-03-31  Brady Eidson  <beidson@apple.com>
3043
3044         Reviewed by Darin and Mitz's rubber stamp
3045
3046         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
3047
3048         * WebCoreSupport/WebEditorClient.mm:
3049         * WebCoreSupport/WebEditorClient.h:
3050
3051 2008-03-28  Brady Eidson  <beidson@apple.com>
3052
3053         Rubberstamped by Darin Adler
3054
3055         Remove WebArchiver.h/mm
3056
3057         * WebView/WebArchiver.h: Removed.
3058         * WebView/WebArchiver.mm: Removed.
3059
3060         * DOM/WebDOMOperations.mm:
3061         * WebCoreSupport/WebDragClient.mm:
3062         * WebCoreSupport/WebEditorClient.mm:
3063         * WebView/WebDataSource.mm:
3064         * WebView/WebHTMLView.mm:
3065
3066 2008-03-28  Brady Eidson  <beidson@apple.com>
3067
3068         Reviewed by Darin Adler
3069
3070         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
3071
3072         * WebCoreSupport/WebEditorClient.mm:
3073         (WebEditorClient::dataForArchivedSelection):
3074
3075         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
3076         * WebView/WebArchiver.mm: Ditto
3077
3078         * WebView/WebHTMLView.mm:
3079         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3080
3081 2008-03-28  Brady Eidson  <beidson@apple.com>
3082
3083         Reviewed by Darin Adler
3084
3085         More Kit->Core WebArchive changes.
3086
3087         Create an archive from the current selection in a frame
3088
3089         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
3090           easily in a followup
3091
3092 2008-03-28  Brady Eidson  <beidson@apple.com>
3093
3094         Reviewed by Sam Weinig
3095
3096         WebArchive saga continues - Can now make archives from ranges in WebCore
3097
3098         * DOM/WebDOMOperations.mm:
3099         (-[DOMRange webArchive]):
3100         (-[DOMRange markupString]):
3101
3102         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
3103         * WebView/WebArchiver.mm:
3104
3105 2008-03-28  Brady Eidson  <beidson@apple.com>
3106
3107         Reviewed by Sam Weinig
3108
3109         More Kit->Core webarchive code movement
3110
3111         * DOM/WebDOMOperations.mm:
3112         (-[DOMNode markupString]): Call createFullMarkup() instead
3113
3114         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
3115         * WebView/WebFrameInternal.h: Ditto
3116
3117 2008-03-28  Brady Eidson  <beidson@apple.com>
3118
3119         Reviewed by Sam Weinig
3120
3121         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
3122
3123         * WebView/WebArchiver.h:
3124         * WebView/WebArchiver.mm:
3125         * WebView/WebDataSource.mm:
3126         (-[WebDataSource webArchive]):
3127
3128 2008-03-28  Brady Eidson  <beidson@apple.com>
3129
3130         Reviewed by Sam Weinig
3131
3132         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
3133
3134         * WebView/WebArchiver.h:
3135         * WebView/WebArchiver.mm:
3136
3137 2008-03-28  Brady Eidson  <beidson@apple.com>
3138
3139         Reviewed by Darin
3140
3141         "Yet another transitional step" to empty out WebKit-based code for archiving.
3142
3143         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
3144         entirely within WebCore, and opens the door to saving WebArchives on Windows.
3145
3146         * DOM/WebDOMOperations.mm:
3147         * WebView/WebArchiver.mm:
3148         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
3149
3150 2008-03-27  Brady Eidson  <beidson@apple.com>
3151
3152         Reviewed by Adam Roben
3153
3154         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
3155         as the push to core-ify WebArchives continues.
3156
3157         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.  
3158         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.  
3159         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources 
3160         (as in "while archiving a page") are accepting of null or empty data.
3161
3162         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change. 
3163
3164         * WebView/WebDataSource.mm:
3165         (-[WebDataSource mainResource]): Call DocumentLoader implementation
3166         (-[WebDataSource subresources]): Ditto
3167         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
3168         * WebView/WebFrameInternal.h:
3169
3170 2008-03-27  Brady Eidson  <beidson@apple.com>
3171
3172         Reviewed by Adam
3173
3174         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
3175         (more efficient)
3176
3177         * WebView/WebResource.mm:
3178         (-[WebResource _initWithCoreResource:]):
3179         * WebView/WebResourceInternal.h:
3180
3181 2008-03-26  Brady Eidson  <beidson@apple.com>
3182
3183         Build fix - accidentally checked in this change which was work in progress
3184
3185         * DOM/WebDOMOperations.mm:
3186
3187 2008-03-26  Brady Eidson  <beidson@apple.com>
3188
3189         Reviewed by Darin
3190
3191         When we create a WebArchive, we walk every node from some starting point, asking each node
3192         along the way "What are your subresource URLs?"
3193
3194         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
3195         WebCore::Node
3196
3197         * DOM/WebDOMOperations.mm:
3198         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
3199           calling into individual WebCore::Node implementations
3200         * DOM/WebDOMOperationsPrivate.h:
3201
3202 2008-03-26  Brady Eidson  <beidson@apple.com>
3203
3204         Reviewed by Mark Rowe
3205
3206         Part of the continued push to move WebArchive-related code down to WebCore, this
3207         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
3208
3209         * WebView/WebDataSource.mm:
3210         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
3211
3212         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
3213           has now been ported down to WebCore
3214         * WebView/WebFrameInternal.h:
3215
3216 2008-03-26  Mark Rowe  <mrowe@apple.com>
3217
3218         Rubber-stamped by Brady Eidson.
3219
3220         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
3221
3222         * Configurations/WebKit.xcconfig:
3223
3224 2008-03-26  Mark Rowe  <mrowe@apple.com>
3225
3226         Reviewed by David Hyatt.
3227
3228         Make the Ahem font antialias correctly on Acid3 on Tiger.
3229
3230         * WebCoreSupport/WebSystemInterface.m:
3231         (InitWebCoreSystemInterface):
3232
3233 2008-03-26  Mark Rowe  <mrowe@apple.com>
3234
3235         Fix the Mac build.
3236
3237         * MigrateHeaders.make: Copy the newly generated header into the right place.
3238
3239 2008-03-25  Brady Eidson  <beidson@apple.com>
3240
3241         Reviewed by Beth Dakin
3242
3243         Remove entirely unused internal method
3244
3245         * WebView/WebArchiver.h:
3246         * WebView/WebArchiver.mm:
3247
3248 2008-03-25  Brady Eidson  <beidson@apple.com>
3249
3250         Reviewed by Adam Roben
3251
3252         <rdar://problem/5819308> - View Source is empty when view webarchives
3253
3254         * WebCore.base.exp:
3255         * loader/DocumentLoader.cpp:
3256         (WebCore::DocumentLoader::setParsedArchiveData):
3257         (WebCore::DocumentLoader::parsedArchiveData):
3258         * loader/DocumentLoader.h:
3259
3260         * loader/FrameLoader.cpp:
3261         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
3262           in the DocumentLoader
3263
3264 2008-03-25  Dan Bernstein  <mitz@apple.com>
3265
3266         Reviewed by Darin Adler.
3267
3268         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
3269           Reopen All Windows From Last Session causes crash
3270
3271         * WebView/WebHTMLView.mm:
3272         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
3273         check.
3274
3275 2008-03-25  Brady Eidson  <beidson@apple.com>
3276
3277         Reviewed by Jon Honeycutt's rubberstamp
3278
3279         Fix a leak with the new WebArchive setup
3280
3281         * WebView/WebArchive.mm:
3282         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
3283
3284 2008-03-25  Brady Eidson  <beidson@apple.com>
3285
3286         Reviewed by Darin
3287
3288         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
3289         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
3290
3291         * WebCoreSupport/WebFrameLoaderClient.h:
3292         * WebCoreSupport/WebFrameLoaderClient.mm:
3293         (WebFrameLoaderClient::WebFrameLoaderClient):
3294
3295 2008-03-25  Brady Eidson  <beidson@apple.com>
3296
3297         Reviewed by Darin
3298
3299         Remove newly obsolete FrameLoaderClient methods
3300
3301         * WebCoreSupport/WebFrameLoaderClient.h:
3302         * WebCoreSupport/WebFrameLoaderClient.mm:
3303
3304 2008-03-25  Brady Eidson  <beidson@apple.com>
3305
3306         Release build fix
3307
3308         * WebView/WebArchive.mm:
3309         (-[WebArchive subresources]):
3310         (-[WebArchive subframeArchives]):
3311
3312 2008-03-25  Brady Eidson  <beidson@apple.com>
3313
3314         Reviewed by Darin
3315
3316         <rdar://problem/4516169> - Support WebArchives on Windows
3317         And paves the way for many future WebArchive bug fixes and enhancements
3318
3319         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains 
3320         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
3321          * WebArchive <-> LegacyWebArchive
3322          * WebResource <-> ArchiveResource
3323          * WebUnarchivingState <-> ArchiveResourceCollection
3324  
3325         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives 
3326         and now exist in WebCore
3327
3328         * WebCoreSupport/WebFrameLoaderClient.mm:
3329         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
3330         (WebFrameLoaderClient::finalSetupForReplace):
3331         (WebFrameLoaderClient::setDefersLoading):
3332         (WebFrameLoaderClient::willUseArchive):
3333         (WebFrameLoaderClient::isArchiveLoadPending):
3334         (WebFrameLoaderClient::cancelPendingArchiveLoad):
3335         (WebFrameLoaderClient::clearArchivedResources):
3336         (WebFrameLoaderClient::createFrame):
3337
3338         * WebView/WebArchive.mm:
3339         (+[WebArchivePrivate initialize]):
3340         (-[WebArchivePrivate init]):
3341         (-[WebArchivePrivate initWithCoreArchive:]):
3342         (-[WebArchivePrivate coreArchive]):
3343         (-[WebArchivePrivate setCoreArchive:]):
3344         (-[WebArchivePrivate dealloc]):
3345         (-[WebArchivePrivate finalize]):
3346         (-[WebArchive init]):
3347         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
3348         (-[WebArchive initWithData:]):
3349         (-[WebArchive initWithCoder:]):
3350         (-[WebArchive encodeWithCoder:]):
3351         (-[WebArchive mainResource]):
3352         (-[WebArchive subresources]):
3353         (-[WebArchive subframeArchives]):
3354         (-[WebArchive data]):
3355         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
3356         (-[WebArchive WebCore::]):
3357         * WebView/WebArchiveInternal.h: Added.
3358
3359         * WebView/WebDataSource.mm:
3360         (-[WebDataSourcePrivate dealloc]):
3361         (-[WebDataSource _addSubframeArchives:]):
3362         (-[WebDataSource _documentFragmentWithArchive:]):
3363         (-[WebDataSource subresourceForURL:]):
3364         (-[WebDataSource addSubresource:]):
3365         * WebView/WebDataSourceInternal.h:
3366
3367         * WebView/WebFrame.mm:
3368         (-[WebFrame loadArchive:]):
3369         * WebView/WebFrameInternal.h:
3370
3371         * WebView/WebHTMLRepresentation.mm:
3372         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3373
3374         * WebView/WebResource.mm:
3375         (+[WebResourcePrivate initialize]):
3376         (-[WebResourcePrivate init]):
3377         (-[WebResourcePrivate initWithCoreResource:]):
3378         (-[WebResourcePrivate dealloc]):
3379         (-[WebResourcePrivate finalize]):
3380         (-[WebResource initWithCoder:]):
3381         (-[WebResource encodeWithCoder:]):
3382         (-[WebResource data]):
3383         (-[WebResource URL]):
3384         (-[WebResource MIMEType]):
3385         (-[WebResource textEncodingName]):
3386         (-[WebResource frameName]):
3387         (-[WebResource _initWithCoreResource:WebCore::]):
3388         (-[WebResource WebCore::]):
3389         (-[WebResource _ignoreWhenUnarchiving]):
3390         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
3391         (-[WebResource _fileWrapperRepresentation]):
3392         (-[WebResource _response]):
3393         (-[WebResource _stringValue]):
3394         * WebView/WebResourceInternal.h: Added.
3395         * WebView/WebResourcePrivate.h:
3396
3397         * WebView/WebUnarchivingState.h: Removed.
3398         * WebView/WebUnarchivingState.m: Removed.
3399
3400 2008-03-24  Oliver Hunt  <oliver@apple.com>
3401
3402         Reviewed by Mark Rowe.
3403
3404         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
3405         <http://bugs.webkit.org/show_bug.cgi?id=18030>
3406
3407         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
3408         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
3409         <http://bugs.webkit.org/show_bug.cgi?id=18057>
3410
3411         * WebView/WebHTMLView.mm:
3412         (-[WebHTMLView keyDown:]):
3413
3414 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3415
3416         Reviewed by Maciej, landed by Brady
3417
3418         Bug 3580: iFrames Appear to be Cached
3419         <http://bugs.webkit.org/show_bug.cgi?id=3580>
3420
3421         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
3422         <http://bugs.webkit.org/show_bug.cgi?id=15486>
3423
3424         Bug 15554: Reload causes <object> to use old data
3425         <http://bugs.webkit.org/show_bug.cgi?id=15554>
3426
3427         If a page is reloaded, a child frame's URL can not be taken from a history item.
3428
3429         * WebView/WebFrame.mm:
3430         (-[WebFrame _loadURL:referrer:intoChild:]):
3431
3432 2008-03-24  Darin Adler  <darin@apple.com>
3433
3434         Reviewed by Beth.
3435
3436         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
3437
3438         * History/WebHistoryItem.mm:
3439         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
3440         * WebView/WebDataSource.mm:
3441         (-[WebDataSource _URL]): Ditto.
3442         (-[WebDataSource unreachableURL]): Ditto.
3443         * WebView/WebHTMLView.mm:
3444         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3445
3446         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3447         * History/WebHistory.mm:
3448         * Misc/WebElementDictionary.mm:
3449         * Misc/WebNSAttributedStringExtras.mm:
3450         Remove unneeded imports of KURL.h.
3451
3452 2008-03-24  Brady Eidson  <beidson@apple.com>
3453
3454         Reviewed by Darin's rubberstamp
3455
3456         Rename this file for upcoming work.
3457
3458         * WebView/WebArchive.m: Removed.
3459         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
3460
3461 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
3462
3463         Build fix.
3464
3465         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
3466
3467 2008-03-23  Oliver Hunt  <oliver@apple.com>
3468
3469         Reviewed by Maciej.
3470
3471         Bug 17670: Key events may improperly propagate from iframe to parent frame
3472         <http://bugs.webkit.org/show_bug.cgi?id=17670>
3473         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
3474         <http://bugs.webkit.org/show_bug.cgi?id=16381>
3475
3476         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
3477         as that results in us dispatching the key events for each frame going up the frame
3478         tree.
3479
3480         * WebView/WebHTMLView.mm:
3481         (-[WebHTMLView keyDown:]):
3482         (-[WebHTMLView keyUp:]):
3483         (-[WebHTMLView flagsChanged:]):
3484
3485 2008-03-21  Timothy Hatcher  <timothy@apple.com>
3486
3487         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
3488         http://bugs.webkit.org/show_bug.cgi?id=17980
3489
3490         Reviewed by Adam.
3491
3492         The new highlight drawing was not honoring the fade value, so it was
3493         always drawing at full opacity. The animation code didn't match Windows
3494         and the new highlight anyway, so it has been removed. The highlight
3495         how just detaches when it is hidden.
3496
3497         * WebCoreSupport/WebInspectorClient.mm:
3498         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
3499         (-[WebInspectorWindowController close]): Ditto.
3500         (-[WebInspectorWindowController highlightNode:]): Call attach.
3501         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
3502         * WebInspector/WebNodeHighlight.h:
3503         * WebInspector/WebNodeHighlight.m:
3504         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
3505         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
3506         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
3507         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
3508         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
3509         * WebInspector/WebNodeHighlightView.h:
3510         * WebInspector/WebNodeHighlightView.m:
3511         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
3512
3513 2008-03-20  Mark Rowe  <mrowe@apple.com>
3514
3515         Reviewed by Sam Weinig.
3516
3517         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
3518         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
3519         command-line.
3520
3521         * Configurations/WebKit.xcconfig:
3522
3523 2008-03-20  Adam Roben  <aroben@apple.com>
3524
3525         Make WebNodeHighlightView use InspectorController to do its painting
3526
3527         Reviewed by Tim Hatcher.
3528
3529         * WebCoreSupport/WebInspectorClient.mm:
3530         (-[WebInspectorWindowController highlightNode:]): Pass the
3531         InspectorController to the WebNodeHighlight, and don't call
3532         setHighlightedNode: (which has been removed).
3533         (-[WebInspectorWindowController hideHighlight]): Removed call to
3534         setHighlightedNode:.
3535         * WebInspector/WebNodeHighlight.h:
3536           - Replaced _highlightNode with _inspectorController
3537           - Removed _highlightedNode accessors
3538           - Added -inspectorController method
3539         * WebInspector/WebNodeHighlight.m:
3540         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
3541         takes an InspectorController* and stores it in _inspectorController.
3542         (-[WebNodeHighlight dealloc]): Removed code dealing with
3543         _highlightedNode.
3544         (-[WebNodeHighlight inspectorController]): Added.
3545         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
3546         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
3547         GraphicsContexts to be based on a flipped CGContext, so we have to
3548         specify that this view is flipped.
3549         (-[WebNodeHighlightView drawRect:]): Changed to create a
3550         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
3551
3552 2008-03-18  David Hyatt  <hyatt@apple.com>
3553
3554         Add support for a preference in WebKit that can be used in nightly builds to test full page
3555         zoom.
3556
3557         Reviewed by Antti
3558
3559         * WebView/WebPreferenceKeysPrivate.h:
3560         * WebView/WebView.mm:
3561         (-[WebView setTextSizeMultiplier:]):
3562         (-[WebView canMakeTextSmaller]):
3563         (-[WebView makeTextSmaller:]):
3564         (-[WebView canMakeTextLarger]):
3565         (-[WebView makeTextLarger:]):
3566         (-[WebView canMakeTextStandardSize]):
3567         (-[WebView makeTextStandardSize:]):
3568
3569 2008-03-17  Eric Seidel  <eric@webkit.org>
3570
3571         Reviewed by darin.
3572
3573         Export _NPN_IntFromIdentifier as part of our NPAPI interface
3574
3575         * Plugins/WebNetscapePluginPackage.m:
3576         (-[WebNetscapePluginPackage load]):
3577
3578 2008-03-14  Brady Eidson  <beidson@apple.com>
3579
3580         Reviewed by Brian Dash's rubberstamp
3581
3582         Remove a class declaration for a class that has never existed
3583
3584         * WebView/WebResource.h:
3585
3586 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
3587
3588         Unify concept of enabling the Mac Java bridge.
3589
3590         Reviewed by Darin and Anders.
3591
3592         * Plugins/WebPluginJava.h: Removed unused file.
3593         * WebCoreSupport/WebFrameLoaderClient.h:
3594         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
3595         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
3596         (WebFrameLoaderClient::javaApplet): Ditto.
3597
3598 2008-03-13  Antti Koivisto  <antti@apple.com>
3599
3600         Reviewed by Darin.
3601
3602         * ForwardingHeaders/wtf/Deque.h: Added.
3603
3604 2008-03-13  Anders Carlsson  <andersca@apple.com>
3605
3606         Reviewed by Adam.
3607
3608         Call originalRequest, not initialRequest.
3609         
3610         * WebView/WebDataSource.mm:
3611         (-[WebDataSource initialRequest]):
3612
3613 2008-03-12  Darin Adler  <darin@apple.com>
3614
3615         Reviewed by John Sullivan.
3616
3617         - cleanup after removing the bridge
3618
3619         * DOM/WebDOMOperations.mm:
3620         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
3621
3622         * Misc/WebCoreStatistics.mm:
3623         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
3624
3625         * Plugins/WebBaseNetscapePluginView.mm:
3626         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
3627         _frameLoader method.
3628         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3629         Ditto.
3630         * Plugins/WebPluginController.mm:
3631         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
3632
3633         * WebCoreSupport/WebFrameLoaderClient.mm:
3634         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
3635         method. Without this we could leave a stale frame pointer around.
3636         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
3637         caller of the _isMainFrame method.
3638         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
3639         _frameLoader method.
3640         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
3641
3642         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
3643         turned out to be unused.
3644         (core): Added overload for DocumentFragment.
3645         (kit): Ditto.
3646         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
3647         to FrameLoader with _private->coreFrame->loader().
3648         (-[WebFrame _attachScriptDebugger]): Ditto.
3649         (-[WebFrame _clearCoreFrame]): Added.
3650         (-[WebFrame _updateBackground]): More of the same.
3651         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
3652         (-[WebFrame _unmarkAllMisspellings]): Ditto.
3653         (-[WebFrame _hasSelection]): Ditto.
3654         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
3655         (-[WebFrame _findFrameWithSelection]): Ditto.
3656         (-[WebFrame _dataSource]): Ditto.
3657         (-[WebFrame _addData:]): Streamlined code a bit.
3658         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3659         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3660         (-[WebFrame _isDescendantOfFrame:]): Ditto.
3661         (-[WebFrame _bodyBackgroundColor]): Ditto.
3662         (-[WebFrame _isFrameSet]): Ditto.
3663         (-[WebFrame _firstLayoutDone]): Ditto.
3664         (-[WebFrame _loadType]): Ditto.
3665         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
3666         (-[WebFrame name]): Ditto.
3667         (-[WebFrame DOMDocument]): Ditto.
3668         (-[WebFrame frameElement]): Ditto.
3669         (-[WebFrame provisionalDataSource]): Ditto.
3670         (-[WebFrame dataSource]): Ditto.
3671         (-[WebFrame loadRequest:]): Ditto.
3672         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
3673         (-[WebFrame loadArchive:]): Ditto.
3674         (-[WebFrame stopLoading]): Ditto.
3675         (-[WebFrame reload]): Ditto.
3676         (-[WebFrame findFrameNamed:]): Ditto.
3677         (-[WebFrame parentFrame]): Ditto.
3678         (-[WebFrame childFrames]): Ditto.
3679         (-[WebFrame windowObject]): Ditto.
3680         (-[WebFrame globalContext]): Ditto.
3681
3682         * WebView/WebFrameInternal.h: Added overloads of core and kit.
3683         Removed method declarations.
3684
3685         * WebView/WebHTMLRepresentation.mm:
3686         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
3687         (formElementFromDOMElement): Ditto.
3688         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3689         (inputElementFromDOMElement): Ditto.
3690         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3691         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3692         (-[WebHTMLRepresentation formForElement:]): Ditto.
3693         (-[WebHTMLRepresentation currentForm]): Ditto.
3694         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3695         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3696         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3697
3698         * WebView/WebHTMLView.mm:
3699         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
3700         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3701         Call createFragmentFromText directly instead of via WebFrame.
3702         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3703         Moved layout calls here from WebFrame.
3704         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3705         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
3706         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
3707         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
3708         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
3709         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3710         Moved code here from WebFrame.
3711         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
3712         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3713         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3714         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3715         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3716         (-[WebHTMLView rectsForTextMatches]): Ditto.
3717
3718         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
3719
3720         * WebView/WebPDFView.mm:
3721         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
3722         _frameLoader method.
3723
3724         * WebView/WebRenderNode.mm:
3725         (copyRenderNode): Moved code here from WebFrame.
3726         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3727
3728         * WebView/WebResource.mm:
3729         (-[WebResource _stringValue]): Moved code here from WebFrame.
3730
3731         * WebView/WebView.mm:
3732         (-[WebView _close]): Use core function intsead of _frameLoader method.
3733         (-[WebView setCustomTextEncodingName:]): Ditto.
3734         (-[WebView setHostWindow:]): Moved code here from WebFrame.
3735         (aeDescFromJSValue): Moved this here from WebFrame.
3736         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
3737
3738 2008-03-12  Darin Adler  <darin@apple.com>
3739
3740         Reviewed by Anders.
3741
3742         - http://bugs.webkit.org/show_bug.cgi?id=17640
3743           eliminate WebCoreFrameBridge
3744
3745         Moved all the code from the bridge into WebFrame. This need not be the final
3746         home of these methods -- they can be moved closer to their callers and improved
3747         further -- but it eliminates the bridge without requiring a rewrite of the code.
3748         It's a fairly mechanical process (just adding underscores to method names really).
3749
3750         There's even a chance that some of the methods are unused. Those we can remove
3751         after checking if that's so.
3752
3753         * DOM/WebDOMOperations.mm:
3754         (-[DOMNode markupString]): Use WebFrame rather than bridge.
3755         (-[DOMDocument webFrame]): Changed to use the core and kit functions
3756         instead of using the bridge.
3757         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
3758         (-[DOMRange markupString]): Ditto.
3759         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
3760
3761         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
3762         * History/WebHistoryItem.mm: Ditto.
3763
3764         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
3765         * Misc/WebCoreStatistics.mm:
3766         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
3767
3768         * Misc/WebElementDictionary.mm: Removed unneeded import.
3769
3770         * Misc/WebKitStatistics.m:
3771         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
3772         * Misc/WebKitStatisticsPrivate.h: Ditto.
3773
3774         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
3775         * Misc/WebNSPasteboardExtras.mm: Ditto.
3776
3777         * Plugins/WebBaseNetscapePluginView.mm:
3778         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
3779         rather than bridge.
3780
3781         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
3782         * Plugins/WebNetscapePluginStream.mm: Ditto.
3783
3784         * Plugins/WebPluginContainerCheck.mm:
3785         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
3786         bridge to get to the WebCore::Frame.
3787
3788         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
3789         * Plugins/WebPluginController.mm:
3790         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
3791         rather than bridge.
3792
3793         * WebCoreSupport/WebEditorClient.mm:
3794         (selectorForKeyEvent): Tweaked comment.
3795
3796         * WebCoreSupport/WebFrameBridge.h: Removed.
3797         * WebCoreSupport/WebFrameBridge.mm: Removed.
3798
3799         * WebCoreSupport/WebFrameLoaderClient.mm:
3800         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
3801         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
3802         I could remove this function entirely, but it looks like the Qt port is using it.
3803
3804         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
3805
3806         * WebView/WebArchiver.mm:
3807         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
3808         (+[WebArchiver archiveNode:]): Ditto.
3809         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
3810
3811         * WebView/WebDataSource.mm:
3812         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
3813         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
3814         (-[WebDataSource subresources]): Ditto.
3815         (-[WebDataSource subresourceForURL:]): Ditto.
3816
3817         * WebView/WebDataSourceInternal.h: Removed _bridge method.
3818
3819         * WebView/WebFrame.mm:
3820         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
3821         (core): Go directly to the core frame, not via the bridge.
3822         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
3823         Remove the code to deal with the bridge.
3824         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
3825         shouldCreateRenderers flag, formerly on the bridge.
3826         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
3827         (aeDescFromJSValue): Moved here from bridge.
3828         (-[WebFrame _domain]): Ditto.
3829         (-[WebFrame _addData:]): Ditto.
3830         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
3831         (-[WebFrame _nodesFromList:]): Ditto.
3832         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
3833         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
3834         (-[WebFrame _selectedString]): Ditto.
3835         (-[WebFrame _stringForRange:]): Ditto.
3836         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
3837         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3838         (-[WebFrame _sendScrollEvent]): Ditto.
3839         (-[WebFrame _drawRect:]): Ditto.
3840         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
3841         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
3842         (-[WebFrame _copyRenderNode:copier:]): Ditto.
3843         (-[WebFrame _copyRenderTree:]): Ditto.
3844         (inputElementFromDOMElement): Ditto.
3845         (formElementFromDOMElement): Ditto.
3846         (-[WebFrame _elementWithName:inForm:]): Ditto.
3847         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
3848         (-[WebFrame _elementIsPassword:]): Ditto.
3849         (-[WebFrame _formForElement:]): Ditto.
3850         (-[WebFrame _currentForm]): Ditto.
3851         (-[WebFrame _controlsInForm:]): Ditto.
3852         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
3853         (-[WebFrame _matchLabels:againstElement:]): Ditto.
3854         (-[WebFrame _URLWithAttributeString:]): Ditto.
3855         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3856         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
3857         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
3858         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
3859         (-[WebFrame _unmarkAllTextMatches]): Ditto.
3860         (-[WebFrame _rectsForTextMatches]): Ditto.
3861         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
3862         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
3863         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3864         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
3865         (-[WebFrame _firstRectForDOMRange:]): Ditto.
3866         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
3867         (-[WebFrame _baseURL]): Ditto.
3868         (-[WebFrame _stringWithData:]): Ditto.
3869         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
3870         (-[WebFrame _needsLayout]): Ditto.
3871         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
3872         (-[WebFrame _accessibilityTree]): Ditto.
3873         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
3874         (-[WebFrame _setDrawsBackground:]): Ditto.
3875         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
3876         Ditto.
3877         (-[WebFrame _selectionGranularity]): Ditto.
3878         (-[WebFrame _convertToNSRange:]): Ditto.
3879         (-[WebFrame _convertToDOMRange:]): Ditto.
3880         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
3881         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
3882         (-[WebFrame _markDOMRange]): Ditto.
3883         (-[WebFrame _markedTextNSRange]): Ditto.
3884         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
3885         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3886         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
3887         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
3888         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
3889         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
3890         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
3891         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
3892         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
3893         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
3894         (-[WebFrame _visiblePositionForPoint:]): Ditto.
3895         (-[WebFrame _characterRangeAtPoint:]): Ditto.
3896         (-[WebFrame _typingStyle]): Ditto.
3897         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
3898         (-[WebFrame _fontForSelection:]): Ditto.
3899         (-[WebFrame _dragSourceMovedTo:]): Ditto.
3900         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
3901         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
3902         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
3903         (-[WebFrame _canProvideDocumentSource]): Ditto.
3904         (-[WebFrame _canSaveAsWebArchive]): Ditto.
3905         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
3906         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
3907         function. Couldn't just keep the bridge method because this was already here with the same name.
3908         (-[WebFrame _selectedNSRange]): Ditto.
3909         (-[WebFrame _selectNSRange:]): Ditto.
3910         (-[WebFrame dealloc]): Remove bridge-related code.
3911         (-[WebFrame finalize]): Ditto.
3912
3913         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
3914         Removed the bridge parameter from the init method. Removed the #if blocks that
3915         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
3916         Removed the _bridge method.
3917
3918         * WebView/WebFrameView.mm: Removed the _bridge method.
3919
3920         * WebView/WebHTMLRepresentation.mm:
3921         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
3922         field.
3923         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
3924         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
3925         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
3926         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
3927         (-[WebHTMLRepresentation documentSource]): Ditto.
3928         (-[WebHTMLRepresentation DOMDocument]): Ditto.
3929         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
3930         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
3931         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
3932         (-[WebHTMLRepresentation formForElement:]): Ditto.
3933         (-[WebHTMLRepresentation currentForm]): Ditto.
3934         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
3935         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
3936         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
3937
3938         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
3939
3940         * WebView/WebHTMLView.mm:
3941         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
3942         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3943         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3944         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
3945         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
3946         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
3947         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
3948         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
3949         (-[WebHTMLView drawSingleRect:]): Ditto.
3950         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
3951         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3952         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
3953         (-[WebHTMLView knowsPageRange:]): Ditto.
3954         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3955         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
3956         (-[WebHTMLView accessibilityHitTest:]): Ditto.
3957         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
3958         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
3959         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
3960         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
3961         (-[WebHTMLView startSpeaking:]): Ditto.
3962         (-[WebHTMLView _updateFontPanel]): Ditto.
3963         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
3964         (-[WebHTMLView _layoutIfNeeded]): Ditto.
3965         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3966         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3967         (-[WebHTMLView selectedRange]): Ditto.
3968         (-[WebHTMLView markedRange]): Ditto.
3969         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3970         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3971         (-[WebHTMLView insertText:]): Ditto.
3972         (-[WebTextCompleteController _insertMatch:]): Ditto.
3973         (-[WebTextCompleteController doCompletion]): Ditto.
3974         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
3975         (-[WebHTMLView string]): Ditto.
3976         (-[WebHTMLView selectedString]): Ditto.
3977         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
3978         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
3979         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
3980         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
3981         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
3982         (-[WebHTMLView rectsForTextMatches]): Ditto.
3983         * WebView/WebRenderNode.mm:
3984         (-[WebRenderNode initWithWebFrameView:]): Ditto.
3985         * WebView/WebResource.mm:
3986         (-[WebResource _stringValue]): Ditto.
3987
3988         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
3989
3990         * WebView/WebView.mm:
3991         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
3992         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
3993         (-[WebView _setInViewSourceMode:]): Ditto.
3994         (-[WebView _inViewSourceMode]): Ditto.
3995         (-[WebView _executeCoreCommandByName:value:]): Ditto.
3996         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
3997         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
3998         (-[WebView scrollDOMRangeToVisible:]): Ditto.
3999         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
4000         (-[WebView setEditable:]): Ditto.
4001         (-[WebView setTypingStyle:]): Ditto.
4002         (-[WebView typingStyle]): Ditto.
4003         (-[WebView replaceSelectionWithNode:]): Ditto.
4004         (-[WebView replaceSelectionWithText:]): Ditto.
4005         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
4006         (-[WebView replaceSelectionWithArchive:]): Ditto.
4007         (-[WebView _insertNewlineInQuotedContent]): Ditto.
4008         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
4009
4010 2008-03-12  David Hyatt  <hyatt@apple.com>
4011
4012         Make the zoom factor a float and not a percent.
4013
4014         Reviewed by antti
4015
4016         * WebView/WebView.mm:
4017         (-[WebView _setZoomMultiplier:isTextOnly:]):
4018
4019 2008-03-11  David Hyatt  <hyatt@apple.com>
4020
4021         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
4022         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
4023         can zoom the page in, out or reset it to the standard size.
4024
4025         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
4026         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
4027         win.
4028
4029         Reviewed by Tim H.
4030
4031         * WebCoreSupport/WebFrameBridge.mm:
4032         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
4033         * WebView/WebDocumentInternal.h:
4034         * WebView/WebHTMLView.mm:
4035         (-[WebHTMLView viewDidMoveToSuperview]):
4036         * WebView/WebPDFView.h:
4037         * WebView/WebPDFView.mm:
4038         (-[WebPDFView _zoomOut:]):
4039         (-[WebPDFView _zoomIn:]):
4040         (-[WebPDFView _resetZoom:]):
4041         (-[WebPDFView _canZoomOut]):
4042         (-[WebPDFView _canZoomIn]):
4043         (-[WebPDFView _canResetZoom]):
4044         * WebView/WebView.mm:
4045         (-[WebViewPrivate init]):
4046         (-[WebView setTextSizeMultiplier:]):
4047         (-[WebView textSizeMultiplier]):
4048         (-[WebView _setZoomMultiplier:isTextOnly:]):
4049         (-[WebView _zoomMultiplier:]):
4050         (-[WebView _realZoomMultiplier]):
4051         (-[WebView _realZoomMultiplierIsTextOnly]):
4052         (-[WebView _canZoomOut:]):
4053         (-[WebView _canZoomIn:]):
4054         (-[WebView _zoomOut:isTextOnly:]):
4055         (-[WebView _zoomIn:isTextOnly:]):
4056         (-[WebView _canResetZoom:]):
4057         (-[WebView _resetZoom:isTextOnly:]):
4058         (-[WebView canMakeTextSmaller]):
4059         (-[WebView makeTextSmaller:]):
4060         (-[WebView canMakeTextLarger]):
4061         (-[WebView makeTextLarger:]):
4062         (-[WebView canMakeTextStandardSize]):
4063         (-[WebView makeTextStandardSize:]):
4064         (-[WebView setPageSizeMultiplier:]):
4065         (-[WebView pageSizeMultiplier]):
4066         (-[WebView canZoomPageIn]):
4067         (-[WebView zoomPageIn:]):
4068         (-[WebView canZoomPageOut]):
4069         (-[WebView zoomPageOut:]):
4070         (-[WebView canResetPageZoom]):
4071         (-[WebView resetPageZoom:]):
4072         (-[WebView _searchWithSpotlightFromMenu:]):
4073         * WebView/WebViewInternal.h:
4074         * WebView/WebViewPrivate.h:
4075
4076 2008-03-12  Dan Bernstein  <mitz@apple.com>
4077
4078         Reviewed by Darin Adler and Sam Weinig.
4079
4080         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
4081
4082         * WebCoreSupport/WebSystemInterface.m:
4083         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
4084         WKGetNSFontATSUFontId Tiger-only.
4085
4086 2008-03-12  Darin Adler  <darin@apple.com>
4087
4088         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
4089           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
4090
4091         * WebView/WebFrame.mm:
4092         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
4093         up pointer from the bridge to the frame. (My next check-in removes the bridge
4094         entirely, but we need this until then.)
4095
4096 2008-03-11  Darin Adler  <darin@apple.com>
4097
4098         Reviewed by Sam.
4099
4100         - remove all bridge-related things from WebCore except the bridge itself
4101
4102         * DOM/WebDOMOperations.mm:
4103         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
4104
4105         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
4106
4107         * Plugins/WebPluginController.mm: Ditto.
4108
4109         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
4110         init and close methods. Added a setWebFrame: method.
4111
4112         * WebCoreSupport/WebFrameBridge.mm:
4113         (-[WebFrameBridge setWebFrame:]): Added.
4114
4115         * WebCoreSupport/WebFrameLoaderClient.mm:
4116         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
4117         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
4118         bridge here. Soon we will be able to remove this entirely!
4119         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
4120         into WebFrame from the bridge.
4121
4122         * WebView/WebFrame.mm:
4123         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
4124         now owned by the frame.
4125         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
4126         debugger under GC without this!
4127         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
4128         use WebFrameLoaderClient instead of the bridge.
4129         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
4130         This is code that used to live in the bridge's init function.
4131         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
4132         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
4133         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
4134         the WebView is now the bridge's owner.
4135         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
4136         WebCore::Frame::bridge function directly to use the kit function instead.
4137         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
4138         This code won't last long -- we're eliminating the bridge soon.
4139         (-[WebFrame finalize]): Ditto.
4140
4141         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
4142         for creating frames.
4143
4144         * WebView/WebView.mm:
4145         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
4146         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
4147         where we have to allocate a WebFrameBridge and then immediately release it.
4148
4149 2008-03-11  Darin Adler  <darin@apple.com>
4150
4151         Reviewed by Anders.
4152
4153         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
4154
4155         * WebCoreSupport/WebFrameLoaderClient.mm:
4156         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
4157         to setView. A couple lines later, there is a call to _install, which sets the
4158         view to the scroll view.
4159
4160         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
4161
4162         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
4163         this file, since it's used by Safari.
4164         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
4165         * WebView/WebDynamicScrollBarsView.m:
4166         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
4167         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
4168         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
4169         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
4170         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
4171         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
4172         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
4173         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
4174         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
4175         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
4176         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
4177         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
4178         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
4179         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
4180         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
4181
4182         * WebView/WebFrameView.mm:
4183         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
4184
4185         * WebView/WebView.mm:
4186         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
4187         (-[WebView alwaysShowVerticalScroller]): Ditto.
4188         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
4189         (-[WebView alwaysShowHorizontalScroller]): Ditto.
4190
4191 2008-03-11  Darin Adler  <darin@apple.com>
4192
4193         Reviewed by Sam.
4194
4195         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
4196
4197         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
4198         bridge methods.