2010-02-08 Maciej Stachowiak <mjs@apple.com>
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Cameron Zwarich.
4
5         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
6         https://bugs.webkit.org/show_bug.cgi?id=34698
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2010-02-09  Alexey Proskuryakov  <ap@apple.com>
11
12         Reviewed by Geoffrey Garen.
13
14         https://bugs.webkit.org/show_bug.cgi?id=34490
15         WebCore::ImageEventSender::dispatchPendingEvents() crashes in certain conditions
16
17         * ForwardingHeaders/wtf/ValueCheck.h: Added.
18
19 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
20
21         Reviewed by Kenneth Rohde Christiansen.
22
23         Support frameset flattening
24         https://bugs.webkit.org/show_bug.cgi?id=32717
25
26         Add support for enabling/disabling FrameSet Flattening on the Mac port.
27
28         * WebView/WebPreferenceKeysPrivate.h:
29         * WebView/WebPreferences.mm:
30         (+[WebPreferences initialize]):
31         (-[WebPreferences isFrameSetFlatteningEnabled]):
32         (-[WebPreferences setFrameSetFlatteningEnabled:]):
33         * WebView/WebPreferencesPrivate.h:
34         * WebView/WebView.mm:
35         (-[WebView _preferencesChangedNotification:]):
36
37 2010-02-09  Alexey Proskuryakov  <ap@apple.com>
38
39         Reviewed by Anders Carlsson.
40
41         https://bugs.webkit.org/show_bug.cgi?id=34771
42         A stray mouse moved event is sent to plug-ins after mouse exit
43
44         * WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::handleEvent): A mouseout
45         DOM event is dispatched while handling NSMouseMoved - but we shouldn't be sending a
46         mouse moved event to plug-ins at this point.
47
48 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
49
50         Reviewed by Darin Adler.
51
52         Provide a way to get total number of pages to be printed
53         https://bugs.webkit.org/show_bug.cgi?id=34699
54
55         * Misc/WebCoreStatistics.h:
56         * Misc/WebCoreStatistics.mm:
57         (-[WebFrame numberOfPages:pageWidthInPixels:]):
58
59 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
60
61         Reviewed by Darin Adler.
62
63         https://bugs.webkit.org/show_bug.cgi?id=34727
64         Assertion crashes and freezes when plug-in property access results in an exception
65
66         * Plugins/Hosted/WebKitPluginClient.defs: Made PCSetProperty and PCRemoveProperty async.
67         A plug-in can call back whil processing this call (e.g. for NPN_SetException), so we need
68         to listen for messages while waiting for reply.
69
70         * Plugins/Hosted/NetscapePluginHostProxy.mm:
71         (WKPCEvaluate): If there is no instance proxy, return KERN_FAILURE. This improves consistency
72         between method implementations, and leaves us with one less IPC call to make in failure case
73         (returning false with KERN_SUCCESS and returning KERN_FAILURE looks the same from plugin
74         host code).
75         (WKPCInvoke): Ditto.
76         (WKPCInvokeDefault): Ditto.
77         (WKPCGetProperty): Ditto.
78         (WKPCSetProperty): Send a reply once done.
79         (WKPCRemoveProperty): Ditto.
80         (WKPCHasProperty): If there is no instance proxy, return KERN_FAILURE.
81         (WKPCHasMethod): Ditto.
82         (WKPCEnumerate): Ditto.
83
84 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
85
86         Reviewed by Anders Carlsson.
87
88         <rdar://problem/6530010> OOP: Support NPN_SetException
89
90         Tested by plugins/netscape-throw-exception.html (removed it from skipped list).
91
92         * Plugins/Hosted/NetscapePluginHostProxy.mm:
93         (WKPCSetException):
94         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
95         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
96         (WebKit::globalExceptionString):
97         (WebKit::NetscapePluginInstanceProxy::setGlobalException):
98         (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
99         * Plugins/Hosted/ProxyInstance.mm:
100         (WebKit::ProxyInstance::invoke):
101         (WebKit::ProxyInstance::getPropertyNames):
102         (WebKit::ProxyInstance::fieldValue):
103         (WebKit::ProxyInstance::setFieldValue):
104         * Plugins/Hosted/WebKitPluginClient.defs:
105         Route exception string to a global that's checked after calling into plug-in (just like in
106         in-process case).
107
108 2010-02-05  Kevin Decker  <kdecker@apple.com>
109
110         Reviewed by Mark Rowe.
111
112         https://bugs.webkit.org/show_bug.cgi?id=34661
113         <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden
114         
115         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
116         (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
117         * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
118         * Plugins/WebBaseNetscapePluginView.mm:
119         (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
120         (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
121         * Plugins/WebNetscapePluginView.mm:
122         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
123
124 2010-02-04  Mark Rowe  <mrowe@apple.com>
125
126         Rubber-stamped by Dan Bernstein.
127
128         Fix the ability to #include <WebKit/DOMFile.h>.
129
130         * MigrateHeaders.make: Mark DOMBlob.h as a public header since the already-public DOMFile.h depends on it.
131
132 2010-02-04  John Sullivan  <sullivan@apple.com>
133
134         https://bugs.webkit.org/show_bug.cgi?id=34611
135         WebLocalizedString() could use an assertion that it is being called on the main thread
136
137         Reviewed by Tim Hatcher.
138
139         * Misc/WebLocalizableStrings.m: Removed.
140         * Misc/WebLocalizableStrings.mm: Copied from mac/Misc/WebLocalizableStrings.m.
141         Renamed to use .mm extension so it can include a C++ header.
142         (WebLocalizedString):
143         Added an assertion that this is being called on the main thread.
144
145 2010-02-04  Dan Bernstein  <mitz@apple.com>
146
147         Reviewed by Simon Fraser.
148
149         REGRESSION (r53718): When scrolling a tall window by page, the overlap between pages is too big
150         https://bugs.webkit.org/show_bug.cgi?id=34371
151
152         * WebView/WebFrameView.mm:
153         (-[WebFrameView _verticalPageScrollDistance]): Use Scrollbar methods instead of
154         constants, and cap the scroll distance.
155         (-[WebFrameView initWithFrame:]): Use Scrollbar::pixelsPerLineStep() instead of
156         cScrollbarPixelsPerLineStep.
157         (-[WebFrameView _horizontalPageScrollDistance]):Use Scrollbar methods instead of
158         constants, and cap the scroll distance.
159
160 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
161
162         Reviewed by Eric Seidel.
163
164         Provide a way to get page number with layoutTestController
165         https://bugs.webkit.org/show_bug.cgi?id=33840
166
167         * Misc/WebCoreStatistics.h:
168         * Misc/WebCoreStatistics.mm:
169         (-[WebFrame pageNumberForElement:element:pageWidth:]):
170
171 2010-01-29  Gavin Barraclough  <barraclough@apple.com>
172
173         Reviewed by Sam Weinig + Oliver Hunt.
174
175         Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
176
177         Pass processeing user gensture flag to media play/pause methods.
178
179         * WebView/WebVideoFullscreenHUDWindowController.mm:
180         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
181
182 2010-02-01  Dan Bernstein  <mitz@apple.com>
183
184         Reviewed by Anders Carlsson.
185
186         <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse()
187
188         The crash was caused by having two streams with a streamID of 1.
189
190         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
191         (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
192         correctly increments m_currentURLRequestID to account for the manual stream.
193         (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
194         null it out instead of trying to remove it from the map. Added an assertion.
195         (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
196
197 == Rolled over to ChangeLog-2010-01-29 ==