WebKit/mac/ChangeLog

   1 2008-05-04  David Kilzer  <ddkilzer@apple.com>
   2
   3         Make parameters match for WebChromeClient::addMessageToConsole()
   4
   5         Reviewed by John.
   6
   7         * WebCoreSupport/WebChromeClient.h:
   8         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
   9         to sourceURL to match implementation in WebChromeClient.mm.
  10
  11 2008-05-02  Anders Carlsson  <andersca@apple.com>
  12
  13         Reviewed by Mark.
  14
  15         Various Cocoa event model and 64-bit plug-in fixes.
  16
  17         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  18         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
  19         Set click count.
  20
  21         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
  22         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
  23         Don't try to get the mouse location for keyboard events.
  24
  25         * Plugins/WebPluginPackage.m:
  26         (-[WebPluginPackage initWithPath:]):
  27         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
  28
  29 2008-05-02  Anders Carlsson  <andersca@apple.com>
  30
  31         Reviewed by Sam.
  32
  33         The event union is now named.
  34
  35         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  36         (WebNetscapePluginEventHandlerCocoa::drawRect):
  37         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
  38         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
  39         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
  40         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
  41         (WebNetscapePluginEventHandlerCocoa::focusChanged):
  42
  43 2008-05-02  Anders Carlsson  <andersca@apple.com>
  44
  45         Reviewed by Mark.
  46
  47         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
  48
  49         Call preflightAndReturnError on the bundle, which will check if any of the architectures
  50         in the bundle match the current architecture.
  51
  52         * Plugins/WebNetscapePluginPackage.m:
  53         (-[WebNetscapePluginPackage _initWithPath:]):
  54
  55 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
  56
  57         Reviewed by Geoffrey Garen.
  58
  59         https://bugs.webkit.org/show_bug.cgi?id=18826
  60         Make JavaScript heap per-thread
  61
  62         * Misc/WebCoreStatistics.mm:
  63         (+[WebCoreStatistics javaScriptObjectsCount]):
  64         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
  65         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
  66         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
  67         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
  68         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
  69         Replaced static Collector calls with calls to a current thread's instance.
  70
  71         * WebView/WebScriptDebugDelegate.mm:
  72         (-[WebScriptCallFrame evaluateWebScript:]):
  73         Pass ExecState to jsString().
  74
  75 2008-05-01  Anders Carlsson  <andersca@apple.com>
  76
  77         Reviewed by Mark.
  78
  79         64-bit NPAPI plugin build fixes.
  80
  81         * Plugins/WebBaseNetscapePluginView.mm:
  82         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
  83         (-[WebBaseNetscapePluginView updateAndSetWindow]):
  84         (-[WebBaseNetscapePluginView start]):
  85         (-[WebBaseNetscapePluginView windowBecameKey:]):
  86         * Plugins/WebNetscapeDeprecatedFunctions.c:
  87         * Plugins/WebNetscapeDeprecatedFunctions.h:
  88         * Plugins/WebNetscapePluginEventHandler.mm:
  89         (WebNetscapePluginEventHandler::create):
  90         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
  91         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
  92         * Plugins/WebPluginDatabase.m:
  93         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
  94
  95 2008-05-01  Anders Carlsson  <andersca@apple.com>
  96
  97         Reviewed by Tim.
  98
  99         Remove duplicate npfunctions.h header from WebKit.
 100
 101         * MigrateHeaders.make:
 102         Migrate npfunctions.h
 103
 104         * Plugins/npfunctions.h: Removed.
 105
 106 2008-05-01  Anders Carlsson  <andersca@apple.com>
 107
 108         Reviewed by John.
 109
 110         Add null checks for the event handler.
 111
 112         * Plugins/WebBaseNetscapePluginView.mm:
 113         (-[WebBaseNetscapePluginView stopTimers]):
 114         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 115
 116 2008-05-01  Anders Carlsson  <andersca@apple.com>
 117
 118         Fix 64-bit build.
 119
 120         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
 121         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 122         * WebCoreSupport/WebFrameLoaderClient.mm:
 123
 124 2008-05-01  Anders Carlsson  <andersca@apple.com>
 125
 126         Fix build.
 127
 128         * Plugins/npfunctions.h:
 129
 130 2008-05-01  Anders Carlsson  <andersca@apple.com>
 131
 132         Reviewed by Adam.
 133
 134         Forward mouse move events to the Netscape plug-in view.
 135
 136         * Plugins/WebBaseNetscapePluginView.h:
 137         * Plugins/WebBaseNetscapePluginView.mm:
 138         (-[WebBaseNetscapePluginView handleMouseMoved:]):
 139         New method that just calls the current event handler.
 140
 141         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 142         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 143         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
 144         don't work on it so don't call them.
 145
 146         * WebCoreSupport/WebFrameLoaderClient.mm:
 147         (NetscapePluginWidget::NetscapePluginWidget):
 148         New Widget subclass to be used for Netscape plug-ins.
 149
 150         (NetscapePluginWidget::handleEvent):
 151         Forward NSMouseMoved events to the plug-in.
 152
 153         (WebFrameLoaderClient::createPlugin):
 154         Wrap the plug-in view in a NetscapePluginWidget.
 155
 156 2008-05-01  Alp Toker  <alp@nuanti.com>
 157
 158         Rubber-stamped by Anders.
 159
 160         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
 161         npapi.h.
 162
 163         Additional fix to use same signedness in npapi.h and Mac for the
 164         interval parameter.
 165
 166         * Plugins/WebBaseNetscapePluginView.h:
 167         * Plugins/WebBaseNetscapePluginView.mm:
 168         (PluginTimer::PluginTimer):
 169         (-[WebBaseNetscapePluginView stopTimers]):
 170         (-[WebBaseNetscapePluginView restartTimers]):
 171         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 172         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 173         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 174         * Plugins/npapi.m:
 175         (NPN_ScheduleTimer):
 176         (NPN_UnscheduleTimer):
 177         * Plugins/npfunctions.h:
 178
 179 2008-04-30  Anders Carlsson  <andersca@apple.com>
 180
 181         Reviewed by Adam.
 182
 183         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
 184
 185         * Plugins/WebBaseNetscapePluginView.h:
 186         * Plugins/WebBaseNetscapePluginView.mm:
 187         (PluginTimer::PluginTimer):
 188         (PluginTimer::start):
 189         (PluginTimer::fired):
 190         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 191         (-[WebBaseNetscapePluginView stopTimers]):
 192         (-[WebBaseNetscapePluginView restartTimers]):
 193         (-[WebBaseNetscapePluginView scrollWheel:]):
 194         (-[WebBaseNetscapePluginView flagsChanged:]):
 195         (-[WebBaseNetscapePluginView start]):
 196         (-[WebBaseNetscapePluginView eventModel]):
 197         (-[WebBaseNetscapePluginView fini]):
 198         (-[WebBaseNetscapePluginView getVariable:value:]):
 199         (-[WebBaseNetscapePluginView setVariable:value:]):
 200         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 201         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 202         * Plugins/WebBaseNetscapePluginViewInternal.h:
 203         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 204         * Plugins/WebNetscapePluginEventHandler.h:
 205         * Plugins/WebNetscapePluginEventHandler.mm:
 206         (WebNetscapePluginEventHandler::create):
 207         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 208         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 209         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
 210         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
 211         (WebNetscapePluginEventHandlerCarbon::platformWindow):
 212         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
 213         (WebNetscapePluginEventHandlerCocoa::startTimers):
 214         (WebNetscapePluginEventHandlerCocoa::stopTimers):
 215         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
 216         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
 217         (WebNetscapePluginEventHandlerCocoa::drawRect):
 218         (WebNetscapePluginEventHandlerCocoa::mouseDown):
 219         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
 220         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
 221         (WebNetscapePluginEventHandlerCocoa::mouseExited):
 222         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
 223         (WebNetscapePluginEventHandlerCocoa::mouseUp):
 224         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
 225         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 226         (WebNetscapePluginEventHandlerCocoa::keyDown):
 227         (WebNetscapePluginEventHandlerCocoa::keyUp):
 228         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 229         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 230         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
 231         (WebNetscapePluginEventHandlerCocoa::focusChanged):
 232         (WebNetscapePluginEventHandlerCocoa::platformWindow):
 233         (WebNetscapePluginEventHandlerCocoa::sendEvent):
 234         * Plugins/WebNetscapePluginPackage.m:
 235         (-[WebNetscapePluginPackage load]):
 236         * Plugins/npapi.m:
 237         (NPN_ScheduleTimer):
 238         (NPN_UnscheduleTimer):
 239         * Plugins/npfunctions.h:
 240
 241 2008-04-30  Brady Eidson  <beidson@apple.com>
 242
 243         Fix my WebPreferences revert check-in
 244
 245         * WebView/WebView.mm:
 246         (-[WebView _preferencesChangedNotification:]):
 247
 248 2008-04-30  Brady Eidson  <beidson@apple.com>
 249
 250         Rubberstamped by John Sullivan
 251
 252         Revert the remainder of my original preferences changes from last week.
 253         They caused a massive PLT regression (too many notifications being sent out
 254         or listened to that weren't previously) and it's not in my schedule to refine
 255         the preferences code instead of working on my feature!
 256
 257         * WebView/WebView.mm:
 258         (-[WebView _updateSettingsFromPreferences:]):
 259         (-[WebView _commonInitializationWithFrameName:groupName:]):
 260
 261 2008-04-30  Anders Carlsson  <andersca@apple.com>
 262
 263         Fix the 64-bit build.
 264
 265         * Plugins/WebNetscapePluginEventHandler.h:
 266         * Plugins/WebNetscapePluginEventHandler.mm:
 267         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 268         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 269
 270 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
 271
 272         BUILD FIX for Release build.
 273
 274         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 275         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
 276         separately so the compiler doesn't complain about an unused variable.
 277         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
 278
 279 2008-04-29  Anders Carlsson  <andersca@apple.com>
 280
 281         Reviewed by Adam.
 282
 283         Refactor the Carbon event handling code out into a separate class in preparation for adding
 284         the Cocoa event handling code.
 285
 286         * Plugins/WebBaseNetscapePluginView.h:
 287         * Plugins/WebBaseNetscapePluginView.mm:
 288         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
 289         (-[WebBaseNetscapePluginView sendActivateEvent:]):
 290         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
 291         (-[WebBaseNetscapePluginView stopTimers]):
 292         (-[WebBaseNetscapePluginView restartTimers]):
 293         (-[WebBaseNetscapePluginView setHasFocus:]):
 294         (-[WebBaseNetscapePluginView mouseDown:]):
 295         (-[WebBaseNetscapePluginView mouseUp:]):
 296         (-[WebBaseNetscapePluginView mouseEntered:]):
 297         (-[WebBaseNetscapePluginView mouseExited:]):
 298         (-[WebBaseNetscapePluginView mouseDragged:]):
 299         (-[WebBaseNetscapePluginView keyUp:]):
 300         (-[WebBaseNetscapePluginView keyDown:]):
 301         (-[WebBaseNetscapePluginView cut:]):
 302         (-[WebBaseNetscapePluginView copy:]):
 303         (-[WebBaseNetscapePluginView paste:]):
 304         (-[WebBaseNetscapePluginView selectAll:]):
 305         (-[WebBaseNetscapePluginView start]):
 306         (-[WebBaseNetscapePluginView stop]):
 307         (-[WebBaseNetscapePluginView fini]):
 308         (-[WebBaseNetscapePluginView drawRect:]):
 309         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
 310         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
 311         (-[WebBaseNetscapePluginView windowBecameKey:]):
 312         (-[WebBaseNetscapePluginView windowResignedKey:]):
 313         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
 314         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
 315         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
 316         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
 317         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 318         (-[WebBaseNetscapePluginView _viewHasMoved]):
 319         * Plugins/WebBaseNetscapePluginViewInternal.h:
 320         * Plugins/WebNetscapePluginEmbeddedView.h:
 321         * Plugins/WebNetscapePluginEventHandler.h: Added.
 322         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
 323         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
 324         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
 325         * Plugins/WebNetscapePluginEventHandler.mm: Added.
 326         (WebNetscapePluginEventHandler::create):
 327         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
 328         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
 329         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
 330         (getCarbonEvent):
 331         (modifiersForEvent):
 332         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
 333         (WebNetscapePluginEventHandlerCarbon::drawRect):
 334         (WebNetscapePluginEventHandlerCarbon::mouseDown):
 335         (WebNetscapePluginEventHandlerCarbon::mouseUp):
 336         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
 337         (WebNetscapePluginEventHandlerCarbon::mouseExited):
 338         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
 339         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
 340         (WebNetscapePluginEventHandlerCarbon::keyDown):
 341         (keyMessageForEvent):
 342         (WebNetscapePluginEventHandlerCarbon::keyUp):
 343         (WebNetscapePluginEventHandlerCarbon::focusChanged):
 344         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
 345         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
 346         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
 347         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
 348         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
 349         (WebNetscapePluginEventHandlerCarbon::startTimers):
 350         (WebNetscapePluginEventHandlerCarbon::stopTimers):
 351         (WebNetscapePluginEventHandlerCarbon::sendEvent):
 352
 353 2008-04-29  Mark Rowe  <mrowe@apple.com>
 354
 355         Reviewed by David Harrison.
 356
 357         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
 358
 359         * WebKit.exp:
 360         * WebView/WebDynamicScrollBarsView.h:
 361         * WebView/WebDynamicScrollBarsView.m:
 362
 363 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
 364
 365         Reviewed by Darin.
 366
 367         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
 368
 369         * WebCoreSupport/WebChromeClient.h:
 370         * WebCoreSupport/WebChromeClient.mm:
 371         * WebView/WebClipView.m:
 372         (-[WebClipView scrollWheel:]):
 373         * WebView/WebHTMLView.mm:
 374         (-[WebHTMLView addMouseMovedObserver]):
 375         (-[WebHTMLView removeMouseMovedObserver]):
 376         (-[WebHTMLView acceptsFirstMouse:]):
 377         * WebView/WebUIDelegatePrivate.h:
 378         * WebView/WebView.mm:
 379         (-[WebViewPrivate init]):
 380         * WebView/WebViewPrivate.h:
 381
 382 2008-04-28  Rob Buis  <buis@kde.org>
 383
 384         Reviewed by Maciej.
 385
 386         Build fix for Tiger.
 387
 388         * WebView/WebView.mm:
 389         (WebKitInitializeApplicationCachePathIfNecessary):
 390
 391 2008-04-28  Adele Peterson  <adele@apple.com>
 392
 393         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
 394
 395         WebKit part of fix for <rdar://problem/3709505>
 396         Safari should have a way to upload bundles from the file upload control (as zip)
 397
 398         Added UIDelegate methods to let the application handle generating replacement files for uploads.
 399         In this case, Safari will create archived files for bundles so they can be uploaded properly.
 400
 401         * DefaultDelegates/WebDefaultUIDelegate.m:
 402         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
 403         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
 404         * WebCoreSupport/WebChromeClient.h:
 405         * WebCoreSupport/WebChromeClient.mm:
 406         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
 407         (WebChromeClient::generateReplacementFile):
 408         * WebView/WebUIDelegatePrivate.h:
 409
 410 2008-04-28  Anders Carlsson  <andersca@apple.com>
 411
 412         Reviewed by Sam, Mark, Adele and Darin.
 413
 414         Initialize the application cache path.
 415
 416         * WebView/WebView.mm:
 417         (WebKitInitializeApplicationCachePathIfNecessary):
 418         (-[WebView _commonInitializationWithFrameName:groupName:]):
 419
 420 2008-04-28  Alice Liu  <alice.liu@apple.com>
 421
 422         Reviewed by Darin.
 423
 424         Fix <rdar://problem/4911289> Add tabindex property to all children
 425         of HTMLElement (7138)
 426         http://bugs.webkit.org/show_bug.cgi?id=7138
 427
 428         * MigrateHeaders.make:
 429         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
 430         because now that focus() has been moved to DOMHTMLElement.h, these
 431         files are no longer needed.
 432
 433 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
 434
 435         Reviewed by Darin.
 436
 437         Fix run-webkit-tests --threading
 438         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
 439         Proxy server issue in Sunday's Nightly
 440
 441         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
 442         only done from icon database code, which is not robust enough.
 443
 444 2008-04-20 Adam Barth <hk9565@gmail.com>
 445
 446         Reviewed by Adam Roben and Sam Weinig.
 447
 448         Updated WebSecurityOrigin to match new SecurityOrigin API.
 449
 450         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
 451
 452         * Storage/WebSecurityOrigin.mm:
 453         (-[WebSecurityOrigin host]):
 454         (-[WebSecurityOrigin domain]):
 455         * Storage/WebSecurityOriginPrivate.h:
 456
 457 2008-04-25  Mark Rowe  <mrowe@apple.com>
 458
 459         Rubber-stamped by Sam Weinig.
 460
 461         Add some content to an empty ICU header file to prevent verification errors.
 462
 463         * icu/unicode/utf_old.h:
 464
 465 2008-04-25  Anders Carlsson  <andersca@apple.com>
 466
 467         Reviewed by Sam.
 468
 469         Add offlineWebApplicationCacheEnabled preference.
 470
 471         * WebView/WebPreferenceKeysPrivate.h:
 472         * WebView/WebPreferences.m:
 473         (+[WebPreferences initialize]):
 474         (-[WebPreferences offlineWebApplicationCacheEnabled]):
 475         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
 476         * WebView/WebPreferencesPrivate.h:
 477         * WebView/WebView.mm:
 478         (-[WebView _updateSettingsFromPreferences:]):
 479
 480 2008-04-24  Mark Rowe  <mrowe@apple.com>
 481
 482         Reviewed by Sam Weinig.
 483
 484         Remove code for calculating the glyph cache size.
 485
 486         * WebCoreSupport/WebSystemInterface.m:
 487         (InitWebCoreSystemInterface): Remove unused symbol.
 488
 489 2008-04-24  Mark Rowe  <mrowe@apple.com>
 490
 491         Reviewed by Sam Weinig.
 492
 493         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
 494
 495         * WebKitPrefix.h:
 496
 497 2008-04-24  Brady Eidson  <beidson@apple.com>
 498
 499         Reviewed by Darin
 500
 501         Fix layout test regressions from my earlier preferences/settings tweak.
 502
 503         * WebView/WebView.mm:
 504         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
 505           the notification to update the settings, each WebView still needs to register for the
 506           notification - restore that behavior.
 507
 508 2008-04-24  Dan Bernstein  <mitz@apple.com>
 509
 510         Reviewed by Darin Adler.
 511
 512         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
 513           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
 514
 515         * WebView/WebFrame.mm:
 516         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
 517         VisiblePosition::caretRect() instead of the RenderObject method which
 518         was removed.
 519
 520 2008-04-24  Brady Eidson  <beidson@apple.com>
 521
 522         Reviewed by Darin
 523
 524         Rework the Settings population again.
 525
 526         * WebView/WebView.mm:
 527         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
 528           and directly from WebView's common init function.
 529         (-[WebView _preferencesChangedNotification:]):
 530         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
 531           after creating the new Page
 532
 533 2008-04-24  Darin Adler  <darin@apple.com>
 534
 535         Reviewed by Geoff.
 536
 537         - fix crash in regression test where we'd ask a frame for a user agent string
 538           after the WebView was already closed
 539
 540         * WebCoreSupport/WebFrameLoaderClient.mm:
 541         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
 542         added some code to prevent the crash in release builds if this problem happens
 543         again.
 544
 545 2008-04-24  Anders Carlsson  <andersca@apple.com>
 546
 547         Reviewed by Sam.
 548
 549         Change some String arguments to be const references instead.
 550
 551         * WebCoreSupport/WebEditorClient.h:
 552         * WebCoreSupport/WebEditorClient.mm:
 553         (WebEditorClient::shouldInsertText):
 554
 555 2008-04-24  John Sullivan  <sullivan@apple.com>
 556
 557         Mac build fix
 558
 559         * WebCoreSupport/WebViewFactory.mm:
 560         (-[WebViewFactory AXButtonActionVerb]):
 561         implement this method using the text in WebCoreLocalizedStrings.cpp
 562         (-[WebViewFactory AXRadioButtonActionVerb]):
 563         ditto
 564         (-[WebViewFactory AXTextFieldActionVerb]):
 565         ditto
 566         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
 567         ditto
 568         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
 569         ditto
 570         (-[WebViewFactory AXLinkActionVerb]):
 571         ditto
 572
 573 2008-04-23  Brady Eidson  <beidson@apple.com>
 574
 575         Reviewed by Sam Weinig
 576
 577         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
 578         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
 579         thereby populating the Settings object, immediately after the Page is created.
 580
 581         * WebView/WebView.mm:
 582         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
 583
 584 2008-04-24  John Sullivan  <sullivan@apple.com>
 585
 586         Reviewed by Jess
 587
 588         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
 589
 590         * Misc/WebNSControlExtras.m:
 591         (-[NSControl sizeToFitAndAdjustWindowHeight]):
 592         deploy userSpaceScaleFactor when using view distances on the window
 593
 594 2008-04-22  Anders Carlsson  <andersca@apple.com>
 595
 596         Reviewed by Darin.
 597
 598         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
 599
 600         * Plugins/npfunctions.h:
 601
 602 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
 603
 604         Mysteriously reviewed by mitz|away.
 605
 606         Bug 18111: Closing a tab while dragging crashes Safari
 607         https://bugs.webkit.org/show_bug.cgi?id=18111
 608
 609         Null check the page before handling drag events.
 610
 611         * WebView/WebView.mm:
 612         (-[WebView draggingUpdated:]):
 613         (-[WebView draggingExited:]):
 614
 615 2008-04-19  Brady Eidson  <beidson@apple.com>
 616
 617         Reviewed by Tim Hatcher
 618
 619         Add a WebPreference for the path of the local storage persistent store.
 620
 621         * WebView/WebPreferenceKeysPrivate.h:
 622
 623         * WebView/WebPreferences.m:
 624         (-[WebPreferences _localStorageDatabasePath]):
 625         (-[WebPreferences _setLocalStorageDatabasePath:]):
 626         * WebView/WebPreferencesPrivate.h:
 627
 628         * WebView/WebView.mm:
 629         (-[WebView _preferencesChangedNotification:]):
 630
 631 2008-04-18  Brady Eidson  <beidson@apple.com>
 632
 633         Reviewed by Sam Weinig
 634
 635         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
 636         No reason to do the work twice...
 637
 638         * WebView/WebView.mm:
 639         (-[WebView _close]):
 640
 641 2008-04-17  Eric Seidel  <eric@webkit.org>
 642
 643         Reviewed by beth.
 644
 645         Rename Frame::renderer() to contentRenderer() and fix uses.
 646
 647         * Misc/WebCoreStatistics.mm:
 648         * WebView/WebRenderNode.mm:
 649         (-[WebRenderNode initWithWebFrameView:]):
 650
 651 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 652
 653         Reviewed by mrowe.
 654
 655         * WebView/WebFrame.mm: Remove temporary build fix.
 656
 657 2008-04-17  Mark Rowe  <mrowe@apple.com>
 658
 659         Reviewed by Dan Bernstein.
 660
 661         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
 662
 663         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
 664
 665         * WebCoreSupport/WebFrameLoaderClient.mm:
 666         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
 667
 668 2008-04-17  Mark Rowe  <mrowe@apple.com>
 669
 670         Rubber-stamped by Dan Bernstein.
 671
 672         Fix the Mac build.
 673
 674         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
 675         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
 676         for this to live going forward.
 677
 678 2008-04-15  Kevin Decker  <kdecker@apple.com>
 679
 680         Reviewed by Anders.
 681
 682         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
 683
 684         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
 685         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
 686         a bundle out from underneath itself.
 687
 688         * Plugins/WebBasePluginPackage.h: Added unload method.
 689         * Plugins/WebBasePluginPackage.m:
 690         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
 691         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
 692         * Plugins/WebNetscapePluginPackage.m:
 693         (-[WebNetscapePluginPackage unload]): Added.
 694
 695 2008-04-15  Anders Carlsson  <andersca@apple.com>
 696
 697         Reviewed by Adam.
 698
 699         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
 700
 701         * Configurations/WebKit.xcconfig:
 702
 703 2008-04-15  Brady Eidson  <beidson@apple.com>
 704
 705         Reviewed by John Sullivan
 706
 707         Do a more complete job adding the "WebArchiveDebugMode" pref
 708
 709         * WebView/WebPreferences.m: Add both getter *and* setter
 710         (-[WebPreferences webArchiveDebugModeEnabled]):
 711         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
 712         * WebView/WebPreferencesPrivate.h:
 713
 714         * WebView/WebView.mm:
 715         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
 716
 717 2008-04-14  Brady Eidson  <beidson@apple.com>
 718
 719         Reviewed by Anders
 720
 721         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
 722         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
 723         network and will instead fail the load as "cancelled."
 724
 725         * WebView/WebPreferenceKeysPrivate.h:
 726
 727         * WebView/WebPreferences.m:
 728         (+[WebPreferences initialize]):
 729         (-[WebPreferences _webArchiveDebugModeEnabled]):
 730         * WebView/WebPreferencesPrivate.h:
 731
 732         * WebView/WebView.mm:
 733         (-[WebView _preferencesChangedNotification:]):
 734
 735 2008-04-11  David Hyatt  <hyatt@apple.com>
 736
 737         Rename CachedResource ref/deref methods to addClient/removeClient.
 738
 739         Reviewed by olliej
 740
 741         * WebView/WebHTMLView.mm:
 742         (-[WebHTMLViewPrivate dealloc]):
 743         (-[WebHTMLViewPrivate finalize]):
 744         (-[WebHTMLViewPrivate clear]):
 745         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
 746
 747 2008-04-07  Brady Eidson  <beidson@apple.com>
 748
 749         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
 750
 751         * Configurations/WebKit.xcconfig:
 752
 753 2008-04-04  Adam Roben  <aroben@apple.com>
 754
 755         Use WebCore's ICU headers instead of our own copy
 756
 757         Rubberstamped by Tim Hatcher.
 758
 759         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
 760         PrivateHeaders.
 761
 762 2008-04-04  Adam Roben  <aroben@apple.com>
 763
 764         Fix <rdar://problem/5804776> Would like to use WebCore's
 765         ForwardingHeaders in WebKit without manually creating copies
 766
 767         Patch by Tim Hatcher, typed by me.
 768
 769         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
 770         WebCore's PrivateHeaders instead of our own copy.
 771
 772 2008-04-04  Ada Chan  <adachan@apple.com>
 773
 774         Now we pass width and height directly as integers to format
 775         the window title for a standalone image.
 776
 777         Reviewed by Dan.
 778
 779         * WebCoreSupport/WebViewFactory.mm:
 780         (-[WebViewFactory imageTitleForFilename:width:height:]):
 781
 782 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
 783
 784         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
 785
 786         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
 787           font-weight does not properly support graded weights
 788
 789         * WebView/WebHTMLView.mm:
 790         (-[WebHTMLView _styleFromFontAttributes:]):
 791         (-[WebHTMLView _originalFontB]):
 792         (-[WebHTMLView _addToStyle:fontA:fontB:]):
 793
 794 2008-04-02  Mark Rowe  <mrowe@apple.com>
 795
 796         Reviewed by Oliver Hunt.
 797
 798         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
 799
 800         * Configurations/Base.xcconfig:
 801
 802 2008-03-31  Alice Liu  <alice.liu@apple.com>
 803
 804         Reviewed by Darin.
 805
 806         * WebView/WebFrame.mm:
 807         (-[WebFrame _accessibilityTree]):
 808         The syntax for fetching an object from the AXObjectCache changed slightly
 809
 810 2008-03-31  Brady Eidson  <beidson@apple.com>
 811
 812         Reviewed by Jon Honeycutt
 813
 814         Move a WebArchive loading check into WebCore
 815
 816         * WebView/WebHTMLRepresentation.mm:
 817         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
 818           responsible for checking that state
 819
 820 2008-03-31  Brady Eidson  <beidson@apple.com>
 821
 822         Reviewed by Darin and Mitz's rubber stamp
 823
 824         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
 825
 826         * WebCoreSupport/WebEditorClient.mm:
 827         * WebCoreSupport/WebEditorClient.h:
 828
 829 2008-03-28  Brady Eidson  <beidson@apple.com>
 830
 831         Rubberstamped by Darin Adler
 832
 833         Remove WebArchiver.h/mm
 834
 835         * WebView/WebArchiver.h: Removed.
 836         * WebView/WebArchiver.mm: Removed.
 837
 838         * DOM/WebDOMOperations.mm:
 839         * WebCoreSupport/WebDragClient.mm:
 840         * WebCoreSupport/WebEditorClient.mm:
 841         * WebView/WebDataSource.mm:
 842         * WebView/WebHTMLView.mm:
 843
 844 2008-03-28  Brady Eidson  <beidson@apple.com>
 845
 846         Reviewed by Darin Adler
 847
 848         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
 849
 850         * WebCoreSupport/WebEditorClient.mm:
 851         (WebEditorClient::dataForArchivedSelection):
 852
 853         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
 854         * WebView/WebArchiver.mm: Ditto
 855
 856         * WebView/WebHTMLView.mm:
 857         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
 858
 859 2008-03-28  Brady Eidson  <beidson@apple.com>
 860
 861         Reviewed by Darin Adler
 862
 863         More Kit->Core WebArchive changes.
 864
 865         Create an archive from the current selection in a frame
 866
 867         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
 868           easily in a followup
 869
 870 2008-03-28  Brady Eidson  <beidson@apple.com>
 871
 872         Reviewed by Sam Weinig
 873
 874         WebArchive saga continues - Can now make archives from ranges in WebCore
 875
 876         * DOM/WebDOMOperations.mm:
 877         (-[DOMRange webArchive]):
 878         (-[DOMRange markupString]):
 879
 880         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
 881         * WebView/WebArchiver.mm:
 882
 883 2008-03-28  Brady Eidson  <beidson@apple.com>
 884
 885         Reviewed by Sam Weinig
 886
 887         More Kit->Core webarchive code movement
 888
 889         * DOM/WebDOMOperations.mm:
 890         (-[DOMNode markupString]): Call createFullMarkup() instead
 891
 892         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
 893         * WebView/WebFrameInternal.h: Ditto
 894
 895 2008-03-28  Brady Eidson  <beidson@apple.com>
 896
 897         Reviewed by Sam Weinig
 898
 899         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
 900
 901         * WebView/WebArchiver.h:
 902         * WebView/WebArchiver.mm:
 903         * WebView/WebDataSource.mm:
 904         (-[WebDataSource webArchive]):
 905
 906 2008-03-28  Brady Eidson  <beidson@apple.com>
 907
 908         Reviewed by Sam Weinig
 909
 910         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
 911
 912         * WebView/WebArchiver.h:
 913         * WebView/WebArchiver.mm:
 914
 915 2008-03-28  Brady Eidson  <beidson@apple.com>
 916
 917         Reviewed by Darin
 918
 919         "Yet another transitional step" to empty out WebKit-based code for archiving.
 920
 921         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
 922         entirely within WebCore, and opens the door to saving WebArchives on Windows.
 923
 924         * DOM/WebDOMOperations.mm:
 925         * WebView/WebArchiver.mm:
 926         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
 927
 928 2008-03-27  Brady Eidson  <beidson@apple.com>
 929
 930         Reviewed by Adam Roben
 931
 932         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
 933         as the push to core-ify WebArchives continues.
 934
 935         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.
 936         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
 937         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources
 938         (as in "while archiving a page") are accepting of null or empty data.
 939
 940         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
 941
 942         * WebView/WebDataSource.mm:
 943         (-[WebDataSource mainResource]): Call DocumentLoader implementation
 944         (-[WebDataSource subresources]): Ditto
 945         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
 946         * WebView/WebFrameInternal.h:
 947
 948 2008-03-27  Brady Eidson  <beidson@apple.com>
 949
 950         Reviewed by Adam
 951
 952         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
 953         (more efficient)
 954
 955         * WebView/WebResource.mm:
 956         (-[WebResource _initWithCoreResource:]):
 957         * WebView/WebResourceInternal.h:
 958
 959 2008-03-26  Brady Eidson  <beidson@apple.com>
 960
 961         Build fix - accidentally checked in this change which was work in progress
 962
 963         * DOM/WebDOMOperations.mm:
 964
 965 2008-03-26  Brady Eidson  <beidson@apple.com>
 966
 967         Reviewed by Darin
 968
 969         When we create a WebArchive, we walk every node from some starting point, asking each node
 970         along the way "What are your subresource URLs?"
 971
 972         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
 973         WebCore::Node
 974
 975         * DOM/WebDOMOperations.mm:
 976         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
 977           calling into individual WebCore::Node implementations
 978         * DOM/WebDOMOperationsPrivate.h:
 979
 980 2008-03-26  Brady Eidson  <beidson@apple.com>
 981
 982         Reviewed by Mark Rowe
 983
 984         Part of the continued push to move WebArchive-related code down to WebCore, this
 985         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
 986
 987         * WebView/WebDataSource.mm:
 988         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
 989
 990         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
 991           has now been ported down to WebCore
 992         * WebView/WebFrameInternal.h:
 993
 994 2008-03-26  Mark Rowe  <mrowe@apple.com>
 995
 996         Rubber-stamped by Brady Eidson.
 997
 998         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
 999
1000         * Configurations/WebKit.xcconfig:
1001
1002 2008-03-26  Mark Rowe  <mrowe@apple.com>
1003
1004         Reviewed by David Hyatt.
1005
1006         Make the Ahem font antialias correctly on Acid3 on Tiger.
1007
1008         * WebCoreSupport/WebSystemInterface.m:
1009         (InitWebCoreSystemInterface):
1010
1011 2008-03-26  Mark Rowe  <mrowe@apple.com>
1012
1013         Fix the Mac build.
1014
1015         * MigrateHeaders.make: Copy the newly generated header into the right place.
1016
1017 2008-03-25  Brady Eidson  <beidson@apple.com>
1018
1019         Reviewed by Beth Dakin
1020
1021         Remove entirely unused internal method
1022
1023         * WebView/WebArchiver.h:
1024         * WebView/WebArchiver.mm:
1025
1026 2008-03-25  Brady Eidson  <beidson@apple.com>
1027
1028         Reviewed by Adam Roben
1029
1030         <rdar://problem/5819308> - View Source is empty when view webarchives
1031
1032         * WebCore.base.exp:
1033         * loader/DocumentLoader.cpp:
1034         (WebCore::DocumentLoader::setParsedArchiveData):
1035         (WebCore::DocumentLoader::parsedArchiveData):
1036         * loader/DocumentLoader.h:
1037
1038         * loader/FrameLoader.cpp:
1039         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
1040           in the DocumentLoader
1041
1042 2008-03-25  Dan Bernstein  <mitz@apple.com>
1043
1044         Reviewed by Darin Adler.
1045
1046         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
1047           Reopen All Windows From Last Session causes crash
1048
1049         * WebView/WebHTMLView.mm:
1050         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
1051         check.
1052
1053 2008-03-25  Brady Eidson  <beidson@apple.com>
1054
1055         Reviewed by Jon Honeycutt's rubberstamp
1056
1057         Fix a leak with the new WebArchive setup
1058
1059         * WebView/WebArchive.mm:
1060         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
1061
1062 2008-03-25  Brady Eidson  <beidson@apple.com>
1063
1064         Reviewed by Darin
1065
1066         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
1067         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
1068
1069         * WebCoreSupport/WebFrameLoaderClient.h:
1070         * WebCoreSupport/WebFrameLoaderClient.mm:
1071         (WebFrameLoaderClient::WebFrameLoaderClient):
1072
1073 2008-03-25  Brady Eidson  <beidson@apple.com>
1074
1075         Reviewed by Darin
1076
1077         Remove newly obsolete FrameLoaderClient methods
1078
1079         * WebCoreSupport/WebFrameLoaderClient.h:
1080         * WebCoreSupport/WebFrameLoaderClient.mm:
1081
1082 2008-03-25  Brady Eidson  <beidson@apple.com>
1083
1084         Release build fix
1085
1086         * WebView/WebArchive.mm:
1087         (-[WebArchive subresources]):
1088         (-[WebArchive subframeArchives]):
1089
1090 2008-03-25  Brady Eidson  <beidson@apple.com>
1091
1092         Reviewed by Darin
1093
1094         <rdar://problem/4516169> - Support WebArchives on Windows
1095         And paves the way for many future WebArchive bug fixes and enhancements
1096
1097         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains
1098         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
1099          * WebArchive <-> LegacyWebArchive
1100          * WebResource <-> ArchiveResource
1101          * WebUnarchivingState <-> ArchiveResourceCollection
1102
1103         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
1104         and now exist in WebCore
1105
1106         * WebCoreSupport/WebFrameLoaderClient.mm:
1107         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
1108         (WebFrameLoaderClient::finalSetupForReplace):
1109         (WebFrameLoaderClient::setDefersLoading):
1110         (WebFrameLoaderClient::willUseArchive):
1111         (WebFrameLoaderClient::isArchiveLoadPending):
1112         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1113         (WebFrameLoaderClient::clearArchivedResources):
1114         (WebFrameLoaderClient::createFrame):
1115
1116         * WebView/WebArchive.mm:
1117         (+[WebArchivePrivate initialize]):
1118         (-[WebArchivePrivate init]):
1119         (-[WebArchivePrivate initWithCoreArchive:]):
1120         (-[WebArchivePrivate coreArchive]):
1121         (-[WebArchivePrivate setCoreArchive:]):
1122         (-[WebArchivePrivate dealloc]):
1123         (-[WebArchivePrivate finalize]):
1124         (-[WebArchive init]):
1125         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1126         (-[WebArchive initWithData:]):
1127         (-[WebArchive initWithCoder:]):
1128         (-[WebArchive encodeWithCoder:]):
1129         (-[WebArchive mainResource]):
1130         (-[WebArchive subresources]):
1131         (-[WebArchive subframeArchives]):
1132         (-[WebArchive data]):
1133         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
1134         (-[WebArchive WebCore::]):
1135         * WebView/WebArchiveInternal.h: Added.
1136
1137         * WebView/WebDataSource.mm:
1138         (-[WebDataSourcePrivate dealloc]):
1139         (-[WebDataSource _addSubframeArchives:]):
1140         (-[WebDataSource _documentFragmentWithArchive:]):
1141         (-[WebDataSource subresourceForURL:]):
1142         (-[WebDataSource addSubresource:]):
1143         * WebView/WebDataSourceInternal.h:
1144
1145         * WebView/WebFrame.mm:
1146         (-[WebFrame loadArchive:]):
1147         * WebView/WebFrameInternal.h:
1148
1149         * WebView/WebHTMLRepresentation.mm:
1150         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1151
1152         * WebView/WebResource.mm:
1153         (+[WebResourcePrivate initialize]):
1154         (-[WebResourcePrivate init]):
1155         (-[WebResourcePrivate initWithCoreResource:]):
1156         (-[WebResourcePrivate dealloc]):
1157         (-[WebResourcePrivate finalize]):
1158         (-[WebResource initWithCoder:]):
1159         (-[WebResource encodeWithCoder:]):
1160         (-[WebResource data]):
1161         (-[WebResource URL]):
1162         (-[WebResource MIMEType]):
1163         (-[WebResource textEncodingName]):
1164         (-[WebResource frameName]):
1165         (-[WebResource _initWithCoreResource:WebCore::]):
1166         (-[WebResource WebCore::]):
1167         (-[WebResource _ignoreWhenUnarchiving]):
1168         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1169         (-[WebResource _fileWrapperRepresentation]):
1170         (-[WebResource _response]):
1171         (-[WebResource _stringValue]):
1172         * WebView/WebResourceInternal.h: Added.
1173         * WebView/WebResourcePrivate.h:
1174
1175         * WebView/WebUnarchivingState.h: Removed.
1176         * WebView/WebUnarchivingState.m: Removed.
1177
1178 2008-03-24  Oliver Hunt  <oliver@apple.com>
1179
1180         Reviewed by Mark Rowe.
1181
1182         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
1183         <http://bugs.webkit.org/show_bug.cgi?id=18030>
1184
1185         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
1186         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
1187         <http://bugs.webkit.org/show_bug.cgi?id=18057>
1188
1189         * WebView/WebHTMLView.mm:
1190         (-[WebHTMLView keyDown:]):
1191
1192 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1193
1194         Reviewed by Maciej, landed by Brady
1195
1196         Bug 3580: iFrames Appear to be Cached
1197         <http://bugs.webkit.org/show_bug.cgi?id=3580>
1198
1199         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
1200         <http://bugs.webkit.org/show_bug.cgi?id=15486>
1201
1202         Bug 15554: Reload causes <object> to use old data
1203         <http://bugs.webkit.org/show_bug.cgi?id=15554>
1204
1205         If a page is reloaded, a child frame's URL can not be taken from a history item.
1206
1207         * WebView/WebFrame.mm:
1208         (-[WebFrame _loadURL:referrer:intoChild:]):
1209
1210 2008-03-24  Darin Adler  <darin@apple.com>
1211
1212         Reviewed by Beth.
1213
1214         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
1215
1216         * History/WebHistoryItem.mm:
1217         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
1218         * WebView/WebDataSource.mm:
1219         (-[WebDataSource _URL]): Ditto.
1220         (-[WebDataSource unreachableURL]): Ditto.
1221         * WebView/WebHTMLView.mm:
1222         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1223
1224         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1225         * History/WebHistory.mm:
1226         * Misc/WebElementDictionary.mm:
1227         * Misc/WebNSAttributedStringExtras.mm:
1228         Remove unneeded imports of KURL.h.
1229
1230 2008-03-24  Brady Eidson  <beidson@apple.com>
1231
1232         Reviewed by Darin's rubberstamp
1233
1234         Rename this file for upcoming work.
1235
1236         * WebView/WebArchive.m: Removed.
1237         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
1238
1239 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
1240
1241         Build fix.
1242
1243         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
1244
1245 2008-03-23  Oliver Hunt  <oliver@apple.com>
1246
1247         Reviewed by Maciej.
1248
1249         Bug 17670: Key events may improperly propagate from iframe to parent frame
1250         <http://bugs.webkit.org/show_bug.cgi?id=17670>
1251         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
1252         <http://bugs.webkit.org/show_bug.cgi?id=16381>
1253
1254         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
1255         as that results in us dispatching the key events for each frame going up the frame
1256         tree.
1257
1258         * WebView/WebHTMLView.mm:
1259         (-[WebHTMLView keyDown:]):
1260         (-[WebHTMLView keyUp:]):
1261         (-[WebHTMLView flagsChanged:]):
1262
1263 2008-03-21  Timothy Hatcher  <timothy@apple.com>
1264
1265         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
1266         http://bugs.webkit.org/show_bug.cgi?id=17980
1267
1268         Reviewed by Adam.
1269
1270         The new highlight drawing was not honoring the fade value, so it was
1271         always drawing at full opacity. The animation code didn't match Windows
1272         and the new highlight anyway, so it has been removed. The highlight
1273         how just detaches when it is hidden.
1274
1275         * WebCoreSupport/WebInspectorClient.mm:
1276         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
1277         (-[WebInspectorWindowController close]): Ditto.
1278         (-[WebInspectorWindowController highlightNode:]): Call attach.
1279         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
1280         * WebInspector/WebNodeHighlight.h:
1281         * WebInspector/WebNodeHighlight.m:
1282         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1283         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
1284         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
1285         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
1286         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
1287         * WebInspector/WebNodeHighlightView.h:
1288         * WebInspector/WebNodeHighlightView.m:
1289         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
1290
1291 2008-03-20  Mark Rowe  <mrowe@apple.com>
1292
1293         Reviewed by Sam Weinig.
1294
1295         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
1296         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
1297         command-line.
1298
1299         * Configurations/WebKit.xcconfig:
1300
1301 2008-03-20  Adam Roben  <aroben@apple.com>
1302
1303         Make WebNodeHighlightView use InspectorController to do its painting
1304
1305         Reviewed by Tim Hatcher.
1306
1307         * WebCoreSupport/WebInspectorClient.mm:
1308         (-[WebInspectorWindowController highlightNode:]): Pass the
1309         InspectorController to the WebNodeHighlight, and don't call
1310         setHighlightedNode: (which has been removed).
1311         (-[WebInspectorWindowController hideHighlight]): Removed call to
1312         setHighlightedNode:.
1313         * WebInspector/WebNodeHighlight.h:
1314           - Replaced _highlightNode with _inspectorController
1315           - Removed _highlightedNode accessors
1316           - Added -inspectorController method
1317         * WebInspector/WebNodeHighlight.m:
1318         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
1319         takes an InspectorController* and stores it in _inspectorController.
1320         (-[WebNodeHighlight dealloc]): Removed code dealing with
1321         _highlightedNode.
1322         (-[WebNodeHighlight inspectorController]): Added.
1323         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
1324         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
1325         GraphicsContexts to be based on a flipped CGContext, so we have to
1326         specify that this view is flipped.
1327         (-[WebNodeHighlightView drawRect:]): Changed to create a
1328         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
1329
1330 2008-03-18  David Hyatt  <hyatt@apple.com>
1331
1332         Add support for a preference in WebKit that can be used in nightly builds to test full page
1333         zoom.
1334
1335         Reviewed by Antti
1336
1337         * WebView/WebPreferenceKeysPrivate.h:
1338         * WebView/WebView.mm:
1339         (-[WebView setTextSizeMultiplier:]):
1340         (-[WebView canMakeTextSmaller]):
1341         (-[WebView makeTextSmaller:]):
1342         (-[WebView canMakeTextLarger]):
1343         (-[WebView makeTextLarger:]):
1344         (-[WebView canMakeTextStandardSize]):
1345         (-[WebView makeTextStandardSize:]):
1346
1347 2008-03-17  Eric Seidel  <eric@webkit.org>
1348
1349         Reviewed by darin.
1350
1351         Export _NPN_IntFromIdentifier as part of our NPAPI interface
1352
1353         * Plugins/WebNetscapePluginPackage.m:
1354         (-[WebNetscapePluginPackage load]):
1355
1356 2008-03-14  Brady Eidson  <beidson@apple.com>
1357
1358         Reviewed by Brian Dash's rubberstamp
1359
1360         Remove a class declaration for a class that has never existed
1361
1362         * WebView/WebResource.h:
1363
1364 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
1365
1366         Unify concept of enabling the Mac Java bridge.
1367
1368         Reviewed by Darin and Anders.
1369
1370         * Plugins/WebPluginJava.h: Removed unused file.
1371         * WebCoreSupport/WebFrameLoaderClient.h:
1372         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
1373         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
1374         (WebFrameLoaderClient::javaApplet): Ditto.
1375
1376 2008-03-13  Antti Koivisto  <antti@apple.com>
1377
1378         Reviewed by Darin.
1379
1380         * ForwardingHeaders/wtf/Deque.h: Added.
1381
1382 2008-03-13  Anders Carlsson  <andersca@apple.com>
1383
1384         Reviewed by Adam.
1385
1386         Call originalRequest, not initialRequest.
1387
1388         * WebView/WebDataSource.mm:
1389         (-[WebDataSource initialRequest]):
1390
1391 2008-03-12  Darin Adler  <darin@apple.com>
1392
1393         Reviewed by John Sullivan.
1394
1395         - cleanup after removing the bridge
1396
1397         * DOM/WebDOMOperations.mm:
1398         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
1399
1400         * Misc/WebCoreStatistics.mm:
1401         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
1402
1403         * Plugins/WebBaseNetscapePluginView.mm:
1404         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
1405         _frameLoader method.
1406         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1407         Ditto.
1408         * Plugins/WebPluginController.mm:
1409         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
1410
1411         * WebCoreSupport/WebFrameLoaderClient.mm:
1412         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
1413         method. Without this we could leave a stale frame pointer around.
1414         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
1415         caller of the _isMainFrame method.
1416         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
1417         _frameLoader method.
1418         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
1419
1420         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
1421         turned out to be unused.
1422         (core): Added overload for DocumentFragment.
1423         (kit): Ditto.
1424         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
1425         to FrameLoader with _private->coreFrame->loader().
1426         (-[WebFrame _attachScriptDebugger]): Ditto.
1427         (-[WebFrame _clearCoreFrame]): Added.
1428         (-[WebFrame _updateBackground]): More of the same.
1429         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
1430         (-[WebFrame _unmarkAllMisspellings]): Ditto.
1431         (-[WebFrame _hasSelection]): Ditto.
1432         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
1433         (-[WebFrame _findFrameWithSelection]): Ditto.
1434         (-[WebFrame _dataSource]): Ditto.
1435         (-[WebFrame _addData:]): Streamlined code a bit.
1436         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1437         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1438         (-[WebFrame _isDescendantOfFrame:]): Ditto.
1439         (-[WebFrame _bodyBackgroundColor]): Ditto.
1440         (-[WebFrame _isFrameSet]): Ditto.
1441         (-[WebFrame _firstLayoutDone]): Ditto.
1442         (-[WebFrame _loadType]): Ditto.
1443         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
1444         (-[WebFrame name]): Ditto.
1445         (-[WebFrame DOMDocument]): Ditto.
1446         (-[WebFrame frameElement]): Ditto.
1447         (-[WebFrame provisionalDataSource]): Ditto.
1448         (-[WebFrame dataSource]): Ditto.
1449         (-[WebFrame loadRequest:]): Ditto.
1450         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
1451         (-[WebFrame loadArchive:]): Ditto.
1452         (-[WebFrame stopLoading]): Ditto.
1453         (-[WebFrame reload]): Ditto.
1454         (-[WebFrame findFrameNamed:]): Ditto.
1455         (-[WebFrame parentFrame]): Ditto.
1456         (-[WebFrame childFrames]): Ditto.
1457         (-[WebFrame windowObject]): Ditto.
1458         (-[WebFrame globalContext]): Ditto.
1459
1460         * WebView/WebFrameInternal.h: Added overloads of core and kit.
1461         Removed method declarations.
1462
1463         * WebView/WebHTMLRepresentation.mm:
1464         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
1465         (formElementFromDOMElement): Ditto.
1466         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1467         (inputElementFromDOMElement): Ditto.
1468         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1469         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1470         (-[WebHTMLRepresentation formForElement:]): Ditto.
1471         (-[WebHTMLRepresentation currentForm]): Ditto.
1472         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1473         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1474         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1475
1476         * WebView/WebHTMLView.mm:
1477         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
1478         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1479         Call createFragmentFromText directly instead of via WebFrame.
1480         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1481         Moved layout calls here from WebFrame.
1482         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1483         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
1484         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
1485         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
1486         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
1487         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1488         Moved code here from WebFrame.
1489         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
1490         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1491         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1492         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1493         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1494         (-[WebHTMLView rectsForTextMatches]): Ditto.
1495
1496         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
1497
1498         * WebView/WebPDFView.mm:
1499         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
1500         _frameLoader method.
1501
1502         * WebView/WebRenderNode.mm:
1503         (copyRenderNode): Moved code here from WebFrame.
1504         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1505
1506         * WebView/WebResource.mm:
1507         (-[WebResource _stringValue]): Moved code here from WebFrame.
1508
1509         * WebView/WebView.mm:
1510         (-[WebView _close]): Use core function intsead of _frameLoader method.
1511         (-[WebView setCustomTextEncodingName:]): Ditto.
1512         (-[WebView setHostWindow:]): Moved code here from WebFrame.
1513         (aeDescFromJSValue): Moved this here from WebFrame.
1514         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
1515
1516 2008-03-12  Darin Adler  <darin@apple.com>
1517
1518         Reviewed by Anders.
1519
1520         - http://bugs.webkit.org/show_bug.cgi?id=17640
1521           eliminate WebCoreFrameBridge
1522
1523         Moved all the code from the bridge into WebFrame. This need not be the final
1524         home of these methods -- they can be moved closer to their callers and improved
1525         further -- but it eliminates the bridge without requiring a rewrite of the code.
1526         It's a fairly mechanical process (just adding underscores to method names really).
1527
1528         There's even a chance that some of the methods are unused. Those we can remove
1529         after checking if that's so.
1530
1531         * DOM/WebDOMOperations.mm:
1532         (-[DOMNode markupString]): Use WebFrame rather than bridge.
1533         (-[DOMDocument webFrame]): Changed to use the core and kit functions
1534         instead of using the bridge.
1535         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
1536         (-[DOMRange markupString]): Ditto.
1537         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
1538
1539         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
1540         * History/WebHistoryItem.mm: Ditto.
1541
1542         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
1543         * Misc/WebCoreStatistics.mm:
1544         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
1545
1546         * Misc/WebElementDictionary.mm: Removed unneeded import.
1547
1548         * Misc/WebKitStatistics.m:
1549         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
1550         * Misc/WebKitStatisticsPrivate.h: Ditto.
1551
1552         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
1553         * Misc/WebNSPasteboardExtras.mm: Ditto.
1554
1555         * Plugins/WebBaseNetscapePluginView.mm:
1556         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
1557         rather than bridge.
1558
1559         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
1560         * Plugins/WebNetscapePluginStream.mm: Ditto.
1561
1562         * Plugins/WebPluginContainerCheck.mm:
1563         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
1564         bridge to get to the WebCore::Frame.
1565
1566         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
1567         * Plugins/WebPluginController.mm:
1568         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
1569         rather than bridge.
1570
1571         * WebCoreSupport/WebEditorClient.mm:
1572         (selectorForKeyEvent): Tweaked comment.
1573
1574         * WebCoreSupport/WebFrameBridge.h: Removed.
1575         * WebCoreSupport/WebFrameBridge.mm: Removed.
1576
1577         * WebCoreSupport/WebFrameLoaderClient.mm:
1578         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
1579         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
1580         I could remove this function entirely, but it looks like the Qt port is using it.
1581
1582         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
1583
1584         * WebView/WebArchiver.mm:
1585         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
1586         (+[WebArchiver archiveNode:]): Ditto.
1587         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
1588
1589         * WebView/WebDataSource.mm:
1590         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
1591         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
1592         (-[WebDataSource subresources]): Ditto.
1593         (-[WebDataSource subresourceForURL:]): Ditto.
1594
1595         * WebView/WebDataSourceInternal.h: Removed _bridge method.
1596
1597         * WebView/WebFrame.mm:
1598         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
1599         (core): Go directly to the core frame, not via the bridge.
1600         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1601         Remove the code to deal with the bridge.
1602         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
1603         shouldCreateRenderers flag, formerly on the bridge.
1604         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
1605         (aeDescFromJSValue): Moved here from bridge.
1606         (-[WebFrame _domain]): Ditto.
1607         (-[WebFrame _addData:]): Ditto.
1608         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
1609         (-[WebFrame _nodesFromList:]): Ditto.
1610         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
1611         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
1612         (-[WebFrame _selectedString]): Ditto.
1613         (-[WebFrame _stringForRange:]): Ditto.
1614         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
1615         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1616         (-[WebFrame _sendScrollEvent]): Ditto.
1617         (-[WebFrame _drawRect:]): Ditto.
1618         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
1619         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
1620         (-[WebFrame _copyRenderNode:copier:]): Ditto.
1621         (-[WebFrame _copyRenderTree:]): Ditto.
1622         (inputElementFromDOMElement): Ditto.
1623         (formElementFromDOMElement): Ditto.
1624         (-[WebFrame _elementWithName:inForm:]): Ditto.
1625         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
1626         (-[WebFrame _elementIsPassword:]): Ditto.
1627         (-[WebFrame _formForElement:]): Ditto.
1628         (-[WebFrame _currentForm]): Ditto.
1629         (-[WebFrame _controlsInForm:]): Ditto.
1630         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
1631         (-[WebFrame _matchLabels:againstElement:]): Ditto.
1632         (-[WebFrame _URLWithAttributeString:]): Ditto.
1633         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1634         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
1635         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
1636         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
1637         (-[WebFrame _unmarkAllTextMatches]): Ditto.
1638         (-[WebFrame _rectsForTextMatches]): Ditto.
1639         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
1640         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
1641         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1642         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
1643         (-[WebFrame _firstRectForDOMRange:]): Ditto.
1644         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
1645         (-[WebFrame _baseURL]): Ditto.
1646         (-[WebFrame _stringWithData:]): Ditto.
1647         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
1648         (-[WebFrame _needsLayout]): Ditto.
1649         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
1650         (-[WebFrame _accessibilityTree]): Ditto.
1651         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
1652         (-[WebFrame _setDrawsBackground:]): Ditto.
1653         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1654         Ditto.
1655         (-[WebFrame _selectionGranularity]): Ditto.
1656         (-[WebFrame _convertToNSRange:]): Ditto.
1657         (-[WebFrame _convertToDOMRange:]): Ditto.
1658         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
1659         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
1660         (-[WebFrame _markDOMRange]): Ditto.
1661         (-[WebFrame _markedTextNSRange]): Ditto.
1662         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
1663         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1664         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1665         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
1666         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
1667         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
1668         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
1669         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
1670         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1671         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
1672         (-[WebFrame _visiblePositionForPoint:]): Ditto.
1673         (-[WebFrame _characterRangeAtPoint:]): Ditto.
1674         (-[WebFrame _typingStyle]): Ditto.
1675         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
1676         (-[WebFrame _fontForSelection:]): Ditto.
1677         (-[WebFrame _dragSourceMovedTo:]): Ditto.
1678         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
1679         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
1680         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
1681         (-[WebFrame _canProvideDocumentSource]): Ditto.
1682         (-[WebFrame _canSaveAsWebArchive]): Ditto.
1683         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1684         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
1685         function. Couldn't just keep the bridge method because this was already here with the same name.
1686         (-[WebFrame _selectedNSRange]): Ditto.
1687         (-[WebFrame _selectNSRange:]): Ditto.
1688         (-[WebFrame dealloc]): Remove bridge-related code.
1689         (-[WebFrame finalize]): Ditto.
1690
1691         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
1692         Removed the bridge parameter from the init method. Removed the #if blocks that
1693         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
1694         Removed the _bridge method.
1695
1696         * WebView/WebFrameView.mm: Removed the _bridge method.
1697
1698         * WebView/WebHTMLRepresentation.mm:
1699         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
1700         field.
1701         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
1702         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
1703         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
1704         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
1705         (-[WebHTMLRepresentation documentSource]): Ditto.
1706         (-[WebHTMLRepresentation DOMDocument]): Ditto.
1707         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1708         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1709         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1710         (-[WebHTMLRepresentation formForElement:]): Ditto.
1711         (-[WebHTMLRepresentation currentForm]): Ditto.
1712         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1713         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1714         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1715
1716         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
1717
1718         * WebView/WebHTMLView.mm:
1719         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
1720         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1721         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1722         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
1723         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
1724         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1725         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
1726         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1727         (-[WebHTMLView drawSingleRect:]): Ditto.
1728         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
1729         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1730         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1731         (-[WebHTMLView knowsPageRange:]): Ditto.
1732         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1733         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
1734         (-[WebHTMLView accessibilityHitTest:]): Ditto.
1735         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
1736         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
1737         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
1738         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
1739         (-[WebHTMLView startSpeaking:]): Ditto.
1740         (-[WebHTMLView _updateFontPanel]): Ditto.
1741         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
1742         (-[WebHTMLView _layoutIfNeeded]): Ditto.
1743         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1744         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1745         (-[WebHTMLView selectedRange]): Ditto.
1746         (-[WebHTMLView markedRange]): Ditto.
1747         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1748         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1749         (-[WebHTMLView insertText:]): Ditto.
1750         (-[WebTextCompleteController _insertMatch:]): Ditto.
1751         (-[WebTextCompleteController doCompletion]): Ditto.
1752         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
1753         (-[WebHTMLView string]): Ditto.
1754         (-[WebHTMLView selectedString]): Ditto.
1755         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1756         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1757         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1758         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1759         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1760         (-[WebHTMLView rectsForTextMatches]): Ditto.
1761         * WebView/WebRenderNode.mm:
1762         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1763         * WebView/WebResource.mm:
1764         (-[WebResource _stringValue]): Ditto.
1765
1766         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
1767
1768         * WebView/WebView.mm:
1769         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
1770         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
1771         (-[WebView _setInViewSourceMode:]): Ditto.
1772         (-[WebView _inViewSourceMode]): Ditto.
1773         (-[WebView _executeCoreCommandByName:value:]): Ditto.
1774         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
1775         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1776         (-[WebView scrollDOMRangeToVisible:]): Ditto.
1777         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
1778         (-[WebView setEditable:]): Ditto.
1779         (-[WebView setTypingStyle:]): Ditto.
1780         (-[WebView typingStyle]): Ditto.
1781         (-[WebView replaceSelectionWithNode:]): Ditto.
1782         (-[WebView replaceSelectionWithText:]): Ditto.
1783         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
1784         (-[WebView replaceSelectionWithArchive:]): Ditto.
1785         (-[WebView _insertNewlineInQuotedContent]): Ditto.
1786         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
1787
1788 2008-03-12  David Hyatt  <hyatt@apple.com>
1789
1790         Make the zoom factor a float and not a percent.
1791
1792         Reviewed by antti
1793
1794         * WebView/WebView.mm:
1795         (-[WebView _setZoomMultiplier:isTextOnly:]):
1796
1797 2008-03-11  David Hyatt  <hyatt@apple.com>
1798
1799         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
1800         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
1801         can zoom the page in, out or reset it to the standard size.
1802
1803         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
1804         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
1805         win.
1806
1807         Reviewed by Tim H.
1808
1809         * WebCoreSupport/WebFrameBridge.mm:
1810         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
1811         * WebView/WebDocumentInternal.h:
1812         * WebView/WebHTMLView.mm:
1813         (-[WebHTMLView viewDidMoveToSuperview]):
1814         * WebView/WebPDFView.h:
1815         * WebView/WebPDFView.mm:
1816         (-[WebPDFView _zoomOut:]):
1817         (-[WebPDFView _zoomIn:]):
1818         (-[WebPDFView _resetZoom:]):
1819         (-[WebPDFView _canZoomOut]):
1820         (-[WebPDFView _canZoomIn]):
1821         (-[WebPDFView _canResetZoom]):
1822         * WebView/WebView.mm:
1823         (-[WebViewPrivate init]):
1824         (-[WebView setTextSizeMultiplier:]):
1825         (-[WebView textSizeMultiplier]):
1826         (-[WebView _setZoomMultiplier:isTextOnly:]):
1827         (-[WebView _zoomMultiplier:]):
1828         (-[WebView _realZoomMultiplier]):
1829         (-[WebView _realZoomMultiplierIsTextOnly]):
1830         (-[WebView _canZoomOut:]):
1831         (-[WebView _canZoomIn:]):
1832         (-[WebView _zoomOut:isTextOnly:]):
1833         (-[WebView _zoomIn:isTextOnly:]):
1834         (-[WebView _canResetZoom:]):
1835         (-[WebView _resetZoom:isTextOnly:]):
1836         (-[WebView canMakeTextSmaller]):
1837         (-[WebView makeTextSmaller:]):
1838         (-[WebView canMakeTextLarger]):
1839         (-[WebView makeTextLarger:]):
1840         (-[WebView canMakeTextStandardSize]):
1841         (-[WebView makeTextStandardSize:]):
1842         (-[WebView setPageSizeMultiplier:]):
1843         (-[WebView pageSizeMultiplier]):
1844         (-[WebView canZoomPageIn]):
1845         (-[WebView zoomPageIn:]):
1846         (-[WebView canZoomPageOut]):
1847         (-[WebView zoomPageOut:]):
1848         (-[WebView canResetPageZoom]):
1849         (-[WebView resetPageZoom:]):
1850         (-[WebView _searchWithSpotlightFromMenu:]):
1851         * WebView/WebViewInternal.h:
1852         * WebView/WebViewPrivate.h:
1853
1854 2008-03-12  Dan Bernstein  <mitz@apple.com>
1855
1856         Reviewed by Darin Adler and Sam Weinig.
1857
1858         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
1859
1860         * WebCoreSupport/WebSystemInterface.m:
1861         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
1862         WKGetNSFontATSUFontId Tiger-only.
1863
1864 2008-03-12  Darin Adler  <darin@apple.com>
1865
1866         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
1867           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
1868
1869         * WebView/WebFrame.mm:
1870         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
1871         up pointer from the bridge to the frame. (My next check-in removes the bridge
1872         entirely, but we need this until then.)
1873
1874 2008-03-11  Darin Adler  <darin@apple.com>
1875
1876         Reviewed by Sam.
1877
1878         - remove all bridge-related things from WebCore except the bridge itself
1879
1880         * DOM/WebDOMOperations.mm:
1881         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
1882
1883         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
1884
1885         * Plugins/WebPluginController.mm: Ditto.
1886
1887         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
1888         init and close methods. Added a setWebFrame: method.
1889
1890         * WebCoreSupport/WebFrameBridge.mm:
1891         (-[WebFrameBridge setWebFrame:]): Added.
1892
1893         * WebCoreSupport/WebFrameLoaderClient.mm:
1894         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
1895         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
1896         bridge here. Soon we will be able to remove this entirely!
1897         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
1898         into WebFrame from the bridge.
1899
1900         * WebView/WebFrame.mm:
1901         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
1902         now owned by the frame.
1903         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
1904         debugger under GC without this!
1905         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
1906         use WebFrameLoaderClient instead of the bridge.
1907         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
1908         This is code that used to live in the bridge's init function.
1909         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
1910         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
1911         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
1912         the WebView is now the bridge's owner.
1913         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
1914         WebCore::Frame::bridge function directly to use the kit function instead.
1915         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
1916         This code won't last long -- we're eliminating the bridge soon.
1917         (-[WebFrame finalize]): Ditto.
1918
1919         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
1920         for creating frames.
1921
1922         * WebView/WebView.mm:
1923         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
1924         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
1925         where we have to allocate a WebFrameBridge and then immediately release it.
1926
1927 2008-03-11  Darin Adler  <darin@apple.com>
1928
1929         Reviewed by Anders.
1930
1931         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
1932
1933         * WebCoreSupport/WebFrameLoaderClient.mm:
1934         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
1935         to setView. A couple lines later, there is a call to _install, which sets the
1936         view to the scroll view.
1937
1938         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
1939
1940         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
1941         this file, since it's used by Safari.
1942         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
1943         * WebView/WebDynamicScrollBarsView.m:
1944         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
1945         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
1946         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
1947         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
1948         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
1949         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
1950         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
1951         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
1952         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
1953         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
1954         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
1955         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
1956         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
1957         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
1958         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
1959
1960         * WebView/WebFrameView.mm:
1961         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
1962
1963         * WebView/WebView.mm:
1964         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
1965         (-[WebView alwaysShowVerticalScroller]): Ditto.
1966         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
1967         (-[WebView alwaysShowHorizontalScroller]): Ditto.
1968
1969 2008-03-11  Darin Adler  <darin@apple.com>
1970
1971         Reviewed by Sam.
1972
1973         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
1974
1975         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
1976         bridge methods.
1977         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
1978         to recently-created functions.
1979         (WebChromeClient::firstResponder): Moved code here from the bridge.
1980         (WebChromeClient::makeFirstResponder): Ditto.
1981         (WebChromeClient::runOpenPanel): Ditto.
1982         (WebChromeClient::willPopUpMenu): Ditto.
1983
1984         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
1985         is related to creating the bridge and connecting it to WebCore, which will
1986         go next when I eliminate use of the bridge to get to/from the Frame*.
1987         * WebCoreSupport/WebFrameBridge.mm:
1988         (-[WebFrameBridge close]): Moved the code to track the bridge count here
1989         instead of the dealloc and finalize methods.
1990
1991 2008-03-11  Darin Adler  <darin@apple.com>
1992
1993         Reviewed by Mitz.
1994
1995         - update code affected by Range changes
1996
1997         * Misc/WebNSAttributedStringExtras.mm:
1998         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
1999         * WebView/WebHTMLRepresentation.mm:
2000         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2001         Use Range::create.
2002         * WebView/WebHTMLView.mm:
2003         (-[WebHTMLView attributedString]): Ditto.
2004
2005 2008-03-10  Darin Adler  <darin@apple.com>
2006
2007         Reviewed by Sam.
2008
2009         - eliminate keyboard UI mode method from WebCoreFrameBridge
2010
2011         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
2012         * WebCoreSupport/WebChromeClient.mm:
2013         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
2014         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
2015         fields for keyboard UI mode.
2016         * WebCoreSupport/WebFrameBridge.mm:
2017         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
2018         method.
2019         (-[WebFrameBridge finalize]): Ditto.
2020         * WebView/WebView.mm: Moved the keyboard mode code in here.
2021         (-[WebView _close]): Remove observer from the distributed notification
2022         center as well as the normal one.
2023         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
2024         here from the bridge.
2025         (-[WebView _keyboardUIMode]): Ditto.
2026         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
2027
2028 2008-03-10  Darin Adler  <darin@apple.com>
2029
2030         Reviewed by Sam.
2031
2032         - eliminate Java applet methods from WebCoreFrameBridge
2033
2034         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
2035         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
2036         the ones that load Java applets.
2037         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
2038         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2039
2040 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
2041
2042         Reviewed by Darin.
2043
2044         Done with Lars.
2045
2046         Simplified WebViewFactory's refreshPlugins method to only refresh the
2047         plugins and not reload the frames anymore since that's now done in a
2048         platform independent manner by WebCore::Page.
2049
2050         Also removed the now unused pluginNameForMIMEType and
2051         pluginSupportsMIMEType methods.
2052
2053         * WebCoreSupport/WebViewFactory.mm:
2054         * WebView/WebFrame.mm:
2055         * WebView/WebFrameInternal.h:
2056         * WebView/WebView.mm:
2057
2058 2008-03-08  Mark Rowe  <mrowe@apple.com>
2059
2060         Reviewed by Darin Adler.
2061
2062         Fix 64-bit build with GCC 4.2.
2063
2064         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
2065         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
2066         * History/WebHistoryItem.mm: Ditto.
2067         * Misc/WebElementDictionary.mm: Ditto.
2068         * WebCoreSupport/WebFrameLoaderClient.mm:
2069         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
2070         variable being unused in 64-bit.
2071         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
2072         * WebView/WebHTMLView.mm:
2073         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
2074         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
2075
2076 2008-03-08  Darin Adler  <darin@apple.com>
2077
2078         Reviewed by Adele.
2079
2080         - eliminate custom highlight methods from WebCoreFrameBridge
2081
2082         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
2083         * WebCoreSupport/WebChromeClient.mm:
2084         (WebChromeClient::customHighlightRect): Moved code here from bridge.
2085         (WebChromeClient::paintCustomHighlight): Ditto.
2086         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
2087
2088 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
2089
2090         Unify concept of enabling Netscape Plug-in API (NPAPI).
2091
2092         Reviewed by Darin.
2093
2094         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
2095
2096         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
2097         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
2098
2099         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
2100         #if ENABLE(NETSCAPE_PLUGIN_API).
2101         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
2102         * Plugins/WebBaseNetscapePluginView.h: Ditto.
2103         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
2104         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
2105         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
2106         * Plugins/WebBasePluginPackage.h: Ditto.
2107         * Plugins/WebBasePluginPackage.m: Ditto.
2108         (+[WebBasePluginPackage pluginWithPath:]):
2109         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
2110         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2111         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
2112         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
2113         * Plugins/WebNetscapePluginPackage.h: Ditto.
2114         * Plugins/WebNetscapePluginPackage.m: Ditto.
2115         * Plugins/WebNetscapePluginStream.h: Ditto.
2116         * Plugins/WebNetscapePluginStream.mm: Ditto.
2117         * Plugins/WebPluginDatabase.m: Ditto.
2118         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2119         * Plugins/npapi.m: Ditto.
2120         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2121         (WebFrameLoaderClient::objectContentType):
2122         (WebFrameLoaderClient::createPlugin):
2123         * WebView/WebHTMLView.mm: Ditto.
2124         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
2125         * WebView/WebHTMLViewInternal.h: Ditto.
2126
2127         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
2128         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
2129         category to (WebInternal) category so we don't expose the ENABLE() macro
2130         from the private header.
2131         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2132         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2133         * WebView/WebFrameInternal.h: Ditto.
2134         * WebView/WebFramePrivate.h: Ditto.
2135
2136 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
2137
2138         Reviewed by Darin.
2139
2140         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
2141         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
2142
2143         * WebView/WebPreferences.m:
2144         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
2145         the one used in Safari.
2146
2147 2008-03-07  Mark Rowe  <mrowe@apple.com>
2148
2149         Reviewed by Oliver Hunt.
2150
2151         Fix WebKit build with GCC 4.2.
2152
2153         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2154
2155 2008-03-07  Darin Adler  <darin@apple.com>
2156
2157         Reviewed by Adam.
2158
2159         - eliminated WebCoreFrameBridge runOpenPanel
2160
2161         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
2162         * WebCoreSupport/WebChromeClient.mm:
2163         (WebChromeClient::runOpenPanel): Added.
2164         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
2165         FileChooser so it can get a result from the UI delegate.
2166         (-[WebOpenPanelResultListener dealloc]): Added.
2167         (-[WebOpenPanelResultListener finalize]): Added.
2168         (-[WebOpenPanelResultListener cancel]): Added.
2169         (-[WebOpenPanelResultListener chooseFilename:]): Added.
2170
2171 2008-03-06  Darin Adler  <darin@apple.com>
2172
2173         Reviewed by Mitz.
2174
2175         - fix regression test failures from the visited-link change
2176
2177         * History/WebHistory.mm:
2178         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
2179         to turn off visited links if there is no history object. Also call
2180         removeAllVisitedLinks so we can start over from scratch with the new history.
2181
2182 2008-03-06  Dan Bernstein  <mitz@apple.com>
2183
2184         Reviewed by Darin Adler.
2185
2186         - fix a regression from r30741: a crash under
2187           WebFrameLoaderClient::createPlugin() when showing a Mail message with
2188           an attachment
2189
2190         * WebCoreSupport/WebFrameLoaderClient.mm:
2191         (WebFrameLoaderClient::createPlugin):
2192
2193 2008-03-06  Darin Adler  <darin@apple.com>
2194
2195         - fix Tiger build
2196
2197         * History/WebHistory.mm: Added include of WebTypesInternal.h.
2198
2199 2008-03-06  Darin Adler  <darin@apple.com>
2200
2201         - fix Release build
2202
2203         * History/WebHistory.mm:
2204         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
2205         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
2206         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
2207
2208 2008-03-06  Darin Adler  <darin@apple.com>
2209
2210         Reviewed by Mitz.
2211
2212         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
2213           REGRESSION: iframes are added to Safari's History menu
2214           by separating the visited link machinery from global history
2215
2216         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
2217         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
2218         method name, since it's on a private object.
2219         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
2220         PageGroup::removeAllVisitedLinks function if the last URL was removed.
2221         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
2222         method name, since it's on a private object.
2223         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
2224         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
2225         method name, since it's on a private object.
2226         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2227         Ditto.
2228         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
2229         to correctly return the error by using the newer version of writeToURL: and
2230         removed the FIXME about that.
2231         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
2232         for every link in the history.
2233         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
2234         (-[WebHistory addItem:]): Moved into the WebPrivate category.
2235         (-[WebHistory addItemForURL:]): Ditto.
2236         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
2237         create an item and already know its title.
2238         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
2239         (-[WebHistory containsItemForURLString:]): Ditto.
2240         (-[WebHistory removeItem:]): Ditto.
2241         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
2242         (-[WebHistory _itemForURLString:]): Ditto.
2243         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
2244
2245         * History/WebHistoryInternal.h: Added.
2246         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
2247         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
2248         Also reorganized what was left behind.
2249
2250         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
2251         * WebCoreSupport/WebChromeClient.mm:
2252         (WebChromeClient::populateVisitedLinks): Added a call to the new
2253         -[WebHistory _addVisitedLinksToPageGroup:] method.
2254
2255         * WebCoreSupport/WebFrameLoaderClient.mm:
2256         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
2257         -[WebHistory _addItemForURL:title:] method.
2258
2259 2008-03-05  Adam Roben  <aroben@apple.com>
2260
2261         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
2262
2263         Reviewed by Kevin M.
2264
2265         * WebView/WebFrame.mm:
2266         * WebView/WebScriptDebugDelegate.mm:
2267         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
2268         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
2269
2270 2008-03-05  Adam Roben  <aroben@apple.com>
2271
2272         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
2273
2274         Reviewed by Kevin M.
2275
2276         * WebView/WebCoreScriptDebuggerImp.h:
2277         * WebView/WebCoreScriptDebuggerImp.mm:
2278         * WebView/WebFrame.mm:
2279         (-[WebFrame _attachScriptDebugger]):
2280         * WebView/WebFrameInternal.h:
2281
2282 2008-03-05  Adam Roben  <aroben@apple.com>
2283
2284         Remove WebScriptDebugger
2285
2286         Uses of WebScriptDebugger have been replaced with
2287         WebCoreScriptDebuggerImp.
2288
2289         Reviewed by Kevin M.
2290
2291         * WebView/WebFrame.mm:
2292         (-[WebFramePrivate dealloc]): Use delete instead of release since
2293         WebCoreScriptDebuggerImp is a C++ class.
2294         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
2295         WebCoreScriptDebuggerImp.
2296         (-[WebFrame _detachScriptDebugger]): Ditto.
2297         * WebView/WebFrameInternal.h:
2298         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
2299         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
2300         * WebView/WebView.mm:
2301
2302 2008-03-05  Adam Roben  <aroben@apple.com>
2303
2304         Remove -webFrame and -globalObject from WebScriptDebugger
2305
2306         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
2307
2308         Reviewed by Kevin M.
2309
2310         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
2311         parameter to the constructor.
2312         * WebView/WebCoreScriptDebuggerImp.mm:
2313         (toWebFrame): Added.
2314         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
2315         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
2316         WindowScriptObject ourselves instead of asking WebScriptDebugger for
2317         it.
2318         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
2319         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
2320         (WebCoreScriptDebuggerImp::exception): Ditto.
2321         * WebView/WebScriptDebugDelegate.mm:
2322         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
2323         WebScriptDebuggerImp's constructor.
2324         * WebView/WebScriptDebugDelegatePrivate.h: Removed
2325         -webFrame/-globalObject.
2326
2327 2008-03-05  Adam Roben  <aroben@apple.com>
2328
2329         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
2330
2331         Reviewed by Kevin M.
2332
2333         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
2334         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
2335         lifetime.
2336         * WebView/WebCoreScriptDebuggerImp.mm:
2337           - Added declaration of -[WebScriptCallFrame
2338             _initWithGlobalObject:caller:state:].
2339           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
2340         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
2341         now-unnecessary initialization of m_topCallFrame.
2342         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
2343         with its implementation. The one difference between this
2344         implementation and the old enterFrame: method is that we don't hand
2345         our reference to m_topCallFrame to _initWithGlobalObject: -- that
2346         method must now retain the passed-in WebScriptCallFrame manually.
2347         (WebCoreScriptDebuggerImp::atStatement):
2348         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
2349         with its implementation.
2350         (WebCoreScriptDebuggerImp::exception):
2351         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
2352         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
2353         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
2354         to retain the passed-in caller.
2355         * WebView/WebScriptDebugDelegatePrivate.h:
2356           - Removed _current ivar
2357           - Removed enterFrame:/leaveFrame declarations.
2358
2359 2008-03-05  Adam Roben  <aroben@apple.com>
2360
2361         Remove -parsedSource: from WebScriptDebugger
2362
2363         Reviewed by Kevin M.
2364
2365         * WebView/WebCoreScriptDebuggerImp.mm:
2366         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
2367         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
2368         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
2369         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2370
2371 2008-03-05  Adam Roben  <aroben@apple.com>
2372
2373         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
2374
2375         Reviewed by Kevin M.
2376
2377         * WebView/WebCoreScriptDebuggerImp.mm:
2378         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
2379         trhough to callEvent instead of duplicating its code here.
2380         (WebCoreScriptDebuggerImp::callEvent): Moved code from
2381         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
2382         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
2383         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
2384         (WebCoreScriptDebuggerImp::exception): Moved code from
2385         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
2386         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
2387         -leavingFrame:, and -exceptionRaised:.
2388         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2389
2390 2008-03-05  Adam Roben  <aroben@apple.com>
2391
2392         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
2393
2394         Reviewed by Kevin M.
2395
2396         * WebView/WebCoreScriptDebuggerImp.mm:
2397         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
2398         -[WebScriptDebugger hitStatement:sourceId:line:].
2399         * WebView/WebScriptDebugDelegate.mm:
2400         (-[WebScriptDebugger webFrame]): Added.
2401         * WebView/WebScriptDebugDelegatePrivate.h:
2402
2403 2008-03-05  Adam Roben  <aroben@apple.com>
2404
2405         Remove WebCoreScriptDebugger
2406
2407         Reviewed by Kevin M.
2408
2409         * WebView/WebCoreScriptDebugger.h: Removed.
2410         * WebView/WebCoreScriptDebugger.mm: Removed.
2411         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
2412         with WebScriptDebugger.
2413         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
2414         delegate] with just m_debugger.
2415         (toNSString): Moved here from WebCoreScriptDebugger.mm.
2416         (toNSURL): Ditto.
2417         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2418         (WebCoreScriptDebuggerImp::sourceParsed):
2419         (WebCoreScriptDebuggerImp::callEvent):
2420         (WebCoreScriptDebuggerImp::atStatement):
2421         (WebCoreScriptDebuggerImp::returnEvent):
2422         (WebCoreScriptDebuggerImp::exception):
2423         * WebView/WebScriptDebugDelegate.mm:
2424         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
2425         WebCoreScriptDebuggerImp, so initialize it properly.
2426         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
2427         WebCoreScriptDebuggerImp.
2428
2429 2008-03-05  Adam Roben  <aroben@apple.com>
2430
2431         Move WebCoreScriptDebuggerImp to its own source files
2432
2433         Also changed WebCoreScriptDebuggerImp coding style to match our style
2434         guidelines.
2435
2436         Reviewed by Kevin M.
2437
2438         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
2439         function.
2440         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
2441         implementation.
2442         (toNSURL): Made no longer static.
2443         * WebView/WebCoreScriptDebuggerImp.h: Added.
2444         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
2445         WebCoreScriptDebugger.mm and cleaned up.
2446         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2447         (WebCoreScriptDebuggerImp::sourceParsed):
2448         (WebCoreScriptDebuggerImp::callEvent):
2449         (WebCoreScriptDebuggerImp::atStatement):
2450         (WebCoreScriptDebuggerImp::returnEvent):
2451         (WebCoreScriptDebuggerImp::exception):
2452
2453 2008-03-05  Adam Roben  <aroben@apple.com>
2454
2455         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
2456
2457         Reviewed by Kevin M.
2458
2459         * WebView/WebCoreScriptDebugger.h:
2460           - Removed newFrameWithGlobalObject:caller:state: from
2461             WebScriptDebugger protocol
2462           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
2463           - Removed _current ivar from WebCoreScriptDebugger
2464         * WebView/WebCoreScriptDebugger.mm:
2465         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
2466         the delegate.
2467         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
2468         * WebView/WebScriptDebugDelegate.mm:
2469         (-[WebScriptDebugger dealloc]): Added code to release _current.
2470         (-[WebScriptDebugger enterFrame:]): Added. Code came from
2471         WebCoreScriptDebugger.
2472         (-[WebScriptDebugger leaveFrame]): Ditto.
2473         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
2474
2475 2008-03-05  Adam Roben  <aroben@apple.com>
2476
2477         Remove WebCoreScriptCallFrame
2478
2479         Reviewed by Tim.
2480
2481         * WebView/WebCoreScriptDebugger.h:
2482           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2483           - Replaced -newWrapperForFrame: with
2484             -newFrameWithGlobalObject:caller:state:
2485           - Removed WebCoreScriptCallFrame interface.
2486         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
2487         with WebScriptCallFrame.
2488         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
2489         -newFrameWithGlobalObject:caller:state.
2490         (-[WebCoreScriptDebugger _leaveFrame]):
2491         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
2492         _private ivar to be of type WebScriptCallFramePrivate*.
2493         * WebView/WebScriptDebugDelegate.mm:
2494           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2495           - Added WebScriptCallFramePrivate
2496         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
2497         (-[WebScriptDebugger hitStatement:sourceId:line:]):
2498         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
2499         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
2500         (-[WebScriptCallFramePrivate dealloc]): Added.
2501         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
2502         Code came from WebCoreScriptCallFrame.
2503         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
2504         ivar.
2505         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
2506         _private with direct access of _private's ivars.
2507         (-[WebScriptCallFrame caller]): Ditto.
2508         (-[WebScriptCallFrame scopeChain]): Ditto.
2509         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2510
2511 2008-03-05  Adam Roben  <aroben@apple.com>
2512
2513         Move -_convertValueToObjcValue to WebScriptCallFrame
2514
2515         Reviewed by Darin.
2516
2517         * WebView/WebCoreScriptDebugger.h: Removed declaration of
2518         -_convertValueToObjcValue.
2519         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
2520         * WebView/WebScriptDebugDelegate.mm:
2521         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
2522         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
2523         (-[WebScriptCallFrame scopeChain]): Changed to call
2524         -_convertValueToObjcValue on self instead of _private.
2525         (-[WebScriptCallFrame exception]): Ditto.
2526         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2527
2528 2008-03-05  Adam Roben  <aroben@apple.com>
2529
2530         Move -exception and -evaluateWebScript: to WebScriptCallFrame
2531
2532         Reviewed by Darin.
2533
2534         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
2535         and -evaluateWebScript:.
2536         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
2537         -evaluateWebScript:.
2538         * WebView/WebScriptDebugDelegate.mm:
2539         (-[WebScriptCallFrame exception]): Added. Code came from
2540         -[WebCoreScriptCallFrame exception].
2541         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
2542         -[WebCoreScriptCallFrame evaluateWebScript:].
2543
2544 2008-03-05  Adam Roben  <aroben@apple.com>
2545
2546         Move -scopeChain to WebScriptCallFrame
2547
2548         Reviewed by Darin.
2549
2550         * WebView/WebCoreScriptDebugger.h:
2551           - Added declarations of -globalObject and -_convertValueToObjcValue:
2552             to WebCoreScriptCallFrame
2553           - Removed declaration of -scopeChain.
2554         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
2555         within the main WebCoreScriptCallFrame implementation.
2556         (-[WebCoreScriptCallFrame globalObject]): Added.
2557         * WebView/WebScriptDebugDelegate.mm:
2558         (-[WebScriptCallFrame scopeChain]): Added. Code came from
2559         -[WebCoreScriptCallFrame scopeChain].
2560
2561 2008-03-05  Adam Roben  <aroben@apple.com>
2562
2563         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
2564
2565         Reviewed by Darin.
2566
2567         * WebView/WebCoreScriptDebugger.h:
2568           - Removed #else case of #ifdef __cplusplus since this file is only
2569             ever used by C++ Objective-C files
2570           - Removed 'using KJS::ExecState' statement since we prefer not to
2571             have using statements in header files
2572           - Consequently prefixed uses of ExecState with KJS::
2573           - Added declaration of toNSString method that takes a const
2574             UString&
2575           - Added declaration of -[WebCoreScriptCallFrame state]
2576           - Removed declaration of -[WebCoreScriptCallFrame functionName]
2577         * WebView/WebCoreScriptDebugger.mm:
2578         (toNSString): Made this no longer static.
2579         (-[WebCoreScriptCallFrame state]): Added.
2580         * WebView/WebScriptDebugDelegate.mm:
2581         (-[WebScriptCallFrame functionName]): Added. Code came from
2582         -[WebCoreScriptCallFrame functionName], though I changed some nested
2583         ifs into early returns.
2584
2585 2008-03-05  Adam Roben  <aroben@apple.com>
2586
2587         Move WebCoreScriptDebugger to WebKit
2588
2589         Reviewed by Darin.
2590
2591         * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
2592         * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
2593         (toNSString):
2594         (toNSURL):
2595         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2596         (WebCoreScriptDebuggerImp::sourceParsed):
2597         (WebCoreScriptDebuggerImp::callEvent):
2598         (WebCoreScriptDebuggerImp::atStatement):
2599         (WebCoreScriptDebuggerImp::returnEvent):
2600         (WebCoreScriptDebuggerImp::exception):
2601         (+[WebCoreScriptDebugger initialize]):
2602         (-[WebCoreScriptDebugger initWithDelegate:]):
2603         (-[WebCoreScriptDebugger dealloc]):
2604         (-[WebCoreScriptDebugger finalize]):
2605         (-[WebCoreScriptDebugger delegate]):
2606         (-[WebCoreScriptDebugger _enterFrame:]):
2607         (-[WebCoreScriptDebugger _leaveFrame]):
2608         (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
2609         (-[WebCoreScriptCallFrame _setWrapper:]):
2610         (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
2611         (-[WebCoreScriptCallFrame dealloc]):
2612         (-[WebCoreScriptCallFrame wrapper]):
2613         (-[WebCoreScriptCallFrame caller]):
2614         (-[WebCoreScriptCallFrame scopeChain]):
2615         (-[WebCoreScriptCallFrame functionName]):
2616         (-[WebCoreScriptCallFrame exception]):
2617         (-[WebCoreScriptCallFrame evaluateWebScript:]):
2618         * WebView/WebScriptDebugDelegate.mm: Updated header path.
2619         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2620
2621 2008-03-05  Anders Carlsson  <andersca@apple.com>
2622
2623         Reviewed by Geoff.
2624
2625         Include file changes.
2626
2627         * Plugins/WebBaseNetscapePluginView.mm:
2628         * Plugins/WebNetscapePluginPackage.m:
2629
2630 2008-03-04  Timothy Hatcher  <timothy@apple.com>
2631
2632         Reviewed by Darin Adler.
2633
2634         <rdar://problem/5720160> Browser windows "do nothing" while modal
2635         dialog or menu is up due to run loop modes (or while scrolling)
2636
2637         Add new API that lets a WebView be scheduled with multiple runloops and modes.
2638         This lets loading continue when in a nested runloop or in a different mode.
2639
2640         * Misc/WebKitVersionChecks.h: Add a new version define:
2641         WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
2642         * WebView/WebView.mm:
2643         (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
2644         the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
2645         (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
2646         (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
2647         * WebView/WebViewPrivate.h: Add the new pending API methods.
2648
2649 2008-03-04  Anders Carlsson  <andersca@apple.com>
2650
2651         Reviewed by Darin.
2652
2653         Fix crash that happens when trying to load a page with a Java applet.
2654
2655         * WebCoreSupport/WebFrameLoaderClient.mm:
2656         Don't release the names and values array - the kit method returns an autoreleased array.
2657
2658 2008-03-04  Darin Adler  <darin@apple.com>
2659
2660         Reviewed by Adam.
2661
2662         - fix 200+ failing regression tests
2663         - fix http://bugs.webkit.org/show_bug.cgi?id=17668
2664           Vertical scrollbar at slashdot.org is randomly not shown
2665
2666         * WebCoreSupport/WebFrameLoaderClient.mm:
2667         (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
2668         code here to exactly match the way it was before it was moved from WebCore. I had
2669         introduced a storage leak and that was causing problems with scroll bars!
2670
2671 2008-03-04  Darin Adler  <darin@apple.com>
2672
2673         Reviewed by Adam.
2674
2675         - remove WebCoreFrameBridge reapplyStyles method
2676
2677         * WebView/WebHTMLView.mm:
2678         (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
2679
2680 2008-03-04  Darin Adler  <darin@apple.com>
2681
2682         Reviewed by Adam.
2683
2684         - eliminate WebCoreFrameBridge createFrameViewWithNSView
2685
2686         * WebCoreSupport/WebFrameLoaderClient.mm:
2687         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2688         Moved code here from createFrameViewWithNSView.
2689
2690 2008-03-04  Darin Adler  <darin@apple.com>
2691
2692         Reviewed by Adam.
2693
2694         - removed WebCoreFrameBridge scrollOverflowInDirection
2695
2696         * WebView/WebFrameView.mm:
2697         (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
2698         EventHandler directly instead of using the bridge.
2699         (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
2700         of the ones from the bridge.
2701         (-[WebFrameView scrollToEndOfDocument:]): Ditto.
2702         (-[WebFrameView _pageVertically:]): Ditto.
2703         (-[WebFrameView _pageHorizontally:]): Ditto.
2704         (-[WebFrameView _scrollLineVertically:]): Ditto.
2705         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
2706
2707 2008-03-04  Darin Adler  <darin@apple.com>
2708
2709         Reviewed by Adam.
2710
2711         - remove WebCoreFrameBridge installInFrame: method
2712
2713         * WebCoreSupport/WebFrameLoaderClient.mm:
2714         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2715         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2716         * WebView/WebFrameView.mm:
2717         (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
2718         (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
2719         method isn't nested inside an if statement. Call
2720         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2721         * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
2722         used in WebFrameLoaderClient.mm.
2723
2724 2008-03-04  Darin Adler  <darin@apple.com>
2725
2726         Reviewed by Adam.
2727
2728         - remove WebCoreFrameBridge window method
2729
2730         * WebCoreSupport/WebFrameBridge.mm: Removed window method.
2731
2732 2008-03-04  Darin Adler  <darin@apple.com>
2733
2734         Reviewed by Adam.
2735
2736         - move code from WebFrameBridge into WebFrameLoaderClient
2737
2738         * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
2739         to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
2740         removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
2741         redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
2742         * WebCoreSupport/WebFrameBridge.mm:
2743         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
2744         Changed to use WebCore::String.
2745         (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
2746         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
2747
2748         * WebCoreSupport/WebFrameLoaderClient.mm:
2749         (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
2750         and added a FIXME.
2751         (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
2752         (WebFrameLoaderClient::objectContentType): Ditto.
2753         (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
2754         (pluginView): Ditto.
2755         (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
2756
2757 2008-03-04  Darin Adler  <darin@apple.com>
2758
2759         Reviewed by Adam.
2760
2761         - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
2762
2763         * WebCoreSupport/WebChromeClient.h:
2764         * WebCoreSupport/WebChromeClient.mm:
2765         (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
2766         The WebCore side now calls this only when there's an actual change.
2767         * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
2768         * WebCoreSupport/WebFrameBridge.mm:
2769         (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
2770         Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
2771
2772 2008-03-04  Darin Adler  <darin@apple.com>
2773
2774         Reviewed by Adam.
2775
2776         - remove WebCoreFrameBridge issuePasteComand method
2777
2778         * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
2779         * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
2780
2781 2008-03-03  Darin Adler  <darin@apple.com>
2782
2783         Reviewed by Adam.
2784
2785         - some "cleanup" on the path to removing WebCoreFrameBridge
2786
2787         * Storage/WebDatabaseManager.mm: Tweak includes.
2788         * Storage/WebDatabaseTrackerClient.mm: Ditto.
2789         * Storage/WebSecurityOrigin.mm: Ditto.
2790         * Storage/WebSecurityOriginInternal.h: Ditto.
2791
2792         * WebView/WebFrame.mm:
2793         (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
2794         match WebCore::EditableLinkBehavior.
2795         * WebView/WebFrameInternal.h: Removed unused kit function.
2796
2797         * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
2798         * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
2799         * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
2800
2801         * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
2802
2803 2008-03-01  Mark Rowe  <mrowe@apple.com>
2804
2805         Reviewed by Tim Hatcher.
2806
2807         Update Xcode configuration to support building debug and release from the mysterious future.
2808
2809         * Configurations/DebugRelease.xcconfig:
2810
2811 2008-02-29  Mark Rowe  <mrowe@apple.com>
2812
2813         Reviewed by Anders Carlsson.
2814
2815         Replace use of WKPathFromFont with implementation in terms of public API.
2816
2817         * WebCoreSupport/WebSystemInterface.m:
2818         (InitWebCoreSystemInterface): Remove unused symbol.
2819
2820 2008-02-29  Mark Rowe  <mrowe@apple.com>
2821
2822         Reviewed by Oliver Hunt.
2823
2824         Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
2825
2826         * Misc/WebNSURLExtras.mm:
2827         (-[NSURL _webkit_canonicalize]):
2828         * WebKit.order:
2829
2830 2008-02-29  Mark Rowe  <mrowe@apple.com>
2831
2832         Reviewed by Oliver Hunt.
2833
2834         Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
2835
2836         * WebCoreSupport/WebSystemInterface.m:
2837         (InitWebCoreSystemInterface):
2838
2839 2008-02-29  Mark Rowe  <mrowe@apple.com>
2840
2841         Reviewed by Oliver Hunt.
2842
2843         Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
2844
2845         * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
2846         * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
2847         * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
2848         * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
2849         requires this class.
2850         * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
2851         of Safari that calls other obsolete methods.
2852         * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
2853         * WebView/WebHTMLView.mm:  Ditto.
2854         * WebView/WebPDFView.mm:  Ditto.
2855         * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
2856
2857 2008-02-29  Mark Rowe  <mrowe@apple.com>
2858
2859         Rubber-stamped by Eric Seidel.
2860
2861         Remove unneeded includes of WebKitSystemInterface.h.
2862
2863         * History/WebHistoryItem.mm:
2864         * Misc/WebNSViewExtras.m:
2865         * WebCoreSupport/WebFrameLoaderClient.mm:
2866         * WebView/WebDataSource.mm:
2867         * WebView/WebPDFView.mm:
2868
2869 2008-02-29  Mark Rowe  <mrowe@apple.com>
2870
2871         Reviewed by Oliver Hunt and Oliver Hunt.
2872
2873         <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
2874
2875         * WebCoreSupport/WebSystemInterface.m:
2876         (InitWebCoreSystemInterface):  Remove unused symbol.
2877         * WebKit.order:  Ditto.
2878
2879 2008-02-28  Mark Rowe  <mrowe@apple.com>
2880
2881         Reviewed by Dave Hyatt.
2882
2883         Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
2884
2885         * WebCoreSupport/WebSystemInterface.m:
2886         (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
2887
2888 2008-02-27  Brady Eidson  <beidson@apple.com>
2889
2890         Reviewed by Mark Rowe (code) and Darin (concept)
2891
2892         Much better fix for <rdar://problem/4930688> (see r19549)
2893         Original fix for <rdar://problem/3947312> (and 14 dupes)
2894
2895         Let me tell you a story:
2896         A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
2897         WebArchive code was intertwined with that code in bizarre and complex ways.
2898         During the months long loader re-factoring where we pushed much loader code down into WebCore,
2899         many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
2900         with a sole purpose.
2901
2902         One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
2903         to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the
2904         single entry point for almost all loading (network or web archives)
2905
2906         This method would check various headers and other fields on the NSURLRequest and NSURLResponse
2907         to make decisions about the load.  If the cache control fields were expired or other conditions
2908         in the headers were met, the load would be forced to go out to the network.
2909
2910         As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
2911         At some point, all that remained was the special cases for loading WebArchives.
2912
2913         Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
2914         to be WebArchive specific, further cementing the assumed design.
2915
2916         Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
2917         specific point in time.  Referring to the request to see if the resource should be reloaded seems
2918         nonsensical, as does referring to the response headers to see if the resource is "expired".  In the
2919         context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
2920         during the initial load!
2921
2922         After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
2923         cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
2924         that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
2925
2926         * WebCoreSupport/WebFrameLoaderClient.h:
2927         * WebCoreSupport/WebFrameLoaderClient.mm:
2928         (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
2929           inspect the request or response objects - We are loading from a WebArchive, and we should never
2930           make the decision to go out to the network when we actually have the resource available.
2931
2932         * WebCoreSupport/WebSystemInterface.m:
2933         (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit
2934
2935 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
2936
2937         Reviewed by Adam Roben.
2938
2939         Bug 14348: Messing up the inspector by dragging an URL into it
2940         http://bugs.webkit.org/show_bug.cgi?id=14348
2941         <rdar://problem/5283620> and <rdar://problem/5712808>
2942
2943         * WebCoreSupport/WebInspectorClient.mm:
2944         (-[WebInspectorWindowController init]): Remove duplicate preference setting.
2945         (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
2946
2947 2008-02-25  Darin Adler  <darin@apple.com>
2948
2949         Reviewed by Adam.
2950
2951         * WebView/WebArchiver.mm:
2952         (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
2953         * WebView/WebFrame.mm:
2954         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
2955         variable name URL to avoid clashing with the renamed KURL in the future. Also use
2956         blankURL.
2957         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
2958         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
2959         (-[WebFrame loadHTMLString:baseURL:]): Ditto.
2960         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
2961
2962 2008-02-24  Darin Adler  <darin@apple.com>
2963
2964         Reviewed by Sam.
2965
2966         - remove separate client calls for "standard" and "reload' history
2967
2968         * WebCoreSupport/WebFrameLoaderClient.h:
2969         * WebCoreSupport/WebFrameLoaderClient.mm:
2970         (WebFrameLoaderClient::updateGlobalHistory):
2971
2972 2008-02-23  Alexey Proskuryakov  <ap@webkit.org>
2973
2974         Reviewed by Darin.
2975
2976         Move basic threading support from WebCore to WTF.
2977
2978         * ForwardingHeaders/wtf/Threading.h: Added.
2979         * ForwardingHeaders/wtf/Locker.h: Added.
2980
2981 2008-02-23  David Kilzer  <ddkilzer@apple.com>
2982
2983         Please clarify licensing for some files
2984         <http://bugs.webkit.org/show_bug.cgi?id=14970>
2985
2986         Reviewed by Darin.
2987
2988         * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
2989         and added Apple BSD-style license.
2990         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2991
2992 2008-02-22  John Sullivan  <sullivan@apple.com>
2993
2994         Reviewed by Adam Roben
2995
2996         Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
2997         pasteAsPlainText: has the same behavior.
2998
2999         * WebView/WebHTMLView.mm:
3000         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
3001         (-[WebHTMLView readSelectionFromPasteboard:]):
3002         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3003         (-[WebHTMLView pasteAsRichText:]):
3004         (-[WebHTMLView paste:]):
3005         * WebView/WebView.mm:
3006         * WebView/WebViewPrivate.h:
3007
3008 2008-02-21  Anders Carlsson  <andersca@apple.com>
3009
3010         Reviewed by Sam.
3011
3012         Use BackForwardList::create instead.
3013
3014         * History/WebBackForwardList.mm:
3015         (-[WebBackForwardList init]):
3016
3017 2008-02-21  John Sullivan  <sullivan@apple.com>
3018
3019         Reviewed by Jessica Kahn
3020
3021         support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
3022
3023         * WebView/WebHTMLView.mm:
3024         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
3025         added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
3026         (-[WebHTMLView readSelectionFromPasteboard:]):
3027         pass NO for new matchStyle parameter to match old behavior
3028         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3029         validate pasteAndMatchStyle the same way as pasteAsRichText
3030         (-[WebHTMLView pasteAndMatchStyle:]):
3031         just like pasteAsRichText but passes YES for matchStyle
3032         (-[WebHTMLView pasteAsRichText:]):
3033         pass NO for new matchStyle parameter to match old behavior
3034         (-[WebHTMLView paste:]):
3035         ditto
3036
3037         * WebView/WebView.mm:
3038         added macro(pasteAndMatchStyle)
3039
3040         * WebView/WebViewPrivate.h:
3041         added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
3042
3043 2008-02-20  Sam Weinig  <sam@webkit.org>
3044
3045         Reviewed by Darin and Geoff.
3046
3047         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
3048
3049         * WebView/WebView.mm:
3050         (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
3051         There are currently no site-specific quirks on Mac, but we will propagate the state
3052         to WebCore to avoid possible mistakes later.
3053
3054 2008-02-19  Anders Carlsson  <andersca@apple.com>
3055
3056         Reviewed by Darin.
3057
3058         Move back WebKit methods that were unused in WebCore.
3059
3060         * Misc/WebNSURLExtras.mm:
3061         (+[NSURL _web_URLWithData:]):
3062         (+[NSURL _web_URLWithData:relativeToURL:]):
3063         (-[NSURL _web_originalData]):
3064         (-[NSURL _web_originalDataAsString]):
3065         (-[NSURL _web_isEmpty]):
3066         (-[NSURL _webkit_canonicalize]):
3067         (-[NSURL _webkit_URLByRemovingComponent:]):
3068         (-[NSURL _webkit_URLByRemovingFragment]):
3069         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3070         (-[NSURL _webkit_isFileURL]):
3071         (-[NSString _webkit_isFileURL]):
3072         * WebCoreSupport/WebFrameLoaderClient.mm:
3073         (WebFrameLoaderClient::setTitle):
3074         * WebCoreSupport/WebSystemInterface.m:
3075         (InitWebCoreSystemInterface):
3076
3077 2008-02-18  Darin Adler  <darin@apple.com>
3078
3079         Reviewed by Sam.
3080
3081         * Misc/WebNSAttributedStringExtras.mm:
3082         (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
3083         DeprecatedString.
3084
3085 2008-02-17  Sam Weinig  <sam@webkit.org>
3086
3087         Reviewed by Dan Bernstein.
3088
3089         Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
3090         document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
3091
3092         * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
3093         mistakenly not migrated.
3094
3095 2008-02-15  Dan Bernstein  <mitz@apple.com>
3096
3097         Reviewed by Alexey Proskuryakov.
3098
3099         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
3100           <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
3101
3102         * WebView/WebDataSource.mm:
3103         (+[WebDataSource _representationClassForMIMEType:]):
3104         (-[WebDataSource _responseMIMEType]):
3105         (-[WebDataSource subresources]):
3106         (-[WebDataSource subresourceForURL:]):
3107         * WebView/WebResource.mm:
3108         (-[WebResource _initWithData:URL:response:]):
3109         * WebView/WebResourcePrivate.h:
3110
3111 2008-02-15  Adam Roben  <aroben@apple.com>
3112
3113         Make WebKit's FEATURE_DEFINES match WebCore's
3114
3115         Reviewed by Mark.
3116
3117         * Configurations/WebKit.xcconfig:
3118
3119 2008-02-14  Darin Adler  <darin@apple.com>
3120
3121         Reviewed by Eric Seidel.
3122
3123         - updated for WebCore KURL changes
3124
3125         * History/WebHistoryItem.mm:
3126         (-[WebHistoryItem URL]): Removed getNSURL call.
3127         * Misc/WebElementDictionary.mm:
3128         (-[WebElementDictionary _absoluteImageURL]): Ditto.
3129         (-[WebElementDictionary _absoluteLinkURL]): Ditto.
3130         * Misc/WebNSAttributedStringExtras.mm:
3131         (fileWrapperForElement): Ditto.
3132         (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
3133         * Misc/WebNSURLExtras.mm:
3134         (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
3135         for function name change.
3136         * WebCoreSupport/WebContextMenuClient.mm:
3137         (WebContextMenuClient::downloadURL): Removed getNSURL call.
3138         * WebCoreSupport/WebDragClient.mm:
3139         (WebDragClient::createDragImageForLink): Ditto.
3140         * WebCoreSupport/WebFrameLoaderClient.mm:
3141         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
3142         (WebFrameLoaderClient::startDownload): Ditto.
3143         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
3144         (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
3145         (WebFrameLoaderClient::cancelledError): Ditto.
3146         (WebFrameLoaderClient::blockedError): Ditto.
3147         (WebFrameLoaderClient::cannotShowURLError): Ditto.
3148         (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
3149         (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
3150         (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
3151         (WebFrameLoaderClient::willUseArchive): Ditto.
3152         (WebFrameLoaderClient::setTitle): Ditto.
3153         (WebFrameLoaderClient::actionDictionary): Ditto.
3154         (WebFrameLoaderClient::createFrame): Ditto.
3155         (WebFrameLoaderClient::objectContentType): Ditto.
3156         (WebFrameLoaderClient::createPlugin): Ditto.
3157         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3158         * WebView/WebDataSource.mm:
3159         (-[WebDataSource _URL]): Ditto.
3160         (-[WebDataSource _initWithDocumentLoader:]): Ditto.
3161         (-[WebDataSource unreachableURL]): Ditto.
3162         * WebView/WebHTMLView.mm:
3163         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3164
3165 2008-02-14  Stephanie Lewis  <slewis@apple.com>
3166
3167         Reviewed by Geoff.
3168
3169         Update order files.
3170
3171         * WebKit.order:
3172
3173 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
3174
3175         Reviewed by Adam Roben.
3176
3177         http://bugs.webkit.org/show_bug.cgi?id=17207
3178         Database example doesn't work (requires not-yet-released Safari)
3179
3180         * WebCoreSupport/WebChromeClient.mm:
3181         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
3182         if it's too old.
3183
3184 2008-02-11  Darin Adler  <darin@apple.com>
3185
3186         - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
3187           incorrectly due to visibility fix
3188
3189         Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
3190
3191         * Misc/WebKitVersionChecks.h: Removed the constant.
3192
3193         * WebView/WebView.mm:
3194         (-[WebView _needsXcodeVisibilityQuirk]): Removed.
3195         (-[WebView _preferencesChangedNotification:]): Removed call to
3196         setNeedsXcodeVisibilityQuirk.
3197
3198 2008-02-12  Anders Carlsson  <andersca@apple.com>
3199
3200         Reviewed by Mitz.
3201
3202         * WebCoreSupport/WebFrameBridge.mm:
3203         * WebCoreSupport/WebViewFactory.mm:
3204         (-[WebViewFactory imageTitleForFilename:size:]):
3205         Move implementation from WebFrameBridge to WebViewFactory.
3206
3207 2008-02-11  Darin Adler  <darin@apple.com>
3208
3209         Reviewed by Mitz.
3210
3211         - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
3212           incorrectly due to visibility fix
3213
3214         Added an Xcode-specific quirk.
3215
3216         * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
3217         part of the check.
3218
3219         * WebView/WebView.mm:
3220         (-[WebView _needsXcodeVisibilityQuirk]): Added.
3221         (-[WebView _preferencesChangedNotification:]): Added a call to
3222         setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
3223
3224 2008-02-10  Darin Adler  <darin@apple.com>
3225
3226         - fix http://bugs.webkit.org/show_bug.cgi?id=17274
3227           REGRESSION: User Agent string broken in r30119
3228
3229         * WebView/WebView.mm:
3230         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
3231         Fix wrong variable name. Doh!
3232
3233 2008-02-09  Darin Adler  <darin@apple.com>
3234
3235         Reviewed by Tim Hatcher.
3236
3237         - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
3238
3239         * WebView/WebView.mm:
3240         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
3241         garbage collector's Objective C++ support by not initializing a static to an object
3242         that needs to be marked when running under GC.
3243
3244 2008-02-05  Dan Bernstein  <mitz@apple.com>
3245
3246         Reviewed by Darin Adler.
3247
3248         - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
3249
3250         The key bindings are Command-Control-left arrow and
3251         Command-Control-right arrow. To match AppKit, the bindings are enabled
3252         only when certain user defaults are set.
3253
3254         * WebView/WebHTMLView.mm:
3255         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3256         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
3257         Frame::baseWritingDirectionForSelectionStart() and
3258         Editor::setBaseWritingDirection() directly.
3259         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
3260         (writingDirectionKeyBindingsEnabled): Added.
3261         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
3262         method.
3263         (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
3264         (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
3265         * WebView/WebView.mm:
3266
3267 2008-02-05  Mark Rowe  <mrowe@apple.com>
3268
3269         Unreviewed build fix.
3270
3271         * WebView/WebView.mm: Add missing #import.
3272
3273 2008-02-05  Mark Rowe  <mrowe@apple.com>
3274
3275         Reviewed by Oliver Hunt.
3276
3277         Update versioning to support the mysterious future.
3278
3279         * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
3280
3281 2008-01-30  Justin Garcia  <justin.garcia@apple.com>
3282
3283         Reviewed by Darin Adler.
3284
3285         <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
3286
3287         * WebView/WebHTMLView.mm:
3288         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
3289         this back, it's used by Mail.
3290         (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
3291         also used by Mail.  Moved to WebPrivate.
3292         * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
3293         accidently remove them in the future.
3294
3295 2008-01-30  Mark Rowe  <mrowe@apple.com>
3296
3297         Reviewed by Oliver Hunt.
3298
3299         Move off deprecated NSTableView methods.
3300
3301         * WebView/WebHTMLView.mm:
3302         (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
3303         (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
3304         (-[WebTextCompleteController filterKeyDown:]): Ditto.
3305
3306 2008-01-26  Mark Rowe  <mrowe@apple.com>
3307
3308         Reviewed by Darin Adler.
3309
3310         Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
3311
3312         * Misc/WebNSDataExtras.m:
3313         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
3314         to the new CFString so that they will be freed when no longer needed.
3315
3316 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
3317
3318         <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
3319
3320         Reviewed by Darin.
3321
3322         * WebCoreSupport/WebDashboardRegion.h: Removed.
3323         * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
3324
3325 2008-01-21  Darin Adler  <darin@apple.com>
3326
3327         Reviewed by John Sullivan.
3328
3329         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
3330         - add a missing export of WebDatabaseExpectedSizeKey
3331         - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
3332
3333         * Storage/WebDatabaseManager.mm:
3334         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
3335         name instead of calling isValid().
3336         (-[WebDatabaseManager deleteOrigin:]): Implemented.
3337         (WebKitInitializeDatabasesIfNecessary): Updated for name change.
3338
3339         * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
3340
3341         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3342         * WebCoreSupport/WebChromeClient.mm:
3343         (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
3344         we had before with a single one.
3345
3346         * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
3347
3348         * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
3349         * WebView/WebPreferences.m:
3350         (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
3351         * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
3352         setDefaultDatabaseQuota:.
3353
3354         * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
3355         methods we had before with a single one.
3356
3357         * WebView/WebView.mm:
3358         (-[WebView _preferencesChangedNotification:]): Removed the code to set the
3359         default database origin quota in WebCore::Settings based on WebPreferences.
3360
3361         * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
3362         types of parameters that the database UI delegate methods had before.
3363
3364 2008-01-20  Mark Rowe  <mrowe@apple.com>
3365
3366         Reviewed by Dan Bernstein.
3367
3368         Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
3369         interested in supporting Safari 2 with TOT WebKit.
3370
3371         * WebView/WebView.mm:
3372         (+[WebView initialize]):
3373
3374 2008-01-17  Timothy Hatcher  <timothy@apple.com>
3375
3376         Reviewed by Adam Roben.
3377
3378         <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
3379         and inactive text selection after loading a page
3380         Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
3381
3382         The problem was other frames were changing the FocusController's active
3383         status to false after the first responder frame set it to true. The last
3384         frame to call _updateActiveState would win.
3385
3386         * WebView/WebHTMLView.mm:
3387         (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
3388         if the first responder is the current WebHTMLView or the WebFrameView.
3389         (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
3390
3391 2008-01-18  Adam Roben  <aroben@apple.com>
3392
3393         Rename _updateActiveState to _updateFocusedAndActiveState
3394
3395         Also renamed any related methods/members similarly.
3396
3397         Reviewed by Adele.
3398
3399         * WebView/WebHTMLView.mm:
3400         (-[WebHTMLViewPrivate dealloc]):
3401         (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
3402         (-[WebHTMLView close]):
3403         (_updateFocusedAndActiveStateTimerCallback):
3404         (-[WebHTMLView viewWillMoveToWindow:]):
3405         (-[WebHTMLView viewDidMoveToWindow]):
3406         (-[WebHTMLView windowDidBecomeKey:]):
3407         (-[WebHTMLView windowDidResignKey:]):
3408         (-[WebHTMLView becomeFirstResponder]):
3409         (-[WebHTMLView resignFirstResponder]):
3410         * WebView/WebHTMLViewInternal.h:
3411         * WebView/WebHTMLViewPrivate.h:
3412
3413 2008-01-17  John Sullivan  <sullivan@apple.com>
3414
3415         Reviewed by Darin
3416
3417         - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
3418
3419         * WebView/WebFrameView.mm:
3420         (-[WebFrameView initWithCoder:]):
3421         override to bump the global WebFrameView count
3422
3423 2008-01-16  Adam Roben  <aroben@apple.com>
3424
3425         Updated for renames/removal of WebCore methods.
3426
3427         Reviewed by Darin.
3428
3429         * Plugins/WebPluginController.mm:
3430         (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
3431         ask isFocusedAndActive directly, instead of going through the frame
3432         bridge.
3433         * WebView/WebHTMLView.mm:
3434         (-[WebHTMLView _updateActiveState]): Updated for method renames.
3435
3436 2008-01-16  John Sullivan  <sullivan@apple.com>
3437
3438         Reviewed by Adam and Dan
3439
3440         - cleaned up some existing logging
3441
3442         * WebView/WebHTMLView.mm:
3443         (-[WebHTMLView setNeedsDisplay:]):
3444         add method name to log, use "YES" and "NO" instead of (int)flag
3445         (-[WebHTMLView setNeedsLayout:]):
3446         ditto
3447         (-[WebHTMLView setNeedsToApplyStyles:]):
3448         ditto
3449
3450 2008-01-15  Geoffrey Garen  <ggaren@apple.com>
3451
3452         Reviewed by Andre Boule.
3453
3454         Fixed <rdar://problem/5667627> [WebCache empty] implementation should
3455         not disable/enable the cache
3456
3457         Toggle the cache model instead -- toggling disable/enable just causes
3458         the cache to forget about resources, not reclaim their memory.
3459
3460         * Misc/WebCache.mm:
3461         (+[WebCache empty]):
3462         * WebView/WebView.mm:
3463         * WebView/WebViewInternal.h:
3464
3465 2008-01-15  Adele Peterson  <adele@apple.com>
3466
3467         Reviewed by Adam and Antti.
3468
3469         WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
3470
3471         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3472           Removed initialization for GetMediaControlBackgroundImageData.  Added initialization for DrawMediaSliderTrack.
3473
3474 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
3475
3476         Reviewed by John Sullivan.
3477
3478         Fixed some world leak reports:
3479         * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
3480         Interpreter after running cvs-base suite
3481
3482         * <rdar://problem/5669423> PLT complains about world leak if browser
3483         window is open when PLT starts
3484
3485         These were both bugs in the reporting mechanism, so I took the
3486         opportunity to do some house cleaning there.
3487
3488         * Misc/WebCoreStatistics.h: Did a little renaming, to match
3489         JavaScriptCore better. I kept the methods with the old names around,
3490         though, because old versions of Safari need them.
3491
3492         * Misc/WebCoreStatistics.mm: Removed dependence on
3493         WebCore::JavaScriptStatistics, which is gone now.
3494
3495         These two methods are now distinct, for the sake of world leak reporting:
3496         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
3497         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
3498
3499 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
3500
3501         Not reviewed. Build fix.
3502
3503         - Attempt to fix mac build.
3504
3505         * Storage/WebDatabaseManager.mm:
3506
3507 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
3508
3509         Reviewed by Sam.
3510
3511         - remove SecurityOriginData and fold its functionality into SecurityOrigin
3512
3513         * Storage/WebDatabaseManager.mm:
3514         (-[WebDatabaseManager origins]):
3515         (-[WebDatabaseManager databasesWithOrigin:]):
3516         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
3517         (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
3518         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3519         * Storage/WebDatabaseTrackerClient.h:
3520         * Storage/WebDatabaseTrackerClient.mm:
3521         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
3522         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
3523         * Storage/WebSecurityOrigin.mm:
3524         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
3525         (-[WebSecurityOrigin protocol]):
3526         (-[WebSecurityOrigin domain]):
3527         (-[WebSecurityOrigin port]):
3528         (-[WebSecurityOrigin usage]):
3529         (-[WebSecurityOrigin quota]):
3530         (-[WebSecurityOrigin setQuota:]):
3531         (-[WebSecurityOrigin isEqual:]):
3532         (-[WebSecurityOrigin dealloc]):
3533         (-[WebSecurityOrigin finalize]):
3534         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
3535         (-[WebSecurityOrigin _core]):
3536         * Storage/WebSecurityOriginInternal.h:
3537         * WebCoreSupport/WebChromeClient.h:
3538         * WebCoreSupport/WebChromeClient.mm:
3539         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
3540         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
3541
3542 2008-01-10  Sam Weinig  <sam@webkit.org>
3543
3544         Reviewed by Anders Carlsson.
3545
3546         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
3547         <rdar://problem/5657355>
3548
3549         * Plugins/WebBaseNetscapePluginView.mm:
3550         (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
3551         to ensure the shouldAllowNavigation check is made.
3552
3553 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
3554
3555         Reviewed by Mark.
3556
3557         Enable SVG_FONTS by default.
3558
3559         * Configurations/WebKit.xcconfig:
3560
3561 2008-01-07  Adele Peterson  <adele@apple.com>
3562
3563         Reviewed by Antti, Adam, and Mitz.
3564
3565         WebKit part of fix for
3566         <rdar://problem/5619073> Updated look for <video> controls
3567         <rdar://problem/5619057> Add volume control to video controls
3568
3569         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3570
3571 2008-01-07  Dan Bernstein  <mitz@apple.com>
3572
3573         Reviewed by Dave Hyatt.
3574
3575         - <rdar://problem/5665216> Support the unicode-range property in @font-face rules
3576
3577         * Misc/WebNSAttributedStringExtras.mm:
3578
3579 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
3580
3581         Reviewed by Darin.
3582
3583         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
3584
3585         * WebView/WebView.mm:
3586         (-[WebView _executeCoreCommandByName:value:]):
3587         * WebView/WebViewPrivate.h:
3588         Added an SPI to implement layoutTestController.execCommand.
3589
3590 2008-01-03  Kevin Decker  <kdecker@apple.com>
3591
3592         Reviewed by Darin.
3593
3594         Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
3595
3596         * Misc/WebNSFileManagerExtras.h:
3597         * Misc/WebNSFileManagerExtras.m:
3598         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set
3599         "Where from:" metadata information.
3600         * WebView/WebHTMLView.mm:
3601         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
3602
3603 2008-01-03  Alice Liu  <alice.liu@apple.com>
3604
3605         Reviewed by Darin.
3606
3607         This fixes pageup/down in iframes.  test for this is fast/frames/iframe-scroll-page-up-down.html
3608
3609         * WebView/WebHTMLView.mm:
3610         (-[WebHTMLView doCommandBySelector:]):
3611         Have the editor handle all the commands it supports instead of just text commands.
3612         If not handled by the editor, the webview will handle the command.
3613
3614 2008-01-02  Kevin Decker  <kdecker@apple.com>
3615
3616         Reviewed by Darin.
3617
3618         Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
3619
3620         * Plugins/WebBaseNetscapePluginView.mm:
3621         (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched
3622         to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
3623
3624 2008-01-01  David D. Kilzer  <ddkilzer@webkit.org>
3625
3626         Reviewed by Dan.
3627
3628         - fix http://bugs.webkit.org/show_bug.cgi?id=16700
3629           Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
3630
3631         * DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of
3632         -[NSFileManager fileExistsAtPath:isDirectory:] before using the value
3633         of isDirectory.
3634
3635 2007-12-29  Nikolas Zimmermann  <zimmermann@kde.org>
3636
3637         Reviewed by Eric.
3638
3639         Add DOMSVGFontElement/DOMSVGGlyphElement/DOMSVGMissingGlyphElement to MigrateHeaders.make
3640
3641         * MigrateHeaders.make:
3642
3643 2007-12-25  Dan Bernstein  <mitz@apple.com>
3644
3645         Reviewed by Oliver Hunt.
3646
3647         - fix an assertion failure when pressing the num lock key
3648
3649         * WebView/WebHTMLView.mm:
3650         (-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to
3651         WebCore.
3652
3653 2007-12-20  Darin Adler  <darin@apple.com>
3654
3655         Reviewed by Oliver.
3656
3657         - fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
3658
3659         * WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of
3660         selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:,
3661         deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:,
3662         moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:,
3663         selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:,
3664         and transpose:.
3665
3666 2007-12-20  Kevin Decker  <kdecker@apple.com>
3667
3668         Reviewed by Anders.
3669
3670         Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)
3671
3672         * Plugins/WebBaseNetscapePluginView.mm:
3673         (-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop
3674          writing to the window backing store. The problem was that change-set 28400 introduced an early return
3675          which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL
3676          plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
3677
3678 2007-12-19  Geoffrey Garen  <ggaren@apple.com>
3679
3680         Reviewed by Oliver Hunt.
3681
3682         Build fix.
3683
3684         * ForwardingHeaders/kjs/SymbolTable.h: Added.
3685         * ForwardingHeaders/wtf/VectorTraits.h: Added.
3686
3687 2007-12-16  Mark Rowe  <mrowe@apple.com>
3688
3689         Reviewed by Maciej Stachowiak.
3690
3691         Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
3692
3693         * Plugins/WebBaseNetscapePluginStream.h:
3694         * Plugins/WebNetscapePluginStream.h:
3695         * Plugins/WebNetscapePluginStream.mm:
3696         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
3697         (-[WebNetscapePluginStream dealloc]):
3698         (-[WebNetscapePluginStream finalize]):
3699         * Plugins/WebPlugInStreamLoaderDelegate.h: Moved from WebCore.
3700         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Added.
3701         (WebNetscapePlugInStreamLoaderClient::WebNetscapePlugInStreamLoaderClient):
3702         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Added.
3703         (WebNetscapePlugInStreamLoaderClient::didReceiveResponse): Call through to the equivalent WebPlugInStreamLoaderDelegate method.
3704         (WebNetscapePlugInStreamLoaderClient::didReceiveData): Ditto.
3705         (WebNetscapePlugInStreamLoaderClient::didFail): Ditto.
3706         (WebNetscapePlugInStreamLoaderClient::didFinishLoading): Ditto.
3707
3708 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
3709
3710         Reviewed by Darin.
3711
3712         http://bugs.webkit.org/show_bug.cgi?id=14140
3713         <rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
3714
3715         * WebView/WebHTMLView.mm:
3716         (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
3717         when handling keypress, too.
3718         (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
3719         (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
3720         restore the state for additional commands to be saved correctly.
3721
3722 2007-12-14  David D. Kilzer  <ddkilzer@apple.com>
3723
3724         <rdar://problem/5647272> Remove user agent string hack for flickr.com
3725
3726         Reviewed by Darin.
3727
3728         * WebView/WebView.mm:
3729         (-[WebView _userAgentForURL:]): Removed hack.
3730
3731 2007-12-14  David D. Kilzer  <ddkilzer@apple.com>
3732
3733         <rdar://problem/5647261> Remove user agent string hack for yahoo.com
3734
3735         Reviewed by Darin.
3736
3737         * WebView/WebView.mm:
3738         (-[WebView _userAgentForURL:]): Removed hack.
3739
3740 2007-12-14  Darin Adler  <darin@apple.com>
3741
3742         Reviewed by Brady.
3743
3744         - fix http://bugs.webkit.org/show_bug.cgi?id=16296
3745           <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
3746
3747         * WebView/WebView.mm:
3748         (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
3749         a didReceiveIcon method is present.
3750
3751 2007-12-14  Darin Adler  <darin@apple.com>
3752
3753         Reviewed by Alexey.
3754
3755         - Changed a few more editing operations to use WebCore instead of WebKit.
3756         - Removed some obsolete unused code.
3757
3758         * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
3759         defined and used on the WebKit side to here. These no longer belong on the bridge
3760         and should be moved to the WebFrame class (or elsewhere).
3761         * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
3762
3763         * WebView/WebFrameView.mm:
3764         (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
3765
3766         * WebView/WebHTMLView.mm:
3767         (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
3768         (-[WebHTMLViewPrivate clear]): Ditto.
3769         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3770         (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
3771         pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
3772         to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
3773         disambiguated with the word "Move"). Added deleteBackward:,
3774         deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
3775         deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
3776         pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
3777         selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
3778         forwarded to WebCore.
3779         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
3780         operations that we forward to WebCore. Instead, look up any command that WebCore can
3781         handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
3782         an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
3783         would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
3784         (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
3785         (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
3786         (-[WebHTMLView resignFirstResponder]): Ditto.
3787         (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
3788
3789         * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
3790         firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
3791         _willMakeFirstResponderForNodeFocus.
3792
3793 2007-12-13  Alexey Proskuryakov  <ap@webkit.org>
3794
3795         Reviewed by Darin.
3796
3797         Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
3798
3799         * Misc/WebKitVersionChecks.h:
3800         * WebView/WebView.mm:
3801         (-[WebView _needsKeyboardEventHandlingQuirks]):
3802         (-[WebView _preferencesChangedNotification:]):
3803
3804 2007-12-12  Brady Eidson  <beidson@apple.com>
3805
3806         Reviewed by Sam Weinig
3807
3808         Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
3809
3810         * WebCoreSupport/WebCachedPagePlatformData.h: Added.
3811         (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
3812         (WebCachedPagePlatformData::clear):
3813         (WebCachedPagePlatformData::webDocumentView):
3814
3815         * WebCoreSupport/WebFrameLoaderClient.h:
3816         * WebCoreSupport/WebFrameLoaderClient.mm:
3817         (WebFrameLoaderClient::savePlatformDataToCachedPage):
3818         (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here,
3819           because that is now done in WebCore.
3820         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3821
3822 2007-12-12  Mark Rowe  <mrowe@apple.com>
3823
3824         Reviewed by Dave Kilzer.
3825
3826         Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
3827
3828         * Configurations/WebKit.xcconfig:
3829
3830 2007-12-11  Sam Weinig  <sam@webkit.org>
3831
3832         Reviewed by Darin Adler.
3833
3834         Scrub URL out of the tree in preparation for renaming KURL to URL.
3835
3836         * WebCoreSupport/WebFrameLoaderClient.mm:
3837         (WebFrameLoaderClient::actionDictionary):
3838         * WebView/WebDataSource.mm:
3839         (-[WebDataSource _URL]):
3840         * WebView/WebView.mm:
3841         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
3842
3843 2007-12-11  Darin Adler  <darin@apple.com>
3844
3845         Reviewed by Geoff.
3846
3847         - change more editing commands to use WebCore::Editor
3848         - change to use the new WebCore::Editor::command() function
3849
3850         * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
3851         alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
3852         insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
3853         subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
3854         to use the "forward to WebCore" macro instead of having hand-written implementations.
3855         (kit): Added function to change a TriState to an AppKit-style tri-state value.
3856         (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
3857         first character or copies the selector name, since the Editor commands are not case
3858         sensitive any more. Returns a command object.
3859         (-[WebHTMLView coreCommandByName:]): Added.
3860         (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
3861         and changed to use the new coreCommandBySelector: method.
3862         (-[WebHTMLView executeCoreCommandByName:]): Added.
3863         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
3864         methods that call through to WebCore to also use the state() and isEnabled()
3865         functions on the commands for the menu item state and user interface item enabling.
3866         (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
3867         name rather than having local methods for them; no need for methods with a single
3868         call site.
3869         (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
3870         than the deprecated execCommand().
3871         (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
3872         than the deprecated execCommand().
3873         * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
3874
3875 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
3876
3877         Reviewed by Darin.
3878
3879         <rdar://problem/5535636>
3880         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
3881
3882         http://bugs.webkit.org/show_bug.cgi?id=13916
3883         JavaScript detects Tab as a character input on a textfield validation
3884
3885         * WebCoreSupport/WebEditorClient.h:
3886         Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
3887         Renamed handleInputMethodKeypress() to handleInputMethodKeydown().
3888         * WebCoreSupport/WebEditorClient.mm:
3889         (WebEditorClient::handleKeyboardEvent): This change makes sense only remotely, but it helped
3890         to get tests working. I guess Mac keyboard event handling needs further refactoring.
3891
3892         * WebView/WebHTMLView.mm:
3893         (selectorToCommandName): Convert AppKit editing selector name to Editor command name - extracted
3894         from callWebCoreCommand:.
3895         (_interceptEditingKeyEvent:shouldSaveCommand:): Insert text from keypress.
3896
3897         * WebView/WebPDFView.mm:
3898         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3899         Convert incoming platform KeyDown into RawKeyDown, as this is what the view is interested in.
3900
3901 2007-12-10  Brady Eidson  <beidson@apple.com>
3902
3903         Reviewed by John Sullivan
3904
3905         Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
3906
3907         This is because a common UI case is to want to know the originating URL of a Database
3908
3909         * WebCoreSupport/WebChromeClient.mm:
3910         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
3911         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
3912
3913         * WebView/WebUIDelegatePrivate.h:
3914
3915         * WebView/WebView.mm:
3916         (CallDelegateReturningUnsignedLongLong):
3917         (CallUIDelegateReturningUnsignedLongLong):
3918         * WebView/WebViewInternal.h:
3919
3920 2007-12-10  Timothy Hatcher  <timothy@apple.com>
3921
3922         Reviewed by Mark Rowe.
3923
3924         <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
3925
3926         * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
3927           so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
3928
3929 2007-12-10  Kevin Decker  <kdecker@apple.com>
3930
3931         Reviewed by Darin.
3932
3933         Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
3934
3935         * WebView/WebHTMLView.mm:
3936         (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
3937
3938 2007-12-08  Oliver Hunt  <oliver@apple.com>
3939
3940         Reviewed by Sam W.
3941
3942         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
3943
3944         Fixes <rdar://problem/5620249> Must disable SVG animation
3945         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
3946
3947         Minor updates to the feature flags used.
3948
3949         * Configurations/WebKit.xcconfig:
3950         * DOM/WebDOMOperations.mm:
3951
3952 2007-12-07  Darin Adler  <darin@apple.com>
3953
3954         Reviewed by Kevin Decker and Tim Hatcher.
3955
3956         - speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
3957           in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
3958
3959         * WebView/WebHTMLView.mm:
3960         (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
3961         and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
3962         (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
3963         window goes away, and the view is never removed from the window.
3964         (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
3965
3966 2007-12-07  Darin Adler  <darin@apple.com>
3967
3968         Reviewed by Mitz.
3969
3970         - http://bugs.webkit.org/show_bug.cgi?id=15981
3971           speed up visited-link code a bit
3972
3973         * History/WebHistory.mm: Removed unused Latin-1 code path.
3974         (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
3975
3976 2007-12-07  Geoffrey Garen  <ggaren@apple.com>
3977
3978         Reviewed by Sam Weinig.
3979
3980         Added a forwarding header, since we now #include nodes.h through some
3981         JavaScriptCore headers.
3982
3983         * ForwardingHeaders/wtf/ListRefPtr.h: Added.
3984
3985 2007-12-06  Brady Eidson  <beidson@apple.com>
3986
3987         Reviewed by Oliver's rubber stamp
3988
3989         Let's go ahead and call the correct UI Delegate method, shall we?
3990
3991         * WebCoreSupport/WebChromeClient.mm:
3992         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
3993
3994 2007-12-06  Adam Roben  <aroben@apple.com>
3995
3996         Remove some assertions we know can fire and replace them with a FIXME
3997
3998         Reviewed by Anders.
3999
4000         * WebCoreSupport/WebFrameLoaderClient.mm:
4001
4002 2007-12-06  Timothy Hatcher  <timothy@apple.com>
4003
4004         Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
4005         Only assert if the major version is zero, since zero is handled in the other cases.
4006
4007         * WebView/WebView.mm:
4008         (callGestalt): Remove the ASSERT.
4009         (createMacOSXVersionString): ASSERT that major is not zero.
4010
4011 2007-12-06  Darin Adler  <darin@apple.com>
4012
4013         Reviewed by Tim Hatcher.
4014
4015         - fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
4016
4017         * WebView/WebView.mm:
4018         (callGestalt): Added.
4019         (createMacOSXVersionString): Added.
4020         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
4021         right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
4022         "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
4023         (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
4024
4025 2007-12-04  Geoffrey Garen  <ggaren@apple.com>
4026
4027         Reviewed by Darin Adler.
4028
4029         Third step in refactoring JSGlobalObject: Moved data members and data
4030         member access from Interpreter to JSGlobalObject.
4031
4032         * WebView/WebFrame.mm:
4033         (-[WebFrame _attachScriptDebugger]):
4034
4035 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
4036
4037         Reviewed by Darin.
4038
4039         - <rdar://5621435>
4040         - Security Fix. Instead of having it off by default, WebKit now must
4041         explicitly turn off local-resource restriction when needed for backwards
4042         coimpatibility reasons.
4043
4044         * WebView/WebView.mm:
4045         (-[WebView _commonInitializationWithFrameName:groupName:]):
4046
4047 2007-12-05  Brady Eidson  <beidson@apple.com>
4048
4049         Reviewed by Kevin Deckers rubberstamp
4050
4051         Disclose and export the Databases Directory defaults key
4052
4053         * Storage/WebDatabaseManager.mm:
4054         * Storage/WebDatabaseManagerPrivate.h:
4055         * WebKit.exp:
4056
4057 2007-12-04  Kevin Decker  <kdecker@apple.com>
4058
4059         Reviewed by Anders.
4060
4061         <rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
4062
4063         * WebCoreSupport/WebViewFactory.mm:
4064         (-[WebViewFactory pluginNameForMIMEType:]): Added.
4065
4066 2007-12-04  Brady Eidson  <beidson@apple.com>
4067
4068         Reviewed by Mark Rowe
4069
4070         Tweaked the way we typedef and cast these objc_msgSend calls
4071
4072         * WebView/WebView.mm:
4073         (CallDelegateReturningUnsignedLongLong):
4074
4075 2007-12-04  John Sullivan  <sullivan@apple.com>
4076
4077         Reviewed by Brady Eidson (with help from Mark Rowe)
4078
4079         Fixed return values for unsigned-long-long delegate methods
4080
4081         * WebView/WebView.mm:
4082         (CallDelegateReturningUnsignedLongLong):
4083         redid the change that Brady did at home over the weekend but forgot to check in
4084
4085 2007-11-27  Adam Roben  <aroben@apple.com>
4086
4087         Remove -[WebFrameBridge setNeedsReapplyStyles]
4088
4089         This functionality is now WebCore's responsibility.
4090
4091         Reviewed by Hyatt.
4092
4093         * WebCoreSupport/WebFrameBridge.mm:
4094         * WebKit.order:
4095
4096 2007-12-04  John Sullivan  <sullivan@apple.com>
4097
4098         Reviewed by Darin
4099
4100         Added deleteOrigin: SPI, which isn't fully implemented
4101
4102         * Storage/WebDatabaseManagerPrivate.h:
4103         * Storage/WebDatabaseManager.mm:
4104         (-[WebDatabaseManager deleteOrigin:]):
4105         just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
4106
4107 2007-12-04  Timothy Hatcher  <timothy@apple.com>
4108
4109         Reviewed by Mark Rowe.
4110
4111         Remove a check for early versions of Leopard CFNetwork now that
4112         Leopard has shipped.
4113
4114         * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
4115         * WebView/WebView.mm:
4116         (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
4117
4118 2007-12-04  Kevin Decker  <kdecker@apple.com>
4119
4120         Reviewed by Darin.
4121
4122         Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
4123
4124         This fix is exactly the same as chageset 28359 with the exception of an added early return in
4125         updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
4126
4127         The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
4128         only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
4129         Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
4130         regardless of whether or not it actually needs to draw.
4131
4132         * Plugins/WebBaseNetscapePluginView.mm:
4133         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
4134         down an ASSERT that was too strict.
4135         (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
4136         which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
4137         function. Also tweaked a comment and added an early return if the plug-in can't draw.
4138
4139 2007-12-04  Darin Adler  <darin@apple.com>
4140
4141         Reviewed by Kevin Decker.
4142
4143         * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
4144         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
4145         * WebKit.order: Ditto.
4146
4147 2007-12-03  Dan Bernstein  <mitz@apple.com>
4148
4149         Reviewed by Dave Hyatt.
4150
4151         - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
4152
4153         * WebView/WebHTMLView.mm:
4154         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
4155         that checked if the view had resized and sent the resize event, since
4156         FrameView sends resize events now.
4157         * WebView/WebHTMLViewInternal.h:
4158
4159 2007-12-03  Timothy Hatcher  <timothy@apple.com>
4160
4161         Reviewed by Darin.
4162
4163         Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
4164         to return a pointer to the implementation struct instead of a copy of the struct. This changes
4165         all of the callers to dereference the pointer to access the struct fields.
4166
4167         * Plugins/WebNullPluginView.mm:
4168         (-[WebNullPluginView reportFailure]):
4169         * WebCoreSupport/WebFrameBridge.mm:
4170         * WebCoreSupport/WebFrameLoaderClient.mm:
4171         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
4172         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
4173         (WebFrameLoaderClient::dispatchWillSendRequest):
4174         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
4175         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):