WebKit/mac/ChangeLog

   1 2008-05-06  Brady Eidson  <beidson@apple.com>
   2
   3         Reviewed by Darin Adler
   4
   5         Preparation for upcoming work making LocalStorage persistent.
   6
   7         When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
   8
   9         * WebView/WebView.mm:
  10         (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
  11
  12 2008-05-05  Sam Weinig  <sam@webkit.org>
  13
  14         Reviewed by Darin Adler.
  15
  16         Fix for <rdar://problem/5884383>
  17         Escape look-a-like characters from the the entire url.
  18
  19         * Misc/WebNSURLExtras.mm:
  20         (escapeUnsafeCharacters):
  21         (-[NSURL _web_userVisibleString]):
  22
  23 2008-05-05  Justin Garcia  <justin.garcia@apple.com>
  24
  25         Reviewed by Darin.
  26
  27         <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
  28
  29         * WebView/WebView.mm:
  30         (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
  31         the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
  32         the two interfere.
  33
  34 2008-05-05  Sam Weinig  <sam@webkit.org>
  35
  36         Reviewed by Tim Hatcher.
  37
  38         Make the Inspector's localizable strings file match the format used by Dashboard widgets.
  39
  40         * WebCoreSupport/WebInspectorClient.mm:
  41         (WebInspectorClient::localizedStringsURL):
  42
  43 2008-05-05  Anders Carlsson  <andersca@apple.com>
  44
  45         Reviewed by Jess.
  46
  47         Apparently preflighting can cause hangs for some reason. Revert this for now.
  48
  49         * Plugins/WebNetscapePluginPackage.m:
  50         (-[WebNetscapePluginPackage _initWithPath:]):
  51         * Plugins/WebPluginPackage.m:
  52         (-[WebPluginPackage initWithPath:]):
  53
  54 2008-05-05  Darin Adler  <darin@apple.com>
  55
  56         Reviewed by Mitz.
  57
  58         - https://bugs.webkit.org/show_bug.cgi?id=18789
  59           fix some shouldCloseWithWindow edge cases
  60
  61         * WebView/WebView.mm:
  62         (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
  63         NSWindowWillCloseNotification if the view was moved out of the window but still
  64         had that window set as the host window. Also make sure this function doesn't do
  65         anything if the WebView is already closed.
  66         (-[WebView setHostWindow:]): Ditto.
  67
  68 2008-05-04  David Kilzer  <ddkilzer@apple.com>
  69
  70         Make parameters match for WebChromeClient::addMessageToConsole()
  71
  72         Reviewed by John.
  73
  74         * WebCoreSupport/WebChromeClient.h:
  75         (WebChromeClient::addMessageToConsole): Renamed sourceID parameter
  76         to sourceURL to match implementation in WebChromeClient.mm.
  77
  78 2008-05-02  Anders Carlsson  <andersca@apple.com>
  79
  80         Reviewed by Mark.
  81
  82         Various Cocoa event model and 64-bit plug-in fixes.
  83
  84         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
  85         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
  86         Set click count.
  87
  88         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
  89         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
  90         Don't try to get the mouse location for keyboard events.
  91
  92         * Plugins/WebPluginPackage.m:
  93         (-[WebPluginPackage initWithPath:]):
  94         Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
  95
  96 2008-05-02  Anders Carlsson  <andersca@apple.com>
  97
  98         Reviewed by Sam.
  99
 100         The event union is now named.
 101
 102         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 103         (WebNetscapePluginEventHandlerCocoa::drawRect):
 104         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 105         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 106         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 107         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
 108         (WebNetscapePluginEventHandlerCocoa::focusChanged):
 109
 110 2008-05-02  Anders Carlsson  <andersca@apple.com>
 111
 112         Reviewed by Mark.
 113
 114         Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
 115
 116         Call preflightAndReturnError on the bundle, which will check if any of the architectures
 117         in the bundle match the current architecture.
 118
 119         * Plugins/WebNetscapePluginPackage.m:
 120         (-[WebNetscapePluginPackage _initWithPath:]):
 121
 122 2008-05-02  Alexey Proskuryakov  <ap@webkit.org>
 123
 124         Reviewed by Geoffrey Garen.
 125
 126         https://bugs.webkit.org/show_bug.cgi?id=18826
 127         Make JavaScript heap per-thread
 128
 129         * Misc/WebCoreStatistics.mm:
 130         (+[WebCoreStatistics javaScriptObjectsCount]):
 131         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
 132         (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
 133         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
 134         (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
 135         (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
 136         Replaced static Collector calls with calls to a current thread's instance.
 137
 138         * WebView/WebScriptDebugDelegate.mm:
 139         (-[WebScriptCallFrame evaluateWebScript:]):
 140         Pass ExecState to jsString().
 141
 142 2008-05-01  Anders Carlsson  <andersca@apple.com>
 143
 144         Reviewed by Mark.
 145
 146         64-bit NPAPI plugin build fixes.
 147
 148         * Plugins/WebBaseNetscapePluginView.mm:
 149         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 150         (-[WebBaseNetscapePluginView updateAndSetWindow]):
 151         (-[WebBaseNetscapePluginView start]):
 152         (-[WebBaseNetscapePluginView windowBecameKey:]):
 153         * Plugins/WebNetscapeDeprecatedFunctions.c:
 154         * Plugins/WebNetscapeDeprecatedFunctions.h:
 155         * Plugins/WebNetscapePluginEventHandler.mm:
 156         (WebNetscapePluginEventHandler::create):
 157         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 158         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 159         * Plugins/WebPluginDatabase.m:
 160         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
 161
 162 2008-05-01  Anders Carlsson  <andersca@apple.com>
 163
 164         Reviewed by Tim.
 165
 166         Remove duplicate npfunctions.h header from WebKit.
 167
 168         * MigrateHeaders.make:
 169         Migrate npfunctions.h
 170
 171         * Plugins/npfunctions.h: Removed.
 172
 173 2008-05-01  Anders Carlsson  <andersca@apple.com>
 174
 175         Reviewed by John.
 176
 177         Add null checks for the event handler.
 178
 179         * Plugins/WebBaseNetscapePluginView.mm:
 180         (-[WebBaseNetscapePluginView stopTimers]):
 181         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 182
 183 2008-05-01  Anders Carlsson  <andersca@apple.com>
 184
 185         Fix 64-bit build.
 186
 187         * Plugins/WebNetscapePluginEventHandlerCocoa.h:
 188         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 189         * WebCoreSupport/WebFrameLoaderClient.mm:
 190
 191 2008-05-01  Anders Carlsson  <andersca@apple.com>
 192
 193         Fix build.
 194
 195         * Plugins/npfunctions.h:
 196
 197 2008-05-01  Anders Carlsson  <andersca@apple.com>
 198
 199         Reviewed by Adam.
 200
 201         Forward mouse move events to the Netscape plug-in view.
 202
 203         * Plugins/WebBaseNetscapePluginView.h:
 204         * Plugins/WebBaseNetscapePluginView.mm:
 205         (-[WebBaseNetscapePluginView handleMouseMoved:]):
 206         New method that just calls the current event handler.
 207
 208         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
 209         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 210         NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors
 211         don't work on it so don't call them.
 212
 213         * WebCoreSupport/WebFrameLoaderClient.mm:
 214         (NetscapePluginWidget::NetscapePluginWidget):
 215         New Widget subclass to be used for Netscape plug-ins.
 216
 217         (NetscapePluginWidget::handleEvent):
 218         Forward NSMouseMoved events to the plug-in.
 219
 220         (WebFrameLoaderClient::createPlugin):
 221         Wrap the plug-in view in a NetscapePluginWidget.
 222
 223 2008-05-01  Alp Toker  <alp@nuanti.com>
 224
 225         Rubber-stamped by Anders.
 226
 227         GTK+ build fix for changes in r32752. Use int32, not int32_t types in
 228         npapi.h.
 229
 230         Additional fix to use same signedness in npapi.h and Mac for the
 231         interval parameter.
 232
 233         * Plugins/WebBaseNetscapePluginView.h:
 234         * Plugins/WebBaseNetscapePluginView.mm:
 235         (PluginTimer::PluginTimer):
 236         (-[WebBaseNetscapePluginView stopTimers]):
 237         (-[WebBaseNetscapePluginView restartTimers]):
 238         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 239         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 240         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 241         * Plugins/npapi.m:
 242         (NPN_ScheduleTimer):
 243         (NPN_UnscheduleTimer):
 244         * Plugins/npfunctions.h:
 245
 246 2008-04-30  Anders Carlsson  <andersca@apple.com>
 247
 248         Reviewed by Adam.
 249
 250         Add new Cocoa event model and the NPN_ScheduleTimer/NPN_UnscheduleTimer methods.
 251
 252         * Plugins/WebBaseNetscapePluginView.h:
 253         * Plugins/WebBaseNetscapePluginView.mm:
 254         (PluginTimer::PluginTimer):
 255         (PluginTimer::start):
 256         (PluginTimer::fired):
 257         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
 258         (-[WebBaseNetscapePluginView stopTimers]):
 259         (-[WebBaseNetscapePluginView restartTimers]):
 260         (-[WebBaseNetscapePluginView scrollWheel:]):
 261         (-[WebBaseNetscapePluginView flagsChanged:]):
 262         (-[WebBaseNetscapePluginView start]):
 263         (-[WebBaseNetscapePluginView eventModel]):
 264         (-[WebBaseNetscapePluginView fini]):
 265         (-[WebBaseNetscapePluginView getVariable:value:]):
 266         (-[WebBaseNetscapePluginView setVariable:value:]):
 267         (-[WebBaseNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
 268         (-[WebBaseNetscapePluginView unscheduleTimer:]):
 269         * Plugins/WebBaseNetscapePluginViewInternal.h:
 270         * Plugins/WebBaseNetscapePluginViewPrivate.h:
 271         * Plugins/WebNetscapePluginEventHandler.h:
 272         * Plugins/WebNetscapePluginEventHandler.mm:
 273         (WebNetscapePluginEventHandler::create):
 274         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 275         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 276         (WebNetscapePluginEventHandlerCarbon::scrollWheel):
 277         (WebNetscapePluginEventHandlerCarbon::flagsChanged):
 278         (WebNetscapePluginEventHandlerCarbon::platformWindow):
 279         * Plugins/WebNetscapePluginEventHandlerCocoa.h: Added.
 280         (WebNetscapePluginEventHandlerCocoa::startTimers):
 281         (WebNetscapePluginEventHandlerCocoa::stopTimers):
 282         * Plugins/WebNetscapePluginEventHandlerCocoa.mm: Added.
 283         (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa):
 284         (WebNetscapePluginEventHandlerCocoa::drawRect):
 285         (WebNetscapePluginEventHandlerCocoa::mouseDown):
 286         (WebNetscapePluginEventHandlerCocoa::mouseDragged):
 287         (WebNetscapePluginEventHandlerCocoa::mouseEntered):
 288         (WebNetscapePluginEventHandlerCocoa::mouseExited):
 289         (WebNetscapePluginEventHandlerCocoa::mouseMoved):
 290         (WebNetscapePluginEventHandlerCocoa::mouseUp):
 291         (WebNetscapePluginEventHandlerCocoa::scrollWheel):
 292         (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
 293         (WebNetscapePluginEventHandlerCocoa::keyDown):
 294         (WebNetscapePluginEventHandlerCocoa::keyUp):
 295         (WebNetscapePluginEventHandlerCocoa::flagsChanged):
 296         (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
 297         (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
 298         (WebNetscapePluginEventHandlerCocoa::focusChanged):
 299         (WebNetscapePluginEventHandlerCocoa::platformWindow):
 300         (WebNetscapePluginEventHandlerCocoa::sendEvent):
 301         * Plugins/WebNetscapePluginPackage.m:
 302         (-[WebNetscapePluginPackage load]):
 303         * Plugins/npapi.m:
 304         (NPN_ScheduleTimer):
 305         (NPN_UnscheduleTimer):
 306         * Plugins/npfunctions.h:
 307
 308 2008-04-30  Brady Eidson  <beidson@apple.com>
 309
 310         Fix my WebPreferences revert check-in
 311
 312         * WebView/WebView.mm:
 313         (-[WebView _preferencesChangedNotification:]):
 314
 315 2008-04-30  Brady Eidson  <beidson@apple.com>
 316
 317         Rubberstamped by John Sullivan
 318
 319         Revert the remainder of my original preferences changes from last week.
 320         They caused a massive PLT regression (too many notifications being sent out
 321         or listened to that weren't previously) and it's not in my schedule to refine
 322         the preferences code instead of working on my feature!
 323
 324         * WebView/WebView.mm:
 325         (-[WebView _updateSettingsFromPreferences:]):
 326         (-[WebView _commonInitializationWithFrameName:groupName:]):
 327
 328 2008-04-30  Anders Carlsson  <andersca@apple.com>
 329
 330         Fix the 64-bit build.
 331
 332         * Plugins/WebNetscapePluginEventHandler.h:
 333         * Plugins/WebNetscapePluginEventHandler.mm:
 334         * Plugins/WebNetscapePluginEventHandlerCarbon.h:
 335         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 336
 337 2008-04-29  David D. Kilzer  <ddkilzer@apple.com>
 338
 339         BUILD FIX for Release build.
 340
 341         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
 342         (WebNetscapePluginEventHandlerCarbon::drawRect): Declare acceptedEvent
 343         separately so the compiler doesn't complain about an unused variable.
 344         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler): Ditto.
 345
 346 2008-04-29  Anders Carlsson  <andersca@apple.com>
 347
 348         Reviewed by Adam.
 349
 350         Refactor the Carbon event handling code out into a separate class in preparation for adding
 351         the Cocoa event handling code.
 352
 353         * Plugins/WebBaseNetscapePluginView.h:
 354         * Plugins/WebBaseNetscapePluginView.mm:
 355         (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
 356         (-[WebBaseNetscapePluginView sendActivateEvent:]):
 357         (-[WebBaseNetscapePluginView sendDrawRectEvent:]):
 358         (-[WebBaseNetscapePluginView stopTimers]):
 359         (-[WebBaseNetscapePluginView restartTimers]):
 360         (-[WebBaseNetscapePluginView setHasFocus:]):
 361         (-[WebBaseNetscapePluginView mouseDown:]):
 362         (-[WebBaseNetscapePluginView mouseUp:]):
 363         (-[WebBaseNetscapePluginView mouseEntered:]):
 364         (-[WebBaseNetscapePluginView mouseExited:]):
 365         (-[WebBaseNetscapePluginView mouseDragged:]):
 366         (-[WebBaseNetscapePluginView keyUp:]):
 367         (-[WebBaseNetscapePluginView keyDown:]):
 368         (-[WebBaseNetscapePluginView cut:]):
 369         (-[WebBaseNetscapePluginView copy:]):
 370         (-[WebBaseNetscapePluginView paste:]):
 371         (-[WebBaseNetscapePluginView selectAll:]):
 372         (-[WebBaseNetscapePluginView start]):
 373         (-[WebBaseNetscapePluginView stop]):
 374         (-[WebBaseNetscapePluginView fini]):
 375         (-[WebBaseNetscapePluginView drawRect:]):
 376         (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
 377         (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
 378         (-[WebBaseNetscapePluginView windowBecameKey:]):
 379         (-[WebBaseNetscapePluginView windowResignedKey:]):
 380         (-[WebBaseNetscapePluginView windowDidMiniaturize:]):
 381         (-[WebBaseNetscapePluginView windowDidDeminiaturize:]):
 382         (-[WebBaseNetscapePluginView loginWindowDidSwitchFromUser:]):
 383         (-[WebBaseNetscapePluginView loginWindowDidSwitchToUser:]):
 384         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
 385         (-[WebBaseNetscapePluginView _viewHasMoved]):
 386         * Plugins/WebBaseNetscapePluginViewInternal.h:
 387         * Plugins/WebNetscapePluginEmbeddedView.h:
 388         * Plugins/WebNetscapePluginEventHandler.h: Added.
 389         (WebNetscapePluginEventHandler::~WebNetscapePluginEventHandler):
 390         (WebNetscapePluginEventHandler::currentEventIsUserGesture):
 391         (WebNetscapePluginEventHandler::WebNetscapePluginEventHandler):
 392         * Plugins/WebNetscapePluginEventHandler.mm: Added.
 393         (WebNetscapePluginEventHandler::create):
 394         * Plugins/WebNetscapePluginEventHandlerCarbon.h: Added.
 395         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Added.
 396         (WebNetscapePluginEventHandlerCarbon::WebNetscapePluginEventHandlerCarbon):
 397         (getCarbonEvent):
 398         (modifiersForEvent):
 399         (WebNetscapePluginEventHandlerCarbon::sendNullEvent):
 400         (WebNetscapePluginEventHandlerCarbon::drawRect):
 401         (WebNetscapePluginEventHandlerCarbon::mouseDown):
 402         (WebNetscapePluginEventHandlerCarbon::mouseUp):
 403         (WebNetscapePluginEventHandlerCarbon::mouseEntered):
 404         (WebNetscapePluginEventHandlerCarbon::mouseExited):
 405         (WebNetscapePluginEventHandlerCarbon::mouseDragged):
 406         (WebNetscapePluginEventHandlerCarbon::mouseMoved):
 407         (WebNetscapePluginEventHandlerCarbon::keyDown):
 408         (keyMessageForEvent):
 409         (WebNetscapePluginEventHandlerCarbon::keyUp):
 410         (WebNetscapePluginEventHandlerCarbon::focusChanged):
 411         (WebNetscapePluginEventHandlerCarbon::windowFocusChanged):
 412         (WebNetscapePluginEventHandlerCarbon::TSMEventHandler):
 413         (WebNetscapePluginEventHandlerCarbon::installKeyEventHandler):
 414         (WebNetscapePluginEventHandlerCarbon::removeKeyEventHandler):
 415         (WebNetscapePluginEventHandlerCarbon::nullEventTimerFired):
 416         (WebNetscapePluginEventHandlerCarbon::startTimers):
 417         (WebNetscapePluginEventHandlerCarbon::stopTimers):
 418         (WebNetscapePluginEventHandlerCarbon::sendEvent):
 419
 420 2008-04-29  Mark Rowe  <mrowe@apple.com>
 421
 422         Reviewed by David Harrison.
 423
 424         Ensure that WebDynamicScrollBarsView defines WebCoreScrollbarAlwaysOn to keep Mail building.
 425
 426         * WebKit.exp:
 427         * WebView/WebDynamicScrollBarsView.h:
 428         * WebView/WebDynamicScrollBarsView.m:
 429
 430 2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
 431
 432         Reviewed by Darin.
 433
 434         Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
 435
 436         * WebCoreSupport/WebChromeClient.h:
 437         * WebCoreSupport/WebChromeClient.mm:
 438         * WebView/WebClipView.m:
 439         (-[WebClipView scrollWheel:]):
 440         * WebView/WebHTMLView.mm:
 441         (-[WebHTMLView addMouseMovedObserver]):
 442         (-[WebHTMLView removeMouseMovedObserver]):
 443         (-[WebHTMLView acceptsFirstMouse:]):
 444         * WebView/WebUIDelegatePrivate.h:
 445         * WebView/WebView.mm:
 446         (-[WebViewPrivate init]):
 447         * WebView/WebViewPrivate.h:
 448
 449 2008-04-28  Rob Buis  <buis@kde.org>
 450
 451         Reviewed by Maciej.
 452
 453         Build fix for Tiger.
 454
 455         * WebView/WebView.mm:
 456         (WebKitInitializeApplicationCachePathIfNecessary):
 457
 458 2008-04-28  Adele Peterson  <adele@apple.com>
 459
 460         Reviewed by Dan Bernstein, Tim Hatcher, Anders Carlsson, and Darin Adler.
 461
 462         WebKit part of fix for <rdar://problem/3709505>
 463         Safari should have a way to upload bundles from the file upload control (as zip)
 464
 465         Added UIDelegate methods to let the application handle generating replacement files for uploads.
 466         In this case, Safari will create archived files for bundles so they can be uploaded properly.
 467
 468         * DefaultDelegates/WebDefaultUIDelegate.m:
 469         (-[WebDefaultUIDelegate webView:shouldReplaceUploadFile:usingGeneratedFilename:]):
 470         (-[WebDefaultUIDelegate webView:generateReplacementFile:]):
 471         * WebCoreSupport/WebChromeClient.h:
 472         * WebCoreSupport/WebChromeClient.mm:
 473         (WebChromeClient::shouldReplaceWithGeneratedFileForUpload):
 474         (WebChromeClient::generateReplacementFile):
 475         * WebView/WebUIDelegatePrivate.h:
 476
 477 2008-04-28  Anders Carlsson  <andersca@apple.com>
 478
 479         Reviewed by Sam, Mark, Adele and Darin.
 480
 481         Initialize the application cache path.
 482
 483         * WebView/WebView.mm:
 484         (WebKitInitializeApplicationCachePathIfNecessary):
 485         (-[WebView _commonInitializationWithFrameName:groupName:]):
 486
 487 2008-04-28  Alice Liu  <alice.liu@apple.com>
 488
 489         Reviewed by Darin.
 490
 491         Fix <rdar://problem/4911289> Add tabindex property to all children
 492         of HTMLElement (7138)
 493         http://bugs.webkit.org/show_bug.cgi?id=7138
 494
 495         * MigrateHeaders.make:
 496         Removing DOMHTMLLabelElementPrivate.h and DOMHTMLLegendElementPrivate.h
 497         because now that focus() has been moved to DOMHTMLElement.h, these
 498         files are no longer needed.
 499
 500 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
 501
 502         Reviewed by Darin.
 503
 504         Fix run-webkit-tests --threading
 505         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
 506         Proxy server issue in Sunday's Nightly
 507
 508         * WebView/WebView.mm: (-[WebViewPrivate init]): Initialize threading. Previously, this was
 509         only done from icon database code, which is not robust enough.
 510
 511 2008-04-20 Adam Barth <hk9565@gmail.com>
 512
 513         Reviewed by Adam Roben and Sam Weinig.
 514
 515         Updated WebSecurityOrigin to match new SecurityOrigin API.
 516
 517         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
 518
 519         * Storage/WebSecurityOrigin.mm:
 520         (-[WebSecurityOrigin host]):
 521         (-[WebSecurityOrigin domain]):
 522         * Storage/WebSecurityOriginPrivate.h:
 523
 524 2008-04-25  Mark Rowe  <mrowe@apple.com>
 525
 526         Rubber-stamped by Sam Weinig.
 527
 528         Add some content to an empty ICU header file to prevent verification errors.
 529
 530         * icu/unicode/utf_old.h:
 531
 532 2008-04-25  Anders Carlsson  <andersca@apple.com>
 533
 534         Reviewed by Sam.
 535
 536         Add offlineWebApplicationCacheEnabled preference.
 537
 538         * WebView/WebPreferenceKeysPrivate.h:
 539         * WebView/WebPreferences.m:
 540         (+[WebPreferences initialize]):
 541         (-[WebPreferences offlineWebApplicationCacheEnabled]):
 542         (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
 543         * WebView/WebPreferencesPrivate.h:
 544         * WebView/WebView.mm:
 545         (-[WebView _updateSettingsFromPreferences:]):
 546
 547 2008-04-24  Mark Rowe  <mrowe@apple.com>
 548
 549         Reviewed by Sam Weinig.
 550
 551         Remove code for calculating the glyph cache size.
 552
 553         * WebCoreSupport/WebSystemInterface.m:
 554         (InitWebCoreSystemInterface): Remove unused symbol.
 555
 556 2008-04-24  Mark Rowe  <mrowe@apple.com>
 557
 558         Reviewed by Sam Weinig.
 559
 560         Add a definition of BUILDING_ON_LEOPARD to complement BUILDING_ON_TIGER.
 561
 562         * WebKitPrefix.h:
 563
 564 2008-04-24  Brady Eidson  <beidson@apple.com>
 565
 566         Reviewed by Darin
 567
 568         Fix layout test regressions from my earlier preferences/settings tweak.
 569
 570         * WebView/WebView.mm:
 571         (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
 572           the notification to update the settings, each WebView still needs to register for the
 573           notification - restore that behavior.
 574
 575 2008-04-24  Dan Bernstein  <mitz@apple.com>
 576
 577         Reviewed by Darin Adler.
 578
 579         - preparation for https://bugs.webkit.org/show_bug.cgi?id=3729
 580           <rdar://problem/4036353> REGRESSION: arrow keys move insertion bar backwards in RTL text
 581
 582         * WebView/WebFrame.mm:
 583         (-[WebFrame _caretRectAtNode:offset:affinity:]): Changed to use
 584         VisiblePosition::caretRect() instead of the RenderObject method which
 585         was removed.
 586
 587 2008-04-24  Brady Eidson  <beidson@apple.com>
 588
 589         Reviewed by Darin
 590
 591         Rework the Settings population again.
 592
 593         * WebView/WebView.mm:
 594         (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
 595           and directly from WebView's common init function.
 596         (-[WebView _preferencesChangedNotification:]):
 597         (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
 598           after creating the new Page
 599
 600 2008-04-24  Darin Adler  <darin@apple.com>
 601
 602         Reviewed by Geoff.
 603
 604         - fix crash in regression test where we'd ask a frame for a user agent string
 605           after the WebView was already closed
 606
 607         * WebCoreSupport/WebFrameLoaderClient.mm:
 608         (WebFrameLoaderClient::userAgent): Assert that the WebView is not nil. Also
 609         added some code to prevent the crash in release builds if this problem happens
 610         again.
 611
 612 2008-04-24  Anders Carlsson  <andersca@apple.com>
 613
 614         Reviewed by Sam.
 615
 616         Change some String arguments to be const references instead.
 617
 618         * WebCoreSupport/WebEditorClient.h:
 619         * WebCoreSupport/WebEditorClient.mm:
 620         (WebEditorClient::shouldInsertText):
 621
 622 2008-04-24  John Sullivan  <sullivan@apple.com>
 623
 624         Mac build fix
 625
 626         * WebCoreSupport/WebViewFactory.mm:
 627         (-[WebViewFactory AXButtonActionVerb]):
 628         implement this method using the text in WebCoreLocalizedStrings.cpp
 629         (-[WebViewFactory AXRadioButtonActionVerb]):
 630         ditto
 631         (-[WebViewFactory AXTextFieldActionVerb]):
 632         ditto
 633         (-[WebViewFactory AXCheckedCheckBoxActionVerb]):
 634         ditto
 635         (-[WebViewFactory AXUncheckedCheckBoxActionVerb]):
 636         ditto
 637         (-[WebViewFactory AXLinkActionVerb]):
 638         ditto
 639
 640 2008-04-23  Brady Eidson  <beidson@apple.com>
 641
 642         Reviewed by Sam Weinig
 643
 644         In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
 645         object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
 646         thereby populating the Settings object, immediately after the Page is created.
 647
 648         * WebView/WebView.mm:
 649         (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
 650
 651 2008-04-24  John Sullivan  <sullivan@apple.com>
 652
 653         Reviewed by Jess
 654
 655         - fixed <rdar://problem/5886655> JavaScript input panel automatic resizing doesn't work right with HiDPI
 656
 657         * Misc/WebNSControlExtras.m:
 658         (-[NSControl sizeToFitAndAdjustWindowHeight]):
 659         deploy userSpaceScaleFactor when using view distances on the window
 660
 661 2008-04-22  Anders Carlsson  <andersca@apple.com>
 662
 663         Reviewed by Darin.
 664
 665         Add NPN_Construct and NPN_PluginThreadAsyncCall declarations.
 666
 667         * Plugins/npfunctions.h:
 668
 669 2008-04-20  Matt Lilek  <webkit@mattlilek.com>
 670
 671         Mysteriously reviewed by mitz|away.
 672
 673         Bug 18111: Closing a tab while dragging crashes Safari
 674         https://bugs.webkit.org/show_bug.cgi?id=18111
 675
 676         Null check the page before handling drag events.
 677
 678         * WebView/WebView.mm:
 679         (-[WebView draggingUpdated:]):
 680         (-[WebView draggingExited:]):
 681
 682 2008-04-19  Brady Eidson  <beidson@apple.com>
 683
 684         Reviewed by Tim Hatcher
 685
 686         Add a WebPreference for the path of the local storage persistent store.
 687
 688         * WebView/WebPreferenceKeysPrivate.h:
 689
 690         * WebView/WebPreferences.m:
 691         (-[WebPreferences _localStorageDatabasePath]):
 692         (-[WebPreferences _setLocalStorageDatabasePath:]):
 693         * WebView/WebPreferencesPrivate.h:
 694
 695         * WebView/WebView.mm:
 696         (-[WebView _preferencesChangedNotification:]):
 697
 698 2008-04-18  Brady Eidson  <beidson@apple.com>
 699
 700         Reviewed by Sam Weinig
 701
 702         Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
 703         No reason to do the work twice...
 704
 705         * WebView/WebView.mm:
 706         (-[WebView _close]):
 707
 708 2008-04-17  Eric Seidel  <eric@webkit.org>
 709
 710         Reviewed by beth.
 711
 712         Rename Frame::renderer() to contentRenderer() and fix uses.
 713
 714         * Misc/WebCoreStatistics.mm:
 715         * WebView/WebRenderNode.mm:
 716         (-[WebRenderNode initWithWebFrameView:]):
 717
 718 2008-04-17  Jon Honeycutt  <jhoneycutt@apple.com>
 719
 720         Reviewed by mrowe.
 721
 722         * WebView/WebFrame.mm: Remove temporary build fix.
 723
 724 2008-04-17  Mark Rowe  <mrowe@apple.com>
 725
 726         Reviewed by Dan Bernstein.
 727
 728         Fix <rdar://problem/5863552> REGRESSION (r30741): Attachments don't appear in the iChat message window after sending
 729
 730         The order of arguments to -[NSDictionary initWithObjects:andKeys:] had been transposed accidentally during refactoring.
 731
 732         * WebCoreSupport/WebFrameLoaderClient.mm:
 733         (WebFrameLoaderClient::createPlugin): Pass the arguments in the correct order.
 734
 735 2008-04-17  Mark Rowe  <mrowe@apple.com>
 736
 737         Rubber-stamped by Dan Bernstein.
 738
 739         Fix the Mac build.
 740
 741         * WebView/WebFrame.mm: Define HAVE_ACCESSIBILITY before including AccessibilityObject.h and AXObjectCache.h to get things building
 742         for now.  This comes from config.h in WebCore but we don't have an equivalent in WebKit so we'll need to work out the correct place
 743         for this to live going forward.
 744
 745 2008-04-15  Kevin Decker  <kdecker@apple.com>
 746
 747         Reviewed by Anders.
 748
 749         <rdar://problem/5412759> CrashTracer: [USER] 22 crashes in Safari at com.apple.quicktime.webplugin: NPN_SetValue + 15403
 750
 751         In certain situations, code in WebBasePluginPackage would load a plug-in only for the explicit reason of asking it to create a
 752         preference file, but wouldn't actually unload the bundle. This created problems for the QuickTime WebKit plug-in by unloading
 753         a bundle out from underneath itself.
 754
 755         * Plugins/WebBasePluginPackage.h: Added unload method.
 756         * Plugins/WebBasePluginPackage.m:
 757         (-[WebBasePluginPackage unload]): Added new method. Currently, only Netscape plug-ins support unload.
 758         (-[WebBasePluginPackage pListForPath:createFile:]): Added a call to unload.
 759         * Plugins/WebNetscapePluginPackage.m:
 760         (-[WebNetscapePluginPackage unload]): Added.
 761
 762 2008-04-15  Anders Carlsson  <andersca@apple.com>
 763
 764         Reviewed by Adam.
 765
 766         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
 767
 768         * Configurations/WebKit.xcconfig:
 769
 770 2008-04-15  Brady Eidson  <beidson@apple.com>
 771
 772         Reviewed by John Sullivan
 773
 774         Do a more complete job adding the "WebArchiveDebugMode" pref
 775
 776         * WebView/WebPreferences.m: Add both getter *and* setter
 777         (-[WebPreferences webArchiveDebugModeEnabled]):
 778         (-[WebPreferences setWebArchiveDebugModeEnabled:]):
 779         * WebView/WebPreferencesPrivate.h:
 780
 781         * WebView/WebView.mm:
 782         (-[WebView _preferencesChangedNotification:]): Call the renamed getter
 783
 784 2008-04-14  Brady Eidson  <beidson@apple.com>
 785
 786         Reviewed by Anders
 787
 788         Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
 789         if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the
 790         network and will instead fail the load as "cancelled."
 791
 792         * WebView/WebPreferenceKeysPrivate.h:
 793
 794         * WebView/WebPreferences.m:
 795         (+[WebPreferences initialize]):
 796         (-[WebPreferences _webArchiveDebugModeEnabled]):
 797         * WebView/WebPreferencesPrivate.h:
 798
 799         * WebView/WebView.mm:
 800         (-[WebView _preferencesChangedNotification:]):
 801
 802 2008-04-11  David Hyatt  <hyatt@apple.com>
 803
 804         Rename CachedResource ref/deref methods to addClient/removeClient.
 805
 806         Reviewed by olliej
 807
 808         * WebView/WebHTMLView.mm:
 809         (-[WebHTMLViewPrivate dealloc]):
 810         (-[WebHTMLViewPrivate finalize]):
 811         (-[WebHTMLViewPrivate clear]):
 812         (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]):
 813
 814 2008-04-07  Brady Eidson  <beidson@apple.com>
 815
 816         Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project
 817
 818         * Configurations/WebKit.xcconfig:
 819
 820 2008-04-04  Adam Roben  <aroben@apple.com>
 821
 822         Use WebCore's ICU headers instead of our own copy
 823
 824         Rubberstamped by Tim Hatcher.
 825
 826         * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
 827         PrivateHeaders.
 828
 829 2008-04-04  Adam Roben  <aroben@apple.com>
 830
 831         Fix <rdar://problem/5804776> Would like to use WebCore's
 832         ForwardingHeaders in WebKit without manually creating copies
 833
 834         Patch by Tim Hatcher, typed by me.
 835
 836         * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
 837         WebCore's PrivateHeaders instead of our own copy.
 838
 839 2008-04-04  Ada Chan  <adachan@apple.com>
 840
 841         Now we pass width and height directly as integers to format
 842         the window title for a standalone image.
 843
 844         Reviewed by Dan.
 845
 846         * WebCoreSupport/WebViewFactory.mm:
 847         (-[WebViewFactory imageTitleForFilename:width:height:]):
 848
 849 2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
 850
 851         Updated by Dan Bernstein. Reviewed by Dave Hyatt.
 852
 853         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
 854           font-weight does not properly support graded weights
 855
 856         * WebView/WebHTMLView.mm:
 857         (-[WebHTMLView _styleFromFontAttributes:]):
 858         (-[WebHTMLView _originalFontB]):
 859         (-[WebHTMLView _addToStyle:fontA:fontB:]):
 860
 861 2008-04-02  Mark Rowe  <mrowe@apple.com>
 862
 863         Reviewed by Oliver Hunt.
 864
 865         Ensure that debug symbols are generated for x86_64 and ppc64 builds.
 866
 867         * Configurations/Base.xcconfig:
 868
 869 2008-03-31  Alice Liu  <alice.liu@apple.com>
 870
 871         Reviewed by Darin.
 872
 873         * WebView/WebFrame.mm:
 874         (-[WebFrame _accessibilityTree]):
 875         The syntax for fetching an object from the AXObjectCache changed slightly
 876
 877 2008-03-31  Brady Eidson  <beidson@apple.com>
 878
 879         Reviewed by Jon Honeycutt
 880
 881         Move a WebArchive loading check into WebCore
 882
 883         * WebView/WebHTMLRepresentation.mm:
 884         (-[WebHTMLRepresentation receivedData:withDataSource:]): Don't check "isDisplayingWebArchive" as WebCore is now
 885           responsible for checking that state
 886
 887 2008-03-31  Brady Eidson  <beidson@apple.com>
 888
 889         Reviewed by Darin and Mitz's rubber stamp
 890
 891         Remove dataForArchivedSelection(WebCore::Frame*) from the EditorClient - only usage is now directly in WebCore
 892
 893         * WebCoreSupport/WebEditorClient.mm:
 894         * WebCoreSupport/WebEditorClient.h:
 895
 896 2008-03-28  Brady Eidson  <beidson@apple.com>
 897
 898         Rubberstamped by Darin Adler
 899
 900         Remove WebArchiver.h/mm
 901
 902         * WebView/WebArchiver.h: Removed.
 903         * WebView/WebArchiver.mm: Removed.
 904
 905         * DOM/WebDOMOperations.mm:
 906         * WebCoreSupport/WebDragClient.mm:
 907         * WebCoreSupport/WebEditorClient.mm:
 908         * WebView/WebDataSource.mm:
 909         * WebView/WebHTMLView.mm:
 910
 911 2008-03-28  Brady Eidson  <beidson@apple.com>
 912
 913         Reviewed by Darin Adler
 914
 915         Now that WebCore can create archives from a frame selection directly, we don't need it in WebArchiver anymore
 916
 917         * WebCoreSupport/WebEditorClient.mm:
 918         (WebEditorClient::dataForArchivedSelection):
 919
 920         * WebView/WebArchiver.h: Nuke archiveSelectionInFrame, as there are no remaining users
 921         * WebView/WebArchiver.mm: Ditto
 922
 923         * WebView/WebHTMLView.mm:
 924         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
 925
 926 2008-03-28  Brady Eidson  <beidson@apple.com>
 927
 928         Reviewed by Darin Adler
 929
 930         More Kit->Core WebArchive changes.
 931
 932         Create an archive from the current selection in a frame
 933
 934         * WebView/WebArchiver.mm: Remove one more *undeclared* method, the last method will drop off
 935           easily in a followup
 936
 937 2008-03-28  Brady Eidson  <beidson@apple.com>
 938
 939         Reviewed by Sam Weinig
 940
 941         WebArchive saga continues - Can now make archives from ranges in WebCore
 942
 943         * DOM/WebDOMOperations.mm:
 944         (-[DOMRange webArchive]):
 945         (-[DOMRange markupString]):
 946
 947         * WebView/WebArchiver.h: Remove newly obsolete [WebArchiver archiveRange:]
 948         * WebView/WebArchiver.mm:
 949
 950 2008-03-28  Brady Eidson  <beidson@apple.com>
 951
 952         Reviewed by Sam Weinig
 953
 954         More Kit->Core webarchive code movement
 955
 956         * DOM/WebDOMOperations.mm:
 957         (-[DOMNode markupString]): Call createFullMarkup() instead
 958
 959         * WebView/WebFrame.mm: Remove obsolete _markupStringFromNode
 960         * WebView/WebFrameInternal.h: Ditto
 961
 962 2008-03-28  Brady Eidson  <beidson@apple.com>
 963
 964         Reviewed by Sam Weinig
 965
 966         Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
 967
 968         * WebView/WebArchiver.h:
 969         * WebView/WebArchiver.mm:
 970         * WebView/WebDataSource.mm:
 971         (-[WebDataSource webArchive]):
 972
 973 2008-03-28  Brady Eidson  <beidson@apple.com>
 974
 975         Reviewed by Sam Weinig
 976
 977         Remove unused [WebArchiver archiveNode:], made obsolete in r31400
 978
 979         * WebView/WebArchiver.h:
 980         * WebView/WebArchiver.mm:
 981
 982 2008-03-28  Brady Eidson  <beidson@apple.com>
 983
 984         Reviewed by Darin
 985
 986         "Yet another transitional step" to empty out WebKit-based code for archiving.
 987
 988         With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
 989         entirely within WebCore, and opens the door to saving WebArchives on Windows.
 990
 991         * DOM/WebDOMOperations.mm:
 992         * WebView/WebArchiver.mm:
 993         (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
 994
 995 2008-03-27  Brady Eidson  <beidson@apple.com>
 996
 997         Reviewed by Adam Roben
 998
 999         Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
1000         as the push to core-ify WebArchives continues.
1001
1002         This patch also introduces a behavior change.  WebCore allows ArchiveResources with null or empty data.
1003         WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
1004         Since WebResource is API, I decided to leave it be to avoid a behavior change.  But internally created resources
1005         (as in "while archiving a page") are accepting of null or empty data.
1006
1007         This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.
1008
1009         * WebView/WebDataSource.mm:
1010         (-[WebDataSource mainResource]): Call DocumentLoader implementation
1011         (-[WebDataSource subresources]): Ditto
1012         * WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
1013         * WebView/WebFrameInternal.h:
1014
1015 2008-03-27  Brady Eidson  <beidson@apple.com>
1016
1017         Reviewed by Adam
1018
1019         Change the "init from WebCore resource" version of WebResource to take PassRefPtr
1020         (more efficient)
1021
1022         * WebView/WebResource.mm:
1023         (-[WebResource _initWithCoreResource:]):
1024         * WebView/WebResourceInternal.h:
1025
1026 2008-03-26  Brady Eidson  <beidson@apple.com>
1027
1028         Build fix - accidentally checked in this change which was work in progress
1029
1030         * DOM/WebDOMOperations.mm:
1031
1032 2008-03-26  Brady Eidson  <beidson@apple.com>
1033
1034         Reviewed by Darin
1035
1036         When we create a WebArchive, we walk every node from some starting point, asking each node
1037         along the way "What are your subresource URLs?"
1038
1039         That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
1040         WebCore::Node
1041
1042         * DOM/WebDOMOperations.mm:
1043         (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
1044           calling into individual WebCore::Node implementations
1045         * DOM/WebDOMOperationsPrivate.h:
1046
1047 2008-03-26  Brady Eidson  <beidson@apple.com>
1048
1049         Reviewed by Mark Rowe
1050
1051         Part of the continued push to move WebArchive-related code down to WebCore, this
1052         moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
1053
1054         * WebView/WebDataSource.mm:
1055         (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader
1056
1057         * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
1058           has now been ported down to WebCore
1059         * WebView/WebFrameInternal.h:
1060
1061 2008-03-26  Mark Rowe  <mrowe@apple.com>
1062
1063         Rubber-stamped by Brady Eidson.
1064
1065         Update FEATURE_DEFINES to be consistent with the other locations in which it is defined.
1066
1067         * Configurations/WebKit.xcconfig:
1068
1069 2008-03-26  Mark Rowe  <mrowe@apple.com>
1070
1071         Reviewed by David Hyatt.
1072
1073         Make the Ahem font antialias correctly on Acid3 on Tiger.
1074
1075         * WebCoreSupport/WebSystemInterface.m:
1076         (InitWebCoreSystemInterface):
1077
1078 2008-03-26  Mark Rowe  <mrowe@apple.com>
1079
1080         Fix the Mac build.
1081
1082         * MigrateHeaders.make: Copy the newly generated header into the right place.
1083
1084 2008-03-25  Brady Eidson  <beidson@apple.com>
1085
1086         Reviewed by Beth Dakin
1087
1088         Remove entirely unused internal method
1089
1090         * WebView/WebArchiver.h:
1091         * WebView/WebArchiver.mm:
1092
1093 2008-03-25  Brady Eidson  <beidson@apple.com>
1094
1095         Reviewed by Adam Roben
1096
1097         <rdar://problem/5819308> - View Source is empty when view webarchives
1098
1099         * WebCore.base.exp:
1100         * loader/DocumentLoader.cpp:
1101         (WebCore::DocumentLoader::setParsedArchiveData):
1102         (WebCore::DocumentLoader::parsedArchiveData):
1103         * loader/DocumentLoader.h:
1104
1105         * loader/FrameLoader.cpp:
1106         (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData
1107           in the DocumentLoader
1108
1109 2008-03-25  Dan Bernstein  <mitz@apple.com>
1110
1111         Reviewed by Darin Adler.
1112
1113         - fix http://bugs.webkit.org/show_bug.cgi?id=17933
1114           Reopen All Windows From Last Session causes crash
1115
1116         * WebView/WebHTMLView.mm:
1117         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null
1118         check.
1119
1120 2008-03-25  Brady Eidson  <beidson@apple.com>
1121
1122         Reviewed by Jon Honeycutt's rubberstamp
1123
1124         Fix a leak with the new WebArchive setup
1125
1126         * WebView/WebArchive.mm:
1127         (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
1128
1129 2008-03-25  Brady Eidson  <beidson@apple.com>
1130
1131         Reviewed by Darin
1132
1133         Removed the concept of "pending archive resources" and the "archive resources delivery timer"
1134         from WebFrameLoaderClient, as those concepts have been pushed into WebCore
1135
1136         * WebCoreSupport/WebFrameLoaderClient.h:
1137         * WebCoreSupport/WebFrameLoaderClient.mm:
1138         (WebFrameLoaderClient::WebFrameLoaderClient):
1139
1140 2008-03-25  Brady Eidson  <beidson@apple.com>
1141
1142         Reviewed by Darin
1143
1144         Remove newly obsolete FrameLoaderClient methods
1145
1146         * WebCoreSupport/WebFrameLoaderClient.h:
1147         * WebCoreSupport/WebFrameLoaderClient.mm:
1148
1149 2008-03-25  Brady Eidson  <beidson@apple.com>
1150
1151         Release build fix
1152
1153         * WebView/WebArchive.mm:
1154         (-[WebArchive subresources]):
1155         (-[WebArchive subframeArchives]):
1156
1157 2008-03-25  Brady Eidson  <beidson@apple.com>
1158
1159         Reviewed by Darin
1160
1161         <rdar://problem/4516169> - Support WebArchives on Windows
1162         And paves the way for many future WebArchive bug fixes and enhancements
1163
1164         This change moves most of the real workhorse code about WebArchives into WebCore.  It maintains
1165         1-to-1 relationships between a few objects in WebCore and WebKit.  Such as:
1166          * WebArchive <-> LegacyWebArchive
1167          * WebResource <-> ArchiveResource
1168          * WebUnarchivingState <-> ArchiveResourceCollection
1169
1170         The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
1171         and now exist in WebCore
1172
1173         * WebCoreSupport/WebFrameLoaderClient.mm:
1174         (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch
1175         (WebFrameLoaderClient::finalSetupForReplace):
1176         (WebFrameLoaderClient::setDefersLoading):
1177         (WebFrameLoaderClient::willUseArchive):
1178         (WebFrameLoaderClient::isArchiveLoadPending):
1179         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1180         (WebFrameLoaderClient::clearArchivedResources):
1181         (WebFrameLoaderClient::createFrame):
1182
1183         * WebView/WebArchive.mm:
1184         (+[WebArchivePrivate initialize]):
1185         (-[WebArchivePrivate init]):
1186         (-[WebArchivePrivate initWithCoreArchive:]):
1187         (-[WebArchivePrivate coreArchive]):
1188         (-[WebArchivePrivate setCoreArchive:]):
1189         (-[WebArchivePrivate dealloc]):
1190         (-[WebArchivePrivate finalize]):
1191         (-[WebArchive init]):
1192         (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
1193         (-[WebArchive initWithData:]):
1194         (-[WebArchive initWithCoder:]):
1195         (-[WebArchive encodeWithCoder:]):
1196         (-[WebArchive mainResource]):
1197         (-[WebArchive subresources]):
1198         (-[WebArchive subframeArchives]):
1199         (-[WebArchive data]):
1200         (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]):
1201         (-[WebArchive WebCore::]):
1202         * WebView/WebArchiveInternal.h: Added.
1203
1204         * WebView/WebDataSource.mm:
1205         (-[WebDataSourcePrivate dealloc]):
1206         (-[WebDataSource _addSubframeArchives:]):
1207         (-[WebDataSource _documentFragmentWithArchive:]):
1208         (-[WebDataSource subresourceForURL:]):
1209         (-[WebDataSource addSubresource:]):
1210         * WebView/WebDataSourceInternal.h:
1211
1212         * WebView/WebFrame.mm:
1213         (-[WebFrame loadArchive:]):
1214         * WebView/WebFrameInternal.h:
1215
1216         * WebView/WebHTMLRepresentation.mm:
1217         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1218
1219         * WebView/WebResource.mm:
1220         (+[WebResourcePrivate initialize]):
1221         (-[WebResourcePrivate init]):
1222         (-[WebResourcePrivate initWithCoreResource:]):
1223         (-[WebResourcePrivate dealloc]):
1224         (-[WebResourcePrivate finalize]):
1225         (-[WebResource initWithCoder:]):
1226         (-[WebResource encodeWithCoder:]):
1227         (-[WebResource data]):
1228         (-[WebResource URL]):
1229         (-[WebResource MIMEType]):
1230         (-[WebResource textEncodingName]):
1231         (-[WebResource frameName]):
1232         (-[WebResource _initWithCoreResource:WebCore::]):
1233         (-[WebResource WebCore::]):
1234         (-[WebResource _ignoreWhenUnarchiving]):
1235         (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
1236         (-[WebResource _fileWrapperRepresentation]):
1237         (-[WebResource _response]):
1238         (-[WebResource _stringValue]):
1239         * WebView/WebResourceInternal.h: Added.
1240         * WebView/WebResourcePrivate.h:
1241
1242         * WebView/WebUnarchivingState.h: Removed.
1243         * WebView/WebUnarchivingState.m: Removed.
1244
1245 2008-03-24  Oliver Hunt  <oliver@apple.com>
1246
1247         Reviewed by Mark Rowe.
1248
1249         Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
1250         <http://bugs.webkit.org/show_bug.cgi?id=18030>
1251
1252         Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
1253         tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
1254         <http://bugs.webkit.org/show_bug.cgi?id=18057>
1255
1256         * WebView/WebHTMLView.mm:
1257         (-[WebHTMLView keyDown:]):
1258
1259 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1260
1261         Reviewed by Maciej, landed by Brady
1262
1263         Bug 3580: iFrames Appear to be Cached
1264         <http://bugs.webkit.org/show_bug.cgi?id=3580>
1265
1266         Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
1267         <http://bugs.webkit.org/show_bug.cgi?id=15486>
1268
1269         Bug 15554: Reload causes <object> to use old data
1270         <http://bugs.webkit.org/show_bug.cgi?id=15554>
1271
1272         If a page is reloaded, a child frame's URL can not be taken from a history item.
1273
1274         * WebView/WebFrame.mm:
1275         (-[WebFrame _loadURL:referrer:intoChild:]):
1276
1277 2008-03-24  Darin Adler  <darin@apple.com>
1278
1279         Reviewed by Beth.
1280
1281         - fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
1282
1283         * History/WebHistoryItem.mm:
1284         (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
1285         * WebView/WebDataSource.mm:
1286         (-[WebDataSource _URL]): Ditto.
1287         (-[WebDataSource unreachableURL]): Ditto.
1288         * WebView/WebHTMLView.mm:
1289         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1290
1291         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1292         * History/WebHistory.mm:
1293         * Misc/WebElementDictionary.mm:
1294         * Misc/WebNSAttributedStringExtras.mm:
1295         Remove unneeded imports of KURL.h.
1296
1297 2008-03-24  Brady Eidson  <beidson@apple.com>
1298
1299         Reviewed by Darin's rubberstamp
1300
1301         Rename this file for upcoming work.
1302
1303         * WebView/WebArchive.m: Removed.
1304         * WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
1305
1306 2008-03-24  Alexey Proskuryakov  <ap@webkit.org>
1307
1308         Build fix.
1309
1310         * MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
1311
1312 2008-03-23  Oliver Hunt  <oliver@apple.com>
1313
1314         Reviewed by Maciej.
1315
1316         Bug 17670: Key events may improperly propagate from iframe to parent frame
1317         <http://bugs.webkit.org/show_bug.cgi?id=17670>
1318         Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus
1319         <http://bugs.webkit.org/show_bug.cgi?id=16381>
1320
1321         Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
1322         as that results in us dispatching the key events for each frame going up the frame
1323         tree.
1324
1325         * WebView/WebHTMLView.mm:
1326         (-[WebHTMLView keyDown:]):
1327         (-[WebHTMLView keyUp:]):
1328         (-[WebHTMLView flagsChanged:]):
1329
1330 2008-03-21  Timothy Hatcher  <timothy@apple.com>
1331
1332         Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
1333         http://bugs.webkit.org/show_bug.cgi?id=17980
1334
1335         Reviewed by Adam.
1336
1337         The new highlight drawing was not honoring the fade value, so it was
1338         always drawing at full opacity. The animation code didn't match Windows
1339         and the new highlight anyway, so it has been removed. The highlight
1340         how just detaches when it is hidden.
1341
1342         * WebCoreSupport/WebInspectorClient.mm:
1343         (-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
1344         (-[WebInspectorWindowController close]): Ditto.
1345         (-[WebInspectorWindowController highlightNode:]): Call attach.
1346         (-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.
1347         * WebInspector/WebNodeHighlight.h:
1348         * WebInspector/WebNodeHighlight.m:
1349         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1350         (-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
1351         (-[WebNodeHighlight attach]): Renamed from attachHighlight.
1352         (-[WebNodeHighlight detach]): Renamed from detachHighlight.
1353         (-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.
1354         * WebInspector/WebNodeHighlightView.h:
1355         * WebInspector/WebNodeHighlightView.m:
1356         (-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.
1357
1358 2008-03-20  Mark Rowe  <mrowe@apple.com>
1359
1360         Reviewed by Sam Weinig.
1361
1362         Ensure that the defines in FEATURE_DEFINES are sorted so that they will match the default settings of build-webkit.
1363         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
1364         command-line.
1365
1366         * Configurations/WebKit.xcconfig:
1367
1368 2008-03-20  Adam Roben  <aroben@apple.com>
1369
1370         Make WebNodeHighlightView use InspectorController to do its painting
1371
1372         Reviewed by Tim Hatcher.
1373
1374         * WebCoreSupport/WebInspectorClient.mm:
1375         (-[WebInspectorWindowController highlightNode:]): Pass the
1376         InspectorController to the WebNodeHighlight, and don't call
1377         setHighlightedNode: (which has been removed).
1378         (-[WebInspectorWindowController hideHighlight]): Removed call to
1379         setHighlightedNode:.
1380         * WebInspector/WebNodeHighlight.h:
1381           - Replaced _highlightNode with _inspectorController
1382           - Removed _highlightedNode accessors
1383           - Added -inspectorController method
1384         * WebInspector/WebNodeHighlight.m:
1385         (-[WebNodeHighlight initWithTargetView:inspectorController:]): Now
1386         takes an InspectorController* and stores it in _inspectorController.
1387         (-[WebNodeHighlight dealloc]): Removed code dealing with
1388         _highlightedNode.
1389         (-[WebNodeHighlight inspectorController]): Added.
1390         * WebInspector/WebNodeHighlightView.m: Removed FileInternal category.
1391         (-[WebNodeHighlightView isFlipped]): Added. WebCore expects all
1392         GraphicsContexts to be based on a flipped CGContext, so we have to
1393         specify that this view is flipped.
1394         (-[WebNodeHighlightView drawRect:]): Changed to create a
1395         GraphicsContext and pass it to InspectorController::drawNodeHighlight.
1396
1397 2008-03-18  David Hyatt  <hyatt@apple.com>
1398
1399         Add support for a preference in WebKit that can be used in nightly builds to test full page
1400         zoom.
1401
1402         Reviewed by Antti
1403
1404         * WebView/WebPreferenceKeysPrivate.h:
1405         * WebView/WebView.mm:
1406         (-[WebView setTextSizeMultiplier:]):
1407         (-[WebView canMakeTextSmaller]):
1408         (-[WebView makeTextSmaller:]):
1409         (-[WebView canMakeTextLarger]):
1410         (-[WebView makeTextLarger:]):
1411         (-[WebView canMakeTextStandardSize]):
1412         (-[WebView makeTextStandardSize:]):
1413
1414 2008-03-17  Eric Seidel  <eric@webkit.org>
1415
1416         Reviewed by darin.
1417
1418         Export _NPN_IntFromIdentifier as part of our NPAPI interface
1419
1420         * Plugins/WebNetscapePluginPackage.m:
1421         (-[WebNetscapePluginPackage load]):
1422
1423 2008-03-14  Brady Eidson  <beidson@apple.com>
1424
1425         Reviewed by Brian Dash's rubberstamp
1426
1427         Remove a class declaration for a class that has never existed
1428
1429         * WebView/WebResource.h:
1430
1431 2008-03-14  David D. Kilzer  <ddkilzer@apple.com>
1432
1433         Unify concept of enabling the Mac Java bridge.
1434
1435         Reviewed by Darin and Anders.
1436
1437         * Plugins/WebPluginJava.h: Removed unused file.
1438         * WebCoreSupport/WebFrameLoaderClient.h:
1439         (WebFrameLoaderClient::javaApplet): Added #if ENABLE(MAC_JAVA_BRIDGE) guard.
1440         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto for #import and NSView SPI method.
1441         (WebFrameLoaderClient::javaApplet): Ditto.
1442
1443 2008-03-13  Antti Koivisto  <antti@apple.com>
1444
1445         Reviewed by Darin.
1446
1447         * ForwardingHeaders/wtf/Deque.h: Added.
1448
1449 2008-03-13  Anders Carlsson  <andersca@apple.com>
1450
1451         Reviewed by Adam.
1452
1453         Call originalRequest, not initialRequest.
1454
1455         * WebView/WebDataSource.mm:
1456         (-[WebDataSource initialRequest]):
1457
1458 2008-03-12  Darin Adler  <darin@apple.com>
1459
1460         Reviewed by John Sullivan.
1461
1462         - cleanup after removing the bridge
1463
1464         * DOM/WebDOMOperations.mm:
1465         (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
1466
1467         * Misc/WebCoreStatistics.mm:
1468         (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
1469
1470         * Plugins/WebBaseNetscapePluginView.mm:
1471         (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
1472         _frameLoader method.
1473         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1474         Ditto.
1475         * Plugins/WebPluginController.mm:
1476         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
1477
1478         * WebCoreSupport/WebFrameLoaderClient.mm:
1479         (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
1480         method. Without this we could leave a stale frame pointer around.
1481         (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
1482         caller of the _isMainFrame method.
1483         (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
1484         _frameLoader method.
1485         (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
1486
1487         * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
1488         turned out to be unused.
1489         (core): Added overload for DocumentFragment.
1490         (kit): Ditto.
1491         (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
1492         to FrameLoader with _private->coreFrame->loader().
1493         (-[WebFrame _attachScriptDebugger]): Ditto.
1494         (-[WebFrame _clearCoreFrame]): Added.
1495         (-[WebFrame _updateBackground]): More of the same.
1496         (-[WebFrame _unmarkAllBadGrammar]): Ditto.
1497         (-[WebFrame _unmarkAllMisspellings]): Ditto.
1498         (-[WebFrame _hasSelection]): Ditto.
1499         (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
1500         (-[WebFrame _findFrameWithSelection]): Ditto.
1501         (-[WebFrame _dataSource]): Ditto.
1502         (-[WebFrame _addData:]): Streamlined code a bit.
1503         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1504         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1505         (-[WebFrame _isDescendantOfFrame:]): Ditto.
1506         (-[WebFrame _bodyBackgroundColor]): Ditto.
1507         (-[WebFrame _isFrameSet]): Ditto.
1508         (-[WebFrame _firstLayoutDone]): Ditto.
1509         (-[WebFrame _loadType]): Ditto.
1510         (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
1511         (-[WebFrame name]): Ditto.
1512         (-[WebFrame DOMDocument]): Ditto.
1513         (-[WebFrame frameElement]): Ditto.
1514         (-[WebFrame provisionalDataSource]): Ditto.
1515         (-[WebFrame dataSource]): Ditto.
1516         (-[WebFrame loadRequest:]): Ditto.
1517         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
1518         (-[WebFrame loadArchive:]): Ditto.
1519         (-[WebFrame stopLoading]): Ditto.
1520         (-[WebFrame reload]): Ditto.
1521         (-[WebFrame findFrameNamed:]): Ditto.
1522         (-[WebFrame parentFrame]): Ditto.
1523         (-[WebFrame childFrames]): Ditto.
1524         (-[WebFrame windowObject]): Ditto.
1525         (-[WebFrame globalContext]): Ditto.
1526
1527         * WebView/WebFrameInternal.h: Added overloads of core and kit.
1528         Removed method declarations.
1529
1530         * WebView/WebHTMLRepresentation.mm:
1531         (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
1532         (formElementFromDOMElement): Ditto.
1533         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1534         (inputElementFromDOMElement): Ditto.
1535         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1536         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1537         (-[WebHTMLRepresentation formForElement:]): Ditto.
1538         (-[WebHTMLRepresentation currentForm]): Ditto.
1539         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1540         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1541         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1542
1543         * WebView/WebHTMLView.mm:
1544         (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
1545         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1546         Call createFragmentFromText directly instead of via WebFrame.
1547         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1548         Moved layout calls here from WebFrame.
1549         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1550         (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
1551         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
1552         (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
1553         (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
1554         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1555         Moved code here from WebFrame.
1556         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
1557         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1558         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1559         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1560         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1561         (-[WebHTMLView rectsForTextMatches]): Ditto.
1562
1563         * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
1564
1565         * WebView/WebPDFView.mm:
1566         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
1567         _frameLoader method.
1568
1569         * WebView/WebRenderNode.mm:
1570         (copyRenderNode): Moved code here from WebFrame.
1571         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1572
1573         * WebView/WebResource.mm:
1574         (-[WebResource _stringValue]): Moved code here from WebFrame.
1575
1576         * WebView/WebView.mm:
1577         (-[WebView _close]): Use core function intsead of _frameLoader method.
1578         (-[WebView setCustomTextEncodingName:]): Ditto.
1579         (-[WebView setHostWindow:]): Moved code here from WebFrame.
1580         (aeDescFromJSValue): Moved this here from WebFrame.
1581         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
1582
1583 2008-03-12  Darin Adler  <darin@apple.com>
1584
1585         Reviewed by Anders.
1586
1587         - http://bugs.webkit.org/show_bug.cgi?id=17640
1588           eliminate WebCoreFrameBridge
1589
1590         Moved all the code from the bridge into WebFrame. This need not be the final
1591         home of these methods -- they can be moved closer to their callers and improved
1592         further -- but it eliminates the bridge without requiring a rewrite of the code.
1593         It's a fairly mechanical process (just adding underscores to method names really).
1594
1595         There's even a chance that some of the methods are unused. Those we can remove
1596         after checking if that's so.
1597
1598         * DOM/WebDOMOperations.mm:
1599         (-[DOMNode markupString]): Use WebFrame rather than bridge.
1600         (-[DOMDocument webFrame]): Changed to use the core and kit functions
1601         instead of using the bridge.
1602         (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
1603         (-[DOMRange markupString]): Ditto.
1604         * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
1605
1606         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
1607         * History/WebHistoryItem.mm: Ditto.
1608
1609         * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
1610         * Misc/WebCoreStatistics.mm:
1611         (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
1612
1613         * Misc/WebElementDictionary.mm: Removed unneeded import.
1614
1615         * Misc/WebKitStatistics.m:
1616         (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
1617         * Misc/WebKitStatisticsPrivate.h: Ditto.
1618
1619         * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
1620         * Misc/WebNSPasteboardExtras.mm: Ditto.
1621
1622         * Plugins/WebBaseNetscapePluginView.mm:
1623         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
1624         rather than bridge.
1625
1626         * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
1627         * Plugins/WebNetscapePluginStream.mm: Ditto.
1628
1629         * Plugins/WebPluginContainerCheck.mm:
1630         (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
1631         bridge to get to the WebCore::Frame.
1632
1633         * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
1634         * Plugins/WebPluginController.mm:
1635         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
1636         rather than bridge.
1637
1638         * WebCoreSupport/WebEditorClient.mm:
1639         (selectorForKeyEvent): Tweaked comment.
1640
1641         * WebCoreSupport/WebFrameBridge.h: Removed.
1642         * WebCoreSupport/WebFrameBridge.mm: Removed.
1643
1644         * WebCoreSupport/WebFrameLoaderClient.mm:
1645         (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
1646         (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
1647         I could remove this function entirely, but it looks like the Qt port is using it.
1648
1649         * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
1650
1651         * WebView/WebArchiver.mm:
1652         (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
1653         (+[WebArchiver archiveNode:]): Ditto.
1654         (+[WebArchiver archiveSelectionInFrame:]): Ditto.
1655
1656         * WebView/WebDataSource.mm:
1657         (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
1658         (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
1659         (-[WebDataSource subresources]): Ditto.
1660         (-[WebDataSource subresourceForURL:]): Ditto.
1661
1662         * WebView/WebDataSourceInternal.h: Removed _bridge method.
1663
1664         * WebView/WebFrame.mm:
1665         (-[WebFramePrivate dealloc]): Removed code to release the bridge.
1666         (core): Go directly to the core frame, not via the bridge.
1667         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
1668         Remove the code to deal with the bridge.
1669         (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
1670         shouldCreateRenderers flag, formerly on the bridge.
1671         (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
1672         (aeDescFromJSValue): Moved here from bridge.
1673         (-[WebFrame _domain]): Ditto.
1674         (-[WebFrame _addData:]): Ditto.
1675         (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
1676         (-[WebFrame _nodesFromList:]): Ditto.
1677         (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
1678         (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
1679         (-[WebFrame _selectedString]): Ditto.
1680         (-[WebFrame _stringForRange:]): Ditto.
1681         (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
1682         (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1683         (-[WebFrame _sendScrollEvent]): Ditto.
1684         (-[WebFrame _drawRect:]): Ditto.
1685         (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
1686         (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
1687         (-[WebFrame _copyRenderNode:copier:]): Ditto.
1688         (-[WebFrame _copyRenderTree:]): Ditto.
1689         (inputElementFromDOMElement): Ditto.
1690         (formElementFromDOMElement): Ditto.
1691         (-[WebFrame _elementWithName:inForm:]): Ditto.
1692         (-[WebFrame _elementDoesAutoComplete:]): Ditto.
1693         (-[WebFrame _elementIsPassword:]): Ditto.
1694         (-[WebFrame _formForElement:]): Ditto.
1695         (-[WebFrame _currentForm]): Ditto.
1696         (-[WebFrame _controlsInForm:]): Ditto.
1697         (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
1698         (-[WebFrame _matchLabels:againstElement:]): Ditto.
1699         (-[WebFrame _URLWithAttributeString:]): Ditto.
1700         (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1701         (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
1702         (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
1703         (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
1704         (-[WebFrame _unmarkAllTextMatches]): Ditto.
1705         (-[WebFrame _rectsForTextMatches]): Ditto.
1706         (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
1707         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
1708         (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1709         (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
1710         (-[WebFrame _firstRectForDOMRange:]): Ditto.
1711         (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
1712         (-[WebFrame _baseURL]): Ditto.
1713         (-[WebFrame _stringWithData:]): Ditto.
1714         (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
1715         (-[WebFrame _needsLayout]): Ditto.
1716         (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
1717         (-[WebFrame _accessibilityTree]): Ditto.
1718         (-[WebFrame _setBaseBackgroundColor:]): Ditto.
1719         (-[WebFrame _setDrawsBackground:]): Ditto.
1720         (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
1721         Ditto.
1722         (-[WebFrame _selectionGranularity]): Ditto.
1723         (-[WebFrame _convertToNSRange:]): Ditto.
1724         (-[WebFrame _convertToDOMRange:]): Ditto.
1725         (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
1726         (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
1727         (-[WebFrame _markDOMRange]): Ditto.
1728         (-[WebFrame _markedTextNSRange]): Ditto.
1729         (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
1730         (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1731         (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
1732         (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
1733         (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
1734         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
1735         (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
1736         (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
1737         (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
1738         (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
1739         (-[WebFrame _visiblePositionForPoint:]): Ditto.
1740         (-[WebFrame _characterRangeAtPoint:]): Ditto.
1741         (-[WebFrame _typingStyle]): Ditto.
1742         (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
1743         (-[WebFrame _fontForSelection:]): Ditto.
1744         (-[WebFrame _dragSourceMovedTo:]): Ditto.
1745         (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
1746         (-[WebFrame _getData:andResponse:forURL:]): Ditto.
1747         (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
1748         (-[WebFrame _canProvideDocumentSource]): Ditto.
1749         (-[WebFrame _canSaveAsWebArchive]): Ditto.
1750         (-[WebFrame _receivedData:textEncodingName:]): Ditto.
1751         (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
1752         function. Couldn't just keep the bridge method because this was already here with the same name.
1753         (-[WebFrame _selectedNSRange]): Ditto.
1754         (-[WebFrame _selectNSRange:]): Ditto.
1755         (-[WebFrame dealloc]): Remove bridge-related code.
1756         (-[WebFrame finalize]): Ditto.
1757
1758         * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
1759         Removed the bridge parameter from the init method. Removed the #if blocks that
1760         tried to make this header work in non-C++ ObjC files -- they were broken and unused.
1761         Removed the _bridge method.
1762
1763         * WebView/WebFrameView.mm: Removed the _bridge method.
1764
1765         * WebView/WebHTMLRepresentation.mm:
1766         (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
1767         field.
1768         (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
1769         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
1770         (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
1771         (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
1772         (-[WebHTMLRepresentation documentSource]): Ditto.
1773         (-[WebHTMLRepresentation DOMDocument]): Ditto.
1774         (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
1775         (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
1776         (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
1777         (-[WebHTMLRepresentation formForElement:]): Ditto.
1778         (-[WebHTMLRepresentation currentForm]): Ditto.
1779         (-[WebHTMLRepresentation controlsInForm:]): Ditto.
1780         (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
1781         (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
1782
1783         * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
1784
1785         * WebView/WebHTMLView.mm:
1786         (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
1787         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1788         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1789         (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
1790         (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
1791         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
1792         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
1793         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
1794         (-[WebHTMLView drawSingleRect:]): Ditto.
1795         (-[WebHTMLView draggedImage:movedTo:]): Ditto.
1796         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1797         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
1798         (-[WebHTMLView knowsPageRange:]): Ditto.
1799         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1800         (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
1801         (-[WebHTMLView accessibilityHitTest:]): Ditto.
1802         (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
1803         (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
1804         (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
1805         (-[WebHTMLView _changeSpellingToWord:]): Ditto.
1806         (-[WebHTMLView startSpeaking:]): Ditto.
1807         (-[WebHTMLView _updateFontPanel]): Ditto.
1808         (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
1809         (-[WebHTMLView _layoutIfNeeded]): Ditto.
1810         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1811         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1812         (-[WebHTMLView selectedRange]): Ditto.
1813         (-[WebHTMLView markedRange]): Ditto.
1814         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1815         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1816         (-[WebHTMLView insertText:]): Ditto.
1817         (-[WebTextCompleteController _insertMatch:]): Ditto.
1818         (-[WebTextCompleteController doCompletion]): Ditto.
1819         (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
1820         (-[WebHTMLView string]): Ditto.
1821         (-[WebHTMLView selectedString]): Ditto.
1822         (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
1823         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
1824         (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
1825         (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
1826         (-[WebHTMLView unmarkAllTextMatches]): Ditto.
1827         (-[WebHTMLView rectsForTextMatches]): Ditto.
1828         * WebView/WebRenderNode.mm:
1829         (-[WebRenderNode initWithWebFrameView:]): Ditto.
1830         * WebView/WebResource.mm:
1831         (-[WebResource _stringValue]): Ditto.
1832
1833         * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
1834
1835         * WebView/WebView.mm:
1836         (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
1837         (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
1838         (-[WebView _setInViewSourceMode:]): Ditto.
1839         (-[WebView _inViewSourceMode]): Ditto.
1840         (-[WebView _executeCoreCommandByName:value:]): Ditto.
1841         (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
1842         (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
1843         (-[WebView scrollDOMRangeToVisible:]): Ditto.
1844         (-[WebView setSelectedDOMRange:affinity:]): Ditto.
1845         (-[WebView setEditable:]): Ditto.
1846         (-[WebView setTypingStyle:]): Ditto.
1847         (-[WebView typingStyle]): Ditto.
1848         (-[WebView replaceSelectionWithNode:]): Ditto.
1849         (-[WebView replaceSelectionWithText:]): Ditto.
1850         (-[WebView replaceSelectionWithMarkupString:]): Ditto.
1851         (-[WebView replaceSelectionWithArchive:]): Ditto.
1852         (-[WebView _insertNewlineInQuotedContent]): Ditto.
1853         (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
1854
1855 2008-03-12  David Hyatt  <hyatt@apple.com>
1856
1857         Make the zoom factor a float and not a percent.
1858
1859         Reviewed by antti
1860
1861         * WebView/WebView.mm:
1862         (-[WebView _setZoomMultiplier:isTextOnly:]):
1863
1864 2008-03-11  David Hyatt  <hyatt@apple.com>
1865
1866         This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
1867         New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
1868         can zoom the page in, out or reset it to the standard size.
1869
1870         In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
1871         and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
1872         win.
1873
1874         Reviewed by Tim H.
1875
1876         * WebCoreSupport/WebFrameBridge.mm:
1877         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
1878         * WebView/WebDocumentInternal.h:
1879         * WebView/WebHTMLView.mm:
1880         (-[WebHTMLView viewDidMoveToSuperview]):
1881         * WebView/WebPDFView.h:
1882         * WebView/WebPDFView.mm:
1883         (-[WebPDFView _zoomOut:]):
1884         (-[WebPDFView _zoomIn:]):
1885         (-[WebPDFView _resetZoom:]):
1886         (-[WebPDFView _canZoomOut]):
1887         (-[WebPDFView _canZoomIn]):
1888         (-[WebPDFView _canResetZoom]):
1889         * WebView/WebView.mm:
1890         (-[WebViewPrivate init]):
1891         (-[WebView setTextSizeMultiplier:]):
1892         (-[WebView textSizeMultiplier]):
1893         (-[WebView _setZoomMultiplier:isTextOnly:]):
1894         (-[WebView _zoomMultiplier:]):
1895         (-[WebView _realZoomMultiplier]):
1896         (-[WebView _realZoomMultiplierIsTextOnly]):
1897         (-[WebView _canZoomOut:]):
1898         (-[WebView _canZoomIn:]):
1899         (-[WebView _zoomOut:isTextOnly:]):
1900         (-[WebView _zoomIn:isTextOnly:]):
1901         (-[WebView _canResetZoom:]):
1902         (-[WebView _resetZoom:isTextOnly:]):
1903         (-[WebView canMakeTextSmaller]):
1904         (-[WebView makeTextSmaller:]):
1905         (-[WebView canMakeTextLarger]):
1906         (-[WebView makeTextLarger:]):
1907         (-[WebView canMakeTextStandardSize]):
1908         (-[WebView makeTextStandardSize:]):
1909         (-[WebView setPageSizeMultiplier:]):
1910         (-[WebView pageSizeMultiplier]):
1911         (-[WebView canZoomPageIn]):
1912         (-[WebView zoomPageIn:]):
1913         (-[WebView canZoomPageOut]):
1914         (-[WebView zoomPageOut:]):
1915         (-[WebView canResetPageZoom]):
1916         (-[WebView resetPageZoom:]):
1917         (-[WebView _searchWithSpotlightFromMenu:]):
1918         * WebView/WebViewInternal.h:
1919         * WebView/WebViewPrivate.h:
1920
1921 2008-03-12  Dan Bernstein  <mitz@apple.com>
1922
1923         Reviewed by Darin Adler and Sam Weinig.
1924
1925         - <rdar://problem/4433248> use CoreText API instead of SPI on Leopard
1926
1927         * WebCoreSupport/WebSystemInterface.m:
1928         (InitWebCoreSystemInterface): Made WKGetCGFontFromNSFont and
1929         WKGetNSFontATSUFontId Tiger-only.
1930
1931 2008-03-12  Darin Adler  <darin@apple.com>
1932
1933         - fix http://bugs.webkit.org/show_bug.cgi?id=17794
1934           REGRESSION (r30980): 23 tests hanging on the Mac buildbot
1935
1936         * WebView/WebFrame.mm:
1937         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added missing call to set
1938         up pointer from the bridge to the frame. (My next check-in removes the bridge
1939         entirely, but we need this until then.)
1940
1941 2008-03-11  Darin Adler  <darin@apple.com>
1942
1943         Reviewed by Sam.
1944
1945         - remove all bridge-related things from WebCore except the bridge itself
1946
1947         * DOM/WebDOMOperations.mm:
1948         (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
1949
1950         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
1951
1952         * Plugins/WebPluginController.mm: Ditto.
1953
1954         * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
1955         init and close methods. Added a setWebFrame: method.
1956
1957         * WebCoreSupport/WebFrameBridge.mm:
1958         (-[WebFrameBridge setWebFrame:]): Added.
1959
1960         * WebCoreSupport/WebFrameLoaderClient.mm:
1961         (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
1962         (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
1963         bridge here. Soon we will be able to remove this entirely!
1964         (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
1965         into WebFrame from the bridge.
1966
1967         * WebView/WebFrame.mm:
1968         (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
1969         now owned by the frame.
1970         (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
1971         debugger under GC without this!
1972         (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
1973         use WebFrameLoaderClient instead of the bridge.
1974         (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
1975         This is code that used to live in the bridge's init function.
1976         (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
1977         (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
1978         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
1979         the WebView is now the bridge's owner.
1980         (-[WebFrame _updateBackground]): Changed this one call site that was calling the
1981         WebCore::Frame::bridge function directly to use the kit function instead.
1982         (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
1983         This code won't last long -- we're eliminating the bridge soon.
1984         (-[WebFrame finalize]): Ditto.
1985
1986         * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
1987         for creating frames.
1988
1989         * WebView/WebView.mm:
1990         (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
1991         the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
1992         where we have to allocate a WebFrameBridge and then immediately release it.
1993
1994 2008-03-11  Darin Adler  <darin@apple.com>
1995
1996         Reviewed by Anders.
1997
1998         - remove code depending on the bridge to get from an NSView to a WebCore::Frame
1999
2000         * WebCoreSupport/WebFrameLoaderClient.mm:
2001         (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
2002         to setView. A couple lines later, there is a call to _install, which sets the
2003         view to the scroll view.
2004
2005         * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
2006
2007         * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
2008         this file, since it's used by Safari.
2009         * WebView/WebDynamicScrollBarsViewInternal.h: Added.
2010         * WebView/WebDynamicScrollBarsView.m:
2011         (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
2012         (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
2013         (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
2014         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
2015         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
2016         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
2017         (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
2018         (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
2019         (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
2020         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
2021         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
2022         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
2023         (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
2024         (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
2025         (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
2026
2027         * WebView/WebFrameView.mm:
2028         (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
2029
2030         * WebView/WebView.mm:
2031         (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
2032         (-[WebView alwaysShowVerticalScroller]): Ditto.
2033         (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
2034         (-[WebView alwaysShowHorizontalScroller]): Ditto.
2035
2036 2008-03-11  Darin Adler  <darin@apple.com>
2037
2038         Reviewed by Sam.
2039
2040         - eliminate the remaining parts of WebCoreBridge used for calls to WebKit from WebCore
2041
2042         * WebCoreSupport/WebChromeClient.h: Added new virtual functions that replace
2043         bridge methods.
2044         * WebCoreSupport/WebChromeClient.mm: Added lots of BEGIN_BLOCK_OBJC_EXCEPTIONS
2045         to recently-created functions.
2046         (WebChromeClient::firstResponder): Moved code here from the bridge.
2047         (WebChromeClient::makeFirstResponder): Ditto.
2048         (WebChromeClient::runOpenPanel): Ditto.
2049         (WebChromeClient::willPopUpMenu): Ditto.
2050
2051         * WebCoreSupport/WebFrameBridge.h: Removed almost everything. What's left
2052         is related to creating the bridge and connecting it to WebCore, which will
2053         go next when I eliminate use of the bridge to get to/from the Frame*.
2054         * WebCoreSupport/WebFrameBridge.mm:
2055         (-[WebFrameBridge close]): Moved the code to track the bridge count here
2056         instead of the dealloc and finalize methods.
2057
2058 2008-03-11  Darin Adler  <darin@apple.com>
2059
2060         Reviewed by Mitz.
2061
2062         - update code affected by Range changes
2063
2064         * Misc/WebNSAttributedStringExtras.mm:
2065         (+[NSAttributedString _web_attributedStringFromRange:]): Update for name changes.
2066         * WebView/WebHTMLRepresentation.mm:
2067         (-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
2068         Use Range::create.
2069         * WebView/WebHTMLView.mm:
2070         (-[WebHTMLView attributedString]): Ditto.
2071
2072 2008-03-10  Darin Adler  <darin@apple.com>
2073
2074         Reviewed by Sam.
2075
2076         - eliminate keyboard UI mode method from WebCoreFrameBridge
2077
2078         * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
2079         * WebCoreSupport/WebChromeClient.mm:
2080         (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
2081         * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
2082         fields for keyboard UI mode.
2083         * WebCoreSupport/WebFrameBridge.mm:
2084         (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
2085         method.
2086         (-[WebFrameBridge finalize]): Ditto.
2087         * WebView/WebView.mm: Moved the keyboard mode code in here.
2088         (-[WebView _close]): Remove observer from the distributed notification
2089         center as well as the normal one.
2090         (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
2091         here from the bridge.
2092         (-[WebView _keyboardUIMode]): Ditto.
2093         * WebView/WebViewInternal.h: Added _keyboardUIMode method.
2094
2095 2008-03-10  Darin Adler  <darin@apple.com>
2096
2097         Reviewed by Sam.
2098
2099         - eliminate Java applet methods from WebCoreFrameBridge
2100
2101         * WebCoreSupport/WebChromeClient.mm: Removed unneeded headers and declarations.
2102         * WebCoreSupport/WebFrameBridge.mm: Ditto. Also removed unneeded methods, including
2103         the ones that load Java applets.
2104         * WebCoreSupport/WebFrameLoaderClient.h: Added javaApplet function.
2105         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2106
2107 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
2108
2109         Reviewed by Darin.
2110
2111         Done with Lars.
2112
2113         Simplified WebViewFactory's refreshPlugins method to only refresh the
2114         plugins and not reload the frames anymore since that's now done in a
2115         platform independent manner by WebCore::Page.
2116
2117         Also removed the now unused pluginNameForMIMEType and
2118         pluginSupportsMIMEType methods.
2119
2120         * WebCoreSupport/WebViewFactory.mm:
2121         * WebView/WebFrame.mm:
2122         * WebView/WebFrameInternal.h:
2123         * WebView/WebView.mm:
2124
2125 2008-03-08  Mark Rowe  <mrowe@apple.com>
2126
2127         Reviewed by Darin Adler.
2128
2129         Fix 64-bit build with GCC 4.2.
2130
2131         * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Use NSUInteger in place of unsigned where required.
2132         * DefaultDelegates/WebDefaultUIDelegate.m: Ditto.
2133         * History/WebHistoryItem.mm: Ditto.
2134         * Misc/WebElementDictionary.mm: Ditto.
2135         * WebCoreSupport/WebFrameLoaderClient.mm:
2136         (WebFrameLoaderClient::objectContentType): Move variable declaration outside of if to avoid warning about the
2137         variable being unused in 64-bit.
2138         * WebCoreSupport/WebInspectorClient.mm: Use NSUInteger in place of unsigned where required.
2139         * WebView/WebHTMLView.mm:
2140         (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Use CGFloat in place of float where required.
2141         (-[WebTextCompleteController numberOfRowsInTableView:]): Use NSInteger in place of int where required.
2142
2143 2008-03-08  Darin Adler  <darin@apple.com>
2144
2145         Reviewed by Adele.
2146
2147         - eliminate custom highlight methods from WebCoreFrameBridge
2148
2149         * WebCoreSupport/WebChromeClient.h: Added custom highlight functions.
2150         * WebCoreSupport/WebChromeClient.mm:
2151         (WebChromeClient::customHighlightRect): Moved code here from bridge.
2152         (WebChromeClient::paintCustomHighlight): Ditto.
2153         * WebCoreSupport/WebFrameBridge.mm: Removed code here.
2154
2155 2008-03-07  David D. Kilzer  <ddkilzer@apple.com>
2156
2157         Unify concept of enabling Netscape Plug-in API (NPAPI).
2158
2159         Reviewed by Darin.
2160
2161         * WebKit.exp: Removed unused class export for WebBaseNetscapePluginView.
2162
2163         * WebKitPrefix.h: Removed WTF_USE_NPOBJECT since we now use
2164         ENABLE(NETSCAPE_PLUGIN_API) as defined in Platform.h.
2165
2166         * Plugins/WebBaseNetscapePluginStream.h: Replaced #ifndef __LP64__ with
2167         #if ENABLE(NETSCAPE_PLUGIN_API).
2168         * Plugins/WebBaseNetscapePluginStream.mm: Ditto.
2169         * Plugins/WebBaseNetscapePluginView.h: Ditto.
2170         * Plugins/WebBaseNetscapePluginView.mm: Ditto.
2171         * Plugins/WebBaseNetscapePluginViewInternal.h: Ditto.
2172         * Plugins/WebBaseNetscapePluginViewPrivate.h: Ditto.
2173         * Plugins/WebBasePluginPackage.h: Ditto.
2174         * Plugins/WebBasePluginPackage.m: Ditto.
2175         (+[WebBasePluginPackage pluginWithPath:]):
2176         * Plugins/WebNetscapeDeprecatedFunctions.c: Ditto.
2177         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
2178         * Plugins/WebNetscapePluginEmbeddedView.h: Ditto.
2179         * Plugins/WebNetscapePluginEmbeddedView.mm: Ditto.
2180         * Plugins/WebNetscapePluginPackage.h: Ditto.
2181         * Plugins/WebNetscapePluginPackage.m: Ditto.
2182         * Plugins/WebNetscapePluginStream.h: Ditto.
2183         * Plugins/WebNetscapePluginStream.mm: Ditto.
2184         * Plugins/WebPluginDatabase.m: Ditto.
2185         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
2186         * Plugins/npapi.m: Ditto.
2187         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
2188         (WebFrameLoaderClient::objectContentType):
2189         (WebFrameLoaderClient::createPlugin):
2190         * WebView/WebHTMLView.mm: Ditto.
2191         (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
2192         * WebView/WebHTMLViewInternal.h: Ditto.
2193
2194         * WebView/WebFrame.mm: Replaced #ifndef __LP64__ with
2195         #if ENABLE(NETSCAPE_PLUGIN_API). Moved methods below from (WebPrivate)
2196         category to (WebInternal) category so we don't expose the ENABLE() macro
2197         from the private header.
2198         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2199         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2200         * WebView/WebFrameInternal.h: Ditto.
2201         * WebView/WebFramePrivate.h: Ditto.
2202
2203 2008-03-07  Alexey Proskuryakov  <ap@webkit.org>
2204
2205         Reviewed by Darin.
2206
2207         <rdar://problem/5579292> REGRESSION: (safari 2-3): "Default default" encoding for Korean
2208         changed from Korean (Windows, DOS) to Korean (ISO 2022-KR), which breaks some sites
2209
2210         * WebView/WebPreferences.m:
2211         (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Make encoding name match
2212         the one used in Safari.
2213
2214 2008-03-07  Mark Rowe  <mrowe@apple.com>
2215
2216         Reviewed by Oliver Hunt.
2217
2218         Fix WebKit build with GCC 4.2.
2219
2220         * Plugins/WebBaseNetscapePluginView.mm: Use the correct return type in method signature.
2221
2222 2008-03-07  Darin Adler  <darin@apple.com>
2223
2224         Reviewed by Adam.
2225
2226         - eliminated WebCoreFrameBridge runOpenPanel
2227
2228         * WebCoreSupport/WebChromeClient.h: Added runOpenPanel.
2229         * WebCoreSupport/WebChromeClient.mm:
2230         (WebChromeClient::runOpenPanel): Added.
2231         (-[WebOpenPanelResultListener initWithChooser:]): Added. Used to wrap the
2232         FileChooser so it can get a result from the UI delegate.
2233         (-[WebOpenPanelResultListener dealloc]): Added.
2234         (-[WebOpenPanelResultListener finalize]): Added.
2235         (-[WebOpenPanelResultListener cancel]): Added.
2236         (-[WebOpenPanelResultListener chooseFilename:]): Added.
2237
2238 2008-03-06  Darin Adler  <darin@apple.com>
2239
2240         Reviewed by Mitz.
2241
2242         - fix regression test failures from the visited-link change
2243
2244         * History/WebHistory.mm:
2245         (+[WebHistory setOptionalSharedHistory:]): Call PageGroup::setShouldTrackVisitedLinks
2246         to turn off visited links if there is no history object. Also call
2247         removeAllVisitedLinks so we can start over from scratch with the new history.
2248
2249 2008-03-06  Dan Bernstein  <mitz@apple.com>
2250
2251         Reviewed by Darin Adler.
2252
2253         - fix a regression from r30741: a crash under
2254           WebFrameLoaderClient::createPlugin() when showing a Mail message with
2255           an attachment
2256
2257         * WebCoreSupport/WebFrameLoaderClient.mm:
2258         (WebFrameLoaderClient::createPlugin):
2259
2260 2008-03-06  Darin Adler  <darin@apple.com>
2261
2262         - fix Tiger build
2263
2264         * History/WebHistory.mm: Added include of WebTypesInternal.h.
2265
2266 2008-03-06  Darin Adler  <darin@apple.com>
2267
2268         - fix Release build
2269
2270         * History/WebHistory.mm:
2271         (-[WebHistoryPrivate setLastVisitedTimeInterval:forItem:]): Removed underscore.
2272         (-[WebHistoryPrivate loadFromURL:collectDiscardedItemsInto:error:]): Added #if.
2273         (-[WebHistoryPrivate saveToURL:error:]): Ditto.
2274
2275 2008-03-06  Darin Adler  <darin@apple.com>
2276
2277         Reviewed by Mitz.
2278
2279         - fix http://bugs.webkit.org/show_bug.cgi?id=17526
2280           REGRESSION: iframes are added to Safari's History menu
2281           by separating the visited link machinery from global history
2282
2283         * History/WebHistory.mm: Moved WebHistoryPrivate inside this file.
2284         (-[WebHistoryPrivate removeItemFromDateCaches:]): Removed the underscore from this
2285         method name, since it's on a private object.
2286         (-[WebHistoryPrivate removeItemForURLString:]): Added a call to the
2287         PageGroup::removeAllVisitedLinks function if the last URL was removed.
2288         (-[WebHistoryPrivate addItemToDateCaches:]): Removed the underscore from this
2289         method name, since it's on a private object.
2290         (-[WebHistoryPrivate removeAllItems]): Call PageGroup::removeAllVisitedLinks.
2291         (-[WebHistoryPrivate ageLimitDate]): Removed the underscore from this
2292         method name, since it's on a private object.
2293         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2294         Ditto.
2295         (-[WebHistoryPrivate saveHistoryGuts:URL:error:]): Ditto. Also changed this
2296         to correctly return the error by using the newer version of writeToURL: and
2297         removed the FIXME about that.
2298         (-[WebHistoryPrivate addVisitedLinksToPageGroup:]): Added. Calls addVisitedLink
2299         for every link in the history.
2300         (-[WebHistory saveToURL:error:]): Removed the FIXME, since we do get the error now.
2301         (-[WebHistory addItem:]): Moved into the WebPrivate category.
2302         (-[WebHistory addItemForURL:]): Ditto.
2303         (-[WebHistory _addItemForURL:title:]): Added. Used for the normal case where we
2304         create an item and already know its title.
2305         (-[WebHistory ageLimitDate]): Moved into the WebPrivate category.
2306         (-[WebHistory containsItemForURLString:]): Ditto.
2307         (-[WebHistory removeItem:]): Ditto.
2308         (-[WebHistory setLastVisitedTimeInterval:forItem:]): Ditto.
2309         (-[WebHistory _itemForURLString:]): Ditto.
2310         (-[WebHistory _addVisitedLinksToPageGroup:]): Added. For use only inside WebKit.
2311
2312         * History/WebHistoryInternal.h: Added.
2313         * History/WebHistoryItemInternal.h: Tweaked formatting and includes.
2314         * History/WebHistoryPrivate.h: Moved the WebHistoryPrivate class out of this header.
2315         Also reorganized what was left behind.
2316
2317         * WebCoreSupport/WebChromeClient.h: Added populateVisitedLinks.
2318         * WebCoreSupport/WebChromeClient.mm:
2319         (WebChromeClient::populateVisitedLinks): Added a call to the new
2320         -[WebHistory _addVisitedLinksToPageGroup:] method.
2321
2322         * WebCoreSupport/WebFrameLoaderClient.mm:
2323         (WebFrameLoaderClient::updateGlobalHistory): Changed code to use the new
2324         -[WebHistory _addItemForURL:title:] method.
2325
2326 2008-03-05  Adam Roben  <aroben@apple.com>
2327
2328         Rename WebCoreScriptDebuggerImp.{h,mm} to WebScriptDebugger.{h,mm}
2329
2330         Reviewed by Kevin M.
2331
2332         * WebView/WebFrame.mm:
2333         * WebView/WebScriptDebugDelegate.mm:
2334         * WebView/WebScriptDebugger.h: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.h.
2335         * WebView/WebScriptDebugger.mm: Renamed from WebKit/mac/WebView/WebCoreScriptDebuggerImp.mm.
2336
2337 2008-03-05  Adam Roben  <aroben@apple.com>
2338
2339         Rename WebCoreScriptDebuggerImp to WebScriptDebugger
2340
2341         Reviewed by Kevin M.
2342
2343         * WebView/WebCoreScriptDebuggerImp.h:
2344         * WebView/WebCoreScriptDebuggerImp.mm:
2345         * WebView/WebFrame.mm:
2346         (-[WebFrame _attachScriptDebugger]):
2347         * WebView/WebFrameInternal.h:
2348
2349 2008-03-05  Adam Roben  <aroben@apple.com>
2350
2351         Remove WebScriptDebugger
2352
2353         Uses of WebScriptDebugger have been replaced with
2354         WebCoreScriptDebuggerImp.
2355
2356         Reviewed by Kevin M.
2357
2358         * WebView/WebFrame.mm:
2359         (-[WebFramePrivate dealloc]): Use delete instead of release since
2360         WebCoreScriptDebuggerImp is a C++ class.
2361         (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
2362         WebCoreScriptDebuggerImp.
2363         (-[WebFrame _detachScriptDebugger]): Ditto.
2364         * WebView/WebFrameInternal.h:
2365         * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
2366         * WebView/WebScriptDebugDelegatePrivate.h: Removed.
2367         * WebView/WebView.mm:
2368
2369 2008-03-05  Adam Roben  <aroben@apple.com>
2370
2371         Remove -webFrame and -globalObject from WebScriptDebugger
2372
2373         WebCoreScriptDebuggerImp is now unaware of WebScriptDebugger
2374
2375         Reviewed by Kevin M.
2376
2377         * WebView/WebCoreScriptDebuggerImp.h: Removed WebScriptDebugger*
2378         parameter to the constructor.
2379         * WebView/WebCoreScriptDebuggerImp.mm:
2380         (toWebFrame): Added.
2381         (WebCoreScriptDebuggerImp::sourceParsed): Call toWebFrame.
2382         (WebCoreScriptDebuggerImp::callEvent): Ditto, and get the Frame's
2383         WindowScriptObject ourselves instead of asking WebScriptDebugger for
2384         it.
2385         (WebCoreScriptDebuggerImp::atStatement): Call toWebFrame.
2386         (WebCoreScriptDebuggerImp::returnEvent): Ditto.
2387         (WebCoreScriptDebuggerImp::exception): Ditto.
2388         * WebView/WebScriptDebugDelegate.mm:
2389         (-[WebScriptDebugger initWithWebFrame:]): Updated for change to
2390         WebScriptDebuggerImp's constructor.
2391         * WebView/WebScriptDebugDelegatePrivate.h: Removed
2392         -webFrame/-globalObject.
2393
2394 2008-03-05  Adam Roben  <aroben@apple.com>
2395
2396         Remove -enterFrame: and -leaveFrame from WebScriptDebugger
2397
2398         Reviewed by Kevin M.
2399
2400         * WebView/WebCoreScriptDebuggerImp.h: Changed to store m_topCallFrame
2401         in a RetainPtr, now that WebCoreScriptDebuggerImp is in charge of its
2402         lifetime.
2403         * WebView/WebCoreScriptDebuggerImp.mm:
2404           - Added declaration of -[WebScriptCallFrame
2405             _initWithGlobalObject:caller:state:].
2406           - Changed most uses of m_topCallFrame to m_topCallFrame.get()
2407         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Removed
2408         now-unnecessary initialization of m_topCallFrame.
2409         (WebCoreScriptDebuggerImp::callEvent): Replaced call to enterFrame:
2410         with its implementation. The one difference between this
2411         implementation and the old enterFrame: method is that we don't hand
2412         our reference to m_topCallFrame to _initWithGlobalObject: -- that
2413         method must now retain the passed-in WebScriptCallFrame manually.
2414         (WebCoreScriptDebuggerImp::atStatement):
2415         (WebCoreScriptDebuggerImp::returnEvent): Replaced call to leaveFrame
2416         with its implementation.
2417         (WebCoreScriptDebuggerImp::exception):
2418         * WebView/WebScriptDebugDelegate.mm: Removed declaration of
2419         -[WebScriptCallFrame _initWithGlobalObject:caller:state:].
2420         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Changed
2421         to retain the passed-in caller.
2422         * WebView/WebScriptDebugDelegatePrivate.h:
2423           - Removed _current ivar
2424           - Removed enterFrame:/leaveFrame declarations.
2425
2426 2008-03-05  Adam Roben  <aroben@apple.com>
2427
2428         Remove -parsedSource: from WebScriptDebugger
2429
2430         Reviewed by Kevin M.
2431
2432         * WebView/WebCoreScriptDebuggerImp.mm:
2433         (WebCoreScriptDebuggerImp::sourceParsed): Moved code here from
2434         -[WebScriptDebugger parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]
2435         * WebView/WebScriptDebugDelegate.mm: Removed -parsedSource:.
2436         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2437
2438 2008-03-05  Adam Roben  <aroben@apple.com>
2439
2440         Remove -enteredFrame:, -leavingFrame:, and -exceptionRaised: from WebScriptDebugger
2441
2442         Reviewed by Kevin M.
2443
2444         * WebView/WebCoreScriptDebuggerImp.mm:
2445         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp): Changed to call
2446         trhough to callEvent instead of duplicating its code here.
2447         (WebCoreScriptDebuggerImp::callEvent): Moved code from
2448         -[WebScriptDebugger enteredFrame:sourceId:line:] here.
2449         (WebCoreScriptDebuggerImp::returnEvent): Moved code from
2450         -[WebScriptDebugger leavingFrame:sourceId:line:] here.
2451         (WebCoreScriptDebuggerImp::exception): Moved code from
2452         -[WebScriptDebugger exceptionRaised:sourceId:line:] here.
2453         * WebView/WebScriptDebugDelegate.mm: Removed -enteredFrame:,
2454         -leavingFrame:, and -exceptionRaised:.
2455         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2456
2457 2008-03-05  Adam Roben  <aroben@apple.com>
2458
2459         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
2460
2461         Reviewed by Kevin M.
2462
2463         * WebView/WebCoreScriptDebuggerImp.mm:
2464         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
2465         -[WebScriptDebugger hitStatement:sourceId:line:].
2466         * WebView/WebScriptDebugDelegate.mm:
2467         (-[WebScriptDebugger webFrame]): Added.
2468         * WebView/WebScriptDebugDelegatePrivate.h:
2469
2470 2008-03-05  Adam Roben  <aroben@apple.com>
2471
2472         Remove WebCoreScriptDebugger
2473
2474         Reviewed by Kevin M.
2475
2476         * WebView/WebCoreScriptDebugger.h: Removed.
2477         * WebView/WebCoreScriptDebugger.mm: Removed.
2478         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
2479         with WebScriptDebugger.
2480         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
2481         delegate] with just m_debugger.
2482         (toNSString): Moved here from WebCoreScriptDebugger.mm.
2483         (toNSURL): Ditto.
2484         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2485         (WebCoreScriptDebuggerImp::sourceParsed):
2486         (WebCoreScriptDebuggerImp::callEvent):
2487         (WebCoreScriptDebuggerImp::atStatement):
2488         (WebCoreScriptDebuggerImp::returnEvent):
2489         (WebCoreScriptDebuggerImp::exception):
2490         * WebView/WebScriptDebugDelegate.mm:
2491         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
2492         WebCoreScriptDebuggerImp, so initialize it properly.
2493         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
2494         WebCoreScriptDebuggerImp.
2495
2496 2008-03-05  Adam Roben  <aroben@apple.com>
2497
2498         Move WebCoreScriptDebuggerImp to its own source files
2499
2500         Also changed WebCoreScriptDebuggerImp coding style to match our style
2501         guidelines.
2502
2503         Reviewed by Kevin M.
2504
2505         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
2506         function.
2507         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
2508         implementation.
2509         (toNSURL): Made no longer static.
2510         * WebView/WebCoreScriptDebuggerImp.h: Added.
2511         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
2512         WebCoreScriptDebugger.mm and cleaned up.
2513         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2514         (WebCoreScriptDebuggerImp::sourceParsed):
2515         (WebCoreScriptDebuggerImp::callEvent):
2516         (WebCoreScriptDebuggerImp::atStatement):
2517         (WebCoreScriptDebuggerImp::returnEvent):
2518         (WebCoreScriptDebuggerImp::exception):
2519
2520 2008-03-05  Adam Roben  <aroben@apple.com>
2521
2522         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
2523
2524         Reviewed by Kevin M.
2525
2526         * WebView/WebCoreScriptDebugger.h:
2527           - Removed newFrameWithGlobalObject:caller:state: from
2528             WebScriptDebugger protocol
2529           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
2530           - Removed _current ivar from WebCoreScriptDebugger
2531         * WebView/WebCoreScriptDebugger.mm:
2532         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
2533         the delegate.
2534         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
2535         * WebView/WebScriptDebugDelegate.mm:
2536         (-[WebScriptDebugger dealloc]): Added code to release _current.
2537         (-[WebScriptDebugger enterFrame:]): Added. Code came from
2538         WebCoreScriptDebugger.
2539         (-[WebScriptDebugger leaveFrame]): Ditto.
2540         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
2541
2542 2008-03-05  Adam Roben  <aroben@apple.com>
2543
2544         Remove WebCoreScriptCallFrame
2545
2546         Reviewed by Tim.
2547
2548         * WebView/WebCoreScriptDebugger.h:
2549           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2550           - Replaced -newWrapperForFrame: with
2551             -newFrameWithGlobalObject:caller:state:
2552           - Removed WebCoreScriptCallFrame interface.
2553         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
2554         with WebScriptCallFrame.
2555         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
2556         -newFrameWithGlobalObject:caller:state.
2557         (-[WebCoreScriptDebugger _leaveFrame]):
2558         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
2559         _private ivar to be of type WebScriptCallFramePrivate*.
2560         * WebView/WebScriptDebugDelegate.mm:
2561           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
2562           - Added WebScriptCallFramePrivate
2563         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
2564         (-[WebScriptDebugger hitStatement:sourceId:line:]):
2565         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
2566         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
2567         (-[WebScriptCallFramePrivate dealloc]): Added.
2568         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
2569         Code came from WebCoreScriptCallFrame.
2570         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
2571         ivar.
2572         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
2573         _private with direct access of _private's ivars.
2574         (-[WebScriptCallFrame caller]): Ditto.
2575         (-[WebScriptCallFrame scopeChain]): Ditto.
2576         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2577
2578 2008-03-05  Adam Roben  <aroben@apple.com>
2579
2580         Move -_convertValueToObjcValue to WebScriptCallFrame
2581
2582         Reviewed by Darin.
2583
2584         * WebView/WebCoreScriptDebugger.h: Removed declaration of
2585         -_convertValueToObjcValue.
2586         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
2587         * WebView/WebScriptDebugDelegate.mm:
2588         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
2589         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
2590         (-[WebScriptCallFrame scopeChain]): Changed to call
2591         -_convertValueToObjcValue on self instead of _private.
2592         (-[WebScriptCallFrame exception]): Ditto.
2593         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
2594
2595 2008-03-05  Adam Roben  <aroben@apple.com>
2596
2597         Move -exception and -evaluateWebScript: to WebScriptCallFrame
2598
2599         Reviewed by Darin.
2600
2601         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
2602         and -evaluateWebScript:.
2603         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
2604         -evaluateWebScript:.
2605         * WebView/WebScriptDebugDelegate.mm:
2606         (-[WebScriptCallFrame exception]): Added. Code came from
2607         -[WebCoreScriptCallFrame exception].
2608         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
2609         -[WebCoreScriptCallFrame evaluateWebScript:].
2610
2611 2008-03-05  Adam Roben  <aroben@apple.com>
2612
2613         Move -scopeChain to WebScriptCallFrame
2614
2615         Reviewed by Darin.
2616
2617         * WebView/WebCoreScriptDebugger.h:
2618           - Added declarations of -globalObject and -_convertValueToObjcValue:
2619             to WebCoreScriptCallFrame
2620           - Removed declaration of -scopeChain.
2621         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
2622         within the main WebCoreScriptCallFrame implementation.
2623         (-[WebCoreScriptCallFrame globalObject]): Added.
2624         * WebView/WebScriptDebugDelegate.mm:
2625         (-[WebScriptCallFrame scopeChain]): Added. Code came from
2626         -[WebCoreScriptCallFrame scopeChain].
2627
2628 2008-03-05  Adam Roben  <aroben@apple.com>
2629
2630         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
2631
2632         Reviewed by Darin.
2633
2634         * WebView/WebCoreScriptDebugger.h:
2635           - Removed #else case of #ifdef __cplusplus since this file is only
2636             ever used by C++ Objective-C files
2637           - Removed 'using KJS::ExecState' statement since we prefer not to
2638             have using statements in header files
2639           - Consequently prefixed uses of ExecState with KJS::
2640           - Added declaration of toNSString method that takes a const
2641             UString&
2642           - Added declaration of -[WebCoreScriptCallFrame state]
2643           - Removed declaration of -[WebCoreScriptCallFrame functionName]
2644         * WebView/WebCoreScriptDebugger.mm:
2645         (toNSString): Made this no longer static.
2646         (-[WebCoreScriptCallFrame state]): Added.
2647         * WebView/WebScriptDebugDelegate.mm:
2648         (-[WebScriptCallFrame functionName]): Added. Code came from
2649         -[WebCoreScriptCallFrame functionName], though I changed some nested
2650         ifs into early returns.
2651
2652 2008-03-05  Adam Roben  <aroben@apple.com>
2653
2654         Move WebCoreScriptDebugger to WebKit
2655
2656         Reviewed by Darin.
2657
2658         * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
2659         * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
2660         (toNSString):
2661         (toNSURL):
2662         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
2663         (WebCoreScriptDebuggerImp::sourceParsed):
2664         (WebCoreScriptDebuggerImp::callEvent):
2665         (WebCoreScriptDebuggerImp::atStatement):
2666         (WebCoreScriptDebuggerImp::returnEvent):
2667         (WebCoreScriptDebuggerImp::exception):
2668         (+[WebCoreScriptDebugger initialize]):
2669         (-[WebCoreScriptDebugger initWithDelegate:]):
2670         (-[WebCoreScriptDebugger dealloc]):
2671         (-[WebCoreScriptDebugger finalize]):
2672         (-[WebCoreScriptDebugger delegate]):
2673         (-[WebCoreScriptDebugger _enterFrame:]):
2674         (-[WebCoreScriptDebugger _leaveFrame]):
2675         (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
2676         (-[WebCoreScriptCallFrame _setWrapper:]):
2677         (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
2678         (-[WebCoreScriptCallFrame dealloc]):
2679         (-[WebCoreScriptCallFrame wrapper]):
2680         (-[WebCoreScriptCallFrame caller]):
2681         (-[WebCoreScriptCallFrame scopeChain]):
2682         (-[WebCoreScriptCallFrame functionName]):
2683         (-[WebCoreScriptCallFrame exception]):
2684         (-[WebCoreScriptCallFrame evaluateWebScript:]):
2685         * WebView/WebScriptDebugDelegate.mm: Updated header path.
2686         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
2687
2688 2008-03-05  Anders Carlsson  <andersca@apple.com>
2689
2690         Reviewed by Geoff.
2691
2692         Include file changes.
2693
2694         * Plugins/WebBaseNetscapePluginView.mm:
2695         * Plugins/WebNetscapePluginPackage.m:
2696
2697 2008-03-04  Timothy Hatcher  <timothy@apple.com>
2698
2699         Reviewed by Darin Adler.
2700
2701         <rdar://problem/5720160> Browser windows "do nothing" while modal
2702         dialog or menu is up due to run loop modes (or while scrolling)
2703
2704         Add new API that lets a WebView be scheduled with multiple runloops and modes.
2705         This lets loading continue when in a nested runloop or in a different mode.
2706
2707         * Misc/WebKitVersionChecks.h: Add a new version define:
2708         WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
2709         * WebView/WebView.mm:
2710         (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
2711         the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
2712         (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
2713         (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
2714         * WebView/WebViewPrivate.h: Add the new pending API methods.
2715
2716 2008-03-04  Anders Carlsson  <andersca@apple.com>
2717
2718         Reviewed by Darin.
2719
2720         Fix crash that happens when trying to load a page with a Java applet.
2721
2722         * WebCoreSupport/WebFrameLoaderClient.mm:
2723         Don't release the names and values array - the kit method returns an autoreleased array.
2724
2725 2008-03-04  Darin Adler  <darin@apple.com>
2726
2727         Reviewed by Adam.
2728
2729         - fix 200+ failing regression tests
2730         - fix http://bugs.webkit.org/show_bug.cgi?id=17668
2731           Vertical scrollbar at slashdot.org is randomly not shown
2732
2733         * WebCoreSupport/WebFrameLoaderClient.mm:
2734         (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
2735         code here to exactly match the way it was before it was moved from WebCore. I had
2736         introduced a storage leak and that was causing problems with scroll bars!
2737
2738 2008-03-04  Darin Adler  <darin@apple.com>
2739
2740         Reviewed by Adam.
2741
2742         - remove WebCoreFrameBridge reapplyStyles method
2743
2744         * WebView/WebHTMLView.mm:
2745         (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
2746
2747 2008-03-04  Darin Adler  <darin@apple.com>
2748
2749         Reviewed by Adam.
2750
2751         - eliminate WebCoreFrameBridge createFrameViewWithNSView
2752
2753         * WebCoreSupport/WebFrameLoaderClient.mm:
2754         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2755         Moved code here from createFrameViewWithNSView.
2756
2757 2008-03-04  Darin Adler  <darin@apple.com>
2758
2759         Reviewed by Adam.
2760
2761         - removed WebCoreFrameBridge scrollOverflowInDirection
2762
2763         * WebView/WebFrameView.mm:
2764         (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
2765         EventHandler directly instead of using the bridge.
2766         (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
2767         of the ones from the bridge.
2768         (-[WebFrameView scrollToEndOfDocument:]): Ditto.
2769         (-[WebFrameView _pageVertically:]): Ditto.
2770         (-[WebFrameView _pageHorizontally:]): Ditto.
2771         (-[WebFrameView _scrollLineVertically:]): Ditto.
2772         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
2773
2774 2008-03-04  Darin Adler  <darin@apple.com>
2775
2776         Reviewed by Adam.
2777
2778         - remove WebCoreFrameBridge installInFrame: method
2779
2780         * WebCoreSupport/WebFrameLoaderClient.mm:
2781         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2782         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2783         * WebView/WebFrameView.mm:
2784         (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
2785         (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
2786         method isn't nested inside an if statement. Call
2787         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
2788         * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
2789         used in WebFrameLoaderClient.mm.
2790
2791 2008-03-04  Darin Adler  <darin@apple.com>
2792
2793         Reviewed by Adam.
2794
2795         - remove WebCoreFrameBridge window method
2796
2797         * WebCoreSupport/WebFrameBridge.mm: Removed window method.
2798
2799 2008-03-04  Darin Adler  <darin@apple.com>
2800
2801         Reviewed by Adam.
2802
2803         - move code from WebFrameBridge into WebFrameLoaderClient
2804
2805         * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
2806         to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
2807         removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
2808         redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
2809         * WebCoreSupport/WebFrameBridge.mm:
2810         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
2811         Changed to use WebCore::String.
2812         (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
2813         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
2814
2815         * WebCoreSupport/WebFrameLoaderClient.mm:
2816         (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
2817         and added a FIXME.
2818         (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
2819         (WebFrameLoaderClient::objectContentType): Ditto.
2820         (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
2821         (pluginView): Ditto.
2822         (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
2823
2824 2008-03-04  Darin Adler  <darin@apple.com>
2825
2826         Reviewed by Adam.
2827
2828         - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
2829
2830         * WebCoreSupport/WebChromeClient.h:
2831         * WebCoreSupport/WebChromeClient.mm:
2832         (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
2833         The WebCore side now calls this only when there's an actual change.
2834         * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
2835         * WebCoreSupport/WebFrameBridge.mm:
2836         (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
2837         Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
2838
2839 2008-03-04  Darin Adler  <darin@apple.com>
2840
2841         Reviewed by Adam.
2842
2843         - remove WebCoreFrameBridge issuePasteComand method
2844
2845         * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
2846         * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
2847
2848 2008-03-03  Darin Adler  <darin@apple.com>
2849
2850         Reviewed by Adam.
2851
2852         - some "cleanup" on the path to removing WebCoreFrameBridge
2853
2854         * Storage/WebDatabaseManager.mm: Tweak includes.
2855         * Storage/WebDatabaseTrackerClient.mm: Ditto.
2856         * Storage/WebSecurityOrigin.mm: Ditto.
2857         * Storage/WebSecurityOriginInternal.h: Ditto.
2858
2859         * WebView/WebFrame.mm:
2860         (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
2861         match WebCore::EditableLinkBehavior.
2862         * WebView/WebFrameInternal.h: Removed unused kit function.
2863
2864         * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
2865         * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
2866         * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
2867
2868         * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
2869
2870 2008-03-01  Mark Rowe  <mrowe@apple.com>
2871
2872         Reviewed by Tim Hatcher.
2873
2874         Update Xcode configuration to support building debug and release from the mysterious future.
2875
2876         * Configurations/DebugRelease.xcconfig:
2877
2878 2008-02-29  Mark Rowe  <mrowe@apple.com>
2879
2880         Reviewed by Anders Carlsson.
2881
2882         Replace use of WKPathFromFont with implementation in terms of public API.
2883
2884         * WebCoreSupport/WebSystemInterface.m:
2885         (InitWebCoreSystemInterface): Remove unused symbol.
2886
2887 2008-02-29  Mark Rowe  <mrowe@apple.com>
2888
2889         Reviewed by Oliver Hunt.
2890
2891         Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
2892
2893         * Misc/WebNSURLExtras.mm:
2894         (-[NSURL _webkit_canonicalize]):
2895         * WebKit.order:
2896
2897 2008-02-29  Mark Rowe  <mrowe@apple.com>
2898
2899         Reviewed by Oliver Hunt.
2900
2901         Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
2902
2903         * WebCoreSupport/WebSystemInterface.m:
2904         (InitWebCoreSystemInterface):
2905
2906 2008-02-29  Mark Rowe  <mrowe@apple.com>
2907
2908         Reviewed by Oliver Hunt.
2909
2910         Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
2911
2912         * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
2913         * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
2914         * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
2915         * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
2916         requires this class.
2917         * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
2918         of Safari that calls other obsolete methods.
2919         * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
2920         * WebView/WebHTMLView.mm:  Ditto.
2921         * WebView/WebPDFView.mm:  Ditto.
2922         * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
2923
2924 2008-02-29  Mark Rowe  <mrowe@apple.com>
2925
2926         Rubber-stamped by Eric Seidel.
2927
2928         Remove unneeded includes of WebKitSystemInterface.h.
2929
2930         * History/WebHistoryItem.mm:
2931         * Misc/WebNSViewExtras.m:
2932         * WebCoreSupport/WebFrameLoaderClient.mm:
2933         * WebView/WebDataSource.mm:
2934         * WebView/WebPDFView.mm:
2935
2936 2008-02-29  Mark Rowe  <mrowe@apple.com>
2937
2938         Reviewed by Oliver Hunt and Oliver Hunt.
2939
2940         <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
2941
2942         * WebCoreSupport/WebSystemInterface.m:
2943         (InitWebCoreSystemInterface):  Remove unused symbol.
2944         * WebKit.order:  Ditto.
2945
2946 2008-02-28  Mark Rowe  <mrowe@apple.com>
2947
2948         Reviewed by Dave Hyatt.
2949
2950         Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
2951
2952         * WebCoreSupport/WebSystemInterface.m:
2953         (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
2954
2955 2008-02-27  Brady Eidson  <beidson@apple.com>
2956
2957         Reviewed by Mark Rowe (code) and Darin (concept)
2958
2959         Much better fix for <rdar://problem/4930688> (see r19549)
2960         Original fix for <rdar://problem/3947312> (and 14 dupes)
2961
2962         Let me tell you a story:
2963         A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
2964         WebArchive code was intertwined with that code in bizarre and complex ways.
2965         During the months long loader re-factoring where we pushed much loader code down into WebCore,
2966         many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
2967         with a sole purpose.
2968
2969         One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
2970         to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the
2971         single entry point for almost all loading (network or web archives)
2972
2973         This method would check various headers and other fields on the NSURLRequest and NSURLResponse
2974         to make decisions about the load.  If the cache control fields were expired or other conditions
2975         in the headers were met, the load would be forced to go out to the network.
2976
2977         As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
2978         At some point, all that remained was the special cases for loading WebArchives.
2979
2980         Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
2981         to be WebArchive specific, further cementing the assumed design.
2982
2983         Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
2984         specific point in time.  Referring to the request to see if the resource should be reloaded seems
2985         nonsensical, as does referring to the response headers to see if the resource is "expired".  In the
2986         context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
2987         during the initial load!
2988
2989         After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
2990         cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
2991         that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
2992
2993         * WebCoreSupport/WebFrameLoaderClient.h:
2994         * WebCoreSupport/WebFrameLoaderClient.mm:
2995         (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
2996           inspect the request or response objects - We are loading from a WebArchive, and we should never
2997           make the decision to go out to the network when we actually have the resource available.
2998
2999         * WebCoreSupport/WebSystemInterface.m:
3000         (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit
3001
3002 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
3003
3004         Reviewed by Adam Roben.
3005
3006         Bug 14348: Messing up the inspector by dragging an URL into it
3007         http://bugs.webkit.org/show_bug.cgi?id=14348
3008         <rdar://problem/5283620> and <rdar://problem/5712808>
3009
3010         * WebCoreSupport/WebInspectorClient.mm:
3011         (-[WebInspectorWindowController init]): Remove duplicate preference setting.
3012         (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
3013
3014 2008-02-25  Darin Adler  <darin@apple.com>
3015
3016         Reviewed by Adam.
3017
3018         * WebView/WebArchiver.mm:
3019         (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
3020         * WebView/WebFrame.mm:
3021         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
3022         variable name URL to avoid clashing with the renamed KURL in the future. Also use
3023         blankURL.
3024         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
3025         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
3026         (-[WebFrame loadHTMLString:baseURL:]): Ditto.
3027         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
3028
3029 2008-02-24  Darin Adler  <darin@apple.com>
3030
3031         Reviewed by Sam.
3032
3033         - remove separate client calls for "standard" and "reload' history
3034
3035         * WebCoreSupport/WebFrameLoaderClient.h:
3036         * WebCoreSupport/WebFrameLoaderClient.mm:
3037         (WebFrameLoaderClient::updateGlobalHistory):
3038
3039 2008-02-23  Alexey Proskuryakov  <ap@webkit.org>
3040
3041         Reviewed by Darin.
3042
3043         Move basic threading support from WebCore to WTF.
3044
3045         * ForwardingHeaders/wtf/Threading.h: Added.
3046         * ForwardingHeaders/wtf/Locker.h: Added.
3047
3048 2008-02-23  David Kilzer  <ddkilzer@apple.com>
3049
3050         Please clarify licensing for some files
3051         <http://bugs.webkit.org/show_bug.cgi?id=14970>
3052
3053         Reviewed by Darin.
3054
3055         * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
3056         and added Apple BSD-style license.
3057         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
3058
3059 2008-02-22  John Sullivan  <sullivan@apple.com>
3060
3061         Reviewed by Adam Roben
3062
3063         Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
3064         pasteAsPlainText: has the same behavior.
3065
3066         * WebView/WebHTMLView.mm:
3067         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
3068         (-[WebHTMLView readSelectionFromPasteboard:]):
3069         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3070         (-[WebHTMLView pasteAsRichText:]):
3071         (-[WebHTMLView paste:]):
3072         * WebView/WebView.mm:
3073         * WebView/WebViewPrivate.h:
3074
3075 2008-02-21  Anders Carlsson  <andersca@apple.com>
3076
3077         Reviewed by Sam.
3078
3079         Use BackForwardList::create instead.
3080
3081         * History/WebBackForwardList.mm:
3082         (-[WebBackForwardList init]):
3083
3084 2008-02-21  John Sullivan  <sullivan@apple.com>
3085
3086         Reviewed by Jessica Kahn
3087
3088         support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
3089
3090         * WebView/WebHTMLView.mm:
3091         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
3092         added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
3093         (-[WebHTMLView readSelectionFromPasteboard:]):
3094         pass NO for new matchStyle parameter to match old behavior
3095         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3096         validate pasteAndMatchStyle the same way as pasteAsRichText
3097         (-[WebHTMLView pasteAndMatchStyle:]):
3098         just like pasteAsRichText but passes YES for matchStyle
3099         (-[WebHTMLView pasteAsRichText:]):
3100         pass NO for new matchStyle parameter to match old behavior
3101         (-[WebHTMLView paste:]):
3102         ditto
3103
3104         * WebView/WebView.mm:
3105         added macro(pasteAndMatchStyle)
3106
3107         * WebView/WebViewPrivate.h:
3108         added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
3109
3110 2008-02-20  Sam Weinig  <sam@webkit.org>
3111
3112         Reviewed by Darin and Geoff.
3113
3114         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
3115
3116         * WebView/WebView.mm:
3117         (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
3118         There are currently no site-specific quirks on Mac, but we will propagate the state
3119         to WebCore to avoid possible mistakes later.
3120
3121 2008-02-19  Anders Carlsson  <andersca@apple.com>
3122
3123         Reviewed by Darin.
3124
3125         Move back WebKit methods that were unused in WebCore.
3126
3127         * Misc/WebNSURLExtras.mm:
3128         (+[NSURL _web_URLWithData:]):
3129         (+[NSURL _web_URLWithData:relativeToURL:]):
3130         (-[NSURL _web_originalData]):
3131         (-[NSURL _web_originalDataAsString]):
3132         (-[NSURL _web_isEmpty]):
3133         (-[NSURL _webkit_canonicalize]):
3134         (-[NSURL _webkit_URLByRemovingComponent:]):
3135         (-[NSURL _webkit_URLByRemovingFragment]):
3136         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3137         (-[NSURL _webkit_isFileURL]):
3138         (-[NSString _webkit_isFileURL]):
3139         * WebCoreSupport/WebFrameLoaderClient.mm:
3140         (WebFrameLoaderClient::setTitle):
3141         * WebCoreSupport/WebSystemInterface.m:
3142         (InitWebCoreSystemInterface):
3143
3144 2008-02-18  Darin Adler  <darin@apple.com>
3145
3146         Reviewed by Sam.
3147
3148         * Misc/WebNSAttributedStringExtras.mm:
3149         (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
3150         DeprecatedString.
3151
3152 2008-02-17  Sam Weinig  <sam@webkit.org>
3153
3154         Reviewed by Dan Bernstein.
3155
3156         Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
3157         document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
3158
3159         * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
3160         mistakenly not migrated.
3161
3162 2008-02-15  Dan Bernstein  <mitz@apple.com>
3163
3164         Reviewed by Alexey Proskuryakov.
3165
3166         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
3167           <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
3168
3169         * WebView/WebDataSource.mm:
3170         (+[WebDataSource _representationClassForMIMEType:]):
3171         (-[WebDataSource _responseMIMEType]):
3172         (-[WebDataSource subresources]):
3173         (-[WebDataSource subresourceForURL:]):
3174         * WebView/WebResource.mm:
3175         (-[WebResource _initWithData:URL:response:]):
3176         * WebView/WebResourcePrivate.h:
3177
3178 2008-02-15  Adam Roben  <aroben@apple.com>
3179
3180         Make WebKit's FEATURE_DEFINES match WebCore's
3181
3182         Reviewed by Mark.
3183
3184         * Configurations/WebKit.xcconfig:
3185
3186 2008-02-14  Darin Adler  <darin@apple.com>
3187
3188         Reviewed by Eric Seidel.
3189
3190         - updated for WebCore KURL changes
3191
3192         * History/WebHistoryItem.mm:
3193         (-[WebHistoryItem URL]): Removed getNSURL call.
3194         * Misc/WebElementDictionary.mm:
3195         (-[WebElementDictionary _absoluteImageURL]): Ditto.
3196         (-[WebElementDictionary _absoluteLinkURL]): Ditto.
3197         * Misc/WebNSAttributedStringExtras.mm:
3198         (fileWrapperForElement): Ditto.
3199         (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
3200         * Misc/WebNSURLExtras.mm:
3201         (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
3202         for function name change.
3203         * WebCoreSupport/WebContextMenuClient.mm:
3204         (WebContextMenuClient::downloadURL): Removed getNSURL call.
3205         * WebCoreSupport/WebDragClient.mm:
3206         (WebDragClient::createDragImageForLink): Ditto.
3207         * WebCoreSupport/WebFrameLoaderClient.mm:
3208         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
3209         (WebFrameLoaderClient::startDownload): Ditto.
3210         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
3211         (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
3212         (WebFrameLoaderClient::cancelledError): Ditto.
3213         (WebFrameLoaderClient::blockedError): Ditto.
3214         (WebFrameLoaderClient::cannotShowURLError): Ditto.
3215         (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
3216         (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
3217         (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
3218         (WebFrameLoaderClient::willUseArchive): Ditto.
3219         (WebFrameLoaderClient::setTitle): Ditto.
3220         (WebFrameLoaderClient::actionDictionary): Ditto.
3221         (WebFrameLoaderClient::createFrame): Ditto.
3222         (WebFrameLoaderClient::objectContentType): Ditto.
3223         (WebFrameLoaderClient::createPlugin): Ditto.
3224         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3225         * WebView/WebDataSource.mm:
3226         (-[WebDataSource _URL]): Ditto.
3227         (-[WebDataSource _initWithDocumentLoader:]): Ditto.
3228         (-[WebDataSource unreachableURL]): Ditto.
3229         * WebView/WebHTMLView.mm:
3230         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3231
3232 2008-02-14  Stephanie Lewis  <slewis@apple.com>
3233
3234         Reviewed by Geoff.
3235
3236         Update order files.
3237
3238         * WebKit.order:
3239
3240 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
3241
3242         Reviewed by Adam Roben.
3243
3244         http://bugs.webkit.org/show_bug.cgi?id=17207
3245         Database example doesn't work (requires not-yet-released Safari)
3246
3247         * WebCoreSupport/WebChromeClient.mm:
3248         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
3249         if it's too old.
3250
3251 2008-02-11  Darin Adler  <darin@apple.com>
3252
3253         - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
3254           incorrectly due to visibility fix
3255
3256         Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
3257
3258         * Misc/WebKitVersionChecks.h: Removed the constant.
3259
3260         * WebView/WebView.mm:
3261         (-[WebView _needsXcodeVisibilityQuirk]): Removed.
3262         (-[WebView _preferencesChangedNotification:]): Removed call to
3263         setNeedsXcodeVisibilityQuirk.
3264
3265 2008-02-12  Anders Carlsson  <andersca@apple.com>
3266
3267         Reviewed by Mitz.
3268
3269         * WebCoreSupport/WebFrameBridge.mm:
3270         * WebCoreSupport/WebViewFactory.mm:
3271         (-[WebViewFactory imageTitleForFilename:size:]):
3272         Move implementation from WebFrameBridge to WebViewFactory.
3273
3274 2008-02-11  Darin Adler  <darin@apple.com>
3275
3276         Reviewed by Mitz.
3277
3278         - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
3279           incorrectly due to visibility fix
3280
3281         Added an Xcode-specific quirk.
3282
3283         * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
3284         part of the check.
3285
3286         * WebView/WebView.mm:
3287         (-[WebView _needsXcodeVisibilityQuirk]): Added.
3288         (-[WebView _preferencesChangedNotification:]): Added a call to
3289         setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
3290
3291 2008-02-10  Darin Adler  <darin@apple.com>
3292
3293         - fix http://bugs.webkit.org/show_bug.cgi?id=17274
3294           REGRESSION: User Agent string broken in r30119
3295
3296         * WebView/WebView.mm:
3297         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
3298         Fix wrong variable name. Doh!
3299
3300 2008-02-09  Darin Adler  <darin@apple.com>
3301
3302         Reviewed by Tim Hatcher.
3303
3304         - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
3305
3306         * WebView/WebView.mm:
3307         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
3308         garbage collector's Objective C++ support by not initializing a static to an object
3309         that needs to be marked when running under GC.
3310
3311 2008-02-05  Dan Bernstein  <mitz@apple.com>
3312
3313         Reviewed by Darin Adler.
3314
3315         - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
3316
3317         The key bindings are Command-Control-left arrow and
3318         Command-Control-right arrow. To match AppKit, the bindings are enabled
3319         only when certain user defaults are set.
3320
3321         * WebView/WebHTMLView.mm:
3322         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
3323         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
3324         Frame::baseWritingDirectionForSelectionStart() and
3325         Editor::setBaseWritingDirection() directly.
3326         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
3327         (writingDirectionKeyBindingsEnabled): Added.
3328         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
3329         method.
3330         (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
3331         (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
3332         * WebView/WebView.mm:
3333
3334 2008-02-05  Mark Rowe  <mrowe@apple.com>
3335
3336         Unreviewed build fix.
3337
3338         * WebView/WebView.mm: Add missing #import.
3339
3340 2008-02-05  Mark Rowe  <mrowe@apple.com>
3341
3342         Reviewed by Oliver Hunt.
3343
3344         Update versioning to support the mysterious future.
3345
3346         * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
3347
3348 2008-01-30  Justin Garcia  <justin.garcia@apple.com>
3349
3350         Reviewed by Darin Adler.
3351
3352         <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
3353
3354         * WebView/WebHTMLView.mm:
3355         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
3356         this back, it's used by Mail.
3357         (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
3358         also used by Mail.  Moved to WebPrivate.
3359         * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
3360         accidently remove them in the future.
3361
3362 2008-01-30  Mark Rowe  <mrowe@apple.com>
3363
3364         Reviewed by Oliver Hunt.
3365
3366         Move off deprecated NSTableView methods.
3367
3368         * WebView/WebHTMLView.mm:
3369         (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
3370         (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
3371         (-[WebTextCompleteController filterKeyDown:]): Ditto.
3372
3373 2008-01-26  Mark Rowe  <mrowe@apple.com>
3374
3375         Reviewed by Darin Adler.
3376
3377         Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
3378
3379         * Misc/WebNSDataExtras.m:
3380         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
3381         to the new CFString so that they will be freed when no longer needed.
3382
3383 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
3384
3385         <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
3386
3387         Reviewed by Darin.
3388
3389         * WebCoreSupport/WebDashboardRegion.h: Removed.
3390         * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
3391
3392 2008-01-21  Darin Adler  <darin@apple.com>
3393
3394         Reviewed by John Sullivan.
3395
3396         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
3397         - add a missing export of WebDatabaseExpectedSizeKey
3398         - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
3399
3400         * Storage/WebDatabaseManager.mm:
3401         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
3402         name instead of calling isValid().
3403         (-[WebDatabaseManager deleteOrigin:]): Implemented.
3404         (WebKitInitializeDatabasesIfNecessary): Updated for name change.
3405
3406         * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
3407
3408         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
3409         * WebCoreSupport/WebChromeClient.mm:
3410         (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
3411         we had before with a single one.
3412
3413         * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
3414
3415         * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
3416         * WebView/WebPreferences.m:
3417         (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
3418         * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
3419         setDefaultDatabaseQuota:.
3420
3421         * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
3422         methods we had before with a single one.
3423
3424         * WebView/WebView.mm:
3425         (-[WebView _preferencesChangedNotification:]): Removed the code to set the
3426         default database origin quota in WebCore::Settings based on WebPreferences.
3427
3428         * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
3429         types of parameters that the database UI delegate methods had before.
3430
3431 2008-01-20  Mark Rowe  <mrowe@apple.com>
3432
3433         Reviewed by Dan Bernstein.
3434
3435         Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
3436         interested in supporting Safari 2 with TOT WebKit.
3437
3438         * WebView/WebView.mm:
3439         (+[WebView initialize]):
3440
3441 2008-01-17  Timothy Hatcher  <timothy@apple.com>
3442
3443         Reviewed by Adam Roben.
3444
3445         <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
3446         and inactive text selection after loading a page
3447         Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
3448
3449         The problem was other frames were changing the FocusController's active
3450         status to false after the first responder frame set it to true. The last
3451         frame to call _updateActiveState would win.
3452
3453         * WebView/WebHTMLView.mm:
3454         (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
3455         if the first responder is the current WebHTMLView or the WebFrameView.
3456         (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
3457
3458 2008-01-18  Adam Roben  <aroben@apple.com>
3459
3460         Rename _updateActiveState to _updateFocusedAndActiveState
3461
3462         Also renamed any related methods/members similarly.
3463
3464         Reviewed by Adele.
3465
3466         * WebView/WebHTMLView.mm:
3467         (-[WebHTMLViewPrivate dealloc]):
3468         (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
3469         (-[WebHTMLView close]):
3470         (_updateFocusedAndActiveStateTimerCallback):
3471         (-[WebHTMLView viewWillMoveToWindow:]):
3472         (-[WebHTMLView viewDidMoveToWindow]):
3473         (-[WebHTMLView windowDidBecomeKey:]):
3474         (-[WebHTMLView windowDidResignKey:]):
3475         (-[WebHTMLView becomeFirstResponder]):
3476         (-[WebHTMLView resignFirstResponder]):
3477         * WebView/WebHTMLViewInternal.h:
3478         * WebView/WebHTMLViewPrivate.h:
3479
3480 2008-01-17  John Sullivan  <sullivan@apple.com>
3481
3482         Reviewed by Darin
3483
3484         - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
3485
3486         * WebView/WebFrameView.mm:
3487         (-[WebFrameView initWithCoder:]):
3488         override to bump the global WebFrameView count
3489
3490 2008-01-16  Adam Roben  <aroben@apple.com>
3491
3492         Updated for renames/removal of WebCore methods.
3493
3494         Reviewed by Darin.
3495
3496         * Plugins/WebPluginController.mm:
3497         (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
3498         ask isFocusedAndActive directly, instead of going through the frame
3499         bridge.
3500         * WebView/WebHTMLView.mm:
3501         (-[WebHTMLView _updateActiveState]): Updated for method renames.
3502
3503 2008-01-16  John Sullivan  <sullivan@apple.com>
3504
3505         Reviewed by Adam and Dan
3506
3507         - cleaned up some existing logging
3508
3509         * WebView/WebHTMLView.mm:
3510         (-[WebHTMLView setNeedsDisplay:]):
3511         add method name to log, use "YES" and "NO" instead of (int)flag
3512         (-[WebHTMLView setNeedsLayout:]):
3513         ditto
3514         (-[WebHTMLView setNeedsToApplyStyles:]):
3515         ditto
3516
3517 2008-01-15  Geoffrey Garen  <ggaren@apple.com>
3518
3519         Reviewed by Andre Boule.
3520
3521         Fixed <rdar://problem/5667627> [WebCache empty] implementation should
3522         not disable/enable the cache
3523
3524         Toggle the cache model instead -- toggling disable/enable just causes
3525         the cache to forget about resources, not reclaim their memory.
3526
3527         * Misc/WebCache.mm:
3528         (+[WebCache empty]):
3529         * WebView/WebView.mm:
3530         * WebView/WebViewInternal.h:
3531
3532 2008-01-15  Adele Peterson  <adele@apple.com>
3533
3534         Reviewed by Adam and Antti.
3535
3536         WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
3537
3538         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3539           Removed initialization for GetMediaControlBackgroundImageData.  Added initialization for DrawMediaSliderTrack.
3540
3541 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
3542
3543         Reviewed by John Sullivan.
3544
3545         Fixed some world leak reports:
3546         * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
3547         Interpreter after running cvs-base suite
3548
3549         * <rdar://problem/5669423> PLT complains about world leak if browser
3550         window is open when PLT starts
3551
3552         These were both bugs in the reporting mechanism, so I took the